Inspection of "Merge pull request #327 from robmachado/master" - nfephp-org/sped-esocial - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 0f22aa...14cb45 )

by Roberto

created 2021-07-16 17:47 UTC

Status

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -108,8 +108,8 @@
 block discarded – undo
 
     
         /**
-     * builder for version S.1.0.0
-     */
+         * builder for version S.1.0.0
+         */
     protected function toNodeS100()
     {
         throw new \Exception("TODO !!");

Please login to merge, or discard this patch.

src/Factories/Traits/TraitS1010.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -58,7 +58,7 @@  discard block
 block discarded – undo
         $this->dom->addChild(
             $ideRubrica,
             "fimValid",
-            ! empty($this->std->fimvalid) ? $this->std->fimvalid : null,
+            !empty($this->std->fimvalid) ? $this->std->fimvalid : null,
             false
         );
         //seleção do modo
@@ -118,13 +118,13 @@  discard block
 block discarded – undo
             $this->dom->addChild(
                 $dadosRubrica,
                 "observacao",
-                ! empty($this->std->dadosrubrica->observacao)
+                !empty($this->std->dadosrubrica->observacao)
                     ? $this->std->dadosrubrica->observacao
                     : null,
                 false
             );
 
-            if (! empty($this->std->dadosrubrica->ideprocessocp)) {
+            if (!empty($this->std->dadosrubrica->ideprocessocp)) {
                 foreach ($this->std->dadosrubrica->ideprocessocp as $cp) {
                     $ideProcessoCP = $this->dom->createElement("ideProcessoCP");
                     $this->dom->addChild(
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
                 }
             }
 
-            if (! empty($this->std->dadosrubrica->ideprocessoirrf)) {
+            if (!empty($this->std->dadosrubrica->ideprocessoirrf)) {
                 foreach ($this->std->dadosrubrica->ideprocessoirrf as $irrf) {
                     $ideProcessoIRRF = $this->dom->createElement("ideProcessoIRRF");
                     $this->dom->addChild(
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
                     $dadosRubrica->appendChild($ideProcessoIRRF);
                 }
             }
-            if (! empty($this->std->dadosrubrica->ideprocessofgts)) {
+            if (!empty($this->std->dadosrubrica->ideprocessofgts)) {
                 foreach ($this->std->dadosrubrica->ideprocessofgts as $fgts) {
                     $ideProcessoFGTS = $this->dom->createElement("ideProcessoFGTS");
                     $this->dom->addChild(
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
                     $dadosRubrica->appendChild($ideProcessoFGTS);
                 }
             }
-            if (! empty($this->std->dadosrubrica->ideprocessosind)) {
+            if (!empty($this->std->dadosrubrica->ideprocessosind)) {
                 foreach ($this->std->dadosrubrica->ideprocessosind as $sind) {
                     $ideProcessoSIND = $this->dom->createElement("ideProcessoSIND");
                     $this->dom->addChild(
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
             }
             $node->appendChild($dadosRubrica);
         }
-        if (! empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
+        if (!empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
             $newVal = $this->std->novavalidade;
             $novaValidade = $this->dom->createElement("novaValidade");
             $this->dom->addChild(
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
             $this->dom->addChild(
                 $novaValidade,
                 "fimValid",
-                ! empty($newVal->fimvalid) ? $newVal->fimvalid : null,
+                !empty($newVal->fimvalid) ? $newVal->fimvalid : null,
                 false
             );
             $node->appendChild($novaValidade);
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
         $this->dom->addChild(
             $ideRubrica,
             "fimValid",
-            ! empty($this->std->fimvalid) ? $this->std->fimvalid : null,
+            !empty($this->std->fimvalid) ? $this->std->fimvalid : null,
             false
         );
         //seleção do modo
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
             $this->dom->addChild(
                 $dadosRubrica,
                 "tetoRemun",
-                ! empty($this->std->dadosrubrica->tetoremun)
+                !empty($this->std->dadosrubrica->tetoremun)
                     ? $this->std->dadosrubrica->tetoremun
                     : null,
                 false
@@ -341,13 +341,13 @@  discard block
 block discarded – undo
             $this->dom->addChild(
                 $dadosRubrica,
                 "observacao",
-                ! empty($this->std->dadosrubrica->observacao)
+                !empty($this->std->dadosrubrica->observacao)
                     ? $this->std->dadosrubrica->observacao
                     : null,
                 false
             );
 
-            if (! empty($this->std->dadosrubrica->ideprocessocp)) {
+            if (!empty($this->std->dadosrubrica->ideprocessocp)) {
                 foreach ($this->std->dadosrubrica->ideprocessocp as $cp) {
                     $ideProcessoCP = $this->dom->createElement("ideProcessoCP");
                     $this->dom->addChild(
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
                 }
             }
 
-            if (! empty($this->std->dadosrubrica->ideprocessoirrf)) {
+            if (!empty($this->std->dadosrubrica->ideprocessoirrf)) {
                 foreach ($this->std->dadosrubrica->ideprocessoirrf as $irrf) {
                     $ideProcessoIRRF = $this->dom->createElement("ideProcessoIRRF");
                     $this->dom->addChild(
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
                     $dadosRubrica->appendChild($ideProcessoIRRF);
                 }
             }
-            if (! empty($this->std->dadosrubrica->ideprocessofgts)) {
+            if (!empty($this->std->dadosrubrica->ideprocessofgts)) {
                 foreach ($this->std->dadosrubrica->ideprocessofgts as $fgts) {
                     $ideProcessoFGTS = $this->dom->createElement("ideProcessoFGTS");
                     $this->dom->addChild(
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
                     $dadosRubrica->appendChild($ideProcessoFGTS);
                 }
             }
-            if (! empty($this->std->dadosrubrica->ideprocessosind)) {
+            if (!empty($this->std->dadosrubrica->ideprocessosind)) {
                 foreach ($this->std->dadosrubrica->ideprocessosind as $sind) {
                     $ideProcessoSIND = $this->dom->createElement("ideProcessoSIND");
                     $this->dom->addChild(
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
             }
             $node->appendChild($dadosRubrica);
         }
-        if (! empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
+        if (!empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
             $newVal = $this->std->novavalidade;
             $novaValidade = $this->dom->createElement("novaValidade");
             $this->dom->addChild(
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
             $this->dom->addChild(
                 $novaValidade,
                 "fimValid",
-                ! empty($newVal->fimvalid) ? $newVal->fimvalid : null,
+                !empty($newVal->fimvalid) ? $newVal->fimvalid : null,
                 false
             );
             $node->appendChild($novaValidade);

Please login to merge, or discard this patch.

		@@ -108,8 +108,8 @@
		block discarded – undo
108	108
109	109
110	110	/**
111		- * builder for version S.1.0.0
112		- */
	111	+ * builder for version S.1.0.0
	112	+ */
113	113	protected function toNodeS100()
114	114	{
115	115	throw new \Exception("TODO !!");

		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	$this->dom->addChild(
59	59	$ideRubrica,
60	60	"fimValid",
61		- ! empty($this->std->fimvalid) ? $this->std->fimvalid : null,
	61	+ !empty($this->std->fimvalid) ? $this->std->fimvalid : null,
62	62	false
63	63	);
64	64	//seleção do modo
		@@ -118,13 +118,13 @@ discard block
		block discarded – undo
118	118	$this->dom->addChild(
119	119	$dadosRubrica,
120	120	"observacao",
121		- ! empty($this->std->dadosrubrica->observacao)
	121	+ !empty($this->std->dadosrubrica->observacao)
122	122	? $this->std->dadosrubrica->observacao
123	123	: null,
124	124	false
125	125	);
126	126
127		- if (! empty($this->std->dadosrubrica->ideprocessocp)) {
	127	+ if (!empty($this->std->dadosrubrica->ideprocessocp)) {
128	128	foreach ($this->std->dadosrubrica->ideprocessocp as $cp) {
129	129	$ideProcessoCP = $this->dom->createElement("ideProcessoCP");
130	130	$this->dom->addChild(
		@@ -155,7 +155,7 @@ discard block
		block discarded – undo
155	155	}
156	156	}
157	157
158		- if (! empty($this->std->dadosrubrica->ideprocessoirrf)) {
	158	+ if (!empty($this->std->dadosrubrica->ideprocessoirrf)) {
159	159	foreach ($this->std->dadosrubrica->ideprocessoirrf as $irrf) {
160	160	$ideProcessoIRRF = $this->dom->createElement("ideProcessoIRRF");
161	161	$this->dom->addChild(
		@@ -173,7 +173,7 @@ discard block
		block discarded – undo
173	173	$dadosRubrica->appendChild($ideProcessoIRRF);
174	174	}
175	175	}
176		- if (! empty($this->std->dadosrubrica->ideprocessofgts)) {
	176	+ if (!empty($this->std->dadosrubrica->ideprocessofgts)) {
177	177	foreach ($this->std->dadosrubrica->ideprocessofgts as $fgts) {
178	178	$ideProcessoFGTS = $this->dom->createElement("ideProcessoFGTS");
179	179	$this->dom->addChild(
		@@ -185,7 +185,7 @@ discard block
		block discarded – undo
185	185	$dadosRubrica->appendChild($ideProcessoFGTS);
186	186	}
187	187	}
188		- if (! empty($this->std->dadosrubrica->ideprocessosind)) {
	188	+ if (!empty($this->std->dadosrubrica->ideprocessosind)) {
189	189	foreach ($this->std->dadosrubrica->ideprocessosind as $sind) {
190	190	$ideProcessoSIND = $this->dom->createElement("ideProcessoSIND");
191	191	$this->dom->addChild(
		@@ -199,7 +199,7 @@ discard block
		block discarded – undo
199	199	}
200	200	$node->appendChild($dadosRubrica);
201	201	}
202		- if (! empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
	202	+ if (!empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
203	203	$newVal = $this->std->novavalidade;
204	204	$novaValidade = $this->dom->createElement("novaValidade");
205	205	$this->dom->addChild(
		@@ -211,7 +211,7 @@ discard block
		block discarded – undo
211	211	$this->dom->addChild(
212	212	$novaValidade,
213	213	"fimValid",
214		- ! empty($newVal->fimvalid) ? $newVal->fimvalid : null,
	214	+ !empty($newVal->fimvalid) ? $newVal->fimvalid : null,
215	215	false
216	216	);
217	217	$node->appendChild($novaValidade);
		@@ -279,7 +279,7 @@ discard block
		block discarded – undo
279	279	$this->dom->addChild(
280	280	$ideRubrica,
281	281	"fimValid",
282		- ! empty($this->std->fimvalid) ? $this->std->fimvalid : null,
	282	+ !empty($this->std->fimvalid) ? $this->std->fimvalid : null,
283	283	false
284	284	);
285	285	//seleção do modo
		@@ -333,7 +333,7 @@ discard block
		block discarded – undo
333	333	$this->dom->addChild(
334	334	$dadosRubrica,
335	335	"tetoRemun",
336		- ! empty($this->std->dadosrubrica->tetoremun)
	336	+ !empty($this->std->dadosrubrica->tetoremun)
337	337	? $this->std->dadosrubrica->tetoremun
338	338	: null,
339	339	false
		@@ -341,13 +341,13 @@ discard block
		block discarded – undo
341	341	$this->dom->addChild(
342	342	$dadosRubrica,
343	343	"observacao",
344		- ! empty($this->std->dadosrubrica->observacao)
	344	+ !empty($this->std->dadosrubrica->observacao)
345	345	? $this->std->dadosrubrica->observacao
346	346	: null,
347	347	false
348	348	);
349	349
350		- if (! empty($this->std->dadosrubrica->ideprocessocp)) {
	350	+ if (!empty($this->std->dadosrubrica->ideprocessocp)) {
351	351	foreach ($this->std->dadosrubrica->ideprocessocp as $cp) {
352	352	$ideProcessoCP = $this->dom->createElement("ideProcessoCP");
353	353	$this->dom->addChild(
		@@ -378,7 +378,7 @@ discard block
		block discarded – undo
378	378	}
379	379	}
380	380
381		- if (! empty($this->std->dadosrubrica->ideprocessoirrf)) {
	381	+ if (!empty($this->std->dadosrubrica->ideprocessoirrf)) {
382	382	foreach ($this->std->dadosrubrica->ideprocessoirrf as $irrf) {
383	383	$ideProcessoIRRF = $this->dom->createElement("ideProcessoIRRF");
384	384	$this->dom->addChild(
		@@ -396,7 +396,7 @@ discard block
		block discarded – undo
396	396	$dadosRubrica->appendChild($ideProcessoIRRF);
397	397	}
398	398	}
399		- if (! empty($this->std->dadosrubrica->ideprocessofgts)) {
	399	+ if (!empty($this->std->dadosrubrica->ideprocessofgts)) {
400	400	foreach ($this->std->dadosrubrica->ideprocessofgts as $fgts) {
401	401	$ideProcessoFGTS = $this->dom->createElement("ideProcessoFGTS");
402	402	$this->dom->addChild(
		@@ -408,7 +408,7 @@ discard block
		block discarded – undo
408	408	$dadosRubrica->appendChild($ideProcessoFGTS);
409	409	}
410	410	}
411		- if (! empty($this->std->dadosrubrica->ideprocessosind)) {
	411	+ if (!empty($this->std->dadosrubrica->ideprocessosind)) {
412	412	foreach ($this->std->dadosrubrica->ideprocessosind as $sind) {
413	413	$ideProcessoSIND = $this->dom->createElement("ideProcessoSIND");
414	414	$this->dom->addChild(
		@@ -422,7 +422,7 @@ discard block
		block discarded – undo
422	422	}
423	423	$node->appendChild($dadosRubrica);
424	424	}
425		- if (! empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
	425	+ if (!empty($this->std->novavalidade) && $this->std->modo == 'ALT') {
426	426	$newVal = $this->std->novavalidade;
427	427	$novaValidade = $this->dom->createElement("novaValidade");
428	428	$this->dom->addChild(
		@@ -434,7 +434,7 @@ discard block
		block discarded – undo
434	434	$this->dom->addChild(
435	435	$novaValidade,
436	436	"fimValid",
437		- ! empty($newVal->fimvalid) ? $newVal->fimvalid : null,
	437	+ !empty($newVal->fimvalid) ? $newVal->fimvalid : null,
438	438	false
439	439	);
440	440	$node->appendChild($novaValidade);

nfephp-org / sped-esocial

Push — master ( 0f22aa...14cb45 )

Status

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch