nfephp-org / sped-common

src/Certificate.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * Read PFX and return this class
      * @param string $content
      * @param string $password
-     * @return \static
+     * @return Certificate
      * @throws CertificateException
      */
     public static function readPfx($content, $password)

src/Certificate/CertificationChain.php

Doc Comments +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     
     /**
      * Add new certificate to certification chain
-     * @param string $contente Certificate in DER, CER or PEM format
+     * @param string $content Certificate in DER, CER or PEM format
      * @return array
      */
     public function add($content)

src/Certificate/PublicKey.php

Doc Comments +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
     /**
      * Load class with certificate content
      * @param string $content
-     * @return \static
+     * @return PublicKey
      */
     public static function createFromContent($content)
     {
@@ -108,7 +108,7 @@ 
      * @param string $data
      * @param string $signature
      * @param int $algorithm [optional] For more information see the list of Signature Algorithms.
-     * @return int Returns true if the signature is correct, false if it is incorrect
+     * @return boolean Returns true if the signature is correct, false if it is incorrect
      * @throws CertificateException An error has occurred when verify signature
      */
     public function verify($data, $signature, $algorithm = OPENSSL_ALGO_SHA1)

Spacing +1 added lines, -2 removed lines

@@ -93,8 +93,7 @@
         $detail = openssl_x509_parse($resource, false);
         $this->commonName = $detail['subject']['commonName'];
         $this->emailAddress = !empty($detail['subject']['emailAddress']) ?
-            $detail['subject']['emailAddress'] :
-            '';
+            $detail['subject']['emailAddress'] : '';
         $this->cspName = $detail['issuer']['organizationalUnitName'];
         $this->serialNumber = $detail['serialNumber'];
         $this->validFrom = \DateTime::createFromFormat('ymdHis\Z', $detail['validFrom']);

src/DOMImproved.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
     /**
      * Load xml from path
      * @param string $filename
-     * @return bool
+     * @return false|null
      */
     public function loadXMLFile($filename)
     {

Spacing +9 added lines, -9 removed lines

@@ -125,9 +125,9 @@ 
     public function getChave($nodeName = 'infNFe')
     {
         $node = $this->getElementsByTagName($nodeName)->item(0);
-        if (! empty($node)) {
+        if (!empty($node)) {
             $chaveId = $node->getAttribute("Id");
-            $chave =  preg_replace('/[^0-9]/', '', $chaveId);
+            $chave = preg_replace('/[^0-9]/', '', $chaveId);
             return $chave;
         }
         return '';
@@ -147,7 +147,7 @@ 
      * @return void
      */
     public function addChild(
-        DOMElement &$parent,
+        DOMElement & $parent,
         $name,
         $content = '',
         $obrigatorio = false,
@@ -174,7 +174,7 @@ 
      * @param string $msg
      * @return void
      */
-    public function appChild(DOMElement &$parent, DOMElement $child = null, $msg = '')
+    public function appChild(DOMElement & $parent, DOMElement $child = null, $msg = '')
     {
         if (empty($child)) {
             $this->erros[] = $msg;
@@ -188,7 +188,7 @@ 
      * @param DOMElement $parent
      * @param DOMElement $child
      */
-    public function appExternalChild(DOMElement &$parent, DOMElement $child)
+    public function appExternalChild(DOMElement & $parent, DOMElement $child)
     {
         $node = $this->importNode($child, true);
         $parent->appendChild($node);
@@ -203,7 +203,7 @@ 
      * @return void
      */
     public function appExternalChildBefore(
-        DOMElement &$parent,
+        DOMElement & $parent,
         DOMElement $child,
         $before
     ) {
@@ -225,7 +225,7 @@ 
      * @param string $msg
      * @return void
      */
-    public function appChildBefore(DOMElement &$parent, DOMElement $child = null, $before = '', $msg = '')
+    public function appChildBefore(DOMElement & $parent, DOMElement $child = null, $before = '', $msg = '')
     {
         if (empty($child) ||
             empty($before) ||
@@ -244,10 +244,10 @@ 
      * @param array $arr
      * @return int
      */
-    public function addArrayChild(DOMElement &$parent, $arr)
+    public function addArrayChild(DOMElement & $parent, $arr)
     {
         $num = 0;
-        if (! empty($arr) && ! empty($parent)) {
+        if (!empty($arr) && !empty($parent)) {
             foreach ($arr as $node) {
                 $this->appChild($parent, $node, '');
                 $num++;

src/Exception/ExceptionCollection.php

Doc Comments -1 removed lines

@@ -32,7 +32,6 @@
     
     /**
      * Add exceptions to the collection
-     * @param ExceptionCollection|\Exception $e Exception to add
      * @return ExceptionCollection;
      */
     public function add(\Exception $exception)

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
     
     public function __toString()
     {
-        $messages = array_map(function (\Exception $exception) {
+        $messages = array_map(function(\Exception $exception) {
             return $exception->getMessage();
         }, $this->exceptions);
         return implode(PHP_EOL, $messages);

src/Signer.php

Doc Comments +1 added lines, -4 removed lines

@@ -37,7 +37,7 @@ 
      * Make Signature tag
      * @param string $content
      * @param string $tagname
-     * @param string $marker for URI
+     * @param string $mark for URI
      * @param string $algorithm
      * @param array $canonical parameters to format node for signature
      * @param string $rootname name of tag to insert signature block
@@ -102,7 +102,6 @@ 
     
     /**
      * Verify if xml signature is valid
-     * @param string $content xml content
      * @param string $tagname tag for sign
      * @return boolean
      */
@@ -237,8 +236,6 @@ 
     /**
      * digestCheck
      * Verify digest value
-     * @param string $content
-     * @param string $tagid
      * @return boolean
      * @throws \NFePHP\Common\Exception\SignerException
      */

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 
 use NFePHP\Common\Certificate;
 use NFePHP\Common\Certificate\PublicKey;
-use NFePHP\Common\Strings;
 use RuntimeException;
 use DOMDocument;
 use DOMElement;

Spacing +8 added lines, -8 removed lines

@@ -31,7 +31,7 @@ 
 
 class Signer
 {
-    private static $canonical = [false,false,null,null];
+    private static $canonical = [false, false, null, null];
     
     /**
      * Make Signature tag
@@ -50,7 +50,7 @@ 
         $tagname = '',
         $mark = 'Id',
         $algorithm = OPENSSL_ALGO_SHA1,
-        $canonical = [false,false,null,null],
+        $canonical = [false, false, null, null],
         $rootname = ''
     ) {
         if (!empty($canonical)) {
@@ -70,7 +70,7 @@ 
                 'Tag not found ' . $tagname . ' ' . $rootname
             );
         }
-        if (! self::existsSignature($dom)) {
+        if (!self::existsSignature($dom)) {
             $dom = self::createSignature(
                 $certificate,
                 $dom,
@@ -136,7 +136,7 @@ 
         DOMElement $node,
         $mark,
         $algorithm = OPENSSL_ALGO_SHA1,
-        $canonical = [false,false,null,null]
+        $canonical = [false, false, null, null]
     ) {
         $nsDSIG = 'http://www.w3.org/2000/09/xmldsig#';
         $nsCannonMethod = 'http://www.w3.org/TR/2001/REC-xml-c14n-20010315';
@@ -148,7 +148,7 @@ 
             $nsSignatureMethod = 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha256';
             $nsDigestMethod = 'http://www.w3.org/2001/04/xmlenc#sha256';
         }
-        $nsTransformMethod1 ='http://www.w3.org/2000/09/xmldsig#enveloped-signature';
+        $nsTransformMethod1 = 'http://www.w3.org/2000/09/xmldsig#enveloped-signature';
         $nsTransformMethod2 = 'http://www.w3.org/TR/2001/REC-xml-c14n-20010315';
         $idSigned = trim($node->getAttribute($mark));
         $digestValue = self::makeDigest($node, $digestAlgorithm, $canonical);
@@ -250,10 +250,10 @@ 
         $root = $dom->documentElement;
         $node = $dom->getElementsByTagName($tagname)->item(0);
         if (empty($node)) {
-            throw new \RuntimeException('Tag not found ' .$tagname);
+            throw new \RuntimeException('Tag not found ' . $tagname);
         }
         $signature = $dom->getElementsByTagName('Signature')->item(0);
-        if (! empty($signature)) {
+        if (!empty($signature)) {
             $clone = $signature->cloneNode(true);
         } else {
             $signature = $dom->getElementsByTagName('Signature')->item(0);
@@ -288,7 +288,7 @@ 
      * @param array $canonical
      * @return string
      */
-    private static function makeDigest(DOMElement $node, $algorithm, $canonical = [false,false,null,null])
+    private static function makeDigest(DOMElement $node, $algorithm, $canonical = [false, false, null, null])
     {
         $dados = $node->C14N(true, false, null, null);
         //calcular o hash dos dados

src/Soap/SoapBase.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 
 use NFePHP\Common\Certificate;
 use NFePHP\Common\Soap\SoapInterface;
-use NFePHP\Common\Exception\SoapException;
 use NFePHP\Common\Exception\RuntimeException;
 use NFePHP\Common\Strings;
 use League\Flysystem\Filesystem;

Spacing +3 added lines, -3 removed lines

@@ -250,9 +250,9 @@
             );
         }
         $this->certsdir = $this->certificate->getCnpj() . '/certs/';
-        $this->prifile = $this->certsdir. Strings::randomString(10).'.pem';
-        $this->pubfile = $this->certsdir . Strings::randomString(10).'.pem';
-        $this->certfile = $this->certsdir . Strings::randomString(10).'.pem';
+        $this->prifile = $this->certsdir . Strings::randomString(10) . '.pem';
+        $this->pubfile = $this->certsdir . Strings::randomString(10) . '.pem';
+        $this->certfile = $this->certsdir . Strings::randomString(10) . '.pem';
         $ret = true;
         $ret &= $this->filesystem->put(
             $this->prifile,

Doc Comments +3 added lines, -1 removed lines

@@ -197,7 +197,7 @@ 
     /**
      * Set security protocol
      * @param int $protocol
-     * @return type Description
+     * @return integer Description
      */
     public function protocol($protocol = self::SSL_DEFAULT)
     {
@@ -248,6 +248,7 @@ 
      * @param string $operation
      * @param array $namespaces
      * @param \SOAPHeader $header
+     * @param integer $soapver
      * @return string
      */
     protected function makeEnvelopeSoap(
@@ -316,6 +317,7 @@ 
     
     /**
      * Delete all files in folder
+     * @param string $folder
      */
     public function removeTemporarilyFiles($folder)
     {

src/Soap/SoapFake.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
  */
 use NFePHP\Common\Soap\SoapBase;
 use NFePHP\Common\Soap\SoapInterface;
-use NFePHP\Common\Exception\SoapException;
 use NFePHP\Common\Certificate;
 use Psr\Log\LoggerInterface;
 

src/Validator.php

Spacing +2 added lines, -2 removed lines

@@ -39,10 +39,10 @@
         $dom->formatOutput = false;
         $dom->loadXML($xml, LIBXML_NOBLANKS | LIBXML_NOEMPTYTAG);
         libxml_clear_errors();
-        if (! $dom->schemaValidate($xsd)) {
+        if (!$dom->schemaValidate($xsd)) {
             $msg = '';
             foreach (libxml_get_errors() as $error) {
-                $msg .= $error->message."\n";
+                $msg .= $error->message . "\n";
             }
             throw new RuntimeException($msg);
         }