Completed
Pull Request — master (#139)
by Eduardo
03:56
created
src/DOMImproved.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
     /**
56 56
      * Load xml from path
57 57
      * @param string $filename
58
-     * @return bool
58
+     * @return false|null
59 59
      */
60 60
     public function loadXMLFile($filename)
61 61
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -125,9 +125,9 @@  discard block
 block discarded – undo
125 125
     public function getChave($nodeName = 'infNFe')
126 126
     {
127 127
         $node = $this->getElementsByTagName($nodeName)->item(0);
128
-        if (! empty($node)) {
128
+        if (!empty($node)) {
129 129
             $chaveId = $node->getAttribute("Id");
130
-            $chave =  preg_replace('/[^0-9]/', '', $chaveId);
130
+            $chave = preg_replace('/[^0-9]/', '', $chaveId);
131 131
             return $chave;
132 132
         }
133 133
         return '';
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
      * @return void
148 148
      */
149 149
     public function addChild(
150
-        DOMElement &$parent,
150
+        DOMElement & $parent,
151 151
         $name,
152 152
         $content = '',
153 153
         $obrigatorio = false,
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
      * @param string $msg
175 175
      * @return void
176 176
      */
177
-    public function appChild(DOMElement &$parent, DOMElement $child = null, $msg = '')
177
+    public function appChild(DOMElement & $parent, DOMElement $child = null, $msg = '')
178 178
     {
179 179
         if (empty($child)) {
180 180
             $this->erros[] = $msg;
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      * @param DOMElement $child
190 190
      * @return void
191 191
      */
192
-    public function appExternalChild(DOMElement &$parent, DOMElement $child)
192
+    public function appExternalChild(DOMElement & $parent, DOMElement $child)
193 193
     {
194 194
         $node = $this->importNode($child, true);
195 195
         $parent->appendChild($node);
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
      * @return void
205 205
      */
206 206
     public function appExternalChildBefore(
207
-        DOMElement &$parent,
207
+        DOMElement & $parent,
208 208
         DOMElement $child,
209 209
         $before
210 210
     ) {
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
      * @param string $msg
227 227
      * @return void
228 228
      */
229
-    public function appChildBefore(DOMElement &$parent, DOMElement $child = null, $before = '', $msg = '')
229
+    public function appChildBefore(DOMElement & $parent, DOMElement $child = null, $before = '', $msg = '')
230 230
     {
231 231
         if (empty($child) ||
232 232
             empty($before) ||
@@ -245,10 +245,10 @@  discard block
 block discarded – undo
245 245
      * @param array $arr
246 246
      * @return int
247 247
      */
248
-    public function addArrayChild(DOMElement &$parent, $arr)
248
+    public function addArrayChild(DOMElement & $parent, $arr)
249 249
     {
250 250
         $num = 0;
251
-        if (! empty($arr) && ! empty($parent)) {
251
+        if (!empty($arr) && !empty($parent)) {
252 252
             foreach ($arr as $node) {
253 253
                 $this->appChild($parent, $node, '');
254 254
                 $num++;
Please login to merge, or discard this patch.
src/Soap/SoapBase.php 3 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
 
18 18
 use NFePHP\Common\Certificate;
19 19
 use NFePHP\Common\Soap\SoapInterface;
20
-use NFePHP\Common\Exception\SoapException;
21 20
 use NFePHP\Common\Exception\RuntimeException;
22 21
 use NFePHP\Common\Strings;
23 22
 use League\Flysystem\Filesystem;
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
     /**
280 280
      * Set security protocol
281 281
      * @param int $protocol
282
-     * @return type Description
282
+     * @return integer Description
283 283
      */
284 284
     public function protocol($protocol = self::SSL_DEFAULT)
285 285
     {
@@ -330,6 +330,7 @@  discard block
 block discarded – undo
330 330
      * @param string $request
331 331
      * @param array $namespaces
332 332
      * @param \SOAPHeader $header
333
+     * @param integer $soapver
333 334
      * @return string
334 335
      */
335 336
     protected function makeEnvelopeSoap(
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -387,9 +387,9 @@  discard block
 block discarded – undo
387 387
             );
388 388
         }
389 389
         $this->certsdir = $this->certificate->getCnpj() . '/certs/';
390
-        $this->prifile = $this->certsdir. Strings::randomString(10).'.pem';
391
-        $this->pubfile = $this->certsdir . Strings::randomString(10).'.pem';
392
-        $this->certfile = $this->certsdir . Strings::randomString(10).'.pem';
390
+        $this->prifile = $this->certsdir . Strings::randomString(10) . '.pem';
391
+        $this->pubfile = $this->certsdir . Strings::randomString(10) . '.pem';
392
+        $this->certfile = $this->certsdir . Strings::randomString(10) . '.pem';
393 393
         $ret = true;
394 394
         $private = $this->certificate->privateKey;
395 395
         if ($this->encriptPrivateKey) {
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
         );
415 415
         $ret &= $this->filesystem->put(
416 416
             $this->certfile,
417
-            $private."{$this->certificate}"
417
+            $private . "{$this->certificate}"
418 418
         );
419 419
         if (!$ret) {
420 420
             throw new RuntimeException(
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
         //utilize a API. Outra solução para remover arquivos "perdidos" pode ser
441 441
         //encontrada oportunamente.
442 442
         $dt = new \DateTime();
443
-        $tint = new \DateInterval("PT".$this->waitingTime."M");
443
+        $tint = new \DateInterval("PT" . $this->waitingTime . "M");
444 444
         $tint->invert = true;
445 445
         $tsLimit = $dt->add($tint)->getTimestamp();
446 446
         foreach ($contents as $item) {
Please login to merge, or discard this patch.
src/Certificate/Oids.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
      */
52 52
     private static function loadOids()
53 53
     {
54
-        $json = file_get_contents(__DIR__ .'/oids.json');
54
+        $json = file_get_contents(__DIR__ . '/oids.json');
55 55
         self::$oidsTable = (array) json_decode($json, true);
56 56
     }
57 57
 }
Please login to merge, or discard this patch.
src/Soap/SoapClientExtended.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      */
31 31
     public function __doRequest($request, $location, $action, $version, $oneWay = 0)
32 32
     {
33
-        $search = [":ns1","ns1:","\n","\r"];
33
+        $search = [":ns1", "ns1:", "\n", "\r"];
34 34
         return parent::__doRequest(
35 35
             str_replace($search, '', $request),
36 36
             $location,
Please login to merge, or discard this patch.
src/Soap/SoapCode.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 {
23 23
     public static function info($code)
24 24
     {
25
-        $codes = (array) json_decode(file_get_contents(__DIR__.'/httpcodes.json'), true);
25
+        $codes = (array) json_decode(file_get_contents(__DIR__ . '/httpcodes.json'), true);
26 26
         if (array_key_exists($code, $codes)) {
27 27
             return $codes[$code];
28 28
         }
Please login to merge, or discard this patch.
src/Certificate/PublicKey.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
     /**
64 64
      * Load class with certificate content
65 65
      * @param string $content
66
-     * @return \static
66
+     * @return PublicKey
67 67
      */
68 68
     public static function createFromContent($content)
69 69
     {
Please login to merge, or discard this patch.
src/Certificate/Asn1.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             //get length of OID data
78 78
             $len = self::getLength((string) $data);
79 79
             //get only a string with bytes belongs to OID
80
-            $oidData = substr($data, 2 + $bytes, $len-($bytes));
80
+            $oidData = substr($data, 2 + $bytes, $len - ($bytes));
81 81
             //parse OID data many possibel formats and structures
82 82
             $head = strlen($oidData) - strlen($xcv) - 2;
83 83
             $ret = substr($oidData, -$head);
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
             if ($num == 0) {
122 122
                 $bun = 40 * $partes[$num];
123 123
             } elseif ($num == 1) {
124
-                $bun +=  $partes[$num];
124
+                $bun += $partes[$num];
125 125
                 $abBinary[] = $bun;
126 126
             } else {
127 127
                 $abBinary = self::xBase128((array) $abBinary, (integer) $partes[$num], true);
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     {
146 146
         $abc = $abIn;
147 147
         if ($qIn > 127) {
148
-            $abc = self::xBase128($abc, floor($qIn/128), false);
148
+            $abc = self::xBase128($abc, floor($qIn / 128), false);
149 149
         }
150 150
         $qIn2 = $qIn % 128;
151 151
         if ($flag) {
Please login to merge, or discard this patch.
src/Exception/ExceptionCollection.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
      */
88 88
     public function __toString()
89 89
     {
90
-        $messages = array_map(function (\Exception $exception) {
90
+        $messages = array_map(function(\Exception $exception) {
91 91
             return $exception->getMessage();
92 92
         }, $this->exceptions);
93 93
         return implode(PHP_EOL, $messages);
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
     
45 45
     /**
46 46
      * Add exceptions to the collection
47
-     * @param Exception Exception to add
47
+     * @param Exception \Exception to add
48 48
      * @return ExceptionCollection;
49 49
      */
50 50
     public function add(\Exception $exception)
Please login to merge, or discard this patch.
src/Soap/SoapCurl.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
                 curl_setopt($oCurl, CURLOPT_KEYPASSWD, $this->temppass);
99 99
             }
100 100
             curl_setopt($oCurl, CURLOPT_RETURNTRANSFER, 1);
101
-            if (! empty($envelope)) {
101
+            if (!empty($envelope)) {
102 102
                 curl_setopt($oCurl, CURLOPT_POST, 1);
103 103
                 curl_setopt($oCurl, CURLOPT_POSTFIELDS, $envelope);
104 104
                 curl_setopt($oCurl, CURLOPT_HTTPHEADER, $parameters);
@@ -140,9 +140,9 @@  discard block
 block discarded – undo
140 140
         if ($this->proxyIP != '') {
141 141
             curl_setopt($oCurl, CURLOPT_HTTPPROXYTUNNEL, 1);
142 142
             curl_setopt($oCurl, CURLOPT_PROXYTYPE, CURLPROXY_HTTP);
143
-            curl_setopt($oCurl, CURLOPT_PROXY, $this->proxyIP.':'.$this->proxyPort);
143
+            curl_setopt($oCurl, CURLOPT_PROXY, $this->proxyIP . ':' . $this->proxyPort);
144 144
             if ($this->proxyUser != '') {
145
-                curl_setopt($oCurl, CURLOPT_PROXYUSERPWD, $this->proxyUser.':'.$this->proxyPass);
145
+                curl_setopt($oCurl, CURLOPT_PROXYUSERPWD, $this->proxyUser . ':' . $this->proxyPass);
146 146
                 curl_setopt($oCurl, CURLOPT_PROXYAUTH, CURLAUTH_BASIC);
147 147
             }
148 148
         }
Please login to merge, or discard this patch.