View GitHub Repository twofactor_gateway

Schedule Inspection
Subscribe
Passed
Pull Request — master (#686)
by Vitor
04:32
created

454 +185 Covered Lines

2,002 +427 Total Lines

22.7 % +5.6% Code Coverage

PHP Classes Changes

 
 ⇢
0%
Login added
 
 ⇢
0%
SendMessage added
 
 ⇢
14.29%
Settings added
 
 ⇢
25%
FieldDefinition added
0%
 ↗
100%
 Status improved
0%
 ↗
71.79%
 AGateway improved
90.91%
 ↘
24.14%
 TConfigurable got worse
0%
 ↗
64%
 Test improved
0%
 ↗
53.13%
 ClickSend improved
73.68%
 ↘
21.74%
 AProvider got worse
13.33%
 ↗
61.76%
 ClickatellCentral improved
0%
 ↗
47.62%
 Configure improved
0%
 ↗
43.48%
 Remove improved
0%
 ↗
42.22%
 Gateway improved
⋮ view more  
0%
 ↛
 
 Login removed
0%
 ↛
 
 SendMessage removed

CRAP Changes

 
 ⇢
30
Login::execute() added
 
 ⇢
30
SendMessage::execute() added
 
 ⇢
6
Settings::resolveId() added
 
 ⇢
6
AProvider::getSettings() added
 
 ⇢
2.0625
AProvider::getSettings() added
 
 ⇢
2
SipGate::createSettings() added
 
 ⇢
2
HuaweiE3531::createSettings() added
 
 ⇢
2
Settings::jsonSerialize() added
 
 ⇢
2
PlaySMS::createSettings() added
 
 ⇢
2
SMSGlobal::createSettings() added
⋮ view more  
2.0625
 ↘
2
 ConfigurationException::__construct() improved
4.5923
 ↘
4.0047
 AFactory::get() improved
2
 ↘
1
 ClickSend::__construct() improved
2
 ↘
1
 Status::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
2
 ↘
1
 AGateway::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
⋮ view more  
30
 ↛
 
 Login::execute() removed
30
 ↛
 
 SendMessage::execute() removed
6
 ↛
 
 Gateway::getSettings() removed
6
 ↛
 
 Factory::isValid() removed
6
 ↛
 
 Gateway::getSettings() removed
2.0625
 ↛
 
 TConfigurable::getSchema() removed
2
 ↛
 
 Login::configure() removed
2
 ↛
 
 SendMessage::configure() removed
2
 ↛
 
 Factory::isValid() removed
1
 ↛
 
 TConfigurable::getSchemaFields() removed
⋮ view more