View GitHub Repository twofactor_gateway

Schedule Inspection
Subscribe
Passed
Pull Request — master (#686)
by Vitor
04:31
created

500 +231 Covered Lines

2,007 +432 Total Lines

24.9 % +7.8% Code Coverage

PHP Classes Changes

 
 ⇢
0%
Login added
 
 ⇢
0%
SendMessage added
 
 ⇢
14.29%
Settings added
 
 ⇢
25%
FieldDefinition added
0%
 ↗
100%
 Status improved
0%
 ↗
92.68%
 AGateway improved
0%
 ↗
86.96%
 Remove improved
0%
 ↗
64%
 Test improved
0%
 ↗
53.13%
 ClickSend improved
13.33%
 ↗
61.76%
 ClickatellCentral improved
0%
 ↗
47.62%
 Configure improved
0%
 ↗
42.22%
 Gateway improved
0%
 ↗
33.33%
 Gateway improved
73.68%
 ↘
41.67%
 AProvider got worse
⋮ view more  
0%
 ↛
 
 Login removed
0%
 ↛
 
 SendMessage removed

CRAP Changes

 
 ⇢
30
Login::execute() added
 
 ⇢
30
SendMessage::execute() added
 
 ⇢
6
Settings::resolveId() added
 
 ⇢
6
AProvider::getSettings() added
 
 ⇢
2
PlaySMS::createSettings() added
 
 ⇢
2
Settings::jsonSerialize() added
 
 ⇢
2
SMSGlobal::createSettings() added
 
 ⇢
2
AProvider::getSettings() added
 
 ⇢
2
Ovh::createSettings() added
 
 ⇢
2
Client::createSettings() added
⋮ view more  
2.0625
 ↘
2
 ConfigurationException::__construct() improved
4.5923
 ↘
4
 AFactory::get() improved
2
 ↘
1
 AGateway::toCamel() improved
2
 ↘
1
 ClickSend::__construct() improved
2
 ↘
1
 Status::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
2
 ↘
1
 AGateway::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
2
 ↘
1
 Gateway::__construct() improved
⋮ view more  
30
 ↛
 
 SendMessage::execute() removed
30
 ↛
 
 Login::execute() removed
6
 ↛
 
 Factory::isValid() removed
6
 ↛
 
 Gateway::getSettings() removed
6
 ↛
 
 Gateway::getSettings() removed
2.0625
 ↛
 
 TConfigurable::getSchema() removed
2
 ↛
 
 Login::configure() removed
2
 ↛
 
 SendMessage::configure() removed
2
 ↛
 
 Factory::isValid() removed
1
 ↛
 
 TConfigurable::getSchemaFields() removed
⋮ view more