Inspection of "Merge pull request #14227 from nextcloud/enh/comme..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 559a67...b37f24 )

by Roeland

created 2019-02-26 09:29 UTC

Status

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch

@@ -35,61 +35,61 @@
 block discarded – undo
 
 class Application extends App {
 
-	public function __construct (array $urlParams = array()) {
-		parent::__construct('comments', $urlParams);
-		$container = $this->getContainer();
+    public function __construct (array $urlParams = array()) {
+        parent::__construct('comments', $urlParams);
+        $container = $this->getContainer();
 
-		$container->registerAlias('NotificationsController', Notifications::class);
+        $container->registerAlias('NotificationsController', Notifications::class);
 
-		$jsSettingsHelper = new JSSettingsHelper($container->getServer());
-		Util::connectHook('\OCP\Config', 'js', $jsSettingsHelper, 'extend');
-	}
+        $jsSettingsHelper = new JSSettingsHelper($container->getServer());
+        Util::connectHook('\OCP\Config', 'js', $jsSettingsHelper, 'extend');
+    }
 
-	public function register() {
-		$server = $this->getContainer()->getServer();
+    public function register() {
+        $server = $this->getContainer()->getServer();
 
-		$dispatcher = $server->getEventDispatcher();
-		$this->registerSidebarScripts($dispatcher);
-		$this->registerDavEntity($dispatcher);
-		$this->registerNotifier();
-		$this->registerCommentsEventHandler();
+        $dispatcher = $server->getEventDispatcher();
+        $this->registerSidebarScripts($dispatcher);
+        $this->registerDavEntity($dispatcher);
+        $this->registerNotifier();
+        $this->registerCommentsEventHandler();
 
-		$server->getSearch()->registerProvider(Provider::class, ['apps' => ['files']]);
-	}
+        $server->getSearch()->registerProvider(Provider::class, ['apps' => ['files']]);
+    }
 
-	protected function registerSidebarScripts(EventDispatcherInterface $dispatcher) {
-		$dispatcher->addListener(
-			'OCA\Files::loadAdditionalScripts',
-			function() {
-				Util::addScript('comments', 'comments');
-			}
-		);
-	}
+    protected function registerSidebarScripts(EventDispatcherInterface $dispatcher) {
+        $dispatcher->addListener(
+            'OCA\Files::loadAdditionalScripts',
+            function() {
+                Util::addScript('comments', 'comments');
+            }
+        );
+    }
 
-	protected function registerDavEntity(EventDispatcherInterface $dispatcher) {
-		$dispatcher->addListener(CommentsEntityEvent::EVENT_ENTITY, function(CommentsEntityEvent $event) {
-			$event->addEntityCollection('files', function($name) {
-				$nodes = \OC::$server->getUserFolder()->getById((int)$name);
-				return !empty($nodes);
-			});
-		});
-	}
+    protected function registerDavEntity(EventDispatcherInterface $dispatcher) {
+        $dispatcher->addListener(CommentsEntityEvent::EVENT_ENTITY, function(CommentsEntityEvent $event) {
+            $event->addEntityCollection('files', function($name) {
+                $nodes = \OC::$server->getUserFolder()->getById((int)$name);
+                return !empty($nodes);
+            });
+        });
+    }
 
-	protected function registerNotifier() {
-		$this->getContainer()->getServer()->getNotificationManager()->registerNotifier(
-			function() {
-				return $this->getContainer()->query(Notifier::class);
-			},
-			function () {
-				$l = $this->getContainer()->getServer()->getL10NFactory()->get('comments');
-				return ['id' => 'comments', 'name' => $l->t('Comments')];
-			}
-		);
-	}
+    protected function registerNotifier() {
+        $this->getContainer()->getServer()->getNotificationManager()->registerNotifier(
+            function() {
+                return $this->getContainer()->query(Notifier::class);
+            },
+            function () {
+                $l = $this->getContainer()->getServer()->getL10NFactory()->get('comments');
+                return ['id' => 'comments', 'name' => $l->t('Comments')];
+            }
+        );
+    }
 
-	protected function registerCommentsEventHandler() {
-		$this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
-			return $this->getContainer()->query(EventHandler::class);
-		});
-	}
+    protected function registerCommentsEventHandler() {
+        $this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
+            return $this->getContainer()->query(EventHandler::class);
+        });
+    }
 }

Please login to merge, or discard this patch.

		@@ -35,61 +35,61 @@
		block discarded – undo
35	35
36	36	class Application extends App {
37	37
38		- public function __construct (array $urlParams = array()) {
39		- parent::__construct('comments', $urlParams);
40		- $container = $this->getContainer();
	38	+ public function __construct (array $urlParams = array()) {
	39	+ parent::__construct('comments', $urlParams);
	40	+ $container = $this->getContainer();
41	41
42		- $container->registerAlias('NotificationsController', Notifications::class);
	42	+ $container->registerAlias('NotificationsController', Notifications::class);
43	43
44		- $jsSettingsHelper = new JSSettingsHelper($container->getServer());
45		- Util::connectHook('\OCP\Config', 'js', $jsSettingsHelper, 'extend');
46		- }
	44	+ $jsSettingsHelper = new JSSettingsHelper($container->getServer());
	45	+ Util::connectHook('\OCP\Config', 'js', $jsSettingsHelper, 'extend');
	46	+ }
47	47
48		- public function register() {
49		- $server = $this->getContainer()->getServer();
	48	+ public function register() {
	49	+ $server = $this->getContainer()->getServer();
50	50
51		- $dispatcher = $server->getEventDispatcher();
52		- $this->registerSidebarScripts($dispatcher);
53		- $this->registerDavEntity($dispatcher);
54		- $this->registerNotifier();
55		- $this->registerCommentsEventHandler();
	51	+ $dispatcher = $server->getEventDispatcher();
	52	+ $this->registerSidebarScripts($dispatcher);
	53	+ $this->registerDavEntity($dispatcher);
	54	+ $this->registerNotifier();
	55	+ $this->registerCommentsEventHandler();
56	56
57		- $server->getSearch()->registerProvider(Provider::class, ['apps' => ['files']]);
58		- }
	57	+ $server->getSearch()->registerProvider(Provider::class, ['apps' => ['files']]);
	58	+ }
59	59
60		- protected function registerSidebarScripts(EventDispatcherInterface $dispatcher) {
61		- $dispatcher->addListener(
62		- 'OCA\Files::loadAdditionalScripts',
63		- function() {
64		- Util::addScript('comments', 'comments');
65		- }
66		- );
67		- }
	60	+ protected function registerSidebarScripts(EventDispatcherInterface $dispatcher) {
	61	+ $dispatcher->addListener(
	62	+ 'OCA\Files::loadAdditionalScripts',
	63	+ function() {
	64	+ Util::addScript('comments', 'comments');
	65	+ }
	66	+ );
	67	+ }
68	68
69		- protected function registerDavEntity(EventDispatcherInterface $dispatcher) {
70		- $dispatcher->addListener(CommentsEntityEvent::EVENT_ENTITY, function(CommentsEntityEvent $event) {
71		- $event->addEntityCollection('files', function($name) {
72		- $nodes = \OC::$server->getUserFolder()->getById((int)$name);
73		- return !empty($nodes);
74		- });
75		- });
76		- }
	69	+ protected function registerDavEntity(EventDispatcherInterface $dispatcher) {
	70	+ $dispatcher->addListener(CommentsEntityEvent::EVENT_ENTITY, function(CommentsEntityEvent $event) {
	71	+ $event->addEntityCollection('files', function($name) {
	72	+ $nodes = \OC::$server->getUserFolder()->getById((int)$name);
	73	+ return !empty($nodes);
	74	+ });
	75	+ });
	76	+ }
77	77
78		- protected function registerNotifier() {
79		- $this->getContainer()->getServer()->getNotificationManager()->registerNotifier(
80		- function() {
81		- return $this->getContainer()->query(Notifier::class);
82		- },
83		- function () {
84		- $l = $this->getContainer()->getServer()->getL10NFactory()->get('comments');
85		- return ['id' => 'comments', 'name' => $l->t('Comments')];
86		- }
87		- );
88		- }
	78	+ protected function registerNotifier() {
	79	+ $this->getContainer()->getServer()->getNotificationManager()->registerNotifier(
	80	+ function() {
	81	+ return $this->getContainer()->query(Notifier::class);
	82	+ },
	83	+ function () {
	84	+ $l = $this->getContainer()->getServer()->getL10NFactory()->get('comments');
	85	+ return ['id' => 'comments', 'name' => $l->t('Comments')];
	86	+ }
	87	+ );
	88	+ }
89	89
90		- protected function registerCommentsEventHandler() {
91		- $this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
92		- return $this->getContainer()->query(EventHandler::class);
93		- });
94		- }
	90	+ protected function registerCommentsEventHandler() {
	91	+ $this->getContainer()->getServer()->getCommentsManager()->registerEventHandler(function () {
	92	+ return $this->getContainer()->query(EventHandler::class);
	93	+ });
	94	+ }
95	95	}

nextcloud / server

Push — master ( 559a67...b37f24 )

Status

Category

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch