nextcloud / server

lib/private/AppFramework/Middleware/Security/RateLimitingMiddleware.php

Indentation +97 added lines, -97 removed lines

@@ -65,101 +65,101 @@
  * @package OC\AppFramework\Middleware\Security
  */
 class RateLimitingMiddleware extends Middleware {
-	public function __construct(
-		protected IRequest $request,
-		protected IUserSession $userSession,
-		protected ControllerMethodReflector $reflector,
-		protected Limiter $limiter,
-	) {
-	}
-
-	/**
-	 * {@inheritDoc}
-	 * @throws RateLimitExceededException
-	 */
-	public function beforeController(Controller $controller, string $methodName): void {
-		parent::beforeController($controller, $methodName);
-		$rateLimitIdentifier = get_class($controller) . '::' . $methodName;
-
-		if ($this->userSession->isLoggedIn()) {
-			$rateLimit = $this->readLimitFromAnnotationOrAttribute($controller, $methodName, 'UserRateThrottle', UserRateLimit::class);
-
-			if ($rateLimit !== null) {
-				$this->limiter->registerUserRequest(
-					$rateLimitIdentifier,
-					$rateLimit->getLimit(),
-					$rateLimit->getPeriod(),
-					$this->userSession->getUser()
-				);
-				return;
-			}
-
-			// If not user specific rate limit is found the Anon rate limit applies!
-		}
-
-		$rateLimit = $this->readLimitFromAnnotationOrAttribute($controller, $methodName, 'AnonRateThrottle', AnonRateLimit::class);
-
-		if ($rateLimit !== null) {
-			$this->limiter->registerAnonRequest(
-				$rateLimitIdentifier,
-				$rateLimit->getLimit(),
-				$rateLimit->getPeriod(),
-				$this->request->getRemoteAddress()
-			);
-		}
-	}
-
-	/**
-	 * @template T of ARateLimit
-	 *
-	 * @param Controller $controller
-	 * @param string $methodName
-	 * @param string $annotationName
-	 * @param class-string<T> $attributeClass
-	 * @return ?ARateLimit
-	 */
-	protected function readLimitFromAnnotationOrAttribute(Controller $controller, string $methodName, string $annotationName, string $attributeClass): ?ARateLimit {
-		$annotationLimit = $this->reflector->getAnnotationParameter($annotationName, 'limit');
-		$annotationPeriod = $this->reflector->getAnnotationParameter($annotationName, 'period');
-
-		if ($annotationLimit !== '' && $annotationPeriod !== '') {
-			return new $attributeClass(
-				(int) $annotationLimit,
-				(int) $annotationPeriod,
-			);
-		}
-
-		$reflectionMethod = new ReflectionMethod($controller, $methodName);
-		$attributes = $reflectionMethod->getAttributes($attributeClass);
-		$attribute = current($attributes);
-
-		if ($attribute !== false) {
-			return $attribute->newInstance();
-		}
-
-		return null;
-	}
-
-	/**
-	 * {@inheritDoc}
-	 */
-	public function afterException(Controller $controller, string $methodName, \Exception $exception): Response {
-		if ($exception instanceof RateLimitExceededException) {
-			if (stripos($this->request->getHeader('Accept'), 'html') === false) {
-				$response = new DataResponse([], $exception->getCode());
-			} else {
-				$response = new TemplateResponse(
-					'core',
-					'429',
-					[],
-					TemplateResponse::RENDER_AS_GUEST
-				);
-				$response->setStatus($exception->getCode());
-			}
-
-			return $response;
-		}
-
-		throw $exception;
-	}
+    public function __construct(
+        protected IRequest $request,
+        protected IUserSession $userSession,
+        protected ControllerMethodReflector $reflector,
+        protected Limiter $limiter,
+    ) {
+    }
+
+    /**
+     * {@inheritDoc}
+     * @throws RateLimitExceededException
+     */
+    public function beforeController(Controller $controller, string $methodName): void {
+        parent::beforeController($controller, $methodName);
+        $rateLimitIdentifier = get_class($controller) . '::' . $methodName;
+
+        if ($this->userSession->isLoggedIn()) {
+            $rateLimit = $this->readLimitFromAnnotationOrAttribute($controller, $methodName, 'UserRateThrottle', UserRateLimit::class);
+
+            if ($rateLimit !== null) {
+                $this->limiter->registerUserRequest(
+                    $rateLimitIdentifier,
+                    $rateLimit->getLimit(),
+                    $rateLimit->getPeriod(),
+                    $this->userSession->getUser()
+                );
+                return;
+            }
+
+            // If not user specific rate limit is found the Anon rate limit applies!
+        }
+
+        $rateLimit = $this->readLimitFromAnnotationOrAttribute($controller, $methodName, 'AnonRateThrottle', AnonRateLimit::class);
+
+        if ($rateLimit !== null) {
+            $this->limiter->registerAnonRequest(
+                $rateLimitIdentifier,
+                $rateLimit->getLimit(),
+                $rateLimit->getPeriod(),
+                $this->request->getRemoteAddress()
+            );
+        }
+    }
+
+    /**
+     * @template T of ARateLimit
+     *
+     * @param Controller $controller
+     * @param string $methodName
+     * @param string $annotationName
+     * @param class-string<T> $attributeClass
+     * @return ?ARateLimit
+     */
+    protected function readLimitFromAnnotationOrAttribute(Controller $controller, string $methodName, string $annotationName, string $attributeClass): ?ARateLimit {
+        $annotationLimit = $this->reflector->getAnnotationParameter($annotationName, 'limit');
+        $annotationPeriod = $this->reflector->getAnnotationParameter($annotationName, 'period');
+
+        if ($annotationLimit !== '' && $annotationPeriod !== '') {
+            return new $attributeClass(
+                (int) $annotationLimit,
+                (int) $annotationPeriod,
+            );
+        }
+
+        $reflectionMethod = new ReflectionMethod($controller, $methodName);
+        $attributes = $reflectionMethod->getAttributes($attributeClass);
+        $attribute = current($attributes);
+
+        if ($attribute !== false) {
+            return $attribute->newInstance();
+        }
+
+        return null;
+    }
+
+    /**
+     * {@inheritDoc}
+     */
+    public function afterException(Controller $controller, string $methodName, \Exception $exception): Response {
+        if ($exception instanceof RateLimitExceededException) {
+            if (stripos($this->request->getHeader('Accept'), 'html') === false) {
+                $response = new DataResponse([], $exception->getCode());
+            } else {
+                $response = new TemplateResponse(
+                    'core',
+                    '429',
+                    [],
+                    TemplateResponse::RENDER_AS_GUEST
+                );
+                $response->setStatus($exception->getCode());
+            }
+
+            return $response;
+        }
+
+        throw $exception;
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
 	 */
 	public function beforeController(Controller $controller, string $methodName): void {
 		parent::beforeController($controller, $methodName);
-		$rateLimitIdentifier = get_class($controller) . '::' . $methodName;
+		$rateLimitIdentifier = get_class($controller).'::'.$methodName;
 
 		if ($this->userSession->isLoggedIn()) {
 			$rateLimit = $this->readLimitFromAnnotationOrAttribute($controller, $methodName, 'UserRateThrottle', UserRateLimit::class);

lib/public/AppFramework/Http/Attribute/ARateLimit.php

Indentation +20 added lines, -20 removed lines

@@ -32,26 +32,26 @@
  * @since 27.0.0
  */
 abstract class ARateLimit {
-	/**
-	 * @since 27.0.0
-	 */
-	public function __construct(
-		protected int $limit,
-		protected int $period,
-	) {
-	}
+    /**
+     * @since 27.0.0
+     */
+    public function __construct(
+        protected int $limit,
+        protected int $period,
+    ) {
+    }
 
-	/**
-	 * @since 27.0.0
-	 */
-	public function getLimit(): int {
-		return $this->limit;
-	}
+    /**
+     * @since 27.0.0
+     */
+    public function getLimit(): int {
+        return $this->limit;
+    }
 
-	/**
-	 * @since 27.0.0
-	 */
-	public function getPeriod(): int {
-		return $this->period;
-	}
+    /**
+     * @since 27.0.0
+     */
+    public function getPeriod(): int {
+        return $this->period;
+    }
 }