nextcloud / server

lib/public/Files.php

Doc Comments +2 added lines, -1 removed lines

@@ -49,6 +49,7 @@ 
 class Files {
 	/**
 	 * Recusive deletion of folders
+	 * @param string $dir
 	 * @return bool
 	 * @since 5.0.0
 	 * @deprecated 14.0.0
@@ -72,7 +73,7 @@ 
 	/**
 	 * Search for files by mimetype
 	 * @param string $mimetype
-	 * @return array
+	 * @return \OC\Files\FileInfo[]
 	 * @since 6.0.0
 	 * @deprecated 14.0.0
 	 */

Indentation +64 added lines, -64 removed lines

@@ -47,73 +47,73 @@
  * @deprecated 14.0.0
  */
 class Files {
-	/**
-	 * Recusive deletion of folders
-	 * @return bool
-	 * @since 5.0.0
-	 * @deprecated 14.0.0
-	 */
-	static public function rmdirr( $dir ) {
-		return \OC_Helper::rmdirr( $dir );
-	}
+    /**
+     * Recusive deletion of folders
+     * @return bool
+     * @since 5.0.0
+     * @deprecated 14.0.0
+     */
+    static public function rmdirr( $dir ) {
+        return \OC_Helper::rmdirr( $dir );
+    }
 
-	/**
-	 * Get the mimetype form a local file
-	 * @param string $path
-	 * @return string
-	 * does NOT work for ownClouds filesystem, use OC_FileSystem::getMimeType instead
-	 * @since 5.0.0
-	 * @deprecated 14.0.0
-	 */
-	static public function getMimeType( $path ) {
-		return \OC::$server->getMimeTypeDetector()->detect($path);
-	}
+    /**
+     * Get the mimetype form a local file
+     * @param string $path
+     * @return string
+     * does NOT work for ownClouds filesystem, use OC_FileSystem::getMimeType instead
+     * @since 5.0.0
+     * @deprecated 14.0.0
+     */
+    static public function getMimeType( $path ) {
+        return \OC::$server->getMimeTypeDetector()->detect($path);
+    }
 
-	/**
-	 * Search for files by mimetype
-	 * @param string $mimetype
-	 * @return array
-	 * @since 6.0.0
-	 * @deprecated 14.0.0
-	 */
-	static public function searchByMime($mimetype) {
-		return \OC\Files\Filesystem::searchByMime($mimetype);
-	}
+    /**
+     * Search for files by mimetype
+     * @param string $mimetype
+     * @return array
+     * @since 6.0.0
+     * @deprecated 14.0.0
+     */
+    static public function searchByMime($mimetype) {
+        return \OC\Files\Filesystem::searchByMime($mimetype);
+    }
 
-	/**
-	 * Copy the contents of one stream to another
-	 * @param resource $source
-	 * @param resource $target
-	 * @return int the number of bytes copied
-	 * @since 5.0.0
-	 * @deprecated 14.0.0
-	 */
-	public static function streamCopy( $source, $target ) {
-		list($count, ) = \OC_Helper::streamCopy( $source, $target );
-		return $count;
-	}
+    /**
+     * Copy the contents of one stream to another
+     * @param resource $source
+     * @param resource $target
+     * @return int the number of bytes copied
+     * @since 5.0.0
+     * @deprecated 14.0.0
+     */
+    public static function streamCopy( $source, $target ) {
+        list($count, ) = \OC_Helper::streamCopy( $source, $target );
+        return $count;
+    }
 
-	/**
-	 * Adds a suffix to the name in case the file exists
-	 * @param string $path
-	 * @param string $filename
-	 * @return string
-	 * @since 5.0.0
-	 * @deprecated 14.0.0 use getNonExistingName of the OCP\Files\Folder object
-	 */
-	public static function buildNotExistingFileName($path, $filename) {
-		return \OC_Helper::buildNotExistingFileName($path, $filename);
-	}
+    /**
+     * Adds a suffix to the name in case the file exists
+     * @param string $path
+     * @param string $filename
+     * @return string
+     * @since 5.0.0
+     * @deprecated 14.0.0 use getNonExistingName of the OCP\Files\Folder object
+     */
+    public static function buildNotExistingFileName($path, $filename) {
+        return \OC_Helper::buildNotExistingFileName($path, $filename);
+    }
 
-	/**
-	 * Gets the Storage for an app - creates the needed folder if they are not
-	 * existent
-	 * @param string $app
-	 * @return \OC\Files\View
-	 * @since 5.0.0
-	 * @deprecated 14.0.0 use IAppData instead
-	 */
-	public static function getStorage($app) {
-		return \OC_App::getStorage( $app );
-	}
+    /**
+     * Gets the Storage for an app - creates the needed folder if they are not
+     * existent
+     * @param string $app
+     * @return \OC\Files\View
+     * @since 5.0.0
+     * @deprecated 14.0.0 use IAppData instead
+     */
+    public static function getStorage($app) {
+        return \OC_App::getStorage( $app );
+    }
 }

Spacing +6 added lines, -6 removed lines

@@ -53,8 +53,8 @@ 
 	 * @since 5.0.0
 	 * @deprecated 14.0.0
 	 */
-	static public function rmdirr( $dir ) {
-		return \OC_Helper::rmdirr( $dir );
+	static public function rmdirr($dir) {
+		return \OC_Helper::rmdirr($dir);
 	}
 
 	/**
@@ -65,7 +65,7 @@ 
 	 * @since 5.0.0
 	 * @deprecated 14.0.0
 	 */
-	static public function getMimeType( $path ) {
+	static public function getMimeType($path) {
 		return \OC::$server->getMimeTypeDetector()->detect($path);
 	}
 
@@ -88,8 +88,8 @@ 
 	 * @since 5.0.0
 	 * @deprecated 14.0.0
 	 */
-	public static function streamCopy( $source, $target ) {
-		list($count, ) = \OC_Helper::streamCopy( $source, $target );
+	public static function streamCopy($source, $target) {
+		list($count,) = \OC_Helper::streamCopy($source, $target);
 		return $count;
 	}
 
@@ -114,6 +114,6 @@ 
 	 * @deprecated 14.0.0 use IAppData instead
 	 */
 	public static function getStorage($app) {
-		return \OC_App::getStorage( $app );
+		return \OC_App::getStorage($app);
 	}
 }

lib/private/App/CodeChecker/DeprecationCheck.php

Indentation +160 added lines, -160 removed lines

@@ -24,164 +24,164 @@
 namespace OC\App\CodeChecker;
 
 class DeprecationCheck extends AbstractCheck {
-	/**
-	 * @return string
-	 */
-	protected function getLocalDescription() {
-		return 'deprecated';
-	}
-
-	/**
-	 * @return array E.g.: `'ClassName' => 'oc version',`
-	 */
-	protected function getLocalClasses() {
-		return [
-			'OC_JSON' => '8.2.0',
-
-			'OCP\Contacts' => '8.1.0',
-			'OCP\DB' => '8.1.0',
-			'OCP\JSON' => '8.1.0',
-			'OCP\Response' => '8.1.0',
-			'OCP\AppFramework\IApi' => '8.0.0',
-			'OCP\User' => '13.0.0',
-			'OCP\BackgroundJob' => '14.0.0',
-			'OCP\App' => '14.0.0',
-			'OCP\Files' => '14.0.0',
-		];
-	}
-
-	/**
-	 * @return array E.g.: `'ClassName::CONSTANT_NAME' => 'oc version',`
-	 */
-	protected function getLocalConstants() {
-		return [
-			'OC_API::GUEST_AUTH' => '8.2.0',
-			'OC_API::USER_AUTH' => '8.2.0',
-			'OC_API::SUBADMIN_AUTH' => '8.2.0',
-			'OC_API::ADMIN_AUTH' => '8.2.0',
-			'OC_API::RESPOND_UNAUTHORISED' => '8.2.0',
-			'OC_API::RESPOND_SERVER_ERROR' => '8.2.0',
-			'OC_API::RESPOND_NOT_FOUND' => '8.2.0',
-			'OC_API::RESPOND_UNKNOWN_ERROR' => '8.2.0',
-
-			'OCP::PERMISSION_CREATE' => '8.0.0',
-			'OCP::PERMISSION_READ' => '8.0.0',
-			'OCP::PERMISSION_UPDATE' => '8.0.0',
-			'OCP::PERMISSION_DELETE' => '8.0.0',
-			'OCP::PERMISSION_SHARE' => '8.0.0',
-			'OCP::PERMISSION_ALL' => '8.0.0',
-			'OCP::FILENAME_INVALID_CHARS' => '8.0.0',
-		];
-	}
-
-	/**
-	 * @return array E.g.: `'functionName' => 'oc version',`
-	 */
-	protected function getLocalFunctions() {
-		return [
-			'OCP::image_path' => '8.0.0',
-			'OCP::mimetype_icon' => '8.0.0',
-			'OCP::preview_icon' => '8.0.0',
-			'OCP::publicPreview_icon' => '8.0.0',
-			'OCP::human_file_size' => '8.0.0',
-			'OCP::relative_modified_date' => '8.0.0',
-			'OCP::simple_file_size' => '8.0.0',
-			'OCP::html_select_options' => '8.0.0',
-		];
-	}
-
-	/**
-	 * @return array E.g.: `'ClassName::methodName' => 'oc version',`
-	 */
-	protected function getLocalMethods() {
-		return [
-			'OC_L10N::get' => '8.2.0',
-
-			'OCP\Activity\IManager::publishActivity' => '8.2.0',
-
-			'OCP\App::register' => '8.1.0',
-			'OCP\App::addNavigationEntry' => '8.1.0',
-			'OCP\App::getActiveNavigationEntry' => '8.2.0',
-			'OCP\App::setActiveNavigationEntry' => '8.1.0',
-			'OCP\App::registerPersonal' => '14.0.0',
-			'OCP\App::registerAdmin' => '14.0.0',
-			'OC_App::getAppInfo' => '14.0.0',
-			'OCP\App::getAppInfo' => '14.0.0',
-			'OC_App::getAppVersion' => '14.0.0',
-			'OCP\App::getAppVersion' => '14.0.0',
-			'OCP\App::registerPersonal' => '14.0.0',
-
-			'OCP\AppFramework\Controller::params' => '7.0.0',
-			'OCP\AppFramework\Controller::getParams' => '7.0.0',
-			'OCP\AppFramework\Controller::method' => '7.0.0',
-			'OCP\AppFramework\Controller::getUploadedFile' => '7.0.0',
-			'OCP\AppFramework\Controller::env' => '7.0.0',
-			'OCP\AppFramework\Controller::cookie' => '7.0.0',
-			'OCP\AppFramework\Controller::render' => '7.0.0',
-
-			'OCP\AppFramework\IAppContainer::getCoreApi' => '8.0.0',
-			'OCP\AppFramework\IAppContainer::isLoggedIn' => '8.0.0',
-			'OCP\AppFramework\IAppContainer::isAdminUser' => '8.0.0',
-			'OCP\AppFramework\IAppContainer::log' => '8.0.0',
-
-			'OCP\BackgroundJob::registerJob' => '8.1.0',
-			'OCP\BackgroundJob::getExecutionType' => '14.0.0',
-			'OCP\BackgroundJob::setExecutionType' => '14.0.0',
-
-			'OCP\Files::tmpFile' => '8.1.0',
-			'OCP\Files::tmpFolder' => '8.1.0',
-
-			'OCP\IAppConfig::getValue' => '8.0.0',
-			'OCP\IAppConfig::deleteKey' => '8.0.0',
-			'OCP\IAppConfig::getKeys' => '8.0.0',
-			'OCP\IAppConfig::setValue' => '8.0.0',
-			'OCP\IAppConfig::deleteApp' => '8.0.0',
-
-			'OCP\IDBConnection::createQueryBuilder' => '8.2.0',
-			'OCP\IDBConnection::getExpressionBuilder' => '8.2.0',
-
-			'OCP\ISearch::search' => '8.0.0',
-
-			'OCP\IServerContainer::getCache' => '8.2.0',
-			'OCP\IServerContainer::getDb' => '8.1.0',
-			'OCP\IServerContainer::getHTTPHelper' => '8.1.0',
-
-			'OCP\Response::disableCaching' => '14.0.0',
-
-			'OCP\User::getUser' => '8.0.0',
-			'OCP\User::getUsers' => '8.1.0',
-			'OCP\User::getDisplayName' => '8.1.0',
-			'OCP\User::getDisplayNames' => '8.1.0',
-			'OCP\User::userExists' => '8.1.0',
-			'OCP\User::logout' => '8.1.0',
-			'OCP\User::checkPassword' => '8.1.0',
-			'OCP\User::isLoggedIn' => '13.0.0',
-			'OCP\User::checkAdminUser' => '13.0.0',
-			'OCP\User::checkLoggedIn' => '13.0.0',
-
-			'OCP\Util::encryptedFiles' => '8.1.0',
-			'OCP\Util::formatDate' => '8.0.0',
-			'OCP\Util::generateRandomBytes' => '8.1.0',
-			'OCP\Util::getServerHost' => '8.1.0',
-			'OCP\Util::getServerProtocol' => '8.1.0',
-			'OCP\Util::getRequestUri' => '8.1.0',
-			'OCP\Util::getScriptName' => '8.1.0',
-			'OCP\Util::imagePath' => '8.1.0',
-			'OCP\Util::isValidFileName' => '8.1.0',
-			'OCP\Util::linkToRoute' => '8.1.0',
-			'OCP\Util::linkTo' => '8.1.0',
-			'OCP\Util::logException' => '8.2.0',
-			'OCP\Util::mb_str_replace' => '8.2.0',
-			'OCP\Util::mb_substr_replace' => '8.2.0',
-			'OCP\Util::sendMail' => '8.1.0',
-			'OCP\Util::writeLog' => '13.0.0',
-
-			'OCP\Files::rmdirr' => '14.0.0',
-			'OCP\Files::getMimeType' => '14.0.0',
-			'OCP\Files::searchByMime' => '14.0.0',
-			'OCP\Files::streamCopy' => '14.0.0',
-			'OCP\Files::buildNotExistingFileName' => '14.0.0',
-			'OCP\Files::getStorage' => '14.0.0',
-		];
-	}
+    /**
+     * @return string
+     */
+    protected function getLocalDescription() {
+        return 'deprecated';
+    }
+
+    /**
+     * @return array E.g.: `'ClassName' => 'oc version',`
+     */
+    protected function getLocalClasses() {
+        return [
+            'OC_JSON' => '8.2.0',
+
+            'OCP\Contacts' => '8.1.0',
+            'OCP\DB' => '8.1.0',
+            'OCP\JSON' => '8.1.0',
+            'OCP\Response' => '8.1.0',
+            'OCP\AppFramework\IApi' => '8.0.0',
+            'OCP\User' => '13.0.0',
+            'OCP\BackgroundJob' => '14.0.0',
+            'OCP\App' => '14.0.0',
+            'OCP\Files' => '14.0.0',
+        ];
+    }
+
+    /**
+     * @return array E.g.: `'ClassName::CONSTANT_NAME' => 'oc version',`
+     */
+    protected function getLocalConstants() {
+        return [
+            'OC_API::GUEST_AUTH' => '8.2.0',
+            'OC_API::USER_AUTH' => '8.2.0',
+            'OC_API::SUBADMIN_AUTH' => '8.2.0',
+            'OC_API::ADMIN_AUTH' => '8.2.0',
+            'OC_API::RESPOND_UNAUTHORISED' => '8.2.0',
+            'OC_API::RESPOND_SERVER_ERROR' => '8.2.0',
+            'OC_API::RESPOND_NOT_FOUND' => '8.2.0',
+            'OC_API::RESPOND_UNKNOWN_ERROR' => '8.2.0',
+
+            'OCP::PERMISSION_CREATE' => '8.0.0',
+            'OCP::PERMISSION_READ' => '8.0.0',
+            'OCP::PERMISSION_UPDATE' => '8.0.0',
+            'OCP::PERMISSION_DELETE' => '8.0.0',
+            'OCP::PERMISSION_SHARE' => '8.0.0',
+            'OCP::PERMISSION_ALL' => '8.0.0',
+            'OCP::FILENAME_INVALID_CHARS' => '8.0.0',
+        ];
+    }
+
+    /**
+     * @return array E.g.: `'functionName' => 'oc version',`
+     */
+    protected function getLocalFunctions() {
+        return [
+            'OCP::image_path' => '8.0.0',
+            'OCP::mimetype_icon' => '8.0.0',
+            'OCP::preview_icon' => '8.0.0',
+            'OCP::publicPreview_icon' => '8.0.0',
+            'OCP::human_file_size' => '8.0.0',
+            'OCP::relative_modified_date' => '8.0.0',
+            'OCP::simple_file_size' => '8.0.0',
+            'OCP::html_select_options' => '8.0.0',
+        ];
+    }
+
+    /**
+     * @return array E.g.: `'ClassName::methodName' => 'oc version',`
+     */
+    protected function getLocalMethods() {
+        return [
+            'OC_L10N::get' => '8.2.0',
+
+            'OCP\Activity\IManager::publishActivity' => '8.2.0',
+
+            'OCP\App::register' => '8.1.0',
+            'OCP\App::addNavigationEntry' => '8.1.0',
+            'OCP\App::getActiveNavigationEntry' => '8.2.0',
+            'OCP\App::setActiveNavigationEntry' => '8.1.0',
+            'OCP\App::registerPersonal' => '14.0.0',
+            'OCP\App::registerAdmin' => '14.0.0',
+            'OC_App::getAppInfo' => '14.0.0',
+            'OCP\App::getAppInfo' => '14.0.0',
+            'OC_App::getAppVersion' => '14.0.0',
+            'OCP\App::getAppVersion' => '14.0.0',
+            'OCP\App::registerPersonal' => '14.0.0',
+
+            'OCP\AppFramework\Controller::params' => '7.0.0',
+            'OCP\AppFramework\Controller::getParams' => '7.0.0',
+            'OCP\AppFramework\Controller::method' => '7.0.0',
+            'OCP\AppFramework\Controller::getUploadedFile' => '7.0.0',
+            'OCP\AppFramework\Controller::env' => '7.0.0',
+            'OCP\AppFramework\Controller::cookie' => '7.0.0',
+            'OCP\AppFramework\Controller::render' => '7.0.0',
+
+            'OCP\AppFramework\IAppContainer::getCoreApi' => '8.0.0',
+            'OCP\AppFramework\IAppContainer::isLoggedIn' => '8.0.0',
+            'OCP\AppFramework\IAppContainer::isAdminUser' => '8.0.0',
+            'OCP\AppFramework\IAppContainer::log' => '8.0.0',
+
+            'OCP\BackgroundJob::registerJob' => '8.1.0',
+            'OCP\BackgroundJob::getExecutionType' => '14.0.0',
+            'OCP\BackgroundJob::setExecutionType' => '14.0.0',
+
+            'OCP\Files::tmpFile' => '8.1.0',
+            'OCP\Files::tmpFolder' => '8.1.0',
+
+            'OCP\IAppConfig::getValue' => '8.0.0',
+            'OCP\IAppConfig::deleteKey' => '8.0.0',
+            'OCP\IAppConfig::getKeys' => '8.0.0',
+            'OCP\IAppConfig::setValue' => '8.0.0',
+            'OCP\IAppConfig::deleteApp' => '8.0.0',
+
+            'OCP\IDBConnection::createQueryBuilder' => '8.2.0',
+            'OCP\IDBConnection::getExpressionBuilder' => '8.2.0',
+
+            'OCP\ISearch::search' => '8.0.0',
+
+            'OCP\IServerContainer::getCache' => '8.2.0',
+            'OCP\IServerContainer::getDb' => '8.1.0',
+            'OCP\IServerContainer::getHTTPHelper' => '8.1.0',
+
+            'OCP\Response::disableCaching' => '14.0.0',
+
+            'OCP\User::getUser' => '8.0.0',
+            'OCP\User::getUsers' => '8.1.0',
+            'OCP\User::getDisplayName' => '8.1.0',
+            'OCP\User::getDisplayNames' => '8.1.0',
+            'OCP\User::userExists' => '8.1.0',
+            'OCP\User::logout' => '8.1.0',
+            'OCP\User::checkPassword' => '8.1.0',
+            'OCP\User::isLoggedIn' => '13.0.0',
+            'OCP\User::checkAdminUser' => '13.0.0',
+            'OCP\User::checkLoggedIn' => '13.0.0',
+
+            'OCP\Util::encryptedFiles' => '8.1.0',
+            'OCP\Util::formatDate' => '8.0.0',
+            'OCP\Util::generateRandomBytes' => '8.1.0',
+            'OCP\Util::getServerHost' => '8.1.0',
+            'OCP\Util::getServerProtocol' => '8.1.0',
+            'OCP\Util::getRequestUri' => '8.1.0',
+            'OCP\Util::getScriptName' => '8.1.0',
+            'OCP\Util::imagePath' => '8.1.0',
+            'OCP\Util::isValidFileName' => '8.1.0',
+            'OCP\Util::linkToRoute' => '8.1.0',
+            'OCP\Util::linkTo' => '8.1.0',
+            'OCP\Util::logException' => '8.2.0',
+            'OCP\Util::mb_str_replace' => '8.2.0',
+            'OCP\Util::mb_substr_replace' => '8.2.0',
+            'OCP\Util::sendMail' => '8.1.0',
+            'OCP\Util::writeLog' => '13.0.0',
+
+            'OCP\Files::rmdirr' => '14.0.0',
+            'OCP\Files::getMimeType' => '14.0.0',
+            'OCP\Files::searchByMime' => '14.0.0',
+            'OCP\Files::streamCopy' => '14.0.0',
+            'OCP\Files::buildNotExistingFileName' => '14.0.0',
+            'OCP\Files::getStorage' => '14.0.0',
+        ];
+    }
 }