nextcloud / server

lib/private/Search/SearchComposer.php

Indentation +302 added lines, -302 removed lines

@@ -51,306 +51,306 @@
  * @psalm-import-type CoreUnifiedSearchProvider from ResponseDefinitions
  */
 class SearchComposer {
-	/**
-	 * @var array<string, array{appId: string, provider: IProvider}>
-	 */
-	private array $providers = [];
-
-	private array $commonFilters;
-	private array $customFilters = [];
-
-	private array $handlers = [];
-
-	public function __construct(
-		private Coordinator $bootstrapCoordinator,
-		private ContainerInterface $container,
-		private IURLGenerator $urlGenerator,
-		private LoggerInterface $logger,
-		private IAppConfig $appConfig,
-	) {
-		$this->commonFilters = [
-			IFilter::BUILTIN_TERM => new FilterDefinition(IFilter::BUILTIN_TERM, FilterDefinition::TYPE_STRING),
-			IFilter::BUILTIN_SINCE => new FilterDefinition(IFilter::BUILTIN_SINCE, FilterDefinition::TYPE_DATETIME),
-			IFilter::BUILTIN_UNTIL => new FilterDefinition(IFilter::BUILTIN_UNTIL, FilterDefinition::TYPE_DATETIME),
-			IFilter::BUILTIN_TITLE_ONLY => new FilterDefinition(IFilter::BUILTIN_TITLE_ONLY, FilterDefinition::TYPE_BOOL, false),
-			IFilter::BUILTIN_PERSON => new FilterDefinition(IFilter::BUILTIN_PERSON, FilterDefinition::TYPE_PERSON),
-			IFilter::BUILTIN_PLACES => new FilterDefinition(IFilter::BUILTIN_PLACES, FilterDefinition::TYPE_STRINGS, false),
-			IFilter::BUILTIN_PROVIDER => new FilterDefinition(IFilter::BUILTIN_PROVIDER, FilterDefinition::TYPE_STRING, false),
-		];
-	}
-
-	/**
-	 * Load all providers dynamically that were registered through `registerProvider`
-	 *
-	 * If $targetProviderId is provided, only this provider is loaded
-	 * If a provider can't be loaded we log it but the operation continues nevertheless
-	 */
-	private function loadLazyProviders(?string $targetProviderId = null): void {
-		$context = $this->bootstrapCoordinator->getRegistrationContext();
-		if ($context === null) {
-			// Too early, nothing registered yet
-			return;
-		}
-
-		$registrations = $context->getSearchProviders();
-		foreach ($registrations as $registration) {
-			try {
-				/** @var IProvider $provider */
-				$provider = $this->container->get($registration->getService());
-				$providerId = $provider->getId();
-				if ($targetProviderId !== null && $targetProviderId !== $providerId) {
-					continue;
-				}
-				$this->providers[$providerId] = [
-					'appId' => $registration->getAppId(),
-					'provider' => $provider,
-				];
-				$this->handlers[$providerId] = [$providerId];
-				if ($targetProviderId !== null) {
-					break;
-				}
-			} catch (ContainerExceptionInterface $e) {
-				// Log an continue. We can be fault tolerant here.
-				$this->logger->error('Could not load search provider dynamically: ' . $e->getMessage(), [
-					'exception' => $e,
-					'app' => $registration->getAppId(),
-				]);
-			}
-		}
-
-		$this->filterProviders();
-
-		$this->loadFilters();
-	}
-
-	private function loadFilters(): void {
-		foreach ($this->providers as $providerId => $providerData) {
-			$appId = $providerData['appId'];
-			$provider = $providerData['provider'];
-			if (!$provider instanceof IFilteringProvider) {
-				continue;
-			}
-
-			foreach ($provider->getCustomFilters() as $filter) {
-				$this->registerCustomFilter($filter, $providerId);
-			}
-			foreach ($provider->getAlternateIds() as $alternateId) {
-				$this->handlers[$alternateId][] = $providerId;
-			}
-			foreach ($provider->getSupportedFilters() as $filterName) {
-				if ($this->getFilterDefinition($filterName, $providerId) === null) {
-					throw new InvalidArgumentException('Invalid filter ' . $filterName);
-				}
-			}
-		}
-	}
-
-	private function registerCustomFilter(FilterDefinition $filter, string $providerId): void {
-		$name = $filter->name();
-		if (isset($this->commonFilters[$name])) {
-			throw new InvalidArgumentException('Filter name is already used');
-		}
-
-		if (isset($this->customFilters[$providerId])) {
-			$this->customFilters[$providerId][$name] = $filter;
-		} else {
-			$this->customFilters[$providerId] = [$name => $filter];
-		}
-	}
-
-	/**
-	 * Get a list of all provider IDs & Names for the consecutive calls to `search`
-	 * Sort the list by the order property
-	 *
-	 * @param string $route the route the user is currently at
-	 * @param array $routeParameters the parameters of the route the user is currently at
-	 *
-	 * @return list<CoreUnifiedSearchProvider>
-	 */
-	public function getProviders(string $route, array $routeParameters): array {
-		$this->loadLazyProviders();
-
-		$providers = array_map(
-			function (array $providerData) use ($route, $routeParameters) {
-				$appId = $providerData['appId'];
-				$provider = $providerData['provider'];
-				$order = $provider->getOrder($route, $routeParameters);
-				if ($order === null) {
-					return;
-				}
-				$triggers = [$provider->getId()];
-				if ($provider instanceof IFilteringProvider) {
-					$triggers += $provider->getAlternateIds();
-					$filters = $provider->getSupportedFilters();
-				} else {
-					$filters = [IFilter::BUILTIN_TERM];
-				}
-
-				return [
-					'id' => $provider->getId(),
-					'appId' => $appId,
-					'name' => $provider->getName(),
-					'icon' => $this->fetchIcon($appId, $provider->getId()),
-					'order' => $order,
-					'triggers' => array_values($triggers),
-					'filters' => $this->getFiltersType($filters, $provider->getId()),
-					'inAppSearch' => $provider instanceof IInAppSearch,
-				];
-			},
-			$this->providers,
-		);
-		$providers = array_filter($providers);
-
-		// Sort providers by order and strip associative keys
-		usort($providers, function ($provider1, $provider2) {
-			return $provider1['order'] <=> $provider2['order'];
-		});
-
-		return $providers;
-	}
-
-	/**
-	 * Filter providers based on 'unified_search.providers_allowed' core app config array
-	 * Will remove providers that are not in the allowed list
-	 */
-	private function filterProviders(): void {
-		$allowedProviders = $this->appConfig->getValueArray('core', 'unified_search.providers_allowed');
-
-		if (empty($allowedProviders)) {
-			return;
-		}
-
-		foreach (array_keys($this->providers) as $providerId) {
-			if (!in_array($providerId, $allowedProviders, true)) {
-				unset($this->providers[$providerId]);
-				unset($this->handlers[$providerId]);
-			}
-		}
-	}
-
-	private function fetchIcon(string $appId, string $providerId): string {
-		$icons = [
-			[$providerId, $providerId . '.svg'],
-			[$providerId, 'app.svg'],
-			[$appId, $providerId . '.svg'],
-			[$appId, $appId . '.svg'],
-			[$appId, 'app.svg'],
-			['core', 'places/default-app-icon.svg'],
-		];
-		if ($appId === 'settings' && $providerId === 'users') {
-			// Conflict:
-			// the file /apps/settings/users.svg is already used in black version by top right user menu
-			// Override icon name here
-			$icons = [['settings', 'users-white.svg']];
-		}
-		foreach ($icons as $i => $icon) {
-			try {
-				return $this->urlGenerator->imagePath(... $icon);
-			} catch (RuntimeException $e) {
-				// Ignore error
-			}
-		}
-
-		return '';
-	}
-
-	/**
-	 * @param $filters string[]
-	 * @return array<string, string>
-	 */
-	private function getFiltersType(array $filters, string $providerId): array {
-		$filterList = [];
-		foreach ($filters as $filter) {
-			$filterList[$filter] = $this->getFilterDefinition($filter, $providerId)->type();
-		}
-
-		return $filterList;
-	}
-
-	private function getFilterDefinition(string $name, string $providerId): ?FilterDefinition {
-		if (isset($this->commonFilters[$name])) {
-			return $this->commonFilters[$name];
-		}
-		if (isset($this->customFilters[$providerId][$name])) {
-			return $this->customFilters[$providerId][$name];
-		}
-
-		return null;
-	}
-
-	/**
-	 * @param array<string, string> $parameters
-	 */
-	public function buildFilterList(string $providerId, array $parameters): FilterCollection {
-		$this->loadLazyProviders($providerId);
-
-		$list = [];
-		foreach ($parameters as $name => $value) {
-			$filter = $this->buildFilter($name, $value, $providerId);
-			if ($filter === null) {
-				continue;
-			}
-			$list[$name] = $filter;
-		}
-
-		return new FilterCollection(... $list);
-	}
-
-	private function buildFilter(string $name, string $value, string $providerId): ?IFilter {
-		$filterDefinition = $this->getFilterDefinition($name, $providerId);
-		if ($filterDefinition === null) {
-			$this->logger->debug('Unable to find {name} definition', [
-				'name' => $name,
-				'value' => $value,
-			]);
-
-			return null;
-		}
-
-		if (!$this->filterSupportedByProvider($filterDefinition, $providerId)) {
-			// FIXME Use dedicated exception and handle it
-			throw new UnsupportedFilter($name, $providerId);
-		}
-
-		return FilterFactory::get($filterDefinition->type(), $value);
-	}
-
-	private function filterSupportedByProvider(FilterDefinition $filterDefinition, string $providerId): bool {
-		// Non exclusive filters can be ommited by apps
-		if (!$filterDefinition->exclusive()) {
-			return true;
-		}
-
-		$provider = $this->providers[$providerId]['provider'];
-		$supportedFilters = $provider instanceof IFilteringProvider
-			? $provider->getSupportedFilters()
-			: [IFilter::BUILTIN_TERM];
-
-		return in_array($filterDefinition->name(), $supportedFilters, true);
-	}
-
-	/**
-	 * Query an individual search provider for results
-	 *
-	 * @param IUser $user
-	 * @param string $providerId one of the IDs received by `getProviders`
-	 * @param ISearchQuery $query
-	 *
-	 * @return SearchResult
-	 * @throws InvalidArgumentException when the $providerId does not correspond to a registered provider
-	 */
-	public function search(
-		IUser $user,
-		string $providerId,
-		ISearchQuery $query,
-	): SearchResult {
-		$this->loadLazyProviders($providerId);
-
-		$provider = $this->providers[$providerId]['provider'] ?? null;
-		if ($provider === null) {
-			throw new InvalidArgumentException("Provider $providerId is unknown");
-		}
-
-		return $provider->search($user, $query);
-	}
+    /**
+     * @var array<string, array{appId: string, provider: IProvider}>
+     */
+    private array $providers = [];
+
+    private array $commonFilters;
+    private array $customFilters = [];
+
+    private array $handlers = [];
+
+    public function __construct(
+        private Coordinator $bootstrapCoordinator,
+        private ContainerInterface $container,
+        private IURLGenerator $urlGenerator,
+        private LoggerInterface $logger,
+        private IAppConfig $appConfig,
+    ) {
+        $this->commonFilters = [
+            IFilter::BUILTIN_TERM => new FilterDefinition(IFilter::BUILTIN_TERM, FilterDefinition::TYPE_STRING),
+            IFilter::BUILTIN_SINCE => new FilterDefinition(IFilter::BUILTIN_SINCE, FilterDefinition::TYPE_DATETIME),
+            IFilter::BUILTIN_UNTIL => new FilterDefinition(IFilter::BUILTIN_UNTIL, FilterDefinition::TYPE_DATETIME),
+            IFilter::BUILTIN_TITLE_ONLY => new FilterDefinition(IFilter::BUILTIN_TITLE_ONLY, FilterDefinition::TYPE_BOOL, false),
+            IFilter::BUILTIN_PERSON => new FilterDefinition(IFilter::BUILTIN_PERSON, FilterDefinition::TYPE_PERSON),
+            IFilter::BUILTIN_PLACES => new FilterDefinition(IFilter::BUILTIN_PLACES, FilterDefinition::TYPE_STRINGS, false),
+            IFilter::BUILTIN_PROVIDER => new FilterDefinition(IFilter::BUILTIN_PROVIDER, FilterDefinition::TYPE_STRING, false),
+        ];
+    }
+
+    /**
+     * Load all providers dynamically that were registered through `registerProvider`
+     *
+     * If $targetProviderId is provided, only this provider is loaded
+     * If a provider can't be loaded we log it but the operation continues nevertheless
+     */
+    private function loadLazyProviders(?string $targetProviderId = null): void {
+        $context = $this->bootstrapCoordinator->getRegistrationContext();
+        if ($context === null) {
+            // Too early, nothing registered yet
+            return;
+        }
+
+        $registrations = $context->getSearchProviders();
+        foreach ($registrations as $registration) {
+            try {
+                /** @var IProvider $provider */
+                $provider = $this->container->get($registration->getService());
+                $providerId = $provider->getId();
+                if ($targetProviderId !== null && $targetProviderId !== $providerId) {
+                    continue;
+                }
+                $this->providers[$providerId] = [
+                    'appId' => $registration->getAppId(),
+                    'provider' => $provider,
+                ];
+                $this->handlers[$providerId] = [$providerId];
+                if ($targetProviderId !== null) {
+                    break;
+                }
+            } catch (ContainerExceptionInterface $e) {
+                // Log an continue. We can be fault tolerant here.
+                $this->logger->error('Could not load search provider dynamically: ' . $e->getMessage(), [
+                    'exception' => $e,
+                    'app' => $registration->getAppId(),
+                ]);
+            }
+        }
+
+        $this->filterProviders();
+
+        $this->loadFilters();
+    }
+
+    private function loadFilters(): void {
+        foreach ($this->providers as $providerId => $providerData) {
+            $appId = $providerData['appId'];
+            $provider = $providerData['provider'];
+            if (!$provider instanceof IFilteringProvider) {
+                continue;
+            }
+
+            foreach ($provider->getCustomFilters() as $filter) {
+                $this->registerCustomFilter($filter, $providerId);
+            }
+            foreach ($provider->getAlternateIds() as $alternateId) {
+                $this->handlers[$alternateId][] = $providerId;
+            }
+            foreach ($provider->getSupportedFilters() as $filterName) {
+                if ($this->getFilterDefinition($filterName, $providerId) === null) {
+                    throw new InvalidArgumentException('Invalid filter ' . $filterName);
+                }
+            }
+        }
+    }
+
+    private function registerCustomFilter(FilterDefinition $filter, string $providerId): void {
+        $name = $filter->name();
+        if (isset($this->commonFilters[$name])) {
+            throw new InvalidArgumentException('Filter name is already used');
+        }
+
+        if (isset($this->customFilters[$providerId])) {
+            $this->customFilters[$providerId][$name] = $filter;
+        } else {
+            $this->customFilters[$providerId] = [$name => $filter];
+        }
+    }
+
+    /**
+     * Get a list of all provider IDs & Names for the consecutive calls to `search`
+     * Sort the list by the order property
+     *
+     * @param string $route the route the user is currently at
+     * @param array $routeParameters the parameters of the route the user is currently at
+     *
+     * @return list<CoreUnifiedSearchProvider>
+     */
+    public function getProviders(string $route, array $routeParameters): array {
+        $this->loadLazyProviders();
+
+        $providers = array_map(
+            function (array $providerData) use ($route, $routeParameters) {
+                $appId = $providerData['appId'];
+                $provider = $providerData['provider'];
+                $order = $provider->getOrder($route, $routeParameters);
+                if ($order === null) {
+                    return;
+                }
+                $triggers = [$provider->getId()];
+                if ($provider instanceof IFilteringProvider) {
+                    $triggers += $provider->getAlternateIds();
+                    $filters = $provider->getSupportedFilters();
+                } else {
+                    $filters = [IFilter::BUILTIN_TERM];
+                }
+
+                return [
+                    'id' => $provider->getId(),
+                    'appId' => $appId,
+                    'name' => $provider->getName(),
+                    'icon' => $this->fetchIcon($appId, $provider->getId()),
+                    'order' => $order,
+                    'triggers' => array_values($triggers),
+                    'filters' => $this->getFiltersType($filters, $provider->getId()),
+                    'inAppSearch' => $provider instanceof IInAppSearch,
+                ];
+            },
+            $this->providers,
+        );
+        $providers = array_filter($providers);
+
+        // Sort providers by order and strip associative keys
+        usort($providers, function ($provider1, $provider2) {
+            return $provider1['order'] <=> $provider2['order'];
+        });
+
+        return $providers;
+    }
+
+    /**
+     * Filter providers based on 'unified_search.providers_allowed' core app config array
+     * Will remove providers that are not in the allowed list
+     */
+    private function filterProviders(): void {
+        $allowedProviders = $this->appConfig->getValueArray('core', 'unified_search.providers_allowed');
+
+        if (empty($allowedProviders)) {
+            return;
+        }
+
+        foreach (array_keys($this->providers) as $providerId) {
+            if (!in_array($providerId, $allowedProviders, true)) {
+                unset($this->providers[$providerId]);
+                unset($this->handlers[$providerId]);
+            }
+        }
+    }
+
+    private function fetchIcon(string $appId, string $providerId): string {
+        $icons = [
+            [$providerId, $providerId . '.svg'],
+            [$providerId, 'app.svg'],
+            [$appId, $providerId . '.svg'],
+            [$appId, $appId . '.svg'],
+            [$appId, 'app.svg'],
+            ['core', 'places/default-app-icon.svg'],
+        ];
+        if ($appId === 'settings' && $providerId === 'users') {
+            // Conflict:
+            // the file /apps/settings/users.svg is already used in black version by top right user menu
+            // Override icon name here
+            $icons = [['settings', 'users-white.svg']];
+        }
+        foreach ($icons as $i => $icon) {
+            try {
+                return $this->urlGenerator->imagePath(... $icon);
+            } catch (RuntimeException $e) {
+                // Ignore error
+            }
+        }
+
+        return '';
+    }
+
+    /**
+     * @param $filters string[]
+     * @return array<string, string>
+     */
+    private function getFiltersType(array $filters, string $providerId): array {
+        $filterList = [];
+        foreach ($filters as $filter) {
+            $filterList[$filter] = $this->getFilterDefinition($filter, $providerId)->type();
+        }
+
+        return $filterList;
+    }
+
+    private function getFilterDefinition(string $name, string $providerId): ?FilterDefinition {
+        if (isset($this->commonFilters[$name])) {
+            return $this->commonFilters[$name];
+        }
+        if (isset($this->customFilters[$providerId][$name])) {
+            return $this->customFilters[$providerId][$name];
+        }
+
+        return null;
+    }
+
+    /**
+     * @param array<string, string> $parameters
+     */
+    public function buildFilterList(string $providerId, array $parameters): FilterCollection {
+        $this->loadLazyProviders($providerId);
+
+        $list = [];
+        foreach ($parameters as $name => $value) {
+            $filter = $this->buildFilter($name, $value, $providerId);
+            if ($filter === null) {
+                continue;
+            }
+            $list[$name] = $filter;
+        }
+
+        return new FilterCollection(... $list);
+    }
+
+    private function buildFilter(string $name, string $value, string $providerId): ?IFilter {
+        $filterDefinition = $this->getFilterDefinition($name, $providerId);
+        if ($filterDefinition === null) {
+            $this->logger->debug('Unable to find {name} definition', [
+                'name' => $name,
+                'value' => $value,
+            ]);
+
+            return null;
+        }
+
+        if (!$this->filterSupportedByProvider($filterDefinition, $providerId)) {
+            // FIXME Use dedicated exception and handle it
+            throw new UnsupportedFilter($name, $providerId);
+        }
+
+        return FilterFactory::get($filterDefinition->type(), $value);
+    }
+
+    private function filterSupportedByProvider(FilterDefinition $filterDefinition, string $providerId): bool {
+        // Non exclusive filters can be ommited by apps
+        if (!$filterDefinition->exclusive()) {
+            return true;
+        }
+
+        $provider = $this->providers[$providerId]['provider'];
+        $supportedFilters = $provider instanceof IFilteringProvider
+            ? $provider->getSupportedFilters()
+            : [IFilter::BUILTIN_TERM];
+
+        return in_array($filterDefinition->name(), $supportedFilters, true);
+    }
+
+    /**
+     * Query an individual search provider for results
+     *
+     * @param IUser $user
+     * @param string $providerId one of the IDs received by `getProviders`
+     * @param ISearchQuery $query
+     *
+     * @return SearchResult
+     * @throws InvalidArgumentException when the $providerId does not correspond to a registered provider
+     */
+    public function search(
+        IUser $user,
+        string $providerId,
+        ISearchQuery $query,
+    ): SearchResult {
+        $this->loadLazyProviders($providerId);
+
+        $provider = $this->providers[$providerId]['provider'] ?? null;
+        if ($provider === null) {
+            throw new InvalidArgumentException("Provider $providerId is unknown");
+        }
+
+        return $provider->search($user, $query);
+    }
 }

Spacing +7 added lines, -7 removed lines

@@ -111,7 +111,7 @@ 
 				}
 			} catch (ContainerExceptionInterface $e) {
 				// Log an continue. We can be fault tolerant here.
-				$this->logger->error('Could not load search provider dynamically: ' . $e->getMessage(), [
+				$this->logger->error('Could not load search provider dynamically: '.$e->getMessage(), [
 					'exception' => $e,
 					'app' => $registration->getAppId(),
 				]);
@@ -139,7 +139,7 @@ 
 			}
 			foreach ($provider->getSupportedFilters() as $filterName) {
 				if ($this->getFilterDefinition($filterName, $providerId) === null) {
-					throw new InvalidArgumentException('Invalid filter ' . $filterName);
+					throw new InvalidArgumentException('Invalid filter '.$filterName);
 				}
 			}
 		}
@@ -171,7 +171,7 @@ 
 		$this->loadLazyProviders();
 
 		$providers = array_map(
-			function (array $providerData) use ($route, $routeParameters) {
+			function(array $providerData) use ($route, $routeParameters) {
 				$appId = $providerData['appId'];
 				$provider = $providerData['provider'];
 				$order = $provider->getOrder($route, $routeParameters);
@@ -202,7 +202,7 @@ 
 		$providers = array_filter($providers);
 
 		// Sort providers by order and strip associative keys
-		usort($providers, function ($provider1, $provider2) {
+		usort($providers, function($provider1, $provider2) {
 			return $provider1['order'] <=> $provider2['order'];
 		});
 
@@ -230,10 +230,10 @@ 
 
 	private function fetchIcon(string $appId, string $providerId): string {
 		$icons = [
-			[$providerId, $providerId . '.svg'],
+			[$providerId, $providerId.'.svg'],
 			[$providerId, 'app.svg'],
-			[$appId, $providerId . '.svg'],
-			[$appId, $appId . '.svg'],
+			[$appId, $providerId.'.svg'],
+			[$appId, $appId.'.svg'],
 			[$appId, 'app.svg'],
 			['core', 'places/default-app-icon.svg'],
 		];

tests/lib/Search/SearchComposerTest.php

Indentation +261 added lines, -261 removed lines

@@ -26,265 +26,265 @@
 use Test\TestCase;
 
 class SearchComposerTest extends TestCase {
-	private Coordinator&MockObject $bootstrapCoordinator;
-	private ContainerInterface&MockObject $container;
-	private IURLGenerator&MockObject $urlGenerator;
-	private LoggerInterface&MockObject $logger;
-	private IAppConfig&MockObject $appConfig;
-	private SearchComposer $searchComposer;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->bootstrapCoordinator = $this->createMock(Coordinator::class);
-		$this->container = $this->createMock(ContainerInterface::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->appConfig = $this->createMock(IAppConfig::class);
-
-		$this->searchComposer = new SearchComposer(
-			$this->bootstrapCoordinator,
-			$this->container,
-			$this->urlGenerator,
-			$this->logger,
-			$this->appConfig
-		);
-
-		$this->setupUrlGenerator();
-	}
-
-	private function setupUrlGenerator(): void {
-		$this->urlGenerator->method('imagePath')
-			->willReturnCallback(function ($appId, $imageName) {
-				return "/apps/$appId/img/$imageName";
-			});
-	}
-
-	private function setupEmptyRegistrationContext(): void {
-		$this->bootstrapCoordinator->expects($this->once())
-			->method('getRegistrationContext')
-			->willReturn(null);
-	}
-
-	private function setupAppConfigForAllowedProviders(array $allowedProviders = []): void {
-		$this->appConfig->method('getValueArray')
-			->with('core', 'unified_search.providers_allowed')
-			->willReturn($allowedProviders);
-	}
-
-	/**
-	 * @param array<string, array{service: string, appId: string, order: int, isInApp?: bool}> $providerConfigs
-	 * @return array{registrations: ServiceRegistration[], providers: IProvider[]}
-	 */
-	private function createMockProvidersAndRegistrations(array $providerConfigs): array {
-		$registrations = [];
-		$providers = [];
-		$containerMap = [];
-
-		foreach ($providerConfigs as $providerId => $config) {
-			// Create registration mock
-			$registration = $this->createMock(ServiceRegistration::class);
-			$registration->method('getService')->willReturn($config['service']);
-			$registration->method('getAppId')->willReturn($config['appId']);
-			$registrations[] = $registration;
-
-			// Create provider mock
-			$providerClass = $config['isInApp'] ?? false ? IInAppSearch::class : IProvider::class;
-			$provider = $this->createMock($providerClass);
-			$provider->method('getId')->willReturn($providerId);
-			$provider->method('getName')->willReturn("Provider $providerId");
-			$provider->method('getOrder')->willReturn($config['order']);
-
-			$providers[$providerId] = $provider;
-			$containerMap[] = [$config['service'], $provider];
-		}
-
-		$this->container->expects($this->exactly(count($providerConfigs)))
-			->method('get')
-			->willReturnMap($containerMap);
-
-		return ['registrations' => $registrations, 'providers' => $providers];
-	}
-
-	private function setupRegistrationContextWithProviders(array $registrations): void {
-		$registrationContext = $this->createMock(RegistrationContext::class);
-		$registrationContext->method('getSearchProviders')->willReturn($registrations);
-
-		$this->bootstrapCoordinator->expects($this->once())
-			->method('getRegistrationContext')
-			->willReturn($registrationContext);
-	}
-
-	public function testGetProvidersWithNoRegisteredProviders(): void {
-		$this->setupEmptyRegistrationContext();
-
-		$providers = $this->searchComposer->getProviders('/test/route', []);
-
-		$this->assertIsArray($providers);
-		$this->assertEmpty($providers);
-	}
-
-	public function testSearchWithUnknownProvider(): void {
-		$this->setupEmptyRegistrationContext();
-
-		$user = $this->createMock(IUser::class);
-		$query = $this->createMock(ISearchQuery::class);
-
-		$this->expectException(InvalidArgumentException::class);
-		$this->expectExceptionMessage('Provider unknown_provider is unknown');
-
-		$this->searchComposer->search($user, 'unknown_provider', $query);
-	}
-
-	public function testGetProvidersWithMultipleProviders(): void {
-		$providerConfigs = [
-			'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
-			'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 5],
-			'provider3' => ['service' => 'provider3_service', 'appId' => 'app3', 'order' => 15, 'isInApp' => true],
-		];
-
-		$mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
-		$this->setupRegistrationContextWithProviders($mockData['registrations']);
-		$this->setupAppConfigForAllowedProviders();
-
-		$providers = $this->searchComposer->getProviders('/test/route', []);
-
-		$this->assertProvidersStructureAndSorting($providers, [
-			['id' => 'provider2', 'name' => 'Provider provider2', 'appId' => 'app2', 'order' => 5, 'inAppSearch' => false],
-			['id' => 'provider1', 'name' => 'Provider provider1', 'appId' => 'app1', 'order' => 10, 'inAppSearch' => false],
-			['id' => 'provider3', 'name' => 'Provider provider3', 'appId' => 'app3', 'order' => 15, 'inAppSearch' => true],
-		]);
-	}
-
-	public function testGetProvidersWithEmptyAllowedProvidersConfiguration(): void {
-		$providerConfigs = [
-			'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
-			'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 5],
-		];
-
-		$mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
-		$this->setupRegistrationContextWithProviders($mockData['registrations']);
-		$this->setupAppConfigForAllowedProviders();
-
-		$providers = $this->searchComposer->getProviders('/test/route', []);
-
-		$this->assertCount(2, $providers);
-		$this->assertProvidersAreSortedByOrder($providers);
-		$this->assertEquals('provider2', $providers[0]['id']);
-		$this->assertEquals('provider1', $providers[1]['id']);
-	}
-
-	public function testGetProvidersWithAllowedProvidersRestriction(): void {
-		$providerConfigs = [
-			'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
-			'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 5],
-			'provider3' => ['service' => 'provider3_service', 'appId' => 'app3', 'order' => 15],
-			'provider4' => ['service' => 'provider4_service', 'appId' => 'app4', 'order' => 8],
-		];
-
-		$mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
-		$this->setupRegistrationContextWithProviders($mockData['registrations']);
-		$this->setupAppConfigForAllowedProviders(['provider1', 'provider3']);
-
-		$providers = $this->searchComposer->getProviders('/test/route', []);
-
-		$this->assertProvidersStructureAndSorting($providers, [
-			['id' => 'provider1', 'name' => 'Provider provider1', 'appId' => 'app1', 'order' => 10, 'inAppSearch' => false],
-			['id' => 'provider3', 'name' => 'Provider provider3', 'appId' => 'app3', 'order' => 15, 'inAppSearch' => false],
-		]);
-
-		// Verify excluded providers are not present
-		$providerIds = array_column($providers, 'id');
-		$this->assertNotContains('provider2', $providerIds);
-		$this->assertNotContains('provider4', $providerIds);
-	}
-
-	public function testGetProvidersFiltersByAllowedProvidersCompletely(): void {
-		$providerConfigs = [
-			'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
-			'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 5],
-		];
-
-		$mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
-		$this->setupRegistrationContextWithProviders($mockData['registrations']);
-		$this->setupAppConfigForAllowedProviders(['provider_not_exists']);
-
-		$providers = $this->searchComposer->getProviders('/test/route', []);
-
-		$this->assertIsArray($providers);
-		$this->assertEmpty($providers);
-	}
-
-	public function testGetProvidersWithMixedOrderValues(): void {
-		$providerConfigs = [
-			'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 100],
-			'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 1],
-			'provider3' => ['service' => 'provider3_service', 'appId' => 'app3', 'order' => 50],
-		];
-
-		$mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
-		$this->setupRegistrationContextWithProviders($mockData['registrations']);
-		$this->setupAppConfigForAllowedProviders();
-
-		$providers = $this->searchComposer->getProviders('/test/route', []);
-
-		$this->assertCount(3, $providers);
-		$this->assertProvidersAreSortedByOrder($providers);
-
-		// Verify correct ordering: provider2 (1), provider3 (50), provider1 (100)
-		$this->assertEquals('provider2', $providers[0]['id']);
-		$this->assertEquals('provider3', $providers[1]['id']);
-		$this->assertEquals('provider1', $providers[2]['id']);
-	}
-
-	public function testProviderIconGeneration(): void {
-		$providerConfigs = [
-			'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
-		];
-
-		$mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
-		$this->setupRegistrationContextWithProviders($mockData['registrations']);
-		$this->setupAppConfigForAllowedProviders();
-
-		$providers = $this->searchComposer->getProviders('/test/route', []);
-
-		$this->assertCount(1, $providers);
-		$this->assertArrayHasKey('icon', $providers[0]);
-		$this->assertStringContainsString('/apps/provider1/img/provider1.svg', $providers[0]['icon']);
-	}
-
-	/**
-	 * Assert providers array structure and expected sorting
-	 */
-	private function assertProvidersStructureAndSorting(array $actualProviders, array $expectedProviders): void {
-		$this->assertIsArray($actualProviders);
-		$this->assertCount(count($expectedProviders), $actualProviders);
-
-		foreach ($actualProviders as $index => $provider) {
-			$this->assertProviderHasRequiredFields($provider);
-
-			$expected = $expectedProviders[$index];
-			$this->assertEquals($expected['id'], $provider['id']);
-			$this->assertEquals($expected['name'], $provider['name']);
-			$this->assertEquals($expected['appId'], $provider['appId']);
-			$this->assertEquals($expected['order'], $provider['order']);
-			$this->assertEquals($expected['inAppSearch'], $provider['inAppSearch']);
-		}
-
-		$this->assertProvidersAreSortedByOrder($actualProviders);
-	}
-
-	private function assertProviderHasRequiredFields(array $provider): void {
-		$requiredFields = ['id', 'appId', 'name', 'icon', 'order', 'triggers', 'filters', 'inAppSearch'];
-		foreach ($requiredFields as $field) {
-			$this->assertArrayHasKey($field, $provider, "Provider must have '$field' field");
-		}
-	}
-
-	private function assertProvidersAreSortedByOrder(array $providers): void {
-		$orders = array_column($providers, 'order');
-		$sortedOrders = $orders;
-		sort($sortedOrders);
-		$this->assertEquals($sortedOrders, $orders, 'Providers should be sorted by order');
-	}
+    private Coordinator&MockObject $bootstrapCoordinator;
+    private ContainerInterface&MockObject $container;
+    private IURLGenerator&MockObject $urlGenerator;
+    private LoggerInterface&MockObject $logger;
+    private IAppConfig&MockObject $appConfig;
+    private SearchComposer $searchComposer;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->bootstrapCoordinator = $this->createMock(Coordinator::class);
+        $this->container = $this->createMock(ContainerInterface::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->appConfig = $this->createMock(IAppConfig::class);
+
+        $this->searchComposer = new SearchComposer(
+            $this->bootstrapCoordinator,
+            $this->container,
+            $this->urlGenerator,
+            $this->logger,
+            $this->appConfig
+        );
+
+        $this->setupUrlGenerator();
+    }
+
+    private function setupUrlGenerator(): void {
+        $this->urlGenerator->method('imagePath')
+            ->willReturnCallback(function ($appId, $imageName) {
+                return "/apps/$appId/img/$imageName";
+            });
+    }
+
+    private function setupEmptyRegistrationContext(): void {
+        $this->bootstrapCoordinator->expects($this->once())
+            ->method('getRegistrationContext')
+            ->willReturn(null);
+    }
+
+    private function setupAppConfigForAllowedProviders(array $allowedProviders = []): void {
+        $this->appConfig->method('getValueArray')
+            ->with('core', 'unified_search.providers_allowed')
+            ->willReturn($allowedProviders);
+    }
+
+    /**
+     * @param array<string, array{service: string, appId: string, order: int, isInApp?: bool}> $providerConfigs
+     * @return array{registrations: ServiceRegistration[], providers: IProvider[]}
+     */
+    private function createMockProvidersAndRegistrations(array $providerConfigs): array {
+        $registrations = [];
+        $providers = [];
+        $containerMap = [];
+
+        foreach ($providerConfigs as $providerId => $config) {
+            // Create registration mock
+            $registration = $this->createMock(ServiceRegistration::class);
+            $registration->method('getService')->willReturn($config['service']);
+            $registration->method('getAppId')->willReturn($config['appId']);
+            $registrations[] = $registration;
+
+            // Create provider mock
+            $providerClass = $config['isInApp'] ?? false ? IInAppSearch::class : IProvider::class;
+            $provider = $this->createMock($providerClass);
+            $provider->method('getId')->willReturn($providerId);
+            $provider->method('getName')->willReturn("Provider $providerId");
+            $provider->method('getOrder')->willReturn($config['order']);
+
+            $providers[$providerId] = $provider;
+            $containerMap[] = [$config['service'], $provider];
+        }
+
+        $this->container->expects($this->exactly(count($providerConfigs)))
+            ->method('get')
+            ->willReturnMap($containerMap);
+
+        return ['registrations' => $registrations, 'providers' => $providers];
+    }
+
+    private function setupRegistrationContextWithProviders(array $registrations): void {
+        $registrationContext = $this->createMock(RegistrationContext::class);
+        $registrationContext->method('getSearchProviders')->willReturn($registrations);
+
+        $this->bootstrapCoordinator->expects($this->once())
+            ->method('getRegistrationContext')
+            ->willReturn($registrationContext);
+    }
+
+    public function testGetProvidersWithNoRegisteredProviders(): void {
+        $this->setupEmptyRegistrationContext();
+
+        $providers = $this->searchComposer->getProviders('/test/route', []);
+
+        $this->assertIsArray($providers);
+        $this->assertEmpty($providers);
+    }
+
+    public function testSearchWithUnknownProvider(): void {
+        $this->setupEmptyRegistrationContext();
+
+        $user = $this->createMock(IUser::class);
+        $query = $this->createMock(ISearchQuery::class);
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Provider unknown_provider is unknown');
+
+        $this->searchComposer->search($user, 'unknown_provider', $query);
+    }
+
+    public function testGetProvidersWithMultipleProviders(): void {
+        $providerConfigs = [
+            'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
+            'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 5],
+            'provider3' => ['service' => 'provider3_service', 'appId' => 'app3', 'order' => 15, 'isInApp' => true],
+        ];
+
+        $mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
+        $this->setupRegistrationContextWithProviders($mockData['registrations']);
+        $this->setupAppConfigForAllowedProviders();
+
+        $providers = $this->searchComposer->getProviders('/test/route', []);
+
+        $this->assertProvidersStructureAndSorting($providers, [
+            ['id' => 'provider2', 'name' => 'Provider provider2', 'appId' => 'app2', 'order' => 5, 'inAppSearch' => false],
+            ['id' => 'provider1', 'name' => 'Provider provider1', 'appId' => 'app1', 'order' => 10, 'inAppSearch' => false],
+            ['id' => 'provider3', 'name' => 'Provider provider3', 'appId' => 'app3', 'order' => 15, 'inAppSearch' => true],
+        ]);
+    }
+
+    public function testGetProvidersWithEmptyAllowedProvidersConfiguration(): void {
+        $providerConfigs = [
+            'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
+            'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 5],
+        ];
+
+        $mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
+        $this->setupRegistrationContextWithProviders($mockData['registrations']);
+        $this->setupAppConfigForAllowedProviders();
+
+        $providers = $this->searchComposer->getProviders('/test/route', []);
+
+        $this->assertCount(2, $providers);
+        $this->assertProvidersAreSortedByOrder($providers);
+        $this->assertEquals('provider2', $providers[0]['id']);
+        $this->assertEquals('provider1', $providers[1]['id']);
+    }
+
+    public function testGetProvidersWithAllowedProvidersRestriction(): void {
+        $providerConfigs = [
+            'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
+            'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 5],
+            'provider3' => ['service' => 'provider3_service', 'appId' => 'app3', 'order' => 15],
+            'provider4' => ['service' => 'provider4_service', 'appId' => 'app4', 'order' => 8],
+        ];
+
+        $mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
+        $this->setupRegistrationContextWithProviders($mockData['registrations']);
+        $this->setupAppConfigForAllowedProviders(['provider1', 'provider3']);
+
+        $providers = $this->searchComposer->getProviders('/test/route', []);
+
+        $this->assertProvidersStructureAndSorting($providers, [
+            ['id' => 'provider1', 'name' => 'Provider provider1', 'appId' => 'app1', 'order' => 10, 'inAppSearch' => false],
+            ['id' => 'provider3', 'name' => 'Provider provider3', 'appId' => 'app3', 'order' => 15, 'inAppSearch' => false],
+        ]);
+
+        // Verify excluded providers are not present
+        $providerIds = array_column($providers, 'id');
+        $this->assertNotContains('provider2', $providerIds);
+        $this->assertNotContains('provider4', $providerIds);
+    }
+
+    public function testGetProvidersFiltersByAllowedProvidersCompletely(): void {
+        $providerConfigs = [
+            'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
+            'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 5],
+        ];
+
+        $mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
+        $this->setupRegistrationContextWithProviders($mockData['registrations']);
+        $this->setupAppConfigForAllowedProviders(['provider_not_exists']);
+
+        $providers = $this->searchComposer->getProviders('/test/route', []);
+
+        $this->assertIsArray($providers);
+        $this->assertEmpty($providers);
+    }
+
+    public function testGetProvidersWithMixedOrderValues(): void {
+        $providerConfigs = [
+            'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 100],
+            'provider2' => ['service' => 'provider2_service', 'appId' => 'app2', 'order' => 1],
+            'provider3' => ['service' => 'provider3_service', 'appId' => 'app3', 'order' => 50],
+        ];
+
+        $mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
+        $this->setupRegistrationContextWithProviders($mockData['registrations']);
+        $this->setupAppConfigForAllowedProviders();
+
+        $providers = $this->searchComposer->getProviders('/test/route', []);
+
+        $this->assertCount(3, $providers);
+        $this->assertProvidersAreSortedByOrder($providers);
+
+        // Verify correct ordering: provider2 (1), provider3 (50), provider1 (100)
+        $this->assertEquals('provider2', $providers[0]['id']);
+        $this->assertEquals('provider3', $providers[1]['id']);
+        $this->assertEquals('provider1', $providers[2]['id']);
+    }
+
+    public function testProviderIconGeneration(): void {
+        $providerConfigs = [
+            'provider1' => ['service' => 'provider1_service', 'appId' => 'app1', 'order' => 10],
+        ];
+
+        $mockData = $this->createMockProvidersAndRegistrations($providerConfigs);
+        $this->setupRegistrationContextWithProviders($mockData['registrations']);
+        $this->setupAppConfigForAllowedProviders();
+
+        $providers = $this->searchComposer->getProviders('/test/route', []);
+
+        $this->assertCount(1, $providers);
+        $this->assertArrayHasKey('icon', $providers[0]);
+        $this->assertStringContainsString('/apps/provider1/img/provider1.svg', $providers[0]['icon']);
+    }
+
+    /**
+     * Assert providers array structure and expected sorting
+     */
+    private function assertProvidersStructureAndSorting(array $actualProviders, array $expectedProviders): void {
+        $this->assertIsArray($actualProviders);
+        $this->assertCount(count($expectedProviders), $actualProviders);
+
+        foreach ($actualProviders as $index => $provider) {
+            $this->assertProviderHasRequiredFields($provider);
+
+            $expected = $expectedProviders[$index];
+            $this->assertEquals($expected['id'], $provider['id']);
+            $this->assertEquals($expected['name'], $provider['name']);
+            $this->assertEquals($expected['appId'], $provider['appId']);
+            $this->assertEquals($expected['order'], $provider['order']);
+            $this->assertEquals($expected['inAppSearch'], $provider['inAppSearch']);
+        }
+
+        $this->assertProvidersAreSortedByOrder($actualProviders);
+    }
+
+    private function assertProviderHasRequiredFields(array $provider): void {
+        $requiredFields = ['id', 'appId', 'name', 'icon', 'order', 'triggers', 'filters', 'inAppSearch'];
+        foreach ($requiredFields as $field) {
+            $this->assertArrayHasKey($field, $provider, "Provider must have '$field' field");
+        }
+    }
+
+    private function assertProvidersAreSortedByOrder(array $providers): void {
+        $orders = array_column($providers, 'order');
+        $sortedOrders = $orders;
+        sort($sortedOrders);
+        $this->assertEquals($sortedOrders, $orders, 'Providers should be sorted by order');
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 
 	private function setupUrlGenerator(): void {
 		$this->urlGenerator->method('imagePath')
-			->willReturnCallback(function ($appId, $imageName) {
+			->willReturnCallback(function($appId, $imageName) {
 				return "/apps/$appId/img/$imageName";
 			});
 	}