nextcloud / server

lib/public/Comments/ICommentsManager.php

Indentation +471 added lines, -471 removed lines

@@ -18,475 +18,475 @@
  * @since 9.0.0
  */
 interface ICommentsManager {
-	/**
-	 * @const DELETED_USER type and id for a user that has been deleted
-	 * @see deleteReferencesOfActor
-	 * @since 9.0.0
-	 *
-	 * To be used as replacement for user type actors in deleteReferencesOfActor().
-	 *
-	 * User interfaces shall show "Deleted user" as display name, if needed.
-	 */
-	public const DELETED_USER = 'deleted_users';
-
-	/**
-	 * returns a comment instance
-	 *
-	 * @param string $id the ID of the comment
-	 * @return IComment
-	 * @throws NotFoundException
-	 * @since 9.0.0
-	 */
-	public function get($id);
-
-	/**
-	 * Returns the comment specified by the id and all it's child comments
-	 *
-	 * @param string $id
-	 * @param int $limit max number of entries to return, 0 returns all
-	 * @param int $offset the start entry
-	 * @return array{comment: IComment, replies: list<array{comment: IComment, replies: array<empty, empty>}>}
-	 * @since 9.0.0
-	 *
-	 * The return array looks like this
-	 * [
-	 * 	 'comment' => IComment, // root comment
-	 *   'replies' =>
-	 *   [
-	 *     0 =>
-	 *     [
-	 *       'comment' => IComment,
-	 *       'replies' =>
-	 *       [
-	 *         0 =>
-	 *         [
-	 *           'comment' => IComment,
-	 *           'replies' => [ … ]
-	 *         ],
-	 *         …
-	 *       ]
-	 *     ]
-	 *     1 =>
-	 *     [
-	 *       'comment' => IComment,
-	 *       'replies'=> [ … ]
-	 *     ],
-	 *     …
-	 *   ]
-	 * ]
-	 */
-	public function getTree($id, $limit = 0, $offset = 0);
-
-	/**
-	 * returns comments for a specific object (e.g. a file).
-	 *
-	 * The sort order is always newest to oldest.
-	 *
-	 * @param string $objectType the object type, e.g. 'files'
-	 * @param string $objectId the id of the object
-	 * @param int $limit optional, number of maximum comments to be returned. if
-	 *                   not specified, all comments are returned.
-	 * @param int $offset optional, starting point
-	 * @param \DateTime|null $notOlderThan optional, timestamp of the oldest comments
-	 *                                     that may be returned
-	 * @return list<IComment>
-	 * @since 9.0.0
-	 */
-	public function getForObject(
-		$objectType,
-		$objectId,
-		$limit = 0,
-		$offset = 0,
-		?\DateTime $notOlderThan = null,
-	);
-
-	/**
-	 * @param string $objectType the object type, e.g. 'files'
-	 * @param string $objectId the id of the object
-	 * @param int $lastKnownCommentId the last known comment (will be used as offset)
-	 * @param string $sortDirection direction of the comments (`asc` or `desc`)
-	 * @param int $limit optional, number of maximum comments to be returned. if
-	 *                   set to 0, all comments are returned.
-	 * @param bool $includeLastKnown
-	 * @param string $topmostParentId Limit the comments to a list of replies and its original root comment
-	 * @return list<IComment>
-	 * @since 14.0.0
-	 * @deprecated 24.0.0 - Use getCommentsWithVerbForObjectSinceComment instead
-	 */
-	public function getForObjectSince(
-		string $objectType,
-		string $objectId,
-		int $lastKnownCommentId,
-		string $sortDirection = 'asc',
-		int $limit = 30,
-		bool $includeLastKnown = false,
-		string $topmostParentId = '',
-	): array;
-
-	/**
-	 * @param string $objectType the object type, e.g. 'files'
-	 * @param string $objectId the id of the object
-	 * @param string[] $verbs List of verbs to filter by
-	 * @param int $lastKnownCommentId the last known comment (will be used as offset)
-	 * @param string $sortDirection direction of the comments (`asc` or `desc`)
-	 * @param int $limit optional, number of maximum comments to be returned. if
-	 *                   set to 0, all comments are returned.
-	 * @param bool $includeLastKnown
-	 * @param string $topmostParentId Limit the comments to a list of replies and its original root comment
-	 * @return list<IComment>
-	 * @since 24.0.0
-	 */
-	public function getCommentsWithVerbForObjectSinceComment(
-		string $objectType,
-		string $objectId,
-		array $verbs,
-		int $lastKnownCommentId,
-		string $sortDirection = 'asc',
-		int $limit = 30,
-		bool $includeLastKnown = false,
-		string $topmostParentId = '',
-	): array;
-
-	/**
-	 * Search for comments with a given content
-	 *
-	 * @param string $search content to search for
-	 * @param string $objectType Limit the search by object type
-	 * @param string $objectId Limit the search by object id
-	 * @param string $verb Limit the verb of the comment
-	 * @param int $offset
-	 * @param int $limit
-	 * @return list<IComment>
-	 * @since 14.0.0
-	 */
-	public function search(string $search, string $objectType, string $objectId, string $verb, int $offset, int $limit = 50): array;
-
-	/**
-	 * Search for comments on one or more objects with a given content
-	 *
-	 * @param string $search content to search for
-	 * @param string $objectType Limit the search by object type
-	 * @param array $objectIds Limit the search by object ids
-	 * @param string $verb Limit the verb of the comment
-	 * @param int $offset
-	 * @param int $limit
-	 * @return IComment[]
-	 * @since 21.0.0
-	 */
-	public function searchForObjects(string $search, string $objectType, array $objectIds, string $verb, int $offset, int $limit = 50): array;
-
-	/**
-	 * @param $objectType string the object type, e.g. 'files'
-	 * @param $objectId string the id of the object
-	 * @param \DateTime|null $notOlderThan optional, timestamp of the oldest comments
-	 *                                     that may be returned
-	 * @param string $verb Limit the verb of the comment - Added in 14.0.0
-	 * @return int
-	 * @since 9.0.0
-	 */
-	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = '');
-
-	/**
-	 * @param $objectType string the object type, e.g. 'files'
-	 * @param $objectIds string[] the ids of the object
-	 * @param \DateTime|null $notOlderThan optional, timestamp of the oldest comments
-	 *                                     that may be returned
-	 * @param string $verb Limit the verb of the comment
-	 * @return array<string, int>
-	 * @since 32.0.0
-	 */
-	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = ''): array;
-
-	/**
-	 * @param string $objectType the object type, e.g. 'files'
-	 * @param string[] $objectIds the id of the object
-	 * @param IUser $user
-	 * @param string $verb Limit the verb of the comment - Added in 14.0.0
-	 * @return array Map with object id => # of unread comments
-	 * @psalm-return array<string, int>
-	 * @since 21.0.0
-	 */
-	public function getNumberOfUnreadCommentsForObjects(string $objectType, array $objectIds, IUser $user, $verb = ''): array;
-
-	/**
-	 * @param string $objectType
-	 * @param string $objectId
-	 * @param int $lastRead
-	 * @param string $verb
-	 * @return int
-	 * @since 21.0.0
-	 * @deprecated 24.0.0 - Use getNumberOfCommentsWithVerbsForObjectSinceComment instead
-	 */
-	public function getNumberOfCommentsForObjectSinceComment(string $objectType, string $objectId, int $lastRead, string $verb = ''): int;
-
-
-	/**
-	 * @param string $objectType
-	 * @param string $objectId
-	 * @param int $lastRead
-	 * @param string[] $verbs
-	 * @return int
-	 * @since 24.0.0
-	 */
-	public function getNumberOfCommentsWithVerbsForObjectSinceComment(string $objectType, string $objectId, int $lastRead, array $verbs): int;
-
-	/**
-	 * @param string $objectType
-	 * @param string $objectId
-	 * @param \DateTime $beforeDate
-	 * @param string $verb
-	 * @return int
-	 * @since 21.0.0
-	 */
-	public function getLastCommentBeforeDate(string $objectType, string $objectId, \DateTime $beforeDate, string $verb = ''): int;
-
-	/**
-	 * @param string $objectType
-	 * @param string $objectId
-	 * @param string $verb
-	 * @param string $actorType
-	 * @param string[] $actors
-	 * @return \DateTime[] Map of "string actor" => "\DateTime most recent comment date"
-	 * @psalm-return array<string, \DateTime>
-	 * @since 21.0.0
-	 */
-	public function getLastCommentDateByActor(
-		string $objectType,
-		string $objectId,
-		string $verb,
-		string $actorType,
-		array $actors,
-	): array;
-
-	/**
-	 * Get the number of unread comments for all files in a folder
-	 *
-	 * @param int $folderId
-	 * @param IUser $user
-	 * @return array [$fileId => $unreadCount]
-	 * @since 12.0.0
-	 * @deprecated 29.0.0 use getNumberOfUnreadCommentsForObjects instead
-	 */
-	public function getNumberOfUnreadCommentsForFolder($folderId, IUser $user);
-
-	/**
-	 * creates a new comment and returns it. At this point of time, it is not
-	 * saved in the used data storage. Use save() after setting other fields
-	 * of the comment (e.g. message or verb).
-	 *
-	 * @param string $actorType the actor type (e.g. 'users')
-	 * @param string $actorId a user id
-	 * @param string $objectType the object type the comment is attached to
-	 * @param string $objectId the object id the comment is attached to
-	 * @return IComment
-	 * @since 9.0.0
-	 */
-	public function create($actorType, $actorId, $objectType, $objectId);
-
-	/**
-	 * permanently deletes the comment specified by the ID
-	 *
-	 * When the comment has child comments, their parent ID will be changed to
-	 * the parent ID of the item that is to be deleted.
-	 *
-	 * @param string $id
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function delete($id);
-
-	/**
-	 * Get comment related with user reaction
-	 *
-	 * Throws PreConditionNotMetException when the system haven't the minimum requirements to
-	 * use reactions
-	 *
-	 * @param int $parentId
-	 * @param string $actorType
-	 * @param string $actorId
-	 * @param string $reaction
-	 * @return IComment
-	 * @throws NotFoundException
-	 * @throws PreConditionNotMetException
-	 * @since 24.0.0
-	 */
-	public function getReactionComment(int $parentId, string $actorType, string $actorId, string $reaction): IComment;
-
-	/**
-	 * Retrieve all reactions of a message
-	 *
-	 * Throws PreConditionNotMetException when the system haven't the minimum requirements to
-	 * use reactions
-	 *
-	 * @param int $parentId
-	 * @return IComment[]
-	 * @throws PreConditionNotMetException
-	 * @since 24.0.0
-	 */
-	public function retrieveAllReactions(int $parentId): array;
-
-	/**
-	 * Retrieve all reactions with specific reaction of a message
-	 *
-	 * Throws PreConditionNotMetException when the system haven't the minimum requirements to
-	 * use reactions
-	 *
-	 * @param int $parentId
-	 * @param string $reaction
-	 * @return IComment[]
-	 * @throws PreConditionNotMetException
-	 * @since 24.0.0
-	 */
-	public function retrieveAllReactionsWithSpecificReaction(int $parentId, string $reaction): array;
-
-	/**
-	 * Support reactions
-	 *
-	 * @return bool
-	 * @since 24.0.0
-	 */
-	public function supportReactions(): bool;
-
-	/**
-	 * saves the comment permanently
-	 *
-	 * if the supplied comment has an empty ID, a new entry comment will be
-	 * saved and the instance updated with the new ID.
-	 *
-	 * Otherwise, an existing comment will be updated.
-	 *
-	 * Throws NotFoundException when a comment that is to be updated does not
-	 * exist anymore at this point of time.
-	 *
-	 * @param IComment $comment
-	 * @return bool
-	 * @throws NotFoundException
-	 * @since 9.0.0
-	 */
-	public function save(IComment $comment);
-
-	/**
-	 * Deletes all references to specific actor (e.g. on user delete) of a comment.
-	 * The comment itself must not get lost/deleted.
-	 *
-	 * A 'users' type actor (type and id) should get replaced by the
-	 * value of the DELETED_USER constant of this interface.
-	 *
-	 * @param string $actorType the actor type (e.g. 'users')
-	 * @param string $actorId a user id
-	 * @return boolean whether the deletion was successful
-	 * @since 9.0.0
-	 */
-	public function deleteReferencesOfActor($actorType, $actorId);
-
-	/**
-	 * Deletes all comments made of a specific object (e.g. on file delete).
-	 *
-	 * @param string $objectType the object type (e.g. 'files')
-	 * @param string $objectId e.g. the file id
-	 * @return boolean whether the deletion was successful
-	 * @since 9.0.0
-	 */
-	public function deleteCommentsAtObject($objectType, $objectId);
-
-	/**
-	 * sets the read marker for a given file to the specified date for the
-	 * provided user
-	 *
-	 * @param string $objectType
-	 * @param string $objectId
-	 * @param \DateTime $dateTime
-	 * @param \OCP\IUser $user
-	 * @since 9.0.0
-	 */
-	public function setReadMark($objectType, $objectId, \DateTime $dateTime, \OCP\IUser $user);
-
-	/**
-	 * returns the read marker for a given file to the specified date for the
-	 * provided user. It returns null, when the marker is not present, i.e.
-	 * no comments were marked as read.
-	 *
-	 * @param string $objectType
-	 * @param string $objectId
-	 * @param \OCP\IUser $user
-	 * @return \DateTime|null
-	 * @since 9.0.0
-	 */
-	public function getReadMark($objectType, $objectId, \OCP\IUser $user);
-
-	/**
-	 * deletes the read markers for the specified user
-	 *
-	 * @param \OCP\IUser $user
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function deleteReadMarksFromUser(\OCP\IUser $user);
-
-	/**
-	 * deletes the read markers on the specified object
-	 *
-	 * @param string $objectType
-	 * @param string $objectId
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function deleteReadMarksOnObject($objectType, $objectId);
-
-	/**
-	 * registers an Entity to the manager, so event notifications can be send
-	 * to consumers of the comments infrastructure
-	 *
-	 * @param \Closure $closure
-	 * @return void
-	 * @since 11.0.0
-	 */
-	public function registerEventHandler(\Closure $closure);
-
-	/**
-	 * registers a method that resolves an ID to a display name for a given type
-	 *
-	 * @param string $type
-	 * @param \Closure $closure
-	 * @return void
-	 * @throws \OutOfBoundsException
-	 * @since 11.0.0
-	 *
-	 * Only one resolver shall be registered per type. Otherwise a
-	 * \OutOfBoundsException has to thrown.
-	 */
-	public function registerDisplayNameResolver($type, \Closure $closure);
-
-	/**
-	 * resolves a given ID of a given Type to a display name.
-	 *
-	 * @param string $type
-	 * @param string $id
-	 * @return string
-	 * @throws \OutOfBoundsException
-	 * @since 11.0.0
-	 *
-	 * If a provided type was not registered, an \OutOfBoundsException shall
-	 * be thrown. It is upon the resolver discretion what to return of the
-	 * provided ID is unknown. It must be ensured that a string is returned.
-	 */
-	public function resolveDisplayName($type, $id);
-
-	/**
-	 * Load the Comments app into the page
-	 *
-	 * @since 21.0.0
-	 */
-	public function load(): void;
-
-	/**
-	 * Delete comments with field expire_date less than current date
-	 * Only will delete the message related with the object.
-	 *
-	 * @param string $objectType the object type (e.g. 'files')
-	 * @param string $objectId e.g. the file id, leave empty to expire on all objects of this type
-	 * @return boolean true if at least one row was deleted
-	 * @since 25.0.0
-	 */
-	public function deleteCommentsExpiredAtObject(string $objectType, string $objectId = ''): bool;
+    /**
+     * @const DELETED_USER type and id for a user that has been deleted
+     * @see deleteReferencesOfActor
+     * @since 9.0.0
+     *
+     * To be used as replacement for user type actors in deleteReferencesOfActor().
+     *
+     * User interfaces shall show "Deleted user" as display name, if needed.
+     */
+    public const DELETED_USER = 'deleted_users';
+
+    /**
+     * returns a comment instance
+     *
+     * @param string $id the ID of the comment
+     * @return IComment
+     * @throws NotFoundException
+     * @since 9.0.0
+     */
+    public function get($id);
+
+    /**
+     * Returns the comment specified by the id and all it's child comments
+     *
+     * @param string $id
+     * @param int $limit max number of entries to return, 0 returns all
+     * @param int $offset the start entry
+     * @return array{comment: IComment, replies: list<array{comment: IComment, replies: array<empty, empty>}>}
+     * @since 9.0.0
+     *
+     * The return array looks like this
+     * [
+     * 	 'comment' => IComment, // root comment
+     *   'replies' =>
+     *   [
+     *     0 =>
+     *     [
+     *       'comment' => IComment,
+     *       'replies' =>
+     *       [
+     *         0 =>
+     *         [
+     *           'comment' => IComment,
+     *           'replies' => [ … ]
+     *         ],
+     *         …
+     *       ]
+     *     ]
+     *     1 =>
+     *     [
+     *       'comment' => IComment,
+     *       'replies'=> [ … ]
+     *     ],
+     *     …
+     *   ]
+     * ]
+     */
+    public function getTree($id, $limit = 0, $offset = 0);
+
+    /**
+     * returns comments for a specific object (e.g. a file).
+     *
+     * The sort order is always newest to oldest.
+     *
+     * @param string $objectType the object type, e.g. 'files'
+     * @param string $objectId the id of the object
+     * @param int $limit optional, number of maximum comments to be returned. if
+     *                   not specified, all comments are returned.
+     * @param int $offset optional, starting point
+     * @param \DateTime|null $notOlderThan optional, timestamp of the oldest comments
+     *                                     that may be returned
+     * @return list<IComment>
+     * @since 9.0.0
+     */
+    public function getForObject(
+        $objectType,
+        $objectId,
+        $limit = 0,
+        $offset = 0,
+        ?\DateTime $notOlderThan = null,
+    );
+
+    /**
+     * @param string $objectType the object type, e.g. 'files'
+     * @param string $objectId the id of the object
+     * @param int $lastKnownCommentId the last known comment (will be used as offset)
+     * @param string $sortDirection direction of the comments (`asc` or `desc`)
+     * @param int $limit optional, number of maximum comments to be returned. if
+     *                   set to 0, all comments are returned.
+     * @param bool $includeLastKnown
+     * @param string $topmostParentId Limit the comments to a list of replies and its original root comment
+     * @return list<IComment>
+     * @since 14.0.0
+     * @deprecated 24.0.0 - Use getCommentsWithVerbForObjectSinceComment instead
+     */
+    public function getForObjectSince(
+        string $objectType,
+        string $objectId,
+        int $lastKnownCommentId,
+        string $sortDirection = 'asc',
+        int $limit = 30,
+        bool $includeLastKnown = false,
+        string $topmostParentId = '',
+    ): array;
+
+    /**
+     * @param string $objectType the object type, e.g. 'files'
+     * @param string $objectId the id of the object
+     * @param string[] $verbs List of verbs to filter by
+     * @param int $lastKnownCommentId the last known comment (will be used as offset)
+     * @param string $sortDirection direction of the comments (`asc` or `desc`)
+     * @param int $limit optional, number of maximum comments to be returned. if
+     *                   set to 0, all comments are returned.
+     * @param bool $includeLastKnown
+     * @param string $topmostParentId Limit the comments to a list of replies and its original root comment
+     * @return list<IComment>
+     * @since 24.0.0
+     */
+    public function getCommentsWithVerbForObjectSinceComment(
+        string $objectType,
+        string $objectId,
+        array $verbs,
+        int $lastKnownCommentId,
+        string $sortDirection = 'asc',
+        int $limit = 30,
+        bool $includeLastKnown = false,
+        string $topmostParentId = '',
+    ): array;
+
+    /**
+     * Search for comments with a given content
+     *
+     * @param string $search content to search for
+     * @param string $objectType Limit the search by object type
+     * @param string $objectId Limit the search by object id
+     * @param string $verb Limit the verb of the comment
+     * @param int $offset
+     * @param int $limit
+     * @return list<IComment>
+     * @since 14.0.0
+     */
+    public function search(string $search, string $objectType, string $objectId, string $verb, int $offset, int $limit = 50): array;
+
+    /**
+     * Search for comments on one or more objects with a given content
+     *
+     * @param string $search content to search for
+     * @param string $objectType Limit the search by object type
+     * @param array $objectIds Limit the search by object ids
+     * @param string $verb Limit the verb of the comment
+     * @param int $offset
+     * @param int $limit
+     * @return IComment[]
+     * @since 21.0.0
+     */
+    public function searchForObjects(string $search, string $objectType, array $objectIds, string $verb, int $offset, int $limit = 50): array;
+
+    /**
+     * @param $objectType string the object type, e.g. 'files'
+     * @param $objectId string the id of the object
+     * @param \DateTime|null $notOlderThan optional, timestamp of the oldest comments
+     *                                     that may be returned
+     * @param string $verb Limit the verb of the comment - Added in 14.0.0
+     * @return int
+     * @since 9.0.0
+     */
+    public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = '');
+
+    /**
+     * @param $objectType string the object type, e.g. 'files'
+     * @param $objectIds string[] the ids of the object
+     * @param \DateTime|null $notOlderThan optional, timestamp of the oldest comments
+     *                                     that may be returned
+     * @param string $verb Limit the verb of the comment
+     * @return array<string, int>
+     * @since 32.0.0
+     */
+    public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = ''): array;
+
+    /**
+     * @param string $objectType the object type, e.g. 'files'
+     * @param string[] $objectIds the id of the object
+     * @param IUser $user
+     * @param string $verb Limit the verb of the comment - Added in 14.0.0
+     * @return array Map with object id => # of unread comments
+     * @psalm-return array<string, int>
+     * @since 21.0.0
+     */
+    public function getNumberOfUnreadCommentsForObjects(string $objectType, array $objectIds, IUser $user, $verb = ''): array;
+
+    /**
+     * @param string $objectType
+     * @param string $objectId
+     * @param int $lastRead
+     * @param string $verb
+     * @return int
+     * @since 21.0.0
+     * @deprecated 24.0.0 - Use getNumberOfCommentsWithVerbsForObjectSinceComment instead
+     */
+    public function getNumberOfCommentsForObjectSinceComment(string $objectType, string $objectId, int $lastRead, string $verb = ''): int;
+
+
+    /**
+     * @param string $objectType
+     * @param string $objectId
+     * @param int $lastRead
+     * @param string[] $verbs
+     * @return int
+     * @since 24.0.0
+     */
+    public function getNumberOfCommentsWithVerbsForObjectSinceComment(string $objectType, string $objectId, int $lastRead, array $verbs): int;
+
+    /**
+     * @param string $objectType
+     * @param string $objectId
+     * @param \DateTime $beforeDate
+     * @param string $verb
+     * @return int
+     * @since 21.0.0
+     */
+    public function getLastCommentBeforeDate(string $objectType, string $objectId, \DateTime $beforeDate, string $verb = ''): int;
+
+    /**
+     * @param string $objectType
+     * @param string $objectId
+     * @param string $verb
+     * @param string $actorType
+     * @param string[] $actors
+     * @return \DateTime[] Map of "string actor" => "\DateTime most recent comment date"
+     * @psalm-return array<string, \DateTime>
+     * @since 21.0.0
+     */
+    public function getLastCommentDateByActor(
+        string $objectType,
+        string $objectId,
+        string $verb,
+        string $actorType,
+        array $actors,
+    ): array;
+
+    /**
+     * Get the number of unread comments for all files in a folder
+     *
+     * @param int $folderId
+     * @param IUser $user
+     * @return array [$fileId => $unreadCount]
+     * @since 12.0.0
+     * @deprecated 29.0.0 use getNumberOfUnreadCommentsForObjects instead
+     */
+    public function getNumberOfUnreadCommentsForFolder($folderId, IUser $user);
+
+    /**
+     * creates a new comment and returns it. At this point of time, it is not
+     * saved in the used data storage. Use save() after setting other fields
+     * of the comment (e.g. message or verb).
+     *
+     * @param string $actorType the actor type (e.g. 'users')
+     * @param string $actorId a user id
+     * @param string $objectType the object type the comment is attached to
+     * @param string $objectId the object id the comment is attached to
+     * @return IComment
+     * @since 9.0.0
+     */
+    public function create($actorType, $actorId, $objectType, $objectId);
+
+    /**
+     * permanently deletes the comment specified by the ID
+     *
+     * When the comment has child comments, their parent ID will be changed to
+     * the parent ID of the item that is to be deleted.
+     *
+     * @param string $id
+     * @return bool
+     * @since 9.0.0
+     */
+    public function delete($id);
+
+    /**
+     * Get comment related with user reaction
+     *
+     * Throws PreConditionNotMetException when the system haven't the minimum requirements to
+     * use reactions
+     *
+     * @param int $parentId
+     * @param string $actorType
+     * @param string $actorId
+     * @param string $reaction
+     * @return IComment
+     * @throws NotFoundException
+     * @throws PreConditionNotMetException
+     * @since 24.0.0
+     */
+    public function getReactionComment(int $parentId, string $actorType, string $actorId, string $reaction): IComment;
+
+    /**
+     * Retrieve all reactions of a message
+     *
+     * Throws PreConditionNotMetException when the system haven't the minimum requirements to
+     * use reactions
+     *
+     * @param int $parentId
+     * @return IComment[]
+     * @throws PreConditionNotMetException
+     * @since 24.0.0
+     */
+    public function retrieveAllReactions(int $parentId): array;
+
+    /**
+     * Retrieve all reactions with specific reaction of a message
+     *
+     * Throws PreConditionNotMetException when the system haven't the minimum requirements to
+     * use reactions
+     *
+     * @param int $parentId
+     * @param string $reaction
+     * @return IComment[]
+     * @throws PreConditionNotMetException
+     * @since 24.0.0
+     */
+    public function retrieveAllReactionsWithSpecificReaction(int $parentId, string $reaction): array;
+
+    /**
+     * Support reactions
+     *
+     * @return bool
+     * @since 24.0.0
+     */
+    public function supportReactions(): bool;
+
+    /**
+     * saves the comment permanently
+     *
+     * if the supplied comment has an empty ID, a new entry comment will be
+     * saved and the instance updated with the new ID.
+     *
+     * Otherwise, an existing comment will be updated.
+     *
+     * Throws NotFoundException when a comment that is to be updated does not
+     * exist anymore at this point of time.
+     *
+     * @param IComment $comment
+     * @return bool
+     * @throws NotFoundException
+     * @since 9.0.0
+     */
+    public function save(IComment $comment);
+
+    /**
+     * Deletes all references to specific actor (e.g. on user delete) of a comment.
+     * The comment itself must not get lost/deleted.
+     *
+     * A 'users' type actor (type and id) should get replaced by the
+     * value of the DELETED_USER constant of this interface.
+     *
+     * @param string $actorType the actor type (e.g. 'users')
+     * @param string $actorId a user id
+     * @return boolean whether the deletion was successful
+     * @since 9.0.0
+     */
+    public function deleteReferencesOfActor($actorType, $actorId);
+
+    /**
+     * Deletes all comments made of a specific object (e.g. on file delete).
+     *
+     * @param string $objectType the object type (e.g. 'files')
+     * @param string $objectId e.g. the file id
+     * @return boolean whether the deletion was successful
+     * @since 9.0.0
+     */
+    public function deleteCommentsAtObject($objectType, $objectId);
+
+    /**
+     * sets the read marker for a given file to the specified date for the
+     * provided user
+     *
+     * @param string $objectType
+     * @param string $objectId
+     * @param \DateTime $dateTime
+     * @param \OCP\IUser $user
+     * @since 9.0.0
+     */
+    public function setReadMark($objectType, $objectId, \DateTime $dateTime, \OCP\IUser $user);
+
+    /**
+     * returns the read marker for a given file to the specified date for the
+     * provided user. It returns null, when the marker is not present, i.e.
+     * no comments were marked as read.
+     *
+     * @param string $objectType
+     * @param string $objectId
+     * @param \OCP\IUser $user
+     * @return \DateTime|null
+     * @since 9.0.0
+     */
+    public function getReadMark($objectType, $objectId, \OCP\IUser $user);
+
+    /**
+     * deletes the read markers for the specified user
+     *
+     * @param \OCP\IUser $user
+     * @return bool
+     * @since 9.0.0
+     */
+    public function deleteReadMarksFromUser(\OCP\IUser $user);
+
+    /**
+     * deletes the read markers on the specified object
+     *
+     * @param string $objectType
+     * @param string $objectId
+     * @return bool
+     * @since 9.0.0
+     */
+    public function deleteReadMarksOnObject($objectType, $objectId);
+
+    /**
+     * registers an Entity to the manager, so event notifications can be send
+     * to consumers of the comments infrastructure
+     *
+     * @param \Closure $closure
+     * @return void
+     * @since 11.0.0
+     */
+    public function registerEventHandler(\Closure $closure);
+
+    /**
+     * registers a method that resolves an ID to a display name for a given type
+     *
+     * @param string $type
+     * @param \Closure $closure
+     * @return void
+     * @throws \OutOfBoundsException
+     * @since 11.0.0
+     *
+     * Only one resolver shall be registered per type. Otherwise a
+     * \OutOfBoundsException has to thrown.
+     */
+    public function registerDisplayNameResolver($type, \Closure $closure);
+
+    /**
+     * resolves a given ID of a given Type to a display name.
+     *
+     * @param string $type
+     * @param string $id
+     * @return string
+     * @throws \OutOfBoundsException
+     * @since 11.0.0
+     *
+     * If a provided type was not registered, an \OutOfBoundsException shall
+     * be thrown. It is upon the resolver discretion what to return of the
+     * provided ID is unknown. It must be ensured that a string is returned.
+     */
+    public function resolveDisplayName($type, $id);
+
+    /**
+     * Load the Comments app into the page
+     *
+     * @since 21.0.0
+     */
+    public function load(): void;
+
+    /**
+     * Delete comments with field expire_date less than current date
+     * Only will delete the message related with the object.
+     *
+     * @param string $objectType the object type (e.g. 'files')
+     * @param string $objectId e.g. the file id, leave empty to expire on all objects of this type
+     * @return boolean true if at least one row was deleted
+     * @since 25.0.0
+     */
+    public function deleteCommentsExpiredAtObject(string $objectType, string $objectId = ''): bool;
 }

lib/private/OpenMetrics/Exporters/FilesByType.php

Indentation +47 added lines, -47 removed lines

@@ -23,58 +23,58 @@
  * Cached exporter, refreshed every 30 minutes
  */
 class FilesByType extends Cached {
-	public function __construct(
-		ICacheFactory $cacheFactory,
-		private IDBConnection $connection,
-		private IMimeTypeLoader $mimetypeLoader,
-	) {
-		parent::__construct($cacheFactory);
-	}
+    public function __construct(
+        ICacheFactory $cacheFactory,
+        private IDBConnection $connection,
+        private IMimeTypeLoader $mimetypeLoader,
+    ) {
+        parent::__construct($cacheFactory);
+    }
 
-	#[Override]
-	public function name(): string {
-		return 'files';
-	}
+    #[Override]
+    public function name(): string {
+        return 'files';
+    }
 
-	#[Override]
-	public function type(): MetricType {
-		return MetricType::gauge;
-	}
+    #[Override]
+    public function type(): MetricType {
+        return MetricType::gauge;
+    }
 
-	#[Override]
-	public function unit(): string {
-		return 'files';
-	}
+    #[Override]
+    public function unit(): string {
+        return 'files';
+    }
 
-	#[Override]
-	public function help(): string {
-		return 'Number of files by type';
-	}
+    #[Override]
+    public function help(): string {
+        return 'Number of files by type';
+    }
 
-	#[Override]
-	public function getTTL(): int {
-		return 30 * 60;
-	}
+    #[Override]
+    public function getTTL(): int {
+        return 30 * 60;
+    }
 
-	#[Override]
-	public function gatherMetrics(): Generator {
-		$qb = $this->connection->getQueryBuilder()->runAcrossAllShards();
-		$metrics = $qb->select('mimetype', $qb->func()->count('*', 'count'))
-			->from('filecache')
-			->groupBy('mimetype')
-			->executeQuery();
+    #[Override]
+    public function gatherMetrics(): Generator {
+        $qb = $this->connection->getQueryBuilder()->runAcrossAllShards();
+        $metrics = $qb->select('mimetype', $qb->func()->count('*', 'count'))
+            ->from('filecache')
+            ->groupBy('mimetype')
+            ->executeQuery();
 
-		if ($metrics->rowCount() === 0) {
-			yield new Metric(0);
-			return;
-		}
-		$now = time();
-		foreach ($metrics->iterateAssociative() as $count) {
-			yield new Metric(
-				$count['count'],
-				['mimetype' => $this->mimetypeLoader->getMimetypeById($count['mimetype']) ?? ''],
-				$now,
-			);
-		}
-	}
+        if ($metrics->rowCount() === 0) {
+            yield new Metric(0);
+            return;
+        }
+        $now = time();
+        foreach ($metrics->iterateAssociative() as $count) {
+            yield new Metric(
+                $count['count'],
+                ['mimetype' => $this->mimetypeLoader->getMimetypeById($count['mimetype']) ?? ''],
+                $now,
+            );
+        }
+    }
 }

apps/webhook_listeners/lib/Service/TokenService.php

Indentation +129 added lines, -129 removed lines

@@ -21,140 +21,140 @@
 use Psr\Log\LoggerInterface;
 
 class TokenService {
-	public function __construct(
-		private IProvider $tokenProvider,
-		private IURLGenerator $urlGenerator,
-		private ISecureRandom $random,
-		private EphemeralTokenMapper $tokenMapper,
-		private LoggerInterface $logger,
-		private ITimeFactory $time,
-		private IFactory $l10nFactory,
-		private IUserManager $userManager,
-	) {
-	}
+    public function __construct(
+        private IProvider $tokenProvider,
+        private IURLGenerator $urlGenerator,
+        private ISecureRandom $random,
+        private EphemeralTokenMapper $tokenMapper,
+        private LoggerInterface $logger,
+        private ITimeFactory $time,
+        private IFactory $l10nFactory,
+        private IUserManager $userManager,
+    ) {
+    }
 
-	/**
-	 * creates an array which includes two arrays of tokens: 'user_ids' and 'user_roles'
-	 * The array ['user_ids' => ['jane', 'bob'], 'user_roles' => ['owner', 'trigger']]
-	 * as requested tokens in the registered webhook produces a result like
-	 * [
-	 * 		['user_ids' => [
-	 * 			['jane' => [
-	 * 				'userId' => 'jane',
-	 * 				'token' => 'abcdtokenabcd1'
-	 * 				'baseUrl' => 'https://nextcloud.example'
-	 * 			],
-	 * 			['bob'=> [
-	 * 				'userId' => 'bob',
-	 * 				'token' => 'abcdtokenabcd2'
-	 * 				'baseUrl' => 'https://nextcloud.example'
-	 * 			],
-	 * 		],
-	 * 		'owner' => [
-	 * 			'userId' => 'admin',
-	 * 			'token' => 'abcdtokenabcd3'
-	 * 			'baseUrl' => 'https://nextcloud.example'
-	 * 		],
-	 * 		'trigger' => [
-	 * 			'userId' => 'user1',
-	 * 			'token' => 'abcdtokenabcd4'
-	 * 			'baseUrl' => 'https://nextcloud.example'
-	 * 		],
-	 * ]
-	 * Created auth tokens are valid for 1 hour.
-	 *
-	 * @param WebhookListener $webhookListener
-	 * @param ?string $triggerUserId the user that triggered the webhook call
-	 * @return array{
-	 *     user_ids?: array<string, array{baseUrl: string, token: string, userId: mixed}>,
-	 *     trigger?: array{baseUrl: string, token: string, userId: string},
-	 *     owner?: array{baseUrl: string, token: string, userId: string},
-	 * }
-	 */
-	public function getTokens(WebhookListener $webhookListener, ?string $triggerUserId): array {
-		$tokens = [];
+    /**
+     * creates an array which includes two arrays of tokens: 'user_ids' and 'user_roles'
+     * The array ['user_ids' => ['jane', 'bob'], 'user_roles' => ['owner', 'trigger']]
+     * as requested tokens in the registered webhook produces a result like
+     * [
+     * 		['user_ids' => [
+     * 			['jane' => [
+     * 				'userId' => 'jane',
+     * 				'token' => 'abcdtokenabcd1'
+     * 				'baseUrl' => 'https://nextcloud.example'
+     * 			],
+     * 			['bob'=> [
+     * 				'userId' => 'bob',
+     * 				'token' => 'abcdtokenabcd2'
+     * 				'baseUrl' => 'https://nextcloud.example'
+     * 			],
+     * 		],
+     * 		'owner' => [
+     * 			'userId' => 'admin',
+     * 			'token' => 'abcdtokenabcd3'
+     * 			'baseUrl' => 'https://nextcloud.example'
+     * 		],
+     * 		'trigger' => [
+     * 			'userId' => 'user1',
+     * 			'token' => 'abcdtokenabcd4'
+     * 			'baseUrl' => 'https://nextcloud.example'
+     * 		],
+     * ]
+     * Created auth tokens are valid for 1 hour.
+     *
+     * @param WebhookListener $webhookListener
+     * @param ?string $triggerUserId the user that triggered the webhook call
+     * @return array{
+     *     user_ids?: array<string, array{baseUrl: string, token: string, userId: mixed}>,
+     *     trigger?: array{baseUrl: string, token: string, userId: string},
+     *     owner?: array{baseUrl: string, token: string, userId: string},
+     * }
+     */
+    public function getTokens(WebhookListener $webhookListener, ?string $triggerUserId): array {
+        $tokens = [];
 
-		$tokenNeeded = $webhookListener->getTokenNeeded();
-		if (isset($tokenNeeded['user_ids'])) {
-			$tokens = [
-				'user_ids' => [],
-			];
-			foreach ($tokenNeeded['user_ids'] as $userId) {
-				try {
-					$tokens['user_ids'][$userId] = [
-						'userId' => $userId,
-						'token' => $this->createEphemeralToken($userId),
-						'baseUrl' => $this->urlGenerator->getBaseUrl()
-					];
-				} catch (\Exception $e) {
-					$this->logger->error('Webhook token creation for user ' . $userId . ' failed: ' . $e->getMessage(), ['exception' => $e]);
-				}
+        $tokenNeeded = $webhookListener->getTokenNeeded();
+        if (isset($tokenNeeded['user_ids'])) {
+            $tokens = [
+                'user_ids' => [],
+            ];
+            foreach ($tokenNeeded['user_ids'] as $userId) {
+                try {
+                    $tokens['user_ids'][$userId] = [
+                        'userId' => $userId,
+                        'token' => $this->createEphemeralToken($userId),
+                        'baseUrl' => $this->urlGenerator->getBaseUrl()
+                    ];
+                } catch (\Exception $e) {
+                    $this->logger->error('Webhook token creation for user ' . $userId . ' failed: ' . $e->getMessage(), ['exception' => $e]);
+                }
 
-			}
-		}
-		if (isset($tokenNeeded['user_roles'])) {
-			foreach ($tokenNeeded['user_roles'] as $user_role) {
-				switch ($user_role) {
-					case 'owner':
-						// token for the person who created the flow
-						$ownerId = $webhookListener->getUserId();
-						if (is_null($ownerId)) { // no owner uid available
-							break;
-						}
-						$tokens['owner'] = [
-							'userId' => $ownerId,
-							'token' => $this->createEphemeralToken($ownerId),
-							'baseUrl' => $this->urlGenerator->getBaseUrl()
-						];
-						break;
-					case 'trigger':
-						// token for the person who triggered the webhook
-						if (is_null($triggerUserId)) { // no trigger uid available
-							break;
-						}
-						$tokens['trigger'] = [
-							'userId' => $triggerUserId,
-							'token' => $this->createEphemeralToken($triggerUserId),
-							'baseUrl' => $this->urlGenerator->getBaseUrl()
-						];
-						break;
-					default:
-						$this->logger->error('Webhook token creation for user role ' . $user_role . ' not defined. ', ['Not defined' => $user_role]);
+            }
+        }
+        if (isset($tokenNeeded['user_roles'])) {
+            foreach ($tokenNeeded['user_roles'] as $user_role) {
+                switch ($user_role) {
+                    case 'owner':
+                        // token for the person who created the flow
+                        $ownerId = $webhookListener->getUserId();
+                        if (is_null($ownerId)) { // no owner uid available
+                            break;
+                        }
+                        $tokens['owner'] = [
+                            'userId' => $ownerId,
+                            'token' => $this->createEphemeralToken($ownerId),
+                            'baseUrl' => $this->urlGenerator->getBaseUrl()
+                        ];
+                        break;
+                    case 'trigger':
+                        // token for the person who triggered the webhook
+                        if (is_null($triggerUserId)) { // no trigger uid available
+                            break;
+                        }
+                        $tokens['trigger'] = [
+                            'userId' => $triggerUserId,
+                            'token' => $this->createEphemeralToken($triggerUserId),
+                            'baseUrl' => $this->urlGenerator->getBaseUrl()
+                        ];
+                        break;
+                    default:
+                        $this->logger->error('Webhook token creation for user role ' . $user_role . ' not defined. ', ['Not defined' => $user_role]);
 
-				}
-			}
-		}
-		return $tokens;
-	}
-	private function createEphemeralToken(string $userId): string {
-		$token = $this->generateRandomDeviceToken();
+                }
+            }
+        }
+        return $tokens;
+    }
+    private function createEphemeralToken(string $userId): string {
+        $token = $this->generateRandomDeviceToken();
 
-		// we need the user`s language to have the token name showing up in the session list in the correct language
-		$user = $this->userManager->get($userId);
-		$lang = $this->l10nFactory->getUserLanguage($user);
-		$l = $this->l10nFactory->get('webhook_listeners', $lang);
-		$name = $l->t('Ephemeral webhook authentication');
-		$password = null;
-		$deviceToken = $this->tokenProvider->generateToken(
-			$token,
-			$userId,
-			$userId,
-			$password,
-			$name,
-			IToken::PERMANENT_TOKEN);
+        // we need the user`s language to have the token name showing up in the session list in the correct language
+        $user = $this->userManager->get($userId);
+        $lang = $this->l10nFactory->getUserLanguage($user);
+        $l = $this->l10nFactory->get('webhook_listeners', $lang);
+        $name = $l->t('Ephemeral webhook authentication');
+        $password = null;
+        $deviceToken = $this->tokenProvider->generateToken(
+            $token,
+            $userId,
+            $userId,
+            $password,
+            $name,
+            IToken::PERMANENT_TOKEN);
 
-		$this->tokenMapper->addEphemeralToken(
-			$deviceToken->getId(),
-			$userId,
-			$this->time->getTime());
-		return $token;
-	}
+        $this->tokenMapper->addEphemeralToken(
+            $deviceToken->getId(),
+            $userId,
+            $this->time->getTime());
+        return $token;
+    }
 
-	private function generateRandomDeviceToken(): string {
-		$groups = [];
-		for ($i = 0; $i < 5; $i++) {
-			$groups[] = $this->random->generate(5, ISecureRandom::CHAR_HUMAN_READABLE);
-		}
-		return implode('-', $groups);
-	}
+    private function generateRandomDeviceToken(): string {
+        $groups = [];
+        for ($i = 0; $i < 5; $i++) {
+            $groups[] = $this->random->generate(5, ISecureRandom::CHAR_HUMAN_READABLE);
+        }
+        return implode('-', $groups);
+    }
 }

tests/lib/Comments/CommentTest.php

Indentation +200 added lines, -200 removed lines

@@ -15,204 +15,204 @@
 use Test\TestCase;
 
 class CommentTest extends TestCase {
-	/**
-	 * @throws IllegalIDChangeException
-	 */
-	public function testSettersValidInput(): void {
-		$comment = new Comment();
-
-		$id = 'comment23';
-		$parentId = 'comment11.5';
-		$topMostParentId = 'comment11.0';
-		$childrenCount = 6;
-		$message = 'I like to comment comment';
-		$verb = 'comment';
-		$actor = ['type' => 'users', 'id' => 'alice'];
-		$creationDT = new \DateTime();
-		$latestChildDT = new \DateTime('yesterday');
-		$object = ['type' => 'files', 'id' => 'file64'];
-		$referenceId = sha1('referenceId');
-		$metaData = ['last_edit_actor_id' => 'admin'];
-
-		$comment
-			->setId($id)
-			->setParentId($parentId)
-			->setTopmostParentId($topMostParentId)
-			->setChildrenCount($childrenCount)
-			->setMessage($message)
-			->setVerb($verb)
-			->setActor($actor['type'], $actor['id'])
-			->setCreationDateTime($creationDT)
-			->setLatestChildDateTime($latestChildDT)
-			->setObject($object['type'], $object['id'])
-			->setReferenceId($referenceId)
-			->setMetaData($metaData);
-
-		$this->assertSame($id, $comment->getId());
-		$this->assertSame($parentId, $comment->getParentId());
-		$this->assertSame($topMostParentId, $comment->getTopmostParentId());
-		$this->assertSame($childrenCount, $comment->getChildrenCount());
-		$this->assertSame($message, $comment->getMessage());
-		$this->assertSame($verb, $comment->getVerb());
-		$this->assertSame($actor['type'], $comment->getActorType());
-		$this->assertSame($actor['id'], $comment->getActorId());
-		$this->assertSame($creationDT, $comment->getCreationDateTime());
-		$this->assertSame($latestChildDT, $comment->getLatestChildDateTime());
-		$this->assertSame($object['type'], $comment->getObjectType());
-		$this->assertSame($object['id'], $comment->getObjectId());
-		$this->assertSame($referenceId, $comment->getReferenceId());
-		$this->assertSame($metaData, $comment->getMetaData());
-	}
-
-
-	public function testSetIdIllegalInput(): void {
-		$this->expectException(IllegalIDChangeException::class);
-
-		$comment = new Comment();
-
-		$comment->setId('c23');
-		$comment->setId('c17');
-	}
-
-	/**
-	 * @throws IllegalIDChangeException
-	 */
-	public function testResetId(): void {
-		$comment = new Comment();
-		$comment->setId('c23');
-		$comment->setId('');
-
-		$this->assertSame('', $comment->getId());
-	}
-
-	public static function simpleSetterProvider(): array {
-		return [
-			['Id', true],
-			['TopmostParentId', true],
-			['ParentId', true],
-			['Message', true],
-			['Verb', true],
-			['Verb', ''],
-			['ChildrenCount', true],
-		];
-	}
-
-	#[DataProvider(methodName: 'simpleSetterProvider')]
-	public function testSimpleSetterInvalidInput($field, $input): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$comment = new Comment();
-		$setter = 'set' . $field;
-
-		$comment->$setter($input);
-	}
-
-	public static function roleSetterProvider(): array {
-		return [
-			['Actor', true, true],
-			['Actor', 'users', true],
-			['Actor', true, 'alice'],
-			['Actor', ' ', ' '],
-			['Object', true, true],
-			['Object', 'files', true],
-			['Object', true, 'file64'],
-			['Object', ' ', ' '],
-		];
-	}
-
-	#[DataProvider(methodName: 'roleSetterProvider')]
-	public function testSetRoleInvalidInput($role, $type, $id): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$comment = new Comment();
-		$setter = 'set' . $role;
-		$comment->$setter($type, $id);
-	}
-
-
-	public function testSetUberlongMessage(): void {
-		$this->expectException(MessageTooLongException::class);
-
-		$comment = new Comment();
-		$msg = str_pad('', IComment::MAX_MESSAGE_LENGTH + 1, 'x');
-		$comment->setMessage($msg);
-	}
-
-	public static function mentionsProvider(): array {
-		return [
-			[
-				'@alice @bob look look, a cook!',
-				[['type' => 'user', 'id' => 'alice'], ['type' => 'user', 'id' => 'bob']],
-			],
-			[
-				'no mentions in this message',
-				[]
-			],
-			[
-				'@alice @bob look look, a duplication @alice test @bob!',
-				[['type' => 'user', 'id' => 'alice'], ['type' => 'user', 'id' => 'bob']],
-			],
-			[
-				'@alice is the author, notify @bob, nevertheless mention her!',
-				[['type' => 'user', 'id' => 'alice'], ['type' => 'user', 'id' => 'bob']],
-				/* author: */ 'alice'
-			],
-			[
-				'@foobar and @barfoo you should know, @foo@bar.com is valid'
-					. ' and so is @bar@foo.org@foobar.io I hope that clarifies everything.'
-					. ' cc @23452-4333-54353-2342 @yolo!'
-					. ' however the most important thing to know is that www.croissant.com/@oil is not valid'
-					. ' and won\'t match anything at all',
-				[
-					['type' => 'user', 'id' => 'bar@foo.org@foobar.io'],
-					['type' => 'user', 'id' => '23452-4333-54353-2342'],
-					['type' => 'user', 'id' => 'foo@bar.com'],
-					['type' => 'user', 'id' => 'foobar'],
-					['type' => 'user', 'id' => 'barfoo'],
-					['type' => 'user', 'id' => 'yolo'],
-				],
-			],
-			[
-				'@@chef is also a valid mention, no matter how strange it looks',
-				[['type' => 'user', 'id' => '@chef']],
-			],
-			[
-				'Also @"user with spaces" are now supported',
-				[['type' => 'user', 'id' => 'user with spaces']],
-			],
-			[
-				'Also @"guest/0123456789abcdef" are now supported',
-				[['type' => 'guest', 'id' => 'guest/0123456789abcdef']],
-			],
-			[
-				'Also @"group/My Group ID 321" are now supported',
-				[['type' => 'group', 'id' => 'My Group ID 321']],
-			],
-			[
-				'Welcome federation @"federated_group/My Group ID 321" @"federated_team/Former Cirle" @"federated_user/cloudId@http://example.tld:8080/nextcloud"! Now freshly supported',
-				[
-					['type' => 'federated_user', 'id' => 'cloudId@http://example.tld:8080/nextcloud'],
-					['type' => 'federated_group', 'id' => 'My Group ID 321'],
-					['type' => 'federated_team', 'id' => 'Former Cirle'],
-				],
-			],
-			[
-				'Emails are supported since 30.0.2 right? @"email/aa23d315de327cfc330f0401ea061005b2b0cdd45ec8346f12664dd1f34cb886"',
-				[
-					['type' => 'email', 'id' => 'aa23d315de327cfc330f0401ea061005b2b0cdd45ec8346f12664dd1f34cb886'],
-				],
-			],
-		];
-	}
-
-	#[DataProvider(methodName: 'mentionsProvider')]
-	public function testMentions(string $message, array $expectedMentions, ?string $author = null): void {
-		$comment = new Comment();
-		$comment->setMessage($message);
-		if (!is_null($author)) {
-			$comment->setActor('user', $author);
-		}
-		$mentions = $comment->getMentions();
-		$this->assertSame($expectedMentions, $mentions);
-	}
+    /**
+     * @throws IllegalIDChangeException
+     */
+    public function testSettersValidInput(): void {
+        $comment = new Comment();
+
+        $id = 'comment23';
+        $parentId = 'comment11.5';
+        $topMostParentId = 'comment11.0';
+        $childrenCount = 6;
+        $message = 'I like to comment comment';
+        $verb = 'comment';
+        $actor = ['type' => 'users', 'id' => 'alice'];
+        $creationDT = new \DateTime();
+        $latestChildDT = new \DateTime('yesterday');
+        $object = ['type' => 'files', 'id' => 'file64'];
+        $referenceId = sha1('referenceId');
+        $metaData = ['last_edit_actor_id' => 'admin'];
+
+        $comment
+            ->setId($id)
+            ->setParentId($parentId)
+            ->setTopmostParentId($topMostParentId)
+            ->setChildrenCount($childrenCount)
+            ->setMessage($message)
+            ->setVerb($verb)
+            ->setActor($actor['type'], $actor['id'])
+            ->setCreationDateTime($creationDT)
+            ->setLatestChildDateTime($latestChildDT)
+            ->setObject($object['type'], $object['id'])
+            ->setReferenceId($referenceId)
+            ->setMetaData($metaData);
+
+        $this->assertSame($id, $comment->getId());
+        $this->assertSame($parentId, $comment->getParentId());
+        $this->assertSame($topMostParentId, $comment->getTopmostParentId());
+        $this->assertSame($childrenCount, $comment->getChildrenCount());
+        $this->assertSame($message, $comment->getMessage());
+        $this->assertSame($verb, $comment->getVerb());
+        $this->assertSame($actor['type'], $comment->getActorType());
+        $this->assertSame($actor['id'], $comment->getActorId());
+        $this->assertSame($creationDT, $comment->getCreationDateTime());
+        $this->assertSame($latestChildDT, $comment->getLatestChildDateTime());
+        $this->assertSame($object['type'], $comment->getObjectType());
+        $this->assertSame($object['id'], $comment->getObjectId());
+        $this->assertSame($referenceId, $comment->getReferenceId());
+        $this->assertSame($metaData, $comment->getMetaData());
+    }
+
+
+    public function testSetIdIllegalInput(): void {
+        $this->expectException(IllegalIDChangeException::class);
+
+        $comment = new Comment();
+
+        $comment->setId('c23');
+        $comment->setId('c17');
+    }
+
+    /**
+     * @throws IllegalIDChangeException
+     */
+    public function testResetId(): void {
+        $comment = new Comment();
+        $comment->setId('c23');
+        $comment->setId('');
+
+        $this->assertSame('', $comment->getId());
+    }
+
+    public static function simpleSetterProvider(): array {
+        return [
+            ['Id', true],
+            ['TopmostParentId', true],
+            ['ParentId', true],
+            ['Message', true],
+            ['Verb', true],
+            ['Verb', ''],
+            ['ChildrenCount', true],
+        ];
+    }
+
+    #[DataProvider(methodName: 'simpleSetterProvider')]
+    public function testSimpleSetterInvalidInput($field, $input): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $comment = new Comment();
+        $setter = 'set' . $field;
+
+        $comment->$setter($input);
+    }
+
+    public static function roleSetterProvider(): array {
+        return [
+            ['Actor', true, true],
+            ['Actor', 'users', true],
+            ['Actor', true, 'alice'],
+            ['Actor', ' ', ' '],
+            ['Object', true, true],
+            ['Object', 'files', true],
+            ['Object', true, 'file64'],
+            ['Object', ' ', ' '],
+        ];
+    }
+
+    #[DataProvider(methodName: 'roleSetterProvider')]
+    public function testSetRoleInvalidInput($role, $type, $id): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $comment = new Comment();
+        $setter = 'set' . $role;
+        $comment->$setter($type, $id);
+    }
+
+
+    public function testSetUberlongMessage(): void {
+        $this->expectException(MessageTooLongException::class);
+
+        $comment = new Comment();
+        $msg = str_pad('', IComment::MAX_MESSAGE_LENGTH + 1, 'x');
+        $comment->setMessage($msg);
+    }
+
+    public static function mentionsProvider(): array {
+        return [
+            [
+                '@alice @bob look look, a cook!',
+                [['type' => 'user', 'id' => 'alice'], ['type' => 'user', 'id' => 'bob']],
+            ],
+            [
+                'no mentions in this message',
+                []
+            ],
+            [
+                '@alice @bob look look, a duplication @alice test @bob!',
+                [['type' => 'user', 'id' => 'alice'], ['type' => 'user', 'id' => 'bob']],
+            ],
+            [
+                '@alice is the author, notify @bob, nevertheless mention her!',
+                [['type' => 'user', 'id' => 'alice'], ['type' => 'user', 'id' => 'bob']],
+                /* author: */ 'alice'
+            ],
+            [
+                '@foobar and @barfoo you should know, @foo@bar.com is valid'
+                    . ' and so is @bar@foo.org@foobar.io I hope that clarifies everything.'
+                    . ' cc @23452-4333-54353-2342 @yolo!'
+                    . ' however the most important thing to know is that www.croissant.com/@oil is not valid'
+                    . ' and won\'t match anything at all',
+                [
+                    ['type' => 'user', 'id' => 'bar@foo.org@foobar.io'],
+                    ['type' => 'user', 'id' => '23452-4333-54353-2342'],
+                    ['type' => 'user', 'id' => 'foo@bar.com'],
+                    ['type' => 'user', 'id' => 'foobar'],
+                    ['type' => 'user', 'id' => 'barfoo'],
+                    ['type' => 'user', 'id' => 'yolo'],
+                ],
+            ],
+            [
+                '@@chef is also a valid mention, no matter how strange it looks',
+                [['type' => 'user', 'id' => '@chef']],
+            ],
+            [
+                'Also @"user with spaces" are now supported',
+                [['type' => 'user', 'id' => 'user with spaces']],
+            ],
+            [
+                'Also @"guest/0123456789abcdef" are now supported',
+                [['type' => 'guest', 'id' => 'guest/0123456789abcdef']],
+            ],
+            [
+                'Also @"group/My Group ID 321" are now supported',
+                [['type' => 'group', 'id' => 'My Group ID 321']],
+            ],
+            [
+                'Welcome federation @"federated_group/My Group ID 321" @"federated_team/Former Cirle" @"federated_user/cloudId@http://example.tld:8080/nextcloud"! Now freshly supported',
+                [
+                    ['type' => 'federated_user', 'id' => 'cloudId@http://example.tld:8080/nextcloud'],
+                    ['type' => 'federated_group', 'id' => 'My Group ID 321'],
+                    ['type' => 'federated_team', 'id' => 'Former Cirle'],
+                ],
+            ],
+            [
+                'Emails are supported since 30.0.2 right? @"email/aa23d315de327cfc330f0401ea061005b2b0cdd45ec8346f12664dd1f34cb886"',
+                [
+                    ['type' => 'email', 'id' => 'aa23d315de327cfc330f0401ea061005b2b0cdd45ec8346f12664dd1f34cb886'],
+                ],
+            ],
+        ];
+    }
+
+    #[DataProvider(methodName: 'mentionsProvider')]
+    public function testMentions(string $message, array $expectedMentions, ?string $author = null): void {
+        $comment = new Comment();
+        $comment->setMessage($message);
+        if (!is_null($author)) {
+            $comment->setActor('user', $author);
+        }
+        $mentions = $comment->getMentions();
+        $this->assertSame($expectedMentions, $mentions);
+    }
 }

tests/lib/Comments/ManagerTest.php

Indentation +2489 added lines, -2489 removed lines

@@ -37,2494 +37,2494 @@
  */
 #[Group(name: 'DB')]
 class ManagerTest extends TestCase {
-	private IDBConnection $connection;
-	private IRootFolder&MockObject $rootFolder;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = Server::get(IDBConnection::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-
-		/** @psalm-suppress DeprecatedMethod */
-		$sql = $this->connection->getDatabasePlatform()->getTruncateTableSQL('`*PREFIX*comments`');
-		$this->connection->prepare($sql)->execute();
-		/** @psalm-suppress DeprecatedMethod */
-		$sql = $this->connection->getDatabasePlatform()->getTruncateTableSQL('`*PREFIX*reactions`');
-		$this->connection->prepare($sql)->execute();
-	}
-
-	protected function addDatabaseEntry(?string $parentId, ?string $topmostParentId, ?\DateTimeInterface $creationDT = null, ?\DateTimeInterface $latestChildDT = null, $objectId = null, ?\DateTimeInterface $expireDate = null): string {
-		$creationDT ??= new \DateTime();
-		$latestChildDT ??= new \DateTime('yesterday');
-		$objectId ??= 'file64';
-
-		$qb = $this->connection->getQueryBuilder();
-		$qb
-			->insert('comments')
-			->values([
-				'parent_id' => $qb->createNamedParameter($parentId),
-				'topmost_parent_id' => $qb->createNamedParameter($topmostParentId),
-				'children_count' => $qb->createNamedParameter(2),
-				'actor_type' => $qb->createNamedParameter('users'),
-				'actor_id' => $qb->createNamedParameter('alice'),
-				'message' => $qb->createNamedParameter('nice one'),
-				'verb' => $qb->createNamedParameter('comment'),
-				'creation_timestamp' => $qb->createNamedParameter($creationDT, IQueryBuilder::PARAM_DATETIME_MUTABLE),
-				'latest_child_timestamp' => $qb->createNamedParameter($latestChildDT, IQueryBuilder::PARAM_DATETIME_MUTABLE),
-				'object_type' => $qb->createNamedParameter('files'),
-				'object_id' => $qb->createNamedParameter($objectId),
-				'expire_date' => $qb->createNamedParameter($expireDate, IQueryBuilder::PARAM_DATETIME_MUTABLE),
-				'reference_id' => $qb->createNamedParameter('referenceId'),
-				'meta_data' => $qb->createNamedParameter(json_encode(['last_edit_actor_id' => 'admin'])),
-			])
-			->executeStatement();
-
-		return (string)$qb->getLastInsertId();
-	}
-
-	protected function getManager(): Manager {
-		/** @psalm-suppress DeprecatedInterface No way around at the moment */
-		return new Manager(
-			$this->connection,
-			$this->createMock(LoggerInterface::class),
-			$this->createMock(IConfig::class),
-			$this->createMock(ITimeFactory::class),
-			new EmojiHelper($this->connection),
-			$this->createMock(IInitialStateService::class),
-			$this->rootFolder,
-			$this->createMock(IEventDispatcher::class),
-		);
-	}
-
-
-	public function testGetCommentNotFound(): void {
-		$this->expectException(NotFoundException::class);
-
-		$manager = $this->getManager();
-		$manager->get('22');
-	}
-
-
-	public function testGetCommentNotFoundInvalidInput(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$manager = $this->getManager();
-		$manager->get('unexisting22');
-	}
-
-	public function testGetComment(): void {
-		$manager = $this->getManager();
-
-		$creationDT = new \DateTime('yesterday');
-		$latestChildDT = new \DateTime();
-
-		$qb = $this->connection->getQueryBuilder();
-		$qb
-			->insert('comments')
-			->values([
-				'parent_id' => $qb->createNamedParameter('2'),
-				'topmost_parent_id' => $qb->createNamedParameter('1'),
-				'children_count' => $qb->createNamedParameter(2),
-				'actor_type' => $qb->createNamedParameter('users'),
-				'actor_id' => $qb->createNamedParameter('alice'),
-				'message' => $qb->createNamedParameter('nice one'),
-				'verb' => $qb->createNamedParameter('comment'),
-				'creation_timestamp' => $qb->createNamedParameter($creationDT, 'datetime'),
-				'latest_child_timestamp' => $qb->createNamedParameter($latestChildDT, 'datetime'),
-				'object_type' => $qb->createNamedParameter('files'),
-				'object_id' => $qb->createNamedParameter('file64'),
-				'reference_id' => $qb->createNamedParameter('referenceId'),
-				'meta_data' => $qb->createNamedParameter(json_encode(['last_edit_actor_id' => 'admin'])),
-			])
-			->executeStatement();
-
-		$id = (string)$qb->getLastInsertId();
-
-		$comment = $manager->get($id);
-		$this->assertInstanceOf(IComment::class, $comment);
-		$this->assertSame($id, $comment->getId());
-		$this->assertSame('2', $comment->getParentId());
-		$this->assertSame('1', $comment->getTopmostParentId());
-		$this->assertSame(2, $comment->getChildrenCount());
-		$this->assertSame('users', $comment->getActorType());
-		$this->assertSame('alice', $comment->getActorId());
-		$this->assertSame('nice one', $comment->getMessage());
-		$this->assertSame('comment', $comment->getVerb());
-		$this->assertSame('files', $comment->getObjectType());
-		$this->assertSame('file64', $comment->getObjectId());
-		$this->assertEquals($creationDT->getTimestamp(), $comment->getCreationDateTime()->getTimestamp());
-		$this->assertEquals($latestChildDT->getTimestamp(), $comment->getLatestChildDateTime()->getTimestamp());
-		$this->assertEquals('referenceId', $comment->getReferenceId());
-		$this->assertEquals(['last_edit_actor_id' => 'admin'], $comment->getMetaData());
-	}
-
-	public function testGetTreeNotFound(): void {
-		$this->expectException(NotFoundException::class);
-
-		$manager = $this->getManager();
-		$manager->getTree('22');
-	}
-
-	public function testGetTreeNotFoundInvalidIpnut(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$manager = $this->getManager();
-		$manager->getTree('unexisting22');
-	}
-
-	public function testGetTree(): void {
-		$headId = $this->addDatabaseEntry('0', '0');
-
-		$this->addDatabaseEntry($headId, $headId, new \DateTime('-3 hours'));
-		$this->addDatabaseEntry($headId, $headId, new \DateTime('-2 hours'));
-		$id = $this->addDatabaseEntry($headId, $headId, new \DateTime('-1 hour'));
-
-		$manager = $this->getManager();
-		$tree = $manager->getTree($headId);
-
-		// Verifying the root comment
-		$this->assertArrayHasKey('comment', $tree);
-		$this->assertInstanceOf(IComment::class, $tree['comment']);
-		$this->assertSame($headId, $tree['comment']->getId());
-		$this->assertArrayHasKey('replies', $tree);
-		$this->assertCount(3, $tree['replies']);
-
-		// one level deep
-		foreach ($tree['replies'] as $reply) {
-			$this->assertInstanceOf(IComment::class, $reply['comment']);
-			$this->assertSame((string)$id, $reply['comment']->getId());
-			$this->assertCount(0, $reply['replies']);
-			$id--;
-		}
-	}
-
-	public function testGetTreeNoReplies(): void {
-		$id = $this->addDatabaseEntry('0', '0');
-
-		$manager = $this->getManager();
-		$tree = $manager->getTree($id);
-
-		// Verifying the root comment
-		$this->assertArrayHasKey('comment', $tree);
-		$this->assertInstanceOf(IComment::class, $tree['comment']);
-		$this->assertSame($id, $tree['comment']->getId());
-		$this->assertArrayHasKey('replies', $tree);
-		$this->assertCount(0, $tree['replies']);
-	}
-
-	public function testGetTreeWithLimitAndOffset(): void {
-		$headId = $this->addDatabaseEntry('0', '0');
-
-		$this->addDatabaseEntry($headId, $headId, new \DateTime('-3 hours'));
-		$this->addDatabaseEntry($headId, $headId, new \DateTime('-2 hours'));
-		$this->addDatabaseEntry($headId, $headId, new \DateTime('-1 hour'));
-		$idToVerify = $this->addDatabaseEntry($headId, $headId, new \DateTime());
-
-		$manager = $this->getManager();
-
-		for ($offset = 0; $offset < 3; $offset += 2) {
-			$tree = $manager->getTree($headId, 2, $offset);
-
-			// Verifying the root comment
-			$this->assertArrayHasKey('comment', $tree);
-			$this->assertInstanceOf(IComment::class, $tree['comment']);
-			$this->assertSame($headId, $tree['comment']->getId());
-			$this->assertArrayHasKey('replies', $tree);
-			$this->assertCount(2, $tree['replies']);
-
-			// one level deep
-			foreach ($tree['replies'] as $reply) {
-				$this->assertInstanceOf(IComment::class, $reply['comment']);
-				$this->assertSame((string)$idToVerify, (string)$reply['comment']->getId());
-				$this->assertCount(0, $reply['replies']);
-				$idToVerify--;
-			}
-		}
-	}
-
-	public function testGetForObject(): void {
-		$this->addDatabaseEntry('0', '0');
-
-		$manager = $this->getManager();
-		$comments = $manager->getForObject('files', 'file64');
-
-		$this->assertIsArray($comments);
-		$this->assertCount(1, $comments);
-		$this->assertInstanceOf(IComment::class, $comments[0]);
-		$this->assertSame('nice one', $comments[0]->getMessage());
-	}
-
-	public function testGetForObjectWithLimitAndOffset(): void {
-		$this->addDatabaseEntry('0', '0', new \DateTime('-6 hours'));
-		$this->addDatabaseEntry('0', '0', new \DateTime('-5 hours'));
-		$this->addDatabaseEntry('1', '1', new \DateTime('-4 hours'));
-		$this->addDatabaseEntry('0', '0', new \DateTime('-3 hours'));
-		$this->addDatabaseEntry('2', '2', new \DateTime('-2 hours'));
-		$this->addDatabaseEntry('2', '2', new \DateTime('-1 hours'));
-		$idToVerify = $this->addDatabaseEntry('3', '1', new \DateTime());
-
-		$manager = $this->getManager();
-		$offset = 0;
-		do {
-			$comments = $manager->getForObject('files', 'file64', 3, $offset);
-
-			$this->assertIsArray($comments);
-			foreach ($comments as $key => $comment) {
-				$this->assertInstanceOf(IComment::class, $comment);
-				$this->assertSame('nice one', $comment->getMessage());
-				$this->assertSame((string)$idToVerify, $comment->getId(), 'ID wrong for comment ' . $key . ' on offset: ' . $offset);
-				$idToVerify--;
-			}
-			$offset += 3;
-		} while (count($comments) > 0);
-	}
-
-	public function testGetForObjectWithDateTimeConstraint(): void {
-		$this->addDatabaseEntry('0', '0', new \DateTime('-6 hours'));
-		$this->addDatabaseEntry('0', '0', new \DateTime('-5 hours'));
-		$id1 = $this->addDatabaseEntry('0', '0', new \DateTime('-3 hours'));
-		$id2 = $this->addDatabaseEntry('2', '2', new \DateTime('-2 hours'));
-
-		$manager = $this->getManager();
-		$comments = $manager->getForObject('files', 'file64', 0, 0, new \DateTime('-4 hours'));
-
-		$this->assertCount(2, $comments);
-		$this->assertSame($id2, $comments[0]->getId());
-		$this->assertSame($id1, $comments[1]->getId());
-	}
-
-	public function testGetForObjectWithLimitAndOffsetAndDateTimeConstraint(): void {
-		$this->addDatabaseEntry('0', '0', new \DateTime('-7 hours'));
-		$this->addDatabaseEntry('0', '0', new \DateTime('-6 hours'));
-		$this->addDatabaseEntry('1', '1', new \DateTime('-5 hours'));
-		$this->addDatabaseEntry('0', '0', new \DateTime('-3 hours'));
-		$this->addDatabaseEntry('2', '2', new \DateTime('-2 hours'));
-		$this->addDatabaseEntry('2', '2', new \DateTime('-1 hours'));
-		$idToVerify = $this->addDatabaseEntry('3', '1', new \DateTime());
-
-		$manager = $this->getManager();
-		$offset = 0;
-		do {
-			$comments = $manager->getForObject('files', 'file64', 3, $offset, new \DateTime('-4 hours'));
-
-			$this->assertIsArray($comments);
-			foreach ($comments as $comment) {
-				$this->assertInstanceOf(IComment::class, $comment);
-				$this->assertSame('nice one', $comment->getMessage());
-				$this->assertSame((string)$idToVerify, $comment->getId());
-				$this->assertGreaterThanOrEqual(4, $comment->getId());
-				$idToVerify--;
-			}
-			$offset += 3;
-		} while (count($comments) > 0);
-	}
-
-	public function testGetNumberOfCommentsForObject(): void {
-		for ($i = 1; $i < 5; $i++) {
-			$this->addDatabaseEntry('0', '0');
-		}
-
-		$manager = $this->getManager();
-
-		$amount = $manager->getNumberOfCommentsForObject('untype', '00');
-		$this->assertSame(0, $amount);
-
-		$amount = $manager->getNumberOfCommentsForObject('files', 'file64');
-		$this->assertSame(4, $amount);
-	}
-
-	public function testGetNumberOfUnreadCommentsForFolder(): void {
-		$folder = $this->createMock(Folder::class);
-		$fileIds = range(1111, 1114);
-		$children = array_map(function (int $id) {
-			$file = $this->createMock(Folder::class);
-			$file->method('getId')
-				->willReturn($id);
-			return $file;
-		}, $fileIds);
-		$folder->method('getId')->willReturn(1000);
-		$folder->method('getDirectoryListing')->willReturn($children);
-		$this->rootFolder->method('getFirstNodeById')
-			->with($folder->getId())
-			->willReturn($folder);
-
-		// 2 comment for 1111 with 1 before read marker
-		// 2 comments for 1112 with no read marker
-		// 1 comment for 1113 before read marker
-		// 1 comment for 1114 with no read marker
-		$this->addDatabaseEntry('0', '0', null, null, $fileIds[1]);
-		for ($i = 0; $i < 4; $i++) {
-			$this->addDatabaseEntry('0', '0', null, null, $fileIds[$i]);
-		}
-		$this->addDatabaseEntry('0', '0', (new \DateTime())->modify('-2 days'), null, $fileIds[0]);
-		/** @var IUser|\PHPUnit\Framework\MockObject\MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('comment_test');
-
-		$manager = $this->getManager();
-
-		$manager->setReadMark('files', (string)$fileIds[0], (new \DateTime())->modify('-1 days'), $user);
-		$manager->setReadMark('files', (string)$fileIds[2], (new \DateTime()), $user);
-
-		$amount = $manager->getNumberOfUnreadCommentsForFolder($folder->getId(), $user);
-		$this->assertEquals([
-			$fileIds[0] => 1,
-			$fileIds[1] => 2,
-			$fileIds[3] => 1,
-		], $amount);
-	}
-
-	#[DataProvider(methodName: 'dataGetForObjectSince')]
-	public function testGetForObjectSince(?int $lastKnown, string $order, int $limit, int $resultFrom, int $resultTo): void {
-		$ids = [];
-		$ids[] = $this->addDatabaseEntry('0', '0');
-		$ids[] = $this->addDatabaseEntry('0', '0');
-		$ids[] = $this->addDatabaseEntry('0', '0');
-		$ids[] = $this->addDatabaseEntry('0', '0');
-		$ids[] = $this->addDatabaseEntry('0', '0');
-
-		$manager = $this->getManager();
-		$comments = $manager->getForObjectSince('files', 'file64', ($lastKnown === null ? 0 : (int)$ids[$lastKnown]), $order, $limit);
-
-		$expected = array_slice($ids, $resultFrom, $resultTo - $resultFrom + 1);
-		if ($order === 'desc') {
-			$expected = array_reverse($expected);
-		}
-
-		$this->assertSame($expected, array_map(static fn (IComment $c): string => $c->getId(), $comments));
-	}
-
-	public static function dataGetForObjectSince(): array {
-		return [
-			[null, 'asc', 20, 0, 4],
-			[null, 'asc', 2, 0, 1],
-			[null, 'desc', 20, 0, 4],
-			[null, 'desc', 2, 3, 4],
-			[1, 'asc', 20, 2, 4],
-			[1, 'asc', 2, 2, 3],
-			[3, 'desc', 20, 0, 2],
-			[3, 'desc', 2, 1, 2],
-		];
-	}
-
-	public static function invalidCreateArgsProvider(): array {
-		return [
-			['', 'aId-1', 'oType-1', 'oId-1'],
-			['aType-1', '', 'oType-1', 'oId-1'],
-			['aType-1', 'aId-1', '', 'oId-1'],
-			['aType-1', 'aId-1', 'oType-1', ''],
-			[1, 'aId-1', 'oType-1', 'oId-1'],
-			['aType-1', 1, 'oType-1', 'oId-1'],
-			['aType-1', 'aId-1', 1, 'oId-1'],
-			['aType-1', 'aId-1', 'oType-1', 1],
-		];
-	}
-
-	#[DataProvider(methodName: 'invalidCreateArgsProvider')]
-	public function testCreateCommentInvalidArguments(string|int $aType, string|int $aId, string|int $oType, string|int $oId): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$manager = $this->getManager();
-		$manager->create($aType, $aId, $oType, $oId);
-	}
-
-	public function testCreateComment(): void {
-		$actorType = 'bot';
-		$actorId = 'bob';
-		$objectType = 'weather';
-		$objectId = 'bielefeld';
-
-		$comment = $this->getManager()->create($actorType, $actorId, $objectType, $objectId);
-		$this->assertInstanceOf(IComment::class, $comment);
-		$this->assertSame($actorType, $comment->getActorType());
-		$this->assertSame($actorId, $comment->getActorId());
-		$this->assertSame($objectType, $comment->getObjectType());
-		$this->assertSame($objectId, $comment->getObjectId());
-	}
-
-
-	public function testDelete(): void {
-		$this->expectException(NotFoundException::class);
-
-		$manager = $this->getManager();
-
-		$done = $manager->delete('404');
-		$this->assertFalse($done);
-
-		$done = $manager->delete('%');
-		$this->assertFalse($done);
-
-		$done = $manager->delete('');
-		$this->assertFalse($done);
-
-		$id = $this->addDatabaseEntry('0', '0');
-		$comment = $manager->get($id);
-		$this->assertInstanceOf(IComment::class, $comment);
-		$done = $manager->delete($id);
-		$this->assertTrue($done);
-		$manager->get($id);
-	}
-
-	#[DataProvider(methodName: 'providerTestSave')]
-	public function testSave(string $message, string $actorId, string $verb, ?string $parentId, ?string $id = ''): IComment {
-		$manager = $this->getManager();
-		$comment = new Comment();
-		$comment
-			->setId($id)
-			->setActor('users', $actorId)
-			->setObject('files', 'file64')
-			->setMessage($message)
-			->setVerb($verb);
-		if ($parentId) {
-			$comment->setParentId($parentId);
-		}
-
-		$saveSuccessful = $manager->save($comment);
-		$this->assertTrue($saveSuccessful, 'Comment saving was not successful');
-		$this->assertNotEquals('', $comment->getId(), 'Comment ID should not be empty');
-		$this->assertNotEquals('0', $comment->getId(), 'Comment ID should not be string \'0\'');
-		$this->assertNotNull($comment->getCreationDateTime(), 'Comment creation date should not be null');
-
-		$loadedComment = $manager->get($comment->getId());
-		$this->assertSame($comment->getMessage(), $loadedComment->getMessage(), 'Comment message should match');
-		$this->assertEquals($comment->getCreationDateTime()->getTimestamp(), $loadedComment->getCreationDateTime()->getTimestamp(), 'Comment creation date should match');
-		return $comment;
-	}
-
-	public static function providerTestSave(): array {
-		return [
-			['very beautiful, I am impressed!', 'alice', 'comment', null],
-		];
-	}
-
-	public function testSaveUpdate(): void {
-		$manager = $this->getManager();
-		$comment = new Comment();
-		$comment
-			->setActor('users', 'alice')
-			->setObject('files', 'file64')
-			->setMessage('very beautiful, I am impressed!')
-			->setVerb('comment')
-			->setExpireDate(new \DateTime('+2 hours'));
-
-		$manager->save($comment);
-
-		$loadedComment = $manager->get($comment->getId());
-		// Compare current object with database values
-		$this->assertSame($comment->getMessage(), $loadedComment->getMessage());
-		$this->assertSame(
-			$comment->getExpireDate()->format('Y-m-d H:i:s'),
-			$loadedComment->getExpireDate()->format('Y-m-d H:i:s')
-		);
-
-		// Preserve the original comment to compare after update
-		$original = clone $comment;
-
-		// Update values
-		$comment->setMessage('very beautiful, I am really so much impressed!')
-			->setExpireDate(new \DateTime('+1 hours'));
-		$manager->save($comment);
-
-		$loadedComment = $manager->get($comment->getId());
-		// Compare current object with database values
-		$this->assertSame($comment->getMessage(), $loadedComment->getMessage());
-		$this->assertSame(
-			$comment->getExpireDate()->format('Y-m-d H:i:s'),
-			$loadedComment->getExpireDate()->format('Y-m-d H:i:s')
-		);
-
-		// Compare original object with database values
-		$this->assertNotSame($original->getMessage(), $loadedComment->getMessage());
-		$this->assertNotSame(
-			$original->getExpireDate()->format('Y-m-d H:i:s'),
-			$loadedComment->getExpireDate()->format('Y-m-d H:i:s')
-		);
-	}
-
-
-	public function testSaveUpdateException(): void {
-		$manager = $this->getManager();
-		$comment = new Comment();
-		$comment
-			->setActor('users', 'alice')
-			->setObject('files', 'file64')
-			->setMessage('very beautiful, I am impressed!')
-			->setVerb('comment');
-
-		$manager->save($comment);
-
-		$manager->delete($comment->getId());
-
-		$comment->setMessage('very beautiful, I am really so much impressed!');
-		$this->expectException(NotFoundException::class);
-		$manager->save($comment);
-	}
-
-
-	public function testSaveIncomplete(): void {
-
-		$manager = $this->getManager();
-		$comment = new Comment();
-		$comment->setMessage('from no one to nothing');
-
-		$this->expectException(\UnexpectedValueException::class);
-		$manager->save($comment);
-	}
-
-	public function testSaveAsChild(): void {
-		$id = $this->addDatabaseEntry('0', '0');
-
-		$manager = $this->getManager();
-
-		for ($i = 0; $i < 3; $i++) {
-			$comment = new Comment();
-			$comment
-				->setActor('users', 'alice')
-				->setObject('files', 'file64')
-				->setParentId($id)
-				->setMessage('full ack')
-				->setVerb('comment')
-				// setting the creation time avoids using sleep() while making sure to test with different timestamps
-				->setCreationDateTime(new \DateTime('+' . $i . ' minutes'));
-
-			$manager->save($comment);
-
-			$this->assertSame($id, $comment->getTopmostParentId());
-			$parentComment = $manager->get($id);
-			$this->assertSame($i + 1, $parentComment->getChildrenCount());
-			$this->assertEquals($comment->getCreationDateTime()->getTimestamp(), $parentComment->getLatestChildDateTime()->getTimestamp());
-		}
-	}
-
-	public static function invalidActorArgsProvider(): array {
-		return
-			[
-				['', ''],
-				[1, 'alice'],
-				['users', 1],
-			];
-	}
-
-	#[DataProvider(methodName: 'invalidActorArgsProvider')]
-	public function testDeleteReferencesOfActorInvalidInput(string|int $type, string|int $id): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$manager = $this->getManager();
-		$manager->deleteReferencesOfActor($type, $id);
-	}
-
-	public function testDeleteReferencesOfActor(): void {
-		$ids = [];
-		$ids[] = $this->addDatabaseEntry('0', '0');
-		$ids[] = $this->addDatabaseEntry('0', '0');
-		$ids[] = $this->addDatabaseEntry('0', '0');
-
-		$manager = $this->getManager();
-
-		// just to make sure they are really set, with correct actor data
-		$comment = $manager->get($ids[1]);
-		$this->assertSame('users', $comment->getActorType());
-		$this->assertSame('alice', $comment->getActorId());
-
-		$wasSuccessful = $manager->deleteReferencesOfActor('users', 'alice');
-		$this->assertTrue($wasSuccessful);
-
-		foreach ($ids as $id) {
-			$comment = $manager->get($id);
-			$this->assertSame(ICommentsManager::DELETED_USER, $comment->getActorType());
-			$this->assertSame(ICommentsManager::DELETED_USER, $comment->getActorId());
-		}
-
-		// actor info is gone from DB, but when database interaction is alright,
-		// we still expect to get true back
-		$wasSuccessful = $manager->deleteReferencesOfActor('users', 'alice');
-		$this->assertTrue($wasSuccessful);
-	}
-
-	public function testDeleteReferencesOfActorWithUserManagement(): void {
-		$user = Server::get(IUserManager::class)->createUser('xenia', 'NotAnEasyPassword123456+');
-		$this->assertInstanceOf(IUser::class, $user);
-
-		$manager = Server::get(ICommentsManager::class);
-		$comment = $manager->create('users', $user->getUID(), 'files', 'file64');
-		$comment
-			->setMessage('Most important comment I ever left on the Internet.')
-			->setVerb('comment');
-		$status = $manager->save($comment);
-		$this->assertTrue($status);
-
-		$commentID = $comment->getId();
-		$user->delete();
-
-		$comment = $manager->get($commentID);
-		$this->assertSame(ICommentsManager::DELETED_USER, $comment->getActorType());
-		$this->assertSame(ICommentsManager::DELETED_USER, $comment->getActorId());
-	}
-
-	public static function invalidObjectArgsProvider(): array {
-		return
-			[
-				['', ''],
-				[1, 'file64'],
-				['files', 1],
-			];
-	}
-
-	#[DataProvider(methodName: 'invalidObjectArgsProvider')]
-	public function testDeleteCommentsAtObjectInvalidInput(string|int $type, string|int $id): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$manager = $this->getManager();
-		$manager->deleteCommentsAtObject($type, $id);
-	}
-
-	public function testDeleteCommentsAtObject(): void {
-		$ids = [];
-		$ids[] = $this->addDatabaseEntry('0', '0');
-		$ids[] = $this->addDatabaseEntry('0', '0');
-		$ids[] = $this->addDatabaseEntry('0', '0');
-
-		$manager = $this->getManager();
-
-		// just to make sure they are really set, with correct actor data
-		$comment = $manager->get($ids[1]);
-		$this->assertSame('files', $comment->getObjectType());
-		$this->assertSame('file64', $comment->getObjectId());
-
-		$wasSuccessful = $manager->deleteCommentsAtObject('files', 'file64');
-		$this->assertTrue($wasSuccessful);
-
-		$verified = 0;
-		foreach ($ids as $id) {
-			try {
-				$manager->get($id);
-			} catch (NotFoundException) {
-				$verified++;
-			}
-		}
-		$this->assertSame(3, $verified);
-
-		// actor info is gone from DB, but when database interaction is alright,
-		// we still expect to get true back
-		$wasSuccessful = $manager->deleteCommentsAtObject('files', 'file64');
-		$this->assertTrue($wasSuccessful);
-	}
-
-	public function testDeleteCommentsExpiredAtObjectTypeAndId(): void {
-		$ids = [];
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('+2 hours'));
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('+2 hours'));
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('+2 hours'));
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('-2 hours'));
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('-2 hours'));
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('-2 hours'));
-
-		/** @psalm-suppress DeprecatedInterface No way around at the moment */
-		$manager = new Manager(
-			$this->connection,
-			$this->createMock(LoggerInterface::class),
-			$this->createMock(IConfig::class),
-			Server::get(ITimeFactory::class),
-			new EmojiHelper($this->connection),
-			$this->createMock(IInitialStateService::class),
-			$this->rootFolder,
-			$this->createMock(IEventDispatcher::class)
-		);
-
-		// just to make sure they are really set, with correct actor data
-		$comment = $manager->get($ids[1]);
-		$this->assertSame('files', $comment->getObjectType());
-		$this->assertSame('file64', $comment->getObjectId());
-
-		$deleted = $manager->deleteCommentsExpiredAtObject('files', 'file64');
-		$this->assertTrue($deleted);
-
-		$deleted = 0;
-		$exists = 0;
-		foreach ($ids as $id) {
-			try {
-				$manager->get($id);
-				$exists++;
-			} catch (NotFoundException) {
-				$deleted++;
-			}
-		}
-		$this->assertSame(3, $exists);
-		$this->assertSame(3, $deleted);
-
-		// actor info is gone from DB, but when database interaction is alright,
-		// we still expect to get true back
-		$deleted = $manager->deleteCommentsExpiredAtObject('files', 'file64');
-		$this->assertFalse($deleted);
-	}
-
-	public function testDeleteCommentsExpiredAtObjectType(): void {
-		$ids = [];
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file1', new \DateTime('-2 hours'));
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file2', new \DateTime('-2 hours'));
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file3', new \DateTime('-2 hours'));
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file3', new \DateTime());
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file3', new \DateTime());
-		$ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file3', new \DateTime());
-
-		/** @psalm-suppress DeprecatedInterface No way around at the moment */
-		$manager = new Manager(
-			$this->connection,
-			$this->createMock(LoggerInterface::class),
-			$this->createMock(IConfig::class),
-			Server::get(ITimeFactory::class),
-			new EmojiHelper($this->connection),
-			$this->createMock(IInitialStateService::class),
-			$this->rootFolder,
-			$this->createMock(IEventDispatcher::class)
-		);
-
-		$deleted = $manager->deleteCommentsExpiredAtObject('files');
-		$this->assertTrue($deleted);
-
-		$deleted = 0;
-		$exists = 0;
-		foreach ($ids as $id) {
-			try {
-				$manager->get($id);
-				$exists++;
-			} catch (NotFoundException) {
-				$deleted++;
-			}
-		}
-		$this->assertSame(0, $exists);
-		$this->assertSame(6, $deleted);
-
-		// actor info is gone from DB, but when database interaction is alright,
-		// we still expect to get true back
-		$deleted = $manager->deleteCommentsExpiredAtObject('files');
-		$this->assertFalse($deleted);
-	}
-
-	public function testSetMarkRead(): void {
-		/** @var IUser|\PHPUnit\Framework\MockObject\MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('alice');
-
-		$dateTimeSet = new \DateTime();
-
-		$manager = $this->getManager();
-		$manager->setReadMark('robot', '36', $dateTimeSet, $user);
-
-		$dateTimeGet = $manager->getReadMark('robot', '36', $user);
-
-		$this->assertEquals($dateTimeSet->getTimestamp(), $dateTimeGet->getTimestamp());
-	}
-
-	public function testSetMarkReadUpdate(): void {
-		/** @var IUser|\PHPUnit\Framework\MockObject\MockObject $user */
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('alice');
-
-		$dateTimeSet = new \DateTime('yesterday');
-
-		$manager = $this->getManager();
-		$manager->setReadMark('robot', '36', $dateTimeSet, $user);
-
-		$dateTimeSet = new \DateTime('today');
-		$manager->setReadMark('robot', '36', $dateTimeSet, $user);
-
-		$dateTimeGet = $manager->getReadMark('robot', '36', $user);
-
-		$this->assertEquals($dateTimeSet, $dateTimeGet);
-	}
-
-	public function testReadMarkDeleteUser(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('alice');
-
-		$dateTimeSet = new \DateTime();
-
-		$manager = $this->getManager();
-		$manager->setReadMark('robot', '36', $dateTimeSet, $user);
-
-		$manager->deleteReadMarksFromUser($user);
-		$dateTimeGet = $manager->getReadMark('robot', '36', $user);
-
-		$this->assertNull($dateTimeGet);
-	}
-
-	public function testReadMarkDeleteObject(): void {
-		$user = $this->createMock(IUser::class);
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('alice');
-
-		$dateTimeSet = new \DateTime();
-
-		$manager = $this->getManager();
-		$manager->setReadMark('robot', '36', $dateTimeSet, $user);
-
-		$manager->deleteReadMarksOnObject('robot', '36');
-		$dateTimeGet = $manager->getReadMark('robot', '36', $user);
-
-		$this->assertNull($dateTimeGet);
-	}
-
-	public function testSendEvent(): void {
-		/** @psalm-suppress DeprecatedInterface Test for deprecated interface */
-		$handler1 = $this->createMock(ICommentsEventHandler::class);
-		$handler1->expects($this->exactly(4))
-			->method('handle');
+    private IDBConnection $connection;
+    private IRootFolder&MockObject $rootFolder;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = Server::get(IDBConnection::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+
+        /** @psalm-suppress DeprecatedMethod */
+        $sql = $this->connection->getDatabasePlatform()->getTruncateTableSQL('`*PREFIX*comments`');
+        $this->connection->prepare($sql)->execute();
+        /** @psalm-suppress DeprecatedMethod */
+        $sql = $this->connection->getDatabasePlatform()->getTruncateTableSQL('`*PREFIX*reactions`');
+        $this->connection->prepare($sql)->execute();
+    }
+
+    protected function addDatabaseEntry(?string $parentId, ?string $topmostParentId, ?\DateTimeInterface $creationDT = null, ?\DateTimeInterface $latestChildDT = null, $objectId = null, ?\DateTimeInterface $expireDate = null): string {
+        $creationDT ??= new \DateTime();
+        $latestChildDT ??= new \DateTime('yesterday');
+        $objectId ??= 'file64';
+
+        $qb = $this->connection->getQueryBuilder();
+        $qb
+            ->insert('comments')
+            ->values([
+                'parent_id' => $qb->createNamedParameter($parentId),
+                'topmost_parent_id' => $qb->createNamedParameter($topmostParentId),
+                'children_count' => $qb->createNamedParameter(2),
+                'actor_type' => $qb->createNamedParameter('users'),
+                'actor_id' => $qb->createNamedParameter('alice'),
+                'message' => $qb->createNamedParameter('nice one'),
+                'verb' => $qb->createNamedParameter('comment'),
+                'creation_timestamp' => $qb->createNamedParameter($creationDT, IQueryBuilder::PARAM_DATETIME_MUTABLE),
+                'latest_child_timestamp' => $qb->createNamedParameter($latestChildDT, IQueryBuilder::PARAM_DATETIME_MUTABLE),
+                'object_type' => $qb->createNamedParameter('files'),
+                'object_id' => $qb->createNamedParameter($objectId),
+                'expire_date' => $qb->createNamedParameter($expireDate, IQueryBuilder::PARAM_DATETIME_MUTABLE),
+                'reference_id' => $qb->createNamedParameter('referenceId'),
+                'meta_data' => $qb->createNamedParameter(json_encode(['last_edit_actor_id' => 'admin'])),
+            ])
+            ->executeStatement();
+
+        return (string)$qb->getLastInsertId();
+    }
+
+    protected function getManager(): Manager {
+        /** @psalm-suppress DeprecatedInterface No way around at the moment */
+        return new Manager(
+            $this->connection,
+            $this->createMock(LoggerInterface::class),
+            $this->createMock(IConfig::class),
+            $this->createMock(ITimeFactory::class),
+            new EmojiHelper($this->connection),
+            $this->createMock(IInitialStateService::class),
+            $this->rootFolder,
+            $this->createMock(IEventDispatcher::class),
+        );
+    }
+
+
+    public function testGetCommentNotFound(): void {
+        $this->expectException(NotFoundException::class);
+
+        $manager = $this->getManager();
+        $manager->get('22');
+    }
+
+
+    public function testGetCommentNotFoundInvalidInput(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $manager = $this->getManager();
+        $manager->get('unexisting22');
+    }
+
+    public function testGetComment(): void {
+        $manager = $this->getManager();
+
+        $creationDT = new \DateTime('yesterday');
+        $latestChildDT = new \DateTime();
+
+        $qb = $this->connection->getQueryBuilder();
+        $qb
+            ->insert('comments')
+            ->values([
+                'parent_id' => $qb->createNamedParameter('2'),
+                'topmost_parent_id' => $qb->createNamedParameter('1'),
+                'children_count' => $qb->createNamedParameter(2),
+                'actor_type' => $qb->createNamedParameter('users'),
+                'actor_id' => $qb->createNamedParameter('alice'),
+                'message' => $qb->createNamedParameter('nice one'),
+                'verb' => $qb->createNamedParameter('comment'),
+                'creation_timestamp' => $qb->createNamedParameter($creationDT, 'datetime'),
+                'latest_child_timestamp' => $qb->createNamedParameter($latestChildDT, 'datetime'),
+                'object_type' => $qb->createNamedParameter('files'),
+                'object_id' => $qb->createNamedParameter('file64'),
+                'reference_id' => $qb->createNamedParameter('referenceId'),
+                'meta_data' => $qb->createNamedParameter(json_encode(['last_edit_actor_id' => 'admin'])),
+            ])
+            ->executeStatement();
+
+        $id = (string)$qb->getLastInsertId();
+
+        $comment = $manager->get($id);
+        $this->assertInstanceOf(IComment::class, $comment);
+        $this->assertSame($id, $comment->getId());
+        $this->assertSame('2', $comment->getParentId());
+        $this->assertSame('1', $comment->getTopmostParentId());
+        $this->assertSame(2, $comment->getChildrenCount());
+        $this->assertSame('users', $comment->getActorType());
+        $this->assertSame('alice', $comment->getActorId());
+        $this->assertSame('nice one', $comment->getMessage());
+        $this->assertSame('comment', $comment->getVerb());
+        $this->assertSame('files', $comment->getObjectType());
+        $this->assertSame('file64', $comment->getObjectId());
+        $this->assertEquals($creationDT->getTimestamp(), $comment->getCreationDateTime()->getTimestamp());
+        $this->assertEquals($latestChildDT->getTimestamp(), $comment->getLatestChildDateTime()->getTimestamp());
+        $this->assertEquals('referenceId', $comment->getReferenceId());
+        $this->assertEquals(['last_edit_actor_id' => 'admin'], $comment->getMetaData());
+    }
+
+    public function testGetTreeNotFound(): void {
+        $this->expectException(NotFoundException::class);
+
+        $manager = $this->getManager();
+        $manager->getTree('22');
+    }
+
+    public function testGetTreeNotFoundInvalidIpnut(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $manager = $this->getManager();
+        $manager->getTree('unexisting22');
+    }
+
+    public function testGetTree(): void {
+        $headId = $this->addDatabaseEntry('0', '0');
+
+        $this->addDatabaseEntry($headId, $headId, new \DateTime('-3 hours'));
+        $this->addDatabaseEntry($headId, $headId, new \DateTime('-2 hours'));
+        $id = $this->addDatabaseEntry($headId, $headId, new \DateTime('-1 hour'));
+
+        $manager = $this->getManager();
+        $tree = $manager->getTree($headId);
+
+        // Verifying the root comment
+        $this->assertArrayHasKey('comment', $tree);
+        $this->assertInstanceOf(IComment::class, $tree['comment']);
+        $this->assertSame($headId, $tree['comment']->getId());
+        $this->assertArrayHasKey('replies', $tree);
+        $this->assertCount(3, $tree['replies']);
+
+        // one level deep
+        foreach ($tree['replies'] as $reply) {
+            $this->assertInstanceOf(IComment::class, $reply['comment']);
+            $this->assertSame((string)$id, $reply['comment']->getId());
+            $this->assertCount(0, $reply['replies']);
+            $id--;
+        }
+    }
+
+    public function testGetTreeNoReplies(): void {
+        $id = $this->addDatabaseEntry('0', '0');
+
+        $manager = $this->getManager();
+        $tree = $manager->getTree($id);
+
+        // Verifying the root comment
+        $this->assertArrayHasKey('comment', $tree);
+        $this->assertInstanceOf(IComment::class, $tree['comment']);
+        $this->assertSame($id, $tree['comment']->getId());
+        $this->assertArrayHasKey('replies', $tree);
+        $this->assertCount(0, $tree['replies']);
+    }
+
+    public function testGetTreeWithLimitAndOffset(): void {
+        $headId = $this->addDatabaseEntry('0', '0');
+
+        $this->addDatabaseEntry($headId, $headId, new \DateTime('-3 hours'));
+        $this->addDatabaseEntry($headId, $headId, new \DateTime('-2 hours'));
+        $this->addDatabaseEntry($headId, $headId, new \DateTime('-1 hour'));
+        $idToVerify = $this->addDatabaseEntry($headId, $headId, new \DateTime());
+
+        $manager = $this->getManager();
+
+        for ($offset = 0; $offset < 3; $offset += 2) {
+            $tree = $manager->getTree($headId, 2, $offset);
+
+            // Verifying the root comment
+            $this->assertArrayHasKey('comment', $tree);
+            $this->assertInstanceOf(IComment::class, $tree['comment']);
+            $this->assertSame($headId, $tree['comment']->getId());
+            $this->assertArrayHasKey('replies', $tree);
+            $this->assertCount(2, $tree['replies']);
+
+            // one level deep
+            foreach ($tree['replies'] as $reply) {
+                $this->assertInstanceOf(IComment::class, $reply['comment']);
+                $this->assertSame((string)$idToVerify, (string)$reply['comment']->getId());
+                $this->assertCount(0, $reply['replies']);
+                $idToVerify--;
+            }
+        }
+    }
+
+    public function testGetForObject(): void {
+        $this->addDatabaseEntry('0', '0');
+
+        $manager = $this->getManager();
+        $comments = $manager->getForObject('files', 'file64');
+
+        $this->assertIsArray($comments);
+        $this->assertCount(1, $comments);
+        $this->assertInstanceOf(IComment::class, $comments[0]);
+        $this->assertSame('nice one', $comments[0]->getMessage());
+    }
+
+    public function testGetForObjectWithLimitAndOffset(): void {
+        $this->addDatabaseEntry('0', '0', new \DateTime('-6 hours'));
+        $this->addDatabaseEntry('0', '0', new \DateTime('-5 hours'));
+        $this->addDatabaseEntry('1', '1', new \DateTime('-4 hours'));
+        $this->addDatabaseEntry('0', '0', new \DateTime('-3 hours'));
+        $this->addDatabaseEntry('2', '2', new \DateTime('-2 hours'));
+        $this->addDatabaseEntry('2', '2', new \DateTime('-1 hours'));
+        $idToVerify = $this->addDatabaseEntry('3', '1', new \DateTime());
+
+        $manager = $this->getManager();
+        $offset = 0;
+        do {
+            $comments = $manager->getForObject('files', 'file64', 3, $offset);
+
+            $this->assertIsArray($comments);
+            foreach ($comments as $key => $comment) {
+                $this->assertInstanceOf(IComment::class, $comment);
+                $this->assertSame('nice one', $comment->getMessage());
+                $this->assertSame((string)$idToVerify, $comment->getId(), 'ID wrong for comment ' . $key . ' on offset: ' . $offset);
+                $idToVerify--;
+            }
+            $offset += 3;
+        } while (count($comments) > 0);
+    }
+
+    public function testGetForObjectWithDateTimeConstraint(): void {
+        $this->addDatabaseEntry('0', '0', new \DateTime('-6 hours'));
+        $this->addDatabaseEntry('0', '0', new \DateTime('-5 hours'));
+        $id1 = $this->addDatabaseEntry('0', '0', new \DateTime('-3 hours'));
+        $id2 = $this->addDatabaseEntry('2', '2', new \DateTime('-2 hours'));
+
+        $manager = $this->getManager();
+        $comments = $manager->getForObject('files', 'file64', 0, 0, new \DateTime('-4 hours'));
+
+        $this->assertCount(2, $comments);
+        $this->assertSame($id2, $comments[0]->getId());
+        $this->assertSame($id1, $comments[1]->getId());
+    }
+
+    public function testGetForObjectWithLimitAndOffsetAndDateTimeConstraint(): void {
+        $this->addDatabaseEntry('0', '0', new \DateTime('-7 hours'));
+        $this->addDatabaseEntry('0', '0', new \DateTime('-6 hours'));
+        $this->addDatabaseEntry('1', '1', new \DateTime('-5 hours'));
+        $this->addDatabaseEntry('0', '0', new \DateTime('-3 hours'));
+        $this->addDatabaseEntry('2', '2', new \DateTime('-2 hours'));
+        $this->addDatabaseEntry('2', '2', new \DateTime('-1 hours'));
+        $idToVerify = $this->addDatabaseEntry('3', '1', new \DateTime());
+
+        $manager = $this->getManager();
+        $offset = 0;
+        do {
+            $comments = $manager->getForObject('files', 'file64', 3, $offset, new \DateTime('-4 hours'));
+
+            $this->assertIsArray($comments);
+            foreach ($comments as $comment) {
+                $this->assertInstanceOf(IComment::class, $comment);
+                $this->assertSame('nice one', $comment->getMessage());
+                $this->assertSame((string)$idToVerify, $comment->getId());
+                $this->assertGreaterThanOrEqual(4, $comment->getId());
+                $idToVerify--;
+            }
+            $offset += 3;
+        } while (count($comments) > 0);
+    }
+
+    public function testGetNumberOfCommentsForObject(): void {
+        for ($i = 1; $i < 5; $i++) {
+            $this->addDatabaseEntry('0', '0');
+        }
+
+        $manager = $this->getManager();
+
+        $amount = $manager->getNumberOfCommentsForObject('untype', '00');
+        $this->assertSame(0, $amount);
+
+        $amount = $manager->getNumberOfCommentsForObject('files', 'file64');
+        $this->assertSame(4, $amount);
+    }
+
+    public function testGetNumberOfUnreadCommentsForFolder(): void {
+        $folder = $this->createMock(Folder::class);
+        $fileIds = range(1111, 1114);
+        $children = array_map(function (int $id) {
+            $file = $this->createMock(Folder::class);
+            $file->method('getId')
+                ->willReturn($id);
+            return $file;
+        }, $fileIds);
+        $folder->method('getId')->willReturn(1000);
+        $folder->method('getDirectoryListing')->willReturn($children);
+        $this->rootFolder->method('getFirstNodeById')
+            ->with($folder->getId())
+            ->willReturn($folder);
+
+        // 2 comment for 1111 with 1 before read marker
+        // 2 comments for 1112 with no read marker
+        // 1 comment for 1113 before read marker
+        // 1 comment for 1114 with no read marker
+        $this->addDatabaseEntry('0', '0', null, null, $fileIds[1]);
+        for ($i = 0; $i < 4; $i++) {
+            $this->addDatabaseEntry('0', '0', null, null, $fileIds[$i]);
+        }
+        $this->addDatabaseEntry('0', '0', (new \DateTime())->modify('-2 days'), null, $fileIds[0]);
+        /** @var IUser|\PHPUnit\Framework\MockObject\MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('comment_test');
+
+        $manager = $this->getManager();
+
+        $manager->setReadMark('files', (string)$fileIds[0], (new \DateTime())->modify('-1 days'), $user);
+        $manager->setReadMark('files', (string)$fileIds[2], (new \DateTime()), $user);
+
+        $amount = $manager->getNumberOfUnreadCommentsForFolder($folder->getId(), $user);
+        $this->assertEquals([
+            $fileIds[0] => 1,
+            $fileIds[1] => 2,
+            $fileIds[3] => 1,
+        ], $amount);
+    }
+
+    #[DataProvider(methodName: 'dataGetForObjectSince')]
+    public function testGetForObjectSince(?int $lastKnown, string $order, int $limit, int $resultFrom, int $resultTo): void {
+        $ids = [];
+        $ids[] = $this->addDatabaseEntry('0', '0');
+        $ids[] = $this->addDatabaseEntry('0', '0');
+        $ids[] = $this->addDatabaseEntry('0', '0');
+        $ids[] = $this->addDatabaseEntry('0', '0');
+        $ids[] = $this->addDatabaseEntry('0', '0');
+
+        $manager = $this->getManager();
+        $comments = $manager->getForObjectSince('files', 'file64', ($lastKnown === null ? 0 : (int)$ids[$lastKnown]), $order, $limit);
+
+        $expected = array_slice($ids, $resultFrom, $resultTo - $resultFrom + 1);
+        if ($order === 'desc') {
+            $expected = array_reverse($expected);
+        }
+
+        $this->assertSame($expected, array_map(static fn (IComment $c): string => $c->getId(), $comments));
+    }
+
+    public static function dataGetForObjectSince(): array {
+        return [
+            [null, 'asc', 20, 0, 4],
+            [null, 'asc', 2, 0, 1],
+            [null, 'desc', 20, 0, 4],
+            [null, 'desc', 2, 3, 4],
+            [1, 'asc', 20, 2, 4],
+            [1, 'asc', 2, 2, 3],
+            [3, 'desc', 20, 0, 2],
+            [3, 'desc', 2, 1, 2],
+        ];
+    }
+
+    public static function invalidCreateArgsProvider(): array {
+        return [
+            ['', 'aId-1', 'oType-1', 'oId-1'],
+            ['aType-1', '', 'oType-1', 'oId-1'],
+            ['aType-1', 'aId-1', '', 'oId-1'],
+            ['aType-1', 'aId-1', 'oType-1', ''],
+            [1, 'aId-1', 'oType-1', 'oId-1'],
+            ['aType-1', 1, 'oType-1', 'oId-1'],
+            ['aType-1', 'aId-1', 1, 'oId-1'],
+            ['aType-1', 'aId-1', 'oType-1', 1],
+        ];
+    }
+
+    #[DataProvider(methodName: 'invalidCreateArgsProvider')]
+    public function testCreateCommentInvalidArguments(string|int $aType, string|int $aId, string|int $oType, string|int $oId): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $manager = $this->getManager();
+        $manager->create($aType, $aId, $oType, $oId);
+    }
+
+    public function testCreateComment(): void {
+        $actorType = 'bot';
+        $actorId = 'bob';
+        $objectType = 'weather';
+        $objectId = 'bielefeld';
+
+        $comment = $this->getManager()->create($actorType, $actorId, $objectType, $objectId);
+        $this->assertInstanceOf(IComment::class, $comment);
+        $this->assertSame($actorType, $comment->getActorType());
+        $this->assertSame($actorId, $comment->getActorId());
+        $this->assertSame($objectType, $comment->getObjectType());
+        $this->assertSame($objectId, $comment->getObjectId());
+    }
+
+
+    public function testDelete(): void {
+        $this->expectException(NotFoundException::class);
+
+        $manager = $this->getManager();
+
+        $done = $manager->delete('404');
+        $this->assertFalse($done);
+
+        $done = $manager->delete('%');
+        $this->assertFalse($done);
+
+        $done = $manager->delete('');
+        $this->assertFalse($done);
+
+        $id = $this->addDatabaseEntry('0', '0');
+        $comment = $manager->get($id);
+        $this->assertInstanceOf(IComment::class, $comment);
+        $done = $manager->delete($id);
+        $this->assertTrue($done);
+        $manager->get($id);
+    }
+
+    #[DataProvider(methodName: 'providerTestSave')]
+    public function testSave(string $message, string $actorId, string $verb, ?string $parentId, ?string $id = ''): IComment {
+        $manager = $this->getManager();
+        $comment = new Comment();
+        $comment
+            ->setId($id)
+            ->setActor('users', $actorId)
+            ->setObject('files', 'file64')
+            ->setMessage($message)
+            ->setVerb($verb);
+        if ($parentId) {
+            $comment->setParentId($parentId);
+        }
+
+        $saveSuccessful = $manager->save($comment);
+        $this->assertTrue($saveSuccessful, 'Comment saving was not successful');
+        $this->assertNotEquals('', $comment->getId(), 'Comment ID should not be empty');
+        $this->assertNotEquals('0', $comment->getId(), 'Comment ID should not be string \'0\'');
+        $this->assertNotNull($comment->getCreationDateTime(), 'Comment creation date should not be null');
+
+        $loadedComment = $manager->get($comment->getId());
+        $this->assertSame($comment->getMessage(), $loadedComment->getMessage(), 'Comment message should match');
+        $this->assertEquals($comment->getCreationDateTime()->getTimestamp(), $loadedComment->getCreationDateTime()->getTimestamp(), 'Comment creation date should match');
+        return $comment;
+    }
+
+    public static function providerTestSave(): array {
+        return [
+            ['very beautiful, I am impressed!', 'alice', 'comment', null],
+        ];
+    }
+
+    public function testSaveUpdate(): void {
+        $manager = $this->getManager();
+        $comment = new Comment();
+        $comment
+            ->setActor('users', 'alice')
+            ->setObject('files', 'file64')
+            ->setMessage('very beautiful, I am impressed!')
+            ->setVerb('comment')
+            ->setExpireDate(new \DateTime('+2 hours'));
+
+        $manager->save($comment);
+
+        $loadedComment = $manager->get($comment->getId());
+        // Compare current object with database values
+        $this->assertSame($comment->getMessage(), $loadedComment->getMessage());
+        $this->assertSame(
+            $comment->getExpireDate()->format('Y-m-d H:i:s'),
+            $loadedComment->getExpireDate()->format('Y-m-d H:i:s')
+        );
+
+        // Preserve the original comment to compare after update
+        $original = clone $comment;
+
+        // Update values
+        $comment->setMessage('very beautiful, I am really so much impressed!')
+            ->setExpireDate(new \DateTime('+1 hours'));
+        $manager->save($comment);
+
+        $loadedComment = $manager->get($comment->getId());
+        // Compare current object with database values
+        $this->assertSame($comment->getMessage(), $loadedComment->getMessage());
+        $this->assertSame(
+            $comment->getExpireDate()->format('Y-m-d H:i:s'),
+            $loadedComment->getExpireDate()->format('Y-m-d H:i:s')
+        );
+
+        // Compare original object with database values
+        $this->assertNotSame($original->getMessage(), $loadedComment->getMessage());
+        $this->assertNotSame(
+            $original->getExpireDate()->format('Y-m-d H:i:s'),
+            $loadedComment->getExpireDate()->format('Y-m-d H:i:s')
+        );
+    }
+
+
+    public function testSaveUpdateException(): void {
+        $manager = $this->getManager();
+        $comment = new Comment();
+        $comment
+            ->setActor('users', 'alice')
+            ->setObject('files', 'file64')
+            ->setMessage('very beautiful, I am impressed!')
+            ->setVerb('comment');
+
+        $manager->save($comment);
+
+        $manager->delete($comment->getId());
+
+        $comment->setMessage('very beautiful, I am really so much impressed!');
+        $this->expectException(NotFoundException::class);
+        $manager->save($comment);
+    }
+
+
+    public function testSaveIncomplete(): void {
+
+        $manager = $this->getManager();
+        $comment = new Comment();
+        $comment->setMessage('from no one to nothing');
+
+        $this->expectException(\UnexpectedValueException::class);
+        $manager->save($comment);
+    }
+
+    public function testSaveAsChild(): void {
+        $id = $this->addDatabaseEntry('0', '0');
+
+        $manager = $this->getManager();
+
+        for ($i = 0; $i < 3; $i++) {
+            $comment = new Comment();
+            $comment
+                ->setActor('users', 'alice')
+                ->setObject('files', 'file64')
+                ->setParentId($id)
+                ->setMessage('full ack')
+                ->setVerb('comment')
+                // setting the creation time avoids using sleep() while making sure to test with different timestamps
+                ->setCreationDateTime(new \DateTime('+' . $i . ' minutes'));
+
+            $manager->save($comment);
+
+            $this->assertSame($id, $comment->getTopmostParentId());
+            $parentComment = $manager->get($id);
+            $this->assertSame($i + 1, $parentComment->getChildrenCount());
+            $this->assertEquals($comment->getCreationDateTime()->getTimestamp(), $parentComment->getLatestChildDateTime()->getTimestamp());
+        }
+    }
+
+    public static function invalidActorArgsProvider(): array {
+        return
+            [
+                ['', ''],
+                [1, 'alice'],
+                ['users', 1],
+            ];
+    }
+
+    #[DataProvider(methodName: 'invalidActorArgsProvider')]
+    public function testDeleteReferencesOfActorInvalidInput(string|int $type, string|int $id): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $manager = $this->getManager();
+        $manager->deleteReferencesOfActor($type, $id);
+    }
+
+    public function testDeleteReferencesOfActor(): void {
+        $ids = [];
+        $ids[] = $this->addDatabaseEntry('0', '0');
+        $ids[] = $this->addDatabaseEntry('0', '0');
+        $ids[] = $this->addDatabaseEntry('0', '0');
+
+        $manager = $this->getManager();
+
+        // just to make sure they are really set, with correct actor data
+        $comment = $manager->get($ids[1]);
+        $this->assertSame('users', $comment->getActorType());
+        $this->assertSame('alice', $comment->getActorId());
+
+        $wasSuccessful = $manager->deleteReferencesOfActor('users', 'alice');
+        $this->assertTrue($wasSuccessful);
+
+        foreach ($ids as $id) {
+            $comment = $manager->get($id);
+            $this->assertSame(ICommentsManager::DELETED_USER, $comment->getActorType());
+            $this->assertSame(ICommentsManager::DELETED_USER, $comment->getActorId());
+        }
+
+        // actor info is gone from DB, but when database interaction is alright,
+        // we still expect to get true back
+        $wasSuccessful = $manager->deleteReferencesOfActor('users', 'alice');
+        $this->assertTrue($wasSuccessful);
+    }
+
+    public function testDeleteReferencesOfActorWithUserManagement(): void {
+        $user = Server::get(IUserManager::class)->createUser('xenia', 'NotAnEasyPassword123456+');
+        $this->assertInstanceOf(IUser::class, $user);
+
+        $manager = Server::get(ICommentsManager::class);
+        $comment = $manager->create('users', $user->getUID(), 'files', 'file64');
+        $comment
+            ->setMessage('Most important comment I ever left on the Internet.')
+            ->setVerb('comment');
+        $status = $manager->save($comment);
+        $this->assertTrue($status);
+
+        $commentID = $comment->getId();
+        $user->delete();
+
+        $comment = $manager->get($commentID);
+        $this->assertSame(ICommentsManager::DELETED_USER, $comment->getActorType());
+        $this->assertSame(ICommentsManager::DELETED_USER, $comment->getActorId());
+    }
+
+    public static function invalidObjectArgsProvider(): array {
+        return
+            [
+                ['', ''],
+                [1, 'file64'],
+                ['files', 1],
+            ];
+    }
+
+    #[DataProvider(methodName: 'invalidObjectArgsProvider')]
+    public function testDeleteCommentsAtObjectInvalidInput(string|int $type, string|int $id): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $manager = $this->getManager();
+        $manager->deleteCommentsAtObject($type, $id);
+    }
+
+    public function testDeleteCommentsAtObject(): void {
+        $ids = [];
+        $ids[] = $this->addDatabaseEntry('0', '0');
+        $ids[] = $this->addDatabaseEntry('0', '0');
+        $ids[] = $this->addDatabaseEntry('0', '0');
+
+        $manager = $this->getManager();
+
+        // just to make sure they are really set, with correct actor data
+        $comment = $manager->get($ids[1]);
+        $this->assertSame('files', $comment->getObjectType());
+        $this->assertSame('file64', $comment->getObjectId());
+
+        $wasSuccessful = $manager->deleteCommentsAtObject('files', 'file64');
+        $this->assertTrue($wasSuccessful);
+
+        $verified = 0;
+        foreach ($ids as $id) {
+            try {
+                $manager->get($id);
+            } catch (NotFoundException) {
+                $verified++;
+            }
+        }
+        $this->assertSame(3, $verified);
+
+        // actor info is gone from DB, but when database interaction is alright,
+        // we still expect to get true back
+        $wasSuccessful = $manager->deleteCommentsAtObject('files', 'file64');
+        $this->assertTrue($wasSuccessful);
+    }
+
+    public function testDeleteCommentsExpiredAtObjectTypeAndId(): void {
+        $ids = [];
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('+2 hours'));
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('+2 hours'));
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('+2 hours'));
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('-2 hours'));
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('-2 hours'));
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, null, new \DateTime('-2 hours'));
+
+        /** @psalm-suppress DeprecatedInterface No way around at the moment */
+        $manager = new Manager(
+            $this->connection,
+            $this->createMock(LoggerInterface::class),
+            $this->createMock(IConfig::class),
+            Server::get(ITimeFactory::class),
+            new EmojiHelper($this->connection),
+            $this->createMock(IInitialStateService::class),
+            $this->rootFolder,
+            $this->createMock(IEventDispatcher::class)
+        );
+
+        // just to make sure they are really set, with correct actor data
+        $comment = $manager->get($ids[1]);
+        $this->assertSame('files', $comment->getObjectType());
+        $this->assertSame('file64', $comment->getObjectId());
+
+        $deleted = $manager->deleteCommentsExpiredAtObject('files', 'file64');
+        $this->assertTrue($deleted);
+
+        $deleted = 0;
+        $exists = 0;
+        foreach ($ids as $id) {
+            try {
+                $manager->get($id);
+                $exists++;
+            } catch (NotFoundException) {
+                $deleted++;
+            }
+        }
+        $this->assertSame(3, $exists);
+        $this->assertSame(3, $deleted);
+
+        // actor info is gone from DB, but when database interaction is alright,
+        // we still expect to get true back
+        $deleted = $manager->deleteCommentsExpiredAtObject('files', 'file64');
+        $this->assertFalse($deleted);
+    }
+
+    public function testDeleteCommentsExpiredAtObjectType(): void {
+        $ids = [];
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file1', new \DateTime('-2 hours'));
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file2', new \DateTime('-2 hours'));
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file3', new \DateTime('-2 hours'));
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file3', new \DateTime());
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file3', new \DateTime());
+        $ids[] = $this->addDatabaseEntry('0', '0', null, null, 'file3', new \DateTime());
+
+        /** @psalm-suppress DeprecatedInterface No way around at the moment */
+        $manager = new Manager(
+            $this->connection,
+            $this->createMock(LoggerInterface::class),
+            $this->createMock(IConfig::class),
+            Server::get(ITimeFactory::class),
+            new EmojiHelper($this->connection),
+            $this->createMock(IInitialStateService::class),
+            $this->rootFolder,
+            $this->createMock(IEventDispatcher::class)
+        );
+
+        $deleted = $manager->deleteCommentsExpiredAtObject('files');
+        $this->assertTrue($deleted);
+
+        $deleted = 0;
+        $exists = 0;
+        foreach ($ids as $id) {
+            try {
+                $manager->get($id);
+                $exists++;
+            } catch (NotFoundException) {
+                $deleted++;
+            }
+        }
+        $this->assertSame(0, $exists);
+        $this->assertSame(6, $deleted);
+
+        // actor info is gone from DB, but when database interaction is alright,
+        // we still expect to get true back
+        $deleted = $manager->deleteCommentsExpiredAtObject('files');
+        $this->assertFalse($deleted);
+    }
+
+    public function testSetMarkRead(): void {
+        /** @var IUser|\PHPUnit\Framework\MockObject\MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('alice');
+
+        $dateTimeSet = new \DateTime();
+
+        $manager = $this->getManager();
+        $manager->setReadMark('robot', '36', $dateTimeSet, $user);
+
+        $dateTimeGet = $manager->getReadMark('robot', '36', $user);
+
+        $this->assertEquals($dateTimeSet->getTimestamp(), $dateTimeGet->getTimestamp());
+    }
+
+    public function testSetMarkReadUpdate(): void {
+        /** @var IUser|\PHPUnit\Framework\MockObject\MockObject $user */
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('alice');
+
+        $dateTimeSet = new \DateTime('yesterday');
+
+        $manager = $this->getManager();
+        $manager->setReadMark('robot', '36', $dateTimeSet, $user);
+
+        $dateTimeSet = new \DateTime('today');
+        $manager->setReadMark('robot', '36', $dateTimeSet, $user);
+
+        $dateTimeGet = $manager->getReadMark('robot', '36', $user);
+
+        $this->assertEquals($dateTimeSet, $dateTimeGet);
+    }
+
+    public function testReadMarkDeleteUser(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('alice');
+
+        $dateTimeSet = new \DateTime();
+
+        $manager = $this->getManager();
+        $manager->setReadMark('robot', '36', $dateTimeSet, $user);
+
+        $manager->deleteReadMarksFromUser($user);
+        $dateTimeGet = $manager->getReadMark('robot', '36', $user);
+
+        $this->assertNull($dateTimeGet);
+    }
+
+    public function testReadMarkDeleteObject(): void {
+        $user = $this->createMock(IUser::class);
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('alice');
+
+        $dateTimeSet = new \DateTime();
+
+        $manager = $this->getManager();
+        $manager->setReadMark('robot', '36', $dateTimeSet, $user);
+
+        $manager->deleteReadMarksOnObject('robot', '36');
+        $dateTimeGet = $manager->getReadMark('robot', '36', $user);
+
+        $this->assertNull($dateTimeGet);
+    }
+
+    public function testSendEvent(): void {
+        /** @psalm-suppress DeprecatedInterface Test for deprecated interface */
+        $handler1 = $this->createMock(ICommentsEventHandler::class);
+        $handler1->expects($this->exactly(4))
+            ->method('handle');
 
-		/** @psalm-suppress DeprecatedInterface Test for deprecated interface */
-		$handler2 = $this->createMock(ICommentsEventHandler::class);
-		$handler1->expects($this->exactly(4))
-			->method('handle');
-
-		$manager = $this->getManager();
-		$manager->registerEventHandler(function () use ($handler1) {
-			return $handler1;
-		});
-		$manager->registerEventHandler(function () use ($handler2) {
-			return $handler2;
-		});
-
-		$comment = new Comment();
-		$comment
-			->setActor('users', 'alice')
-			->setObject('files', 'file64')
-			->setMessage('very beautiful, I am impressed!')
-			->setVerb('comment');
-
-		// Add event
-		$manager->save($comment);
-
-		// Update event
-		$comment->setMessage('Different topic');
-		$manager->save($comment);
-
-		// Delete event
-		$manager->delete($comment->getId());
-	}
-
-	public function testResolveDisplayName(): void {
-		$manager = $this->getManager();
-
-		$planetClosure = function ($name) {
-			return ucfirst($name);
-		};
-
-		$galaxyClosure = function ($name) {
-			return strtoupper($name);
-		};
-
-		$manager->registerDisplayNameResolver('planet', $planetClosure);
-		$manager->registerDisplayNameResolver('galaxy', $galaxyClosure);
-
-		$this->assertSame('Neptune', $manager->resolveDisplayName('planet', 'neptune'));
-		$this->assertSame('SOMBRERO', $manager->resolveDisplayName('galaxy', 'sombrero'));
-	}
-
-
-	public function testRegisterResolverDuplicate(): void {
-		$this->expectException(\OutOfBoundsException::class);
-
-		$manager = $this->getManager();
-
-		$planetClosure = static fn (string $name): string => ucfirst($name);
-		$manager->registerDisplayNameResolver('planet', $planetClosure);
-		$manager->registerDisplayNameResolver('planet', $planetClosure);
-	}
-
-
-	public function testResolveDisplayNameUnregisteredType(): void {
-		$this->expectException(\OutOfBoundsException::class);
-
-		$manager = $this->getManager();
-
-		$planetClosure = static fn (string $name): string => ucfirst($name);
-		$manager->registerDisplayNameResolver('planet', $planetClosure);
-		$manager->resolveDisplayName('galaxy', 'sombrero');
-	}
-
-	public function testResolveDisplayNameDirtyResolver(): void {
-		$manager = $this->getManager();
-
-		$planetClosure = static fn (): null => null;
-		$manager->registerDisplayNameResolver('planet', $planetClosure);
-		$this->assertIsString($manager->resolveDisplayName('planet', 'neptune'));
-	}
-
-	private function skipIfNotSupport4ByteUTF(): void {
-		if (!$this->getManager()->supportReactions()) {
-			$this->markTestSkipped('MySQL doesn\'t support 4 byte UTF-8');
-		}
-	}
-
-	#[DataProvider(methodName: 'providerTestReactionAddAndDelete')]
-	public function testReactionAddAndDelete(array $comments, array $reactionsExpected): void {
-		$this->skipIfNotSupport4ByteUTF();
-		$manager = $this->getManager();
-
-		$processedComments = $this->proccessComments($comments);
-		$comment = end($processedComments);
-		if ($comment->getParentId()) {
-			$parent = $manager->get($comment->getParentId());
-			$this->assertEqualsCanonicalizing($reactionsExpected, $parent->getReactions());
-		}
-	}
-
-	public static function providerTestReactionAddAndDelete(): array {
-		return[
-			[
-				[
-					['message', 'alice', 'comment', null],
-				], [],
-			],
-			[
-				[
-					['message', 'alice', 'comment', null],
-					['

Spacing +26 added lines, -26 removed lines

@@ -80,7 +80,7 @@ 
 			])
 			->executeStatement();
 
-		return (string)$qb->getLastInsertId();
+		return (string) $qb->getLastInsertId();
 	}
 
 	protected function getManager(): Manager {
@@ -139,7 +139,7 @@ 
 			])
 			->executeStatement();
 
-		$id = (string)$qb->getLastInsertId();
+		$id = (string) $qb->getLastInsertId();
 
 		$comment = $manager->get($id);
 		$this->assertInstanceOf(IComment::class, $comment);
@@ -193,7 +193,7 @@ 
 		// one level deep
 		foreach ($tree['replies'] as $reply) {
 			$this->assertInstanceOf(IComment::class, $reply['comment']);
-			$this->assertSame((string)$id, $reply['comment']->getId());
+			$this->assertSame((string) $id, $reply['comment']->getId());
 			$this->assertCount(0, $reply['replies']);
 			$id--;
 		}
@@ -236,7 +236,7 @@ 
 			// one level deep
 			foreach ($tree['replies'] as $reply) {
 				$this->assertInstanceOf(IComment::class, $reply['comment']);
-				$this->assertSame((string)$idToVerify, (string)$reply['comment']->getId());
+				$this->assertSame((string) $idToVerify, (string) $reply['comment']->getId());
 				$this->assertCount(0, $reply['replies']);
 				$idToVerify--;
 			}
@@ -273,7 +273,7 @@ 
 			foreach ($comments as $key => $comment) {
 				$this->assertInstanceOf(IComment::class, $comment);
 				$this->assertSame('nice one', $comment->getMessage());
-				$this->assertSame((string)$idToVerify, $comment->getId(), 'ID wrong for comment ' . $key . ' on offset: ' . $offset);
+				$this->assertSame((string) $idToVerify, $comment->getId(), 'ID wrong for comment '.$key.' on offset: '.$offset);
 				$idToVerify--;
 			}
 			$offset += 3;
@@ -312,7 +312,7 @@ 
 			foreach ($comments as $comment) {
 				$this->assertInstanceOf(IComment::class, $comment);
 				$this->assertSame('nice one', $comment->getMessage());
-				$this->assertSame((string)$idToVerify, $comment->getId());
+				$this->assertSame((string) $idToVerify, $comment->getId());
 				$this->assertGreaterThanOrEqual(4, $comment->getId());
 				$idToVerify--;
 			}
@@ -337,7 +337,7 @@ 
 	public function testGetNumberOfUnreadCommentsForFolder(): void {
 		$folder = $this->createMock(Folder::class);
 		$fileIds = range(1111, 1114);
-		$children = array_map(function (int $id) {
+		$children = array_map(function(int $id) {
 			$file = $this->createMock(Folder::class);
 			$file->method('getId')
 				->willReturn($id);
@@ -366,8 +366,8 @@ 
 
 		$manager = $this->getManager();
 
-		$manager->setReadMark('files', (string)$fileIds[0], (new \DateTime())->modify('-1 days'), $user);
-		$manager->setReadMark('files', (string)$fileIds[2], (new \DateTime()), $user);
+		$manager->setReadMark('files', (string) $fileIds[0], (new \DateTime())->modify('-1 days'), $user);
+		$manager->setReadMark('files', (string) $fileIds[2], (new \DateTime()), $user);
 
 		$amount = $manager->getNumberOfUnreadCommentsForFolder($folder->getId(), $user);
 		$this->assertEquals([
@@ -387,7 +387,7 @@ 
 		$ids[] = $this->addDatabaseEntry('0', '0');
 
 		$manager = $this->getManager();
-		$comments = $manager->getForObjectSince('files', 'file64', ($lastKnown === null ? 0 : (int)$ids[$lastKnown]), $order, $limit);
+		$comments = $manager->getForObjectSince('files', 'file64', ($lastKnown === null ? 0 : (int) $ids[$lastKnown]), $order, $limit);
 
 		$expected = array_slice($ids, $resultFrom, $resultTo - $resultFrom + 1);
 		if ($order === 'desc') {
@@ -424,7 +424,7 @@ 
 	}
 
 	#[DataProvider(methodName: 'invalidCreateArgsProvider')]
-	public function testCreateCommentInvalidArguments(string|int $aType, string|int $aId, string|int $oType, string|int $oId): void {
+	public function testCreateCommentInvalidArguments(string | int $aType, string | int $aId, string | int $oType, string | int $oId): void {
 		$this->expectException(\InvalidArgumentException::class);
 
 		$manager = $this->getManager();
@@ -588,7 +588,7 @@ 
 				->setMessage('full ack')
 				->setVerb('comment')
 				// setting the creation time avoids using sleep() while making sure to test with different timestamps
-				->setCreationDateTime(new \DateTime('+' . $i . ' minutes'));
+				->setCreationDateTime(new \DateTime('+'.$i.' minutes'));
 
 			$manager->save($comment);
 
@@ -609,7 +609,7 @@ 
 	}
 
 	#[DataProvider(methodName: 'invalidActorArgsProvider')]
-	public function testDeleteReferencesOfActorInvalidInput(string|int $type, string|int $id): void {
+	public function testDeleteReferencesOfActorInvalidInput(string | int $type, string | int $id): void {
 		$this->expectException(\InvalidArgumentException::class);
 
 		$manager = $this->getManager();
@@ -674,7 +674,7 @@ 
 	}
 
 	#[DataProvider(methodName: 'invalidObjectArgsProvider')]
-	public function testDeleteCommentsAtObjectInvalidInput(string|int $type, string|int $id): void {
+	public function testDeleteCommentsAtObjectInvalidInput(string | int $type, string | int $id): void {
 		$this->expectException(\InvalidArgumentException::class);
 
 		$manager = $this->getManager();
@@ -887,10 +887,10 @@ 
 			->method('handle');
 
 		$manager = $this->getManager();
-		$manager->registerEventHandler(function () use ($handler1) {
+		$manager->registerEventHandler(function() use ($handler1) {
 			return $handler1;
 		});
-		$manager->registerEventHandler(function () use ($handler2) {
+		$manager->registerEventHandler(function() use ($handler2) {
 			return $handler2;
 		});
 
@@ -915,11 +915,11 @@ 
 	public function testResolveDisplayName(): void {
 		$manager = $this->getManager();
 
-		$planetClosure = function ($name) {
+		$planetClosure = function($name) {
 			return ucfirst($name);
 		};
 
-		$galaxyClosure = function ($name) {
+		$galaxyClosure = function($name) {
 			return strtoupper($name);
 		};
 
@@ -1042,10 +1042,10 @@ 
 			}
 			$id = '';
 			if ($verb === 'reaction_deleted') {
-				$id = $comments[$message . '#' . $actorId]->getId();
+				$id = $comments[$message.'#'.$actorId]->getId();
 			}
 			$comment = $this->testSave($message, $actorId, $verb, $parentId, $id);
-			$comments[$comment->getMessage() . '#' . $comment->getActorId()] = $comment;
+			$comments[$comment->getMessage().'#'.$comment->getActorId()] = $comment;
 		}
 		$this->connection->commit();
 		return $comments;
@@ -1058,8 +1058,8 @@ 
 
 		$processedComments = $this->proccessComments($comments);
 		$comment = reset($processedComments);
-		$all = $manager->retrieveAllReactions((int)$comment->getId());
-		$actual = array_map(static function (IComment $row): array {
+		$all = $manager->retrieveAllReactions((int) $comment->getId());
+		$actual = array_map(static function(IComment $row): array {
 			return [
 				$row->getActorId(),
 				$row->getMessage(),
@@ -2320,8 +2320,8 @@ 
 
 		$processedComments = $this->proccessComments($comments);
 		$comment = reset($processedComments);
-		$all = $manager->retrieveAllReactionsWithSpecificReaction((int)$comment->getId(), $reaction);
-		$actual = array_map(static function (IComment $row): array {
+		$all = $manager->retrieveAllReactionsWithSpecificReaction((int) $comment->getId(), $reaction);
+		$actual = array_map(static function(IComment $row): array {
 			return [
 				$row->getActorId(),
 				$row->getMessage(),
@@ -2379,8 +2379,8 @@ 
 		if ($notFound) {
 			$this->expectException(NotFoundException::class);
 		}
-		$comment = $processedComments[$expected['message'] . '#' . $expected['actorId']];
-		$actual = $manager->getReactionComment((int)$comment->getParentId(), $comment->getActorType(), $comment->getActorId(), $comment->getMessage());
+		$comment = $processedComments[$expected['message'].'#'.$expected['actorId']];
+		$actual = $manager->getReactionComment((int) $comment->getParentId(), $comment->getActorType(), $comment->getActorId(), $comment->getMessage());
 		if (!$notFound) {
 			$this->assertEquals($expected['message'], $actual->getMessage());
 			$this->assertEquals($expected['actorId'], $actual->getActorId());

tests/lib/Comments/FakeManager.php

Indentation +148 added lines, -148 removed lines

@@ -16,155 +16,155 @@
  * Class FakeManager
  */
 class FakeManager implements ICommentsManager {
-	public function get($id): IComment {
-		throw new \Exception('Not implemented');
-	}
-
-	public function getTree($id, $limit = 0, $offset = 0): array {
-		return ['comment' => new Comment(), 'replies' => []];
-	}
-
-	public function getForObject(
-		$objectType,
-		$objectId,
-		$limit = 0,
-		$offset = 0,
-		?\DateTime $notOlderThan = null,
-	): array {
-		return [];
-	}
-
-	public function getForObjectSince(
-		string $objectType,
-		string $objectId,
-		int $lastKnownCommentId,
-		string $sortDirection = 'asc',
-		int $limit = 30,
-		bool $includeLastKnown = false,
-		string $topmostParentId = '',
-	): array {
-		return [];
-	}
-
-	public function getCommentsWithVerbForObjectSinceComment(
-		string $objectType,
-		string $objectId,
-		array $verbs,
-		int $lastKnownCommentId,
-		string $sortDirection = 'asc',
-		int $limit = 30,
-		bool $includeLastKnown = false,
-		string $topmostParentId = '',
-	): array {
-		return [];
-	}
-
-	public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = ''): int {
-		return 0;
-	}
-
-	public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = ''): array {
-		return array_fill_keys($objectIds, 0);
-	}
-
-	public function search(string $search, string $objectType, string $objectId, string $verb, int $offset, int $limit = 50): array {
-		return [];
-	}
-
-	public function create($actorType, $actorId, $objectType, $objectId): IComment {
-		return new Comment();
-	}
-
-	public function delete($id): bool {
-		return false;
-	}
-
-	public function getReactionComment(int $parentId, string $actorType, string $actorId, string $reaction): IComment {
-		return new Comment();
-	}
-
-	public function retrieveAllReactions(int $parentId): array {
-		return [];
-	}
-
-	public function retrieveAllReactionsWithSpecificReaction(int $parentId, string $reaction): array {
-		return [];
-	}
-
-	public function supportReactions(): bool {
-		return false;
-	}
-
-	public function save(IComment $comment): bool {
-		return false;
-	}
-
-	public function deleteReferencesOfActor($actorType, $actorId): bool {
-		return false;
-	}
-
-	public function deleteCommentsAtObject($objectType, $objectId): bool {
-		return false;
-	}
-
-	public function setReadMark($objectType, $objectId, \DateTime $dateTime, IUser $user): bool {
-		return false;
-	}
-
-	public function getReadMark($objectType, $objectId, IUser $user): bool {
-		return false;
-	}
-
-	public function deleteReadMarksFromUser(IUser $user): bool {
-		return false;
-	}
-
-	public function deleteReadMarksOnObject($objectType, $objectId): bool {
-		return false;
-	}
-
-	public function registerEventHandler(\Closure $closure): void {
-	}
-
-	public function registerDisplayNameResolver($type, \Closure $closure): void {
-	}
-
-	public function resolveDisplayName($type, $id): string {
-		return '';
-	}
-
-	public function getNumberOfUnreadCommentsForFolder($folderId, IUser $user): array {
-		return [];
-	}
-
-	public function getNumberOfUnreadCommentsForObjects(string $objectType, array $objectIds, IUser $user, $verb = ''): array {
-		return [];
-	}
-
-	public function load(): void {
-	}
-
-	public function searchForObjects(string $search, string $objectType, array $objectIds, string $verb, int $offset, int $limit = 50): array {
-		return [];
-	}
-
-	public function getNumberOfCommentsForObjectSinceComment(string $objectType, string $objectId, int $lastRead, string $verb = ''): int {
-		return 0;
-	}
-
-	public function getNumberOfCommentsWithVerbsForObjectSinceComment(string $objectType, string $objectId, int $lastRead, array $verbs): int {
-		return 0;
-	}
+    public function get($id): IComment {
+        throw new \Exception('Not implemented');
+    }
+
+    public function getTree($id, $limit = 0, $offset = 0): array {
+        return ['comment' => new Comment(), 'replies' => []];
+    }
+
+    public function getForObject(
+        $objectType,
+        $objectId,
+        $limit = 0,
+        $offset = 0,
+        ?\DateTime $notOlderThan = null,
+    ): array {
+        return [];
+    }
+
+    public function getForObjectSince(
+        string $objectType,
+        string $objectId,
+        int $lastKnownCommentId,
+        string $sortDirection = 'asc',
+        int $limit = 30,
+        bool $includeLastKnown = false,
+        string $topmostParentId = '',
+    ): array {
+        return [];
+    }
+
+    public function getCommentsWithVerbForObjectSinceComment(
+        string $objectType,
+        string $objectId,
+        array $verbs,
+        int $lastKnownCommentId,
+        string $sortDirection = 'asc',
+        int $limit = 30,
+        bool $includeLastKnown = false,
+        string $topmostParentId = '',
+    ): array {
+        return [];
+    }
+
+    public function getNumberOfCommentsForObject($objectType, $objectId, ?\DateTime $notOlderThan = null, $verb = ''): int {
+        return 0;
+    }
+
+    public function getNumberOfCommentsForObjects(string $objectType, array $objectIds, ?\DateTime $notOlderThan = null, string $verb = ''): array {
+        return array_fill_keys($objectIds, 0);
+    }
+
+    public function search(string $search, string $objectType, string $objectId, string $verb, int $offset, int $limit = 50): array {
+        return [];
+    }
+
+    public function create($actorType, $actorId, $objectType, $objectId): IComment {
+        return new Comment();
+    }
+
+    public function delete($id): bool {
+        return false;
+    }
+
+    public function getReactionComment(int $parentId, string $actorType, string $actorId, string $reaction): IComment {
+        return new Comment();
+    }
+
+    public function retrieveAllReactions(int $parentId): array {
+        return [];
+    }
+
+    public function retrieveAllReactionsWithSpecificReaction(int $parentId, string $reaction): array {
+        return [];
+    }
+
+    public function supportReactions(): bool {
+        return false;
+    }
+
+    public function save(IComment $comment): bool {
+        return false;
+    }
+
+    public function deleteReferencesOfActor($actorType, $actorId): bool {
+        return false;
+    }
+
+    public function deleteCommentsAtObject($objectType, $objectId): bool {
+        return false;
+    }
+
+    public function setReadMark($objectType, $objectId, \DateTime $dateTime, IUser $user): bool {
+        return false;
+    }
+
+    public function getReadMark($objectType, $objectId, IUser $user): bool {
+        return false;
+    }
+
+    public function deleteReadMarksFromUser(IUser $user): bool {
+        return false;
+    }
+
+    public function deleteReadMarksOnObject($objectType, $objectId): bool {
+        return false;
+    }
+
+    public function registerEventHandler(\Closure $closure): void {
+    }
+
+    public function registerDisplayNameResolver($type, \Closure $closure): void {
+    }
+
+    public function resolveDisplayName($type, $id): string {
+        return '';
+    }
+
+    public function getNumberOfUnreadCommentsForFolder($folderId, IUser $user): array {
+        return [];
+    }
+
+    public function getNumberOfUnreadCommentsForObjects(string $objectType, array $objectIds, IUser $user, $verb = ''): array {
+        return [];
+    }
+
+    public function load(): void {
+    }
+
+    public function searchForObjects(string $search, string $objectType, array $objectIds, string $verb, int $offset, int $limit = 50): array {
+        return [];
+    }
+
+    public function getNumberOfCommentsForObjectSinceComment(string $objectType, string $objectId, int $lastRead, string $verb = ''): int {
+        return 0;
+    }
+
+    public function getNumberOfCommentsWithVerbsForObjectSinceComment(string $objectType, string $objectId, int $lastRead, array $verbs): int {
+        return 0;
+    }
 
-	public function getLastCommentBeforeDate(string $objectType, string $objectId, \DateTime $beforeDate, string $verb = ''): int {
-		return 0;
-	}
+    public function getLastCommentBeforeDate(string $objectType, string $objectId, \DateTime $beforeDate, string $verb = ''): int {
+        return 0;
+    }
 
-	public function getLastCommentDateByActor(string $objectType, string $objectId, string $verb, string $actorType, array $actors): array {
-		return [];
-	}
+    public function getLastCommentDateByActor(string $objectType, string $objectId, string $verb, string $actorType, array $actors): array {
+        return [];
+    }
 
-	public function deleteCommentsExpiredAtObject(string $objectType, string $objectId = ''): bool {
-		return true;
-	}
+    public function deleteCommentsExpiredAtObject(string $objectType, string $objectId = ''): bool {
+        return true;
+    }
 }

tests/lib/TestCase.php

Indentation +492 added lines, -492 removed lines

@@ -37,496 +37,496 @@
 use Psr\Container\ContainerExceptionInterface;
 
 abstract class TestCase extends \PHPUnit\Framework\TestCase {
-	private QueueBus $commandBus;
-
-	protected static ?IDBConnection $realDatabase = null;
-	private static bool $wasDatabaseAllowed = false;
-	protected array $services = [];
-
-	protected function onNotSuccessfulTest(\Throwable $t): never {
-		$this->restoreAllServices();
-
-		// restore database connection
-		if (!$this->IsDatabaseAccessAllowed()) {
-			\OC::$server->registerService(IDBConnection::class, function () {
-				return self::$realDatabase;
-			});
-		}
-
-		parent::onNotSuccessfulTest($t);
-	}
-
-	public function overwriteService(string $name, mixed $newService): bool {
-		if (isset($this->services[$name])) {
-			return false;
-		}
-
-		try {
-			$this->services[$name] = Server::get($name);
-		} catch (ContainerExceptionInterface $e) {
-			$this->services[$name] = false;
-		}
-		/** @psalm-suppress InternalMethod */
-		$container = \OC::$server->getAppContainerForService($name);
-		$container = $container ?? \OC::$server;
-
-		$container->registerService($name, function () use ($newService) {
-			return $newService;
-		});
-
-		return true;
-	}
-
-	public function restoreService(string $name): bool {
-		if (isset($this->services[$name])) {
-			$oldService = $this->services[$name];
-
-			/** @psalm-suppress InternalMethod */
-			$container = \OC::$server->getAppContainerForService($name);
-			$container = $container ?? \OC::$server;
-
-			if ($oldService !== false) {
-				$container->registerService($name, function () use ($oldService) {
-					return $oldService;
-				});
-			} else {
-				unset($container[$oldService]);
-			}
-
-
-			unset($this->services[$name]);
-			return true;
-		}
-
-		return false;
-	}
-
-	public function restoreAllServices(): void {
-		foreach ($this->services as $name => $service) {
-			$this->restoreService($name);
-		}
-	}
-
-	protected function getTestTraits(): array {
-		$traits = [];
-		$class = $this;
-		do {
-			$traits = array_merge(class_uses($class), $traits);
-		} while ($class = get_parent_class($class));
-		foreach ($traits as $trait => $same) {
-			$traits = array_merge(class_uses($trait), $traits);
-		}
-		$traits = array_unique($traits);
-		return array_filter($traits, function ($trait) {
-			return substr($trait, 0, 5) === 'Test\\';
-		});
-	}
-
-	protected function setUp(): void {
-		// overwrite the command bus with one we can run ourselves
-		$this->commandBus = new QueueBus();
-		$this->overwriteService('AsyncCommandBus', $this->commandBus);
-		$this->overwriteService(IBus::class, $this->commandBus);
-
-		// detect database access
-		self::$wasDatabaseAllowed = true;
-		if (!$this->IsDatabaseAccessAllowed()) {
-			self::$wasDatabaseAllowed = false;
-			if (is_null(self::$realDatabase)) {
-				self::$realDatabase = Server::get(IDBConnection::class);
-			}
-			/** @psalm-suppress InternalMethod */
-			\OC::$server->registerService(IDBConnection::class, function (): void {
-				$this->fail('Your test case is not allowed to access the database.');
-			});
-		}
-
-		$traits = $this->getTestTraits();
-		foreach ($traits as $trait) {
-			$methodName = 'setUp' . basename(str_replace('\\', '/', $trait));
-			if (method_exists($this, $methodName)) {
-				call_user_func([$this, $methodName]);
-			}
-		}
-	}
-
-	protected function tearDown(): void {
-		$this->restoreAllServices();
-
-		// restore database connection
-		if (!$this->IsDatabaseAccessAllowed()) {
-			/** @psalm-suppress InternalMethod */
-			\OC::$server->registerService(IDBConnection::class, function () {
-				return self::$realDatabase;
-			});
-		}
-
-		// further cleanup
-		$hookExceptions = \OC_Hook::$thrownExceptions;
-		\OC_Hook::$thrownExceptions = [];
-		Server::get(ILockingProvider::class)->releaseAll();
-		if (!empty($hookExceptions)) {
-			throw $hookExceptions[0];
-		}
-
-		// fail hard if xml errors have not been cleaned up
-		$errors = libxml_get_errors();
-		libxml_clear_errors();
-		if (!empty($errors)) {
-			self::assertEquals([], $errors, 'There have been xml parsing errors');
-		}
-
-		if ($this->IsDatabaseAccessAllowed()) {
-			Storage::getGlobalCache()->clearCache();
-		}
-
-		// tearDown the traits
-		$traits = $this->getTestTraits();
-		foreach ($traits as $trait) {
-			$methodName = 'tearDown' . basename(str_replace('\\', '/', $trait));
-			if (method_exists($this, $methodName)) {
-				call_user_func([$this, $methodName]);
-			}
-		}
-	}
-
-	/**
-	 * Allows us to test private methods/properties
-	 *
-	 * @param $object
-	 * @param $methodName
-	 * @param array $parameters
-	 * @return mixed
-	 */
-	protected static function invokePrivate($object, $methodName, array $parameters = []) {
-		if (is_string($object)) {
-			$className = $object;
-		} else {
-			$className = get_class($object);
-		}
-		$reflection = new \ReflectionClass($className);
-
-		if ($reflection->hasMethod($methodName)) {
-			$method = $reflection->getMethod($methodName);
-			return $method->invokeArgs($object, $parameters);
-		} elseif ($reflection->hasProperty($methodName)) {
-			$property = $reflection->getProperty($methodName);
-
-			if (!empty($parameters)) {
-				if ($property->isStatic()) {
-					$property->setValue(null, array_pop($parameters));
-				} else {
-					$property->setValue($object, array_pop($parameters));
-				}
-			}
-
-			if (is_object($object)) {
-				return $property->getValue($object);
-			}
-
-			return $property->getValue();
-		} elseif ($reflection->hasConstant($methodName)) {
-			return $reflection->getConstant($methodName);
-		}
-
-		return false;
-	}
-
-	/**
-	 * Returns a unique identifier as uniqid() is not reliable sometimes
-	 *
-	 * @param string $prefix
-	 * @param int $length
-	 * @return string
-	 */
-	protected static function getUniqueID($prefix = '', $length = 13) {
-		return $prefix . Server::get(ISecureRandom::class)->generate(
-			$length,
-			// Do not use dots and slashes as we use the value for file names
-			ISecureRandom::CHAR_DIGITS . ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_UPPER
-		);
-	}
-
-	/**
-	 * Filter methods
-	 *
-	 * Returns all methods of the given class,
-	 * that are public or abstract and not in the ignoreMethods list,
-	 * to be able to fill onlyMethods() with an inverted list.
-	 *
-	 * @param string $className
-	 * @param string[] $filterMethods
-	 * @return string[]
-	 */
-	public function filterClassMethods(string $className, array $filterMethods): array {
-		$class = new \ReflectionClass($className);
-
-		$methods = [];
-		foreach ($class->getMethods() as $method) {
-			if (($method->isPublic() || $method->isAbstract()) && !in_array($method->getName(), $filterMethods, true)) {
-				$methods[] = $method->getName();
-			}
-		}
-
-		return $methods;
-	}
-
-	public static function tearDownAfterClass(): void {
-		if (!self::$wasDatabaseAllowed && self::$realDatabase !== null) {
-			// in case an error is thrown in a test, PHPUnit jumps straight to tearDownAfterClass,
-			// so we need the database again
-			\OC::$server->registerService(IDBConnection::class, function () {
-				return self::$realDatabase;
-			});
-		}
-		$dataDir = Server::get(IConfig::class)->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data-autotest');
-		if (self::$wasDatabaseAllowed && Server::get(IDBConnection::class)) {
-			$db = Server::get(IDBConnection::class);
-			if ($db->inTransaction()) {
-				$db->rollBack();
-				throw new \Exception('There was a transaction still in progress and needed to be rolled back. Please fix this in your test.');
-			}
-			$queryBuilder = $db->getQueryBuilder();
-
-			self::tearDownAfterClassCleanShares($queryBuilder);
-			self::tearDownAfterClassCleanStorages($queryBuilder);
-			self::tearDownAfterClassCleanFileCache($queryBuilder);
-		}
-		self::tearDownAfterClassCleanStrayDataFiles($dataDir);
-		self::tearDownAfterClassCleanStrayHooks();
-		self::tearDownAfterClassCleanStrayLocks();
-
-		// Ensure we start with fresh instances of some classes to reduce side-effects between tests
-		/** @psalm-suppress DeprecatedMethod */
-		unset(\OC::$server[Factory::class]);
-		/** @psalm-suppress DeprecatedMethod */
-		unset(\OC::$server[AppFetcher::class]);
-		/** @psalm-suppress DeprecatedMethod */
-		unset(\OC::$server[Installer::class]);
-		/** @psalm-suppress DeprecatedMethod */
-		unset(\OC::$server[Updater::class]);
-
-		/** @var SetupManager $setupManager */
-		$setupManager = Server::get(SetupManager::class);
-		$setupManager->tearDown();
-
-		/** @var MountProviderCollection $mountProviderCollection */
-		$mountProviderCollection = Server::get(MountProviderCollection::class);
-		$mountProviderCollection->clearProviders();
-
-		/** @var IConfig $config */
-		$config = Server::get(IConfig::class);
-		$mountProviderCollection->registerProvider(new CacheMountProvider($config));
-		$mountProviderCollection->registerHomeProvider(new LocalHomeMountProvider());
-		$objectStoreConfig = Server::get(PrimaryObjectStoreConfig::class);
-		$mountProviderCollection->registerRootProvider(new RootMountProvider($objectStoreConfig, $config));
-
-		$setupManager->setupRoot();
-
-		parent::tearDownAfterClass();
-	}
-
-	/**
-	 * Remove all entries from the share table
-	 */
-	protected static function tearDownAfterClassCleanShares(IQueryBuilder $queryBuilder): void {
-		$queryBuilder->delete('share')
-			->executeStatement();
-	}
-
-	/**
-	 * Remove all entries from the storages table
-	 */
-	protected static function tearDownAfterClassCleanStorages(IQueryBuilder $queryBuilder): void {
-		$queryBuilder->delete('storages')
-			->executeStatement();
-	}
-
-	/**
-	 * Remove all entries from the filecache table
-	 */
-	protected static function tearDownAfterClassCleanFileCache(IQueryBuilder $queryBuilder): void {
-		$queryBuilder->delete('filecache')
-			->runAcrossAllShards()
-			->executeStatement();
-	}
-
-	/**
-	 * Remove all unused files from the data dir
-	 *
-	 * @param string $dataDir
-	 */
-	protected static function tearDownAfterClassCleanStrayDataFiles(string $dataDir): void {
-		$knownEntries = [
-			'nextcloud.log' => true,
-			'audit.log' => true,
-			'owncloud.db' => true,
-			'.ocdata' => true,
-			'..' => true,
-			'.' => true,
-		];
-
-		if ($dh = opendir($dataDir)) {
-			while (($file = readdir($dh)) !== false) {
-				if (!isset($knownEntries[$file])) {
-					self::tearDownAfterClassCleanStrayDataUnlinkDir($dataDir . '/' . $file);
-				}
-			}
-			closedir($dh);
-		}
-	}
-
-	/**
-	 * Recursive delete files and folders from a given directory
-	 *
-	 * @param string $dir
-	 */
-	protected static function tearDownAfterClassCleanStrayDataUnlinkDir(string $dir): void {
-		if ($dh = @opendir($dir)) {
-			while (($file = readdir($dh)) !== false) {
-				if (Filesystem::isIgnoredDir($file)) {
-					continue;
-				}
-				$path = $dir . '/' . $file;
-				if (is_dir($path)) {
-					self::tearDownAfterClassCleanStrayDataUnlinkDir($path);
-				} else {
-					@unlink($path);
-				}
-			}
-			closedir($dh);
-		}
-		@rmdir($dir);
-	}
-
-	/**
-	 * Clean up the list of hooks
-	 */
-	protected static function tearDownAfterClassCleanStrayHooks(): void {
-		\OC_Hook::clear();
-	}
-
-	/**
-	 * Clean up the list of locks
-	 */
-	protected static function tearDownAfterClassCleanStrayLocks(): void {
-		Server::get(ILockingProvider::class)->releaseAll();
-	}
-
-	/**
-	 * Login and setup FS as a given user,
-	 * sets the given user as the current user.
-	 *
-	 * @param string $user user id or empty for a generic FS
-	 */
-	protected static function loginAsUser(string $user = ''): void {
-		self::logout();
-		Filesystem::tearDown();
-		\OC_User::setUserId($user);
-		$userManager = Server::get(IUserManager::class);
-		$setupManager = Server::get(SetupManager::class);
-		$userObject = $userManager->get($user);
-		if (!is_null($userObject)) {
-			$userObject->updateLastLoginTimestamp();
-			$setupManager->setupForUser($userObject);
-			$rootFolder = Server::get(IRootFolder::class);
-			$rootFolder->getUserFolder($user);
-		}
-	}
-
-	/**
-	 * Logout the current user and tear down the filesystem.
-	 */
-	protected static function logout(): void {
-		Server::get(SetupManager::class)->tearDown();
-		$userSession = Server::get(\OC\User\Session::class);
-		$userSession->getSession()->set('user_id', '');
-		// needed for fully logout
-		$userSession->setUser(null);
-	}
-
-	/**
-	 * Run all commands pushed to the bus
-	 */
-	protected function runCommands(): void {
-		$setupManager = Server::get(SetupManager::class);
-		$session = Server::get(IUserSession::class);
-		$user = $session->getUser();
-
-		$setupManager->tearDown(); // commands can't reply on the fs being setup
-		$this->commandBus->run();
-		$setupManager->tearDown();
-
-		if ($user) {
-			$setupManager->setupForUser($user);
-		}
-	}
-
-	/**
-	 * Check if the given path is locked with a given type
-	 *
-	 * @param View $view view
-	 * @param string $path path to check
-	 * @param int $type lock type
-	 * @param bool $onMountPoint true to check the mount point instead of the
-	 *                           mounted storage
-	 *
-	 * @return boolean true if the file is locked with the
-	 *                 given type, false otherwise
-	 */
-	protected function isFileLocked(View $view, string $path, int $type, bool $onMountPoint = false) {
-		// Note: this seems convoluted but is necessary because
-		// the format of the lock key depends on the storage implementation
-		// (in our case mostly md5)
-
-		if ($type === ILockingProvider::LOCK_SHARED) {
-			// to check if the file has a shared lock, try acquiring an exclusive lock
-			$checkType = ILockingProvider::LOCK_EXCLUSIVE;
-		} else {
-			// a shared lock cannot be set if exclusive lock is in place
-			$checkType = ILockingProvider::LOCK_SHARED;
-		}
-		try {
-			$view->lockFile($path, $checkType, $onMountPoint);
-			// no exception, which means the lock of $type is not set
-			// clean up
-			$view->unlockFile($path, $checkType, $onMountPoint);
-			return false;
-		} catch (LockedException $e) {
-			// we could not acquire the counter-lock, which means
-			// the lock of $type was in place
-			return true;
-		}
-	}
-
-	/**
-	 * @return list<string>
-	 */
-	protected function getGroupAnnotations(): array {
-		if (method_exists($this, 'getAnnotations')) {
-			$annotations = $this->getAnnotations();
-			return $annotations['class']['group'] ?? [];
-		}
-
-		$r = new \ReflectionClass($this);
-		$doc = $r->getDocComment();
-
-		if (class_exists(Group::class)) {
-			$attributes = array_map(function (\ReflectionAttribute $attribute): string {
-				/** @var Group $group */
-				$group = $attribute->newInstance();
-				return $group->name();
-			}, $r->getAttributes(Group::class));
-			if (count($attributes) > 0) {
-				return $attributes;
-			}
-		}
-		preg_match_all('#@group\s+(.*?)\n#s', $doc, $annotations);
-		return $annotations[1] ?? [];
-	}
-
-	protected function IsDatabaseAccessAllowed(): bool {
-		$annotations = $this->getGroupAnnotations();
-		return in_array('DB', $annotations) || in_array('SLOWDB', $annotations);
-	}
+    private QueueBus $commandBus;
+
+    protected static ?IDBConnection $realDatabase = null;
+    private static bool $wasDatabaseAllowed = false;
+    protected array $services = [];
+
+    protected function onNotSuccessfulTest(\Throwable $t): never {
+        $this->restoreAllServices();
+
+        // restore database connection
+        if (!$this->IsDatabaseAccessAllowed()) {
+            \OC::$server->registerService(IDBConnection::class, function () {
+                return self::$realDatabase;
+            });
+        }
+
+        parent::onNotSuccessfulTest($t);
+    }
+
+    public function overwriteService(string $name, mixed $newService): bool {
+        if (isset($this->services[$name])) {
+            return false;
+        }
+
+        try {
+            $this->services[$name] = Server::get($name);
+        } catch (ContainerExceptionInterface $e) {
+            $this->services[$name] = false;
+        }
+        /** @psalm-suppress InternalMethod */
+        $container = \OC::$server->getAppContainerForService($name);
+        $container = $container ?? \OC::$server;
+
+        $container->registerService($name, function () use ($newService) {
+            return $newService;
+        });
+
+        return true;
+    }
+
+    public function restoreService(string $name): bool {
+        if (isset($this->services[$name])) {
+            $oldService = $this->services[$name];
+
+            /** @psalm-suppress InternalMethod */
+            $container = \OC::$server->getAppContainerForService($name);
+            $container = $container ?? \OC::$server;
+
+            if ($oldService !== false) {
+                $container->registerService($name, function () use ($oldService) {
+                    return $oldService;
+                });
+            } else {
+                unset($container[$oldService]);
+            }
+
+
+            unset($this->services[$name]);
+            return true;
+        }
+
+        return false;
+    }
+
+    public function restoreAllServices(): void {
+        foreach ($this->services as $name => $service) {
+            $this->restoreService($name);
+        }
+    }
+
+    protected function getTestTraits(): array {
+        $traits = [];
+        $class = $this;
+        do {
+            $traits = array_merge(class_uses($class), $traits);
+        } while ($class = get_parent_class($class));
+        foreach ($traits as $trait => $same) {
+            $traits = array_merge(class_uses($trait), $traits);
+        }
+        $traits = array_unique($traits);
+        return array_filter($traits, function ($trait) {
+            return substr($trait, 0, 5) === 'Test\\';
+        });
+    }
+
+    protected function setUp(): void {
+        // overwrite the command bus with one we can run ourselves
+        $this->commandBus = new QueueBus();
+        $this->overwriteService('AsyncCommandBus', $this->commandBus);
+        $this->overwriteService(IBus::class, $this->commandBus);
+
+        // detect database access
+        self::$wasDatabaseAllowed = true;
+        if (!$this->IsDatabaseAccessAllowed()) {
+            self::$wasDatabaseAllowed = false;
+            if (is_null(self::$realDatabase)) {
+                self::$realDatabase = Server::get(IDBConnection::class);
+            }
+            /** @psalm-suppress InternalMethod */
+            \OC::$server->registerService(IDBConnection::class, function (): void {
+                $this->fail('Your test case is not allowed to access the database.');
+            });
+        }
+
+        $traits = $this->getTestTraits();
+        foreach ($traits as $trait) {
+            $methodName = 'setUp' . basename(str_replace('\\', '/', $trait));
+            if (method_exists($this, $methodName)) {
+                call_user_func([$this, $methodName]);
+            }
+        }
+    }
+
+    protected function tearDown(): void {
+        $this->restoreAllServices();
+
+        // restore database connection
+        if (!$this->IsDatabaseAccessAllowed()) {
+            /** @psalm-suppress InternalMethod */
+            \OC::$server->registerService(IDBConnection::class, function () {
+                return self::$realDatabase;
+            });
+        }
+
+        // further cleanup
+        $hookExceptions = \OC_Hook::$thrownExceptions;
+        \OC_Hook::$thrownExceptions = [];
+        Server::get(ILockingProvider::class)->releaseAll();
+        if (!empty($hookExceptions)) {
+            throw $hookExceptions[0];
+        }
+
+        // fail hard if xml errors have not been cleaned up
+        $errors = libxml_get_errors();
+        libxml_clear_errors();
+        if (!empty($errors)) {
+            self::assertEquals([], $errors, 'There have been xml parsing errors');
+        }
+
+        if ($this->IsDatabaseAccessAllowed()) {
+            Storage::getGlobalCache()->clearCache();
+        }
+
+        // tearDown the traits
+        $traits = $this->getTestTraits();
+        foreach ($traits as $trait) {
+            $methodName = 'tearDown' . basename(str_replace('\\', '/', $trait));
+            if (method_exists($this, $methodName)) {
+                call_user_func([$this, $methodName]);
+            }
+        }
+    }
+
+    /**
+     * Allows us to test private methods/properties
+     *
+     * @param $object
+     * @param $methodName
+     * @param array $parameters
+     * @return mixed
+     */
+    protected static function invokePrivate($object, $methodName, array $parameters = []) {
+        if (is_string($object)) {
+            $className = $object;
+        } else {
+            $className = get_class($object);
+        }
+        $reflection = new \ReflectionClass($className);
+
+        if ($reflection->hasMethod($methodName)) {
+            $method = $reflection->getMethod($methodName);
+            return $method->invokeArgs($object, $parameters);
+        } elseif ($reflection->hasProperty($methodName)) {
+            $property = $reflection->getProperty($methodName);
+
+            if (!empty($parameters)) {
+                if ($property->isStatic()) {
+                    $property->setValue(null, array_pop($parameters));
+                } else {
+                    $property->setValue($object, array_pop($parameters));
+                }
+            }
+
+            if (is_object($object)) {
+                return $property->getValue($object);
+            }
+
+            return $property->getValue();
+        } elseif ($reflection->hasConstant($methodName)) {
+            return $reflection->getConstant($methodName);
+        }
+
+        return false;
+    }
+
+    /**
+     * Returns a unique identifier as uniqid() is not reliable sometimes
+     *
+     * @param string $prefix
+     * @param int $length
+     * @return string
+     */
+    protected static function getUniqueID($prefix = '', $length = 13) {
+        return $prefix . Server::get(ISecureRandom::class)->generate(
+            $length,
+            // Do not use dots and slashes as we use the value for file names
+            ISecureRandom::CHAR_DIGITS . ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_UPPER
+        );
+    }
+
+    /**
+     * Filter methods
+     *
+     * Returns all methods of the given class,
+     * that are public or abstract and not in the ignoreMethods list,
+     * to be able to fill onlyMethods() with an inverted list.
+     *
+     * @param string $className
+     * @param string[] $filterMethods
+     * @return string[]
+     */
+    public function filterClassMethods(string $className, array $filterMethods): array {
+        $class = new \ReflectionClass($className);
+
+        $methods = [];
+        foreach ($class->getMethods() as $method) {
+            if (($method->isPublic() || $method->isAbstract()) && !in_array($method->getName(), $filterMethods, true)) {
+                $methods[] = $method->getName();
+            }
+        }
+
+        return $methods;
+    }
+
+    public static function tearDownAfterClass(): void {
+        if (!self::$wasDatabaseAllowed && self::$realDatabase !== null) {
+            // in case an error is thrown in a test, PHPUnit jumps straight to tearDownAfterClass,
+            // so we need the database again
+            \OC::$server->registerService(IDBConnection::class, function () {
+                return self::$realDatabase;
+            });
+        }
+        $dataDir = Server::get(IConfig::class)->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data-autotest');
+        if (self::$wasDatabaseAllowed && Server::get(IDBConnection::class)) {
+            $db = Server::get(IDBConnection::class);
+            if ($db->inTransaction()) {
+                $db->rollBack();
+                throw new \Exception('There was a transaction still in progress and needed to be rolled back. Please fix this in your test.');
+            }
+            $queryBuilder = $db->getQueryBuilder();
+
+            self::tearDownAfterClassCleanShares($queryBuilder);
+            self::tearDownAfterClassCleanStorages($queryBuilder);
+            self::tearDownAfterClassCleanFileCache($queryBuilder);
+        }
+        self::tearDownAfterClassCleanStrayDataFiles($dataDir);
+        self::tearDownAfterClassCleanStrayHooks();
+        self::tearDownAfterClassCleanStrayLocks();
+
+        // Ensure we start with fresh instances of some classes to reduce side-effects between tests
+        /** @psalm-suppress DeprecatedMethod */
+        unset(\OC::$server[Factory::class]);
+        /** @psalm-suppress DeprecatedMethod */
+        unset(\OC::$server[AppFetcher::class]);
+        /** @psalm-suppress DeprecatedMethod */
+        unset(\OC::$server[Installer::class]);
+        /** @psalm-suppress DeprecatedMethod */
+        unset(\OC::$server[Updater::class]);
+
+        /** @var SetupManager $setupManager */
+        $setupManager = Server::get(SetupManager::class);
+        $setupManager->tearDown();
+
+        /** @var MountProviderCollection $mountProviderCollection */
+        $mountProviderCollection = Server::get(MountProviderCollection::class);
+        $mountProviderCollection->clearProviders();
+
+        /** @var IConfig $config */
+        $config = Server::get(IConfig::class);
+        $mountProviderCollection->registerProvider(new CacheMountProvider($config));
+        $mountProviderCollection->registerHomeProvider(new LocalHomeMountProvider());
+        $objectStoreConfig = Server::get(PrimaryObjectStoreConfig::class);
+        $mountProviderCollection->registerRootProvider(new RootMountProvider($objectStoreConfig, $config));
+
+        $setupManager->setupRoot();
+
+        parent::tearDownAfterClass();
+    }
+
+    /**
+     * Remove all entries from the share table
+     */
+    protected static function tearDownAfterClassCleanShares(IQueryBuilder $queryBuilder): void {
+        $queryBuilder->delete('share')
+            ->executeStatement();
+    }
+
+    /**
+     * Remove all entries from the storages table
+     */
+    protected static function tearDownAfterClassCleanStorages(IQueryBuilder $queryBuilder): void {
+        $queryBuilder->delete('storages')
+            ->executeStatement();
+    }
+
+    /**
+     * Remove all entries from the filecache table
+     */
+    protected static function tearDownAfterClassCleanFileCache(IQueryBuilder $queryBuilder): void {
+        $queryBuilder->delete('filecache')
+            ->runAcrossAllShards()
+            ->executeStatement();
+    }
+
+    /**
+     * Remove all unused files from the data dir
+     *
+     * @param string $dataDir
+     */
+    protected static function tearDownAfterClassCleanStrayDataFiles(string $dataDir): void {
+        $knownEntries = [
+            'nextcloud.log' => true,
+            'audit.log' => true,
+            'owncloud.db' => true,
+            '.ocdata' => true,
+            '..' => true,
+            '.' => true,
+        ];
+
+        if ($dh = opendir($dataDir)) {
+            while (($file = readdir($dh)) !== false) {
+                if (!isset($knownEntries[$file])) {
+                    self::tearDownAfterClassCleanStrayDataUnlinkDir($dataDir . '/' . $file);
+                }
+            }
+            closedir($dh);
+        }
+    }
+
+    /**
+     * Recursive delete files and folders from a given directory
+     *
+     * @param string $dir
+     */
+    protected static function tearDownAfterClassCleanStrayDataUnlinkDir(string $dir): void {
+        if ($dh = @opendir($dir)) {
+            while (($file = readdir($dh)) !== false) {
+                if (Filesystem::isIgnoredDir($file)) {
+                    continue;
+                }
+                $path = $dir . '/' . $file;
+                if (is_dir($path)) {
+                    self::tearDownAfterClassCleanStrayDataUnlinkDir($path);
+                } else {
+                    @unlink($path);
+                }
+            }
+            closedir($dh);
+        }
+        @rmdir($dir);
+    }
+
+    /**
+     * Clean up the list of hooks
+     */
+    protected static function tearDownAfterClassCleanStrayHooks(): void {
+        \OC_Hook::clear();
+    }
+
+    /**
+     * Clean up the list of locks
+     */
+    protected static function tearDownAfterClassCleanStrayLocks(): void {
+        Server::get(ILockingProvider::class)->releaseAll();
+    }
+
+    /**
+     * Login and setup FS as a given user,
+     * sets the given user as the current user.
+     *
+     * @param string $user user id or empty for a generic FS
+     */
+    protected static function loginAsUser(string $user = ''): void {
+        self::logout();
+        Filesystem::tearDown();
+        \OC_User::setUserId($user);
+        $userManager = Server::get(IUserManager::class);
+        $setupManager = Server::get(SetupManager::class);
+        $userObject = $userManager->get($user);
+        if (!is_null($userObject)) {
+            $userObject->updateLastLoginTimestamp();
+            $setupManager->setupForUser($userObject);
+            $rootFolder = Server::get(IRootFolder::class);
+            $rootFolder->getUserFolder($user);
+        }
+    }
+
+    /**
+     * Logout the current user and tear down the filesystem.
+     */
+    protected static function logout(): void {
+        Server::get(SetupManager::class)->tearDown();
+        $userSession = Server::get(\OC\User\Session::class);
+        $userSession->getSession()->set('user_id', '');
+        // needed for fully logout
+        $userSession->setUser(null);
+    }
+
+    /**
+     * Run all commands pushed to the bus
+     */
+    protected function runCommands(): void {
+        $setupManager = Server::get(SetupManager::class);
+        $session = Server::get(IUserSession::class);
+        $user = $session->getUser();
+
+        $setupManager->tearDown(); // commands can't reply on the fs being setup
+        $this->commandBus->run();
+        $setupManager->tearDown();
+
+        if ($user) {
+            $setupManager->setupForUser($user);
+        }
+    }
+
+    /**
+     * Check if the given path is locked with a given type
+     *
+     * @param View $view view
+     * @param string $path path to check
+     * @param int $type lock type
+     * @param bool $onMountPoint true to check the mount point instead of the
+     *                           mounted storage
+     *
+     * @return boolean true if the file is locked with the
+     *                 given type, false otherwise
+     */
+    protected function isFileLocked(View $view, string $path, int $type, bool $onMountPoint = false) {
+        // Note: this seems convoluted but is necessary because
+        // the format of the lock key depends on the storage implementation
+        // (in our case mostly md5)
+
+        if ($type === ILockingProvider::LOCK_SHARED) {
+            // to check if the file has a shared lock, try acquiring an exclusive lock
+            $checkType = ILockingProvider::LOCK_EXCLUSIVE;
+        } else {
+            // a shared lock cannot be set if exclusive lock is in place
+            $checkType = ILockingProvider::LOCK_SHARED;
+        }
+        try {
+            $view->lockFile($path, $checkType, $onMountPoint);
+            // no exception, which means the lock of $type is not set
+            // clean up
+            $view->unlockFile($path, $checkType, $onMountPoint);
+            return false;
+        } catch (LockedException $e) {
+            // we could not acquire the counter-lock, which means
+            // the lock of $type was in place
+            return true;
+        }
+    }
+
+    /**
+     * @return list<string>
+     */
+    protected function getGroupAnnotations(): array {
+        if (method_exists($this, 'getAnnotations')) {
+            $annotations = $this->getAnnotations();
+            return $annotations['class']['group'] ?? [];
+        }
+
+        $r = new \ReflectionClass($this);
+        $doc = $r->getDocComment();
+
+        if (class_exists(Group::class)) {
+            $attributes = array_map(function (\ReflectionAttribute $attribute): string {
+                /** @var Group $group */
+                $group = $attribute->newInstance();
+                return $group->name();
+            }, $r->getAttributes(Group::class));
+            if (count($attributes) > 0) {
+                return $attributes;
+            }
+        }
+        preg_match_all('#@group\s+(.*?)\n#s', $doc, $annotations);
+        return $annotations[1] ?? [];
+    }
+
+    protected function IsDatabaseAccessAllowed(): bool {
+        $annotations = $this->getGroupAnnotations();
+        return in_array('DB', $annotations) || in_array('SLOWDB', $annotations);
+    }
 }

Spacing +15 added lines, -15 removed lines

@@ -48,7 +48,7 @@ 
 
 		// restore database connection
 		if (!$this->IsDatabaseAccessAllowed()) {
-			\OC::$server->registerService(IDBConnection::class, function () {
+			\OC::$server->registerService(IDBConnection::class, function() {
 				return self::$realDatabase;
 			});
 		}
@@ -70,7 +70,7 @@ 
 		$container = \OC::$server->getAppContainerForService($name);
 		$container = $container ?? \OC::$server;
 
-		$container->registerService($name, function () use ($newService) {
+		$container->registerService($name, function() use ($newService) {
 			return $newService;
 		});
 
@@ -86,7 +86,7 @@ 
 			$container = $container ?? \OC::$server;
 
 			if ($oldService !== false) {
-				$container->registerService($name, function () use ($oldService) {
+				$container->registerService($name, function() use ($oldService) {
 					return $oldService;
 				});
 			} else {
@@ -117,7 +117,7 @@ 
 			$traits = array_merge(class_uses($trait), $traits);
 		}
 		$traits = array_unique($traits);
-		return array_filter($traits, function ($trait) {
+		return array_filter($traits, function($trait) {
 			return substr($trait, 0, 5) === 'Test\\';
 		});
 	}
@@ -136,14 +136,14 @@ 
 				self::$realDatabase = Server::get(IDBConnection::class);
 			}
 			/** @psalm-suppress InternalMethod */
-			\OC::$server->registerService(IDBConnection::class, function (): void {
+			\OC::$server->registerService(IDBConnection::class, function(): void {
 				$this->fail('Your test case is not allowed to access the database.');
 			});
 		}
 
 		$traits = $this->getTestTraits();
 		foreach ($traits as $trait) {
-			$methodName = 'setUp' . basename(str_replace('\\', '/', $trait));
+			$methodName = 'setUp'.basename(str_replace('\\', '/', $trait));
 			if (method_exists($this, $methodName)) {
 				call_user_func([$this, $methodName]);
 			}
@@ -156,7 +156,7 @@ 
 		// restore database connection
 		if (!$this->IsDatabaseAccessAllowed()) {
 			/** @psalm-suppress InternalMethod */
-			\OC::$server->registerService(IDBConnection::class, function () {
+			\OC::$server->registerService(IDBConnection::class, function() {
 				return self::$realDatabase;
 			});
 		}
@@ -183,7 +183,7 @@ 
 		// tearDown the traits
 		$traits = $this->getTestTraits();
 		foreach ($traits as $trait) {
-			$methodName = 'tearDown' . basename(str_replace('\\', '/', $trait));
+			$methodName = 'tearDown'.basename(str_replace('\\', '/', $trait));
 			if (method_exists($this, $methodName)) {
 				call_user_func([$this, $methodName]);
 			}
@@ -240,10 +240,10 @@ 
 	 * @return string
 	 */
 	protected static function getUniqueID($prefix = '', $length = 13) {
-		return $prefix . Server::get(ISecureRandom::class)->generate(
+		return $prefix.Server::get(ISecureRandom::class)->generate(
 			$length,
 			// Do not use dots and slashes as we use the value for file names
-			ISecureRandom::CHAR_DIGITS . ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_UPPER
+			ISecureRandom::CHAR_DIGITS.ISecureRandom::CHAR_LOWER.ISecureRandom::CHAR_UPPER
 		);
 	}
 
@@ -275,11 +275,11 @@ 
 		if (!self::$wasDatabaseAllowed && self::$realDatabase !== null) {
 			// in case an error is thrown in a test, PHPUnit jumps straight to tearDownAfterClass,
 			// so we need the database again
-			\OC::$server->registerService(IDBConnection::class, function () {
+			\OC::$server->registerService(IDBConnection::class, function() {
 				return self::$realDatabase;
 			});
 		}
-		$dataDir = Server::get(IConfig::class)->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data-autotest');
+		$dataDir = Server::get(IConfig::class)->getSystemValueString('datadirectory', \OC::$SERVERROOT.'/data-autotest');
 		if (self::$wasDatabaseAllowed && Server::get(IDBConnection::class)) {
 			$db = Server::get(IDBConnection::class);
 			if ($db->inTransaction()) {
@@ -369,7 +369,7 @@ 
 		if ($dh = opendir($dataDir)) {
 			while (($file = readdir($dh)) !== false) {
 				if (!isset($knownEntries[$file])) {
-					self::tearDownAfterClassCleanStrayDataUnlinkDir($dataDir . '/' . $file);
+					self::tearDownAfterClassCleanStrayDataUnlinkDir($dataDir.'/'.$file);
 				}
 			}
 			closedir($dh);
@@ -387,7 +387,7 @@ 
 				if (Filesystem::isIgnoredDir($file)) {
 					continue;
 				}
-				$path = $dir . '/' . $file;
+				$path = $dir.'/'.$file;
 				if (is_dir($path)) {
 					self::tearDownAfterClassCleanStrayDataUnlinkDir($path);
 				} else {
@@ -512,7 +512,7 @@ 
 		$doc = $r->getDocComment();
 
 		if (class_exists(Group::class)) {
-			$attributes = array_map(function (\ReflectionAttribute $attribute): string {
+			$attributes = array_map(function(\ReflectionAttribute $attribute): string {
 				/** @var Group $group */
 				$group = $attribute->newInstance();
 				return $group->name();