nextcloud / server

tests/lib/AppTest.php

Indentation +529 added lines, -529 removed lines

@@ -30,559 +30,559 @@
  * @group DB
  */
 class AppTest extends \Test\TestCase {
-	public const TEST_USER1 = 'user1';
-	public const TEST_USER2 = 'user2';
-	public const TEST_USER3 = 'user3';
-	public const TEST_GROUP1 = 'group1';
-	public const TEST_GROUP2 = 'group2';
+    public const TEST_USER1 = 'user1';
+    public const TEST_USER2 = 'user2';
+    public const TEST_USER3 = 'user3';
+    public const TEST_GROUP1 = 'group1';
+    public const TEST_GROUP2 = 'group2';
 
-	public static function appVersionsProvider(): array {
-		return [
-			// exact match
-			[
-				'6.0.0.0',
-				[
-					'requiremin' => '6.0',
-					'requiremax' => '6.0',
-				],
-				true
-			],
-			// in-between match
-			[
-				'6.0.0.0',
-				[
-					'requiremin' => '5.0',
-					'requiremax' => '7.0',
-				],
-				true
-			],
-			// app too old
-			[
-				'6.0.0.0',
-				[
-					'requiremin' => '5.0',
-					'requiremax' => '5.0',
-				],
-				false
-			],
-			// app too new
-			[
-				'5.0.0.0',
-				[
-					'requiremin' => '6.0',
-					'requiremax' => '6.0',
-				],
-				false
-			],
-			// only min specified
-			[
-				'6.0.0.0',
-				[
-					'requiremin' => '6.0',
-				],
-				true
-			],
-			// only min specified fail
-			[
-				'5.0.0.0',
-				[
-					'requiremin' => '6.0',
-				],
-				false
-			],
-			// only min specified legacy
-			[
-				'6.0.0.0',
-				[
-					'require' => '6.0',
-				],
-				true
-			],
-			// only min specified legacy fail
-			[
-				'4.0.0.0',
-				[
-					'require' => '6.0',
-				],
-				false
-			],
-			// only max specified
-			[
-				'5.0.0.0',
-				[
-					'requiremax' => '6.0',
-				],
-				true
-			],
-			// only max specified fail
-			[
-				'7.0.0.0',
-				[
-					'requiremax' => '6.0',
-				],
-				false
-			],
-			// variations of versions
-			// single OC number
-			[
-				'4',
-				[
-					'require' => '4.0',
-				],
-				true
-			],
-			// multiple OC number
-			[
-				'4.3.1',
-				[
-					'require' => '4.3',
-				],
-				true
-			],
-			// single app number
-			[
-				'4',
-				[
-					'require' => '4',
-				],
-				true
-			],
-			// single app number fail
-			[
-				'4.3',
-				[
-					'require' => '5',
-				],
-				false
-			],
-			// complex
-			[
-				'5.0.0',
-				[
-					'require' => '4.5.1',
-				],
-				true
-			],
-			// complex fail
-			[
-				'4.3.1',
-				[
-					'require' => '4.3.2',
-				],
-				false
-			],
-			// two numbers
-			[
-				'4.3.1',
-				[
-					'require' => '4.4',
-				],
-				false
-			],
-			// one number fail
-			[
-				'4.3.1',
-				[
-					'require' => '5',
-				],
-				false
-			],
-			// pre-alpha app
-			[
-				'5.0.3',
-				[
-					'require' => '4.93',
-				],
-				true
-			],
-			// pre-alpha OC
-			[
-				'6.90.0.2',
-				[
-					'require' => '6.90',
-				],
-				true
-			],
-			// pre-alpha OC max
-			[
-				'6.90.0.2',
-				[
-					'requiremax' => '7',
-				],
-				true
-			],
-			// expect same major number match
-			[
-				'5.0.3',
-				[
-					'require' => '5',
-				],
-				true
-			],
-			// expect same major number match
-			[
-				'5.0.3',
-				[
-					'requiremax' => '5',
-				],
-				true
-			],
-			// dependencies versions before require*
-			[
-				'6.0.0.0',
-				[
-					'requiremin' => '5.0',
-					'requiremax' => '7.0',
-					'dependencies' => [
-						'owncloud' => [
-							'@attributes' => [
-								'min-version' => '7.0',
-								'max-version' => '7.0',
-							],
-						],
-					],
-				],
-				false
-			],
-			[
-				'6.0.0.0',
-				[
-					'requiremin' => '5.0',
-					'requiremax' => '7.0',
-					'dependencies' => [
-						'owncloud' => [
-							'@attributes' => [
-								'min-version' => '5.0',
-								'max-version' => '5.0',
-							],
-						],
-					],
-				],
-				false
-			],
-			[
-				'6.0.0.0',
-				[
-					'requiremin' => '5.0',
-					'requiremax' => '5.0',
-					'dependencies' => [
-						'owncloud' => [
-							'@attributes' => [
-								'min-version' => '5.0',
-								'max-version' => '7.0',
-							],
-						],
-					],
-				],
-				true
-			],
-			[
-				'9.2.0.0',
-				[
-					'dependencies' => [
-						'owncloud' => [
-							'@attributes' => [
-								'min-version' => '9.0',
-								'max-version' => '9.1',
-							],
-						],
-						'nextcloud' => [
-							'@attributes' => [
-								'min-version' => '9.1',
-								'max-version' => '9.2',
-							],
-						],
-					],
-				],
-				true
-			],
-			[
-				'9.2.0.0',
-				[
-					'dependencies' => [
-						'nextcloud' => [
-							'@attributes' => [
-								'min-version' => '9.1',
-								'max-version' => '9.2',
-							],
-						],
-					],
-				],
-				true
-			],
-		];
-	}
+    public static function appVersionsProvider(): array {
+        return [
+            // exact match
+            [
+                '6.0.0.0',
+                [
+                    'requiremin' => '6.0',
+                    'requiremax' => '6.0',
+                ],
+                true
+            ],
+            // in-between match
+            [
+                '6.0.0.0',
+                [
+                    'requiremin' => '5.0',
+                    'requiremax' => '7.0',
+                ],
+                true
+            ],
+            // app too old
+            [
+                '6.0.0.0',
+                [
+                    'requiremin' => '5.0',
+                    'requiremax' => '5.0',
+                ],
+                false
+            ],
+            // app too new
+            [
+                '5.0.0.0',
+                [
+                    'requiremin' => '6.0',
+                    'requiremax' => '6.0',
+                ],
+                false
+            ],
+            // only min specified
+            [
+                '6.0.0.0',
+                [
+                    'requiremin' => '6.0',
+                ],
+                true
+            ],
+            // only min specified fail
+            [
+                '5.0.0.0',
+                [
+                    'requiremin' => '6.0',
+                ],
+                false
+            ],
+            // only min specified legacy
+            [
+                '6.0.0.0',
+                [
+                    'require' => '6.0',
+                ],
+                true
+            ],
+            // only min specified legacy fail
+            [
+                '4.0.0.0',
+                [
+                    'require' => '6.0',
+                ],
+                false
+            ],
+            // only max specified
+            [
+                '5.0.0.0',
+                [
+                    'requiremax' => '6.0',
+                ],
+                true
+            ],
+            // only max specified fail
+            [
+                '7.0.0.0',
+                [
+                    'requiremax' => '6.0',
+                ],
+                false
+            ],
+            // variations of versions
+            // single OC number
+            [
+                '4',
+                [
+                    'require' => '4.0',
+                ],
+                true
+            ],
+            // multiple OC number
+            [
+                '4.3.1',
+                [
+                    'require' => '4.3',
+                ],
+                true
+            ],
+            // single app number
+            [
+                '4',
+                [
+                    'require' => '4',
+                ],
+                true
+            ],
+            // single app number fail
+            [
+                '4.3',
+                [
+                    'require' => '5',
+                ],
+                false
+            ],
+            // complex
+            [
+                '5.0.0',
+                [
+                    'require' => '4.5.1',
+                ],
+                true
+            ],
+            // complex fail
+            [
+                '4.3.1',
+                [
+                    'require' => '4.3.2',
+                ],
+                false
+            ],
+            // two numbers
+            [
+                '4.3.1',
+                [
+                    'require' => '4.4',
+                ],
+                false
+            ],
+            // one number fail
+            [
+                '4.3.1',
+                [
+                    'require' => '5',
+                ],
+                false
+            ],
+            // pre-alpha app
+            [
+                '5.0.3',
+                [
+                    'require' => '4.93',
+                ],
+                true
+            ],
+            // pre-alpha OC
+            [
+                '6.90.0.2',
+                [
+                    'require' => '6.90',
+                ],
+                true
+            ],
+            // pre-alpha OC max
+            [
+                '6.90.0.2',
+                [
+                    'requiremax' => '7',
+                ],
+                true
+            ],
+            // expect same major number match
+            [
+                '5.0.3',
+                [
+                    'require' => '5',
+                ],
+                true
+            ],
+            // expect same major number match
+            [
+                '5.0.3',
+                [
+                    'requiremax' => '5',
+                ],
+                true
+            ],
+            // dependencies versions before require*
+            [
+                '6.0.0.0',
+                [
+                    'requiremin' => '5.0',
+                    'requiremax' => '7.0',
+                    'dependencies' => [
+                        'owncloud' => [
+                            '@attributes' => [
+                                'min-version' => '7.0',
+                                'max-version' => '7.0',
+                            ],
+                        ],
+                    ],
+                ],
+                false
+            ],
+            [
+                '6.0.0.0',
+                [
+                    'requiremin' => '5.0',
+                    'requiremax' => '7.0',
+                    'dependencies' => [
+                        'owncloud' => [
+                            '@attributes' => [
+                                'min-version' => '5.0',
+                                'max-version' => '5.0',
+                            ],
+                        ],
+                    ],
+                ],
+                false
+            ],
+            [
+                '6.0.0.0',
+                [
+                    'requiremin' => '5.0',
+                    'requiremax' => '5.0',
+                    'dependencies' => [
+                        'owncloud' => [
+                            '@attributes' => [
+                                'min-version' => '5.0',
+                                'max-version' => '7.0',
+                            ],
+                        ],
+                    ],
+                ],
+                true
+            ],
+            [
+                '9.2.0.0',
+                [
+                    'dependencies' => [
+                        'owncloud' => [
+                            '@attributes' => [
+                                'min-version' => '9.0',
+                                'max-version' => '9.1',
+                            ],
+                        ],
+                        'nextcloud' => [
+                            '@attributes' => [
+                                'min-version' => '9.1',
+                                'max-version' => '9.2',
+                            ],
+                        ],
+                    ],
+                ],
+                true
+            ],
+            [
+                '9.2.0.0',
+                [
+                    'dependencies' => [
+                        'nextcloud' => [
+                            '@attributes' => [
+                                'min-version' => '9.1',
+                                'max-version' => '9.2',
+                            ],
+                        ],
+                    ],
+                ],
+                true
+            ],
+        ];
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('appVersionsProvider')]
-	public function testIsAppCompatible($ocVersion, $appInfo, $expectedResult): void {
-		$this->assertEquals($expectedResult, \OC_App::isAppCompatible($ocVersion, $appInfo));
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('appVersionsProvider')]
+    public function testIsAppCompatible($ocVersion, $appInfo, $expectedResult): void {
+        $this->assertEquals($expectedResult, \OC_App::isAppCompatible($ocVersion, $appInfo));
+    }
 
-	/**
-	 * Tests that the app order is correct
-	 */
-	public function testGetEnabledAppsIsSorted(): void {
-		$apps = \OC_App::getEnabledApps();
-		// copy array
-		$sortedApps = $apps;
-		sort($sortedApps);
-		// 'files' is always on top
-		unset($sortedApps[array_search('files', $sortedApps)]);
-		array_unshift($sortedApps, 'files');
-		$this->assertEquals($sortedApps, $apps);
-	}
+    /**
+     * Tests that the app order is correct
+     */
+    public function testGetEnabledAppsIsSorted(): void {
+        $apps = \OC_App::getEnabledApps();
+        // copy array
+        $sortedApps = $apps;
+        sort($sortedApps);
+        // 'files' is always on top
+        unset($sortedApps[array_search('files', $sortedApps)]);
+        array_unshift($sortedApps, 'files');
+        $this->assertEquals($sortedApps, $apps);
+    }
 
-	/**
-	 * Providers for the app config values
-	 */
-	public static function appConfigValuesProvider(): array {
-		return [
-			// logged in user1
-			[
-				self::TEST_USER1,
-				[
-					'files',
-					'app1',
-					'app3',
-					'appforgroup1',
-					'appforgroup12',
-					'cloud_federation_api',
-					'dav',
-					'federatedfilesharing',
-					'lookup_server_connector',
-					'oauth2',
-					'profile',
-					'provisioning_api',
-					'settings',
-					'theming',
-					'twofactor_backupcodes',
-					'viewer',
-					'workflowengine',
-				],
-				false
-			],
-			// logged in user2
-			[
-				self::TEST_USER2,
-				[
-					'files',
-					'app1',
-					'app3',
-					'appforgroup12',
-					'appforgroup2',
-					'cloud_federation_api',
-					'dav',
-					'federatedfilesharing',
-					'lookup_server_connector',
-					'oauth2',
-					'profile',
-					'provisioning_api',
-					'settings',
-					'theming',
-					'twofactor_backupcodes',
-					'viewer',
-					'workflowengine',
-				],
-				false
-			],
-			// logged in user3
-			[
-				self::TEST_USER3,
-				[
-					'files',
-					'app1',
-					'app3',
-					'appforgroup1',
-					'appforgroup12',
-					'appforgroup2',
-					'cloud_federation_api',
-					'dav',
-					'federatedfilesharing',
-					'lookup_server_connector',
-					'oauth2',
-					'profile',
-					'provisioning_api',
-					'settings',
-					'theming',
-					'twofactor_backupcodes',
-					'viewer',
-					'workflowengine',
-				],
-				false
-			],
-			//  no user, returns all apps
-			[
-				null,
-				[
-					'files',
-					'app1',
-					'app3',
-					'appforgroup1',
-					'appforgroup12',
-					'appforgroup2',
-					'cloud_federation_api',
-					'dav',
-					'federatedfilesharing',
-					'lookup_server_connector',
-					'oauth2',
-					'profile',
-					'provisioning_api',
-					'settings',
-					'theming',
-					'twofactor_backupcodes',
-					'viewer',
-					'workflowengine',
-				],
-				false,
-			],
-			//  user given, but ask for all
-			[
-				self::TEST_USER1,
-				[
-					'files',
-					'app1',
-					'app3',
-					'appforgroup1',
-					'appforgroup12',
-					'appforgroup2',
-					'cloud_federation_api',
-					'dav',
-					'federatedfilesharing',
-					'lookup_server_connector',
-					'oauth2',
-					'profile',
-					'provisioning_api',
-					'settings',
-					'theming',
-					'twofactor_backupcodes',
-					'viewer',
-					'workflowengine',
-				],
-				true,
-			],
-		];
-	}
+    /**
+     * Providers for the app config values
+     */
+    public static function appConfigValuesProvider(): array {
+        return [
+            // logged in user1
+            [
+                self::TEST_USER1,
+                [
+                    'files',
+                    'app1',
+                    'app3',
+                    'appforgroup1',
+                    'appforgroup12',
+                    'cloud_federation_api',
+                    'dav',
+                    'federatedfilesharing',
+                    'lookup_server_connector',
+                    'oauth2',
+                    'profile',
+                    'provisioning_api',
+                    'settings',
+                    'theming',
+                    'twofactor_backupcodes',
+                    'viewer',
+                    'workflowengine',
+                ],
+                false
+            ],
+            // logged in user2
+            [
+                self::TEST_USER2,
+                [
+                    'files',
+                    'app1',
+                    'app3',
+                    'appforgroup12',
+                    'appforgroup2',
+                    'cloud_federation_api',
+                    'dav',
+                    'federatedfilesharing',
+                    'lookup_server_connector',
+                    'oauth2',
+                    'profile',
+                    'provisioning_api',
+                    'settings',
+                    'theming',
+                    'twofactor_backupcodes',
+                    'viewer',
+                    'workflowengine',
+                ],
+                false
+            ],
+            // logged in user3
+            [
+                self::TEST_USER3,
+                [
+                    'files',
+                    'app1',
+                    'app3',
+                    'appforgroup1',
+                    'appforgroup12',
+                    'appforgroup2',
+                    'cloud_federation_api',
+                    'dav',
+                    'federatedfilesharing',
+                    'lookup_server_connector',
+                    'oauth2',
+                    'profile',
+                    'provisioning_api',
+                    'settings',
+                    'theming',
+                    'twofactor_backupcodes',
+                    'viewer',
+                    'workflowengine',
+                ],
+                false
+            ],
+            //  no user, returns all apps
+            [
+                null,
+                [
+                    'files',
+                    'app1',
+                    'app3',
+                    'appforgroup1',
+                    'appforgroup12',
+                    'appforgroup2',
+                    'cloud_federation_api',
+                    'dav',
+                    'federatedfilesharing',
+                    'lookup_server_connector',
+                    'oauth2',
+                    'profile',
+                    'provisioning_api',
+                    'settings',
+                    'theming',
+                    'twofactor_backupcodes',
+                    'viewer',
+                    'workflowengine',
+                ],
+                false,
+            ],
+            //  user given, but ask for all
+            [
+                self::TEST_USER1,
+                [
+                    'files',
+                    'app1',
+                    'app3',
+                    'appforgroup1',
+                    'appforgroup12',
+                    'appforgroup2',
+                    'cloud_federation_api',
+                    'dav',
+                    'federatedfilesharing',
+                    'lookup_server_connector',
+                    'oauth2',
+                    'profile',
+                    'provisioning_api',
+                    'settings',
+                    'theming',
+                    'twofactor_backupcodes',
+                    'viewer',
+                    'workflowengine',
+                ],
+                true,
+            ],
+        ];
+    }
 
-	/**
-	 * Test enabled apps
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('appConfigValuesProvider')]
-	public function testEnabledApps($user, $expectedApps, $forceAll): void {
-		$userManager = Server::get(IUserManager::class);
-		$groupManager = Server::get(IGroupManager::class);
-		$user1 = $userManager->createUser(self::TEST_USER1, 'NotAnEasyPassword123456+');
-		$user2 = $userManager->createUser(self::TEST_USER2, 'NotAnEasyPassword123456_');
-		$user3 = $userManager->createUser(self::TEST_USER3, 'NotAnEasyPassword123456?');
+    /**
+     * Test enabled apps
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('appConfigValuesProvider')]
+    public function testEnabledApps($user, $expectedApps, $forceAll): void {
+        $userManager = Server::get(IUserManager::class);
+        $groupManager = Server::get(IGroupManager::class);
+        $user1 = $userManager->createUser(self::TEST_USER1, 'NotAnEasyPassword123456+');
+        $user2 = $userManager->createUser(self::TEST_USER2, 'NotAnEasyPassword123456_');
+        $user3 = $userManager->createUser(self::TEST_USER3, 'NotAnEasyPassword123456?');
 
-		$group1 = $groupManager->createGroup(self::TEST_GROUP1);
-		$group1->addUser($user1);
-		$group1->addUser($user3);
-		$group2 = $groupManager->createGroup(self::TEST_GROUP2);
-		$group2->addUser($user2);
-		$group2->addUser($user3);
+        $group1 = $groupManager->createGroup(self::TEST_GROUP1);
+        $group1->addUser($user1);
+        $group1->addUser($user3);
+        $group2 = $groupManager->createGroup(self::TEST_GROUP2);
+        $group2->addUser($user2);
+        $group2->addUser($user3);
 
-		\OC_User::setUserId($user);
+        \OC_User::setUserId($user);
 
-		$this->setupAppConfigMock()->expects($this->once())
-			->method('searchValues')
-			->willReturn(
-				[
-					'app3' => 'yes',
-					'app2' => 'no',
-					'app1' => 'yes',
-					'appforgroup1' => '["group1"]',
-					'appforgroup2' => '["group2"]',
-					'appforgroup12' => '["group2","group1"]',
-				]
-			);
+        $this->setupAppConfigMock()->expects($this->once())
+            ->method('searchValues')
+            ->willReturn(
+                [
+                    'app3' => 'yes',
+                    'app2' => 'no',
+                    'app1' => 'yes',
+                    'appforgroup1' => '["group1"]',
+                    'appforgroup2' => '["group2"]',
+                    'appforgroup12' => '["group2","group1"]',
+                ]
+            );
 
-		$apps = \OC_App::getEnabledApps(false, $forceAll);
+        $apps = \OC_App::getEnabledApps(false, $forceAll);
 
-		$this->restoreAppConfig();
-		\OC_User::setUserId(null);
+        $this->restoreAppConfig();
+        \OC_User::setUserId(null);
 
-		$user1->delete();
-		$user2->delete();
-		$user3->delete();
+        $user1->delete();
+        $user2->delete();
+        $user3->delete();
 
-		$group1->delete();
-		$group2->delete();
+        $group1->delete();
+        $group2->delete();
 
-		$this->assertEquals($expectedApps, $apps);
-	}
+        $this->assertEquals($expectedApps, $apps);
+    }
 
-	/**
-	 * Test isEnabledApps() with cache, not re-reading the list of
-	 * enabled apps more than once when a user is set.
-	 */
-	public function testEnabledAppsCache(): void {
-		$userManager = Server::get(IUserManager::class);
-		$user1 = $userManager->createUser(self::TEST_USER1, 'NotAnEasyPassword123456+');
+    /**
+     * Test isEnabledApps() with cache, not re-reading the list of
+     * enabled apps more than once when a user is set.
+     */
+    public function testEnabledAppsCache(): void {
+        $userManager = Server::get(IUserManager::class);
+        $user1 = $userManager->createUser(self::TEST_USER1, 'NotAnEasyPassword123456+');
 
-		\OC_User::setUserId(self::TEST_USER1);
+        \OC_User::setUserId(self::TEST_USER1);
 
-		$this->setupAppConfigMock()->expects($this->once())
-			->method('searchValues')
-			->willReturn(
-				[
-					'app3' => 'yes',
-					'app2' => 'no',
-				]
-			);
+        $this->setupAppConfigMock()->expects($this->once())
+            ->method('searchValues')
+            ->willReturn(
+                [
+                    'app3' => 'yes',
+                    'app2' => 'no',
+                ]
+            );
 
-		$apps = \OC_App::getEnabledApps();
-		$this->assertEquals(['files', 'app3', 'cloud_federation_api', 'dav', 'federatedfilesharing', 'lookup_server_connector', 'oauth2', 'profile', 'provisioning_api', 'settings', 'theming', 'twofactor_backupcodes', 'viewer', 'workflowengine'], $apps);
+        $apps = \OC_App::getEnabledApps();
+        $this->assertEquals(['files', 'app3', 'cloud_federation_api', 'dav', 'federatedfilesharing', 'lookup_server_connector', 'oauth2', 'profile', 'provisioning_api', 'settings', 'theming', 'twofactor_backupcodes', 'viewer', 'workflowengine'], $apps);
 
-		// mock should not be called again here
-		$apps = \OC_App::getEnabledApps();
-		$this->assertEquals(['files', 'app3', 'cloud_federation_api', 'dav', 'federatedfilesharing', 'lookup_server_connector', 'oauth2', 'profile', 'provisioning_api', 'settings', 'theming', 'twofactor_backupcodes', 'viewer', 'workflowengine'], $apps);
+        // mock should not be called again here
+        $apps = \OC_App::getEnabledApps();
+        $this->assertEquals(['files', 'app3', 'cloud_federation_api', 'dav', 'federatedfilesharing', 'lookup_server_connector', 'oauth2', 'profile', 'provisioning_api', 'settings', 'theming', 'twofactor_backupcodes', 'viewer', 'workflowengine'], $apps);
 
-		$this->restoreAppConfig();
-		\OC_User::setUserId(null);
+        $this->restoreAppConfig();
+        \OC_User::setUserId(null);
 
-		$user1->delete();
-	}
+        $user1->delete();
+    }
 
 
-	private function setupAppConfigMock() {
-		/** @var AppConfig|MockObject */
-		$appConfig = $this->getMockBuilder(AppConfig::class)
-			->onlyMethods(['searchValues'])
-			->setConstructorArgs([Server::get(IDBConnection::class)])
-			->disableOriginalConstructor()
-			->getMock();
+    private function setupAppConfigMock() {
+        /** @var AppConfig|MockObject */
+        $appConfig = $this->getMockBuilder(AppConfig::class)
+            ->onlyMethods(['searchValues'])
+            ->setConstructorArgs([Server::get(IDBConnection::class)])
+            ->disableOriginalConstructor()
+            ->getMock();
 
-		$this->registerAppConfig($appConfig);
-		return $appConfig;
-	}
+        $this->registerAppConfig($appConfig);
+        return $appConfig;
+    }
 
-	/**
-	 * Register an app config mock for testing purposes.
-	 *
-	 * @param IAppConfig $appConfig app config mock
-	 */
-	private function registerAppConfig(AppConfig $appConfig) {
-		$this->overwriteService(AppConfig::class, $appConfig);
-		$this->overwriteService(AppManager::class, new AppManager(
-			Server::get(IUserSession::class),
-			Server::get(IConfig::class),
-			Server::get(IGroupManager::class),
-			Server::get(ICacheFactory::class),
-			Server::get(IEventDispatcher::class),
-			Server::get(LoggerInterface::class),
-			Server::get(ServerVersion::class),
-			Server::get(ConfigManager::class),
-		));
-	}
+    /**
+     * Register an app config mock for testing purposes.
+     *
+     * @param IAppConfig $appConfig app config mock
+     */
+    private function registerAppConfig(AppConfig $appConfig) {
+        $this->overwriteService(AppConfig::class, $appConfig);
+        $this->overwriteService(AppManager::class, new AppManager(
+            Server::get(IUserSession::class),
+            Server::get(IConfig::class),
+            Server::get(IGroupManager::class),
+            Server::get(ICacheFactory::class),
+            Server::get(IEventDispatcher::class),
+            Server::get(LoggerInterface::class),
+            Server::get(ServerVersion::class),
+            Server::get(ConfigManager::class),
+        ));
+    }
 
-	/**
-	 * Restore the original app config service.
-	 */
-	private function restoreAppConfig() {
-		$this->restoreService(AppConfig::class);
-		$this->restoreService(AppManager::class);
+    /**
+     * Restore the original app config service.
+     */
+    private function restoreAppConfig() {
+        $this->restoreService(AppConfig::class);
+        $this->restoreService(AppManager::class);
 
-		// Remove the cache of the mocked apps list with a forceRefresh
-		\OC_App::getEnabledApps();
-	}
+        // Remove the cache of the mocked apps list with a forceRefresh
+        \OC_App::getEnabledApps();
+    }
 }

tests/lib/App/InfoParserTest.php

Indentation +82 added lines, -82 removed lines

@@ -13,97 +13,97 @@
 use Test\TestCase;
 
 class InfoParserTest extends TestCase {
-	/** @var CappedMemoryCache */
-	private static $cache;
+    /** @var CappedMemoryCache */
+    private static $cache;
 
-	public static function setUpBeforeClass(): void {
-		self::$cache = new CappedMemoryCache();
-	}
+    public static function setUpBeforeClass(): void {
+        self::$cache = new CappedMemoryCache();
+    }
 
-	public function parserTest($expectedJson, $xmlFile, $cache = null) {
-		$parser = new InfoParser($cache);
+    public function parserTest($expectedJson, $xmlFile, $cache = null) {
+        $parser = new InfoParser($cache);
 
-		$expectedData = null;
-		if (!is_null($expectedJson)) {
-			$expectedData = json_decode(file_get_contents(OC::$SERVERROOT . "/tests/data/app/$expectedJson"), true);
-		}
-		$data = $parser->parse(OC::$SERVERROOT . "/tests/data/app/$xmlFile");
+        $expectedData = null;
+        if (!is_null($expectedJson)) {
+            $expectedData = json_decode(file_get_contents(OC::$SERVERROOT . "/tests/data/app/$expectedJson"), true);
+        }
+        $data = $parser->parse(OC::$SERVERROOT . "/tests/data/app/$xmlFile");
 
-		$this->assertEquals($expectedData, $data);
-	}
+        $this->assertEquals($expectedData, $data);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesInfoXml')]
-	public function testParsingValidXmlWithoutCache($expectedJson, $xmlFile): void {
-		$this->parserTest($expectedJson, $xmlFile);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesInfoXml')]
+    public function testParsingValidXmlWithoutCache($expectedJson, $xmlFile): void {
+        $this->parserTest($expectedJson, $xmlFile);
+    }
 
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesInfoXml')]
-	public function testParsingValidXmlWithCache($expectedJson, $xmlFile): void {
-		$this->parserTest($expectedJson, $xmlFile, self::$cache);
-	}
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesInfoXml')]
+    public function testParsingValidXmlWithCache($expectedJson, $xmlFile): void {
+        $this->parserTest($expectedJson, $xmlFile, self::$cache);
+    }
 
-	public static function providesInfoXml(): array {
-		return [
-			['expected-info.json', 'valid-info.xml'],
-			[null, 'invalid-info.xml'],
-			['expected-info.json', 'valid-info.xml'],
-			[null, 'invalid-info.xml'],
-			['navigation-one-item.json', 'navigation-one-item.xml'],
-			['navigation-two-items.json', 'navigation-two-items.xml'],
-			['various-single-item.json', 'various-single-item.xml'],
-		];
-	}
+    public static function providesInfoXml(): array {
+        return [
+            ['expected-info.json', 'valid-info.xml'],
+            [null, 'invalid-info.xml'],
+            ['expected-info.json', 'valid-info.xml'],
+            [null, 'invalid-info.xml'],
+            ['navigation-one-item.json', 'navigation-one-item.xml'],
+            ['navigation-two-items.json', 'navigation-two-items.xml'],
+            ['various-single-item.json', 'various-single-item.xml'],
+        ];
+    }
 
-	/**
-	 * Providers for the app data values
-	 */
-	public static function appDataProvider(): array {
-		return [
-			[
-				['description' => " \t  This is a multiline \n test with \n \t \n \n some new lines   "],
-				['description' => "This is a multiline \n test with \n \t \n \n some new lines"],
-			],
-			[
-				['description' => " \t  This is a multiline \n test with \n \t   some new lines   "],
-				['description' => "This is a multiline \n test with \n \t   some new lines"],
-			],
-			[
-				['description' => hex2bin('5065726d657420646520732761757468656e7469666965722064616e732070697769676f20646972656374656d656e74206176656320736573206964656e74696669616e7473206f776e636c6f75642073616e73206c65732072657461706572206574206d657420c3a0206a6f757273206365757820636920656e20636173206465206368616e67656d656e74206465206d6f742064652070617373652e0d0a0d')],
-				['description' => "Permet de s'authentifier dans piwigo directement avec ses identifiants owncloud sans les retaper et met à jours ceux ci en cas de changement de mot de passe."],
-			],
-			[
-				['not-a-description' => " \t  This is a multiline \n test with \n \t   some new lines   "],
-				[
-					'not-a-description' => " \t  This is a multiline \n test with \n \t   some new lines   ",
-					'description' => '',
-				],
-			],
-			[
-				['description' => [100, 'bla']],
-				['description' => ''],
-			],
-		];
-	}
+    /**
+     * Providers for the app data values
+     */
+    public static function appDataProvider(): array {
+        return [
+            [
+                ['description' => " \t  This is a multiline \n test with \n \t \n \n some new lines   "],
+                ['description' => "This is a multiline \n test with \n \t \n \n some new lines"],
+            ],
+            [
+                ['description' => " \t  This is a multiline \n test with \n \t   some new lines   "],
+                ['description' => "This is a multiline \n test with \n \t   some new lines"],
+            ],
+            [
+                ['description' => hex2bin('5065726d657420646520732761757468656e7469666965722064616e732070697769676f20646972656374656d656e74206176656320736573206964656e74696669616e7473206f776e636c6f75642073616e73206c65732072657461706572206574206d657420c3a0206a6f757273206365757820636920656e20636173206465206368616e67656d656e74206465206d6f742064652070617373652e0d0a0d')],
+                ['description' => "Permet de s'authentifier dans piwigo directement avec ses identifiants owncloud sans les retaper et met à jours ceux ci en cas de changement de mot de passe."],
+            ],
+            [
+                ['not-a-description' => " \t  This is a multiline \n test with \n \t   some new lines   "],
+                [
+                    'not-a-description' => " \t  This is a multiline \n test with \n \t   some new lines   ",
+                    'description' => '',
+                ],
+            ],
+            [
+                ['description' => [100, 'bla']],
+                ['description' => ''],
+            ],
+        ];
+    }
 
-	/**
-	 * Test app info parser
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('appDataProvider')]
-	public function testApplyL10NNoLanguage(array $data, array $expected): void {
-		$parser = new InfoParser();
-		$this->assertSame($expected, $parser->applyL10N($data));
-	}
+    /**
+     * Test app info parser
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('appDataProvider')]
+    public function testApplyL10NNoLanguage(array $data, array $expected): void {
+        $parser = new InfoParser();
+        $this->assertSame($expected, $parser->applyL10N($data));
+    }
 
-	public function testApplyL10N(): void {
-		$parser = new InfoParser();
-		$data = $parser->parse(\OC::$SERVERROOT . '/tests/data/app/description-multi-lang.xml');
-		$this->assertEquals('English', $parser->applyL10N($data, 'en')['description']);
-		$this->assertEquals('German', $parser->applyL10N($data, 'de')['description']);
-	}
+    public function testApplyL10N(): void {
+        $parser = new InfoParser();
+        $data = $parser->parse(\OC::$SERVERROOT . '/tests/data/app/description-multi-lang.xml');
+        $this->assertEquals('English', $parser->applyL10N($data, 'en')['description']);
+        $this->assertEquals('German', $parser->applyL10N($data, 'de')['description']);
+    }
 
-	public function testApplyL10NSingleLanguage(): void {
-		$parser = new InfoParser();
-		$data = $parser->parse(\OC::$SERVERROOT . '/tests/data/app/description-single-lang.xml');
-		$this->assertEquals('English', $parser->applyL10N($data, 'en')['description']);
-	}
+    public function testApplyL10NSingleLanguage(): void {
+        $parser = new InfoParser();
+        $data = $parser->parse(\OC::$SERVERROOT . '/tests/data/app/description-single-lang.xml');
+        $this->assertEquals('English', $parser->applyL10N($data, 'en')['description']);
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -25,9 +25,9 @@ 
 
 		$expectedData = null;
 		if (!is_null($expectedJson)) {
-			$expectedData = json_decode(file_get_contents(OC::$SERVERROOT . "/tests/data/app/$expectedJson"), true);
+			$expectedData = json_decode(file_get_contents(OC::$SERVERROOT."/tests/data/app/$expectedJson"), true);
 		}
-		$data = $parser->parse(OC::$SERVERROOT . "/tests/data/app/$xmlFile");
+		$data = $parser->parse(OC::$SERVERROOT."/tests/data/app/$xmlFile");
 
 		$this->assertEquals($expectedData, $data);
 	}
@@ -96,14 +96,14 @@ 
 
 	public function testApplyL10N(): void {
 		$parser = new InfoParser();
-		$data = $parser->parse(\OC::$SERVERROOT . '/tests/data/app/description-multi-lang.xml');
+		$data = $parser->parse(\OC::$SERVERROOT.'/tests/data/app/description-multi-lang.xml');
 		$this->assertEquals('English', $parser->applyL10N($data, 'en')['description']);
 		$this->assertEquals('German', $parser->applyL10N($data, 'de')['description']);
 	}
 
 	public function testApplyL10NSingleLanguage(): void {
 		$parser = new InfoParser();
-		$data = $parser->parse(\OC::$SERVERROOT . '/tests/data/app/description-single-lang.xml');
+		$data = $parser->parse(\OC::$SERVERROOT.'/tests/data/app/description-single-lang.xml');
 		$this->assertEquals('English', $parser->applyL10N($data, 'en')['description']);
 	}
 }

tests/lib/App/DependencyAnalyzerTest.php

Indentation +446 added lines, -446 removed lines

@@ -13,476 +13,476 @@
 use Test\TestCase;
 
 class DependencyAnalyzerTest extends TestCase {
-	/** @var Platform|\PHPUnit\Framework\MockObject\MockObject */
-	private $platformMock;
+    /** @var Platform|\PHPUnit\Framework\MockObject\MockObject */
+    private $platformMock;
 
-	/** @var IL10N */
-	private $l10nMock;
+    /** @var IL10N */
+    private $l10nMock;
 
-	/** @var DependencyAnalyzer */
-	private $analyser;
+    /** @var DependencyAnalyzer */
+    private $analyser;
 
-	protected function setUp(): void {
-		$this->platformMock = $this->getMockBuilder(Platform::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->platformMock->expects($this->any())
-			->method('getPhpVersion')
-			->willReturn('5.4.3');
-		$this->platformMock->expects($this->any())
-			->method('getIntSize')
-			->willReturn(4);
-		$this->platformMock->expects($this->any())
-			->method('getDatabase')
-			->willReturn('mysql');
-		$this->platformMock->expects($this->any())
-			->method('getOS')
-			->willReturn('Linux');
-		$this->platformMock->expects($this->any())
-			->method('isCommandKnown')
-			->willReturnCallback(function ($command) {
-				return ($command === 'grep');
-			});
-		$this->platformMock->expects($this->any())
-			->method('getLibraryVersion')
-			->willReturnCallback(function ($lib) {
-				if ($lib === 'curl') {
-					return '2.3.4';
-				}
-				return null;
-			});
-		$this->platformMock->expects($this->any())
-			->method('getOcVersion')
-			->willReturn('8.0.2');
+    protected function setUp(): void {
+        $this->platformMock = $this->getMockBuilder(Platform::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->platformMock->expects($this->any())
+            ->method('getPhpVersion')
+            ->willReturn('5.4.3');
+        $this->platformMock->expects($this->any())
+            ->method('getIntSize')
+            ->willReturn(4);
+        $this->platformMock->expects($this->any())
+            ->method('getDatabase')
+            ->willReturn('mysql');
+        $this->platformMock->expects($this->any())
+            ->method('getOS')
+            ->willReturn('Linux');
+        $this->platformMock->expects($this->any())
+            ->method('isCommandKnown')
+            ->willReturnCallback(function ($command) {
+                return ($command === 'grep');
+            });
+        $this->platformMock->expects($this->any())
+            ->method('getLibraryVersion')
+            ->willReturnCallback(function ($lib) {
+                if ($lib === 'curl') {
+                    return '2.3.4';
+                }
+                return null;
+            });
+        $this->platformMock->expects($this->any())
+            ->method('getOcVersion')
+            ->willReturn('8.0.2');
 
-		$this->l10nMock = $this->getMockBuilder(IL10N::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$this->l10nMock->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
+        $this->l10nMock = $this->getMockBuilder(IL10N::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->l10nMock->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
 
-		$this->analyser = new DependencyAnalyzer($this->platformMock, $this->l10nMock);
-	}
+        $this->analyser = new DependencyAnalyzer($this->platformMock, $this->l10nMock);
+    }
 
-	/**
-	 *
-	 * @param string $expectedMissing
-	 * @param string $minVersion
-	 * @param string $maxVersion
-	 * @param string $intSize
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesPhpVersion')]
-	public function testPhpVersion($expectedMissing, $minVersion, $maxVersion, $intSize): void {
-		$app = [
-			'dependencies' => [
-				'php' => []
-			]
-		];
-		if (!is_null($minVersion)) {
-			$app['dependencies']['php']['@attributes']['min-version'] = $minVersion;
-		}
-		if (!is_null($maxVersion)) {
-			$app['dependencies']['php']['@attributes']['max-version'] = $maxVersion;
-		}
-		if (!is_null($intSize)) {
-			$app['dependencies']['php']['@attributes']['min-int-size'] = $intSize;
-		}
-		$missing = $this->analyser->analyze($app);
+    /**
+     *
+     * @param string $expectedMissing
+     * @param string $minVersion
+     * @param string $maxVersion
+     * @param string $intSize
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesPhpVersion')]
+    public function testPhpVersion($expectedMissing, $minVersion, $maxVersion, $intSize): void {
+        $app = [
+            'dependencies' => [
+                'php' => []
+            ]
+        ];
+        if (!is_null($minVersion)) {
+            $app['dependencies']['php']['@attributes']['min-version'] = $minVersion;
+        }
+        if (!is_null($maxVersion)) {
+            $app['dependencies']['php']['@attributes']['max-version'] = $maxVersion;
+        }
+        if (!is_null($intSize)) {
+            $app['dependencies']['php']['@attributes']['min-int-size'] = $intSize;
+        }
+        $missing = $this->analyser->analyze($app);
 
-		$this->assertTrue(is_array($missing));
-		$this->assertEquals($expectedMissing, $missing);
-	}
+        $this->assertTrue(is_array($missing));
+        $this->assertEquals($expectedMissing, $missing);
+    }
 
-	/**
-	 * @param $expectedMissing
-	 * @param $databases
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesDatabases')]
-	public function testDatabases($expectedMissing, $databases): void {
-		$app = [
-			'dependencies' => [
-			]
-		];
-		if (!is_null($databases)) {
-			$app['dependencies']['database'] = $databases;
-		}
-		$missing = $this->analyser->analyze($app);
+    /**
+     * @param $expectedMissing
+     * @param $databases
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesDatabases')]
+    public function testDatabases($expectedMissing, $databases): void {
+        $app = [
+            'dependencies' => [
+            ]
+        ];
+        if (!is_null($databases)) {
+            $app['dependencies']['database'] = $databases;
+        }
+        $missing = $this->analyser->analyze($app);
 
-		$this->assertTrue(is_array($missing));
-		$this->assertEquals($expectedMissing, $missing);
-	}
+        $this->assertTrue(is_array($missing));
+        $this->assertEquals($expectedMissing, $missing);
+    }
 
-	/**
-	 *
-	 * @param string $expectedMissing
-	 * @param string|null $commands
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesCommands')]
-	public function testCommand($expectedMissing, $commands): void {
-		$app = [
-			'dependencies' => [
-			]
-		];
-		if (!is_null($commands)) {
-			$app['dependencies']['command'] = $commands;
-		}
-		$missing = $this->analyser->analyze($app);
+    /**
+     *
+     * @param string $expectedMissing
+     * @param string|null $commands
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesCommands')]
+    public function testCommand($expectedMissing, $commands): void {
+        $app = [
+            'dependencies' => [
+            ]
+        ];
+        if (!is_null($commands)) {
+            $app['dependencies']['command'] = $commands;
+        }
+        $missing = $this->analyser->analyze($app);
 
-		$this->assertTrue(is_array($missing));
-		$this->assertEquals($expectedMissing, $missing);
-	}
+        $this->assertTrue(is_array($missing));
+        $this->assertEquals($expectedMissing, $missing);
+    }
 
-	/**
-	 * @param $expectedMissing
-	 * @param $libs
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesLibs')]
-	public function testLibs($expectedMissing, $libs): void {
-		$app = [
-			'dependencies' => [
-			]
-		];
-		if (!is_null($libs)) {
-			$app['dependencies']['lib'] = $libs;
-		}
+    /**
+     * @param $expectedMissing
+     * @param $libs
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesLibs')]
+    public function testLibs($expectedMissing, $libs): void {
+        $app = [
+            'dependencies' => [
+            ]
+        ];
+        if (!is_null($libs)) {
+            $app['dependencies']['lib'] = $libs;
+        }
 
-		$missing = $this->analyser->analyze($app);
+        $missing = $this->analyser->analyze($app);
 
-		$this->assertTrue(is_array($missing));
-		$this->assertEquals($expectedMissing, $missing);
-	}
+        $this->assertTrue(is_array($missing));
+        $this->assertEquals($expectedMissing, $missing);
+    }
 
-	/**
-	 * @param $expectedMissing
-	 * @param $oss
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesOS')]
-	public function testOS($expectedMissing, $oss): void {
-		$app = [
-			'dependencies' => []
-		];
-		if (!is_null($oss)) {
-			$app['dependencies']['os'] = $oss;
-		}
+    /**
+     * @param $expectedMissing
+     * @param $oss
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesOS')]
+    public function testOS($expectedMissing, $oss): void {
+        $app = [
+            'dependencies' => []
+        ];
+        if (!is_null($oss)) {
+            $app['dependencies']['os'] = $oss;
+        }
 
-		$missing = $this->analyser->analyze($app);
+        $missing = $this->analyser->analyze($app);
 
-		$this->assertTrue(is_array($missing));
-		$this->assertEquals($expectedMissing, $missing);
-	}
+        $this->assertTrue(is_array($missing));
+        $this->assertEquals($expectedMissing, $missing);
+    }
 
-	/**
-	 * @param $expectedMissing
-	 * @param $oc
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('providesOC')]
-	public function testOC($expectedMissing, $oc): void {
-		$app = [
-			'dependencies' => []
-		];
-		if (!is_null($oc)) {
-			$app['dependencies'] = $oc;
-		}
+    /**
+     * @param $expectedMissing
+     * @param $oc
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('providesOC')]
+    public function testOC($expectedMissing, $oc): void {
+        $app = [
+            'dependencies' => []
+        ];
+        if (!is_null($oc)) {
+            $app['dependencies'] = $oc;
+        }
 
-		$missing = $this->analyser->analyze($app);
+        $missing = $this->analyser->analyze($app);
 
-		$this->assertTrue(is_array($missing));
-		$this->assertEquals($expectedMissing, $missing);
-	}
+        $this->assertTrue(is_array($missing));
+        $this->assertEquals($expectedMissing, $missing);
+    }
 
-	/**
-	 * @return array
-	 */
-	public static function providesOC(): array {
-		return [
-			// no version -> no missing dependency
-			[
-				[],
-				null,
-			],
-			[
-				[],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'min-version' => '8',
-							'max-version' => '8',
-						],
-					],
-				],
-			],
-			[
-				[],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'min-version' => '8.0',
-							'max-version' => '8.0',
-						],
-					],
-				],
-			],
-			[
-				[],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'min-version' => '8.0.2',
-							'max-version' => '8.0.2'
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 8.0.3 or higher is required.',
-				],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'min-version' => '8.0.3'
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 9 or higher is required.',
-				],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'min-version' => '9'
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 10 or higher is required.',
-				],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'min-version' => '10'
-						],
-					],
-					'owncloud' => [
-						'@attributes' => [
-							'min-version' => '9'
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 9.2 or higher is required.',
-				],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'min-version' => '9.2',
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 11 or higher is required.',
-				],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'min-version' => '11',
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 8.0.1 or lower is required.',
-				],
-				[
-					'nextcloud' => [
-						'@attributes' => [
-							'max-version' => '8.0.1',
-						],
-					],
-				],
-			],
-			[
-				[],
-				[
-					'owncloud' => [
-						'@attributes' => [
-							'min-version' => '8',
-							'max-version' => '8',
-						],
-					],
-				],
-			],
-			[
-				[],
-				[
-					'owncloud' => [
-						'@attributes' => [
-							'min-version' => '8.0',
-							'max-version' => '8.0',
-						],
-					],
-				],
-			],
-			[
-				[],
-				[
-					'owncloud' => [
-						'@attributes' => [
-							'min-version' => '8.0.2',
-							'max-version' => '8.0.2'
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 8.0.3 or higher is required.',
-				],
-				[
-					'owncloud' => [
-						'@attributes' => [
-							'min-version' => '8.0.3'
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 9 or higher is required.',
-				],
-				[
-					'owncloud' => [
-						'@attributes' => [
-							'min-version' => '9'
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 9.2 or higher is required.',
-				],
-				[
-					'owncloud' => [
-						'@attributes' => [
-							'min-version' => '9.2',
-						],
-					],
-				],
-			],
-			[
-				[
-					'Server version 8.0.1 or lower is required.',
-				],
-				[
-					'owncloud' => [
-						'@attributes' => [
-							'max-version' => '8.0.1',
-						],
-					],
-				],
-			],
-		];
-	}
+    /**
+     * @return array
+     */
+    public static function providesOC(): array {
+        return [
+            // no version -> no missing dependency
+            [
+                [],
+                null,
+            ],
+            [
+                [],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'min-version' => '8',
+                            'max-version' => '8',
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'min-version' => '8.0',
+                            'max-version' => '8.0',
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'min-version' => '8.0.2',
+                            'max-version' => '8.0.2'
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 8.0.3 or higher is required.',
+                ],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'min-version' => '8.0.3'
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 9 or higher is required.',
+                ],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'min-version' => '9'
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 10 or higher is required.',
+                ],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'min-version' => '10'
+                        ],
+                    ],
+                    'owncloud' => [
+                        '@attributes' => [
+                            'min-version' => '9'
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 9.2 or higher is required.',
+                ],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'min-version' => '9.2',
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 11 or higher is required.',
+                ],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'min-version' => '11',
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 8.0.1 or lower is required.',
+                ],
+                [
+                    'nextcloud' => [
+                        '@attributes' => [
+                            'max-version' => '8.0.1',
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [],
+                [
+                    'owncloud' => [
+                        '@attributes' => [
+                            'min-version' => '8',
+                            'max-version' => '8',
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [],
+                [
+                    'owncloud' => [
+                        '@attributes' => [
+                            'min-version' => '8.0',
+                            'max-version' => '8.0',
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [],
+                [
+                    'owncloud' => [
+                        '@attributes' => [
+                            'min-version' => '8.0.2',
+                            'max-version' => '8.0.2'
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 8.0.3 or higher is required.',
+                ],
+                [
+                    'owncloud' => [
+                        '@attributes' => [
+                            'min-version' => '8.0.3'
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 9 or higher is required.',
+                ],
+                [
+                    'owncloud' => [
+                        '@attributes' => [
+                            'min-version' => '9'
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 9.2 or higher is required.',
+                ],
+                [
+                    'owncloud' => [
+                        '@attributes' => [
+                            'min-version' => '9.2',
+                        ],
+                    ],
+                ],
+            ],
+            [
+                [
+                    'Server version 8.0.1 or lower is required.',
+                ],
+                [
+                    'owncloud' => [
+                        '@attributes' => [
+                            'max-version' => '8.0.1',
+                        ],
+                    ],
+                ],
+            ],
+        ];
+    }
 
-	/**
-	 * @return array
-	 */
-	public static function providesOS(): array {
-		return [
-			[[], null],
-			[[], []],
-			[['The following platforms are supported: ANDROID'], 'ANDROID'],
-			[['The following platforms are supported: WINNT'], ['WINNT']]
-		];
-	}
+    /**
+     * @return array
+     */
+    public static function providesOS(): array {
+        return [
+            [[], null],
+            [[], []],
+            [['The following platforms are supported: ANDROID'], 'ANDROID'],
+            [['The following platforms are supported: WINNT'], ['WINNT']]
+        ];
+    }
 
-	/**
-	 * @return array
-	 */
-	public static function providesLibs(): array {
-		return [
-			// we expect curl to exist
-			[[], 'curl'],
-			// we expect abcde to exist
-			[['The library abcde is not available.'], ['abcde']],
-			// curl in version 100.0 does not exist
-			[['Library curl with a version higher than 100.0 is required - available version 2.3.4.'],
-				[['@attributes' => ['min-version' => '100.0'], '@value' => 'curl']]],
-			// curl in version 100.0 does not exist
-			[['Library curl with a version lower than 1.0.0 is required - available version 2.3.4.'],
-				[['@attributes' => ['max-version' => '1.0.0'], '@value' => 'curl']]],
-			[['Library curl with a version lower than 2.3.3 is required - available version 2.3.4.'],
-				[['@attributes' => ['max-version' => '2.3.3'], '@value' => 'curl']]],
-			[['Library curl with a version higher than 2.3.5 is required - available version 2.3.4.'],
-				[['@attributes' => ['min-version' => '2.3.5'], '@value' => 'curl']]],
-			[[],
-				[['@attributes' => ['min-version' => '2.3.4', 'max-version' => '2.3.4'], '@value' => 'curl']]],
-			[[],
-				[['@attributes' => ['min-version' => '2.3', 'max-version' => '2.3'], '@value' => 'curl']]],
-			[[],
-				[['@attributes' => ['min-version' => '2', 'max-version' => '2'], '@value' => 'curl']]],
-			[[],
-				['@attributes' => ['min-version' => '2', 'max-version' => '2'], '@value' => 'curl']],
-		];
-	}
+    /**
+     * @return array
+     */
+    public static function providesLibs(): array {
+        return [
+            // we expect curl to exist
+            [[], 'curl'],
+            // we expect abcde to exist
+            [['The library abcde is not available.'], ['abcde']],
+            // curl in version 100.0 does not exist
+            [['Library curl with a version higher than 100.0 is required - available version 2.3.4.'],
+                [['@attributes' => ['min-version' => '100.0'], '@value' => 'curl']]],
+            // curl in version 100.0 does not exist
+            [['Library curl with a version lower than 1.0.0 is required - available version 2.3.4.'],
+                [['@attributes' => ['max-version' => '1.0.0'], '@value' => 'curl']]],
+            [['Library curl with a version lower than 2.3.3 is required - available version 2.3.4.'],
+                [['@attributes' => ['max-version' => '2.3.3'], '@value' => 'curl']]],
+            [['Library curl with a version higher than 2.3.5 is required - available version 2.3.4.'],
+                [['@attributes' => ['min-version' => '2.3.5'], '@value' => 'curl']]],
+            [[],
+                [['@attributes' => ['min-version' => '2.3.4', 'max-version' => '2.3.4'], '@value' => 'curl']]],
+            [[],
+                [['@attributes' => ['min-version' => '2.3', 'max-version' => '2.3'], '@value' => 'curl']]],
+            [[],
+                [['@attributes' => ['min-version' => '2', 'max-version' => '2'], '@value' => 'curl']]],
+            [[],
+                ['@attributes' => ['min-version' => '2', 'max-version' => '2'], '@value' => 'curl']],
+        ];
+    }
 
-	/**
-	 * @return array
-	 */
-	public static function providesCommands(): array {
-		return [
-			[[], null],
-			// grep is known on linux
-			[[], [['@attributes' => ['os' => 'Linux'], '@value' => 'grep']]],
-			// grepp is not known on linux
-			[['The command line tool grepp could not be found'], [['@attributes' => ['os' => 'Linux'], '@value' => 'grepp']]],
-			// we don't care about tools on Windows - we are on Linux
-			[[], [['@attributes' => ['os' => 'Windows'], '@value' => 'grepp']]],
-			// grep is known on all systems
-			[[], 'grep'],
-			[[], ['@attributes' => ['os' => 'Linux'], '@value' => 'grep']],
-		];
-	}
+    /**
+     * @return array
+     */
+    public static function providesCommands(): array {
+        return [
+            [[], null],
+            // grep is known on linux
+            [[], [['@attributes' => ['os' => 'Linux'], '@value' => 'grep']]],
+            // grepp is not known on linux
+            [['The command line tool grepp could not be found'], [['@attributes' => ['os' => 'Linux'], '@value' => 'grepp']]],
+            // we don't care about tools on Windows - we are on Linux
+            [[], [['@attributes' => ['os' => 'Windows'], '@value' => 'grepp']]],
+            // grep is known on all systems
+            [[], 'grep'],
+            [[], ['@attributes' => ['os' => 'Linux'], '@value' => 'grep']],
+        ];
+    }
 
-	/**
-	 * @return array
-	 */
-	public static function providesDatabases(): array {
-		return [
-			// non BC - in case on databases are defined -> all are supported
-			[[], null],
-			[[], []],
-			[['The following databases are supported: mongodb'], 'mongodb'],
-			[['The following databases are supported: sqlite, postgres'], ['sqlite', ['@value' => 'postgres']]],
-		];
-	}
+    /**
+     * @return array
+     */
+    public static function providesDatabases(): array {
+        return [
+            // non BC - in case on databases are defined -> all are supported
+            [[], null],
+            [[], []],
+            [['The following databases are supported: mongodb'], 'mongodb'],
+            [['The following databases are supported: sqlite, postgres'], ['sqlite', ['@value' => 'postgres']]],
+        ];
+    }
 
-	/**
-	 * @return array
-	 */
-	public static function providesPhpVersion(): array {
-		return [
-			[[], null, null, null],
-			[[], '5.4', null, null],
-			[[], null, '5.5', null],
-			[[], '5.4', '5.5', null],
-			[['PHP 5.4.4 or higher is required.'], '5.4.4', null, null],
-			[['PHP with a version lower than 5.4.2 is required.'], null, '5.4.2', null],
-			[['64bit or higher PHP required.'], null, null, 64],
-			[[], '5.4', '5.4', null],
-		];
-	}
+    /**
+     * @return array
+     */
+    public static function providesPhpVersion(): array {
+        return [
+            [[], null, null, null],
+            [[], '5.4', null, null],
+            [[], null, '5.5', null],
+            [[], '5.4', '5.5', null],
+            [['PHP 5.4.4 or higher is required.'], '5.4.4', null, null],
+            [['PHP with a version lower than 5.4.2 is required.'], null, '5.4.2', null],
+            [['64bit or higher PHP required.'], null, null, 64],
+            [[], '5.4', '5.4', null],
+        ];
+    }
 }

lib/private/App/AppManager.php

Indentation +914 added lines, -914 removed lines

@@ -35,918 +35,918 @@
 use Psr\Log\LoggerInterface;
 
 class AppManager implements IAppManager {
-	/**
-	 * Apps with these types can not be enabled for certain groups only
-	 * @var string[]
-	 */
-	protected $protectedAppTypes = [
-		'filesystem',
-		'prelogin',
-		'authentication',
-		'logging',
-		'prevent_group_restriction',
-	];
-
-	/** @var string[] $appId => $enabled */
-	private array $enabledAppsCache = [];
-
-	/** @var string[]|null */
-	private ?array $shippedApps = null;
-
-	private array $alwaysEnabled = [];
-	private array $defaultEnabled = [];
-
-	/** @var array */
-	private array $appInfos = [];
-
-	/** @var array */
-	private array $appVersions = [];
-
-	/** @var array */
-	private array $autoDisabledApps = [];
-	private array $appTypes = [];
-
-	/** @var array<string, true> */
-	private array $loadedApps = [];
-
-	private ?AppConfig $appConfig = null;
-	private ?IURLGenerator $urlGenerator = null;
-	private ?INavigationManager $navigationManager = null;
-
-	/**
-	 * Be extremely careful when injecting classes here. The AppManager is used by the installer,
-	 * so it needs to work before installation. See how AppConfig and IURLGenerator are injected for reference
-	 */
-	public function __construct(
-		private IUserSession $userSession,
-		private IConfig $config,
-		private IGroupManager $groupManager,
-		private ICacheFactory $memCacheFactory,
-		private IEventDispatcher $dispatcher,
-		private LoggerInterface $logger,
-		private ServerVersion $serverVersion,
-		private ConfigManager $configManager,
-	) {
-	}
-
-	private function getNavigationManager(): INavigationManager {
-		if ($this->navigationManager === null) {
-			$this->navigationManager = Server::get(INavigationManager::class);
-		}
-		return $this->navigationManager;
-	}
-
-	public function getAppIcon(string $appId, bool $dark = false): ?string {
-		$possibleIcons = $dark ? [$appId . '-dark.svg', 'app-dark.svg'] : [$appId . '.svg', 'app.svg'];
-		$icon = null;
-		foreach ($possibleIcons as $iconName) {
-			try {
-				$icon = $this->getUrlGenerator()->imagePath($appId, $iconName);
-				break;
-			} catch (\RuntimeException $e) {
-				// ignore
-			}
-		}
-		return $icon;
-	}
-
-	private function getAppConfig(): AppConfig {
-		if ($this->appConfig !== null) {
-			return $this->appConfig;
-		}
-		if (!$this->config->getSystemValueBool('installed', false)) {
-			throw new \Exception('Nextcloud is not installed yet, AppConfig is not available');
-		}
-		$this->appConfig = Server::get(AppConfig::class);
-		return $this->appConfig;
-	}
-
-	private function getUrlGenerator(): IURLGenerator {
-		if ($this->urlGenerator !== null) {
-			return $this->urlGenerator;
-		}
-		if (!$this->config->getSystemValueBool('installed', false)) {
-			throw new \Exception('Nextcloud is not installed yet, AppConfig is not available');
-		}
-		$this->urlGenerator = Server::get(IURLGenerator::class);
-		return $this->urlGenerator;
-	}
-
-	/**
-	 * For all enabled apps, return the value of their 'enabled' config key.
-	 *
-	 * @return array<string,string> appId => enabled (may be 'yes', or a json encoded list of group ids)
-	 */
-	private function getEnabledAppsValues(): array {
-		if (!$this->enabledAppsCache) {
-			/** @var array<string,string> */
-			$values = $this->getAppConfig()->searchValues('enabled', false, IAppConfig::VALUE_STRING);
-
-			$alwaysEnabledApps = $this->getAlwaysEnabledApps();
-			foreach ($alwaysEnabledApps as $appId) {
-				$values[$appId] = 'yes';
-			}
-
-			$this->enabledAppsCache = array_filter($values, function ($value) {
-				return $value !== 'no';
-			});
-			ksort($this->enabledAppsCache);
-		}
-		return $this->enabledAppsCache;
-	}
-
-	/**
-	 * Deprecated alias
-	 *
-	 * @return string[]
-	 */
-	public function getInstalledApps() {
-		return $this->getEnabledApps();
-	}
-
-	/**
-	 * List all enabled apps, either for everyone or for some groups
-	 *
-	 * @return list<string>
-	 */
-	public function getEnabledApps(): array {
-		return array_keys($this->getEnabledAppsValues());
-	}
-
-	/**
-	 * Get a list of all apps in the apps folder
-	 *
-	 * @return list<string> an array of app names (string IDs)
-	 */
-	public function getAllAppsInAppsFolders(): array {
-		$apps = [];
-
-		foreach (\OC::$APPSROOTS as $apps_dir) {
-			if (!is_readable($apps_dir['path'])) {
-				$this->logger->warning('unable to read app folder : ' . $apps_dir['path'], ['app' => 'core']);
-				continue;
-			}
-			$dh = opendir($apps_dir['path']);
-
-			if (is_resource($dh)) {
-				while (($file = readdir($dh)) !== false) {
-					if (
-						$file[0] != '.'
-						&& is_dir($apps_dir['path'] . '/' . $file)
-						&& is_file($apps_dir['path'] . '/' . $file . '/appinfo/info.xml')
-					) {
-						$apps[] = $file;
-					}
-				}
-			}
-		}
-
-		return array_values(array_unique($apps));
-	}
-
-	/**
-	 * List all apps enabled for a user
-	 *
-	 * @param \OCP\IUser $user
-	 * @return list<string>
-	 */
-	public function getEnabledAppsForUser(IUser $user) {
-		$apps = $this->getEnabledAppsValues();
-		$appsForUser = array_filter($apps, function ($enabled) use ($user) {
-			return $this->checkAppForUser($enabled, $user);
-		});
-		return array_keys($appsForUser);
-	}
-
-	public function getEnabledAppsForGroup(IGroup $group): array {
-		$apps = $this->getEnabledAppsValues();
-		$appsForGroups = array_filter($apps, function ($enabled) use ($group) {
-			return $this->checkAppForGroups($enabled, $group);
-		});
-		return array_keys($appsForGroups);
-	}
-
-	/**
-	 * Loads all apps
-	 *
-	 * @param string[] $types
-	 * @return bool
-	 *
-	 * This function walks through the Nextcloud directory and loads all apps
-	 * it can find. A directory contains an app if the file /appinfo/info.xml
-	 * exists.
-	 *
-	 * if $types is set to non-empty array, only apps of those types will be loaded
-	 */
-	public function loadApps(array $types = []): bool {
-		if ($this->config->getSystemValueBool('maintenance', false)) {
-			return false;
-		}
-		// Load the enabled apps here
-		$apps = \OC_App::getEnabledApps();
-
-		// Add each apps' folder as allowed class path
-		foreach ($apps as $app) {
-			// If the app is already loaded then autoloading it makes no sense
-			if (!$this->isAppLoaded($app)) {
-				$path = \OC_App::getAppPath($app);
-				if ($path !== false) {
-					\OC_App::registerAutoloading($app, $path);
-				}
-			}
-		}
-
-		// prevent app loading from printing output
-		ob_start();
-		foreach ($apps as $app) {
-			if (!$this->isAppLoaded($app) && ($types === [] || $this->isType($app, $types))) {
-				try {
-					$this->loadApp($app);
-				} catch (\Throwable $e) {
-					$this->logger->emergency('Error during app loading: ' . $e->getMessage(), [
-						'exception' => $e,
-						'app' => $app,
-					]);
-				}
-			}
-		}
-		ob_end_clean();
-
-		return true;
-	}
-
-	/**
-	 * check if an app is of a specific type
-	 *
-	 * @param string $app
-	 * @param array $types
-	 * @return bool
-	 */
-	public function isType(string $app, array $types): bool {
-		$appTypes = $this->getAppTypes($app);
-		foreach ($types as $type) {
-			if (in_array($type, $appTypes, true)) {
-				return true;
-			}
-		}
-		return false;
-	}
-
-	/**
-	 * get the types of an app
-	 *
-	 * @param string $app
-	 * @return string[]
-	 */
-	private function getAppTypes(string $app): array {
-		//load the cache
-		if (count($this->appTypes) === 0) {
-			$this->appTypes = $this->getAppConfig()->getValues(false, 'types') ?: [];
-		}
-
-		if (isset($this->appTypes[$app])) {
-			return explode(',', $this->appTypes[$app]);
-		}
-
-		return [];
-	}
-
-	/**
-	 * @return array
-	 */
-	public function getAutoDisabledApps(): array {
-		return $this->autoDisabledApps;
-	}
-
-	public function getAppRestriction(string $appId): array {
-		$values = $this->getEnabledAppsValues();
-
-		if (!isset($values[$appId])) {
-			return [];
-		}
-
-		if ($values[$appId] === 'yes' || $values[$appId] === 'no') {
-			return [];
-		}
-		return json_decode($values[$appId], true);
-	}
-
-	/**
-	 * Check if an app is enabled for user
-	 *
-	 * @param string $appId
-	 * @param \OCP\IUser|null $user (optional) if not defined, the currently logged in user will be used
-	 * @return bool
-	 */
-	public function isEnabledForUser($appId, $user = null) {
-		if ($this->isAlwaysEnabled($appId)) {
-			return true;
-		}
-		if ($user === null) {
-			$user = $this->userSession->getUser();
-		}
-		$enabledAppsValues = $this->getEnabledAppsValues();
-		if (isset($enabledAppsValues[$appId])) {
-			return $this->checkAppForUser($enabledAppsValues[$appId], $user);
-		} else {
-			return false;
-		}
-	}
-
-	private function checkAppForUser(string $enabled, ?IUser $user): bool {
-		if ($enabled === 'yes') {
-			return true;
-		} elseif ($user === null) {
-			return false;
-		} else {
-			if (empty($enabled)) {
-				return false;
-			}
-
-			$groupIds = json_decode($enabled);
-
-			if (!is_array($groupIds)) {
-				$jsonError = json_last_error();
-				$jsonErrorMsg = json_last_error_msg();
-				// this really should never happen (if it does, the admin should check the `enabled` key value via `occ config:list` because it's bogus for some reason)
-				$this->logger->warning('AppManager::checkAppForUser - can\'t decode group IDs listed in app\'s enabled config key: ' . print_r($enabled, true) . ' - JSON error (' . $jsonError . ') ' . $jsonErrorMsg);
-				return false;
-			}
-
-			$userGroups = $this->groupManager->getUserGroupIds($user);
-			foreach ($userGroups as $groupId) {
-				if (in_array($groupId, $groupIds, true)) {
-					return true;
-				}
-			}
-			return false;
-		}
-	}
-
-	private function checkAppForGroups(string $enabled, IGroup $group): bool {
-		if ($enabled === 'yes') {
-			return true;
-		} else {
-			if (empty($enabled)) {
-				return false;
-			}
-
-			$groupIds = json_decode($enabled);
-
-			if (!is_array($groupIds)) {
-				$jsonError = json_last_error();
-				$jsonErrorMsg = json_last_error_msg();
-				// this really should never happen (if it does, the admin should check the `enabled` key value via `occ config:list` because it's bogus for some reason)
-				$this->logger->warning('AppManager::checkAppForGroups - can\'t decode group IDs listed in app\'s enabled config key: ' . print_r($enabled, true) . ' - JSON error (' . $jsonError . ') ' . $jsonErrorMsg);
-				return false;
-			}
-
-			return in_array($group->getGID(), $groupIds);
-		}
-	}
-
-	/**
-	 * Check if an app is enabled in the instance
-	 *
-	 * Notice: This actually checks if the app is enabled and not only if it is installed.
-	 *
-	 * @param string $appId
-	 */
-	public function isInstalled($appId): bool {
-		return $this->isEnabledForAnyone($appId);
-	}
-
-	public function isEnabledForAnyone(string $appId): bool {
-		$enabledAppsValues = $this->getEnabledAppsValues();
-		return isset($enabledAppsValues[$appId]);
-	}
-
-	/**
-	 * Overwrite the `max-version` requirement for this app.
-	 */
-	public function overwriteNextcloudRequirement(string $appId): void {
-		$ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
-		if (!in_array($appId, $ignoreMaxApps, true)) {
-			$ignoreMaxApps[] = $appId;
-		}
-		$this->config->setSystemValue('app_install_overwrite', $ignoreMaxApps);
-	}
-
-	/**
-	 * Remove the `max-version` overwrite for this app.
-	 * This means this app now again can not be enabled if the `max-version` is smaller than the current Nextcloud version.
-	 */
-	public function removeOverwriteNextcloudRequirement(string $appId): void {
-		$ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
-		$ignoreMaxApps = array_filter($ignoreMaxApps, fn (string $id) => $id !== $appId);
-		$this->config->setSystemValue('app_install_overwrite', $ignoreMaxApps);
-	}
-
-	public function loadApp(string $app): void {
-		if (isset($this->loadedApps[$app])) {
-			return;
-		}
-		$this->loadedApps[$app] = true;
-		$appPath = \OC_App::getAppPath($app);
-		if ($appPath === false) {
-			return;
-		}
-		$eventLogger = \OC::$server->get(IEventLogger::class);
-		$eventLogger->start("bootstrap:load_app:$app", "Load app: $app");
-
-		// in case someone calls loadApp() directly
-		\OC_App::registerAutoloading($app, $appPath);
-
-		if (is_file($appPath . '/appinfo/app.php')) {
-			$this->logger->error('/appinfo/app.php is not supported anymore, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.', [
-				'app' => $app,
-			]);
-		}
-
-		$coordinator = Server::get(Coordinator::class);
-		$coordinator->bootApp($app);
-
-		$eventLogger->start("bootstrap:load_app:$app:info", "Load info.xml for $app and register any services defined in it");
-		$info = $this->getAppInfo($app);
-		if (!empty($info['activity'])) {
-			$activityManager = \OC::$server->get(IActivityManager::class);
-			if (!empty($info['activity']['filters'])) {
-				foreach ($info['activity']['filters'] as $filter) {
-					$activityManager->registerFilter($filter);
-				}
-			}
-			if (!empty($info['activity']['settings'])) {
-				foreach ($info['activity']['settings'] as $setting) {
-					$activityManager->registerSetting($setting);
-				}
-			}
-			if (!empty($info['activity']['providers'])) {
-				foreach ($info['activity']['providers'] as $provider) {
-					$activityManager->registerProvider($provider);
-				}
-			}
-		}
-
-		if (!empty($info['settings'])) {
-			$settingsManager = \OC::$server->get(ISettingsManager::class);
-			if (!empty($info['settings']['admin'])) {
-				foreach ($info['settings']['admin'] as $setting) {
-					$settingsManager->registerSetting('admin', $setting);
-				}
-			}
-			if (!empty($info['settings']['admin-section'])) {
-				foreach ($info['settings']['admin-section'] as $section) {
-					$settingsManager->registerSection('admin', $section);
-				}
-			}
-			if (!empty($info['settings']['personal'])) {
-				foreach ($info['settings']['personal'] as $setting) {
-					$settingsManager->registerSetting('personal', $setting);
-				}
-			}
-			if (!empty($info['settings']['personal-section'])) {
-				foreach ($info['settings']['personal-section'] as $section) {
-					$settingsManager->registerSection('personal', $section);
-				}
-			}
-		}
-
-		if (!empty($info['collaboration']['plugins'])) {
-			// deal with one or many plugin entries
-			$plugins = isset($info['collaboration']['plugins']['plugin']['@value'])
-				? [$info['collaboration']['plugins']['plugin']] : $info['collaboration']['plugins']['plugin'];
-			$collaboratorSearch = null;
-			$autoCompleteManager = null;
-			foreach ($plugins as $plugin) {
-				if ($plugin['@attributes']['type'] === 'collaborator-search') {
-					$pluginInfo = [
-						'shareType' => $plugin['@attributes']['share-type'],
-						'class' => $plugin['@value'],
-					];
-					$collaboratorSearch ??= \OC::$server->get(ICollaboratorSearch::class);
-					$collaboratorSearch->registerPlugin($pluginInfo);
-				} elseif ($plugin['@attributes']['type'] === 'autocomplete-sort') {
-					$autoCompleteManager ??= \OC::$server->get(IAutoCompleteManager::class);
-					$autoCompleteManager->registerSorter($plugin['@value']);
-				}
-			}
-		}
-		$eventLogger->end("bootstrap:load_app:$app:info");
-
-		$eventLogger->end("bootstrap:load_app:$app");
-	}
-
-	/**
-	 * Check if an app is loaded
-	 * @param string $app app id
-	 * @since 26.0.0
-	 */
-	public function isAppLoaded(string $app): bool {
-		return isset($this->loadedApps[$app]);
-	}
-
-	/**
-	 * Enable an app for every user
-	 *
-	 * @param string $appId
-	 * @param bool $forceEnable
-	 * @throws AppPathNotFoundException
-	 * @throws \InvalidArgumentException if the application is not installed yet
-	 */
-	public function enableApp(string $appId, bool $forceEnable = false): void {
-		// Check if app exists
-		$this->getAppPath($appId);
-
-		if ($this->config->getAppValue($appId, 'installed_version', '') === '') {
-			throw new \InvalidArgumentException("$appId is not installed, cannot be enabled.");
-		}
-
-		if ($forceEnable) {
-			$this->overwriteNextcloudRequirement($appId);
-		}
-
-		$this->enabledAppsCache[$appId] = 'yes';
-		$this->getAppConfig()->setValue($appId, 'enabled', 'yes');
-		$this->dispatcher->dispatchTyped(new AppEnableEvent($appId));
-		$this->dispatcher->dispatch(ManagerEvent::EVENT_APP_ENABLE, new ManagerEvent(
-			ManagerEvent::EVENT_APP_ENABLE, $appId
-		));
-		$this->clearAppsCache();
-
-		$this->configManager->migrateConfigLexiconKeys($appId);
-	}
-
-	/**
-	 * Whether a list of types contains a protected app type
-	 *
-	 * @param string[] $types
-	 * @return bool
-	 */
-	public function hasProtectedAppType($types) {
-		if (empty($types)) {
-			return false;
-		}
-
-		$protectedTypes = array_intersect($this->protectedAppTypes, $types);
-		return !empty($protectedTypes);
-	}
-
-	/**
-	 * Enable an app only for specific groups
-	 *
-	 * @param string $appId
-	 * @param IGroup[] $groups
-	 * @param bool $forceEnable
-	 * @throws \InvalidArgumentException if app can't be enabled for groups
-	 * @throws AppPathNotFoundException
-	 */
-	public function enableAppForGroups(string $appId, array $groups, bool $forceEnable = false): void {
-		// Check if app exists
-		$this->getAppPath($appId);
-
-		$info = $this->getAppInfo($appId);
-		if (!empty($info['types']) && $this->hasProtectedAppType($info['types'])) {
-			throw new \InvalidArgumentException("$appId can't be enabled for groups.");
-		}
-
-		if ($this->config->getAppValue($appId, 'installed_version', '') === '') {
-			throw new \InvalidArgumentException("$appId is not installed, cannot be enabled.");
-		}
-
-		if ($forceEnable) {
-			$this->overwriteNextcloudRequirement($appId);
-		}
-
-		/** @var string[] $groupIds */
-		$groupIds = array_map(function ($group) {
-			/** @var IGroup $group */
-			return ($group instanceof IGroup)
-				? $group->getGID()
-				: $group;
-		}, $groups);
-
-		$this->enabledAppsCache[$appId] = json_encode($groupIds);
-		$this->getAppConfig()->setValue($appId, 'enabled', json_encode($groupIds));
-		$this->dispatcher->dispatchTyped(new AppEnableEvent($appId, $groupIds));
-		$this->dispatcher->dispatch(ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS, new ManagerEvent(
-			ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS, $appId, $groups
-		));
-		$this->clearAppsCache();
-
-		$this->configManager->migrateConfigLexiconKeys($appId);
-	}
-
-	/**
-	 * Disable an app for every user
-	 *
-	 * @param string $appId
-	 * @param bool $automaticDisabled
-	 * @throws \Exception if app can't be disabled
-	 */
-	public function disableApp($appId, $automaticDisabled = false): void {
-		if ($this->isAlwaysEnabled($appId)) {
-			throw new \Exception("$appId can't be disabled.");
-		}
-
-		if ($automaticDisabled) {
-			$previousSetting = $this->getAppConfig()->getValue($appId, 'enabled', 'yes');
-			if ($previousSetting !== 'yes' && $previousSetting !== 'no') {
-				$previousSetting = json_decode($previousSetting, true);
-			}
-			$this->autoDisabledApps[$appId] = $previousSetting;
-		}
-
-		unset($this->enabledAppsCache[$appId]);
-		$this->getAppConfig()->setValue($appId, 'enabled', 'no');
-
-		// run uninstall steps
-		$appData = $this->getAppInfo($appId);
-		if (!is_null($appData)) {
-			\OC_App::executeRepairSteps($appId, $appData['repair-steps']['uninstall']);
-		}
-
-		$this->dispatcher->dispatchTyped(new AppDisableEvent($appId));
-		$this->dispatcher->dispatch(ManagerEvent::EVENT_APP_DISABLE, new ManagerEvent(
-			ManagerEvent::EVENT_APP_DISABLE, $appId
-		));
-		$this->clearAppsCache();
-	}
-
-	/**
-	 * Get the directory for the given app.
-	 *
-	 * @throws AppPathNotFoundException if app folder can't be found
-	 */
-	public function getAppPath(string $appId): string {
-		$appPath = \OC_App::getAppPath($appId);
-		if ($appPath === false) {
-			throw new AppPathNotFoundException('Could not find path for ' . $appId);
-		}
-		return $appPath;
-	}
-
-	/**
-	 * Get the web path for the given app.
-	 *
-	 * @param string $appId
-	 * @return string
-	 * @throws AppPathNotFoundException if app path can't be found
-	 */
-	public function getAppWebPath(string $appId): string {
-		$appWebPath = \OC_App::getAppWebPath($appId);
-		if ($appWebPath === false) {
-			throw new AppPathNotFoundException('Could not find web path for ' . $appId);
-		}
-		return $appWebPath;
-	}
-
-	/**
-	 * Clear the cached list of apps when enabling/disabling an app
-	 */
-	public function clearAppsCache(): void {
-		$this->appInfos = [];
-	}
-
-	/**
-	 * Returns a list of apps that need upgrade
-	 *
-	 * @param string $version Nextcloud version as array of version components
-	 * @return array list of app info from apps that need an upgrade
-	 *
-	 * @internal
-	 */
-	public function getAppsNeedingUpgrade($version) {
-		$appsToUpgrade = [];
-		$apps = $this->getEnabledApps();
-		foreach ($apps as $appId) {
-			$appInfo = $this->getAppInfo($appId);
-			$appDbVersion = $this->getAppConfig()->getValue($appId, 'installed_version');
-			if ($appDbVersion
-				&& isset($appInfo['version'])
-				&& version_compare($appInfo['version'], $appDbVersion, '>')
-				&& \OC_App::isAppCompatible($version, $appInfo)
-			) {
-				$appsToUpgrade[] = $appInfo;
-			}
-		}
-
-		return $appsToUpgrade;
-	}
-
-	/**
-	 * Returns the app information from "appinfo/info.xml".
-	 *
-	 * @param string|null $lang
-	 * @return array|null app info
-	 */
-	public function getAppInfo(string $appId, bool $path = false, $lang = null) {
-		if ($path) {
-			throw new \InvalidArgumentException('Calling IAppManager::getAppInfo() with a path is no longer supported. Please call IAppManager::getAppInfoByPath() instead and verify that the path is good before calling.');
-		}
-		if ($lang === null && isset($this->appInfos[$appId])) {
-			return $this->appInfos[$appId];
-		}
-		try {
-			$appPath = $this->getAppPath($appId);
-		} catch (AppPathNotFoundException) {
-			return null;
-		}
-		$file = $appPath . '/appinfo/info.xml';
-
-		$data = $this->getAppInfoByPath($file, $lang);
-
-		if ($lang === null) {
-			$this->appInfos[$appId] = $data;
-		}
-
-		return $data;
-	}
-
-	public function getAppInfoByPath(string $path, ?string $lang = null): ?array {
-		if (!str_ends_with($path, '/appinfo/info.xml')) {
-			return null;
-		}
-
-		$parser = new InfoParser($this->memCacheFactory->createLocal('core.appinfo'));
-		$data = $parser->parse($path);
-
-		if (is_array($data)) {
-			$data = $parser->applyL10N($data, $lang);
-		}
-
-		return $data;
-	}
-
-	public function getAppVersion(string $appId, bool $useCache = true): string {
-		if (!$useCache || !isset($this->appVersions[$appId])) {
-			if ($appId === 'core') {
-				$this->appVersions[$appId] = $this->serverVersion->getVersionString();
-			} else {
-				$appInfo = $this->getAppInfo($appId);
-				$this->appVersions[$appId] = ($appInfo !== null && isset($appInfo['version'])) ? $appInfo['version'] : '0';
-			}
-		}
-		return $this->appVersions[$appId];
-	}
-
-	/**
-	 * Returns the installed versions of all apps
-	 *
-	 * @return array<string, string>
-	 */
-	public function getAppInstalledVersions(bool $onlyEnabled = false): array {
-		return $this->getAppConfig()->getAppInstalledVersions($onlyEnabled);
-	}
-
-	/**
-	 * Returns a list of apps incompatible with the given version
-	 *
-	 * @param string $version Nextcloud version as array of version components
-	 *
-	 * @return array list of app info from incompatible apps
-	 *
-	 * @internal
-	 */
-	public function getIncompatibleApps(string $version): array {
-		$apps = $this->getEnabledApps();
-		$incompatibleApps = [];
-		foreach ($apps as $appId) {
-			$info = $this->getAppInfo($appId);
-			if ($info === null) {
-				$incompatibleApps[] = ['id' => $appId, 'name' => $appId];
-			} elseif (!\OC_App::isAppCompatible($version, $info)) {
-				$incompatibleApps[] = $info;
-			}
-		}
-		return $incompatibleApps;
-	}
-
-	/**
-	 * @inheritdoc
-	 * In case you change this method, also change \OC\App\CodeChecker\InfoChecker::isShipped()
-	 */
-	public function isShipped($appId) {
-		$this->loadShippedJson();
-		return in_array($appId, $this->shippedApps, true);
-	}
-
-	private function isAlwaysEnabled(string $appId): bool {
-		if ($appId === 'core') {
-			return true;
-		}
-
-		$alwaysEnabled = $this->getAlwaysEnabledApps();
-		return in_array($appId, $alwaysEnabled, true);
-	}
-
-	/**
-	 * In case you change this method, also change \OC\App\CodeChecker\InfoChecker::loadShippedJson()
-	 * @throws \Exception
-	 */
-	private function loadShippedJson(): void {
-		if ($this->shippedApps === null) {
-			$shippedJson = \OC::$SERVERROOT . '/core/shipped.json';
-			if (!file_exists($shippedJson)) {
-				throw new \Exception("File not found: $shippedJson");
-			}
-			$content = json_decode(file_get_contents($shippedJson), true);
-			$this->shippedApps = $content['shippedApps'];
-			$this->alwaysEnabled = $content['alwaysEnabled'];
-			$this->defaultEnabled = $content['defaultEnabled'];
-		}
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getAlwaysEnabledApps() {
-		$this->loadShippedJson();
-		return $this->alwaysEnabled;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function isDefaultEnabled(string $appId): bool {
-		return (in_array($appId, $this->getDefaultEnabledApps()));
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getDefaultEnabledApps(): array {
-		$this->loadShippedJson();
-
-		return $this->defaultEnabled;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getDefaultAppForUser(?IUser $user = null, bool $withFallbacks = true): string {
-		$id = $this->getNavigationManager()->getDefaultEntryIdForUser($user, $withFallbacks);
-		$entry = $this->getNavigationManager()->get($id);
-		return (string)$entry['app'];
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getDefaultApps(): array {
-		$ids = $this->getNavigationManager()->getDefaultEntryIds();
-
-		return array_values(array_unique(array_map(function (string $id) {
-			$entry = $this->getNavigationManager()->get($id);
-			return (string)$entry['app'];
-		}, $ids)));
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setDefaultApps(array $defaultApps): void {
-		$entries = $this->getNavigationManager()->getAll();
-		$ids = [];
-		foreach ($defaultApps as $defaultApp) {
-			foreach ($entries as $entry) {
-				if ((string)$entry['app'] === $defaultApp) {
-					$ids[] = (string)$entry['id'];
-					break;
-				}
-			}
-		}
-		$this->getNavigationManager()->setDefaultEntryIds($ids);
-	}
-
-	public function isBackendRequired(string $backend): bool {
-		foreach ($this->appInfos as $appInfo) {
-			foreach ($appInfo['dependencies']['backend'] as $appBackend) {
-				if ($backend === $appBackend) {
-					return true;
-				}
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Clean the appId from forbidden characters
-	 *
-	 * @psalm-taint-escape callable
-	 * @psalm-taint-escape cookie
-	 * @psalm-taint-escape file
-	 * @psalm-taint-escape has_quotes
-	 * @psalm-taint-escape header
-	 * @psalm-taint-escape html
-	 * @psalm-taint-escape include
-	 * @psalm-taint-escape ldap
-	 * @psalm-taint-escape shell
-	 * @psalm-taint-escape sql
-	 * @psalm-taint-escape unserialize
-	 */
-	public function cleanAppId(string $app): string {
-		/* Only lowercase alphanumeric is allowed */
-		return preg_replace('/(^[0-9_]|[^a-z0-9_]+|_$)/', '', $app);
-	}
+    /**
+     * Apps with these types can not be enabled for certain groups only
+     * @var string[]
+     */
+    protected $protectedAppTypes = [
+        'filesystem',
+        'prelogin',
+        'authentication',
+        'logging',
+        'prevent_group_restriction',
+    ];
+
+    /** @var string[] $appId => $enabled */
+    private array $enabledAppsCache = [];
+
+    /** @var string[]|null */
+    private ?array $shippedApps = null;
+
+    private array $alwaysEnabled = [];
+    private array $defaultEnabled = [];
+
+    /** @var array */
+    private array $appInfos = [];
+
+    /** @var array */
+    private array $appVersions = [];
+
+    /** @var array */
+    private array $autoDisabledApps = [];
+    private array $appTypes = [];
+
+    /** @var array<string, true> */
+    private array $loadedApps = [];
+
+    private ?AppConfig $appConfig = null;
+    private ?IURLGenerator $urlGenerator = null;
+    private ?INavigationManager $navigationManager = null;
+
+    /**
+     * Be extremely careful when injecting classes here. The AppManager is used by the installer,
+     * so it needs to work before installation. See how AppConfig and IURLGenerator are injected for reference
+     */
+    public function __construct(
+        private IUserSession $userSession,
+        private IConfig $config,
+        private IGroupManager $groupManager,
+        private ICacheFactory $memCacheFactory,
+        private IEventDispatcher $dispatcher,
+        private LoggerInterface $logger,
+        private ServerVersion $serverVersion,
+        private ConfigManager $configManager,
+    ) {
+    }
+
+    private function getNavigationManager(): INavigationManager {
+        if ($this->navigationManager === null) {
+            $this->navigationManager = Server::get(INavigationManager::class);
+        }
+        return $this->navigationManager;
+    }
+
+    public function getAppIcon(string $appId, bool $dark = false): ?string {
+        $possibleIcons = $dark ? [$appId . '-dark.svg', 'app-dark.svg'] : [$appId . '.svg', 'app.svg'];
+        $icon = null;
+        foreach ($possibleIcons as $iconName) {
+            try {
+                $icon = $this->getUrlGenerator()->imagePath($appId, $iconName);
+                break;
+            } catch (\RuntimeException $e) {
+                // ignore
+            }
+        }
+        return $icon;
+    }
+
+    private function getAppConfig(): AppConfig {
+        if ($this->appConfig !== null) {
+            return $this->appConfig;
+        }
+        if (!$this->config->getSystemValueBool('installed', false)) {
+            throw new \Exception('Nextcloud is not installed yet, AppConfig is not available');
+        }
+        $this->appConfig = Server::get(AppConfig::class);
+        return $this->appConfig;
+    }
+
+    private function getUrlGenerator(): IURLGenerator {
+        if ($this->urlGenerator !== null) {
+            return $this->urlGenerator;
+        }
+        if (!$this->config->getSystemValueBool('installed', false)) {
+            throw new \Exception('Nextcloud is not installed yet, AppConfig is not available');
+        }
+        $this->urlGenerator = Server::get(IURLGenerator::class);
+        return $this->urlGenerator;
+    }
+
+    /**
+     * For all enabled apps, return the value of their 'enabled' config key.
+     *
+     * @return array<string,string> appId => enabled (may be 'yes', or a json encoded list of group ids)
+     */
+    private function getEnabledAppsValues(): array {
+        if (!$this->enabledAppsCache) {
+            /** @var array<string,string> */
+            $values = $this->getAppConfig()->searchValues('enabled', false, IAppConfig::VALUE_STRING);
+
+            $alwaysEnabledApps = $this->getAlwaysEnabledApps();
+            foreach ($alwaysEnabledApps as $appId) {
+                $values[$appId] = 'yes';
+            }
+
+            $this->enabledAppsCache = array_filter($values, function ($value) {
+                return $value !== 'no';
+            });
+            ksort($this->enabledAppsCache);
+        }
+        return $this->enabledAppsCache;
+    }
+
+    /**
+     * Deprecated alias
+     *
+     * @return string[]
+     */
+    public function getInstalledApps() {
+        return $this->getEnabledApps();
+    }
+
+    /**
+     * List all enabled apps, either for everyone or for some groups
+     *
+     * @return list<string>
+     */
+    public function getEnabledApps(): array {
+        return array_keys($this->getEnabledAppsValues());
+    }
+
+    /**
+     * Get a list of all apps in the apps folder
+     *
+     * @return list<string> an array of app names (string IDs)
+     */
+    public function getAllAppsInAppsFolders(): array {
+        $apps = [];
+
+        foreach (\OC::$APPSROOTS as $apps_dir) {
+            if (!is_readable($apps_dir['path'])) {
+                $this->logger->warning('unable to read app folder : ' . $apps_dir['path'], ['app' => 'core']);
+                continue;
+            }
+            $dh = opendir($apps_dir['path']);
+
+            if (is_resource($dh)) {
+                while (($file = readdir($dh)) !== false) {
+                    if (
+                        $file[0] != '.'
+                        && is_dir($apps_dir['path'] . '/' . $file)
+                        && is_file($apps_dir['path'] . '/' . $file . '/appinfo/info.xml')
+                    ) {
+                        $apps[] = $file;
+                    }
+                }
+            }
+        }
+
+        return array_values(array_unique($apps));
+    }
+
+    /**
+     * List all apps enabled for a user
+     *
+     * @param \OCP\IUser $user
+     * @return list<string>
+     */
+    public function getEnabledAppsForUser(IUser $user) {
+        $apps = $this->getEnabledAppsValues();
+        $appsForUser = array_filter($apps, function ($enabled) use ($user) {
+            return $this->checkAppForUser($enabled, $user);
+        });
+        return array_keys($appsForUser);
+    }
+
+    public function getEnabledAppsForGroup(IGroup $group): array {
+        $apps = $this->getEnabledAppsValues();
+        $appsForGroups = array_filter($apps, function ($enabled) use ($group) {
+            return $this->checkAppForGroups($enabled, $group);
+        });
+        return array_keys($appsForGroups);
+    }
+
+    /**
+     * Loads all apps
+     *
+     * @param string[] $types
+     * @return bool
+     *
+     * This function walks through the Nextcloud directory and loads all apps
+     * it can find. A directory contains an app if the file /appinfo/info.xml
+     * exists.
+     *
+     * if $types is set to non-empty array, only apps of those types will be loaded
+     */
+    public function loadApps(array $types = []): bool {
+        if ($this->config->getSystemValueBool('maintenance', false)) {
+            return false;
+        }
+        // Load the enabled apps here
+        $apps = \OC_App::getEnabledApps();
+
+        // Add each apps' folder as allowed class path
+        foreach ($apps as $app) {
+            // If the app is already loaded then autoloading it makes no sense
+            if (!$this->isAppLoaded($app)) {
+                $path = \OC_App::getAppPath($app);
+                if ($path !== false) {
+                    \OC_App::registerAutoloading($app, $path);
+                }
+            }
+        }
+
+        // prevent app loading from printing output
+        ob_start();
+        foreach ($apps as $app) {
+            if (!$this->isAppLoaded($app) && ($types === [] || $this->isType($app, $types))) {
+                try {
+                    $this->loadApp($app);
+                } catch (\Throwable $e) {
+                    $this->logger->emergency('Error during app loading: ' . $e->getMessage(), [
+                        'exception' => $e,
+                        'app' => $app,
+                    ]);
+                }
+            }
+        }
+        ob_end_clean();
+
+        return true;
+    }
+
+    /**
+     * check if an app is of a specific type
+     *
+     * @param string $app
+     * @param array $types
+     * @return bool
+     */
+    public function isType(string $app, array $types): bool {
+        $appTypes = $this->getAppTypes($app);
+        foreach ($types as $type) {
+            if (in_array($type, $appTypes, true)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    /**
+     * get the types of an app
+     *
+     * @param string $app
+     * @return string[]
+     */
+    private function getAppTypes(string $app): array {
+        //load the cache
+        if (count($this->appTypes) === 0) {
+            $this->appTypes = $this->getAppConfig()->getValues(false, 'types') ?: [];
+        }
+
+        if (isset($this->appTypes[$app])) {
+            return explode(',', $this->appTypes[$app]);
+        }
+
+        return [];
+    }
+
+    /**
+     * @return array
+     */
+    public function getAutoDisabledApps(): array {
+        return $this->autoDisabledApps;
+    }
+
+    public function getAppRestriction(string $appId): array {
+        $values = $this->getEnabledAppsValues();
+
+        if (!isset($values[$appId])) {
+            return [];
+        }
+
+        if ($values[$appId] === 'yes' || $values[$appId] === 'no') {
+            return [];
+        }
+        return json_decode($values[$appId], true);
+    }
+
+    /**
+     * Check if an app is enabled for user
+     *
+     * @param string $appId
+     * @param \OCP\IUser|null $user (optional) if not defined, the currently logged in user will be used
+     * @return bool
+     */
+    public function isEnabledForUser($appId, $user = null) {
+        if ($this->isAlwaysEnabled($appId)) {
+            return true;
+        }
+        if ($user === null) {
+            $user = $this->userSession->getUser();
+        }
+        $enabledAppsValues = $this->getEnabledAppsValues();
+        if (isset($enabledAppsValues[$appId])) {
+            return $this->checkAppForUser($enabledAppsValues[$appId], $user);
+        } else {
+            return false;
+        }
+    }
+
+    private function checkAppForUser(string $enabled, ?IUser $user): bool {
+        if ($enabled === 'yes') {
+            return true;
+        } elseif ($user === null) {
+            return false;
+        } else {
+            if (empty($enabled)) {
+                return false;
+            }
+
+            $groupIds = json_decode($enabled);
+
+            if (!is_array($groupIds)) {
+                $jsonError = json_last_error();
+                $jsonErrorMsg = json_last_error_msg();
+                // this really should never happen (if it does, the admin should check the `enabled` key value via `occ config:list` because it's bogus for some reason)
+                $this->logger->warning('AppManager::checkAppForUser - can\'t decode group IDs listed in app\'s enabled config key: ' . print_r($enabled, true) . ' - JSON error (' . $jsonError . ') ' . $jsonErrorMsg);
+                return false;
+            }
+
+            $userGroups = $this->groupManager->getUserGroupIds($user);
+            foreach ($userGroups as $groupId) {
+                if (in_array($groupId, $groupIds, true)) {
+                    return true;
+                }
+            }
+            return false;
+        }
+    }
+
+    private function checkAppForGroups(string $enabled, IGroup $group): bool {
+        if ($enabled === 'yes') {
+            return true;
+        } else {
+            if (empty($enabled)) {
+                return false;
+            }
+
+            $groupIds = json_decode($enabled);
+
+            if (!is_array($groupIds)) {
+                $jsonError = json_last_error();
+                $jsonErrorMsg = json_last_error_msg();
+                // this really should never happen (if it does, the admin should check the `enabled` key value via `occ config:list` because it's bogus for some reason)
+                $this->logger->warning('AppManager::checkAppForGroups - can\'t decode group IDs listed in app\'s enabled config key: ' . print_r($enabled, true) . ' - JSON error (' . $jsonError . ') ' . $jsonErrorMsg);
+                return false;
+            }
+
+            return in_array($group->getGID(), $groupIds);
+        }
+    }
+
+    /**
+     * Check if an app is enabled in the instance
+     *
+     * Notice: This actually checks if the app is enabled and not only if it is installed.
+     *
+     * @param string $appId
+     */
+    public function isInstalled($appId): bool {
+        return $this->isEnabledForAnyone($appId);
+    }
+
+    public function isEnabledForAnyone(string $appId): bool {
+        $enabledAppsValues = $this->getEnabledAppsValues();
+        return isset($enabledAppsValues[$appId]);
+    }
+
+    /**
+     * Overwrite the `max-version` requirement for this app.
+     */
+    public function overwriteNextcloudRequirement(string $appId): void {
+        $ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
+        if (!in_array($appId, $ignoreMaxApps, true)) {
+            $ignoreMaxApps[] = $appId;
+        }
+        $this->config->setSystemValue('app_install_overwrite', $ignoreMaxApps);
+    }
+
+    /**
+     * Remove the `max-version` overwrite for this app.
+     * This means this app now again can not be enabled if the `max-version` is smaller than the current Nextcloud version.
+     */
+    public function removeOverwriteNextcloudRequirement(string $appId): void {
+        $ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
+        $ignoreMaxApps = array_filter($ignoreMaxApps, fn (string $id) => $id !== $appId);
+        $this->config->setSystemValue('app_install_overwrite', $ignoreMaxApps);
+    }
+
+    public function loadApp(string $app): void {
+        if (isset($this->loadedApps[$app])) {
+            return;
+        }
+        $this->loadedApps[$app] = true;
+        $appPath = \OC_App::getAppPath($app);
+        if ($appPath === false) {
+            return;
+        }
+        $eventLogger = \OC::$server->get(IEventLogger::class);
+        $eventLogger->start("bootstrap:load_app:$app", "Load app: $app");
+
+        // in case someone calls loadApp() directly
+        \OC_App::registerAutoloading($app, $appPath);
+
+        if (is_file($appPath . '/appinfo/app.php')) {
+            $this->logger->error('/appinfo/app.php is not supported anymore, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.', [
+                'app' => $app,
+            ]);
+        }
+
+        $coordinator = Server::get(Coordinator::class);
+        $coordinator->bootApp($app);
+
+        $eventLogger->start("bootstrap:load_app:$app:info", "Load info.xml for $app and register any services defined in it");
+        $info = $this->getAppInfo($app);
+        if (!empty($info['activity'])) {
+            $activityManager = \OC::$server->get(IActivityManager::class);
+            if (!empty($info['activity']['filters'])) {
+                foreach ($info['activity']['filters'] as $filter) {
+                    $activityManager->registerFilter($filter);
+                }
+            }
+            if (!empty($info['activity']['settings'])) {
+                foreach ($info['activity']['settings'] as $setting) {
+                    $activityManager->registerSetting($setting);
+                }
+            }
+            if (!empty($info['activity']['providers'])) {
+                foreach ($info['activity']['providers'] as $provider) {
+                    $activityManager->registerProvider($provider);
+                }
+            }
+        }
+
+        if (!empty($info['settings'])) {
+            $settingsManager = \OC::$server->get(ISettingsManager::class);
+            if (!empty($info['settings']['admin'])) {
+                foreach ($info['settings']['admin'] as $setting) {
+                    $settingsManager->registerSetting('admin', $setting);
+                }
+            }
+            if (!empty($info['settings']['admin-section'])) {
+                foreach ($info['settings']['admin-section'] as $section) {
+                    $settingsManager->registerSection('admin', $section);
+                }
+            }
+            if (!empty($info['settings']['personal'])) {
+                foreach ($info['settings']['personal'] as $setting) {
+                    $settingsManager->registerSetting('personal', $setting);
+                }
+            }
+            if (!empty($info['settings']['personal-section'])) {
+                foreach ($info['settings']['personal-section'] as $section) {
+                    $settingsManager->registerSection('personal', $section);
+                }
+            }
+        }
+
+        if (!empty($info['collaboration']['plugins'])) {
+            // deal with one or many plugin entries
+            $plugins = isset($info['collaboration']['plugins']['plugin']['@value'])
+                ? [$info['collaboration']['plugins']['plugin']] : $info['collaboration']['plugins']['plugin'];
+            $collaboratorSearch = null;
+            $autoCompleteManager = null;
+            foreach ($plugins as $plugin) {
+                if ($plugin['@attributes']['type'] === 'collaborator-search') {
+                    $pluginInfo = [
+                        'shareType' => $plugin['@attributes']['share-type'],
+                        'class' => $plugin['@value'],
+                    ];
+                    $collaboratorSearch ??= \OC::$server->get(ICollaboratorSearch::class);
+                    $collaboratorSearch->registerPlugin($pluginInfo);
+                } elseif ($plugin['@attributes']['type'] === 'autocomplete-sort') {
+                    $autoCompleteManager ??= \OC::$server->get(IAutoCompleteManager::class);
+                    $autoCompleteManager->registerSorter($plugin['@value']);
+                }
+            }
+        }
+        $eventLogger->end("bootstrap:load_app:$app:info");
+
+        $eventLogger->end("bootstrap:load_app:$app");
+    }
+
+    /**
+     * Check if an app is loaded
+     * @param string $app app id
+     * @since 26.0.0
+     */
+    public function isAppLoaded(string $app): bool {
+        return isset($this->loadedApps[$app]);
+    }
+
+    /**
+     * Enable an app for every user
+     *
+     * @param string $appId
+     * @param bool $forceEnable
+     * @throws AppPathNotFoundException
+     * @throws \InvalidArgumentException if the application is not installed yet
+     */
+    public function enableApp(string $appId, bool $forceEnable = false): void {
+        // Check if app exists
+        $this->getAppPath($appId);
+
+        if ($this->config->getAppValue($appId, 'installed_version', '') === '') {
+            throw new \InvalidArgumentException("$appId is not installed, cannot be enabled.");
+        }
+
+        if ($forceEnable) {
+            $this->overwriteNextcloudRequirement($appId);
+        }
+
+        $this->enabledAppsCache[$appId] = 'yes';
+        $this->getAppConfig()->setValue($appId, 'enabled', 'yes');
+        $this->dispatcher->dispatchTyped(new AppEnableEvent($appId));
+        $this->dispatcher->dispatch(ManagerEvent::EVENT_APP_ENABLE, new ManagerEvent(
+            ManagerEvent::EVENT_APP_ENABLE, $appId
+        ));
+        $this->clearAppsCache();
+
+        $this->configManager->migrateConfigLexiconKeys($appId);
+    }
+
+    /**
+     * Whether a list of types contains a protected app type
+     *
+     * @param string[] $types
+     * @return bool
+     */
+    public function hasProtectedAppType($types) {
+        if (empty($types)) {
+            return false;
+        }
+
+        $protectedTypes = array_intersect($this->protectedAppTypes, $types);
+        return !empty($protectedTypes);
+    }
+
+    /**
+     * Enable an app only for specific groups
+     *
+     * @param string $appId
+     * @param IGroup[] $groups
+     * @param bool $forceEnable
+     * @throws \InvalidArgumentException if app can't be enabled for groups
+     * @throws AppPathNotFoundException
+     */
+    public function enableAppForGroups(string $appId, array $groups, bool $forceEnable = false): void {
+        // Check if app exists
+        $this->getAppPath($appId);
+
+        $info = $this->getAppInfo($appId);
+        if (!empty($info['types']) && $this->hasProtectedAppType($info['types'])) {
+            throw new \InvalidArgumentException("$appId can't be enabled for groups.");
+        }
+
+        if ($this->config->getAppValue($appId, 'installed_version', '') === '') {
+            throw new \InvalidArgumentException("$appId is not installed, cannot be enabled.");
+        }
+
+        if ($forceEnable) {
+            $this->overwriteNextcloudRequirement($appId);
+        }
+
+        /** @var string[] $groupIds */
+        $groupIds = array_map(function ($group) {
+            /** @var IGroup $group */
+            return ($group instanceof IGroup)
+                ? $group->getGID()
+                : $group;
+        }, $groups);
+
+        $this->enabledAppsCache[$appId] = json_encode($groupIds);
+        $this->getAppConfig()->setValue($appId, 'enabled', json_encode($groupIds));
+        $this->dispatcher->dispatchTyped(new AppEnableEvent($appId, $groupIds));
+        $this->dispatcher->dispatch(ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS, new ManagerEvent(
+            ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS, $appId, $groups
+        ));
+        $this->clearAppsCache();
+
+        $this->configManager->migrateConfigLexiconKeys($appId);
+    }
+
+    /**
+     * Disable an app for every user
+     *
+     * @param string $appId
+     * @param bool $automaticDisabled
+     * @throws \Exception if app can't be disabled
+     */
+    public function disableApp($appId, $automaticDisabled = false): void {
+        if ($this->isAlwaysEnabled($appId)) {
+            throw new \Exception("$appId can't be disabled.");
+        }
+
+        if ($automaticDisabled) {
+            $previousSetting = $this->getAppConfig()->getValue($appId, 'enabled', 'yes');
+            if ($previousSetting !== 'yes' && $previousSetting !== 'no') {
+                $previousSetting = json_decode($previousSetting, true);
+            }
+            $this->autoDisabledApps[$appId] = $previousSetting;
+        }
+
+        unset($this->enabledAppsCache[$appId]);
+        $this->getAppConfig()->setValue($appId, 'enabled', 'no');
+
+        // run uninstall steps
+        $appData = $this->getAppInfo($appId);
+        if (!is_null($appData)) {
+            \OC_App::executeRepairSteps($appId, $appData['repair-steps']['uninstall']);
+        }
+
+        $this->dispatcher->dispatchTyped(new AppDisableEvent($appId));
+        $this->dispatcher->dispatch(ManagerEvent::EVENT_APP_DISABLE, new ManagerEvent(
+            ManagerEvent::EVENT_APP_DISABLE, $appId
+        ));
+        $this->clearAppsCache();
+    }
+
+    /**
+     * Get the directory for the given app.
+     *
+     * @throws AppPathNotFoundException if app folder can't be found
+     */
+    public function getAppPath(string $appId): string {
+        $appPath = \OC_App::getAppPath($appId);
+        if ($appPath === false) {
+            throw new AppPathNotFoundException('Could not find path for ' . $appId);
+        }
+        return $appPath;
+    }
+
+    /**
+     * Get the web path for the given app.
+     *
+     * @param string $appId
+     * @return string
+     * @throws AppPathNotFoundException if app path can't be found
+     */
+    public function getAppWebPath(string $appId): string {
+        $appWebPath = \OC_App::getAppWebPath($appId);
+        if ($appWebPath === false) {
+            throw new AppPathNotFoundException('Could not find web path for ' . $appId);
+        }
+        return $appWebPath;
+    }
+
+    /**
+     * Clear the cached list of apps when enabling/disabling an app
+     */
+    public function clearAppsCache(): void {
+        $this->appInfos = [];
+    }
+
+    /**
+     * Returns a list of apps that need upgrade
+     *
+     * @param string $version Nextcloud version as array of version components
+     * @return array list of app info from apps that need an upgrade
+     *
+     * @internal
+     */
+    public function getAppsNeedingUpgrade($version) {
+        $appsToUpgrade = [];
+        $apps = $this->getEnabledApps();
+        foreach ($apps as $appId) {
+            $appInfo = $this->getAppInfo($appId);
+            $appDbVersion = $this->getAppConfig()->getValue($appId, 'installed_version');
+            if ($appDbVersion
+                && isset($appInfo['version'])
+                && version_compare($appInfo['version'], $appDbVersion, '>')
+                && \OC_App::isAppCompatible($version, $appInfo)
+            ) {
+                $appsToUpgrade[] = $appInfo;
+            }
+        }
+
+        return $appsToUpgrade;
+    }
+
+    /**
+     * Returns the app information from "appinfo/info.xml".
+     *
+     * @param string|null $lang
+     * @return array|null app info
+     */
+    public function getAppInfo(string $appId, bool $path = false, $lang = null) {
+        if ($path) {
+            throw new \InvalidArgumentException('Calling IAppManager::getAppInfo() with a path is no longer supported. Please call IAppManager::getAppInfoByPath() instead and verify that the path is good before calling.');
+        }
+        if ($lang === null && isset($this->appInfos[$appId])) {
+            return $this->appInfos[$appId];
+        }
+        try {
+            $appPath = $this->getAppPath($appId);
+        } catch (AppPathNotFoundException) {
+            return null;
+        }
+        $file = $appPath . '/appinfo/info.xml';
+
+        $data = $this->getAppInfoByPath($file, $lang);
+
+        if ($lang === null) {
+            $this->appInfos[$appId] = $data;
+        }
+
+        return $data;
+    }
+
+    public function getAppInfoByPath(string $path, ?string $lang = null): ?array {
+        if (!str_ends_with($path, '/appinfo/info.xml')) {
+            return null;
+        }
+
+        $parser = new InfoParser($this->memCacheFactory->createLocal('core.appinfo'));
+        $data = $parser->parse($path);
+
+        if (is_array($data)) {
+            $data = $parser->applyL10N($data, $lang);
+        }
+
+        return $data;
+    }
+
+    public function getAppVersion(string $appId, bool $useCache = true): string {
+        if (!$useCache || !isset($this->appVersions[$appId])) {
+            if ($appId === 'core') {
+                $this->appVersions[$appId] = $this->serverVersion->getVersionString();
+            } else {
+                $appInfo = $this->getAppInfo($appId);
+                $this->appVersions[$appId] = ($appInfo !== null && isset($appInfo['version'])) ? $appInfo['version'] : '0';
+            }
+        }
+        return $this->appVersions[$appId];
+    }
+
+    /**
+     * Returns the installed versions of all apps
+     *
+     * @return array<string, string>
+     */
+    public function getAppInstalledVersions(bool $onlyEnabled = false): array {
+        return $this->getAppConfig()->getAppInstalledVersions($onlyEnabled);
+    }
+
+    /**
+     * Returns a list of apps incompatible with the given version
+     *
+     * @param string $version Nextcloud version as array of version components
+     *
+     * @return array list of app info from incompatible apps
+     *
+     * @internal
+     */
+    public function getIncompatibleApps(string $version): array {
+        $apps = $this->getEnabledApps();
+        $incompatibleApps = [];
+        foreach ($apps as $appId) {
+            $info = $this->getAppInfo($appId);
+            if ($info === null) {
+                $incompatibleApps[] = ['id' => $appId, 'name' => $appId];
+            } elseif (!\OC_App::isAppCompatible($version, $info)) {
+                $incompatibleApps[] = $info;
+            }
+        }
+        return $incompatibleApps;
+    }
+
+    /**
+     * @inheritdoc
+     * In case you change this method, also change \OC\App\CodeChecker\InfoChecker::isShipped()
+     */
+    public function isShipped($appId) {
+        $this->loadShippedJson();
+        return in_array($appId, $this->shippedApps, true);
+    }
+
+    private function isAlwaysEnabled(string $appId): bool {
+        if ($appId === 'core') {
+            return true;
+        }
+
+        $alwaysEnabled = $this->getAlwaysEnabledApps();
+        return in_array($appId, $alwaysEnabled, true);
+    }
+
+    /**
+     * In case you change this method, also change \OC\App\CodeChecker\InfoChecker::loadShippedJson()
+     * @throws \Exception
+     */
+    private function loadShippedJson(): void {
+        if ($this->shippedApps === null) {
+            $shippedJson = \OC::$SERVERROOT . '/core/shipped.json';
+            if (!file_exists($shippedJson)) {
+                throw new \Exception("File not found: $shippedJson");
+            }
+            $content = json_decode(file_get_contents($shippedJson), true);
+            $this->shippedApps = $content['shippedApps'];
+            $this->alwaysEnabled = $content['alwaysEnabled'];
+            $this->defaultEnabled = $content['defaultEnabled'];
+        }
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getAlwaysEnabledApps() {
+        $this->loadShippedJson();
+        return $this->alwaysEnabled;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function isDefaultEnabled(string $appId): bool {
+        return (in_array($appId, $this->getDefaultEnabledApps()));
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getDefaultEnabledApps(): array {
+        $this->loadShippedJson();
+
+        return $this->defaultEnabled;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getDefaultAppForUser(?IUser $user = null, bool $withFallbacks = true): string {
+        $id = $this->getNavigationManager()->getDefaultEntryIdForUser($user, $withFallbacks);
+        $entry = $this->getNavigationManager()->get($id);
+        return (string)$entry['app'];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getDefaultApps(): array {
+        $ids = $this->getNavigationManager()->getDefaultEntryIds();
+
+        return array_values(array_unique(array_map(function (string $id) {
+            $entry = $this->getNavigationManager()->get($id);
+            return (string)$entry['app'];
+        }, $ids)));
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setDefaultApps(array $defaultApps): void {
+        $entries = $this->getNavigationManager()->getAll();
+        $ids = [];
+        foreach ($defaultApps as $defaultApp) {
+            foreach ($entries as $entry) {
+                if ((string)$entry['app'] === $defaultApp) {
+                    $ids[] = (string)$entry['id'];
+                    break;
+                }
+            }
+        }
+        $this->getNavigationManager()->setDefaultEntryIds($ids);
+    }
+
+    public function isBackendRequired(string $backend): bool {
+        foreach ($this->appInfos as $appInfo) {
+            foreach ($appInfo['dependencies']['backend'] as $appBackend) {
+                if ($backend === $appBackend) {
+                    return true;
+                }
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Clean the appId from forbidden characters
+     *
+     * @psalm-taint-escape callable
+     * @psalm-taint-escape cookie
+     * @psalm-taint-escape file
+     * @psalm-taint-escape has_quotes
+     * @psalm-taint-escape header
+     * @psalm-taint-escape html
+     * @psalm-taint-escape include
+     * @psalm-taint-escape ldap
+     * @psalm-taint-escape shell
+     * @psalm-taint-escape sql
+     * @psalm-taint-escape unserialize
+     */
+    public function cleanAppId(string $app): string {
+        /* Only lowercase alphanumeric is allowed */
+        return preg_replace('/(^[0-9_]|[^a-z0-9_]+|_$)/', '', $app);
+    }
 }

lib/private/App/DependencyAnalyzer.php

Indentation +301 added lines, -301 removed lines

@@ -13,305 +13,305 @@
 use OCP\IL10N;
 
 class DependencyAnalyzer {
-	public function __construct(
-		private Platform $platform,
-		private IL10N $l,
-	) {
-	}
-
-	/**
-	 * @return array of missing dependencies
-	 */
-	public function analyze(array $app, bool $ignoreMax = false): array {
-		if (isset($app['dependencies'])) {
-			$dependencies = $app['dependencies'];
-		} else {
-			$dependencies = [];
-		}
-
-		return array_merge(
-			$this->analyzeArchitecture($dependencies),
-			$this->analyzePhpVersion($dependencies),
-			$this->analyzeDatabases($dependencies),
-			$this->analyzeCommands($dependencies),
-			$this->analyzeLibraries($dependencies),
-			$this->analyzeOS($dependencies),
-			$this->analyzeOC($dependencies, $app, $ignoreMax)
-		);
-	}
-
-	public function isMarkedCompatible(array $app): bool {
-		if (isset($app['dependencies'])) {
-			$dependencies = $app['dependencies'];
-		} else {
-			$dependencies = [];
-		}
-
-		$maxVersion = $this->getMaxVersion($dependencies, $app);
-		if ($maxVersion === null) {
-			return true;
-		}
-		return !$this->compareBigger($this->platform->getOcVersion(), $maxVersion);
-	}
-
-	/**
-	 * Truncates both versions to the lowest common version, e.g.
-	 * 5.1.2.3 and 5.1 will be turned into 5.1 and 5.1,
-	 * 5.2.6.5 and 5.1 will be turned into 5.2 and 5.1
-	 * @return string[] first element is the first version, second element is the
-	 *                  second version
-	 */
-	private function normalizeVersions(string $first, string $second): array {
-		$first = explode('.', $first);
-		$second = explode('.', $second);
-
-		// get both arrays to the same minimum size
-		$length = min(count($second), count($first));
-		$first = array_slice($first, 0, $length);
-		$second = array_slice($second, 0, $length);
-
-		return [implode('.', $first), implode('.', $second)];
-	}
-
-	/**
-	 * Parameters will be normalized and then passed into version_compare
-	 * in the same order they are specified in the method header
-	 * @return bool result similar to version_compare
-	 */
-	private function compare(string $first, string $second, string $operator): bool {
-		[$first, $second] = $this->normalizeVersions($first, $second);
-
-		return version_compare($first, $second, $operator);
-	}
-
-	/**
-	 * Checks if a version is bigger than another version
-	 * @return bool true if the first version is bigger than the second
-	 */
-	private function compareBigger(string $first, string $second): bool {
-		return $this->compare($first, $second, '>');
-	}
-
-	/**
-	 * Checks if a version is smaller than another version
-	 * @return bool true if the first version is smaller than the second
-	 */
-	private function compareSmaller(string $first, string $second): bool {
-		return $this->compare($first, $second, '<');
-	}
-
-	private function analyzePhpVersion(array $dependencies): array {
-		$missing = [];
-		if (isset($dependencies['php']['@attributes']['min-version'])) {
-			$minVersion = $dependencies['php']['@attributes']['min-version'];
-			if ($this->compareSmaller($this->platform->getPhpVersion(), $minVersion)) {
-				$missing[] = $this->l->t('PHP %s or higher is required.', [$minVersion]);
-			}
-		}
-		if (isset($dependencies['php']['@attributes']['max-version'])) {
-			$maxVersion = $dependencies['php']['@attributes']['max-version'];
-			if ($this->compareBigger($this->platform->getPhpVersion(), $maxVersion)) {
-				$missing[] = $this->l->t('PHP with a version lower than %s is required.', [$maxVersion]);
-			}
-		}
-		if (isset($dependencies['php']['@attributes']['min-int-size'])) {
-			$intSize = $dependencies['php']['@attributes']['min-int-size'];
-			if ($intSize > $this->platform->getIntSize() * 8) {
-				$missing[] = $this->l->t('%sbit or higher PHP required.', [$intSize]);
-			}
-		}
-		return $missing;
-	}
-
-	private function analyzeArchitecture(array $dependencies): array {
-		$missing = [];
-		if (!isset($dependencies['architecture'])) {
-			return $missing;
-		}
-
-		$supportedArchitectures = $dependencies['architecture'];
-		if (empty($supportedArchitectures)) {
-			return $missing;
-		}
-		if (!is_array($supportedArchitectures)) {
-			$supportedArchitectures = [$supportedArchitectures];
-		}
-		$supportedArchitectures = array_map(function ($architecture) {
-			return $this->getValue($architecture);
-		}, $supportedArchitectures);
-		$currentArchitecture = $this->platform->getArchitecture();
-		if (!in_array($currentArchitecture, $supportedArchitectures, true)) {
-			$missing[] = $this->l->t('The following architectures are supported: %s', [implode(', ', $supportedArchitectures)]);
-		}
-		return $missing;
-	}
-
-	private function analyzeDatabases(array $dependencies): array {
-		$missing = [];
-		if (!isset($dependencies['database'])) {
-			return $missing;
-		}
-
-		$supportedDatabases = $dependencies['database'];
-		if (empty($supportedDatabases)) {
-			return $missing;
-		}
-		if (!is_array($supportedDatabases)) {
-			$supportedDatabases = [$supportedDatabases];
-		}
-		if (isset($supportedDatabases['@value'])) {
-			$supportedDatabases = [$supportedDatabases];
-		}
-		$supportedDatabases = array_map(function ($db) {
-			return $this->getValue($db);
-		}, $supportedDatabases);
-		$currentDatabase = $this->platform->getDatabase();
-		if (!in_array($currentDatabase, $supportedDatabases)) {
-			$missing[] = $this->l->t('The following databases are supported: %s', [implode(', ', $supportedDatabases)]);
-		}
-		return $missing;
-	}
-
-	private function analyzeCommands(array $dependencies): array {
-		$missing = [];
-		if (!isset($dependencies['command'])) {
-			return $missing;
-		}
-
-		$commands = $dependencies['command'];
-		if (!is_array($commands)) {
-			$commands = [$commands];
-		}
-		if (isset($commands['@value'])) {
-			$commands = [$commands];
-		}
-		$os = $this->platform->getOS();
-		foreach ($commands as $command) {
-			if (isset($command['@attributes']['os']) && $command['@attributes']['os'] !== $os) {
-				continue;
-			}
-			$commandName = $this->getValue($command);
-			if (!$this->platform->isCommandKnown($commandName)) {
-				$missing[] = $this->l->t('The command line tool %s could not be found', [$commandName]);
-			}
-		}
-		return $missing;
-	}
-
-	private function analyzeLibraries(array $dependencies): array {
-		$missing = [];
-		if (!isset($dependencies['lib'])) {
-			return $missing;
-		}
-
-		$libs = $dependencies['lib'];
-		if (!is_array($libs)) {
-			$libs = [$libs];
-		}
-		if (isset($libs['@value'])) {
-			$libs = [$libs];
-		}
-		foreach ($libs as $lib) {
-			$libName = $this->getValue($lib);
-			$libVersion = $this->platform->getLibraryVersion($libName);
-			if (is_null($libVersion)) {
-				$missing[] = $this->l->t('The library %s is not available.', [$libName]);
-				continue;
-			}
-
-			if (is_array($lib)) {
-				if (isset($lib['@attributes']['min-version'])) {
-					$minVersion = $lib['@attributes']['min-version'];
-					if ($this->compareSmaller($libVersion, $minVersion)) {
-						$missing[] = $this->l->t('Library %1$s with a version higher than %2$s is required - available version %3$s.',
-							[$libName, $minVersion, $libVersion]);
-					}
-				}
-				if (isset($lib['@attributes']['max-version'])) {
-					$maxVersion = $lib['@attributes']['max-version'];
-					if ($this->compareBigger($libVersion, $maxVersion)) {
-						$missing[] = $this->l->t('Library %1$s with a version lower than %2$s is required - available version %3$s.',
-							[$libName, $maxVersion, $libVersion]);
-					}
-				}
-			}
-		}
-		return $missing;
-	}
-
-	private function analyzeOS(array $dependencies): array {
-		$missing = [];
-		if (!isset($dependencies['os'])) {
-			return $missing;
-		}
-
-		$oss = $dependencies['os'];
-		if (empty($oss)) {
-			return $missing;
-		}
-		if (is_array($oss)) {
-			$oss = array_map(function ($os) {
-				return $this->getValue($os);
-			}, $oss);
-		} else {
-			$oss = [$oss];
-		}
-		$currentOS = $this->platform->getOS();
-		if (!in_array($currentOS, $oss)) {
-			$missing[] = $this->l->t('The following platforms are supported: %s', [implode(', ', $oss)]);
-		}
-		return $missing;
-	}
-
-	private function analyzeOC(array $dependencies, array $appInfo, bool $ignoreMax): array {
-		$missing = [];
-		$minVersion = null;
-		if (isset($dependencies['nextcloud']['@attributes']['min-version'])) {
-			$minVersion = $dependencies['nextcloud']['@attributes']['min-version'];
-		} elseif (isset($dependencies['owncloud']['@attributes']['min-version'])) {
-			$minVersion = $dependencies['owncloud']['@attributes']['min-version'];
-		} elseif (isset($appInfo['requiremin'])) {
-			$minVersion = $appInfo['requiremin'];
-		} elseif (isset($appInfo['require'])) {
-			$minVersion = $appInfo['require'];
-		}
-		$maxVersion = $this->getMaxVersion($dependencies, $appInfo);
-
-		if (!is_null($minVersion)) {
-			if ($this->compareSmaller($this->platform->getOcVersion(), $minVersion)) {
-				$missing[] = $this->l->t('Server version %s or higher is required.', [$minVersion]);
-			}
-		}
-		if (!$ignoreMax && !is_null($maxVersion)) {
-			if ($this->compareBigger($this->platform->getOcVersion(), $maxVersion)) {
-				$missing[] = $this->l->t('Server version %s or lower is required.', [$maxVersion]);
-			}
-		}
-		return $missing;
-	}
-
-	private function getMaxVersion(array $dependencies, array $appInfo): ?string {
-		if (isset($dependencies['nextcloud']['@attributes']['max-version'])) {
-			return $dependencies['nextcloud']['@attributes']['max-version'];
-		}
-		if (isset($dependencies['owncloud']['@attributes']['max-version'])) {
-			return $dependencies['owncloud']['@attributes']['max-version'];
-		}
-		if (isset($appInfo['requiremax'])) {
-			return $appInfo['requiremax'];
-		}
-
-		return null;
-	}
-
-	/**
-	 * @param mixed $element
-	 * @return mixed
-	 */
-	private function getValue($element) {
-		if (isset($element['@value'])) {
-			return $element['@value'];
-		}
-		return (string)$element;
-	}
+    public function __construct(
+        private Platform $platform,
+        private IL10N $l,
+    ) {
+    }
+
+    /**
+     * @return array of missing dependencies
+     */
+    public function analyze(array $app, bool $ignoreMax = false): array {
+        if (isset($app['dependencies'])) {
+            $dependencies = $app['dependencies'];
+        } else {
+            $dependencies = [];
+        }
+
+        return array_merge(
+            $this->analyzeArchitecture($dependencies),
+            $this->analyzePhpVersion($dependencies),
+            $this->analyzeDatabases($dependencies),
+            $this->analyzeCommands($dependencies),
+            $this->analyzeLibraries($dependencies),
+            $this->analyzeOS($dependencies),
+            $this->analyzeOC($dependencies, $app, $ignoreMax)
+        );
+    }
+
+    public function isMarkedCompatible(array $app): bool {
+        if (isset($app['dependencies'])) {
+            $dependencies = $app['dependencies'];
+        } else {
+            $dependencies = [];
+        }
+
+        $maxVersion = $this->getMaxVersion($dependencies, $app);
+        if ($maxVersion === null) {
+            return true;
+        }
+        return !$this->compareBigger($this->platform->getOcVersion(), $maxVersion);
+    }
+
+    /**
+     * Truncates both versions to the lowest common version, e.g.
+     * 5.1.2.3 and 5.1 will be turned into 5.1 and 5.1,
+     * 5.2.6.5 and 5.1 will be turned into 5.2 and 5.1
+     * @return string[] first element is the first version, second element is the
+     *                  second version
+     */
+    private function normalizeVersions(string $first, string $second): array {
+        $first = explode('.', $first);
+        $second = explode('.', $second);
+
+        // get both arrays to the same minimum size
+        $length = min(count($second), count($first));
+        $first = array_slice($first, 0, $length);
+        $second = array_slice($second, 0, $length);
+
+        return [implode('.', $first), implode('.', $second)];
+    }
+
+    /**
+     * Parameters will be normalized and then passed into version_compare
+     * in the same order they are specified in the method header
+     * @return bool result similar to version_compare
+     */
+    private function compare(string $first, string $second, string $operator): bool {
+        [$first, $second] = $this->normalizeVersions($first, $second);
+
+        return version_compare($first, $second, $operator);
+    }
+
+    /**
+     * Checks if a version is bigger than another version
+     * @return bool true if the first version is bigger than the second
+     */
+    private function compareBigger(string $first, string $second): bool {
+        return $this->compare($first, $second, '>');
+    }
+
+    /**
+     * Checks if a version is smaller than another version
+     * @return bool true if the first version is smaller than the second
+     */
+    private function compareSmaller(string $first, string $second): bool {
+        return $this->compare($first, $second, '<');
+    }
+
+    private function analyzePhpVersion(array $dependencies): array {
+        $missing = [];
+        if (isset($dependencies['php']['@attributes']['min-version'])) {
+            $minVersion = $dependencies['php']['@attributes']['min-version'];
+            if ($this->compareSmaller($this->platform->getPhpVersion(), $minVersion)) {
+                $missing[] = $this->l->t('PHP %s or higher is required.', [$minVersion]);
+            }
+        }
+        if (isset($dependencies['php']['@attributes']['max-version'])) {
+            $maxVersion = $dependencies['php']['@attributes']['max-version'];
+            if ($this->compareBigger($this->platform->getPhpVersion(), $maxVersion)) {
+                $missing[] = $this->l->t('PHP with a version lower than %s is required.', [$maxVersion]);
+            }
+        }
+        if (isset($dependencies['php']['@attributes']['min-int-size'])) {
+            $intSize = $dependencies['php']['@attributes']['min-int-size'];
+            if ($intSize > $this->platform->getIntSize() * 8) {
+                $missing[] = $this->l->t('%sbit or higher PHP required.', [$intSize]);
+            }
+        }
+        return $missing;
+    }
+
+    private function analyzeArchitecture(array $dependencies): array {
+        $missing = [];
+        if (!isset($dependencies['architecture'])) {
+            return $missing;
+        }
+
+        $supportedArchitectures = $dependencies['architecture'];
+        if (empty($supportedArchitectures)) {
+            return $missing;
+        }
+        if (!is_array($supportedArchitectures)) {
+            $supportedArchitectures = [$supportedArchitectures];
+        }
+        $supportedArchitectures = array_map(function ($architecture) {
+            return $this->getValue($architecture);
+        }, $supportedArchitectures);
+        $currentArchitecture = $this->platform->getArchitecture();
+        if (!in_array($currentArchitecture, $supportedArchitectures, true)) {
+            $missing[] = $this->l->t('The following architectures are supported: %s', [implode(', ', $supportedArchitectures)]);
+        }
+        return $missing;
+    }
+
+    private function analyzeDatabases(array $dependencies): array {
+        $missing = [];
+        if (!isset($dependencies['database'])) {
+            return $missing;
+        }
+
+        $supportedDatabases = $dependencies['database'];
+        if (empty($supportedDatabases)) {
+            return $missing;
+        }
+        if (!is_array($supportedDatabases)) {
+            $supportedDatabases = [$supportedDatabases];
+        }
+        if (isset($supportedDatabases['@value'])) {
+            $supportedDatabases = [$supportedDatabases];
+        }
+        $supportedDatabases = array_map(function ($db) {
+            return $this->getValue($db);
+        }, $supportedDatabases);
+        $currentDatabase = $this->platform->getDatabase();
+        if (!in_array($currentDatabase, $supportedDatabases)) {
+            $missing[] = $this->l->t('The following databases are supported: %s', [implode(', ', $supportedDatabases)]);
+        }
+        return $missing;
+    }
+
+    private function analyzeCommands(array $dependencies): array {
+        $missing = [];
+        if (!isset($dependencies['command'])) {
+            return $missing;
+        }
+
+        $commands = $dependencies['command'];
+        if (!is_array($commands)) {
+            $commands = [$commands];
+        }
+        if (isset($commands['@value'])) {
+            $commands = [$commands];
+        }
+        $os = $this->platform->getOS();
+        foreach ($commands as $command) {
+            if (isset($command['@attributes']['os']) && $command['@attributes']['os'] !== $os) {
+                continue;
+            }
+            $commandName = $this->getValue($command);
+            if (!$this->platform->isCommandKnown($commandName)) {
+                $missing[] = $this->l->t('The command line tool %s could not be found', [$commandName]);
+            }
+        }
+        return $missing;
+    }
+
+    private function analyzeLibraries(array $dependencies): array {
+        $missing = [];
+        if (!isset($dependencies['lib'])) {
+            return $missing;
+        }
+
+        $libs = $dependencies['lib'];
+        if (!is_array($libs)) {
+            $libs = [$libs];
+        }
+        if (isset($libs['@value'])) {
+            $libs = [$libs];
+        }
+        foreach ($libs as $lib) {
+            $libName = $this->getValue($lib);
+            $libVersion = $this->platform->getLibraryVersion($libName);
+            if (is_null($libVersion)) {
+                $missing[] = $this->l->t('The library %s is not available.', [$libName]);
+                continue;
+            }
+
+            if (is_array($lib)) {
+                if (isset($lib['@attributes']['min-version'])) {
+                    $minVersion = $lib['@attributes']['min-version'];
+                    if ($this->compareSmaller($libVersion, $minVersion)) {
+                        $missing[] = $this->l->t('Library %1$s with a version higher than %2$s is required - available version %3$s.',
+                            [$libName, $minVersion, $libVersion]);
+                    }
+                }
+                if (isset($lib['@attributes']['max-version'])) {
+                    $maxVersion = $lib['@attributes']['max-version'];
+                    if ($this->compareBigger($libVersion, $maxVersion)) {
+                        $missing[] = $this->l->t('Library %1$s with a version lower than %2$s is required - available version %3$s.',
+                            [$libName, $maxVersion, $libVersion]);
+                    }
+                }
+            }
+        }
+        return $missing;
+    }
+
+    private function analyzeOS(array $dependencies): array {
+        $missing = [];
+        if (!isset($dependencies['os'])) {
+            return $missing;
+        }
+
+        $oss = $dependencies['os'];
+        if (empty($oss)) {
+            return $missing;
+        }
+        if (is_array($oss)) {
+            $oss = array_map(function ($os) {
+                return $this->getValue($os);
+            }, $oss);
+        } else {
+            $oss = [$oss];
+        }
+        $currentOS = $this->platform->getOS();
+        if (!in_array($currentOS, $oss)) {
+            $missing[] = $this->l->t('The following platforms are supported: %s', [implode(', ', $oss)]);
+        }
+        return $missing;
+    }
+
+    private function analyzeOC(array $dependencies, array $appInfo, bool $ignoreMax): array {
+        $missing = [];
+        $minVersion = null;
+        if (isset($dependencies['nextcloud']['@attributes']['min-version'])) {
+            $minVersion = $dependencies['nextcloud']['@attributes']['min-version'];
+        } elseif (isset($dependencies['owncloud']['@attributes']['min-version'])) {
+            $minVersion = $dependencies['owncloud']['@attributes']['min-version'];
+        } elseif (isset($appInfo['requiremin'])) {
+            $minVersion = $appInfo['requiremin'];
+        } elseif (isset($appInfo['require'])) {
+            $minVersion = $appInfo['require'];
+        }
+        $maxVersion = $this->getMaxVersion($dependencies, $appInfo);
+
+        if (!is_null($minVersion)) {
+            if ($this->compareSmaller($this->platform->getOcVersion(), $minVersion)) {
+                $missing[] = $this->l->t('Server version %s or higher is required.', [$minVersion]);
+            }
+        }
+        if (!$ignoreMax && !is_null($maxVersion)) {
+            if ($this->compareBigger($this->platform->getOcVersion(), $maxVersion)) {
+                $missing[] = $this->l->t('Server version %s or lower is required.', [$maxVersion]);
+            }
+        }
+        return $missing;
+    }
+
+    private function getMaxVersion(array $dependencies, array $appInfo): ?string {
+        if (isset($dependencies['nextcloud']['@attributes']['max-version'])) {
+            return $dependencies['nextcloud']['@attributes']['max-version'];
+        }
+        if (isset($dependencies['owncloud']['@attributes']['max-version'])) {
+            return $dependencies['owncloud']['@attributes']['max-version'];
+        }
+        if (isset($appInfo['requiremax'])) {
+            return $appInfo['requiremax'];
+        }
+
+        return null;
+    }
+
+    /**
+     * @param mixed $element
+     * @return mixed
+     */
+    private function getValue($element) {
+        if (isset($element['@value'])) {
+            return $element['@value'];
+        }
+        return (string)$element;
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -136,7 +136,7 @@ 
 		if (!is_array($supportedArchitectures)) {
 			$supportedArchitectures = [$supportedArchitectures];
 		}
-		$supportedArchitectures = array_map(function ($architecture) {
+		$supportedArchitectures = array_map(function($architecture) {
 			return $this->getValue($architecture);
 		}, $supportedArchitectures);
 		$currentArchitecture = $this->platform->getArchitecture();
@@ -162,7 +162,7 @@ 
 		if (isset($supportedDatabases['@value'])) {
 			$supportedDatabases = [$supportedDatabases];
 		}
-		$supportedDatabases = array_map(function ($db) {
+		$supportedDatabases = array_map(function($db) {
 			return $this->getValue($db);
 		}, $supportedDatabases);
 		$currentDatabase = $this->platform->getDatabase();
@@ -250,7 +250,7 @@ 
 			return $missing;
 		}
 		if (is_array($oss)) {
-			$oss = array_map(function ($os) {
+			$oss = array_map(function($os) {
 				return $this->getValue($os);
 			}, $oss);
 		} else {
@@ -312,6 +312,6 @@ 
 		if (isset($element['@value'])) {
 			return $element['@value'];
 		}
-		return (string)$element;
+		return (string) $element;
 	}
 }

lib/private/App/InfoParser.php

Indentation +309 added lines, -309 removed lines

@@ -11,338 +11,338 @@
 use function simplexml_load_string;
 
 class InfoParser {
-	/**
-	 * @param ICache|null $cache
-	 */
-	public function __construct(
-		private ?ICache $cache = null,
-	) {
-	}
+    /**
+     * @param ICache|null $cache
+     */
+    public function __construct(
+        private ?ICache $cache = null,
+    ) {
+    }
 
-	/**
-	 * @param string $file the xml file to be loaded
-	 * @return null|array where null is an indicator for an error
-	 */
-	public function parse(string $file): ?array {
-		if (!file_exists($file)) {
-			return null;
-		}
+    /**
+     * @param string $file the xml file to be loaded
+     * @return null|array where null is an indicator for an error
+     */
+    public function parse(string $file): ?array {
+        if (!file_exists($file)) {
+            return null;
+        }
 
-		if ($this->cache !== null) {
-			$fileCacheKey = $file . filemtime($file);
-			if ($cachedValue = $this->cache->get($fileCacheKey)) {
-				return json_decode($cachedValue, true);
-			}
-		}
+        if ($this->cache !== null) {
+            $fileCacheKey = $file . filemtime($file);
+            if ($cachedValue = $this->cache->get($fileCacheKey)) {
+                return json_decode($cachedValue, true);
+            }
+        }
 
-		libxml_use_internal_errors(true);
-		$xml = simplexml_load_string(file_get_contents($file));
+        libxml_use_internal_errors(true);
+        $xml = simplexml_load_string(file_get_contents($file));
 
-		if ($xml === false) {
-			libxml_clear_errors();
-			return null;
-		}
-		$array = $this->xmlToArray($xml);
+        if ($xml === false) {
+            libxml_clear_errors();
+            return null;
+        }
+        $array = $this->xmlToArray($xml);
 
-		if (is_string($array)) {
-			return null;
-		}
+        if (is_string($array)) {
+            return null;
+        }
 
-		if (!array_key_exists('info', $array)) {
-			$array['info'] = [];
-		}
-		if (!array_key_exists('remote', $array)) {
-			$array['remote'] = [];
-		}
-		if (!array_key_exists('public', $array)) {
-			$array['public'] = [];
-		}
-		if (!array_key_exists('types', $array)) {
-			$array['types'] = [];
-		}
-		if (!array_key_exists('repair-steps', $array)) {
-			$array['repair-steps'] = [];
-		}
-		if (!array_key_exists('install', $array['repair-steps'])) {
-			$array['repair-steps']['install'] = [];
-		}
-		if (!array_key_exists('pre-migration', $array['repair-steps'])) {
-			$array['repair-steps']['pre-migration'] = [];
-		}
-		if (!array_key_exists('post-migration', $array['repair-steps'])) {
-			$array['repair-steps']['post-migration'] = [];
-		}
-		if (!array_key_exists('live-migration', $array['repair-steps'])) {
-			$array['repair-steps']['live-migration'] = [];
-		}
-		if (!array_key_exists('uninstall', $array['repair-steps'])) {
-			$array['repair-steps']['uninstall'] = [];
-		}
-		if (!array_key_exists('background-jobs', $array)) {
-			$array['background-jobs'] = [];
-		}
-		if (!array_key_exists('two-factor-providers', $array)) {
-			$array['two-factor-providers'] = [];
-		}
-		if (!array_key_exists('commands', $array)) {
-			$array['commands'] = [];
-		}
-		if (!array_key_exists('activity', $array)) {
-			$array['activity'] = [];
-		}
-		if (!array_key_exists('filters', $array['activity'])) {
-			$array['activity']['filters'] = [];
-		}
-		if (!array_key_exists('settings', $array['activity'])) {
-			$array['activity']['settings'] = [];
-		}
-		if (!array_key_exists('providers', $array['activity'])) {
-			$array['activity']['providers'] = [];
-		}
-		if (!array_key_exists('settings', $array)) {
-			$array['settings'] = [];
-		}
-		if (!array_key_exists('admin', $array['settings'])) {
-			$array['settings']['admin'] = [];
-		}
-		if (!array_key_exists('admin-section', $array['settings'])) {
-			$array['settings']['admin-section'] = [];
-		}
-		if (!array_key_exists('personal', $array['settings'])) {
-			$array['settings']['personal'] = [];
-		}
-		if (!array_key_exists('personal-section', $array['settings'])) {
-			$array['settings']['personal-section'] = [];
-		}
-		if (!array_key_exists('dependencies', $array)) {
-			$array['dependencies'] = [];
-		}
-		if (!array_key_exists('backend', $array['dependencies'])) {
-			$array['dependencies']['backend'] = [];
-		}
+        if (!array_key_exists('info', $array)) {
+            $array['info'] = [];
+        }
+        if (!array_key_exists('remote', $array)) {
+            $array['remote'] = [];
+        }
+        if (!array_key_exists('public', $array)) {
+            $array['public'] = [];
+        }
+        if (!array_key_exists('types', $array)) {
+            $array['types'] = [];
+        }
+        if (!array_key_exists('repair-steps', $array)) {
+            $array['repair-steps'] = [];
+        }
+        if (!array_key_exists('install', $array['repair-steps'])) {
+            $array['repair-steps']['install'] = [];
+        }
+        if (!array_key_exists('pre-migration', $array['repair-steps'])) {
+            $array['repair-steps']['pre-migration'] = [];
+        }
+        if (!array_key_exists('post-migration', $array['repair-steps'])) {
+            $array['repair-steps']['post-migration'] = [];
+        }
+        if (!array_key_exists('live-migration', $array['repair-steps'])) {
+            $array['repair-steps']['live-migration'] = [];
+        }
+        if (!array_key_exists('uninstall', $array['repair-steps'])) {
+            $array['repair-steps']['uninstall'] = [];
+        }
+        if (!array_key_exists('background-jobs', $array)) {
+            $array['background-jobs'] = [];
+        }
+        if (!array_key_exists('two-factor-providers', $array)) {
+            $array['two-factor-providers'] = [];
+        }
+        if (!array_key_exists('commands', $array)) {
+            $array['commands'] = [];
+        }
+        if (!array_key_exists('activity', $array)) {
+            $array['activity'] = [];
+        }
+        if (!array_key_exists('filters', $array['activity'])) {
+            $array['activity']['filters'] = [];
+        }
+        if (!array_key_exists('settings', $array['activity'])) {
+            $array['activity']['settings'] = [];
+        }
+        if (!array_key_exists('providers', $array['activity'])) {
+            $array['activity']['providers'] = [];
+        }
+        if (!array_key_exists('settings', $array)) {
+            $array['settings'] = [];
+        }
+        if (!array_key_exists('admin', $array['settings'])) {
+            $array['settings']['admin'] = [];
+        }
+        if (!array_key_exists('admin-section', $array['settings'])) {
+            $array['settings']['admin-section'] = [];
+        }
+        if (!array_key_exists('personal', $array['settings'])) {
+            $array['settings']['personal'] = [];
+        }
+        if (!array_key_exists('personal-section', $array['settings'])) {
+            $array['settings']['personal-section'] = [];
+        }
+        if (!array_key_exists('dependencies', $array)) {
+            $array['dependencies'] = [];
+        }
+        if (!array_key_exists('backend', $array['dependencies'])) {
+            $array['dependencies']['backend'] = [];
+        }
 
-		if (array_key_exists('types', $array)) {
-			if (is_array($array['types'])) {
-				foreach ($array['types'] as $type => $v) {
-					unset($array['types'][$type]);
-					if (is_string($type)) {
-						$array['types'][] = $type;
-					}
-				}
-			} else {
-				$array['types'] = [];
-			}
-		}
-		if (isset($array['repair-steps']['install']['step']) && is_array($array['repair-steps']['install']['step'])) {
-			$array['repair-steps']['install'] = $array['repair-steps']['install']['step'];
-		}
-		if (isset($array['repair-steps']['pre-migration']['step']) && is_array($array['repair-steps']['pre-migration']['step'])) {
-			$array['repair-steps']['pre-migration'] = $array['repair-steps']['pre-migration']['step'];
-		}
-		if (isset($array['repair-steps']['post-migration']['step']) && is_array($array['repair-steps']['post-migration']['step'])) {
-			$array['repair-steps']['post-migration'] = $array['repair-steps']['post-migration']['step'];
-		}
-		if (isset($array['repair-steps']['live-migration']['step']) && is_array($array['repair-steps']['live-migration']['step'])) {
-			$array['repair-steps']['live-migration'] = $array['repair-steps']['live-migration']['step'];
-		}
-		if (isset($array['repair-steps']['uninstall']['step']) && is_array($array['repair-steps']['uninstall']['step'])) {
-			$array['repair-steps']['uninstall'] = $array['repair-steps']['uninstall']['step'];
-		}
-		if (isset($array['background-jobs']['job']) && is_array($array['background-jobs']['job'])) {
-			$array['background-jobs'] = $array['background-jobs']['job'];
-		}
-		if (isset($array['commands']['command']) && is_array($array['commands']['command'])) {
-			$array['commands'] = $array['commands']['command'];
-		}
-		if (isset($array['two-factor-providers']['provider']) && is_array($array['two-factor-providers']['provider'])) {
-			$array['two-factor-providers'] = $array['two-factor-providers']['provider'];
-		}
-		if (isset($array['activity']['filters']['filter']) && is_array($array['activity']['filters']['filter'])) {
-			$array['activity']['filters'] = $array['activity']['filters']['filter'];
-		}
-		if (isset($array['activity']['settings']['setting']) && is_array($array['activity']['settings']['setting'])) {
-			$array['activity']['settings'] = $array['activity']['settings']['setting'];
-		}
-		if (isset($array['activity']['providers']['provider']) && is_array($array['activity']['providers']['provider'])) {
-			$array['activity']['providers'] = $array['activity']['providers']['provider'];
-		}
-		if (isset($array['collaboration']['collaborators']['searchPlugins']['searchPlugin'])
-			&& is_array($array['collaboration']['collaborators']['searchPlugins']['searchPlugin'])
-			&& !isset($array['collaboration']['collaborators']['searchPlugins']['searchPlugin']['class'])
-		) {
-			$array['collaboration']['collaborators']['searchPlugins'] = $array['collaboration']['collaborators']['searchPlugins']['searchPlugin'];
-		}
-		if (isset($array['settings']['admin']) && !is_array($array['settings']['admin'])) {
-			$array['settings']['admin'] = [$array['settings']['admin']];
-		}
-		if (isset($array['settings']['admin-section']) && !is_array($array['settings']['admin-section'])) {
-			$array['settings']['admin-section'] = [$array['settings']['admin-section']];
-		}
-		if (isset($array['settings']['personal']) && !is_array($array['settings']['personal'])) {
-			$array['settings']['personal'] = [$array['settings']['personal']];
-		}
-		if (isset($array['settings']['personal-section']) && !is_array($array['settings']['personal-section'])) {
-			$array['settings']['personal-section'] = [$array['settings']['personal-section']];
-		}
-		if (isset($array['navigations']['navigation']) && $this->isNavigationItem($array['navigations']['navigation'])) {
-			$array['navigations']['navigation'] = [$array['navigations']['navigation']];
-		}
-		if (isset($array['dependencies']['backend']) && !is_array($array['dependencies']['backend'])) {
-			$array['dependencies']['backend'] = [$array['dependencies']['backend']];
-		}
+        if (array_key_exists('types', $array)) {
+            if (is_array($array['types'])) {
+                foreach ($array['types'] as $type => $v) {
+                    unset($array['types'][$type]);
+                    if (is_string($type)) {
+                        $array['types'][] = $type;
+                    }
+                }
+            } else {
+                $array['types'] = [];
+            }
+        }
+        if (isset($array['repair-steps']['install']['step']) && is_array($array['repair-steps']['install']['step'])) {
+            $array['repair-steps']['install'] = $array['repair-steps']['install']['step'];
+        }
+        if (isset($array['repair-steps']['pre-migration']['step']) && is_array($array['repair-steps']['pre-migration']['step'])) {
+            $array['repair-steps']['pre-migration'] = $array['repair-steps']['pre-migration']['step'];
+        }
+        if (isset($array['repair-steps']['post-migration']['step']) && is_array($array['repair-steps']['post-migration']['step'])) {
+            $array['repair-steps']['post-migration'] = $array['repair-steps']['post-migration']['step'];
+        }
+        if (isset($array['repair-steps']['live-migration']['step']) && is_array($array['repair-steps']['live-migration']['step'])) {
+            $array['repair-steps']['live-migration'] = $array['repair-steps']['live-migration']['step'];
+        }
+        if (isset($array['repair-steps']['uninstall']['step']) && is_array($array['repair-steps']['uninstall']['step'])) {
+            $array['repair-steps']['uninstall'] = $array['repair-steps']['uninstall']['step'];
+        }
+        if (isset($array['background-jobs']['job']) && is_array($array['background-jobs']['job'])) {
+            $array['background-jobs'] = $array['background-jobs']['job'];
+        }
+        if (isset($array['commands']['command']) && is_array($array['commands']['command'])) {
+            $array['commands'] = $array['commands']['command'];
+        }
+        if (isset($array['two-factor-providers']['provider']) && is_array($array['two-factor-providers']['provider'])) {
+            $array['two-factor-providers'] = $array['two-factor-providers']['provider'];
+        }
+        if (isset($array['activity']['filters']['filter']) && is_array($array['activity']['filters']['filter'])) {
+            $array['activity']['filters'] = $array['activity']['filters']['filter'];
+        }
+        if (isset($array['activity']['settings']['setting']) && is_array($array['activity']['settings']['setting'])) {
+            $array['activity']['settings'] = $array['activity']['settings']['setting'];
+        }
+        if (isset($array['activity']['providers']['provider']) && is_array($array['activity']['providers']['provider'])) {
+            $array['activity']['providers'] = $array['activity']['providers']['provider'];
+        }
+        if (isset($array['collaboration']['collaborators']['searchPlugins']['searchPlugin'])
+            && is_array($array['collaboration']['collaborators']['searchPlugins']['searchPlugin'])
+            && !isset($array['collaboration']['collaborators']['searchPlugins']['searchPlugin']['class'])
+        ) {
+            $array['collaboration']['collaborators']['searchPlugins'] = $array['collaboration']['collaborators']['searchPlugins']['searchPlugin'];
+        }
+        if (isset($array['settings']['admin']) && !is_array($array['settings']['admin'])) {
+            $array['settings']['admin'] = [$array['settings']['admin']];
+        }
+        if (isset($array['settings']['admin-section']) && !is_array($array['settings']['admin-section'])) {
+            $array['settings']['admin-section'] = [$array['settings']['admin-section']];
+        }
+        if (isset($array['settings']['personal']) && !is_array($array['settings']['personal'])) {
+            $array['settings']['personal'] = [$array['settings']['personal']];
+        }
+        if (isset($array['settings']['personal-section']) && !is_array($array['settings']['personal-section'])) {
+            $array['settings']['personal-section'] = [$array['settings']['personal-section']];
+        }
+        if (isset($array['navigations']['navigation']) && $this->isNavigationItem($array['navigations']['navigation'])) {
+            $array['navigations']['navigation'] = [$array['navigations']['navigation']];
+        }
+        if (isset($array['dependencies']['backend']) && !is_array($array['dependencies']['backend'])) {
+            $array['dependencies']['backend'] = [$array['dependencies']['backend']];
+        }
 
-		// Ensure some fields are always arrays
-		if (isset($array['screenshot']) && !is_array($array['screenshot'])) {
-			$array['screenshot'] = [$array['screenshot']];
-		}
-		if (isset($array['author']) && !is_array($array['author'])) {
-			$array['author'] = [$array['author']];
-		}
-		if (isset($array['category']) && !is_array($array['category'])) {
-			$array['category'] = [$array['category']];
-		}
+        // Ensure some fields are always arrays
+        if (isset($array['screenshot']) && !is_array($array['screenshot'])) {
+            $array['screenshot'] = [$array['screenshot']];
+        }
+        if (isset($array['author']) && !is_array($array['author'])) {
+            $array['author'] = [$array['author']];
+        }
+        if (isset($array['category']) && !is_array($array['category'])) {
+            $array['category'] = [$array['category']];
+        }
 
-		if ($this->cache !== null) {
-			$this->cache->set($fileCacheKey, json_encode($array));
-		}
-		return $array;
-	}
+        if ($this->cache !== null) {
+            $this->cache->set($fileCacheKey, json_encode($array));
+        }
+        return $array;
+    }
 
-	private function isNavigationItem(array $data): bool {
-		// Allow settings navigation items with no route entry
-		$type = $data['type'] ?? 'link';
-		if ($type === 'settings') {
-			return isset($data['name']);
-		}
-		return isset($data['name'], $data['route']);
-	}
+    private function isNavigationItem(array $data): bool {
+        // Allow settings navigation items with no route entry
+        $type = $data['type'] ?? 'link';
+        if ($type === 'settings') {
+            return isset($data['name']);
+        }
+        return isset($data['name'], $data['route']);
+    }
 
-	public function xmlToArray(\SimpleXMLElement $xml): array|string {
-		$children = $xml->children();
-		if ($children === null || count($children) === 0) {
-			return (string)$xml;
-		}
+    public function xmlToArray(\SimpleXMLElement $xml): array|string {
+        $children = $xml->children();
+        if ($children === null || count($children) === 0) {
+            return (string)$xml;
+        }
 
-		$array = [];
-		foreach ($children as $element => $node) {
-			if ($element === null) {
-				throw new \InvalidArgumentException('xml contains a null element');
-			}
-			$totalElement = count($xml->{$element});
+        $array = [];
+        foreach ($children as $element => $node) {
+            if ($element === null) {
+                throw new \InvalidArgumentException('xml contains a null element');
+            }
+            $totalElement = count($xml->{$element});
 
-			if (!isset($array[$element])) {
-				$array[$element] = $totalElement > 1 ? [] : '';
-			}
-			/** @var \SimpleXMLElement $node */
-			// Has attributes
-			if ($attributes = $node->attributes()) {
-				$data = [
-					'@attributes' => [],
-				];
-				$converted = $this->xmlToArray($node);
-				if (is_string($converted)) {
-					if (!empty($converted)) {
-						$data['@value'] = $converted;
-					}
-				} else {
-					$data = array_merge($data, $converted);
-				}
-				foreach ($attributes as $attr => $value) {
-					if ($attr === null) {
-						throw new \InvalidArgumentException('xml contains a null element');
-					}
-					$data['@attributes'][$attr] = (string)$value;
-				}
+            if (!isset($array[$element])) {
+                $array[$element] = $totalElement > 1 ? [] : '';
+            }
+            /** @var \SimpleXMLElement $node */
+            // Has attributes
+            if ($attributes = $node->attributes()) {
+                $data = [
+                    '@attributes' => [],
+                ];
+                $converted = $this->xmlToArray($node);
+                if (is_string($converted)) {
+                    if (!empty($converted)) {
+                        $data['@value'] = $converted;
+                    }
+                } else {
+                    $data = array_merge($data, $converted);
+                }
+                foreach ($attributes as $attr => $value) {
+                    if ($attr === null) {
+                        throw new \InvalidArgumentException('xml contains a null element');
+                    }
+                    $data['@attributes'][$attr] = (string)$value;
+                }
 
-				if ($totalElement > 1) {
-					$array[$element][] = $data;
-				} else {
-					$array[$element] = $data;
-				}
-				// Just a value
-			} else {
-				if ($totalElement > 1) {
-					$array[$element][] = $this->xmlToArray($node);
-				} else {
-					$array[$element] = $this->xmlToArray($node);
-				}
-			}
-		}
+                if ($totalElement > 1) {
+                    $array[$element][] = $data;
+                } else {
+                    $array[$element] = $data;
+                }
+                // Just a value
+            } else {
+                if ($totalElement > 1) {
+                    $array[$element][] = $this->xmlToArray($node);
+                } else {
+                    $array[$element] = $this->xmlToArray($node);
+                }
+            }
+        }
 
-		return $array;
-	}
+        return $array;
+    }
 
-	/**
-	 * Select the appropriate l10n version for fields name, summary and description
-	 */
-	public function applyL10N(array $data, ?string $lang = null): array {
-		if ($lang !== '' && $lang !== null) {
-			if (isset($data['name']) && is_array($data['name'])) {
-				$data['name'] = $this->findBestL10NOption($data['name'], $lang);
-			}
-			if (isset($data['summary']) && is_array($data['summary'])) {
-				$data['summary'] = $this->findBestL10NOption($data['summary'], $lang);
-			}
-			if (isset($data['description']) && is_array($data['description'])) {
-				$data['description'] = trim($this->findBestL10NOption($data['description'], $lang));
-			}
-		} elseif (isset($data['description']) && is_string($data['description'])) {
-			$data['description'] = trim($data['description']);
-		} else {
-			$data['description'] = '';
-		}
+    /**
+     * Select the appropriate l10n version for fields name, summary and description
+     */
+    public function applyL10N(array $data, ?string $lang = null): array {
+        if ($lang !== '' && $lang !== null) {
+            if (isset($data['name']) && is_array($data['name'])) {
+                $data['name'] = $this->findBestL10NOption($data['name'], $lang);
+            }
+            if (isset($data['summary']) && is_array($data['summary'])) {
+                $data['summary'] = $this->findBestL10NOption($data['summary'], $lang);
+            }
+            if (isset($data['description']) && is_array($data['description'])) {
+                $data['description'] = trim($this->findBestL10NOption($data['description'], $lang));
+            }
+        } elseif (isset($data['description']) && is_string($data['description'])) {
+            $data['description'] = trim($data['description']);
+        } else {
+            $data['description'] = '';
+        }
 
-		return $data;
-	}
+        return $data;
+    }
 
-	protected function findBestL10NOption(array $options, string $lang): string {
-		// only a single option
-		if (isset($options['@value'])) {
-			return $options['@value'];
-		}
+    protected function findBestL10NOption(array $options, string $lang): string {
+        // only a single option
+        if (isset($options['@value'])) {
+            return $options['@value'];
+        }
 
-		$fallback = $similarLangFallback = $englishFallback = false;
+        $fallback = $similarLangFallback = $englishFallback = false;
 
-		$lang = strtolower($lang);
-		$similarLang = $lang;
-		$pos = strpos($similarLang, '_');
-		if ($pos !== false && $pos > 0) {
-			// For "de_DE" we want to find "de" and the other way around
-			$similarLang = substr($lang, 0, $pos);
-		}
+        $lang = strtolower($lang);
+        $similarLang = $lang;
+        $pos = strpos($similarLang, '_');
+        if ($pos !== false && $pos > 0) {
+            // For "de_DE" we want to find "de" and the other way around
+            $similarLang = substr($lang, 0, $pos);
+        }
 
-		foreach ($options as $option) {
-			if (is_array($option)) {
-				if ($fallback === false) {
-					$fallback = $option['@value'];
-				}
+        foreach ($options as $option) {
+            if (is_array($option)) {
+                if ($fallback === false) {
+                    $fallback = $option['@value'];
+                }
 
-				if (!isset($option['@attributes']['lang'])) {
-					continue;
-				}
+                if (!isset($option['@attributes']['lang'])) {
+                    continue;
+                }
 
-				$attributeLang = strtolower($option['@attributes']['lang']);
-				if ($attributeLang === $lang) {
-					return $option['@value'];
-				}
+                $attributeLang = strtolower($option['@attributes']['lang']);
+                if ($attributeLang === $lang) {
+                    return $option['@value'];
+                }
 
-				if ($attributeLang === $similarLang) {
-					$similarLangFallback = $option['@value'];
-				} elseif (str_starts_with($attributeLang, $similarLang . '_')) {
-					if ($similarLangFallback === false) {
-						$similarLangFallback = $option['@value'];
-					}
-				}
-			} else {
-				$englishFallback = $option;
-			}
-		}
+                if ($attributeLang === $similarLang) {
+                    $similarLangFallback = $option['@value'];
+                } elseif (str_starts_with($attributeLang, $similarLang . '_')) {
+                    if ($similarLangFallback === false) {
+                        $similarLangFallback = $option['@value'];
+                    }
+                }
+            } else {
+                $englishFallback = $option;
+            }
+        }
 
-		if ($similarLangFallback !== false) {
-			return $similarLangFallback;
-		} elseif ($englishFallback !== false) {
-			return $englishFallback;
-		}
-		return (string)$fallback;
-	}
+        if ($similarLangFallback !== false) {
+            return $similarLangFallback;
+        } elseif ($englishFallback !== false) {
+            return $englishFallback;
+        }
+        return (string)$fallback;
+    }
 }

Spacing +6 added lines, -6 removed lines

@@ -29,7 +29,7 @@ 
 		}
 
 		if ($this->cache !== null) {
-			$fileCacheKey = $file . filemtime($file);
+			$fileCacheKey = $file.filemtime($file);
 			if ($cachedValue = $this->cache->get($fileCacheKey)) {
 				return json_decode($cachedValue, true);
 			}
@@ -217,10 +217,10 @@ 
 		return isset($data['name'], $data['route']);
 	}
 
-	public function xmlToArray(\SimpleXMLElement $xml): array|string {
+	public function xmlToArray(\SimpleXMLElement $xml): array | string {
 		$children = $xml->children();
 		if ($children === null || count($children) === 0) {
-			return (string)$xml;
+			return (string) $xml;
 		}
 
 		$array = [];
@@ -251,7 +251,7 @@ 
 					if ($attr === null) {
 						throw new \InvalidArgumentException('xml contains a null element');
 					}
-					$data['@attributes'][$attr] = (string)$value;
+					$data['@attributes'][$attr] = (string) $value;
 				}
 
 				if ($totalElement > 1) {
@@ -328,7 +328,7 @@ 
 
 				if ($attributeLang === $similarLang) {
 					$similarLangFallback = $option['@value'];
-				} elseif (str_starts_with($attributeLang, $similarLang . '_')) {
+				} elseif (str_starts_with($attributeLang, $similarLang.'_')) {
 					if ($similarLangFallback === false) {
 						$similarLangFallback = $option['@value'];
 					}
@@ -343,6 +343,6 @@ 
 		} elseif ($englishFallback !== false) {
 			return $englishFallback;
 		}
-		return (string)$fallback;
+		return (string) $fallback;
 	}
 }

lib/private/legacy/OC_App.php

Indentation +762 added lines, -762 removed lines

@@ -31,766 +31,766 @@
  * upgrading and removing apps.
  */
 class OC_App {
-	private static $altLogin = [];
-	private static $alreadyRegistered = [];
-	public const supportedApp = 300;
-	public const officialApp = 200;
-
-	/**
-	 * clean the appId
-	 *
-	 * @psalm-taint-escape file
-	 * @psalm-taint-escape include
-	 * @psalm-taint-escape html
-	 * @psalm-taint-escape has_quotes
-	 *
-	 * @deprecated 31.0.0 use IAppManager::cleanAppId
-	 */
-	public static function cleanAppId(string $app): string {
-		return str_replace(['<', '>', '"', "'", '\0', '/', '\\', '..'], '', $app);
-	}
-
-	/**
-	 * Check if an app is loaded
-	 *
-	 * @param string $app
-	 * @return bool
-	 * @deprecated 27.0.0 use IAppManager::isAppLoaded
-	 */
-	public static function isAppLoaded(string $app): bool {
-		return \OC::$server->get(IAppManager::class)->isAppLoaded($app);
-	}
-
-	/**
-	 * loads all apps
-	 *
-	 * @param string[] $types
-	 * @return bool
-	 *
-	 * This function walks through the Nextcloud directory and loads all apps
-	 * it can find. A directory contains an app if the file /appinfo/info.xml
-	 * exists.
-	 *
-	 * if $types is set to non-empty array, only apps of those types will be loaded
-	 *
-	 * @deprecated 29.0.0 use IAppManager::loadApps instead
-	 */
-	public static function loadApps(array $types = []): bool {
-		if (!\OC::$server->getSystemConfig()->getValue('installed', false)) {
-			// This should be done before calling this method so that appmanager can be used
-			return false;
-		}
-		return \OC::$server->get(IAppManager::class)->loadApps($types);
-	}
-
-	/**
-	 * load a single app
-	 *
-	 * @param string $app
-	 * @throws Exception
-	 * @deprecated 27.0.0 use IAppManager::loadApp
-	 */
-	public static function loadApp(string $app): void {
-		\OC::$server->get(IAppManager::class)->loadApp($app);
-	}
-
-	/**
-	 * @internal
-	 * @param string $app
-	 * @param string $path
-	 * @param bool $force
-	 */
-	public static function registerAutoloading(string $app, string $path, bool $force = false) {
-		$key = $app . '-' . $path;
-		if (!$force && isset(self::$alreadyRegistered[$key])) {
-			return;
-		}
-
-		self::$alreadyRegistered[$key] = true;
-
-		// Register on PSR-4 composer autoloader
-		$appNamespace = \OC\AppFramework\App::buildAppNamespace($app);
-		\OC::$server->registerNamespace($app, $appNamespace);
-
-		if (file_exists($path . '/composer/autoload.php')) {
-			require_once $path . '/composer/autoload.php';
-		} else {
-			\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
-		}
-
-		// Register Test namespace only when testing
-		if (defined('PHPUNIT_RUN') || defined('CLI_TEST_RUN')) {
-			\OC::$composerAutoloader->addPsr4($appNamespace . '\\Tests\\', $path . '/tests/', true);
-		}
-	}
-
-	/**
-	 * check if an app is of a specific type
-	 *
-	 * @param string $app
-	 * @param array $types
-	 * @return bool
-	 * @deprecated 27.0.0 use IAppManager::isType
-	 */
-	public static function isType(string $app, array $types): bool {
-		return \OC::$server->get(IAppManager::class)->isType($app, $types);
-	}
-
-	/**
-	 * read app types from info.xml and cache them in the database
-	 */
-	public static function setAppTypes(string $app) {
-		$appManager = \OC::$server->getAppManager();
-		$appData = $appManager->getAppInfo($app);
-		if (!is_array($appData)) {
-			return;
-		}
-
-		if (isset($appData['types'])) {
-			$appTypes = implode(',', $appData['types']);
-		} else {
-			$appTypes = '';
-			$appData['types'] = [];
-		}
-
-		$config = \OC::$server->getConfig();
-		$config->setAppValue($app, 'types', $appTypes);
-
-		if ($appManager->hasProtectedAppType($appData['types'])) {
-			$enabled = $config->getAppValue($app, 'enabled', 'yes');
-			if ($enabled !== 'yes' && $enabled !== 'no') {
-				$config->setAppValue($app, 'enabled', 'yes');
-			}
-		}
-	}
-
-	/**
-	 * Returns apps enabled for the current user.
-	 *
-	 * @param bool $forceRefresh whether to refresh the cache
-	 * @param bool $all whether to return apps for all users, not only the
-	 *                  currently logged in one
-	 * @return list<string>
-	 */
-	public static function getEnabledApps(bool $forceRefresh = false, bool $all = false): array {
-		if (!\OC::$server->getSystemConfig()->getValue('installed', false)) {
-			return [];
-		}
-		// in incognito mode or when logged out, $user will be false,
-		// which is also the case during an upgrade
-		$appManager = \OC::$server->getAppManager();
-		if ($all) {
-			$user = null;
-		} else {
-			$user = \OC::$server->getUserSession()->getUser();
-		}
-
-		if (is_null($user)) {
-			$apps = $appManager->getEnabledApps();
-		} else {
-			$apps = $appManager->getEnabledAppsForUser($user);
-		}
-		$apps = array_filter($apps, function ($app) {
-			return $app !== 'files';//we add this manually
-		});
-		sort($apps);
-		array_unshift($apps, 'files');
-		return $apps;
-	}
-
-	/**
-	 * enables an app
-	 *
-	 * @param string $appId
-	 * @param array $groups (optional) when set, only these groups will have access to the app
-	 * @throws \Exception
-	 * @return void
-	 *
-	 * This function set an app as enabled in appconfig.
-	 */
-	public function enable(string $appId,
-		array $groups = []) {
-		// Check if app is already downloaded
-		/** @var Installer $installer */
-		$installer = Server::get(Installer::class);
-		$isDownloaded = $installer->isDownloaded($appId);
-
-		if (!$isDownloaded) {
-			$installer->downloadApp($appId);
-		}
-
-		$installer->installApp($appId);
-
-		$appManager = \OC::$server->getAppManager();
-		if ($groups !== []) {
-			$groupManager = \OC::$server->getGroupManager();
-			$groupsList = [];
-			foreach ($groups as $group) {
-				$groupItem = $groupManager->get($group);
-				if ($groupItem instanceof \OCP\IGroup) {
-					$groupsList[] = $groupManager->get($group);
-				}
-			}
-			$appManager->enableAppForGroups($appId, $groupsList);
-		} else {
-			$appManager->enableApp($appId);
-		}
-	}
-
-	/**
-	 * Get the path where to install apps
-	 */
-	public static function getInstallPath(): ?string {
-		foreach (OC::$APPSROOTS as $dir) {
-			if (isset($dir['writable']) && $dir['writable'] === true) {
-				return $dir['path'];
-			}
-		}
-
-		Server::get(LoggerInterface::class)->error('No application directories are marked as writable.', ['app' => 'core']);
-		return null;
-	}
-
-
-	/**
-	 * Find the apps root for an app id.
-	 *
-	 * If multiple copies are found, the apps root the latest version is returned.
-	 *
-	 * @param string $appId
-	 * @param bool $ignoreCache ignore cache and rebuild it
-	 * @return false|array{path: string, url: string} the apps root shape
-	 */
-	public static function findAppInDirectories(string $appId, bool $ignoreCache = false) {
-		$sanitizedAppId = self::cleanAppId($appId);
-		if ($sanitizedAppId !== $appId) {
-			return false;
-		}
-		static $app_dir = [];
-
-		if (isset($app_dir[$appId]) && !$ignoreCache) {
-			return $app_dir[$appId];
-		}
-
-		$possibleApps = [];
-		foreach (OC::$APPSROOTS as $dir) {
-			if (file_exists($dir['path'] . '/' . $appId)) {
-				$possibleApps[] = $dir;
-			}
-		}
-
-		if (empty($possibleApps)) {
-			return false;
-		} elseif (count($possibleApps) === 1) {
-			$dir = array_shift($possibleApps);
-			$app_dir[$appId] = $dir;
-			return $dir;
-		} else {
-			$versionToLoad = [];
-			foreach ($possibleApps as $possibleApp) {
-				$version = self::getAppVersionByPath($possibleApp['path'] . '/' . $appId);
-				if (empty($versionToLoad) || version_compare($version, $versionToLoad['version'], '>')) {
-					$versionToLoad = [
-						'dir' => $possibleApp,
-						'version' => $version,
-					];
-				}
-			}
-			$app_dir[$appId] = $versionToLoad['dir'];
-			return $versionToLoad['dir'];
-			//TODO - write test
-		}
-	}
-
-	/**
-	 * Get the directory for the given app.
-	 * If the app is defined in multiple directories, the first one is taken. (false if not found)
-	 *
-	 * @psalm-taint-specialize
-	 *
-	 * @param string $appId
-	 * @param bool $refreshAppPath should be set to true only during install/upgrade
-	 * @return string|false
-	 * @deprecated 11.0.0 use Server::get(IAppManager)->getAppPath()
-	 */
-	public static function getAppPath(string $appId, bool $refreshAppPath = false) {
-		$appId = self::cleanAppId($appId);
-		if ($appId === '') {
-			return false;
-		} elseif ($appId === 'core') {
-			return __DIR__ . '/../../../core';
-		}
-
-		if (($dir = self::findAppInDirectories($appId, $refreshAppPath)) != false) {
-			return $dir['path'] . '/' . $appId;
-		}
-		return false;
-	}
-
-	/**
-	 * Get the path for the given app on the access
-	 * If the app is defined in multiple directories, the first one is taken. (false if not found)
-	 *
-	 * @param string $appId
-	 * @return string|false
-	 * @deprecated 18.0.0 use \OC::$server->getAppManager()->getAppWebPath()
-	 */
-	public static function getAppWebPath(string $appId) {
-		if (($dir = self::findAppInDirectories($appId)) != false) {
-			return OC::$WEBROOT . $dir['url'] . '/' . $appId;
-		}
-		return false;
-	}
-
-	/**
-	 * get app's version based on it's path
-	 *
-	 * @param string $path
-	 * @return string
-	 */
-	public static function getAppVersionByPath(string $path): string {
-		$infoFile = $path . '/appinfo/info.xml';
-		$appData = Server::get(IAppManager::class)->getAppInfoByPath($infoFile);
-		return $appData['version'] ?? '';
-	}
-
-	/**
-	 * get the id of loaded app
-	 *
-	 * @return string
-	 */
-	public static function getCurrentApp(): string {
-		if (\OC::$CLI) {
-			return '';
-		}
-
-		$request = \OC::$server->getRequest();
-		$script = substr($request->getScriptName(), strlen(OC::$WEBROOT) + 1);
-		$topFolder = substr($script, 0, strpos($script, '/') ?: 0);
-		if (empty($topFolder)) {
-			try {
-				$path_info = $request->getPathInfo();
-			} catch (Exception $e) {
-				// Can happen from unit tests because the script name is `./vendor/bin/phpunit` or something a like then.
-				\OC::$server->get(LoggerInterface::class)->error('Failed to detect current app from script path', ['exception' => $e]);
-				return '';
-			}
-			if ($path_info) {
-				$topFolder = substr($path_info, 1, strpos($path_info, '/', 1) - 1);
-			}
-		}
-		if ($topFolder == 'apps') {
-			$length = strlen($topFolder);
-			return substr($script, $length + 1, strpos($script, '/', $length + 1) - $length - 1) ?: '';
-		} else {
-			return $topFolder;
-		}
-	}
-
-	/**
-	 * @param array $entry
-	 * @deprecated 20.0.0 Please register your alternative login option using the registerAlternativeLogin() on the RegistrationContext in your Application class implementing the OCP\Authentication\IAlternativeLogin interface
-	 */
-	public static function registerLogIn(array $entry) {
-		Server::get(LoggerInterface::class)->debug('OC_App::registerLogIn() is deprecated, please register your alternative login option using the registerAlternativeLogin() on the RegistrationContext in your Application class implementing the OCP\Authentication\IAlternativeLogin interface');
-		self::$altLogin[] = $entry;
-	}
-
-	/**
-	 * @return array
-	 */
-	public static function getAlternativeLogIns(): array {
-		/** @var Coordinator $bootstrapCoordinator */
-		$bootstrapCoordinator = Server::get(Coordinator::class);
-
-		foreach ($bootstrapCoordinator->getRegistrationContext()->getAlternativeLogins() as $registration) {
-			if (!in_array(IAlternativeLogin::class, class_implements($registration->getService()), true)) {
-				Server::get(LoggerInterface::class)->error('Alternative login option {option} does not implement {interface} and is therefore ignored.', [
-					'option' => $registration->getService(),
-					'interface' => IAlternativeLogin::class,
-					'app' => $registration->getAppId(),
-				]);
-				continue;
-			}
-
-			try {
-				/** @var IAlternativeLogin $provider */
-				$provider = Server::get($registration->getService());
-			} catch (ContainerExceptionInterface $e) {
-				Server::get(LoggerInterface::class)->error('Alternative login option {option} can not be initialized.',
-					[
-						'exception' => $e,
-						'option' => $registration->getService(),
-						'app' => $registration->getAppId(),
-					]);
-			}
-
-			try {
-				$provider->load();
-
-				self::$altLogin[] = [
-					'name' => $provider->getLabel(),
-					'href' => $provider->getLink(),
-					'class' => $provider->getClass(),
-				];
-			} catch (Throwable $e) {
-				Server::get(LoggerInterface::class)->error('Alternative login option {option} had an error while loading.',
-					[
-						'exception' => $e,
-						'option' => $registration->getService(),
-						'app' => $registration->getAppId(),
-					]);
-			}
-		}
-
-		return self::$altLogin;
-	}
-
-	/**
-	 * get a list of all apps in the apps folder
-	 *
-	 * @return string[] an array of app names (string IDs)
-	 * @deprecated 31.0.0 Use IAppManager::getAllAppsInAppsFolders instead
-	 */
-	public static function getAllApps(): array {
-		return Server::get(IAppManager::class)->getAllAppsInAppsFolders();
-	}
-
-	/**
-	 * List all supported apps
-	 *
-	 * @deprecated 32.0.0 Use \OCP\Support\Subscription\IRegistry::delegateGetSupportedApps instead
-	 */
-	public function getSupportedApps(): array {
-		$subscriptionRegistry = Server::get(\OCP\Support\Subscription\IRegistry::class);
-		$supportedApps = $subscriptionRegistry->delegateGetSupportedApps();
-		return $supportedApps;
-	}
-
-	/**
-	 * List all apps, this is used in apps.php
-	 *
-	 * @return array
-	 */
-	public function listAllApps(): array {
-		$appManager = \OC::$server->getAppManager();
-
-		$installedApps = $appManager->getAllAppsInAppsFolders();
-		//we don't want to show configuration for these
-		$blacklist = $appManager->getAlwaysEnabledApps();
-		$appList = [];
-		$langCode = \OC::$server->getL10N('core')->getLanguageCode();
-		$urlGenerator = \OC::$server->getURLGenerator();
-		$supportedApps = $this->getSupportedApps();
-
-		foreach ($installedApps as $app) {
-			if (!in_array($app, $blacklist)) {
-				$info = $appManager->getAppInfo($app, false, $langCode);
-				if (!is_array($info)) {
-					Server::get(LoggerInterface::class)->error('Could not read app info file for app "' . $app . '"', ['app' => 'core']);
-					continue;
-				}
-
-				if (!isset($info['name'])) {
-					Server::get(LoggerInterface::class)->error('App id "' . $app . '" has no name in appinfo', ['app' => 'core']);
-					continue;
-				}
-
-				$enabled = \OC::$server->getConfig()->getAppValue($app, 'enabled', 'no');
-				$info['groups'] = null;
-				if ($enabled === 'yes') {
-					$active = true;
-				} elseif ($enabled === 'no') {
-					$active = false;
-				} else {
-					$active = true;
-					$info['groups'] = $enabled;
-				}
-
-				$info['active'] = $active;
-
-				if ($appManager->isShipped($app)) {
-					$info['internal'] = true;
-					$info['level'] = self::officialApp;
-					$info['removable'] = false;
-				} else {
-					$info['internal'] = false;
-					$info['removable'] = true;
-				}
-
-				if (in_array($app, $supportedApps)) {
-					$info['level'] = self::supportedApp;
-				}
-
-				$appPath = self::getAppPath($app);
-				if ($appPath !== false) {
-					$appIcon = $appPath . '/img/' . $app . '.svg';
-					if (file_exists($appIcon)) {
-						$info['preview'] = $urlGenerator->imagePath($app, $app . '.svg');
-						$info['previewAsIcon'] = true;
-					} else {
-						$appIcon = $appPath . '/img/app.svg';
-						if (file_exists($appIcon)) {
-							$info['preview'] = $urlGenerator->imagePath($app, 'app.svg');
-							$info['previewAsIcon'] = true;
-						}
-					}
-				}
-				// fix documentation
-				if (isset($info['documentation']) && is_array($info['documentation'])) {
-					foreach ($info['documentation'] as $key => $url) {
-						// If it is not an absolute URL we assume it is a key
-						// i.e. admin-ldap will get converted to go.php?to=admin-ldap
-						if (stripos($url, 'https://') !== 0 && stripos($url, 'http://') !== 0) {
-							$url = $urlGenerator->linkToDocs($url);
-						}
-
-						$info['documentation'][$key] = $url;
-					}
-				}
-
-				$info['version'] = $appManager->getAppVersion($app);
-				$appList[] = $info;
-			}
-		}
-
-		return $appList;
-	}
-
-	public static function shouldUpgrade(string $app): bool {
-		$versions = self::getAppVersions();
-		$currentVersion = Server::get(\OCP\App\IAppManager::class)->getAppVersion($app);
-		if ($currentVersion && isset($versions[$app])) {
-			$installedVersion = $versions[$app];
-			if (!version_compare($currentVersion, $installedVersion, '=')) {
-				return true;
-			}
-		}
-		return false;
-	}
-
-	/**
-	 * Adjust the number of version parts of $version1 to match
-	 * the number of version parts of $version2.
-	 *
-	 * @param string $version1 version to adjust
-	 * @param string $version2 version to take the number of parts from
-	 * @return string shortened $version1
-	 */
-	private static function adjustVersionParts(string $version1, string $version2): string {
-		$version1 = explode('.', $version1);
-		$version2 = explode('.', $version2);
-		// reduce $version1 to match the number of parts in $version2
-		while (count($version1) > count($version2)) {
-			array_pop($version1);
-		}
-		// if $version1 does not have enough parts, add some
-		while (count($version1) < count($version2)) {
-			$version1[] = '0';
-		}
-		return implode('.', $version1);
-	}
-
-	/**
-	 * Check whether the current Nextcloud version matches the given
-	 * application's version requirements.
-	 *
-	 * The comparison is made based on the number of parts that the
-	 * app info version has. For example for ownCloud 6.0.3 if the
-	 * app info version is expecting version 6.0, the comparison is
-	 * made on the first two parts of the ownCloud version.
-	 * This means that it's possible to specify "requiremin" => 6
-	 * and "requiremax" => 6 and it will still match ownCloud 6.0.3.
-	 *
-	 * @param string $ocVersion Nextcloud version to check against
-	 * @param array $appInfo app info (from xml)
-	 *
-	 * @return boolean true if compatible, otherwise false
-	 */
-	public static function isAppCompatible(string $ocVersion, array $appInfo, bool $ignoreMax = false): bool {
-		$requireMin = '';
-		$requireMax = '';
-		if (isset($appInfo['dependencies']['nextcloud']['@attributes']['min-version'])) {
-			$requireMin = $appInfo['dependencies']['nextcloud']['@attributes']['min-version'];
-		} elseif (isset($appInfo['dependencies']['owncloud']['@attributes']['min-version'])) {
-			$requireMin = $appInfo['dependencies']['owncloud']['@attributes']['min-version'];
-		} elseif (isset($appInfo['requiremin'])) {
-			$requireMin = $appInfo['requiremin'];
-		} elseif (isset($appInfo['require'])) {
-			$requireMin = $appInfo['require'];
-		}
-
-		if (isset($appInfo['dependencies']['nextcloud']['@attributes']['max-version'])) {
-			$requireMax = $appInfo['dependencies']['nextcloud']['@attributes']['max-version'];
-		} elseif (isset($appInfo['dependencies']['owncloud']['@attributes']['max-version'])) {
-			$requireMax = $appInfo['dependencies']['owncloud']['@attributes']['max-version'];
-		} elseif (isset($appInfo['requiremax'])) {
-			$requireMax = $appInfo['requiremax'];
-		}
-
-		if (!empty($requireMin)
-			&& version_compare(self::adjustVersionParts($ocVersion, $requireMin), $requireMin, '<')
-		) {
-			return false;
-		}
-
-		if (!$ignoreMax && !empty($requireMax)
-			&& version_compare(self::adjustVersionParts($ocVersion, $requireMax), $requireMax, '>')
-		) {
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * get the installed version of all apps
-	 * @deprecated 32.0.0 Use IAppManager::getAppInstalledVersions or IAppConfig::getAppInstalledVersions instead
-	 */
-	public static function getAppVersions(): array {
-		return Server::get(IAppConfig::class)->getAppInstalledVersions();
-	}
-
-	/**
-	 * update the database for the app and call the update script
-	 *
-	 * @param string $appId
-	 * @return bool
-	 */
-	public static function updateApp(string $appId): bool {
-		// for apps distributed with core, we refresh app path in case the downloaded version
-		// have been installed in custom apps and not in the default path
-		$appPath = self::getAppPath($appId, true);
-		if ($appPath === false) {
-			return false;
-		}
-
-		if (is_file($appPath . '/appinfo/database.xml')) {
-			Server::get(LoggerInterface::class)->error('The appinfo/database.xml file is not longer supported. Used in ' . $appId);
-			return false;
-		}
-
-		\OC::$server->getAppManager()->clearAppsCache();
-		$l = \OC::$server->getL10N('core');
-		$appData = Server::get(\OCP\App\IAppManager::class)->getAppInfo($appId, false, $l->getLanguageCode());
-
-		$ignoreMaxApps = \OC::$server->getConfig()->getSystemValue('app_install_overwrite', []);
-		$ignoreMax = in_array($appId, $ignoreMaxApps, true);
-		\OC_App::checkAppDependencies(
-			\OC::$server->getConfig(),
-			$l,
-			$appData,
-			$ignoreMax
-		);
-
-		self::registerAutoloading($appId, $appPath, true);
-		self::executeRepairSteps($appId, $appData['repair-steps']['pre-migration']);
-
-		$ms = new MigrationService($appId, \OC::$server->get(\OC\DB\Connection::class));
-		$ms->migrate();
-
-		self::executeRepairSteps($appId, $appData['repair-steps']['post-migration']);
-		self::setupLiveMigrations($appId, $appData['repair-steps']['live-migration']);
-		// update appversion in app manager
-		\OC::$server->getAppManager()->clearAppsCache();
-		\OC::$server->getAppManager()->getAppVersion($appId, false);
-
-		self::setupBackgroundJobs($appData['background-jobs']);
-
-		//set remote/public handlers
-		if (array_key_exists('ocsid', $appData)) {
-			\OC::$server->getConfig()->setAppValue($appId, 'ocsid', $appData['ocsid']);
-		} elseif (\OC::$server->getConfig()->getAppValue($appId, 'ocsid', null) !== null) {
-			\OC::$server->getConfig()->deleteAppValue($appId, 'ocsid');
-		}
-		foreach ($appData['remote'] as $name => $path) {
-			\OC::$server->getConfig()->setAppValue('core', 'remote_' . $name, $appId . '/' . $path);
-		}
-		foreach ($appData['public'] as $name => $path) {
-			\OC::$server->getConfig()->setAppValue('core', 'public_' . $name, $appId . '/' . $path);
-		}
-
-		self::setAppTypes($appId);
-
-		$version = Server::get(\OCP\App\IAppManager::class)->getAppVersion($appId);
-		\OC::$server->getConfig()->setAppValue($appId, 'installed_version', $version);
-
-		// migrate eventual new config keys in the process
-		/** @psalm-suppress InternalMethod */
-		Server::get(ConfigManager::class)->migrateConfigLexiconKeys($appId);
-
-		\OC::$server->get(IEventDispatcher::class)->dispatchTyped(new AppUpdateEvent($appId));
-		\OC::$server->get(IEventDispatcher::class)->dispatch(ManagerEvent::EVENT_APP_UPDATE, new ManagerEvent(
-			ManagerEvent::EVENT_APP_UPDATE, $appId
-		));
-
-		return true;
-	}
-
-	/**
-	 * @param string $appId
-	 * @param string[] $steps
-	 * @throws \OC\NeedsUpdateException
-	 */
-	public static function executeRepairSteps(string $appId, array $steps) {
-		if (empty($steps)) {
-			return;
-		}
-		// load the app
-		self::loadApp($appId);
-
-		$dispatcher = Server::get(IEventDispatcher::class);
-
-		// load the steps
-		$r = Server::get(Repair::class);
-		foreach ($steps as $step) {
-			try {
-				$r->addStep($step);
-			} catch (Exception $ex) {
-				$dispatcher->dispatchTyped(new RepairErrorEvent($ex->getMessage()));
-				logger('core')->error('Failed to add app migration step ' . $step, ['exception' => $ex]);
-			}
-		}
-		// run the steps
-		$r->run();
-	}
-
-	public static function setupBackgroundJobs(array $jobs) {
-		$queue = \OC::$server->getJobList();
-		foreach ($jobs as $job) {
-			$queue->add($job);
-		}
-	}
-
-	/**
-	 * @param string $appId
-	 * @param string[] $steps
-	 */
-	private static function setupLiveMigrations(string $appId, array $steps) {
-		$queue = \OC::$server->getJobList();
-		foreach ($steps as $step) {
-			$queue->add('OC\Migration\BackgroundRepair', [
-				'app' => $appId,
-				'step' => $step]);
-		}
-	}
-
-	/**
-	 * @param \OCP\IConfig $config
-	 * @param \OCP\IL10N $l
-	 * @param array $info
-	 * @throws \Exception
-	 */
-	public static function checkAppDependencies(\OCP\IConfig $config, \OCP\IL10N $l, array $info, bool $ignoreMax) {
-		$dependencyAnalyzer = new DependencyAnalyzer(new Platform($config), $l);
-		$missing = $dependencyAnalyzer->analyze($info, $ignoreMax);
-		if (!empty($missing)) {
-			$missingMsg = implode(PHP_EOL, $missing);
-			throw new \Exception(
-				$l->t('App "%1$s" cannot be installed because the following dependencies are not fulfilled: %2$s',
-					[$info['name'], $missingMsg]
-				)
-			);
-		}
-	}
+    private static $altLogin = [];
+    private static $alreadyRegistered = [];
+    public const supportedApp = 300;
+    public const officialApp = 200;
+
+    /**
+     * clean the appId
+     *
+     * @psalm-taint-escape file
+     * @psalm-taint-escape include
+     * @psalm-taint-escape html
+     * @psalm-taint-escape has_quotes
+     *
+     * @deprecated 31.0.0 use IAppManager::cleanAppId
+     */
+    public static function cleanAppId(string $app): string {
+        return str_replace(['<', '>', '"', "'", '\0', '/', '\\', '..'], '', $app);
+    }
+
+    /**
+     * Check if an app is loaded
+     *
+     * @param string $app
+     * @return bool
+     * @deprecated 27.0.0 use IAppManager::isAppLoaded
+     */
+    public static function isAppLoaded(string $app): bool {
+        return \OC::$server->get(IAppManager::class)->isAppLoaded($app);
+    }
+
+    /**
+     * loads all apps
+     *
+     * @param string[] $types
+     * @return bool
+     *
+     * This function walks through the Nextcloud directory and loads all apps
+     * it can find. A directory contains an app if the file /appinfo/info.xml
+     * exists.
+     *
+     * if $types is set to non-empty array, only apps of those types will be loaded
+     *
+     * @deprecated 29.0.0 use IAppManager::loadApps instead
+     */
+    public static function loadApps(array $types = []): bool {
+        if (!\OC::$server->getSystemConfig()->getValue('installed', false)) {
+            // This should be done before calling this method so that appmanager can be used
+            return false;
+        }
+        return \OC::$server->get(IAppManager::class)->loadApps($types);
+    }
+
+    /**
+     * load a single app
+     *
+     * @param string $app
+     * @throws Exception
+     * @deprecated 27.0.0 use IAppManager::loadApp
+     */
+    public static function loadApp(string $app): void {
+        \OC::$server->get(IAppManager::class)->loadApp($app);
+    }
+
+    /**
+     * @internal
+     * @param string $app
+     * @param string $path
+     * @param bool $force
+     */
+    public static function registerAutoloading(string $app, string $path, bool $force = false) {
+        $key = $app . '-' . $path;
+        if (!$force && isset(self::$alreadyRegistered[$key])) {
+            return;
+        }
+
+        self::$alreadyRegistered[$key] = true;
+
+        // Register on PSR-4 composer autoloader
+        $appNamespace = \OC\AppFramework\App::buildAppNamespace($app);
+        \OC::$server->registerNamespace($app, $appNamespace);
+
+        if (file_exists($path . '/composer/autoload.php')) {
+            require_once $path . '/composer/autoload.php';
+        } else {
+            \OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
+        }
+
+        // Register Test namespace only when testing
+        if (defined('PHPUNIT_RUN') || defined('CLI_TEST_RUN')) {
+            \OC::$composerAutoloader->addPsr4($appNamespace . '\\Tests\\', $path . '/tests/', true);
+        }
+    }
+
+    /**
+     * check if an app is of a specific type
+     *
+     * @param string $app
+     * @param array $types
+     * @return bool
+     * @deprecated 27.0.0 use IAppManager::isType
+     */
+    public static function isType(string $app, array $types): bool {
+        return \OC::$server->get(IAppManager::class)->isType($app, $types);
+    }
+
+    /**
+     * read app types from info.xml and cache them in the database
+     */
+    public static function setAppTypes(string $app) {
+        $appManager = \OC::$server->getAppManager();
+        $appData = $appManager->getAppInfo($app);
+        if (!is_array($appData)) {
+            return;
+        }
+
+        if (isset($appData['types'])) {
+            $appTypes = implode(',', $appData['types']);
+        } else {
+            $appTypes = '';
+            $appData['types'] = [];
+        }
+
+        $config = \OC::$server->getConfig();
+        $config->setAppValue($app, 'types', $appTypes);
+
+        if ($appManager->hasProtectedAppType($appData['types'])) {
+            $enabled = $config->getAppValue($app, 'enabled', 'yes');
+            if ($enabled !== 'yes' && $enabled !== 'no') {
+                $config->setAppValue($app, 'enabled', 'yes');
+            }
+        }
+    }
+
+    /**
+     * Returns apps enabled for the current user.
+     *
+     * @param bool $forceRefresh whether to refresh the cache
+     * @param bool $all whether to return apps for all users, not only the
+     *                  currently logged in one
+     * @return list<string>
+     */
+    public static function getEnabledApps(bool $forceRefresh = false, bool $all = false): array {
+        if (!\OC::$server->getSystemConfig()->getValue('installed', false)) {
+            return [];
+        }
+        // in incognito mode or when logged out, $user will be false,
+        // which is also the case during an upgrade
+        $appManager = \OC::$server->getAppManager();
+        if ($all) {
+            $user = null;
+        } else {
+            $user = \OC::$server->getUserSession()->getUser();
+        }
+
+        if (is_null($user)) {
+            $apps = $appManager->getEnabledApps();
+        } else {
+            $apps = $appManager->getEnabledAppsForUser($user);
+        }
+        $apps = array_filter($apps, function ($app) {
+            return $app !== 'files';//we add this manually
+        });
+        sort($apps);
+        array_unshift($apps, 'files');
+        return $apps;
+    }
+
+    /**
+     * enables an app
+     *
+     * @param string $appId
+     * @param array $groups (optional) when set, only these groups will have access to the app
+     * @throws \Exception
+     * @return void
+     *
+     * This function set an app as enabled in appconfig.
+     */
+    public function enable(string $appId,
+        array $groups = []) {
+        // Check if app is already downloaded
+        /** @var Installer $installer */
+        $installer = Server::get(Installer::class);
+        $isDownloaded = $installer->isDownloaded($appId);
+
+        if (!$isDownloaded) {
+            $installer->downloadApp($appId);
+        }
+
+        $installer->installApp($appId);
+
+        $appManager = \OC::$server->getAppManager();
+        if ($groups !== []) {
+            $groupManager = \OC::$server->getGroupManager();
+            $groupsList = [];
+            foreach ($groups as $group) {
+                $groupItem = $groupManager->get($group);
+                if ($groupItem instanceof \OCP\IGroup) {
+                    $groupsList[] = $groupManager->get($group);
+                }
+            }
+            $appManager->enableAppForGroups($appId, $groupsList);
+        } else {
+            $appManager->enableApp($appId);
+        }
+    }
+
+    /**
+     * Get the path where to install apps
+     */
+    public static function getInstallPath(): ?string {
+        foreach (OC::$APPSROOTS as $dir) {
+            if (isset($dir['writable']) && $dir['writable'] === true) {
+                return $dir['path'];
+            }
+        }
+
+        Server::get(LoggerInterface::class)->error('No application directories are marked as writable.', ['app' => 'core']);
+        return null;
+    }
+
+
+    /**
+     * Find the apps root for an app id.
+     *
+     * If multiple copies are found, the apps root the latest version is returned.
+     *
+     * @param string $appId
+     * @param bool $ignoreCache ignore cache and rebuild it
+     * @return false|array{path: string, url: string} the apps root shape
+     */
+    public static function findAppInDirectories(string $appId, bool $ignoreCache = false) {
+        $sanitizedAppId = self::cleanAppId($appId);
+        if ($sanitizedAppId !== $appId) {
+            return false;
+        }
+        static $app_dir = [];
+
+        if (isset($app_dir[$appId]) && !$ignoreCache) {
+            return $app_dir[$appId];
+        }
+
+        $possibleApps = [];
+        foreach (OC::$APPSROOTS as $dir) {
+            if (file_exists($dir['path'] . '/' . $appId)) {
+                $possibleApps[] = $dir;
+            }
+        }
+
+        if (empty($possibleApps)) {
+            return false;
+        } elseif (count($possibleApps) === 1) {
+            $dir = array_shift($possibleApps);
+            $app_dir[$appId] = $dir;
+            return $dir;
+        } else {
+            $versionToLoad = [];
+            foreach ($possibleApps as $possibleApp) {
+                $version = self::getAppVersionByPath($possibleApp['path'] . '/' . $appId);
+                if (empty($versionToLoad) || version_compare($version, $versionToLoad['version'], '>')) {
+                    $versionToLoad = [
+                        'dir' => $possibleApp,
+                        'version' => $version,
+                    ];
+                }
+            }
+            $app_dir[$appId] = $versionToLoad['dir'];
+            return $versionToLoad['dir'];
+            //TODO - write test
+        }
+    }
+
+    /**
+     * Get the directory for the given app.
+     * If the app is defined in multiple directories, the first one is taken. (false if not found)
+     *
+     * @psalm-taint-specialize
+     *
+     * @param string $appId
+     * @param bool $refreshAppPath should be set to true only during install/upgrade
+     * @return string|false
+     * @deprecated 11.0.0 use Server::get(IAppManager)->getAppPath()
+     */
+    public static function getAppPath(string $appId, bool $refreshAppPath = false) {
+        $appId = self::cleanAppId($appId);
+        if ($appId === '') {
+            return false;
+        } elseif ($appId === 'core') {
+            return __DIR__ . '/../../../core';
+        }
+
+        if (($dir = self::findAppInDirectories($appId, $refreshAppPath)) != false) {
+            return $dir['path'] . '/' . $appId;
+        }
+        return false;
+    }
+
+    /**
+     * Get the path for the given app on the access
+     * If the app is defined in multiple directories, the first one is taken. (false if not found)
+     *
+     * @param string $appId
+     * @return string|false
+     * @deprecated 18.0.0 use \OC::$server->getAppManager()->getAppWebPath()
+     */
+    public static function getAppWebPath(string $appId) {
+        if (($dir = self::findAppInDirectories($appId)) != false) {
+            return OC::$WEBROOT . $dir['url'] . '/' . $appId;
+        }
+        return false;
+    }
+
+    /**
+     * get app's version based on it's path
+     *
+     * @param string $path
+     * @return string
+     */
+    public static function getAppVersionByPath(string $path): string {
+        $infoFile = $path . '/appinfo/info.xml';
+        $appData = Server::get(IAppManager::class)->getAppInfoByPath($infoFile);
+        return $appData['version'] ?? '';
+    }
+
+    /**
+     * get the id of loaded app
+     *
+     * @return string
+     */
+    public static function getCurrentApp(): string {
+        if (\OC::$CLI) {
+            return '';
+        }
+
+        $request = \OC::$server->getRequest();
+        $script = substr($request->getScriptName(), strlen(OC::$WEBROOT) + 1);
+        $topFolder = substr($script, 0, strpos($script, '/') ?: 0);
+        if (empty($topFolder)) {
+            try {
+                $path_info = $request->getPathInfo();
+            } catch (Exception $e) {
+                // Can happen from unit tests because the script name is `./vendor/bin/phpunit` or something a like then.
+                \OC::$server->get(LoggerInterface::class)->error('Failed to detect current app from script path', ['exception' => $e]);
+                return '';
+            }
+            if ($path_info) {
+                $topFolder = substr($path_info, 1, strpos($path_info, '/', 1) - 1);
+            }
+        }
+        if ($topFolder == 'apps') {
+            $length = strlen($topFolder);
+            return substr($script, $length + 1, strpos($script, '/', $length + 1) - $length - 1) ?: '';
+        } else {
+            return $topFolder;
+        }
+    }
+
+    /**
+     * @param array $entry
+     * @deprecated 20.0.0 Please register your alternative login option using the registerAlternativeLogin() on the RegistrationContext in your Application class implementing the OCP\Authentication\IAlternativeLogin interface
+     */
+    public static function registerLogIn(array $entry) {
+        Server::get(LoggerInterface::class)->debug('OC_App::registerLogIn() is deprecated, please register your alternative login option using the registerAlternativeLogin() on the RegistrationContext in your Application class implementing the OCP\Authentication\IAlternativeLogin interface');
+        self::$altLogin[] = $entry;
+    }
+
+    /**
+     * @return array
+     */
+    public static function getAlternativeLogIns(): array {
+        /** @var Coordinator $bootstrapCoordinator */
+        $bootstrapCoordinator = Server::get(Coordinator::class);
+
+        foreach ($bootstrapCoordinator->getRegistrationContext()->getAlternativeLogins() as $registration) {
+            if (!in_array(IAlternativeLogin::class, class_implements($registration->getService()), true)) {
+                Server::get(LoggerInterface::class)->error('Alternative login option {option} does not implement {interface} and is therefore ignored.', [
+                    'option' => $registration->getService(),
+                    'interface' => IAlternativeLogin::class,
+                    'app' => $registration->getAppId(),
+                ]);
+                continue;
+            }
+
+            try {
+                /** @var IAlternativeLogin $provider */
+                $provider = Server::get($registration->getService());
+            } catch (ContainerExceptionInterface $e) {
+                Server::get(LoggerInterface::class)->error('Alternative login option {option} can not be initialized.',
+                    [
+                        'exception' => $e,
+                        'option' => $registration->getService(),
+                        'app' => $registration->getAppId(),
+                    ]);
+            }
+
+            try {
+                $provider->load();
+
+                self::$altLogin[] = [
+                    'name' => $provider->getLabel(),
+                    'href' => $provider->getLink(),
+                    'class' => $provider->getClass(),
+                ];
+            } catch (Throwable $e) {
+                Server::get(LoggerInterface::class)->error('Alternative login option {option} had an error while loading.',
+                    [
+                        'exception' => $e,
+                        'option' => $registration->getService(),
+                        'app' => $registration->getAppId(),
+                    ]);
+            }
+        }
+
+        return self::$altLogin;
+    }
+
+    /**
+     * get a list of all apps in the apps folder
+     *
+     * @return string[] an array of app names (string IDs)
+     * @deprecated 31.0.0 Use IAppManager::getAllAppsInAppsFolders instead
+     */
+    public static function getAllApps(): array {
+        return Server::get(IAppManager::class)->getAllAppsInAppsFolders();
+    }
+
+    /**
+     * List all supported apps
+     *
+     * @deprecated 32.0.0 Use \OCP\Support\Subscription\IRegistry::delegateGetSupportedApps instead
+     */
+    public function getSupportedApps(): array {
+        $subscriptionRegistry = Server::get(\OCP\Support\Subscription\IRegistry::class);
+        $supportedApps = $subscriptionRegistry->delegateGetSupportedApps();
+        return $supportedApps;
+    }
+
+    /**
+     * List all apps, this is used in apps.php
+     *
+     * @return array
+     */
+    public function listAllApps(): array {
+        $appManager = \OC::$server->getAppManager();
+
+        $installedApps = $appManager->getAllAppsInAppsFolders();
+        //we don't want to show configuration for these
+        $blacklist = $appManager->getAlwaysEnabledApps();
+        $appList = [];
+        $langCode = \OC::$server->getL10N('core')->getLanguageCode();
+        $urlGenerator = \OC::$server->getURLGenerator();
+        $supportedApps = $this->getSupportedApps();
+
+        foreach ($installedApps as $app) {
+            if (!in_array($app, $blacklist)) {
+                $info = $appManager->getAppInfo($app, false, $langCode);
+                if (!is_array($info)) {
+                    Server::get(LoggerInterface::class)->error('Could not read app info file for app "' . $app . '"', ['app' => 'core']);
+                    continue;
+                }
+
+                if (!isset($info['name'])) {
+                    Server::get(LoggerInterface::class)->error('App id "' . $app . '" has no name in appinfo', ['app' => 'core']);
+                    continue;
+                }
+
+                $enabled = \OC::$server->getConfig()->getAppValue($app, 'enabled', 'no');
+                $info['groups'] = null;
+                if ($enabled === 'yes') {
+                    $active = true;
+                } elseif ($enabled === 'no') {
+                    $active = false;
+                } else {
+                    $active = true;
+                    $info['groups'] = $enabled;
+                }
+
+                $info['active'] = $active;
+
+                if ($appManager->isShipped($app)) {
+                    $info['internal'] = true;
+                    $info['level'] = self::officialApp;
+                    $info['removable'] = false;
+                } else {
+                    $info['internal'] = false;
+                    $info['removable'] = true;
+                }
+
+                if (in_array($app, $supportedApps)) {
+                    $info['level'] = self::supportedApp;
+                }
+
+                $appPath = self::getAppPath($app);
+                if ($appPath !== false) {
+                    $appIcon = $appPath . '/img/' . $app . '.svg';
+                    if (file_exists($appIcon)) {
+                        $info['preview'] = $urlGenerator->imagePath($app, $app . '.svg');
+                        $info['previewAsIcon'] = true;
+                    } else {
+                        $appIcon = $appPath . '/img/app.svg';
+                        if (file_exists($appIcon)) {
+                            $info['preview'] = $urlGenerator->imagePath($app, 'app.svg');
+                            $info['previewAsIcon'] = true;
+                        }
+                    }
+                }
+                // fix documentation
+                if (isset($info['documentation']) && is_array($info['documentation'])) {
+                    foreach ($info['documentation'] as $key => $url) {
+                        // If it is not an absolute URL we assume it is a key
+                        // i.e. admin-ldap will get converted to go.php?to=admin-ldap
+                        if (stripos($url, 'https://') !== 0 && stripos($url, 'http://') !== 0) {
+                            $url = $urlGenerator->linkToDocs($url);
+                        }
+
+                        $info['documentation'][$key] = $url;
+                    }
+                }
+
+                $info['version'] = $appManager->getAppVersion($app);
+                $appList[] = $info;
+            }
+        }
+
+        return $appList;
+    }
+
+    public static function shouldUpgrade(string $app): bool {
+        $versions = self::getAppVersions();
+        $currentVersion = Server::get(\OCP\App\IAppManager::class)->getAppVersion($app);
+        if ($currentVersion && isset($versions[$app])) {
+            $installedVersion = $versions[$app];
+            if (!version_compare($currentVersion, $installedVersion, '=')) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    /**
+     * Adjust the number of version parts of $version1 to match
+     * the number of version parts of $version2.
+     *
+     * @param string $version1 version to adjust
+     * @param string $version2 version to take the number of parts from
+     * @return string shortened $version1
+     */
+    private static function adjustVersionParts(string $version1, string $version2): string {
+        $version1 = explode('.', $version1);
+        $version2 = explode('.', $version2);
+        // reduce $version1 to match the number of parts in $version2
+        while (count($version1) > count($version2)) {
+            array_pop($version1);
+        }
+        // if $version1 does not have enough parts, add some
+        while (count($version1) < count($version2)) {
+            $version1[] = '0';
+        }
+        return implode('.', $version1);
+    }
+
+    /**
+     * Check whether the current Nextcloud version matches the given
+     * application's version requirements.
+     *
+     * The comparison is made based on the number of parts that the
+     * app info version has. For example for ownCloud 6.0.3 if the
+     * app info version is expecting version 6.0, the comparison is
+     * made on the first two parts of the ownCloud version.
+     * This means that it's possible to specify "requiremin" => 6
+     * and "requiremax" => 6 and it will still match ownCloud 6.0.3.
+     *
+     * @param string $ocVersion Nextcloud version to check against
+     * @param array $appInfo app info (from xml)
+     *
+     * @return boolean true if compatible, otherwise false
+     */
+    public static function isAppCompatible(string $ocVersion, array $appInfo, bool $ignoreMax = false): bool {
+        $requireMin = '';
+        $requireMax = '';
+        if (isset($appInfo['dependencies']['nextcloud']['@attributes']['min-version'])) {
+            $requireMin = $appInfo['dependencies']['nextcloud']['@attributes']['min-version'];
+        } elseif (isset($appInfo['dependencies']['owncloud']['@attributes']['min-version'])) {
+            $requireMin = $appInfo['dependencies']['owncloud']['@attributes']['min-version'];
+        } elseif (isset($appInfo['requiremin'])) {
+            $requireMin = $appInfo['requiremin'];
+        } elseif (isset($appInfo['require'])) {
+            $requireMin = $appInfo['require'];
+        }
+
+        if (isset($appInfo['dependencies']['nextcloud']['@attributes']['max-version'])) {
+            $requireMax = $appInfo['dependencies']['nextcloud']['@attributes']['max-version'];
+        } elseif (isset($appInfo['dependencies']['owncloud']['@attributes']['max-version'])) {
+            $requireMax = $appInfo['dependencies']['owncloud']['@attributes']['max-version'];
+        } elseif (isset($appInfo['requiremax'])) {
+            $requireMax = $appInfo['requiremax'];
+        }
+
+        if (!empty($requireMin)
+            && version_compare(self::adjustVersionParts($ocVersion, $requireMin), $requireMin, '<')
+        ) {
+            return false;
+        }
+
+        if (!$ignoreMax && !empty($requireMax)
+            && version_compare(self::adjustVersionParts($ocVersion, $requireMax), $requireMax, '>')
+        ) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * get the installed version of all apps
+     * @deprecated 32.0.0 Use IAppManager::getAppInstalledVersions or IAppConfig::getAppInstalledVersions instead
+     */
+    public static function getAppVersions(): array {
+        return Server::get(IAppConfig::class)->getAppInstalledVersions();
+    }
+
+    /**
+     * update the database for the app and call the update script
+     *
+     * @param string $appId
+     * @return bool
+     */
+    public static function updateApp(string $appId): bool {
+        // for apps distributed with core, we refresh app path in case the downloaded version
+        // have been installed in custom apps and not in the default path
+        $appPath = self::getAppPath($appId, true);
+        if ($appPath === false) {
+            return false;
+        }
+
+        if (is_file($appPath . '/appinfo/database.xml')) {
+            Server::get(LoggerInterface::class)->error('The appinfo/database.xml file is not longer supported. Used in ' . $appId);
+            return false;
+        }
+
+        \OC::$server->getAppManager()->clearAppsCache();
+        $l = \OC::$server->getL10N('core');
+        $appData = Server::get(\OCP\App\IAppManager::class)->getAppInfo($appId, false, $l->getLanguageCode());
+
+        $ignoreMaxApps = \OC::$server->getConfig()->getSystemValue('app_install_overwrite', []);
+        $ignoreMax = in_array($appId, $ignoreMaxApps, true);
+        \OC_App::checkAppDependencies(
+            \OC::$server->getConfig(),
+            $l,
+            $appData,
+            $ignoreMax
+        );
+
+        self::registerAutoloading($appId, $appPath, true);
+        self::executeRepairSteps($appId, $appData['repair-steps']['pre-migration']);
+
+        $ms = new MigrationService($appId, \OC::$server->get(\OC\DB\Connection::class));
+        $ms->migrate();
+
+        self::executeRepairSteps($appId, $appData['repair-steps']['post-migration']);
+        self::setupLiveMigrations($appId, $appData['repair-steps']['live-migration']);
+        // update appversion in app manager
+        \OC::$server->getAppManager()->clearAppsCache();
+        \OC::$server->getAppManager()->getAppVersion($appId, false);
+
+        self::setupBackgroundJobs($appData['background-jobs']);
+
+        //set remote/public handlers
+        if (array_key_exists('ocsid', $appData)) {
+            \OC::$server->getConfig()->setAppValue($appId, 'ocsid', $appData['ocsid']);
+        } elseif (\OC::$server->getConfig()->getAppValue($appId, 'ocsid', null) !== null) {
+            \OC::$server->getConfig()->deleteAppValue($appId, 'ocsid');
+        }
+        foreach ($appData['remote'] as $name => $path) {
+            \OC::$server->getConfig()->setAppValue('core', 'remote_' . $name, $appId . '/' . $path);
+        }
+        foreach ($appData['public'] as $name => $path) {
+            \OC::$server->getConfig()->setAppValue('core', 'public_' . $name, $appId . '/' . $path);
+        }
+
+        self::setAppTypes($appId);
+
+        $version = Server::get(\OCP\App\IAppManager::class)->getAppVersion($appId);
+        \OC::$server->getConfig()->setAppValue($appId, 'installed_version', $version);
+
+        // migrate eventual new config keys in the process
+        /** @psalm-suppress InternalMethod */
+        Server::get(ConfigManager::class)->migrateConfigLexiconKeys($appId);
+
+        \OC::$server->get(IEventDispatcher::class)->dispatchTyped(new AppUpdateEvent($appId));
+        \OC::$server->get(IEventDispatcher::class)->dispatch(ManagerEvent::EVENT_APP_UPDATE, new ManagerEvent(
+            ManagerEvent::EVENT_APP_UPDATE, $appId
+        ));
+
+        return true;
+    }
+
+    /**
+     * @param string $appId
+     * @param string[] $steps
+     * @throws \OC\NeedsUpdateException
+     */
+    public static function executeRepairSteps(string $appId, array $steps) {
+        if (empty($steps)) {
+            return;
+        }
+        // load the app
+        self::loadApp($appId);
+
+        $dispatcher = Server::get(IEventDispatcher::class);
+
+        // load the steps
+        $r = Server::get(Repair::class);
+        foreach ($steps as $step) {
+            try {
+                $r->addStep($step);
+            } catch (Exception $ex) {
+                $dispatcher->dispatchTyped(new RepairErrorEvent($ex->getMessage()));
+                logger('core')->error('Failed to add app migration step ' . $step, ['exception' => $ex]);
+            }
+        }
+        // run the steps
+        $r->run();
+    }
+
+    public static function setupBackgroundJobs(array $jobs) {
+        $queue = \OC::$server->getJobList();
+        foreach ($jobs as $job) {
+            $queue->add($job);
+        }
+    }
+
+    /**
+     * @param string $appId
+     * @param string[] $steps
+     */
+    private static function setupLiveMigrations(string $appId, array $steps) {
+        $queue = \OC::$server->getJobList();
+        foreach ($steps as $step) {
+            $queue->add('OC\Migration\BackgroundRepair', [
+                'app' => $appId,
+                'step' => $step]);
+        }
+    }
+
+    /**
+     * @param \OCP\IConfig $config
+     * @param \OCP\IL10N $l
+     * @param array $info
+     * @throws \Exception
+     */
+    public static function checkAppDependencies(\OCP\IConfig $config, \OCP\IL10N $l, array $info, bool $ignoreMax) {
+        $dependencyAnalyzer = new DependencyAnalyzer(new Platform($config), $l);
+        $missing = $dependencyAnalyzer->analyze($info, $ignoreMax);
+        if (!empty($missing)) {
+            $missingMsg = implode(PHP_EOL, $missing);
+            throw new \Exception(
+                $l->t('App "%1$s" cannot be installed because the following dependencies are not fulfilled: %2$s',
+                    [$info['name'], $missingMsg]
+                )
+            );
+        }
+    }
 }

Spacing +23 added lines, -23 removed lines

@@ -101,7 +101,7 @@ 
 	 * @param bool $force
 	 */
 	public static function registerAutoloading(string $app, string $path, bool $force = false) {
-		$key = $app . '-' . $path;
+		$key = $app.'-'.$path;
 		if (!$force && isset(self::$alreadyRegistered[$key])) {
 			return;
 		}
@@ -112,15 +112,15 @@ 
 		$appNamespace = \OC\AppFramework\App::buildAppNamespace($app);
 		\OC::$server->registerNamespace($app, $appNamespace);
 
-		if (file_exists($path . '/composer/autoload.php')) {
-			require_once $path . '/composer/autoload.php';
+		if (file_exists($path.'/composer/autoload.php')) {
+			require_once $path.'/composer/autoload.php';
 		} else {
-			\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
+			\OC::$composerAutoloader->addPsr4($appNamespace.'\\', $path.'/lib/', true);
 		}
 
 		// Register Test namespace only when testing
 		if (defined('PHPUNIT_RUN') || defined('CLI_TEST_RUN')) {
-			\OC::$composerAutoloader->addPsr4($appNamespace . '\\Tests\\', $path . '/tests/', true);
+			\OC::$composerAutoloader->addPsr4($appNamespace.'\\Tests\\', $path.'/tests/', true);
 		}
 	}
 
@@ -190,8 +190,8 @@ 
 		} else {
 			$apps = $appManager->getEnabledAppsForUser($user);
 		}
-		$apps = array_filter($apps, function ($app) {
-			return $app !== 'files';//we add this manually
+		$apps = array_filter($apps, function($app) {
+			return $app !== 'files'; //we add this manually
 		});
 		sort($apps);
 		array_unshift($apps, 'files');
@@ -274,7 +274,7 @@ 
 
 		$possibleApps = [];
 		foreach (OC::$APPSROOTS as $dir) {
-			if (file_exists($dir['path'] . '/' . $appId)) {
+			if (file_exists($dir['path'].'/'.$appId)) {
 				$possibleApps[] = $dir;
 			}
 		}
@@ -288,7 +288,7 @@ 
 		} else {
 			$versionToLoad = [];
 			foreach ($possibleApps as $possibleApp) {
-				$version = self::getAppVersionByPath($possibleApp['path'] . '/' . $appId);
+				$version = self::getAppVersionByPath($possibleApp['path'].'/'.$appId);
 				if (empty($versionToLoad) || version_compare($version, $versionToLoad['version'], '>')) {
 					$versionToLoad = [
 						'dir' => $possibleApp,
@@ -318,11 +318,11 @@ 
 		if ($appId === '') {
 			return false;
 		} elseif ($appId === 'core') {
-			return __DIR__ . '/../../../core';
+			return __DIR__.'/../../../core';
 		}
 
 		if (($dir = self::findAppInDirectories($appId, $refreshAppPath)) != false) {
-			return $dir['path'] . '/' . $appId;
+			return $dir['path'].'/'.$appId;
 		}
 		return false;
 	}
@@ -337,7 +337,7 @@ 
 	 */
 	public static function getAppWebPath(string $appId) {
 		if (($dir = self::findAppInDirectories($appId)) != false) {
-			return OC::$WEBROOT . $dir['url'] . '/' . $appId;
+			return OC::$WEBROOT.$dir['url'].'/'.$appId;
 		}
 		return false;
 	}
@@ -349,7 +349,7 @@ 
 	 * @return string
 	 */
 	public static function getAppVersionByPath(string $path): string {
-		$infoFile = $path . '/appinfo/info.xml';
+		$infoFile = $path.'/appinfo/info.xml';
 		$appData = Server::get(IAppManager::class)->getAppInfoByPath($infoFile);
 		return $appData['version'] ?? '';
 	}
@@ -487,12 +487,12 @@ 
 			if (!in_array($app, $blacklist)) {
 				$info = $appManager->getAppInfo($app, false, $langCode);
 				if (!is_array($info)) {
-					Server::get(LoggerInterface::class)->error('Could not read app info file for app "' . $app . '"', ['app' => 'core']);
+					Server::get(LoggerInterface::class)->error('Could not read app info file for app "'.$app.'"', ['app' => 'core']);
 					continue;
 				}
 
 				if (!isset($info['name'])) {
-					Server::get(LoggerInterface::class)->error('App id "' . $app . '" has no name in appinfo', ['app' => 'core']);
+					Server::get(LoggerInterface::class)->error('App id "'.$app.'" has no name in appinfo', ['app' => 'core']);
 					continue;
 				}
 
@@ -524,12 +524,12 @@ 
 
 				$appPath = self::getAppPath($app);
 				if ($appPath !== false) {
-					$appIcon = $appPath . '/img/' . $app . '.svg';
+					$appIcon = $appPath.'/img/'.$app.'.svg';
 					if (file_exists($appIcon)) {
-						$info['preview'] = $urlGenerator->imagePath($app, $app . '.svg');
+						$info['preview'] = $urlGenerator->imagePath($app, $app.'.svg');
 						$info['previewAsIcon'] = true;
 					} else {
-						$appIcon = $appPath . '/img/app.svg';
+						$appIcon = $appPath.'/img/app.svg';
 						if (file_exists($appIcon)) {
 							$info['preview'] = $urlGenerator->imagePath($app, 'app.svg');
 							$info['previewAsIcon'] = true;
@@ -665,8 +665,8 @@ 
 			return false;
 		}
 
-		if (is_file($appPath . '/appinfo/database.xml')) {
-			Server::get(LoggerInterface::class)->error('The appinfo/database.xml file is not longer supported. Used in ' . $appId);
+		if (is_file($appPath.'/appinfo/database.xml')) {
+			Server::get(LoggerInterface::class)->error('The appinfo/database.xml file is not longer supported. Used in '.$appId);
 			return false;
 		}
 
@@ -704,10 +704,10 @@ 
 			\OC::$server->getConfig()->deleteAppValue($appId, 'ocsid');
 		}
 		foreach ($appData['remote'] as $name => $path) {
-			\OC::$server->getConfig()->setAppValue('core', 'remote_' . $name, $appId . '/' . $path);
+			\OC::$server->getConfig()->setAppValue('core', 'remote_'.$name, $appId.'/'.$path);
 		}
 		foreach ($appData['public'] as $name => $path) {
-			\OC::$server->getConfig()->setAppValue('core', 'public_' . $name, $appId . '/' . $path);
+			\OC::$server->getConfig()->setAppValue('core', 'public_'.$name, $appId.'/'.$path);
 		}
 
 		self::setAppTypes($appId);
@@ -748,7 +748,7 @@ 
 				$r->addStep($step);
 			} catch (Exception $ex) {
 				$dispatcher->dispatchTyped(new RepairErrorEvent($ex->getMessage()));
-				logger('core')->error('Failed to add app migration step ' . $step, ['exception' => $ex]);
+				logger('core')->error('Failed to add app migration step '.$step, ['exception' => $ex]);
 			}
 		}
 		// run the steps