Inspection of "Merge pull request #16683 from nextcloud/fix/audit..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6b1186...4e3ada )

by Roeland

created 2019-08-08 06:20 UTC

Status

Indentation +99 added lines, -99 removed lines patch added patch discarded remove patch

@@ -35,108 +35,108 @@
 block discarded – undo
  * @package OCA\AdminAudit\Actions
  */
 class UserManagement extends Action {
-	/**
-	 * Log creation of users
-	 *
-	 * @param array $params
-	 */
-	public function create(array $params) {
-		$this->log(
-			'User created: "%s"',
-			$params,
-			[
-				'uid',
-			]
-		);
-	}
+    /**
+     * Log creation of users
+     *
+     * @param array $params
+     */
+    public function create(array $params) {
+        $this->log(
+            'User created: "%s"',
+            $params,
+            [
+                'uid',
+            ]
+        );
+    }
 
-	/**
-	 * Log assignments of users (typically user backends)
-	 *
-	 * @param string $uid
-	 */
-	public function assign(string $uid) {
-		$this->log(
-		'UserID assigned: "%s"',
-			[ 'uid' => $uid ],
-			[ 'uid' ]
-		);
-	}
+    /**
+     * Log assignments of users (typically user backends)
+     *
+     * @param string $uid
+     */
+    public function assign(string $uid) {
+        $this->log(
+        'UserID assigned: "%s"',
+            [ 'uid' => $uid ],
+            [ 'uid' ]
+        );
+    }
 
-	/**
-	 * Log deletion of users
-	 *
-	 * @param array $params
-	 */
-	public function delete(array $params) {
-		$this->log(
-			'User deleted: "%s"',
-			$params,
-			[
-				'uid',
-			]
-		);
-	}
+    /**
+     * Log deletion of users
+     *
+     * @param array $params
+     */
+    public function delete(array $params) {
+        $this->log(
+            'User deleted: "%s"',
+            $params,
+            [
+                'uid',
+            ]
+        );
+    }
 
-	/**
-	 * Log unassignments of users (typically user backends, no data removed)
-	 *
-	 * @param string $uid
-	 */
-	public function unassign(string $uid) {
-		$this->log(
-			'UserID unassigned: "%s"',
-			[ 'uid' => $uid ],
-			[ 'uid' ]
-		);
-	}
+    /**
+     * Log unassignments of users (typically user backends, no data removed)
+     *
+     * @param string $uid
+     */
+    public function unassign(string $uid) {
+        $this->log(
+            'UserID unassigned: "%s"',
+            [ 'uid' => $uid ],
+            [ 'uid' ]
+        );
+    }
 
-	/**
-	 * Log enabling of users
-	 *
-	 * @param array $params
-	 */
-	public function change(array $params) {
-		switch($params['feature']) {
-			case 'enabled':
-				$this->log(
-					$params['value'] === true
-						? 'User enabled: "%s"'
-						: 'User disabled: "%s"',
-					['user' => $params['user']->getUID()],
-					[
-						'user',
-					]
-				);
-				break;
-			case 'eMailAddress':
-				$this->log(
-					'Email address changed for user %s',
-					['user' => $params['user']->getUID()],
-					[
-						'user',
-					]
-				);
-				break;
-		}
-	}
+    /**
+     * Log enabling of users
+     *
+     * @param array $params
+     */
+    public function change(array $params) {
+        switch($params['feature']) {
+            case 'enabled':
+                $this->log(
+                    $params['value'] === true
+                        ? 'User enabled: "%s"'
+                        : 'User disabled: "%s"',
+                    ['user' => $params['user']->getUID()],
+                    [
+                        'user',
+                    ]
+                );
+                break;
+            case 'eMailAddress':
+                $this->log(
+                    'Email address changed for user %s',
+                    ['user' => $params['user']->getUID()],
+                    [
+                        'user',
+                    ]
+                );
+                break;
+        }
+    }
 
-	/**
-	 * Logs changing of the user scope
-	 *
-	 * @param IUser $user
-	 */
-	public function setPassword(IUser $user) {
-		if($user->getBackendClassName() === 'Database') {
-			$this->log(
-				'Password of user "%s" has been changed',
-				[
-					'user' => $user->getUID(),
-				],
-				[
-					'user',
-				]
-			);
-		}
-	}
+    /**
+     * Logs changing of the user scope
+     *
+     * @param IUser $user
+     */
+    public function setPassword(IUser $user) {
+        if($user->getBackendClassName() === 'Database') {
+            $this->log(
+                'Password of user "%s" has been changed',
+                [
+                    'user' => $user->getUID(),
+                ],
+                [
+                    'user',
+                ]
+            );
+        }
+    }
 }

Please login to merge, or discard this patch.

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -58,8 +58,8 @@  discard block
 block discarded – undo
 	public function assign(string $uid) {
 		$this->log(
 		'UserID assigned: "%s"',
-			[ 'uid' => $uid ],
-			[ 'uid' ]
+			['uid' => $uid],
+			['uid']
 		);
 	}
 
@@ -86,8 +86,8 @@  discard block
 block discarded – undo
 	public function unassign(string $uid) {
 		$this->log(
 			'UserID unassigned: "%s"',
-			[ 'uid' => $uid ],
-			[ 'uid' ]
+			['uid' => $uid],
+			['uid']
 		);
 	}
 
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
 	 * @param array $params
 	 */
 	public function change(array $params) {
-		switch($params['feature']) {
+		switch ($params['feature']) {
 			case 'enabled':
 				$this->log(
 					$params['value'] === true
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
 	 * @param IUser $user
 	 */
 	public function setPassword(IUser $user) {
-		if($user->getBackendClassName() === 'Database') {
+		if ($user->getBackendClassName() === 'Database') {
 			$this->log(
 				'Password of user "%s" has been changed',
 				[

Please login to merge, or discard this patch.

		@@ -58,8 +58,8 @@ discard block
		block discarded – undo
58	58	public function assign(string $uid) {
59	59	$this->log(
60	60	'UserID assigned: "%s"',
61		- [ 'uid' => $uid ],
62		- [ 'uid' ]
	61	+ ['uid' => $uid],
	62	+ ['uid']
63	63	);
64	64	}
65	65
		@@ -86,8 +86,8 @@ discard block
		block discarded – undo
86	86	public function unassign(string $uid) {
87	87	$this->log(
88	88	'UserID unassigned: "%s"',
89		- [ 'uid' => $uid ],
90		- [ 'uid' ]
	89	+ ['uid' => $uid],
	90	+ ['uid']
91	91	);
92	92	}
93	93
		@@ -97,7 +97,7 @@ discard block
		block discarded – undo
97	97	* @param array $params
98	98	*/
99	99	public function change(array $params) {
100		- switch($params['feature']) {
	100	+ switch ($params['feature']) {
101	101	case 'enabled':
102	102	$this->log(
103	103	$params['value'] === true
		@@ -127,7 +127,7 @@ discard block
		block discarded – undo
127	127	* @param IUser $user
128	128	*/
129	129	public function setPassword(IUser $user) {
130		- if($user->getBackendClassName() === 'Database') {
	130	+ if ($user->getBackendClassName() === 'Database') {
131	131	$this->log(
132	132	'Password of user "%s" has been changed',
133	133	[

		@@ -35,108 +35,108 @@
		block discarded – undo
35	35	* @package OCA\AdminAudit\Actions
36	36	*/
37	37	class UserManagement extends Action {
38		- /**
39		- * Log creation of users
40		- *
41		- * @param array $params
42		- */
43		- public function create(array $params) {
44		- $this->log(
45		- 'User created: "%s"',
46		- $params,
47		- [
48		- 'uid',
49		- ]
50		- );
51		- }
	38	+ /**
	39	+ * Log creation of users
	40	+ *
	41	+ * @param array $params
	42	+ */
	43	+ public function create(array $params) {
	44	+ $this->log(
	45	+ 'User created: "%s"',
	46	+ $params,
	47	+ [
	48	+ 'uid',
	49	+ ]
	50	+ );
	51	+ }
52	52
53		- /**
54		- * Log assignments of users (typically user backends)
55		- *
56		- * @param string $uid
57		- */
58		- public function assign(string $uid) {
59		- $this->log(
60		- 'UserID assigned: "%s"',
61		- [ 'uid' => $uid ],
62		- [ 'uid' ]
63		- );
64		- }
	53	+ /**
	54	+ * Log assignments of users (typically user backends)
	55	+ *
	56	+ * @param string $uid
	57	+ */
	58	+ public function assign(string $uid) {
	59	+ $this->log(
	60	+ 'UserID assigned: "%s"',
	61	+ [ 'uid' => $uid ],
	62	+ [ 'uid' ]
	63	+ );
	64	+ }
65	65
66		- /**
67		- * Log deletion of users
68		- *
69		- * @param array $params
70		- */
71		- public function delete(array $params) {
72		- $this->log(
73		- 'User deleted: "%s"',
74		- $params,
75		- [
76		- 'uid',
77		- ]
78		- );
79		- }
	66	+ /**
	67	+ * Log deletion of users
	68	+ *
	69	+ * @param array $params
	70	+ */
	71	+ public function delete(array $params) {
	72	+ $this->log(
	73	+ 'User deleted: "%s"',
	74	+ $params,
	75	+ [
	76	+ 'uid',
	77	+ ]
	78	+ );
	79	+ }
80	80
81		- /**
82		- * Log unassignments of users (typically user backends, no data removed)
83		- *
84		- * @param string $uid
85		- */
86		- public function unassign(string $uid) {
87		- $this->log(
88		- 'UserID unassigned: "%s"',
89		- [ 'uid' => $uid ],
90		- [ 'uid' ]
91		- );
92		- }
	81	+ /**
	82	+ * Log unassignments of users (typically user backends, no data removed)
	83	+ *
	84	+ * @param string $uid
	85	+ */
	86	+ public function unassign(string $uid) {
	87	+ $this->log(
	88	+ 'UserID unassigned: "%s"',
	89	+ [ 'uid' => $uid ],
	90	+ [ 'uid' ]
	91	+ );
	92	+ }
93	93
94		- /**
95		- * Log enabling of users
96		- *
97		- * @param array $params
98		- */
99		- public function change(array $params) {
100		- switch($params['feature']) {
101		- case 'enabled':
102		- $this->log(
103		- $params['value'] === true
104		- ? 'User enabled: "%s"'
105		- : 'User disabled: "%s"',
106		- ['user' => $params['user']->getUID()],
107		- [
108		- 'user',
109		- ]
110		- );
111		- break;
112		- case 'eMailAddress':
113		- $this->log(
114		- 'Email address changed for user %s',
115		- ['user' => $params['user']->getUID()],
116		- [
117		- 'user',
118		- ]
119		- );
120		- break;
121		- }
122		- }
	94	+ /**
	95	+ * Log enabling of users
	96	+ *
	97	+ * @param array $params
	98	+ */
	99	+ public function change(array $params) {
	100	+ switch($params['feature']) {
	101	+ case 'enabled':
	102	+ $this->log(
	103	+ $params['value'] === true
	104	+ ? 'User enabled: "%s"'
	105	+ : 'User disabled: "%s"',
	106	+ ['user' => $params['user']->getUID()],
	107	+ [
	108	+ 'user',
	109	+ ]
	110	+ );
	111	+ break;
	112	+ case 'eMailAddress':
	113	+ $this->log(
	114	+ 'Email address changed for user %s',
	115	+ ['user' => $params['user']->getUID()],
	116	+ [
	117	+ 'user',
	118	+ ]
	119	+ );
	120	+ break;
	121	+ }
	122	+ }
123	123
124		- /**
125		- * Logs changing of the user scope
126		- *
127		- * @param IUser $user
128		- */
129		- public function setPassword(IUser $user) {
130		- if($user->getBackendClassName() === 'Database') {
131		- $this->log(
132		- 'Password of user "%s" has been changed',
133		- [
134		- 'user' => $user->getUID(),
135		- ],
136		- [
137		- 'user',
138		- ]
139		- );
140		- }
141		- }
	124	+ /**
	125	+ * Logs changing of the user scope
	126	+ *
	127	+ * @param IUser $user
	128	+ */
	129	+ public function setPassword(IUser $user) {
	130	+ if($user->getBackendClassName() === 'Database') {
	131	+ $this->log(
	132	+ 'Password of user "%s" has been changed',
	133	+ [
	134	+ 'user' => $user->getUID(),
	135	+ ],
	136	+ [
	137	+ 'user',
	138	+ ]
	139	+ );
	140	+ }
	141	+ }
142	142	}

nextcloud / server

Push — master ( 6b1186...4e3ada )

Status

Category

Indentation +99 added lines, -99 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch