Inspection of "Updated popover rules to allow form inputs and add..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8575)

by John

created 2018-03-07 09:29 UTC

Status

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

@@ -28,41 +28,41 @@
 block discarded – undo
 
 class ExternalShareMenuAction extends SimpleMenuAction {
 
-	/** @var string */
-	private $owner;
+    /** @var string */
+    private $owner;
 
-	/** @var string */
-	private $displayname;
+    /** @var string */
+    private $displayname;
 
-	/** @var string */
-	private $shareName;
+    /** @var string */
+    private $shareName;
 
-	/**
-	 * ExternalShareMenuAction constructor.
-	 *
-	 * @param string $label
-	 * @param string $icon
-	 * @param string $owner
-	 * @param string $displayname
-	 * @param string $shareName
-	 */
-	public function __construct(string $label, string $icon, string $owner, string $displayname, string $shareName) {
-		parent::__construct('save', $label, $icon);
-		$this->owner = $owner;
-		$this->displayname = $displayname;
-		$this->shareName = $shareName;
-	}
+    /**
+     * ExternalShareMenuAction constructor.
+     *
+     * @param string $label
+     * @param string $icon
+     * @param string $owner
+     * @param string $displayname
+     * @param string $shareName
+     */
+    public function __construct(string $label, string $icon, string $owner, string $displayname, string $shareName) {
+        parent::__construct('save', $label, $icon);
+        $this->owner = $owner;
+        $this->displayname = $displayname;
+        $this->shareName = $shareName;
+    }
 
-	public function render(): string {
-		return '<li>' .
-			'<a id="save" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' .
-			'<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
-			'<span id="save-button">' . Util::sanitizeHTML($this->getLabel()) . '</span>' .
-			'<form class="save-form hidden" action="#">' .
-			'<input type="text" id="remote_address" placeholder="[email protected]">' .
-			'<input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
-			'</form>' .
-			'</a>' .
-			'</li>';
-	}
+    public function render(): string {
+        return '<li>' .
+            '<a id="save" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' .
+            '<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
+            '<span id="save-button">' . Util::sanitizeHTML($this->getLabel()) . '</span>' .
+            '<form class="save-form hidden" action="#">' .
+            '<input type="text" id="remote_address" placeholder="[email protected]">' .
+            '<input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
+            '</form>' .
+            '</a>' .
+            '</li>';
+    }
 }

Please login to merge, or discard this patch.

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -54,15 +54,15 @@
 block discarded – undo
 	}
 
 	public function render(): string {
-		return '<li>' .
-			'<a id="save" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' .
-			'<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
-			'<span id="save-button">' . Util::sanitizeHTML($this->getLabel()) . '</span>' .
-			'<form class="save-form hidden" action="#">' .
-			'<input type="text" id="remote_address" placeholder="[email protected]">' .
-			'<input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
-			'</form>' .
-			'</a>' .
+		return '<li>'.
+			'<a id="save" data-protected="false" data-owner-display-name="'.Util::sanitizeHTML($this->displayname).'" data-owner="'.Util::sanitizeHTML($this->owner).'" data-name="'.Util::sanitizeHTML($this->shareName).'">'.
+			'<span class="icon '.Util::sanitizeHTML($this->getIcon()).'"></span>'.
+			'<span id="save-button">'.Util::sanitizeHTML($this->getLabel()).'</span>'.
+			'<form class="save-form hidden" action="#">'.
+			'<input type="text" id="remote_address" placeholder="[email protected]">'.
+			'<input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>'.
+			'</form>'.
+			'</a>'.
 			'</li>';
 	}
 }

Please login to merge, or discard this patch.

		@@ -28,41 +28,41 @@
		block discarded – undo
28	28
29	29	class ExternalShareMenuAction extends SimpleMenuAction {
30	30
31		- /** @var string */
32		- private $owner;
	31	+ /** @var string */
	32	+ private $owner;
33	33
34		- /** @var string */
35		- private $displayname;
	34	+ /** @var string */
	35	+ private $displayname;
36	36
37		- /** @var string */
38		- private $shareName;
	37	+ /** @var string */
	38	+ private $shareName;
39	39
40		- /**
41		- * ExternalShareMenuAction constructor.
42		- *
43		- * @param string $label
44		- * @param string $icon
45		- * @param string $owner
46		- * @param string $displayname
47		- * @param string $shareName
48		- */
49		- public function __construct(string $label, string $icon, string $owner, string $displayname, string $shareName) {
50		- parent::__construct('save', $label, $icon);
51		- $this->owner = $owner;
52		- $this->displayname = $displayname;
53		- $this->shareName = $shareName;
54		- }
	40	+ /**
	41	+ * ExternalShareMenuAction constructor.
	42	+ *
	43	+ * @param string $label
	44	+ * @param string $icon
	45	+ * @param string $owner
	46	+ * @param string $displayname
	47	+ * @param string $shareName
	48	+ */
	49	+ public function __construct(string $label, string $icon, string $owner, string $displayname, string $shareName) {
	50	+ parent::__construct('save', $label, $icon);
	51	+ $this->owner = $owner;
	52	+ $this->displayname = $displayname;
	53	+ $this->shareName = $shareName;
	54	+ }
55	55
56		- public function render(): string {
57		- return '<li>' .
58		- '<a id="save" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' .
59		- '<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
60		- '<span id="save-button">' . Util::sanitizeHTML($this->getLabel()) . '</span>' .
61		- '<form class="save-form hidden" action="#">' .
62		- '<input type="text" id="remote_address" placeholder="[email protected]">' .
63		- '<input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
64		- '</form>' .
65		- '</a>' .
66		- '</li>';
67		- }
	56	+ public function render(): string {
	57	+ return '<li>' .
	58	+ '<a id="save" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' .
	59	+ '<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
	60	+ '<span id="save-button">' . Util::sanitizeHTML($this->getLabel()) . '</span>' .
	61	+ '<form class="save-form hidden" action="#">' .
	62	+ '<input type="text" id="remote_address" placeholder="[email protected]">' .
	63	+ '<input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
	64	+ '</form>' .
	65	+ '</a>' .
	66	+ '</li>';
	67	+ }
68	68	}

		@@ -54,15 +54,15 @@
		block discarded – undo
54	54	}
55	55
56	56	public function render(): string {
57		- return '<li>' .
58		- '<a id="save" data-protected="false" data-owner-display-name="' . Util::sanitizeHTML($this->displayname) . '" data-owner="' . Util::sanitizeHTML($this->owner) . '" data-name="' . Util::sanitizeHTML($this->shareName) . '">' .
59		- '<span class="icon ' . Util::sanitizeHTML($this->getIcon()) . '"></span>' .
60		- '<span id="save-button">' . Util::sanitizeHTML($this->getLabel()) . '</span>' .
61		- '<form class="save-form hidden" action="#">' .
62		- '<input type="text" id="remote_address" placeholder="[email protected]">' .
63		- '<input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>' .
64		- '</form>' .
65		- '</a>' .
	57	+ return '<li>'.
	58	+ '<a id="save" data-protected="false" data-owner-display-name="'.Util::sanitizeHTML($this->displayname).'" data-owner="'.Util::sanitizeHTML($this->owner).'" data-name="'.Util::sanitizeHTML($this->shareName).'">'.
	59	+ '<span class="icon '.Util::sanitizeHTML($this->getIcon()).'"></span>'.
	60	+ '<span id="save-button">'.Util::sanitizeHTML($this->getLabel()).'</span>'.
	61	+ '<form class="save-form hidden" action="#">'.
	62	+ '<input type="text" id="remote_address" placeholder="[email protected]">'.
	63	+ '<input type="submit" value=" " id="save-button-confirm" class="icon-confirm" disabled="disabled"></button>'.
	64	+ '</form>'.
	65	+ '</a>'.
66	66	'</li>';
67	67	}
68	68	}

nextcloud / server

Pull Request — master (#8575)

Status

Category

Indentation +33 added lines, -33 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch