nextcloud / server

apps/theming/lib/Controller/ThemingController.php

Indentation +408 added lines, -408 removed lines

@@ -62,380 +62,380 @@ 
  * @package OCA\Theming\Controller
  */
 class ThemingController extends Controller {
-	/** @var ThemingDefaults */
-	private $themingDefaults;
-	/** @var Util */
-	private $util;
-	/** @var IL10N */
-	private $l10n;
-	/** @var IConfig */
-	private $config;
-	/** @var ITempManager */
-	private $tempManager;
-	/** @var IAppData */
-	private $appData;
-	/** @var SCSSCacher */
-	private $scssCacher;
-	/** @var IURLGenerator */
-	private $urlGenerator;
-	/** @var IAppManager */
-	private $appManager;
-	/** @var ImageManager */
-	private $imageManager;
-
-	/**
-	 * ThemingController constructor.
-	 *
-	 * @param string $appName
-	 * @param IRequest $request
-	 * @param IConfig $config
-	 * @param ThemingDefaults $themingDefaults
-	 * @param Util $util
-	 * @param IL10N $l
-	 * @param ITempManager $tempManager
-	 * @param IAppData $appData
-	 * @param SCSSCacher $scssCacher
-	 * @param IURLGenerator $urlGenerator
-	 * @param IAppManager $appManager
-	 * @param ImageManager $imageManager
-	 */
-	public function __construct(
-		$appName,
-		IRequest $request,
-		IConfig $config,
-		ThemingDefaults $themingDefaults,
-		Util $util,
-		IL10N $l,
-		ITempManager $tempManager,
-		IAppData $appData,
-		SCSSCacher $scssCacher,
-		IURLGenerator $urlGenerator,
-		IAppManager $appManager,
-		ImageManager $imageManager
-	) {
-		parent::__construct($appName, $request);
-
-		$this->themingDefaults = $themingDefaults;
-		$this->util = $util;
-		$this->l10n = $l;
-		$this->config = $config;
-		$this->tempManager = $tempManager;
-		$this->appData = $appData;
-		$this->scssCacher = $scssCacher;
-		$this->urlGenerator = $urlGenerator;
-		$this->appManager = $appManager;
-		$this->imageManager = $imageManager;
-	}
-
-	/**
-	 * @param string $setting
-	 * @param string $value
-	 * @return DataResponse
-	 * @throws NotPermittedException
-	 */
-	public function updateStylesheet($setting, $value) {
-		$value = trim($value);
-		switch ($setting) {
-			case 'name':
-				if (strlen($value) > 250) {
-					return new DataResponse([
-						'data' => [
-							'message' => $this->l10n->t('The given name is too long'),
-						],
-						'status' => 'error'
-					]);
-				}
-				break;
-			case 'url':
-				if (strlen($value) > 500) {
-					return new DataResponse([
-						'data' => [
-							'message' => $this->l10n->t('The given web address is too long'),
-						],
-						'status' => 'error'
-					]);
-				}
-				break;
-			case 'imprintUrl':
-				if (strlen($value) > 500) {
-					return new DataResponse([
-						'data' => [
-							'message' => $this->l10n->t('The given legal notice address is too long'),
-						],
-						'status' => 'error'
-					]);
-				}
-				break;
-			case 'privacyUrl':
-				if (strlen($value) > 500) {
-					return new DataResponse([
-						'data' => [
-							'message' => $this->l10n->t('The given privacy policy address is too long'),
-						],
-						'status' => 'error'
-					]);
-				}
-				break;
-			case 'slogan':
-				if (strlen($value) > 500) {
-					return new DataResponse([
-						'data' => [
-							'message' => $this->l10n->t('The given slogan is too long'),
-						],
-						'status' => 'error'
-					]);
-				}
-				break;
-			case 'color':
-				if (!preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $value)) {
-					return new DataResponse([
-						'data' => [
-							'message' => $this->l10n->t('The given color is invalid'),
-						],
-						'status' => 'error'
-					]);
-				}
-				break;
-		}
-
-		$this->themingDefaults->set($setting, $value);
-
-		// reprocess server scss for preview
-		$cssCached = $this->scssCacher->process(\OC::$SERVERROOT, 'core/css/css-variables.scss', 'core');
-
-		return new DataResponse(
-			[
-				'data' =>
-					[
-						'message' => $this->l10n->t('Saved'),
-						'serverCssUrl' => $this->urlGenerator->linkTo('', $this->scssCacher->getCachedSCSS('core', '/core/css/css-variables.scss'))
-					],
-				'status' => 'success'
-			]
-		);
-	}
-
-	/**
-	 * @return DataResponse
-	 * @throws NotPermittedException
-	 */
-	public function uploadImage(): DataResponse {
-		// logo / background
-		// new: favicon logo-header
-		//
-		$key = $this->request->getParam('key');
-		$image = $this->request->getUploadedFile('image');
-		$error = null;
-		$phpFileUploadErrors = [
-			UPLOAD_ERR_OK => $this->l10n->t('The file was uploaded'),
-			UPLOAD_ERR_INI_SIZE => $this->l10n->t('The uploaded file exceeds the upload_max_filesize directive in php.ini'),
-			UPLOAD_ERR_FORM_SIZE => $this->l10n->t('The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form'),
-			UPLOAD_ERR_PARTIAL => $this->l10n->t('The file was only partially uploaded'),
-			UPLOAD_ERR_NO_FILE => $this->l10n->t('No file was uploaded'),
-			UPLOAD_ERR_NO_TMP_DIR => $this->l10n->t('Missing a temporary folder'),
-			UPLOAD_ERR_CANT_WRITE => $this->l10n->t('Could not write file to disk'),
-			UPLOAD_ERR_EXTENSION => $this->l10n->t('A PHP extension stopped the file upload'),
-		];
-		if (empty($image)) {
-			$error = $this->l10n->t('No file uploaded');
-		}
-		if (!empty($image) && array_key_exists('error', $image) && $image['error'] !== UPLOAD_ERR_OK) {
-			$error = $phpFileUploadErrors[$image['error']];
-		}
-
-		if ($error !== null) {
-			return new DataResponse(
-				[
-					'data' => [
-						'message' => $error
-					],
-					'status' => 'failure',
-				],
-				Http::STATUS_UNPROCESSABLE_ENTITY
-			);
-		}
-
-		$name = '';
-		try {
-			$folder = $this->appData->getFolder('images');
-		} catch (NotFoundException $e) {
-			$folder = $this->appData->newFolder('images');
-		}
-
-		$this->imageManager->delete($key);
-
-		$target = $folder->newFile($key);
-		$supportedFormats = $this->getSupportedUploadImageFormats($key);
-		$detectedMimeType = mime_content_type($image['tmp_name']);
-		if (!in_array($image['type'], $supportedFormats) || !in_array($detectedMimeType, $supportedFormats)) {
-			return new DataResponse(
-				[
-					'data' => [
-						'message' => $this->l10n->t('Unsupported image type'),
-					],
-					'status' => 'failure',
-				],
-				Http::STATUS_UNPROCESSABLE_ENTITY
-			);
-		}
-
-		$resizeKeys = ['background'];
-		if (in_array($key, $resizeKeys, true)) {
-			// Optimize the image since some people may upload images that will be
-			// either to big or are not progressive rendering.
-			$newImage = @imagecreatefromstring(file_get_contents($image['tmp_name'], 'r'));
-
-			$tmpFile = $this->tempManager->getTemporaryFile();
-			$newWidth = imagesx($newImage) < 4096 ? imagesx($newImage) : 4096;
-			$newHeight = imagesy($newImage) / (imagesx($newImage) / $newWidth);
-			$outputImage = imagescale($newImage, $newWidth, $newHeight);
-
-			imageinterlace($outputImage, 1);
-			imagejpeg($outputImage, $tmpFile, 75);
-			imagedestroy($outputImage);
-
-			$target->putContent(file_get_contents($tmpFile, 'r'));
-		} else {
-			$target->putContent(file_get_contents($image['tmp_name'], 'r'));
-		}
-		$name = $image['name'];
-
-		$this->themingDefaults->set($key.'Mime', $image['type']);
-
-		$cssCached = $this->scssCacher->process(\OC::$SERVERROOT, 'core/css/css-variables.scss', 'core');
-
-		return new DataResponse(
-			[
-				'data' =>
-					[
-						'name' => $name,
-						'url' => $this->imageManager->getImageUrl($key),
-						'message' => $this->l10n->t('Saved'),
-						'serverCssUrl' => $this->urlGenerator->linkTo('', $this->scssCacher->getCachedSCSS('core', '/core/css/css-variables.scss'))
-					],
-				'status' => 'success'
-			]
-		);
-	}
-
-	/**
-	 * Returns a list of supported mime types for image uploads.
-	 * "favicon" images are only allowed to be SVG when imagemagick with SVG support is available.
-	 *
-	 * @param string $key The image key, e.g. "favicon"
-	 * @return array
-	 */
-	private function getSupportedUploadImageFormats(string $key): array {
-		$supportedFormats = ['image/jpeg', 'image/png', 'image/gif',];
-
-		if ($key !== 'favicon' || $this->imageManager->shouldReplaceIcons() === true) {
-			$supportedFormats[] = 'image/svg+xml';
-			$supportedFormats[] = 'image/svg';
-		}
-
-		return $supportedFormats;
-	}
-
-	/**
-	 * Revert setting to default value
-	 *
-	 * @param string $setting setting which should be reverted
-	 * @return DataResponse
-	 * @throws NotPermittedException
-	 */
-	public function undo(string $setting): DataResponse {
-		$value = $this->themingDefaults->undo($setting);
-		// reprocess server scss for preview
-		$cssCached = $this->scssCacher->process(\OC::$SERVERROOT, 'core/css/css-variables.scss', 'core');
-
-		if (strpos($setting, 'Mime') !== -1) {
-			$imageKey = str_replace('Mime', '', $setting);
-			$this->imageManager->delete($imageKey);
-		}
-
-		return new DataResponse(
-			[
-				'data' =>
-					[
-						'value' => $value,
-						'message' => $this->l10n->t('Saved'),
-						'serverCssUrl' => $this->urlGenerator->linkTo('', $this->scssCacher->getCachedSCSS('core', '/core/css/css-variables.scss'))
-					],
-				'status' => 'success'
-			]
-		);
-	}
-
-	/**
-	 * @PublicPage
-	 * @NoCSRFRequired
-	 *
-	 * @param string $key
-	 * @param bool $useSvg
-	 * @return FileDisplayResponse|NotFoundResponse
-	 * @throws NotPermittedException
-	 */
-	public function getImage(string $key, bool $useSvg = true) {
-		try {
-			$file = $this->imageManager->getImage($key, $useSvg);
-		} catch (NotFoundException $e) {
-			return new NotFoundResponse();
-		}
-
-		$response = new FileDisplayResponse($file);
-		$response->cacheFor(3600);
-		$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
-		$response->addHeader('Content-Disposition', 'attachment; filename="' . $key . '"');
-		if (!$useSvg) {
-			$response->addHeader('Content-Type', 'image/png');
-		} else {
-			$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
-		}
-		return $response;
-	}
-
-	/**
-	 * @NoCSRFRequired
-	 * @PublicPage
-	 * @NoSameSiteCookieRequired
-	 *
-	 * @return FileDisplayResponse|NotFoundResponse
-	 * @throws NotPermittedException
-	 * @throws \Exception
-	 * @throws \OCP\App\AppPathNotFoundException
-	 */
-	public function getStylesheet() {
-		$appPath = $this->appManager->getAppPath('theming');
-
-		/* SCSSCacher is required here
+    /** @var ThemingDefaults */
+    private $themingDefaults;
+    /** @var Util */
+    private $util;
+    /** @var IL10N */
+    private $l10n;
+    /** @var IConfig */
+    private $config;
+    /** @var ITempManager */
+    private $tempManager;
+    /** @var IAppData */
+    private $appData;
+    /** @var SCSSCacher */
+    private $scssCacher;
+    /** @var IURLGenerator */
+    private $urlGenerator;
+    /** @var IAppManager */
+    private $appManager;
+    /** @var ImageManager */
+    private $imageManager;
+
+    /**
+     * ThemingController constructor.
+     *
+     * @param string $appName
+     * @param IRequest $request
+     * @param IConfig $config
+     * @param ThemingDefaults $themingDefaults
+     * @param Util $util
+     * @param IL10N $l
+     * @param ITempManager $tempManager
+     * @param IAppData $appData
+     * @param SCSSCacher $scssCacher
+     * @param IURLGenerator $urlGenerator
+     * @param IAppManager $appManager
+     * @param ImageManager $imageManager
+     */
+    public function __construct(
+        $appName,
+        IRequest $request,
+        IConfig $config,
+        ThemingDefaults $themingDefaults,
+        Util $util,
+        IL10N $l,
+        ITempManager $tempManager,
+        IAppData $appData,
+        SCSSCacher $scssCacher,
+        IURLGenerator $urlGenerator,
+        IAppManager $appManager,
+        ImageManager $imageManager
+    ) {
+        parent::__construct($appName, $request);
+
+        $this->themingDefaults = $themingDefaults;
+        $this->util = $util;
+        $this->l10n = $l;
+        $this->config = $config;
+        $this->tempManager = $tempManager;
+        $this->appData = $appData;
+        $this->scssCacher = $scssCacher;
+        $this->urlGenerator = $urlGenerator;
+        $this->appManager = $appManager;
+        $this->imageManager = $imageManager;
+    }
+
+    /**
+     * @param string $setting
+     * @param string $value
+     * @return DataResponse
+     * @throws NotPermittedException
+     */
+    public function updateStylesheet($setting, $value) {
+        $value = trim($value);
+        switch ($setting) {
+            case 'name':
+                if (strlen($value) > 250) {
+                    return new DataResponse([
+                        'data' => [
+                            'message' => $this->l10n->t('The given name is too long'),
+                        ],
+                        'status' => 'error'
+                    ]);
+                }
+                break;
+            case 'url':
+                if (strlen($value) > 500) {
+                    return new DataResponse([
+                        'data' => [
+                            'message' => $this->l10n->t('The given web address is too long'),
+                        ],
+                        'status' => 'error'
+                    ]);
+                }
+                break;
+            case 'imprintUrl':
+                if (strlen($value) > 500) {
+                    return new DataResponse([
+                        'data' => [
+                            'message' => $this->l10n->t('The given legal notice address is too long'),
+                        ],
+                        'status' => 'error'
+                    ]);
+                }
+                break;
+            case 'privacyUrl':
+                if (strlen($value) > 500) {
+                    return new DataResponse([
+                        'data' => [
+                            'message' => $this->l10n->t('The given privacy policy address is too long'),
+                        ],
+                        'status' => 'error'
+                    ]);
+                }
+                break;
+            case 'slogan':
+                if (strlen($value) > 500) {
+                    return new DataResponse([
+                        'data' => [
+                            'message' => $this->l10n->t('The given slogan is too long'),
+                        ],
+                        'status' => 'error'
+                    ]);
+                }
+                break;
+            case 'color':
+                if (!preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $value)) {
+                    return new DataResponse([
+                        'data' => [
+                            'message' => $this->l10n->t('The given color is invalid'),
+                        ],
+                        'status' => 'error'
+                    ]);
+                }
+                break;
+        }
+
+        $this->themingDefaults->set($setting, $value);
+
+        // reprocess server scss for preview
+        $cssCached = $this->scssCacher->process(\OC::$SERVERROOT, 'core/css/css-variables.scss', 'core');
+
+        return new DataResponse(
+            [
+                'data' =>
+                    [
+                        'message' => $this->l10n->t('Saved'),
+                        'serverCssUrl' => $this->urlGenerator->linkTo('', $this->scssCacher->getCachedSCSS('core', '/core/css/css-variables.scss'))
+                    ],
+                'status' => 'success'
+            ]
+        );
+    }
+
+    /**
+     * @return DataResponse
+     * @throws NotPermittedException
+     */
+    public function uploadImage(): DataResponse {
+        // logo / background
+        // new: favicon logo-header
+        //
+        $key = $this->request->getParam('key');
+        $image = $this->request->getUploadedFile('image');
+        $error = null;
+        $phpFileUploadErrors = [
+            UPLOAD_ERR_OK => $this->l10n->t('The file was uploaded'),
+            UPLOAD_ERR_INI_SIZE => $this->l10n->t('The uploaded file exceeds the upload_max_filesize directive in php.ini'),
+            UPLOAD_ERR_FORM_SIZE => $this->l10n->t('The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form'),
+            UPLOAD_ERR_PARTIAL => $this->l10n->t('The file was only partially uploaded'),
+            UPLOAD_ERR_NO_FILE => $this->l10n->t('No file was uploaded'),
+            UPLOAD_ERR_NO_TMP_DIR => $this->l10n->t('Missing a temporary folder'),
+            UPLOAD_ERR_CANT_WRITE => $this->l10n->t('Could not write file to disk'),
+            UPLOAD_ERR_EXTENSION => $this->l10n->t('A PHP extension stopped the file upload'),
+        ];
+        if (empty($image)) {
+            $error = $this->l10n->t('No file uploaded');
+        }
+        if (!empty($image) && array_key_exists('error', $image) && $image['error'] !== UPLOAD_ERR_OK) {
+            $error = $phpFileUploadErrors[$image['error']];
+        }
+
+        if ($error !== null) {
+            return new DataResponse(
+                [
+                    'data' => [
+                        'message' => $error
+                    ],
+                    'status' => 'failure',
+                ],
+                Http::STATUS_UNPROCESSABLE_ENTITY
+            );
+        }
+
+        $name = '';
+        try {
+            $folder = $this->appData->getFolder('images');
+        } catch (NotFoundException $e) {
+            $folder = $this->appData->newFolder('images');
+        }
+
+        $this->imageManager->delete($key);
+
+        $target = $folder->newFile($key);
+        $supportedFormats = $this->getSupportedUploadImageFormats($key);
+        $detectedMimeType = mime_content_type($image['tmp_name']);
+        if (!in_array($image['type'], $supportedFormats) || !in_array($detectedMimeType, $supportedFormats)) {
+            return new DataResponse(
+                [
+                    'data' => [
+                        'message' => $this->l10n->t('Unsupported image type'),
+                    ],
+                    'status' => 'failure',
+                ],
+                Http::STATUS_UNPROCESSABLE_ENTITY
+            );
+        }
+
+        $resizeKeys = ['background'];
+        if (in_array($key, $resizeKeys, true)) {
+            // Optimize the image since some people may upload images that will be
+            // either to big or are not progressive rendering.
+            $newImage = @imagecreatefromstring(file_get_contents($image['tmp_name'], 'r'));
+
+            $tmpFile = $this->tempManager->getTemporaryFile();
+            $newWidth = imagesx($newImage) < 4096 ? imagesx($newImage) : 4096;
+            $newHeight = imagesy($newImage) / (imagesx($newImage) / $newWidth);
+            $outputImage = imagescale($newImage, $newWidth, $newHeight);
+
+            imageinterlace($outputImage, 1);
+            imagejpeg($outputImage, $tmpFile, 75);
+            imagedestroy($outputImage);
+
+            $target->putContent(file_get_contents($tmpFile, 'r'));
+        } else {
+            $target->putContent(file_get_contents($image['tmp_name'], 'r'));
+        }
+        $name = $image['name'];
+
+        $this->themingDefaults->set($key.'Mime', $image['type']);
+
+        $cssCached = $this->scssCacher->process(\OC::$SERVERROOT, 'core/css/css-variables.scss', 'core');
+
+        return new DataResponse(
+            [
+                'data' =>
+                    [
+                        'name' => $name,
+                        'url' => $this->imageManager->getImageUrl($key),
+                        'message' => $this->l10n->t('Saved'),
+                        'serverCssUrl' => $this->urlGenerator->linkTo('', $this->scssCacher->getCachedSCSS('core', '/core/css/css-variables.scss'))
+                    ],
+                'status' => 'success'
+            ]
+        );
+    }
+
+    /**
+     * Returns a list of supported mime types for image uploads.
+     * "favicon" images are only allowed to be SVG when imagemagick with SVG support is available.
+     *
+     * @param string $key The image key, e.g. "favicon"
+     * @return array
+     */
+    private function getSupportedUploadImageFormats(string $key): array {
+        $supportedFormats = ['image/jpeg', 'image/png', 'image/gif',];
+
+        if ($key !== 'favicon' || $this->imageManager->shouldReplaceIcons() === true) {
+            $supportedFormats[] = 'image/svg+xml';
+            $supportedFormats[] = 'image/svg';
+        }
+
+        return $supportedFormats;
+    }
+
+    /**
+     * Revert setting to default value
+     *
+     * @param string $setting setting which should be reverted
+     * @return DataResponse
+     * @throws NotPermittedException
+     */
+    public function undo(string $setting): DataResponse {
+        $value = $this->themingDefaults->undo($setting);
+        // reprocess server scss for preview
+        $cssCached = $this->scssCacher->process(\OC::$SERVERROOT, 'core/css/css-variables.scss', 'core');
+
+        if (strpos($setting, 'Mime') !== -1) {
+            $imageKey = str_replace('Mime', '', $setting);
+            $this->imageManager->delete($imageKey);
+        }
+
+        return new DataResponse(
+            [
+                'data' =>
+                    [
+                        'value' => $value,
+                        'message' => $this->l10n->t('Saved'),
+                        'serverCssUrl' => $this->urlGenerator->linkTo('', $this->scssCacher->getCachedSCSS('core', '/core/css/css-variables.scss'))
+                    ],
+                'status' => 'success'
+            ]
+        );
+    }
+
+    /**
+     * @PublicPage
+     * @NoCSRFRequired
+     *
+     * @param string $key
+     * @param bool $useSvg
+     * @return FileDisplayResponse|NotFoundResponse
+     * @throws NotPermittedException
+     */
+    public function getImage(string $key, bool $useSvg = true) {
+        try {
+            $file = $this->imageManager->getImage($key, $useSvg);
+        } catch (NotFoundException $e) {
+            return new NotFoundResponse();
+        }
+
+        $response = new FileDisplayResponse($file);
+        $response->cacheFor(3600);
+        $response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
+        $response->addHeader('Content-Disposition', 'attachment; filename="' . $key . '"');
+        if (!$useSvg) {
+            $response->addHeader('Content-Type', 'image/png');
+        } else {
+            $response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
+        }
+        return $response;
+    }
+
+    /**
+     * @NoCSRFRequired
+     * @PublicPage
+     * @NoSameSiteCookieRequired
+     *
+     * @return FileDisplayResponse|NotFoundResponse
+     * @throws NotPermittedException
+     * @throws \Exception
+     * @throws \OCP\App\AppPathNotFoundException
+     */
+    public function getStylesheet() {
+        $appPath = $this->appManager->getAppPath('theming');
+
+        /* SCSSCacher is required here
 		 * We cannot rely on automatic caching done by \OC_Util::addStyle,
 		 * since we need to add the cacheBuster value to the url
 		 */
-		$cssCached = $this->scssCacher->process($appPath, 'css/theming.scss', 'theming');
-		if(!$cssCached) {
-			return new NotFoundResponse();
-		}
-
-		try {
-			$cssFile = $this->scssCacher->getCachedCSS('theming', 'theming.css');
-			$response = new FileDisplayResponse($cssFile, Http::STATUS_OK, ['Content-Type' => 'text/css']);
-			$response->cacheFor(86400);
-			return $response;
-		} catch (NotFoundException $e) {
-			return new NotFoundResponse();
-		}
-	}
-
-	/**
-	 * @NoCSRFRequired
-	 * @PublicPage
-	 * @NoSameSiteCookieRequired
-	 *
-	 * @return DataDownloadResponse
-	 */
-	public function getJavascript() {
-		$cacheBusterValue = $this->config->getAppValue('theming', 'cachebuster', '0');
-		$responseJS = '(function() {
+        $cssCached = $this->scssCacher->process($appPath, 'css/theming.scss', 'theming');
+        if(!$cssCached) {
+            return new NotFoundResponse();
+        }
+
+        try {
+            $cssFile = $this->scssCacher->getCachedCSS('theming', 'theming.css');
+            $response = new FileDisplayResponse($cssFile, Http::STATUS_OK, ['Content-Type' => 'text/css']);
+            $response->cacheFor(86400);
+            return $response;
+        } catch (NotFoundException $e) {
+            return new NotFoundResponse();
+        }
+    }
+
+    /**
+     * @NoCSRFRequired
+     * @PublicPage
+     * @NoSameSiteCookieRequired
+     *
+     * @return DataDownloadResponse
+     */
+    public function getJavascript() {
+        $cacheBusterValue = $this->config->getAppValue('theming', 'cachebuster', '0');
+        $responseJS = '(function() {
 	OCA.Theming = {
 		name: ' . json_encode($this->themingDefaults->getName()) . ',
 		url: ' . json_encode($this->themingDefaults->getBaseUrl()) . ',
@@ -447,41 +447,41 @@ 
 		cacheBuster: ' . json_encode($cacheBusterValue) . '
 	};
 })();';
-		$response = new DataDownloadResponse($responseJS, 'javascript', 'text/javascript');
-		$response->cacheFor(3600);
-		return $response;
-	}
-
-	/**
-	 * @NoCSRFRequired
-	 * @PublicPage
-	 *
-	 * @return Http\JSONResponse
-	 */
-	public function getManifest($app) {
-		$cacheBusterValue = $this->config->getAppValue('theming', 'cachebuster', '0');
-		$responseJS = [
-			'name' => $this->themingDefaults->getName(),
-			'start_url' => $this->urlGenerator->getBaseUrl(),
-			'icons' =>
-				[
-					[
-						'src' => $this->urlGenerator->linkToRoute('theming.Icon.getTouchIcon',
-								['app' => $app]) . '?v=' . $cacheBusterValue,
-						'type'=> 'image/png',
-						'sizes'=> '128x128'
-					],
-					[
-						'src' => $this->urlGenerator->linkToRoute('theming.Icon.getFavicon',
-								['app' => $app]) . '?v=' . $cacheBusterValue,
-						'type' => 'image/svg+xml',
-						'sizes' => '16x16'
-					]
-				],
-			'display' => 'standalone'
-		];
-		$response = new Http\JSONResponse($responseJS);
-		$response->cacheFor(3600);
-		return $response;
-	}
+        $response = new DataDownloadResponse($responseJS, 'javascript', 'text/javascript');
+        $response->cacheFor(3600);
+        return $response;
+    }
+
+    /**
+     * @NoCSRFRequired
+     * @PublicPage
+     *
+     * @return Http\JSONResponse
+     */
+    public function getManifest($app) {
+        $cacheBusterValue = $this->config->getAppValue('theming', 'cachebuster', '0');
+        $responseJS = [
+            'name' => $this->themingDefaults->getName(),
+            'start_url' => $this->urlGenerator->getBaseUrl(),
+            'icons' =>
+                [
+                    [
+                        'src' => $this->urlGenerator->linkToRoute('theming.Icon.getTouchIcon',
+                                ['app' => $app]) . '?v=' . $cacheBusterValue,
+                        'type'=> 'image/png',
+                        'sizes'=> '128x128'
+                    ],
+                    [
+                        'src' => $this->urlGenerator->linkToRoute('theming.Icon.getFavicon',
+                                ['app' => $app]) . '?v=' . $cacheBusterValue,
+                        'type' => 'image/svg+xml',
+                        'sizes' => '16x16'
+                    ]
+                ],
+            'display' => 'standalone'
+        ];
+        $response = new Http\JSONResponse($responseJS);
+        $response->cacheFor(3600);
+        return $response;
+    }
 }

core/Controller/JsController.php

Indentation +60 added lines, -60 removed lines

@@ -40,74 +40,74 @@
 
 class JsController extends Controller {
 
-	/** @var IAppData */
-	protected $appData;
+    /** @var IAppData */
+    protected $appData;
 
-	/** @var ITimeFactory */
-	protected $timeFactory;
+    /** @var ITimeFactory */
+    protected $timeFactory;
 
-	public function __construct($appName, IRequest $request, Factory $appDataFactory, ITimeFactory $timeFactory) {
-		parent::__construct($appName, $request);
+    public function __construct($appName, IRequest $request, Factory $appDataFactory, ITimeFactory $timeFactory) {
+        parent::__construct($appName, $request);
 
-		$this->appData = $appDataFactory->get('js');
-		$this->timeFactory = $timeFactory;
-	}
+        $this->appData = $appDataFactory->get('js');
+        $this->timeFactory = $timeFactory;
+    }
 
-	/**
-	 * @PublicPage
-	 * @NoCSRFRequired
-	 * @NoSameSiteCookieRequired
-	 *
-	 * @param string $fileName js filename with extension
-	 * @param string $appName js folder name
-	 * @return FileDisplayResponse|NotFoundResponse
-	 */
-	public function getJs(string $fileName, string $appName): Response {
-		try {
-			$folder = $this->appData->getFolder($appName);
-			$gzip = false;
-			$file = $this->getFile($folder, $fileName, $gzip);
-		} catch(NotFoundException $e) {
-			return new NotFoundResponse();
-		}
+    /**
+     * @PublicPage
+     * @NoCSRFRequired
+     * @NoSameSiteCookieRequired
+     *
+     * @param string $fileName js filename with extension
+     * @param string $appName js folder name
+     * @return FileDisplayResponse|NotFoundResponse
+     */
+    public function getJs(string $fileName, string $appName): Response {
+        try {
+            $folder = $this->appData->getFolder($appName);
+            $gzip = false;
+            $file = $this->getFile($folder, $fileName, $gzip);
+        } catch(NotFoundException $e) {
+            return new NotFoundResponse();
+        }
 
-		$response = new FileDisplayResponse($file, Http::STATUS_OK, ['Content-Type' => 'application/javascript']);
-		if ($gzip) {
-			$response->addHeader('Content-Encoding', 'gzip');
-		}
+        $response = new FileDisplayResponse($file, Http::STATUS_OK, ['Content-Type' => 'application/javascript']);
+        if ($gzip) {
+            $response->addHeader('Content-Encoding', 'gzip');
+        }
 
-		$ttl = 31536000;
-		$response->addHeader('Cache-Control', 'max-age='.$ttl.', immutable');
+        $ttl = 31536000;
+        $response->addHeader('Cache-Control', 'max-age='.$ttl.', immutable');
 
-		$expires = new \DateTime();
-		$expires->setTimestamp($this->timeFactory->getTime());
-		$expires->add(new \DateInterval('PT'.$ttl.'S'));
-		$response->addHeader('Expires', $expires->format(\DateTime::RFC1123));
-		$response->addHeader('Pragma', 'cache');
-		return $response;
-	}
+        $expires = new \DateTime();
+        $expires->setTimestamp($this->timeFactory->getTime());
+        $expires->add(new \DateInterval('PT'.$ttl.'S'));
+        $response->addHeader('Expires', $expires->format(\DateTime::RFC1123));
+        $response->addHeader('Pragma', 'cache');
+        return $response;
+    }
 
-	/**
-	 * @param ISimpleFolder $folder
-	 * @param string $fileName
-	 * @param bool $gzip is set to true if we use the gzip file
-	 * @return ISimpleFile
-	 *
-	 * @throws NotFoundException
-	 */
-	private function getFile(ISimpleFolder $folder, string $fileName, bool &$gzip): ISimpleFile {
-		$encoding = $this->request->getHeader('Accept-Encoding');
+    /**
+     * @param ISimpleFolder $folder
+     * @param string $fileName
+     * @param bool $gzip is set to true if we use the gzip file
+     * @return ISimpleFile
+     *
+     * @throws NotFoundException
+     */
+    private function getFile(ISimpleFolder $folder, string $fileName, bool &$gzip): ISimpleFile {
+        $encoding = $this->request->getHeader('Accept-Encoding');
 
-		if (strpos($encoding, 'gzip') !== false) {
-			try {
-				$gzip = true;
-				return $folder->getFile($fileName . '.gzip'); # Safari doesn't like .gz
-			} catch (NotFoundException $e) {
-				// continue
-			}
-		}
+        if (strpos($encoding, 'gzip') !== false) {
+            try {
+                $gzip = true;
+                return $folder->getFile($fileName . '.gzip'); # Safari doesn't like .gz
+            } catch (NotFoundException $e) {
+                // continue
+            }
+        }
 
-		$gzip = false;
-		return $folder->getFile($fileName);
-	}
+        $gzip = false;
+        return $folder->getFile($fileName);
+    }
 }

core/Controller/CssController.php

Indentation +62 added lines, -62 removed lines

@@ -43,76 +43,76 @@
 
 class CssController extends Controller {
 
-	/** @var IAppData */
-	protected $appData;
+    /** @var IAppData */
+    protected $appData;
 
-	/** @var ITimeFactory */
-	protected $timeFactory;
+    /** @var ITimeFactory */
+    protected $timeFactory;
 
-	public function __construct(string $appName,
-								IRequest $request,
-								Factory $appDataFactory,
-								ITimeFactory $timeFactory) {
-		parent::__construct($appName, $request);
+    public function __construct(string $appName,
+                                IRequest $request,
+                                Factory $appDataFactory,
+                                ITimeFactory $timeFactory) {
+        parent::__construct($appName, $request);
 
-		$this->appData = $appDataFactory->get('css');
-		$this->timeFactory = $timeFactory;
-	}
+        $this->appData = $appDataFactory->get('css');
+        $this->timeFactory = $timeFactory;
+    }
 
-	/**
-	 * @PublicPage
-	 * @NoCSRFRequired
-	 * @NoSameSiteCookieRequired
-	 *
-	 * @param string $fileName css filename with extension
-	 * @param string $appName css folder name
-	 * @return FileDisplayResponse|NotFoundResponse
-	 */
-	public function getCss(string $fileName, string $appName): Response {
-		try {
-			$folder = $this->appData->getFolder($appName);
-			$gzip = false;
-			$file = $this->getFile($folder, $fileName, $gzip);
-		} catch(NotFoundException $e) {
-			return new NotFoundResponse();
-		}
+    /**
+     * @PublicPage
+     * @NoCSRFRequired
+     * @NoSameSiteCookieRequired
+     *
+     * @param string $fileName css filename with extension
+     * @param string $appName css folder name
+     * @return FileDisplayResponse|NotFoundResponse
+     */
+    public function getCss(string $fileName, string $appName): Response {
+        try {
+            $folder = $this->appData->getFolder($appName);
+            $gzip = false;
+            $file = $this->getFile($folder, $fileName, $gzip);
+        } catch(NotFoundException $e) {
+            return new NotFoundResponse();
+        }
 
-		$response = new FileDisplayResponse($file, Http::STATUS_OK, ['Content-Type' => 'text/css']);
-		if ($gzip) {
-			$response->addHeader('Content-Encoding', 'gzip');
-		}
+        $response = new FileDisplayResponse($file, Http::STATUS_OK, ['Content-Type' => 'text/css']);
+        if ($gzip) {
+            $response->addHeader('Content-Encoding', 'gzip');
+        }
 
-		$ttl = 31536000;
-		$response->addHeader('Cache-Control', 'max-age='.$ttl.', immutable');
+        $ttl = 31536000;
+        $response->addHeader('Cache-Control', 'max-age='.$ttl.', immutable');
 
-		$expires = new \DateTime();
-		$expires->setTimestamp($this->timeFactory->getTime());
-		$expires->add(new \DateInterval('PT'.$ttl.'S'));
-		$response->addHeader('Expires', $expires->format(\DateTime::RFC1123));
-		$response->addHeader('Pragma', 'cache');
-		return $response;
-	}
+        $expires = new \DateTime();
+        $expires->setTimestamp($this->timeFactory->getTime());
+        $expires->add(new \DateInterval('PT'.$ttl.'S'));
+        $response->addHeader('Expires', $expires->format(\DateTime::RFC1123));
+        $response->addHeader('Pragma', 'cache');
+        return $response;
+    }
 
-	/**
-	 * @param ISimpleFolder $folder
-	 * @param string $fileName
-	 * @param bool $gzip is set to true if we use the gzip file
-	 * @return ISimpleFile
-	 * @throws NotFoundException
-	 */
-	private function getFile(ISimpleFolder $folder, string $fileName, bool &$gzip): ISimpleFile {
-		$encoding = $this->request->getHeader('Accept-Encoding');
+    /**
+     * @param ISimpleFolder $folder
+     * @param string $fileName
+     * @param bool $gzip is set to true if we use the gzip file
+     * @return ISimpleFile
+     * @throws NotFoundException
+     */
+    private function getFile(ISimpleFolder $folder, string $fileName, bool &$gzip): ISimpleFile {
+        $encoding = $this->request->getHeader('Accept-Encoding');
 
-		if (strpos($encoding, 'gzip') !== false) {
-			try {
-				$gzip = true;
-				return $folder->getFile($fileName . '.gzip'); # Safari doesn't like .gz
-			} catch (NotFoundException $e) {
-				// continue
-			}
-		}
+        if (strpos($encoding, 'gzip') !== false) {
+            try {
+                $gzip = true;
+                return $folder->getFile($fileName . '.gzip'); # Safari doesn't like .gz
+            } catch (NotFoundException $e) {
+                // continue
+            }
+        }
 
-		$gzip = false;
-		return $folder->getFile($fileName);
-	}
+        $gzip = false;
+        return $folder->getFile($fileName);
+    }
 }

core/Controller/SvgController.php

Indentation +106 added lines, -106 removed lines

@@ -34,110 +34,110 @@
 
 class SvgController extends Controller {
 
-	/** @var string */
-	protected $serverRoot;
-
-	/** @var ITimeFactory */
-	protected $timeFactory;
-
-	/** @var IAppManager */
-	protected $appManager;
-
-	public function __construct(string $appName,
-								IRequest $request,
-								ITimeFactory $timeFactory,
-								IAppManager $appManager) {
-		parent::__construct($appName, $request);
-
-		$this->serverRoot  = \OC::$SERVERROOT;
-		$this->timeFactory = $timeFactory;
-		$this->appManager = $appManager;
-	}
-
-	/**
-	 * @PublicPage
-	 * @NoCSRFRequired
-	 * @NoSameSiteCookieRequired
-	 *
-	 * Generate svg from filename with the requested color
-	 *
-	 * @param string $folder
-	 * @param string $fileName
-	 * @param string $color
-	 * @return DataDisplayResponse|NotFoundResponse
-	 */
-	public function getSvgFromCore(string $folder, string $fileName, string $color = 'ffffff') {
-		$path = $this->serverRoot . "/core/img/$folder/$fileName.svg";
-		return $this->getSvg($path, $color, $fileName);
-	}
-
-	/**
-	 * @PublicPage
-	 * @NoCSRFRequired
-	 * @NoSameSiteCookieRequired
-	 *
-	 * Generate svg from filename with the requested color
-	 *
-	 * @param string $app
-	 * @param string $fileName
-	 * @param string $color
-	 * @return DataDisplayResponse|NotFoundResponse
-	 */
-	public function getSvgFromApp(string $app, string $fileName, string $color = 'ffffff') {
-
-		if ($app === 'settings') {
-			$path = $this->serverRoot . "/settings/img/$fileName.svg";
-			return $this->getSvg($path, $color, $fileName);
-		}
-
-		$appRootPath = $this->appManager->getAppPath($app);
-		$appPath = substr($appRootPath, strlen($this->serverRoot));
-
-		if (!$appPath) {
-			return new NotFoundResponse();
-		}
-		$path = $this->serverRoot . $appPath ."/img/$fileName.svg";
-		return $this->getSvg($path, $color, $fileName);
-	}
-
-	/**
-	 * Generate svg from filename with the requested color
-	 *
-	 * @param string $path
-	 * @param string $color
-	 * @return DataDisplayResponse|NotFoundResponse
-	 */
-	private function getSvg(string $path, string $color, string $fileName) {
-		if (!file_exists($path)) {
-			return new NotFoundResponse();
-		}
-
-		$svg = file_get_contents($path);
-
-		if (is_null($svg)) {
-			return new NotFoundResponse();
-		}
-
-		// add fill (fill is not present on black elements)
-		$fillRe = '/<((circle|rect|path)((?!fill)[a-z0-9 =".\-#():;])+)\/>/mi';
-		$svg = preg_replace($fillRe, '<$1 fill="#' . $color . '"/>', $svg);
-
-		// replace any fill or stroke colors
-		$svg = preg_replace('/stroke="#([a-z0-9]{3,6})"/mi', 'stroke="#' . $color . '"', $svg);
-		$svg = preg_replace('/fill="#([a-z0-9]{3,6})"/mi', 'fill="#' . $color . '"', $svg);
-
-		$response = new DataDisplayResponse($svg, Http::STATUS_OK, ['Content-Type' => 'image/svg+xml']);
-
-		// Set cache control
-		$ttl = 31536000;
-		$response->cacheFor($ttl);
-		$response->addHeader('Content-Disposition', 'inline; filename="' . $fileName . '.svg"');
-		$expires = new \DateTime();
-		$expires->setTimestamp($this->timeFactory->getTime());
-		$expires->add(new \DateInterval('PT' . $ttl . 'S'));
-		$response->addHeader('Expires', $expires->format(\DateTime::RFC1123));
-		$response->addHeader('Pragma', 'cache');
-
-		return $response;
-	}
+    /** @var string */
+    protected $serverRoot;
+
+    /** @var ITimeFactory */
+    protected $timeFactory;
+
+    /** @var IAppManager */
+    protected $appManager;
+
+    public function __construct(string $appName,
+                                IRequest $request,
+                                ITimeFactory $timeFactory,
+                                IAppManager $appManager) {
+        parent::__construct($appName, $request);
+
+        $this->serverRoot  = \OC::$SERVERROOT;
+        $this->timeFactory = $timeFactory;
+        $this->appManager = $appManager;
+    }
+
+    /**
+     * @PublicPage
+     * @NoCSRFRequired
+     * @NoSameSiteCookieRequired
+     *
+     * Generate svg from filename with the requested color
+     *
+     * @param string $folder
+     * @param string $fileName
+     * @param string $color
+     * @return DataDisplayResponse|NotFoundResponse
+     */
+    public function getSvgFromCore(string $folder, string $fileName, string $color = 'ffffff') {
+        $path = $this->serverRoot . "/core/img/$folder/$fileName.svg";
+        return $this->getSvg($path, $color, $fileName);
+    }
+
+    /**
+     * @PublicPage
+     * @NoCSRFRequired
+     * @NoSameSiteCookieRequired
+     *
+     * Generate svg from filename with the requested color
+     *
+     * @param string $app
+     * @param string $fileName
+     * @param string $color
+     * @return DataDisplayResponse|NotFoundResponse
+     */
+    public function getSvgFromApp(string $app, string $fileName, string $color = 'ffffff') {
+
+        if ($app === 'settings') {
+            $path = $this->serverRoot . "/settings/img/$fileName.svg";
+            return $this->getSvg($path, $color, $fileName);
+        }
+
+        $appRootPath = $this->appManager->getAppPath($app);
+        $appPath = substr($appRootPath, strlen($this->serverRoot));
+
+        if (!$appPath) {
+            return new NotFoundResponse();
+        }
+        $path = $this->serverRoot . $appPath ."/img/$fileName.svg";
+        return $this->getSvg($path, $color, $fileName);
+    }
+
+    /**
+     * Generate svg from filename with the requested color
+     *
+     * @param string $path
+     * @param string $color
+     * @return DataDisplayResponse|NotFoundResponse
+     */
+    private function getSvg(string $path, string $color, string $fileName) {
+        if (!file_exists($path)) {
+            return new NotFoundResponse();
+        }
+
+        $svg = file_get_contents($path);
+
+        if (is_null($svg)) {
+            return new NotFoundResponse();
+        }
+
+        // add fill (fill is not present on black elements)
+        $fillRe = '/<((circle|rect|path)((?!fill)[a-z0-9 =".\-#():;])+)\/>/mi';
+        $svg = preg_replace($fillRe, '<$1 fill="#' . $color . '"/>', $svg);
+
+        // replace any fill or stroke colors
+        $svg = preg_replace('/stroke="#([a-z0-9]{3,6})"/mi', 'stroke="#' . $color . '"', $svg);
+        $svg = preg_replace('/fill="#([a-z0-9]{3,6})"/mi', 'fill="#' . $color . '"', $svg);
+
+        $response = new DataDisplayResponse($svg, Http::STATUS_OK, ['Content-Type' => 'image/svg+xml']);
+
+        // Set cache control
+        $ttl = 31536000;
+        $response->cacheFor($ttl);
+        $response->addHeader('Content-Disposition', 'inline; filename="' . $fileName . '.svg"');
+        $expires = new \DateTime();
+        $expires->setTimestamp($this->timeFactory->getTime());
+        $expires->add(new \DateInterval('PT' . $ttl . 'S'));
+        $response->addHeader('Expires', $expires->format(\DateTime::RFC1123));
+        $response->addHeader('Pragma', 'cache');
+
+        return $response;
+    }
 }