nextcloud / server

lib/private/Files/ObjectStore/ObjectStoreStorage.php

Indentation +662 added lines, -662 removed lines

@@ -48,669 +48,669 @@
 use OCP\Files\Storage\IStorage;
 
 class ObjectStoreStorage extends \OC\Files\Storage\Common implements IChunkedFileWrite {
-	use CopyDirectory;
-
-	/**
-	 * @var \OCP\Files\ObjectStore\IObjectStore $objectStore
-	 */
-	protected $objectStore;
-	/**
-	 * @var string $id
-	 */
-	protected $id;
-	/**
-	 * @var \OC\User\User $user
-	 */
-	protected $user;
-
-	private $objectPrefix = 'urn:oid:';
-
-	private $logger;
-
-	/** @var bool */
-	protected $validateWrites = true;
-
-	public function __construct($params) {
-		if (isset($params['objectstore']) && $params['objectstore'] instanceof IObjectStore) {
-			$this->objectStore = $params['objectstore'];
-		} else {
-			throw new \Exception('missing IObjectStore instance');
-		}
-		if (isset($params['storageid'])) {
-			$this->id = 'object::store:' . $params['storageid'];
-		} else {
-			$this->id = 'object::store:' . $this->objectStore->getStorageId();
-		}
-		if (isset($params['objectPrefix'])) {
-			$this->objectPrefix = $params['objectPrefix'];
-		}
-		if (isset($params['validateWrites'])) {
-			$this->validateWrites = (bool)$params['validateWrites'];
-		}
-		//initialize cache with root directory in cache
-		if (!$this->is_dir('/')) {
-			$this->mkdir('/');
-		}
-
-		$this->logger = \OC::$server->getLogger();
-	}
-
-	public function mkdir($path) {
-		$path = $this->normalizePath($path);
-		if ($this->file_exists($path)) {
-			return false;
-		}
-
-		$mTime = time();
-		$data = [
-			'mimetype' => 'httpd/unix-directory',
-			'size' => 0,
-			'mtime' => $mTime,
-			'storage_mtime' => $mTime,
-			'permissions' => \OCP\Constants::PERMISSION_ALL,
-		];
-		if ($path === '') {
-			//create root on the fly
-			$data['etag'] = $this->getETag('');
-			$this->getCache()->put('', $data);
-			return true;
-		} else {
-			// if parent does not exist, create it
-			$parent = $this->normalizePath(dirname($path));
-			$parentType = $this->filetype($parent);
-			if ($parentType === false) {
-				if (!$this->mkdir($parent)) {
-					// something went wrong
-					return false;
-				}
-			} elseif ($parentType === 'file') {
-				// parent is a file
-				return false;
-			}
-			// finally create the new dir
-			$mTime = time(); // update mtime
-			$data['mtime'] = $mTime;
-			$data['storage_mtime'] = $mTime;
-			$data['etag'] = $this->getETag($path);
-			$this->getCache()->put($path, $data);
-			return true;
-		}
-	}
-
-	/**
-	 * @param string $path
-	 * @return string
-	 */
-	private function normalizePath($path) {
-		$path = trim($path, '/');
-		//FIXME why do we sometimes get a path like 'files//username'?
-		$path = str_replace('//', '/', $path);
-
-		// dirname('/folder') returns '.' but internally (in the cache) we store the root as ''
-		if (!$path || $path === '.') {
-			$path = '';
-		}
-
-		return $path;
-	}
-
-	/**
-	 * Object Stores use a NoopScanner because metadata is directly stored in
-	 * the file cache and cannot really scan the filesystem. The storage passed in is not used anywhere.
-	 *
-	 * @param string $path
-	 * @param \OC\Files\Storage\Storage (optional) the storage to pass to the scanner
-	 * @return \OC\Files\ObjectStore\NoopScanner
-	 */
-	public function getScanner($path = '', $storage = null) {
-		if (!$storage) {
-			$storage = $this;
-		}
-		if (!isset($this->scanner)) {
-			$this->scanner = new NoopScanner($storage);
-		}
-		return $this->scanner;
-	}
-
-	public function getId() {
-		return $this->id;
-	}
-
-	public function rmdir($path) {
-		$path = $this->normalizePath($path);
-		$entry = $this->getCache()->get($path);
-
-		if (!$entry || $entry->getMimeType() !== ICacheEntry::DIRECTORY_MIMETYPE) {
-			return false;
-		}
-
-		return $this->rmObjects($entry);
-	}
-
-	private function rmObjects(ICacheEntry $entry): bool {
-		$children = $this->getCache()->getFolderContentsById($entry->getId());
-		foreach ($children as $child) {
-			if ($child->getMimeType() === ICacheEntry::DIRECTORY_MIMETYPE) {
-				if (!$this->rmObjects($child)) {
-					return false;
-				}
-			} else {
-				if (!$this->rmObject($child)) {
-					return false;
-				}
-			}
-		}
-
-		$this->getCache()->remove($entry->getPath());
-
-		return true;
-	}
-
-	public function unlink($path) {
-		$path = $this->normalizePath($path);
-		$entry = $this->getCache()->get($path);
-
-		if ($entry instanceof ICacheEntry) {
-			if ($entry->getMimeType() === ICacheEntry::DIRECTORY_MIMETYPE) {
-				return $this->rmObjects($entry);
-			} else {
-				return $this->rmObject($entry);
-			}
-		}
-		return false;
-	}
-
-	public function rmObject(ICacheEntry $entry): bool {
-		try {
-			$this->objectStore->deleteObject($this->getURN($entry->getId()));
-		} catch (\Exception $ex) {
-			if ($ex->getCode() !== 404) {
-				$this->logger->logException($ex, [
-					'app' => 'objectstore',
-					'message' => 'Could not delete object ' . $this->getURN($entry->getId()) . ' for ' . $entry->getPath(),
-				]);
-				return false;
-			}
-			//removing from cache is ok as it does not exist in the objectstore anyway
-		}
-		$this->getCache()->remove($entry->getPath());
-		return true;
-	}
-
-	public function stat($path) {
-		$path = $this->normalizePath($path);
-		$cacheEntry = $this->getCache()->get($path);
-		if ($cacheEntry instanceof CacheEntry) {
-			return $cacheEntry->getData();
-		} else {
-			return false;
-		}
-	}
-
-	public function getPermissions($path) {
-		$stat = $this->stat($path);
-
-		if (is_array($stat) && isset($stat['permissions'])) {
-			return $stat['permissions'];
-		}
-
-		return parent::getPermissions($path);
-	}
-
-	/**
-	 * Override this method if you need a different unique resource identifier for your object storage implementation.
-	 * The default implementations just appends the fileId to 'urn:oid:'. Make sure the URN is unique over all users.
-	 * You may need a mapping table to store your URN if it cannot be generated from the fileid.
-	 *
-	 * @param int $fileId the fileid
-	 * @return null|string the unified resource name used to identify the object
-	 */
-	public function getURN($fileId) {
-		if (is_numeric($fileId)) {
-			return $this->objectPrefix . $fileId;
-		}
-		return null;
-	}
-
-	public function opendir($path) {
-		$path = $this->normalizePath($path);
-
-		try {
-			$files = [];
-			$folderContents = $this->getCache()->getFolderContents($path);
-			foreach ($folderContents as $file) {
-				$files[] = $file['name'];
-			}
-
-			return IteratorDirectory::wrap($files);
-		} catch (\Exception $e) {
-			$this->logger->logException($e);
-			return false;
-		}
-	}
-
-	public function filetype($path) {
-		$path = $this->normalizePath($path);
-		$stat = $this->stat($path);
-		if ($stat) {
-			if ($stat['mimetype'] === 'httpd/unix-directory') {
-				return 'dir';
-			}
-			return 'file';
-		} else {
-			return false;
-		}
-	}
-
-	public function fopen($path, $mode) {
-		$path = $this->normalizePath($path);
-
-		if (strrpos($path, '.') !== false) {
-			$ext = substr($path, strrpos($path, '.'));
-		} else {
-			$ext = '';
-		}
-
-		switch ($mode) {
-			case 'r':
-			case 'rb':
-				$stat = $this->stat($path);
-				if (is_array($stat)) {
-					$filesize = $stat['size'] ?? 0;
-					// Reading 0 sized files is a waste of time
-					if ($filesize === 0) {
-						return fopen('php://memory', $mode);
-					}
-
-					try {
-						$handle = $this->objectStore->readObject($this->getURN($stat['fileid']));
-						if ($handle === false) {
-							return false; // keep backward compatibility
-						}
-						$streamStat = fstat($handle);
-						$actualSize = $streamStat['size'] ?? -1;
-						if ($actualSize > -1 && $actualSize !== $filesize) {
-							$this->getCache()->update((int)$stat['fileid'], ['size' => $actualSize]);
-						}
-						return $handle;
-					} catch (NotFoundException $e) {
-						$this->logger->logException($e, [
-							'app' => 'objectstore',
-							'message' => 'Could not get object ' . $this->getURN($stat['fileid']) . ' for file ' . $path,
-						]);
-						throw $e;
-					} catch (\Exception $ex) {
-						$this->logger->logException($ex, [
-							'app' => 'objectstore',
-							'message' => 'Could not get object ' . $this->getURN($stat['fileid']) . ' for file ' . $path,
-						]);
-						return false;
-					}
-				} else {
-					return false;
-				}
-				// no break
-			case 'w':
-			case 'wb':
-			case 'w+':
-			case 'wb+':
-				$tmpFile = \OC::$server->getTempManager()->getTemporaryFile($ext);
-				$handle = fopen($tmpFile, $mode);
-				return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
-					$this->writeBack($tmpFile, $path);
-					unlink($tmpFile);
-				});
-			case 'a':
-			case 'ab':
-			case 'r+':
-			case 'a+':
-			case 'x':
-			case 'x+':
-			case 'c':
-			case 'c+':
-				$tmpFile = \OC::$server->getTempManager()->getTemporaryFile($ext);
-				if ($this->file_exists($path)) {
-					$source = $this->fopen($path, 'r');
-					file_put_contents($tmpFile, $source);
-				}
-				$handle = fopen($tmpFile, $mode);
-				return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
-					$this->writeBack($tmpFile, $path);
-					unlink($tmpFile);
-				});
-		}
-		return false;
-	}
-
-	public function file_exists($path) {
-		$path = $this->normalizePath($path);
-		return (bool)$this->stat($path);
-	}
-
-	public function rename($source, $target) {
-		$source = $this->normalizePath($source);
-		$target = $this->normalizePath($target);
-		$this->remove($target);
-		$this->getCache()->move($source, $target);
-		$this->touch(dirname($target));
-		return true;
-	}
-
-	public function getMimeType($path) {
-		$path = $this->normalizePath($path);
-		return parent::getMimeType($path);
-	}
-
-	public function touch($path, $mtime = null) {
-		if (is_null($mtime)) {
-			$mtime = time();
-		}
-
-		$path = $this->normalizePath($path);
-		$dirName = dirname($path);
-		$parentExists = $this->is_dir($dirName);
-		if (!$parentExists) {
-			return false;
-		}
-
-		$stat = $this->stat($path);
-		if (is_array($stat)) {
-			// update existing mtime in db
-			$stat['mtime'] = $mtime;
-			$this->getCache()->update($stat['fileid'], $stat);
-		} else {
-			try {
-				//create a empty file, need to have at least on char to make it
-				// work with all object storage implementations
-				$this->file_put_contents($path, ' ');
-				$mimeType = \OC::$server->getMimeTypeDetector()->detectPath($path);
-				$stat = [
-					'etag' => $this->getETag($path),
-					'mimetype' => $mimeType,
-					'size' => 0,
-					'mtime' => $mtime,
-					'storage_mtime' => $mtime,
-					'permissions' => \OCP\Constants::PERMISSION_ALL - \OCP\Constants::PERMISSION_CREATE,
-				];
-				$this->getCache()->put($path, $stat);
-			} catch (\Exception $ex) {
-				$this->logger->logException($ex, [
-					'app' => 'objectstore',
-					'message' => 'Could not create object for ' . $path,
-				]);
-				throw $ex;
-			}
-		}
-		return true;
-	}
-
-	public function writeBack($tmpFile, $path) {
-		$size = filesize($tmpFile);
-		$this->writeStream($path, fopen($tmpFile, 'r'), $size);
-	}
-
-	/**
-	 * external changes are not supported, exclusive access to the object storage is assumed
-	 *
-	 * @param string $path
-	 * @param int $time
-	 * @return false
-	 */
-	public function hasUpdated($path, $time) {
-		return false;
-	}
-
-	public function needsPartFile() {
-		return false;
-	}
-
-	public function file_put_contents($path, $data) {
-		$handle = $this->fopen($path, 'w+');
-		$result = fwrite($handle, $data);
-		fclose($handle);
-		return $result;
-	}
-
-	public function writeStream(string $path, $stream, int $size = null): int {
-		$stat = $this->stat($path);
-		if (empty($stat)) {
-			// create new file
-			$stat = [
-				'permissions' => \OCP\Constants::PERMISSION_ALL - \OCP\Constants::PERMISSION_CREATE,
-			];
-		}
-		// update stat with new data
-		$mTime = time();
-		$stat['size'] = (int)$size;
-		$stat['mtime'] = $mTime;
-		$stat['storage_mtime'] = $mTime;
-
-		$mimetypeDetector = \OC::$server->getMimeTypeDetector();
-		$mimetype = $mimetypeDetector->detectPath($path);
-
-		$stat['mimetype'] = $mimetype;
-		$stat['etag'] = $this->getETag($path);
-		$stat['checksum'] = '';
-
-		$exists = $this->getCache()->inCache($path);
-		$uploadPath = $exists ? $path : $path . '.part';
-
-		if ($exists) {
-			$fileId = $stat['fileid'];
-		} else {
-			$fileId = $this->getCache()->put($uploadPath, $stat);
-		}
-
-		$urn = $this->getURN($fileId);
-		try {
-			//upload to object storage
-			if ($size === null) {
-				$countStream = CountWrapper::wrap($stream, function ($writtenSize) use ($fileId, &$size) {
-					$this->getCache()->update($fileId, [
-						'size' => $writtenSize,
-					]);
-					$size = $writtenSize;
-				});
-				$this->objectStore->writeObject($urn, $countStream, $mimetype);
-				if (is_resource($countStream)) {
-					fclose($countStream);
-				}
-				$stat['size'] = $size;
-			} else {
-				$this->objectStore->writeObject($urn, $stream, $mimetype);
-				if (is_resource($stream)) {
-					fclose($stream);
-				}
-			}
-		} catch (\Exception $ex) {
-			if (!$exists) {
-				/*
+    use CopyDirectory;
+
+    /**
+     * @var \OCP\Files\ObjectStore\IObjectStore $objectStore
+     */
+    protected $objectStore;
+    /**
+     * @var string $id
+     */
+    protected $id;
+    /**
+     * @var \OC\User\User $user
+     */
+    protected $user;
+
+    private $objectPrefix = 'urn:oid:';
+
+    private $logger;
+
+    /** @var bool */
+    protected $validateWrites = true;
+
+    public function __construct($params) {
+        if (isset($params['objectstore']) && $params['objectstore'] instanceof IObjectStore) {
+            $this->objectStore = $params['objectstore'];
+        } else {
+            throw new \Exception('missing IObjectStore instance');
+        }
+        if (isset($params['storageid'])) {
+            $this->id = 'object::store:' . $params['storageid'];
+        } else {
+            $this->id = 'object::store:' . $this->objectStore->getStorageId();
+        }
+        if (isset($params['objectPrefix'])) {
+            $this->objectPrefix = $params['objectPrefix'];
+        }
+        if (isset($params['validateWrites'])) {
+            $this->validateWrites = (bool)$params['validateWrites'];
+        }
+        //initialize cache with root directory in cache
+        if (!$this->is_dir('/')) {
+            $this->mkdir('/');
+        }
+
+        $this->logger = \OC::$server->getLogger();
+    }
+
+    public function mkdir($path) {
+        $path = $this->normalizePath($path);
+        if ($this->file_exists($path)) {
+            return false;
+        }
+
+        $mTime = time();
+        $data = [
+            'mimetype' => 'httpd/unix-directory',
+            'size' => 0,
+            'mtime' => $mTime,
+            'storage_mtime' => $mTime,
+            'permissions' => \OCP\Constants::PERMISSION_ALL,
+        ];
+        if ($path === '') {
+            //create root on the fly
+            $data['etag'] = $this->getETag('');
+            $this->getCache()->put('', $data);
+            return true;
+        } else {
+            // if parent does not exist, create it
+            $parent = $this->normalizePath(dirname($path));
+            $parentType = $this->filetype($parent);
+            if ($parentType === false) {
+                if (!$this->mkdir($parent)) {
+                    // something went wrong
+                    return false;
+                }
+            } elseif ($parentType === 'file') {
+                // parent is a file
+                return false;
+            }
+            // finally create the new dir
+            $mTime = time(); // update mtime
+            $data['mtime'] = $mTime;
+            $data['storage_mtime'] = $mTime;
+            $data['etag'] = $this->getETag($path);
+            $this->getCache()->put($path, $data);
+            return true;
+        }
+    }
+
+    /**
+     * @param string $path
+     * @return string
+     */
+    private function normalizePath($path) {
+        $path = trim($path, '/');
+        //FIXME why do we sometimes get a path like 'files//username'?
+        $path = str_replace('//', '/', $path);
+
+        // dirname('/folder') returns '.' but internally (in the cache) we store the root as ''
+        if (!$path || $path === '.') {
+            $path = '';
+        }
+
+        return $path;
+    }
+
+    /**
+     * Object Stores use a NoopScanner because metadata is directly stored in
+     * the file cache and cannot really scan the filesystem. The storage passed in is not used anywhere.
+     *
+     * @param string $path
+     * @param \OC\Files\Storage\Storage (optional) the storage to pass to the scanner
+     * @return \OC\Files\ObjectStore\NoopScanner
+     */
+    public function getScanner($path = '', $storage = null) {
+        if (!$storage) {
+            $storage = $this;
+        }
+        if (!isset($this->scanner)) {
+            $this->scanner = new NoopScanner($storage);
+        }
+        return $this->scanner;
+    }
+
+    public function getId() {
+        return $this->id;
+    }
+
+    public function rmdir($path) {
+        $path = $this->normalizePath($path);
+        $entry = $this->getCache()->get($path);
+
+        if (!$entry || $entry->getMimeType() !== ICacheEntry::DIRECTORY_MIMETYPE) {
+            return false;
+        }
+
+        return $this->rmObjects($entry);
+    }
+
+    private function rmObjects(ICacheEntry $entry): bool {
+        $children = $this->getCache()->getFolderContentsById($entry->getId());
+        foreach ($children as $child) {
+            if ($child->getMimeType() === ICacheEntry::DIRECTORY_MIMETYPE) {
+                if (!$this->rmObjects($child)) {
+                    return false;
+                }
+            } else {
+                if (!$this->rmObject($child)) {
+                    return false;
+                }
+            }
+        }
+
+        $this->getCache()->remove($entry->getPath());
+
+        return true;
+    }
+
+    public function unlink($path) {
+        $path = $this->normalizePath($path);
+        $entry = $this->getCache()->get($path);
+
+        if ($entry instanceof ICacheEntry) {
+            if ($entry->getMimeType() === ICacheEntry::DIRECTORY_MIMETYPE) {
+                return $this->rmObjects($entry);
+            } else {
+                return $this->rmObject($entry);
+            }
+        }
+        return false;
+    }
+
+    public function rmObject(ICacheEntry $entry): bool {
+        try {
+            $this->objectStore->deleteObject($this->getURN($entry->getId()));
+        } catch (\Exception $ex) {
+            if ($ex->getCode() !== 404) {
+                $this->logger->logException($ex, [
+                    'app' => 'objectstore',
+                    'message' => 'Could not delete object ' . $this->getURN($entry->getId()) . ' for ' . $entry->getPath(),
+                ]);
+                return false;
+            }
+            //removing from cache is ok as it does not exist in the objectstore anyway
+        }
+        $this->getCache()->remove($entry->getPath());
+        return true;
+    }
+
+    public function stat($path) {
+        $path = $this->normalizePath($path);
+        $cacheEntry = $this->getCache()->get($path);
+        if ($cacheEntry instanceof CacheEntry) {
+            return $cacheEntry->getData();
+        } else {
+            return false;
+        }
+    }
+
+    public function getPermissions($path) {
+        $stat = $this->stat($path);
+
+        if (is_array($stat) && isset($stat['permissions'])) {
+            return $stat['permissions'];
+        }
+
+        return parent::getPermissions($path);
+    }
+
+    /**
+     * Override this method if you need a different unique resource identifier for your object storage implementation.
+     * The default implementations just appends the fileId to 'urn:oid:'. Make sure the URN is unique over all users.
+     * You may need a mapping table to store your URN if it cannot be generated from the fileid.
+     *
+     * @param int $fileId the fileid
+     * @return null|string the unified resource name used to identify the object
+     */
+    public function getURN($fileId) {
+        if (is_numeric($fileId)) {
+            return $this->objectPrefix . $fileId;
+        }
+        return null;
+    }
+
+    public function opendir($path) {
+        $path = $this->normalizePath($path);
+
+        try {
+            $files = [];
+            $folderContents = $this->getCache()->getFolderContents($path);
+            foreach ($folderContents as $file) {
+                $files[] = $file['name'];
+            }
+
+            return IteratorDirectory::wrap($files);
+        } catch (\Exception $e) {
+            $this->logger->logException($e);
+            return false;
+        }
+    }
+
+    public function filetype($path) {
+        $path = $this->normalizePath($path);
+        $stat = $this->stat($path);
+        if ($stat) {
+            if ($stat['mimetype'] === 'httpd/unix-directory') {
+                return 'dir';
+            }
+            return 'file';
+        } else {
+            return false;
+        }
+    }
+
+    public function fopen($path, $mode) {
+        $path = $this->normalizePath($path);
+
+        if (strrpos($path, '.') !== false) {
+            $ext = substr($path, strrpos($path, '.'));
+        } else {
+            $ext = '';
+        }
+
+        switch ($mode) {
+            case 'r':
+            case 'rb':
+                $stat = $this->stat($path);
+                if (is_array($stat)) {
+                    $filesize = $stat['size'] ?? 0;
+                    // Reading 0 sized files is a waste of time
+                    if ($filesize === 0) {
+                        return fopen('php://memory', $mode);
+                    }
+
+                    try {
+                        $handle = $this->objectStore->readObject($this->getURN($stat['fileid']));
+                        if ($handle === false) {
+                            return false; // keep backward compatibility
+                        }
+                        $streamStat = fstat($handle);
+                        $actualSize = $streamStat['size'] ?? -1;
+                        if ($actualSize > -1 && $actualSize !== $filesize) {
+                            $this->getCache()->update((int)$stat['fileid'], ['size' => $actualSize]);
+                        }
+                        return $handle;
+                    } catch (NotFoundException $e) {
+                        $this->logger->logException($e, [
+                            'app' => 'objectstore',
+                            'message' => 'Could not get object ' . $this->getURN($stat['fileid']) . ' for file ' . $path,
+                        ]);
+                        throw $e;
+                    } catch (\Exception $ex) {
+                        $this->logger->logException($ex, [
+                            'app' => 'objectstore',
+                            'message' => 'Could not get object ' . $this->getURN($stat['fileid']) . ' for file ' . $path,
+                        ]);
+                        return false;
+                    }
+                } else {
+                    return false;
+                }
+                // no break
+            case 'w':
+            case 'wb':
+            case 'w+':
+            case 'wb+':
+                $tmpFile = \OC::$server->getTempManager()->getTemporaryFile($ext);
+                $handle = fopen($tmpFile, $mode);
+                return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
+                    $this->writeBack($tmpFile, $path);
+                    unlink($tmpFile);
+                });
+            case 'a':
+            case 'ab':
+            case 'r+':
+            case 'a+':
+            case 'x':
+            case 'x+':
+            case 'c':
+            case 'c+':
+                $tmpFile = \OC::$server->getTempManager()->getTemporaryFile($ext);
+                if ($this->file_exists($path)) {
+                    $source = $this->fopen($path, 'r');
+                    file_put_contents($tmpFile, $source);
+                }
+                $handle = fopen($tmpFile, $mode);
+                return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
+                    $this->writeBack($tmpFile, $path);
+                    unlink($tmpFile);
+                });
+        }
+        return false;
+    }
+
+    public function file_exists($path) {
+        $path = $this->normalizePath($path);
+        return (bool)$this->stat($path);
+    }
+
+    public function rename($source, $target) {
+        $source = $this->normalizePath($source);
+        $target = $this->normalizePath($target);
+        $this->remove($target);
+        $this->getCache()->move($source, $target);
+        $this->touch(dirname($target));
+        return true;
+    }
+
+    public function getMimeType($path) {
+        $path = $this->normalizePath($path);
+        return parent::getMimeType($path);
+    }
+
+    public function touch($path, $mtime = null) {
+        if (is_null($mtime)) {
+            $mtime = time();
+        }
+
+        $path = $this->normalizePath($path);
+        $dirName = dirname($path);
+        $parentExists = $this->is_dir($dirName);
+        if (!$parentExists) {
+            return false;
+        }
+
+        $stat = $this->stat($path);
+        if (is_array($stat)) {
+            // update existing mtime in db
+            $stat['mtime'] = $mtime;
+            $this->getCache()->update($stat['fileid'], $stat);
+        } else {
+            try {
+                //create a empty file, need to have at least on char to make it
+                // work with all object storage implementations
+                $this->file_put_contents($path, ' ');
+                $mimeType = \OC::$server->getMimeTypeDetector()->detectPath($path);
+                $stat = [
+                    'etag' => $this->getETag($path),
+                    'mimetype' => $mimeType,
+                    'size' => 0,
+                    'mtime' => $mtime,
+                    'storage_mtime' => $mtime,
+                    'permissions' => \OCP\Constants::PERMISSION_ALL - \OCP\Constants::PERMISSION_CREATE,
+                ];
+                $this->getCache()->put($path, $stat);
+            } catch (\Exception $ex) {
+                $this->logger->logException($ex, [
+                    'app' => 'objectstore',
+                    'message' => 'Could not create object for ' . $path,
+                ]);
+                throw $ex;
+            }
+        }
+        return true;
+    }
+
+    public function writeBack($tmpFile, $path) {
+        $size = filesize($tmpFile);
+        $this->writeStream($path, fopen($tmpFile, 'r'), $size);
+    }
+
+    /**
+     * external changes are not supported, exclusive access to the object storage is assumed
+     *
+     * @param string $path
+     * @param int $time
+     * @return false
+     */
+    public function hasUpdated($path, $time) {
+        return false;
+    }
+
+    public function needsPartFile() {
+        return false;
+    }
+
+    public function file_put_contents($path, $data) {
+        $handle = $this->fopen($path, 'w+');
+        $result = fwrite($handle, $data);
+        fclose($handle);
+        return $result;
+    }
+
+    public function writeStream(string $path, $stream, int $size = null): int {
+        $stat = $this->stat($path);
+        if (empty($stat)) {
+            // create new file
+            $stat = [
+                'permissions' => \OCP\Constants::PERMISSION_ALL - \OCP\Constants::PERMISSION_CREATE,
+            ];
+        }
+        // update stat with new data
+        $mTime = time();
+        $stat['size'] = (int)$size;
+        $stat['mtime'] = $mTime;
+        $stat['storage_mtime'] = $mTime;
+
+        $mimetypeDetector = \OC::$server->getMimeTypeDetector();
+        $mimetype = $mimetypeDetector->detectPath($path);
+
+        $stat['mimetype'] = $mimetype;
+        $stat['etag'] = $this->getETag($path);
+        $stat['checksum'] = '';
+
+        $exists = $this->getCache()->inCache($path);
+        $uploadPath = $exists ? $path : $path . '.part';
+
+        if ($exists) {
+            $fileId = $stat['fileid'];
+        } else {
+            $fileId = $this->getCache()->put($uploadPath, $stat);
+        }
+
+        $urn = $this->getURN($fileId);
+        try {
+            //upload to object storage
+            if ($size === null) {
+                $countStream = CountWrapper::wrap($stream, function ($writtenSize) use ($fileId, &$size) {
+                    $this->getCache()->update($fileId, [
+                        'size' => $writtenSize,
+                    ]);
+                    $size = $writtenSize;
+                });
+                $this->objectStore->writeObject($urn, $countStream, $mimetype);
+                if (is_resource($countStream)) {
+                    fclose($countStream);
+                }
+                $stat['size'] = $size;
+            } else {
+                $this->objectStore->writeObject($urn, $stream, $mimetype);
+                if (is_resource($stream)) {
+                    fclose($stream);
+                }
+            }
+        } catch (\Exception $ex) {
+            if (!$exists) {
+                /*
 				 * Only remove the entry if we are dealing with a new file.
 				 * Else people lose access to existing files
 				 */
-				$this->getCache()->remove($uploadPath);
-				$this->logger->logException($ex, [
-					'app' => 'objectstore',
-					'message' => 'Could not create object ' . $urn . ' for ' . $path,
-				]);
-			} else {
-				$this->logger->logException($ex, [
-					'app' => 'objectstore',
-					'message' => 'Could not update object ' . $urn . ' for ' . $path,
-				]);
-			}
-			throw $ex; // make this bubble up
-		}
-
-		if ($exists) {
-			$this->getCache()->update($fileId, $stat);
-		} else {
-			if (!$this->validateWrites || $this->objectStore->objectExists($urn)) {
-				$this->getCache()->move($uploadPath, $path);
-			} else {
-				$this->getCache()->remove($uploadPath);
-				throw new \Exception("Object not found after writing (urn: $urn, path: $path)", 404);
-			}
-		}
-
-		return $size;
-	}
-
-	public function getObjectStore(): IObjectStore {
-		return $this->objectStore;
-	}
-
-	public function copyFromStorage(
-		IStorage $sourceStorage,
-		$sourceInternalPath,
-		$targetInternalPath,
-		$preserveMtime = false
-	) {
-		if ($sourceStorage->instanceOfStorage(ObjectStoreStorage::class)) {
-			/** @var ObjectStoreStorage $sourceStorage */
-			if ($sourceStorage->getObjectStore()->getStorageId() === $this->getObjectStore()->getStorageId()) {
-				/** @var CacheEntry $sourceEntry */
-				$sourceEntry = $sourceStorage->getCache()->get($sourceInternalPath);
-				$sourceEntryData = $sourceEntry->getData();
-				// $sourceEntry['permissions'] here is the permissions from the jailed storage for the current
-				// user. Instead we use $sourceEntryData['scan_permissions'] that are the permissions from the
-				// unjailed storage.
-				if (is_array($sourceEntryData) && array_key_exists('scan_permissions', $sourceEntryData)) {
-					$sourceEntry['permissions'] = $sourceEntryData['scan_permissions'];
-				}
-				$this->copyInner($sourceEntry, $targetInternalPath);
-				return true;
-			}
-		}
-
-		return parent::copyFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath);
-	}
-
-	public function copy($source, $target) {
-		$source = $this->normalizePath($source);
-		$target = $this->normalizePath($target);
-
-		$cache = $this->getCache();
-		$sourceEntry = $cache->get($source);
-		if (!$sourceEntry) {
-			throw new NotFoundException('Source object not found');
-		}
-
-		$this->copyInner($sourceEntry, $target);
-
-		return true;
-	}
-
-	private function copyInner(ICacheEntry $sourceEntry, string $to) {
-		$cache = $this->getCache();
-
-		if ($sourceEntry->getMimeType() === FileInfo::MIMETYPE_FOLDER) {
-			if ($cache->inCache($to)) {
-				$cache->remove($to);
-			}
-			$this->mkdir($to);
-
-			foreach ($cache->getFolderContentsById($sourceEntry->getId()) as $child) {
-				$this->copyInner($child, $to . '/' . $child->getName());
-			}
-		} else {
-			$this->copyFile($sourceEntry, $to);
-		}
-	}
-
-	private function copyFile(ICacheEntry $sourceEntry, string $to) {
-		$cache = $this->getCache();
-
-		$sourceUrn = $this->getURN($sourceEntry->getId());
-
-		if (!$cache instanceof Cache) {
-			throw new \Exception("Invalid source cache for object store copy");
-		}
-
-		$targetId = $cache->copyFromCache($cache, $sourceEntry, $to);
-
-		$targetUrn = $this->getURN($targetId);
-
-		try {
-			$this->objectStore->copyObject($sourceUrn, $targetUrn);
-		} catch (\Exception $e) {
-			$cache->remove($to);
-
-			throw $e;
-		}
-	}
-
-	public function startChunkedWrite(string $targetPath): string {
-		if (!$this->objectStore instanceof IObjectStoreMultiPartUpload) {
-			throw new GenericFileException('Object store does not support multipart upload');
-		}
-		$cacheEntry = $this->getCache()->get($targetPath);
-		$urn = $this->getURN($cacheEntry->getId());
-		return $this->objectStore->initiateMultipartUpload($urn);
-	}
-
-	/**
-	 *
-	 * @throws GenericFileException
-	 */
-	public function putChunkedWritePart(
-		string $targetPath,
-		string $writeToken,
-		string $chunkId,
-		$data,
-		$size = null
-	): ?array {
-		if (!$this->objectStore instanceof IObjectStoreMultiPartUpload) {
-			throw new GenericFileException('Object store does not support multipart upload');
-		}
-		$cacheEntry = $this->getCache()->get($targetPath);
-		$urn = $this->getURN($cacheEntry->getId());
-
-		$result = $this->objectStore->uploadMultipartPart($urn, $writeToken, (int)$chunkId, $data, $size);
-
-		$parts[$chunkId] = [
-			'PartNumber' => $chunkId,
-			'ETag' => trim($result->get('ETag'), '"'),
-		];
-		return $parts[$chunkId];
-	}
-
-	public function completeChunkedWrite(string $targetPath, string $writeToken): int {
-		if (!$this->objectStore instanceof IObjectStoreMultiPartUpload) {
-			throw new GenericFileException('Object store does not support multipart upload');
-		}
-		$cacheEntry = $this->getCache()->get($targetPath);
-		$urn = $this->getURN($cacheEntry->getId());
-		$parts = $this->objectStore->getMultipartUploads($urn, $writeToken);
-		$sortedParts = array_values($parts);
-		sort($sortedParts);
-		try {
-			$size = $this->objectStore->completeMultipartUpload($urn, $writeToken, $sortedParts);
-			$stat = $this->stat($targetPath);
-			$mtime = time();
-			if (is_array($stat)) {
-				$stat['size'] = $size;
-				$stat['mtime'] = $mtime;
-				$stat['mimetype'] = $this->getMimeType($targetPath);
-				$this->getCache()->update($stat['fileid'], $stat);
-			}
-		} catch (S3MultipartUploadException|S3Exception $e) {
-			$this->objectStore->abortMultipartUpload($urn, $writeToken);
-			$this->logger->logException($e, [
-				'app' => 'objectstore',
-				'message' => 'Could not compete multipart upload ' . $urn . ' with uploadId ' . $writeToken,
-			]);
-			throw new GenericFileException('Could not write chunked file');
-		}
-		return $size;
-	}
-
-	public function cancelChunkedWrite(string $targetPath, string $writeToken): void {
-		if (!$this->objectStore instanceof IObjectStoreMultiPartUpload) {
-			throw new GenericFileException('Object store does not support multipart upload');
-		}
-		$cacheEntry = $this->getCache()->get($targetPath);
-		$urn = $this->getURN($cacheEntry->getId());
-		$this->objectStore->abortMultipartUpload($urn, $writeToken);
-	}
+                $this->getCache()->remove($uploadPath);
+                $this->logger->logException($ex, [
+                    'app' => 'objectstore',
+                    'message' => 'Could not create object ' . $urn . ' for ' . $path,
+                ]);
+            } else {
+                $this->logger->logException($ex, [
+                    'app' => 'objectstore',
+                    'message' => 'Could not update object ' . $urn . ' for ' . $path,
+                ]);
+            }
+            throw $ex; // make this bubble up
+        }
+
+        if ($exists) {
+            $this->getCache()->update($fileId, $stat);
+        } else {
+            if (!$this->validateWrites || $this->objectStore->objectExists($urn)) {
+                $this->getCache()->move($uploadPath, $path);
+            } else {
+                $this->getCache()->remove($uploadPath);
+                throw new \Exception("Object not found after writing (urn: $urn, path: $path)", 404);
+            }
+        }
+
+        return $size;
+    }
+
+    public function getObjectStore(): IObjectStore {
+        return $this->objectStore;
+    }
+
+    public function copyFromStorage(
+        IStorage $sourceStorage,
+        $sourceInternalPath,
+        $targetInternalPath,
+        $preserveMtime = false
+    ) {
+        if ($sourceStorage->instanceOfStorage(ObjectStoreStorage::class)) {
+            /** @var ObjectStoreStorage $sourceStorage */
+            if ($sourceStorage->getObjectStore()->getStorageId() === $this->getObjectStore()->getStorageId()) {
+                /** @var CacheEntry $sourceEntry */
+                $sourceEntry = $sourceStorage->getCache()->get($sourceInternalPath);
+                $sourceEntryData = $sourceEntry->getData();
+                // $sourceEntry['permissions'] here is the permissions from the jailed storage for the current
+                // user. Instead we use $sourceEntryData['scan_permissions'] that are the permissions from the
+                // unjailed storage.
+                if (is_array($sourceEntryData) && array_key_exists('scan_permissions', $sourceEntryData)) {
+                    $sourceEntry['permissions'] = $sourceEntryData['scan_permissions'];
+                }
+                $this->copyInner($sourceEntry, $targetInternalPath);
+                return true;
+            }
+        }
+
+        return parent::copyFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath);
+    }
+
+    public function copy($source, $target) {
+        $source = $this->normalizePath($source);
+        $target = $this->normalizePath($target);
+
+        $cache = $this->getCache();
+        $sourceEntry = $cache->get($source);
+        if (!$sourceEntry) {
+            throw new NotFoundException('Source object not found');
+        }
+
+        $this->copyInner($sourceEntry, $target);
+
+        return true;
+    }
+
+    private function copyInner(ICacheEntry $sourceEntry, string $to) {
+        $cache = $this->getCache();
+
+        if ($sourceEntry->getMimeType() === FileInfo::MIMETYPE_FOLDER) {
+            if ($cache->inCache($to)) {
+                $cache->remove($to);
+            }
+            $this->mkdir($to);
+
+            foreach ($cache->getFolderContentsById($sourceEntry->getId()) as $child) {
+                $this->copyInner($child, $to . '/' . $child->getName());
+            }
+        } else {
+            $this->copyFile($sourceEntry, $to);
+        }
+    }
+
+    private function copyFile(ICacheEntry $sourceEntry, string $to) {
+        $cache = $this->getCache();
+
+        $sourceUrn = $this->getURN($sourceEntry->getId());
+
+        if (!$cache instanceof Cache) {
+            throw new \Exception("Invalid source cache for object store copy");
+        }
+
+        $targetId = $cache->copyFromCache($cache, $sourceEntry, $to);
+
+        $targetUrn = $this->getURN($targetId);
+
+        try {
+            $this->objectStore->copyObject($sourceUrn, $targetUrn);
+        } catch (\Exception $e) {
+            $cache->remove($to);
+
+            throw $e;
+        }
+    }
+
+    public function startChunkedWrite(string $targetPath): string {
+        if (!$this->objectStore instanceof IObjectStoreMultiPartUpload) {
+            throw new GenericFileException('Object store does not support multipart upload');
+        }
+        $cacheEntry = $this->getCache()->get($targetPath);
+        $urn = $this->getURN($cacheEntry->getId());
+        return $this->objectStore->initiateMultipartUpload($urn);
+    }
+
+    /**
+     *
+     * @throws GenericFileException
+     */
+    public function putChunkedWritePart(
+        string $targetPath,
+        string $writeToken,
+        string $chunkId,
+        $data,
+        $size = null
+    ): ?array {
+        if (!$this->objectStore instanceof IObjectStoreMultiPartUpload) {
+            throw new GenericFileException('Object store does not support multipart upload');
+        }
+        $cacheEntry = $this->getCache()->get($targetPath);
+        $urn = $this->getURN($cacheEntry->getId());
+
+        $result = $this->objectStore->uploadMultipartPart($urn, $writeToken, (int)$chunkId, $data, $size);
+
+        $parts[$chunkId] = [
+            'PartNumber' => $chunkId,
+            'ETag' => trim($result->get('ETag'), '"'),
+        ];
+        return $parts[$chunkId];
+    }
+
+    public function completeChunkedWrite(string $targetPath, string $writeToken): int {
+        if (!$this->objectStore instanceof IObjectStoreMultiPartUpload) {
+            throw new GenericFileException('Object store does not support multipart upload');
+        }
+        $cacheEntry = $this->getCache()->get($targetPath);
+        $urn = $this->getURN($cacheEntry->getId());
+        $parts = $this->objectStore->getMultipartUploads($urn, $writeToken);
+        $sortedParts = array_values($parts);
+        sort($sortedParts);
+        try {
+            $size = $this->objectStore->completeMultipartUpload($urn, $writeToken, $sortedParts);
+            $stat = $this->stat($targetPath);
+            $mtime = time();
+            if (is_array($stat)) {
+                $stat['size'] = $size;
+                $stat['mtime'] = $mtime;
+                $stat['mimetype'] = $this->getMimeType($targetPath);
+                $this->getCache()->update($stat['fileid'], $stat);
+            }
+        } catch (S3MultipartUploadException|S3Exception $e) {
+            $this->objectStore->abortMultipartUpload($urn, $writeToken);
+            $this->logger->logException($e, [
+                'app' => 'objectstore',
+                'message' => 'Could not compete multipart upload ' . $urn . ' with uploadId ' . $writeToken,
+            ]);
+            throw new GenericFileException('Could not write chunked file');
+        }
+        return $size;
+    }
+
+    public function cancelChunkedWrite(string $targetPath, string $writeToken): void {
+        if (!$this->objectStore instanceof IObjectStoreMultiPartUpload) {
+            throw new GenericFileException('Object store does not support multipart upload');
+        }
+        $cacheEntry = $this->getCache()->get($targetPath);
+        $urn = $this->getURN($cacheEntry->getId());
+        $this->objectStore->abortMultipartUpload($urn, $writeToken);
+    }
 }

Spacing +21 added lines, -21 removed lines

@@ -77,15 +77,15 @@ 
 			throw new \Exception('missing IObjectStore instance');
 		}
 		if (isset($params['storageid'])) {
-			$this->id = 'object::store:' . $params['storageid'];
+			$this->id = 'object::store:'.$params['storageid'];
 		} else {
-			$this->id = 'object::store:' . $this->objectStore->getStorageId();
+			$this->id = 'object::store:'.$this->objectStore->getStorageId();
 		}
 		if (isset($params['objectPrefix'])) {
 			$this->objectPrefix = $params['objectPrefix'];
 		}
 		if (isset($params['validateWrites'])) {
-			$this->validateWrites = (bool)$params['validateWrites'];
+			$this->validateWrites = (bool) $params['validateWrites'];
 		}
 		//initialize cache with root directory in cache
 		if (!$this->is_dir('/')) {
@@ -227,7 +227,7 @@ 
 			if ($ex->getCode() !== 404) {
 				$this->logger->logException($ex, [
 					'app' => 'objectstore',
-					'message' => 'Could not delete object ' . $this->getURN($entry->getId()) . ' for ' . $entry->getPath(),
+					'message' => 'Could not delete object '.$this->getURN($entry->getId()).' for '.$entry->getPath(),
 				]);
 				return false;
 			}
@@ -267,7 +267,7 @@ 
 	 */
 	public function getURN($fileId) {
 		if (is_numeric($fileId)) {
-			return $this->objectPrefix . $fileId;
+			return $this->objectPrefix.$fileId;
 		}
 		return null;
 	}
@@ -330,19 +330,19 @@ 
 						$streamStat = fstat($handle);
 						$actualSize = $streamStat['size'] ?? -1;
 						if ($actualSize > -1 && $actualSize !== $filesize) {
-							$this->getCache()->update((int)$stat['fileid'], ['size' => $actualSize]);
+							$this->getCache()->update((int) $stat['fileid'], ['size' => $actualSize]);
 						}
 						return $handle;
 					} catch (NotFoundException $e) {
 						$this->logger->logException($e, [
 							'app' => 'objectstore',
-							'message' => 'Could not get object ' . $this->getURN($stat['fileid']) . ' for file ' . $path,
+							'message' => 'Could not get object '.$this->getURN($stat['fileid']).' for file '.$path,
 						]);
 						throw $e;
 					} catch (\Exception $ex) {
 						$this->logger->logException($ex, [
 							'app' => 'objectstore',
-							'message' => 'Could not get object ' . $this->getURN($stat['fileid']) . ' for file ' . $path,
+							'message' => 'Could not get object '.$this->getURN($stat['fileid']).' for file '.$path,
 						]);
 						return false;
 					}
@@ -356,7 +356,7 @@ 
 			case 'wb+':
 				$tmpFile = \OC::$server->getTempManager()->getTemporaryFile($ext);
 				$handle = fopen($tmpFile, $mode);
-				return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
+				return CallbackWrapper::wrap($handle, null, null, function() use ($path, $tmpFile) {
 					$this->writeBack($tmpFile, $path);
 					unlink($tmpFile);
 				});
@@ -374,7 +374,7 @@ 
 					file_put_contents($tmpFile, $source);
 				}
 				$handle = fopen($tmpFile, $mode);
-				return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {
+				return CallbackWrapper::wrap($handle, null, null, function() use ($path, $tmpFile) {
 					$this->writeBack($tmpFile, $path);
 					unlink($tmpFile);
 				});
@@ -384,7 +384,7 @@ 
 
 	public function file_exists($path) {
 		$path = $this->normalizePath($path);
-		return (bool)$this->stat($path);
+		return (bool) $this->stat($path);
 	}
 
 	public function rename($source, $target) {
@@ -436,7 +436,7 @@ 
 			} catch (\Exception $ex) {
 				$this->logger->logException($ex, [
 					'app' => 'objectstore',
-					'message' => 'Could not create object for ' . $path,
+					'message' => 'Could not create object for '.$path,
 				]);
 				throw $ex;
 			}
@@ -481,7 +481,7 @@ 
 		}
 		// update stat with new data
 		$mTime = time();
-		$stat['size'] = (int)$size;
+		$stat['size'] = (int) $size;
 		$stat['mtime'] = $mTime;
 		$stat['storage_mtime'] = $mTime;
 
@@ -493,7 +493,7 @@ 
 		$stat['checksum'] = '';
 
 		$exists = $this->getCache()->inCache($path);
-		$uploadPath = $exists ? $path : $path . '.part';
+		$uploadPath = $exists ? $path : $path.'.part';
 
 		if ($exists) {
 			$fileId = $stat['fileid'];
@@ -505,7 +505,7 @@ 
 		try {
 			//upload to object storage
 			if ($size === null) {
-				$countStream = CountWrapper::wrap($stream, function ($writtenSize) use ($fileId, &$size) {
+				$countStream = CountWrapper::wrap($stream, function($writtenSize) use ($fileId, &$size) {
 					$this->getCache()->update($fileId, [
 						'size' => $writtenSize,
 					]);
@@ -531,12 +531,12 @@ 
 				$this->getCache()->remove($uploadPath);
 				$this->logger->logException($ex, [
 					'app' => 'objectstore',
-					'message' => 'Could not create object ' . $urn . ' for ' . $path,
+					'message' => 'Could not create object '.$urn.' for '.$path,
 				]);
 			} else {
 				$this->logger->logException($ex, [
 					'app' => 'objectstore',
-					'message' => 'Could not update object ' . $urn . ' for ' . $path,
+					'message' => 'Could not update object '.$urn.' for '.$path,
 				]);
 			}
 			throw $ex; // make this bubble up
@@ -611,7 +611,7 @@ 
 			$this->mkdir($to);
 
 			foreach ($cache->getFolderContentsById($sourceEntry->getId()) as $child) {
-				$this->copyInner($child, $to . '/' . $child->getName());
+				$this->copyInner($child, $to.'/'.$child->getName());
 			}
 		} else {
 			$this->copyFile($sourceEntry, $to);
@@ -666,7 +666,7 @@ 
 		$cacheEntry = $this->getCache()->get($targetPath);
 		$urn = $this->getURN($cacheEntry->getId());
 
-		$result = $this->objectStore->uploadMultipartPart($urn, $writeToken, (int)$chunkId, $data, $size);
+		$result = $this->objectStore->uploadMultipartPart($urn, $writeToken, (int) $chunkId, $data, $size);
 
 		$parts[$chunkId] = [
 			'PartNumber' => $chunkId,
@@ -694,11 +694,11 @@ 
 				$stat['mimetype'] = $this->getMimeType($targetPath);
 				$this->getCache()->update($stat['fileid'], $stat);
 			}
-		} catch (S3MultipartUploadException|S3Exception $e) {
+		} catch (S3MultipartUploadException | S3Exception $e) {
 			$this->objectStore->abortMultipartUpload($urn, $writeToken);
 			$this->logger->logException($e, [
 				'app' => 'objectstore',
-				'message' => 'Could not compete multipart upload ' . $urn . ' with uploadId ' . $writeToken,
+				'message' => 'Could not compete multipart upload '.$urn.' with uploadId '.$writeToken,
 			]);
 			throw new GenericFileException('Could not write chunked file');
 		}