Inspection of "Merge pull request #54275 from nextcloud/fix-order..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2e0baa...43aa92 )

unknown

created 2025-08-07 13:05 UTC

Status

Indentation +70 added lines, -70 removed lines patch added patch discarded remove patch

@@ -58,88 +58,88 @@
 block discarded – undo
 use Psr\Log\LoggerInterface;
 
 class Application extends App implements IBootstrap {
-	public const APP_ID = 'files';
+    public const APP_ID = 'files';
 
-	public function __construct(array $urlParams = []) {
-		parent::__construct(self::APP_ID, $urlParams);
-	}
+    public function __construct(array $urlParams = []) {
+        parent::__construct(self::APP_ID, $urlParams);
+    }
 
-	public function register(IRegistrationContext $context): void {
-		/**
-		 * Controllers
-		 */
-		$context->registerService('APIController', function (ContainerInterface $c) {
-			/** @var IServerContainer $server */
-			$server = $c->get(IServerContainer::class);
+    public function register(IRegistrationContext $context): void {
+        /**
+         * Controllers
+         */
+        $context->registerService('APIController', function (ContainerInterface $c) {
+            /** @var IServerContainer $server */
+            $server = $c->get(IServerContainer::class);
 
-			return new ApiController(
-				$c->get('AppName'),
-				$c->get(IRequest::class),
-				$c->get(IUserSession::class),
-				$c->get(TagService::class),
-				$c->get(IPreview::class),
-				$c->get(IShareManager::class),
-				$c->get(IConfig::class),
-				$server->getUserFolder(),
-				$c->get(UserConfig::class),
-				$c->get(ViewConfig::class),
-				$c->get(IL10N::class),
-				$c->get(IRootFolder::class),
-				$c->get(LoggerInterface::class),
-			);
-		});
+            return new ApiController(
+                $c->get('AppName'),
+                $c->get(IRequest::class),
+                $c->get(IUserSession::class),
+                $c->get(TagService::class),
+                $c->get(IPreview::class),
+                $c->get(IShareManager::class),
+                $c->get(IConfig::class),
+                $server->getUserFolder(),
+                $c->get(UserConfig::class),
+                $c->get(ViewConfig::class),
+                $c->get(IL10N::class),
+                $c->get(IRootFolder::class),
+                $c->get(LoggerInterface::class),
+            );
+        });
 
-		/**
-		 * Services
-		 */
-		$context->registerService(TagService::class, function (ContainerInterface $c) {
-			/** @var IServerContainer $server */
-			$server = $c->get(IServerContainer::class);
+        /**
+         * Services
+         */
+        $context->registerService(TagService::class, function (ContainerInterface $c) {
+            /** @var IServerContainer $server */
+            $server = $c->get(IServerContainer::class);
 
-			return new TagService(
-				$c->get(IUserSession::class),
-				$c->get(IActivityManager::class),
-				$c->get(ITagManager::class)->load(self::APP_ID),
-				$server->getUserFolder(),
-			);
-		});
+            return new TagService(
+                $c->get(IUserSession::class),
+                $c->get(IActivityManager::class),
+                $c->get(ITagManager::class)->load(self::APP_ID),
+                $server->getUserFolder(),
+            );
+        });
 
-		/*
+        /*
 		 * Register capabilities
 		 */
-		$context->registerCapability(Capabilities::class);
-		$context->registerCapability(AdvancedCapabilities::class);
-		$context->registerCapability(DirectEditingCapabilities::class);
+        $context->registerCapability(Capabilities::class);
+        $context->registerCapability(AdvancedCapabilities::class);
+        $context->registerCapability(DirectEditingCapabilities::class);
 
-		$context->registerDeclarativeSettings(DeclarativeAdminSettings::class);
+        $context->registerDeclarativeSettings(DeclarativeAdminSettings::class);
 
-		$context->registerEventListener(LoadSidebar::class, LoadSidebarListener::class);
-		$context->registerEventListener(RenderReferenceEvent::class, RenderReferenceEventListener::class);
-		$context->registerEventListener(BeforeNodeRenamedEvent::class, SyncLivePhotosListener::class);
-		$context->registerEventListener(BeforeNodeDeletedEvent::class, SyncLivePhotosListener::class);
-		$context->registerEventListener(CacheEntryRemovedEvent::class, SyncLivePhotosListener::class, 1); // Ensure this happen before the metadata are deleted.
-		$context->registerEventListener(BeforeNodeCopiedEvent::class, SyncLivePhotosListener::class);
-		$context->registerEventListener(NodeCopiedEvent::class, SyncLivePhotosListener::class);
-		$context->registerEventListener(LoadSearchPlugins::class, LoadSearchPluginsListener::class);
-		$context->registerEventListener(NodeAddedToFavorite::class, NodeAddedToFavoriteListener::class);
-		$context->registerEventListener(NodeRemovedFromFavorite::class, NodeRemovedFromFavoriteListener::class);
-		$context->registerSearchProvider(FilesSearchProvider::class);
+        $context->registerEventListener(LoadSidebar::class, LoadSidebarListener::class);
+        $context->registerEventListener(RenderReferenceEvent::class, RenderReferenceEventListener::class);
+        $context->registerEventListener(BeforeNodeRenamedEvent::class, SyncLivePhotosListener::class);
+        $context->registerEventListener(BeforeNodeDeletedEvent::class, SyncLivePhotosListener::class);
+        $context->registerEventListener(CacheEntryRemovedEvent::class, SyncLivePhotosListener::class, 1); // Ensure this happen before the metadata are deleted.
+        $context->registerEventListener(BeforeNodeCopiedEvent::class, SyncLivePhotosListener::class);
+        $context->registerEventListener(NodeCopiedEvent::class, SyncLivePhotosListener::class);
+        $context->registerEventListener(LoadSearchPlugins::class, LoadSearchPluginsListener::class);
+        $context->registerEventListener(NodeAddedToFavorite::class, NodeAddedToFavoriteListener::class);
+        $context->registerEventListener(NodeRemovedFromFavorite::class, NodeRemovedFromFavoriteListener::class);
+        $context->registerSearchProvider(FilesSearchProvider::class);
 
-		$context->registerNotifierService(Notifier::class);
-		$context->registerDashboardWidget(FavoriteWidget::class);
-	}
+        $context->registerNotifierService(Notifier::class);
+        $context->registerDashboardWidget(FavoriteWidget::class);
+    }
 
-	public function boot(IBootContext $context): void {
-		$context->injectFn(Closure::fromCallable([$this, 'registerCollaboration']));
-		$context->injectFn([Listener::class, 'register']);
-		$this->registerHooks();
-	}
+    public function boot(IBootContext $context): void {
+        $context->injectFn(Closure::fromCallable([$this, 'registerCollaboration']));
+        $context->injectFn([Listener::class, 'register']);
+        $this->registerHooks();
+    }
 
-	private function registerCollaboration(IProviderManager $providerManager): void {
-		$providerManager->registerResourceProvider(ResourceProvider::class);
-	}
+    private function registerCollaboration(IProviderManager $providerManager): void {
+        $providerManager->registerResourceProvider(ResourceProvider::class);
+    }
 
-	private function registerHooks(): void {
-		Util::connectHook('\OCP\Config', 'js', '\OCA\Files\App', 'extendJsConfig');
-	}
+    private function registerHooks(): void {
+        Util::connectHook('\OCP\Config', 'js', '\OCA\Files\App', 'extendJsConfig');
+    }
 }

Please login to merge, or discard this patch.

		@@ -58,88 +58,88 @@
		block discarded – undo
58	58	use Psr\Log\LoggerInterface;
59	59
60	60	class Application extends App implements IBootstrap {
61		- public const APP_ID = 'files';
	61	+ public const APP_ID = 'files';
62	62
63		- public function __construct(array $urlParams = []) {
64		- parent::__construct(self::APP_ID, $urlParams);
65		- }
	63	+ public function __construct(array $urlParams = []) {
	64	+ parent::__construct(self::APP_ID, $urlParams);
	65	+ }
66	66
67		- public function register(IRegistrationContext $context): void {
68		- /**
69		- * Controllers
70		- */
71		- $context->registerService('APIController', function (ContainerInterface $c) {
72		- /** @var IServerContainer $server */
73		- $server = $c->get(IServerContainer::class);
	67	+ public function register(IRegistrationContext $context): void {
	68	+ /**
	69	+ * Controllers
	70	+ */
	71	+ $context->registerService('APIController', function (ContainerInterface $c) {
	72	+ /** @var IServerContainer $server */
	73	+ $server = $c->get(IServerContainer::class);
74	74
75		- return new ApiController(
76		- $c->get('AppName'),
77		- $c->get(IRequest::class),
78		- $c->get(IUserSession::class),
79		- $c->get(TagService::class),
80		- $c->get(IPreview::class),
81		- $c->get(IShareManager::class),
82		- $c->get(IConfig::class),
83		- $server->getUserFolder(),
84		- $c->get(UserConfig::class),
85		- $c->get(ViewConfig::class),
86		- $c->get(IL10N::class),
87		- $c->get(IRootFolder::class),
88		- $c->get(LoggerInterface::class),
89		- );
90		- });
	75	+ return new ApiController(
	76	+ $c->get('AppName'),
	77	+ $c->get(IRequest::class),
	78	+ $c->get(IUserSession::class),
	79	+ $c->get(TagService::class),
	80	+ $c->get(IPreview::class),
	81	+ $c->get(IShareManager::class),
	82	+ $c->get(IConfig::class),
	83	+ $server->getUserFolder(),
	84	+ $c->get(UserConfig::class),
	85	+ $c->get(ViewConfig::class),
	86	+ $c->get(IL10N::class),
	87	+ $c->get(IRootFolder::class),
	88	+ $c->get(LoggerInterface::class),
	89	+ );
	90	+ });
91	91
92		- /**
93		- * Services
94		- */
95		- $context->registerService(TagService::class, function (ContainerInterface $c) {
96		- /** @var IServerContainer $server */
97		- $server = $c->get(IServerContainer::class);
	92	+ /**
	93	+ * Services
	94	+ */
	95	+ $context->registerService(TagService::class, function (ContainerInterface $c) {
	96	+ /** @var IServerContainer $server */
	97	+ $server = $c->get(IServerContainer::class);
98	98
99		- return new TagService(
100		- $c->get(IUserSession::class),
101		- $c->get(IActivityManager::class),
102		- $c->get(ITagManager::class)->load(self::APP_ID),
103		- $server->getUserFolder(),
104		- );
105		- });
	99	+ return new TagService(
	100	+ $c->get(IUserSession::class),
	101	+ $c->get(IActivityManager::class),
	102	+ $c->get(ITagManager::class)->load(self::APP_ID),
	103	+ $server->getUserFolder(),
	104	+ );
	105	+ });
106	106
107		- /*
	107	+ /*
108	108	* Register capabilities
109	109	*/
110		- $context->registerCapability(Capabilities::class);
111		- $context->registerCapability(AdvancedCapabilities::class);
112		- $context->registerCapability(DirectEditingCapabilities::class);
	110	+ $context->registerCapability(Capabilities::class);
	111	+ $context->registerCapability(AdvancedCapabilities::class);
	112	+ $context->registerCapability(DirectEditingCapabilities::class);
113	113
114		- $context->registerDeclarativeSettings(DeclarativeAdminSettings::class);
	114	+ $context->registerDeclarativeSettings(DeclarativeAdminSettings::class);
115	115
116		- $context->registerEventListener(LoadSidebar::class, LoadSidebarListener::class);
117		- $context->registerEventListener(RenderReferenceEvent::class, RenderReferenceEventListener::class);
118		- $context->registerEventListener(BeforeNodeRenamedEvent::class, SyncLivePhotosListener::class);
119		- $context->registerEventListener(BeforeNodeDeletedEvent::class, SyncLivePhotosListener::class);
120		- $context->registerEventListener(CacheEntryRemovedEvent::class, SyncLivePhotosListener::class, 1); // Ensure this happen before the metadata are deleted.
121		- $context->registerEventListener(BeforeNodeCopiedEvent::class, SyncLivePhotosListener::class);
122		- $context->registerEventListener(NodeCopiedEvent::class, SyncLivePhotosListener::class);
123		- $context->registerEventListener(LoadSearchPlugins::class, LoadSearchPluginsListener::class);
124		- $context->registerEventListener(NodeAddedToFavorite::class, NodeAddedToFavoriteListener::class);
125		- $context->registerEventListener(NodeRemovedFromFavorite::class, NodeRemovedFromFavoriteListener::class);
126		- $context->registerSearchProvider(FilesSearchProvider::class);
	116	+ $context->registerEventListener(LoadSidebar::class, LoadSidebarListener::class);
	117	+ $context->registerEventListener(RenderReferenceEvent::class, RenderReferenceEventListener::class);
	118	+ $context->registerEventListener(BeforeNodeRenamedEvent::class, SyncLivePhotosListener::class);
	119	+ $context->registerEventListener(BeforeNodeDeletedEvent::class, SyncLivePhotosListener::class);
	120	+ $context->registerEventListener(CacheEntryRemovedEvent::class, SyncLivePhotosListener::class, 1); // Ensure this happen before the metadata are deleted.
	121	+ $context->registerEventListener(BeforeNodeCopiedEvent::class, SyncLivePhotosListener::class);
	122	+ $context->registerEventListener(NodeCopiedEvent::class, SyncLivePhotosListener::class);
	123	+ $context->registerEventListener(LoadSearchPlugins::class, LoadSearchPluginsListener::class);
	124	+ $context->registerEventListener(NodeAddedToFavorite::class, NodeAddedToFavoriteListener::class);
	125	+ $context->registerEventListener(NodeRemovedFromFavorite::class, NodeRemovedFromFavoriteListener::class);
	126	+ $context->registerSearchProvider(FilesSearchProvider::class);
127	127
128		- $context->registerNotifierService(Notifier::class);
129		- $context->registerDashboardWidget(FavoriteWidget::class);
130		- }
	128	+ $context->registerNotifierService(Notifier::class);
	129	+ $context->registerDashboardWidget(FavoriteWidget::class);
	130	+ }
131	131
132		- public function boot(IBootContext $context): void {
133		- $context->injectFn(Closure::fromCallable([$this, 'registerCollaboration']));
134		- $context->injectFn([Listener::class, 'register']);
135		- $this->registerHooks();
136		- }
	132	+ public function boot(IBootContext $context): void {
	133	+ $context->injectFn(Closure::fromCallable([$this, 'registerCollaboration']));
	134	+ $context->injectFn([Listener::class, 'register']);
	135	+ $this->registerHooks();
	136	+ }
137	137
138		- private function registerCollaboration(IProviderManager $providerManager): void {
139		- $providerManager->registerResourceProvider(ResourceProvider::class);
140		- }
	138	+ private function registerCollaboration(IProviderManager $providerManager): void {
	139	+ $providerManager->registerResourceProvider(ResourceProvider::class);
	140	+ }
141	141
142		- private function registerHooks(): void {
143		- Util::connectHook('\OCP\Config', 'js', '\OCA\Files\App', 'extendJsConfig');
144		- }
	142	+ private function registerHooks(): void {
	143	+ Util::connectHook('\OCP\Config', 'js', '\OCA\Files\App', 'extendJsConfig');
	144	+ }
145	145	}

nextcloud / server

Push — master ( 2e0baa...43aa92 )

Status

Category

Indentation +70 added lines, -70 removed lines patch added patch discarded remove patch