Completed
Pull Request — master (#840)
by Julius
12:09
created
apps/theming/lib/Controller/IconController.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,6 @@
 block discarded – undo
34 34
 use OCP\IL10N;
35 35
 use OCP\IRequest;
36 36
 use OCA\Theming\Util;
37
-use OCP\IURLGenerator;
38 37
 use Imagick;
39 38
 use ImagickPixel;
40 39
 
Please login to merge, or discard this patch.
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 	 *
91 91
 	 * @param $app app name
92 92
 	 * @param $image image file name
93
-	 * @return StreamResponse|DataResponse
93
+	 * @return DataDisplayResponse
94 94
 	 */
95 95
 	public function getThemedIcon($app, $image) {
96 96
 		$image = $this->getAppImage($app, $image);
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	 * @NoCSRFRequired
108 108
 	 *
109 109
 	 * @param $app app name
110
-	 * @return StreamResponse|DataResponse
110
+	 * @return DataDisplayResponse
111 111
 	 */
112 112
 	public function getFavicon($app="core") {
113 113
 		// TODO: we need caching here
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	 * @NoCSRFRequired
129 129
 	 *
130 130
 	 * @param $app app name
131
-	 * @return StreamResponse|DataResponse
131
+	 * @return DataDisplayResponse
132 132
 	 */
133 133
 	public function getTouchIcon($app="core") {
134 134
 		// TODO: we need caching here
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 	 * Render app icon on themed background color
147 147
 	 * fallback to logo
148 148
 	 *
149
-	 * @param $app app name
149
+	 * @param string $app app name
150 150
 	 * @return Imagick
151 151
 	 */
152 152
 	private function renderAppIcon($app) {
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 	/**
276 276
 	 * replace black with white and white with black
277 277
 	 *
278
-	 * @param $svg content of a svg file
278
+	 * @param string $svg content of a svg file
279 279
 	 * @return string
280 280
 	 */
281 281
 	private function svgInvert($svg) {
@@ -288,8 +288,8 @@  discard block
 block discarded – undo
288 288
 	/**
289 289
 	 * replace default color with a custom one
290 290
 	 *
291
-	 * @param $svg content of a svg file
292
-	 * @param $color color to match
291
+	 * @param string $svg content of a svg file
292
+	 * @param string $color color to match
293 293
 	 * @return string
294 294
 	 */
295 295
 	private function colorizeSvg($svg, $color) {
Please login to merge, or discard this patch.