Completed
Pull Request — master (#796)
by Blizzz
16:18 queued 06:17
created
lib/private/Settings/Manager.php 1 patch
Doc Comments   +16 added lines patch added patch discarded remove patch
@@ -125,6 +125,9 @@  discard block
 block discarded – undo
125 125
 		]);
126 126
 	}
127 127
 
128
+	/**
129
+	 * @param string $table
130
+	 */
128 131
 	private function add($table, $values) {
129 132
 		$query = $this->dbc->getQueryBuilder();
130 133
 		$values = array_map(function($value) use ($query) {
@@ -138,11 +141,18 @@  discard block
 block discarded – undo
138 141
 		return $this->has(self::TABLE_ADMIN_SECTIONS, 'id', $section->getID());
139 142
 	}
140 143
 
144
+	/**
145
+	 * @param IAdmin $pageClass
146
+	 */
141 147
 	private function hasAdminSettings($pageClass) {
142 148
 		return $this->has(self::TABLE_ADMIN_SETTINGS, 'class', $pageClass);
143 149
 	}
144 150
 
145 151
 
152
+	/**
153
+	 * @param string $table
154
+	 * @param string $idCol
155
+	 */
146 156
 	private function has($table, $idCol, $id) {
147 157
 		$query = $this->dbc->getQueryBuilder();
148 158
 		$query->select($idCol)
@@ -230,6 +240,9 @@  discard block
 block discarded – undo
230 240
 		return $sections;
231 241
 	}
232 242
 
243
+	/**
244
+	 * @param string $section
245
+	 */
233 246
 	private function getBuiltInAdminSettings($section) {
234 247
 		$forms = [];
235 248
 		try {
@@ -264,6 +277,9 @@  discard block
 block discarded – undo
264 277
 		return $forms;
265 278
 	}
266 279
 
280
+	/**
281
+	 * @param string $section
282
+	 */
267 283
 	private function getAdminSettingsFromDB($section, &$settings) {
268 284
 		$query = $this->dbc->getQueryBuilder();
269 285
 		$query->select(['class', 'priority'])
Please login to merge, or discard this patch.
settings/Controller/AdminSettingsController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -82,6 +82,9 @@
 block discarded – undo
82 82
 
83 83
 	}
84 84
 
85
+	/**
86
+	 * @param string $section
87
+	 */
85 88
 	private function getSettings($section) {
86 89
 		$settings = $this->settingsManager->getAdminSettings($section);
87 90
 		$html = '';
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 namespace OC\Settings\Controller;
25 25
 
26
-use Doctrine\DBAL\Connection;
27 26
 use OCP\AppFramework\Controller;
28 27
 use OCP\AppFramework\Http\TemplateResponse;
29 28
 use OC\Encryption\Manager as EncryptionManager;
Please login to merge, or discard this patch.