nextcloud / server

apps/files_sharing/tests/MountProviderTest.php

Indentation +354 added lines, -354 removed lines

@@ -28,380 +28,380 @@
  */
 class MountProviderTest extends \Test\TestCase {
 
-	protected MountProvider $provider;
+    protected MountProvider $provider;
 
-	protected IUser&MockObject $user;
-	protected IConfig&MockObject $config;
-	protected IManager&MockObject $shareManager;
-	protected IStorageFactory&MockObject $loader;
-	protected LoggerInterface&MockObject $logger;
+    protected IUser&MockObject $user;
+    protected IConfig&MockObject $config;
+    protected IManager&MockObject $shareManager;
+    protected IStorageFactory&MockObject $loader;
+    protected LoggerInterface&MockObject $logger;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->config = $this->getMockBuilder(IConfig::class)->getMock();
-		$this->user = $this->getMockBuilder(IUser::class)->getMock();
-		$this->loader = $this->getMockBuilder('OCP\Files\Storage\IStorageFactory')->getMock();
-		$this->shareManager = $this->getMockBuilder(IManager::class)->getMock();
-		$this->logger = $this->getMockBuilder(LoggerInterface::class)->getMock();
-		$eventDispatcher = $this->createMock(IEventDispatcher::class);
-		$cacheFactory = $this->createMock(ICacheFactory::class);
-		$cacheFactory->method('createLocal')
-			->willReturn(new NullCache());
-		$mountManager = $this->createMock(IMountManager::class);
+        $this->config = $this->getMockBuilder(IConfig::class)->getMock();
+        $this->user = $this->getMockBuilder(IUser::class)->getMock();
+        $this->loader = $this->getMockBuilder('OCP\Files\Storage\IStorageFactory')->getMock();
+        $this->shareManager = $this->getMockBuilder(IManager::class)->getMock();
+        $this->logger = $this->getMockBuilder(LoggerInterface::class)->getMock();
+        $eventDispatcher = $this->createMock(IEventDispatcher::class);
+        $cacheFactory = $this->createMock(ICacheFactory::class);
+        $cacheFactory->method('createLocal')
+            ->willReturn(new NullCache());
+        $mountManager = $this->createMock(IMountManager::class);
 
-		$this->provider = new MountProvider($this->config, $this->shareManager, $this->logger, $eventDispatcher, $cacheFactory, $mountManager);
-	}
+        $this->provider = new MountProvider($this->config, $this->shareManager, $this->logger, $eventDispatcher, $cacheFactory, $mountManager);
+    }
 
-	private function makeMockShareAttributes($attrs) {
-		if ($attrs === null) {
-			return null;
-		}
+    private function makeMockShareAttributes($attrs) {
+        if ($attrs === null) {
+            return null;
+        }
 
-		$shareAttributes = $this->createMock(IShareAttributes::class);
-		$shareAttributes->method('toArray')->willReturn($attrs);
-		$shareAttributes->method('getAttribute')->will(
-			$this->returnCallback(function ($scope, $key) use ($attrs) {
-				$result = null;
-				foreach ($attrs as $attr) {
-					if ($attr['key'] === $key && $attr['scope'] === $scope) {
-						$result = $attr['value'];
-					}
-				}
-				return $result;
-			})
-		);
-		return $shareAttributes;
-	}
+        $shareAttributes = $this->createMock(IShareAttributes::class);
+        $shareAttributes->method('toArray')->willReturn($attrs);
+        $shareAttributes->method('getAttribute')->will(
+            $this->returnCallback(function ($scope, $key) use ($attrs) {
+                $result = null;
+                foreach ($attrs as $attr) {
+                    if ($attr['key'] === $key && $attr['scope'] === $scope) {
+                        $result = $attr['value'];
+                    }
+                }
+                return $result;
+            })
+        );
+        return $shareAttributes;
+    }
 
-	private function makeMockShare($id, $nodeId, $owner = 'user2', $target = null, $permissions = 31, $attributes = null) {
-		$share = $this->createMock(IShare::class);
-		$share->expects($this->any())
-			->method('getPermissions')
-			->willReturn($permissions);
-		$share->expects($this->any())
-			->method('getAttributes')
-			->will($this->returnValue($this->makeMockShareAttributes($attributes)));
-		$share->expects($this->any())
-			->method('getShareOwner')
-			->willReturn($owner);
-		$share->expects($this->any())
-			->method('getTarget')
-			->willReturn($target);
-		$share->expects($this->any())
-			->method('getId')
-			->willReturn($id);
-		$share->expects($this->any())
-			->method('getNodeId')
-			->willReturn($nodeId);
-		$share->expects($this->any())
-			->method('getShareTime')
-			->willReturn(
-				// compute share time based on id, simulating share order
-				new \DateTime('@' . (1469193980 + 1000 * $id))
-			);
-		return $share;
-	}
+    private function makeMockShare($id, $nodeId, $owner = 'user2', $target = null, $permissions = 31, $attributes = null) {
+        $share = $this->createMock(IShare::class);
+        $share->expects($this->any())
+            ->method('getPermissions')
+            ->willReturn($permissions);
+        $share->expects($this->any())
+            ->method('getAttributes')
+            ->will($this->returnValue($this->makeMockShareAttributes($attributes)));
+        $share->expects($this->any())
+            ->method('getShareOwner')
+            ->willReturn($owner);
+        $share->expects($this->any())
+            ->method('getTarget')
+            ->willReturn($target);
+        $share->expects($this->any())
+            ->method('getId')
+            ->willReturn($id);
+        $share->expects($this->any())
+            ->method('getNodeId')
+            ->willReturn($nodeId);
+        $share->expects($this->any())
+            ->method('getShareTime')
+            ->willReturn(
+                // compute share time based on id, simulating share order
+                new \DateTime('@' . (1469193980 + 1000 * $id))
+            );
+        return $share;
+    }
 
-	/**
-	 * Tests excluding shares from the current view. This includes:
-	 * - shares that were opted out of (permissions === 0)
-	 * - shares with a group in which the owner is already in
-	 */
-	public function testExcludeShares(): void {
-		$rootFolder = $this->createMock(IRootFolder::class);
-		$userManager = $this->createMock(IUserManager::class);
-		$attr1 = [];
-		$attr2 = [['scope' => 'permission', 'key' => 'download', 'value' => true]];
-		$userShares = [
-			$this->makeMockShare(1, 100, 'user2', '/share2', 0, $attr1),
-			$this->makeMockShare(2, 100, 'user2', '/share2', 31, $attr2),
-		];
-		$groupShares = [
-			$this->makeMockShare(3, 100, 'user2', '/share2', 0, $attr1),
-			$this->makeMockShare(4, 101, 'user2', '/share4', 31, $attr2),
-			$this->makeMockShare(5, 100, 'user1', '/share4', 31, $attr2),
-		];
-		$roomShares = [
-			$this->makeMockShare(6, 102, 'user2', '/share6', 0),
-			$this->makeMockShare(7, 102, 'user1', '/share6', 31),
-			$this->makeMockShare(8, 102, 'user2', '/share6', 31),
-			$this->makeMockShare(9, 102, 'user2', '/share6', 31),
-		];
-		$deckShares = [
-			$this->makeMockShare(10, 103, 'user2', '/share7', 0),
-			$this->makeMockShare(11, 103, 'user1', '/share7', 31),
-			$this->makeMockShare(12, 103, 'user2', '/share7', 31),
-			$this->makeMockShare(13, 103, 'user2', '/share7', 31),
-		];
-		// tests regarding circles and sciencemesh are made in the apps themselves.
-		$circleShares = [];
-		$scienceMeshShares = [];
-		$this->user->expects($this->any())
-			->method('getUID')
-			->willReturn('user1');
-		$this->shareManager->expects($this->exactly(6))
-			->method('getSharedWith')
-			->willReturnMap([
-				['user1', IShare::TYPE_USER, null, -1, 0, $userShares],
-				['user1', IShare::TYPE_GROUP, null, -1, 0, $groupShares],
-				['user1', IShare::TYPE_CIRCLE, null, -1, 0, $circleShares],
-				['user1', IShare::TYPE_ROOM, null, -1, 0, $roomShares],
-				['user1', IShare::TYPE_DECK, null, -1, 0, $deckShares],
-				['user1', IShare::TYPE_SCIENCEMESH, null, -1, 0, $scienceMeshShares],
-			]);
+    /**
+     * Tests excluding shares from the current view. This includes:
+     * - shares that were opted out of (permissions === 0)
+     * - shares with a group in which the owner is already in
+     */
+    public function testExcludeShares(): void {
+        $rootFolder = $this->createMock(IRootFolder::class);
+        $userManager = $this->createMock(IUserManager::class);
+        $attr1 = [];
+        $attr2 = [['scope' => 'permission', 'key' => 'download', 'value' => true]];
+        $userShares = [
+            $this->makeMockShare(1, 100, 'user2', '/share2', 0, $attr1),
+            $this->makeMockShare(2, 100, 'user2', '/share2', 31, $attr2),
+        ];
+        $groupShares = [
+            $this->makeMockShare(3, 100, 'user2', '/share2', 0, $attr1),
+            $this->makeMockShare(4, 101, 'user2', '/share4', 31, $attr2),
+            $this->makeMockShare(5, 100, 'user1', '/share4', 31, $attr2),
+        ];
+        $roomShares = [
+            $this->makeMockShare(6, 102, 'user2', '/share6', 0),
+            $this->makeMockShare(7, 102, 'user1', '/share6', 31),
+            $this->makeMockShare(8, 102, 'user2', '/share6', 31),
+            $this->makeMockShare(9, 102, 'user2', '/share6', 31),
+        ];
+        $deckShares = [
+            $this->makeMockShare(10, 103, 'user2', '/share7', 0),
+            $this->makeMockShare(11, 103, 'user1', '/share7', 31),
+            $this->makeMockShare(12, 103, 'user2', '/share7', 31),
+            $this->makeMockShare(13, 103, 'user2', '/share7', 31),
+        ];
+        // tests regarding circles and sciencemesh are made in the apps themselves.
+        $circleShares = [];
+        $scienceMeshShares = [];
+        $this->user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user1');
+        $this->shareManager->expects($this->exactly(6))
+            ->method('getSharedWith')
+            ->willReturnMap([
+                ['user1', IShare::TYPE_USER, null, -1, 0, $userShares],
+                ['user1', IShare::TYPE_GROUP, null, -1, 0, $groupShares],
+                ['user1', IShare::TYPE_CIRCLE, null, -1, 0, $circleShares],
+                ['user1', IShare::TYPE_ROOM, null, -1, 0, $roomShares],
+                ['user1', IShare::TYPE_DECK, null, -1, 0, $deckShares],
+                ['user1', IShare::TYPE_SCIENCEMESH, null, -1, 0, $scienceMeshShares],
+            ]);
 
-		$this->shareManager->expects($this->any())
-			->method('newShare')
-			->willReturnCallback(function () use ($rootFolder, $userManager) {
-				return new Share($rootFolder, $userManager);
-			});
+        $this->shareManager->expects($this->any())
+            ->method('newShare')
+            ->willReturnCallback(function () use ($rootFolder, $userManager) {
+                return new Share($rootFolder, $userManager);
+            });
 
-		$mounts = $this->provider->getMountsForUser($this->user, $this->loader);
-		$this->assertCount(4, $mounts);
-		$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[0]);
-		$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[1]);
-		$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[2]);
-		$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[3]);
-		/** @var OCA\Files_Sharing\SharedMount[] $mounts */
-		$mountedShare1 = $mounts[0]->getShare();
-		$this->assertEquals('2', $mountedShare1->getId());
-		$this->assertEquals('user2', $mountedShare1->getShareOwner());
-		$this->assertEquals(100, $mountedShare1->getNodeId());
-		$this->assertEquals('/share2', $mountedShare1->getTarget());
-		$this->assertEquals(31, $mountedShare1->getPermissions());
-		$this->assertEquals(true, $mountedShare1->getAttributes()->getAttribute('permission', 'download'));
-		$mountedShare2 = $mounts[1]->getShare();
-		$this->assertEquals('4', $mountedShare2->getId());
-		$this->assertEquals('user2', $mountedShare2->getShareOwner());
-		$this->assertEquals(101, $mountedShare2->getNodeId());
-		$this->assertEquals('/share4', $mountedShare2->getTarget());
-		$this->assertEquals(31, $mountedShare2->getPermissions());
-		$this->assertEquals(true, $mountedShare2->getAttributes()->getAttribute('permission', 'download'));
-		$mountedShare3 = $mounts[2]->getShare();
-		$this->assertEquals('8', $mountedShare3->getId());
-		$this->assertEquals('user2', $mountedShare3->getShareOwner());
-		$this->assertEquals(102, $mountedShare3->getNodeId());
-		$this->assertEquals('/share6', $mountedShare3->getTarget());
-		$this->assertEquals(31, $mountedShare3->getPermissions());
-		$mountedShare4 = $mounts[3]->getShare();
-		$this->assertEquals('12', $mountedShare4->getId());
-		$this->assertEquals('user2', $mountedShare4->getShareOwner());
-		$this->assertEquals(103, $mountedShare4->getNodeId());
-		$this->assertEquals('/share7', $mountedShare4->getTarget());
-		$this->assertEquals(31, $mountedShare4->getPermissions());
-	}
+        $mounts = $this->provider->getMountsForUser($this->user, $this->loader);
+        $this->assertCount(4, $mounts);
+        $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[0]);
+        $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[1]);
+        $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[2]);
+        $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mounts[3]);
+        /** @var OCA\Files_Sharing\SharedMount[] $mounts */
+        $mountedShare1 = $mounts[0]->getShare();
+        $this->assertEquals('2', $mountedShare1->getId());
+        $this->assertEquals('user2', $mountedShare1->getShareOwner());
+        $this->assertEquals(100, $mountedShare1->getNodeId());
+        $this->assertEquals('/share2', $mountedShare1->getTarget());
+        $this->assertEquals(31, $mountedShare1->getPermissions());
+        $this->assertEquals(true, $mountedShare1->getAttributes()->getAttribute('permission', 'download'));
+        $mountedShare2 = $mounts[1]->getShare();
+        $this->assertEquals('4', $mountedShare2->getId());
+        $this->assertEquals('user2', $mountedShare2->getShareOwner());
+        $this->assertEquals(101, $mountedShare2->getNodeId());
+        $this->assertEquals('/share4', $mountedShare2->getTarget());
+        $this->assertEquals(31, $mountedShare2->getPermissions());
+        $this->assertEquals(true, $mountedShare2->getAttributes()->getAttribute('permission', 'download'));
+        $mountedShare3 = $mounts[2]->getShare();
+        $this->assertEquals('8', $mountedShare3->getId());
+        $this->assertEquals('user2', $mountedShare3->getShareOwner());
+        $this->assertEquals(102, $mountedShare3->getNodeId());
+        $this->assertEquals('/share6', $mountedShare3->getTarget());
+        $this->assertEquals(31, $mountedShare3->getPermissions());
+        $mountedShare4 = $mounts[3]->getShare();
+        $this->assertEquals('12', $mountedShare4->getId());
+        $this->assertEquals('user2', $mountedShare4->getShareOwner());
+        $this->assertEquals(103, $mountedShare4->getNodeId());
+        $this->assertEquals('/share7', $mountedShare4->getTarget());
+        $this->assertEquals(31, $mountedShare4->getPermissions());
+    }
 
-	public static function mergeSharesDataProvider(): array {
-		// note: the user in the specs here is the shareOwner not recipient
-		// the recipient is always "user1"
-		return [
-			// #0: share as outsider with "group1" and "user1" with same permissions
-			[
-				[
-					[1, 100, 'user2', '/share2', 31, null],
-				],
-				[
-					[2, 100, 'user2', '/share2', 31, null],
-				],
-				[
-					// combined, user share has higher priority
-					['1', 100, 'user2', '/share2', 31, []],
-				],
-			],
-			// #1: share as outsider with "group1" and "user1" with different permissions
-			[
-				[
-					[1, 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true], ['scope' => 'app', 'key' => 'attribute1', 'value' => true]]],
-				],
-				[
-					[2, 100, 'user2', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => false], ['scope' => 'app', 'key' => 'attribute2', 'value' => false]]],
-				],
-				[
-					// use highest permissions
-					['1', 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true], ['scope' => 'app', 'key' => 'attribute1', 'value' => true], ['scope' => 'app', 'key' => 'attribute2', 'value' => false]]],
-				],
-			],
-			// #2: share as outsider with "group1" and "group2" with same permissions
-			[
-				[
-				],
-				[
-					[1, 100, 'user2', '/share', 31, null],
-					[2, 100, 'user2', '/share', 31, []],
-				],
-				[
-					// combined, first group share has higher priority
-					['1', 100, 'user2', '/share', 31, []],
-				],
-			],
-			// #3: share as outsider with "group1" and "group2" with different permissions
-			[
-				[
-				],
-				[
-					[1, 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => false]]],
-					[2, 100, 'user2', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
-				],
-				[
-					// use higher permissions (most permissive)
-					['1', 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
-				],
-			],
-			// #4: share as insider with "group1"
-			[
-				[
-				],
-				[
-					[1, 100, 'user1', '/share', 31, []],
-				],
-				[
-					// no received share since "user1" is the sharer/owner
-				],
-			],
-			// #5: share as insider with "group1" and "group2" with different permissions
-			[
-				[
-				],
-				[
-					[1, 100, 'user1', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
-					[2, 100, 'user1', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => false]]],
-				],
-				[
-					// no received share since "user1" is the sharer/owner
-				],
-			],
-			// #6: share as outside with "group1", recipient opted out
-			[
-				[
-				],
-				[
-					[1, 100, 'user2', '/share', 0, []],
-				],
-				[
-					// no received share since "user1" opted out
-				],
-			],
-			// #7: share as outsider with "group1" and "user1" where recipient renamed in between
-			[
-				[
-					[1, 100, 'user2', '/share2-renamed', 31, []],
-				],
-				[
-					[2, 100, 'user2', '/share2', 31, []],
-				],
-				[
-					// use target of least recent share
-					['1', 100, 'user2', '/share2-renamed', 31, []],
-				],
-			],
-			// #8: share as outsider with "group1" and "user1" where recipient renamed in between
-			[
-				[
-					[2, 100, 'user2', '/share2', 31, []],
-				],
-				[
-					[1, 100, 'user2', '/share2-renamed', 31, []],
-				],
-				[
-					// use target of least recent share
-					['1', 100, 'user2', '/share2-renamed', 31, []],
-				],
-			],
-			// #9: share as outsider with "nullgroup" and "user1" where recipient renamed in between
-			[
-				[
-					[2, 100, 'user2', '/share2', 31, []],
-				],
-				[
-					[1, 100, 'nullgroup', '/share2-renamed', 31, []],
-				],
-				[
-					// use target of least recent share
-					['1', 100, 'nullgroup', '/share2-renamed', 31, []],
-				],
-				true
-			],
-		];
-	}
+    public static function mergeSharesDataProvider(): array {
+        // note: the user in the specs here is the shareOwner not recipient
+        // the recipient is always "user1"
+        return [
+            // #0: share as outsider with "group1" and "user1" with same permissions
+            [
+                [
+                    [1, 100, 'user2', '/share2', 31, null],
+                ],
+                [
+                    [2, 100, 'user2', '/share2', 31, null],
+                ],
+                [
+                    // combined, user share has higher priority
+                    ['1', 100, 'user2', '/share2', 31, []],
+                ],
+            ],
+            // #1: share as outsider with "group1" and "user1" with different permissions
+            [
+                [
+                    [1, 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true], ['scope' => 'app', 'key' => 'attribute1', 'value' => true]]],
+                ],
+                [
+                    [2, 100, 'user2', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => false], ['scope' => 'app', 'key' => 'attribute2', 'value' => false]]],
+                ],
+                [
+                    // use highest permissions
+                    ['1', 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true], ['scope' => 'app', 'key' => 'attribute1', 'value' => true], ['scope' => 'app', 'key' => 'attribute2', 'value' => false]]],
+                ],
+            ],
+            // #2: share as outsider with "group1" and "group2" with same permissions
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user2', '/share', 31, null],
+                    [2, 100, 'user2', '/share', 31, []],
+                ],
+                [
+                    // combined, first group share has higher priority
+                    ['1', 100, 'user2', '/share', 31, []],
+                ],
+            ],
+            // #3: share as outsider with "group1" and "group2" with different permissions
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => false]]],
+                    [2, 100, 'user2', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
+                ],
+                [
+                    // use higher permissions (most permissive)
+                    ['1', 100, 'user2', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
+                ],
+            ],
+            // #4: share as insider with "group1"
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user1', '/share', 31, []],
+                ],
+                [
+                    // no received share since "user1" is the sharer/owner
+                ],
+            ],
+            // #5: share as insider with "group1" and "group2" with different permissions
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user1', '/share', 31, [['scope' => 'permission', 'key' => 'download', 'value' => true]]],
+                    [2, 100, 'user1', '/share', 15, [['scope' => 'permission', 'key' => 'download', 'value' => false]]],
+                ],
+                [
+                    // no received share since "user1" is the sharer/owner
+                ],
+            ],
+            // #6: share as outside with "group1", recipient opted out
+            [
+                [
+                ],
+                [
+                    [1, 100, 'user2', '/share', 0, []],
+                ],
+                [
+                    // no received share since "user1" opted out
+                ],
+            ],
+            // #7: share as outsider with "group1" and "user1" where recipient renamed in between
+            [
+                [
+                    [1, 100, 'user2', '/share2-renamed', 31, []],
+                ],
+                [
+                    [2, 100, 'user2', '/share2', 31, []],
+                ],
+                [
+                    // use target of least recent share
+                    ['1', 100, 'user2', '/share2-renamed', 31, []],
+                ],
+            ],
+            // #8: share as outsider with "group1" and "user1" where recipient renamed in between
+            [
+                [
+                    [2, 100, 'user2', '/share2', 31, []],
+                ],
+                [
+                    [1, 100, 'user2', '/share2-renamed', 31, []],
+                ],
+                [
+                    // use target of least recent share
+                    ['1', 100, 'user2', '/share2-renamed', 31, []],
+                ],
+            ],
+            // #9: share as outsider with "nullgroup" and "user1" where recipient renamed in between
+            [
+                [
+                    [2, 100, 'user2', '/share2', 31, []],
+                ],
+                [
+                    [1, 100, 'nullgroup', '/share2-renamed', 31, []],
+                ],
+                [
+                    // use target of least recent share
+                    ['1', 100, 'nullgroup', '/share2-renamed', 31, []],
+                ],
+                true
+            ],
+        ];
+    }
 
-	/**
-	 * Tests merging shares.
-	 *
-	 * Happens when sharing the same entry to a user through multiple ways,
-	 * like several groups and also direct shares at the same time.
-	 *
-	 * @dataProvider mergeSharesDataProvider
-	 *
-	 * @param array $userShares array of user share specs
-	 * @param array $groupShares array of group share specs
-	 * @param array $expectedShares array of expected supershare specs
-	 */
-	public function testMergeShares($userShares, $groupShares, $expectedShares, $moveFails = false): void {
-		$rootFolder = $this->createMock(IRootFolder::class);
-		$userManager = $this->createMock(IUserManager::class);
+    /**
+     * Tests merging shares.
+     *
+     * Happens when sharing the same entry to a user through multiple ways,
+     * like several groups and also direct shares at the same time.
+     *
+     * @dataProvider mergeSharesDataProvider
+     *
+     * @param array $userShares array of user share specs
+     * @param array $groupShares array of group share specs
+     * @param array $expectedShares array of expected supershare specs
+     */
+    public function testMergeShares($userShares, $groupShares, $expectedShares, $moveFails = false): void {
+        $rootFolder = $this->createMock(IRootFolder::class);
+        $userManager = $this->createMock(IUserManager::class);
 
-		$userShares = array_map(function ($shareSpec) {
-			return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
-		}, $userShares);
-		$groupShares = array_map(function ($shareSpec) {
-			return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
-		}, $groupShares);
+        $userShares = array_map(function ($shareSpec) {
+            return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
+        }, $userShares);
+        $groupShares = array_map(function ($shareSpec) {
+            return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
+        }, $groupShares);
 
-		$this->user->expects($this->any())
-			->method('getUID')
-			->willReturn('user1');
+        $this->user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user1');
 
-		// tests regarding circles are made in the app itself.
-		$circleShares = [];
-		$roomShares = [];
-		$deckShares = [];
-		$scienceMeshShares = [];
-		$this->shareManager->expects($this->exactly(6))
-			->method('getSharedWith')
-			->willReturnMap([
-				['user1', IShare::TYPE_USER, null, -1, 0, $userShares],
-				['user1', IShare::TYPE_GROUP, null, -1, 0, $groupShares],
-				['user1', IShare::TYPE_CIRCLE, null, -1, 0, $circleShares],
-				['user1', IShare::TYPE_ROOM, null, -1, 0, $roomShares],
-				['user1', IShare::TYPE_DECK, null, -1, 0, $deckShares],
-				['user1', IShare::TYPE_SCIENCEMESH, null, -1, 0, $scienceMeshShares],
-			]);
+        // tests regarding circles are made in the app itself.
+        $circleShares = [];
+        $roomShares = [];
+        $deckShares = [];
+        $scienceMeshShares = [];
+        $this->shareManager->expects($this->exactly(6))
+            ->method('getSharedWith')
+            ->willReturnMap([
+                ['user1', IShare::TYPE_USER, null, -1, 0, $userShares],
+                ['user1', IShare::TYPE_GROUP, null, -1, 0, $groupShares],
+                ['user1', IShare::TYPE_CIRCLE, null, -1, 0, $circleShares],
+                ['user1', IShare::TYPE_ROOM, null, -1, 0, $roomShares],
+                ['user1', IShare::TYPE_DECK, null, -1, 0, $deckShares],
+                ['user1', IShare::TYPE_SCIENCEMESH, null, -1, 0, $scienceMeshShares],
+            ]);
 
-		$this->shareManager->expects($this->any())
-			->method('newShare')
-			->willReturnCallback(function () use ($rootFolder, $userManager) {
-				return new Share($rootFolder, $userManager);
-			});
+        $this->shareManager->expects($this->any())
+            ->method('newShare')
+            ->willReturnCallback(function () use ($rootFolder, $userManager) {
+                return new Share($rootFolder, $userManager);
+            });
 
-		if ($moveFails) {
-			$this->shareManager->expects($this->any())
-				->method('moveShare')
-				->will($this->throwException(new \InvalidArgumentException()));
-		}
+        if ($moveFails) {
+            $this->shareManager->expects($this->any())
+                ->method('moveShare')
+                ->will($this->throwException(new \InvalidArgumentException()));
+        }
 
-		$mounts = $this->provider->getMountsForUser($this->user, $this->loader);
+        $mounts = $this->provider->getMountsForUser($this->user, $this->loader);
 
-		$this->assertCount(count($expectedShares), $mounts);
+        $this->assertCount(count($expectedShares), $mounts);
 
-		foreach ($mounts as $index => $mount) {
-			$expectedShare = $expectedShares[$index];
-			$this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mount);
+        foreach ($mounts as $index => $mount) {
+            $expectedShare = $expectedShares[$index];
+            $this->assertInstanceOf('OCA\Files_Sharing\SharedMount', $mount);
 
-			// supershare
-			/** @var OCA\Files_Sharing\SharedMount $mount */
-			$share = $mount->getShare();
+            // supershare
+            /** @var OCA\Files_Sharing\SharedMount $mount */
+            $share = $mount->getShare();
 
-			$this->assertEquals($expectedShare[0], $share->getId());
-			$this->assertEquals($expectedShare[1], $share->getNodeId());
-			$this->assertEquals($expectedShare[2], $share->getShareOwner());
-			$this->assertEquals($expectedShare[3], $share->getTarget());
-			$this->assertEquals($expectedShare[4], $share->getPermissions());
-			if ($expectedShare[5] === null) {
-				$this->assertNull($share->getAttributes());
-			} else {
-				$this->assertEquals($expectedShare[5], $share->getAttributes()->toArray());
-			}
-		}
-	}
+            $this->assertEquals($expectedShare[0], $share->getId());
+            $this->assertEquals($expectedShare[1], $share->getNodeId());
+            $this->assertEquals($expectedShare[2], $share->getShareOwner());
+            $this->assertEquals($expectedShare[3], $share->getTarget());
+            $this->assertEquals($expectedShare[4], $share->getPermissions());
+            if ($expectedShare[5] === null) {
+                $this->assertNull($share->getAttributes());
+            } else {
+                $this->assertEquals($expectedShare[5], $share->getAttributes()->toArray());
+            }
+        }
+    }
 }

Spacing +6 added lines, -6 removed lines

@@ -61,7 +61,7 @@ 
 		$shareAttributes = $this->createMock(IShareAttributes::class);
 		$shareAttributes->method('toArray')->willReturn($attrs);
 		$shareAttributes->method('getAttribute')->will(
-			$this->returnCallback(function ($scope, $key) use ($attrs) {
+			$this->returnCallback(function($scope, $key) use ($attrs) {
 				$result = null;
 				foreach ($attrs as $attr) {
 					if ($attr['key'] === $key && $attr['scope'] === $scope) {
@@ -98,7 +98,7 @@ 
 			->method('getShareTime')
 			->willReturn(
 				// compute share time based on id, simulating share order
-				new \DateTime('@' . (1469193980 + 1000 * $id))
+				new \DateTime('@'.(1469193980 + 1000 * $id))
 			);
 		return $share;
 	}
@@ -153,7 +153,7 @@ 
 
 		$this->shareManager->expects($this->any())
 			->method('newShare')
-			->willReturnCallback(function () use ($rootFolder, $userManager) {
+			->willReturnCallback(function() use ($rootFolder, $userManager) {
 				return new Share($rootFolder, $userManager);
 			});
 
@@ -341,10 +341,10 @@ 
 		$rootFolder = $this->createMock(IRootFolder::class);
 		$userManager = $this->createMock(IUserManager::class);
 
-		$userShares = array_map(function ($shareSpec) {
+		$userShares = array_map(function($shareSpec) {
 			return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
 		}, $userShares);
-		$groupShares = array_map(function ($shareSpec) {
+		$groupShares = array_map(function($shareSpec) {
 			return $this->makeMockShare($shareSpec[0], $shareSpec[1], $shareSpec[2], $shareSpec[3], $shareSpec[4], $shareSpec[5]);
 		}, $groupShares);
 
@@ -370,7 +370,7 @@ 
 
 		$this->shareManager->expects($this->any())
 			->method('newShare')
-			->willReturnCallback(function () use ($rootFolder, $userManager) {
+			->willReturnCallback(function() use ($rootFolder, $userManager) {
 				return new Share($rootFolder, $userManager);
 			});
 

apps/files_sharing/tests/Command/CleanupRemoteStoragesTest.php

Indentation +176 added lines, -176 removed lines

@@ -25,180 +25,180 @@
  */
 class CleanupRemoteStoragesTest extends TestCase {
 
-	protected IDBConnection $connection;
-	protected CleanupRemoteStorages $command;
-	private ICloudIdManager&MockObject $cloudIdManager;
-
-	private $storages = [
-		['id' => 'shared::7b4a322b22f9d0047c38d77d471ce3cf', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e1', 'remote' => 'https://hostname.tld/owncloud1', 'user' => 'user1'],
-		['id' => 'shared::efe3b456112c3780da6155d3a9b9141c', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e2', 'remote' => 'https://hostname.tld/owncloud2', 'user' => 'user2'],
-		['notExistingId' => 'shared::33323d9f4ca416a9e3525b435354bc6f', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e3', 'remote' => 'https://hostname.tld/owncloud3', 'user' => 'user3'],
-		['id' => 'shared::7fe41a07d3f517a923f4b2b599e72cbb', 'files_count' => 2],
-		['id' => 'shared::de4aeb2f378d222b6d2c5fd8f4e42f8e', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e5', 'remote' => 'https://hostname.tld/owncloud5', 'user' => 'user5'],
-		['id' => 'shared::af712293ab5eb9e6a1745a13818b99fe', 'files_count' => 3],
-		['notExistingId' => 'shared::c34568c143cdac7d2f06e0800b5280f9', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e7', 'remote' => 'https://hostname.tld/owncloud7', 'user' => 'user7'],
-	];
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = Server::get(IDBConnection::class);
-
-		$storageQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$storageQuery->insert('storages')
-			->setValue('id', $storageQuery->createParameter('id'));
-
-		$shareExternalQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$shareExternalQuery->insert('share_external')
-			->setValue('share_token', $shareExternalQuery->createParameter('share_token'))
-			->setValue('remote', $shareExternalQuery->createParameter('remote'))
-			->setValue('name', $shareExternalQuery->createParameter('name'))
-			->setValue('owner', $shareExternalQuery->createParameter('owner'))
-			->setValue('user', $shareExternalQuery->createParameter('user'))
-			->setValue('mountpoint', $shareExternalQuery->createParameter('mountpoint'))
-			->setValue('mountpoint_hash', $shareExternalQuery->createParameter('mountpoint_hash'));
-
-		$filesQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$filesQuery->insert('filecache')
-			->setValue('storage', $filesQuery->createParameter('storage'))
-			->setValue('path', $filesQuery->createParameter('path'))
-			->setValue('path_hash', $filesQuery->createParameter('path_hash'));
-
-		foreach ($this->storages as &$storage) {
-			if (isset($storage['id'])) {
-				$storageQuery->setParameter('id', $storage['id']);
-				$storageQuery->executeStatement();
-				$storage['numeric_id'] = $storageQuery->getLastInsertId();
-			}
-
-			if (isset($storage['share_token'])) {
-				$shareExternalQuery
-					->setParameter('share_token', $storage['share_token'])
-					->setParameter('remote', $storage['remote'])
-					->setParameter('name', 'irrelevant')
-					->setParameter('owner', 'irrelevant')
-					->setParameter('user', $storage['user'])
-					->setParameter('mountpoint', 'irrelevant')
-					->setParameter('mountpoint_hash', 'irrelevant');
-				$shareExternalQuery->executeStatement();
-			}
-
-			if (isset($storage['files_count'])) {
-				for ($i = 0; $i < $storage['files_count']; $i++) {
-					$filesQuery->setParameter('storage', $storage['numeric_id']);
-					$filesQuery->setParameter('path', 'file' . $i);
-					$filesQuery->setParameter('path_hash', md5('file' . $i));
-					$filesQuery->executeStatement();
-				}
-			}
-		}
-
-		$this->cloudIdManager = $this->createMock(ICloudIdManager::class);
-
-		$this->command = new CleanupRemoteStorages($this->connection, $this->cloudIdManager);
-	}
-
-	protected function tearDown(): void {
-		$storageQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$storageQuery->delete('storages')
-			->where($storageQuery->expr()->eq('id', $storageQuery->createParameter('id')));
-
-		$shareExternalQuery = Server::get(IDBConnection::class)->getQueryBuilder();
-		$shareExternalQuery->delete('share_external')
-			->where($shareExternalQuery->expr()->eq('share_token', $shareExternalQuery->createParameter('share_token')))
-			->andWhere($shareExternalQuery->expr()->eq('remote', $shareExternalQuery->createParameter('remote')));
-
-		foreach ($this->storages as $storage) {
-			if (isset($storage['id'])) {
-				$storageQuery->setParameter('id', $storage['id']);
-				$storageQuery->executeStatement();
-			}
-
-			if (isset($storage['share_token'])) {
-				$shareExternalQuery->setParameter('share_token', $storage['share_token']);
-				$shareExternalQuery->setParameter('remote', $storage['remote']);
-				$shareExternalQuery->executeStatement();
-			}
-		}
-
-		parent::tearDown();
-	}
-
-	private function doesStorageExist($numericId) {
-		$qb = Server::get(IDBConnection::class)->getQueryBuilder();
-		$qb->select('*')
-			->from('storages')
-			->where($qb->expr()->eq('numeric_id', $qb->createNamedParameter($numericId)));
-
-		$qResult = $qb->executeQuery();
-		$result = $qResult->fetch();
-		$qResult->closeCursor();
-		if (!empty($result)) {
-			return true;
-		}
-
-		$qb = Server::get(IDBConnection::class)->getQueryBuilder();
-		$qb->select('*')
-			->from('filecache')
-			->where($qb->expr()->eq('storage', $qb->createNamedParameter($numericId)));
-
-		$qResult = $qb->executeQuery();
-		$result = $qResult->fetch();
-		$qResult->closeCursor();
-		if (!empty($result)) {
-			return true;
-		}
-
-		return false;
-	}
-
-	/**
-	 * Test cleanup of orphaned storages
-	 */
-	public function testCleanup(): void {
-		$input = $this->getMockBuilder(InputInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$output = $this->getMockBuilder(OutputInterface::class)
-			->disableOriginalConstructor()
-			->getMock();
-
-		// parent folder, `files`, ´test` and `welcome.txt` => 4 elements
-		$outputCalls = [];
-		$output
-			->expects($this->any())
-			->method('writeln')
-			->willReturnCallback(function (string $text) use (&$outputCalls) {
-				$outputCalls[] = $text;
-			});
-
-		$this->cloudIdManager
-			->expects($this->any())
-			->method('getCloudId')
-			->will($this->returnCallback(function (string $user, string $remote) {
-				$cloudIdMock = $this->createMock(ICloudId::class);
-
-				// The remotes are already sanitized in the original data, so
-				// they can be directly returned.
-				$cloudIdMock
-					->expects($this->any())
-					->method('getRemote')
-					->willReturn($remote);
-
-				return $cloudIdMock;
-			}));
-
-		$this->command->execute($input, $output);
-
-		$this->assertTrue($this->doesStorageExist($this->storages[0]['numeric_id']));
-		$this->assertTrue($this->doesStorageExist($this->storages[1]['numeric_id']));
-		$this->assertFalse($this->doesStorageExist($this->storages[3]['numeric_id']));
-		$this->assertTrue($this->doesStorageExist($this->storages[4]['numeric_id']));
-		$this->assertFalse($this->doesStorageExist($this->storages[5]['numeric_id']));
-
-		$this->assertEquals([
-			'5 remote storage(s) need(s) to be checked',
-			'5 remote share(s) exist',
-		], array_slice($outputCalls, 0, 2));
-	}
+    protected IDBConnection $connection;
+    protected CleanupRemoteStorages $command;
+    private ICloudIdManager&MockObject $cloudIdManager;
+
+    private $storages = [
+        ['id' => 'shared::7b4a322b22f9d0047c38d77d471ce3cf', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e1', 'remote' => 'https://hostname.tld/owncloud1', 'user' => 'user1'],
+        ['id' => 'shared::efe3b456112c3780da6155d3a9b9141c', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e2', 'remote' => 'https://hostname.tld/owncloud2', 'user' => 'user2'],
+        ['notExistingId' => 'shared::33323d9f4ca416a9e3525b435354bc6f', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e3', 'remote' => 'https://hostname.tld/owncloud3', 'user' => 'user3'],
+        ['id' => 'shared::7fe41a07d3f517a923f4b2b599e72cbb', 'files_count' => 2],
+        ['id' => 'shared::de4aeb2f378d222b6d2c5fd8f4e42f8e', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e5', 'remote' => 'https://hostname.tld/owncloud5', 'user' => 'user5'],
+        ['id' => 'shared::af712293ab5eb9e6a1745a13818b99fe', 'files_count' => 3],
+        ['notExistingId' => 'shared::c34568c143cdac7d2f06e0800b5280f9', 'share_token' => 'f2c69dad1dc0649f26976fd210fc62e7', 'remote' => 'https://hostname.tld/owncloud7', 'user' => 'user7'],
+    ];
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = Server::get(IDBConnection::class);
+
+        $storageQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $storageQuery->insert('storages')
+            ->setValue('id', $storageQuery->createParameter('id'));
+
+        $shareExternalQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $shareExternalQuery->insert('share_external')
+            ->setValue('share_token', $shareExternalQuery->createParameter('share_token'))
+            ->setValue('remote', $shareExternalQuery->createParameter('remote'))
+            ->setValue('name', $shareExternalQuery->createParameter('name'))
+            ->setValue('owner', $shareExternalQuery->createParameter('owner'))
+            ->setValue('user', $shareExternalQuery->createParameter('user'))
+            ->setValue('mountpoint', $shareExternalQuery->createParameter('mountpoint'))
+            ->setValue('mountpoint_hash', $shareExternalQuery->createParameter('mountpoint_hash'));
+
+        $filesQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $filesQuery->insert('filecache')
+            ->setValue('storage', $filesQuery->createParameter('storage'))
+            ->setValue('path', $filesQuery->createParameter('path'))
+            ->setValue('path_hash', $filesQuery->createParameter('path_hash'));
+
+        foreach ($this->storages as &$storage) {
+            if (isset($storage['id'])) {
+                $storageQuery->setParameter('id', $storage['id']);
+                $storageQuery->executeStatement();
+                $storage['numeric_id'] = $storageQuery->getLastInsertId();
+            }
+
+            if (isset($storage['share_token'])) {
+                $shareExternalQuery
+                    ->setParameter('share_token', $storage['share_token'])
+                    ->setParameter('remote', $storage['remote'])
+                    ->setParameter('name', 'irrelevant')
+                    ->setParameter('owner', 'irrelevant')
+                    ->setParameter('user', $storage['user'])
+                    ->setParameter('mountpoint', 'irrelevant')
+                    ->setParameter('mountpoint_hash', 'irrelevant');
+                $shareExternalQuery->executeStatement();
+            }
+
+            if (isset($storage['files_count'])) {
+                for ($i = 0; $i < $storage['files_count']; $i++) {
+                    $filesQuery->setParameter('storage', $storage['numeric_id']);
+                    $filesQuery->setParameter('path', 'file' . $i);
+                    $filesQuery->setParameter('path_hash', md5('file' . $i));
+                    $filesQuery->executeStatement();
+                }
+            }
+        }
+
+        $this->cloudIdManager = $this->createMock(ICloudIdManager::class);
+
+        $this->command = new CleanupRemoteStorages($this->connection, $this->cloudIdManager);
+    }
+
+    protected function tearDown(): void {
+        $storageQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $storageQuery->delete('storages')
+            ->where($storageQuery->expr()->eq('id', $storageQuery->createParameter('id')));
+
+        $shareExternalQuery = Server::get(IDBConnection::class)->getQueryBuilder();
+        $shareExternalQuery->delete('share_external')
+            ->where($shareExternalQuery->expr()->eq('share_token', $shareExternalQuery->createParameter('share_token')))
+            ->andWhere($shareExternalQuery->expr()->eq('remote', $shareExternalQuery->createParameter('remote')));
+
+        foreach ($this->storages as $storage) {
+            if (isset($storage['id'])) {
+                $storageQuery->setParameter('id', $storage['id']);
+                $storageQuery->executeStatement();
+            }
+
+            if (isset($storage['share_token'])) {
+                $shareExternalQuery->setParameter('share_token', $storage['share_token']);
+                $shareExternalQuery->setParameter('remote', $storage['remote']);
+                $shareExternalQuery->executeStatement();
+            }
+        }
+
+        parent::tearDown();
+    }
+
+    private function doesStorageExist($numericId) {
+        $qb = Server::get(IDBConnection::class)->getQueryBuilder();
+        $qb->select('*')
+            ->from('storages')
+            ->where($qb->expr()->eq('numeric_id', $qb->createNamedParameter($numericId)));
+
+        $qResult = $qb->executeQuery();
+        $result = $qResult->fetch();
+        $qResult->closeCursor();
+        if (!empty($result)) {
+            return true;
+        }
+
+        $qb = Server::get(IDBConnection::class)->getQueryBuilder();
+        $qb->select('*')
+            ->from('filecache')
+            ->where($qb->expr()->eq('storage', $qb->createNamedParameter($numericId)));
+
+        $qResult = $qb->executeQuery();
+        $result = $qResult->fetch();
+        $qResult->closeCursor();
+        if (!empty($result)) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * Test cleanup of orphaned storages
+     */
+    public function testCleanup(): void {
+        $input = $this->getMockBuilder(InputInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $output = $this->getMockBuilder(OutputInterface::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        // parent folder, `files`, ´test` and `welcome.txt` => 4 elements
+        $outputCalls = [];
+        $output
+            ->expects($this->any())
+            ->method('writeln')
+            ->willReturnCallback(function (string $text) use (&$outputCalls) {
+                $outputCalls[] = $text;
+            });
+
+        $this->cloudIdManager
+            ->expects($this->any())
+            ->method('getCloudId')
+            ->will($this->returnCallback(function (string $user, string $remote) {
+                $cloudIdMock = $this->createMock(ICloudId::class);
+
+                // The remotes are already sanitized in the original data, so
+                // they can be directly returned.
+                $cloudIdMock
+                    ->expects($this->any())
+                    ->method('getRemote')
+                    ->willReturn($remote);
+
+                return $cloudIdMock;
+            }));
+
+        $this->command->execute($input, $output);
+
+        $this->assertTrue($this->doesStorageExist($this->storages[0]['numeric_id']));
+        $this->assertTrue($this->doesStorageExist($this->storages[1]['numeric_id']));
+        $this->assertFalse($this->doesStorageExist($this->storages[3]['numeric_id']));
+        $this->assertTrue($this->doesStorageExist($this->storages[4]['numeric_id']));
+        $this->assertFalse($this->doesStorageExist($this->storages[5]['numeric_id']));
+
+        $this->assertEquals([
+            '5 remote storage(s) need(s) to be checked',
+            '5 remote share(s) exist',
+        ], array_slice($outputCalls, 0, 2));
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -86,8 +86,8 @@ 
 			if (isset($storage['files_count'])) {
 				for ($i = 0; $i < $storage['files_count']; $i++) {
 					$filesQuery->setParameter('storage', $storage['numeric_id']);
-					$filesQuery->setParameter('path', 'file' . $i);
-					$filesQuery->setParameter('path_hash', md5('file' . $i));
+					$filesQuery->setParameter('path', 'file'.$i);
+					$filesQuery->setParameter('path_hash', md5('file'.$i));
 					$filesQuery->executeStatement();
 				}
 			}
@@ -168,14 +168,14 @@ 
 		$output
 			->expects($this->any())
 			->method('writeln')
-			->willReturnCallback(function (string $text) use (&$outputCalls) {
+			->willReturnCallback(function(string $text) use (&$outputCalls) {
 				$outputCalls[] = $text;
 			});
 
 		$this->cloudIdManager
 			->expects($this->any())
 			->method('getCloudId')
-			->will($this->returnCallback(function (string $user, string $remote) {
+			->will($this->returnCallback(function(string $user, string $remote) {
 				$cloudIdMock = $this->createMock(ICloudId::class);
 
 				// The remotes are already sanitized in the original data, so

apps/files_sharing/tests/Controller/ShareInfoControllerTest.php

Indentation +253 added lines, -253 removed lines

@@ -20,257 +20,257 @@
 
 class ShareInfoControllerTest extends TestCase {
 
-	protected ShareInfoController $controller;
-	protected ShareManager&MockObject $shareManager;
-
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->shareManager = $this->createMock(ShareManager::class);
-
-		$this->controller = new ShareInfoController(
-			'files_sharing',
-			$this->createMock(IRequest::class),
-			$this->shareManager
-		);
-	}
-
-	public function testNoShare(): void {
-		$this->shareManager->method('getShareByToken')
-			->with('token')
-			->willThrowException(new ShareNotFound());
-
-		$expected = new JSONResponse([], Http::STATUS_NOT_FOUND);
-		$expected->throttle(['token' => 'token']);
-		$this->assertEquals($expected, $this->controller->info('token'));
-	}
-
-	public function testWrongPassword(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')
-			->willReturn('sharePass');
-
-		$this->shareManager->method('getShareByToken')
-			->with('token')
-			->willReturn($share);
-		$this->shareManager->method('checkPassword')
-			->with($share, 'pass')
-			->willReturn(false);
-
-		$expected = new JSONResponse([], Http::STATUS_FORBIDDEN);
-		$expected->throttle(['token' => 'token']);
-		$this->assertEquals($expected, $this->controller->info('token', 'pass'));
-	}
-
-	public function testNoReadPermissions(): void {
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')
-			->willReturn('sharePass');
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_CREATE);
-
-		$this->shareManager->method('getShareByToken')
-			->with('token')
-			->willReturn($share);
-		$this->shareManager->method('checkPassword')
-			->with($share, 'pass')
-			->willReturn(true);
-
-		$expected = new JSONResponse([], Http::STATUS_FORBIDDEN);
-		$expected->throttle(['token' => 'token']);
-		$this->assertEquals($expected, $this->controller->info('token', 'pass'));
-	}
-
-	private function prepareFile() {
-		$file = $this->createMock(File::class);
-
-		$file->method('getId')->willReturn(42);
-
-		$parent = $this->createMock(Folder::class);
-		$parent->method('getId')->willReturn(41);
-		$file->method('getParent')->willReturn($parent);
-
-		$file->method('getMTime')->willReturn(1337);
-		$file->method('getName')->willReturn('file');
-		$file->method('getPermissions')->willReturn(Constants::PERMISSION_READ);
-		$file->method('getMimeType')->willReturn('mime/type');
-		$file->method('getSize')->willReturn(1);
-		$file->method('getType')->willReturn('file');
-		$file->method('getEtag')->willReturn('etag');
-
-		return $file;
-	}
-
-	public function testInfoFile(): void {
-		$file = $this->prepareFile();
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')
-			->willReturn('sharePass');
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE);
-		$share->method('getNode')
-			->willReturn($file);
-
-		$this->shareManager->method('getShareByToken')
-			->with('token')
-			->willReturn($share);
-		$this->shareManager->method('checkPassword')
-			->with($share, 'pass')
-			->willReturn(true);
-
-		$expected = new JSONResponse([
-			'id' => 42,
-			'parentId' => 41,
-			'mtime' => 1337	,
-			'name' => 'file',
-			'permissions' => 1,
-			'mimetype' => 'mime/type',
-			'size' => 1,
-			'type' => 'file',
-			'etag' => 'etag',
-		]);
-		$this->assertEquals($expected, $this->controller->info('token', 'pass'));
-	}
-
-	public function testInfoFileRO(): void {
-		$file = $this->prepareFile();
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')
-			->willReturn('sharePass');
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-		$share->method('getNode')
-			->willReturn($file);
-
-		$this->shareManager->method('getShareByToken')
-			->with('token')
-			->willReturn($share);
-		$this->shareManager->method('checkPassword')
-			->with($share, 'pass')
-			->willReturn(true);
-
-		$expected = new JSONResponse([
-			'id' => 42,
-			'parentId' => 41,
-			'mtime' => 1337	,
-			'name' => 'file',
-			'permissions' => 1,
-			'mimetype' => 'mime/type',
-			'size' => 1,
-			'type' => 'file',
-			'etag' => 'etag',
-		]);
-		$this->assertEquals($expected, $this->controller->info('token', 'pass'));
-	}
-
-	private function prepareFolder() {
-		$root = $this->createMock(Folder::class);
-
-		$root->method('getId')->willReturn(42);
-
-		$parent = $this->createMock(Folder::class);
-		$parent->method('getId')->willReturn(41);
-		$root->method('getParent')->willReturn($parent);
-
-		$root->method('getMTime')->willReturn(1337);
-		$root->method('getName')->willReturn('root');
-		$root->method('getPermissions')->willReturn(Constants::PERMISSION_READ);
-		$root->method('getMimeType')->willReturn('mime/type');
-		$root->method('getSize')->willReturn(1);
-		$root->method('getType')->willReturn('folder');
-		$root->method('getEtag')->willReturn('etag');
-
-
-		//Subfolder
-		$sub = $this->createMock(Folder::class);
-
-		$sub->method('getId')->willReturn(43);
-		$sub->method('getParent')->willReturn($root);
-		$sub->method('getMTime')->willReturn(1338);
-		$sub->method('getName')->willReturn('sub');
-		$sub->method('getPermissions')->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE);
-		$sub->method('getMimeType')->willReturn('mime/type');
-		$sub->method('getSize')->willReturn(2);
-		$sub->method('getType')->willReturn('folder');
-		$sub->method('getEtag')->willReturn('etag2');
-
-		$root->method('getDirectoryListing')->willReturn([$sub]);
-
-		//Subfile
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(88);
-		$file->method('getParent')->willReturn($sub);
-		$file->method('getMTime')->willReturn(1339);
-		$file->method('getName')->willReturn('file');
-		$file->method('getPermissions')->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_DELETE);
-		$file->method('getMimeType')->willReturn('mime/type');
-		$file->method('getSize')->willReturn(3);
-		$file->method('getType')->willReturn('file');
-		$file->method('getEtag')->willReturn('etag3');
-
-		$sub->method('getDirectoryListing')->willReturn([$file]);
-
-		return $root;
-	}
-
-	public function testInfoFolder(): void {
-		$file = $this->prepareFolder();
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getPassword')
-			->willReturn('sharePass');
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE);
-		$share->method('getNode')
-			->willReturn($file);
-
-		$this->shareManager->method('getShareByToken')
-			->with('token')
-			->willReturn($share);
-		$this->shareManager->method('checkPassword')
-			->with($share, 'pass')
-			->willReturn(true);
-
-		$expected = new JSONResponse([
-			'id' => 42,
-			'parentId' => 41,
-			'mtime' => 1337,
-			'name' => 'root',
-			'permissions' => 1,
-			'mimetype' => 'mime/type',
-			'size' => 1,
-			'type' => 'folder',
-			'etag' => 'etag',
-			'children' => [
-				[
-					'id' => 43,
-					'parentId' => 42,
-					'mtime' => 1338,
-					'name' => 'sub',
-					'permissions' => 3,
-					'mimetype' => 'mime/type',
-					'size' => 2,
-					'type' => 'folder',
-					'etag' => 'etag2',
-					'children' => [
-						[
-							'id' => 88,
-							'parentId' => 43,
-							'mtime' => 1339,
-							'name' => 'file',
-							'permissions' => 1,
-							'mimetype' => 'mime/type',
-							'size' => 3,
-							'type' => 'file',
-							'etag' => 'etag3',
-						]
-					],
-				]
-			],
-		]);
-		$this->assertEquals($expected, $this->controller->info('token', 'pass'));
-	}
+    protected ShareInfoController $controller;
+    protected ShareManager&MockObject $shareManager;
+
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->shareManager = $this->createMock(ShareManager::class);
+
+        $this->controller = new ShareInfoController(
+            'files_sharing',
+            $this->createMock(IRequest::class),
+            $this->shareManager
+        );
+    }
+
+    public function testNoShare(): void {
+        $this->shareManager->method('getShareByToken')
+            ->with('token')
+            ->willThrowException(new ShareNotFound());
+
+        $expected = new JSONResponse([], Http::STATUS_NOT_FOUND);
+        $expected->throttle(['token' => 'token']);
+        $this->assertEquals($expected, $this->controller->info('token'));
+    }
+
+    public function testWrongPassword(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')
+            ->willReturn('sharePass');
+
+        $this->shareManager->method('getShareByToken')
+            ->with('token')
+            ->willReturn($share);
+        $this->shareManager->method('checkPassword')
+            ->with($share, 'pass')
+            ->willReturn(false);
+
+        $expected = new JSONResponse([], Http::STATUS_FORBIDDEN);
+        $expected->throttle(['token' => 'token']);
+        $this->assertEquals($expected, $this->controller->info('token', 'pass'));
+    }
+
+    public function testNoReadPermissions(): void {
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')
+            ->willReturn('sharePass');
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_CREATE);
+
+        $this->shareManager->method('getShareByToken')
+            ->with('token')
+            ->willReturn($share);
+        $this->shareManager->method('checkPassword')
+            ->with($share, 'pass')
+            ->willReturn(true);
+
+        $expected = new JSONResponse([], Http::STATUS_FORBIDDEN);
+        $expected->throttle(['token' => 'token']);
+        $this->assertEquals($expected, $this->controller->info('token', 'pass'));
+    }
+
+    private function prepareFile() {
+        $file = $this->createMock(File::class);
+
+        $file->method('getId')->willReturn(42);
+
+        $parent = $this->createMock(Folder::class);
+        $parent->method('getId')->willReturn(41);
+        $file->method('getParent')->willReturn($parent);
+
+        $file->method('getMTime')->willReturn(1337);
+        $file->method('getName')->willReturn('file');
+        $file->method('getPermissions')->willReturn(Constants::PERMISSION_READ);
+        $file->method('getMimeType')->willReturn('mime/type');
+        $file->method('getSize')->willReturn(1);
+        $file->method('getType')->willReturn('file');
+        $file->method('getEtag')->willReturn('etag');
+
+        return $file;
+    }
+
+    public function testInfoFile(): void {
+        $file = $this->prepareFile();
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')
+            ->willReturn('sharePass');
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE);
+        $share->method('getNode')
+            ->willReturn($file);
+
+        $this->shareManager->method('getShareByToken')
+            ->with('token')
+            ->willReturn($share);
+        $this->shareManager->method('checkPassword')
+            ->with($share, 'pass')
+            ->willReturn(true);
+
+        $expected = new JSONResponse([
+            'id' => 42,
+            'parentId' => 41,
+            'mtime' => 1337	,
+            'name' => 'file',
+            'permissions' => 1,
+            'mimetype' => 'mime/type',
+            'size' => 1,
+            'type' => 'file',
+            'etag' => 'etag',
+        ]);
+        $this->assertEquals($expected, $this->controller->info('token', 'pass'));
+    }
+
+    public function testInfoFileRO(): void {
+        $file = $this->prepareFile();
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')
+            ->willReturn('sharePass');
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+        $share->method('getNode')
+            ->willReturn($file);
+
+        $this->shareManager->method('getShareByToken')
+            ->with('token')
+            ->willReturn($share);
+        $this->shareManager->method('checkPassword')
+            ->with($share, 'pass')
+            ->willReturn(true);
+
+        $expected = new JSONResponse([
+            'id' => 42,
+            'parentId' => 41,
+            'mtime' => 1337	,
+            'name' => 'file',
+            'permissions' => 1,
+            'mimetype' => 'mime/type',
+            'size' => 1,
+            'type' => 'file',
+            'etag' => 'etag',
+        ]);
+        $this->assertEquals($expected, $this->controller->info('token', 'pass'));
+    }
+
+    private function prepareFolder() {
+        $root = $this->createMock(Folder::class);
+
+        $root->method('getId')->willReturn(42);
+
+        $parent = $this->createMock(Folder::class);
+        $parent->method('getId')->willReturn(41);
+        $root->method('getParent')->willReturn($parent);
+
+        $root->method('getMTime')->willReturn(1337);
+        $root->method('getName')->willReturn('root');
+        $root->method('getPermissions')->willReturn(Constants::PERMISSION_READ);
+        $root->method('getMimeType')->willReturn('mime/type');
+        $root->method('getSize')->willReturn(1);
+        $root->method('getType')->willReturn('folder');
+        $root->method('getEtag')->willReturn('etag');
+
+
+        //Subfolder
+        $sub = $this->createMock(Folder::class);
+
+        $sub->method('getId')->willReturn(43);
+        $sub->method('getParent')->willReturn($root);
+        $sub->method('getMTime')->willReturn(1338);
+        $sub->method('getName')->willReturn('sub');
+        $sub->method('getPermissions')->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE);
+        $sub->method('getMimeType')->willReturn('mime/type');
+        $sub->method('getSize')->willReturn(2);
+        $sub->method('getType')->willReturn('folder');
+        $sub->method('getEtag')->willReturn('etag2');
+
+        $root->method('getDirectoryListing')->willReturn([$sub]);
+
+        //Subfile
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(88);
+        $file->method('getParent')->willReturn($sub);
+        $file->method('getMTime')->willReturn(1339);
+        $file->method('getName')->willReturn('file');
+        $file->method('getPermissions')->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_DELETE);
+        $file->method('getMimeType')->willReturn('mime/type');
+        $file->method('getSize')->willReturn(3);
+        $file->method('getType')->willReturn('file');
+        $file->method('getEtag')->willReturn('etag3');
+
+        $sub->method('getDirectoryListing')->willReturn([$file]);
+
+        return $root;
+    }
+
+    public function testInfoFolder(): void {
+        $file = $this->prepareFolder();
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getPassword')
+            ->willReturn('sharePass');
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE);
+        $share->method('getNode')
+            ->willReturn($file);
+
+        $this->shareManager->method('getShareByToken')
+            ->with('token')
+            ->willReturn($share);
+        $this->shareManager->method('checkPassword')
+            ->with($share, 'pass')
+            ->willReturn(true);
+
+        $expected = new JSONResponse([
+            'id' => 42,
+            'parentId' => 41,
+            'mtime' => 1337,
+            'name' => 'root',
+            'permissions' => 1,
+            'mimetype' => 'mime/type',
+            'size' => 1,
+            'type' => 'folder',
+            'etag' => 'etag',
+            'children' => [
+                [
+                    'id' => 43,
+                    'parentId' => 42,
+                    'mtime' => 1338,
+                    'name' => 'sub',
+                    'permissions' => 3,
+                    'mimetype' => 'mime/type',
+                    'size' => 2,
+                    'type' => 'folder',
+                    'etag' => 'etag2',
+                    'children' => [
+                        [
+                            'id' => 88,
+                            'parentId' => 43,
+                            'mtime' => 1339,
+                            'name' => 'file',
+                            'permissions' => 1,
+                            'mimetype' => 'mime/type',
+                            'size' => 3,
+                            'type' => 'file',
+                            'etag' => 'etag3',
+                        ]
+                    ],
+                ]
+            ],
+        ]);
+        $this->assertEquals($expected, $this->controller->info('token', 'pass'));
+    }
 }

apps/files_sharing/tests/Controller/ShareAPIControllerTest.php

Indentation +5116 added lines, -5116 removed lines

@@ -57,504 +57,504 @@ 
  */
 class ShareAPIControllerTest extends TestCase {
 
-	private string $appName = 'files_sharing';
-	private string $currentUser;
-
-	private ShareAPIController $ocs;
-
-	private IManager&MockObject $shareManager;
-	private IGroupManager&MockObject $groupManager;
-	private IUserManager&MockObject $userManager;
-	private IRequest&MockObject $request;
-	private IRootFolder&MockObject $rootFolder;
-	private IURLGenerator&MockObject $urlGenerator;
-	private IL10N&MockObject $l;
-	private IConfig&MockObject $config;
-	private IAppManager&MockObject $appManager;
-	private ContainerInterface&MockObject $serverContainer;
-	private IUserStatusManager&MockObject $userStatusManager;
-	private IPreview&MockObject $previewManager;
-	private IDateTimeZone&MockObject $dateTimeZone;
-	private LoggerInterface&MockObject $logger;
-	private IProviderFactory&MockObject $factory;
-	private IMailer&MockObject $mailer;
-	private ITagManager&MockObject $tagManager;
-
-	protected function setUp(): void {
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->shareManager
-			->expects($this->any())
-			->method('shareApiEnabled')
-			->willReturn(true);
-		$this->shareManager
-			->expects($this->any())
-			->method('shareProviderExists')->willReturn(true);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->currentUser = 'currentUser';
-
-		$this->l = $this->createMock(IL10N::class);
-		$this->l->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
-		$this->config = $this->createMock(IConfig::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->serverContainer = $this->createMock(ContainerInterface::class);
-		$this->userStatusManager = $this->createMock(IUserStatusManager::class);
-		$this->previewManager = $this->createMock(IPreview::class);
-		$this->previewManager->method('isAvailable')
-			->willReturnCallback(function ($fileInfo) {
-				return $fileInfo->getMimeType() === 'mimeWithPreview';
-			});
-		$this->dateTimeZone = $this->createMock(IDateTimeZone::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->factory = $this->createMock(IProviderFactory::class);
-		$this->mailer = $this->createMock(IMailer::class);
-		$this->tagManager = $this->createMock(ITagManager::class);
-
-		$this->ocs = new ShareAPIController(
-			$this->appName,
-			$this->request,
-			$this->shareManager,
-			$this->groupManager,
-			$this->userManager,
-			$this->rootFolder,
-			$this->urlGenerator,
-			$this->l,
-			$this->config,
-			$this->appManager,
-			$this->serverContainer,
-			$this->userStatusManager,
-			$this->previewManager,
-			$this->dateTimeZone,
-			$this->logger,
-			$this->factory,
-			$this->mailer,
-			$this->tagManager,
-			$this->currentUser,
-		);
-	}
-
-	/**
-	 * @return ShareAPIController&MockObject
-	 */
-	private function mockFormatShare() {
-		return $this->getMockBuilder(ShareAPIController::class)
-			->setConstructorArgs([
-				$this->appName,
-				$this->request,
-				$this->shareManager,
-				$this->groupManager,
-				$this->userManager,
-				$this->rootFolder,
-				$this->urlGenerator,
-				$this->l,
-				$this->config,
-				$this->appManager,
-				$this->serverContainer,
-				$this->userStatusManager,
-				$this->previewManager,
-				$this->dateTimeZone,
-				$this->logger,
-				$this->factory,
-				$this->mailer,
-				$this->tagManager,
-				$this->currentUser,
-			])->onlyMethods(['formatShare'])
-			->getMock();
-	}
-
-	private function newShare() {
-		return Server::get(IManager::class)->newShare();
-	}
-
-
-	private function mockShareAttributes() {
-		$formattedShareAttributes = [
-			[
-				'scope' => 'permissions',
-				'key' => 'download',
-				'value' => true
-			]
-		];
-
-		$shareAttributes = $this->createMock(IShareAttributes::class);
-		$shareAttributes->method('toArray')->willReturn($formattedShareAttributes);
-		$shareAttributes->method('getAttribute')->with('permissions', 'download')->willReturn(true);
-
-		// send both IShare attributes class and expected json string
-		return [$shareAttributes, \json_encode($formattedShareAttributes)];
-	}
-
-	public function testDeleteShareShareNotFound(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Wrong share ID, share does not exist');
-
-		$this->shareManager
-			->expects($this->exactly(7))
-			->method('getShareById')
-			->willReturnCallback(function ($id): void {
-				if ($id === 'ocinternal:42' || $id === 'ocRoomShare:42' || $id === 'ocFederatedSharing:42' || $id === 'ocCircleShare:42' || $id === 'ocMailShare:42' || $id === 'deck:42' || $id === 'sciencemesh:42') {
-					throw new ShareNotFound();
-				} else {
-					throw new \Exception();
-				}
-			});
-
-		$this->shareManager->method('outgoingServer2ServerSharesAllowed')->willReturn(true);
-
-		$this->ocs->deleteShare(42);
-	}
-
-	public function testDeleteShare(): void {
-		$node = $this->getMockBuilder(File::class)->getMock();
-
-		$share = $this->newShare();
-		$share->setSharedBy($this->currentUser)
-			->setNode($node);
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:42')
-			->willReturn($share);
-		$this->shareManager
-			->expects($this->once())
-			->method('deleteShare')
-			->with($share);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$expected = new DataResponse();
-		$result = $this->ocs->deleteShare(42);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-
-	public function testDeleteShareLocked(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Could not delete share');
-
-		$node = $this->getMockBuilder(File::class)->getMock();
-		$node->method('getId')->willReturn(1);
-
-		$share = $this->newShare();
-		$share->setNode($node);
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with($share->getNodeId())
-			->willReturn([$node]);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:42')
-			->willReturn($share);
-
-		$this->shareManager
-			->expects($this->never())
-			->method('deleteShare')
-			->with($share);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED)
-			->will($this->throwException(new LockedException('mypath')));
-
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteFromSelf', [$share]));
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
-
-		$this->ocs->deleteShare(42);
-	}
-
-	/**
-	 * You can always remove a share that was shared with you
-	 */
-	public function testDeleteShareWithMe(): void {
-		$node = $this->getMockBuilder(File::class)->getMock();
-
-		$share = $this->newShare();
-		$share->setSharedWith($this->currentUser)
-			->setShareType(IShare::TYPE_USER)
-			->setNode($node);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:42')
-			->willReturn($share);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('deleteShare')
-			->with($share);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteFromSelf', [$share]));
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
-
-		$this->ocs->deleteShare(42);
-	}
-
-	/**
-	 * You can always delete a share you own
-	 */
-	public function testDeleteShareOwner(): void {
-		$node = $this->getMockBuilder(File::class)->getMock();
-
-		$share = $this->newShare();
-		$share->setSharedBy($this->currentUser)
-			->setNode($node);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:42')
-			->willReturn($share);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('deleteShare')
-			->with($share);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteFromSelf', [$share]));
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
-
-		$this->ocs->deleteShare(42);
-	}
-
-	/**
-	 * You can always delete a share when you own
-	 * the file path it belong to
-	 */
-	public function testDeleteShareFileOwner(): void {
-		$node = $this->getMockBuilder(File::class)->getMock();
-		$node->method('getId')->willReturn(1);
-
-		$share = $this->newShare();
-		$share->setShareOwner($this->currentUser)
-			->setNode($node);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:42')
-			->willReturn($share);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('deleteShare')
-			->with($share);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteFromSelf', [$share]));
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
-
-		$this->ocs->deleteShare(42);
-	}
-
-	/**
-	 * You can remove (the mountpoint, not the share)
-	 * a share if you're in the group the share is shared with
-	 */
-	public function testDeleteSharedWithMyGroup(): void {
-		$node = $this->getMockBuilder(File::class)->getMock();
-		$node->method('getId')->willReturn(1);
-
-		$share = $this->newShare();
-		$share->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('group')
-			->setNode($node);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:42')
-			->willReturn($share);
-
-		// canDeleteShareFromSelf
-		$user = $this->createMock(IUser::class);
-		$group = $this->getMockBuilder(IGroup::class)->getMock();
-		$this->groupManager
-			->method('get')
-			->with('group')
-			->willReturn($group);
-		$this->userManager
-			->method('get')
-			->with($this->currentUser)
-			->willReturn($user);
-		$group->method('inGroup')
-			->with($user)
-			->willReturn(true);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with($share->getNodeId())
-			->willReturn([$share->getNode()]);
-
-		$this->shareManager->expects($this->once())
-			->method('deleteFromSelf')
-			->with($share, $this->currentUser);
-
-		$this->shareManager->expects($this->never())
-			->method('deleteShare');
-
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canDeleteShareFromSelf', [$share]));
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
-
-		$this->ocs->deleteShare(42);
-	}
-
-	/**
-	 * You cannot remove a share if you're not
-	 * in the group the share is shared with
-	 */
-	public function testDeleteSharedWithGroupIDontBelongTo(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Wrong share ID, share does not exist');
-
-		$node = $this->getMockBuilder(File::class)->getMock();
-		$node->method('getId')->willReturn(42);
-
-		$share = $this->newShare();
-		$share->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('group')
-			->setNode($node);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:42')
-			->willReturn($share);
-
-		// canDeleteShareFromSelf
-		$user = $this->createMock(IUser::class);
-		$group = $this->getMockBuilder(IGroup::class)->getMock();
-		$this->groupManager
-			->method('get')
-			->with('group')
-			->willReturn($group);
-		$this->userManager
-			->method('get')
-			->with($this->currentUser)
-			->willReturn($user);
-		$group->method('inGroup')
-			->with($user)
-			->willReturn(false);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with($share->getNodeId())
-			->willReturn([$share->getNode()]);
-
-		$this->shareManager->expects($this->never())
-			->method('deleteFromSelf');
-
-		$this->shareManager->expects($this->never())
-			->method('deleteShare');
-
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteShareFromSelf', [$share]));
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
-
-		$this->ocs->deleteShare(42);
-	}
-
-	public function testDeleteShareOwnerless(): void {
-		$ocs = $this->mockFormatShare();
-
-		$mount = $this->createMock(IShareOwnerlessMount::class);
-
-		$file = $this->createMock(File::class);
-		$file
-			->expects($this->exactly(2))
-			->method('getPermissions')
-			->willReturn(Constants::PERMISSION_SHARE);
-		$file
-			->expects($this->once())
-			->method('getMountPoint')
-			->willReturn($mount);
-
-		$userFolder = $this->createMock(Folder::class);
-		$userFolder->method('getById')
-			->with(2)
-			->willReturn([$file]);
-		$userFolder->method('getFirstNodeById')
-			->with(2)
-			->willReturn($file);
-
-		$this->rootFolder
-			->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$share = $this->createMock(IShare::class);
-		$share
-			->expects($this->once())
-			->method('getNode')
-			->willReturn($file);
-		$share
-			->expects($this->exactly(2))
-			->method('getNodeId')
-			->willReturn(2);
-		$share
-			->expects($this->exactly(2))
-			->method('getPermissions')
-			->willReturn(Constants::PERMISSION_SHARE);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:1', $this->currentUser)
-			->willReturn($share);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('deleteShare')
-			->with($share);
-
-		$result = $ocs->deleteShare(1);
-		$this->assertInstanceOf(DataResponse::class, $result);
-	}
-
-	/*
+    private string $appName = 'files_sharing';
+    private string $currentUser;
+
+    private ShareAPIController $ocs;
+
+    private IManager&MockObject $shareManager;
+    private IGroupManager&MockObject $groupManager;
+    private IUserManager&MockObject $userManager;
+    private IRequest&MockObject $request;
+    private IRootFolder&MockObject $rootFolder;
+    private IURLGenerator&MockObject $urlGenerator;
+    private IL10N&MockObject $l;
+    private IConfig&MockObject $config;
+    private IAppManager&MockObject $appManager;
+    private ContainerInterface&MockObject $serverContainer;
+    private IUserStatusManager&MockObject $userStatusManager;
+    private IPreview&MockObject $previewManager;
+    private IDateTimeZone&MockObject $dateTimeZone;
+    private LoggerInterface&MockObject $logger;
+    private IProviderFactory&MockObject $factory;
+    private IMailer&MockObject $mailer;
+    private ITagManager&MockObject $tagManager;
+
+    protected function setUp(): void {
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->shareManager
+            ->expects($this->any())
+            ->method('shareApiEnabled')
+            ->willReturn(true);
+        $this->shareManager
+            ->expects($this->any())
+            ->method('shareProviderExists')->willReturn(true);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->currentUser = 'currentUser';
+
+        $this->l = $this->createMock(IL10N::class);
+        $this->l->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
+        $this->config = $this->createMock(IConfig::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->serverContainer = $this->createMock(ContainerInterface::class);
+        $this->userStatusManager = $this->createMock(IUserStatusManager::class);
+        $this->previewManager = $this->createMock(IPreview::class);
+        $this->previewManager->method('isAvailable')
+            ->willReturnCallback(function ($fileInfo) {
+                return $fileInfo->getMimeType() === 'mimeWithPreview';
+            });
+        $this->dateTimeZone = $this->createMock(IDateTimeZone::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->factory = $this->createMock(IProviderFactory::class);
+        $this->mailer = $this->createMock(IMailer::class);
+        $this->tagManager = $this->createMock(ITagManager::class);
+
+        $this->ocs = new ShareAPIController(
+            $this->appName,
+            $this->request,
+            $this->shareManager,
+            $this->groupManager,
+            $this->userManager,
+            $this->rootFolder,
+            $this->urlGenerator,
+            $this->l,
+            $this->config,
+            $this->appManager,
+            $this->serverContainer,
+            $this->userStatusManager,
+            $this->previewManager,
+            $this->dateTimeZone,
+            $this->logger,
+            $this->factory,
+            $this->mailer,
+            $this->tagManager,
+            $this->currentUser,
+        );
+    }
+
+    /**
+     * @return ShareAPIController&MockObject
+     */
+    private function mockFormatShare() {
+        return $this->getMockBuilder(ShareAPIController::class)
+            ->setConstructorArgs([
+                $this->appName,
+                $this->request,
+                $this->shareManager,
+                $this->groupManager,
+                $this->userManager,
+                $this->rootFolder,
+                $this->urlGenerator,
+                $this->l,
+                $this->config,
+                $this->appManager,
+                $this->serverContainer,
+                $this->userStatusManager,
+                $this->previewManager,
+                $this->dateTimeZone,
+                $this->logger,
+                $this->factory,
+                $this->mailer,
+                $this->tagManager,
+                $this->currentUser,
+            ])->onlyMethods(['formatShare'])
+            ->getMock();
+    }
+
+    private function newShare() {
+        return Server::get(IManager::class)->newShare();
+    }
+
+
+    private function mockShareAttributes() {
+        $formattedShareAttributes = [
+            [
+                'scope' => 'permissions',
+                'key' => 'download',
+                'value' => true
+            ]
+        ];
+
+        $shareAttributes = $this->createMock(IShareAttributes::class);
+        $shareAttributes->method('toArray')->willReturn($formattedShareAttributes);
+        $shareAttributes->method('getAttribute')->with('permissions', 'download')->willReturn(true);
+
+        // send both IShare attributes class and expected json string
+        return [$shareAttributes, \json_encode($formattedShareAttributes)];
+    }
+
+    public function testDeleteShareShareNotFound(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Wrong share ID, share does not exist');
+
+        $this->shareManager
+            ->expects($this->exactly(7))
+            ->method('getShareById')
+            ->willReturnCallback(function ($id): void {
+                if ($id === 'ocinternal:42' || $id === 'ocRoomShare:42' || $id === 'ocFederatedSharing:42' || $id === 'ocCircleShare:42' || $id === 'ocMailShare:42' || $id === 'deck:42' || $id === 'sciencemesh:42') {
+                    throw new ShareNotFound();
+                } else {
+                    throw new \Exception();
+                }
+            });
+
+        $this->shareManager->method('outgoingServer2ServerSharesAllowed')->willReturn(true);
+
+        $this->ocs->deleteShare(42);
+    }
+
+    public function testDeleteShare(): void {
+        $node = $this->getMockBuilder(File::class)->getMock();
+
+        $share = $this->newShare();
+        $share->setSharedBy($this->currentUser)
+            ->setNode($node);
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:42')
+            ->willReturn($share);
+        $this->shareManager
+            ->expects($this->once())
+            ->method('deleteShare')
+            ->with($share);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $expected = new DataResponse();
+        $result = $this->ocs->deleteShare(42);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+
+    public function testDeleteShareLocked(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Could not delete share');
+
+        $node = $this->getMockBuilder(File::class)->getMock();
+        $node->method('getId')->willReturn(1);
+
+        $share = $this->newShare();
+        $share->setNode($node);
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with($share->getNodeId())
+            ->willReturn([$node]);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:42')
+            ->willReturn($share);
+
+        $this->shareManager
+            ->expects($this->never())
+            ->method('deleteShare')
+            ->with($share);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED)
+            ->will($this->throwException(new LockedException('mypath')));
+
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteFromSelf', [$share]));
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
+
+        $this->ocs->deleteShare(42);
+    }
+
+    /**
+     * You can always remove a share that was shared with you
+     */
+    public function testDeleteShareWithMe(): void {
+        $node = $this->getMockBuilder(File::class)->getMock();
+
+        $share = $this->newShare();
+        $share->setSharedWith($this->currentUser)
+            ->setShareType(IShare::TYPE_USER)
+            ->setNode($node);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:42')
+            ->willReturn($share);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('deleteShare')
+            ->with($share);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteFromSelf', [$share]));
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
+
+        $this->ocs->deleteShare(42);
+    }
+
+    /**
+     * You can always delete a share you own
+     */
+    public function testDeleteShareOwner(): void {
+        $node = $this->getMockBuilder(File::class)->getMock();
+
+        $share = $this->newShare();
+        $share->setSharedBy($this->currentUser)
+            ->setNode($node);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:42')
+            ->willReturn($share);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('deleteShare')
+            ->with($share);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteFromSelf', [$share]));
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
+
+        $this->ocs->deleteShare(42);
+    }
+
+    /**
+     * You can always delete a share when you own
+     * the file path it belong to
+     */
+    public function testDeleteShareFileOwner(): void {
+        $node = $this->getMockBuilder(File::class)->getMock();
+        $node->method('getId')->willReturn(1);
+
+        $share = $this->newShare();
+        $share->setShareOwner($this->currentUser)
+            ->setNode($node);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:42')
+            ->willReturn($share);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('deleteShare')
+            ->with($share);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteFromSelf', [$share]));
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
+
+        $this->ocs->deleteShare(42);
+    }
+
+    /**
+     * You can remove (the mountpoint, not the share)
+     * a share if you're in the group the share is shared with
+     */
+    public function testDeleteSharedWithMyGroup(): void {
+        $node = $this->getMockBuilder(File::class)->getMock();
+        $node->method('getId')->willReturn(1);
+
+        $share = $this->newShare();
+        $share->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('group')
+            ->setNode($node);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:42')
+            ->willReturn($share);
+
+        // canDeleteShareFromSelf
+        $user = $this->createMock(IUser::class);
+        $group = $this->getMockBuilder(IGroup::class)->getMock();
+        $this->groupManager
+            ->method('get')
+            ->with('group')
+            ->willReturn($group);
+        $this->userManager
+            ->method('get')
+            ->with($this->currentUser)
+            ->willReturn($user);
+        $group->method('inGroup')
+            ->with($user)
+            ->willReturn(true);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with($share->getNodeId())
+            ->willReturn([$share->getNode()]);
+
+        $this->shareManager->expects($this->once())
+            ->method('deleteFromSelf')
+            ->with($share, $this->currentUser);
+
+        $this->shareManager->expects($this->never())
+            ->method('deleteShare');
+
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canDeleteShareFromSelf', [$share]));
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
+
+        $this->ocs->deleteShare(42);
+    }
+
+    /**
+     * You cannot remove a share if you're not
+     * in the group the share is shared with
+     */
+    public function testDeleteSharedWithGroupIDontBelongTo(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Wrong share ID, share does not exist');
+
+        $node = $this->getMockBuilder(File::class)->getMock();
+        $node->method('getId')->willReturn(42);
+
+        $share = $this->newShare();
+        $share->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('group')
+            ->setNode($node);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:42')
+            ->willReturn($share);
+
+        // canDeleteShareFromSelf
+        $user = $this->createMock(IUser::class);
+        $group = $this->getMockBuilder(IGroup::class)->getMock();
+        $this->groupManager
+            ->method('get')
+            ->with('group')
+            ->willReturn($group);
+        $this->userManager
+            ->method('get')
+            ->with($this->currentUser)
+            ->willReturn($user);
+        $group->method('inGroup')
+            ->with($user)
+            ->willReturn(false);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with($share->getNodeId())
+            ->willReturn([$share->getNode()]);
+
+        $this->shareManager->expects($this->never())
+            ->method('deleteFromSelf');
+
+        $this->shareManager->expects($this->never())
+            ->method('deleteShare');
+
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteShareFromSelf', [$share]));
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canDeleteShare', [$share]));
+
+        $this->ocs->deleteShare(42);
+    }
+
+    public function testDeleteShareOwnerless(): void {
+        $ocs = $this->mockFormatShare();
+
+        $mount = $this->createMock(IShareOwnerlessMount::class);
+
+        $file = $this->createMock(File::class);
+        $file
+            ->expects($this->exactly(2))
+            ->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_SHARE);
+        $file
+            ->expects($this->once())
+            ->method('getMountPoint')
+            ->willReturn($mount);
+
+        $userFolder = $this->createMock(Folder::class);
+        $userFolder->method('getById')
+            ->with(2)
+            ->willReturn([$file]);
+        $userFolder->method('getFirstNodeById')
+            ->with(2)
+            ->willReturn($file);
+
+        $this->rootFolder
+            ->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $share = $this->createMock(IShare::class);
+        $share
+            ->expects($this->once())
+            ->method('getNode')
+            ->willReturn($file);
+        $share
+            ->expects($this->exactly(2))
+            ->method('getNodeId')
+            ->willReturn(2);
+        $share
+            ->expects($this->exactly(2))
+            ->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_SHARE);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:1', $this->currentUser)
+            ->willReturn($share);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('deleteShare')
+            ->with($share);
+
+        $result = $ocs->deleteShare(1);
+        $this->assertInstanceOf(DataResponse::class, $result);
+    }
+
+    /*
 	 * FIXME: Enable once we have a federated Share Provider
 
 	public function testGetGetShareNotExists() {
@@ -569,4623 +569,4623 @@ 
 	}
 	*/
 
-	public function createShare($id, $shareType, $sharedWith, $sharedBy, $shareOwner, $path, $permissions,
-		$shareTime, $expiration, $parent, $target, $mail_send, $note = '', $token = null,
-		$password = null, $label = '', $attributes = null) {
-		$share = $this->getMockBuilder(IShare::class)->getMock();
-		$share->method('getId')->willReturn($id);
-		$share->method('getShareType')->willReturn($shareType);
-		$share->method('getSharedWith')->willReturn($sharedWith);
-		$share->method('getSharedBy')->willReturn($sharedBy);
-		$share->method('getShareOwner')->willReturn($shareOwner);
-		$share->method('getNode')->willReturn($path);
-		$share->method('getPermissions')->willReturn($permissions);
-		$share->method('getNote')->willReturn($note);
-		$share->method('getLabel')->willReturn($label);
-		$share->method('getAttributes')->willReturn($attributes);
-		$time = new \DateTime();
-		$time->setTimestamp($shareTime);
-		$share->method('getShareTime')->willReturn($time);
-		$share->method('getExpirationDate')->willReturn($expiration);
-		$share->method('getTarget')->willReturn($target);
-		$share->method('getMailSend')->willReturn($mail_send);
-		$share->method('getToken')->willReturn($token);
-		$share->method('getPassword')->willReturn($password);
-
-		if ($shareType === IShare::TYPE_USER ||
-			$shareType === IShare::TYPE_GROUP ||
-			$shareType === IShare::TYPE_LINK) {
-			$share->method('getFullId')->willReturn('ocinternal:' . $id);
-		}
-
-		return $share;
-	}
-
-	public function dataGetShare() {
-		$data = [];
-
-		$cache = $this->getMockBuilder('OC\Files\Cache\Cache')
-			->disableOriginalConstructor()
-			->getMock();
-		$cache->method('getNumericStorageId')->willReturn(101);
-
-		$storage = $this->getMockBuilder(IStorage::class)
-			->disableOriginalConstructor()
-			->getMock();
-		$storage->method('getId')->willReturn('STORAGE');
-		$storage->method('getCache')->willReturn($cache);
-
-		$parentFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$parentFolder->method('getId')->willReturn(3);
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$mountPoint->method('getMountType')->willReturn('');
-
-		$file = $this->getMockBuilder('OCP\Files\File')->getMock();
-		$file->method('getId')->willReturn(1);
-		$file->method('getPath')->willReturn('file');
-		$file->method('getStorage')->willReturn($storage);
-		$file->method('getParent')->willReturn($parentFolder);
-		$file->method('getSize')->willReturn(123465);
-		$file->method('getMTime')->willReturn(1234567890);
-		$file->method('getMimeType')->willReturn('myMimeType');
-		$file->method('getMountPoint')->willReturn($mountPoint);
-
-		$folder = $this->getMockBuilder(Folder::class)->getMock();
-		$folder->method('getId')->willReturn(2);
-		$folder->method('getPath')->willReturn('folder');
-		$folder->method('getStorage')->willReturn($storage);
-		$folder->method('getParent')->willReturn($parentFolder);
-		$folder->method('getSize')->willReturn(123465);
-		$folder->method('getMTime')->willReturn(1234567890);
-		$folder->method('getMimeType')->willReturn('myFolderMimeType');
-		$folder->method('getMountPoint')->willReturn($mountPoint);
-
-		[$shareAttributes, $shareAttributesReturnJson] = $this->mockShareAttributes();
-
-		// File shared with user
-		$share = $this->createShare(
-			100,
-			IShare::TYPE_USER,
-			'userId',
-			'initiatorId',
-			'ownerId',
-			$file,
-			4,
-			5,
-			null,
-			6,
-			'target',
-			0,
-			'personal note',
-			$shareAttributes,
-		);
-		$expected = [
-			'id' => 100,
-			'share_type' => IShare::TYPE_USER,
-			'share_with' => 'userId',
-			'share_with_displayname' => 'userDisplay',
-			'share_with_displayname_unique' => 'userId@example.com',
-			'uid_owner' => 'initiatorId',
-			'displayname_owner' => 'initiatorDisplay',
-			'item_type' => 'file',
-			'item_source' => 1,
-			'file_source' => 1,
-			'file_target' => 'target',
-			'file_parent' => 3,
-			'token' => null,
-			'expiration' => null,
-			'permissions' => 4,
-			'attributes' => $shareAttributesReturnJson,
-			'stime' => 5,
-			'parent' => null,
-			'storage_id' => 'STORAGE',
-			'path' => 'file',
-			'storage' => 101,
-			'mail_send' => 0,
-			'uid_file_owner' => 'ownerId',
-			'note' => 'personal note',
-			'label' => '',
-			'displayname_file_owner' => 'ownerDisplay',
-			'mimetype' => 'myMimeType',
-			'has_preview' => false,
-			'hide_download' => 0,
-			'can_edit' => false,
-			'can_delete' => false,
-			'item_size' => 123465,
-			'item_mtime' => 1234567890,
-			'attributes' => null,
-			'item_permissions' => 4,
-			'is-mount-root' => false,
-			'mount-type' => '',
-		];
-		$data[] = [$share, $expected];
-
-		// Folder shared with group
-		$share = $this->createShare(
-			101,
-			IShare::TYPE_GROUP,
-			'groupId',
-			'initiatorId',
-			'ownerId',
-			$folder,
-			4,
-			5,
-			null,
-			6,
-			'target',
-			0,
-			'personal note',
-			$shareAttributes,
-		);
-		$expected = [
-			'id' => 101,
-			'share_type' => IShare::TYPE_GROUP,
-			'share_with' => 'groupId',
-			'share_with_displayname' => 'groupId',
-			'uid_owner' => 'initiatorId',
-			'displayname_owner' => 'initiatorDisplay',
-			'item_type' => 'folder',
-			'item_source' => 2,
-			'file_source' => 2,
-			'file_target' => 'target',
-			'file_parent' => 3,
-			'token' => null,
-			'expiration' => null,
-			'permissions' => 4,
-			'attributes' => $shareAttributesReturnJson,
-			'stime' => 5,
-			'parent' => null,
-			'storage_id' => 'STORAGE',
-			'path' => 'folder',
-			'storage' => 101,
-			'mail_send' => 0,
-			'uid_file_owner' => 'ownerId',
-			'note' => 'personal note',
-			'label' => '',
-			'displayname_file_owner' => 'ownerDisplay',
-			'mimetype' => 'myFolderMimeType',
-			'has_preview' => false,
-			'hide_download' => 0,
-			'can_edit' => false,
-			'can_delete' => false,
-			'item_size' => 123465,
-			'item_mtime' => 1234567890,
-			'attributes' => null,
-			'item_permissions' => 4,
-			'is-mount-root' => false,
-			'mount-type' => '',
-		];
-		$data[] = [$share, $expected];
-
-		// File shared by link with Expire
-		$expire = \DateTime::createFromFormat('Y-m-d h:i:s', '2000-01-02 01:02:03');
-		$share = $this->createShare(
-			101,
-			IShare::TYPE_LINK,
-			null,
-			'initiatorId',
-			'ownerId',
-			$folder,
-			4,
-			5,
-			$expire,
-			6,
-			'target',
-			0,
-			'personal note',
-			'token',
-			'password',
-			'first link share'
-		);
-		$expected = [
-			'id' => 101,
-			'share_type' => IShare::TYPE_LINK,
-			'password' => 'password',
-			'share_with' => 'password',
-			'share_with_displayname' => '(Shared link)',
-			'send_password_by_talk' => false,
-			'uid_owner' => 'initiatorId',
-			'displayname_owner' => 'initiatorDisplay',
-			'item_type' => 'folder',
-			'item_source' => 2,
-			'file_source' => 2,
-			'file_target' => 'target',
-			'file_parent' => 3,
-			'token' => 'token',
-			'expiration' => '2000-01-02 00:00:00',
-			'permissions' => 4,
-			'attributes' => null,
-			'stime' => 5,
-			'parent' => null,
-			'storage_id' => 'STORAGE',
-			'path' => 'folder',
-			'storage' => 101,
-			'mail_send' => 0,
-			'url' => 'url',
-			'uid_file_owner' => 'ownerId',
-			'note' => 'personal note',
-			'label' => 'first link share',
-			'displayname_file_owner' => 'ownerDisplay',
-			'mimetype' => 'myFolderMimeType',
-			'has_preview' => false,
-			'hide_download' => 0,
-			'can_edit' => false,
-			'can_delete' => false,
-			'item_size' => 123465,
-			'item_mtime' => 1234567890,
-			'attributes' => null,
-			'item_permissions' => 4,
-			'is-mount-root' => false,
-			'mount-type' => '',
-		];
-		$data[] = [$share, $expected];
-
-		return $data;
-	}
-
-	/**
-	 * @dataProvider dataGetShare
-	 */
-	public function testGetShare(IShare $share, array $result): void {
-		/** @var ShareAPIController&MockObject $ocs */
-		$ocs = $this->getMockBuilder(ShareAPIController::class)
-			->setConstructorArgs([
-				$this->appName,
-				$this->request,
-				$this->shareManager,
-				$this->groupManager,
-				$this->userManager,
-				$this->rootFolder,
-				$this->urlGenerator,
-				$this->l,
-				$this->config,
-				$this->appManager,
-				$this->serverContainer,
-				$this->userStatusManager,
-				$this->previewManager,
-				$this->dateTimeZone,
-				$this->logger,
-				$this->factory,
-				$this->mailer,
-				$this->tagManager,
-				$this->currentUser,
-			])
-			->onlyMethods(['canAccessShare'])
-			->getMock();
-
-		$ocs->expects($this->any())
-			->method('canAccessShare')
-			->willReturn(true);
-
-		$this->shareManager
-			->expects($this->any())
-			->method('getShareById')
-			->with($share->getFullId(), 'currentUser')
-			->willReturn($share);
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$userFolder
-			->method('getRelativePath')
-			->willReturnArgument(0);
-
-		$userFolder->method('getById')
-			->with($share->getNodeId())
-			->willReturn([$share->getNode()]);
-		$userFolder->method('getFirstNodeById')
-			->with($share->getNodeId())
-			->willReturn($share->getNode());
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$this->urlGenerator
-			->method('linkToRouteAbsolute')
-			->willReturn('url');
-
-		$initiator = $this->getMockBuilder(IUser::class)->getMock();
-		$initiator->method('getUID')->willReturn('initiatorId');
-		$initiator->method('getDisplayName')->willReturn('initiatorDisplay');
-
-		$owner = $this->getMockBuilder(IUser::class)->getMock();
-		$owner->method('getUID')->willReturn('ownerId');
-		$owner->method('getDisplayName')->willReturn('ownerDisplay');
-
-		$user = $this->getMockBuilder(IUser::class)->getMock();
-		$user->method('getUID')->willReturn('userId');
-		$user->method('getDisplayName')->willReturn('userDisplay');
-		$user->method('getSystemEMailAddress')->willReturn('userId@example.com');
-
-		$group = $this->getMockBuilder(IGroup::class)->getMock();
-		$group->method('getGID')->willReturn('groupId');
-
-		$this->userManager->method('get')->willReturnMap([
-			['userId', $user],
-			['initiatorId', $initiator],
-			['ownerId', $owner],
-		]);
-		$this->groupManager->method('get')->willReturnMap([
-			['group', $group],
-		]);
-		$this->dateTimeZone->method('getTimezone')->willReturn(new \DateTimeZone('UTC'));
-
-		$data = $ocs->getShare($share->getId())->getData()[0];
-		$this->assertEquals($result, $data);
-	}
-
-
-	public function testGetShareInvalidNode(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Wrong share ID, share does not exist');
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setSharedBy('initiator')
-			->setSharedWith('recipient')
-			->setShareOwner('owner');
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:42', 'currentUser')
-			->willReturn($share);
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$this->ocs->getShare(42);
-	}
-
-	public function dataGetShares() {
-		$folder = $this->getMockBuilder(Folder::class)->getMock();
-		$file1 = $this->getMockBuilder(File::class)->getMock();
-		$file1->method('getName')
-			->willReturn('file1');
-		$file2 = $this->getMockBuilder(File::class)->getMock();
-		$file2->method('getName')
-			->willReturn('file2');
-
-		$folder->method('getDirectoryListing')
-			->willReturn([$file1, $file2]);
-
-		$file1UserShareOwner = Server::get(IManager::class)->newShare();
-		$file1UserShareOwner->setShareType(IShare::TYPE_USER)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(4);
-
-		$file1UserShareOwnerExpected = [
-			'id' => 4,
-			'share_type' => IShare::TYPE_USER,
-		];
-
-		$file1UserShareInitiator = Server::get(IManager::class)->newShare();
-		$file1UserShareInitiator->setShareType(IShare::TYPE_USER)
-			->setSharedWith('recipient')
-			->setSharedBy('currentUser')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(8);
-
-		$file1UserShareInitiatorExpected = [
-			'id' => 8,
-			'share_type' => IShare::TYPE_USER,
-		];
-
-		$file1UserShareRecipient = Server::get(IManager::class)->newShare();
-		$file1UserShareRecipient->setShareType(IShare::TYPE_USER)
-			->setSharedWith('currentUser')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(15);
-
-		$file1UserShareRecipientExpected = [
-			'id' => 15,
-			'share_type' => IShare::TYPE_USER,
-		];
-
-		$file1UserShareOther = Server::get(IManager::class)->newShare();
-		$file1UserShareOther->setShareType(IShare::TYPE_USER)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(16);
-
-		$file1UserShareOtherExpected = [
-			'id' => 16,
-			'share_type' => IShare::TYPE_USER,
-		];
-
-		$file1GroupShareOwner = Server::get(IManager::class)->newShare();
-		$file1GroupShareOwner->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(23);
-
-		$file1GroupShareOwnerExpected = [
-			'id' => 23,
-			'share_type' => IShare::TYPE_GROUP,
-		];
-
-		$file1GroupShareRecipient = Server::get(IManager::class)->newShare();
-		$file1GroupShareRecipient->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('currentUserGroup')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(42);
-
-		$file1GroupShareRecipientExpected = [
-			'id' => 42,
-			'share_type' => IShare::TYPE_GROUP,
-		];
-
-		$file1GroupShareOther = Server::get(IManager::class)->newShare();
-		$file1GroupShareOther->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(108);
-
-		$file1LinkShareOwner = Server::get(IManager::class)->newShare();
-		$file1LinkShareOwner->setShareType(IShare::TYPE_LINK)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(415);
-
-		$file1LinkShareOwnerExpected = [
-			'id' => 415,
-			'share_type' => IShare::TYPE_LINK,
-		];
-
-		$file1EmailShareOwner = Server::get(IManager::class)->newShare();
-		$file1EmailShareOwner->setShareType(IShare::TYPE_EMAIL)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(416);
-
-		$file1EmailShareOwnerExpected = [
-			'id' => 416,
-			'share_type' => IShare::TYPE_EMAIL,
-		];
-
-		$file1CircleShareOwner = Server::get(IManager::class)->newShare();
-		$file1CircleShareOwner->setShareType(IShare::TYPE_CIRCLE)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(423);
-
-		$file1CircleShareOwnerExpected = [
-			'id' => 423,
-			'share_type' => IShare::TYPE_CIRCLE,
-		];
-
-		$file1RoomShareOwner = Server::get(IManager::class)->newShare();
-		$file1RoomShareOwner->setShareType(IShare::TYPE_ROOM)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file1)
-			->setId(442);
-
-		$file1RoomShareOwnerExpected = [
-			'id' => 442,
-			'share_type' => IShare::TYPE_ROOM,
-		];
-
-		$file1RemoteShareOwner = Server::get(IManager::class)->newShare();
-		$file1RemoteShareOwner->setShareType(IShare::TYPE_REMOTE)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setExpirationDate(new \DateTime('2000-01-01T01:02:03'))
-			->setNode($file1)
-			->setId(815);
-
-		$file1RemoteShareOwnerExpected = [
-			'id' => 815,
-			'share_type' => IShare::TYPE_REMOTE,
-		];
-
-		$file1RemoteGroupShareOwner = Server::get(IManager::class)->newShare();
-		$file1RemoteGroupShareOwner->setShareType(IShare::TYPE_REMOTE_GROUP)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setExpirationDate(new \DateTime('2000-01-02T01:02:03'))
-			->setNode($file1)
-			->setId(816);
-
-		$file1RemoteGroupShareOwnerExpected = [
-			'id' => 816,
-			'share_type' => IShare::TYPE_REMOTE_GROUP,
-		];
-
-		$file2UserShareOwner = Server::get(IManager::class)->newShare();
-		$file2UserShareOwner->setShareType(IShare::TYPE_USER)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file2)
-			->setId(823);
-
-		$file2UserShareOwnerExpected = [
-			'id' => 823,
-			'share_type' => IShare::TYPE_USER,
-		];
-
-		$data = [
-			[
-				[
-					'path' => $file1,
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareOwner, $file1UserShareOwner],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected
-				]
-			],
-			[
-				[
-					'path' => $file1,
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareRecipient],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected,
-				]
-			],
-			[
-				[
-					'path' => $file1,
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareRecipient, $file1UserShareInitiator, $file1UserShareOther],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected,
-					$file1UserShareInitiatorExpected,
-					$file1UserShareOtherExpected,
-				]
-			],
-			[
-				[
-					'path' => $file1,
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareRecipient, $file1UserShareInitiator, $file1UserShareOther],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareInitiatorExpected,
-				]
-			],
-			[
-				[
-					'path' => $file1,
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner],
-						IShare::TYPE_GROUP => [$file1GroupShareRecipient],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected,
-					$file1GroupShareRecipientExpected,
-				]
-			],
-			[
-				[
-					'path' => $file1,
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner],
-						IShare::TYPE_GROUP => [$file1GroupShareOwner],
-						IShare::TYPE_LINK => [$file1LinkShareOwner],
-						IShare::TYPE_EMAIL => [$file1EmailShareOwner],
-						IShare::TYPE_CIRCLE => [$file1CircleShareOwner],
-						IShare::TYPE_ROOM => [$file1RoomShareOwner],
-						IShare::TYPE_REMOTE => [$file1RemoteShareOwner],
-						IShare::TYPE_REMOTE_GROUP => [$file1RemoteGroupShareOwner],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected,
-					$file1GroupShareOwnerExpected,
-					$file1LinkShareOwnerExpected,
-					$file1EmailShareOwnerExpected,
-					$file1CircleShareOwnerExpected,
-					$file1RoomShareOwnerExpected,
-				]
-			],
-			[
-				[
-					'path' => $file1,
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner],
-						IShare::TYPE_GROUP => [$file1GroupShareOwner],
-						IShare::TYPE_LINK => [$file1LinkShareOwner],
-						IShare::TYPE_EMAIL => [$file1EmailShareOwner],
-						IShare::TYPE_CIRCLE => [$file1CircleShareOwner],
-						IShare::TYPE_ROOM => [$file1RoomShareOwner],
-						IShare::TYPE_REMOTE => [$file1RemoteShareOwner],
-						IShare::TYPE_REMOTE_GROUP => [$file1RemoteGroupShareOwner],
-					],
-				],
-				[
-					IShare::TYPE_REMOTE => true,
-					IShare::TYPE_REMOTE_GROUP => true,
-				],
-				[
-					$file1UserShareOwnerExpected,
-					$file1GroupShareOwnerExpected,
-					$file1LinkShareOwnerExpected,
-					$file1EmailShareOwnerExpected,
-					$file1CircleShareOwnerExpected,
-					$file1RoomShareOwnerExpected,
-					$file1RemoteShareOwnerExpected,
-					$file1RemoteGroupShareOwnerExpected,
-				]
-			],
-			[
-				[
-					'path' => $folder,
-					'subfiles' => 'true',
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner],
-					],
-					'file2' => [
-						IShare::TYPE_USER => [$file2UserShareOwner],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected,
-					$file2UserShareOwnerExpected,
-				]
-			],
-			[
-				[
-					'path' => $folder,
-					'subfiles' => 'true',
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareOwner, $file1UserShareOwner],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected,
-				]
-			],
-			[
-				[
-					'path' => $folder,
-					'subfiles' => 'true',
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareRecipient],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected
-				]
-			],
-			[
-				[
-					'path' => $folder,
-					'subfiles' => 'true',
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareRecipient, $file1UserShareInitiator, $file1UserShareOther],
-					],
-					'file2' => [
-						IShare::TYPE_USER => [$file2UserShareOwner],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareInitiatorExpected,
-					$file1UserShareOtherExpected,
-					$file2UserShareOwnerExpected,
-				]
-			],
-			// This might not happen in a real environment, as the combination
-			// of shares does not seem to be possible on a folder without
-			// resharing rights; if the folder has resharing rights then the
-			// share with others would be included too in the results.
-			[
-				[
-					'path' => $folder,
-					'subfiles' => 'true',
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareRecipient, $file1UserShareInitiator, $file1UserShareOther],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareInitiatorExpected,
-				]
-			],
-			[
-				[
-					'path' => $folder,
-					'subfiles' => 'true',
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner],
-						IShare::TYPE_GROUP => [$file1GroupShareRecipient],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected,
-					$file1GroupShareRecipientExpected,
-				]
-			],
-			[
-				[
-					'path' => $folder,
-					'subfiles' => 'true',
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner],
-						IShare::TYPE_GROUP => [$file1GroupShareOwner],
-						IShare::TYPE_LINK => [$file1LinkShareOwner],
-						IShare::TYPE_EMAIL => [$file1EmailShareOwner],
-						IShare::TYPE_CIRCLE => [$file1CircleShareOwner],
-						IShare::TYPE_ROOM => [$file1RoomShareOwner],
-						IShare::TYPE_REMOTE => [$file1RemoteShareOwner],
-						IShare::TYPE_REMOTE_GROUP => [$file1RemoteGroupShareOwner],
-					],
-				],
-				[
-				],
-				[
-					$file1UserShareOwnerExpected,
-					$file1GroupShareOwnerExpected,
-					$file1LinkShareOwnerExpected,
-					$file1EmailShareOwnerExpected,
-					$file1CircleShareOwnerExpected,
-					$file1RoomShareOwnerExpected,
-				]
-			],
-			[
-				[
-					'path' => $folder,
-					'subfiles' => 'true',
-				],
-				[
-					'file1' => [
-						IShare::TYPE_USER => [$file1UserShareOwner],
-						IShare::TYPE_GROUP => [$file1GroupShareOwner],
-						IShare::TYPE_LINK => [$file1LinkShareOwner],
-						IShare::TYPE_EMAIL => [$file1EmailShareOwner],
-						IShare::TYPE_CIRCLE => [$file1CircleShareOwner],
-						IShare::TYPE_ROOM => [$file1RoomShareOwner],
-						IShare::TYPE_REMOTE => [$file1RemoteShareOwner],
-						IShare::TYPE_REMOTE_GROUP => [$file1RemoteGroupShareOwner],
-					],
-				],
-				[
-					IShare::TYPE_REMOTE => true,
-					IShare::TYPE_REMOTE_GROUP => true,
-				],
-				[
-					$file1UserShareOwnerExpected,
-					$file1GroupShareOwnerExpected,
-					$file1LinkShareOwnerExpected,
-					$file1EmailShareOwnerExpected,
-					$file1CircleShareOwnerExpected,
-					$file1RoomShareOwnerExpected,
-					$file1RemoteShareOwnerExpected,
-					$file1RemoteGroupShareOwnerExpected,
-				]
-			],
-		];
-
-		return $data;
-	}
-
-	/**
-	 * @dataProvider dataGetShares
-	 */
-	public function testGetShares(array $getSharesParameters, array $shares, array $extraShareTypes, array $expected): void {
-		/** @var ShareAPIController&MockObject $ocs */
-		$ocs = $this->getMockBuilder(ShareAPIController::class)
-			->setConstructorArgs([
-				$this->appName,
-				$this->request,
-				$this->shareManager,
-				$this->groupManager,
-				$this->userManager,
-				$this->rootFolder,
-				$this->urlGenerator,
-				$this->l,
-				$this->config,
-				$this->appManager,
-				$this->serverContainer,
-				$this->userStatusManager,
-				$this->previewManager,
-				$this->dateTimeZone,
-				$this->logger,
-				$this->factory,
-				$this->mailer,
-				$this->tagManager,
-				$this->currentUser,
-			])
-			->onlyMethods(['formatShare'])
-			->getMock();
-
-		$ocs->method('formatShare')
-			->willReturnCallback(
-				function ($share) {
-					return [
-						'id' => $share->getId(),
-						'share_type' => $share->getShareType()
-					];
-				}
-			);
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$userFolder->method('get')
-			->with('path')
-			->willReturn($getSharesParameters['path']);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$this->shareManager
-			->method('getSharesBy')
-			->willReturnCallback(
-				function ($user, $shareType, $node) use ($shares) {
-					if (!isset($shares[$node->getName()]) || !isset($shares[$node->getName()][$shareType])) {
-						return [];
-					}
-					return $shares[$node->getName()][$shareType];
-				}
-			);
-
-		$this->shareManager
-			->method('outgoingServer2ServerSharesAllowed')
-			->willReturn($extraShareTypes[ISHARE::TYPE_REMOTE] ?? false);
-
-		$this->shareManager
-			->method('outgoingServer2ServerGroupSharesAllowed')
-			->willReturn($extraShareTypes[ISHARE::TYPE_REMOTE_GROUP] ?? false);
-
-		$this->groupManager
-			->method('isInGroup')
-			->willReturnCallback(
-				function ($user, $group) {
-					return $group === 'currentUserGroup';
-				}
-			);
-
-		$result = $ocs->getShares(
-			$getSharesParameters['sharedWithMe'] ?? 'false',
-			$getSharesParameters['reshares'] ?? 'false',
-			$getSharesParameters['subfiles'] ?? 'false',
-			'path'
-		);
-
-		$this->assertEquals($expected, $result->getData());
-	}
-
-	public function testCanAccessShare(): void {
-		$share = $this->getMockBuilder(IShare::class)->getMock();
-		$share->method('getShareOwner')->willReturn($this->currentUser);
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-
-		$share = $this->getMockBuilder(IShare::class)->getMock();
-		$share->method('getSharedBy')->willReturn($this->currentUser);
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-
-		$share = $this->getMockBuilder(IShare::class)->getMock();
-		$share->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$share->method('getSharedWith')->willReturn($this->currentUser);
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-
-		$file = $this->getMockBuilder(File::class)->getMock();
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getFirstNodeById')
-			->with($share->getNodeId())
-			->willReturn($file);
-		$userFolder->method('getById')
-			->with($share->getNodeId())
-			->willReturn([$file]);
-
-		$file->method('getPermissions')
-			->will($this->onConsecutiveCalls(Constants::PERMISSION_SHARE, Constants::PERMISSION_READ));
-
-		// getPermissions -> share
-		$share = $this->getMockBuilder(IShare::class)->getMock();
-		$share->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$share->method('getSharedWith')->willReturn($this->getMockBuilder(IUser::class)->getMock());
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-
-		// getPermissions -> read
-		$share = $this->getMockBuilder(IShare::class)->getMock();
-		$share->method('getShareType')->willReturn(IShare::TYPE_USER);
-		$share->method('getSharedWith')->willReturn($this->getMockBuilder(IUser::class)->getMock());
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-
-		$share = $this->getMockBuilder(IShare::class)->getMock();
-		$share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
-		$share->method('getSharedWith')->willReturn('group');
-
-		$user = $this->createMock(IUser::class);
-		$this->userManager->method('get')
-			->with($this->currentUser)
-			->willReturn($user);
-
-		$group = $this->getMockBuilder(IGroup::class)->getMock();
-		$group->method('inGroup')->with($user)->willReturn(true);
-		$group2 = $this->getMockBuilder(IGroup::class)->getMock();
-		$group2->method('inGroup')->with($user)->willReturn(false);
-
-		$this->groupManager->method('get')->willReturnMap([
-			['group', $group],
-			['group2', $group2],
-			['groupnull', null],
-		]);
-		$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
-		$share->method('getSharedWith')->willReturn('group2');
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-
-		// null group
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
-		$share->method('getSharedWith')->willReturn('groupnull');
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
-		$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-	}
-
-	public function dataCanAccessRoomShare() {
-		$result = [];
-
-		$share = $this->createMock(IShare::class);
-		$share->method('getShareType')->willReturn(IShare::TYPE_ROOM);
-		$share->method('getSharedWith')->willReturn('recipientRoom');
-
-		$result[] = [
-			false, $share, false, false
-		];
-
-		$result[] = [
-			false, $share, false, true
-		];
-
-		$result[] = [
-			true, $share, true, true
-		];
-
-		$result[] = [
-			false, $share, true, false
-		];
-
-		return $result;
-	}
-
-	/**
-	 * @dataProvider dataCanAccessRoomShare
-	 *
-	 * @param bool $expects
-	 * @param IShare $share
-	 * @param bool helperAvailable
-	 * @param bool canAccessShareByHelper
-	 */
-	public function testCanAccessRoomShare(bool $expected, IShare $share, bool $helperAvailable, bool $canAccessShareByHelper): void {
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with($share->getNodeId())
-			->willReturn([$share->getNode()]);
-
-		if (!$helperAvailable) {
-			$this->appManager->method('isEnabledForUser')
-				->with('spreed')
-				->willReturn(false);
-		} else {
-			$this->appManager->method('isEnabledForUser')
-				->with('spreed')
-				->willReturn(true);
-
-			// This is not possible anymore with PHPUnit 10+
-			// as `setMethods` was removed and now real reflection is used, thus the class needs to exist.
-			// $helper = $this->getMockBuilder('\OCA\Talk\Share\Helper\ShareAPIController')
-			$helper = $this->getMockBuilder(\stdClass::class)
-				->addMethods(['canAccessShare'])
-				->getMock();
-			$helper->method('canAccessShare')
-				->with($share, $this->currentUser)
-				->willReturn($canAccessShareByHelper);
-
-			$this->serverContainer->method('get')
-				->with('\OCA\Talk\Share\Helper\ShareAPIController')
-				->willReturn($helper);
-		}
-
-		$this->assertEquals($expected, $this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
-	}
-
-
-	public function testCreateShareNoPath(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Please specify a file or folder path');
-
-		$this->ocs->createShare();
-	}
-
-
-	public function testCreateShareInvalidPath(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Wrong path, file/folder does not exist');
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$this->rootFolder->expects($this->once())
-			->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('invalid-path')
-			->will($this->throwException(new NotFoundException()));
-
-		$this->ocs->createShare('invalid-path');
-	}
-
-	public function testCreateShareInvalidShareType(): void {
-		$this->expectException(OCSBadRequestException::class);
-		$this->expectExceptionMessage('Unknown share type');
-
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		[$userFolder, $file] = $this->getNonSharedUserFile();
-		$this->rootFolder->expects($this->atLeastOnce())
-			->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->atLeastOnce())
-			->method('get')
-			->with('valid-path')
-			->willReturn($file);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$file->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->ocs->createShare('valid-path', 31);
-	}
-
-	public function testCreateShareUserNoShareWith(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Please specify a valid account to share with');
-
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		[$userFolder, $path] = $this->getNonSharedUserFile();
-		$this->rootFolder->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_USER);
-	}
-
-
-	public function testCreateShareUserNoValidShareWith(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Please specify a valid account to share with');
-
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		[$userFolder, $path] = $this->getNonSharedUserFile();
-		$this->rootFolder->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-		$this->userManager->method('userExists')
-			->with('invalidUser')
-			->willReturn(false);
-
-		$this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_USER, 'invalidUser');
-	}
-
-	public function testCreateShareUser(): void {
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		/** @var ShareAPIController $ocs */
-		$ocs = $this->getMockBuilder(ShareAPIController::class)
-			->setConstructorArgs([
-				$this->appName,
-				$this->request,
-				$this->shareManager,
-				$this->groupManager,
-				$this->userManager,
-				$this->rootFolder,
-				$this->urlGenerator,
-				$this->l,
-				$this->config,
-				$this->appManager,
-				$this->serverContainer,
-				$this->userStatusManager,
-				$this->previewManager,
-				$this->dateTimeZone,
-				$this->logger,
-				$this->factory,
-				$this->mailer,
-				$this->tagManager,
-				$this->currentUser,
-			])->onlyMethods(['formatShare'])
-			->getMock();
-
-		[$userFolder, $path] = $this->getNonSharedUserFile();
-		$this->rootFolder->expects($this->exactly(2))
-			->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$this->userManager->method('userExists')->with('validUser')->willReturn(true);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('createShare')
-			->with($this->callback(function (IShare $share) use ($path) {
-				return $share->getNode() === $path &&
-					$share->getPermissions() === (
-						Constants::PERMISSION_ALL &
-						~Constants::PERMISSION_DELETE &
-						~Constants::PERMISSION_CREATE
-					) &&
-					$share->getShareType() === IShare::TYPE_USER &&
-					$share->getSharedWith() === 'validUser' &&
-					$share->getSharedBy() === 'currentUser';
-			}))
-			->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_USER, 'validUser');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-
-	public function testCreateShareGroupNoValidShareWith(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Please specify a valid group');
-
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-		$this->shareManager->method('createShare')->willReturnArgument(0);
-		$this->shareManager->method('allowGroupSharing')->willReturn(true);
-
-		[$userFolder, $path] = $this->getNonSharedUserFile();
-		$this->rootFolder->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_GROUP, 'invalidGroup');
-	}
-
-	public function testCreateShareGroup(): void {
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		/** @var ShareAPIController&MockObject $ocs */
-		$ocs = $this->getMockBuilder(ShareAPIController::class)
-			->setConstructorArgs([
-				$this->appName,
-				$this->request,
-				$this->shareManager,
-				$this->groupManager,
-				$this->userManager,
-				$this->rootFolder,
-				$this->urlGenerator,
-				$this->l,
-				$this->config,
-				$this->appManager,
-				$this->serverContainer,
-				$this->userStatusManager,
-				$this->previewManager,
-				$this->dateTimeZone,
-				$this->logger,
-				$this->factory,
-				$this->mailer,
-				$this->tagManager,
-				$this->currentUser,
-			])->onlyMethods(['formatShare'])
-			->getMock();
-
-		$this->request
-			->method('getParam')
-			->willReturnMap([
-				['path', null, 'valid-path'],
-				['permissions', null, Constants::PERMISSION_ALL],
-				['shareType', '-1', IShare::TYPE_GROUP],
-				['shareWith', null, 'validGroup'],
-			]);
-
-		[$userFolder, $path] = $this->getNonSharedUserFolder();
-		$this->rootFolder->expects($this->exactly(2))
-			->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$this->groupManager->method('groupExists')->with('validGroup')->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('allowGroupSharing')
-			->willReturn(true);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('createShare')
-			->with($this->callback(function (IShare $share) use ($path) {
-				return $share->getNode() === $path &&
-				$share->getPermissions() === Constants::PERMISSION_ALL &&
-				$share->getShareType() === IShare::TYPE_GROUP &&
-				$share->getSharedWith() === 'validGroup' &&
-				$share->getSharedBy() === 'currentUser';
-			}))
-			->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_GROUP, 'validGroup');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-
-	public function testCreateShareGroupNotAllowed(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Group sharing is disabled by the administrator');
-
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		[$userFolder, $path] = $this->getNonSharedUserFolder();
-		$this->rootFolder->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$this->groupManager->method('groupExists')->with('validGroup')->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('allowGroupSharing')
-			->willReturn(false);
-
-		$this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_GROUP, 'invalidGroup');
-	}
-
-
-	public function testCreateShareLinkNoLinksAllowed(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Public link sharing is disabled by the administrator');
-
-		$this->request
-			->method('getParam')
-			->willReturnMap([
-				['path', null, 'valid-path'],
-				['shareType', '-1', IShare::TYPE_LINK],
-			]);
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(42);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$path->method('getStorage')->willReturn($storage);
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(false);
-
-		$this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK);
-	}
-
-
-	public function testCreateShareLinkNoPublicUpload(): void {
-		$this->expectException(OCSForbiddenException::class);
-		$this->expectExceptionMessage('Public upload disabled by the administrator');
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(42);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$path->method('getStorage')->willReturn($storage);
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
-
-		$this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true');
-	}
-
-
-	public function testCreateShareLinkPublicUploadFile(): void {
-		$this->expectException(OCSBadRequestException::class);
-		$this->expectExceptionMessage('Public upload is only possible for publicly shared folders');
-
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(42);
-		$file->method('getStorage')->willReturn($storage);
+    public function createShare($id, $shareType, $sharedWith, $sharedBy, $shareOwner, $path, $permissions,
+        $shareTime, $expiration, $parent, $target, $mail_send, $note = '', $token = null,
+        $password = null, $label = '', $attributes = null) {
+        $share = $this->getMockBuilder(IShare::class)->getMock();
+        $share->method('getId')->willReturn($id);
+        $share->method('getShareType')->willReturn($shareType);
+        $share->method('getSharedWith')->willReturn($sharedWith);
+        $share->method('getSharedBy')->willReturn($sharedBy);
+        $share->method('getShareOwner')->willReturn($shareOwner);
+        $share->method('getNode')->willReturn($path);
+        $share->method('getPermissions')->willReturn($permissions);
+        $share->method('getNote')->willReturn($note);
+        $share->method('getLabel')->willReturn($label);
+        $share->method('getAttributes')->willReturn($attributes);
+        $time = new \DateTime();
+        $time->setTimestamp($shareTime);
+        $share->method('getShareTime')->willReturn($time);
+        $share->method('getExpirationDate')->willReturn($expiration);
+        $share->method('getTarget')->willReturn($target);
+        $share->method('getMailSend')->willReturn($mail_send);
+        $share->method('getToken')->willReturn($token);
+        $share->method('getPassword')->willReturn($password);
+
+        if ($shareType === IShare::TYPE_USER ||
+            $shareType === IShare::TYPE_GROUP ||
+            $shareType === IShare::TYPE_LINK) {
+            $share->method('getFullId')->willReturn('ocinternal:' . $id);
+        }
+
+        return $share;
+    }
+
+    public function dataGetShare() {
+        $data = [];
+
+        $cache = $this->getMockBuilder('OC\Files\Cache\Cache')
+            ->disableOriginalConstructor()
+            ->getMock();
+        $cache->method('getNumericStorageId')->willReturn(101);
+
+        $storage = $this->getMockBuilder(IStorage::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $storage->method('getId')->willReturn('STORAGE');
+        $storage->method('getCache')->willReturn($cache);
+
+        $parentFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $parentFolder->method('getId')->willReturn(3);
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $mountPoint->method('getMountType')->willReturn('');
+
+        $file = $this->getMockBuilder('OCP\Files\File')->getMock();
+        $file->method('getId')->willReturn(1);
+        $file->method('getPath')->willReturn('file');
+        $file->method('getStorage')->willReturn($storage);
+        $file->method('getParent')->willReturn($parentFolder);
+        $file->method('getSize')->willReturn(123465);
+        $file->method('getMTime')->willReturn(1234567890);
+        $file->method('getMimeType')->willReturn('myMimeType');
+        $file->method('getMountPoint')->willReturn($mountPoint);
+
+        $folder = $this->getMockBuilder(Folder::class)->getMock();
+        $folder->method('getId')->willReturn(2);
+        $folder->method('getPath')->willReturn('folder');
+        $folder->method('getStorage')->willReturn($storage);
+        $folder->method('getParent')->willReturn($parentFolder);
+        $folder->method('getSize')->willReturn(123465);
+        $folder->method('getMTime')->willReturn(1234567890);
+        $folder->method('getMimeType')->willReturn('myFolderMimeType');
+        $folder->method('getMountPoint')->willReturn($mountPoint);
+
+        [$shareAttributes, $shareAttributesReturnJson] = $this->mockShareAttributes();
+
+        // File shared with user
+        $share = $this->createShare(
+            100,
+            IShare::TYPE_USER,
+            'userId',
+            'initiatorId',
+            'ownerId',
+            $file,
+            4,
+            5,
+            null,
+            6,
+            'target',
+            0,
+            'personal note',
+            $shareAttributes,
+        );
+        $expected = [
+            'id' => 100,
+            'share_type' => IShare::TYPE_USER,
+            'share_with' => 'userId',
+            'share_with_displayname' => 'userDisplay',
+            'share_with_displayname_unique' => 'userId@example.com',
+            'uid_owner' => 'initiatorId',
+            'displayname_owner' => 'initiatorDisplay',
+            'item_type' => 'file',
+            'item_source' => 1,
+            'file_source' => 1,
+            'file_target' => 'target',
+            'file_parent' => 3,
+            'token' => null,
+            'expiration' => null,
+            'permissions' => 4,
+            'attributes' => $shareAttributesReturnJson,
+            'stime' => 5,
+            'parent' => null,
+            'storage_id' => 'STORAGE',
+            'path' => 'file',
+            'storage' => 101,
+            'mail_send' => 0,
+            'uid_file_owner' => 'ownerId',
+            'note' => 'personal note',
+            'label' => '',
+            'displayname_file_owner' => 'ownerDisplay',
+            'mimetype' => 'myMimeType',
+            'has_preview' => false,
+            'hide_download' => 0,
+            'can_edit' => false,
+            'can_delete' => false,
+            'item_size' => 123465,
+            'item_mtime' => 1234567890,
+            'attributes' => null,
+            'item_permissions' => 4,
+            'is-mount-root' => false,
+            'mount-type' => '',
+        ];
+        $data[] = [$share, $expected];
+
+        // Folder shared with group
+        $share = $this->createShare(
+            101,
+            IShare::TYPE_GROUP,
+            'groupId',
+            'initiatorId',
+            'ownerId',
+            $folder,
+            4,
+            5,
+            null,
+            6,
+            'target',
+            0,
+            'personal note',
+            $shareAttributes,
+        );
+        $expected = [
+            'id' => 101,
+            'share_type' => IShare::TYPE_GROUP,
+            'share_with' => 'groupId',
+            'share_with_displayname' => 'groupId',
+            'uid_owner' => 'initiatorId',
+            'displayname_owner' => 'initiatorDisplay',
+            'item_type' => 'folder',
+            'item_source' => 2,
+            'file_source' => 2,
+            'file_target' => 'target',
+            'file_parent' => 3,
+            'token' => null,
+            'expiration' => null,
+            'permissions' => 4,
+            'attributes' => $shareAttributesReturnJson,
+            'stime' => 5,
+            'parent' => null,
+            'storage_id' => 'STORAGE',
+            'path' => 'folder',
+            'storage' => 101,
+            'mail_send' => 0,
+            'uid_file_owner' => 'ownerId',
+            'note' => 'personal note',
+            'label' => '',
+            'displayname_file_owner' => 'ownerDisplay',
+            'mimetype' => 'myFolderMimeType',
+            'has_preview' => false,
+            'hide_download' => 0,
+            'can_edit' => false,
+            'can_delete' => false,
+            'item_size' => 123465,
+            'item_mtime' => 1234567890,
+            'attributes' => null,
+            'item_permissions' => 4,
+            'is-mount-root' => false,
+            'mount-type' => '',
+        ];
+        $data[] = [$share, $expected];
+
+        // File shared by link with Expire
+        $expire = \DateTime::createFromFormat('Y-m-d h:i:s', '2000-01-02 01:02:03');
+        $share = $this->createShare(
+            101,
+            IShare::TYPE_LINK,
+            null,
+            'initiatorId',
+            'ownerId',
+            $folder,
+            4,
+            5,
+            $expire,
+            6,
+            'target',
+            0,
+            'personal note',
+            'token',
+            'password',
+            'first link share'
+        );
+        $expected = [
+            'id' => 101,
+            'share_type' => IShare::TYPE_LINK,
+            'password' => 'password',
+            'share_with' => 'password',
+            'share_with_displayname' => '(Shared link)',
+            'send_password_by_talk' => false,
+            'uid_owner' => 'initiatorId',
+            'displayname_owner' => 'initiatorDisplay',
+            'item_type' => 'folder',
+            'item_source' => 2,
+            'file_source' => 2,
+            'file_target' => 'target',
+            'file_parent' => 3,
+            'token' => 'token',
+            'expiration' => '2000-01-02 00:00:00',
+            'permissions' => 4,
+            'attributes' => null,
+            'stime' => 5,
+            'parent' => null,
+            'storage_id' => 'STORAGE',
+            'path' => 'folder',
+            'storage' => 101,
+            'mail_send' => 0,
+            'url' => 'url',
+            'uid_file_owner' => 'ownerId',
+            'note' => 'personal note',
+            'label' => 'first link share',
+            'displayname_file_owner' => 'ownerDisplay',
+            'mimetype' => 'myFolderMimeType',
+            'has_preview' => false,
+            'hide_download' => 0,
+            'can_edit' => false,
+            'can_delete' => false,
+            'item_size' => 123465,
+            'item_mtime' => 1234567890,
+            'attributes' => null,
+            'item_permissions' => 4,
+            'is-mount-root' => false,
+            'mount-type' => '',
+        ];
+        $data[] = [$share, $expected];
+
+        return $data;
+    }
+
+    /**
+     * @dataProvider dataGetShare
+     */
+    public function testGetShare(IShare $share, array $result): void {
+        /** @var ShareAPIController&MockObject $ocs */
+        $ocs = $this->getMockBuilder(ShareAPIController::class)
+            ->setConstructorArgs([
+                $this->appName,
+                $this->request,
+                $this->shareManager,
+                $this->groupManager,
+                $this->userManager,
+                $this->rootFolder,
+                $this->urlGenerator,
+                $this->l,
+                $this->config,
+                $this->appManager,
+                $this->serverContainer,
+                $this->userStatusManager,
+                $this->previewManager,
+                $this->dateTimeZone,
+                $this->logger,
+                $this->factory,
+                $this->mailer,
+                $this->tagManager,
+                $this->currentUser,
+            ])
+            ->onlyMethods(['canAccessShare'])
+            ->getMock();
+
+        $ocs->expects($this->any())
+            ->method('canAccessShare')
+            ->willReturn(true);
+
+        $this->shareManager
+            ->expects($this->any())
+            ->method('getShareById')
+            ->with($share->getFullId(), 'currentUser')
+            ->willReturn($share);
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $userFolder
+            ->method('getRelativePath')
+            ->willReturnArgument(0);
+
+        $userFolder->method('getById')
+            ->with($share->getNodeId())
+            ->willReturn([$share->getNode()]);
+        $userFolder->method('getFirstNodeById')
+            ->with($share->getNodeId())
+            ->willReturn($share->getNode());
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $this->urlGenerator
+            ->method('linkToRouteAbsolute')
+            ->willReturn('url');
+
+        $initiator = $this->getMockBuilder(IUser::class)->getMock();
+        $initiator->method('getUID')->willReturn('initiatorId');
+        $initiator->method('getDisplayName')->willReturn('initiatorDisplay');
+
+        $owner = $this->getMockBuilder(IUser::class)->getMock();
+        $owner->method('getUID')->willReturn('ownerId');
+        $owner->method('getDisplayName')->willReturn('ownerDisplay');
+
+        $user = $this->getMockBuilder(IUser::class)->getMock();
+        $user->method('getUID')->willReturn('userId');
+        $user->method('getDisplayName')->willReturn('userDisplay');
+        $user->method('getSystemEMailAddress')->willReturn('userId@example.com');
+
+        $group = $this->getMockBuilder(IGroup::class)->getMock();
+        $group->method('getGID')->willReturn('groupId');
+
+        $this->userManager->method('get')->willReturnMap([
+            ['userId', $user],
+            ['initiatorId', $initiator],
+            ['ownerId', $owner],
+        ]);
+        $this->groupManager->method('get')->willReturnMap([
+            ['group', $group],
+        ]);
+        $this->dateTimeZone->method('getTimezone')->willReturn(new \DateTimeZone('UTC'));
+
+        $data = $ocs->getShare($share->getId())->getData()[0];
+        $this->assertEquals($result, $data);
+    }
+
+
+    public function testGetShareInvalidNode(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Wrong share ID, share does not exist');
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setSharedBy('initiator')
+            ->setSharedWith('recipient')
+            ->setShareOwner('owner');
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:42', 'currentUser')
+            ->willReturn($share);
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $this->ocs->getShare(42);
+    }
+
+    public function dataGetShares() {
+        $folder = $this->getMockBuilder(Folder::class)->getMock();
+        $file1 = $this->getMockBuilder(File::class)->getMock();
+        $file1->method('getName')
+            ->willReturn('file1');
+        $file2 = $this->getMockBuilder(File::class)->getMock();
+        $file2->method('getName')
+            ->willReturn('file2');
+
+        $folder->method('getDirectoryListing')
+            ->willReturn([$file1, $file2]);
+
+        $file1UserShareOwner = Server::get(IManager::class)->newShare();
+        $file1UserShareOwner->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(4);
+
+        $file1UserShareOwnerExpected = [
+            'id' => 4,
+            'share_type' => IShare::TYPE_USER,
+        ];
+
+        $file1UserShareInitiator = Server::get(IManager::class)->newShare();
+        $file1UserShareInitiator->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('recipient')
+            ->setSharedBy('currentUser')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(8);
+
+        $file1UserShareInitiatorExpected = [
+            'id' => 8,
+            'share_type' => IShare::TYPE_USER,
+        ];
+
+        $file1UserShareRecipient = Server::get(IManager::class)->newShare();
+        $file1UserShareRecipient->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('currentUser')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(15);
+
+        $file1UserShareRecipientExpected = [
+            'id' => 15,
+            'share_type' => IShare::TYPE_USER,
+        ];
+
+        $file1UserShareOther = Server::get(IManager::class)->newShare();
+        $file1UserShareOther->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(16);
+
+        $file1UserShareOtherExpected = [
+            'id' => 16,
+            'share_type' => IShare::TYPE_USER,
+        ];
+
+        $file1GroupShareOwner = Server::get(IManager::class)->newShare();
+        $file1GroupShareOwner->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(23);
+
+        $file1GroupShareOwnerExpected = [
+            'id' => 23,
+            'share_type' => IShare::TYPE_GROUP,
+        ];
+
+        $file1GroupShareRecipient = Server::get(IManager::class)->newShare();
+        $file1GroupShareRecipient->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('currentUserGroup')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(42);
+
+        $file1GroupShareRecipientExpected = [
+            'id' => 42,
+            'share_type' => IShare::TYPE_GROUP,
+        ];
+
+        $file1GroupShareOther = Server::get(IManager::class)->newShare();
+        $file1GroupShareOther->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(108);
+
+        $file1LinkShareOwner = Server::get(IManager::class)->newShare();
+        $file1LinkShareOwner->setShareType(IShare::TYPE_LINK)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(415);
+
+        $file1LinkShareOwnerExpected = [
+            'id' => 415,
+            'share_type' => IShare::TYPE_LINK,
+        ];
+
+        $file1EmailShareOwner = Server::get(IManager::class)->newShare();
+        $file1EmailShareOwner->setShareType(IShare::TYPE_EMAIL)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(416);
+
+        $file1EmailShareOwnerExpected = [
+            'id' => 416,
+            'share_type' => IShare::TYPE_EMAIL,
+        ];
+
+        $file1CircleShareOwner = Server::get(IManager::class)->newShare();
+        $file1CircleShareOwner->setShareType(IShare::TYPE_CIRCLE)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(423);
+
+        $file1CircleShareOwnerExpected = [
+            'id' => 423,
+            'share_type' => IShare::TYPE_CIRCLE,
+        ];
+
+        $file1RoomShareOwner = Server::get(IManager::class)->newShare();
+        $file1RoomShareOwner->setShareType(IShare::TYPE_ROOM)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file1)
+            ->setId(442);
+
+        $file1RoomShareOwnerExpected = [
+            'id' => 442,
+            'share_type' => IShare::TYPE_ROOM,
+        ];
+
+        $file1RemoteShareOwner = Server::get(IManager::class)->newShare();
+        $file1RemoteShareOwner->setShareType(IShare::TYPE_REMOTE)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setExpirationDate(new \DateTime('2000-01-01T01:02:03'))
+            ->setNode($file1)
+            ->setId(815);
+
+        $file1RemoteShareOwnerExpected = [
+            'id' => 815,
+            'share_type' => IShare::TYPE_REMOTE,
+        ];
+
+        $file1RemoteGroupShareOwner = Server::get(IManager::class)->newShare();
+        $file1RemoteGroupShareOwner->setShareType(IShare::TYPE_REMOTE_GROUP)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setExpirationDate(new \DateTime('2000-01-02T01:02:03'))
+            ->setNode($file1)
+            ->setId(816);
+
+        $file1RemoteGroupShareOwnerExpected = [
+            'id' => 816,
+            'share_type' => IShare::TYPE_REMOTE_GROUP,
+        ];
+
+        $file2UserShareOwner = Server::get(IManager::class)->newShare();
+        $file2UserShareOwner->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file2)
+            ->setId(823);
+
+        $file2UserShareOwnerExpected = [
+            'id' => 823,
+            'share_type' => IShare::TYPE_USER,
+        ];
+
+        $data = [
+            [
+                [
+                    'path' => $file1,
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareOwner, $file1UserShareOwner],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected
+                ]
+            ],
+            [
+                [
+                    'path' => $file1,
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareRecipient],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $file1,
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareRecipient, $file1UserShareInitiator, $file1UserShareOther],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                    $file1UserShareInitiatorExpected,
+                    $file1UserShareOtherExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $file1,
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareRecipient, $file1UserShareInitiator, $file1UserShareOther],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareInitiatorExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $file1,
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner],
+                        IShare::TYPE_GROUP => [$file1GroupShareRecipient],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                    $file1GroupShareRecipientExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $file1,
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner],
+                        IShare::TYPE_GROUP => [$file1GroupShareOwner],
+                        IShare::TYPE_LINK => [$file1LinkShareOwner],
+                        IShare::TYPE_EMAIL => [$file1EmailShareOwner],
+                        IShare::TYPE_CIRCLE => [$file1CircleShareOwner],
+                        IShare::TYPE_ROOM => [$file1RoomShareOwner],
+                        IShare::TYPE_REMOTE => [$file1RemoteShareOwner],
+                        IShare::TYPE_REMOTE_GROUP => [$file1RemoteGroupShareOwner],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                    $file1GroupShareOwnerExpected,
+                    $file1LinkShareOwnerExpected,
+                    $file1EmailShareOwnerExpected,
+                    $file1CircleShareOwnerExpected,
+                    $file1RoomShareOwnerExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $file1,
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner],
+                        IShare::TYPE_GROUP => [$file1GroupShareOwner],
+                        IShare::TYPE_LINK => [$file1LinkShareOwner],
+                        IShare::TYPE_EMAIL => [$file1EmailShareOwner],
+                        IShare::TYPE_CIRCLE => [$file1CircleShareOwner],
+                        IShare::TYPE_ROOM => [$file1RoomShareOwner],
+                        IShare::TYPE_REMOTE => [$file1RemoteShareOwner],
+                        IShare::TYPE_REMOTE_GROUP => [$file1RemoteGroupShareOwner],
+                    ],
+                ],
+                [
+                    IShare::TYPE_REMOTE => true,
+                    IShare::TYPE_REMOTE_GROUP => true,
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                    $file1GroupShareOwnerExpected,
+                    $file1LinkShareOwnerExpected,
+                    $file1EmailShareOwnerExpected,
+                    $file1CircleShareOwnerExpected,
+                    $file1RoomShareOwnerExpected,
+                    $file1RemoteShareOwnerExpected,
+                    $file1RemoteGroupShareOwnerExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $folder,
+                    'subfiles' => 'true',
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner],
+                    ],
+                    'file2' => [
+                        IShare::TYPE_USER => [$file2UserShareOwner],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                    $file2UserShareOwnerExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $folder,
+                    'subfiles' => 'true',
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareOwner, $file1UserShareOwner],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $folder,
+                    'subfiles' => 'true',
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner, $file1UserShareRecipient],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected
+                ]
+            ],
+            [
+                [
+                    'path' => $folder,
+                    'subfiles' => 'true',
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareRecipient, $file1UserShareInitiator, $file1UserShareOther],
+                    ],
+                    'file2' => [
+                        IShare::TYPE_USER => [$file2UserShareOwner],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareInitiatorExpected,
+                    $file1UserShareOtherExpected,
+                    $file2UserShareOwnerExpected,
+                ]
+            ],
+            // This might not happen in a real environment, as the combination
+            // of shares does not seem to be possible on a folder without
+            // resharing rights; if the folder has resharing rights then the
+            // share with others would be included too in the results.
+            [
+                [
+                    'path' => $folder,
+                    'subfiles' => 'true',
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareRecipient, $file1UserShareInitiator, $file1UserShareOther],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareInitiatorExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $folder,
+                    'subfiles' => 'true',
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner],
+                        IShare::TYPE_GROUP => [$file1GroupShareRecipient],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                    $file1GroupShareRecipientExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $folder,
+                    'subfiles' => 'true',
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner],
+                        IShare::TYPE_GROUP => [$file1GroupShareOwner],
+                        IShare::TYPE_LINK => [$file1LinkShareOwner],
+                        IShare::TYPE_EMAIL => [$file1EmailShareOwner],
+                        IShare::TYPE_CIRCLE => [$file1CircleShareOwner],
+                        IShare::TYPE_ROOM => [$file1RoomShareOwner],
+                        IShare::TYPE_REMOTE => [$file1RemoteShareOwner],
+                        IShare::TYPE_REMOTE_GROUP => [$file1RemoteGroupShareOwner],
+                    ],
+                ],
+                [
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                    $file1GroupShareOwnerExpected,
+                    $file1LinkShareOwnerExpected,
+                    $file1EmailShareOwnerExpected,
+                    $file1CircleShareOwnerExpected,
+                    $file1RoomShareOwnerExpected,
+                ]
+            ],
+            [
+                [
+                    'path' => $folder,
+                    'subfiles' => 'true',
+                ],
+                [
+                    'file1' => [
+                        IShare::TYPE_USER => [$file1UserShareOwner],
+                        IShare::TYPE_GROUP => [$file1GroupShareOwner],
+                        IShare::TYPE_LINK => [$file1LinkShareOwner],
+                        IShare::TYPE_EMAIL => [$file1EmailShareOwner],
+                        IShare::TYPE_CIRCLE => [$file1CircleShareOwner],
+                        IShare::TYPE_ROOM => [$file1RoomShareOwner],
+                        IShare::TYPE_REMOTE => [$file1RemoteShareOwner],
+                        IShare::TYPE_REMOTE_GROUP => [$file1RemoteGroupShareOwner],
+                    ],
+                ],
+                [
+                    IShare::TYPE_REMOTE => true,
+                    IShare::TYPE_REMOTE_GROUP => true,
+                ],
+                [
+                    $file1UserShareOwnerExpected,
+                    $file1GroupShareOwnerExpected,
+                    $file1LinkShareOwnerExpected,
+                    $file1EmailShareOwnerExpected,
+                    $file1CircleShareOwnerExpected,
+                    $file1RoomShareOwnerExpected,
+                    $file1RemoteShareOwnerExpected,
+                    $file1RemoteGroupShareOwnerExpected,
+                ]
+            ],
+        ];
+
+        return $data;
+    }
+
+    /**
+     * @dataProvider dataGetShares
+     */
+    public function testGetShares(array $getSharesParameters, array $shares, array $extraShareTypes, array $expected): void {
+        /** @var ShareAPIController&MockObject $ocs */
+        $ocs = $this->getMockBuilder(ShareAPIController::class)
+            ->setConstructorArgs([
+                $this->appName,
+                $this->request,
+                $this->shareManager,
+                $this->groupManager,
+                $this->userManager,
+                $this->rootFolder,
+                $this->urlGenerator,
+                $this->l,
+                $this->config,
+                $this->appManager,
+                $this->serverContainer,
+                $this->userStatusManager,
+                $this->previewManager,
+                $this->dateTimeZone,
+                $this->logger,
+                $this->factory,
+                $this->mailer,
+                $this->tagManager,
+                $this->currentUser,
+            ])
+            ->onlyMethods(['formatShare'])
+            ->getMock();
+
+        $ocs->method('formatShare')
+            ->willReturnCallback(
+                function ($share) {
+                    return [
+                        'id' => $share->getId(),
+                        'share_type' => $share->getShareType()
+                    ];
+                }
+            );
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $userFolder->method('get')
+            ->with('path')
+            ->willReturn($getSharesParameters['path']);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $this->shareManager
+            ->method('getSharesBy')
+            ->willReturnCallback(
+                function ($user, $shareType, $node) use ($shares) {
+                    if (!isset($shares[$node->getName()]) || !isset($shares[$node->getName()][$shareType])) {
+                        return [];
+                    }
+                    return $shares[$node->getName()][$shareType];
+                }
+            );
+
+        $this->shareManager
+            ->method('outgoingServer2ServerSharesAllowed')
+            ->willReturn($extraShareTypes[ISHARE::TYPE_REMOTE] ?? false);
+
+        $this->shareManager
+            ->method('outgoingServer2ServerGroupSharesAllowed')
+            ->willReturn($extraShareTypes[ISHARE::TYPE_REMOTE_GROUP] ?? false);
+
+        $this->groupManager
+            ->method('isInGroup')
+            ->willReturnCallback(
+                function ($user, $group) {
+                    return $group === 'currentUserGroup';
+                }
+            );
+
+        $result = $ocs->getShares(
+            $getSharesParameters['sharedWithMe'] ?? 'false',
+            $getSharesParameters['reshares'] ?? 'false',
+            $getSharesParameters['subfiles'] ?? 'false',
+            'path'
+        );
+
+        $this->assertEquals($expected, $result->getData());
+    }
+
+    public function testCanAccessShare(): void {
+        $share = $this->getMockBuilder(IShare::class)->getMock();
+        $share->method('getShareOwner')->willReturn($this->currentUser);
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+
+        $share = $this->getMockBuilder(IShare::class)->getMock();
+        $share->method('getSharedBy')->willReturn($this->currentUser);
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+
+        $share = $this->getMockBuilder(IShare::class)->getMock();
+        $share->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $share->method('getSharedWith')->willReturn($this->currentUser);
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+
+        $file = $this->getMockBuilder(File::class)->getMock();
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getFirstNodeById')
+            ->with($share->getNodeId())
+            ->willReturn($file);
+        $userFolder->method('getById')
+            ->with($share->getNodeId())
+            ->willReturn([$file]);
+
+        $file->method('getPermissions')
+            ->will($this->onConsecutiveCalls(Constants::PERMISSION_SHARE, Constants::PERMISSION_READ));
+
+        // getPermissions -> share
+        $share = $this->getMockBuilder(IShare::class)->getMock();
+        $share->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $share->method('getSharedWith')->willReturn($this->getMockBuilder(IUser::class)->getMock());
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+
+        // getPermissions -> read
+        $share = $this->getMockBuilder(IShare::class)->getMock();
+        $share->method('getShareType')->willReturn(IShare::TYPE_USER);
+        $share->method('getSharedWith')->willReturn($this->getMockBuilder(IUser::class)->getMock());
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+
+        $share = $this->getMockBuilder(IShare::class)->getMock();
+        $share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
+        $share->method('getSharedWith')->willReturn('group');
+
+        $user = $this->createMock(IUser::class);
+        $this->userManager->method('get')
+            ->with($this->currentUser)
+            ->willReturn($user);
+
+        $group = $this->getMockBuilder(IGroup::class)->getMock();
+        $group->method('inGroup')->with($user)->willReturn(true);
+        $group2 = $this->getMockBuilder(IGroup::class)->getMock();
+        $group2->method('inGroup')->with($user)->willReturn(false);
+
+        $this->groupManager->method('get')->willReturnMap([
+            ['group', $group],
+            ['group2', $group2],
+            ['groupnull', null],
+        ]);
+        $this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
+        $share->method('getSharedWith')->willReturn('group2');
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+
+        // null group
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
+        $share->method('getSharedWith')->willReturn('groupnull');
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_LINK);
+        $this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+    }
+
+    public function dataCanAccessRoomShare() {
+        $result = [];
+
+        $share = $this->createMock(IShare::class);
+        $share->method('getShareType')->willReturn(IShare::TYPE_ROOM);
+        $share->method('getSharedWith')->willReturn('recipientRoom');
+
+        $result[] = [
+            false, $share, false, false
+        ];
+
+        $result[] = [
+            false, $share, false, true
+        ];
+
+        $result[] = [
+            true, $share, true, true
+        ];
+
+        $result[] = [
+            false, $share, true, false
+        ];
+
+        return $result;
+    }
+
+    /**
+     * @dataProvider dataCanAccessRoomShare
+     *
+     * @param bool $expects
+     * @param IShare $share
+     * @param bool helperAvailable
+     * @param bool canAccessShareByHelper
+     */
+    public function testCanAccessRoomShare(bool $expected, IShare $share, bool $helperAvailable, bool $canAccessShareByHelper): void {
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with($share->getNodeId())
+            ->willReturn([$share->getNode()]);
+
+        if (!$helperAvailable) {
+            $this->appManager->method('isEnabledForUser')
+                ->with('spreed')
+                ->willReturn(false);
+        } else {
+            $this->appManager->method('isEnabledForUser')
+                ->with('spreed')
+                ->willReturn(true);
+
+            // This is not possible anymore with PHPUnit 10+
+            // as `setMethods` was removed and now real reflection is used, thus the class needs to exist.
+            // $helper = $this->getMockBuilder('\OCA\Talk\Share\Helper\ShareAPIController')
+            $helper = $this->getMockBuilder(\stdClass::class)
+                ->addMethods(['canAccessShare'])
+                ->getMock();
+            $helper->method('canAccessShare')
+                ->with($share, $this->currentUser)
+                ->willReturn($canAccessShareByHelper);
+
+            $this->serverContainer->method('get')
+                ->with('\OCA\Talk\Share\Helper\ShareAPIController')
+                ->willReturn($helper);
+        }
+
+        $this->assertEquals($expected, $this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
+    }
+
+
+    public function testCreateShareNoPath(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Please specify a file or folder path');
+
+        $this->ocs->createShare();
+    }
+
+
+    public function testCreateShareInvalidPath(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Wrong path, file/folder does not exist');
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $this->rootFolder->expects($this->once())
+            ->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('invalid-path')
+            ->will($this->throwException(new NotFoundException()));
+
+        $this->ocs->createShare('invalid-path');
+    }
+
+    public function testCreateShareInvalidShareType(): void {
+        $this->expectException(OCSBadRequestException::class);
+        $this->expectExceptionMessage('Unknown share type');
+
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        [$userFolder, $file] = $this->getNonSharedUserFile();
+        $this->rootFolder->expects($this->atLeastOnce())
+            ->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->atLeastOnce())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($file);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $file->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->ocs->createShare('valid-path', 31);
+    }
+
+    public function testCreateShareUserNoShareWith(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Please specify a valid account to share with');
+
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        [$userFolder, $path] = $this->getNonSharedUserFile();
+        $this->rootFolder->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_USER);
+    }
+
+
+    public function testCreateShareUserNoValidShareWith(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Please specify a valid account to share with');
+
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        [$userFolder, $path] = $this->getNonSharedUserFile();
+        $this->rootFolder->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+        $this->userManager->method('userExists')
+            ->with('invalidUser')
+            ->willReturn(false);
+
+        $this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_USER, 'invalidUser');
+    }
+
+    public function testCreateShareUser(): void {
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        /** @var ShareAPIController $ocs */
+        $ocs = $this->getMockBuilder(ShareAPIController::class)
+            ->setConstructorArgs([
+                $this->appName,
+                $this->request,
+                $this->shareManager,
+                $this->groupManager,
+                $this->userManager,
+                $this->rootFolder,
+                $this->urlGenerator,
+                $this->l,
+                $this->config,
+                $this->appManager,
+                $this->serverContainer,
+                $this->userStatusManager,
+                $this->previewManager,
+                $this->dateTimeZone,
+                $this->logger,
+                $this->factory,
+                $this->mailer,
+                $this->tagManager,
+                $this->currentUser,
+            ])->onlyMethods(['formatShare'])
+            ->getMock();
+
+        [$userFolder, $path] = $this->getNonSharedUserFile();
+        $this->rootFolder->expects($this->exactly(2))
+            ->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $this->userManager->method('userExists')->with('validUser')->willReturn(true);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('createShare')
+            ->with($this->callback(function (IShare $share) use ($path) {
+                return $share->getNode() === $path &&
+                    $share->getPermissions() === (
+                        Constants::PERMISSION_ALL &
+                        ~Constants::PERMISSION_DELETE &
+                        ~Constants::PERMISSION_CREATE
+                    ) &&
+                    $share->getShareType() === IShare::TYPE_USER &&
+                    $share->getSharedWith() === 'validUser' &&
+                    $share->getSharedBy() === 'currentUser';
+            }))
+            ->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_USER, 'validUser');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+
+    public function testCreateShareGroupNoValidShareWith(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Please specify a valid group');
+
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+        $this->shareManager->method('createShare')->willReturnArgument(0);
+        $this->shareManager->method('allowGroupSharing')->willReturn(true);
+
+        [$userFolder, $path] = $this->getNonSharedUserFile();
+        $this->rootFolder->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_GROUP, 'invalidGroup');
+    }
+
+    public function testCreateShareGroup(): void {
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        /** @var ShareAPIController&MockObject $ocs */
+        $ocs = $this->getMockBuilder(ShareAPIController::class)
+            ->setConstructorArgs([
+                $this->appName,
+                $this->request,
+                $this->shareManager,
+                $this->groupManager,
+                $this->userManager,
+                $this->rootFolder,
+                $this->urlGenerator,
+                $this->l,
+                $this->config,
+                $this->appManager,
+                $this->serverContainer,
+                $this->userStatusManager,
+                $this->previewManager,
+                $this->dateTimeZone,
+                $this->logger,
+                $this->factory,
+                $this->mailer,
+                $this->tagManager,
+                $this->currentUser,
+            ])->onlyMethods(['formatShare'])
+            ->getMock();
+
+        $this->request
+            ->method('getParam')
+            ->willReturnMap([
+                ['path', null, 'valid-path'],
+                ['permissions', null, Constants::PERMISSION_ALL],
+                ['shareType', '-1', IShare::TYPE_GROUP],
+                ['shareWith', null, 'validGroup'],
+            ]);
+
+        [$userFolder, $path] = $this->getNonSharedUserFolder();
+        $this->rootFolder->expects($this->exactly(2))
+            ->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $this->groupManager->method('groupExists')->with('validGroup')->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowGroupSharing')
+            ->willReturn(true);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('createShare')
+            ->with($this->callback(function (IShare $share) use ($path) {
+                return $share->getNode() === $path &&
+                $share->getPermissions() === Constants::PERMISSION_ALL &&
+                $share->getShareType() === IShare::TYPE_GROUP &&
+                $share->getSharedWith() === 'validGroup' &&
+                $share->getSharedBy() === 'currentUser';
+            }))
+            ->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_GROUP, 'validGroup');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+
+    public function testCreateShareGroupNotAllowed(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Group sharing is disabled by the administrator');
+
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        [$userFolder, $path] = $this->getNonSharedUserFolder();
+        $this->rootFolder->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $this->groupManager->method('groupExists')->with('validGroup')->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('allowGroupSharing')
+            ->willReturn(false);
+
+        $this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_GROUP, 'invalidGroup');
+    }
+
+
+    public function testCreateShareLinkNoLinksAllowed(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Public link sharing is disabled by the administrator');
+
+        $this->request
+            ->method('getParam')
+            ->willReturnMap([
+                ['path', null, 'valid-path'],
+                ['shareType', '-1', IShare::TYPE_LINK],
+            ]);
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(42);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $path->method('getStorage')->willReturn($storage);
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($path);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(false);
+
+        $this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK);
+    }
+
+
+    public function testCreateShareLinkNoPublicUpload(): void {
+        $this->expectException(OCSForbiddenException::class);
+        $this->expectExceptionMessage('Public upload disabled by the administrator');
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(42);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $path->method('getStorage')->willReturn($storage);
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($path);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(true);
+
+        $this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true');
+    }
+
+
+    public function testCreateShareLinkPublicUploadFile(): void {
+        $this->expectException(OCSBadRequestException::class);
+        $this->expectExceptionMessage('Public upload is only possible for publicly shared folders');
+
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(42);
+        $file->method('getStorage')->willReturn($storage);
 	
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($file);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true');
-	}
-
-	public function testCreateShareLinkPublicUploadFolder(): void {
-		$ocs = $this->mockFormatShare();
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(1);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$path->method('getStorage')->willReturn($storage);
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('createShare')->with(
-			$this->callback(function (IShare $share) use ($path) {
-				return $share->getNode() === $path &&
-					$share->getShareType() === IShare::TYPE_LINK &&
-					$share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
-					$share->getSharedBy() === 'currentUser' &&
-					$share->getPassword() === null &&
-					$share->getExpirationDate() === null;
-			})
-		)->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true', '', null, '');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testCreateShareLinkPassword(): void {
-		$ocs = $this->mockFormatShare();
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(42);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$path->method('getStorage')->willReturn($storage);
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('createShare')->with(
-			$this->callback(function (IShare $share) use ($path) {
-				return $share->getNode() === $path
-				&& $share->getShareType() === IShare::TYPE_LINK
-				&& $share->getPermissions() === Constants::PERMISSION_READ // publicUpload was set to false
-				&& $share->getSharedBy() === 'currentUser'
-				&& $share->getPassword() === 'password'
-				&& $share->getExpirationDate() === null;
-			})
-		)->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', Constants::PERMISSION_READ, IShare::TYPE_LINK, null, 'false', 'password', null, '');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testCreateShareLinkSendPasswordByTalk(): void {
-		$ocs = $this->mockFormatShare();
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(42);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$path->method('getStorage')->willReturn($storage);
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('createShare')->with(
-			$this->callback(function (IShare $share) use ($path) {
-				return $share->getNode() === $path &&
-				$share->getShareType() === IShare::TYPE_LINK &&
-				$share->getPermissions() === (Constants::PERMISSION_ALL & ~(Constants::PERMISSION_SHARE)) &&
-				$share->getSharedBy() === 'currentUser' &&
-				$share->getPassword() === 'password' &&
-				$share->getSendPasswordByTalk() === true &&
-				$share->getExpirationDate() === null;
-			})
-		)->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true', 'password', 'true', '');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-
-	public function testCreateShareLinkSendPasswordByTalkWithTalkDisabled(): void {
-		$this->expectException(OCSForbiddenException::class);
-		$this->expectExceptionMessage('Sharing valid-path sending the password by Nextcloud Talk failed because Nextcloud Talk is not enabled');
-
-		$ocs = $this->mockFormatShare();
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(42);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$path->method('getStorage')->willReturn($storage);
-		$path->method('getPath')->willReturn('valid-path');
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(false);
-
-		$this->shareManager->expects($this->never())->method('createShare');
-
-		$ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', 'password', 'true', '');
-	}
-
-	public function testCreateShareValidExpireDate(): void {
-		$ocs = $this->mockFormatShare();
-
-		$this->request
-			->method('getParam')
-			->willReturnMap([
-				['path', null, 'valid-path'],
-				['shareType', '-1', IShare::TYPE_LINK],
-				['publicUpload', null, 'false'],
-				['expireDate', '', '2000-01-01'],
-				['password', '', ''],
-			]);
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(42);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$path->method('getStorage')->willReturn($storage);
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('createShare')->with(
-			$this->callback(function (IShare $share) use ($path) {
-				$date = new \DateTime('2000-01-01');
-				$date->setTime(0, 0, 0);
-
-				return $share->getNode() === $path &&
-				$share->getShareType() === IShare::TYPE_LINK &&
-				$share->getPermissions() === Constants::PERMISSION_READ | Constants::PERMISSION_SHARE &&
-				$share->getSharedBy() === 'currentUser' &&
-				$share->getPassword() === null &&
-				$share->getExpirationDate() == $date;
-			})
-		)->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', null, IShare::TYPE_LINK, null, 'false', '', null, '2000-01-01');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-
-	public function testCreateShareInvalidExpireDate(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Invalid date. Format must be YYYY-MM-DD');
-
-		$ocs = $this->mockFormatShare();
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(42);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$path->method('getStorage')->willReturn($storage);
-		$this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
-		$this->rootFolder->method('get')->with('valid-path')->willReturn($path);
-		$this->rootFolder->method('getById')
-			->willReturn([]);
-
-		$this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
-		$this->shareManager->method('shareApiAllowLinks')->willReturn(true);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, 'a1b2d3');
-	}
-
-	public function testCreateShareRemote(): void {
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		/** @var ShareAPIController $ocs */
-		$ocs = $this->getMockBuilder(ShareAPIController::class)
-			->setConstructorArgs([
-				$this->appName,
-				$this->request,
-				$this->shareManager,
-				$this->groupManager,
-				$this->userManager,
-				$this->rootFolder,
-				$this->urlGenerator,
-				$this->l,
-				$this->config,
-				$this->appManager,
-				$this->serverContainer,
-				$this->userStatusManager,
-				$this->previewManager,
-				$this->dateTimeZone,
-				$this->logger,
-				$this->factory,
-				$this->mailer,
-				$this->tagManager,
-				$this->currentUser,
-			])->onlyMethods(['formatShare'])
-			->getMock();
-
-		[$userFolder, $path] = $this->getNonSharedUserFile();
-		$this->rootFolder->expects($this->exactly(2))
-			->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$this->userManager->method('userExists')->with('validUser')->willReturn(true);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('createShare')
-			->with($this->callback(function (IShare $share) use ($path) {
-				return $share->getNode() === $path &&
-					$share->getPermissions() === (
-						Constants::PERMISSION_ALL &
-						~Constants::PERMISSION_DELETE &
-						~Constants::PERMISSION_CREATE
-					) &&
-					$share->getShareType() === IShare::TYPE_REMOTE &&
-					$share->getSharedWith() === 'user@example.org' &&
-					$share->getSharedBy() === 'currentUser';
-			}))
-			->willReturnArgument(0);
-
-		$this->shareManager->method('outgoingServer2ServerSharesAllowed')->willReturn(true);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_REMOTE, 'user@example.org');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testCreateShareRemoteGroup(): void {
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		/** @var ShareAPIController $ocs */
-		$ocs = $this->getMockBuilder(ShareAPIController::class)
-			->setConstructorArgs([
-				$this->appName,
-				$this->request,
-				$this->shareManager,
-				$this->groupManager,
-				$this->userManager,
-				$this->rootFolder,
-				$this->urlGenerator,
-				$this->l,
-				$this->config,
-				$this->appManager,
-				$this->serverContainer,
-				$this->userStatusManager,
-				$this->previewManager,
-				$this->dateTimeZone,
-				$this->logger,
-				$this->factory,
-				$this->mailer,
-				$this->tagManager,
-				$this->currentUser,
-			])->onlyMethods(['formatShare'])
-			->getMock();
-
-		[$userFolder, $path] = $this->getNonSharedUserFile();
-		$this->rootFolder->expects($this->exactly(2))
-			->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$this->userManager->method('userExists')->with('validUser')->willReturn(true);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('createShare')
-			->with($this->callback(function (IShare $share) use ($path) {
-				return $share->getNode() === $path &&
-					$share->getPermissions() === (
-						Constants::PERMISSION_ALL &
-						~Constants::PERMISSION_DELETE &
-						~Constants::PERMISSION_CREATE
-					) &&
-					$share->getShareType() === IShare::TYPE_REMOTE_GROUP &&
-					$share->getSharedWith() === 'group@example.org' &&
-					$share->getSharedBy() === 'currentUser';
-			}))
-			->willReturnArgument(0);
-
-		$this->shareManager->method('outgoingServer2ServerGroupSharesAllowed')->willReturn(true);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_REMOTE_GROUP, 'group@example.org');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testCreateShareRoom(): void {
-		$ocs = $this->mockFormatShare();
-
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		[$userFolder, $path] = $this->getNonSharedUserFile();
-		$this->rootFolder->expects($this->exactly(2))
-			->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->appManager->method('isEnabledForUser')
-			->with('spreed')
-			->willReturn(true);
-
-		// This is not possible anymore with PHPUnit 10+
-		// as `setMethods` was removed and now real reflection is used, thus the class needs to exist.
-		// $helper = $this->getMockBuilder('\OCA\Talk\Share\Helper\ShareAPIController')
-		$helper = $this->getMockBuilder(\stdClass::class)
-			->addMethods(['createShare'])
-			->getMock();
-		$helper->method('createShare')
-			->with(
-				$share,
-				'recipientRoom',
-				Constants::PERMISSION_ALL &
-				~Constants::PERMISSION_DELETE &
-				~Constants::PERMISSION_CREATE,
-				''
-			)->willReturnCallback(
-				function ($share): void {
-					$share->setSharedWith('recipientRoom');
-					$share->setPermissions(Constants::PERMISSION_ALL);
-				}
-			);
-
-		$this->serverContainer->method('get')
-			->with('\OCA\Talk\Share\Helper\ShareAPIController')
-			->willReturn($helper);
-
-		$this->shareManager->method('createShare')
-			->with($this->callback(function (IShare $share) use ($path) {
-				return $share->getNode() === $path
-					&& $share->getPermissions() === Constants::PERMISSION_ALL
-					&& $share->getShareType() === IShare::TYPE_ROOM
-					&& $share->getSharedWith() === 'recipientRoom'
-					&& $share->getSharedBy() === 'currentUser';
-			}))
-			->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_ROOM, 'recipientRoom');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-
-	public function testCreateShareRoomHelperNotAvailable(): void {
-		$this->expectException(OCSForbiddenException::class);
-		$this->expectExceptionMessage('Sharing valid-path failed because the back end does not support room shares');
-
-		$ocs = $this->mockFormatShare();
-
-		$share = $this->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		[$userFolder, $path] = $this->getNonSharedUserFolder();
-		$this->rootFolder->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$path->method('getPath')->willReturn('valid-path');
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->appManager->method('isEnabledForUser')
-			->with('spreed')
-			->willReturn(false);
-
-		$this->shareManager->expects($this->never())->method('createShare');
-
-		$ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_ROOM, 'recipientRoom');
-	}
-
-
-	public function testCreateShareRoomHelperThrowException(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Exception thrown by the helper');
-
-		$ocs = $this->mockFormatShare();
-
-		$share = $this->newShare();
-		$share->setSharedBy('currentUser');
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		[$userFolder, $path] = $this->getNonSharedUserFile();
-		$this->rootFolder->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$path->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->appManager->method('isEnabledForUser')
-			->with('spreed')
-			->willReturn(true);
-
-		// This is not possible anymore with PHPUnit 10+
-		// as `setMethods` was removed and now real reflection is used, thus the class needs to exist.
-		// $helper = $this->getMockBuilder('\OCA\Talk\Share\Helper\ShareAPIController')
-		$helper = $this->getMockBuilder(\stdClass::class)
-			->addMethods(['createShare'])
-			->getMock();
-		$helper->method('createShare')
-			->with(
-				$share,
-				'recipientRoom',
-				Constants::PERMISSION_ALL & ~(Constants::PERMISSION_CREATE | Constants::PERMISSION_DELETE),
-				''
-			)->willReturnCallback(
-				function ($share): void {
-					throw new OCSNotFoundException('Exception thrown by the helper');
-				}
-			);
-
-		$this->serverContainer->method('get')
-			->with('\OCA\Talk\Share\Helper\ShareAPIController')
-			->willReturn($helper);
-
-		$this->shareManager->expects($this->never())->method('createShare');
-
-		$ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_ROOM, 'recipientRoom');
-	}
-
-	/**
-	 * Test for https://github.com/owncloud/core/issues/22587
-	 * TODO: Remove once proper solution is in place
-	 */
-	public function testCreateReshareOfFederatedMountNoDeletePermissions(): void {
-		$share = Server::get(IManager::class)->newShare();
-		$this->shareManager->method('newShare')->willReturn($share);
-
-		/** @var ShareAPIController&MockObject $ocs */
-		$ocs = $this->getMockBuilder(ShareAPIController::class)
-			->setConstructorArgs([
-				$this->appName,
-				$this->request,
-				$this->shareManager,
-				$this->groupManager,
-				$this->userManager,
-				$this->rootFolder,
-				$this->urlGenerator,
-				$this->l,
-				$this->config,
-				$this->appManager,
-				$this->serverContainer,
-				$this->userStatusManager,
-				$this->previewManager,
-				$this->dateTimeZone,
-				$this->logger,
-				$this->factory,
-				$this->mailer,
-				$this->tagManager,
-				$this->currentUser,
-			])->onlyMethods(['formatShare'])
-			->getMock();
-
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$this->rootFolder->expects($this->exactly(2))
-			->method('getUserFolder')
-			->with('currentUser')
-			->willReturn($userFolder);
-
-		$path = $this->getMockBuilder(Folder::class)->getMock();
-		$path->method('getId')->willReturn(42);
-
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', true],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$userFolder->method('getStorage')->willReturn($storage);
-		$path->method('getStorage')->willReturn($storage);
-
-		$path->method('getPermissions')->willReturn(Constants::PERMISSION_READ);
-		$userFolder->expects($this->once())
-			->method('get')
-			->with('valid-path')
-			->willReturn($path);
-		$userFolder->method('getById')
-			->willReturn([]);
-
-		$this->userManager->method('userExists')->with('validUser')->willReturn(true);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('createShare')
-			->with($this->callback(function (IShare $share) {
-				return $share->getPermissions() === Constants::PERMISSION_READ;
-			}))
-			->willReturnArgument(0);
-
-		$ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_USER, 'validUser');
-	}
-
-
-	public function testUpdateShareCantAccess(): void {
-		$this->expectException(OCSNotFoundException::class);
-		$this->expectExceptionMessage('Wrong share ID, share does not exist');
-
-		[$userFolder, $node] = $this->getNonSharedUserFolder();
-		$share = $this->newShare();
-		$share->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with($share->getNodeId())
-			->willReturn([$share->getNode()]);
-
-		$this->ocs->updateShare(42);
-	}
-
-
-	public function testUpdateNoParametersLink(): void {
-		$this->expectException(OCSBadRequestException::class);
-		$this->expectExceptionMessage('Wrong or no update parameter given');
-
-		$node = $this->getMockBuilder(Folder::class)->getMock();
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->ocs->updateShare(42);
-	}
-
-
-	public function testUpdateNoParametersOther(): void {
-		$this->expectException(OCSBadRequestException::class);
-		$this->expectExceptionMessage('Wrong or no update parameter given');
-
-		$node = $this->getMockBuilder(Folder::class)->getMock();
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_GROUP)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->ocs->updateShare(42);
-	}
-
-	public function testUpdateLinkShareClear(): void {
-		$ocs = $this->mockFormatShare();
-
-		[$userFolder, $node] = $this->getNonSharedUserFolder();
-		$node->method('getId')
-			->willReturn(42);
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setExpirationDate(new \DateTime())
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) {
-				return $share->getPermissions() === Constants::PERMISSION_READ &&
-				$share->getPassword() === null &&
-				$share->getExpirationDate() === null &&
-				// Once set a note or a label are never back to null, only to an
-				// empty string.
-				$share->getNote() === '' &&
-				$share->getLabel() === '' &&
-				$share->getHideDownload() === false;
-			})
-		)->willReturnArgument(0);
-
-		$this->shareManager->method('getSharedWith')
-			->willReturn([]);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$node]);
-		$userFolder->method('getFirstNodeById')
-			->with(42)
-			->willReturn($node);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$node->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, null, '', null, 'false', '', '', '', 'false');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateLinkShareSet(): void {
-		$ocs = $this->mockFormatShare();
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) {
-				$date = new \DateTime('2000-01-01');
-				$date->setTime(0, 0, 0);
-
-				return $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
-				$share->getPassword() === 'password' &&
-				$share->getExpirationDate() == $date &&
-				$share->getNote() === 'note' &&
-				$share->getLabel() === 'label' &&
-				$share->getHideDownload() === true;
-			})
-		)->willReturnArgument(0);
-
-		$this->shareManager->method('getSharedWith')
-			->willReturn([]);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$folder->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, null, 'password', null, 'true', '2000-01-01', 'note', 'label', 'true');
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	/**
-	 * @dataProvider publicUploadParamsProvider
-	 */
-	public function testUpdateLinkShareEnablePublicUpload($permissions, $publicUpload, $expireDate, $password): void {
-		$ocs = $this->mockFormatShare();
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-		$this->shareManager->method('getSharedWith')->willReturn([]);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) {
-				return $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
-				$share->getPassword() === 'password' &&
-				$share->getExpirationDate() === null;
-			})
-		)->willReturnArgument(0);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$folder->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, $permissions, $password, null, $publicUpload, $expireDate);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-
-	public function publicLinkValidPermissionsProvider() {
-		return [
-			[Constants::PERMISSION_CREATE],
-			[Constants::PERMISSION_READ],
-			[Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE],
-			[Constants::PERMISSION_READ | Constants::PERMISSION_DELETE],
-			[Constants::PERMISSION_READ | Constants::PERMISSION_CREATE],
-		];
-	}
-
-	/**
-	 * @dataProvider publicLinkValidPermissionsProvider
-	 */
-	public function testUpdateLinkShareSetCRUDPermissions($permissions): void {
-		$ocs = $this->mockFormatShare();
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-		$this->shareManager->method('getSharedWith')->willReturn([]);
-
-		$this->shareManager
-			->expects($this->any())
-			->method('updateShare')
-			->willReturnArgument(0);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$folder->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, $permissions, 'password', null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function publicLinkInvalidPermissionsProvider1() {
-		return [
-			[Constants::PERMISSION_DELETE],
-			[Constants::PERMISSION_UPDATE],
-			[Constants::PERMISSION_SHARE],
-		];
-	}
-
-	/**
-	 * @dataProvider publicLinkInvalidPermissionsProvider1
-	 */
-	public function testUpdateLinkShareSetInvalidCRUDPermissions1($permissions): void {
-		$this->expectException(OCSBadRequestException::class);
-		$this->expectExceptionMessage('Share must at least have READ or CREATE permissions');
-
-		$this->testUpdateLinkShareSetCRUDPermissions($permissions, null);
-	}
-
-	public function publicLinkInvalidPermissionsProvider2() {
-		return [
-			[Constants::PERMISSION_CREATE | Constants::PERMISSION_DELETE],
-			[Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE],
-		];
-	}
-
-	/**
-	 * @dataProvider publicLinkInvalidPermissionsProvider2
-	 */
-	public function testUpdateLinkShareSetInvalidCRUDPermissions2($permissions): void {
-		$this->expectException(OCSBadRequestException::class);
-		$this->expectExceptionMessage('Share must have READ permission if UPDATE or DELETE permission is set');
-
-		$this->testUpdateLinkShareSetCRUDPermissions($permissions);
-	}
-
-	public function testUpdateLinkShareInvalidDate(): void {
-		$this->expectException(OCSBadRequestException::class);
-		$this->expectExceptionMessage('Invalid date. Format must be YYYY-MM-DD');
-
-		$ocs = $this->mockFormatShare();
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$ocs->updateShare(42, null, 'password', null, 'true', '2000-01-a');
-	}
-
-	public function publicUploadParamsProvider() {
-		return [
-			[null, 'true', null, 'password'],
-			// legacy had no delete
-			[
-				Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE,
-				'true', null, 'password'
-			],
-			// correct
-			[
-				Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE,
-				null, null, 'password'
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider publicUploadParamsProvider
-	 */
-	public function testUpdateLinkSharePublicUploadNotAllowed($permissions, $publicUpload, $expireDate, $password): void {
-		$this->expectException(OCSForbiddenException::class);
-		$this->expectExceptionMessage('Public upload disabled by the administrator');
-
-		$ocs = $this->mockFormatShare();
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$folder->method('getId')->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(false);
-
-		$ocs->updateShare(42, $permissions, $password, null, $publicUpload, $expireDate);
-	}
-
-
-	public function testUpdateLinkSharePublicUploadOnFile(): void {
-		$this->expectException(OCSBadRequestException::class);
-		$this->expectExceptionMessage('Public upload is only possible for publicly shared folders');
-
-		$ocs = $this->mockFormatShare();
-
-		$file = $this->getMockBuilder(File::class)->getMock();
-		$file->method('getId')
-			->willReturn(42);
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setNode($file);
-
-		$this->shareManager
-			->method('getShareById')
-			->with('ocinternal:42')
-			->willReturn($share);
-		$this->shareManager
-			->method('shareApiLinkAllowPublicUpload')
-			->willReturn(true);
-		$this->shareManager
-			->method('updateShare')
-			->with($share)
-			->willThrowException(new \InvalidArgumentException('File shares cannot have create or delete permissions'));
-
-		$ocs->updateShare(42, null, 'password', null, 'true', '');
-	}
-
-	public function testUpdateLinkSharePasswordDoesNotChangeOther(): void {
-		$ocs = $this->mockFormatShare();
-
-		$date = new \DateTime('2000-01-01');
-		$date->setTime(0, 0, 0);
-
-		[$userFolder, $node] = $this->getNonSharedUserFolder();
-		$node->method('getId')->willReturn(42);
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$node]);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($date)
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) use ($date) {
-				return $share->getPermissions() === Constants::PERMISSION_ALL &&
-				$share->getPassword() === 'newpassword' &&
-				$share->getSendPasswordByTalk() === true &&
-				$share->getExpirationDate() === $date &&
-				$share->getNote() === 'note' &&
-				$share->getLabel() === 'label' &&
-				$share->getHideDownload() === true;
-			})
-		)->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, null, 'newpassword', null, null, null, null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateLinkShareSendPasswordByTalkDoesNotChangeOther(): void {
-		$ocs = $this->mockFormatShare();
-
-		$date = new \DateTime('2000-01-01');
-		$date->setTime(0, 0, 0);
-
-		[$userFolder, $node] = $this->getNonSharedUserFolder();
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$node]);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-		$node->method('getId')->willReturn(42);
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(false)
-			->setExpirationDate($date)
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) use ($date) {
-				return $share->getPermissions() === Constants::PERMISSION_ALL &&
-				$share->getPassword() === 'password' &&
-				$share->getSendPasswordByTalk() === true &&
-				$share->getExpirationDate() === $date &&
-				$share->getNote() === 'note' &&
-				$share->getLabel() === 'label' &&
-				$share->getHideDownload() === true;
-			})
-		)->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, null, null, 'true', null, null, null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-
-	public function testUpdateLinkShareSendPasswordByTalkWithTalkDisabledDoesNotChangeOther(): void {
-		$this->expectException(OCSForbiddenException::class);
-		$this->expectExceptionMessage('"Sending the password by Nextcloud Talk" for sharing a file or folder failed because Nextcloud Talk is not enabled.');
-
-		$ocs = $this->mockFormatShare();
-
-		$date = new \DateTime('2000-01-01');
-		$date->setTime(0, 0, 0);
-
-		[$userFolder, $node] = $this->getNonSharedUserFolder();
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$node]);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-		$node->method('getId')->willReturn(42);
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(false)
-			->setExpirationDate($date)
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(false);
-
-		$this->shareManager->expects($this->never())->method('updateShare');
-
-		$ocs->updateShare(42, null, null, 'true', null, null, null, null, null);
-	}
-
-	public function testUpdateLinkShareDoNotSendPasswordByTalkDoesNotChangeOther(): void {
-		$ocs = $this->mockFormatShare();
-
-		$date = new \DateTime('2000-01-01');
-		$date->setTime(0, 0, 0);
-
-		[$userFolder, $node] = $this->getNonSharedUserFolder();
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$node]);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-		$node->method('getId')->willReturn(42);
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($date)
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) use ($date) {
-				return $share->getPermissions() === Constants::PERMISSION_ALL &&
-				$share->getPassword() === 'password' &&
-				$share->getSendPasswordByTalk() === false &&
-				$share->getExpirationDate() === $date &&
-				$share->getNote() === 'note' &&
-				$share->getLabel() === 'label' &&
-				$share->getHideDownload() === true;
-			})
-		)->willReturnArgument(0);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, null, null, 'false', null, null, null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateLinkShareDoNotSendPasswordByTalkWithTalkDisabledDoesNotChangeOther(): void {
-		$ocs = $this->mockFormatShare();
-
-		$date = new \DateTime('2000-01-01');
-		$date->setTime(0, 0, 0);
-
-		[$userFolder, $node] = $this->getNonSharedUserFolder();
-		$node->method('getId')
-			->willReturn(42);
-
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($date)
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(false);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) use ($date) {
-				return $share->getPermissions() === Constants::PERMISSION_ALL &&
-				$share->getPassword() === 'password' &&
-				$share->getSendPasswordByTalk() === false &&
-				$share->getExpirationDate() === $date &&
-				$share->getNote() === 'note' &&
-				$share->getLabel() === 'label' &&
-				$share->getHideDownload() === true;
-			})
-		)->willReturnArgument(0);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$node]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$node->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$node->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, null, null, 'false', null, null, null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateLinkShareExpireDateDoesNotChangeOther(): void {
-		$ocs = $this->mockFormatShare();
-
-		[$userFolder, $node] = $this->getNonSharedUserFolder();
-		$node->method('getId')
-			->willReturn(42);
-
-		$share = $this->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate(new \DateTime())
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($node);
-
-		$node->expects($this->once())
-			->method('lock')
-			->with(ILockingProvider::LOCK_SHARED);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) {
-				$date = new \DateTime('2010-12-23');
-				$date->setTime(0, 0, 0);
-
-				return $share->getPermissions() === Constants::PERMISSION_ALL &&
-				$share->getPassword() === 'password' &&
-				$share->getSendPasswordByTalk() === true &&
-				$share->getExpirationDate() == $date &&
-				$share->getNote() === 'note' &&
-				$share->getLabel() === 'label' &&
-				$share->getHideDownload() === true;
-			})
-		)->willReturnArgument(0);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$node]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$node->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, null, null, null, null, '2010-12-23', null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateLinkSharePublicUploadDoesNotChangeOther(): void {
-		$ocs = $this->mockFormatShare();
-
-		$date = new \DateTime('2000-01-01');
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($date)
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) use ($date) {
-				return $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
-				$share->getPassword() === 'password' &&
-				$share->getSendPasswordByTalk() === true &&
-				$share->getExpirationDate() === $date &&
-				$share->getNote() === 'note' &&
-				$share->getLabel() === 'label' &&
-				$share->getHideDownload() === true;
-			})
-		)->willReturnArgument(0);
-
-		$this->shareManager->method('getSharedWith')
-			->willReturn([]);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$folder->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, null, null, null, 'true', null, null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateLinkSharePermissions(): void {
-		$ocs = $this->mockFormatShare();
-
-		$date = new \DateTime('2000-01-01');
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($date)
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_ALL)
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) use ($date): bool {
-				return $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
-				$share->getPassword() === 'password' &&
-				$share->getSendPasswordByTalk() === true &&
-				$share->getExpirationDate() === $date &&
-				$share->getNote() === 'note' &&
-				$share->getLabel() === 'label' &&
-				$share->getHideDownload() === true;
-			})
-		)->willReturnArgument(0);
-
-		$this->shareManager->method('getSharedWith')->willReturn([]);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$folder->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, 7, null, null, 'true', null, null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateLinkSharePermissionsShare(): void {
-		$ocs = $this->mockFormatShare();
-
-		$date = new \DateTime('2000-01-01');
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_LINK)
-			->setPassword('password')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate($date)
-			->setNote('note')
-			->setLabel('label')
-			->setHideDownload(true)
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->shareManager->expects($this->once())
-			->method('updateShare')
-			->with(
-				$this->callback(function (IShare $share) use ($date) {
-					return $share->getPermissions() === Constants::PERMISSION_ALL &&
-						$share->getPassword() === 'password' &&
-						$share->getSendPasswordByTalk() === true &&
-						$share->getExpirationDate() === $date &&
-						$share->getNote() === 'note' &&
-						$share->getLabel() === 'label' &&
-						$share->getHideDownload() === true;
-				})
-			)->willReturnArgument(0);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$folder->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$this->shareManager->method('getSharedWith')->willReturn([]);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, Constants::PERMISSION_ALL, null, null, null, null, null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateOtherPermissions(): void {
-		$ocs = $this->mockFormatShare();
-
-		[$userFolder, $file] = $this->getNonSharedUserFolder();
-		$file->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setPermissions(Constants::PERMISSION_ALL)
-			->setSharedBy($this->currentUser)
-			->setShareType(IShare::TYPE_USER)
-			->setNode($file);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-		$this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
-
-		$this->shareManager->expects($this->once())->method('updateShare')->with(
-			$this->callback(function (IShare $share) {
-				return $share->getPermissions() === Constants::PERMISSION_ALL;
-			})
-		)->willReturnArgument(0);
-
-		$this->shareManager->method('getSharedWith')->willReturn([]);
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$file]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$file->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$expected = new DataResponse([]);
-		$result = $ocs->updateShare(42, 31, null, null, null, null);
-
-		$this->assertInstanceOf(get_class($expected), $result);
-		$this->assertEquals($expected->getData(), $result->getData());
-	}
-
-	public function testUpdateShareCannotIncreasePermissions(): void {
-		$ocs = $this->mockFormatShare();
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share
-			->setId(42)
-			->setSharedBy($this->currentUser)
-			->setShareOwner('anotheruser')
-			->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('group1')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder);
-
-		// note: updateShare will modify the received instance but getSharedWith will reread from the database,
-		// so their values will be different
-		$incomingShare = Server::get(IManager::class)->newShare();
-		$incomingShare
-			->setId(42)
-			->setSharedBy($this->currentUser)
-			->setShareOwner('anotheruser')
-			->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('group1')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder);
-
-		$this->request
-			->method('getParam')
-			->willReturnMap([
-				['permissions', null, '31'],
-			]);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->shareManager->expects($this->any())
-			->method('getSharedWith')
-			->willReturnMap([
-				['currentUser', IShare::TYPE_USER, $share->getNode(), -1, 0, []],
-				['currentUser', IShare::TYPE_GROUP, $share->getNode(), -1, 0, [$incomingShare]],
-				['currentUser', IShare::TYPE_ROOM, $share->getNode(), -1, 0, []]
-			]);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-		$userFolder->method('getFirstNodeById')
-			->with(42)
-			->willReturn($folder);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$folder->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$this->shareManager->expects($this->once())
-			->method('updateShare')
-			->with($share)
-			->willThrowException(new GenericShareException('Cannot increase permissions of path/file', 'Cannot increase permissions of path/file', 404));
-
-		try {
-			$ocs->updateShare(42, 31);
-			$this->fail();
-		} catch (OCSException $e) {
-			$this->assertEquals('Cannot increase permissions of path/file', $e->getMessage());
-		}
-	}
-
-	public function testUpdateShareCanIncreasePermissionsIfOwner(): void {
-		$ocs = $this->mockFormatShare();
-
-		[$userFolder, $folder] = $this->getNonSharedUserFolder();
-		$folder->method('getId')
-			->willReturn(42);
-
-		$share = Server::get(IManager::class)->newShare();
-		$share
-			->setId(42)
-			->setSharedBy($this->currentUser)
-			->setShareOwner($this->currentUser)
-			->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('group1')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder);
-
-		// note: updateShare will modify the received instance but getSharedWith will reread from the database,
-		// so their values will be different
-		$incomingShare = Server::get(IManager::class)->newShare();
-		$incomingShare
-			->setId(42)
-			->setSharedBy($this->currentUser)
-			->setShareOwner($this->currentUser)
-			->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('group1')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder);
-
-		$this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
-
-		$this->shareManager->expects($this->any())
-			->method('getSharedWith')
-			->willReturnMap([
-				['currentUser', IShare::TYPE_USER, $share->getNode(), -1, 0, []],
-				['currentUser', IShare::TYPE_GROUP, $share->getNode(), -1, 0, [$incomingShare]]
-			]);
-
-		$this->shareManager->expects($this->once())
-			->method('updateShare')
-			->with($share)
-			->willReturn($share);
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$userFolder->method('getById')
-			->with(42)
-			->willReturn([$folder]);
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$folder->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mountPoint->method('getStorageRootId')
-			->willReturn(42);
-
-		$result = $ocs->updateShare(42, 31);
-		$this->assertInstanceOf(DataResponse::class, $result);
-	}
-
-	public function testUpdateShareOwnerless(): void {
-		$ocs = $this->mockFormatShare();
-
-		$mount = $this->createMock(IShareOwnerlessMount::class);
-
-		$file = $this->createMock(File::class);
-		$file
-			->expects($this->exactly(2))
-			->method('getPermissions')
-			->willReturn(Constants::PERMISSION_SHARE);
-		$file
-			->expects($this->once())
-			->method('getMountPoint')
-			->willReturn($mount);
-
-		$userFolder = $this->createMock(Folder::class);
-		$userFolder->method('getById')
-			->with(2)
-			->willReturn([$file]);
-		$userFolder->method('getFirstNodeById')
-			->with(2)
-			->willReturn($file);
-
-		$this->rootFolder
-			->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturn($userFolder);
-
-		$share = $this->createMock(IShare::class);
-		$share
-			->expects($this->once())
-			->method('getNode')
-			->willReturn($file);
-		$share
-			->expects($this->exactly(2))
-			->method('getNodeId')
-			->willReturn(2);
-		$share
-			->expects($this->exactly(2))
-			->method('getPermissions')
-			->willReturn(Constants::PERMISSION_SHARE);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('getShareById')
-			->with('ocinternal:1', $this->currentUser)
-			->willReturn($share);
-
-		$this->shareManager
-			->expects($this->once())
-			->method('updateShare')
-			->with($share)
-			->willReturn($share);
-
-		$result = $ocs->updateShare(1, Constants::PERMISSION_ALL);
-		$this->assertInstanceOf(DataResponse::class, $result);
-	}
-
-	public function dataFormatShare() {
-		$file = $this->getMockBuilder(File::class)->getMock();
-		$folder = $this->getMockBuilder(Folder::class)->getMock();
-		$parent = $this->getMockBuilder(Folder::class)->getMock();
-		$fileWithPreview = $this->getMockBuilder(File::class)->getMock();
-
-		$file->method('getMimeType')->willReturn('myMimeType');
-		$folder->method('getMimeType')->willReturn('myFolderMimeType');
-		$fileWithPreview->method('getMimeType')->willReturn('mimeWithPreview');
-
-		$mountPoint = $this->createMock(IMountPoint::class);
-		$mountPoint->method('getMountType')->willReturn('');
-		$file->method('getMountPoint')->willReturn($mountPoint);
-		$folder->method('getMountPoint')->willReturn($mountPoint);
-		$fileWithPreview->method('getMountPoint')->willReturn($mountPoint);
-
-		$file->method('getPath')->willReturn('file');
-		$folder->method('getPath')->willReturn('folder');
-		$fileWithPreview->method('getPath')->willReturn('fileWithPreview');
-
-		$parent->method('getId')->willReturn(1);
-		$folder->method('getId')->willReturn(2);
-		$file->method('getId')->willReturn(3);
-		$fileWithPreview->method('getId')->willReturn(4);
-
-		$file->method('getParent')->willReturn($parent);
-		$folder->method('getParent')->willReturn($parent);
-		$fileWithPreview->method('getParent')->willReturn($parent);
-
-		$file->method('getSize')->willReturn(123456);
-		$folder->method('getSize')->willReturn(123456);
-		$fileWithPreview->method('getSize')->willReturn(123456);
-		$file->method('getMTime')->willReturn(1234567890);
-		$folder->method('getMTime')->willReturn(1234567890);
-		$fileWithPreview->method('getMTime')->willReturn(1234567890);
-
-		$cache = $this->getMockBuilder('OCP\Files\Cache\ICache')->getMock();
-		$cache->method('getNumericStorageId')->willReturn(100);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('getId')->willReturn('storageId');
-		$storage->method('getCache')->willReturn($cache);
-
-		$file->method('getStorage')->willReturn($storage);
-		$folder->method('getStorage')->willReturn($storage);
-		$fileWithPreview->method('getStorage')->willReturn($storage);
-
-
-		$mountPoint = $this->getMockBuilder(IMountPoint::class)->getMock();
-		$mountPoint->method('getMountType')->willReturn('');
-		$file->method('getMountPoint')->willReturn($mountPoint);
-		$folder->method('getMountPoint')->willReturn($mountPoint);
-
-		$owner = $this->getMockBuilder(IUser::class)->getMock();
-		$owner->method('getDisplayName')->willReturn('ownerDN');
-		$initiator = $this->getMockBuilder(IUser::class)->getMock();
-		$initiator->method('getDisplayName')->willReturn('initiatorDN');
-		$recipient = $this->getMockBuilder(IUser::class)->getMock();
-		$recipient->method('getDisplayName')->willReturn('recipientDN');
-		$recipient->method('getSystemEMailAddress')->willReturn('recipient');
-		[$shareAttributes, $shareAttributesReturnJson] = $this->mockShareAttributes();
-
-		$result = [];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_USER)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setAttributes($shareAttributes)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-
-		// User backend down
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_USER,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'attributes' => $shareAttributesReturnJson,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipient',
-				'share_with_displayname' => 'recipient',
-				'share_with_displayname_unique' => 'recipient',
-				'note' => 'personal note',
-				'label' => '',
-				'mail_send' => 0,
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => '[{"scope":"permissions","key":"download","value":true}]',
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-		// User backend up
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_USER,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiatorDN',
-				'permissions' => 1,
-				'attributes' => $shareAttributesReturnJson,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'ownerDN',
-				'note' => 'personal note',
-				'label' => '',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipient',
-				'share_with_displayname' => 'recipientDN',
-				'share_with_displayname_unique' => 'recipient',
-				'mail_send' => 0,
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => '[{"scope":"permissions","key":"download","value":true}]',
-				'item_permissions' => 1,
-			], $share, [
-				['owner', $owner],
-				['initiator', $initiator],
-				['recipient', $recipient],
-			], false
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_USER)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-		// User backend down
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_USER,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'attributes' => null,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'label' => '',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipient',
-				'share_with_displayname' => 'recipient',
-				'share_with_displayname_unique' => 'recipient',
-				'mail_send' => 0,
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_USER)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-		// User backend down
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_USER,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'attributes' => null,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'currentUser',
-				'displayname_file_owner' => 'currentUser',
-				'note' => 'personal note',
-				'label' => '',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipient',
-				'share_with_displayname' => 'recipient',
-				'share_with_displayname_unique' => 'recipient',
-				'mail_send' => 0,
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => true,
-				'can_delete' => true,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 11,
-			], $share, [], false
-		];
-
-		// with existing group
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('recipientGroup')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_GROUP,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'attributes' => null,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'label' => '',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipientGroup',
-				'share_with_displayname' => 'recipientGroupDisplayName',
-				'mail_send' => 0,
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		// with unknown group / no group backend
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_GROUP)
-			->setSharedWith('recipientGroup2')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_GROUP,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'label' => '',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipientGroup2',
-				'share_with_displayname' => 'recipientGroup2',
-				'mail_send' => 0,
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_LINK)
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setPassword('mypassword')
-			->setExpirationDate(new \DateTime('2001-01-02T00:00:00'))
-			->setToken('myToken')
-			->setNote('personal note')
-			->setLabel('new link share')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_LINK,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'attributes' => null,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => '2001-01-02 00:00:00',
-				'token' => 'myToken',
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'label' => 'new link share',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'password' => 'mypassword',
-				'share_with' => 'mypassword',
-				'share_with_displayname' => '(Shared link)',
-				'send_password_by_talk' => false,
-				'mail_send' => 0,
-				'url' => 'myLink',
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_LINK)
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setPassword('mypassword')
-			->setSendPasswordByTalk(true)
-			->setExpirationDate(new \DateTime('2001-01-02T00:00:00'))
-			->setToken('myToken')
-			->setNote('personal note')
-			->setLabel('new link share')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_LINK,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => '2001-01-02 00:00:00',
-				'token' => 'myToken',
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'label' => 'new link share',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'password' => 'mypassword',
-				'share_with' => 'mypassword',
-				'share_with_displayname' => '(Shared link)',
-				'send_password_by_talk' => true,
-				'mail_send' => 0,
-				'url' => 'myLink',
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_REMOTE)
-			->setSharedBy('initiator')
-			->setSharedWith('user@server.com')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setExpirationDate(new \DateTime('2001-02-03T04:05:06'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_REMOTE,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => '2001-02-03 00:00:00',
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'label' => '',
-				'path' => 'folder',
-				'item_type' => 'folder',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 2,
-				'file_source' => 2,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'user@server.com',
-				'share_with_displayname' => 'foobar',
-				'mail_send' => 0,
-				'mimetype' => 'myFolderMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_REMOTE_GROUP)
-			->setSharedBy('initiator')
-			->setSharedWith('user@server.com')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setExpirationDate(new \DateTime('2001-02-03T04:05:06'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_REMOTE_GROUP,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => '2001-02-03 00:00:00',
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'label' => '',
-				'path' => 'folder',
-				'item_type' => 'folder',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 2,
-				'file_source' => 2,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'user@server.com',
-				'share_with_displayname' => 'foobar',
-				'mail_send' => 0,
-				'mimetype' => 'myFolderMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		// Circle with id, display name and avatar set by the Circles app
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_CIRCLE)
-			->setSharedBy('initiator')
-			->setSharedWith('Circle (Public circle, circleOwner) [4815162342]')
-			->setSharedWithDisplayName('The display name')
-			->setSharedWithAvatar('path/to/the/avatar')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_CIRCLE,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'attributes' => null,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => '',
-				'label' => '',
-				'path' => 'folder',
-				'item_type' => 'folder',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 2,
-				'file_source' => 2,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => '4815162342',
-				'share_with_displayname' => 'The display name',
-				'share_with_avatar' => 'path/to/the/avatar',
-				'mail_send' => 0,
-				'mimetype' => 'myFolderMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		// Circle with id set by the Circles app
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_CIRCLE)
-			->setSharedBy('initiator')
-			->setSharedWith('Circle (Public circle, circleOwner) [4815162342]')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_CIRCLE,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => '',
-				'label' => '',
-				'path' => 'folder',
-				'item_type' => 'folder',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 2,
-				'file_source' => 2,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => '4815162342',
-				'share_with_displayname' => 'Circle (Public circle, circleOwner)',
-				'share_with_avatar' => '',
-				'mail_send' => 0,
-				'mimetype' => 'myFolderMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		// Circle with id not set by the Circles app
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_CIRCLE)
-			->setSharedBy('initiator')
-			->setSharedWith('Circle (Public circle, circleOwner)')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_CIRCLE,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => '',
-				'label' => '',
-				'path' => 'folder',
-				'item_type' => 'folder',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 2,
-				'file_source' => 2,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'Circle',
-				'share_with_displayname' => 'Circle (Public circle, circleOwner)',
-				'share_with_avatar' => '',
-				'mail_send' => 0,
-				'mimetype' => 'myFolderMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_USER)
-			->setSharedBy('initiator')
-			->setSharedWith('recipient')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-
-		$result[] = [
-			[], $share, [], true
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_EMAIL)
-			->setSharedBy('initiator')
-			->setSharedWith('user@server.com')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setId(42)
-			->setPassword('password');
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_EMAIL,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => '',
-				'label' => '',
-				'path' => 'folder',
-				'item_type' => 'folder',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 2,
-				'file_source' => 2,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'user@server.com',
-				'share_with_displayname' => 'mail display name',
-				'mail_send' => 0,
-				'mimetype' => 'myFolderMimeType',
-				'has_preview' => false,
-				'password' => 'password',
-				'send_password_by_talk' => false,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'password_expiration_time' => null,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_EMAIL)
-			->setSharedBy('initiator')
-			->setSharedWith('user@server.com')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($folder)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setId(42)
-			->setPassword('password')
-			->setSendPasswordByTalk(true);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_EMAIL,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => '',
-				'label' => '',
-				'path' => 'folder',
-				'item_type' => 'folder',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 2,
-				'file_source' => 2,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'user@server.com',
-				'share_with_displayname' => 'mail display name',
-				'mail_send' => 0,
-				'mimetype' => 'myFolderMimeType',
-				'has_preview' => false,
-				'password' => 'password',
-				'send_password_by_talk' => true,
-				'hide_download' => 0,
-				'can_edit' => false,
-				'can_delete' => false,
-				'password_expiration_time' => null,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, [], false
-		];
-
-		// Preview is available
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_USER)
-			->setSharedWith('recipient')
-			->setSharedBy('initiator')
-			->setShareOwner('currentUser')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($fileWithPreview)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_USER,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'currentUser',
-				'displayname_file_owner' => 'currentUser',
-				'note' => 'personal note',
-				'label' => '',
-				'path' => 'fileWithPreview',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 4,
-				'file_source' => 4,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipient',
-				'share_with_displayname' => 'recipient',
-				'share_with_displayname_unique' => 'recipient',
-				'mail_send' => 0,
-				'mimetype' => 'mimeWithPreview',
-				'has_preview' => true,
-				'hide_download' => 0,
-				'can_edit' => true,
-				'can_delete' => true,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 11,
-			], $share, [], false
-		];
-
-		return $result;
-	}
-
-	/**
-	 * @dataProvider dataFormatShare
-	 *
-	 * @param array $expects
-	 * @param IShare $share
-	 * @param array $users
-	 * @param $exception
-	 */
-	public function testFormatShare(array $expects, IShare $share, array $users, $exception): void {
-		$this->userManager->method('get')->willReturnMap($users);
-
-		$recipientGroup = $this->createMock(IGroup::class);
-		$recipientGroup->method('getDisplayName')->willReturn('recipientGroupDisplayName');
-		$this->groupManager->method('get')->willReturnMap([
-			['recipientGroup', $recipientGroup],
-		]);
-
-		$this->urlGenerator->method('linkToRouteAbsolute')
-			->with('files_sharing.sharecontroller.showShare', ['token' => 'myToken'])
-			->willReturn('myLink');
-
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturnSelf();
-		$this->dateTimeZone->method('getTimezone')->willReturn(new \DateTimeZone('UTC'));
-
-		if (!$exception) {
-			$this->rootFolder->method('getFirstNodeById')
-				->with($share->getNodeId())
-				->willReturn($share->getNode());
-
-			$this->rootFolder->method('getRelativePath')
-				->with($share->getNode()->getPath())
-				->willReturnArgument(0);
-		}
-
-		$cm = $this->createMock(\OCP\Contacts\IManager::class);
-		$this->overwriteService(\OCP\Contacts\IManager::class, $cm);
-
-		$cm->method('search')
-			->willReturnMap([
-				['user@server.com', ['CLOUD'], [
-					'limit' => 1,
-					'enumeration' => false,
-					'strict_search' => true,
-				],
-					[
-						[
-							'CLOUD' => [
-								'user@server.com',
-							],
-							'FN' => 'foobar',
-						],
-					],
-				],
-				['user@server.com', ['EMAIL'], [
-					'limit' => 1,
-					'enumeration' => false,
-					'strict_search' => true,
-				],
-					[
-						[
-							'EMAIL' => [
-								'user@server.com',
-							],
-							'FN' => 'mail display name',
-						],
-					],
-				],
-			]);
-
-		try {
-			$result = $this->invokePrivate($this->ocs, 'formatShare', [$share]);
-			$this->assertFalse($exception);
-			$this->assertEquals($expects, $result);
-		} catch (NotFoundException $e) {
-			$this->assertTrue($exception);
-		}
-	}
-
-	public function dataFormatRoomShare() {
-		$file = $this->getMockBuilder(File::class)->getMock();
-		$parent = $this->getMockBuilder(Folder::class)->getMock();
-
-		$file->method('getMimeType')->willReturn('myMimeType');
-
-		$file->method('getPath')->willReturn('file');
-
-		$parent->method('getId')->willReturn(1);
-		$file->method('getId')->willReturn(3);
-
-		$file->method('getParent')->willReturn($parent);
-
-		$file->method('getSize')->willReturn(123456);
-		$file->method('getMTime')->willReturn(1234567890);
-
-		$mountPoint = $this->getMockBuilder(IMountPoint::class)->getMock();
-		$mountPoint->method('getMountType')->willReturn('');
-		$file->method('getMountPoint')->willReturn($mountPoint);
-
-		$cache = $this->getMockBuilder('OCP\Files\Cache\ICache')->getMock();
-		$cache->method('getNumericStorageId')->willReturn(100);
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('getId')->willReturn('storageId');
-		$storage->method('getCache')->willReturn($cache);
-
-		$file->method('getStorage')->willReturn($storage);
-
-		$result = [];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_ROOM)
-			->setSharedWith('recipientRoom')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_ROOM,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipientRoom',
-				'share_with_displayname' => '',
-				'mail_send' => 0,
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'label' => '',
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 1,
-			], $share, false, []
-		];
-
-		$share = Server::get(IManager::class)->newShare();
-		$share->setShareType(IShare::TYPE_ROOM)
-			->setSharedWith('recipientRoom')
-			->setSharedBy('initiator')
-			->setShareOwner('owner')
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($file)
-			->setShareTime(new \DateTime('2000-01-01T00:01:02'))
-			->setTarget('myTarget')
-			->setNote('personal note')
-			->setId(42);
-
-		$result[] = [
-			[
-				'id' => '42',
-				'share_type' => IShare::TYPE_ROOM,
-				'uid_owner' => 'initiator',
-				'displayname_owner' => 'initiator',
-				'permissions' => 1,
-				'stime' => 946684862,
-				'parent' => null,
-				'expiration' => null,
-				'token' => null,
-				'uid_file_owner' => 'owner',
-				'displayname_file_owner' => 'owner',
-				'note' => 'personal note',
-				'path' => 'file',
-				'item_type' => 'file',
-				'storage_id' => 'storageId',
-				'storage' => 100,
-				'item_source' => 3,
-				'file_source' => 3,
-				'file_parent' => 1,
-				'file_target' => 'myTarget',
-				'share_with' => 'recipientRoom',
-				'share_with_displayname' => 'recipientRoomName',
-				'mail_send' => 0,
-				'mimetype' => 'myMimeType',
-				'has_preview' => false,
-				'hide_download' => 0,
-				'label' => '',
-				'can_edit' => false,
-				'can_delete' => false,
-				'item_size' => 123456,
-				'item_mtime' => 1234567890,
-				'is-mount-root' => false,
-				'mount-type' => '',
-				'attributes' => null,
-				'item_permissions' => 9,
-			], $share, true, [
-				'share_with_displayname' => 'recipientRoomName'
-			]
-		];
-
-		return $result;
-	}
-
-	/**
-	 * @dataProvider dataFormatRoomShare
-	 *
-	 * @param array $expects
-	 * @param IShare $share
-	 * @param bool $helperAvailable
-	 * @param array $formatShareByHelper
-	 */
-	public function testFormatRoomShare(array $expects, IShare $share, bool $helperAvailable, array $formatShareByHelper): void {
-		$this->rootFolder->method('getUserFolder')
-			->with($this->currentUser)
-			->willReturnSelf();
-
-		$this->rootFolder->method('getFirstNodeById')
-			->with($share->getNodeId())
-			->willReturn($share->getNode());
-
-		$this->rootFolder->method('getRelativePath')
-			->with($share->getNode()->getPath())
-			->willReturnArgument(0);
-
-		if (!$helperAvailable) {
-			$this->appManager->method('isEnabledForUser')
-				->with('spreed')
-				->willReturn(false);
-		} else {
-			$this->appManager->method('isEnabledForUser')
-				->with('spreed')
-				->willReturn(true);
-
-			// This is not possible anymore with PHPUnit 10+
-			// as `setMethods` was removed and now real reflection is used, thus the class needs to exist.
-			// $helper = $this->getMockBuilder('\OCA\Talk\Share\Helper\ShareAPIController')
-			$helper = $this->getMockBuilder(\stdClass::class)
-				->addMethods(['formatShare', 'canAccessShare'])
-				->getMock();
-			$helper->method('formatShare')
-				->with($share)
-				->willReturn($formatShareByHelper);
-			$helper->method('canAccessShare')
-				->with($share)
-				->willReturn(true);
-
-			$this->serverContainer->method('get')
-				->with('\OCA\Talk\Share\Helper\ShareAPIController')
-				->willReturn($helper);
-		}
-
-		$result = $this->invokePrivate($this->ocs, 'formatShare', [$share]);
-		$this->assertEquals($expects, $result);
-	}
-
-	/**
-	 * @return list{Folder, Folder}
-	 */
-	private function getNonSharedUserFolder(): array {
-		$node = $this->getMockBuilder(Folder::class)->getMock();
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$userFolder->method('getStorage')->willReturn($storage);
-		$node->method('getStorage')->willReturn($storage);
-		$node->method('getId')->willReturn(42);
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')->willReturn($this->currentUser);
-		$node->method('getOwner')->willReturn($user);
-		return [$userFolder, $node];
-	}
-
-	/**
-	 * @return list{Folder, File}
-	 */
-	private function getNonSharedUserFile(): array {
-		$node = $this->getMockBuilder(File::class)->getMock();
-		$userFolder = $this->getMockBuilder(Folder::class)->getMock();
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')
-			->willReturnMap([
-				['OCA\Files_Sharing\External\Storage', false],
-				['OCA\Files_Sharing\SharedStorage', false],
-			]);
-		$userFolder->method('getStorage')->willReturn($storage);
-		$node->method('getStorage')->willReturn($storage);
-		$node->method('getId')->willReturn(42);
-		return [$userFolder, $node];
-	}
-
-	public function testPopulateTags(): void {
-		$tagger = $this->createMock(ITags::class);
-		$this->tagManager->method('load')
-			->with('files')
-			->willReturn($tagger);
-		$data = [
-			['file_source' => 10],
-			['file_source' => 22, 'foo' => 'bar'],
-			['file_source' => 42, 'x' => 'y'],
-		];
-		$tags = [
-			10 => ['tag3'],
-			42 => ['tag1', 'tag2'],
-		];
-		$tagger->method('getTagsForObjects')
-			->with([10, 22, 42])
-			->willReturn($tags);
-
-		$result = self::invokePrivate($this->ocs, 'populateTags', [$data]);
-		$this->assertSame([
-			['file_source' => 10, 'tags' => ['tag3']],
-			['file_source' => 22, 'foo' => 'bar', 'tags' => []],
-			['file_source' => 42, 'x' => 'y', 'tags' => ['tag1', 'tag2']],
-		], $result);
-	}
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($file);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(true);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true');
+    }
+
+    public function testCreateShareLinkPublicUploadFolder(): void {
+        $ocs = $this->mockFormatShare();
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(1);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $path->method('getStorage')->willReturn($storage);
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($path);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(true);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('createShare')->with(
+            $this->callback(function (IShare $share) use ($path) {
+                return $share->getNode() === $path &&
+                    $share->getShareType() === IShare::TYPE_LINK &&
+                    $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
+                    $share->getSharedBy() === 'currentUser' &&
+                    $share->getPassword() === null &&
+                    $share->getExpirationDate() === null;
+            })
+        )->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true', '', null, '');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testCreateShareLinkPassword(): void {
+        $ocs = $this->mockFormatShare();
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(42);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $path->method('getStorage')->willReturn($storage);
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($path);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(true);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('createShare')->with(
+            $this->callback(function (IShare $share) use ($path) {
+                return $share->getNode() === $path
+                && $share->getShareType() === IShare::TYPE_LINK
+                && $share->getPermissions() === Constants::PERMISSION_READ // publicUpload was set to false
+                && $share->getSharedBy() === 'currentUser'
+                && $share->getPassword() === 'password'
+                && $share->getExpirationDate() === null;
+            })
+        )->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', Constants::PERMISSION_READ, IShare::TYPE_LINK, null, 'false', 'password', null, '');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testCreateShareLinkSendPasswordByTalk(): void {
+        $ocs = $this->mockFormatShare();
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(42);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $path->method('getStorage')->willReturn($storage);
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($path);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(true);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('createShare')->with(
+            $this->callback(function (IShare $share) use ($path) {
+                return $share->getNode() === $path &&
+                $share->getShareType() === IShare::TYPE_LINK &&
+                $share->getPermissions() === (Constants::PERMISSION_ALL & ~(Constants::PERMISSION_SHARE)) &&
+                $share->getSharedBy() === 'currentUser' &&
+                $share->getPassword() === 'password' &&
+                $share->getSendPasswordByTalk() === true &&
+                $share->getExpirationDate() === null;
+            })
+        )->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'true', 'password', 'true', '');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+
+    public function testCreateShareLinkSendPasswordByTalkWithTalkDisabled(): void {
+        $this->expectException(OCSForbiddenException::class);
+        $this->expectExceptionMessage('Sharing valid-path sending the password by Nextcloud Talk failed because Nextcloud Talk is not enabled');
+
+        $ocs = $this->mockFormatShare();
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(42);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $path->method('getStorage')->willReturn($storage);
+        $path->method('getPath')->willReturn('valid-path');
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($path);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(true);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(false);
+
+        $this->shareManager->expects($this->never())->method('createShare');
+
+        $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', 'password', 'true', '');
+    }
+
+    public function testCreateShareValidExpireDate(): void {
+        $ocs = $this->mockFormatShare();
+
+        $this->request
+            ->method('getParam')
+            ->willReturnMap([
+                ['path', null, 'valid-path'],
+                ['shareType', '-1', IShare::TYPE_LINK],
+                ['publicUpload', null, 'false'],
+                ['expireDate', '', '2000-01-01'],
+                ['password', '', ''],
+            ]);
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(42);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $path->method('getStorage')->willReturn($storage);
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($path);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(true);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('createShare')->with(
+            $this->callback(function (IShare $share) use ($path) {
+                $date = new \DateTime('2000-01-01');
+                $date->setTime(0, 0, 0);
+
+                return $share->getNode() === $path &&
+                $share->getShareType() === IShare::TYPE_LINK &&
+                $share->getPermissions() === Constants::PERMISSION_READ | Constants::PERMISSION_SHARE &&
+                $share->getSharedBy() === 'currentUser' &&
+                $share->getPassword() === null &&
+                $share->getExpirationDate() == $date;
+            })
+        )->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', null, IShare::TYPE_LINK, null, 'false', '', null, '2000-01-01');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+
+    public function testCreateShareInvalidExpireDate(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Invalid date. Format must be YYYY-MM-DD');
+
+        $ocs = $this->mockFormatShare();
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(42);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $path->method('getStorage')->willReturn($storage);
+        $this->rootFolder->method('getUserFolder')->with($this->currentUser)->willReturnSelf();
+        $this->rootFolder->method('get')->with('valid-path')->willReturn($path);
+        $this->rootFolder->method('getById')
+            ->willReturn([]);
+
+        $this->shareManager->method('newShare')->willReturn(Server::get(IManager::class)->newShare());
+        $this->shareManager->method('shareApiAllowLinks')->willReturn(true);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_LINK, null, 'false', '', null, 'a1b2d3');
+    }
+
+    public function testCreateShareRemote(): void {
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        /** @var ShareAPIController $ocs */
+        $ocs = $this->getMockBuilder(ShareAPIController::class)
+            ->setConstructorArgs([
+                $this->appName,
+                $this->request,
+                $this->shareManager,
+                $this->groupManager,
+                $this->userManager,
+                $this->rootFolder,
+                $this->urlGenerator,
+                $this->l,
+                $this->config,
+                $this->appManager,
+                $this->serverContainer,
+                $this->userStatusManager,
+                $this->previewManager,
+                $this->dateTimeZone,
+                $this->logger,
+                $this->factory,
+                $this->mailer,
+                $this->tagManager,
+                $this->currentUser,
+            ])->onlyMethods(['formatShare'])
+            ->getMock();
+
+        [$userFolder, $path] = $this->getNonSharedUserFile();
+        $this->rootFolder->expects($this->exactly(2))
+            ->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $this->userManager->method('userExists')->with('validUser')->willReturn(true);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('createShare')
+            ->with($this->callback(function (IShare $share) use ($path) {
+                return $share->getNode() === $path &&
+                    $share->getPermissions() === (
+                        Constants::PERMISSION_ALL &
+                        ~Constants::PERMISSION_DELETE &
+                        ~Constants::PERMISSION_CREATE
+                    ) &&
+                    $share->getShareType() === IShare::TYPE_REMOTE &&
+                    $share->getSharedWith() === 'user@example.org' &&
+                    $share->getSharedBy() === 'currentUser';
+            }))
+            ->willReturnArgument(0);
+
+        $this->shareManager->method('outgoingServer2ServerSharesAllowed')->willReturn(true);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_REMOTE, 'user@example.org');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testCreateShareRemoteGroup(): void {
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        /** @var ShareAPIController $ocs */
+        $ocs = $this->getMockBuilder(ShareAPIController::class)
+            ->setConstructorArgs([
+                $this->appName,
+                $this->request,
+                $this->shareManager,
+                $this->groupManager,
+                $this->userManager,
+                $this->rootFolder,
+                $this->urlGenerator,
+                $this->l,
+                $this->config,
+                $this->appManager,
+                $this->serverContainer,
+                $this->userStatusManager,
+                $this->previewManager,
+                $this->dateTimeZone,
+                $this->logger,
+                $this->factory,
+                $this->mailer,
+                $this->tagManager,
+                $this->currentUser,
+            ])->onlyMethods(['formatShare'])
+            ->getMock();
+
+        [$userFolder, $path] = $this->getNonSharedUserFile();
+        $this->rootFolder->expects($this->exactly(2))
+            ->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $this->userManager->method('userExists')->with('validUser')->willReturn(true);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('createShare')
+            ->with($this->callback(function (IShare $share) use ($path) {
+                return $share->getNode() === $path &&
+                    $share->getPermissions() === (
+                        Constants::PERMISSION_ALL &
+                        ~Constants::PERMISSION_DELETE &
+                        ~Constants::PERMISSION_CREATE
+                    ) &&
+                    $share->getShareType() === IShare::TYPE_REMOTE_GROUP &&
+                    $share->getSharedWith() === 'group@example.org' &&
+                    $share->getSharedBy() === 'currentUser';
+            }))
+            ->willReturnArgument(0);
+
+        $this->shareManager->method('outgoingServer2ServerGroupSharesAllowed')->willReturn(true);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_REMOTE_GROUP, 'group@example.org');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testCreateShareRoom(): void {
+        $ocs = $this->mockFormatShare();
+
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        [$userFolder, $path] = $this->getNonSharedUserFile();
+        $this->rootFolder->expects($this->exactly(2))
+            ->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->appManager->method('isEnabledForUser')
+            ->with('spreed')
+            ->willReturn(true);
+
+        // This is not possible anymore with PHPUnit 10+
+        // as `setMethods` was removed and now real reflection is used, thus the class needs to exist.
+        // $helper = $this->getMockBuilder('\OCA\Talk\Share\Helper\ShareAPIController')
+        $helper = $this->getMockBuilder(\stdClass::class)
+            ->addMethods(['createShare'])
+            ->getMock();
+        $helper->method('createShare')
+            ->with(
+                $share,
+                'recipientRoom',
+                Constants::PERMISSION_ALL &
+                ~Constants::PERMISSION_DELETE &
+                ~Constants::PERMISSION_CREATE,
+                ''
+            )->willReturnCallback(
+                function ($share): void {
+                    $share->setSharedWith('recipientRoom');
+                    $share->setPermissions(Constants::PERMISSION_ALL);
+                }
+            );
+
+        $this->serverContainer->method('get')
+            ->with('\OCA\Talk\Share\Helper\ShareAPIController')
+            ->willReturn($helper);
+
+        $this->shareManager->method('createShare')
+            ->with($this->callback(function (IShare $share) use ($path) {
+                return $share->getNode() === $path
+                    && $share->getPermissions() === Constants::PERMISSION_ALL
+                    && $share->getShareType() === IShare::TYPE_ROOM
+                    && $share->getSharedWith() === 'recipientRoom'
+                    && $share->getSharedBy() === 'currentUser';
+            }))
+            ->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_ROOM, 'recipientRoom');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+
+    public function testCreateShareRoomHelperNotAvailable(): void {
+        $this->expectException(OCSForbiddenException::class);
+        $this->expectExceptionMessage('Sharing valid-path failed because the back end does not support room shares');
+
+        $ocs = $this->mockFormatShare();
+
+        $share = $this->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        [$userFolder, $path] = $this->getNonSharedUserFolder();
+        $this->rootFolder->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $path->method('getPath')->willReturn('valid-path');
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->appManager->method('isEnabledForUser')
+            ->with('spreed')
+            ->willReturn(false);
+
+        $this->shareManager->expects($this->never())->method('createShare');
+
+        $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_ROOM, 'recipientRoom');
+    }
+
+
+    public function testCreateShareRoomHelperThrowException(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Exception thrown by the helper');
+
+        $ocs = $this->mockFormatShare();
+
+        $share = $this->newShare();
+        $share->setSharedBy('currentUser');
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        [$userFolder, $path] = $this->getNonSharedUserFile();
+        $this->rootFolder->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $path->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->appManager->method('isEnabledForUser')
+            ->with('spreed')
+            ->willReturn(true);
+
+        // This is not possible anymore with PHPUnit 10+
+        // as `setMethods` was removed and now real reflection is used, thus the class needs to exist.
+        // $helper = $this->getMockBuilder('\OCA\Talk\Share\Helper\ShareAPIController')
+        $helper = $this->getMockBuilder(\stdClass::class)
+            ->addMethods(['createShare'])
+            ->getMock();
+        $helper->method('createShare')
+            ->with(
+                $share,
+                'recipientRoom',
+                Constants::PERMISSION_ALL & ~(Constants::PERMISSION_CREATE | Constants::PERMISSION_DELETE),
+                ''
+            )->willReturnCallback(
+                function ($share): void {
+                    throw new OCSNotFoundException('Exception thrown by the helper');
+                }
+            );
+
+        $this->serverContainer->method('get')
+            ->with('\OCA\Talk\Share\Helper\ShareAPIController')
+            ->willReturn($helper);
+
+        $this->shareManager->expects($this->never())->method('createShare');
+
+        $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_ROOM, 'recipientRoom');
+    }
+
+    /**
+     * Test for https://github.com/owncloud/core/issues/22587
+     * TODO: Remove once proper solution is in place
+     */
+    public function testCreateReshareOfFederatedMountNoDeletePermissions(): void {
+        $share = Server::get(IManager::class)->newShare();
+        $this->shareManager->method('newShare')->willReturn($share);
+
+        /** @var ShareAPIController&MockObject $ocs */
+        $ocs = $this->getMockBuilder(ShareAPIController::class)
+            ->setConstructorArgs([
+                $this->appName,
+                $this->request,
+                $this->shareManager,
+                $this->groupManager,
+                $this->userManager,
+                $this->rootFolder,
+                $this->urlGenerator,
+                $this->l,
+                $this->config,
+                $this->appManager,
+                $this->serverContainer,
+                $this->userStatusManager,
+                $this->previewManager,
+                $this->dateTimeZone,
+                $this->logger,
+                $this->factory,
+                $this->mailer,
+                $this->tagManager,
+                $this->currentUser,
+            ])->onlyMethods(['formatShare'])
+            ->getMock();
+
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $this->rootFolder->expects($this->exactly(2))
+            ->method('getUserFolder')
+            ->with('currentUser')
+            ->willReturn($userFolder);
+
+        $path = $this->getMockBuilder(Folder::class)->getMock();
+        $path->method('getId')->willReturn(42);
+
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', true],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $userFolder->method('getStorage')->willReturn($storage);
+        $path->method('getStorage')->willReturn($storage);
+
+        $path->method('getPermissions')->willReturn(Constants::PERMISSION_READ);
+        $userFolder->expects($this->once())
+            ->method('get')
+            ->with('valid-path')
+            ->willReturn($path);
+        $userFolder->method('getById')
+            ->willReturn([]);
+
+        $this->userManager->method('userExists')->with('validUser')->willReturn(true);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('createShare')
+            ->with($this->callback(function (IShare $share) {
+                return $share->getPermissions() === Constants::PERMISSION_READ;
+            }))
+            ->willReturnArgument(0);
+
+        $ocs->createShare('valid-path', Constants::PERMISSION_ALL, IShare::TYPE_USER, 'validUser');
+    }
+
+
+    public function testUpdateShareCantAccess(): void {
+        $this->expectException(OCSNotFoundException::class);
+        $this->expectExceptionMessage('Wrong share ID, share does not exist');
+
+        [$userFolder, $node] = $this->getNonSharedUserFolder();
+        $share = $this->newShare();
+        $share->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with($share->getNodeId())
+            ->willReturn([$share->getNode()]);
+
+        $this->ocs->updateShare(42);
+    }
+
+
+    public function testUpdateNoParametersLink(): void {
+        $this->expectException(OCSBadRequestException::class);
+        $this->expectExceptionMessage('Wrong or no update parameter given');
+
+        $node = $this->getMockBuilder(Folder::class)->getMock();
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->ocs->updateShare(42);
+    }
+
+
+    public function testUpdateNoParametersOther(): void {
+        $this->expectException(OCSBadRequestException::class);
+        $this->expectExceptionMessage('Wrong or no update parameter given');
+
+        $node = $this->getMockBuilder(Folder::class)->getMock();
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_GROUP)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->ocs->updateShare(42);
+    }
+
+    public function testUpdateLinkShareClear(): void {
+        $ocs = $this->mockFormatShare();
+
+        [$userFolder, $node] = $this->getNonSharedUserFolder();
+        $node->method('getId')
+            ->willReturn(42);
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setExpirationDate(new \DateTime())
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) {
+                return $share->getPermissions() === Constants::PERMISSION_READ &&
+                $share->getPassword() === null &&
+                $share->getExpirationDate() === null &&
+                // Once set a note or a label are never back to null, only to an
+                // empty string.
+                $share->getNote() === '' &&
+                $share->getLabel() === '' &&
+                $share->getHideDownload() === false;
+            })
+        )->willReturnArgument(0);
+
+        $this->shareManager->method('getSharedWith')
+            ->willReturn([]);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$node]);
+        $userFolder->method('getFirstNodeById')
+            ->with(42)
+            ->willReturn($node);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $node->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, null, '', null, 'false', '', '', '', 'false');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateLinkShareSet(): void {
+        $ocs = $this->mockFormatShare();
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) {
+                $date = new \DateTime('2000-01-01');
+                $date->setTime(0, 0, 0);
+
+                return $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
+                $share->getPassword() === 'password' &&
+                $share->getExpirationDate() == $date &&
+                $share->getNote() === 'note' &&
+                $share->getLabel() === 'label' &&
+                $share->getHideDownload() === true;
+            })
+        )->willReturnArgument(0);
+
+        $this->shareManager->method('getSharedWith')
+            ->willReturn([]);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $folder->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, null, 'password', null, 'true', '2000-01-01', 'note', 'label', 'true');
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    /**
+     * @dataProvider publicUploadParamsProvider
+     */
+    public function testUpdateLinkShareEnablePublicUpload($permissions, $publicUpload, $expireDate, $password): void {
+        $ocs = $this->mockFormatShare();
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+        $this->shareManager->method('getSharedWith')->willReturn([]);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) {
+                return $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
+                $share->getPassword() === 'password' &&
+                $share->getExpirationDate() === null;
+            })
+        )->willReturnArgument(0);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $folder->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, $permissions, $password, null, $publicUpload, $expireDate);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+
+    public function publicLinkValidPermissionsProvider() {
+        return [
+            [Constants::PERMISSION_CREATE],
+            [Constants::PERMISSION_READ],
+            [Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE],
+            [Constants::PERMISSION_READ | Constants::PERMISSION_DELETE],
+            [Constants::PERMISSION_READ | Constants::PERMISSION_CREATE],
+        ];
+    }
+
+    /**
+     * @dataProvider publicLinkValidPermissionsProvider
+     */
+    public function testUpdateLinkShareSetCRUDPermissions($permissions): void {
+        $ocs = $this->mockFormatShare();
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+        $this->shareManager->method('getSharedWith')->willReturn([]);
+
+        $this->shareManager
+            ->expects($this->any())
+            ->method('updateShare')
+            ->willReturnArgument(0);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $folder->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, $permissions, 'password', null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function publicLinkInvalidPermissionsProvider1() {
+        return [
+            [Constants::PERMISSION_DELETE],
+            [Constants::PERMISSION_UPDATE],
+            [Constants::PERMISSION_SHARE],
+        ];
+    }
+
+    /**
+     * @dataProvider publicLinkInvalidPermissionsProvider1
+     */
+    public function testUpdateLinkShareSetInvalidCRUDPermissions1($permissions): void {
+        $this->expectException(OCSBadRequestException::class);
+        $this->expectExceptionMessage('Share must at least have READ or CREATE permissions');
+
+        $this->testUpdateLinkShareSetCRUDPermissions($permissions, null);
+    }
+
+    public function publicLinkInvalidPermissionsProvider2() {
+        return [
+            [Constants::PERMISSION_CREATE | Constants::PERMISSION_DELETE],
+            [Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE],
+        ];
+    }
+
+    /**
+     * @dataProvider publicLinkInvalidPermissionsProvider2
+     */
+    public function testUpdateLinkShareSetInvalidCRUDPermissions2($permissions): void {
+        $this->expectException(OCSBadRequestException::class);
+        $this->expectExceptionMessage('Share must have READ permission if UPDATE or DELETE permission is set');
+
+        $this->testUpdateLinkShareSetCRUDPermissions($permissions);
+    }
+
+    public function testUpdateLinkShareInvalidDate(): void {
+        $this->expectException(OCSBadRequestException::class);
+        $this->expectExceptionMessage('Invalid date. Format must be YYYY-MM-DD');
+
+        $ocs = $this->mockFormatShare();
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $ocs->updateShare(42, null, 'password', null, 'true', '2000-01-a');
+    }
+
+    public function publicUploadParamsProvider() {
+        return [
+            [null, 'true', null, 'password'],
+            // legacy had no delete
+            [
+                Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE,
+                'true', null, 'password'
+            ],
+            // correct
+            [
+                Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE,
+                null, null, 'password'
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider publicUploadParamsProvider
+     */
+    public function testUpdateLinkSharePublicUploadNotAllowed($permissions, $publicUpload, $expireDate, $password): void {
+        $this->expectException(OCSForbiddenException::class);
+        $this->expectExceptionMessage('Public upload disabled by the administrator');
+
+        $ocs = $this->mockFormatShare();
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $folder->method('getId')->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(false);
+
+        $ocs->updateShare(42, $permissions, $password, null, $publicUpload, $expireDate);
+    }
+
+
+    public function testUpdateLinkSharePublicUploadOnFile(): void {
+        $this->expectException(OCSBadRequestException::class);
+        $this->expectExceptionMessage('Public upload is only possible for publicly shared folders');
+
+        $ocs = $this->mockFormatShare();
+
+        $file = $this->getMockBuilder(File::class)->getMock();
+        $file->method('getId')
+            ->willReturn(42);
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setNode($file);
+
+        $this->shareManager
+            ->method('getShareById')
+            ->with('ocinternal:42')
+            ->willReturn($share);
+        $this->shareManager
+            ->method('shareApiLinkAllowPublicUpload')
+            ->willReturn(true);
+        $this->shareManager
+            ->method('updateShare')
+            ->with($share)
+            ->willThrowException(new \InvalidArgumentException('File shares cannot have create or delete permissions'));
+
+        $ocs->updateShare(42, null, 'password', null, 'true', '');
+    }
+
+    public function testUpdateLinkSharePasswordDoesNotChangeOther(): void {
+        $ocs = $this->mockFormatShare();
+
+        $date = new \DateTime('2000-01-01');
+        $date->setTime(0, 0, 0);
+
+        [$userFolder, $node] = $this->getNonSharedUserFolder();
+        $node->method('getId')->willReturn(42);
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$node]);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($date)
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) use ($date) {
+                return $share->getPermissions() === Constants::PERMISSION_ALL &&
+                $share->getPassword() === 'newpassword' &&
+                $share->getSendPasswordByTalk() === true &&
+                $share->getExpirationDate() === $date &&
+                $share->getNote() === 'note' &&
+                $share->getLabel() === 'label' &&
+                $share->getHideDownload() === true;
+            })
+        )->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, null, 'newpassword', null, null, null, null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateLinkShareSendPasswordByTalkDoesNotChangeOther(): void {
+        $ocs = $this->mockFormatShare();
+
+        $date = new \DateTime('2000-01-01');
+        $date->setTime(0, 0, 0);
+
+        [$userFolder, $node] = $this->getNonSharedUserFolder();
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$node]);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+        $node->method('getId')->willReturn(42);
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(false)
+            ->setExpirationDate($date)
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) use ($date) {
+                return $share->getPermissions() === Constants::PERMISSION_ALL &&
+                $share->getPassword() === 'password' &&
+                $share->getSendPasswordByTalk() === true &&
+                $share->getExpirationDate() === $date &&
+                $share->getNote() === 'note' &&
+                $share->getLabel() === 'label' &&
+                $share->getHideDownload() === true;
+            })
+        )->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, null, null, 'true', null, null, null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+
+    public function testUpdateLinkShareSendPasswordByTalkWithTalkDisabledDoesNotChangeOther(): void {
+        $this->expectException(OCSForbiddenException::class);
+        $this->expectExceptionMessage('"Sending the password by Nextcloud Talk" for sharing a file or folder failed because Nextcloud Talk is not enabled.');
+
+        $ocs = $this->mockFormatShare();
+
+        $date = new \DateTime('2000-01-01');
+        $date->setTime(0, 0, 0);
+
+        [$userFolder, $node] = $this->getNonSharedUserFolder();
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$node]);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+        $node->method('getId')->willReturn(42);
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(false)
+            ->setExpirationDate($date)
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(false);
+
+        $this->shareManager->expects($this->never())->method('updateShare');
+
+        $ocs->updateShare(42, null, null, 'true', null, null, null, null, null);
+    }
+
+    public function testUpdateLinkShareDoNotSendPasswordByTalkDoesNotChangeOther(): void {
+        $ocs = $this->mockFormatShare();
+
+        $date = new \DateTime('2000-01-01');
+        $date->setTime(0, 0, 0);
+
+        [$userFolder, $node] = $this->getNonSharedUserFolder();
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$node]);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+        $node->method('getId')->willReturn(42);
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($date)
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) use ($date) {
+                return $share->getPermissions() === Constants::PERMISSION_ALL &&
+                $share->getPassword() === 'password' &&
+                $share->getSendPasswordByTalk() === false &&
+                $share->getExpirationDate() === $date &&
+                $share->getNote() === 'note' &&
+                $share->getLabel() === 'label' &&
+                $share->getHideDownload() === true;
+            })
+        )->willReturnArgument(0);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, null, null, 'false', null, null, null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateLinkShareDoNotSendPasswordByTalkWithTalkDisabledDoesNotChangeOther(): void {
+        $ocs = $this->mockFormatShare();
+
+        $date = new \DateTime('2000-01-01');
+        $date->setTime(0, 0, 0);
+
+        [$userFolder, $node] = $this->getNonSharedUserFolder();
+        $node->method('getId')
+            ->willReturn(42);
+
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($date)
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->appManager->method('isEnabledForUser')->with('spreed')->willReturn(false);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) use ($date) {
+                return $share->getPermissions() === Constants::PERMISSION_ALL &&
+                $share->getPassword() === 'password' &&
+                $share->getSendPasswordByTalk() === false &&
+                $share->getExpirationDate() === $date &&
+                $share->getNote() === 'note' &&
+                $share->getLabel() === 'label' &&
+                $share->getHideDownload() === true;
+            })
+        )->willReturnArgument(0);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$node]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $node->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $node->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, null, null, 'false', null, null, null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateLinkShareExpireDateDoesNotChangeOther(): void {
+        $ocs = $this->mockFormatShare();
+
+        [$userFolder, $node] = $this->getNonSharedUserFolder();
+        $node->method('getId')
+            ->willReturn(42);
+
+        $share = $this->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate(new \DateTime())
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($node);
+
+        $node->expects($this->once())
+            ->method('lock')
+            ->with(ILockingProvider::LOCK_SHARED);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) {
+                $date = new \DateTime('2010-12-23');
+                $date->setTime(0, 0, 0);
+
+                return $share->getPermissions() === Constants::PERMISSION_ALL &&
+                $share->getPassword() === 'password' &&
+                $share->getSendPasswordByTalk() === true &&
+                $share->getExpirationDate() == $date &&
+                $share->getNote() === 'note' &&
+                $share->getLabel() === 'label' &&
+                $share->getHideDownload() === true;
+            })
+        )->willReturnArgument(0);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$node]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $node->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, null, null, null, null, '2010-12-23', null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateLinkSharePublicUploadDoesNotChangeOther(): void {
+        $ocs = $this->mockFormatShare();
+
+        $date = new \DateTime('2000-01-01');
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($date)
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) use ($date) {
+                return $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
+                $share->getPassword() === 'password' &&
+                $share->getSendPasswordByTalk() === true &&
+                $share->getExpirationDate() === $date &&
+                $share->getNote() === 'note' &&
+                $share->getLabel() === 'label' &&
+                $share->getHideDownload() === true;
+            })
+        )->willReturnArgument(0);
+
+        $this->shareManager->method('getSharedWith')
+            ->willReturn([]);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $folder->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, null, null, null, 'true', null, null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateLinkSharePermissions(): void {
+        $ocs = $this->mockFormatShare();
+
+        $date = new \DateTime('2000-01-01');
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($date)
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_ALL)
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) use ($date): bool {
+                return $share->getPermissions() === (Constants::PERMISSION_READ | Constants::PERMISSION_CREATE | Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE) &&
+                $share->getPassword() === 'password' &&
+                $share->getSendPasswordByTalk() === true &&
+                $share->getExpirationDate() === $date &&
+                $share->getNote() === 'note' &&
+                $share->getLabel() === 'label' &&
+                $share->getHideDownload() === true;
+            })
+        )->willReturnArgument(0);
+
+        $this->shareManager->method('getSharedWith')->willReturn([]);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $folder->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, 7, null, null, 'true', null, null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateLinkSharePermissionsShare(): void {
+        $ocs = $this->mockFormatShare();
+
+        $date = new \DateTime('2000-01-01');
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_LINK)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate($date)
+            ->setNote('note')
+            ->setLabel('label')
+            ->setHideDownload(true)
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->shareManager->expects($this->once())
+            ->method('updateShare')
+            ->with(
+                $this->callback(function (IShare $share) use ($date) {
+                    return $share->getPermissions() === Constants::PERMISSION_ALL &&
+                        $share->getPassword() === 'password' &&
+                        $share->getSendPasswordByTalk() === true &&
+                        $share->getExpirationDate() === $date &&
+                        $share->getNote() === 'note' &&
+                        $share->getLabel() === 'label' &&
+                        $share->getHideDownload() === true;
+                })
+            )->willReturnArgument(0);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $folder->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $this->shareManager->method('getSharedWith')->willReturn([]);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, Constants::PERMISSION_ALL, null, null, null, null, null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateOtherPermissions(): void {
+        $ocs = $this->mockFormatShare();
+
+        [$userFolder, $file] = $this->getNonSharedUserFolder();
+        $file->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setPermissions(Constants::PERMISSION_ALL)
+            ->setSharedBy($this->currentUser)
+            ->setShareType(IShare::TYPE_USER)
+            ->setNode($file);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+        $this->shareManager->method('shareApiLinkAllowPublicUpload')->willReturn(true);
+
+        $this->shareManager->expects($this->once())->method('updateShare')->with(
+            $this->callback(function (IShare $share) {
+                return $share->getPermissions() === Constants::PERMISSION_ALL;
+            })
+        )->willReturnArgument(0);
+
+        $this->shareManager->method('getSharedWith')->willReturn([]);
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$file]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $file->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $expected = new DataResponse([]);
+        $result = $ocs->updateShare(42, 31, null, null, null, null);
+
+        $this->assertInstanceOf(get_class($expected), $result);
+        $this->assertEquals($expected->getData(), $result->getData());
+    }
+
+    public function testUpdateShareCannotIncreasePermissions(): void {
+        $ocs = $this->mockFormatShare();
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share
+            ->setId(42)
+            ->setSharedBy($this->currentUser)
+            ->setShareOwner('anotheruser')
+            ->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('group1')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder);
+
+        // note: updateShare will modify the received instance but getSharedWith will reread from the database,
+        // so their values will be different
+        $incomingShare = Server::get(IManager::class)->newShare();
+        $incomingShare
+            ->setId(42)
+            ->setSharedBy($this->currentUser)
+            ->setShareOwner('anotheruser')
+            ->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('group1')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder);
+
+        $this->request
+            ->method('getParam')
+            ->willReturnMap([
+                ['permissions', null, '31'],
+            ]);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->shareManager->expects($this->any())
+            ->method('getSharedWith')
+            ->willReturnMap([
+                ['currentUser', IShare::TYPE_USER, $share->getNode(), -1, 0, []],
+                ['currentUser', IShare::TYPE_GROUP, $share->getNode(), -1, 0, [$incomingShare]],
+                ['currentUser', IShare::TYPE_ROOM, $share->getNode(), -1, 0, []]
+            ]);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+        $userFolder->method('getFirstNodeById')
+            ->with(42)
+            ->willReturn($folder);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $folder->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $this->shareManager->expects($this->once())
+            ->method('updateShare')
+            ->with($share)
+            ->willThrowException(new GenericShareException('Cannot increase permissions of path/file', 'Cannot increase permissions of path/file', 404));
+
+        try {
+            $ocs->updateShare(42, 31);
+            $this->fail();
+        } catch (OCSException $e) {
+            $this->assertEquals('Cannot increase permissions of path/file', $e->getMessage());
+        }
+    }
+
+    public function testUpdateShareCanIncreasePermissionsIfOwner(): void {
+        $ocs = $this->mockFormatShare();
+
+        [$userFolder, $folder] = $this->getNonSharedUserFolder();
+        $folder->method('getId')
+            ->willReturn(42);
+
+        $share = Server::get(IManager::class)->newShare();
+        $share
+            ->setId(42)
+            ->setSharedBy($this->currentUser)
+            ->setShareOwner($this->currentUser)
+            ->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('group1')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder);
+
+        // note: updateShare will modify the received instance but getSharedWith will reread from the database,
+        // so their values will be different
+        $incomingShare = Server::get(IManager::class)->newShare();
+        $incomingShare
+            ->setId(42)
+            ->setSharedBy($this->currentUser)
+            ->setShareOwner($this->currentUser)
+            ->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('group1')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder);
+
+        $this->shareManager->method('getShareById')->with('ocinternal:42')->willReturn($share);
+
+        $this->shareManager->expects($this->any())
+            ->method('getSharedWith')
+            ->willReturnMap([
+                ['currentUser', IShare::TYPE_USER, $share->getNode(), -1, 0, []],
+                ['currentUser', IShare::TYPE_GROUP, $share->getNode(), -1, 0, [$incomingShare]]
+            ]);
+
+        $this->shareManager->expects($this->once())
+            ->method('updateShare')
+            ->with($share)
+            ->willReturn($share);
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $userFolder->method('getById')
+            ->with(42)
+            ->willReturn([$folder]);
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $folder->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mountPoint->method('getStorageRootId')
+            ->willReturn(42);
+
+        $result = $ocs->updateShare(42, 31);
+        $this->assertInstanceOf(DataResponse::class, $result);
+    }
+
+    public function testUpdateShareOwnerless(): void {
+        $ocs = $this->mockFormatShare();
+
+        $mount = $this->createMock(IShareOwnerlessMount::class);
+
+        $file = $this->createMock(File::class);
+        $file
+            ->expects($this->exactly(2))
+            ->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_SHARE);
+        $file
+            ->expects($this->once())
+            ->method('getMountPoint')
+            ->willReturn($mount);
+
+        $userFolder = $this->createMock(Folder::class);
+        $userFolder->method('getById')
+            ->with(2)
+            ->willReturn([$file]);
+        $userFolder->method('getFirstNodeById')
+            ->with(2)
+            ->willReturn($file);
+
+        $this->rootFolder
+            ->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturn($userFolder);
+
+        $share = $this->createMock(IShare::class);
+        $share
+            ->expects($this->once())
+            ->method('getNode')
+            ->willReturn($file);
+        $share
+            ->expects($this->exactly(2))
+            ->method('getNodeId')
+            ->willReturn(2);
+        $share
+            ->expects($this->exactly(2))
+            ->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_SHARE);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('getShareById')
+            ->with('ocinternal:1', $this->currentUser)
+            ->willReturn($share);
+
+        $this->shareManager
+            ->expects($this->once())
+            ->method('updateShare')
+            ->with($share)
+            ->willReturn($share);
+
+        $result = $ocs->updateShare(1, Constants::PERMISSION_ALL);
+        $this->assertInstanceOf(DataResponse::class, $result);
+    }
+
+    public function dataFormatShare() {
+        $file = $this->getMockBuilder(File::class)->getMock();
+        $folder = $this->getMockBuilder(Folder::class)->getMock();
+        $parent = $this->getMockBuilder(Folder::class)->getMock();
+        $fileWithPreview = $this->getMockBuilder(File::class)->getMock();
+
+        $file->method('getMimeType')->willReturn('myMimeType');
+        $folder->method('getMimeType')->willReturn('myFolderMimeType');
+        $fileWithPreview->method('getMimeType')->willReturn('mimeWithPreview');
+
+        $mountPoint = $this->createMock(IMountPoint::class);
+        $mountPoint->method('getMountType')->willReturn('');
+        $file->method('getMountPoint')->willReturn($mountPoint);
+        $folder->method('getMountPoint')->willReturn($mountPoint);
+        $fileWithPreview->method('getMountPoint')->willReturn($mountPoint);
+
+        $file->method('getPath')->willReturn('file');
+        $folder->method('getPath')->willReturn('folder');
+        $fileWithPreview->method('getPath')->willReturn('fileWithPreview');
+
+        $parent->method('getId')->willReturn(1);
+        $folder->method('getId')->willReturn(2);
+        $file->method('getId')->willReturn(3);
+        $fileWithPreview->method('getId')->willReturn(4);
+
+        $file->method('getParent')->willReturn($parent);
+        $folder->method('getParent')->willReturn($parent);
+        $fileWithPreview->method('getParent')->willReturn($parent);
+
+        $file->method('getSize')->willReturn(123456);
+        $folder->method('getSize')->willReturn(123456);
+        $fileWithPreview->method('getSize')->willReturn(123456);
+        $file->method('getMTime')->willReturn(1234567890);
+        $folder->method('getMTime')->willReturn(1234567890);
+        $fileWithPreview->method('getMTime')->willReturn(1234567890);
+
+        $cache = $this->getMockBuilder('OCP\Files\Cache\ICache')->getMock();
+        $cache->method('getNumericStorageId')->willReturn(100);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('getId')->willReturn('storageId');
+        $storage->method('getCache')->willReturn($cache);
+
+        $file->method('getStorage')->willReturn($storage);
+        $folder->method('getStorage')->willReturn($storage);
+        $fileWithPreview->method('getStorage')->willReturn($storage);
+
+
+        $mountPoint = $this->getMockBuilder(IMountPoint::class)->getMock();
+        $mountPoint->method('getMountType')->willReturn('');
+        $file->method('getMountPoint')->willReturn($mountPoint);
+        $folder->method('getMountPoint')->willReturn($mountPoint);
+
+        $owner = $this->getMockBuilder(IUser::class)->getMock();
+        $owner->method('getDisplayName')->willReturn('ownerDN');
+        $initiator = $this->getMockBuilder(IUser::class)->getMock();
+        $initiator->method('getDisplayName')->willReturn('initiatorDN');
+        $recipient = $this->getMockBuilder(IUser::class)->getMock();
+        $recipient->method('getDisplayName')->willReturn('recipientDN');
+        $recipient->method('getSystemEMailAddress')->willReturn('recipient');
+        [$shareAttributes, $shareAttributesReturnJson] = $this->mockShareAttributes();
+
+        $result = [];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setAttributes($shareAttributes)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+
+        // User backend down
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_USER,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'attributes' => $shareAttributesReturnJson,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipient',
+                'share_with_displayname' => 'recipient',
+                'share_with_displayname_unique' => 'recipient',
+                'note' => 'personal note',
+                'label' => '',
+                'mail_send' => 0,
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => '[{"scope":"permissions","key":"download","value":true}]',
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+        // User backend up
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_USER,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiatorDN',
+                'permissions' => 1,
+                'attributes' => $shareAttributesReturnJson,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'ownerDN',
+                'note' => 'personal note',
+                'label' => '',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipient',
+                'share_with_displayname' => 'recipientDN',
+                'share_with_displayname_unique' => 'recipient',
+                'mail_send' => 0,
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => '[{"scope":"permissions","key":"download","value":true}]',
+                'item_permissions' => 1,
+            ], $share, [
+                ['owner', $owner],
+                ['initiator', $initiator],
+                ['recipient', $recipient],
+            ], false
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+        // User backend down
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_USER,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'attributes' => null,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'label' => '',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipient',
+                'share_with_displayname' => 'recipient',
+                'share_with_displayname_unique' => 'recipient',
+                'mail_send' => 0,
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+        // User backend down
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_USER,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'attributes' => null,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'currentUser',
+                'displayname_file_owner' => 'currentUser',
+                'note' => 'personal note',
+                'label' => '',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipient',
+                'share_with_displayname' => 'recipient',
+                'share_with_displayname_unique' => 'recipient',
+                'mail_send' => 0,
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => true,
+                'can_delete' => true,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 11,
+            ], $share, [], false
+        ];
+
+        // with existing group
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('recipientGroup')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_GROUP,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'attributes' => null,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'label' => '',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipientGroup',
+                'share_with_displayname' => 'recipientGroupDisplayName',
+                'mail_send' => 0,
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        // with unknown group / no group backend
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_GROUP)
+            ->setSharedWith('recipientGroup2')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_GROUP,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'label' => '',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipientGroup2',
+                'share_with_displayname' => 'recipientGroup2',
+                'mail_send' => 0,
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_LINK)
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setPassword('mypassword')
+            ->setExpirationDate(new \DateTime('2001-01-02T00:00:00'))
+            ->setToken('myToken')
+            ->setNote('personal note')
+            ->setLabel('new link share')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_LINK,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'attributes' => null,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => '2001-01-02 00:00:00',
+                'token' => 'myToken',
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'label' => 'new link share',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'password' => 'mypassword',
+                'share_with' => 'mypassword',
+                'share_with_displayname' => '(Shared link)',
+                'send_password_by_talk' => false,
+                'mail_send' => 0,
+                'url' => 'myLink',
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_LINK)
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setPassword('mypassword')
+            ->setSendPasswordByTalk(true)
+            ->setExpirationDate(new \DateTime('2001-01-02T00:00:00'))
+            ->setToken('myToken')
+            ->setNote('personal note')
+            ->setLabel('new link share')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_LINK,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => '2001-01-02 00:00:00',
+                'token' => 'myToken',
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'label' => 'new link share',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'password' => 'mypassword',
+                'share_with' => 'mypassword',
+                'share_with_displayname' => '(Shared link)',
+                'send_password_by_talk' => true,
+                'mail_send' => 0,
+                'url' => 'myLink',
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_REMOTE)
+            ->setSharedBy('initiator')
+            ->setSharedWith('user@server.com')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setExpirationDate(new \DateTime('2001-02-03T04:05:06'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_REMOTE,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => '2001-02-03 00:00:00',
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'label' => '',
+                'path' => 'folder',
+                'item_type' => 'folder',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 2,
+                'file_source' => 2,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'user@server.com',
+                'share_with_displayname' => 'foobar',
+                'mail_send' => 0,
+                'mimetype' => 'myFolderMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_REMOTE_GROUP)
+            ->setSharedBy('initiator')
+            ->setSharedWith('user@server.com')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setExpirationDate(new \DateTime('2001-02-03T04:05:06'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_REMOTE_GROUP,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => '2001-02-03 00:00:00',
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'label' => '',
+                'path' => 'folder',
+                'item_type' => 'folder',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 2,
+                'file_source' => 2,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'user@server.com',
+                'share_with_displayname' => 'foobar',
+                'mail_send' => 0,
+                'mimetype' => 'myFolderMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        // Circle with id, display name and avatar set by the Circles app
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_CIRCLE)
+            ->setSharedBy('initiator')
+            ->setSharedWith('Circle (Public circle, circleOwner) [4815162342]')
+            ->setSharedWithDisplayName('The display name')
+            ->setSharedWithAvatar('path/to/the/avatar')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_CIRCLE,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'attributes' => null,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => '',
+                'label' => '',
+                'path' => 'folder',
+                'item_type' => 'folder',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 2,
+                'file_source' => 2,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => '4815162342',
+                'share_with_displayname' => 'The display name',
+                'share_with_avatar' => 'path/to/the/avatar',
+                'mail_send' => 0,
+                'mimetype' => 'myFolderMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        // Circle with id set by the Circles app
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_CIRCLE)
+            ->setSharedBy('initiator')
+            ->setSharedWith('Circle (Public circle, circleOwner) [4815162342]')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_CIRCLE,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => '',
+                'label' => '',
+                'path' => 'folder',
+                'item_type' => 'folder',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 2,
+                'file_source' => 2,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => '4815162342',
+                'share_with_displayname' => 'Circle (Public circle, circleOwner)',
+                'share_with_avatar' => '',
+                'mail_send' => 0,
+                'mimetype' => 'myFolderMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        // Circle with id not set by the Circles app
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_CIRCLE)
+            ->setSharedBy('initiator')
+            ->setSharedWith('Circle (Public circle, circleOwner)')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_CIRCLE,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => '',
+                'label' => '',
+                'path' => 'folder',
+                'item_type' => 'folder',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 2,
+                'file_source' => 2,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'Circle',
+                'share_with_displayname' => 'Circle (Public circle, circleOwner)',
+                'share_with_avatar' => '',
+                'mail_send' => 0,
+                'mimetype' => 'myFolderMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_USER)
+            ->setSharedBy('initiator')
+            ->setSharedWith('recipient')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+
+        $result[] = [
+            [], $share, [], true
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_EMAIL)
+            ->setSharedBy('initiator')
+            ->setSharedWith('user@server.com')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setId(42)
+            ->setPassword('password');
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_EMAIL,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => '',
+                'label' => '',
+                'path' => 'folder',
+                'item_type' => 'folder',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 2,
+                'file_source' => 2,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'user@server.com',
+                'share_with_displayname' => 'mail display name',
+                'mail_send' => 0,
+                'mimetype' => 'myFolderMimeType',
+                'has_preview' => false,
+                'password' => 'password',
+                'send_password_by_talk' => false,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'password_expiration_time' => null,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_EMAIL)
+            ->setSharedBy('initiator')
+            ->setSharedWith('user@server.com')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($folder)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setId(42)
+            ->setPassword('password')
+            ->setSendPasswordByTalk(true);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_EMAIL,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => '',
+                'label' => '',
+                'path' => 'folder',
+                'item_type' => 'folder',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 2,
+                'file_source' => 2,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'user@server.com',
+                'share_with_displayname' => 'mail display name',
+                'mail_send' => 0,
+                'mimetype' => 'myFolderMimeType',
+                'has_preview' => false,
+                'password' => 'password',
+                'send_password_by_talk' => true,
+                'hide_download' => 0,
+                'can_edit' => false,
+                'can_delete' => false,
+                'password_expiration_time' => null,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, [], false
+        ];
+
+        // Preview is available
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_USER)
+            ->setSharedWith('recipient')
+            ->setSharedBy('initiator')
+            ->setShareOwner('currentUser')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($fileWithPreview)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_USER,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'currentUser',
+                'displayname_file_owner' => 'currentUser',
+                'note' => 'personal note',
+                'label' => '',
+                'path' => 'fileWithPreview',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 4,
+                'file_source' => 4,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipient',
+                'share_with_displayname' => 'recipient',
+                'share_with_displayname_unique' => 'recipient',
+                'mail_send' => 0,
+                'mimetype' => 'mimeWithPreview',
+                'has_preview' => true,
+                'hide_download' => 0,
+                'can_edit' => true,
+                'can_delete' => true,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 11,
+            ], $share, [], false
+        ];
+
+        return $result;
+    }
+
+    /**
+     * @dataProvider dataFormatShare
+     *
+     * @param array $expects
+     * @param IShare $share
+     * @param array $users
+     * @param $exception
+     */
+    public function testFormatShare(array $expects, IShare $share, array $users, $exception): void {
+        $this->userManager->method('get')->willReturnMap($users);
+
+        $recipientGroup = $this->createMock(IGroup::class);
+        $recipientGroup->method('getDisplayName')->willReturn('recipientGroupDisplayName');
+        $this->groupManager->method('get')->willReturnMap([
+            ['recipientGroup', $recipientGroup],
+        ]);
+
+        $this->urlGenerator->method('linkToRouteAbsolute')
+            ->with('files_sharing.sharecontroller.showShare', ['token' => 'myToken'])
+            ->willReturn('myLink');
+
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturnSelf();
+        $this->dateTimeZone->method('getTimezone')->willReturn(new \DateTimeZone('UTC'));
+
+        if (!$exception) {
+            $this->rootFolder->method('getFirstNodeById')
+                ->with($share->getNodeId())
+                ->willReturn($share->getNode());
+
+            $this->rootFolder->method('getRelativePath')
+                ->with($share->getNode()->getPath())
+                ->willReturnArgument(0);
+        }
+
+        $cm = $this->createMock(\OCP\Contacts\IManager::class);
+        $this->overwriteService(\OCP\Contacts\IManager::class, $cm);
+
+        $cm->method('search')
+            ->willReturnMap([
+                ['user@server.com', ['CLOUD'], [
+                    'limit' => 1,
+                    'enumeration' => false,
+                    'strict_search' => true,
+                ],
+                    [
+                        [
+                            'CLOUD' => [
+                                'user@server.com',
+                            ],
+                            'FN' => 'foobar',
+                        ],
+                    ],
+                ],
+                ['user@server.com', ['EMAIL'], [
+                    'limit' => 1,
+                    'enumeration' => false,
+                    'strict_search' => true,
+                ],
+                    [
+                        [
+                            'EMAIL' => [
+                                'user@server.com',
+                            ],
+                            'FN' => 'mail display name',
+                        ],
+                    ],
+                ],
+            ]);
+
+        try {
+            $result = $this->invokePrivate($this->ocs, 'formatShare', [$share]);
+            $this->assertFalse($exception);
+            $this->assertEquals($expects, $result);
+        } catch (NotFoundException $e) {
+            $this->assertTrue($exception);
+        }
+    }
+
+    public function dataFormatRoomShare() {
+        $file = $this->getMockBuilder(File::class)->getMock();
+        $parent = $this->getMockBuilder(Folder::class)->getMock();
+
+        $file->method('getMimeType')->willReturn('myMimeType');
+
+        $file->method('getPath')->willReturn('file');
+
+        $parent->method('getId')->willReturn(1);
+        $file->method('getId')->willReturn(3);
+
+        $file->method('getParent')->willReturn($parent);
+
+        $file->method('getSize')->willReturn(123456);
+        $file->method('getMTime')->willReturn(1234567890);
+
+        $mountPoint = $this->getMockBuilder(IMountPoint::class)->getMock();
+        $mountPoint->method('getMountType')->willReturn('');
+        $file->method('getMountPoint')->willReturn($mountPoint);
+
+        $cache = $this->getMockBuilder('OCP\Files\Cache\ICache')->getMock();
+        $cache->method('getNumericStorageId')->willReturn(100);
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('getId')->willReturn('storageId');
+        $storage->method('getCache')->willReturn($cache);
+
+        $file->method('getStorage')->willReturn($storage);
+
+        $result = [];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_ROOM)
+            ->setSharedWith('recipientRoom')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_ROOM,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipientRoom',
+                'share_with_displayname' => '',
+                'mail_send' => 0,
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'label' => '',
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 1,
+            ], $share, false, []
+        ];
+
+        $share = Server::get(IManager::class)->newShare();
+        $share->setShareType(IShare::TYPE_ROOM)
+            ->setSharedWith('recipientRoom')
+            ->setSharedBy('initiator')
+            ->setShareOwner('owner')
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($file)
+            ->setShareTime(new \DateTime('2000-01-01T00:01:02'))
+            ->setTarget('myTarget')
+            ->setNote('personal note')
+            ->setId(42);
+
+        $result[] = [
+            [
+                'id' => '42',
+                'share_type' => IShare::TYPE_ROOM,
+                'uid_owner' => 'initiator',
+                'displayname_owner' => 'initiator',
+                'permissions' => 1,
+                'stime' => 946684862,
+                'parent' => null,
+                'expiration' => null,
+                'token' => null,
+                'uid_file_owner' => 'owner',
+                'displayname_file_owner' => 'owner',
+                'note' => 'personal note',
+                'path' => 'file',
+                'item_type' => 'file',
+                'storage_id' => 'storageId',
+                'storage' => 100,
+                'item_source' => 3,
+                'file_source' => 3,
+                'file_parent' => 1,
+                'file_target' => 'myTarget',
+                'share_with' => 'recipientRoom',
+                'share_with_displayname' => 'recipientRoomName',
+                'mail_send' => 0,
+                'mimetype' => 'myMimeType',
+                'has_preview' => false,
+                'hide_download' => 0,
+                'label' => '',
+                'can_edit' => false,
+                'can_delete' => false,
+                'item_size' => 123456,
+                'item_mtime' => 1234567890,
+                'is-mount-root' => false,
+                'mount-type' => '',
+                'attributes' => null,
+                'item_permissions' => 9,
+            ], $share, true, [
+                'share_with_displayname' => 'recipientRoomName'
+            ]
+        ];
+
+        return $result;
+    }
+
+    /**
+     * @dataProvider dataFormatRoomShare
+     *
+     * @param array $expects
+     * @param IShare $share
+     * @param bool $helperAvailable
+     * @param array $formatShareByHelper
+     */
+    public function testFormatRoomShare(array $expects, IShare $share, bool $helperAvailable, array $formatShareByHelper): void {
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->currentUser)
+            ->willReturnSelf();
+
+        $this->rootFolder->method('getFirstNodeById')
+            ->with($share->getNodeId())
+            ->willReturn($share->getNode());
+
+        $this->rootFolder->method('getRelativePath')
+            ->with($share->getNode()->getPath())
+            ->willReturnArgument(0);
+
+        if (!$helperAvailable) {
+            $this->appManager->method('isEnabledForUser')
+                ->with('spreed')
+                ->willReturn(false);
+        } else {
+            $this->appManager->method('isEnabledForUser')
+                ->with('spreed')
+                ->willReturn(true);
+
+            // This is not possible anymore with PHPUnit 10+
+            // as `setMethods` was removed and now real reflection is used, thus the class needs to exist.
+            // $helper = $this->getMockBuilder('\OCA\Talk\Share\Helper\ShareAPIController')
+            $helper = $this->getMockBuilder(\stdClass::class)
+                ->addMethods(['formatShare', 'canAccessShare'])
+                ->getMock();
+            $helper->method('formatShare')
+                ->with($share)
+                ->willReturn($formatShareByHelper);
+            $helper->method('canAccessShare')
+                ->with($share)
+                ->willReturn(true);
+
+            $this->serverContainer->method('get')
+                ->with('\OCA\Talk\Share\Helper\ShareAPIController')
+                ->willReturn($helper);
+        }
+
+        $result = $this->invokePrivate($this->ocs, 'formatShare', [$share]);
+        $this->assertEquals($expects, $result);
+    }
+
+    /**
+     * @return list{Folder, Folder}
+     */
+    private function getNonSharedUserFolder(): array {
+        $node = $this->getMockBuilder(Folder::class)->getMock();
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $userFolder->method('getStorage')->willReturn($storage);
+        $node->method('getStorage')->willReturn($storage);
+        $node->method('getId')->willReturn(42);
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')->willReturn($this->currentUser);
+        $node->method('getOwner')->willReturn($user);
+        return [$userFolder, $node];
+    }
+
+    /**
+     * @return list{Folder, File}
+     */
+    private function getNonSharedUserFile(): array {
+        $node = $this->getMockBuilder(File::class)->getMock();
+        $userFolder = $this->getMockBuilder(Folder::class)->getMock();
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')
+            ->willReturnMap([
+                ['OCA\Files_Sharing\External\Storage', false],
+                ['OCA\Files_Sharing\SharedStorage', false],
+            ]);
+        $userFolder->method('getStorage')->willReturn($storage);
+        $node->method('getStorage')->willReturn($storage);
+        $node->method('getId')->willReturn(42);
+        return [$userFolder, $node];
+    }
+
+    public function testPopulateTags(): void {
+        $tagger = $this->createMock(ITags::class);
+        $this->tagManager->method('load')
+            ->with('files')
+            ->willReturn($tagger);
+        $data = [
+            ['file_source' => 10],
+            ['file_source' => 22, 'foo' => 'bar'],
+            ['file_source' => 42, 'x' => 'y'],
+        ];
+        $tags = [
+            10 => ['tag3'],
+            42 => ['tag1', 'tag2'],
+        ];
+        $tagger->method('getTagsForObjects')
+            ->with([10, 22, 42])
+            ->willReturn($tags);
+
+        $result = self::invokePrivate($this->ocs, 'populateTags', [$data]);
+        $this->assertSame([
+            ['file_source' => 10, 'tags' => ['tag3']],
+            ['file_source' => 22, 'foo' => 'bar', 'tags' => []],
+            ['file_source' => 42, 'x' => 'y', 'tags' => ['tag1', 'tag2']],
+        ], $result);
+    }
 }

apps/files_sharing/tests/External/ManagerTest.php

Indentation +681 added lines, -681 removed lines

@@ -45,685 +45,685 @@
  * @package OCA\Files_Sharing\Tests\External
  */
 class ManagerTest extends TestCase {
-	use UserTrait;
-
-	protected string $uid;
-	protected IUser $user;
-	protected MountProvider $testMountProvider;
-	protected IEventDispatcher&MockObject $eventDispatcher;
-	protected LoggerInterface&MockObject $logger;
-	protected \OC\Files\Mount\Manager $mountManager;
-	protected IManager&MockObject $contactsManager;
-	protected Manager&MockObject $manager;
-	protected IClientService&MockObject $clientService;
-	protected ICloudFederationProviderManager&MockObject $cloudFederationProviderManager;
-	protected ICloudFederationFactory&MockObject $cloudFederationFactory;
-	protected IGroupManager&MockObject $groupManager;
-	protected IUserManager&MockObject $userManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->uid = $this->getUniqueID('user');
-		$this->user = $this->createUser($this->uid, '');
-		$this->mountManager = new \OC\Files\Mount\Manager($this->createMock(SetupManagerFactory::class));
-		$this->clientService = $this->getMockBuilder(IClientService::class)
-			->disableOriginalConstructor()->getMock();
-		$this->cloudFederationProviderManager = $this->createMock(ICloudFederationProviderManager::class);
-		$this->cloudFederationFactory = $this->createMock(ICloudFederationFactory::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->eventDispatcher = $this->createMock(IEventDispatcher::class);
-
-		$this->contactsManager = $this->createMock(IManager::class);
-		// needed for MountProvider() initialization
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->willReturn([]);
-
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->logger->expects($this->never())->method('emergency');
-
-		$this->manager = $this->createManagerForUser($this->uid);
-
-		$this->testMountProvider = new MountProvider(Server::get(IDBConnection::class), function () {
-			return $this->manager;
-		}, new CloudIdManager(
-			$this->contactsManager,
-			$this->createMock(IURLGenerator::class),
-			$this->userManager,
-			$this->createMock(ICacheFactory::class),
-			$this->createMock(IEventDispatcher::class)
-		));
-
-		$group1 = $this->createMock(IGroup::class);
-		$group1->expects($this->any())->method('getGID')->willReturn('group1');
-		$group1->expects($this->any())->method('inGroup')->with($this->user)->willReturn(true);
-
-		$group2 = $this->createMock(IGroup::class);
-		$group2->expects($this->any())->method('getGID')->willReturn('group2');
-		$group2->expects($this->any())->method('inGroup')->with($this->user)->willReturn(true);
-
-		$this->userManager->expects($this->any())->method('get')->willReturn($this->user);
-		$this->groupManager->expects($this->any())->method(('getUserGroups'))->willReturn([$group1, $group2]);
-		$this->groupManager->expects($this->any())->method(('get'))
-			->will($this->returnValueMap([
-				['group1', $group1],
-				['group2', $group2],
-			]));
-	}
-
-	protected function tearDown(): void {
-		// clear the share external table to avoid side effects
-		$query = Server::get(IDBConnection::class)->prepare('DELETE FROM `*PREFIX*share_external`');
-		$result = $query->execute();
-		$result->closeCursor();
-
-		parent::tearDown();
-	}
-
-	private function createManagerForUser($userId) {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn($userId);
-		$userSession = $this->createMock(IUserSession::class);
-		$userSession->method('getUser')
-			->willReturn($user);
-
-		return $this->getMockBuilder(Manager::class)
-			->setConstructorArgs(
-				[
-					Server::get(IDBConnection::class),
-					$this->mountManager,
-					new StorageFactory(),
-					$this->clientService,
-					Server::get(\OCP\Notification\IManager::class),
-					Server::get(IDiscoveryService::class),
-					$this->cloudFederationProviderManager,
-					$this->cloudFederationFactory,
-					$this->groupManager,
-					$this->userManager,
-					$userSession,
-					$this->eventDispatcher,
-					$this->logger,
-				]
-			)->onlyMethods(['tryOCMEndPoint'])->getMock();
-	}
-
-	private function setupMounts() {
-		$this->clearMounts();
-		$mounts = $this->testMountProvider->getMountsForUser($this->user, new StorageFactory());
-		foreach ($mounts as $mount) {
-			$this->mountManager->addMount($mount);
-		}
-	}
-
-	private function clearMounts() {
-		$this->mountManager->clear();
-		$this->mountManager->addMount(new MountPoint(Temporary::class, '', []));
-	}
-
-	public function testAddUserShare(): void {
-		$this->doTestAddShare([
-			'remote' => 'http://localhost',
-			'token' => 'token1',
-			'password' => '',
-			'name' => '/SharedFolder',
-			'owner' => 'foobar',
-			'shareType' => IShare::TYPE_USER,
-			'accepted' => false,
-			'user' => $this->uid,
-			'remoteId' => '2342'
-		], false);
-	}
-
-	public function testAddGroupShare(): void {
-		$this->doTestAddShare([
-			'remote' => 'http://localhost',
-			'token' => 'token1',
-			'password' => '',
-			'name' => '/SharedFolder',
-			'owner' => 'foobar',
-			'shareType' => IShare::TYPE_GROUP,
-			'accepted' => false,
-			'user' => 'group1',
-			'remoteId' => '2342'
-		], true);
-	}
-
-	public function doTestAddShare($shareData1, $isGroup = false) {
-		$shareData2 = $shareData1;
-		$shareData2['token'] = 'token2';
-		$shareData3 = $shareData1;
-		$shareData3['token'] = 'token3';
-
-		if ($isGroup) {
-			$this->manager->expects($this->never())->method('tryOCMEndPoint');
-		} else {
-			$this->manager->expects(self::atLeast(2))
-				->method('tryOCMEndPoint')
-				->willReturnMap([
-					['http://localhost', 'token1', '2342', 'accept', false],
-					['http://localhost', 'token3', '2342', 'decline', false],
-				]);
-		}
-
-		// Add a share for "user"
-		$this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData1));
-		$openShares = $this->manager->getOpenShares();
-		$this->assertCount(1, $openShares);
-		$this->assertExternalShareEntry($shareData1, $openShares[0], 1, '{{TemporaryMountPointName#' . $shareData1['name'] . '}}', $shareData1['user']);
-
-		$this->setupMounts();
-		$this->assertNotMount('SharedFolder');
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
-
-		// Add a second share for "user" with the same name
-		$this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData2));
-		$openShares = $this->manager->getOpenShares();
-		$this->assertCount(2, $openShares);
-		$this->assertExternalShareEntry($shareData1, $openShares[0], 1, '{{TemporaryMountPointName#' . $shareData1['name'] . '}}', $shareData1['user']);
-		// New share falls back to "-1" appendix, because the name is already taken
-		$this->assertExternalShareEntry($shareData2, $openShares[1], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $shareData2['user']);
-
-		$this->setupMounts();
-		$this->assertNotMount('SharedFolder');
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
-
-		$newClientCalls = [];
-		$this->clientService
-			->method('newClient')
-			->willReturnCallback(function () use (&$newClientCalls): IClient {
-				if (!empty($newClientCalls)) {
-					return array_shift($newClientCalls);
-				}
-				return $this->createMock(IClient::class);
-			});
-		if (!$isGroup) {
-			$client = $this->createMock(IClient::class);
-			$newClientCalls[] = $client;
-			$response = $this->createMock(IResponse::class);
-			$response->method('getBody')
-				->willReturn(json_encode([
-					'ocs' => [
-						'meta' => [
-							'statuscode' => 200,
-						]
-					]
-				]));
-			$client->expects($this->once())
-				->method('post')
-				->with($this->stringStartsWith('http://localhost/ocs/v2.php/cloud/shares/' . $openShares[0]['remote_id']), $this->anything())
-				->willReturn($response);
-		}
-
-		// Accept the first share
-		$this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
-
-		// Check remaining shares - Accepted
-		$acceptedShares = self::invokePrivate($this->manager, 'getShares', [true]);
-		$this->assertCount(1, $acceptedShares);
-		$shareData1['accepted'] = true;
-		$this->assertExternalShareEntry($shareData1, $acceptedShares[0], 1, $shareData1['name'], $this->uid);
-		// Check remaining shares - Open
-		$openShares = $this->manager->getOpenShares();
-		$this->assertCount(1, $openShares);
-		$this->assertExternalShareEntry($shareData2, $openShares[0], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $shareData2['user']);
-
-		$this->setupMounts();
-		$this->assertMount($shareData1['name']);
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
-
-		// Add another share for "user" with the same name
-		$this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData3));
-		$openShares = $this->manager->getOpenShares();
-		$this->assertCount(2, $openShares);
-		$this->assertExternalShareEntry($shareData2, $openShares[0], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $shareData2['user']);
-		if (!$isGroup) {
-			// New share falls back to the original name (no "-\d", because the name is not taken)
-			$this->assertExternalShareEntry($shareData3, $openShares[1], 3, '{{TemporaryMountPointName#' . $shareData3['name'] . '}}', $shareData3['user']);
-		} else {
-			$this->assertExternalShareEntry($shareData3, $openShares[1], 3, '{{TemporaryMountPointName#' . $shareData3['name'] . '}}-2', $shareData3['user']);
-		}
-
-		$this->setupMounts();
-		$this->assertMount($shareData1['name']);
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
-
-		if (!$isGroup) {
-			$client = $this->createMock(IClient::class);
-			$newClientCalls[] = $client;
-			$response = $this->createMock(IResponse::class);
-			$response->method('getBody')
-				->willReturn(json_encode([
-					'ocs' => [
-						'meta' => [
-							'statuscode' => 200,
-						]
-					]
-				]));
-			$client->expects($this->once())
-				->method('post')
-				->with($this->stringStartsWith('http://localhost/ocs/v2.php/cloud/shares/' . $openShares[1]['remote_id'] . '/decline'), $this->anything())
-				->willReturn($response);
-		}
-
-		// Decline the third share
-		$this->assertTrue($this->manager->declineShare($openShares[1]['id']));
-
-		$this->setupMounts();
-		$this->assertMount($shareData1['name']);
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
-
-		// Check remaining shares - Accepted
-		$acceptedShares = self::invokePrivate($this->manager, 'getShares', [true]);
-		$this->assertCount(1, $acceptedShares);
-		$shareData1['accepted'] = true;
-		$this->assertExternalShareEntry($shareData1, $acceptedShares[0], 1, $shareData1['name'], $this->uid);
-		// Check remaining shares - Open
-		$openShares = $this->manager->getOpenShares();
-		if ($isGroup) {
-			// declining a group share adds it back to pending instead of deleting it
-			$this->assertCount(2, $openShares);
-			// this is a group share that is still open
-			$this->assertExternalShareEntry($shareData2, $openShares[0], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $shareData2['user']);
-			// this is the user share sub-entry matching the group share which got declined
-			$this->assertExternalShareEntry($shareData3, $openShares[1], 2, '{{TemporaryMountPointName#' . $shareData3['name'] . '}}-2', $this->uid);
-		} else {
-			$this->assertCount(1, $openShares);
-			$this->assertExternalShareEntry($shareData2, $openShares[0], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $this->uid);
-		}
-
-		$this->setupMounts();
-		$this->assertMount($shareData1['name']);
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
-
-		if ($isGroup) {
-			// no http requests here
-			$this->manager->removeGroupShares('group1');
-		} else {
-			$client1 = $this->createMock(IClient::class);
-			$client2 = $this->createMock(IClient::class);
-			$newClientCalls[] = $client1;
-			$newClientCalls[] = $client2;
-			$response = $this->createMock(IResponse::class);
-			$response->method('getBody')
-				->willReturn(json_encode([
-					'ocs' => [
-						'meta' => [
-							'statuscode' => 200,
-						]
-					]
-				]));
-
-			$client1->expects($this->once())
-				->method('post')
-				->with($this->stringStartsWith('http://localhost/ocs/v2.php/cloud/shares/' . $openShares[0]['remote_id'] . '/decline'), $this->anything())
-				->willReturn($response);
-			$client2->expects($this->once())
-				->method('post')
-				->with($this->stringStartsWith('http://localhost/ocs/v2.php/cloud/shares/' . $acceptedShares[0]['remote_id'] . '/decline'), $this->anything())
-				->willReturn($response);
-
-			$this->manager->removeUserShares($this->uid);
-		}
-
-		$this->assertEmpty(self::invokePrivate($this->manager, 'getShares', [null]), 'Asserting all shares for the user have been deleted');
-
-		$this->clearMounts();
-		self::invokePrivate($this->manager, 'setupMounts');
-		$this->assertNotMount($shareData1['name']);
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
-		$this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
-	}
-
-	private function verifyAcceptedGroupShare($shareData) {
-		$openShares = $this->manager->getOpenShares();
-		$this->assertCount(0, $openShares);
-		$acceptedShares = self::invokePrivate($this->manager, 'getShares', [true]);
-		$this->assertCount(1, $acceptedShares);
-		$shareData['accepted'] = true;
-		$this->assertExternalShareEntry($shareData, $acceptedShares[0], 0, $shareData['name'], $this->uid);
-		$this->setupMounts();
-		$this->assertMount($shareData['name']);
-	}
-
-	private function verifyDeclinedGroupShare($shareData, $tempMount = null) {
-		if ($tempMount === null) {
-			$tempMount = '{{TemporaryMountPointName#/SharedFolder}}';
-		}
-		$openShares = $this->manager->getOpenShares();
-		$this->assertCount(1, $openShares);
-		$acceptedShares = self::invokePrivate($this->manager, 'getShares', [true]);
-		$this->assertCount(0, $acceptedShares);
-		$this->assertExternalShareEntry($shareData, $openShares[0], 0, $tempMount, $this->uid);
-		$this->setupMounts();
-		$this->assertNotMount($shareData['name']);
-		$this->assertNotMount($tempMount);
-	}
-
-	private function createTestUserShare($userId = 'user1') {
-		$shareData = [
-			'remote' => 'http://localhost',
-			'token' => 'token1',
-			'password' => '',
-			'name' => '/SharedFolder',
-			'owner' => 'foobar',
-			'shareType' => IShare::TYPE_USER,
-			'accepted' => false,
-			'user' => $userId,
-			'remoteId' => '2342'
-		];
-
-		$this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData));
-
-		return $shareData;
-	}
-	private function createTestGroupShare($groupId = 'group1') {
-		$shareData = [
-			'remote' => 'http://localhost',
-			'token' => 'token1',
-			'password' => '',
-			'name' => '/SharedFolder',
-			'owner' => 'foobar',
-			'shareType' => IShare::TYPE_GROUP,
-			'accepted' => false,
-			'user' => $groupId,
-			'remoteId' => '2342'
-		];
-
-		$this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData));
-
-		$allShares = self::invokePrivate($this->manager, 'getShares', [null]);
-		foreach ($allShares as $share) {
-			if ($share['user'] === $groupId) {
-				// this will hold the main group entry
-				$groupShare = $share;
-				break;
-			}
-		}
-
-		return [$shareData, $groupShare];
-	}
-
-	public function testAcceptOriginalGroupShare(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-
-		// a second time
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-	}
-
-	public function testAcceptGroupShareAgainThroughGroupShare(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-
-		// decline again, this keeps the sub-share
-		$this->assertTrue($this->manager->declineShare($groupShare['id']));
-		$this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
-
-		// this will return sub-entries
-		$openShares = $this->manager->getOpenShares();
-		$this->assertCount(1, $openShares);
-
-		// accept through group share
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData, '/SharedFolder');
-
-		// accept a second time
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData, '/SharedFolder');
-	}
-
-	public function testAcceptGroupShareAgainThroughSubShare(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-
-		// decline again, this keeps the sub-share
-		$this->assertTrue($this->manager->declineShare($groupShare['id']));
-		$this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
-
-		// this will return sub-entries
-		$openShares = $this->manager->getOpenShares();
-		$this->assertCount(1, $openShares);
-
-		// accept through sub-share
-		$this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-
-		// accept a second time
-		$this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-	}
-
-	public function testDeclineOriginalGroupShare(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		$this->assertTrue($this->manager->declineShare($groupShare['id']));
-		$this->verifyDeclinedGroupShare($shareData);
-
-		// a second time
-		$this->assertTrue($this->manager->declineShare($groupShare['id']));
-		$this->verifyDeclinedGroupShare($shareData);
-	}
-
-	public function testDeclineGroupShareAgainThroughGroupShare(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-
-		// decline again, this keeps the sub-share
-		$this->assertTrue($this->manager->declineShare($groupShare['id']));
-		$this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
-
-		// a second time
-		$this->assertTrue($this->manager->declineShare($groupShare['id']));
-		$this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
-	}
-
-	public function testDeclineGroupShareAgainThroughSubshare(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-
-		// this will return sub-entries
-		$allShares = self::invokePrivate($this->manager, 'getShares', [null]);
-		$this->assertCount(1, $allShares);
-
-		// decline again through sub-share
-		$this->assertTrue($this->manager->declineShare($allShares[0]['id']));
-		$this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
-
-		// a second time
-		$this->assertTrue($this->manager->declineShare($allShares[0]['id']));
-		$this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
-	}
-
-	public function testDeclineGroupShareAgainThroughMountPoint(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-
-		// decline through mount point name
-		$this->assertTrue($this->manager->removeShare($this->uid . '/files/' . $shareData['name']));
-		$this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
-
-		// second time must fail as the mount point is gone
-		$this->assertFalse($this->manager->removeShare($this->uid . '/files/' . $shareData['name']));
-	}
-
-	public function testDeclineThenAcceptGroupShareAgainThroughGroupShare(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		// decline, this creates a declined sub-share
-		$this->assertTrue($this->manager->declineShare($groupShare['id']));
-		$this->verifyDeclinedGroupShare($shareData);
-
-		// this will return sub-entries
-		$openShares = $this->manager->getOpenShares();
-
-		// accept through sub-share
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData, '/SharedFolder');
-
-		// accept a second time
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-		$this->verifyAcceptedGroupShare($shareData, '/SharedFolder');
-	}
-
-	public function testDeclineThenAcceptGroupShareAgainThroughSubShare(): void {
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-		// decline, this creates a declined sub-share
-		$this->assertTrue($this->manager->declineShare($groupShare['id']));
-		$this->verifyDeclinedGroupShare($shareData);
-
-		// this will return sub-entries
-		$openShares = $this->manager->getOpenShares();
-
-		// accept through sub-share
-		$this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-
-		// accept a second time
-		$this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
-		$this->verifyAcceptedGroupShare($shareData);
-	}
-
-	public function testDeleteUserShares(): void {
-		// user 1 shares
-
-		$shareData = $this->createTestUserShare($this->uid);
-
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-
-		$shares = $this->manager->getOpenShares();
-		$this->assertCount(2, $shares);
-
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-
-		// user 2 shares
-		$manager2 = $this->createManagerForUser('user2');
-		$shareData2 = [
-			'remote' => 'http://localhost',
-			'token' => 'token1',
-			'password' => '',
-			'name' => '/SharedFolder',
-			'owner' => 'foobar',
-			'shareType' => IShare::TYPE_USER,
-			'accepted' => false,
-			'user' => 'user2',
-			'remoteId' => '2342'
-		];
-
-		$this->assertCount(1, $manager2->getOpenShares());
-		$this->assertSame(null, call_user_func_array([$manager2, 'addShare'], $shareData2));
-		$this->assertCount(2, $manager2->getOpenShares());
-
-		$this->manager->expects($this->once())->method('tryOCMEndPoint')->with('http://localhost', 'token1', '2342', 'decline')->willReturn([]);
-		$this->manager->removeUserShares($this->uid);
-
-		$user1Shares = $this->manager->getOpenShares();
-		// user share is gone, group is still there
-		$this->assertCount(1, $user1Shares);
-		$this->assertEquals($user1Shares[0]['share_type'], IShare::TYPE_GROUP);
-
-		// user 2 shares untouched
-		$user2Shares = $manager2->getOpenShares();
-		$this->assertCount(2, $user2Shares);
-		$this->assertEquals($user2Shares[0]['share_type'], IShare::TYPE_GROUP);
-		$this->assertEquals($user2Shares[0]['user'], 'group1');
-		$this->assertEquals($user2Shares[1]['share_type'], IShare::TYPE_USER);
-		$this->assertEquals($user2Shares[1]['user'], 'user2');
-	}
-
-	public function testDeleteGroupShares(): void {
-		$shareData = $this->createTestUserShare($this->uid);
-
-		[$shareData, $groupShare] = $this->createTestGroupShare();
-
-		$shares = $this->manager->getOpenShares();
-		$this->assertCount(2, $shares);
-
-		$this->assertTrue($this->manager->acceptShare($groupShare['id']));
-
-		// user 2 shares
-		$manager2 = $this->createManagerForUser('user2');
-		$shareData2 = [
-			'remote' => 'http://localhost',
-			'token' => 'token1',
-			'password' => '',
-			'name' => '/SharedFolder',
-			'owner' => 'foobar',
-			'shareType' => IShare::TYPE_USER,
-			'accepted' => false,
-			'user' => 'user2',
-			'remoteId' => '2342'
-		];
-
-		$this->assertCount(1, $manager2->getOpenShares());
-		$this->assertSame(null, call_user_func_array([$manager2, 'addShare'], $shareData2));
-		$this->assertCount(2, $manager2->getOpenShares());
-
-		$this->manager->expects($this->never())->method('tryOCMEndPoint');
-		$this->manager->removeGroupShares('group1');
-
-		$user1Shares = $this->manager->getOpenShares();
-		// user share is gone, group is still there
-		$this->assertCount(1, $user1Shares);
-		$this->assertEquals($user1Shares[0]['share_type'], IShare::TYPE_USER);
-
-		// user 2 shares untouched
-		$user2Shares = $manager2->getOpenShares();
-		$this->assertCount(1, $user2Shares);
-		$this->assertEquals($user2Shares[0]['share_type'], IShare::TYPE_USER);
-		$this->assertEquals($user2Shares[0]['user'], 'user2');
-	}
-
-	/**
-	 * @param array $expected
-	 * @param array $actual
-	 * @param int $share
-	 * @param string $mountPoint
-	 */
-	protected function assertExternalShareEntry($expected, $actual, $share, $mountPoint, $targetEntity) {
-		$this->assertEquals($expected['remote'], $actual['remote'], 'Asserting remote of a share #' . $share);
-		$this->assertEquals($expected['token'], $actual['share_token'], 'Asserting token of a share #' . $share);
-		$this->assertEquals($expected['name'], $actual['name'], 'Asserting name of a share #' . $share);
-		$this->assertEquals($expected['owner'], $actual['owner'], 'Asserting owner of a share #' . $share);
-		$this->assertEquals($expected['accepted'], (int)$actual['accepted'], 'Asserting accept of a share #' . $share);
-		$this->assertEquals($targetEntity, $actual['user'], 'Asserting user of a share #' . $share);
-		$this->assertEquals($mountPoint, $actual['mountpoint'], 'Asserting mountpoint of a share #' . $share);
-	}
-
-	private function assertMount($mountPoint) {
-		$mountPoint = rtrim($mountPoint, '/');
-		$mount = $this->mountManager->find($this->getFullPath($mountPoint));
-		$this->assertInstanceOf('\OCA\Files_Sharing\External\Mount', $mount);
-		$this->assertInstanceOf('\OCP\Files\Mount\IMountPoint', $mount);
-		$this->assertEquals($this->getFullPath($mountPoint), rtrim($mount->getMountPoint(), '/'));
-		$storage = $mount->getStorage();
-		$this->assertInstanceOf('\OCA\Files_Sharing\External\Storage', $storage);
-	}
-
-	private function assertNotMount($mountPoint) {
-		$mountPoint = rtrim($mountPoint, '/');
-		try {
-			$mount = $this->mountManager->find($this->getFullPath($mountPoint));
-			$this->assertInstanceOf('\OCP\Files\Mount\IMountPoint', $mount);
-			$this->assertNotEquals($this->getFullPath($mountPoint), rtrim($mount->getMountPoint(), '/'));
-		} catch (NotFoundException $e) {
-
-		}
-	}
-
-	private function getFullPath($path) {
-		return '/' . $this->uid . '/files' . $path;
-	}
+    use UserTrait;
+
+    protected string $uid;
+    protected IUser $user;
+    protected MountProvider $testMountProvider;
+    protected IEventDispatcher&MockObject $eventDispatcher;
+    protected LoggerInterface&MockObject $logger;
+    protected \OC\Files\Mount\Manager $mountManager;
+    protected IManager&MockObject $contactsManager;
+    protected Manager&MockObject $manager;
+    protected IClientService&MockObject $clientService;
+    protected ICloudFederationProviderManager&MockObject $cloudFederationProviderManager;
+    protected ICloudFederationFactory&MockObject $cloudFederationFactory;
+    protected IGroupManager&MockObject $groupManager;
+    protected IUserManager&MockObject $userManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->uid = $this->getUniqueID('user');
+        $this->user = $this->createUser($this->uid, '');
+        $this->mountManager = new \OC\Files\Mount\Manager($this->createMock(SetupManagerFactory::class));
+        $this->clientService = $this->getMockBuilder(IClientService::class)
+            ->disableOriginalConstructor()->getMock();
+        $this->cloudFederationProviderManager = $this->createMock(ICloudFederationProviderManager::class);
+        $this->cloudFederationFactory = $this->createMock(ICloudFederationFactory::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->eventDispatcher = $this->createMock(IEventDispatcher::class);
+
+        $this->contactsManager = $this->createMock(IManager::class);
+        // needed for MountProvider() initialization
+        $this->contactsManager->expects($this->any())
+            ->method('search')
+            ->willReturn([]);
+
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->logger->expects($this->never())->method('emergency');
+
+        $this->manager = $this->createManagerForUser($this->uid);
+
+        $this->testMountProvider = new MountProvider(Server::get(IDBConnection::class), function () {
+            return $this->manager;
+        }, new CloudIdManager(
+            $this->contactsManager,
+            $this->createMock(IURLGenerator::class),
+            $this->userManager,
+            $this->createMock(ICacheFactory::class),
+            $this->createMock(IEventDispatcher::class)
+        ));
+
+        $group1 = $this->createMock(IGroup::class);
+        $group1->expects($this->any())->method('getGID')->willReturn('group1');
+        $group1->expects($this->any())->method('inGroup')->with($this->user)->willReturn(true);
+
+        $group2 = $this->createMock(IGroup::class);
+        $group2->expects($this->any())->method('getGID')->willReturn('group2');
+        $group2->expects($this->any())->method('inGroup')->with($this->user)->willReturn(true);
+
+        $this->userManager->expects($this->any())->method('get')->willReturn($this->user);
+        $this->groupManager->expects($this->any())->method(('getUserGroups'))->willReturn([$group1, $group2]);
+        $this->groupManager->expects($this->any())->method(('get'))
+            ->will($this->returnValueMap([
+                ['group1', $group1],
+                ['group2', $group2],
+            ]));
+    }
+
+    protected function tearDown(): void {
+        // clear the share external table to avoid side effects
+        $query = Server::get(IDBConnection::class)->prepare('DELETE FROM `*PREFIX*share_external`');
+        $result = $query->execute();
+        $result->closeCursor();
+
+        parent::tearDown();
+    }
+
+    private function createManagerForUser($userId) {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn($userId);
+        $userSession = $this->createMock(IUserSession::class);
+        $userSession->method('getUser')
+            ->willReturn($user);
+
+        return $this->getMockBuilder(Manager::class)
+            ->setConstructorArgs(
+                [
+                    Server::get(IDBConnection::class),
+                    $this->mountManager,
+                    new StorageFactory(),
+                    $this->clientService,
+                    Server::get(\OCP\Notification\IManager::class),
+                    Server::get(IDiscoveryService::class),
+                    $this->cloudFederationProviderManager,
+                    $this->cloudFederationFactory,
+                    $this->groupManager,
+                    $this->userManager,
+                    $userSession,
+                    $this->eventDispatcher,
+                    $this->logger,
+                ]
+            )->onlyMethods(['tryOCMEndPoint'])->getMock();
+    }
+
+    private function setupMounts() {
+        $this->clearMounts();
+        $mounts = $this->testMountProvider->getMountsForUser($this->user, new StorageFactory());
+        foreach ($mounts as $mount) {
+            $this->mountManager->addMount($mount);
+        }
+    }
+
+    private function clearMounts() {
+        $this->mountManager->clear();
+        $this->mountManager->addMount(new MountPoint(Temporary::class, '', []));
+    }
+
+    public function testAddUserShare(): void {
+        $this->doTestAddShare([
+            'remote' => 'http://localhost',
+            'token' => 'token1',
+            'password' => '',
+            'name' => '/SharedFolder',
+            'owner' => 'foobar',
+            'shareType' => IShare::TYPE_USER,
+            'accepted' => false,
+            'user' => $this->uid,
+            'remoteId' => '2342'
+        ], false);
+    }
+
+    public function testAddGroupShare(): void {
+        $this->doTestAddShare([
+            'remote' => 'http://localhost',
+            'token' => 'token1',
+            'password' => '',
+            'name' => '/SharedFolder',
+            'owner' => 'foobar',
+            'shareType' => IShare::TYPE_GROUP,
+            'accepted' => false,
+            'user' => 'group1',
+            'remoteId' => '2342'
+        ], true);
+    }
+
+    public function doTestAddShare($shareData1, $isGroup = false) {
+        $shareData2 = $shareData1;
+        $shareData2['token'] = 'token2';
+        $shareData3 = $shareData1;
+        $shareData3['token'] = 'token3';
+
+        if ($isGroup) {
+            $this->manager->expects($this->never())->method('tryOCMEndPoint');
+        } else {
+            $this->manager->expects(self::atLeast(2))
+                ->method('tryOCMEndPoint')
+                ->willReturnMap([
+                    ['http://localhost', 'token1', '2342', 'accept', false],
+                    ['http://localhost', 'token3', '2342', 'decline', false],
+                ]);
+        }
+
+        // Add a share for "user"
+        $this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData1));
+        $openShares = $this->manager->getOpenShares();
+        $this->assertCount(1, $openShares);
+        $this->assertExternalShareEntry($shareData1, $openShares[0], 1, '{{TemporaryMountPointName#' . $shareData1['name'] . '}}', $shareData1['user']);
+
+        $this->setupMounts();
+        $this->assertNotMount('SharedFolder');
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
+
+        // Add a second share for "user" with the same name
+        $this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData2));
+        $openShares = $this->manager->getOpenShares();
+        $this->assertCount(2, $openShares);
+        $this->assertExternalShareEntry($shareData1, $openShares[0], 1, '{{TemporaryMountPointName#' . $shareData1['name'] . '}}', $shareData1['user']);
+        // New share falls back to "-1" appendix, because the name is already taken
+        $this->assertExternalShareEntry($shareData2, $openShares[1], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $shareData2['user']);
+
+        $this->setupMounts();
+        $this->assertNotMount('SharedFolder');
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
+
+        $newClientCalls = [];
+        $this->clientService
+            ->method('newClient')
+            ->willReturnCallback(function () use (&$newClientCalls): IClient {
+                if (!empty($newClientCalls)) {
+                    return array_shift($newClientCalls);
+                }
+                return $this->createMock(IClient::class);
+            });
+        if (!$isGroup) {
+            $client = $this->createMock(IClient::class);
+            $newClientCalls[] = $client;
+            $response = $this->createMock(IResponse::class);
+            $response->method('getBody')
+                ->willReturn(json_encode([
+                    'ocs' => [
+                        'meta' => [
+                            'statuscode' => 200,
+                        ]
+                    ]
+                ]));
+            $client->expects($this->once())
+                ->method('post')
+                ->with($this->stringStartsWith('http://localhost/ocs/v2.php/cloud/shares/' . $openShares[0]['remote_id']), $this->anything())
+                ->willReturn($response);
+        }
+
+        // Accept the first share
+        $this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
+
+        // Check remaining shares - Accepted
+        $acceptedShares = self::invokePrivate($this->manager, 'getShares', [true]);
+        $this->assertCount(1, $acceptedShares);
+        $shareData1['accepted'] = true;
+        $this->assertExternalShareEntry($shareData1, $acceptedShares[0], 1, $shareData1['name'], $this->uid);
+        // Check remaining shares - Open
+        $openShares = $this->manager->getOpenShares();
+        $this->assertCount(1, $openShares);
+        $this->assertExternalShareEntry($shareData2, $openShares[0], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $shareData2['user']);
+
+        $this->setupMounts();
+        $this->assertMount($shareData1['name']);
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
+
+        // Add another share for "user" with the same name
+        $this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData3));
+        $openShares = $this->manager->getOpenShares();
+        $this->assertCount(2, $openShares);
+        $this->assertExternalShareEntry($shareData2, $openShares[0], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $shareData2['user']);
+        if (!$isGroup) {
+            // New share falls back to the original name (no "-\d", because the name is not taken)
+            $this->assertExternalShareEntry($shareData3, $openShares[1], 3, '{{TemporaryMountPointName#' . $shareData3['name'] . '}}', $shareData3['user']);
+        } else {
+            $this->assertExternalShareEntry($shareData3, $openShares[1], 3, '{{TemporaryMountPointName#' . $shareData3['name'] . '}}-2', $shareData3['user']);
+        }
+
+        $this->setupMounts();
+        $this->assertMount($shareData1['name']);
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
+
+        if (!$isGroup) {
+            $client = $this->createMock(IClient::class);
+            $newClientCalls[] = $client;
+            $response = $this->createMock(IResponse::class);
+            $response->method('getBody')
+                ->willReturn(json_encode([
+                    'ocs' => [
+                        'meta' => [
+                            'statuscode' => 200,
+                        ]
+                    ]
+                ]));
+            $client->expects($this->once())
+                ->method('post')
+                ->with($this->stringStartsWith('http://localhost/ocs/v2.php/cloud/shares/' . $openShares[1]['remote_id'] . '/decline'), $this->anything())
+                ->willReturn($response);
+        }
+
+        // Decline the third share
+        $this->assertTrue($this->manager->declineShare($openShares[1]['id']));
+
+        $this->setupMounts();
+        $this->assertMount($shareData1['name']);
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
+
+        // Check remaining shares - Accepted
+        $acceptedShares = self::invokePrivate($this->manager, 'getShares', [true]);
+        $this->assertCount(1, $acceptedShares);
+        $shareData1['accepted'] = true;
+        $this->assertExternalShareEntry($shareData1, $acceptedShares[0], 1, $shareData1['name'], $this->uid);
+        // Check remaining shares - Open
+        $openShares = $this->manager->getOpenShares();
+        if ($isGroup) {
+            // declining a group share adds it back to pending instead of deleting it
+            $this->assertCount(2, $openShares);
+            // this is a group share that is still open
+            $this->assertExternalShareEntry($shareData2, $openShares[0], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $shareData2['user']);
+            // this is the user share sub-entry matching the group share which got declined
+            $this->assertExternalShareEntry($shareData3, $openShares[1], 2, '{{TemporaryMountPointName#' . $shareData3['name'] . '}}-2', $this->uid);
+        } else {
+            $this->assertCount(1, $openShares);
+            $this->assertExternalShareEntry($shareData2, $openShares[0], 2, '{{TemporaryMountPointName#' . $shareData2['name'] . '}}-1', $this->uid);
+        }
+
+        $this->setupMounts();
+        $this->assertMount($shareData1['name']);
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
+
+        if ($isGroup) {
+            // no http requests here
+            $this->manager->removeGroupShares('group1');
+        } else {
+            $client1 = $this->createMock(IClient::class);
+            $client2 = $this->createMock(IClient::class);
+            $newClientCalls[] = $client1;
+            $newClientCalls[] = $client2;
+            $response = $this->createMock(IResponse::class);
+            $response->method('getBody')
+                ->willReturn(json_encode([
+                    'ocs' => [
+                        'meta' => [
+                            'statuscode' => 200,
+                        ]
+                    ]
+                ]));
+
+            $client1->expects($this->once())
+                ->method('post')
+                ->with($this->stringStartsWith('http://localhost/ocs/v2.php/cloud/shares/' . $openShares[0]['remote_id'] . '/decline'), $this->anything())
+                ->willReturn($response);
+            $client2->expects($this->once())
+                ->method('post')
+                ->with($this->stringStartsWith('http://localhost/ocs/v2.php/cloud/shares/' . $acceptedShares[0]['remote_id'] . '/decline'), $this->anything())
+                ->willReturn($response);
+
+            $this->manager->removeUserShares($this->uid);
+        }
+
+        $this->assertEmpty(self::invokePrivate($this->manager, 'getShares', [null]), 'Asserting all shares for the user have been deleted');
+
+        $this->clearMounts();
+        self::invokePrivate($this->manager, 'setupMounts');
+        $this->assertNotMount($shareData1['name']);
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}');
+        $this->assertNotMount('{{TemporaryMountPointName#' . $shareData1['name'] . '}}-1');
+    }
+
+    private function verifyAcceptedGroupShare($shareData) {
+        $openShares = $this->manager->getOpenShares();
+        $this->assertCount(0, $openShares);
+        $acceptedShares = self::invokePrivate($this->manager, 'getShares', [true]);
+        $this->assertCount(1, $acceptedShares);
+        $shareData['accepted'] = true;
+        $this->assertExternalShareEntry($shareData, $acceptedShares[0], 0, $shareData['name'], $this->uid);
+        $this->setupMounts();
+        $this->assertMount($shareData['name']);
+    }
+
+    private function verifyDeclinedGroupShare($shareData, $tempMount = null) {
+        if ($tempMount === null) {
+            $tempMount = '{{TemporaryMountPointName#/SharedFolder}}';
+        }
+        $openShares = $this->manager->getOpenShares();
+        $this->assertCount(1, $openShares);
+        $acceptedShares = self::invokePrivate($this->manager, 'getShares', [true]);
+        $this->assertCount(0, $acceptedShares);
+        $this->assertExternalShareEntry($shareData, $openShares[0], 0, $tempMount, $this->uid);
+        $this->setupMounts();
+        $this->assertNotMount($shareData['name']);
+        $this->assertNotMount($tempMount);
+    }
+
+    private function createTestUserShare($userId = 'user1') {
+        $shareData = [
+            'remote' => 'http://localhost',
+            'token' => 'token1',
+            'password' => '',
+            'name' => '/SharedFolder',
+            'owner' => 'foobar',
+            'shareType' => IShare::TYPE_USER,
+            'accepted' => false,
+            'user' => $userId,
+            'remoteId' => '2342'
+        ];
+
+        $this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData));
+
+        return $shareData;
+    }
+    private function createTestGroupShare($groupId = 'group1') {
+        $shareData = [
+            'remote' => 'http://localhost',
+            'token' => 'token1',
+            'password' => '',
+            'name' => '/SharedFolder',
+            'owner' => 'foobar',
+            'shareType' => IShare::TYPE_GROUP,
+            'accepted' => false,
+            'user' => $groupId,
+            'remoteId' => '2342'
+        ];
+
+        $this->assertSame(null, call_user_func_array([$this->manager, 'addShare'], $shareData));
+
+        $allShares = self::invokePrivate($this->manager, 'getShares', [null]);
+        foreach ($allShares as $share) {
+            if ($share['user'] === $groupId) {
+                // this will hold the main group entry
+                $groupShare = $share;
+                break;
+            }
+        }
+
+        return [$shareData, $groupShare];
+    }
+
+    public function testAcceptOriginalGroupShare(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+
+        // a second time
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+    }
+
+    public function testAcceptGroupShareAgainThroughGroupShare(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+
+        // decline again, this keeps the sub-share
+        $this->assertTrue($this->manager->declineShare($groupShare['id']));
+        $this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
+
+        // this will return sub-entries
+        $openShares = $this->manager->getOpenShares();
+        $this->assertCount(1, $openShares);
+
+        // accept through group share
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData, '/SharedFolder');
+
+        // accept a second time
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData, '/SharedFolder');
+    }
+
+    public function testAcceptGroupShareAgainThroughSubShare(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+
+        // decline again, this keeps the sub-share
+        $this->assertTrue($this->manager->declineShare($groupShare['id']));
+        $this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
+
+        // this will return sub-entries
+        $openShares = $this->manager->getOpenShares();
+        $this->assertCount(1, $openShares);
+
+        // accept through sub-share
+        $this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+
+        // accept a second time
+        $this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+    }
+
+    public function testDeclineOriginalGroupShare(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        $this->assertTrue($this->manager->declineShare($groupShare['id']));
+        $this->verifyDeclinedGroupShare($shareData);
+
+        // a second time
+        $this->assertTrue($this->manager->declineShare($groupShare['id']));
+        $this->verifyDeclinedGroupShare($shareData);
+    }
+
+    public function testDeclineGroupShareAgainThroughGroupShare(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+
+        // decline again, this keeps the sub-share
+        $this->assertTrue($this->manager->declineShare($groupShare['id']));
+        $this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
+
+        // a second time
+        $this->assertTrue($this->manager->declineShare($groupShare['id']));
+        $this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
+    }
+
+    public function testDeclineGroupShareAgainThroughSubshare(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+
+        // this will return sub-entries
+        $allShares = self::invokePrivate($this->manager, 'getShares', [null]);
+        $this->assertCount(1, $allShares);
+
+        // decline again through sub-share
+        $this->assertTrue($this->manager->declineShare($allShares[0]['id']));
+        $this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
+
+        // a second time
+        $this->assertTrue($this->manager->declineShare($allShares[0]['id']));
+        $this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
+    }
+
+    public function testDeclineGroupShareAgainThroughMountPoint(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+
+        // decline through mount point name
+        $this->assertTrue($this->manager->removeShare($this->uid . '/files/' . $shareData['name']));
+        $this->verifyDeclinedGroupShare($shareData, '/SharedFolder');
+
+        // second time must fail as the mount point is gone
+        $this->assertFalse($this->manager->removeShare($this->uid . '/files/' . $shareData['name']));
+    }
+
+    public function testDeclineThenAcceptGroupShareAgainThroughGroupShare(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        // decline, this creates a declined sub-share
+        $this->assertTrue($this->manager->declineShare($groupShare['id']));
+        $this->verifyDeclinedGroupShare($shareData);
+
+        // this will return sub-entries
+        $openShares = $this->manager->getOpenShares();
+
+        // accept through sub-share
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData, '/SharedFolder');
+
+        // accept a second time
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+        $this->verifyAcceptedGroupShare($shareData, '/SharedFolder');
+    }
+
+    public function testDeclineThenAcceptGroupShareAgainThroughSubShare(): void {
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+        // decline, this creates a declined sub-share
+        $this->assertTrue($this->manager->declineShare($groupShare['id']));
+        $this->verifyDeclinedGroupShare($shareData);
+
+        // this will return sub-entries
+        $openShares = $this->manager->getOpenShares();
+
+        // accept through sub-share
+        $this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+
+        // accept a second time
+        $this->assertTrue($this->manager->acceptShare($openShares[0]['id']));
+        $this->verifyAcceptedGroupShare($shareData);
+    }
+
+    public function testDeleteUserShares(): void {
+        // user 1 shares
+
+        $shareData = $this->createTestUserShare($this->uid);
+
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+
+        $shares = $this->manager->getOpenShares();
+        $this->assertCount(2, $shares);
+
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+
+        // user 2 shares
+        $manager2 = $this->createManagerForUser('user2');
+        $shareData2 = [
+            'remote' => 'http://localhost',
+            'token' => 'token1',
+            'password' => '',
+            'name' => '/SharedFolder',
+            'owner' => 'foobar',
+            'shareType' => IShare::TYPE_USER,
+            'accepted' => false,
+            'user' => 'user2',
+            'remoteId' => '2342'
+        ];
+
+        $this->assertCount(1, $manager2->getOpenShares());
+        $this->assertSame(null, call_user_func_array([$manager2, 'addShare'], $shareData2));
+        $this->assertCount(2, $manager2->getOpenShares());
+
+        $this->manager->expects($this->once())->method('tryOCMEndPoint')->with('http://localhost', 'token1', '2342', 'decline')->willReturn([]);
+        $this->manager->removeUserShares($this->uid);
+
+        $user1Shares = $this->manager->getOpenShares();
+        // user share is gone, group is still there
+        $this->assertCount(1, $user1Shares);
+        $this->assertEquals($user1Shares[0]['share_type'], IShare::TYPE_GROUP);
+
+        // user 2 shares untouched
+        $user2Shares = $manager2->getOpenShares();
+        $this->assertCount(2, $user2Shares);
+        $this->assertEquals($user2Shares[0]['share_type'], IShare::TYPE_GROUP);
+        $this->assertEquals($user2Shares[0]['user'], 'group1');
+        $this->assertEquals($user2Shares[1]['share_type'], IShare::TYPE_USER);
+        $this->assertEquals($user2Shares[1]['user'], 'user2');
+    }
+
+    public function testDeleteGroupShares(): void {
+        $shareData = $this->createTestUserShare($this->uid);
+
+        [$shareData, $groupShare] = $this->createTestGroupShare();
+
+        $shares = $this->manager->getOpenShares();
+        $this->assertCount(2, $shares);
+
+        $this->assertTrue($this->manager->acceptShare($groupShare['id']));
+
+        // user 2 shares
+        $manager2 = $this->createManagerForUser('user2');
+        $shareData2 = [
+            'remote' => 'http://localhost',
+            'token' => 'token1',
+            'password' => '',
+            'name' => '/SharedFolder',
+            'owner' => 'foobar',
+            'shareType' => IShare::TYPE_USER,
+            'accepted' => false,
+            'user' => 'user2',
+            'remoteId' => '2342'
+        ];
+
+        $this->assertCount(1, $manager2->getOpenShares());
+        $this->assertSame(null, call_user_func_array([$manager2, 'addShare'], $shareData2));
+        $this->assertCount(2, $manager2->getOpenShares());
+
+        $this->manager->expects($this->never())->method('tryOCMEndPoint');
+        $this->manager->removeGroupShares('group1');
+
+        $user1Shares = $this->manager->getOpenShares();
+        // user share is gone, group is still there
+        $this->assertCount(1, $user1Shares);
+        $this->assertEquals($user1Shares[0]['share_type'], IShare::TYPE_USER);
+
+        // user 2 shares untouched
+        $user2Shares = $manager2->getOpenShares();
+        $this->assertCount(1, $user2Shares);
+        $this->assertEquals($user2Shares[0]['share_type'], IShare::TYPE_USER);
+        $this->assertEquals($user2Shares[0]['user'], 'user2');
+    }
+
+    /**
+     * @param array $expected
+     * @param array $actual
+     * @param int $share
+     * @param string $mountPoint
+     */
+    protected function assertExternalShareEntry($expected, $actual, $share, $mountPoint, $targetEntity) {
+        $this->assertEquals($expected['remote'], $actual['remote'], 'Asserting remote of a share #' . $share);
+        $this->assertEquals($expected['token'], $actual['share_token'], 'Asserting token of a share #' . $share);
+        $this->assertEquals($expected['name'], $actual['name'], 'Asserting name of a share #' . $share);
+        $this->assertEquals($expected['owner'], $actual['owner'], 'Asserting owner of a share #' . $share);
+        $this->assertEquals($expected['accepted'], (int)$actual['accepted'], 'Asserting accept of a share #' . $share);
+        $this->assertEquals($targetEntity, $actual['user'], 'Asserting user of a share #' . $share);
+        $this->assertEquals($mountPoint, $actual['mountpoint'], 'Asserting mountpoint of a share #' . $share);
+    }
+
+    private function assertMount($mountPoint) {
+        $mountPoint = rtrim($mountPoint, '/');
+        $mount = $this->mountManager->find($this->getFullPath($mountPoint));
+        $this->assertInstanceOf('\OCA\Files_Sharing\External\Mount', $mount);
+        $this->assertInstanceOf('\OCP\Files\Mount\IMountPoint', $mount);
+        $this->assertEquals($this->getFullPath($mountPoint), rtrim($mount->getMountPoint(), '/'));
+        $storage = $mount->getStorage();
+        $this->assertInstanceOf('\OCA\Files_Sharing\External\Storage', $storage);
+    }
+
+    private function assertNotMount($mountPoint) {
+        $mountPoint = rtrim($mountPoint, '/');
+        try {
+            $mount = $this->mountManager->find($this->getFullPath($mountPoint));
+            $this->assertInstanceOf('\OCP\Files\Mount\IMountPoint', $mount);
+            $this->assertNotEquals($this->getFullPath($mountPoint), rtrim($mount->getMountPoint(), '/'));
+        } catch (NotFoundException $e) {
+
+        }
+    }
+
+    private function getFullPath($path) {
+        return '/' . $this->uid . '/files' . $path;
+    }
 }