nextcloud / server

lib/public/Group/Events/SubAdminAddedEvent.php

Indentation +24 added lines, -24 removed lines

@@ -36,32 +36,32 @@
  */
 class SubAdminAddedEvent extends Event {
 
-	/** @var IGroup */
-	private $group;
+    /** @var IGroup */
+    private $group;
 
-	/*** @var IUser */
-	private $user;
+    /*** @var IUser */
+    private $user;
 
-	/**
-	 * @since 21.0.0
-	 */
-	public function __construct(IGroup $group, IUser $user) {
-		parent::__construct();
-		$this->group = $group;
-		$this->user = $user;
-	}
+    /**
+     * @since 21.0.0
+     */
+    public function __construct(IGroup $group, IUser $user) {
+        parent::__construct();
+        $this->group = $group;
+        $this->user = $user;
+    }
 
-	/**
-	 * @since 21.0.0
-	 */
-	public function getGroup(): IGroup {
-		return $this->group;
-	}
+    /**
+     * @since 21.0.0
+     */
+    public function getGroup(): IGroup {
+        return $this->group;
+    }
 
-	/**
-	 * @since 21.0.0
-	 */
-	public function getUser(): IUser {
-		return $this->user;
-	}
+    /**
+     * @since 21.0.0
+     */
+    public function getUser(): IUser {
+        return $this->user;
+    }
 }

lib/public/Group/Events/SubAdminRemovedEvent.php

Indentation +24 added lines, -24 removed lines

@@ -36,32 +36,32 @@
  */
 class SubAdminRemovedEvent extends Event {
 
-	/** @var IGroup */
-	private $group;
+    /** @var IGroup */
+    private $group;
 
-	/*** @var IUser */
-	private $user;
+    /*** @var IUser */
+    private $user;
 
-	/**
-	 * @since 21.0.0
-	 */
-	public function __construct(IGroup $group, IUser $user) {
-		parent::__construct();
-		$this->group = $group;
-		$this->user = $user;
-	}
+    /**
+     * @since 21.0.0
+     */
+    public function __construct(IGroup $group, IUser $user) {
+        parent::__construct();
+        $this->group = $group;
+        $this->user = $user;
+    }
 
-	/**
-	 * @since 21.0.0
-	 */
-	public function getGroup(): IGroup {
-		return $this->group;
-	}
+    /**
+     * @since 21.0.0
+     */
+    public function getGroup(): IGroup {
+        return $this->group;
+    }
 
-	/**
-	 * @since 21.0.0
-	 */
-	public function getUser(): IUser {
-		return $this->user;
-	}
+    /**
+     * @since 21.0.0
+     */
+    public function getUser(): IUser {
+        return $this->user;
+    }
 }

lib/private/SubAdmin.php

Indentation +269 added lines, -269 removed lines

@@ -44,275 +44,275 @@
 
 class SubAdmin extends PublicEmitter implements ISubAdmin {
 
-	/** @var IUserManager */
-	private $userManager;
-
-	/** @var IGroupManager */
-	private $groupManager;
-
-	/** @var IDBConnection */
-	private $dbConn;
-
-	/** @var IEventDispatcher */
-	private $eventDispatcher;
-
-	/**
-	 * @param IUserManager $userManager
-	 * @param IGroupManager $groupManager
-	 * @param IDBConnection $dbConn
-	 */
-	public function __construct(IUserManager $userManager,
-								IGroupManager $groupManager,
-								IDBConnection $dbConn,
-								IEventDispatcher $eventDispatcher) {
-		$this->userManager = $userManager;
-		$this->groupManager = $groupManager;
-		$this->dbConn = $dbConn;
-		$this->eventDispatcher = $eventDispatcher;
-
-		$this->userManager->listen('\OC\User', 'postDelete', function ($user) {
-			$this->post_deleteUser($user);
-		});
-		$this->groupManager->listen('\OC\Group', 'postDelete', function ($group) {
-			$this->post_deleteGroup($group);
-		});
-	}
-
-	/**
-	 * add a SubAdmin
-	 * @param IUser $user user to be SubAdmin
-	 * @param IGroup $group group $user becomes subadmin of
-	 */
-	public function createSubAdmin(IUser $user, IGroup $group): void {
-		$qb = $this->dbConn->getQueryBuilder();
-
-		$qb->insert('group_admin')
-			->values([
-				'gid' => $qb->createNamedParameter($group->getGID()),
-				'uid' => $qb->createNamedParameter($user->getUID())
-			])
-			->execute();
-
-		/** @depreacted 21.0.0 - use type SubAdminAddedEvent instead  */
-		$this->emit('\OC\SubAdmin', 'postCreateSubAdmin', [$user, $group]);
-		$event = new SubAdminAddedEvent($group, $user);
-		$this->eventDispatcher->dispatchTyped($event);
-	}
-
-	/**
-	 * delete a SubAdmin
-	 * @param IUser $user the user that is the SubAdmin
-	 * @param IGroup $group the group
-	 */
-	public function deleteSubAdmin(IUser $user, IGroup $group): void {
-		$qb = $this->dbConn->getQueryBuilder();
-
-		$qb->delete('group_admin')
-			->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
-			->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
-			->execute();
-
-		/** @depreacted 21.0.0 - use type SubAdminRemovedEvent instead  */
-		$this->emit('\OC\SubAdmin', 'postDeleteSubAdmin', [$user, $group]);
-		$event = new SubAdminRemovedEvent($group, $user);
-		$this->eventDispatcher->dispatchTyped($event);
-	}
-
-	/**
-	 * get groups of a SubAdmin
-	 * @param IUser $user the SubAdmin
-	 * @return IGroup[]
-	 */
-	public function getSubAdminsGroups(IUser $user): array {
-		$groupIds = $this->getSubAdminsGroupIds($user);
-
-		$groups = [];
-		foreach ($groupIds as $groupId) {
-			$group = $this->groupManager->get($groupId);
-			if ($group !== null) {
-				$groups[$group->getGID()] = $group;
-			}
-		}
-
-		return $groups;
-	}
-
-	/**
-	 * Get group ids of a SubAdmin
-	 * @param IUser $user the SubAdmin
-	 * @return string[]
-	 */
-	public function getSubAdminsGroupIds(IUser $user): array {
-		$qb = $this->dbConn->getQueryBuilder();
-
-		$result = $qb->select('gid')
-			->from('group_admin')
-			->where($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
-			->execute();
-
-		$groups = [];
-		while ($row = $result->fetch()) {
-			$groups[] = $row['gid'];
-		}
-		$result->closeCursor();
-
-		return $groups;
-	}
-
-	/**
-	 * get an array of groupid and displayName for a user
-	 * @param IUser $user
-	 * @return array ['displayName' => displayname]
-	 */
-	public function getSubAdminsGroupsName(IUser $user): array {
-		return array_map(function ($group) {
-			return ['displayName' => $group->getDisplayName()];
-		}, $this->getSubAdminsGroups($user));
-	}
-
-	/**
-	 * get SubAdmins of a group
-	 * @param IGroup $group the group
-	 * @return IUser[]
-	 */
-	public function getGroupsSubAdmins(IGroup $group): array {
-		$qb = $this->dbConn->getQueryBuilder();
-
-		$result = $qb->select('uid')
-			->from('group_admin')
-			->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
-			->execute();
-
-		$users = [];
-		while ($row = $result->fetch()) {
-			$user = $this->userManager->get($row['uid']);
-			if (!is_null($user)) {
-				$users[] = $user;
-			}
-		}
-		$result->closeCursor();
-
-		return $users;
-	}
-
-	/**
-	 * get all SubAdmins
-	 * @return array
-	 */
-	public function getAllSubAdmins(): array {
-		$qb = $this->dbConn->getQueryBuilder();
-
-		$result = $qb->select('*')
-			->from('group_admin')
-			->execute();
-
-		$subadmins = [];
-		while ($row = $result->fetch()) {
-			$user = $this->userManager->get($row['uid']);
-			$group = $this->groupManager->get($row['gid']);
-			if (!is_null($user) && !is_null($group)) {
-				$subadmins[] = [
-					'user' => $user,
-					'group' => $group
-				];
-			}
-		}
-		$result->closeCursor();
-
-		return $subadmins;
-	}
-
-	/**
-	 * checks if a user is a SubAdmin of a group
-	 * @param IUser $user
-	 * @param IGroup $group
-	 * @return bool
-	 */
-	public function isSubAdminOfGroup(IUser $user, IGroup $group): bool {
-		$qb = $this->dbConn->getQueryBuilder();
-
-		/*
+    /** @var IUserManager */
+    private $userManager;
+
+    /** @var IGroupManager */
+    private $groupManager;
+
+    /** @var IDBConnection */
+    private $dbConn;
+
+    /** @var IEventDispatcher */
+    private $eventDispatcher;
+
+    /**
+     * @param IUserManager $userManager
+     * @param IGroupManager $groupManager
+     * @param IDBConnection $dbConn
+     */
+    public function __construct(IUserManager $userManager,
+                                IGroupManager $groupManager,
+                                IDBConnection $dbConn,
+                                IEventDispatcher $eventDispatcher) {
+        $this->userManager = $userManager;
+        $this->groupManager = $groupManager;
+        $this->dbConn = $dbConn;
+        $this->eventDispatcher = $eventDispatcher;
+
+        $this->userManager->listen('\OC\User', 'postDelete', function ($user) {
+            $this->post_deleteUser($user);
+        });
+        $this->groupManager->listen('\OC\Group', 'postDelete', function ($group) {
+            $this->post_deleteGroup($group);
+        });
+    }
+
+    /**
+     * add a SubAdmin
+     * @param IUser $user user to be SubAdmin
+     * @param IGroup $group group $user becomes subadmin of
+     */
+    public function createSubAdmin(IUser $user, IGroup $group): void {
+        $qb = $this->dbConn->getQueryBuilder();
+
+        $qb->insert('group_admin')
+            ->values([
+                'gid' => $qb->createNamedParameter($group->getGID()),
+                'uid' => $qb->createNamedParameter($user->getUID())
+            ])
+            ->execute();
+
+        /** @depreacted 21.0.0 - use type SubAdminAddedEvent instead  */
+        $this->emit('\OC\SubAdmin', 'postCreateSubAdmin', [$user, $group]);
+        $event = new SubAdminAddedEvent($group, $user);
+        $this->eventDispatcher->dispatchTyped($event);
+    }
+
+    /**
+     * delete a SubAdmin
+     * @param IUser $user the user that is the SubAdmin
+     * @param IGroup $group the group
+     */
+    public function deleteSubAdmin(IUser $user, IGroup $group): void {
+        $qb = $this->dbConn->getQueryBuilder();
+
+        $qb->delete('group_admin')
+            ->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
+            ->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
+            ->execute();
+
+        /** @depreacted 21.0.0 - use type SubAdminRemovedEvent instead  */
+        $this->emit('\OC\SubAdmin', 'postDeleteSubAdmin', [$user, $group]);
+        $event = new SubAdminRemovedEvent($group, $user);
+        $this->eventDispatcher->dispatchTyped($event);
+    }
+
+    /**
+     * get groups of a SubAdmin
+     * @param IUser $user the SubAdmin
+     * @return IGroup[]
+     */
+    public function getSubAdminsGroups(IUser $user): array {
+        $groupIds = $this->getSubAdminsGroupIds($user);
+
+        $groups = [];
+        foreach ($groupIds as $groupId) {
+            $group = $this->groupManager->get($groupId);
+            if ($group !== null) {
+                $groups[$group->getGID()] = $group;
+            }
+        }
+
+        return $groups;
+    }
+
+    /**
+     * Get group ids of a SubAdmin
+     * @param IUser $user the SubAdmin
+     * @return string[]
+     */
+    public function getSubAdminsGroupIds(IUser $user): array {
+        $qb = $this->dbConn->getQueryBuilder();
+
+        $result = $qb->select('gid')
+            ->from('group_admin')
+            ->where($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
+            ->execute();
+
+        $groups = [];
+        while ($row = $result->fetch()) {
+            $groups[] = $row['gid'];
+        }
+        $result->closeCursor();
+
+        return $groups;
+    }
+
+    /**
+     * get an array of groupid and displayName for a user
+     * @param IUser $user
+     * @return array ['displayName' => displayname]
+     */
+    public function getSubAdminsGroupsName(IUser $user): array {
+        return array_map(function ($group) {
+            return ['displayName' => $group->getDisplayName()];
+        }, $this->getSubAdminsGroups($user));
+    }
+
+    /**
+     * get SubAdmins of a group
+     * @param IGroup $group the group
+     * @return IUser[]
+     */
+    public function getGroupsSubAdmins(IGroup $group): array {
+        $qb = $this->dbConn->getQueryBuilder();
+
+        $result = $qb->select('uid')
+            ->from('group_admin')
+            ->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
+            ->execute();
+
+        $users = [];
+        while ($row = $result->fetch()) {
+            $user = $this->userManager->get($row['uid']);
+            if (!is_null($user)) {
+                $users[] = $user;
+            }
+        }
+        $result->closeCursor();
+
+        return $users;
+    }
+
+    /**
+     * get all SubAdmins
+     * @return array
+     */
+    public function getAllSubAdmins(): array {
+        $qb = $this->dbConn->getQueryBuilder();
+
+        $result = $qb->select('*')
+            ->from('group_admin')
+            ->execute();
+
+        $subadmins = [];
+        while ($row = $result->fetch()) {
+            $user = $this->userManager->get($row['uid']);
+            $group = $this->groupManager->get($row['gid']);
+            if (!is_null($user) && !is_null($group)) {
+                $subadmins[] = [
+                    'user' => $user,
+                    'group' => $group
+                ];
+            }
+        }
+        $result->closeCursor();
+
+        return $subadmins;
+    }
+
+    /**
+     * checks if a user is a SubAdmin of a group
+     * @param IUser $user
+     * @param IGroup $group
+     * @return bool
+     */
+    public function isSubAdminOfGroup(IUser $user, IGroup $group): bool {
+        $qb = $this->dbConn->getQueryBuilder();
+
+        /*
 		 * Primary key is ('gid', 'uid') so max 1 result possible here
 		 */
-		$result = $qb->select('*')
-			->from('group_admin')
-			->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
-			->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
-			->execute();
-
-		$fetch = $result->fetch();
-		$result->closeCursor();
-		$result = !empty($fetch) ? true : false;
-
-		return $result;
-	}
-
-	/**
-	 * checks if a user is a SubAdmin
-	 * @param IUser $user
-	 * @return bool
-	 */
-	public function isSubAdmin(IUser $user): bool {
-		// Check if the user is already an admin
-		if ($this->groupManager->isAdmin($user->getUID())) {
-			return true;
-		}
-
-		$qb = $this->dbConn->getQueryBuilder();
-
-		$result = $qb->select('gid')
-			->from('group_admin')
-			->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
-			->setMaxResults(1)
-			->execute();
-
-		$isSubAdmin = $result->fetch();
-		$result->closeCursor();
-
-		return $isSubAdmin !== false;
-	}
-
-	/**
-	 * checks if a user is a accessible by a subadmin
-	 * @param IUser $subadmin
-	 * @param IUser $user
-	 * @return bool
-	 */
-	public function isUserAccessible(IUser $subadmin, IUser $user): bool {
-		if (!$this->isSubAdmin($subadmin)) {
-			return false;
-		}
-		if ($this->groupManager->isAdmin($user->getUID())) {
-			return false;
-		}
-
-		$accessibleGroups = $this->getSubAdminsGroupIds($subadmin);
-		$userGroups = $this->groupManager->getUserGroupIds($user);
-
-		return !empty(array_intersect($accessibleGroups, $userGroups));
-	}
-
-	/**
-	 * delete all SubAdmins by $user
-	 * @param IUser $user
-	 */
-	private function post_deleteUser(IUser $user) {
-		$qb = $this->dbConn->getQueryBuilder();
-
-		$qb->delete('group_admin')
-			->where($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
-			->execute();
-	}
-
-	/**
-	 * delete all SubAdmins by $group
-	 * @param IGroup $group
-	 */
-	private function post_deleteGroup(IGroup $group) {
-		$qb = $this->dbConn->getQueryBuilder();
-
-		$qb->delete('group_admin')
-			->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
-			->execute();
-	}
+        $result = $qb->select('*')
+            ->from('group_admin')
+            ->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
+            ->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
+            ->execute();
+
+        $fetch = $result->fetch();
+        $result->closeCursor();
+        $result = !empty($fetch) ? true : false;
+
+        return $result;
+    }
+
+    /**
+     * checks if a user is a SubAdmin
+     * @param IUser $user
+     * @return bool
+     */
+    public function isSubAdmin(IUser $user): bool {
+        // Check if the user is already an admin
+        if ($this->groupManager->isAdmin($user->getUID())) {
+            return true;
+        }
+
+        $qb = $this->dbConn->getQueryBuilder();
+
+        $result = $qb->select('gid')
+            ->from('group_admin')
+            ->andWhere($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
+            ->setMaxResults(1)
+            ->execute();
+
+        $isSubAdmin = $result->fetch();
+        $result->closeCursor();
+
+        return $isSubAdmin !== false;
+    }
+
+    /**
+     * checks if a user is a accessible by a subadmin
+     * @param IUser $subadmin
+     * @param IUser $user
+     * @return bool
+     */
+    public function isUserAccessible(IUser $subadmin, IUser $user): bool {
+        if (!$this->isSubAdmin($subadmin)) {
+            return false;
+        }
+        if ($this->groupManager->isAdmin($user->getUID())) {
+            return false;
+        }
+
+        $accessibleGroups = $this->getSubAdminsGroupIds($subadmin);
+        $userGroups = $this->groupManager->getUserGroupIds($user);
+
+        return !empty(array_intersect($accessibleGroups, $userGroups));
+    }
+
+    /**
+     * delete all SubAdmins by $user
+     * @param IUser $user
+     */
+    private function post_deleteUser(IUser $user) {
+        $qb = $this->dbConn->getQueryBuilder();
+
+        $qb->delete('group_admin')
+            ->where($qb->expr()->eq('uid', $qb->createNamedParameter($user->getUID())))
+            ->execute();
+    }
+
+    /**
+     * delete all SubAdmins by $group
+     * @param IGroup $group
+     */
+    private function post_deleteGroup(IGroup $group) {
+        $qb = $this->dbConn->getQueryBuilder();
+
+        $qb->delete('group_admin')
+            ->where($qb->expr()->eq('gid', $qb->createNamedParameter($group->getGID())))
+            ->execute();
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -70,10 +70,10 @@ 
 		$this->dbConn = $dbConn;
 		$this->eventDispatcher = $eventDispatcher;
 
-		$this->userManager->listen('\OC\User', 'postDelete', function ($user) {
+		$this->userManager->listen('\OC\User', 'postDelete', function($user) {
 			$this->post_deleteUser($user);
 		});
-		$this->groupManager->listen('\OC\Group', 'postDelete', function ($group) {
+		$this->groupManager->listen('\OC\Group', 'postDelete', function($group) {
 			$this->post_deleteGroup($group);
 		});
 	}
@@ -165,7 +165,7 @@ 
 	 * @return array ['displayName' => displayname]
 	 */
 	public function getSubAdminsGroupsName(IUser $user): array {
-		return array_map(function ($group) {
+		return array_map(function($group) {
 			return ['displayName' => $group->getDisplayName()];
 		}, $this->getSubAdminsGroups($user));
 	}

lib/private/Group/Manager.php

Indentation +359 added lines, -359 removed lines

@@ -65,363 +65,363 @@
  * @package OC\Group
  */
 class Manager extends PublicEmitter implements IGroupManager {
-	/** @var GroupInterface[] */
-	private $backends = [];
-
-	/** @var \OC\User\Manager */
-	private $userManager;
-	/** @var EventDispatcherInterface */
-	private $dispatcher;
-	/** @var ILogger */
-	private $logger;
-
-	/** @var \OC\Group\Group[] */
-	private $cachedGroups = [];
-
-	/** @var (string[])[] */
-	private $cachedUserGroups = [];
-
-	/** @var \OC\SubAdmin */
-	private $subAdmin = null;
-
-	/**
-	 * @param \OC\User\Manager $userManager
-	 * @param EventDispatcherInterface $dispatcher
-	 * @param ILogger $logger
-	 */
-	public function __construct(\OC\User\Manager $userManager,
-								EventDispatcherInterface $dispatcher,
-								ILogger $logger) {
-		$this->userManager = $userManager;
-		$this->dispatcher = $dispatcher;
-		$this->logger = $logger;
-
-		$cachedGroups = &$this->cachedGroups;
-		$cachedUserGroups = &$this->cachedUserGroups;
-		$this->listen('\OC\Group', 'postDelete', function ($group) use (&$cachedGroups, &$cachedUserGroups) {
-			/**
-			 * @var \OC\Group\Group $group
-			 */
-			unset($cachedGroups[$group->getGID()]);
-			$cachedUserGroups = [];
-		});
-		$this->listen('\OC\Group', 'postAddUser', function ($group) use (&$cachedUserGroups) {
-			/**
-			 * @var \OC\Group\Group $group
-			 */
-			$cachedUserGroups = [];
-		});
-		$this->listen('\OC\Group', 'postRemoveUser', function ($group) use (&$cachedUserGroups) {
-			/**
-			 * @var \OC\Group\Group $group
-			 */
-			$cachedUserGroups = [];
-		});
-	}
-
-	/**
-	 * Checks whether a given backend is used
-	 *
-	 * @param string $backendClass Full classname including complete namespace
-	 * @return bool
-	 */
-	public function isBackendUsed($backendClass) {
-		$backendClass = strtolower(ltrim($backendClass, '\\'));
-
-		foreach ($this->backends as $backend) {
-			if (strtolower(get_class($backend)) === $backendClass) {
-				return true;
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * @param \OCP\GroupInterface $backend
-	 */
-	public function addBackend($backend) {
-		$this->backends[] = $backend;
-		$this->clearCaches();
-	}
-
-	public function clearBackends() {
-		$this->backends = [];
-		$this->clearCaches();
-	}
-
-	/**
-	 * Get the active backends
-	 *
-	 * @return \OCP\GroupInterface[]
-	 */
-	public function getBackends() {
-		return $this->backends;
-	}
-
-
-	protected function clearCaches() {
-		$this->cachedGroups = [];
-		$this->cachedUserGroups = [];
-	}
-
-	/**
-	 * @param string $gid
-	 * @return IGroup|null
-	 */
-	public function get($gid) {
-		if (isset($this->cachedGroups[$gid])) {
-			return $this->cachedGroups[$gid];
-		}
-		return $this->getGroupObject($gid);
-	}
-
-	/**
-	 * @param string $gid
-	 * @param string $displayName
-	 * @return \OCP\IGroup|null
-	 */
-	protected function getGroupObject($gid, $displayName = null) {
-		$backends = [];
-		foreach ($this->backends as $backend) {
-			if ($backend->implementsActions(Backend::GROUP_DETAILS)) {
-				$groupData = $backend->getGroupDetails($gid);
-				if (is_array($groupData) && !empty($groupData)) {
-					// take the display name from the first backend that has a non-null one
-					if (is_null($displayName) && isset($groupData['displayName'])) {
-						$displayName = $groupData['displayName'];
-					}
-					$backends[] = $backend;
-				}
-			} elseif ($backend->groupExists($gid)) {
-				$backends[] = $backend;
-			}
-		}
-		if (count($backends) === 0) {
-			return null;
-		}
-		$this->cachedGroups[$gid] = new Group($gid, $backends, $this->dispatcher, $this->userManager, $this, $displayName);
-		return $this->cachedGroups[$gid];
-	}
-
-	/**
-	 * @param string $gid
-	 * @return bool
-	 */
-	public function groupExists($gid) {
-		return $this->get($gid) instanceof IGroup;
-	}
-
-	/**
-	 * @param string $gid
-	 * @return IGroup|null
-	 */
-	public function createGroup($gid) {
-		if ($gid === '' || $gid === null) {
-			return null;
-		} elseif ($group = $this->get($gid)) {
-			return $group;
-		} else {
-			$this->emit('\OC\Group', 'preCreate', [$gid]);
-			foreach ($this->backends as $backend) {
-				if ($backend->implementsActions(Backend::CREATE_GROUP)) {
-					if ($backend->createGroup($gid)) {
-						$group = $this->getGroupObject($gid);
-						$this->emit('\OC\Group', 'postCreate', [$group]);
-						return $group;
-					}
-				}
-			}
-			return null;
-		}
-	}
-
-	/**
-	 * @param string $search
-	 * @param int $limit
-	 * @param int $offset
-	 * @return \OC\Group\Group[]
-	 */
-	public function search($search, $limit = null, $offset = null) {
-		$groups = [];
-		foreach ($this->backends as $backend) {
-			$groupIds = $backend->getGroups($search, $limit, $offset);
-			foreach ($groupIds as $groupId) {
-				$aGroup = $this->get($groupId);
-				if ($aGroup instanceof IGroup) {
-					$groups[$groupId] = $aGroup;
-				} else {
-					$this->logger->debug('Group "' . $groupId . '" was returned by search but not found through direct access', ['app' => 'core']);
-				}
-			}
-			if (!is_null($limit) and $limit <= 0) {
-				return array_values($groups);
-			}
-		}
-		return array_values($groups);
-	}
-
-	/**
-	 * @param IUser|null $user
-	 * @return \OC\Group\Group[]
-	 */
-	public function getUserGroups(IUser $user = null) {
-		if (!$user instanceof IUser) {
-			return [];
-		}
-		return $this->getUserIdGroups($user->getUID());
-	}
-
-	/**
-	 * @param string $uid the user id
-	 * @return \OC\Group\Group[]
-	 */
-	public function getUserIdGroups($uid) {
-		$groups = [];
-
-		foreach ($this->getUserIdGroupIds($uid) as $groupId) {
-			$aGroup = $this->get($groupId);
-			if ($aGroup instanceof IGroup) {
-				$groups[$groupId] = $aGroup;
-			} else {
-				$this->logger->debug('User "' . $uid . '" belongs to deleted group: "' . $groupId . '"', ['app' => 'core']);
-			}
-		}
-
-		return $groups;
-	}
-
-	/**
-	 * Checks if a userId is in the admin group
-	 *
-	 * @param string $userId
-	 * @return bool if admin
-	 */
-	public function isAdmin($userId) {
-		foreach ($this->backends as $backend) {
-			if ($backend->implementsActions(Backend::IS_ADMIN) && $backend->isAdmin($userId)) {
-				return true;
-			}
-		}
-		return $this->isInGroup($userId, 'admin');
-	}
-
-	/**
-	 * Checks if a userId is in a group
-	 *
-	 * @param string $userId
-	 * @param string $group
-	 * @return bool if in group
-	 */
-	public function isInGroup($userId, $group) {
-		return array_search($group, $this->getUserIdGroupIds($userId)) !== false;
-	}
-
-	/**
-	 * get a list of group ids for a user
-	 *
-	 * @param IUser $user
-	 * @return array with group ids
-	 */
-	public function getUserGroupIds(IUser $user) {
-		return $this->getUserIdGroupIds($user->getUID());
-	}
-
-	/**
-	 * @param string $uid the user id
-	 * @return GroupInterface[]
-	 */
-	private function getUserIdGroupIds($uid) {
-		if (!isset($this->cachedUserGroups[$uid])) {
-			$groups = [];
-			foreach ($this->backends as $backend) {
-				if ($groupIds = $backend->getUserGroups($uid)) {
-					$groups = array_merge($groups, $groupIds);
-				}
-			}
-			$this->cachedUserGroups[$uid] = $groups;
-		}
-
-		return $this->cachedUserGroups[$uid];
-	}
-
-	/**
-	 * get an array of groupid and displayName for a user
-	 *
-	 * @param IUser $user
-	 * @return array ['displayName' => displayname]
-	 */
-	public function getUserGroupNames(IUser $user) {
-		return array_map(function ($group) {
-			return ['displayName' => $group->getDisplayName()];
-		}, $this->getUserGroups($user));
-	}
-
-	/**
-	 * get a list of all display names in a group
-	 *
-	 * @param string $gid
-	 * @param string $search
-	 * @param int $limit
-	 * @param int $offset
-	 * @return array an array of display names (value) and user ids (key)
-	 */
-	public function displayNamesInGroup($gid, $search = '', $limit = -1, $offset = 0) {
-		$group = $this->get($gid);
-		if (is_null($group)) {
-			return [];
-		}
-
-		$search = trim($search);
-		$groupUsers = [];
-
-		if (!empty($search)) {
-			// only user backends have the capability to do a complex search for users
-			$searchOffset = 0;
-			$searchLimit = $limit * 100;
-			if ($limit === -1) {
-				$searchLimit = 500;
-			}
-
-			do {
-				$filteredUsers = $this->userManager->searchDisplayName($search, $searchLimit, $searchOffset);
-				foreach ($filteredUsers as $filteredUser) {
-					if ($group->inGroup($filteredUser)) {
-						$groupUsers[] = $filteredUser;
-					}
-				}
-				$searchOffset += $searchLimit;
-			} while (count($groupUsers) < $searchLimit + $offset && count($filteredUsers) >= $searchLimit);
-
-			if ($limit === -1) {
-				$groupUsers = array_slice($groupUsers, $offset);
-			} else {
-				$groupUsers = array_slice($groupUsers, $offset, $limit);
-			}
-		} else {
-			$groupUsers = $group->searchUsers('', $limit, $offset);
-		}
-
-		$matchingUsers = [];
-		foreach ($groupUsers as $groupUser) {
-			$matchingUsers[(string) $groupUser->getUID()] = $groupUser->getDisplayName();
-		}
-		return $matchingUsers;
-	}
-
-	/**
-	 * @return \OC\SubAdmin
-	 */
-	public function getSubAdmin() {
-		if (!$this->subAdmin) {
-			$this->subAdmin = new \OC\SubAdmin(
-				$this->userManager,
-				$this,
-				\OC::$server->getDatabaseConnection(),
-				\OC::$server->get(IEventDispatcher::class)
-			);
-		}
-
-		return $this->subAdmin;
-	}
+    /** @var GroupInterface[] */
+    private $backends = [];
+
+    /** @var \OC\User\Manager */
+    private $userManager;
+    /** @var EventDispatcherInterface */
+    private $dispatcher;
+    /** @var ILogger */
+    private $logger;
+
+    /** @var \OC\Group\Group[] */
+    private $cachedGroups = [];
+
+    /** @var (string[])[] */
+    private $cachedUserGroups = [];
+
+    /** @var \OC\SubAdmin */
+    private $subAdmin = null;
+
+    /**
+     * @param \OC\User\Manager $userManager
+     * @param EventDispatcherInterface $dispatcher
+     * @param ILogger $logger
+     */
+    public function __construct(\OC\User\Manager $userManager,
+                                EventDispatcherInterface $dispatcher,
+                                ILogger $logger) {
+        $this->userManager = $userManager;
+        $this->dispatcher = $dispatcher;
+        $this->logger = $logger;
+
+        $cachedGroups = &$this->cachedGroups;
+        $cachedUserGroups = &$this->cachedUserGroups;
+        $this->listen('\OC\Group', 'postDelete', function ($group) use (&$cachedGroups, &$cachedUserGroups) {
+            /**
+             * @var \OC\Group\Group $group
+             */
+            unset($cachedGroups[$group->getGID()]);
+            $cachedUserGroups = [];
+        });
+        $this->listen('\OC\Group', 'postAddUser', function ($group) use (&$cachedUserGroups) {
+            /**
+             * @var \OC\Group\Group $group
+             */
+            $cachedUserGroups = [];
+        });
+        $this->listen('\OC\Group', 'postRemoveUser', function ($group) use (&$cachedUserGroups) {
+            /**
+             * @var \OC\Group\Group $group
+             */
+            $cachedUserGroups = [];
+        });
+    }
+
+    /**
+     * Checks whether a given backend is used
+     *
+     * @param string $backendClass Full classname including complete namespace
+     * @return bool
+     */
+    public function isBackendUsed($backendClass) {
+        $backendClass = strtolower(ltrim($backendClass, '\\'));
+
+        foreach ($this->backends as $backend) {
+            if (strtolower(get_class($backend)) === $backendClass) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * @param \OCP\GroupInterface $backend
+     */
+    public function addBackend($backend) {
+        $this->backends[] = $backend;
+        $this->clearCaches();
+    }
+
+    public function clearBackends() {
+        $this->backends = [];
+        $this->clearCaches();
+    }
+
+    /**
+     * Get the active backends
+     *
+     * @return \OCP\GroupInterface[]
+     */
+    public function getBackends() {
+        return $this->backends;
+    }
+
+
+    protected function clearCaches() {
+        $this->cachedGroups = [];
+        $this->cachedUserGroups = [];
+    }
+
+    /**
+     * @param string $gid
+     * @return IGroup|null
+     */
+    public function get($gid) {
+        if (isset($this->cachedGroups[$gid])) {
+            return $this->cachedGroups[$gid];
+        }
+        return $this->getGroupObject($gid);
+    }
+
+    /**
+     * @param string $gid
+     * @param string $displayName
+     * @return \OCP\IGroup|null
+     */
+    protected function getGroupObject($gid, $displayName = null) {
+        $backends = [];
+        foreach ($this->backends as $backend) {
+            if ($backend->implementsActions(Backend::GROUP_DETAILS)) {
+                $groupData = $backend->getGroupDetails($gid);
+                if (is_array($groupData) && !empty($groupData)) {
+                    // take the display name from the first backend that has a non-null one
+                    if (is_null($displayName) && isset($groupData['displayName'])) {
+                        $displayName = $groupData['displayName'];
+                    }
+                    $backends[] = $backend;
+                }
+            } elseif ($backend->groupExists($gid)) {
+                $backends[] = $backend;
+            }
+        }
+        if (count($backends) === 0) {
+            return null;
+        }
+        $this->cachedGroups[$gid] = new Group($gid, $backends, $this->dispatcher, $this->userManager, $this, $displayName);
+        return $this->cachedGroups[$gid];
+    }
+
+    /**
+     * @param string $gid
+     * @return bool
+     */
+    public function groupExists($gid) {
+        return $this->get($gid) instanceof IGroup;
+    }
+
+    /**
+     * @param string $gid
+     * @return IGroup|null
+     */
+    public function createGroup($gid) {
+        if ($gid === '' || $gid === null) {
+            return null;
+        } elseif ($group = $this->get($gid)) {
+            return $group;
+        } else {
+            $this->emit('\OC\Group', 'preCreate', [$gid]);
+            foreach ($this->backends as $backend) {
+                if ($backend->implementsActions(Backend::CREATE_GROUP)) {
+                    if ($backend->createGroup($gid)) {
+                        $group = $this->getGroupObject($gid);
+                        $this->emit('\OC\Group', 'postCreate', [$group]);
+                        return $group;
+                    }
+                }
+            }
+            return null;
+        }
+    }
+
+    /**
+     * @param string $search
+     * @param int $limit
+     * @param int $offset
+     * @return \OC\Group\Group[]
+     */
+    public function search($search, $limit = null, $offset = null) {
+        $groups = [];
+        foreach ($this->backends as $backend) {
+            $groupIds = $backend->getGroups($search, $limit, $offset);
+            foreach ($groupIds as $groupId) {
+                $aGroup = $this->get($groupId);
+                if ($aGroup instanceof IGroup) {
+                    $groups[$groupId] = $aGroup;
+                } else {
+                    $this->logger->debug('Group "' . $groupId . '" was returned by search but not found through direct access', ['app' => 'core']);
+                }
+            }
+            if (!is_null($limit) and $limit <= 0) {
+                return array_values($groups);
+            }
+        }
+        return array_values($groups);
+    }
+
+    /**
+     * @param IUser|null $user
+     * @return \OC\Group\Group[]
+     */
+    public function getUserGroups(IUser $user = null) {
+        if (!$user instanceof IUser) {
+            return [];
+        }
+        return $this->getUserIdGroups($user->getUID());
+    }
+
+    /**
+     * @param string $uid the user id
+     * @return \OC\Group\Group[]
+     */
+    public function getUserIdGroups($uid) {
+        $groups = [];
+
+        foreach ($this->getUserIdGroupIds($uid) as $groupId) {
+            $aGroup = $this->get($groupId);
+            if ($aGroup instanceof IGroup) {
+                $groups[$groupId] = $aGroup;
+            } else {
+                $this->logger->debug('User "' . $uid . '" belongs to deleted group: "' . $groupId . '"', ['app' => 'core']);
+            }
+        }
+
+        return $groups;
+    }
+
+    /**
+     * Checks if a userId is in the admin group
+     *
+     * @param string $userId
+     * @return bool if admin
+     */
+    public function isAdmin($userId) {
+        foreach ($this->backends as $backend) {
+            if ($backend->implementsActions(Backend::IS_ADMIN) && $backend->isAdmin($userId)) {
+                return true;
+            }
+        }
+        return $this->isInGroup($userId, 'admin');
+    }
+
+    /**
+     * Checks if a userId is in a group
+     *
+     * @param string $userId
+     * @param string $group
+     * @return bool if in group
+     */
+    public function isInGroup($userId, $group) {
+        return array_search($group, $this->getUserIdGroupIds($userId)) !== false;
+    }
+
+    /**
+     * get a list of group ids for a user
+     *
+     * @param IUser $user
+     * @return array with group ids
+     */
+    public function getUserGroupIds(IUser $user) {
+        return $this->getUserIdGroupIds($user->getUID());
+    }
+
+    /**
+     * @param string $uid the user id
+     * @return GroupInterface[]
+     */
+    private function getUserIdGroupIds($uid) {
+        if (!isset($this->cachedUserGroups[$uid])) {
+            $groups = [];
+            foreach ($this->backends as $backend) {
+                if ($groupIds = $backend->getUserGroups($uid)) {
+                    $groups = array_merge($groups, $groupIds);
+                }
+            }
+            $this->cachedUserGroups[$uid] = $groups;
+        }
+
+        return $this->cachedUserGroups[$uid];
+    }
+
+    /**
+     * get an array of groupid and displayName for a user
+     *
+     * @param IUser $user
+     * @return array ['displayName' => displayname]
+     */
+    public function getUserGroupNames(IUser $user) {
+        return array_map(function ($group) {
+            return ['displayName' => $group->getDisplayName()];
+        }, $this->getUserGroups($user));
+    }
+
+    /**
+     * get a list of all display names in a group
+     *
+     * @param string $gid
+     * @param string $search
+     * @param int $limit
+     * @param int $offset
+     * @return array an array of display names (value) and user ids (key)
+     */
+    public function displayNamesInGroup($gid, $search = '', $limit = -1, $offset = 0) {
+        $group = $this->get($gid);
+        if (is_null($group)) {
+            return [];
+        }
+
+        $search = trim($search);
+        $groupUsers = [];
+
+        if (!empty($search)) {
+            // only user backends have the capability to do a complex search for users
+            $searchOffset = 0;
+            $searchLimit = $limit * 100;
+            if ($limit === -1) {
+                $searchLimit = 500;
+            }
+
+            do {
+                $filteredUsers = $this->userManager->searchDisplayName($search, $searchLimit, $searchOffset);
+                foreach ($filteredUsers as $filteredUser) {
+                    if ($group->inGroup($filteredUser)) {
+                        $groupUsers[] = $filteredUser;
+                    }
+                }
+                $searchOffset += $searchLimit;
+            } while (count($groupUsers) < $searchLimit + $offset && count($filteredUsers) >= $searchLimit);
+
+            if ($limit === -1) {
+                $groupUsers = array_slice($groupUsers, $offset);
+            } else {
+                $groupUsers = array_slice($groupUsers, $offset, $limit);
+            }
+        } else {
+            $groupUsers = $group->searchUsers('', $limit, $offset);
+        }
+
+        $matchingUsers = [];
+        foreach ($groupUsers as $groupUser) {
+            $matchingUsers[(string) $groupUser->getUID()] = $groupUser->getDisplayName();
+        }
+        return $matchingUsers;
+    }
+
+    /**
+     * @return \OC\SubAdmin
+     */
+    public function getSubAdmin() {
+        if (!$this->subAdmin) {
+            $this->subAdmin = new \OC\SubAdmin(
+                $this->userManager,
+                $this,
+                \OC::$server->getDatabaseConnection(),
+                \OC::$server->get(IEventDispatcher::class)
+            );
+        }
+
+        return $this->subAdmin;
+    }
 }