nextcloud / server

apps/theming/lib/Settings/Personal.php

Indentation +76 added lines, -76 removed lines

@@ -20,90 +20,90 @@
 
 class Personal implements ISettings {
 
-	public function __construct(
-		private string $userId,
-		private IConfig $config,
-		private ThemesService $themesService,
-		private IInitialState $initialStateService,
-		private ThemingDefaults $themingDefaults,
-		private INavigationManager $navigationManager,
-	) {
-	}
+    public function __construct(
+        private string $userId,
+        private IConfig $config,
+        private ThemesService $themesService,
+        private IInitialState $initialStateService,
+        private ThemingDefaults $themingDefaults,
+        private INavigationManager $navigationManager,
+    ) {
+    }
 
-	public function getForm(): TemplateResponse {
-		$enforcedTheme = $this->config->getSystemValueString('enforce_theme', '');
+    public function getForm(): TemplateResponse {
+        $enforcedTheme = $this->config->getSystemValueString('enforce_theme', '');
 
-		$themes = array_map(function ($theme) {
-			return [
-				'id' => $theme->getId(),
-				'type' => $theme->getType(),
-				'title' => $theme->getTitle(),
-				'enableLabel' => $theme->getEnableLabel(),
-				'description' => $theme->getDescription(),
-				'enabled' => $this->themesService->isEnabled($theme),
-			];
-		}, $this->themesService->getThemes());
+        $themes = array_map(function ($theme) {
+            return [
+                'id' => $theme->getId(),
+                'type' => $theme->getType(),
+                'title' => $theme->getTitle(),
+                'enableLabel' => $theme->getEnableLabel(),
+                'description' => $theme->getDescription(),
+                'enabled' => $this->themesService->isEnabled($theme),
+            ];
+        }, $this->themesService->getThemes());
 
-		if ($enforcedTheme !== '') {
-			$themes = array_filter($themes, function ($theme) use ($enforcedTheme) {
-				return $theme['type'] !== ITheme::TYPE_THEME || $theme['id'] === $enforcedTheme;
-			});
-		}
+        if ($enforcedTheme !== '') {
+            $themes = array_filter($themes, function ($theme) use ($enforcedTheme) {
+                return $theme['type'] !== ITheme::TYPE_THEME || $theme['id'] === $enforcedTheme;
+            });
+        }
 
-		// Get the default entry enforced by admin
-		$forcedDefaultEntry = $this->navigationManager->getDefaultEntryIdForUser(null, false);
+        // Get the default entry enforced by admin
+        $forcedDefaultEntry = $this->navigationManager->getDefaultEntryIdForUser(null, false);
 
-		/** List of all shipped backgrounds */
-		$this->initialStateService->provideInitialState('shippedBackgrounds', BackgroundService::SHIPPED_BACKGROUNDS);
+        /** List of all shipped backgrounds */
+        $this->initialStateService->provideInitialState('shippedBackgrounds', BackgroundService::SHIPPED_BACKGROUNDS);
 
-		/**
-		 * Admin theming
-		 */
-		$this->initialStateService->provideInitialState('themingDefaults', [
-			/** URL of admin configured background image */
-			'backgroundImage' => $this->themingDefaults->getBackground(),
-			/** `backgroundColor` if disabled, mime type if defined and empty by default */
-			'backgroundMime' => $this->config->getAppValue('theming', 'backgroundMime', ''),
-			/** Admin configured background color */
-			'backgroundColor' => $this->themingDefaults->getDefaultColorBackground(),
-			/** Admin configured primary color */
-			'primaryColor' => $this->themingDefaults->getDefaultColorPrimary(),
-			/** Nextcloud default background image */
-			'defaultShippedBackground' => BackgroundService::DEFAULT_BACKGROUND_IMAGE,
-		]);
+        /**
+         * Admin theming
+         */
+        $this->initialStateService->provideInitialState('themingDefaults', [
+            /** URL of admin configured background image */
+            'backgroundImage' => $this->themingDefaults->getBackground(),
+            /** `backgroundColor` if disabled, mime type if defined and empty by default */
+            'backgroundMime' => $this->config->getAppValue('theming', 'backgroundMime', ''),
+            /** Admin configured background color */
+            'backgroundColor' => $this->themingDefaults->getDefaultColorBackground(),
+            /** Admin configured primary color */
+            'primaryColor' => $this->themingDefaults->getDefaultColorPrimary(),
+            /** Nextcloud default background image */
+            'defaultShippedBackground' => BackgroundService::DEFAULT_BACKGROUND_IMAGE,
+        ]);
 
-		$this->initialStateService->provideInitialState('userBackgroundImage', $this->config->getUserValue($this->userId, 'theming', 'background_image', BackgroundService::BACKGROUND_DEFAULT));
-		$this->initialStateService->provideInitialState('themes', array_values($themes));
-		$this->initialStateService->provideInitialState('enforceTheme', $enforcedTheme);
-		$this->initialStateService->provideInitialState('isUserThemingDisabled', $this->themingDefaults->isUserThemingDisabled());
-		$this->initialStateService->provideInitialState('enableBlurFilter', $this->config->getUserValue($this->userId, 'theming', 'force_enable_blur_filter', ''));
-		$this->initialStateService->provideInitialState('navigationBar', [
-			'userAppOrder' => json_decode($this->config->getUserValue($this->userId, 'core', 'apporder', '[]'), true, flags:JSON_THROW_ON_ERROR),
-			'enforcedDefaultApp' => $forcedDefaultEntry
-		]);
+        $this->initialStateService->provideInitialState('userBackgroundImage', $this->config->getUserValue($this->userId, 'theming', 'background_image', BackgroundService::BACKGROUND_DEFAULT));
+        $this->initialStateService->provideInitialState('themes', array_values($themes));
+        $this->initialStateService->provideInitialState('enforceTheme', $enforcedTheme);
+        $this->initialStateService->provideInitialState('isUserThemingDisabled', $this->themingDefaults->isUserThemingDisabled());
+        $this->initialStateService->provideInitialState('enableBlurFilter', $this->config->getUserValue($this->userId, 'theming', 'force_enable_blur_filter', ''));
+        $this->initialStateService->provideInitialState('navigationBar', [
+            'userAppOrder' => json_decode($this->config->getUserValue($this->userId, 'core', 'apporder', '[]'), true, flags:JSON_THROW_ON_ERROR),
+            'enforcedDefaultApp' => $forcedDefaultEntry
+        ]);
 
-		Util::addStyle(Application::APP_ID, 'settings-personal');
-		Util::addScript(Application::APP_ID, 'settings-personal');
-		return new TemplateResponse(Application::APP_ID, 'settings-personal');
-	}
+        Util::addStyle(Application::APP_ID, 'settings-personal');
+        Util::addScript(Application::APP_ID, 'settings-personal');
+        return new TemplateResponse(Application::APP_ID, 'settings-personal');
+    }
 
-	/**
-	 * @return string the section ID, e.g. 'sharing'
-	 * @since 9.1
-	 */
-	public function getSection(): string {
-		return Application::APP_ID;
-	}
+    /**
+     * @return string the section ID, e.g. 'sharing'
+     * @since 9.1
+     */
+    public function getSection(): string {
+        return Application::APP_ID;
+    }
 
-	/**
-	 * @return int whether the form should be rather on the top or bottom of
-	 *             the admin section. The forms are arranged in ascending order of the
-	 *             priority values. It is required to return a value between 0 and 100.
-	 *
-	 * E.g.: 70
-	 * @since 9.1
-	 */
-	public function getPriority(): int {
-		return 40;
-	}
+    /**
+     * @return int whether the form should be rather on the top or bottom of
+     *             the admin section. The forms are arranged in ascending order of the
+     *             priority values. It is required to return a value between 0 and 100.
+     *
+     * E.g.: 70
+     * @since 9.1
+     */
+    public function getPriority(): int {
+        return 40;
+    }
 }

apps/theming/lib/Settings/PersonalSection.php

Indentation +53 added lines, -53 removed lines

@@ -13,61 +13,61 @@
 
 class PersonalSection implements IIconSection {
 
-	/**
-	 * Personal Section constructor.
-	 *
-	 * @param string $appName
-	 * @param IURLGenerator $urlGenerator
-	 * @param IL10N $l
-	 */
-	public function __construct(
-		private IURLGenerator $urlGenerator,
-		private IL10N $l,
-	) {
-	}
+    /**
+     * Personal Section constructor.
+     *
+     * @param string $appName
+     * @param IURLGenerator $urlGenerator
+     * @param IL10N $l
+     */
+    public function __construct(
+        private IURLGenerator $urlGenerator,
+        private IL10N $l,
+    ) {
+    }
 
-	/**
-	 * returns the relative path to an 16*16 icon describing the section.
-	 * e.g. '/core/img/places/files.svg'
-	 *
-	 * @returns string
-	 * @since 13.0.0
-	 */
-	public function getIcon() {
-		return $this->urlGenerator->imagePath(Application::APP_ID, 'accessibility-dark.svg');
-	}
+    /**
+     * returns the relative path to an 16*16 icon describing the section.
+     * e.g. '/core/img/places/files.svg'
+     *
+     * @returns string
+     * @since 13.0.0
+     */
+    public function getIcon() {
+        return $this->urlGenerator->imagePath(Application::APP_ID, 'accessibility-dark.svg');
+    }
 
-	/**
-	 * returns the ID of the section. It is supposed to be a lower case string,
-	 * e.g. 'ldap'
-	 *
-	 * @returns string
-	 * @since 9.1
-	 */
-	public function getID() {
-		return Application::APP_ID;
-	}
+    /**
+     * returns the ID of the section. It is supposed to be a lower case string,
+     * e.g. 'ldap'
+     *
+     * @returns string
+     * @since 9.1
+     */
+    public function getID() {
+        return Application::APP_ID;
+    }
 
-	/**
-	 * returns the translated name as it should be displayed, e.g. 'LDAP / AD
-	 * integration'. Use the L10N service to translate it.
-	 *
-	 * @return string
-	 * @since 9.1
-	 */
-	public function getName() {
-		return $this->l->t('Appearance and accessibility');
-	}
+    /**
+     * returns the translated name as it should be displayed, e.g. 'LDAP / AD
+     * integration'. Use the L10N service to translate it.
+     *
+     * @return string
+     * @since 9.1
+     */
+    public function getName() {
+        return $this->l->t('Appearance and accessibility');
+    }
 
-	/**
-	 * @return int whether the form should be rather on the top or bottom of
-	 *             the settings navigation. The sections are arranged in ascending order of
-	 *             the priority values. It is required to return a value between 0 and 99.
-	 *
-	 * E.g.: 70
-	 * @since 9.1
-	 */
-	public function getPriority() {
-		return 15;
-	}
+    /**
+     * @return int whether the form should be rather on the top or bottom of
+     *             the settings navigation. The sections are arranged in ascending order of
+     *             the priority values. It is required to return a value between 0 and 99.
+     *
+     * E.g.: 70
+     * @since 9.1
+     */
+    public function getPriority() {
+        return 15;
+    }
 }

apps/theming/lib/Settings/Admin.php

Indentation +79 added lines, -79 removed lines

@@ -22,92 +22,92 @@
 
 class Admin implements IDelegatedSettings {
 
-	public function __construct(
-		private IConfig $config,
-		private IL10N $l,
-		private ThemingDefaults $themingDefaults,
-		private IInitialState $initialState,
-		private IURLGenerator $urlGenerator,
-		private ImageManager $imageManager,
-		private INavigationManager $navigationManager,
-	) {
-	}
+    public function __construct(
+        private IConfig $config,
+        private IL10N $l,
+        private ThemingDefaults $themingDefaults,
+        private IInitialState $initialState,
+        private IURLGenerator $urlGenerator,
+        private ImageManager $imageManager,
+        private INavigationManager $navigationManager,
+    ) {
+    }
 
-	/**
-	 * @return TemplateResponse
-	 */
-	public function getForm(): TemplateResponse {
-		$themeable = true;
-		$errorMessage = '';
-		$theme = $this->config->getSystemValue('theme', '');
-		if ($theme !== '') {
-			$themeable = false;
-			$errorMessage = $this->l->t('You are already using a custom theme. Theming app settings might be overwritten by that.');
-		}
+    /**
+     * @return TemplateResponse
+     */
+    public function getForm(): TemplateResponse {
+        $themeable = true;
+        $errorMessage = '';
+        $theme = $this->config->getSystemValue('theme', '');
+        if ($theme !== '') {
+            $themeable = false;
+            $errorMessage = $this->l->t('You are already using a custom theme. Theming app settings might be overwritten by that.');
+        }
 
-		$allowedMimeTypes = array_reduce(ThemingController::VALID_UPLOAD_KEYS, function ($carry, $key) {
-			$carry[$key] = $this->imageManager->getSupportedUploadImageFormats($key);
-			return $carry;
-		}, []);
+        $allowedMimeTypes = array_reduce(ThemingController::VALID_UPLOAD_KEYS, function ($carry, $key) {
+            $carry[$key] = $this->imageManager->getSupportedUploadImageFormats($key);
+            return $carry;
+        }, []);
 
-		$this->initialState->provideInitialState('adminThemingInfo', [
-			'isThemeable' => $themeable,
-			'notThemeableErrorMessage' => $errorMessage,
-			'defaultBackgroundURL' => $this->urlGenerator->linkTo(Application::APP_ID, 'img/background/' . BackgroundService::DEFAULT_BACKGROUND_IMAGE),
-			'defaultBackgroundColor' => BackgroundService::DEFAULT_BACKGROUND_COLOR,
-			'docUrl' => $this->urlGenerator->linkToDocs('admin-theming'),
-			'docUrlIcons' => $this->urlGenerator->linkToDocs('admin-theming-icons'),
-			'canThemeIcons' => $this->imageManager->shouldReplaceIcons(),
-		]);
+        $this->initialState->provideInitialState('adminThemingInfo', [
+            'isThemeable' => $themeable,
+            'notThemeableErrorMessage' => $errorMessage,
+            'defaultBackgroundURL' => $this->urlGenerator->linkTo(Application::APP_ID, 'img/background/' . BackgroundService::DEFAULT_BACKGROUND_IMAGE),
+            'defaultBackgroundColor' => BackgroundService::DEFAULT_BACKGROUND_COLOR,
+            'docUrl' => $this->urlGenerator->linkToDocs('admin-theming'),
+            'docUrlIcons' => $this->urlGenerator->linkToDocs('admin-theming-icons'),
+            'canThemeIcons' => $this->imageManager->shouldReplaceIcons(),
+        ]);
 
-		$this->initialState->provideInitialState('adminThemingParameters', [
-			'name' => $this->themingDefaults->getEntity(),
-			'url' => $this->themingDefaults->getBaseUrl(),
-			'slogan' => $this->themingDefaults->getSlogan(),
-			'primaryColor' => $this->themingDefaults->getDefaultColorPrimary(),
-			'backgroundColor' => $this->themingDefaults->getDefaultColorBackground(),
-			'logoMime' => $this->config->getAppValue(Application::APP_ID, 'logoMime', ''),
-			'allowedMimeTypes' => $allowedMimeTypes,
-			'backgroundURL' => $this->imageManager->getImageUrl('background'),
-			'backgroundMime' => $this->config->getAppValue(Application::APP_ID, 'backgroundMime', ''),
-			'logoheaderMime' => $this->config->getAppValue(Application::APP_ID, 'logoheaderMime', ''),
-			'faviconMime' => $this->config->getAppValue(Application::APP_ID, 'faviconMime', ''),
-			'legalNoticeUrl' => $this->themingDefaults->getImprintUrl(),
-			'privacyPolicyUrl' => $this->themingDefaults->getPrivacyUrl(),
-			'disableUserTheming' => $this->themingDefaults->isUserThemingDisabled(),
-			'defaultApps' => $this->navigationManager->getDefaultEntryIds(),
-		]);
+        $this->initialState->provideInitialState('adminThemingParameters', [
+            'name' => $this->themingDefaults->getEntity(),
+            'url' => $this->themingDefaults->getBaseUrl(),
+            'slogan' => $this->themingDefaults->getSlogan(),
+            'primaryColor' => $this->themingDefaults->getDefaultColorPrimary(),
+            'backgroundColor' => $this->themingDefaults->getDefaultColorBackground(),
+            'logoMime' => $this->config->getAppValue(Application::APP_ID, 'logoMime', ''),
+            'allowedMimeTypes' => $allowedMimeTypes,
+            'backgroundURL' => $this->imageManager->getImageUrl('background'),
+            'backgroundMime' => $this->config->getAppValue(Application::APP_ID, 'backgroundMime', ''),
+            'logoheaderMime' => $this->config->getAppValue(Application::APP_ID, 'logoheaderMime', ''),
+            'faviconMime' => $this->config->getAppValue(Application::APP_ID, 'faviconMime', ''),
+            'legalNoticeUrl' => $this->themingDefaults->getImprintUrl(),
+            'privacyPolicyUrl' => $this->themingDefaults->getPrivacyUrl(),
+            'disableUserTheming' => $this->themingDefaults->isUserThemingDisabled(),
+            'defaultApps' => $this->navigationManager->getDefaultEntryIds(),
+        ]);
 
-		Util::addStyle(Application::APP_ID, 'settings-admin');
-		Util::addScript(Application::APP_ID, 'settings-admin');
-		return new TemplateResponse(Application::APP_ID, 'settings-admin');
-	}
+        Util::addStyle(Application::APP_ID, 'settings-admin');
+        Util::addScript(Application::APP_ID, 'settings-admin');
+        return new TemplateResponse(Application::APP_ID, 'settings-admin');
+    }
 
-	/**
-	 * @return string the section ID, e.g. 'sharing'
-	 */
-	public function getSection(): string {
-		return Application::APP_ID;
-	}
+    /**
+     * @return string the section ID, e.g. 'sharing'
+     */
+    public function getSection(): string {
+        return Application::APP_ID;
+    }
 
-	/**
-	 * @return int whether the form should be rather on the top or bottom of
-	 *             the admin section. The forms are arranged in ascending order of the
-	 *             priority values. It is required to return a value between 0 and 100.
-	 *
-	 * E.g.: 70
-	 */
-	public function getPriority(): int {
-		return 5;
-	}
+    /**
+     * @return int whether the form should be rather on the top or bottom of
+     *             the admin section. The forms are arranged in ascending order of the
+     *             priority values. It is required to return a value between 0 and 100.
+     *
+     * E.g.: 70
+     */
+    public function getPriority(): int {
+        return 5;
+    }
 
-	public function getName(): ?string {
-		return null; // Only one setting in this section
-	}
+    public function getName(): ?string {
+        return null; // Only one setting in this section
+    }
 
-	public function getAuthorizedAppConfig(): array {
-		return [
-			Application::APP_ID => '/.*/',
-		];
-	}
+    public function getAuthorizedAppConfig(): array {
+        return [
+            Application::APP_ID => '/.*/',
+        ];
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
 			$errorMessage = $this->l->t('You are already using a custom theme. Theming app settings might be overwritten by that.');
 		}
 
-		$allowedMimeTypes = array_reduce(ThemingController::VALID_UPLOAD_KEYS, function ($carry, $key) {
+		$allowedMimeTypes = array_reduce(ThemingController::VALID_UPLOAD_KEYS, function($carry, $key) {
 			$carry[$key] = $this->imageManager->getSupportedUploadImageFormats($key);
 			return $carry;
 		}, []);
@@ -53,7 +53,7 @@ 
 		$this->initialState->provideInitialState('adminThemingInfo', [
 			'isThemeable' => $themeable,
 			'notThemeableErrorMessage' => $errorMessage,
-			'defaultBackgroundURL' => $this->urlGenerator->linkTo(Application::APP_ID, 'img/background/' . BackgroundService::DEFAULT_BACKGROUND_IMAGE),
+			'defaultBackgroundURL' => $this->urlGenerator->linkTo(Application::APP_ID, 'img/background/'.BackgroundService::DEFAULT_BACKGROUND_IMAGE),
 			'defaultBackgroundColor' => BackgroundService::DEFAULT_BACKGROUND_COLOR,
 			'docUrl' => $this->urlGenerator->linkToDocs('admin-theming'),
 			'docUrlIcons' => $this->urlGenerator->linkToDocs('admin-theming-icons'),

apps/theming/lib/Controller/ThemingController.php

Indentation +446 added lines, -446 removed lines

@@ -42,476 +42,476 @@
  * @package OCA\Theming\Controller
  */
 class ThemingController extends Controller {
-	public const VALID_UPLOAD_KEYS = ['header', 'logo', 'logoheader', 'background', 'favicon'];
+    public const VALID_UPLOAD_KEYS = ['header', 'logo', 'logoheader', 'background', 'favicon'];
 
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		private IConfig $config,
-		private IAppConfig $appConfig,
-		private ThemingDefaults $themingDefaults,
-		private IL10N $l10n,
-		private IURLGenerator $urlGenerator,
-		private IAppManager $appManager,
-		private ImageManager $imageManager,
-		private ThemesService $themesService,
-		private INavigationManager $navigationManager,
-	) {
-		parent::__construct($appName, $request);
-	}
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        private IConfig $config,
+        private IAppConfig $appConfig,
+        private ThemingDefaults $themingDefaults,
+        private IL10N $l10n,
+        private IURLGenerator $urlGenerator,
+        private IAppManager $appManager,
+        private ImageManager $imageManager,
+        private ThemesService $themesService,
+        private INavigationManager $navigationManager,
+    ) {
+        parent::__construct($appName, $request);
+    }
 
-	/**
-	 * @param string $setting
-	 * @param string $value
-	 * @return DataResponse
-	 * @throws NotPermittedException
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	public function updateStylesheet($setting, $value) {
-		$value = trim($value);
-		$error = null;
-		$saved = false;
-		switch ($setting) {
-			case 'name':
-				if (strlen($value) > 250) {
-					$error = $this->l10n->t('The given name is too long');
-				}
-				break;
-			case 'url':
-				if (strlen($value) > 500) {
-					$error = $this->l10n->t('The given web address is too long');
-				}
-				if ($value !== '' && !$this->isValidUrl($value)) {
-					$error = $this->l10n->t('The given web address is not a valid URL');
-				}
-				break;
-			case 'legalNoticeUrl':
-				$setting = 'imprintUrl';
-				// no break
-			case 'imprintUrl':
-				if (strlen($value) > 500) {
-					$error = $this->l10n->t('The given legal notice address is too long');
-				}
-				if (!$this->isValidUrl($value)) {
-					$error = $this->l10n->t('The given legal notice address is not a valid URL');
-				}
-				break;
-			case 'privacyPolicyUrl':
-				$setting = 'privacyUrl';
-				// no break
-			case 'privacyUrl':
-				if (strlen($value) > 500) {
-					$error = $this->l10n->t('The given privacy policy address is too long');
-				}
-				if (!$this->isValidUrl($value)) {
-					$error = $this->l10n->t('The given privacy policy address is not a valid URL');
-				}
-				break;
-			case 'slogan':
-				if (strlen($value) > 500) {
-					$error = $this->l10n->t('The given slogan is too long');
-				}
-				break;
-			case 'primaryColor':
-				$setting = 'primary_color';
-				// no break
-			case 'primary_color':
-				if (!preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $value)) {
-					$error = $this->l10n->t('The given color is invalid');
-				}
-				break;
-			case 'backgroundColor':
-				$setting = 'background_color';
-				// no break
-			case 'background_color':
-				if (!preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $value)) {
-					$error = $this->l10n->t('The given color is invalid');
-				}
-				break;
-			case 'disableUserTheming':
-			case 'disable-user-theming':
-				if (!in_array($value, ['yes', 'true', 'no', 'false'])) {
-					$error = $this->l10n->t('%1$s should be true or false', ['disable-user-theming']);
-				} else {
-					$this->appConfig->setAppValueBool('disable-user-theming', $value === 'yes' || $value === 'true');
-					$saved = true;
-				}
-				break;
-			case 'backgroundMime':
-				if ($value !== 'backgroundColor') {
-					$error = $this->l10n->t('%1$s can only be set to %2$s through the API', ['backgroundMime', 'backgroundColor']);
-				}
-				break;
-			default:
-				$error = $this->l10n->t('Invalid setting key');
-		}
-		if ($error !== null) {
-			return new DataResponse([
-				'data' => [
-					'message' => $error,
-				],
-				'status' => 'error'
-			], Http::STATUS_BAD_REQUEST);
-		}
+    /**
+     * @param string $setting
+     * @param string $value
+     * @return DataResponse
+     * @throws NotPermittedException
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    public function updateStylesheet($setting, $value) {
+        $value = trim($value);
+        $error = null;
+        $saved = false;
+        switch ($setting) {
+            case 'name':
+                if (strlen($value) > 250) {
+                    $error = $this->l10n->t('The given name is too long');
+                }
+                break;
+            case 'url':
+                if (strlen($value) > 500) {
+                    $error = $this->l10n->t('The given web address is too long');
+                }
+                if ($value !== '' && !$this->isValidUrl($value)) {
+                    $error = $this->l10n->t('The given web address is not a valid URL');
+                }
+                break;
+            case 'legalNoticeUrl':
+                $setting = 'imprintUrl';
+                // no break
+            case 'imprintUrl':
+                if (strlen($value) > 500) {
+                    $error = $this->l10n->t('The given legal notice address is too long');
+                }
+                if (!$this->isValidUrl($value)) {
+                    $error = $this->l10n->t('The given legal notice address is not a valid URL');
+                }
+                break;
+            case 'privacyPolicyUrl':
+                $setting = 'privacyUrl';
+                // no break
+            case 'privacyUrl':
+                if (strlen($value) > 500) {
+                    $error = $this->l10n->t('The given privacy policy address is too long');
+                }
+                if (!$this->isValidUrl($value)) {
+                    $error = $this->l10n->t('The given privacy policy address is not a valid URL');
+                }
+                break;
+            case 'slogan':
+                if (strlen($value) > 500) {
+                    $error = $this->l10n->t('The given slogan is too long');
+                }
+                break;
+            case 'primaryColor':
+                $setting = 'primary_color';
+                // no break
+            case 'primary_color':
+                if (!preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $value)) {
+                    $error = $this->l10n->t('The given color is invalid');
+                }
+                break;
+            case 'backgroundColor':
+                $setting = 'background_color';
+                // no break
+            case 'background_color':
+                if (!preg_match('/^\#([0-9a-f]{3}|[0-9a-f]{6})$/i', $value)) {
+                    $error = $this->l10n->t('The given color is invalid');
+                }
+                break;
+            case 'disableUserTheming':
+            case 'disable-user-theming':
+                if (!in_array($value, ['yes', 'true', 'no', 'false'])) {
+                    $error = $this->l10n->t('%1$s should be true or false', ['disable-user-theming']);
+                } else {
+                    $this->appConfig->setAppValueBool('disable-user-theming', $value === 'yes' || $value === 'true');
+                    $saved = true;
+                }
+                break;
+            case 'backgroundMime':
+                if ($value !== 'backgroundColor') {
+                    $error = $this->l10n->t('%1$s can only be set to %2$s through the API', ['backgroundMime', 'backgroundColor']);
+                }
+                break;
+            default:
+                $error = $this->l10n->t('Invalid setting key');
+        }
+        if ($error !== null) {
+            return new DataResponse([
+                'data' => [
+                    'message' => $error,
+                ],
+                'status' => 'error'
+            ], Http::STATUS_BAD_REQUEST);
+        }
 
-		if (!$saved) {
-			$this->themingDefaults->set($setting, $value);
-		}
+        if (!$saved) {
+            $this->themingDefaults->set($setting, $value);
+        }
 
-		return new DataResponse([
-			'data' => [
-				'message' => $this->l10n->t('Saved'),
-			],
-			'status' => 'success'
-		]);
-	}
+        return new DataResponse([
+            'data' => [
+                'message' => $this->l10n->t('Saved'),
+            ],
+            'status' => 'success'
+        ]);
+    }
 
-	/**
-	 * @param string $setting
-	 * @param mixed $value
-	 * @return DataResponse
-	 * @throws NotPermittedException
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	public function updateAppMenu($setting, $value) {
-		$error = null;
-		switch ($setting) {
-			case 'defaultApps':
-				if (is_array($value)) {
-					try {
-						$this->navigationManager->setDefaultEntryIds($value);
-					} catch (InvalidArgumentException $e) {
-						$error = $this->l10n->t('Invalid app given');
-					}
-				} else {
-					$error = $this->l10n->t('Invalid type for setting "defaultApp" given');
-				}
-				break;
-			default:
-				$error = $this->l10n->t('Invalid setting key');
-		}
-		if ($error !== null) {
-			return new DataResponse([
-				'data' => [
-					'message' => $error,
-				],
-				'status' => 'error'
-			], Http::STATUS_BAD_REQUEST);
-		}
+    /**
+     * @param string $setting
+     * @param mixed $value
+     * @return DataResponse
+     * @throws NotPermittedException
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    public function updateAppMenu($setting, $value) {
+        $error = null;
+        switch ($setting) {
+            case 'defaultApps':
+                if (is_array($value)) {
+                    try {
+                        $this->navigationManager->setDefaultEntryIds($value);
+                    } catch (InvalidArgumentException $e) {
+                        $error = $this->l10n->t('Invalid app given');
+                    }
+                } else {
+                    $error = $this->l10n->t('Invalid type for setting "defaultApp" given');
+                }
+                break;
+            default:
+                $error = $this->l10n->t('Invalid setting key');
+        }
+        if ($error !== null) {
+            return new DataResponse([
+                'data' => [
+                    'message' => $error,
+                ],
+                'status' => 'error'
+            ], Http::STATUS_BAD_REQUEST);
+        }
 
-		return new DataResponse([
-			'data' => [
-				'message' => $this->l10n->t('Saved'),
-			],
-			'status' => 'success'
-		]);
-	}
+        return new DataResponse([
+            'data' => [
+                'message' => $this->l10n->t('Saved'),
+            ],
+            'status' => 'success'
+        ]);
+    }
 
-	/**
-	 * Check that a string is a valid http/https url.
-	 * Also validates that there is no way for XSS through HTML
-	 */
-	private function isValidUrl(string $url): bool {
-		return ((str_starts_with($url, 'http://') || str_starts_with($url, 'https://'))
-			&& filter_var($url, FILTER_VALIDATE_URL) !== false)
-			&& !str_contains($url, '"');
-	}
+    /**
+     * Check that a string is a valid http/https url.
+     * Also validates that there is no way for XSS through HTML
+     */
+    private function isValidUrl(string $url): bool {
+        return ((str_starts_with($url, 'http://') || str_starts_with($url, 'https://'))
+            && filter_var($url, FILTER_VALIDATE_URL) !== false)
+            && !str_contains($url, '"');
+    }
 
-	/**
-	 * @return DataResponse
-	 * @throws NotPermittedException
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	public function uploadImage(): DataResponse {
-		$key = $this->request->getParam('key');
-		if (!in_array($key, self::VALID_UPLOAD_KEYS, true)) {
-			return new DataResponse(
-				[
-					'data' => [
-						'message' => 'Invalid key'
-					],
-					'status' => 'failure',
-				],
-				Http::STATUS_BAD_REQUEST
-			);
-		}
-		$image = $this->request->getUploadedFile('image');
-		$error = null;
-		$phpFileUploadErrors = [
-			UPLOAD_ERR_OK => $this->l10n->t('The file was uploaded'),
-			UPLOAD_ERR_INI_SIZE => $this->l10n->t('The uploaded file exceeds the upload_max_filesize directive in php.ini'),
-			UPLOAD_ERR_FORM_SIZE => $this->l10n->t('The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form'),
-			UPLOAD_ERR_PARTIAL => $this->l10n->t('The file was only partially uploaded'),
-			UPLOAD_ERR_NO_FILE => $this->l10n->t('No file was uploaded'),
-			UPLOAD_ERR_NO_TMP_DIR => $this->l10n->t('Missing a temporary folder'),
-			UPLOAD_ERR_CANT_WRITE => $this->l10n->t('Could not write file to disk'),
-			UPLOAD_ERR_EXTENSION => $this->l10n->t('A PHP extension stopped the file upload'),
-		];
-		if (empty($image)) {
-			$error = $this->l10n->t('No file uploaded');
-		}
-		if (!empty($image) && array_key_exists('error', $image) && $image['error'] !== UPLOAD_ERR_OK) {
-			$error = $phpFileUploadErrors[$image['error']];
-		}
+    /**
+     * @return DataResponse
+     * @throws NotPermittedException
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    public function uploadImage(): DataResponse {
+        $key = $this->request->getParam('key');
+        if (!in_array($key, self::VALID_UPLOAD_KEYS, true)) {
+            return new DataResponse(
+                [
+                    'data' => [
+                        'message' => 'Invalid key'
+                    ],
+                    'status' => 'failure',
+                ],
+                Http::STATUS_BAD_REQUEST
+            );
+        }
+        $image = $this->request->getUploadedFile('image');
+        $error = null;
+        $phpFileUploadErrors = [
+            UPLOAD_ERR_OK => $this->l10n->t('The file was uploaded'),
+            UPLOAD_ERR_INI_SIZE => $this->l10n->t('The uploaded file exceeds the upload_max_filesize directive in php.ini'),
+            UPLOAD_ERR_FORM_SIZE => $this->l10n->t('The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form'),
+            UPLOAD_ERR_PARTIAL => $this->l10n->t('The file was only partially uploaded'),
+            UPLOAD_ERR_NO_FILE => $this->l10n->t('No file was uploaded'),
+            UPLOAD_ERR_NO_TMP_DIR => $this->l10n->t('Missing a temporary folder'),
+            UPLOAD_ERR_CANT_WRITE => $this->l10n->t('Could not write file to disk'),
+            UPLOAD_ERR_EXTENSION => $this->l10n->t('A PHP extension stopped the file upload'),
+        ];
+        if (empty($image)) {
+            $error = $this->l10n->t('No file uploaded');
+        }
+        if (!empty($image) && array_key_exists('error', $image) && $image['error'] !== UPLOAD_ERR_OK) {
+            $error = $phpFileUploadErrors[$image['error']];
+        }
 
-		if ($error !== null) {
-			return new DataResponse(
-				[
-					'data' => [
-						'message' => $error
-					],
-					'status' => 'failure',
-				],
-				Http::STATUS_UNPROCESSABLE_ENTITY
-			);
-		}
+        if ($error !== null) {
+            return new DataResponse(
+                [
+                    'data' => [
+                        'message' => $error
+                    ],
+                    'status' => 'failure',
+                ],
+                Http::STATUS_UNPROCESSABLE_ENTITY
+            );
+        }
 
-		try {
-			$mime = $this->imageManager->updateImage($key, $image['tmp_name']);
-			$this->themingDefaults->set($key . 'Mime', $mime);
-		} catch (\Exception $e) {
-			return new DataResponse(
-				[
-					'data' => [
-						'message' => $e->getMessage()
-					],
-					'status' => 'failure',
-				],
-				Http::STATUS_UNPROCESSABLE_ENTITY
-			);
-		}
+        try {
+            $mime = $this->imageManager->updateImage($key, $image['tmp_name']);
+            $this->themingDefaults->set($key . 'Mime', $mime);
+        } catch (\Exception $e) {
+            return new DataResponse(
+                [
+                    'data' => [
+                        'message' => $e->getMessage()
+                    ],
+                    'status' => 'failure',
+                ],
+                Http::STATUS_UNPROCESSABLE_ENTITY
+            );
+        }
 
-		$name = $image['name'];
+        $name = $image['name'];
 
-		return new DataResponse(
-			[
-				'data'
-					=> [
-						'name' => $name,
-						'url' => $this->imageManager->getImageUrl($key),
-						'message' => $this->l10n->t('Saved'),
-					],
-				'status' => 'success'
-			]
-		);
-	}
+        return new DataResponse(
+            [
+                'data'
+                    => [
+                        'name' => $name,
+                        'url' => $this->imageManager->getImageUrl($key),
+                        'message' => $this->l10n->t('Saved'),
+                    ],
+                'status' => 'success'
+            ]
+        );
+    }
 
-	/**
-	 * Revert setting to default value
-	 *
-	 * @param string $setting setting which should be reverted
-	 * @return DataResponse
-	 * @throws NotPermittedException
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	public function undo(string $setting): DataResponse {
-		$setting = match ($setting) {
-			'primaryColor' => 'primary_color',
-			'backgroundColor' => 'background_color',
-			default => $setting,
-		};
-		$value = $this->themingDefaults->undo($setting);
+    /**
+     * Revert setting to default value
+     *
+     * @param string $setting setting which should be reverted
+     * @return DataResponse
+     * @throws NotPermittedException
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    public function undo(string $setting): DataResponse {
+        $setting = match ($setting) {
+            'primaryColor' => 'primary_color',
+            'backgroundColor' => 'background_color',
+            default => $setting,
+        };
+        $value = $this->themingDefaults->undo($setting);
 
-		return new DataResponse(
-			[
-				'data'
-					=> [
-						'value' => $value,
-						'message' => $this->l10n->t('Saved'),
-					],
-				'status' => 'success'
-			]
-		);
-	}
+        return new DataResponse(
+            [
+                'data'
+                    => [
+                        'value' => $value,
+                        'message' => $this->l10n->t('Saved'),
+                    ],
+                'status' => 'success'
+            ]
+        );
+    }
 
-	/**
-	 * Revert all theming settings to their default values
-	 *
-	 * @return DataResponse
-	 * @throws NotPermittedException
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	public function undoAll(): DataResponse {
-		$this->themingDefaults->undoAll();
-		$this->navigationManager->setDefaultEntryIds([]);
+    /**
+     * Revert all theming settings to their default values
+     *
+     * @return DataResponse
+     * @throws NotPermittedException
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    public function undoAll(): DataResponse {
+        $this->themingDefaults->undoAll();
+        $this->navigationManager->setDefaultEntryIds([]);
 
-		return new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => $this->l10n->t('Saved'),
-					],
-				'status' => 'success'
-			]
-		);
-	}
+        return new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => $this->l10n->t('Saved'),
+                    ],
+                'status' => 'success'
+            ]
+        );
+    }
 
-	/**
-	 * @NoSameSiteCookieRequired
-	 *
-	 * Get an image
-	 *
-	 * @param string $key Key of the image
-	 * @param bool $useSvg Return image as SVG
-	 * @return FileDisplayResponse<Http::STATUS_OK, array{}>|NotFoundResponse<Http::STATUS_NOT_FOUND, array{}>
-	 * @throws NotPermittedException
-	 *
-	 * 200: Image returned
-	 * 404: Image not found
-	 */
-	#[PublicPage]
-	#[NoCSRFRequired]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getImage(string $key, bool $useSvg = true) {
-		try {
-			$file = $this->imageManager->getImage($key, $useSvg);
-		} catch (NotFoundException $e) {
-			return new NotFoundResponse();
-		}
+    /**
+     * @NoSameSiteCookieRequired
+     *
+     * Get an image
+     *
+     * @param string $key Key of the image
+     * @param bool $useSvg Return image as SVG
+     * @return FileDisplayResponse<Http::STATUS_OK, array{}>|NotFoundResponse<Http::STATUS_NOT_FOUND, array{}>
+     * @throws NotPermittedException
+     *
+     * 200: Image returned
+     * 404: Image not found
+     */
+    #[PublicPage]
+    #[NoCSRFRequired]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getImage(string $key, bool $useSvg = true) {
+        try {
+            $file = $this->imageManager->getImage($key, $useSvg);
+        } catch (NotFoundException $e) {
+            return new NotFoundResponse();
+        }
 
-		$response = new FileDisplayResponse($file);
-		$csp = new ContentSecurityPolicy();
-		$csp->allowInlineStyle();
-		$response->setContentSecurityPolicy($csp);
-		$response->cacheFor(3600);
-		$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
-		$response->addHeader('Content-Disposition', 'attachment; filename="' . $key . '"');
-		if (!$useSvg) {
-			$response->addHeader('Content-Type', 'image/png');
-		} else {
-			$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
-		}
-		return $response;
-	}
+        $response = new FileDisplayResponse($file);
+        $csp = new ContentSecurityPolicy();
+        $csp->allowInlineStyle();
+        $response->setContentSecurityPolicy($csp);
+        $response->cacheFor(3600);
+        $response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
+        $response->addHeader('Content-Disposition', 'attachment; filename="' . $key . '"');
+        if (!$useSvg) {
+            $response->addHeader('Content-Type', 'image/png');
+        } else {
+            $response->addHeader('Content-Type', $this->config->getAppValue($this->appName, $key . 'Mime', ''));
+        }
+        return $response;
+    }
 
-	/**
-	 * @NoSameSiteCookieRequired
-	 * @NoTwoFactorRequired
-	 *
-	 * Get the CSS stylesheet for a theme
-	 *
-	 * @param string $themeId ID of the theme
-	 * @param bool $plain Let the browser decide the CSS priority
-	 * @param bool $withCustomCss Include custom CSS
-	 * @return DataDisplayResponse<Http::STATUS_OK, array{Content-Type: 'text/css'}>|NotFoundResponse<Http::STATUS_NOT_FOUND, array{}>
-	 *
-	 * 200: Stylesheet returned
-	 * 404: Theme not found
-	 */
-	#[PublicPage]
-	#[NoCSRFRequired]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getThemeStylesheet(string $themeId, bool $plain = false, bool $withCustomCss = false) {
-		$themes = $this->themesService->getThemes();
-		if (!in_array($themeId, array_keys($themes))) {
-			return new NotFoundResponse();
-		}
+    /**
+     * @NoSameSiteCookieRequired
+     * @NoTwoFactorRequired
+     *
+     * Get the CSS stylesheet for a theme
+     *
+     * @param string $themeId ID of the theme
+     * @param bool $plain Let the browser decide the CSS priority
+     * @param bool $withCustomCss Include custom CSS
+     * @return DataDisplayResponse<Http::STATUS_OK, array{Content-Type: 'text/css'}>|NotFoundResponse<Http::STATUS_NOT_FOUND, array{}>
+     *
+     * 200: Stylesheet returned
+     * 404: Theme not found
+     */
+    #[PublicPage]
+    #[NoCSRFRequired]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getThemeStylesheet(string $themeId, bool $plain = false, bool $withCustomCss = false) {
+        $themes = $this->themesService->getThemes();
+        if (!in_array($themeId, array_keys($themes))) {
+            return new NotFoundResponse();
+        }
 
-		$theme = $themes[$themeId];
-		$customCss = $theme->getCustomCss();
+        $theme = $themes[$themeId];
+        $customCss = $theme->getCustomCss();
 
-		// Generate variables
-		$variables = '';
-		foreach ($theme->getCSSVariables() as $variable => $value) {
-			$variables .= "$variable:$value; ";
-		};
+        // Generate variables
+        $variables = '';
+        foreach ($theme->getCSSVariables() as $variable => $value) {
+            $variables .= "$variable:$value; ";
+        };
 
-		// If plain is set, the browser decides of the css priority
-		if ($plain) {
-			$css = ":root { $variables } " . $customCss;
-		} else {
-			// If not set, we'll rely on the body class
-			// We need to separate @-rules from normal selectors, as they can't be nested
-			// This is a replacement for the SCSS compiler that did this automatically before f1448fcf0777db7d4254cb0a3ef94d63be9f7a24
-			// We need a better way to handle this, but for now we just remove comments and split the at-rules
-			// from the rest of the CSS.
-			$customCssWithoutComments = preg_replace('!/\*.*?\*/!s', '', $customCss);
-			$customCssWithoutComments = preg_replace('!//.*!', '', $customCssWithoutComments);
-			preg_match_all('/(@[^{]+{(?:[^{}]*|(?R))*})/', $customCssWithoutComments, $atRules);
-			$atRulesCss = implode('', $atRules[0]);
-			$scopedCss = preg_replace('/(@[^{]+{(?:[^{}]*|(?R))*})/', '', $customCssWithoutComments);
+        // If plain is set, the browser decides of the css priority
+        if ($plain) {
+            $css = ":root { $variables } " . $customCss;
+        } else {
+            // If not set, we'll rely on the body class
+            // We need to separate @-rules from normal selectors, as they can't be nested
+            // This is a replacement for the SCSS compiler that did this automatically before f1448fcf0777db7d4254cb0a3ef94d63be9f7a24
+            // We need a better way to handle this, but for now we just remove comments and split the at-rules
+            // from the rest of the CSS.
+            $customCssWithoutComments = preg_replace('!/\*.*?\*/!s', '', $customCss);
+            $customCssWithoutComments = preg_replace('!//.*!', '', $customCssWithoutComments);
+            preg_match_all('/(@[^{]+{(?:[^{}]*|(?R))*})/', $customCssWithoutComments, $atRules);
+            $atRulesCss = implode('', $atRules[0]);
+            $scopedCss = preg_replace('/(@[^{]+{(?:[^{}]*|(?R))*})/', '', $customCssWithoutComments);
 
-			$css = "$atRulesCss [data-theme-$themeId] { $variables $scopedCss }";
-		}
+            $css = "$atRulesCss [data-theme-$themeId] { $variables $scopedCss }";
+        }
 
-		try {
-			$response = new DataDisplayResponse($css, Http::STATUS_OK, ['Content-Type' => 'text/css']);
-			$response->cacheFor(86400);
-			return $response;
-		} catch (NotFoundException $e) {
-			return new NotFoundResponse();
-		}
-	}
+        try {
+            $response = new DataDisplayResponse($css, Http::STATUS_OK, ['Content-Type' => 'text/css']);
+            $response->cacheFor(86400);
+            return $response;
+        } catch (NotFoundException $e) {
+            return new NotFoundResponse();
+        }
+    }
 
-	/**
-	 * Get the manifest for an app
-	 *
-	 * @param string $app ID of the app
-	 * @psalm-suppress LessSpecificReturnStatement The content of the Manifest doesn't need to be described in the return type
-	 * @return JSONResponse<Http::STATUS_OK, array{name: string, short_name: string, start_url: string, theme_color: string, background_color: string, description: string, icons: list<array{src: non-empty-string, type: string, sizes: string}>, display_override: list<string>, display: string}, array{}>|JSONResponse<Http::STATUS_NOT_FOUND, list<empty>, array{}>
-	 *
-	 * 200: Manifest returned
-	 * 404: App not found
-	 */
-	#[PublicPage]
-	#[NoCSRFRequired]
-	#[BruteForceProtection(action: 'manifest')]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getManifest(string $app): JSONResponse {
-		$cacheBusterValue = $this->config->getAppValue('theming', 'cachebuster', '0');
-		if ($app === 'core' || $app === 'settings') {
-			$name = $this->themingDefaults->getName();
-			$shortName = $this->themingDefaults->getName();
-			$startUrl = $this->urlGenerator->getBaseUrl();
-			$description = $this->themingDefaults->getSlogan();
-		} else {
-			if (!$this->appManager->isEnabledForUser($app)) {
-				$response = new JSONResponse([], Http::STATUS_NOT_FOUND);
-				$response->throttle(['action' => 'manifest', 'app' => $app]);
-				return $response;
-			}
+    /**
+     * Get the manifest for an app
+     *
+     * @param string $app ID of the app
+     * @psalm-suppress LessSpecificReturnStatement The content of the Manifest doesn't need to be described in the return type
+     * @return JSONResponse<Http::STATUS_OK, array{name: string, short_name: string, start_url: string, theme_color: string, background_color: string, description: string, icons: list<array{src: non-empty-string, type: string, sizes: string}>, display_override: list<string>, display: string}, array{}>|JSONResponse<Http::STATUS_NOT_FOUND, list<empty>, array{}>
+     *
+     * 200: Manifest returned
+     * 404: App not found
+     */
+    #[PublicPage]
+    #[NoCSRFRequired]
+    #[BruteForceProtection(action: 'manifest')]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getManifest(string $app): JSONResponse {
+        $cacheBusterValue = $this->config->getAppValue('theming', 'cachebuster', '0');
+        if ($app === 'core' || $app === 'settings') {
+            $name = $this->themingDefaults->getName();
+            $shortName = $this->themingDefaults->getName();
+            $startUrl = $this->urlGenerator->getBaseUrl();
+            $description = $this->themingDefaults->getSlogan();
+        } else {
+            if (!$this->appManager->isEnabledForUser($app)) {
+                $response = new JSONResponse([], Http::STATUS_NOT_FOUND);
+                $response->throttle(['action' => 'manifest', 'app' => $app]);
+                return $response;
+            }
 
-			$info = $this->appManager->getAppInfo($app, false, $this->l10n->getLanguageCode());
-			$name = $info['name'] . ' - ' . $this->themingDefaults->getName();
-			$shortName = $info['name'];
-			if (str_contains($this->request->getRequestUri(), '/index.php/')) {
-				$startUrl = $this->urlGenerator->getBaseUrl() . '/index.php/apps/' . $app . '/';
-			} else {
-				$startUrl = $this->urlGenerator->getBaseUrl() . '/apps/' . $app . '/';
-			}
-			$description = $info['summary'] ?? '';
-		}
-		/**
-		 * @var string $description
-		 * @var string $shortName
-		 */
-		$responseJS = [
-			'name' => $name,
-			'short_name' => $shortName,
-			'start_url' => $startUrl,
-			'theme_color' => $this->themingDefaults->getColorPrimary(),
-			'background_color' => $this->themingDefaults->getColorPrimary(),
-			'description' => $description,
-			'icons'
-				=> [
-					[
-						'src' => $this->urlGenerator->linkToRoute('theming.Icon.getTouchIcon',
-							['app' => $app]) . '?v=' . $cacheBusterValue,
-						'type' => 'image/png',
-						'sizes' => '512x512'
-					],
-					[
-						'src' => $this->urlGenerator->linkToRoute('theming.Icon.getFavicon',
-							['app' => $app]) . '?v=' . $cacheBusterValue,
-						'type' => 'image/svg+xml',
-						'sizes' => '16x16'
-					]
-				],
-			'display_override' => [$this->config->getSystemValueBool('theming.standalone_window.enabled', true) ? 'minimal-ui' : ''],
-			'display' => $this->config->getSystemValueBool('theming.standalone_window.enabled', true) ? 'standalone' : 'browser'
-		];
-		$response = new JSONResponse($responseJS);
-		$response->cacheFor(3600);
-		return $response;
-	}
+            $info = $this->appManager->getAppInfo($app, false, $this->l10n->getLanguageCode());
+            $name = $info['name'] . ' - ' . $this->themingDefaults->getName();
+            $shortName = $info['name'];
+            if (str_contains($this->request->getRequestUri(), '/index.php/')) {
+                $startUrl = $this->urlGenerator->getBaseUrl() . '/index.php/apps/' . $app . '/';
+            } else {
+                $startUrl = $this->urlGenerator->getBaseUrl() . '/apps/' . $app . '/';
+            }
+            $description = $info['summary'] ?? '';
+        }
+        /**
+         * @var string $description
+         * @var string $shortName
+         */
+        $responseJS = [
+            'name' => $name,
+            'short_name' => $shortName,
+            'start_url' => $startUrl,
+            'theme_color' => $this->themingDefaults->getColorPrimary(),
+            'background_color' => $this->themingDefaults->getColorPrimary(),
+            'description' => $description,
+            'icons'
+                => [
+                    [
+                        'src' => $this->urlGenerator->linkToRoute('theming.Icon.getTouchIcon',
+                            ['app' => $app]) . '?v=' . $cacheBusterValue,
+                        'type' => 'image/png',
+                        'sizes' => '512x512'
+                    ],
+                    [
+                        'src' => $this->urlGenerator->linkToRoute('theming.Icon.getFavicon',
+                            ['app' => $app]) . '?v=' . $cacheBusterValue,
+                        'type' => 'image/svg+xml',
+                        'sizes' => '16x16'
+                    ]
+                ],
+            'display_override' => [$this->config->getSystemValueBool('theming.standalone_window.enabled', true) ? 'minimal-ui' : ''],
+            'display' => $this->config->getSystemValueBool('theming.standalone_window.enabled', true) ? 'standalone' : 'browser'
+        ];
+        $response = new JSONResponse($responseJS);
+        $response->cacheFor(3600);
+        return $response;
+    }
 }

apps/theming/tests/Settings/AdminTest.php

Indentation +104 added lines, -104 removed lines

@@ -20,116 +20,116 @@
 use Test\TestCase;
 
 class AdminTest extends TestCase {
-	private Admin $admin;
-	private IConfig&MockObject $config;
-	private ThemingDefaults&MockObject $themingDefaults;
-	private IInitialState&MockObject $initialState;
-	private IURLGenerator&MockObject $urlGenerator;
-	private ImageManager&MockObject $imageManager;
-	private IL10N&MockObject $l10n;
-	private INavigationManager&MockObject $navigationManager;
+    private Admin $admin;
+    private IConfig&MockObject $config;
+    private ThemingDefaults&MockObject $themingDefaults;
+    private IInitialState&MockObject $initialState;
+    private IURLGenerator&MockObject $urlGenerator;
+    private ImageManager&MockObject $imageManager;
+    private IL10N&MockObject $l10n;
+    private INavigationManager&MockObject $navigationManager;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->config = $this->createMock(IConfig::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->themingDefaults = $this->createMock(ThemingDefaults::class);
-		$this->initialState = $this->createMock(IInitialState::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->imageManager = $this->createMock(ImageManager::class);
-		$this->navigationManager = $this->createMock(INavigationManager::class);
+    protected function setUp(): void {
+        parent::setUp();
+        $this->config = $this->createMock(IConfig::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->themingDefaults = $this->createMock(ThemingDefaults::class);
+        $this->initialState = $this->createMock(IInitialState::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->imageManager = $this->createMock(ImageManager::class);
+        $this->navigationManager = $this->createMock(INavigationManager::class);
 
-		$this->admin = new Admin(
-			$this->config,
-			$this->l10n,
-			$this->themingDefaults,
-			$this->initialState,
-			$this->urlGenerator,
-			$this->imageManager,
-			$this->navigationManager,
-		);
-	}
+        $this->admin = new Admin(
+            $this->config,
+            $this->l10n,
+            $this->themingDefaults,
+            $this->initialState,
+            $this->urlGenerator,
+            $this->imageManager,
+            $this->navigationManager,
+        );
+    }
 
-	public function testGetFormNoErrors(): void {
-		$this->config
-			->expects($this->once())
-			->method('getSystemValue')
-			->with('theme', '')
-			->willReturn('');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getEntity')
-			->willReturn('MyEntity');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getBaseUrl')
-			->willReturn('https://example.com');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getImprintUrl')
-			->willReturn('');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getPrivacyUrl')
-			->willReturn('');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getSlogan')
-			->willReturn('MySlogan');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getDefaultColorPrimary')
-			->willReturn('#fff');
+    public function testGetFormNoErrors(): void {
+        $this->config
+            ->expects($this->once())
+            ->method('getSystemValue')
+            ->with('theme', '')
+            ->willReturn('');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getEntity')
+            ->willReturn('MyEntity');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getBaseUrl')
+            ->willReturn('https://example.com');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getImprintUrl')
+            ->willReturn('');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getPrivacyUrl')
+            ->willReturn('');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getSlogan')
+            ->willReturn('MySlogan');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getDefaultColorPrimary')
+            ->willReturn('#fff');
 
-		$expected = new TemplateResponse('theming', 'settings-admin');
-		$this->assertEquals($expected, $this->admin->getForm());
-	}
+        $expected = new TemplateResponse('theming', 'settings-admin');
+        $this->assertEquals($expected, $this->admin->getForm());
+    }
 
-	public function testGetFormWithErrors(): void {
-		$this->config
-			->expects($this->once())
-			->method('getSystemValue')
-			->with('theme', '')
-			->willReturn('MyCustomTheme');
-		$this->l10n
-			->expects($this->once())
-			->method('t')
-			->with('You are already using a custom theme. Theming app settings might be overwritten by that.')
-			->willReturn('You are already using a custom theme. Theming app settings might be overwritten by that.');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getEntity')
-			->willReturn('MyEntity');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getBaseUrl')
-			->willReturn('https://example.com');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getImprintUrl')
-			->willReturn('');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getPrivacyUrl')
-			->willReturn('');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getSlogan')
-			->willReturn('MySlogan');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('getDefaultColorPrimary')
-			->willReturn('#fff');
+    public function testGetFormWithErrors(): void {
+        $this->config
+            ->expects($this->once())
+            ->method('getSystemValue')
+            ->with('theme', '')
+            ->willReturn('MyCustomTheme');
+        $this->l10n
+            ->expects($this->once())
+            ->method('t')
+            ->with('You are already using a custom theme. Theming app settings might be overwritten by that.')
+            ->willReturn('You are already using a custom theme. Theming app settings might be overwritten by that.');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getEntity')
+            ->willReturn('MyEntity');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getBaseUrl')
+            ->willReturn('https://example.com');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getImprintUrl')
+            ->willReturn('');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getPrivacyUrl')
+            ->willReturn('');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getSlogan')
+            ->willReturn('MySlogan');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('getDefaultColorPrimary')
+            ->willReturn('#fff');
 
-		$expected = new TemplateResponse('theming', 'settings-admin');
-		$this->assertEquals($expected, $this->admin->getForm());
-	}
+        $expected = new TemplateResponse('theming', 'settings-admin');
+        $this->assertEquals($expected, $this->admin->getForm());
+    }
 
-	public function testGetSection(): void {
-		$this->assertSame('theming', $this->admin->getSection());
-	}
+    public function testGetSection(): void {
+        $this->assertSame('theming', $this->admin->getSection());
+    }
 
-	public function testGetPriority(): void {
-		$this->assertSame(5, $this->admin->getPriority());
-	}
+    public function testGetPriority(): void {
+        $this->assertSame(5, $this->admin->getPriority());
+    }
 }

apps/theming/tests/Settings/PersonalTest.php

Indentation +201 added lines, -201 removed lines

@@ -33,205 +33,205 @@
 use Test\TestCase;
 
 class PersonalTest extends TestCase {
-	private IConfig&MockObject $config;
-	private ThemesService&MockObject $themesService;
-	private IInitialState&MockObject $initialStateService;
-	private ThemingDefaults&MockObject $themingDefaults;
-	private INavigationManager&MockObject $navigationManager;
-	private Personal $admin;
-
-	/** @var ITheme[] */
-	private array $themes;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->config = $this->createMock(IConfig::class);
-		$this->themesService = $this->createMock(ThemesService::class);
-		$this->initialStateService = $this->createMock(IInitialState::class);
-		$this->themingDefaults = $this->createMock(ThemingDefaults::class);
-		$this->navigationManager = $this->createMock(INavigationManager::class);
-
-		$this->initThemes();
-
-		$this->themesService
-			->expects($this->any())
-			->method('getThemes')
-			->willReturn($this->themes);
-
-		$this->admin = new Personal(
-			'admin',
-			$this->config,
-			$this->themesService,
-			$this->initialStateService,
-			$this->themingDefaults,
-			$this->navigationManager,
-		);
-	}
-
-	public static function dataTestGetForm(): array {
-		return [
-			['', [
-				'default',
-				'light',
-				'dark',
-				'light-highcontrast',
-				'dark-highcontrast',
-				'opendyslexic',
-			]],
-			['dark', [
-				'dark',
-				'opendyslexic',
-			]],
-		];
-	}
-
-	#[DataProvider('dataTestGetForm')]
-	public function testGetForm(string $enforcedTheme, array $themesState): void {
-		$themesState = array_map(
-			$this->formatThemeForm(...),
-			$themesState
-		);
-
-		$this->config->expects($this->once())
-			->method('getSystemValueString')
-			->with('enforce_theme', '')
-			->willReturn($enforcedTheme);
-
-		$this->config->expects($this->any())
-			->method('getUserValue')
-			->willReturnMap([
-				['admin', 'core', 'apporder', '[]', '[]'],
-				['admin', 'theming', 'background_image', BackgroundService::BACKGROUND_DEFAULT],
-			]);
-
-		$this->navigationManager->expects($this->once())
-			->method('getDefaultEntryIdForUser')
-			->willReturn('forced_id');
-
-		$this->initialStateService->expects($this->exactly(8))
-			->method('provideInitialState')
-			->willReturnMap([
-				['shippedBackgrounds', BackgroundService::SHIPPED_BACKGROUNDS],
-				['themingDefaults'],
-				['enableBlurFilter', ''],
-				['userBackgroundImage'],
-				['themes', $themesState],
-				['enforceTheme', $enforcedTheme],
-				['isUserThemingDisabled', false],
-				['navigationBar', ['userAppOrder' => [], 'enforcedDefaultApp' => 'forced_id']],
-			]);
-
-		$expected = new TemplateResponse('theming', 'settings-personal');
-		$this->assertEquals($expected, $this->admin->getForm());
-	}
-
-	public function testGetSection(): void {
-		$this->assertSame('theming', $this->admin->getSection());
-	}
-
-	public function testGetPriority(): void {
-		$this->assertSame(40, $this->admin->getPriority());
-	}
-
-	private function initThemes() {
-		$util = $this->createMock(Util::class);
-		$themingDefaults = $this->createMock(ThemingDefaults::class);
-		$userSession = $this->createMock(IUserSession::class);
-		$urlGenerator = $this->createMock(IURLGenerator::class);
-		$imageManager = $this->createMock(ImageManager::class);
-		$config = $this->createMock(IConfig::class);
-		$l10n = $this->createMock(IL10N::class);
-		$appManager = $this->createMock(IAppManager::class);
-
-		$themingDefaults->expects($this->any())
-			->method('getColorPrimary')
-			->willReturn('#0082c9');
-
-		$themingDefaults->expects($this->any())
-			->method('getDefaultColorPrimary')
-			->willReturn('#0082c9');
-
-		$this->themes = [
-			'default' => new DefaultTheme(
-				$util,
-				$themingDefaults,
-				$userSession,
-				$urlGenerator,
-				$imageManager,
-				$config,
-				$l10n,
-				$appManager,
-				null,
-			),
-			'light' => new LightTheme(
-				$util,
-				$themingDefaults,
-				$userSession,
-				$urlGenerator,
-				$imageManager,
-				$config,
-				$l10n,
-				$appManager,
-				null,
-			),
-			'dark' => new DarkTheme(
-				$util,
-				$themingDefaults,
-				$userSession,
-				$urlGenerator,
-				$imageManager,
-				$config,
-				$l10n,
-				$appManager,
-				null,
-			),
-			'light-highcontrast' => new HighContrastTheme(
-				$util,
-				$themingDefaults,
-				$userSession,
-				$urlGenerator,
-				$imageManager,
-				$config,
-				$l10n,
-				$appManager,
-				null,
-			),
-			'dark-highcontrast' => new DarkHighContrastTheme(
-				$util,
-				$themingDefaults,
-				$userSession,
-				$urlGenerator,
-				$imageManager,
-				$config,
-				$l10n,
-				$appManager,
-				null,
-			),
-			'opendyslexic' => new DyslexiaFont(
-				$util,
-				$themingDefaults,
-				$userSession,
-				$urlGenerator,
-				$imageManager,
-				$config,
-				$l10n,
-				$appManager,
-				null,
-			),
-		];
-	}
-
-	private function formatThemeForm(string $themeId): array {
-		$this->initThemes();
-
-		$theme = $this->themes[$themeId];
-		return [
-			'id' => $theme->getId(),
-			'type' => $theme->getType(),
-			'title' => $theme->getTitle(),
-			'enableLabel' => $theme->getEnableLabel(),
-			'description' => $theme->getDescription(),
-			'enabled' => false,
-		];
-	}
+    private IConfig&MockObject $config;
+    private ThemesService&MockObject $themesService;
+    private IInitialState&MockObject $initialStateService;
+    private ThemingDefaults&MockObject $themingDefaults;
+    private INavigationManager&MockObject $navigationManager;
+    private Personal $admin;
+
+    /** @var ITheme[] */
+    private array $themes;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->config = $this->createMock(IConfig::class);
+        $this->themesService = $this->createMock(ThemesService::class);
+        $this->initialStateService = $this->createMock(IInitialState::class);
+        $this->themingDefaults = $this->createMock(ThemingDefaults::class);
+        $this->navigationManager = $this->createMock(INavigationManager::class);
+
+        $this->initThemes();
+
+        $this->themesService
+            ->expects($this->any())
+            ->method('getThemes')
+            ->willReturn($this->themes);
+
+        $this->admin = new Personal(
+            'admin',
+            $this->config,
+            $this->themesService,
+            $this->initialStateService,
+            $this->themingDefaults,
+            $this->navigationManager,
+        );
+    }
+
+    public static function dataTestGetForm(): array {
+        return [
+            ['', [
+                'default',
+                'light',
+                'dark',
+                'light-highcontrast',
+                'dark-highcontrast',
+                'opendyslexic',
+            ]],
+            ['dark', [
+                'dark',
+                'opendyslexic',
+            ]],
+        ];
+    }
+
+    #[DataProvider('dataTestGetForm')]
+    public function testGetForm(string $enforcedTheme, array $themesState): void {
+        $themesState = array_map(
+            $this->formatThemeForm(...),
+            $themesState
+        );
+
+        $this->config->expects($this->once())
+            ->method('getSystemValueString')
+            ->with('enforce_theme', '')
+            ->willReturn($enforcedTheme);
+
+        $this->config->expects($this->any())
+            ->method('getUserValue')
+            ->willReturnMap([
+                ['admin', 'core', 'apporder', '[]', '[]'],
+                ['admin', 'theming', 'background_image', BackgroundService::BACKGROUND_DEFAULT],
+            ]);
+
+        $this->navigationManager->expects($this->once())
+            ->method('getDefaultEntryIdForUser')
+            ->willReturn('forced_id');
+
+        $this->initialStateService->expects($this->exactly(8))
+            ->method('provideInitialState')
+            ->willReturnMap([
+                ['shippedBackgrounds', BackgroundService::SHIPPED_BACKGROUNDS],
+                ['themingDefaults'],
+                ['enableBlurFilter', ''],
+                ['userBackgroundImage'],
+                ['themes', $themesState],
+                ['enforceTheme', $enforcedTheme],
+                ['isUserThemingDisabled', false],
+                ['navigationBar', ['userAppOrder' => [], 'enforcedDefaultApp' => 'forced_id']],
+            ]);
+
+        $expected = new TemplateResponse('theming', 'settings-personal');
+        $this->assertEquals($expected, $this->admin->getForm());
+    }
+
+    public function testGetSection(): void {
+        $this->assertSame('theming', $this->admin->getSection());
+    }
+
+    public function testGetPriority(): void {
+        $this->assertSame(40, $this->admin->getPriority());
+    }
+
+    private function initThemes() {
+        $util = $this->createMock(Util::class);
+        $themingDefaults = $this->createMock(ThemingDefaults::class);
+        $userSession = $this->createMock(IUserSession::class);
+        $urlGenerator = $this->createMock(IURLGenerator::class);
+        $imageManager = $this->createMock(ImageManager::class);
+        $config = $this->createMock(IConfig::class);
+        $l10n = $this->createMock(IL10N::class);
+        $appManager = $this->createMock(IAppManager::class);
+
+        $themingDefaults->expects($this->any())
+            ->method('getColorPrimary')
+            ->willReturn('#0082c9');
+
+        $themingDefaults->expects($this->any())
+            ->method('getDefaultColorPrimary')
+            ->willReturn('#0082c9');
+
+        $this->themes = [
+            'default' => new DefaultTheme(
+                $util,
+                $themingDefaults,
+                $userSession,
+                $urlGenerator,
+                $imageManager,
+                $config,
+                $l10n,
+                $appManager,
+                null,
+            ),
+            'light' => new LightTheme(
+                $util,
+                $themingDefaults,
+                $userSession,
+                $urlGenerator,
+                $imageManager,
+                $config,
+                $l10n,
+                $appManager,
+                null,
+            ),
+            'dark' => new DarkTheme(
+                $util,
+                $themingDefaults,
+                $userSession,
+                $urlGenerator,
+                $imageManager,
+                $config,
+                $l10n,
+                $appManager,
+                null,
+            ),
+            'light-highcontrast' => new HighContrastTheme(
+                $util,
+                $themingDefaults,
+                $userSession,
+                $urlGenerator,
+                $imageManager,
+                $config,
+                $l10n,
+                $appManager,
+                null,
+            ),
+            'dark-highcontrast' => new DarkHighContrastTheme(
+                $util,
+                $themingDefaults,
+                $userSession,
+                $urlGenerator,
+                $imageManager,
+                $config,
+                $l10n,
+                $appManager,
+                null,
+            ),
+            'opendyslexic' => new DyslexiaFont(
+                $util,
+                $themingDefaults,
+                $userSession,
+                $urlGenerator,
+                $imageManager,
+                $config,
+                $l10n,
+                $appManager,
+                null,
+            ),
+        ];
+    }
+
+    private function formatThemeForm(string $themeId): array {
+        $this->initThemes();
+
+        $theme = $this->themes[$themeId];
+        return [
+            'id' => $theme->getId(),
+            'type' => $theme->getType(),
+            'title' => $theme->getTitle(),
+            'enableLabel' => $theme->getEnableLabel(),
+            'description' => $theme->getDescription(),
+            'enabled' => false,
+        ];
+    }
 }

apps/theming/tests/Controller/ThemingControllerTest.php

Indentation +725 added lines, -725 removed lines

@@ -35,729 +35,729 @@
 
 class ThemingControllerTest extends TestCase {
 
-	private IRequest&MockObject $request;
-	private IConfig&MockObject $config;
-	private IAppConfig&MockObject $appConfig;
-	private ThemingDefaults&MockObject $themingDefaults;
-	private IL10N&MockObject $l10n;
-	private IAppManager&MockObject $appManager;
-	private ImageManager&MockObject $imageManager;
-	private IURLGenerator&MockObject $urlGenerator;
-	private ThemesService&MockObject $themesService;
-	private INavigationManager&MockObject $navigationManager;
-
-	private ThemingController $themingController;
-
-	protected function setUp(): void {
-		$this->request = $this->createMock(IRequest::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->appConfig = $this->createMock(IAppConfig::class);
-		$this->themingDefaults = $this->createMock(ThemingDefaults::class);
-		$this->l10n = $this->createMock(L10N::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->imageManager = $this->createMock(ImageManager::class);
-		$this->themesService = $this->createMock(ThemesService::class);
-		$this->navigationManager = $this->createMock(INavigationManager::class);
-
-		$timeFactory = $this->createMock(ITimeFactory::class);
-		$timeFactory->expects($this->any())
-			->method('getTime')
-			->willReturn(123);
-
-		$this->overwriteService(ITimeFactory::class, $timeFactory);
-
-		$this->themingController = new ThemingController(
-			'theming',
-			$this->request,
-			$this->config,
-			$this->appConfig,
-			$this->themingDefaults,
-			$this->l10n,
-			$this->urlGenerator,
-			$this->appManager,
-			$this->imageManager,
-			$this->themesService,
-			$this->navigationManager,
-		);
-
-		parent::setUp();
-	}
-
-	public static function dataUpdateStylesheetSuccess(): array {
-		return [
-			['name', str_repeat('a', 250), 'Saved'],
-			['url', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
-			['slogan', str_repeat('a', 500), 'Saved'],
-			['primaryColor', '#0082c9', 'Saved', 'primary_color'],
-			['primary_color', '#0082C9', 'Saved'],
-			['backgroundColor', '#0082C9', 'Saved', 'background_color'],
-			['background_color', '#0082C9', 'Saved'],
-			['imprintUrl', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
-			['privacyUrl', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateStylesheetSuccess')]
-	public function testUpdateStylesheetSuccess(string $setting, string $value, string $message, ?string $realSetting = null): void {
-		$this->themingDefaults
-			->expects($this->once())
-			->method('set')
-			->with($realSetting ?? $setting, $value);
-		$this->l10n
-			->expects($this->once())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => $message,
-					],
-				'status' => 'success',
-			]
-		);
-		$this->assertEquals($expected, $this->themingController->updateStylesheet($setting, $value));
-	}
-
-	public static function dataUpdateStylesheetError(): array {
-		$urls = [
-			'url' => 'web address',
-			'imprintUrl' => 'legal notice address',
-			'privacyUrl' => 'privacy policy address',
-		];
-
-		$urlTests = [];
-		foreach ($urls as $urlKey => $urlName) {
-			// Check length limit
-			$urlTests[] = [$urlKey, 'http://example.com/' . str_repeat('a', 501), "The given {$urlName} is too long"];
-			// Check potential evil javascript
-			$urlTests[] = [$urlKey, 'javascript:alert(1)', "The given {$urlName} is not a valid URL"];
-			// Check XSS
-			$urlTests[] = [$urlKey, 'https://example.com/"><script/src="alert(\'1\')"><a/href/="', "The given {$urlName} is not a valid URL"];
-		}
-
-		return [
-			['name', str_repeat('a', 251), 'The given name is too long'],
-			['slogan', str_repeat('a', 501), 'The given slogan is too long'],
-			['primary_color', '0082C9', 'The given color is invalid'],
-			['primary_color', '#0082Z9', 'The given color is invalid'],
-			['primary_color', 'Nextcloud', 'The given color is invalid'],
-			['background_color', '0082C9', 'The given color is invalid'],
-			['background_color', '#0082Z9', 'The given color is invalid'],
-			['background_color', 'Nextcloud', 'The given color is invalid'],
-
-			['doesnotexist', 'value', 'Invalid setting key'],
-
-			...$urlTests,
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateStylesheetError')]
-	public function testUpdateStylesheetError(string $setting, string $value, string $message): void {
-		$this->themingDefaults
-			->expects($this->never())
-			->method('set')
-			->with($setting, $value);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => $message,
-					],
-				'status' => 'error',
-			],
-			Http::STATUS_BAD_REQUEST
-		);
-		$this->assertEquals($expected, $this->themingController->updateStylesheet($setting, $value));
-	}
-
-	public function testUpdateLogoNoData(): void {
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('logo');
-		$this->request
-			->expects($this->once())
-			->method('getUploadedFile')
-			->with('image')
-			->willReturn(null);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => 'No file uploaded',
-					],
-				'status' => 'failure',
-			],
-			Http::STATUS_UNPROCESSABLE_ENTITY
-		);
-
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	public function testUploadInvalidUploadKey(): void {
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('invalid');
-		$this->request
-			->expects($this->never())
-			->method('getUploadedFile');
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => 'Invalid key',
-					],
-				'status' => 'failure',
-			],
-			Http::STATUS_BAD_REQUEST
-		);
-
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	/**
-	 * Checks that trying to upload an SVG favicon without imagemagick
-	 * results in an unsupported media type response.
-	 */
-	public function testUploadSVGFaviconWithoutImagemagick(): void {
-		$this->imageManager
-			->method('shouldReplaceIcons')
-			->willReturn(false);
-
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('favicon');
-		$this->request
-			->expects($this->once())
-			->method('getUploadedFile')
-			->with('image')
-			->willReturn([
-				'tmp_name' => __DIR__ . '/../../../../tests/data/testimagelarge.svg',
-				'type' => 'image/svg',
-				'name' => 'testimagelarge.svg',
-				'error' => 0,
-			]);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$this->imageManager->expects($this->once())
-			->method('updateImage')
-			->willThrowException(new \Exception('Unsupported image type'));
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => 'Unsupported image type',
-					],
-				'status' => 'failure'
-			],
-			Http::STATUS_UNPROCESSABLE_ENTITY
-		);
-
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	public function testUpdateLogoInvalidMimeType(): void {
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('logo');
-		$this->request
-			->expects($this->once())
-			->method('getUploadedFile')
-			->with('image')
-			->willReturn([
-				'tmp_name' => __DIR__ . '/../../../../tests/data/lorem.txt',
-				'type' => 'application/pdf',
-				'name' => 'logo.pdf',
-				'error' => 0,
-			]);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$this->imageManager->expects($this->once())
-			->method('updateImage')
-			->willThrowException(new \Exception('Unsupported image type'));
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => 'Unsupported image type',
-					],
-				'status' => 'failure'
-			],
-			Http::STATUS_UNPROCESSABLE_ENTITY
-		);
-
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	public static function dataUpdateImages(): array {
-		return [
-			['image/jpeg', false],
-			['image/jpeg', true],
-			['image/gif'],
-			['image/png'],
-			['image/svg+xml'],
-			['image/svg']
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateImages')]
-	public function testUpdateLogoNormalLogoUpload(string $mimeType, bool $folderExists = true): void {
-		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . '/logo.svg';
-		$destination = Server::get(ITempManager::class)->getTemporaryFolder();
-
-		touch($tmpLogo);
-		copy(__DIR__ . '/../../../../tests/data/testimage.png', $tmpLogo);
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('logo');
-		$this->request
-			->expects($this->once())
-			->method('getUploadedFile')
-			->with('image')
-			->willReturn([
-				'tmp_name' => $tmpLogo,
-				'type' => $mimeType,
-				'name' => 'logo.svg',
-				'error' => 0,
-			]);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$this->imageManager->expects($this->once())
-			->method('getImageUrl')
-			->with('logo')
-			->willReturn('imageUrl');
-
-		$this->imageManager->expects($this->once())
-			->method('updateImage');
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'name' => 'logo.svg',
-						'message' => 'Saved',
-						'url' => 'imageUrl',
-					],
-				'status' => 'success'
-			]
-		);
-
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	public function testUpdateLogoLoginScreenUpload(): void {
-		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . 'logo.png';
-
-		touch($tmpLogo);
-		copy(__DIR__ . '/../../../../tests/data/desktopapp.png', $tmpLogo);
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('background');
-		$this->request
-			->expects($this->once())
-			->method('getUploadedFile')
-			->with('image')
-			->willReturn([
-				'tmp_name' => $tmpLogo,
-				'type' => 'image/svg+xml',
-				'name' => 'logo.svg',
-				'error' => 0,
-			]);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$this->imageManager->expects($this->once())
-			->method('updateImage');
-
-		$this->imageManager->expects($this->once())
-			->method('getImageUrl')
-			->with('background')
-			->willReturn('imageUrl');
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'name' => 'logo.svg',
-						'message' => 'Saved',
-						'url' => 'imageUrl',
-					],
-				'status' => 'success'
-			]
-		);
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	public function testUpdateLogoLoginScreenUploadWithInvalidImage(): void {
-		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . '/logo.svg';
-
-		touch($tmpLogo);
-		file_put_contents($tmpLogo, file_get_contents(__DIR__ . '/../../../../tests/data/data.zip'));
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('logo');
-		$this->request
-			->expects($this->once())
-			->method('getUploadedFile')
-			->with('image')
-			->willReturn([
-				'tmp_name' => $tmpLogo,
-				'type' => 'foobar',
-				'name' => 'logo.svg',
-				'error' => 0,
-			]);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$this->imageManager->expects($this->once())
-			->method('updateImage')
-			->willThrowException(new \Exception('Unsupported image type'));
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => 'Unsupported image type',
-					],
-				'status' => 'failure'
-			],
-			Http::STATUS_UNPROCESSABLE_ENTITY
-		);
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	public static function dataPhpUploadErrors(): array {
-		return [
-			[UPLOAD_ERR_INI_SIZE, 'The uploaded file exceeds the upload_max_filesize directive in php.ini'],
-			[UPLOAD_ERR_FORM_SIZE, 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form'],
-			[UPLOAD_ERR_PARTIAL, 'The file was only partially uploaded'],
-			[UPLOAD_ERR_NO_FILE, 'No file was uploaded'],
-			[UPLOAD_ERR_NO_TMP_DIR, 'Missing a temporary folder'],
-			[UPLOAD_ERR_CANT_WRITE, 'Could not write file to disk'],
-			[UPLOAD_ERR_EXTENSION, 'A PHP extension stopped the file upload'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataPhpUploadErrors')]
-	public function testUpdateLogoLoginScreenUploadWithInvalidImageUpload(int $error, string $expectedErrorMessage): void {
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('background');
-		$this->request
-			->expects($this->once())
-			->method('getUploadedFile')
-			->with('image')
-			->willReturn([
-				'tmp_name' => '',
-				'type' => 'image/svg+xml',
-				'name' => 'logo.svg',
-				'error' => $error,
-			]);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => $expectedErrorMessage,
-					],
-				'status' => 'failure'
-			],
-			Http::STATUS_UNPROCESSABLE_ENTITY
-		);
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataPhpUploadErrors')]
-	public function testUpdateLogoUploadWithInvalidImageUpload($error, $expectedErrorMessage): void {
-		$this->request
-			->expects($this->once())
-			->method('getParam')
-			->with('key')
-			->willReturn('background');
-		$this->request
-			->expects($this->once())
-			->method('getUploadedFile')
-			->with('image')
-			->willReturn([
-				'tmp_name' => '',
-				'type' => 'text/svg',
-				'name' => 'logo.svg',
-				'error' => $error,
-			]);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($str) {
-				return $str;
-			});
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'message' => $expectedErrorMessage
-					],
-				'status' => 'failure'
-			],
-			Http::STATUS_UNPROCESSABLE_ENTITY
-		);
-		$this->assertEquals($expected, $this->themingController->uploadImage());
-	}
-
-	public function testUndo(): void {
-		$this->l10n
-			->expects($this->once())
-			->method('t')
-			->with('Saved')
-			->willReturn('Saved');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('undo')
-			->with('MySetting')
-			->willReturn('MyValue');
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'value' => 'MyValue',
-						'message' => 'Saved'
-					],
-				'status' => 'success'
-			]
-		);
-		$this->assertEquals($expected, $this->themingController->undo('MySetting'));
-	}
-
-	public static function dataUndoDelete(): array {
-		return [
-			[ 'backgroundMime', 'background' ],
-			[ 'logoMime', 'logo' ]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataUndoDelete')]
-	public function testUndoDelete(string $value, string $filename): void {
-		$this->l10n
-			->expects($this->once())
-			->method('t')
-			->with('Saved')
-			->willReturn('Saved');
-		$this->themingDefaults
-			->expects($this->once())
-			->method('undo')
-			->with($value)
-			->willReturn($value);
-
-		$expected = new DataResponse(
-			[
-				'data'
-					=> [
-						'value' => $value,
-						'message' => 'Saved',
-					],
-				'status' => 'success'
-			]
-		);
-		$this->assertEquals($expected, $this->themingController->undo($value));
-	}
-
-
-
-	public function testGetLogoNotExistent(): void {
-		$this->imageManager->method('getImage')
-			->with($this->equalTo('logo'))
-			->willThrowException(new NotFoundException());
-
-		$expected = new NotFoundResponse();
-		$this->assertEquals($expected, $this->themingController->getImage('logo'));
-	}
-
-	public function testGetLogo(): void {
-		$file = $this->createMock(ISimpleFile::class);
-		$file->method('getName')->willReturn('logo.svg');
-		$file->method('getMTime')->willReturn(42);
-		$this->imageManager->expects($this->once())
-			->method('getImage')
-			->willReturn($file);
-		$this->config
-			->expects($this->any())
-			->method('getAppValue')
-			->with('theming', 'logoMime', '')
-			->willReturn('text/svg');
-
-		@$expected = new FileDisplayResponse($file);
-		$expected->cacheFor(3600);
-		$expected->addHeader('Content-Type', 'text/svg');
-		$expected->addHeader('Content-Disposition', 'attachment; filename="logo"');
-		$csp = new ContentSecurityPolicy();
-		$csp->allowInlineStyle();
-		$expected->setContentSecurityPolicy($csp);
-		@$this->assertEquals($expected, $this->themingController->getImage('logo'));
-	}
-
-
-	public function testGetLoginBackgroundNotExistent(): void {
-		$this->imageManager->method('getImage')
-			->with($this->equalTo('background'))
-			->willThrowException(new NotFoundException());
-		$expected = new NotFoundResponse();
-		$this->assertEquals($expected, $this->themingController->getImage('background'));
-	}
-
-	public function testGetLoginBackground(): void {
-		$file = $this->createMock(ISimpleFile::class);
-		$file->method('getName')->willReturn('background.png');
-		$file->method('getMTime')->willReturn(42);
-		$this->imageManager->expects($this->once())
-			->method('getImage')
-			->willReturn($file);
-
-		$this->config
-			->expects($this->any())
-			->method('getAppValue')
-			->with('theming', 'backgroundMime', '')
-			->willReturn('image/png');
-
-		@$expected = new FileDisplayResponse($file);
-		$expected->cacheFor(3600);
-		$expected->addHeader('Content-Type', 'image/png');
-		$expected->addHeader('Content-Disposition', 'attachment; filename="background"');
-		$csp = new ContentSecurityPolicy();
-		$csp->allowInlineStyle();
-		$expected->setContentSecurityPolicy($csp);
-		@$this->assertEquals($expected, $this->themingController->getImage('background'));
-	}
-
-	public static function dataGetManifest(): array {
-		return [
-			[true],
-			[false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataGetManifest')]
-	public function testGetManifest(bool $standalone): void {
-		$this->config
-			->expects($this->once())
-			->method('getAppValue')
-			->with('theming', 'cachebuster', '0')
-			->willReturn('0');
-		$this->themingDefaults
-			->expects($this->any())
-			->method('getName')
-			->willReturn('Nextcloud');
-		$this->urlGenerator
-			->expects($this->once())
-			->method('getBaseUrl')
-			->willReturn('localhost');
-		$this->urlGenerator
-			->expects($this->exactly(2))
-			->method('linkToRoute')
-			->willReturnMap([
-				['theming.Icon.getTouchIcon', ['app' => 'core'], 'touchicon'],
-				['theming.Icon.getFavicon', ['app' => 'core'], 'favicon'],
-			]);
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValueBool')
-			->with('theming.standalone_window.enabled', true)
-			->willReturn($standalone);
-		$response = new JSONResponse([
-			'name' => 'Nextcloud',
-			'start_url' => 'localhost',
-			'icons'
-				=> [
-					[
-						'src' => 'touchicon?v=0',
-						'type' => 'image/png',
-						'sizes' => '512x512'
-					],
-					[
-						'src' => 'favicon?v=0',
-						'type' => 'image/svg+xml',
-						'sizes' => '16x16'
-					]
-				],
-			'display_override' => [$standalone ? 'minimal-ui' : ''],
-			'display' => $standalone ? 'standalone' : 'browser',
-			'short_name' => 'Nextcloud',
-			'theme_color' => null,
-			'background_color' => null,
-			'description' => null
-		]);
-		$response->cacheFor(3600);
-		$this->assertEquals($response, $this->themingController->getManifest('core'));
-	}
+    private IRequest&MockObject $request;
+    private IConfig&MockObject $config;
+    private IAppConfig&MockObject $appConfig;
+    private ThemingDefaults&MockObject $themingDefaults;
+    private IL10N&MockObject $l10n;
+    private IAppManager&MockObject $appManager;
+    private ImageManager&MockObject $imageManager;
+    private IURLGenerator&MockObject $urlGenerator;
+    private ThemesService&MockObject $themesService;
+    private INavigationManager&MockObject $navigationManager;
+
+    private ThemingController $themingController;
+
+    protected function setUp(): void {
+        $this->request = $this->createMock(IRequest::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->appConfig = $this->createMock(IAppConfig::class);
+        $this->themingDefaults = $this->createMock(ThemingDefaults::class);
+        $this->l10n = $this->createMock(L10N::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->imageManager = $this->createMock(ImageManager::class);
+        $this->themesService = $this->createMock(ThemesService::class);
+        $this->navigationManager = $this->createMock(INavigationManager::class);
+
+        $timeFactory = $this->createMock(ITimeFactory::class);
+        $timeFactory->expects($this->any())
+            ->method('getTime')
+            ->willReturn(123);
+
+        $this->overwriteService(ITimeFactory::class, $timeFactory);
+
+        $this->themingController = new ThemingController(
+            'theming',
+            $this->request,
+            $this->config,
+            $this->appConfig,
+            $this->themingDefaults,
+            $this->l10n,
+            $this->urlGenerator,
+            $this->appManager,
+            $this->imageManager,
+            $this->themesService,
+            $this->navigationManager,
+        );
+
+        parent::setUp();
+    }
+
+    public static function dataUpdateStylesheetSuccess(): array {
+        return [
+            ['name', str_repeat('a', 250), 'Saved'],
+            ['url', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
+            ['slogan', str_repeat('a', 500), 'Saved'],
+            ['primaryColor', '#0082c9', 'Saved', 'primary_color'],
+            ['primary_color', '#0082C9', 'Saved'],
+            ['backgroundColor', '#0082C9', 'Saved', 'background_color'],
+            ['background_color', '#0082C9', 'Saved'],
+            ['imprintUrl', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
+            ['privacyUrl', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateStylesheetSuccess')]
+    public function testUpdateStylesheetSuccess(string $setting, string $value, string $message, ?string $realSetting = null): void {
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('set')
+            ->with($realSetting ?? $setting, $value);
+        $this->l10n
+            ->expects($this->once())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => $message,
+                    ],
+                'status' => 'success',
+            ]
+        );
+        $this->assertEquals($expected, $this->themingController->updateStylesheet($setting, $value));
+    }
+
+    public static function dataUpdateStylesheetError(): array {
+        $urls = [
+            'url' => 'web address',
+            'imprintUrl' => 'legal notice address',
+            'privacyUrl' => 'privacy policy address',
+        ];
+
+        $urlTests = [];
+        foreach ($urls as $urlKey => $urlName) {
+            // Check length limit
+            $urlTests[] = [$urlKey, 'http://example.com/' . str_repeat('a', 501), "The given {$urlName} is too long"];
+            // Check potential evil javascript
+            $urlTests[] = [$urlKey, 'javascript:alert(1)', "The given {$urlName} is not a valid URL"];
+            // Check XSS
+            $urlTests[] = [$urlKey, 'https://example.com/"><script/src="alert(\'1\')"><a/href/="', "The given {$urlName} is not a valid URL"];
+        }
+
+        return [
+            ['name', str_repeat('a', 251), 'The given name is too long'],
+            ['slogan', str_repeat('a', 501), 'The given slogan is too long'],
+            ['primary_color', '0082C9', 'The given color is invalid'],
+            ['primary_color', '#0082Z9', 'The given color is invalid'],
+            ['primary_color', 'Nextcloud', 'The given color is invalid'],
+            ['background_color', '0082C9', 'The given color is invalid'],
+            ['background_color', '#0082Z9', 'The given color is invalid'],
+            ['background_color', 'Nextcloud', 'The given color is invalid'],
+
+            ['doesnotexist', 'value', 'Invalid setting key'],
+
+            ...$urlTests,
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateStylesheetError')]
+    public function testUpdateStylesheetError(string $setting, string $value, string $message): void {
+        $this->themingDefaults
+            ->expects($this->never())
+            ->method('set')
+            ->with($setting, $value);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => $message,
+                    ],
+                'status' => 'error',
+            ],
+            Http::STATUS_BAD_REQUEST
+        );
+        $this->assertEquals($expected, $this->themingController->updateStylesheet($setting, $value));
+    }
+
+    public function testUpdateLogoNoData(): void {
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('logo');
+        $this->request
+            ->expects($this->once())
+            ->method('getUploadedFile')
+            ->with('image')
+            ->willReturn(null);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => 'No file uploaded',
+                    ],
+                'status' => 'failure',
+            ],
+            Http::STATUS_UNPROCESSABLE_ENTITY
+        );
+
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    public function testUploadInvalidUploadKey(): void {
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('invalid');
+        $this->request
+            ->expects($this->never())
+            ->method('getUploadedFile');
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => 'Invalid key',
+                    ],
+                'status' => 'failure',
+            ],
+            Http::STATUS_BAD_REQUEST
+        );
+
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    /**
+     * Checks that trying to upload an SVG favicon without imagemagick
+     * results in an unsupported media type response.
+     */
+    public function testUploadSVGFaviconWithoutImagemagick(): void {
+        $this->imageManager
+            ->method('shouldReplaceIcons')
+            ->willReturn(false);
+
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('favicon');
+        $this->request
+            ->expects($this->once())
+            ->method('getUploadedFile')
+            ->with('image')
+            ->willReturn([
+                'tmp_name' => __DIR__ . '/../../../../tests/data/testimagelarge.svg',
+                'type' => 'image/svg',
+                'name' => 'testimagelarge.svg',
+                'error' => 0,
+            ]);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $this->imageManager->expects($this->once())
+            ->method('updateImage')
+            ->willThrowException(new \Exception('Unsupported image type'));
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => 'Unsupported image type',
+                    ],
+                'status' => 'failure'
+            ],
+            Http::STATUS_UNPROCESSABLE_ENTITY
+        );
+
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    public function testUpdateLogoInvalidMimeType(): void {
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('logo');
+        $this->request
+            ->expects($this->once())
+            ->method('getUploadedFile')
+            ->with('image')
+            ->willReturn([
+                'tmp_name' => __DIR__ . '/../../../../tests/data/lorem.txt',
+                'type' => 'application/pdf',
+                'name' => 'logo.pdf',
+                'error' => 0,
+            ]);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $this->imageManager->expects($this->once())
+            ->method('updateImage')
+            ->willThrowException(new \Exception('Unsupported image type'));
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => 'Unsupported image type',
+                    ],
+                'status' => 'failure'
+            ],
+            Http::STATUS_UNPROCESSABLE_ENTITY
+        );
+
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    public static function dataUpdateImages(): array {
+        return [
+            ['image/jpeg', false],
+            ['image/jpeg', true],
+            ['image/gif'],
+            ['image/png'],
+            ['image/svg+xml'],
+            ['image/svg']
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateImages')]
+    public function testUpdateLogoNormalLogoUpload(string $mimeType, bool $folderExists = true): void {
+        $tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . '/logo.svg';
+        $destination = Server::get(ITempManager::class)->getTemporaryFolder();
+
+        touch($tmpLogo);
+        copy(__DIR__ . '/../../../../tests/data/testimage.png', $tmpLogo);
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('logo');
+        $this->request
+            ->expects($this->once())
+            ->method('getUploadedFile')
+            ->with('image')
+            ->willReturn([
+                'tmp_name' => $tmpLogo,
+                'type' => $mimeType,
+                'name' => 'logo.svg',
+                'error' => 0,
+            ]);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $this->imageManager->expects($this->once())
+            ->method('getImageUrl')
+            ->with('logo')
+            ->willReturn('imageUrl');
+
+        $this->imageManager->expects($this->once())
+            ->method('updateImage');
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'name' => 'logo.svg',
+                        'message' => 'Saved',
+                        'url' => 'imageUrl',
+                    ],
+                'status' => 'success'
+            ]
+        );
+
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    public function testUpdateLogoLoginScreenUpload(): void {
+        $tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . 'logo.png';
+
+        touch($tmpLogo);
+        copy(__DIR__ . '/../../../../tests/data/desktopapp.png', $tmpLogo);
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('background');
+        $this->request
+            ->expects($this->once())
+            ->method('getUploadedFile')
+            ->with('image')
+            ->willReturn([
+                'tmp_name' => $tmpLogo,
+                'type' => 'image/svg+xml',
+                'name' => 'logo.svg',
+                'error' => 0,
+            ]);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $this->imageManager->expects($this->once())
+            ->method('updateImage');
+
+        $this->imageManager->expects($this->once())
+            ->method('getImageUrl')
+            ->with('background')
+            ->willReturn('imageUrl');
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'name' => 'logo.svg',
+                        'message' => 'Saved',
+                        'url' => 'imageUrl',
+                    ],
+                'status' => 'success'
+            ]
+        );
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    public function testUpdateLogoLoginScreenUploadWithInvalidImage(): void {
+        $tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . '/logo.svg';
+
+        touch($tmpLogo);
+        file_put_contents($tmpLogo, file_get_contents(__DIR__ . '/../../../../tests/data/data.zip'));
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('logo');
+        $this->request
+            ->expects($this->once())
+            ->method('getUploadedFile')
+            ->with('image')
+            ->willReturn([
+                'tmp_name' => $tmpLogo,
+                'type' => 'foobar',
+                'name' => 'logo.svg',
+                'error' => 0,
+            ]);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $this->imageManager->expects($this->once())
+            ->method('updateImage')
+            ->willThrowException(new \Exception('Unsupported image type'));
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => 'Unsupported image type',
+                    ],
+                'status' => 'failure'
+            ],
+            Http::STATUS_UNPROCESSABLE_ENTITY
+        );
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    public static function dataPhpUploadErrors(): array {
+        return [
+            [UPLOAD_ERR_INI_SIZE, 'The uploaded file exceeds the upload_max_filesize directive in php.ini'],
+            [UPLOAD_ERR_FORM_SIZE, 'The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form'],
+            [UPLOAD_ERR_PARTIAL, 'The file was only partially uploaded'],
+            [UPLOAD_ERR_NO_FILE, 'No file was uploaded'],
+            [UPLOAD_ERR_NO_TMP_DIR, 'Missing a temporary folder'],
+            [UPLOAD_ERR_CANT_WRITE, 'Could not write file to disk'],
+            [UPLOAD_ERR_EXTENSION, 'A PHP extension stopped the file upload'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataPhpUploadErrors')]
+    public function testUpdateLogoLoginScreenUploadWithInvalidImageUpload(int $error, string $expectedErrorMessage): void {
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('background');
+        $this->request
+            ->expects($this->once())
+            ->method('getUploadedFile')
+            ->with('image')
+            ->willReturn([
+                'tmp_name' => '',
+                'type' => 'image/svg+xml',
+                'name' => 'logo.svg',
+                'error' => $error,
+            ]);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => $expectedErrorMessage,
+                    ],
+                'status' => 'failure'
+            ],
+            Http::STATUS_UNPROCESSABLE_ENTITY
+        );
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataPhpUploadErrors')]
+    public function testUpdateLogoUploadWithInvalidImageUpload($error, $expectedErrorMessage): void {
+        $this->request
+            ->expects($this->once())
+            ->method('getParam')
+            ->with('key')
+            ->willReturn('background');
+        $this->request
+            ->expects($this->once())
+            ->method('getUploadedFile')
+            ->with('image')
+            ->willReturn([
+                'tmp_name' => '',
+                'type' => 'text/svg',
+                'name' => 'logo.svg',
+                'error' => $error,
+            ]);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($str) {
+                return $str;
+            });
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'message' => $expectedErrorMessage
+                    ],
+                'status' => 'failure'
+            ],
+            Http::STATUS_UNPROCESSABLE_ENTITY
+        );
+        $this->assertEquals($expected, $this->themingController->uploadImage());
+    }
+
+    public function testUndo(): void {
+        $this->l10n
+            ->expects($this->once())
+            ->method('t')
+            ->with('Saved')
+            ->willReturn('Saved');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('undo')
+            ->with('MySetting')
+            ->willReturn('MyValue');
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'value' => 'MyValue',
+                        'message' => 'Saved'
+                    ],
+                'status' => 'success'
+            ]
+        );
+        $this->assertEquals($expected, $this->themingController->undo('MySetting'));
+    }
+
+    public static function dataUndoDelete(): array {
+        return [
+            [ 'backgroundMime', 'background' ],
+            [ 'logoMime', 'logo' ]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataUndoDelete')]
+    public function testUndoDelete(string $value, string $filename): void {
+        $this->l10n
+            ->expects($this->once())
+            ->method('t')
+            ->with('Saved')
+            ->willReturn('Saved');
+        $this->themingDefaults
+            ->expects($this->once())
+            ->method('undo')
+            ->with($value)
+            ->willReturn($value);
+
+        $expected = new DataResponse(
+            [
+                'data'
+                    => [
+                        'value' => $value,
+                        'message' => 'Saved',
+                    ],
+                'status' => 'success'
+            ]
+        );
+        $this->assertEquals($expected, $this->themingController->undo($value));
+    }
+
+
+
+    public function testGetLogoNotExistent(): void {
+        $this->imageManager->method('getImage')
+            ->with($this->equalTo('logo'))
+            ->willThrowException(new NotFoundException());
+
+        $expected = new NotFoundResponse();
+        $this->assertEquals($expected, $this->themingController->getImage('logo'));
+    }
+
+    public function testGetLogo(): void {
+        $file = $this->createMock(ISimpleFile::class);
+        $file->method('getName')->willReturn('logo.svg');
+        $file->method('getMTime')->willReturn(42);
+        $this->imageManager->expects($this->once())
+            ->method('getImage')
+            ->willReturn($file);
+        $this->config
+            ->expects($this->any())
+            ->method('getAppValue')
+            ->with('theming', 'logoMime', '')
+            ->willReturn('text/svg');
+
+        @$expected = new FileDisplayResponse($file);
+        $expected->cacheFor(3600);
+        $expected->addHeader('Content-Type', 'text/svg');
+        $expected->addHeader('Content-Disposition', 'attachment; filename="logo"');
+        $csp = new ContentSecurityPolicy();
+        $csp->allowInlineStyle();
+        $expected->setContentSecurityPolicy($csp);
+        @$this->assertEquals($expected, $this->themingController->getImage('logo'));
+    }
+
+
+    public function testGetLoginBackgroundNotExistent(): void {
+        $this->imageManager->method('getImage')
+            ->with($this->equalTo('background'))
+            ->willThrowException(new NotFoundException());
+        $expected = new NotFoundResponse();
+        $this->assertEquals($expected, $this->themingController->getImage('background'));
+    }
+
+    public function testGetLoginBackground(): void {
+        $file = $this->createMock(ISimpleFile::class);
+        $file->method('getName')->willReturn('background.png');
+        $file->method('getMTime')->willReturn(42);
+        $this->imageManager->expects($this->once())
+            ->method('getImage')
+            ->willReturn($file);
+
+        $this->config
+            ->expects($this->any())
+            ->method('getAppValue')
+            ->with('theming', 'backgroundMime', '')
+            ->willReturn('image/png');
+
+        @$expected = new FileDisplayResponse($file);
+        $expected->cacheFor(3600);
+        $expected->addHeader('Content-Type', 'image/png');
+        $expected->addHeader('Content-Disposition', 'attachment; filename="background"');
+        $csp = new ContentSecurityPolicy();
+        $csp->allowInlineStyle();
+        $expected->setContentSecurityPolicy($csp);
+        @$this->assertEquals($expected, $this->themingController->getImage('background'));
+    }
+
+    public static function dataGetManifest(): array {
+        return [
+            [true],
+            [false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataGetManifest')]
+    public function testGetManifest(bool $standalone): void {
+        $this->config
+            ->expects($this->once())
+            ->method('getAppValue')
+            ->with('theming', 'cachebuster', '0')
+            ->willReturn('0');
+        $this->themingDefaults
+            ->expects($this->any())
+            ->method('getName')
+            ->willReturn('Nextcloud');
+        $this->urlGenerator
+            ->expects($this->once())
+            ->method('getBaseUrl')
+            ->willReturn('localhost');
+        $this->urlGenerator
+            ->expects($this->exactly(2))
+            ->method('linkToRoute')
+            ->willReturnMap([
+                ['theming.Icon.getTouchIcon', ['app' => 'core'], 'touchicon'],
+                ['theming.Icon.getFavicon', ['app' => 'core'], 'favicon'],
+            ]);
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValueBool')
+            ->with('theming.standalone_window.enabled', true)
+            ->willReturn($standalone);
+        $response = new JSONResponse([
+            'name' => 'Nextcloud',
+            'start_url' => 'localhost',
+            'icons'
+                => [
+                    [
+                        'src' => 'touchicon?v=0',
+                        'type' => 'image/png',
+                        'sizes' => '512x512'
+                    ],
+                    [
+                        'src' => 'favicon?v=0',
+                        'type' => 'image/svg+xml',
+                        'sizes' => '16x16'
+                    ]
+                ],
+            'display_override' => [$standalone ? 'minimal-ui' : ''],
+            'display' => $standalone ? 'standalone' : 'browser',
+            'short_name' => 'Nextcloud',
+            'theme_color' => null,
+            'background_color' => null,
+            'description' => null
+        ]);
+        $response->cacheFor(3600);
+        $this->assertEquals($response, $this->themingController->getManifest('core'));
+    }
 }

Spacing +25 added lines, -25 removed lines

@@ -87,14 +87,14 @@ 
 	public static function dataUpdateStylesheetSuccess(): array {
 		return [
 			['name', str_repeat('a', 250), 'Saved'],
-			['url', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
+			['url', 'https://nextcloud.com/'.str_repeat('a', 478), 'Saved'],
 			['slogan', str_repeat('a', 500), 'Saved'],
 			['primaryColor', '#0082c9', 'Saved', 'primary_color'],
 			['primary_color', '#0082C9', 'Saved'],
 			['backgroundColor', '#0082C9', 'Saved', 'background_color'],
 			['background_color', '#0082C9', 'Saved'],
-			['imprintUrl', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
-			['privacyUrl', 'https://nextcloud.com/' . str_repeat('a', 478), 'Saved'],
+			['imprintUrl', 'https://nextcloud.com/'.str_repeat('a', 478), 'Saved'],
+			['privacyUrl', 'https://nextcloud.com/'.str_repeat('a', 478), 'Saved'],
 		];
 	}
 
@@ -107,7 +107,7 @@ 
 		$this->l10n
 			->expects($this->once())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -133,7 +133,7 @@ 
 		$urlTests = [];
 		foreach ($urls as $urlKey => $urlName) {
 			// Check length limit
-			$urlTests[] = [$urlKey, 'http://example.com/' . str_repeat('a', 501), "The given {$urlName} is too long"];
+			$urlTests[] = [$urlKey, 'http://example.com/'.str_repeat('a', 501), "The given {$urlName} is too long"];
 			// Check potential evil javascript
 			$urlTests[] = [$urlKey, 'javascript:alert(1)', "The given {$urlName} is not a valid URL"];
 			// Check XSS
@@ -165,7 +165,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -196,7 +196,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -226,7 +226,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -263,7 +263,7 @@ 
 			->method('getUploadedFile')
 			->with('image')
 			->willReturn([
-				'tmp_name' => __DIR__ . '/../../../../tests/data/testimagelarge.svg',
+				'tmp_name' => __DIR__.'/../../../../tests/data/testimagelarge.svg',
 				'type' => 'image/svg',
 				'name' => 'testimagelarge.svg',
 				'error' => 0,
@@ -271,7 +271,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -304,7 +304,7 @@ 
 			->method('getUploadedFile')
 			->with('image')
 			->willReturn([
-				'tmp_name' => __DIR__ . '/../../../../tests/data/lorem.txt',
+				'tmp_name' => __DIR__.'/../../../../tests/data/lorem.txt',
 				'type' => 'application/pdf',
 				'name' => 'logo.pdf',
 				'error' => 0,
@@ -312,7 +312,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -347,11 +347,11 @@ 
 
 	#[\PHPUnit\Framework\Attributes\DataProvider('dataUpdateImages')]
 	public function testUpdateLogoNormalLogoUpload(string $mimeType, bool $folderExists = true): void {
-		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . '/logo.svg';
+		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder().'/logo.svg';
 		$destination = Server::get(ITempManager::class)->getTemporaryFolder();
 
 		touch($tmpLogo);
-		copy(__DIR__ . '/../../../../tests/data/testimage.png', $tmpLogo);
+		copy(__DIR__.'/../../../../tests/data/testimage.png', $tmpLogo);
 		$this->request
 			->expects($this->once())
 			->method('getParam')
@@ -370,7 +370,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -398,10 +398,10 @@ 
 	}
 
 	public function testUpdateLogoLoginScreenUpload(): void {
-		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . 'logo.png';
+		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder().'logo.png';
 
 		touch($tmpLogo);
-		copy(__DIR__ . '/../../../../tests/data/desktopapp.png', $tmpLogo);
+		copy(__DIR__.'/../../../../tests/data/desktopapp.png', $tmpLogo);
 		$this->request
 			->expects($this->once())
 			->method('getParam')
@@ -420,7 +420,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -446,10 +446,10 @@ 
 	}
 
 	public function testUpdateLogoLoginScreenUploadWithInvalidImage(): void {
-		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder() . '/logo.svg';
+		$tmpLogo = Server::get(ITempManager::class)->getTemporaryFolder().'/logo.svg';
 
 		touch($tmpLogo);
-		file_put_contents($tmpLogo, file_get_contents(__DIR__ . '/../../../../tests/data/data.zip'));
+		file_put_contents($tmpLogo, file_get_contents(__DIR__.'/../../../../tests/data/data.zip'));
 		$this->request
 			->expects($this->once())
 			->method('getParam')
@@ -468,7 +468,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -521,7 +521,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -558,7 +558,7 @@ 
 		$this->l10n
 			->expects($this->any())
 			->method('t')
-			->willReturnCallback(function ($str) {
+			->willReturnCallback(function($str) {
 				return $str;
 			});
 
@@ -602,8 +602,8 @@ 
 
 	public static function dataUndoDelete(): array {
 		return [
-			[ 'backgroundMime', 'background' ],
-			[ 'logoMime', 'logo' ]
+			['backgroundMime', 'background'],
+			['logoMime', 'logo']
 		];
 	}