nextcloud / server

apps/dav/lib/Connector/Sabre/FilesPlugin.php

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
 namespace OCA\DAV\Connector\Sabre;
 
 use OC\Files\View;
-use OCA\DAV\Upload\FutureFile;
 use OCP\Files\ForbiddenException;
 use Sabre\DAV\Exception\Forbidden;
 use Sabre\DAV\Exception\NotFound;

apps/files_external/lib/Lib/Storage/Google.php

Doc Comments +1 added lines, -1 removed lines

@@ -216,7 +216,7 @@
 	 *
 	 * @param \Google_Service_Drive_DriveFile
 	 *
-	 * @return true if the file is a Google Doc file, false otherwise
+	 * @return boolean if the file is a Google Doc file, false otherwise
 	 */
 	private function isGoogleDocFile($file) {
 		return $this->getGoogleDocExtension($file->getMimeType()) !== '';

core/Controller/TokenController.php

Doc Comments +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
 	/**
 	 * @param string $appName
 	 * @param IRequest $request
-	 * @param Manager $userManager
+	 * @param UserManager $userManager
 	 * @param DefaultTokenProvider $tokenProvider
 	 * @param ISecureRandom $secureRandom
 	 */

lib/private/Files/View.php

Doc Comments +4 added lines, -4 removed lines

@@ -200,7 +200,7 @@ 
 	 * and does not take the chroot into account )
 	 *
 	 * @param string $path
-	 * @return \OCP\Files\Mount\IMountPoint
+	 * @return Mount\MountPoint|null
 	 */
 	public function getMount($path) {
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -963,7 +963,7 @@ 
 
 	/**
 	 * @param string $path
-	 * @return bool|string
+	 * @return string|false
 	 * @throws \OCP\Files\InvalidPathException
 	 */
 	public function toTmpFile($path) {
@@ -1078,7 +1078,7 @@ 
 	 * @param string $path
 	 * @param array $hooks (optional)
 	 * @param mixed $extraParam (optional)
-	 * @return mixed
+	 * @return string
 	 * @throws \Exception
 	 *
 	 * This method takes requests for basic filesystem functions (e.g. reading & writing
@@ -2086,7 +2086,7 @@ 
 
 	/**
 	 * @param string $filename
-	 * @return array
+	 * @return string[]
 	 * @throws \OC\User\NoUserException
 	 * @throws NotFoundException
 	 */

lib/private/User/Session.php

Doc Comments +7 added lines, -1 removed lines

@@ -292,7 +292,7 @@ 
 	 *
 	 * @param string $uid
 	 * @param string $password
-	 * @return boolean|null
+	 * @return boolean
 	 * @throws LoginException
 	 */
 	public function login($uid, $password) {
@@ -375,6 +375,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -446,6 +449,9 @@ 
 		return false;
 	}
 
+	/**
+	 * @param string $uid
+	 */
 	private function loginWithToken($uid) {
 		// TODO: $this->manager->emit('\OC\User', 'preTokenLogin', array($uid));
 		$user = $this->manager->get($uid);