nextcloud / server

tests/lib/InstallerTest.php

Indentation +450 added lines, -450 removed lines

@@ -26,153 +26,153 @@ 
  * @group DB
  */
 class InstallerTest extends TestCase {
-	private static $appid = 'testapp';
-	private $appstore;
-	/** @var AppFetcher|\PHPUnit\Framework\MockObject\MockObject */
-	private $appFetcher;
-	/** @var IClientService|\PHPUnit\Framework\MockObject\MockObject */
-	private $clientService;
-	/** @var ITempManager|\PHPUnit\Framework\MockObject\MockObject */
-	private $tempManager;
-	/** @var LoggerInterface|\PHPUnit\Framework\MockObject\MockObject */
-	private $logger;
-	/** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
-	private $config;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->appFetcher = $this->createMock(AppFetcher::class);
-		$this->clientService = $this->createMock(IClientService::class);
-		$this->tempManager = $this->createMock(ITempManager::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->config = $this->createMock(IConfig::class);
-
-		$config = Server::get(IConfig::class);
-		$this->appstore = $config->setSystemValue('appstoreenabled', true);
-		$config->setSystemValue('appstoreenabled', true);
-		$installer = new Installer(
-			Server::get(AppFetcher::class),
-			Server::get(IClientService::class),
-			Server::get(ITempManager::class),
-			Server::get(LoggerInterface::class),
-			$config,
-			false
-		);
-		$installer->removeApp(self::$appid);
-	}
-
-	protected function getInstaller() {
-		return new Installer(
-			$this->appFetcher,
-			$this->clientService,
-			$this->tempManager,
-			$this->logger,
-			$this->config,
-			false
-		);
-	}
-
-	protected function tearDown(): void {
-		$installer = new Installer(
-			Server::get(AppFetcher::class),
-			Server::get(IClientService::class),
-			Server::get(ITempManager::class),
-			Server::get(LoggerInterface::class),
-			Server::get(IConfig::class),
-			false
-		);
-		$installer->removeApp(self::$appid);
-		Server::get(IConfig::class)->setSystemValue('appstoreenabled', $this->appstore);
-
-		parent::tearDown();
-	}
-
-	public function testInstallApp(): void {
-		// Read the current version of the app to check for bug #2572
-		Server::get(IAppManager::class)->getAppVersion('testapp', true);
-
-		// Build installer
-		$installer = new Installer(
-			Server::get(AppFetcher::class),
-			Server::get(IClientService::class),
-			Server::get(ITempManager::class),
-			Server::get(LoggerInterface::class),
-			Server::get(IConfig::class),
-			false
-		);
-
-		// Extract app
-		$pathOfTestApp = __DIR__ . '/../data/testapp.zip';
-		$tar = new ZIP($pathOfTestApp);
-		$tar->extract($installer->getInstallPath());
-
-		// Install app
-		$this->assertNull(Server::get(IConfig::class)->getAppValue('testapp', 'enabled', null), 'Check that the app is not listed before installation');
-		$this->assertSame('testapp', $installer->installApp(self::$appid));
-		$this->assertSame('no', Server::get(IConfig::class)->getAppValue('testapp', 'enabled', null), 'Check that the app is listed after installation');
-		$this->assertSame('0.9', Server::get(IConfig::class)->getAppValue('testapp', 'installed_version'));
-		$installer->removeApp(self::$appid);
-	}
-
-	public static function updateArrayProvider(): array {
-		return [
-			// Update available
-			[
-				[
-					[
-						'id' => 'files',
-						'releases' => [
-							[
-								'version' => '1111.0'
-							],
-						],
-					],
-				],
-				'1111.0',
-			],
-			// No update available
-			[
-				[
-					[
-						'id' => 'files',
-						'releases' => [
-							[
-								'version' => '1.0'
-							],
-						],
-					],
-				],
-				false,
-			],
-		];
-	}
-
-	/**
-	 * @param array $appArray
-	 * @param string|bool $updateAvailable
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('updateArrayProvider')]
-	public function testIsUpdateAvailable(array $appArray, $updateAvailable): void {
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
-
-		$installer = $this->getInstaller();
-		$this->assertSame($updateAvailable, $installer->isUpdateAvailable('files'));
-		$this->assertSame($updateAvailable, $installer->isUpdateAvailable('files'), 'Cached result should be returned and fetcher should be only called once');
-	}
-
-
-	public function testDownloadAppWithRevokedCertificate(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Certificate "4112" has been revoked');
-
-		$appArray = [
-			[
-				'id' => 'news',
-				'certificate' => '-----BEGIN CERTIFICATE-----
+    private static $appid = 'testapp';
+    private $appstore;
+    /** @var AppFetcher|\PHPUnit\Framework\MockObject\MockObject */
+    private $appFetcher;
+    /** @var IClientService|\PHPUnit\Framework\MockObject\MockObject */
+    private $clientService;
+    /** @var ITempManager|\PHPUnit\Framework\MockObject\MockObject */
+    private $tempManager;
+    /** @var LoggerInterface|\PHPUnit\Framework\MockObject\MockObject */
+    private $logger;
+    /** @var IConfig|\PHPUnit\Framework\MockObject\MockObject */
+    private $config;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->appFetcher = $this->createMock(AppFetcher::class);
+        $this->clientService = $this->createMock(IClientService::class);
+        $this->tempManager = $this->createMock(ITempManager::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->config = $this->createMock(IConfig::class);
+
+        $config = Server::get(IConfig::class);
+        $this->appstore = $config->setSystemValue('appstoreenabled', true);
+        $config->setSystemValue('appstoreenabled', true);
+        $installer = new Installer(
+            Server::get(AppFetcher::class),
+            Server::get(IClientService::class),
+            Server::get(ITempManager::class),
+            Server::get(LoggerInterface::class),
+            $config,
+            false
+        );
+        $installer->removeApp(self::$appid);
+    }
+
+    protected function getInstaller() {
+        return new Installer(
+            $this->appFetcher,
+            $this->clientService,
+            $this->tempManager,
+            $this->logger,
+            $this->config,
+            false
+        );
+    }
+
+    protected function tearDown(): void {
+        $installer = new Installer(
+            Server::get(AppFetcher::class),
+            Server::get(IClientService::class),
+            Server::get(ITempManager::class),
+            Server::get(LoggerInterface::class),
+            Server::get(IConfig::class),
+            false
+        );
+        $installer->removeApp(self::$appid);
+        Server::get(IConfig::class)->setSystemValue('appstoreenabled', $this->appstore);
+
+        parent::tearDown();
+    }
+
+    public function testInstallApp(): void {
+        // Read the current version of the app to check for bug #2572
+        Server::get(IAppManager::class)->getAppVersion('testapp', true);
+
+        // Build installer
+        $installer = new Installer(
+            Server::get(AppFetcher::class),
+            Server::get(IClientService::class),
+            Server::get(ITempManager::class),
+            Server::get(LoggerInterface::class),
+            Server::get(IConfig::class),
+            false
+        );
+
+        // Extract app
+        $pathOfTestApp = __DIR__ . '/../data/testapp.zip';
+        $tar = new ZIP($pathOfTestApp);
+        $tar->extract($installer->getInstallPath());
+
+        // Install app
+        $this->assertNull(Server::get(IConfig::class)->getAppValue('testapp', 'enabled', null), 'Check that the app is not listed before installation');
+        $this->assertSame('testapp', $installer->installApp(self::$appid));
+        $this->assertSame('no', Server::get(IConfig::class)->getAppValue('testapp', 'enabled', null), 'Check that the app is listed after installation');
+        $this->assertSame('0.9', Server::get(IConfig::class)->getAppValue('testapp', 'installed_version'));
+        $installer->removeApp(self::$appid);
+    }
+
+    public static function updateArrayProvider(): array {
+        return [
+            // Update available
+            [
+                [
+                    [
+                        'id' => 'files',
+                        'releases' => [
+                            [
+                                'version' => '1111.0'
+                            ],
+                        ],
+                    ],
+                ],
+                '1111.0',
+            ],
+            // No update available
+            [
+                [
+                    [
+                        'id' => 'files',
+                        'releases' => [
+                            [
+                                'version' => '1.0'
+                            ],
+                        ],
+                    ],
+                ],
+                false,
+            ],
+        ];
+    }
+
+    /**
+     * @param array $appArray
+     * @param string|bool $updateAvailable
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('updateArrayProvider')]
+    public function testIsUpdateAvailable(array $appArray, $updateAvailable): void {
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
+
+        $installer = $this->getInstaller();
+        $this->assertSame($updateAvailable, $installer->isUpdateAvailable('files'));
+        $this->assertSame($updateAvailable, $installer->isUpdateAvailable('files'), 'Cached result should be returned and fetcher should be only called once');
+    }
+
+
+    public function testDownloadAppWithRevokedCertificate(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Certificate "4112" has been revoked');
+
+        $appArray = [
+            [
+                'id' => 'news',
+                'certificate' => '-----BEGIN CERTIFICATE-----
 MIIEAjCCAuoCAhAQMA0GCSqGSIb3DQEBCwUAMHsxCzAJBgNVBAYTAkRFMRswGQYD
 VQQIDBJCYWRlbi1XdWVydHRlbWJlcmcxFzAVBgNVBAoMDk5leHRjbG91ZCBHbWJI
 MTYwNAYDVQQDDC1OZXh0Y2xvdWQgQ29kZSBTaWduaW5nIEludGVybWVkaWF0ZSBB
@@ -196,27 +196,27 @@ 
 tczQMzLtVdTg5z8XMi//6TkAPxRPjYi8Vef/s2mLo7KystTmofxI/HZePSieJ9tj
 gLgK8d8sKL60JMmKHN3boHrsThKBVA==
 -----END CERTIFICATE-----',
-			],
-		];
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
+            ],
+        ];
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
 
 
-		$installer = $this->getInstaller();
-		$installer->downloadApp('news');
-	}
+        $installer = $this->getInstaller();
+        $installer->downloadApp('news');
+    }
 
 
-	public function testDownloadAppWithNotNextcloudCertificate(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('App with id news has a certificate not issued by a trusted Code Signing Authority');
+    public function testDownloadAppWithNotNextcloudCertificate(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('App with id news has a certificate not issued by a trusted Code Signing Authority');
 
-		$appArray = [
-			[
-				'id' => 'news',
-				'certificate' => '-----BEGIN CERTIFICATE-----
+        $appArray = [
+            [
+                'id' => 'news',
+                'certificate' => '-----BEGIN CERTIFICATE-----
 MIID8TCCAdkCAhAAMA0GCSqGSIb3DQEBCwUAMG0xCzAJBgNVBAYTAlVTMQ8wDQYD
 VQQIDAZCb3N0b24xFjAUBgNVBAoMDW93bkNsb3VkIEluYy4xNTAzBgNVBAMMLG93
 bkNsb3VkIENvZGUgU2lnbmluZyBJbnRlcm1lZGlhdGUgQXV0aG9yaXR5MB4XDTE2
@@ -240,26 +240,26 @@ 
 crl5lBlKjXh2GP0+omSO3x1jX4+iQPCW2TWoyKkUdLu/hGHG2w8RrTeme+kATECH
 YSu356M=
 -----END CERTIFICATE-----',
-			],
-		];
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
-
-		$installer = $this->getInstaller();
-		$installer->downloadApp('news');
-	}
-
-
-	public function testDownloadAppWithDifferentCN(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('App with id news has a cert issued to passman');
-
-		$appArray = [
-			[
-				'id' => 'news',
-				'certificate' => '-----BEGIN CERTIFICATE-----
+            ],
+        ];
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
+
+        $installer = $this->getInstaller();
+        $installer->downloadApp('news');
+    }
+
+
+    public function testDownloadAppWithDifferentCN(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('App with id news has a cert issued to passman');
+
+        $appArray = [
+            [
+                'id' => 'news',
+                'certificate' => '-----BEGIN CERTIFICATE-----
 MIIEAjCCAuoCAhDUMA0GCSqGSIb3DQEBCwUAMHsxCzAJBgNVBAYTAkRFMRswGQYD
 VQQIDBJCYWRlbi1XdWVydHRlbWJlcmcxFzAVBgNVBAoMDk5leHRjbG91ZCBHbWJI
 MTYwNAYDVQQDDC1OZXh0Y2xvdWQgQ29kZSBTaWduaW5nIEludGVybWVkaWF0ZSBB
@@ -283,26 +283,26 @@ 
 u/spPSSVhaun5BA1FlphB2TkgnzlCmxJa63nFY045e/Jq+IKMcqqZl/092gbI2EQ
 5EpZaQ1l6H5DBXwrz58a8WTPC2Mu8g==
 -----END CERTIFICATE-----',
-			],
-		];
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
-
-		$installer = $this->getInstaller();
-		$installer->downloadApp('news');
-	}
-
-
-	public function testDownloadAppWithInvalidSignature(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('App with id passman has invalid signature');
-
-		$appArray = [
-			[
-				'id' => 'passman',
-				'certificate' => '-----BEGIN CERTIFICATE-----
+            ],
+        ];
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
+
+        $installer = $this->getInstaller();
+        $installer->downloadApp('news');
+    }
+
+
+    public function testDownloadAppWithInvalidSignature(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('App with id passman has invalid signature');
+
+        $appArray = [
+            [
+                'id' => 'passman',
+                'certificate' => '-----BEGIN CERTIFICATE-----
 MIIEAjCCAuoCAhDUMA0GCSqGSIb3DQEBCwUAMHsxCzAJBgNVBAYTAkRFMRswGQYD
 VQQIDBJCYWRlbi1XdWVydHRlbWJlcmcxFzAVBgNVBAoMDk5leHRjbG91ZCBHbWJI
 MTYwNAYDVQQDDC1OZXh0Y2xvdWQgQ29kZSBTaWduaW5nIEludGVybWVkaWF0ZSBB
@@ -326,51 +326,51 @@ 
 u/spPSSVhaun5BA1FlphB2TkgnzlCmxJa63nFY045e/Jq+IKMcqqZl/092gbI2EQ
 5EpZaQ1l6H5DBXwrz58a8WTPC2Mu8g==
 -----END CERTIFICATE-----',
-				'releases' => [
-					[
-						'download' => 'https://example.com',
-						'signature' => 'MySignature',
-					],
-					[
-						'download' => 'https://nextcloud.com',
-					],
-				],
-			],
-		];
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
-		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp.tar.gz', $realTmpFile);
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFile')
-			->with('.tar.gz')
-			->willReturn($realTmpFile);
-		$client = $this->createMock(IClient::class);
-		$client
-			->expects($this->once())
-			->method('get')
-			->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
-		$this->clientService
-			->expects($this->once())
-			->method('newClient')
-			->willReturn($client);
-
-		$installer = $this->getInstaller();
-		$installer->downloadApp('passman');
-	}
-
-
-	public function testDownloadAppWithMoreThanOneFolderDownloaded(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Extracted app testapp has more than 1 folder');
-
-		$appArray = [
-			[
-				'id' => 'testapp',
-				'certificate' => '-----BEGIN CERTIFICATE-----
+                'releases' => [
+                    [
+                        'download' => 'https://example.com',
+                        'signature' => 'MySignature',
+                    ],
+                    [
+                        'download' => 'https://nextcloud.com',
+                    ],
+                ],
+            ],
+        ];
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
+        $realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
+        copy(__DIR__ . '/../data/testapp.tar.gz', $realTmpFile);
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFile')
+            ->with('.tar.gz')
+            ->willReturn($realTmpFile);
+        $client = $this->createMock(IClient::class);
+        $client
+            ->expects($this->once())
+            ->method('get')
+            ->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
+        $this->clientService
+            ->expects($this->once())
+            ->method('newClient')
+            ->willReturn($client);
+
+        $installer = $this->getInstaller();
+        $installer->downloadApp('passman');
+    }
+
+
+    public function testDownloadAppWithMoreThanOneFolderDownloaded(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Extracted app testapp has more than 1 folder');
+
+        $appArray = [
+            [
+                'id' => 'testapp',
+                'certificate' => '-----BEGIN CERTIFICATE-----
 MIIEAjCCAuoCAhAbMA0GCSqGSIb3DQEBCwUAMHsxCzAJBgNVBAYTAkRFMRswGQYD
 VQQIDBJCYWRlbi1XdWVydHRlbWJlcmcxFzAVBgNVBAoMDk5leHRjbG91ZCBHbWJI
 MTYwNAYDVQQDDC1OZXh0Y2xvdWQgQ29kZSBTaWduaW5nIEludGVybWVkaWF0ZSBB
@@ -394,10 +394,10 @@ 
 Zh8Xg8UMNrOtXc1Wx1Wmjaa4ZE9dY6/KkU2ny2UWyDHKU/9VE8QQ4HN93gxU4+H7
 cUg0V1uAxqUvKytKkMfcyPWsz/AINA==
 -----END CERTIFICATE-----',
-				'releases' => [
-					[
-						'download' => 'https://example.com',
-						'signature' => 'h8H3tUy2dDlwrV/hY/ZxqYqe8Vue+IINluLtAt1HxX2cjz3vdoVHJRINRkMYYcdz
+                'releases' => [
+                    [
+                        'download' => 'https://example.com',
+                        'signature' => 'h8H3tUy2dDlwrV/hY/ZxqYqe8Vue+IINluLtAt1HxX2cjz3vdoVHJRINRkMYYcdz
 VlndvHyKdqJHDAACphR8tVV6EFrPermn7gEgWk7a51LbUM7sAN7RV7ijEooUo+TQ
 jNW9Ch48Wg3jvebMwWNr5t5U4MEXTP5f0YX/kxvkJoUrG3a3spt7ziEuHaq8IPvt
 Jj/JSDFhvRNpom7yNNcI1Ijoq8yC11sg7RJBNfrHdGPHPZVz2SyBiY9OcvgGSpUU
@@ -408,53 +408,53 @@ 
 GqEhdDmOHsxNaeJ08Hlptq5yLv3+0wEdtriVjgAZNVduHG1F1FkhPIrDHaB6pd67
 0AFvO/pZgMSHDRHD+safBgaLb5dBZ895Qvudbq3RQevVnO+YZQYZkpmjoF/+TQ7/
 YwDVP+QmNRzx72jtqAN/Kc3CvQ9nkgYhU65B95aX0xA=',
-					],
-					[
-						'download' => 'https://nextcloud.com',
-					],
-				],
-			],
-		];
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
-		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp1.tar.gz', $realTmpFile);
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFile')
-			->with('.tar.gz')
-			->willReturn($realTmpFile);
-		$realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
-		mkdir($realTmpFolder . '/testfolder');
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFolder')
-			->willReturn($realTmpFolder);
-		$client = $this->createMock(IClient::class);
-		$client
-			->expects($this->once())
-			->method('get')
-			->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
-		$this->clientService
-			->expects($this->once())
-			->method('newClient')
-			->willReturn($client);
-
-		$installer = $this->getInstaller();
-		$installer->downloadApp('testapp');
-	}
-
-
-	public function testDownloadAppWithMismatchingIdentifier(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('App for id testapp has a wrong app ID in info.xml: testapp1');
-
-		$appArray = [
-			[
-				'id' => 'testapp',
-				'certificate' => '-----BEGIN CERTIFICATE-----
+                    ],
+                    [
+                        'download' => 'https://nextcloud.com',
+                    ],
+                ],
+            ],
+        ];
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
+        $realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
+        copy(__DIR__ . '/../data/testapp1.tar.gz', $realTmpFile);
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFile')
+            ->with('.tar.gz')
+            ->willReturn($realTmpFile);
+        $realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
+        mkdir($realTmpFolder . '/testfolder');
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFolder')
+            ->willReturn($realTmpFolder);
+        $client = $this->createMock(IClient::class);
+        $client
+            ->expects($this->once())
+            ->method('get')
+            ->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
+        $this->clientService
+            ->expects($this->once())
+            ->method('newClient')
+            ->willReturn($client);
+
+        $installer = $this->getInstaller();
+        $installer->downloadApp('testapp');
+    }
+
+
+    public function testDownloadAppWithMismatchingIdentifier(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('App for id testapp has a wrong app ID in info.xml: testapp1');
+
+        $appArray = [
+            [
+                'id' => 'testapp',
+                'certificate' => '-----BEGIN CERTIFICATE-----
 MIIEAjCCAuoCAhAbMA0GCSqGSIb3DQEBCwUAMHsxCzAJBgNVBAYTAkRFMRswGQYD
 VQQIDBJCYWRlbi1XdWVydHRlbWJlcmcxFzAVBgNVBAoMDk5leHRjbG91ZCBHbWJI
 MTYwNAYDVQQDDC1OZXh0Y2xvdWQgQ29kZSBTaWduaW5nIEludGVybWVkaWF0ZSBB
@@ -478,10 +478,10 @@ 
 Zh8Xg8UMNrOtXc1Wx1Wmjaa4ZE9dY6/KkU2ny2UWyDHKU/9VE8QQ4HN93gxU4+H7
 cUg0V1uAxqUvKytKkMfcyPWsz/AINA==
 -----END CERTIFICATE-----',
-				'releases' => [
-					[
-						'download' => 'https://example.com',
-						'signature' => 'h8H3tUy2dDlwrV/hY/ZxqYqe8Vue+IINluLtAt1HxX2cjz3vdoVHJRINRkMYYcdz
+                'releases' => [
+                    [
+                        'download' => 'https://example.com',
+                        'signature' => 'h8H3tUy2dDlwrV/hY/ZxqYqe8Vue+IINluLtAt1HxX2cjz3vdoVHJRINRkMYYcdz
 VlndvHyKdqJHDAACphR8tVV6EFrPermn7gEgWk7a51LbUM7sAN7RV7ijEooUo+TQ
 jNW9Ch48Wg3jvebMwWNr5t5U4MEXTP5f0YX/kxvkJoUrG3a3spt7ziEuHaq8IPvt
 Jj/JSDFhvRNpom7yNNcI1Ijoq8yC11sg7RJBNfrHdGPHPZVz2SyBiY9OcvgGSpUU
@@ -492,48 +492,48 @@ 
 GqEhdDmOHsxNaeJ08Hlptq5yLv3+0wEdtriVjgAZNVduHG1F1FkhPIrDHaB6pd67
 0AFvO/pZgMSHDRHD+safBgaLb5dBZ895Qvudbq3RQevVnO+YZQYZkpmjoF/+TQ7/
 YwDVP+QmNRzx72jtqAN/Kc3CvQ9nkgYhU65B95aX0xA=',
-					],
-					[
-						'download' => 'https://nextcloud.com',
-					],
-				],
-			],
-		];
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
-		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp1.tar.gz', $realTmpFile);
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFile')
-			->with('.tar.gz')
-			->willReturn($realTmpFile);
-		$realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFolder')
-			->willReturn($realTmpFolder);
-		$client = $this->createMock(IClient::class);
-		$client
-			->expects($this->once())
-			->method('get')
-			->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
-		$this->clientService
-			->expects($this->once())
-			->method('newClient')
-			->willReturn($client);
-
-		$installer = $this->getInstaller();
-		$installer->downloadApp('testapp');
-	}
-
-	public function testDownloadAppSuccessful(): void {
-		$appArray = [
-			[
-				'id' => 'testapp',
-				'certificate' => '-----BEGIN CERTIFICATE-----
+                    ],
+                    [
+                        'download' => 'https://nextcloud.com',
+                    ],
+                ],
+            ],
+        ];
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
+        $realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
+        copy(__DIR__ . '/../data/testapp1.tar.gz', $realTmpFile);
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFile')
+            ->with('.tar.gz')
+            ->willReturn($realTmpFile);
+        $realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFolder')
+            ->willReturn($realTmpFolder);
+        $client = $this->createMock(IClient::class);
+        $client
+            ->expects($this->once())
+            ->method('get')
+            ->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
+        $this->clientService
+            ->expects($this->once())
+            ->method('newClient')
+            ->willReturn($client);
+
+        $installer = $this->getInstaller();
+        $installer->downloadApp('testapp');
+    }
+
+    public function testDownloadAppSuccessful(): void {
+        $appArray = [
+            [
+                'id' => 'testapp',
+                'certificate' => '-----BEGIN CERTIFICATE-----
 MIIEAjCCAuoCAhAbMA0GCSqGSIb3DQEBCwUAMHsxCzAJBgNVBAYTAkRFMRswGQYD
 VQQIDBJCYWRlbi1XdWVydHRlbWJlcmcxFzAVBgNVBAoMDk5leHRjbG91ZCBHbWJI
 MTYwNAYDVQQDDC1OZXh0Y2xvdWQgQ29kZSBTaWduaW5nIEludGVybWVkaWF0ZSBB
@@ -557,10 +557,10 @@ 
 Zh8Xg8UMNrOtXc1Wx1Wmjaa4ZE9dY6/KkU2ny2UWyDHKU/9VE8QQ4HN93gxU4+H7
 cUg0V1uAxqUvKytKkMfcyPWsz/AINA==
 -----END CERTIFICATE-----',
-				'releases' => [
-					[
-						'download' => 'https://example.com',
-						'signature' => 'O5UWFRnSx4mSdEX83Uh9u7KW+Gl1OWU4uaFg6aYY19zc+lWP4rKCbAUH7Jo1Bohf
+                'releases' => [
+                    [
+                        'download' => 'https://example.com',
+                        'signature' => 'O5UWFRnSx4mSdEX83Uh9u7KW+Gl1OWU4uaFg6aYY19zc+lWP4rKCbAUH7Jo1Bohf
 qxQbhXs4cMqGmoL8dW4zeFUqSJCRk52LA+ciLezjPFv275q+BxEgyWOylLnbhBaz
 +v6lXLaeG0J/ry8wEdg+rwP8FCYPsvKlXSVbFjgubvCR/owKJJf5iL0B93noBwBN
 jfbcxi7Kh16HAKy6f/gVZ6hf/4Uo7iEFMCPEHjidope+ejUpqbd8XhQg5/yh7TQ7
@@ -571,63 +571,63 @@ 
 7yQWrsV7QvAzygAOFsC0TlSNJbmMCljouUk9di4CUZ+xsQ6n6TZtE7gsdljlKjPS
 3Ys+e3V1HUaVzv8SaSmKwjRoQxQxHWLtXpJS2Yq+i+gq7LuC+aStzxAzV/h2plDW
 358picx/PobNDi71Q97+/CAOq+4wDOwhKwls7lwudIs=',
-					],
-					[
-						'download' => 'https://nextcloud.com',
-					],
-				],
-			],
-		];
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
-		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp.tar.gz', $realTmpFile);
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFile')
-			->with('.tar.gz')
-			->willReturn($realTmpFile);
-		$realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFolder')
-			->willReturn($realTmpFolder);
-		$client = $this->createMock(IClient::class);
-		$client
-			->expects($this->once())
-			->method('get')
-			->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
-		$this->clientService
-			->expects($this->once())
-			->method('newClient')
-			->willReturn($client);
-
-		$installer = $this->getInstaller();
-		$installer->downloadApp('testapp');
-
-		$this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
-		$this->assertEquals('0.9', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
-	}
-
-
-	public function testDownloadAppWithDowngrade(): void {
-		// Use previous test to download the application in version 0.9
-		$this->testDownloadAppSuccessful();
-
-		// Reset mocks
-		$this->appFetcher = $this->createMock(AppFetcher::class);
-		$this->clientService = $this->createMock(IClientService::class);
-		$this->tempManager = $this->createMock(ITempManager::class);
-
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('App for id testapp has version 0.9 and tried to update to lower version 0.8');
-
-		$appArray = [
-			[
-				'id' => 'testapp',
-				'certificate' => '-----BEGIN CERTIFICATE-----
+                    ],
+                    [
+                        'download' => 'https://nextcloud.com',
+                    ],
+                ],
+            ],
+        ];
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
+        $realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
+        copy(__DIR__ . '/../data/testapp.tar.gz', $realTmpFile);
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFile')
+            ->with('.tar.gz')
+            ->willReturn($realTmpFile);
+        $realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFolder')
+            ->willReturn($realTmpFolder);
+        $client = $this->createMock(IClient::class);
+        $client
+            ->expects($this->once())
+            ->method('get')
+            ->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
+        $this->clientService
+            ->expects($this->once())
+            ->method('newClient')
+            ->willReturn($client);
+
+        $installer = $this->getInstaller();
+        $installer->downloadApp('testapp');
+
+        $this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
+        $this->assertEquals('0.9', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
+    }
+
+
+    public function testDownloadAppWithDowngrade(): void {
+        // Use previous test to download the application in version 0.9
+        $this->testDownloadAppSuccessful();
+
+        // Reset mocks
+        $this->appFetcher = $this->createMock(AppFetcher::class);
+        $this->clientService = $this->createMock(IClientService::class);
+        $this->tempManager = $this->createMock(ITempManager::class);
+
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('App for id testapp has version 0.9 and tried to update to lower version 0.8');
+
+        $appArray = [
+            [
+                'id' => 'testapp',
+                'certificate' => '-----BEGIN CERTIFICATE-----
 MIIEAjCCAuoCAhAbMA0GCSqGSIb3DQEBCwUAMHsxCzAJBgNVBAYTAkRFMRswGQYD
 VQQIDBJCYWRlbi1XdWVydHRlbWJlcmcxFzAVBgNVBAoMDk5leHRjbG91ZCBHbWJI
 MTYwNAYDVQQDDC1OZXh0Y2xvdWQgQ29kZSBTaWduaW5nIEludGVybWVkaWF0ZSBB
@@ -651,10 +651,10 @@ 
 Zh8Xg8UMNrOtXc1Wx1Wmjaa4ZE9dY6/KkU2ny2UWyDHKU/9VE8QQ4HN93gxU4+H7
 cUg0V1uAxqUvKytKkMfcyPWsz/AINA==
 -----END CERTIFICATE-----',
-				'releases' => [
-					[
-						'download' => 'https://example.com',
-						'signature' => 'KMSao4cKdMIYxeT8Bm4lrmSeIQnk7YzJZh+Vz+4LVSBwF+OMmcujryQuWLXmbPfg
+                'releases' => [
+                    [
+                        'download' => 'https://example.com',
+                        'signature' => 'KMSao4cKdMIYxeT8Bm4lrmSeIQnk7YzJZh+Vz+4LVSBwF+OMmcujryQuWLXmbPfg
 4hGI9zS025469VNjUoCprn01H8NBq3O1cXz+ewG1oxYWMMQFZDkOtUQ+XZ27b91t
 y0l45H6C8j0sTeSrUb/LCjrdm+buUygkhC2RZxCI6tLi4rYWj0MiqDz98XkbB3te
 pW3ZND6mG6Jxn1fnd35paqZ/+URMftoLQ4K+6vJoBVGnug9nk1RpGLouICI0zCrz
@@ -665,44 +665,44 @@ 
 9WfeKJ/mavrSLVa7QqZ4RCcMigmijT1kdqbaEh05IZNrzs6VDcS2EIrbDX8SGXUk
 uDDkPXZEXqNDEjyONfDXVRLiqDa52Gg+I4vW/l/4ZOFgAWdZkqPPuZFaqzZpsJXm
 JXhrdaWDZ8fzpUjugrtC3qslsqL0dzgU37anS3HwrT8=',
-					],
-					[
-						'download' => 'https://nextcloud.com',
-					],
-				],
-			],
-		];
-		$this->appFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn($appArray);
-		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp.0.8.tar.gz', $realTmpFile);
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFile')
-			->with('.tar.gz')
-			->willReturn($realTmpFile);
-		$realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
-		$this->tempManager
-			->expects($this->once())
-			->method('getTemporaryFolder')
-			->willReturn($realTmpFolder);
-		$client = $this->createMock(IClient::class);
-		$client
-			->expects($this->once())
-			->method('get')
-			->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
-		$this->clientService
-			->expects($this->once())
-			->method('newClient')
-			->willReturn($client);
-		$this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
-		$this->assertEquals('0.9', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
-
-		$installer = $this->getInstaller();
-		$installer->downloadApp('testapp');
-		$this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
-		$this->assertEquals('0.8', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
-	}
+                    ],
+                    [
+                        'download' => 'https://nextcloud.com',
+                    ],
+                ],
+            ],
+        ];
+        $this->appFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn($appArray);
+        $realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
+        copy(__DIR__ . '/../data/testapp.0.8.tar.gz', $realTmpFile);
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFile')
+            ->with('.tar.gz')
+            ->willReturn($realTmpFile);
+        $realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
+        $this->tempManager
+            ->expects($this->once())
+            ->method('getTemporaryFolder')
+            ->willReturn($realTmpFolder);
+        $client = $this->createMock(IClient::class);
+        $client
+            ->expects($this->once())
+            ->method('get')
+            ->with('https://example.com', ['sink' => $realTmpFile, 'timeout' => 120]);
+        $this->clientService
+            ->expects($this->once())
+            ->method('newClient')
+            ->willReturn($client);
+        $this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
+        $this->assertEquals('0.9', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
+
+        $installer = $this->getInstaller();
+        $installer->downloadApp('testapp');
+        $this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
+        $this->assertEquals('0.8', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
+    }
 }

Spacing +13 added lines, -13 removed lines

@@ -103,7 +103,7 @@ 
 		);
 
 		// Extract app
-		$pathOfTestApp = __DIR__ . '/../data/testapp.zip';
+		$pathOfTestApp = __DIR__.'/../data/testapp.zip';
 		$tar = new ZIP($pathOfTestApp);
 		$tar->extract($installer->getInstallPath());
 
@@ -342,7 +342,7 @@ 
 			->method('get')
 			->willReturn($appArray);
 		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp.tar.gz', $realTmpFile);
+		copy(__DIR__.'/../data/testapp.tar.gz', $realTmpFile);
 		$this->tempManager
 			->expects($this->once())
 			->method('getTemporaryFile')
@@ -420,14 +420,14 @@ 
 			->method('get')
 			->willReturn($appArray);
 		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp1.tar.gz', $realTmpFile);
+		copy(__DIR__.'/../data/testapp1.tar.gz', $realTmpFile);
 		$this->tempManager
 			->expects($this->once())
 			->method('getTemporaryFile')
 			->with('.tar.gz')
 			->willReturn($realTmpFile);
 		$realTmpFolder = Server::get(ITempManager::class)->getTemporaryFolder();
-		mkdir($realTmpFolder . '/testfolder');
+		mkdir($realTmpFolder.'/testfolder');
 		$this->tempManager
 			->expects($this->once())
 			->method('getTemporaryFolder')
@@ -504,7 +504,7 @@ 
 			->method('get')
 			->willReturn($appArray);
 		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp1.tar.gz', $realTmpFile);
+		copy(__DIR__.'/../data/testapp1.tar.gz', $realTmpFile);
 		$this->tempManager
 			->expects($this->once())
 			->method('getTemporaryFile')
@@ -583,7 +583,7 @@ 
 			->method('get')
 			->willReturn($appArray);
 		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp.tar.gz', $realTmpFile);
+		copy(__DIR__.'/../data/testapp.tar.gz', $realTmpFile);
 		$this->tempManager
 			->expects($this->once())
 			->method('getTemporaryFile')
@@ -607,8 +607,8 @@ 
 		$installer = $this->getInstaller();
 		$installer->downloadApp('testapp');
 
-		$this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
-		$this->assertEquals('0.9', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
+		$this->assertTrue(file_exists(__DIR__.'/../../apps/testapp/appinfo/info.xml'));
+		$this->assertEquals('0.9', \OC_App::getAppVersionByPath(__DIR__.'/../../apps/testapp/'));
 	}
 
 
@@ -677,7 +677,7 @@ 
 			->method('get')
 			->willReturn($appArray);
 		$realTmpFile = Server::get(ITempManager::class)->getTemporaryFile('.tar.gz');
-		copy(__DIR__ . '/../data/testapp.0.8.tar.gz', $realTmpFile);
+		copy(__DIR__.'/../data/testapp.0.8.tar.gz', $realTmpFile);
 		$this->tempManager
 			->expects($this->once())
 			->method('getTemporaryFile')
@@ -697,12 +697,12 @@ 
 			->expects($this->once())
 			->method('newClient')
 			->willReturn($client);
-		$this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
-		$this->assertEquals('0.9', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
+		$this->assertTrue(file_exists(__DIR__.'/../../apps/testapp/appinfo/info.xml'));
+		$this->assertEquals('0.9', \OC_App::getAppVersionByPath(__DIR__.'/../../apps/testapp/'));
 
 		$installer = $this->getInstaller();
 		$installer->downloadApp('testapp');
-		$this->assertTrue(file_exists(__DIR__ . '/../../apps/testapp/appinfo/info.xml'));
-		$this->assertEquals('0.8', \OC_App::getAppVersionByPath(__DIR__ . '/../../apps/testapp/'));
+		$this->assertTrue(file_exists(__DIR__.'/../../apps/testapp/appinfo/info.xml'));
+		$this->assertEquals('0.8', \OC_App::getAppVersionByPath(__DIR__.'/../../apps/testapp/'));
 	}
 }

lib/private/Installer.php

Indentation +629 added lines, -629 removed lines

@@ -34,633 +34,633 @@
  * This class provides the functionality needed to install, update and remove apps
  */
 class Installer {
-	private ?bool $isInstanceReadyForUpdates = null;
-	private ?array $apps = null;
-
-	public function __construct(
-		private AppFetcher $appFetcher,
-		private IClientService $clientService,
-		private ITempManager $tempManager,
-		private LoggerInterface $logger,
-		private IConfig $config,
-		private bool $isCLI,
-	) {
-	}
-
-	/**
-	 * Installs an app that is located in one of the app folders already
-	 *
-	 * @param string $appId App to install
-	 * @param bool $forceEnable
-	 * @throws \Exception
-	 * @return string app ID
-	 */
-	public function installApp(string $appId, bool $forceEnable = false): string {
-		$app = \OC_App::findAppInDirectories($appId);
-		if ($app === false) {
-			throw new \Exception('App not found in any app directory');
-		}
-
-		$basedir = $app['path'] . '/' . $appId;
-
-		if (is_file($basedir . '/appinfo/database.xml')) {
-			throw new \Exception('The appinfo/database.xml file is not longer supported. Used in ' . $appId);
-		}
-
-		$l = \OCP\Util::getL10N('core');
-		$info = \OCP\Server::get(IAppManager::class)->getAppInfoByPath($basedir . '/appinfo/info.xml', $l->getLanguageCode());
-
-		if (!is_array($info)) {
-			throw new \Exception(
-				$l->t('App "%s" cannot be installed because appinfo file cannot be read.',
-					[$appId]
-				)
-			);
-		}
-
-		$ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
-		$ignoreMax = $forceEnable || in_array($appId, $ignoreMaxApps, true);
-
-		$version = implode('.', \OCP\Util::getVersion());
-		if (!\OC_App::isAppCompatible($version, $info, $ignoreMax)) {
-			throw new \Exception(
-				// TODO $l
-				$l->t('App "%s" cannot be installed because it is not compatible with this version of the server.',
-					[$info['name']]
-				)
-			);
-		}
-
-		// check for required dependencies
-		\OC_App::checkAppDependencies($this->config, $l, $info, $ignoreMax);
-		/** @var Coordinator $coordinator */
-		$coordinator = \OC::$server->get(Coordinator::class);
-		$coordinator->runLazyRegistration($appId);
-		\OC_App::registerAutoloading($appId, $basedir);
-
-		$previousVersion = $this->config->getAppValue($info['id'], 'installed_version', false);
-		if ($previousVersion) {
-			OC_App::executeRepairSteps($appId, $info['repair-steps']['pre-migration']);
-		}
-
-		//install the database
-		$ms = new MigrationService($info['id'], \OCP\Server::get(Connection::class));
-		$ms->migrate('latest', !$previousVersion);
-
-		if ($previousVersion) {
-			OC_App::executeRepairSteps($appId, $info['repair-steps']['post-migration']);
-		}
-
-		\OC_App::setupBackgroundJobs($info['background-jobs']);
-
-		//run appinfo/install.php
-		self::includeAppScript($basedir . '/appinfo/install.php');
-
-		OC_App::executeRepairSteps($appId, $info['repair-steps']['install']);
-
-		$config = \OCP\Server::get(IConfig::class);
-		//set the installed version
-		$config->setAppValue($info['id'], 'installed_version', \OCP\Server::get(IAppManager::class)->getAppVersion($info['id'], false));
-		$config->setAppValue($info['id'], 'enabled', 'no');
-
-		//set remote/public handlers
-		foreach ($info['remote'] as $name => $path) {
-			$config->setAppValue('core', 'remote_' . $name, $info['id'] . '/' . $path);
-		}
-		foreach ($info['public'] as $name => $path) {
-			$config->setAppValue('core', 'public_' . $name, $info['id'] . '/' . $path);
-		}
-
-		OC_App::setAppTypes($info['id']);
-
-		return $info['id'];
-	}
-
-	/**
-	 * Updates the specified app from the appstore
-	 *
-	 * @param bool $allowUnstable Allow unstable releases
-	 */
-	public function updateAppstoreApp(string $appId, bool $allowUnstable = false): bool {
-		if ($this->isUpdateAvailable($appId, $allowUnstable)) {
-			try {
-				$this->downloadApp($appId, $allowUnstable);
-			} catch (\Exception $e) {
-				$this->logger->error($e->getMessage(), [
-					'exception' => $e,
-				]);
-				return false;
-			}
-			return OC_App::updateApp($appId);
-		}
-
-		return false;
-	}
-
-	/**
-	 * Split the certificate file in individual certs
-	 *
-	 * @param string $cert
-	 * @return string[]
-	 */
-	private function splitCerts(string $cert): array {
-		preg_match_all('([\-]{3,}[\S\ ]+?[\-]{3,}[\S\s]+?[\-]{3,}[\S\ ]+?[\-]{3,})', $cert, $matches);
-
-		return $matches[0];
-	}
-
-	/**
-	 * Get the path where to install apps
-	 *
-	 * @throws \RuntimeException if an app folder is marked as writable but is missing permissions
-	 */
-	public function getInstallPath(): ?string {
-		foreach (\OC::$APPSROOTS as $dir) {
-			if (isset($dir['writable']) && $dir['writable'] === true) {
-				// Check if there is a writable install folder.
-				if (!is_writable($dir['path'])
-					|| !is_readable($dir['path'])
-				) {
-					throw new \RuntimeException(
-						'Cannot write into "apps" directory. This can usually be fixed by giving the web server write access to the apps directory or disabling the App Store in the config file.'
-					);
-				}
-				return $dir['path'];
-			}
-		}
-		return null;
-	}
-
-	/**
-	 * Downloads an app and puts it into the app directory
-	 *
-	 * @param string $appId
-	 * @param bool [$allowUnstable]
-	 *
-	 * @throws AppNotFoundException If the app is not found on the appstore
-	 * @throws \Exception If the installation was not successful
-	 */
-	public function downloadApp(string $appId, bool $allowUnstable = false): void {
-		$appId = strtolower($appId);
-
-		$installPath = $this->getInstallPath();
-		if ($installPath === null) {
-			throw new \Exception('No application directories are marked as writable.');
-		}
-
-		$apps = $this->appFetcher->get($allowUnstable);
-		foreach ($apps as $app) {
-			if ($app['id'] === $appId) {
-				// Load the certificate
-				$certificate = new X509();
-				$rootCrt = file_get_contents(__DIR__ . '/../../resources/codesigning/root.crt');
-				$rootCrts = $this->splitCerts($rootCrt);
-				foreach ($rootCrts as $rootCrt) {
-					$certificate->loadCA($rootCrt);
-				}
-				$loadedCertificate = $certificate->loadX509($app['certificate']);
-
-				// Verify if the certificate has been revoked
-				$crl = new X509();
-				foreach ($rootCrts as $rootCrt) {
-					$crl->loadCA($rootCrt);
-				}
-				$crl->loadCRL(file_get_contents(__DIR__ . '/../../resources/codesigning/root.crl'));
-				if ($crl->validateSignature() !== true) {
-					throw new \Exception('Could not validate CRL signature');
-				}
-				$csn = $loadedCertificate['tbsCertificate']['serialNumber']->toString();
-				$revoked = $crl->getRevoked($csn);
-				if ($revoked !== false) {
-					throw new \Exception(
-						sprintf(
-							'Certificate "%s" has been revoked',
-							$csn
-						)
-					);
-				}
-
-				// Verify if the certificate has been issued by the Nextcloud Code Authority CA
-				if ($certificate->validateSignature() !== true) {
-					throw new \Exception(
-						sprintf(
-							'App with id %s has a certificate not issued by a trusted Code Signing Authority',
-							$appId
-						)
-					);
-				}
-
-				// Verify if the certificate is issued for the requested app id
-				$certInfo = openssl_x509_parse($app['certificate']);
-				if (!isset($certInfo['subject']['CN'])) {
-					throw new \Exception(
-						sprintf(
-							'App with id %s has a cert with no CN',
-							$appId
-						)
-					);
-				}
-				if ($certInfo['subject']['CN'] !== $appId) {
-					throw new \Exception(
-						sprintf(
-							'App with id %s has a cert issued to %s',
-							$appId,
-							$certInfo['subject']['CN']
-						)
-					);
-				}
-
-				// Download the release
-				$tempFile = $this->tempManager->getTemporaryFile('.tar.gz');
-				if ($tempFile === false) {
-					throw new \RuntimeException('Could not create temporary file for downloading app archive.');
-				}
-
-				$timeout = $this->isCLI ? 0 : 120;
-				$client = $this->clientService->newClient();
-				$client->get($app['releases'][0]['download'], ['sink' => $tempFile, 'timeout' => $timeout]);
-
-				// Check if the signature actually matches the downloaded content
-				$certificate = openssl_get_publickey($app['certificate']);
-				$verified = openssl_verify(file_get_contents($tempFile), base64_decode($app['releases'][0]['signature']), $certificate, OPENSSL_ALGO_SHA512) === 1;
-
-				if ($verified === true) {
-					// Seems to match, let's proceed
-					$extractDir = $this->tempManager->getTemporaryFolder();
-					if ($extractDir === false) {
-						throw new \RuntimeException('Could not create temporary directory for unpacking app.');
-					}
-
-					$archive = new TAR($tempFile);
-					if (!$archive->extract($extractDir)) {
-						$errorMessage = 'Could not extract app ' . $appId;
-
-						$archiveError = $archive->getError();
-						if ($archiveError instanceof \PEAR_Error) {
-							$errorMessage .= ': ' . $archiveError->getMessage();
-						}
-
-						throw new \Exception($errorMessage);
-					}
-					$allFiles = scandir($extractDir);
-					$folders = array_diff($allFiles, ['.', '..']);
-					$folders = array_values($folders);
-
-					if (count($folders) < 1) {
-						throw new \Exception(
-							sprintf(
-								'Extracted app %s has no folders',
-								$appId
-							)
-						);
-					}
-
-					if (count($folders) > 1) {
-						throw new \Exception(
-							sprintf(
-								'Extracted app %s has more than 1 folder',
-								$appId
-							)
-						);
-					}
-
-					// Check if appinfo/info.xml has the same app ID as well
-					$xml = simplexml_load_string(file_get_contents($extractDir . '/' . $folders[0] . '/appinfo/info.xml'));
-
-					if ($xml === false) {
-						throw new \Exception(
-							sprintf(
-								'Failed to load info.xml for app id %s',
-								$appId,
-							)
-						);
-					}
-
-					if ((string)$xml->id !== $appId) {
-						throw new \Exception(
-							sprintf(
-								'App for id %s has a wrong app ID in info.xml: %s',
-								$appId,
-								(string)$xml->id
-							)
-						);
-					}
-
-					// Check if the version is lower than before
-					$currentVersion = \OCP\Server::get(IAppManager::class)->getAppVersion($appId, true);
-					$newVersion = (string)$xml->version;
-					if (version_compare($currentVersion, $newVersion) === 1) {
-						throw new \Exception(
-							sprintf(
-								'App for id %s has version %s and tried to update to lower version %s',
-								$appId,
-								$currentVersion,
-								$newVersion
-							)
-						);
-					}
-
-					$baseDir = $installPath . '/' . $appId;
-					// Remove old app with the ID if existent
-					Files::rmdirr($baseDir);
-					// Move to app folder
-					if (@mkdir($baseDir)) {
-						$extractDir .= '/' . $folders[0];
-					}
-					// otherwise we just copy the outer directory
-					$this->copyRecursive($extractDir, $baseDir);
-					Files::rmdirr($extractDir);
-					if (function_exists('opcache_reset')) {
-						opcache_reset();
-					}
-					return;
-				}
-				// Signature does not match
-				throw new \Exception(
-					sprintf(
-						'App with id %s has invalid signature',
-						$appId
-					)
-				);
-			}
-		}
-
-		throw new AppNotFoundException(
-			sprintf(
-				'Could not download app %s, it was not found on the appstore',
-				$appId
-			)
-		);
-	}
-
-	/**
-	 * Check if an update for the app is available
-	 *
-	 * @param string $appId
-	 * @param bool $allowUnstable
-	 * @return string|false false or the version number of the update
-	 */
-	public function isUpdateAvailable($appId, $allowUnstable = false): string|false {
-		if ($this->isInstanceReadyForUpdates === null) {
-			$installPath = $this->getInstallPath();
-			if ($installPath === null) {
-				$this->isInstanceReadyForUpdates = false;
-			} else {
-				$this->isInstanceReadyForUpdates = true;
-			}
-		}
-
-		if ($this->isInstanceReadyForUpdates === false) {
-			return false;
-		}
-
-		if ($this->isInstalledFromGit($appId) === true) {
-			return false;
-		}
-
-		if ($this->apps === null) {
-			$this->apps = $this->appFetcher->get($allowUnstable);
-		}
-
-		foreach ($this->apps as $app) {
-			if ($app['id'] === $appId) {
-				$currentVersion = \OCP\Server::get(IAppManager::class)->getAppVersion($appId, true);
-
-				if (!isset($app['releases'][0]['version'])) {
-					return false;
-				}
-				$newestVersion = $app['releases'][0]['version'];
-				if ($currentVersion !== '0' && version_compare($newestVersion, $currentVersion, '>')) {
-					return $newestVersion;
-				} else {
-					return false;
-				}
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Check if app has been installed from git
-	 *
-	 * The function will check if the path contains a .git folder
-	 */
-	private function isInstalledFromGit(string $appId): bool {
-		$app = \OC_App::findAppInDirectories($appId);
-		if ($app === false) {
-			return false;
-		}
-		$basedir = $app['path'] . '/' . $appId;
-		return file_exists($basedir . '/.git/');
-	}
-
-	/**
-	 * Check if app is already downloaded
-	 *
-	 * The function will check if the app is already downloaded in the apps repository
-	 */
-	public function isDownloaded(string $name): bool {
-		foreach (\OC::$APPSROOTS as $dir) {
-			$dirToTest = $dir['path'];
-			$dirToTest .= '/';
-			$dirToTest .= $name;
-			$dirToTest .= '/';
-
-			if (is_dir($dirToTest)) {
-				return true;
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Removes an app
-	 *
-	 * This function works as follows
-	 *   -# call uninstall repair steps
-	 *   -# removing the files
-	 *
-	 * The function will not delete preferences, tables and the configuration,
-	 * this has to be done by the function oc_app_uninstall().
-	 */
-	public function removeApp(string $appId): bool {
-		if ($this->isDownloaded($appId)) {
-			if (\OCP\Server::get(IAppManager::class)->isShipped($appId)) {
-				return false;
-			}
-
-			$installPath = $this->getInstallPath();
-			if ($installPath === null) {
-				$this->logger->error('No application directories are marked as writable.', ['app' => 'core']);
-				return false;
-			}
-			$appDir = $installPath . '/' . $appId;
-			Files::rmdirr($appDir);
-			return true;
-		} else {
-			$this->logger->error('can\'t remove app ' . $appId . '. It is not installed.');
-
-			return false;
-		}
-	}
-
-	/**
-	 * Installs the app within the bundle and marks the bundle as installed
-	 *
-	 * @throws \Exception If app could not get installed
-	 */
-	public function installAppBundle(Bundle $bundle): void {
-		$appIds = $bundle->getAppIdentifiers();
-		foreach ($appIds as $appId) {
-			if (!$this->isDownloaded($appId)) {
-				$this->downloadApp($appId);
-			}
-			$this->installApp($appId);
-			$app = new OC_App();
-			$app->enable($appId);
-		}
-		$bundles = json_decode($this->config->getAppValue('core', 'installed.bundles', json_encode([])), true);
-		$bundles[] = $bundle->getIdentifier();
-		$this->config->setAppValue('core', 'installed.bundles', json_encode($bundles));
-	}
-
-	/**
-	 * Installs shipped apps
-	 *
-	 * This function installs all apps found in the 'apps' directory that should be enabled by default;
-	 * @param bool $softErrors When updating we ignore errors and simply log them, better to have a
-	 *                         working ownCloud at the end instead of an aborted update.
-	 * @return array Array of error messages (appid => Exception)
-	 */
-	public static function installShippedApps(bool $softErrors = false, ?IOutput $output = null): array {
-		if ($output instanceof IOutput) {
-			$output->debug('Installing shipped apps');
-		}
-		$appManager = \OCP\Server::get(IAppManager::class);
-		$config = \OCP\Server::get(IConfig::class);
-		$errors = [];
-		foreach (\OC::$APPSROOTS as $app_dir) {
-			if ($dir = opendir($app_dir['path'])) {
-				while (false !== ($filename = readdir($dir))) {
-					if ($filename[0] !== '.' and is_dir($app_dir['path'] . "/$filename")) {
-						if (file_exists($app_dir['path'] . "/$filename/appinfo/info.xml")) {
-							if ($config->getAppValue($filename, 'installed_version', null) === null) {
-								$enabled = $appManager->isDefaultEnabled($filename);
-								if (($enabled || in_array($filename, $appManager->getAlwaysEnabledApps()))
-									  && $config->getAppValue($filename, 'enabled') !== 'no') {
-									if ($softErrors) {
-										try {
-											Installer::installShippedApp($filename, $output);
-										} catch (HintException $e) {
-											if ($e->getPrevious() instanceof TableExistsException) {
-												$errors[$filename] = $e;
-												continue;
-											}
-											throw $e;
-										}
-									} else {
-										Installer::installShippedApp($filename, $output);
-									}
-									$config->setAppValue($filename, 'enabled', 'yes');
-								}
-							}
-						}
-					}
-				}
-				closedir($dir);
-			}
-		}
-
-		return $errors;
-	}
-
-	/**
-	 * install an app already placed in the app folder
-	 */
-	public static function installShippedApp(string $app, ?IOutput $output = null): string|false {
-		if ($output instanceof IOutput) {
-			$output->debug('Installing ' . $app);
-		}
-
-		$appManager = \OCP\Server::get(IAppManager::class);
-		$config = \OCP\Server::get(IConfig::class);
-
-		$appPath = $appManager->getAppPath($app);
-		\OC_App::registerAutoloading($app, $appPath);
-
-		$ms = new MigrationService($app, \OCP\Server::get(Connection::class));
-		if ($output instanceof IOutput) {
-			$ms->setOutput($output);
-		}
-		$previousVersion = $config->getAppValue($app, 'installed_version', false);
-		$ms->migrate('latest', !$previousVersion);
-
-		//run appinfo/install.php
-		self::includeAppScript("$appPath/appinfo/install.php");
-
-		$info = \OCP\Server::get(IAppManager::class)->getAppInfo($app);
-		if (is_null($info)) {
-			return false;
-		}
-		if ($output instanceof IOutput) {
-			$output->debug('Registering tasks of ' . $app);
-		}
-		\OC_App::setupBackgroundJobs($info['background-jobs']);
-
-		OC_App::executeRepairSteps($app, $info['repair-steps']['install']);
-
-		$config->setAppValue($app, 'installed_version', \OCP\Server::get(IAppManager::class)->getAppVersion($app));
-		if (array_key_exists('ocsid', $info)) {
-			$config->setAppValue($app, 'ocsid', $info['ocsid']);
-		}
-
-		//set remote/public handlers
-		foreach ($info['remote'] as $name => $path) {
-			$config->setAppValue('core', 'remote_' . $name, $app . '/' . $path);
-		}
-		foreach ($info['public'] as $name => $path) {
-			$config->setAppValue('core', 'public_' . $name, $app . '/' . $path);
-		}
-
-		OC_App::setAppTypes($info['id']);
-
-		return $info['id'];
-	}
-
-	private static function includeAppScript(string $script): void {
-		if (file_exists($script)) {
-			include $script;
-		}
-	}
-
-	/**
-	 * Recursive copying of local folders.
-	 *
-	 * @param string $src source folder
-	 * @param string $dest target folder
-	 */
-	private function copyRecursive(string $src, string $dest): void {
-		if (!file_exists($src)) {
-			return;
-		}
-
-		if (is_dir($src)) {
-			if (!is_dir($dest)) {
-				mkdir($dest);
-			}
-			$files = scandir($src);
-			foreach ($files as $file) {
-				if ($file != '.' && $file != '..') {
-					$this->copyRecursive("$src/$file", "$dest/$file");
-				}
-			}
-		} else {
-			$validator = Server::get(FilenameValidator::class);
-			if (!$validator->isForbidden($src)) {
-				copy($src, $dest);
-			}
-		}
-	}
+    private ?bool $isInstanceReadyForUpdates = null;
+    private ?array $apps = null;
+
+    public function __construct(
+        private AppFetcher $appFetcher,
+        private IClientService $clientService,
+        private ITempManager $tempManager,
+        private LoggerInterface $logger,
+        private IConfig $config,
+        private bool $isCLI,
+    ) {
+    }
+
+    /**
+     * Installs an app that is located in one of the app folders already
+     *
+     * @param string $appId App to install
+     * @param bool $forceEnable
+     * @throws \Exception
+     * @return string app ID
+     */
+    public function installApp(string $appId, bool $forceEnable = false): string {
+        $app = \OC_App::findAppInDirectories($appId);
+        if ($app === false) {
+            throw new \Exception('App not found in any app directory');
+        }
+
+        $basedir = $app['path'] . '/' . $appId;
+
+        if (is_file($basedir . '/appinfo/database.xml')) {
+            throw new \Exception('The appinfo/database.xml file is not longer supported. Used in ' . $appId);
+        }
+
+        $l = \OCP\Util::getL10N('core');
+        $info = \OCP\Server::get(IAppManager::class)->getAppInfoByPath($basedir . '/appinfo/info.xml', $l->getLanguageCode());
+
+        if (!is_array($info)) {
+            throw new \Exception(
+                $l->t('App "%s" cannot be installed because appinfo file cannot be read.',
+                    [$appId]
+                )
+            );
+        }
+
+        $ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
+        $ignoreMax = $forceEnable || in_array($appId, $ignoreMaxApps, true);
+
+        $version = implode('.', \OCP\Util::getVersion());
+        if (!\OC_App::isAppCompatible($version, $info, $ignoreMax)) {
+            throw new \Exception(
+                // TODO $l
+                $l->t('App "%s" cannot be installed because it is not compatible with this version of the server.',
+                    [$info['name']]
+                )
+            );
+        }
+
+        // check for required dependencies
+        \OC_App::checkAppDependencies($this->config, $l, $info, $ignoreMax);
+        /** @var Coordinator $coordinator */
+        $coordinator = \OC::$server->get(Coordinator::class);
+        $coordinator->runLazyRegistration($appId);
+        \OC_App::registerAutoloading($appId, $basedir);
+
+        $previousVersion = $this->config->getAppValue($info['id'], 'installed_version', false);
+        if ($previousVersion) {
+            OC_App::executeRepairSteps($appId, $info['repair-steps']['pre-migration']);
+        }
+
+        //install the database
+        $ms = new MigrationService($info['id'], \OCP\Server::get(Connection::class));
+        $ms->migrate('latest', !$previousVersion);
+
+        if ($previousVersion) {
+            OC_App::executeRepairSteps($appId, $info['repair-steps']['post-migration']);
+        }
+
+        \OC_App::setupBackgroundJobs($info['background-jobs']);
+
+        //run appinfo/install.php
+        self::includeAppScript($basedir . '/appinfo/install.php');
+
+        OC_App::executeRepairSteps($appId, $info['repair-steps']['install']);
+
+        $config = \OCP\Server::get(IConfig::class);
+        //set the installed version
+        $config->setAppValue($info['id'], 'installed_version', \OCP\Server::get(IAppManager::class)->getAppVersion($info['id'], false));
+        $config->setAppValue($info['id'], 'enabled', 'no');
+
+        //set remote/public handlers
+        foreach ($info['remote'] as $name => $path) {
+            $config->setAppValue('core', 'remote_' . $name, $info['id'] . '/' . $path);
+        }
+        foreach ($info['public'] as $name => $path) {
+            $config->setAppValue('core', 'public_' . $name, $info['id'] . '/' . $path);
+        }
+
+        OC_App::setAppTypes($info['id']);
+
+        return $info['id'];
+    }
+
+    /**
+     * Updates the specified app from the appstore
+     *
+     * @param bool $allowUnstable Allow unstable releases
+     */
+    public function updateAppstoreApp(string $appId, bool $allowUnstable = false): bool {
+        if ($this->isUpdateAvailable($appId, $allowUnstable)) {
+            try {
+                $this->downloadApp($appId, $allowUnstable);
+            } catch (\Exception $e) {
+                $this->logger->error($e->getMessage(), [
+                    'exception' => $e,
+                ]);
+                return false;
+            }
+            return OC_App::updateApp($appId);
+        }
+
+        return false;
+    }
+
+    /**
+     * Split the certificate file in individual certs
+     *
+     * @param string $cert
+     * @return string[]
+     */
+    private function splitCerts(string $cert): array {
+        preg_match_all('([\-]{3,}[\S\ ]+?[\-]{3,}[\S\s]+?[\-]{3,}[\S\ ]+?[\-]{3,})', $cert, $matches);
+
+        return $matches[0];
+    }
+
+    /**
+     * Get the path where to install apps
+     *
+     * @throws \RuntimeException if an app folder is marked as writable but is missing permissions
+     */
+    public function getInstallPath(): ?string {
+        foreach (\OC::$APPSROOTS as $dir) {
+            if (isset($dir['writable']) && $dir['writable'] === true) {
+                // Check if there is a writable install folder.
+                if (!is_writable($dir['path'])
+                    || !is_readable($dir['path'])
+                ) {
+                    throw new \RuntimeException(
+                        'Cannot write into "apps" directory. This can usually be fixed by giving the web server write access to the apps directory or disabling the App Store in the config file.'
+                    );
+                }
+                return $dir['path'];
+            }
+        }
+        return null;
+    }
+
+    /**
+     * Downloads an app and puts it into the app directory
+     *
+     * @param string $appId
+     * @param bool [$allowUnstable]
+     *
+     * @throws AppNotFoundException If the app is not found on the appstore
+     * @throws \Exception If the installation was not successful
+     */
+    public function downloadApp(string $appId, bool $allowUnstable = false): void {
+        $appId = strtolower($appId);
+
+        $installPath = $this->getInstallPath();
+        if ($installPath === null) {
+            throw new \Exception('No application directories are marked as writable.');
+        }
+
+        $apps = $this->appFetcher->get($allowUnstable);
+        foreach ($apps as $app) {
+            if ($app['id'] === $appId) {
+                // Load the certificate
+                $certificate = new X509();
+                $rootCrt = file_get_contents(__DIR__ . '/../../resources/codesigning/root.crt');
+                $rootCrts = $this->splitCerts($rootCrt);
+                foreach ($rootCrts as $rootCrt) {
+                    $certificate->loadCA($rootCrt);
+                }
+                $loadedCertificate = $certificate->loadX509($app['certificate']);
+
+                // Verify if the certificate has been revoked
+                $crl = new X509();
+                foreach ($rootCrts as $rootCrt) {
+                    $crl->loadCA($rootCrt);
+                }
+                $crl->loadCRL(file_get_contents(__DIR__ . '/../../resources/codesigning/root.crl'));
+                if ($crl->validateSignature() !== true) {
+                    throw new \Exception('Could not validate CRL signature');
+                }
+                $csn = $loadedCertificate['tbsCertificate']['serialNumber']->toString();
+                $revoked = $crl->getRevoked($csn);
+                if ($revoked !== false) {
+                    throw new \Exception(
+                        sprintf(
+                            'Certificate "%s" has been revoked',
+                            $csn
+                        )
+                    );
+                }
+
+                // Verify if the certificate has been issued by the Nextcloud Code Authority CA
+                if ($certificate->validateSignature() !== true) {
+                    throw new \Exception(
+                        sprintf(
+                            'App with id %s has a certificate not issued by a trusted Code Signing Authority',
+                            $appId
+                        )
+                    );
+                }
+
+                // Verify if the certificate is issued for the requested app id
+                $certInfo = openssl_x509_parse($app['certificate']);
+                if (!isset($certInfo['subject']['CN'])) {
+                    throw new \Exception(
+                        sprintf(
+                            'App with id %s has a cert with no CN',
+                            $appId
+                        )
+                    );
+                }
+                if ($certInfo['subject']['CN'] !== $appId) {
+                    throw new \Exception(
+                        sprintf(
+                            'App with id %s has a cert issued to %s',
+                            $appId,
+                            $certInfo['subject']['CN']
+                        )
+                    );
+                }
+
+                // Download the release
+                $tempFile = $this->tempManager->getTemporaryFile('.tar.gz');
+                if ($tempFile === false) {
+                    throw new \RuntimeException('Could not create temporary file for downloading app archive.');
+                }
+
+                $timeout = $this->isCLI ? 0 : 120;
+                $client = $this->clientService->newClient();
+                $client->get($app['releases'][0]['download'], ['sink' => $tempFile, 'timeout' => $timeout]);
+
+                // Check if the signature actually matches the downloaded content
+                $certificate = openssl_get_publickey($app['certificate']);
+                $verified = openssl_verify(file_get_contents($tempFile), base64_decode($app['releases'][0]['signature']), $certificate, OPENSSL_ALGO_SHA512) === 1;
+
+                if ($verified === true) {
+                    // Seems to match, let's proceed
+                    $extractDir = $this->tempManager->getTemporaryFolder();
+                    if ($extractDir === false) {
+                        throw new \RuntimeException('Could not create temporary directory for unpacking app.');
+                    }
+
+                    $archive = new TAR($tempFile);
+                    if (!$archive->extract($extractDir)) {
+                        $errorMessage = 'Could not extract app ' . $appId;
+
+                        $archiveError = $archive->getError();
+                        if ($archiveError instanceof \PEAR_Error) {
+                            $errorMessage .= ': ' . $archiveError->getMessage();
+                        }
+
+                        throw new \Exception($errorMessage);
+                    }
+                    $allFiles = scandir($extractDir);
+                    $folders = array_diff($allFiles, ['.', '..']);
+                    $folders = array_values($folders);
+
+                    if (count($folders) < 1) {
+                        throw new \Exception(
+                            sprintf(
+                                'Extracted app %s has no folders',
+                                $appId
+                            )
+                        );
+                    }
+
+                    if (count($folders) > 1) {
+                        throw new \Exception(
+                            sprintf(
+                                'Extracted app %s has more than 1 folder',
+                                $appId
+                            )
+                        );
+                    }
+
+                    // Check if appinfo/info.xml has the same app ID as well
+                    $xml = simplexml_load_string(file_get_contents($extractDir . '/' . $folders[0] . '/appinfo/info.xml'));
+
+                    if ($xml === false) {
+                        throw new \Exception(
+                            sprintf(
+                                'Failed to load info.xml for app id %s',
+                                $appId,
+                            )
+                        );
+                    }
+
+                    if ((string)$xml->id !== $appId) {
+                        throw new \Exception(
+                            sprintf(
+                                'App for id %s has a wrong app ID in info.xml: %s',
+                                $appId,
+                                (string)$xml->id
+                            )
+                        );
+                    }
+
+                    // Check if the version is lower than before
+                    $currentVersion = \OCP\Server::get(IAppManager::class)->getAppVersion($appId, true);
+                    $newVersion = (string)$xml->version;
+                    if (version_compare($currentVersion, $newVersion) === 1) {
+                        throw new \Exception(
+                            sprintf(
+                                'App for id %s has version %s and tried to update to lower version %s',
+                                $appId,
+                                $currentVersion,
+                                $newVersion
+                            )
+                        );
+                    }
+
+                    $baseDir = $installPath . '/' . $appId;
+                    // Remove old app with the ID if existent
+                    Files::rmdirr($baseDir);
+                    // Move to app folder
+                    if (@mkdir($baseDir)) {
+                        $extractDir .= '/' . $folders[0];
+                    }
+                    // otherwise we just copy the outer directory
+                    $this->copyRecursive($extractDir, $baseDir);
+                    Files::rmdirr($extractDir);
+                    if (function_exists('opcache_reset')) {
+                        opcache_reset();
+                    }
+                    return;
+                }
+                // Signature does not match
+                throw new \Exception(
+                    sprintf(
+                        'App with id %s has invalid signature',
+                        $appId
+                    )
+                );
+            }
+        }
+
+        throw new AppNotFoundException(
+            sprintf(
+                'Could not download app %s, it was not found on the appstore',
+                $appId
+            )
+        );
+    }
+
+    /**
+     * Check if an update for the app is available
+     *
+     * @param string $appId
+     * @param bool $allowUnstable
+     * @return string|false false or the version number of the update
+     */
+    public function isUpdateAvailable($appId, $allowUnstable = false): string|false {
+        if ($this->isInstanceReadyForUpdates === null) {
+            $installPath = $this->getInstallPath();
+            if ($installPath === null) {
+                $this->isInstanceReadyForUpdates = false;
+            } else {
+                $this->isInstanceReadyForUpdates = true;
+            }
+        }
+
+        if ($this->isInstanceReadyForUpdates === false) {
+            return false;
+        }
+
+        if ($this->isInstalledFromGit($appId) === true) {
+            return false;
+        }
+
+        if ($this->apps === null) {
+            $this->apps = $this->appFetcher->get($allowUnstable);
+        }
+
+        foreach ($this->apps as $app) {
+            if ($app['id'] === $appId) {
+                $currentVersion = \OCP\Server::get(IAppManager::class)->getAppVersion($appId, true);
+
+                if (!isset($app['releases'][0]['version'])) {
+                    return false;
+                }
+                $newestVersion = $app['releases'][0]['version'];
+                if ($currentVersion !== '0' && version_compare($newestVersion, $currentVersion, '>')) {
+                    return $newestVersion;
+                } else {
+                    return false;
+                }
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Check if app has been installed from git
+     *
+     * The function will check if the path contains a .git folder
+     */
+    private function isInstalledFromGit(string $appId): bool {
+        $app = \OC_App::findAppInDirectories($appId);
+        if ($app === false) {
+            return false;
+        }
+        $basedir = $app['path'] . '/' . $appId;
+        return file_exists($basedir . '/.git/');
+    }
+
+    /**
+     * Check if app is already downloaded
+     *
+     * The function will check if the app is already downloaded in the apps repository
+     */
+    public function isDownloaded(string $name): bool {
+        foreach (\OC::$APPSROOTS as $dir) {
+            $dirToTest = $dir['path'];
+            $dirToTest .= '/';
+            $dirToTest .= $name;
+            $dirToTest .= '/';
+
+            if (is_dir($dirToTest)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Removes an app
+     *
+     * This function works as follows
+     *   -# call uninstall repair steps
+     *   -# removing the files
+     *
+     * The function will not delete preferences, tables and the configuration,
+     * this has to be done by the function oc_app_uninstall().
+     */
+    public function removeApp(string $appId): bool {
+        if ($this->isDownloaded($appId)) {
+            if (\OCP\Server::get(IAppManager::class)->isShipped($appId)) {
+                return false;
+            }
+
+            $installPath = $this->getInstallPath();
+            if ($installPath === null) {
+                $this->logger->error('No application directories are marked as writable.', ['app' => 'core']);
+                return false;
+            }
+            $appDir = $installPath . '/' . $appId;
+            Files::rmdirr($appDir);
+            return true;
+        } else {
+            $this->logger->error('can\'t remove app ' . $appId . '. It is not installed.');
+
+            return false;
+        }
+    }
+
+    /**
+     * Installs the app within the bundle and marks the bundle as installed
+     *
+     * @throws \Exception If app could not get installed
+     */
+    public function installAppBundle(Bundle $bundle): void {
+        $appIds = $bundle->getAppIdentifiers();
+        foreach ($appIds as $appId) {
+            if (!$this->isDownloaded($appId)) {
+                $this->downloadApp($appId);
+            }
+            $this->installApp($appId);
+            $app = new OC_App();
+            $app->enable($appId);
+        }
+        $bundles = json_decode($this->config->getAppValue('core', 'installed.bundles', json_encode([])), true);
+        $bundles[] = $bundle->getIdentifier();
+        $this->config->setAppValue('core', 'installed.bundles', json_encode($bundles));
+    }
+
+    /**
+     * Installs shipped apps
+     *
+     * This function installs all apps found in the 'apps' directory that should be enabled by default;
+     * @param bool $softErrors When updating we ignore errors and simply log them, better to have a
+     *                         working ownCloud at the end instead of an aborted update.
+     * @return array Array of error messages (appid => Exception)
+     */
+    public static function installShippedApps(bool $softErrors = false, ?IOutput $output = null): array {
+        if ($output instanceof IOutput) {
+            $output->debug('Installing shipped apps');
+        }
+        $appManager = \OCP\Server::get(IAppManager::class);
+        $config = \OCP\Server::get(IConfig::class);
+        $errors = [];
+        foreach (\OC::$APPSROOTS as $app_dir) {
+            if ($dir = opendir($app_dir['path'])) {
+                while (false !== ($filename = readdir($dir))) {
+                    if ($filename[0] !== '.' and is_dir($app_dir['path'] . "/$filename")) {
+                        if (file_exists($app_dir['path'] . "/$filename/appinfo/info.xml")) {
+                            if ($config->getAppValue($filename, 'installed_version', null) === null) {
+                                $enabled = $appManager->isDefaultEnabled($filename);
+                                if (($enabled || in_array($filename, $appManager->getAlwaysEnabledApps()))
+                                      && $config->getAppValue($filename, 'enabled') !== 'no') {
+                                    if ($softErrors) {
+                                        try {
+                                            Installer::installShippedApp($filename, $output);
+                                        } catch (HintException $e) {
+                                            if ($e->getPrevious() instanceof TableExistsException) {
+                                                $errors[$filename] = $e;
+                                                continue;
+                                            }
+                                            throw $e;
+                                        }
+                                    } else {
+                                        Installer::installShippedApp($filename, $output);
+                                    }
+                                    $config->setAppValue($filename, 'enabled', 'yes');
+                                }
+                            }
+                        }
+                    }
+                }
+                closedir($dir);
+            }
+        }
+
+        return $errors;
+    }
+
+    /**
+     * install an app already placed in the app folder
+     */
+    public static function installShippedApp(string $app, ?IOutput $output = null): string|false {
+        if ($output instanceof IOutput) {
+            $output->debug('Installing ' . $app);
+        }
+
+        $appManager = \OCP\Server::get(IAppManager::class);
+        $config = \OCP\Server::get(IConfig::class);
+
+        $appPath = $appManager->getAppPath($app);
+        \OC_App::registerAutoloading($app, $appPath);
+
+        $ms = new MigrationService($app, \OCP\Server::get(Connection::class));
+        if ($output instanceof IOutput) {
+            $ms->setOutput($output);
+        }
+        $previousVersion = $config->getAppValue($app, 'installed_version', false);
+        $ms->migrate('latest', !$previousVersion);
+
+        //run appinfo/install.php
+        self::includeAppScript("$appPath/appinfo/install.php");
+
+        $info = \OCP\Server::get(IAppManager::class)->getAppInfo($app);
+        if (is_null($info)) {
+            return false;
+        }
+        if ($output instanceof IOutput) {
+            $output->debug('Registering tasks of ' . $app);
+        }
+        \OC_App::setupBackgroundJobs($info['background-jobs']);
+
+        OC_App::executeRepairSteps($app, $info['repair-steps']['install']);
+
+        $config->setAppValue($app, 'installed_version', \OCP\Server::get(IAppManager::class)->getAppVersion($app));
+        if (array_key_exists('ocsid', $info)) {
+            $config->setAppValue($app, 'ocsid', $info['ocsid']);
+        }
+
+        //set remote/public handlers
+        foreach ($info['remote'] as $name => $path) {
+            $config->setAppValue('core', 'remote_' . $name, $app . '/' . $path);
+        }
+        foreach ($info['public'] as $name => $path) {
+            $config->setAppValue('core', 'public_' . $name, $app . '/' . $path);
+        }
+
+        OC_App::setAppTypes($info['id']);
+
+        return $info['id'];
+    }
+
+    private static function includeAppScript(string $script): void {
+        if (file_exists($script)) {
+            include $script;
+        }
+    }
+
+    /**
+     * Recursive copying of local folders.
+     *
+     * @param string $src source folder
+     * @param string $dest target folder
+     */
+    private function copyRecursive(string $src, string $dest): void {
+        if (!file_exists($src)) {
+            return;
+        }
+
+        if (is_dir($src)) {
+            if (!is_dir($dest)) {
+                mkdir($dest);
+            }
+            $files = scandir($src);
+            foreach ($files as $file) {
+                if ($file != '.' && $file != '..') {
+                    $this->copyRecursive("$src/$file", "$dest/$file");
+                }
+            }
+        } else {
+            $validator = Server::get(FilenameValidator::class);
+            if (!$validator->isForbidden($src)) {
+                copy($src, $dest);
+            }
+        }
+    }
 }

Spacing +29 added lines, -29 removed lines

@@ -61,14 +61,14 @@ 
 			throw new \Exception('App not found in any app directory');
 		}
 
-		$basedir = $app['path'] . '/' . $appId;
+		$basedir = $app['path'].'/'.$appId;
 
-		if (is_file($basedir . '/appinfo/database.xml')) {
-			throw new \Exception('The appinfo/database.xml file is not longer supported. Used in ' . $appId);
+		if (is_file($basedir.'/appinfo/database.xml')) {
+			throw new \Exception('The appinfo/database.xml file is not longer supported. Used in '.$appId);
 		}
 
 		$l = \OCP\Util::getL10N('core');
-		$info = \OCP\Server::get(IAppManager::class)->getAppInfoByPath($basedir . '/appinfo/info.xml', $l->getLanguageCode());
+		$info = \OCP\Server::get(IAppManager::class)->getAppInfoByPath($basedir.'/appinfo/info.xml', $l->getLanguageCode());
 
 		if (!is_array($info)) {
 			throw new \Exception(
@@ -114,7 +114,7 @@ 
 		\OC_App::setupBackgroundJobs($info['background-jobs']);
 
 		//run appinfo/install.php
-		self::includeAppScript($basedir . '/appinfo/install.php');
+		self::includeAppScript($basedir.'/appinfo/install.php');
 
 		OC_App::executeRepairSteps($appId, $info['repair-steps']['install']);
 
@@ -125,10 +125,10 @@ 
 
 		//set remote/public handlers
 		foreach ($info['remote'] as $name => $path) {
-			$config->setAppValue('core', 'remote_' . $name, $info['id'] . '/' . $path);
+			$config->setAppValue('core', 'remote_'.$name, $info['id'].'/'.$path);
 		}
 		foreach ($info['public'] as $name => $path) {
-			$config->setAppValue('core', 'public_' . $name, $info['id'] . '/' . $path);
+			$config->setAppValue('core', 'public_'.$name, $info['id'].'/'.$path);
 		}
 
 		OC_App::setAppTypes($info['id']);
@@ -213,7 +213,7 @@ 
 			if ($app['id'] === $appId) {
 				// Load the certificate
 				$certificate = new X509();
-				$rootCrt = file_get_contents(__DIR__ . '/../../resources/codesigning/root.crt');
+				$rootCrt = file_get_contents(__DIR__.'/../../resources/codesigning/root.crt');
 				$rootCrts = $this->splitCerts($rootCrt);
 				foreach ($rootCrts as $rootCrt) {
 					$certificate->loadCA($rootCrt);
@@ -225,7 +225,7 @@ 
 				foreach ($rootCrts as $rootCrt) {
 					$crl->loadCA($rootCrt);
 				}
-				$crl->loadCRL(file_get_contents(__DIR__ . '/../../resources/codesigning/root.crl'));
+				$crl->loadCRL(file_get_contents(__DIR__.'/../../resources/codesigning/root.crl'));
 				if ($crl->validateSignature() !== true) {
 					throw new \Exception('Could not validate CRL signature');
 				}
@@ -293,11 +293,11 @@ 
 
 					$archive = new TAR($tempFile);
 					if (!$archive->extract($extractDir)) {
-						$errorMessage = 'Could not extract app ' . $appId;
+						$errorMessage = 'Could not extract app '.$appId;
 
 						$archiveError = $archive->getError();
 						if ($archiveError instanceof \PEAR_Error) {
-							$errorMessage .= ': ' . $archiveError->getMessage();
+							$errorMessage .= ': '.$archiveError->getMessage();
 						}
 
 						throw new \Exception($errorMessage);
@@ -325,7 +325,7 @@ 
 					}
 
 					// Check if appinfo/info.xml has the same app ID as well
-					$xml = simplexml_load_string(file_get_contents($extractDir . '/' . $folders[0] . '/appinfo/info.xml'));
+					$xml = simplexml_load_string(file_get_contents($extractDir.'/'.$folders[0].'/appinfo/info.xml'));
 
 					if ($xml === false) {
 						throw new \Exception(
@@ -336,19 +336,19 @@ 
 						);
 					}
 
-					if ((string)$xml->id !== $appId) {
+					if ((string) $xml->id !== $appId) {
 						throw new \Exception(
 							sprintf(
 								'App for id %s has a wrong app ID in info.xml: %s',
 								$appId,
-								(string)$xml->id
+								(string) $xml->id
 							)
 						);
 					}
 
 					// Check if the version is lower than before
 					$currentVersion = \OCP\Server::get(IAppManager::class)->getAppVersion($appId, true);
-					$newVersion = (string)$xml->version;
+					$newVersion = (string) $xml->version;
 					if (version_compare($currentVersion, $newVersion) === 1) {
 						throw new \Exception(
 							sprintf(
@@ -360,12 +360,12 @@ 
 						);
 					}
 
-					$baseDir = $installPath . '/' . $appId;
+					$baseDir = $installPath.'/'.$appId;
 					// Remove old app with the ID if existent
 					Files::rmdirr($baseDir);
 					// Move to app folder
 					if (@mkdir($baseDir)) {
-						$extractDir .= '/' . $folders[0];
+						$extractDir .= '/'.$folders[0];
 					}
 					// otherwise we just copy the outer directory
 					$this->copyRecursive($extractDir, $baseDir);
@@ -400,7 +400,7 @@ 
 	 * @param bool $allowUnstable
 	 * @return string|false false or the version number of the update
 	 */
-	public function isUpdateAvailable($appId, $allowUnstable = false): string|false {
+	public function isUpdateAvailable($appId, $allowUnstable = false): string | false {
 		if ($this->isInstanceReadyForUpdates === null) {
 			$installPath = $this->getInstallPath();
 			if ($installPath === null) {
@@ -451,8 +451,8 @@ 
 		if ($app === false) {
 			return false;
 		}
-		$basedir = $app['path'] . '/' . $appId;
-		return file_exists($basedir . '/.git/');
+		$basedir = $app['path'].'/'.$appId;
+		return file_exists($basedir.'/.git/');
 	}
 
 	/**
@@ -496,11 +496,11 @@ 
 				$this->logger->error('No application directories are marked as writable.', ['app' => 'core']);
 				return false;
 			}
-			$appDir = $installPath . '/' . $appId;
+			$appDir = $installPath.'/'.$appId;
 			Files::rmdirr($appDir);
 			return true;
 		} else {
-			$this->logger->error('can\'t remove app ' . $appId . '. It is not installed.');
+			$this->logger->error('can\'t remove app '.$appId.'. It is not installed.');
 
 			return false;
 		}
@@ -544,8 +544,8 @@ 
 		foreach (\OC::$APPSROOTS as $app_dir) {
 			if ($dir = opendir($app_dir['path'])) {
 				while (false !== ($filename = readdir($dir))) {
-					if ($filename[0] !== '.' and is_dir($app_dir['path'] . "/$filename")) {
-						if (file_exists($app_dir['path'] . "/$filename/appinfo/info.xml")) {
+					if ($filename[0] !== '.' and is_dir($app_dir['path']."/$filename")) {
+						if (file_exists($app_dir['path']."/$filename/appinfo/info.xml")) {
 							if ($config->getAppValue($filename, 'installed_version', null) === null) {
 								$enabled = $appManager->isDefaultEnabled($filename);
 								if (($enabled || in_array($filename, $appManager->getAlwaysEnabledApps()))
@@ -579,9 +579,9 @@ 
 	/**
 	 * install an app already placed in the app folder
 	 */
-	public static function installShippedApp(string $app, ?IOutput $output = null): string|false {
+	public static function installShippedApp(string $app, ?IOutput $output = null): string | false {
 		if ($output instanceof IOutput) {
-			$output->debug('Installing ' . $app);
+			$output->debug('Installing '.$app);
 		}
 
 		$appManager = \OCP\Server::get(IAppManager::class);
@@ -605,7 +605,7 @@ 
 			return false;
 		}
 		if ($output instanceof IOutput) {
-			$output->debug('Registering tasks of ' . $app);
+			$output->debug('Registering tasks of '.$app);
 		}
 		\OC_App::setupBackgroundJobs($info['background-jobs']);
 
@@ -618,10 +618,10 @@ 
 
 		//set remote/public handlers
 		foreach ($info['remote'] as $name => $path) {
-			$config->setAppValue('core', 'remote_' . $name, $app . '/' . $path);
+			$config->setAppValue('core', 'remote_'.$name, $app.'/'.$path);
 		}
 		foreach ($info['public'] as $name => $path) {
-			$config->setAppValue('core', 'public_' . $name, $app . '/' . $path);
+			$config->setAppValue('core', 'public_'.$name, $app.'/'.$path);
 		}
 
 		OC_App::setAppTypes($info['id']);

lib/private/legacy/OC_Util.php

Indentation +822 added lines, -822 removed lines

@@ -22,826 +22,826 @@
  * @deprecated 32.0.0 Use \OCP\Util or any appropriate official API instead
  */
 class OC_Util {
-	public static $styles = [];
-	public static $headers = [];
-
-	/**
-	 * Setup the file system
-	 *
-	 * @param string|null $user
-	 * @return boolean
-	 * @description configure the initial filesystem based on the configuration
-	 * @suppress PhanDeprecatedFunction
-	 * @suppress PhanAccessMethodInternal
-	 */
-	public static function setupFS(?string $user = '') {
-		// If we are not forced to load a specific user we load the one that is logged in
-		if ($user === '') {
-			$userObject = \OC::$server->get(\OCP\IUserSession::class)->getUser();
-		} else {
-			$userObject = \OC::$server->get(\OCP\IUserManager::class)->get($user);
-		}
-
-		/** @var SetupManager $setupManager */
-		$setupManager = \OC::$server->get(SetupManager::class);
-
-		if ($userObject) {
-			$setupManager->setupForUser($userObject);
-		} else {
-			$setupManager->setupRoot();
-		}
-		return true;
-	}
-
-	/**
-	 * Check if a password is required for each public link
-	 *
-	 * @param bool $checkGroupMembership Check group membership exclusion
-	 * @return bool
-	 * @deprecated 32.0.0 use OCP\Share\IManager's shareApiLinkEnforcePassword directly
-	 */
-	public static function isPublicLinkPasswordRequired(bool $checkGroupMembership = true) {
-		/** @var IManager $shareManager */
-		$shareManager = \OC::$server->get(IManager::class);
-		return $shareManager->shareApiLinkEnforcePassword($checkGroupMembership);
-	}
-
-	/**
-	 * check if sharing is disabled for the current user
-	 * @param IConfig $config
-	 * @param IGroupManager $groupManager
-	 * @param IUser|null $user
-	 * @return bool
-	 * @deprecated 32.0.0 use OCP\Share\IManager's sharingDisabledForUser directly
-	 */
-	public static function isSharingDisabledForUser(IConfig $config, IGroupManager $groupManager, $user) {
-		/** @var IManager $shareManager */
-		$shareManager = \OC::$server->get(IManager::class);
-		$userId = $user ? $user->getUID() : null;
-		return $shareManager->sharingDisabledForUser($userId);
-	}
-
-	/**
-	 * check if share API enforces a default expire date
-	 *
-	 * @return bool
-	 * @deprecated 32.0.0 use OCP\Share\IManager's shareApiLinkDefaultExpireDateEnforced directly
-	 */
-	public static function isDefaultExpireDateEnforced() {
-		/** @var IManager $shareManager */
-		$shareManager = \OC::$server->get(IManager::class);
-		return $shareManager->shareApiLinkDefaultExpireDateEnforced();
-	}
-
-	/**
-	 * Get the quota of a user
-	 *
-	 * @param IUser|null $user
-	 * @return int|\OCP\Files\FileInfo::SPACE_UNLIMITED|false|float Quota bytes
-	 * @deprecated 9.0.0 - Use \OCP\IUser::getQuota or \OCP\IUser::getQuotaBytes
-	 */
-	public static function getUserQuota(?IUser $user) {
-		if (is_null($user)) {
-			return \OCP\Files\FileInfo::SPACE_UNLIMITED;
-		}
-		$userQuota = $user->getQuota();
-		if ($userQuota === 'none') {
-			return \OCP\Files\FileInfo::SPACE_UNLIMITED;
-		}
-		return \OCP\Util::computerFileSize($userQuota);
-	}
-
-	/**
-	 * copies the skeleton to the users /files
-	 *
-	 * @param string $userId
-	 * @param \OCP\Files\Folder $userDirectory
-	 * @throws \OCP\Files\NotFoundException
-	 * @throws \OCP\Files\NotPermittedException
-	 * @suppress PhanDeprecatedFunction
-	 */
-	public static function copySkeleton($userId, \OCP\Files\Folder $userDirectory) {
-		/** @var LoggerInterface $logger */
-		$logger = \OC::$server->get(LoggerInterface::class);
-
-		$plainSkeletonDirectory = \OC::$server->getConfig()->getSystemValueString('skeletondirectory', \OC::$SERVERROOT . '/core/skeleton');
-		$userLang = \OC::$server->get(IFactory::class)->findLanguage();
-		$skeletonDirectory = str_replace('{lang}', $userLang, $plainSkeletonDirectory);
-
-		if (!file_exists($skeletonDirectory)) {
-			$dialectStart = strpos($userLang, '_');
-			if ($dialectStart !== false) {
-				$skeletonDirectory = str_replace('{lang}', substr($userLang, 0, $dialectStart), $plainSkeletonDirectory);
-			}
-			if ($dialectStart === false || !file_exists($skeletonDirectory)) {
-				$skeletonDirectory = str_replace('{lang}', 'default', $plainSkeletonDirectory);
-			}
-			if (!file_exists($skeletonDirectory)) {
-				$skeletonDirectory = '';
-			}
-		}
-
-		$instanceId = \OC::$server->getConfig()->getSystemValue('instanceid', '');
-
-		if ($instanceId === null) {
-			throw new \RuntimeException('no instance id!');
-		}
-		$appdata = 'appdata_' . $instanceId;
-		if ($userId === $appdata) {
-			throw new \RuntimeException('username is reserved name: ' . $appdata);
-		}
-
-		if (!empty($skeletonDirectory)) {
-			$logger->debug('copying skeleton for ' . $userId . ' from ' . $skeletonDirectory . ' to ' . $userDirectory->getFullPath('/'), ['app' => 'files_skeleton']);
-			self::copyr($skeletonDirectory, $userDirectory);
-			// update the file cache
-			$userDirectory->getStorage()->getScanner()->scan('', \OC\Files\Cache\Scanner::SCAN_RECURSIVE);
-
-			/** @var ITemplateManager $templateManager */
-			$templateManager = \OC::$server->get(ITemplateManager::class);
-			$templateManager->initializeTemplateDirectory(null, $userId);
-		}
-	}
-
-	/**
-	 * copies a directory recursively by using streams
-	 *
-	 * @param string $source
-	 * @param \OCP\Files\Folder $target
-	 * @return void
-	 */
-	public static function copyr($source, \OCP\Files\Folder $target) {
-		$logger = \OCP\Server::get(LoggerInterface::class);
-
-		// Verify if folder exists
-		$dir = opendir($source);
-		if ($dir === false) {
-			$logger->error(sprintf('Could not opendir "%s"', $source), ['app' => 'core']);
-			return;
-		}
-
-		// Copy the files
-		while (false !== ($file = readdir($dir))) {
-			if (!\OC\Files\Filesystem::isIgnoredDir($file)) {
-				if (is_dir($source . '/' . $file)) {
-					$child = $target->newFolder($file);
-					self::copyr($source . '/' . $file, $child);
-				} else {
-					$sourceStream = fopen($source . '/' . $file, 'r');
-					if ($sourceStream === false) {
-						$logger->error(sprintf('Could not fopen "%s"', $source . '/' . $file), ['app' => 'core']);
-						closedir($dir);
-						return;
-					}
-					$target->newFile($file, $sourceStream);
-				}
-			}
-		}
-		closedir($dir);
-	}
-
-	/**
-	 * @deprecated 32.0.0 Call tearDown directly on SetupManager
-	 */
-	public static function tearDownFS(): void {
-		$setupManager = \OCP\Server::get(SetupManager::class);
-		$setupManager->tearDown();
-	}
-
-	/**
-	 * generates a path for JS/CSS files. If no application is provided it will create the path for core.
-	 *
-	 * @param string $application application to get the files from
-	 * @param string $directory directory within this application (css, js, vendor, etc)
-	 * @param ?string $file the file inside of the above folder
-	 */
-	private static function generatePath($application, $directory, $file): string {
-		if (is_null($file)) {
-			$file = $application;
-			$application = '';
-		}
-		if (!empty($application)) {
-			return "$application/$directory/$file";
-		} else {
-			return "$directory/$file";
-		}
-	}
-
-	/**
-	 * add a css file
-	 *
-	 * @param string $application application id
-	 * @param string|null $file filename
-	 * @param bool $prepend prepend the Style to the beginning of the list
-	 * @deprecated 32.0.0 Use \OCP\Util::addStyle
-	 */
-	public static function addStyle($application, $file = null, $prepend = false): void {
-		$path = OC_Util::generatePath($application, 'css', $file);
-		self::addExternalResource($application, $prepend, $path, 'style');
-	}
-
-	/**
-	 * add a css file from the vendor sub folder
-	 *
-	 * @param string $application application id
-	 * @param string|null $file filename
-	 * @param bool $prepend prepend the Style to the beginning of the list
-	 * @deprecated 32.0.0
-	 */
-	public static function addVendorStyle($application, $file = null, $prepend = false): void {
-		$path = OC_Util::generatePath($application, 'vendor', $file);
-		self::addExternalResource($application, $prepend, $path, 'style');
-	}
-
-	/**
-	 * add an external resource css/js file
-	 *
-	 * @param string $application application id
-	 * @param bool $prepend prepend the file to the beginning of the list
-	 * @param string $path
-	 * @param string $type (script or style)
-	 */
-	private static function addExternalResource($application, $prepend, $path, $type = 'script'): void {
-		if ($type === 'style') {
-			if (!in_array($path, self::$styles)) {
-				if ($prepend === true) {
-					array_unshift(self::$styles, $path);
-				} else {
-					self::$styles[] = $path;
-				}
-			}
-		}
-	}
-
-	/**
-	 * Add a custom element to the header
-	 * If $text is null then the element will be written as empty element.
-	 * So use "" to get a closing tag.
-	 * @param string $tag tag name of the element
-	 * @param array $attributes array of attributes for the element
-	 * @param string $text the text content for the element
-	 * @param bool $prepend prepend the header to the beginning of the list
-	 * @deprecated 32.0.0 Use \OCP\Util::addHeader instead
-	 */
-	public static function addHeader($tag, $attributes, $text = null, $prepend = false): void {
-		$header = [
-			'tag' => $tag,
-			'attributes' => $attributes,
-			'text' => $text
-		];
-		if ($prepend === true) {
-			array_unshift(self::$headers, $header);
-		} else {
-			self::$headers[] = $header;
-		}
-	}
-
-	/**
-	 * check if the current server configuration is suitable for ownCloud
-	 *
-	 * @return array arrays with error messages and hints
-	 */
-	public static function checkServer(\OC\SystemConfig $config) {
-		$l = \OC::$server->getL10N('lib');
-		$errors = [];
-		$CONFIG_DATADIRECTORY = $config->getValue('datadirectory', OC::$SERVERROOT . '/data');
-
-		if (!self::needUpgrade($config) && $config->getValue('installed', false)) {
-			// this check needs to be done every time
-			$errors = self::checkDataDirectoryValidity($CONFIG_DATADIRECTORY);
-		}
-
-		// Assume that if checkServer() succeeded before in this session, then all is fine.
-		if (\OC::$server->getSession()->exists('checkServer_succeeded') && \OC::$server->getSession()->get('checkServer_succeeded')) {
-			return $errors;
-		}
-
-		$webServerRestart = false;
-		$setup = \OCP\Server::get(\OC\Setup::class);
-
-		$urlGenerator = \OC::$server->getURLGenerator();
-
-		$availableDatabases = $setup->getSupportedDatabases();
-		if (empty($availableDatabases)) {
-			$errors[] = [
-				'error' => $l->t('No database drivers (sqlite, mysql, or postgresql) installed.'),
-				'hint' => '' //TODO: sane hint
-			];
-			$webServerRestart = true;
-		}
-
-		// Check if config folder is writable.
-		if (!(bool)$config->getValue('config_is_read_only', false)) {
-			if (!is_writable(OC::$configDir) or !is_readable(OC::$configDir)) {
-				$errors[] = [
-					'error' => $l->t('Cannot write into "config" directory.'),
-					'hint' => $l->t('This can usually be fixed by giving the web server write access to the config directory. See %s',
-						[ $urlGenerator->linkToDocs('admin-dir_permissions') ]) . '. '
-						. $l->t('Or, if you prefer to keep config.php file read only, set the option "config_is_read_only" to true in it. See %s',
-							[ $urlGenerator->linkToDocs('admin-config') ])
-				];
-			}
-		}
-
-		// Create root dir.
-		if ($config->getValue('installed', false)) {
-			if (!is_dir($CONFIG_DATADIRECTORY)) {
-				$success = @mkdir($CONFIG_DATADIRECTORY);
-				if ($success) {
-					$errors = array_merge($errors, self::checkDataDirectoryPermissions($CONFIG_DATADIRECTORY));
-				} else {
-					$errors[] = [
-						'error' => $l->t('Cannot create "data" directory.'),
-						'hint' => $l->t('This can usually be fixed by giving the web server write access to the root directory. See %s',
-							[$urlGenerator->linkToDocs('admin-dir_permissions')])
-					];
-				}
-			} elseif (!is_writable($CONFIG_DATADIRECTORY) or !is_readable($CONFIG_DATADIRECTORY)) {
-				// is_writable doesn't work for NFS mounts, so try to write a file and check if it exists.
-				$testFile = sprintf('%s/%s.tmp', $CONFIG_DATADIRECTORY, uniqid('data_dir_writability_test_'));
-				$handle = fopen($testFile, 'w');
-				if (!$handle || fwrite($handle, 'Test write operation') === false) {
-					$permissionsHint = $l->t('Permissions can usually be fixed by giving the web server write access to the root directory. See %s.',
-						[$urlGenerator->linkToDocs('admin-dir_permissions')]);
-					$errors[] = [
-						'error' => $l->t('Your data directory is not writable.'),
-						'hint' => $permissionsHint
-					];
-				} else {
-					fclose($handle);
-					unlink($testFile);
-				}
-			} else {
-				$errors = array_merge($errors, self::checkDataDirectoryPermissions($CONFIG_DATADIRECTORY));
-			}
-		}
-
-		if (!OC_Util::isSetLocaleWorking()) {
-			$errors[] = [
-				'error' => $l->t('Setting locale to %s failed.',
-					['en_US.UTF-8/fr_FR.UTF-8/es_ES.UTF-8/de_DE.UTF-8/ru_RU.UTF-8/'
-						. 'pt_BR.UTF-8/it_IT.UTF-8/ja_JP.UTF-8/zh_CN.UTF-8']),
-				'hint' => $l->t('Please install one of these locales on your system and restart your web server.')
-			];
-		}
-
-		// Contains the dependencies that should be checked against
-		// classes = class_exists
-		// functions = function_exists
-		// defined = defined
-		// ini = ini_get
-		// If the dependency is not found the missing module name is shown to the EndUser
-		// When adding new checks always verify that they pass on CI as well
-		$dependencies = [
-			'classes' => [
-				'ZipArchive' => 'zip',
-				'DOMDocument' => 'dom',
-				'XMLWriter' => 'XMLWriter',
-				'XMLReader' => 'XMLReader',
-			],
-			'functions' => [
-				'xml_parser_create' => 'libxml',
-				'mb_strcut' => 'mbstring',
-				'ctype_digit' => 'ctype',
-				'json_encode' => 'JSON',
-				'gd_info' => 'GD',
-				'gzencode' => 'zlib',
-				'simplexml_load_string' => 'SimpleXML',
-				'hash' => 'HASH Message Digest Framework',
-				'curl_init' => 'cURL',
-				'openssl_verify' => 'OpenSSL',
-			],
-			'defined' => [
-				'PDO::ATTR_DRIVER_NAME' => 'PDO'
-			],
-			'ini' => [
-				'default_charset' => 'UTF-8',
-			],
-		];
-		$missingDependencies = [];
-		$invalidIniSettings = [];
-
-		$iniWrapper = \OC::$server->get(IniGetWrapper::class);
-		foreach ($dependencies['classes'] as $class => $module) {
-			if (!class_exists($class)) {
-				$missingDependencies[] = $module;
-			}
-		}
-		foreach ($dependencies['functions'] as $function => $module) {
-			if (!function_exists($function)) {
-				$missingDependencies[] = $module;
-			}
-		}
-		foreach ($dependencies['defined'] as $defined => $module) {
-			if (!defined($defined)) {
-				$missingDependencies[] = $module;
-			}
-		}
-		foreach ($dependencies['ini'] as $setting => $expected) {
-			if (strtolower($iniWrapper->getString($setting)) !== strtolower($expected)) {
-				$invalidIniSettings[] = [$setting, $expected];
-			}
-		}
-
-		foreach ($missingDependencies as $missingDependency) {
-			$errors[] = [
-				'error' => $l->t('PHP module %s not installed.', [$missingDependency]),
-				'hint' => $l->t('Please ask your server administrator to install the module.'),
-			];
-			$webServerRestart = true;
-		}
-		foreach ($invalidIniSettings as $setting) {
-			$errors[] = [
-				'error' => $l->t('PHP setting "%s" is not set to "%s".', [$setting[0], var_export($setting[1], true)]),
-				'hint' => $l->t('Adjusting this setting in php.ini will make Nextcloud run again')
-			];
-			$webServerRestart = true;
-		}
-
-		/**
-		 * The mbstring.func_overload check can only be performed if the mbstring
-		 * module is installed as it will return null if the checking setting is
-		 * not available and thus a check on the boolean value fails.
-		 *
-		 * TODO: Should probably be implemented in the above generic dependency
-		 *       check somehow in the long-term.
-		 */
-		if ($iniWrapper->getBool('mbstring.func_overload') !== null
-			&& $iniWrapper->getBool('mbstring.func_overload') === true) {
-			$errors[] = [
-				'error' => $l->t('<code>mbstring.func_overload</code> is set to <code>%s</code> instead of the expected value <code>0</code>.', [$iniWrapper->getString('mbstring.func_overload')]),
-				'hint' => $l->t('To fix this issue set <code>mbstring.func_overload</code> to <code>0</code> in your php.ini.')
-			];
-		}
-
-		if (!self::isAnnotationsWorking()) {
-			$errors[] = [
-				'error' => $l->t('PHP is apparently set up to strip inline doc blocks. This will make several core apps inaccessible.'),
-				'hint' => $l->t('This is probably caused by a cache/accelerator such as Zend OPcache or eAccelerator.')
-			];
-		}
-
-		if (!\OC::$CLI && $webServerRestart) {
-			$errors[] = [
-				'error' => $l->t('PHP modules have been installed, but they are still listed as missing?'),
-				'hint' => $l->t('Please ask your server administrator to restart the web server.')
-			];
-		}
-
-		foreach (['secret', 'instanceid', 'passwordsalt'] as $requiredConfig) {
-			if ($config->getValue($requiredConfig, '') === '' && !\OC::$CLI && $config->getValue('installed', false)) {
-				$errors[] = [
-					'error' => $l->t('The required %s config variable is not configured in the config.php file.', [$requiredConfig]),
-					'hint' => $l->t('Please ask your server administrator to check the Nextcloud configuration.')
-				];
-			}
-		}
-
-		// Cache the result of this function
-		\OC::$server->getSession()->set('checkServer_succeeded', count($errors) == 0);
-
-		return $errors;
-	}
-
-	/**
-	 * Check for correct file permissions of data directory
-	 *
-	 * @param string $dataDirectory
-	 * @return array arrays with error messages and hints
-	 * @internal
-	 */
-	public static function checkDataDirectoryPermissions($dataDirectory) {
-		if (!\OC::$server->getConfig()->getSystemValueBool('check_data_directory_permissions', true)) {
-			return  [];
-		}
-
-		$perms = substr(decoct(@fileperms($dataDirectory)), -3);
-		if (substr($perms, -1) !== '0') {
-			chmod($dataDirectory, 0770);
-			clearstatcache();
-			$perms = substr(decoct(@fileperms($dataDirectory)), -3);
-			if ($perms[2] !== '0') {
-				$l = \OC::$server->getL10N('lib');
-				return [[
-					'error' => $l->t('Your data directory is readable by other people.'),
-					'hint' => $l->t('Please change the permissions to 0770 so that the directory cannot be listed by other people.'),
-				]];
-			}
-		}
-		return [];
-	}
-
-	/**
-	 * Check that the data directory exists and is valid by
-	 * checking the existence of the ".ncdata" file.
-	 *
-	 * @param string $dataDirectory data directory path
-	 * @return array errors found
-	 * @internal
-	 */
-	public static function checkDataDirectoryValidity($dataDirectory) {
-		$l = \OC::$server->getL10N('lib');
-		$errors = [];
-		if ($dataDirectory[0] !== '/') {
-			$errors[] = [
-				'error' => $l->t('Your data directory must be an absolute path.'),
-				'hint' => $l->t('Check the value of "datadirectory" in your configuration.')
-			];
-		}
-
-		if (!file_exists($dataDirectory . '/.ncdata')) {
-			$errors[] = [
-				'error' => $l->t('Your data directory is invalid.'),
-				'hint' => $l->t('Ensure there is a file called "%1$s" in the root of the data directory. It should have the content: "%2$s"', ['.ncdata', '# Nextcloud data directory']),
-			];
-		}
-		return $errors;
-	}
-
-	/**
-	 * Check if the user is logged in, redirects to home if not. With
-	 * redirect URL parameter to the request URI.
-	 *
-	 * @deprecated 32.0.0
-	 */
-	public static function checkLoggedIn(): void {
-		// Check if we are a user
-		if (!\OC::$server->getUserSession()->isLoggedIn()) {
-			header('Location: ' . \OC::$server->getURLGenerator()->linkToRoute(
-				'core.login.showLoginForm',
-				[
-					'redirect_url' => \OC::$server->getRequest()->getRequestUri(),
-				]
-			)
-			);
-			exit();
-		}
-		// Redirect to 2FA challenge selection if 2FA challenge was not solved yet
-		if (\OC::$server->get(TwoFactorAuthManager::class)->needsSecondFactor(\OC::$server->getUserSession()->getUser())) {
-			header('Location: ' . \OC::$server->getURLGenerator()->linkToRoute('core.TwoFactorChallenge.selectChallenge'));
-			exit();
-		}
-	}
-
-	/**
-	 * Check if the user is a admin, redirects to home if not
-	 *
-	 * @deprecated 32.0.0
-	 */
-	public static function checkAdminUser(): void {
-		self::checkLoggedIn();
-		if (!OC_User::isAdminUser(OC_User::getUser())) {
-			header('Location: ' . \OCP\Util::linkToAbsolute('', 'index.php'));
-			exit();
-		}
-	}
-
-	/**
-	 * Returns the URL of the default page
-	 * based on the system configuration and
-	 * the apps visible for the current user
-	 *
-	 * @return string URL
-	 * @deprecated 32.0.0 use IURLGenerator's linkToDefaultPageUrl directly
-	 */
-	public static function getDefaultPageUrl() {
-		/** @var IURLGenerator $urlGenerator */
-		$urlGenerator = \OC::$server->get(IURLGenerator::class);
-		return $urlGenerator->linkToDefaultPageUrl();
-	}
-
-	/**
-	 * Redirect to the user default page
-	 *
-	 * @deprecated 32.0.0
-	 */
-	public static function redirectToDefaultPage(): void {
-		$location = self::getDefaultPageUrl();
-		header('Location: ' . $location);
-		exit();
-	}
-
-	/**
-	 * get an id unique for this instance
-	 *
-	 * @return string
-	 */
-	public static function getInstanceId(): string {
-		$id = \OC::$server->getSystemConfig()->getValue('instanceid', null);
-		if (is_null($id)) {
-			// We need to guarantee at least one letter in instanceid so it can be used as the session_name
-			$id = 'oc' . \OC::$server->get(ISecureRandom::class)->generate(10, \OCP\Security\ISecureRandom::CHAR_LOWER . \OCP\Security\ISecureRandom::CHAR_DIGITS);
-			\OC::$server->getSystemConfig()->setValue('instanceid', $id);
-		}
-		return $id;
-	}
-
-	/**
-	 * Public function to sanitize HTML
-	 *
-	 * This function is used to sanitize HTML and should be applied on any
-	 * string or array of strings before displaying it on a web page.
-	 *
-	 * @param string|string[] $value
-	 * @return ($value is array ? string[] : string)
-	 * @deprecated 32.0.0 use \OCP\Util::sanitizeHTML instead
-	 */
-	public static function sanitizeHTML($value) {
-		if (is_array($value)) {
-			$value = array_map(function ($value) {
-				return self::sanitizeHTML($value);
-			}, $value);
-		} else {
-			// Specify encoding for PHP<5.4
-			$value = htmlspecialchars((string)$value, ENT_QUOTES, 'UTF-8');
-		}
-		return $value;
-	}
-
-	/**
-	 * Public function to encode url parameters
-	 *
-	 * This function is used to encode path to file before output.
-	 * Encoding is done according to RFC 3986 with one exception:
-	 * Character '/' is preserved as is.
-	 *
-	 * @param string $component part of URI to encode
-	 * @return string
-	 * @deprecated 32.0.0 use \OCP\Util::encodePath instead
-	 */
-	public static function encodePath($component) {
-		$encoded = rawurlencode($component);
-		$encoded = str_replace('%2F', '/', $encoded);
-		return $encoded;
-	}
-
-	/**
-	 * Check if current locale is non-UTF8
-	 *
-	 * @return bool
-	 */
-	private static function isNonUTF8Locale() {
-		if (function_exists('escapeshellcmd')) {
-			return escapeshellcmd('§') === '';
-		} elseif (function_exists('escapeshellarg')) {
-			return escapeshellarg('§') === '\'\'';
-		} else {
-			return preg_match('/utf-?8/i', setlocale(LC_CTYPE, 0)) === 0;
-		}
-	}
-
-	/**
-	 * Check if the setlocale call does not work. This can happen if the right
-	 * local packages are not available on the server.
-	 *
-	 * @internal
-	 */
-	public static function isSetLocaleWorking(): bool {
-		if (self::isNonUTF8Locale()) {
-			// Borrowed from \Patchwork\Utf8\Bootup::initLocale
-			setlocale(LC_ALL, 'C.UTF-8', 'C');
-			setlocale(LC_CTYPE, 'en_US.UTF-8', 'fr_FR.UTF-8', 'es_ES.UTF-8', 'de_DE.UTF-8', 'ru_RU.UTF-8', 'pt_BR.UTF-8', 'it_IT.UTF-8', 'ja_JP.UTF-8', 'zh_CN.UTF-8', '0');
-
-			// Check again
-			if (self::isNonUTF8Locale()) {
-				return false;
-			}
-		}
-
-		return true;
-	}
-
-	/**
-	 * Check if it's possible to get the inline annotations
-	 *
-	 * @internal
-	 */
-	public static function isAnnotationsWorking(): bool {
-		if (PHP_VERSION_ID >= 80300) {
-			/** @psalm-suppress UndefinedMethod */
-			$reflection = \ReflectionMethod::createFromMethodName(__METHOD__);
-		} else {
-			$reflection = new \ReflectionMethod(__METHOD__);
-		}
-		$docs = $reflection->getDocComment();
-
-		return (is_string($docs) && strlen($docs) > 50);
-	}
-
-	/**
-	 * Check if the PHP module fileinfo is loaded.
-	 *
-	 * @internal
-	 */
-	public static function fileInfoLoaded(): bool {
-		return function_exists('finfo_open');
-	}
-
-	/**
-	 * clear all levels of output buffering
-	 *
-	 * @return void
-	 */
-	public static function obEnd() {
-		while (ob_get_level()) {
-			ob_end_clean();
-		}
-	}
-
-	/**
-	 * Checks whether the server is running on Mac OS X
-	 *
-	 * @return bool true if running on Mac OS X, false otherwise
-	 */
-	public static function runningOnMac() {
-		return (strtoupper(substr(PHP_OS, 0, 6)) === 'DARWIN');
-	}
-
-	/**
-	 * Handles the case that there may not be a theme, then check if a "default"
-	 * theme exists and take that one
-	 *
-	 * @return string the theme
-	 */
-	public static function getTheme() {
-		$theme = \OC::$server->getSystemConfig()->getValue('theme', '');
-
-		if ($theme === '') {
-			if (is_dir(OC::$SERVERROOT . '/themes/default')) {
-				$theme = 'default';
-			}
-		}
-
-		return $theme;
-	}
-
-	/**
-	 * Normalize a unicode string
-	 *
-	 * @param string $value a not normalized string
-	 * @return string The normalized string or the input if the normalization failed
-	 */
-	public static function normalizeUnicode(string $value): string {
-		if (Normalizer::isNormalized($value)) {
-			return $value;
-		}
-
-		$normalizedValue = Normalizer::normalize($value);
-		if ($normalizedValue === false) {
-			\OCP\Server::get(LoggerInterface::class)->warning('normalizing failed for "' . $value . '"', ['app' => 'core']);
-			return $value;
-		}
-
-		return $normalizedValue;
-	}
-
-	/**
-	 * Check whether the instance needs to perform an upgrade,
-	 * either when the core version is higher or any app requires
-	 * an upgrade.
-	 *
-	 * @param \OC\SystemConfig $config
-	 * @return bool whether the core or any app needs an upgrade
-	 * @throws \OCP\HintException When the upgrade from the given version is not allowed
-	 * @deprecated 32.0.0 Use \OCP\Util::needUpgrade instead
-	 */
-	public static function needUpgrade(\OC\SystemConfig $config) {
-		if ($config->getValue('installed', false)) {
-			$installedVersion = $config->getValue('version', '0.0.0');
-			$currentVersion = implode('.', \OCP\Util::getVersion());
-			$versionDiff = version_compare($currentVersion, $installedVersion);
-			if ($versionDiff > 0) {
-				return true;
-			} elseif ($config->getValue('debug', false) && $versionDiff < 0) {
-				// downgrade with debug
-				$installedMajor = explode('.', $installedVersion);
-				$installedMajor = $installedMajor[0] . '.' . $installedMajor[1];
-				$currentMajor = explode('.', $currentVersion);
-				$currentMajor = $currentMajor[0] . '.' . $currentMajor[1];
-				if ($installedMajor === $currentMajor) {
-					// Same major, allow downgrade for developers
-					return true;
-				} else {
-					// downgrade attempt, throw exception
-					throw new \OCP\HintException('Downgrading is not supported and is likely to cause unpredictable issues (from ' . $installedVersion . ' to ' . $currentVersion . ')');
-				}
-			} elseif ($versionDiff < 0) {
-				// downgrade attempt, throw exception
-				throw new \OCP\HintException('Downgrading is not supported and is likely to cause unpredictable issues (from ' . $installedVersion . ' to ' . $currentVersion . ')');
-			}
-
-			// also check for upgrades for apps (independently from the user)
-			$apps = \OC_App::getEnabledApps(false, true);
-			$shouldUpgrade = false;
-			foreach ($apps as $app) {
-				if (\OC_App::shouldUpgrade($app)) {
-					$shouldUpgrade = true;
-					break;
-				}
-			}
-			return $shouldUpgrade;
-		} else {
-			return false;
-		}
-	}
+    public static $styles = [];
+    public static $headers = [];
+
+    /**
+     * Setup the file system
+     *
+     * @param string|null $user
+     * @return boolean
+     * @description configure the initial filesystem based on the configuration
+     * @suppress PhanDeprecatedFunction
+     * @suppress PhanAccessMethodInternal
+     */
+    public static function setupFS(?string $user = '') {
+        // If we are not forced to load a specific user we load the one that is logged in
+        if ($user === '') {
+            $userObject = \OC::$server->get(\OCP\IUserSession::class)->getUser();
+        } else {
+            $userObject = \OC::$server->get(\OCP\IUserManager::class)->get($user);
+        }
+
+        /** @var SetupManager $setupManager */
+        $setupManager = \OC::$server->get(SetupManager::class);
+
+        if ($userObject) {
+            $setupManager->setupForUser($userObject);
+        } else {
+            $setupManager->setupRoot();
+        }
+        return true;
+    }
+
+    /**
+     * Check if a password is required for each public link
+     *
+     * @param bool $checkGroupMembership Check group membership exclusion
+     * @return bool
+     * @deprecated 32.0.0 use OCP\Share\IManager's shareApiLinkEnforcePassword directly
+     */
+    public static function isPublicLinkPasswordRequired(bool $checkGroupMembership = true) {
+        /** @var IManager $shareManager */
+        $shareManager = \OC::$server->get(IManager::class);
+        return $shareManager->shareApiLinkEnforcePassword($checkGroupMembership);
+    }
+
+    /**
+     * check if sharing is disabled for the current user
+     * @param IConfig $config
+     * @param IGroupManager $groupManager
+     * @param IUser|null $user
+     * @return bool
+     * @deprecated 32.0.0 use OCP\Share\IManager's sharingDisabledForUser directly
+     */
+    public static function isSharingDisabledForUser(IConfig $config, IGroupManager $groupManager, $user) {
+        /** @var IManager $shareManager */
+        $shareManager = \OC::$server->get(IManager::class);
+        $userId = $user ? $user->getUID() : null;
+        return $shareManager->sharingDisabledForUser($userId);
+    }
+
+    /**
+     * check if share API enforces a default expire date
+     *
+     * @return bool
+     * @deprecated 32.0.0 use OCP\Share\IManager's shareApiLinkDefaultExpireDateEnforced directly
+     */
+    public static function isDefaultExpireDateEnforced() {
+        /** @var IManager $shareManager */
+        $shareManager = \OC::$server->get(IManager::class);
+        return $shareManager->shareApiLinkDefaultExpireDateEnforced();
+    }
+
+    /**
+     * Get the quota of a user
+     *
+     * @param IUser|null $user
+     * @return int|\OCP\Files\FileInfo::SPACE_UNLIMITED|false|float Quota bytes
+     * @deprecated 9.0.0 - Use \OCP\IUser::getQuota or \OCP\IUser::getQuotaBytes
+     */
+    public static function getUserQuota(?IUser $user) {
+        if (is_null($user)) {
+            return \OCP\Files\FileInfo::SPACE_UNLIMITED;
+        }
+        $userQuota = $user->getQuota();
+        if ($userQuota === 'none') {
+            return \OCP\Files\FileInfo::SPACE_UNLIMITED;
+        }
+        return \OCP\Util::computerFileSize($userQuota);
+    }
+
+    /**
+     * copies the skeleton to the users /files
+     *
+     * @param string $userId
+     * @param \OCP\Files\Folder $userDirectory
+     * @throws \OCP\Files\NotFoundException
+     * @throws \OCP\Files\NotPermittedException
+     * @suppress PhanDeprecatedFunction
+     */
+    public static function copySkeleton($userId, \OCP\Files\Folder $userDirectory) {
+        /** @var LoggerInterface $logger */
+        $logger = \OC::$server->get(LoggerInterface::class);
+
+        $plainSkeletonDirectory = \OC::$server->getConfig()->getSystemValueString('skeletondirectory', \OC::$SERVERROOT . '/core/skeleton');
+        $userLang = \OC::$server->get(IFactory::class)->findLanguage();
+        $skeletonDirectory = str_replace('{lang}', $userLang, $plainSkeletonDirectory);
+
+        if (!file_exists($skeletonDirectory)) {
+            $dialectStart = strpos($userLang, '_');
+            if ($dialectStart !== false) {
+                $skeletonDirectory = str_replace('{lang}', substr($userLang, 0, $dialectStart), $plainSkeletonDirectory);
+            }
+            if ($dialectStart === false || !file_exists($skeletonDirectory)) {
+                $skeletonDirectory = str_replace('{lang}', 'default', $plainSkeletonDirectory);
+            }
+            if (!file_exists($skeletonDirectory)) {
+                $skeletonDirectory = '';
+            }
+        }
+
+        $instanceId = \OC::$server->getConfig()->getSystemValue('instanceid', '');
+
+        if ($instanceId === null) {
+            throw new \RuntimeException('no instance id!');
+        }
+        $appdata = 'appdata_' . $instanceId;
+        if ($userId === $appdata) {
+            throw new \RuntimeException('username is reserved name: ' . $appdata);
+        }
+
+        if (!empty($skeletonDirectory)) {
+            $logger->debug('copying skeleton for ' . $userId . ' from ' . $skeletonDirectory . ' to ' . $userDirectory->getFullPath('/'), ['app' => 'files_skeleton']);
+            self::copyr($skeletonDirectory, $userDirectory);
+            // update the file cache
+            $userDirectory->getStorage()->getScanner()->scan('', \OC\Files\Cache\Scanner::SCAN_RECURSIVE);
+
+            /** @var ITemplateManager $templateManager */
+            $templateManager = \OC::$server->get(ITemplateManager::class);
+            $templateManager->initializeTemplateDirectory(null, $userId);
+        }
+    }
+
+    /**
+     * copies a directory recursively by using streams
+     *
+     * @param string $source
+     * @param \OCP\Files\Folder $target
+     * @return void
+     */
+    public static function copyr($source, \OCP\Files\Folder $target) {
+        $logger = \OCP\Server::get(LoggerInterface::class);
+
+        // Verify if folder exists
+        $dir = opendir($source);
+        if ($dir === false) {
+            $logger->error(sprintf('Could not opendir "%s"', $source), ['app' => 'core']);
+            return;
+        }
+
+        // Copy the files
+        while (false !== ($file = readdir($dir))) {
+            if (!\OC\Files\Filesystem::isIgnoredDir($file)) {
+                if (is_dir($source . '/' . $file)) {
+                    $child = $target->newFolder($file);
+                    self::copyr($source . '/' . $file, $child);
+                } else {
+                    $sourceStream = fopen($source . '/' . $file, 'r');
+                    if ($sourceStream === false) {
+                        $logger->error(sprintf('Could not fopen "%s"', $source . '/' . $file), ['app' => 'core']);
+                        closedir($dir);
+                        return;
+                    }
+                    $target->newFile($file, $sourceStream);
+                }
+            }
+        }
+        closedir($dir);
+    }
+
+    /**
+     * @deprecated 32.0.0 Call tearDown directly on SetupManager
+     */
+    public static function tearDownFS(): void {
+        $setupManager = \OCP\Server::get(SetupManager::class);
+        $setupManager->tearDown();
+    }
+
+    /**
+     * generates a path for JS/CSS files. If no application is provided it will create the path for core.
+     *
+     * @param string $application application to get the files from
+     * @param string $directory directory within this application (css, js, vendor, etc)
+     * @param ?string $file the file inside of the above folder
+     */
+    private static function generatePath($application, $directory, $file): string {
+        if (is_null($file)) {
+            $file = $application;
+            $application = '';
+        }
+        if (!empty($application)) {
+            return "$application/$directory/$file";
+        } else {
+            return "$directory/$file";
+        }
+    }
+
+    /**
+     * add a css file
+     *
+     * @param string $application application id
+     * @param string|null $file filename
+     * @param bool $prepend prepend the Style to the beginning of the list
+     * @deprecated 32.0.0 Use \OCP\Util::addStyle
+     */
+    public static function addStyle($application, $file = null, $prepend = false): void {
+        $path = OC_Util::generatePath($application, 'css', $file);
+        self::addExternalResource($application, $prepend, $path, 'style');
+    }
+
+    /**
+     * add a css file from the vendor sub folder
+     *
+     * @param string $application application id
+     * @param string|null $file filename
+     * @param bool $prepend prepend the Style to the beginning of the list
+     * @deprecated 32.0.0
+     */
+    public static function addVendorStyle($application, $file = null, $prepend = false): void {
+        $path = OC_Util::generatePath($application, 'vendor', $file);
+        self::addExternalResource($application, $prepend, $path, 'style');
+    }
+
+    /**
+     * add an external resource css/js file
+     *
+     * @param string $application application id
+     * @param bool $prepend prepend the file to the beginning of the list
+     * @param string $path
+     * @param string $type (script or style)
+     */
+    private static function addExternalResource($application, $prepend, $path, $type = 'script'): void {
+        if ($type === 'style') {
+            if (!in_array($path, self::$styles)) {
+                if ($prepend === true) {
+                    array_unshift(self::$styles, $path);
+                } else {
+                    self::$styles[] = $path;
+                }
+            }
+        }
+    }
+
+    /**
+     * Add a custom element to the header
+     * If $text is null then the element will be written as empty element.
+     * So use "" to get a closing tag.
+     * @param string $tag tag name of the element
+     * @param array $attributes array of attributes for the element
+     * @param string $text the text content for the element
+     * @param bool $prepend prepend the header to the beginning of the list
+     * @deprecated 32.0.0 Use \OCP\Util::addHeader instead
+     */
+    public static function addHeader($tag, $attributes, $text = null, $prepend = false): void {
+        $header = [
+            'tag' => $tag,
+            'attributes' => $attributes,
+            'text' => $text
+        ];
+        if ($prepend === true) {
+            array_unshift(self::$headers, $header);
+        } else {
+            self::$headers[] = $header;
+        }
+    }
+
+    /**
+     * check if the current server configuration is suitable for ownCloud
+     *
+     * @return array arrays with error messages and hints
+     */
+    public static function checkServer(\OC\SystemConfig $config) {
+        $l = \OC::$server->getL10N('lib');
+        $errors = [];
+        $CONFIG_DATADIRECTORY = $config->getValue('datadirectory', OC::$SERVERROOT . '/data');
+
+        if (!self::needUpgrade($config) && $config->getValue('installed', false)) {
+            // this check needs to be done every time
+            $errors = self::checkDataDirectoryValidity($CONFIG_DATADIRECTORY);
+        }
+
+        // Assume that if checkServer() succeeded before in this session, then all is fine.
+        if (\OC::$server->getSession()->exists('checkServer_succeeded') && \OC::$server->getSession()->get('checkServer_succeeded')) {
+            return $errors;
+        }
+
+        $webServerRestart = false;
+        $setup = \OCP\Server::get(\OC\Setup::class);
+
+        $urlGenerator = \OC::$server->getURLGenerator();
+
+        $availableDatabases = $setup->getSupportedDatabases();
+        if (empty($availableDatabases)) {
+            $errors[] = [
+                'error' => $l->t('No database drivers (sqlite, mysql, or postgresql) installed.'),
+                'hint' => '' //TODO: sane hint
+            ];
+            $webServerRestart = true;
+        }
+
+        // Check if config folder is writable.
+        if (!(bool)$config->getValue('config_is_read_only', false)) {
+            if (!is_writable(OC::$configDir) or !is_readable(OC::$configDir)) {
+                $errors[] = [
+                    'error' => $l->t('Cannot write into "config" directory.'),
+                    'hint' => $l->t('This can usually be fixed by giving the web server write access to the config directory. See %s',
+                        [ $urlGenerator->linkToDocs('admin-dir_permissions') ]) . '. '
+                        . $l->t('Or, if you prefer to keep config.php file read only, set the option "config_is_read_only" to true in it. See %s',
+                            [ $urlGenerator->linkToDocs('admin-config') ])
+                ];
+            }
+        }
+
+        // Create root dir.
+        if ($config->getValue('installed', false)) {
+            if (!is_dir($CONFIG_DATADIRECTORY)) {
+                $success = @mkdir($CONFIG_DATADIRECTORY);
+                if ($success) {
+                    $errors = array_merge($errors, self::checkDataDirectoryPermissions($CONFIG_DATADIRECTORY));
+                } else {
+                    $errors[] = [
+                        'error' => $l->t('Cannot create "data" directory.'),
+                        'hint' => $l->t('This can usually be fixed by giving the web server write access to the root directory. See %s',
+                            [$urlGenerator->linkToDocs('admin-dir_permissions')])
+                    ];
+                }
+            } elseif (!is_writable($CONFIG_DATADIRECTORY) or !is_readable($CONFIG_DATADIRECTORY)) {
+                // is_writable doesn't work for NFS mounts, so try to write a file and check if it exists.
+                $testFile = sprintf('%s/%s.tmp', $CONFIG_DATADIRECTORY, uniqid('data_dir_writability_test_'));
+                $handle = fopen($testFile, 'w');
+                if (!$handle || fwrite($handle, 'Test write operation') === false) {
+                    $permissionsHint = $l->t('Permissions can usually be fixed by giving the web server write access to the root directory. See %s.',
+                        [$urlGenerator->linkToDocs('admin-dir_permissions')]);
+                    $errors[] = [
+                        'error' => $l->t('Your data directory is not writable.'),
+                        'hint' => $permissionsHint
+                    ];
+                } else {
+                    fclose($handle);
+                    unlink($testFile);
+                }
+            } else {
+                $errors = array_merge($errors, self::checkDataDirectoryPermissions($CONFIG_DATADIRECTORY));
+            }
+        }
+
+        if (!OC_Util::isSetLocaleWorking()) {
+            $errors[] = [
+                'error' => $l->t('Setting locale to %s failed.',
+                    ['en_US.UTF-8/fr_FR.UTF-8/es_ES.UTF-8/de_DE.UTF-8/ru_RU.UTF-8/'
+                        . 'pt_BR.UTF-8/it_IT.UTF-8/ja_JP.UTF-8/zh_CN.UTF-8']),
+                'hint' => $l->t('Please install one of these locales on your system and restart your web server.')
+            ];
+        }
+
+        // Contains the dependencies that should be checked against
+        // classes = class_exists
+        // functions = function_exists
+        // defined = defined
+        // ini = ini_get
+        // If the dependency is not found the missing module name is shown to the EndUser
+        // When adding new checks always verify that they pass on CI as well
+        $dependencies = [
+            'classes' => [
+                'ZipArchive' => 'zip',
+                'DOMDocument' => 'dom',
+                'XMLWriter' => 'XMLWriter',
+                'XMLReader' => 'XMLReader',
+            ],
+            'functions' => [
+                'xml_parser_create' => 'libxml',
+                'mb_strcut' => 'mbstring',
+                'ctype_digit' => 'ctype',
+                'json_encode' => 'JSON',
+                'gd_info' => 'GD',
+                'gzencode' => 'zlib',
+                'simplexml_load_string' => 'SimpleXML',
+                'hash' => 'HASH Message Digest Framework',
+                'curl_init' => 'cURL',
+                'openssl_verify' => 'OpenSSL',
+            ],
+            'defined' => [
+                'PDO::ATTR_DRIVER_NAME' => 'PDO'
+            ],
+            'ini' => [
+                'default_charset' => 'UTF-8',
+            ],
+        ];
+        $missingDependencies = [];
+        $invalidIniSettings = [];
+
+        $iniWrapper = \OC::$server->get(IniGetWrapper::class);
+        foreach ($dependencies['classes'] as $class => $module) {
+            if (!class_exists($class)) {
+                $missingDependencies[] = $module;
+            }
+        }
+        foreach ($dependencies['functions'] as $function => $module) {
+            if (!function_exists($function)) {
+                $missingDependencies[] = $module;
+            }
+        }
+        foreach ($dependencies['defined'] as $defined => $module) {
+            if (!defined($defined)) {
+                $missingDependencies[] = $module;
+            }
+        }
+        foreach ($dependencies['ini'] as $setting => $expected) {
+            if (strtolower($iniWrapper->getString($setting)) !== strtolower($expected)) {
+                $invalidIniSettings[] = [$setting, $expected];
+            }
+        }
+
+        foreach ($missingDependencies as $missingDependency) {
+            $errors[] = [
+                'error' => $l->t('PHP module %s not installed.', [$missingDependency]),
+                'hint' => $l->t('Please ask your server administrator to install the module.'),
+            ];
+            $webServerRestart = true;
+        }
+        foreach ($invalidIniSettings as $setting) {
+            $errors[] = [
+                'error' => $l->t('PHP setting "%s" is not set to "%s".', [$setting[0], var_export($setting[1], true)]),
+                'hint' => $l->t('Adjusting this setting in php.ini will make Nextcloud run again')
+            ];
+            $webServerRestart = true;
+        }
+
+        /**
+         * The mbstring.func_overload check can only be performed if the mbstring
+         * module is installed as it will return null if the checking setting is
+         * not available and thus a check on the boolean value fails.
+         *
+         * TODO: Should probably be implemented in the above generic dependency
+         *       check somehow in the long-term.
+         */
+        if ($iniWrapper->getBool('mbstring.func_overload') !== null
+            && $iniWrapper->getBool('mbstring.func_overload') === true) {
+            $errors[] = [
+                'error' => $l->t('<code>mbstring.func_overload</code> is set to <code>%s</code> instead of the expected value <code>0</code>.', [$iniWrapper->getString('mbstring.func_overload')]),
+                'hint' => $l->t('To fix this issue set <code>mbstring.func_overload</code> to <code>0</code> in your php.ini.')
+            ];
+        }
+
+        if (!self::isAnnotationsWorking()) {
+            $errors[] = [
+                'error' => $l->t('PHP is apparently set up to strip inline doc blocks. This will make several core apps inaccessible.'),
+                'hint' => $l->t('This is probably caused by a cache/accelerator such as Zend OPcache or eAccelerator.')
+            ];
+        }
+
+        if (!\OC::$CLI && $webServerRestart) {
+            $errors[] = [
+                'error' => $l->t('PHP modules have been installed, but they are still listed as missing?'),
+                'hint' => $l->t('Please ask your server administrator to restart the web server.')
+            ];
+        }
+
+        foreach (['secret', 'instanceid', 'passwordsalt'] as $requiredConfig) {
+            if ($config->getValue($requiredConfig, '') === '' && !\OC::$CLI && $config->getValue('installed', false)) {
+                $errors[] = [
+                    'error' => $l->t('The required %s config variable is not configured in the config.php file.', [$requiredConfig]),
+                    'hint' => $l->t('Please ask your server administrator to check the Nextcloud configuration.')
+                ];
+            }
+        }
+
+        // Cache the result of this function
+        \OC::$server->getSession()->set('checkServer_succeeded', count($errors) == 0);
+
+        return $errors;
+    }
+
+    /**
+     * Check for correct file permissions of data directory
+     *
+     * @param string $dataDirectory
+     * @return array arrays with error messages and hints
+     * @internal
+     */
+    public static function checkDataDirectoryPermissions($dataDirectory) {
+        if (!\OC::$server->getConfig()->getSystemValueBool('check_data_directory_permissions', true)) {
+            return  [];
+        }
+
+        $perms = substr(decoct(@fileperms($dataDirectory)), -3);
+        if (substr($perms, -1) !== '0') {
+            chmod($dataDirectory, 0770);
+            clearstatcache();
+            $perms = substr(decoct(@fileperms($dataDirectory)), -3);
+            if ($perms[2] !== '0') {
+                $l = \OC::$server->getL10N('lib');
+                return [[
+                    'error' => $l->t('Your data directory is readable by other people.'),
+                    'hint' => $l->t('Please change the permissions to 0770 so that the directory cannot be listed by other people.'),
+                ]];
+            }
+        }
+        return [];
+    }
+
+    /**
+     * Check that the data directory exists and is valid by
+     * checking the existence of the ".ncdata" file.
+     *
+     * @param string $dataDirectory data directory path
+     * @return array errors found
+     * @internal
+     */
+    public static function checkDataDirectoryValidity($dataDirectory) {
+        $l = \OC::$server->getL10N('lib');
+        $errors = [];
+        if ($dataDirectory[0] !== '/') {
+            $errors[] = [
+                'error' => $l->t('Your data directory must be an absolute path.'),
+                'hint' => $l->t('Check the value of "datadirectory" in your configuration.')
+            ];
+        }
+
+        if (!file_exists($dataDirectory . '/.ncdata')) {
+            $errors[] = [
+                'error' => $l->t('Your data directory is invalid.'),
+                'hint' => $l->t('Ensure there is a file called "%1$s" in the root of the data directory. It should have the content: "%2$s"', ['.ncdata', '# Nextcloud data directory']),
+            ];
+        }
+        return $errors;
+    }
+
+    /**
+     * Check if the user is logged in, redirects to home if not. With
+     * redirect URL parameter to the request URI.
+     *
+     * @deprecated 32.0.0
+     */
+    public static function checkLoggedIn(): void {
+        // Check if we are a user
+        if (!\OC::$server->getUserSession()->isLoggedIn()) {
+            header('Location: ' . \OC::$server->getURLGenerator()->linkToRoute(
+                'core.login.showLoginForm',
+                [
+                    'redirect_url' => \OC::$server->getRequest()->getRequestUri(),
+                ]
+            )
+            );
+            exit();
+        }
+        // Redirect to 2FA challenge selection if 2FA challenge was not solved yet
+        if (\OC::$server->get(TwoFactorAuthManager::class)->needsSecondFactor(\OC::$server->getUserSession()->getUser())) {
+            header('Location: ' . \OC::$server->getURLGenerator()->linkToRoute('core.TwoFactorChallenge.selectChallenge'));
+            exit();
+        }
+    }
+
+    /**
+     * Check if the user is a admin, redirects to home if not
+     *
+     * @deprecated 32.0.0
+     */
+    public static function checkAdminUser(): void {
+        self::checkLoggedIn();
+        if (!OC_User::isAdminUser(OC_User::getUser())) {
+            header('Location: ' . \OCP\Util::linkToAbsolute('', 'index.php'));
+            exit();
+        }
+    }
+
+    /**
+     * Returns the URL of the default page
+     * based on the system configuration and
+     * the apps visible for the current user
+     *
+     * @return string URL
+     * @deprecated 32.0.0 use IURLGenerator's linkToDefaultPageUrl directly
+     */
+    public static function getDefaultPageUrl() {
+        /** @var IURLGenerator $urlGenerator */
+        $urlGenerator = \OC::$server->get(IURLGenerator::class);
+        return $urlGenerator->linkToDefaultPageUrl();
+    }
+
+    /**
+     * Redirect to the user default page
+     *
+     * @deprecated 32.0.0
+     */
+    public static function redirectToDefaultPage(): void {
+        $location = self::getDefaultPageUrl();
+        header('Location: ' . $location);
+        exit();
+    }
+
+    /**
+     * get an id unique for this instance
+     *
+     * @return string
+     */
+    public static function getInstanceId(): string {
+        $id = \OC::$server->getSystemConfig()->getValue('instanceid', null);
+        if (is_null($id)) {
+            // We need to guarantee at least one letter in instanceid so it can be used as the session_name
+            $id = 'oc' . \OC::$server->get(ISecureRandom::class)->generate(10, \OCP\Security\ISecureRandom::CHAR_LOWER . \OCP\Security\ISecureRandom::CHAR_DIGITS);
+            \OC::$server->getSystemConfig()->setValue('instanceid', $id);
+        }
+        return $id;
+    }
+
+    /**
+     * Public function to sanitize HTML
+     *
+     * This function is used to sanitize HTML and should be applied on any
+     * string or array of strings before displaying it on a web page.
+     *
+     * @param string|string[] $value
+     * @return ($value is array ? string[] : string)
+     * @deprecated 32.0.0 use \OCP\Util::sanitizeHTML instead
+     */
+    public static function sanitizeHTML($value) {
+        if (is_array($value)) {
+            $value = array_map(function ($value) {
+                return self::sanitizeHTML($value);
+            }, $value);
+        } else {
+            // Specify encoding for PHP<5.4
+            $value = htmlspecialchars((string)$value, ENT_QUOTES, 'UTF-8');
+        }
+        return $value;
+    }
+
+    /**
+     * Public function to encode url parameters
+     *
+     * This function is used to encode path to file before output.
+     * Encoding is done according to RFC 3986 with one exception:
+     * Character '/' is preserved as is.
+     *
+     * @param string $component part of URI to encode
+     * @return string
+     * @deprecated 32.0.0 use \OCP\Util::encodePath instead
+     */
+    public static function encodePath($component) {
+        $encoded = rawurlencode($component);
+        $encoded = str_replace('%2F', '/', $encoded);
+        return $encoded;
+    }
+
+    /**
+     * Check if current locale is non-UTF8
+     *
+     * @return bool
+     */
+    private static function isNonUTF8Locale() {
+        if (function_exists('escapeshellcmd')) {
+            return escapeshellcmd('§') === '';
+        } elseif (function_exists('escapeshellarg')) {
+            return escapeshellarg('§') === '\'\'';
+        } else {
+            return preg_match('/utf-?8/i', setlocale(LC_CTYPE, 0)) === 0;
+        }
+    }
+
+    /**
+     * Check if the setlocale call does not work. This can happen if the right
+     * local packages are not available on the server.
+     *
+     * @internal
+     */
+    public static function isSetLocaleWorking(): bool {
+        if (self::isNonUTF8Locale()) {
+            // Borrowed from \Patchwork\Utf8\Bootup::initLocale
+            setlocale(LC_ALL, 'C.UTF-8', 'C');
+            setlocale(LC_CTYPE, 'en_US.UTF-8', 'fr_FR.UTF-8', 'es_ES.UTF-8', 'de_DE.UTF-8', 'ru_RU.UTF-8', 'pt_BR.UTF-8', 'it_IT.UTF-8', 'ja_JP.UTF-8', 'zh_CN.UTF-8', '0');
+
+            // Check again
+            if (self::isNonUTF8Locale()) {
+                return false;
+            }
+        }
+
+        return true;
+    }
+
+    /**
+     * Check if it's possible to get the inline annotations
+     *
+     * @internal
+     */
+    public static function isAnnotationsWorking(): bool {
+        if (PHP_VERSION_ID >= 80300) {
+            /** @psalm-suppress UndefinedMethod */
+            $reflection = \ReflectionMethod::createFromMethodName(__METHOD__);
+        } else {
+            $reflection = new \ReflectionMethod(__METHOD__);
+        }
+        $docs = $reflection->getDocComment();
+
+        return (is_string($docs) && strlen($docs) > 50);
+    }
+
+    /**
+     * Check if the PHP module fileinfo is loaded.
+     *
+     * @internal
+     */
+    public static function fileInfoLoaded(): bool {
+        return function_exists('finfo_open');
+    }
+
+    /**
+     * clear all levels of output buffering
+     *
+     * @return void
+     */
+    public static function obEnd() {
+        while (ob_get_level()) {
+            ob_end_clean();
+        }
+    }
+
+    /**
+     * Checks whether the server is running on Mac OS X
+     *
+     * @return bool true if running on Mac OS X, false otherwise
+     */
+    public static function runningOnMac() {
+        return (strtoupper(substr(PHP_OS, 0, 6)) === 'DARWIN');
+    }
+
+    /**
+     * Handles the case that there may not be a theme, then check if a "default"
+     * theme exists and take that one
+     *
+     * @return string the theme
+     */
+    public static function getTheme() {
+        $theme = \OC::$server->getSystemConfig()->getValue('theme', '');
+
+        if ($theme === '') {
+            if (is_dir(OC::$SERVERROOT . '/themes/default')) {
+                $theme = 'default';
+            }
+        }
+
+        return $theme;
+    }
+
+    /**
+     * Normalize a unicode string
+     *
+     * @param string $value a not normalized string
+     * @return string The normalized string or the input if the normalization failed
+     */
+    public static function normalizeUnicode(string $value): string {
+        if (Normalizer::isNormalized($value)) {
+            return $value;
+        }
+
+        $normalizedValue = Normalizer::normalize($value);
+        if ($normalizedValue === false) {
+            \OCP\Server::get(LoggerInterface::class)->warning('normalizing failed for "' . $value . '"', ['app' => 'core']);
+            return $value;
+        }
+
+        return $normalizedValue;
+    }
+
+    /**
+     * Check whether the instance needs to perform an upgrade,
+     * either when the core version is higher or any app requires
+     * an upgrade.
+     *
+     * @param \OC\SystemConfig $config
+     * @return bool whether the core or any app needs an upgrade
+     * @throws \OCP\HintException When the upgrade from the given version is not allowed
+     * @deprecated 32.0.0 Use \OCP\Util::needUpgrade instead
+     */
+    public static function needUpgrade(\OC\SystemConfig $config) {
+        if ($config->getValue('installed', false)) {
+            $installedVersion = $config->getValue('version', '0.0.0');
+            $currentVersion = implode('.', \OCP\Util::getVersion());
+            $versionDiff = version_compare($currentVersion, $installedVersion);
+            if ($versionDiff > 0) {
+                return true;
+            } elseif ($config->getValue('debug', false) && $versionDiff < 0) {
+                // downgrade with debug
+                $installedMajor = explode('.', $installedVersion);
+                $installedMajor = $installedMajor[0] . '.' . $installedMajor[1];
+                $currentMajor = explode('.', $currentVersion);
+                $currentMajor = $currentMajor[0] . '.' . $currentMajor[1];
+                if ($installedMajor === $currentMajor) {
+                    // Same major, allow downgrade for developers
+                    return true;
+                } else {
+                    // downgrade attempt, throw exception
+                    throw new \OCP\HintException('Downgrading is not supported and is likely to cause unpredictable issues (from ' . $installedVersion . ' to ' . $currentVersion . ')');
+                }
+            } elseif ($versionDiff < 0) {
+                // downgrade attempt, throw exception
+                throw new \OCP\HintException('Downgrading is not supported and is likely to cause unpredictable issues (from ' . $installedVersion . ' to ' . $currentVersion . ')');
+            }
+
+            // also check for upgrades for apps (independently from the user)
+            $apps = \OC_App::getEnabledApps(false, true);
+            $shouldUpgrade = false;
+            foreach ($apps as $app) {
+                if (\OC_App::shouldUpgrade($app)) {
+                    $shouldUpgrade = true;
+                    break;
+                }
+            }
+            return $shouldUpgrade;
+        } else {
+            return false;
+        }
+    }
 }

lib/private/legacy/OC_App.php

Indentation +747 added lines, -747 removed lines

@@ -31,751 +31,751 @@
  * upgrading and removing apps.
  */
 class OC_App {
-	private static $altLogin = [];
-	private static $alreadyRegistered = [];
-	public const supportedApp = 300;
-	public const officialApp = 200;
-
-	/**
-	 * clean the appId
-	 *
-	 * @psalm-taint-escape file
-	 * @psalm-taint-escape include
-	 * @psalm-taint-escape html
-	 * @psalm-taint-escape has_quotes
-	 *
-	 * @deprecated 31.0.0 use IAppManager::cleanAppId
-	 */
-	public static function cleanAppId(string $app): string {
-		return str_replace(['<', '>', '"', "'", '\0', '/', '\\', '..'], '', $app);
-	}
-
-	/**
-	 * Check if an app is loaded
-	 *
-	 * @param string $app
-	 * @return bool
-	 * @deprecated 27.0.0 use IAppManager::isAppLoaded
-	 */
-	public static function isAppLoaded(string $app): bool {
-		return \OC::$server->get(IAppManager::class)->isAppLoaded($app);
-	}
-
-	/**
-	 * loads all apps
-	 *
-	 * @param string[] $types
-	 * @return bool
-	 *
-	 * This function walks through the Nextcloud directory and loads all apps
-	 * it can find. A directory contains an app if the file /appinfo/info.xml
-	 * exists.
-	 *
-	 * if $types is set to non-empty array, only apps of those types will be loaded
-	 *
-	 * @deprecated 29.0.0 use IAppManager::loadApps instead
-	 */
-	public static function loadApps(array $types = []): bool {
-		if (!\OC::$server->getSystemConfig()->getValue('installed', false)) {
-			// This should be done before calling this method so that appmanager can be used
-			return false;
-		}
-		return \OC::$server->get(IAppManager::class)->loadApps($types);
-	}
-
-	/**
-	 * load a single app
-	 *
-	 * @param string $app
-	 * @throws Exception
-	 * @deprecated 27.0.0 use IAppManager::loadApp
-	 */
-	public static function loadApp(string $app): void {
-		\OC::$server->get(IAppManager::class)->loadApp($app);
-	}
-
-	/**
-	 * @internal
-	 * @param string $app
-	 * @param string $path
-	 * @param bool $force
-	 */
-	public static function registerAutoloading(string $app, string $path, bool $force = false) {
-		$key = $app . '-' . $path;
-		if (!$force && isset(self::$alreadyRegistered[$key])) {
-			return;
-		}
-
-		self::$alreadyRegistered[$key] = true;
-
-		// Register on PSR-4 composer autoloader
-		$appNamespace = \OC\AppFramework\App::buildAppNamespace($app);
-		\OC::$server->registerNamespace($app, $appNamespace);
-
-		if (file_exists($path . '/composer/autoload.php')) {
-			require_once $path . '/composer/autoload.php';
-		} else {
-			\OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
-		}
-
-		// Register Test namespace only when testing
-		if (defined('PHPUNIT_RUN') || defined('CLI_TEST_RUN')) {
-			\OC::$composerAutoloader->addPsr4($appNamespace . '\\Tests\\', $path . '/tests/', true);
-		}
-	}
-
-	/**
-	 * check if an app is of a specific type
-	 *
-	 * @param string $app
-	 * @param array $types
-	 * @return bool
-	 * @deprecated 27.0.0 use IAppManager::isType
-	 */
-	public static function isType(string $app, array $types): bool {
-		return \OC::$server->get(IAppManager::class)->isType($app, $types);
-	}
-
-	/**
-	 * read app types from info.xml and cache them in the database
-	 */
-	public static function setAppTypes(string $app) {
-		$appManager = \OC::$server->getAppManager();
-		$appData = $appManager->getAppInfo($app);
-		if (!is_array($appData)) {
-			return;
-		}
-
-		if (isset($appData['types'])) {
-			$appTypes = implode(',', $appData['types']);
-		} else {
-			$appTypes = '';
-			$appData['types'] = [];
-		}
-
-		$config = \OC::$server->getConfig();
-		$config->setAppValue($app, 'types', $appTypes);
-
-		if ($appManager->hasProtectedAppType($appData['types'])) {
-			$enabled = $config->getAppValue($app, 'enabled', 'yes');
-			if ($enabled !== 'yes' && $enabled !== 'no') {
-				$config->setAppValue($app, 'enabled', 'yes');
-			}
-		}
-	}
-
-	/**
-	 * Returns apps enabled for the current user.
-	 *
-	 * @param bool $forceRefresh whether to refresh the cache
-	 * @param bool $all whether to return apps for all users, not only the
-	 *                  currently logged in one
-	 * @return list<string>
-	 */
-	public static function getEnabledApps(bool $forceRefresh = false, bool $all = false): array {
-		if (!\OC::$server->getSystemConfig()->getValue('installed', false)) {
-			return [];
-		}
-		// in incognito mode or when logged out, $user will be false,
-		// which is also the case during an upgrade
-		$appManager = \OC::$server->getAppManager();
-		if ($all) {
-			$user = null;
-		} else {
-			$user = \OC::$server->getUserSession()->getUser();
-		}
-
-		if (is_null($user)) {
-			$apps = $appManager->getEnabledApps();
-		} else {
-			$apps = $appManager->getEnabledAppsForUser($user);
-		}
-		$apps = array_filter($apps, function ($app) {
-			return $app !== 'files';//we add this manually
-		});
-		sort($apps);
-		array_unshift($apps, 'files');
-		return $apps;
-	}
-
-	/**
-	 * enables an app
-	 *
-	 * @param string $appId
-	 * @param array $groups (optional) when set, only these groups will have access to the app
-	 * @throws \Exception
-	 * @return void
-	 *
-	 * This function set an app as enabled in appconfig.
-	 */
-	public function enable(string $appId,
-		array $groups = []) {
-		// Check if app is already downloaded
-		/** @var Installer $installer */
-		$installer = Server::get(Installer::class);
-		$isDownloaded = $installer->isDownloaded($appId);
-
-		if (!$isDownloaded) {
-			$installer->downloadApp($appId);
-		}
-
-		$installer->installApp($appId);
-
-		$appManager = \OC::$server->getAppManager();
-		if ($groups !== []) {
-			$groupManager = \OC::$server->getGroupManager();
-			$groupsList = [];
-			foreach ($groups as $group) {
-				$groupItem = $groupManager->get($group);
-				if ($groupItem instanceof \OCP\IGroup) {
-					$groupsList[] = $groupManager->get($group);
-				}
-			}
-			$appManager->enableAppForGroups($appId, $groupsList);
-		} else {
-			$appManager->enableApp($appId);
-		}
-	}
-
-	/**
-	 * Find the apps root for an app id.
-	 *
-	 * If multiple copies are found, the apps root the latest version is returned.
-	 *
-	 * @param string $appId
-	 * @param bool $ignoreCache ignore cache and rebuild it
-	 * @return false|array{path: string, url: string} the apps root shape
-	 */
-	public static function findAppInDirectories(string $appId, bool $ignoreCache = false) {
-		$sanitizedAppId = self::cleanAppId($appId);
-		if ($sanitizedAppId !== $appId) {
-			return false;
-		}
-		static $app_dir = [];
-
-		if (isset($app_dir[$appId]) && !$ignoreCache) {
-			return $app_dir[$appId];
-		}
-
-		$possibleApps = [];
-		foreach (OC::$APPSROOTS as $dir) {
-			if (file_exists($dir['path'] . '/' . $appId)) {
-				$possibleApps[] = $dir;
-			}
-		}
-
-		if (empty($possibleApps)) {
-			return false;
-		} elseif (count($possibleApps) === 1) {
-			$dir = array_shift($possibleApps);
-			$app_dir[$appId] = $dir;
-			return $dir;
-		} else {
-			$versionToLoad = [];
-			foreach ($possibleApps as $possibleApp) {
-				$version = self::getAppVersionByPath($possibleApp['path'] . '/' . $appId);
-				if (empty($versionToLoad) || version_compare($version, $versionToLoad['version'], '>')) {
-					$versionToLoad = [
-						'dir' => $possibleApp,
-						'version' => $version,
-					];
-				}
-			}
-			$app_dir[$appId] = $versionToLoad['dir'];
-			return $versionToLoad['dir'];
-			//TODO - write test
-		}
-	}
-
-	/**
-	 * Get the directory for the given app.
-	 * If the app is defined in multiple directories, the first one is taken. (false if not found)
-	 *
-	 * @psalm-taint-specialize
-	 *
-	 * @param string $appId
-	 * @param bool $refreshAppPath should be set to true only during install/upgrade
-	 * @return string|false
-	 * @deprecated 11.0.0 use Server::get(IAppManager)->getAppPath()
-	 */
-	public static function getAppPath(string $appId, bool $refreshAppPath = false) {
-		$appId = self::cleanAppId($appId);
-		if ($appId === '') {
-			return false;
-		} elseif ($appId === 'core') {
-			return __DIR__ . '/../../../core';
-		}
-
-		if (($dir = self::findAppInDirectories($appId, $refreshAppPath)) != false) {
-			return $dir['path'] . '/' . $appId;
-		}
-		return false;
-	}
-
-	/**
-	 * Get the path for the given app on the access
-	 * If the app is defined in multiple directories, the first one is taken. (false if not found)
-	 *
-	 * @param string $appId
-	 * @return string|false
-	 * @deprecated 18.0.0 use \OC::$server->getAppManager()->getAppWebPath()
-	 */
-	public static function getAppWebPath(string $appId) {
-		if (($dir = self::findAppInDirectories($appId)) != false) {
-			return OC::$WEBROOT . $dir['url'] . '/' . $appId;
-		}
-		return false;
-	}
-
-	/**
-	 * get app's version based on it's path
-	 *
-	 * @param string $path
-	 * @return string
-	 */
-	public static function getAppVersionByPath(string $path): string {
-		$infoFile = $path . '/appinfo/info.xml';
-		$appData = Server::get(IAppManager::class)->getAppInfoByPath($infoFile);
-		return $appData['version'] ?? '';
-	}
-
-	/**
-	 * get the id of loaded app
-	 *
-	 * @return string
-	 */
-	public static function getCurrentApp(): string {
-		if (\OC::$CLI) {
-			return '';
-		}
-
-		$request = \OC::$server->getRequest();
-		$script = substr($request->getScriptName(), strlen(OC::$WEBROOT) + 1);
-		$topFolder = substr($script, 0, strpos($script, '/') ?: 0);
-		if (empty($topFolder)) {
-			try {
-				$path_info = $request->getPathInfo();
-			} catch (Exception $e) {
-				// Can happen from unit tests because the script name is `./vendor/bin/phpunit` or something a like then.
-				\OC::$server->get(LoggerInterface::class)->error('Failed to detect current app from script path', ['exception' => $e]);
-				return '';
-			}
-			if ($path_info) {
-				$topFolder = substr($path_info, 1, strpos($path_info, '/', 1) - 1);
-			}
-		}
-		if ($topFolder == 'apps') {
-			$length = strlen($topFolder);
-			return substr($script, $length + 1, strpos($script, '/', $length + 1) - $length - 1) ?: '';
-		} else {
-			return $topFolder;
-		}
-	}
-
-	/**
-	 * @param array $entry
-	 * @deprecated 20.0.0 Please register your alternative login option using the registerAlternativeLogin() on the RegistrationContext in your Application class implementing the OCP\Authentication\IAlternativeLogin interface
-	 */
-	public static function registerLogIn(array $entry) {
-		Server::get(LoggerInterface::class)->debug('OC_App::registerLogIn() is deprecated, please register your alternative login option using the registerAlternativeLogin() on the RegistrationContext in your Application class implementing the OCP\Authentication\IAlternativeLogin interface');
-		self::$altLogin[] = $entry;
-	}
-
-	/**
-	 * @return array
-	 */
-	public static function getAlternativeLogIns(): array {
-		/** @var Coordinator $bootstrapCoordinator */
-		$bootstrapCoordinator = Server::get(Coordinator::class);
-
-		foreach ($bootstrapCoordinator->getRegistrationContext()->getAlternativeLogins() as $registration) {
-			if (!in_array(IAlternativeLogin::class, class_implements($registration->getService()), true)) {
-				Server::get(LoggerInterface::class)->error('Alternative login option {option} does not implement {interface} and is therefore ignored.', [
-					'option' => $registration->getService(),
-					'interface' => IAlternativeLogin::class,
-					'app' => $registration->getAppId(),
-				]);
-				continue;
-			}
-
-			try {
-				/** @var IAlternativeLogin $provider */
-				$provider = Server::get($registration->getService());
-			} catch (ContainerExceptionInterface $e) {
-				Server::get(LoggerInterface::class)->error('Alternative login option {option} can not be initialized.',
-					[
-						'exception' => $e,
-						'option' => $registration->getService(),
-						'app' => $registration->getAppId(),
-					]);
-			}
-
-			try {
-				$provider->load();
-
-				self::$altLogin[] = [
-					'name' => $provider->getLabel(),
-					'href' => $provider->getLink(),
-					'class' => $provider->getClass(),
-				];
-			} catch (Throwable $e) {
-				Server::get(LoggerInterface::class)->error('Alternative login option {option} had an error while loading.',
-					[
-						'exception' => $e,
-						'option' => $registration->getService(),
-						'app' => $registration->getAppId(),
-					]);
-			}
-		}
-
-		return self::$altLogin;
-	}
-
-	/**
-	 * get a list of all apps in the apps folder
-	 *
-	 * @return string[] an array of app names (string IDs)
-	 * @deprecated 31.0.0 Use IAppManager::getAllAppsInAppsFolders instead
-	 */
-	public static function getAllApps(): array {
-		return Server::get(IAppManager::class)->getAllAppsInAppsFolders();
-	}
-
-	/**
-	 * List all supported apps
-	 *
-	 * @deprecated 32.0.0 Use \OCP\Support\Subscription\IRegistry::delegateGetSupportedApps instead
-	 */
-	public function getSupportedApps(): array {
-		$subscriptionRegistry = Server::get(\OCP\Support\Subscription\IRegistry::class);
-		$supportedApps = $subscriptionRegistry->delegateGetSupportedApps();
-		return $supportedApps;
-	}
-
-	/**
-	 * List all apps, this is used in apps.php
-	 *
-	 * @return array
-	 */
-	public function listAllApps(): array {
-		$appManager = \OC::$server->getAppManager();
-
-		$installedApps = $appManager->getAllAppsInAppsFolders();
-		//we don't want to show configuration for these
-		$blacklist = $appManager->getAlwaysEnabledApps();
-		$appList = [];
-		$langCode = \OC::$server->getL10N('core')->getLanguageCode();
-		$urlGenerator = \OC::$server->getURLGenerator();
-		$supportedApps = $this->getSupportedApps();
-
-		foreach ($installedApps as $app) {
-			if (!in_array($app, $blacklist)) {
-				$info = $appManager->getAppInfo($app, false, $langCode);
-				if (!is_array($info)) {
-					Server::get(LoggerInterface::class)->error('Could not read app info file for app "' . $app . '"', ['app' => 'core']);
-					continue;
-				}
-
-				if (!isset($info['name'])) {
-					Server::get(LoggerInterface::class)->error('App id "' . $app . '" has no name in appinfo', ['app' => 'core']);
-					continue;
-				}
-
-				$enabled = \OC::$server->getConfig()->getAppValue($app, 'enabled', 'no');
-				$info['groups'] = null;
-				if ($enabled === 'yes') {
-					$active = true;
-				} elseif ($enabled === 'no') {
-					$active = false;
-				} else {
-					$active = true;
-					$info['groups'] = $enabled;
-				}
-
-				$info['active'] = $active;
-
-				if ($appManager->isShipped($app)) {
-					$info['internal'] = true;
-					$info['level'] = self::officialApp;
-					$info['removable'] = false;
-				} else {
-					$info['internal'] = false;
-					$info['removable'] = true;
-				}
-
-				if (in_array($app, $supportedApps)) {
-					$info['level'] = self::supportedApp;
-				}
-
-				$appPath = self::getAppPath($app);
-				if ($appPath !== false) {
-					$appIcon = $appPath . '/img/' . $app . '.svg';
-					if (file_exists($appIcon)) {
-						$info['preview'] = $urlGenerator->imagePath($app, $app . '.svg');
-						$info['previewAsIcon'] = true;
-					} else {
-						$appIcon = $appPath . '/img/app.svg';
-						if (file_exists($appIcon)) {
-							$info['preview'] = $urlGenerator->imagePath($app, 'app.svg');
-							$info['previewAsIcon'] = true;
-						}
-					}
-				}
-				// fix documentation
-				if (isset($info['documentation']) && is_array($info['documentation'])) {
-					foreach ($info['documentation'] as $key => $url) {
-						// If it is not an absolute URL we assume it is a key
-						// i.e. admin-ldap will get converted to go.php?to=admin-ldap
-						if (stripos($url, 'https://') !== 0 && stripos($url, 'http://') !== 0) {
-							$url = $urlGenerator->linkToDocs($url);
-						}
-
-						$info['documentation'][$key] = $url;
-					}
-				}
-
-				$info['version'] = $appManager->getAppVersion($app);
-				$appList[] = $info;
-			}
-		}
-
-		return $appList;
-	}
-
-	public static function shouldUpgrade(string $app): bool {
-		$versions = self::getAppVersions();
-		$currentVersion = Server::get(\OCP\App\IAppManager::class)->getAppVersion($app);
-		if ($currentVersion && isset($versions[$app])) {
-			$installedVersion = $versions[$app];
-			if (!version_compare($currentVersion, $installedVersion, '=')) {
-				return true;
-			}
-		}
-		return false;
-	}
-
-	/**
-	 * Adjust the number of version parts of $version1 to match
-	 * the number of version parts of $version2.
-	 *
-	 * @param string $version1 version to adjust
-	 * @param string $version2 version to take the number of parts from
-	 * @return string shortened $version1
-	 */
-	private static function adjustVersionParts(string $version1, string $version2): string {
-		$version1 = explode('.', $version1);
-		$version2 = explode('.', $version2);
-		// reduce $version1 to match the number of parts in $version2
-		while (count($version1) > count($version2)) {
-			array_pop($version1);
-		}
-		// if $version1 does not have enough parts, add some
-		while (count($version1) < count($version2)) {
-			$version1[] = '0';
-		}
-		return implode('.', $version1);
-	}
-
-	/**
-	 * Check whether the current Nextcloud version matches the given
-	 * application's version requirements.
-	 *
-	 * The comparison is made based on the number of parts that the
-	 * app info version has. For example for ownCloud 6.0.3 if the
-	 * app info version is expecting version 6.0, the comparison is
-	 * made on the first two parts of the ownCloud version.
-	 * This means that it's possible to specify "requiremin" => 6
-	 * and "requiremax" => 6 and it will still match ownCloud 6.0.3.
-	 *
-	 * @param string $ocVersion Nextcloud version to check against
-	 * @param array $appInfo app info (from xml)
-	 *
-	 * @return boolean true if compatible, otherwise false
-	 */
-	public static function isAppCompatible(string $ocVersion, array $appInfo, bool $ignoreMax = false): bool {
-		$requireMin = '';
-		$requireMax = '';
-		if (isset($appInfo['dependencies']['nextcloud']['@attributes']['min-version'])) {
-			$requireMin = $appInfo['dependencies']['nextcloud']['@attributes']['min-version'];
-		} elseif (isset($appInfo['dependencies']['owncloud']['@attributes']['min-version'])) {
-			$requireMin = $appInfo['dependencies']['owncloud']['@attributes']['min-version'];
-		} elseif (isset($appInfo['requiremin'])) {
-			$requireMin = $appInfo['requiremin'];
-		} elseif (isset($appInfo['require'])) {
-			$requireMin = $appInfo['require'];
-		}
-
-		if (isset($appInfo['dependencies']['nextcloud']['@attributes']['max-version'])) {
-			$requireMax = $appInfo['dependencies']['nextcloud']['@attributes']['max-version'];
-		} elseif (isset($appInfo['dependencies']['owncloud']['@attributes']['max-version'])) {
-			$requireMax = $appInfo['dependencies']['owncloud']['@attributes']['max-version'];
-		} elseif (isset($appInfo['requiremax'])) {
-			$requireMax = $appInfo['requiremax'];
-		}
-
-		if (!empty($requireMin)
-			&& version_compare(self::adjustVersionParts($ocVersion, $requireMin), $requireMin, '<')
-		) {
-			return false;
-		}
-
-		if (!$ignoreMax && !empty($requireMax)
-			&& version_compare(self::adjustVersionParts($ocVersion, $requireMax), $requireMax, '>')
-		) {
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * get the installed version of all apps
-	 * @deprecated 32.0.0 Use IAppManager::getAppInstalledVersions or IAppConfig::getAppInstalledVersions instead
-	 */
-	public static function getAppVersions(): array {
-		return Server::get(IAppConfig::class)->getAppInstalledVersions();
-	}
-
-	/**
-	 * update the database for the app and call the update script
-	 *
-	 * @param string $appId
-	 * @return bool
-	 */
-	public static function updateApp(string $appId): bool {
-		// for apps distributed with core, we refresh app path in case the downloaded version
-		// have been installed in custom apps and not in the default path
-		$appPath = self::getAppPath($appId, true);
-		if ($appPath === false) {
-			return false;
-		}
-
-		if (is_file($appPath . '/appinfo/database.xml')) {
-			Server::get(LoggerInterface::class)->error('The appinfo/database.xml file is not longer supported. Used in ' . $appId);
-			return false;
-		}
-
-		\OC::$server->getAppManager()->clearAppsCache();
-		$l = \OC::$server->getL10N('core');
-		$appData = Server::get(\OCP\App\IAppManager::class)->getAppInfo($appId, false, $l->getLanguageCode());
-
-		$ignoreMaxApps = \OC::$server->getConfig()->getSystemValue('app_install_overwrite', []);
-		$ignoreMax = in_array($appId, $ignoreMaxApps, true);
-		\OC_App::checkAppDependencies(
-			\OC::$server->getConfig(),
-			$l,
-			$appData,
-			$ignoreMax
-		);
-
-		self::registerAutoloading($appId, $appPath, true);
-		self::executeRepairSteps($appId, $appData['repair-steps']['pre-migration']);
-
-		$ms = new MigrationService($appId, \OC::$server->get(\OC\DB\Connection::class));
-		$ms->migrate();
-
-		self::executeRepairSteps($appId, $appData['repair-steps']['post-migration']);
-		self::setupLiveMigrations($appId, $appData['repair-steps']['live-migration']);
-		// update appversion in app manager
-		\OC::$server->getAppManager()->clearAppsCache();
-		\OC::$server->getAppManager()->getAppVersion($appId, false);
-
-		self::setupBackgroundJobs($appData['background-jobs']);
-
-		//set remote/public handlers
-		if (array_key_exists('ocsid', $appData)) {
-			\OC::$server->getConfig()->setAppValue($appId, 'ocsid', $appData['ocsid']);
-		} elseif (\OC::$server->getConfig()->getAppValue($appId, 'ocsid', null) !== null) {
-			\OC::$server->getConfig()->deleteAppValue($appId, 'ocsid');
-		}
-		foreach ($appData['remote'] as $name => $path) {
-			\OC::$server->getConfig()->setAppValue('core', 'remote_' . $name, $appId . '/' . $path);
-		}
-		foreach ($appData['public'] as $name => $path) {
-			\OC::$server->getConfig()->setAppValue('core', 'public_' . $name, $appId . '/' . $path);
-		}
-
-		self::setAppTypes($appId);
-
-		$version = Server::get(\OCP\App\IAppManager::class)->getAppVersion($appId);
-		\OC::$server->getConfig()->setAppValue($appId, 'installed_version', $version);
-
-		// migrate eventual new config keys in the process
-		/** @psalm-suppress InternalMethod */
-		Server::get(ConfigManager::class)->migrateConfigLexiconKeys($appId);
-
-		\OC::$server->get(IEventDispatcher::class)->dispatchTyped(new AppUpdateEvent($appId));
-		\OC::$server->get(IEventDispatcher::class)->dispatch(ManagerEvent::EVENT_APP_UPDATE, new ManagerEvent(
-			ManagerEvent::EVENT_APP_UPDATE, $appId
-		));
-
-		return true;
-	}
-
-	/**
-	 * @param string $appId
-	 * @param string[] $steps
-	 * @throws \OC\NeedsUpdateException
-	 */
-	public static function executeRepairSteps(string $appId, array $steps) {
-		if (empty($steps)) {
-			return;
-		}
-		// load the app
-		self::loadApp($appId);
-
-		$dispatcher = Server::get(IEventDispatcher::class);
-
-		// load the steps
-		$r = Server::get(Repair::class);
-		foreach ($steps as $step) {
-			try {
-				$r->addStep($step);
-			} catch (Exception $ex) {
-				$dispatcher->dispatchTyped(new RepairErrorEvent($ex->getMessage()));
-				logger('core')->error('Failed to add app migration step ' . $step, ['exception' => $ex]);
-			}
-		}
-		// run the steps
-		$r->run();
-	}
-
-	public static function setupBackgroundJobs(array $jobs) {
-		$queue = \OC::$server->getJobList();
-		foreach ($jobs as $job) {
-			$queue->add($job);
-		}
-	}
-
-	/**
-	 * @param string $appId
-	 * @param string[] $steps
-	 */
-	private static function setupLiveMigrations(string $appId, array $steps) {
-		$queue = \OC::$server->getJobList();
-		foreach ($steps as $step) {
-			$queue->add('OC\Migration\BackgroundRepair', [
-				'app' => $appId,
-				'step' => $step]);
-		}
-	}
-
-	/**
-	 * @param \OCP\IConfig $config
-	 * @param \OCP\IL10N $l
-	 * @param array $info
-	 * @throws \Exception
-	 */
-	public static function checkAppDependencies(\OCP\IConfig $config, \OCP\IL10N $l, array $info, bool $ignoreMax) {
-		$dependencyAnalyzer = new DependencyAnalyzer(new Platform($config), $l);
-		$missing = $dependencyAnalyzer->analyze($info, $ignoreMax);
-		if (!empty($missing)) {
-			$missingMsg = implode(PHP_EOL, $missing);
-			throw new \Exception(
-				$l->t('App "%1$s" cannot be installed because the following dependencies are not fulfilled: %2$s',
-					[$info['name'], $missingMsg]
-				)
-			);
-		}
-	}
+    private static $altLogin = [];
+    private static $alreadyRegistered = [];
+    public const supportedApp = 300;
+    public const officialApp = 200;
+
+    /**
+     * clean the appId
+     *
+     * @psalm-taint-escape file
+     * @psalm-taint-escape include
+     * @psalm-taint-escape html
+     * @psalm-taint-escape has_quotes
+     *
+     * @deprecated 31.0.0 use IAppManager::cleanAppId
+     */
+    public static function cleanAppId(string $app): string {
+        return str_replace(['<', '>', '"', "'", '\0', '/', '\\', '..'], '', $app);
+    }
+
+    /**
+     * Check if an app is loaded
+     *
+     * @param string $app
+     * @return bool
+     * @deprecated 27.0.0 use IAppManager::isAppLoaded
+     */
+    public static function isAppLoaded(string $app): bool {
+        return \OC::$server->get(IAppManager::class)->isAppLoaded($app);
+    }
+
+    /**
+     * loads all apps
+     *
+     * @param string[] $types
+     * @return bool
+     *
+     * This function walks through the Nextcloud directory and loads all apps
+     * it can find. A directory contains an app if the file /appinfo/info.xml
+     * exists.
+     *
+     * if $types is set to non-empty array, only apps of those types will be loaded
+     *
+     * @deprecated 29.0.0 use IAppManager::loadApps instead
+     */
+    public static function loadApps(array $types = []): bool {
+        if (!\OC::$server->getSystemConfig()->getValue('installed', false)) {
+            // This should be done before calling this method so that appmanager can be used
+            return false;
+        }
+        return \OC::$server->get(IAppManager::class)->loadApps($types);
+    }
+
+    /**
+     * load a single app
+     *
+     * @param string $app
+     * @throws Exception
+     * @deprecated 27.0.0 use IAppManager::loadApp
+     */
+    public static function loadApp(string $app): void {
+        \OC::$server->get(IAppManager::class)->loadApp($app);
+    }
+
+    /**
+     * @internal
+     * @param string $app
+     * @param string $path
+     * @param bool $force
+     */
+    public static function registerAutoloading(string $app, string $path, bool $force = false) {
+        $key = $app . '-' . $path;
+        if (!$force && isset(self::$alreadyRegistered[$key])) {
+            return;
+        }
+
+        self::$alreadyRegistered[$key] = true;
+
+        // Register on PSR-4 composer autoloader
+        $appNamespace = \OC\AppFramework\App::buildAppNamespace($app);
+        \OC::$server->registerNamespace($app, $appNamespace);
+
+        if (file_exists($path . '/composer/autoload.php')) {
+            require_once $path . '/composer/autoload.php';
+        } else {
+            \OC::$composerAutoloader->addPsr4($appNamespace . '\\', $path . '/lib/', true);
+        }
+
+        // Register Test namespace only when testing
+        if (defined('PHPUNIT_RUN') || defined('CLI_TEST_RUN')) {
+            \OC::$composerAutoloader->addPsr4($appNamespace . '\\Tests\\', $path . '/tests/', true);
+        }
+    }
+
+    /**
+     * check if an app is of a specific type
+     *
+     * @param string $app
+     * @param array $types
+     * @return bool
+     * @deprecated 27.0.0 use IAppManager::isType
+     */
+    public static function isType(string $app, array $types): bool {
+        return \OC::$server->get(IAppManager::class)->isType($app, $types);
+    }
+
+    /**
+     * read app types from info.xml and cache them in the database
+     */
+    public static function setAppTypes(string $app) {
+        $appManager = \OC::$server->getAppManager();
+        $appData = $appManager->getAppInfo($app);
+        if (!is_array($appData)) {
+            return;
+        }
+
+        if (isset($appData['types'])) {
+            $appTypes = implode(',', $appData['types']);
+        } else {
+            $appTypes = '';
+            $appData['types'] = [];
+        }
+
+        $config = \OC::$server->getConfig();
+        $config->setAppValue($app, 'types', $appTypes);
+
+        if ($appManager->hasProtectedAppType($appData['types'])) {
+            $enabled = $config->getAppValue($app, 'enabled', 'yes');
+            if ($enabled !== 'yes' && $enabled !== 'no') {
+                $config->setAppValue($app, 'enabled', 'yes');
+            }
+        }
+    }
+
+    /**
+     * Returns apps enabled for the current user.
+     *
+     * @param bool $forceRefresh whether to refresh the cache
+     * @param bool $all whether to return apps for all users, not only the
+     *                  currently logged in one
+     * @return list<string>
+     */
+    public static function getEnabledApps(bool $forceRefresh = false, bool $all = false): array {
+        if (!\OC::$server->getSystemConfig()->getValue('installed', false)) {
+            return [];
+        }
+        // in incognito mode or when logged out, $user will be false,
+        // which is also the case during an upgrade
+        $appManager = \OC::$server->getAppManager();
+        if ($all) {
+            $user = null;
+        } else {
+            $user = \OC::$server->getUserSession()->getUser();
+        }
+
+        if (is_null($user)) {
+            $apps = $appManager->getEnabledApps();
+        } else {
+            $apps = $appManager->getEnabledAppsForUser($user);
+        }
+        $apps = array_filter($apps, function ($app) {
+            return $app !== 'files';//we add this manually
+        });
+        sort($apps);
+        array_unshift($apps, 'files');
+        return $apps;
+    }
+
+    /**
+     * enables an app
+     *
+     * @param string $appId
+     * @param array $groups (optional) when set, only these groups will have access to the app
+     * @throws \Exception
+     * @return void
+     *
+     * This function set an app as enabled in appconfig.
+     */
+    public function enable(string $appId,
+        array $groups = []) {
+        // Check if app is already downloaded
+        /** @var Installer $installer */
+        $installer = Server::get(Installer::class);
+        $isDownloaded = $installer->isDownloaded($appId);
+
+        if (!$isDownloaded) {
+            $installer->downloadApp($appId);
+        }
+
+        $installer->installApp($appId);
+
+        $appManager = \OC::$server->getAppManager();
+        if ($groups !== []) {
+            $groupManager = \OC::$server->getGroupManager();
+            $groupsList = [];
+            foreach ($groups as $group) {
+                $groupItem = $groupManager->get($group);
+                if ($groupItem instanceof \OCP\IGroup) {
+                    $groupsList[] = $groupManager->get($group);
+                }
+            }
+            $appManager->enableAppForGroups($appId, $groupsList);
+        } else {
+            $appManager->enableApp($appId);
+        }
+    }
+
+    /**
+     * Find the apps root for an app id.
+     *
+     * If multiple copies are found, the apps root the latest version is returned.
+     *
+     * @param string $appId
+     * @param bool $ignoreCache ignore cache and rebuild it
+     * @return false|array{path: string, url: string} the apps root shape
+     */
+    public static function findAppInDirectories(string $appId, bool $ignoreCache = false) {
+        $sanitizedAppId = self::cleanAppId($appId);
+        if ($sanitizedAppId !== $appId) {
+            return false;
+        }
+        static $app_dir = [];
+
+        if (isset($app_dir[$appId]) && !$ignoreCache) {
+            return $app_dir[$appId];
+        }
+
+        $possibleApps = [];
+        foreach (OC::$APPSROOTS as $dir) {
+            if (file_exists($dir['path'] . '/' . $appId)) {
+                $possibleApps[] = $dir;
+            }
+        }
+
+        if (empty($possibleApps)) {
+            return false;
+        } elseif (count($possibleApps) === 1) {
+            $dir = array_shift($possibleApps);
+            $app_dir[$appId] = $dir;
+            return $dir;
+        } else {
+            $versionToLoad = [];
+            foreach ($possibleApps as $possibleApp) {
+                $version = self::getAppVersionByPath($possibleApp['path'] . '/' . $appId);
+                if (empty($versionToLoad) || version_compare($version, $versionToLoad['version'], '>')) {
+                    $versionToLoad = [
+                        'dir' => $possibleApp,
+                        'version' => $version,
+                    ];
+                }
+            }
+            $app_dir[$appId] = $versionToLoad['dir'];
+            return $versionToLoad['dir'];
+            //TODO - write test
+        }
+    }
+
+    /**
+     * Get the directory for the given app.
+     * If the app is defined in multiple directories, the first one is taken. (false if not found)
+     *
+     * @psalm-taint-specialize
+     *
+     * @param string $appId
+     * @param bool $refreshAppPath should be set to true only during install/upgrade
+     * @return string|false
+     * @deprecated 11.0.0 use Server::get(IAppManager)->getAppPath()
+     */
+    public static function getAppPath(string $appId, bool $refreshAppPath = false) {
+        $appId = self::cleanAppId($appId);
+        if ($appId === '') {
+            return false;
+        } elseif ($appId === 'core') {
+            return __DIR__ . '/../../../core';
+        }
+
+        if (($dir = self::findAppInDirectories($appId, $refreshAppPath)) != false) {
+            return $dir['path'] . '/' . $appId;
+        }
+        return false;
+    }
+
+    /**
+     * Get the path for the given app on the access
+     * If the app is defined in multiple directories, the first one is taken. (false if not found)
+     *
+     * @param string $appId
+     * @return string|false
+     * @deprecated 18.0.0 use \OC::$server->getAppManager()->getAppWebPath()
+     */
+    public static function getAppWebPath(string $appId) {
+        if (($dir = self::findAppInDirectories($appId)) != false) {
+            return OC::$WEBROOT . $dir['url'] . '/' . $appId;
+        }
+        return false;
+    }
+
+    /**
+     * get app's version based on it's path
+     *
+     * @param string $path
+     * @return string
+     */
+    public static function getAppVersionByPath(string $path): string {
+        $infoFile = $path . '/appinfo/info.xml';
+        $appData = Server::get(IAppManager::class)->getAppInfoByPath($infoFile);
+        return $appData['version'] ?? '';
+    }
+
+    /**
+     * get the id of loaded app
+     *
+     * @return string
+     */
+    public static function getCurrentApp(): string {
+        if (\OC::$CLI) {
+            return '';
+        }
+
+        $request = \OC::$server->getRequest();
+        $script = substr($request->getScriptName(), strlen(OC::$WEBROOT) + 1);
+        $topFolder = substr($script, 0, strpos($script, '/') ?: 0);
+        if (empty($topFolder)) {
+            try {
+                $path_info = $request->getPathInfo();
+            } catch (Exception $e) {
+                // Can happen from unit tests because the script name is `./vendor/bin/phpunit` or something a like then.
+                \OC::$server->get(LoggerInterface::class)->error('Failed to detect current app from script path', ['exception' => $e]);
+                return '';
+            }
+            if ($path_info) {
+                $topFolder = substr($path_info, 1, strpos($path_info, '/', 1) - 1);
+            }
+        }
+        if ($topFolder == 'apps') {
+            $length = strlen($topFolder);
+            return substr($script, $length + 1, strpos($script, '/', $length + 1) - $length - 1) ?: '';
+        } else {
+            return $topFolder;
+        }
+    }
+
+    /**
+     * @param array $entry
+     * @deprecated 20.0.0 Please register your alternative login option using the registerAlternativeLogin() on the RegistrationContext in your Application class implementing the OCP\Authentication\IAlternativeLogin interface
+     */
+    public static function registerLogIn(array $entry) {
+        Server::get(LoggerInterface::class)->debug('OC_App::registerLogIn() is deprecated, please register your alternative login option using the registerAlternativeLogin() on the RegistrationContext in your Application class implementing the OCP\Authentication\IAlternativeLogin interface');
+        self::$altLogin[] = $entry;
+    }
+
+    /**
+     * @return array
+     */
+    public static function getAlternativeLogIns(): array {
+        /** @var Coordinator $bootstrapCoordinator */
+        $bootstrapCoordinator = Server::get(Coordinator::class);
+
+        foreach ($bootstrapCoordinator->getRegistrationContext()->getAlternativeLogins() as $registration) {
+            if (!in_array(IAlternativeLogin::class, class_implements($registration->getService()), true)) {
+                Server::get(LoggerInterface::class)->error('Alternative login option {option} does not implement {interface} and is therefore ignored.', [
+                    'option' => $registration->getService(),
+                    'interface' => IAlternativeLogin::class,
+                    'app' => $registration->getAppId(),
+                ]);
+                continue;
+            }
+
+            try {
+                /** @var IAlternativeLogin $provider */
+                $provider = Server::get($registration->getService());
+            } catch (ContainerExceptionInterface $e) {
+                Server::get(LoggerInterface::class)->error('Alternative login option {option} can not be initialized.',
+                    [
+                        'exception' => $e,
+                        'option' => $registration->getService(),
+                        'app' => $registration->getAppId(),
+                    ]);
+            }
+
+            try {
+                $provider->load();
+
+                self::$altLogin[] = [
+                    'name' => $provider->getLabel(),
+                    'href' => $provider->getLink(),
+                    'class' => $provider->getClass(),
+                ];
+            } catch (Throwable $e) {
+                Server::get(LoggerInterface::class)->error('Alternative login option {option} had an error while loading.',
+                    [
+                        'exception' => $e,
+                        'option' => $registration->getService(),
+                        'app' => $registration->getAppId(),
+                    ]);
+            }
+        }
+
+        return self::$altLogin;
+    }
+
+    /**
+     * get a list of all apps in the apps folder
+     *
+     * @return string[] an array of app names (string IDs)
+     * @deprecated 31.0.0 Use IAppManager::getAllAppsInAppsFolders instead
+     */
+    public static function getAllApps(): array {
+        return Server::get(IAppManager::class)->getAllAppsInAppsFolders();
+    }
+
+    /**
+     * List all supported apps
+     *
+     * @deprecated 32.0.0 Use \OCP\Support\Subscription\IRegistry::delegateGetSupportedApps instead
+     */
+    public function getSupportedApps(): array {
+        $subscriptionRegistry = Server::get(\OCP\Support\Subscription\IRegistry::class);
+        $supportedApps = $subscriptionRegistry->delegateGetSupportedApps();
+        return $supportedApps;
+    }
+
+    /**
+     * List all apps, this is used in apps.php
+     *
+     * @return array
+     */
+    public function listAllApps(): array {
+        $appManager = \OC::$server->getAppManager();
+
+        $installedApps = $appManager->getAllAppsInAppsFolders();
+        //we don't want to show configuration for these
+        $blacklist = $appManager->getAlwaysEnabledApps();
+        $appList = [];
+        $langCode = \OC::$server->getL10N('core')->getLanguageCode();
+        $urlGenerator = \OC::$server->getURLGenerator();
+        $supportedApps = $this->getSupportedApps();
+
+        foreach ($installedApps as $app) {
+            if (!in_array($app, $blacklist)) {
+                $info = $appManager->getAppInfo($app, false, $langCode);
+                if (!is_array($info)) {
+                    Server::get(LoggerInterface::class)->error('Could not read app info file for app "' . $app . '"', ['app' => 'core']);
+                    continue;
+                }
+
+                if (!isset($info['name'])) {
+                    Server::get(LoggerInterface::class)->error('App id "' . $app . '" has no name in appinfo', ['app' => 'core']);
+                    continue;
+                }
+
+                $enabled = \OC::$server->getConfig()->getAppValue($app, 'enabled', 'no');
+                $info['groups'] = null;
+                if ($enabled === 'yes') {
+                    $active = true;
+                } elseif ($enabled === 'no') {
+                    $active = false;
+                } else {
+                    $active = true;
+                    $info['groups'] = $enabled;
+                }
+
+                $info['active'] = $active;
+
+                if ($appManager->isShipped($app)) {
+                    $info['internal'] = true;
+                    $info['level'] = self::officialApp;
+                    $info['removable'] = false;
+                } else {
+                    $info['internal'] = false;
+                    $info['removable'] = true;
+                }
+
+                if (in_array($app, $supportedApps)) {
+                    $info['level'] = self::supportedApp;
+                }
+
+                $appPath = self::getAppPath($app);
+                if ($appPath !== false) {
+                    $appIcon = $appPath . '/img/' . $app . '.svg';
+                    if (file_exists($appIcon)) {
+                        $info['preview'] = $urlGenerator->imagePath($app, $app . '.svg');
+                        $info['previewAsIcon'] = true;
+                    } else {
+                        $appIcon = $appPath . '/img/app.svg';
+                        if (file_exists($appIcon)) {
+                            $info['preview'] = $urlGenerator->imagePath($app, 'app.svg');
+                            $info['previewAsIcon'] = true;
+                        }
+                    }
+                }
+                // fix documentation
+                if (isset($info['documentation']) && is_array($info['documentation'])) {
+                    foreach ($info['documentation'] as $key => $url) {
+                        // If it is not an absolute URL we assume it is a key
+                        // i.e. admin-ldap will get converted to go.php?to=admin-ldap
+                        if (stripos($url, 'https://') !== 0 && stripos($url, 'http://') !== 0) {
+                            $url = $urlGenerator->linkToDocs($url);
+                        }
+
+                        $info['documentation'][$key] = $url;
+                    }
+                }
+
+                $info['version'] = $appManager->getAppVersion($app);
+                $appList[] = $info;
+            }
+        }
+
+        return $appList;
+    }
+
+    public static function shouldUpgrade(string $app): bool {
+        $versions = self::getAppVersions();
+        $currentVersion = Server::get(\OCP\App\IAppManager::class)->getAppVersion($app);
+        if ($currentVersion && isset($versions[$app])) {
+            $installedVersion = $versions[$app];
+            if (!version_compare($currentVersion, $installedVersion, '=')) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    /**
+     * Adjust the number of version parts of $version1 to match
+     * the number of version parts of $version2.
+     *
+     * @param string $version1 version to adjust
+     * @param string $version2 version to take the number of parts from
+     * @return string shortened $version1
+     */
+    private static function adjustVersionParts(string $version1, string $version2): string {
+        $version1 = explode('.', $version1);
+        $version2 = explode('.', $version2);
+        // reduce $version1 to match the number of parts in $version2
+        while (count($version1) > count($version2)) {
+            array_pop($version1);
+        }
+        // if $version1 does not have enough parts, add some
+        while (count($version1) < count($version2)) {
+            $version1[] = '0';
+        }
+        return implode('.', $version1);
+    }
+
+    /**
+     * Check whether the current Nextcloud version matches the given
+     * application's version requirements.
+     *
+     * The comparison is made based on the number of parts that the
+     * app info version has. For example for ownCloud 6.0.3 if the
+     * app info version is expecting version 6.0, the comparison is
+     * made on the first two parts of the ownCloud version.
+     * This means that it's possible to specify "requiremin" => 6
+     * and "requiremax" => 6 and it will still match ownCloud 6.0.3.
+     *
+     * @param string $ocVersion Nextcloud version to check against
+     * @param array $appInfo app info (from xml)
+     *
+     * @return boolean true if compatible, otherwise false
+     */
+    public static function isAppCompatible(string $ocVersion, array $appInfo, bool $ignoreMax = false): bool {
+        $requireMin = '';
+        $requireMax = '';
+        if (isset($appInfo['dependencies']['nextcloud']['@attributes']['min-version'])) {
+            $requireMin = $appInfo['dependencies']['nextcloud']['@attributes']['min-version'];
+        } elseif (isset($appInfo['dependencies']['owncloud']['@attributes']['min-version'])) {
+            $requireMin = $appInfo['dependencies']['owncloud']['@attributes']['min-version'];
+        } elseif (isset($appInfo['requiremin'])) {
+            $requireMin = $appInfo['requiremin'];
+        } elseif (isset($appInfo['require'])) {
+            $requireMin = $appInfo['require'];
+        }
+
+        if (isset($appInfo['dependencies']['nextcloud']['@attributes']['max-version'])) {
+            $requireMax = $appInfo['dependencies']['nextcloud']['@attributes']['max-version'];
+        } elseif (isset($appInfo['dependencies']['owncloud']['@attributes']['max-version'])) {
+            $requireMax = $appInfo['dependencies']['owncloud']['@attributes']['max-version'];
+        } elseif (isset($appInfo['requiremax'])) {
+            $requireMax = $appInfo['requiremax'];
+        }
+
+        if (!empty($requireMin)
+            && version_compare(self::adjustVersionParts($ocVersion, $requireMin), $requireMin, '<')
+        ) {
+            return false;
+        }
+
+        if (!$ignoreMax && !empty($requireMax)
+            && version_compare(self::adjustVersionParts($ocVersion, $requireMax), $requireMax, '>')
+        ) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * get the installed version of all apps
+     * @deprecated 32.0.0 Use IAppManager::getAppInstalledVersions or IAppConfig::getAppInstalledVersions instead
+     */
+    public static function getAppVersions(): array {
+        return Server::get(IAppConfig::class)->getAppInstalledVersions();
+    }
+
+    /**
+     * update the database for the app and call the update script
+     *
+     * @param string $appId
+     * @return bool
+     */
+    public static function updateApp(string $appId): bool {
+        // for apps distributed with core, we refresh app path in case the downloaded version
+        // have been installed in custom apps and not in the default path
+        $appPath = self::getAppPath($appId, true);
+        if ($appPath === false) {
+            return false;
+        }
+
+        if (is_file($appPath . '/appinfo/database.xml')) {
+            Server::get(LoggerInterface::class)->error('The appinfo/database.xml file is not longer supported. Used in ' . $appId);
+            return false;
+        }
+
+        \OC::$server->getAppManager()->clearAppsCache();
+        $l = \OC::$server->getL10N('core');
+        $appData = Server::get(\OCP\App\IAppManager::class)->getAppInfo($appId, false, $l->getLanguageCode());
+
+        $ignoreMaxApps = \OC::$server->getConfig()->getSystemValue('app_install_overwrite', []);
+        $ignoreMax = in_array($appId, $ignoreMaxApps, true);
+        \OC_App::checkAppDependencies(
+            \OC::$server->getConfig(),
+            $l,
+            $appData,
+            $ignoreMax
+        );
+
+        self::registerAutoloading($appId, $appPath, true);
+        self::executeRepairSteps($appId, $appData['repair-steps']['pre-migration']);
+
+        $ms = new MigrationService($appId, \OC::$server->get(\OC\DB\Connection::class));
+        $ms->migrate();
+
+        self::executeRepairSteps($appId, $appData['repair-steps']['post-migration']);
+        self::setupLiveMigrations($appId, $appData['repair-steps']['live-migration']);
+        // update appversion in app manager
+        \OC::$server->getAppManager()->clearAppsCache();
+        \OC::$server->getAppManager()->getAppVersion($appId, false);
+
+        self::setupBackgroundJobs($appData['background-jobs']);
+
+        //set remote/public handlers
+        if (array_key_exists('ocsid', $appData)) {
+            \OC::$server->getConfig()->setAppValue($appId, 'ocsid', $appData['ocsid']);
+        } elseif (\OC::$server->getConfig()->getAppValue($appId, 'ocsid', null) !== null) {
+            \OC::$server->getConfig()->deleteAppValue($appId, 'ocsid');
+        }
+        foreach ($appData['remote'] as $name => $path) {
+            \OC::$server->getConfig()->setAppValue('core', 'remote_' . $name, $appId . '/' . $path);
+        }
+        foreach ($appData['public'] as $name => $path) {
+            \OC::$server->getConfig()->setAppValue('core', 'public_' . $name, $appId . '/' . $path);
+        }
+
+        self::setAppTypes($appId);
+
+        $version = Server::get(\OCP\App\IAppManager::class)->getAppVersion($appId);
+        \OC::$server->getConfig()->setAppValue($appId, 'installed_version', $version);
+
+        // migrate eventual new config keys in the process
+        /** @psalm-suppress InternalMethod */
+        Server::get(ConfigManager::class)->migrateConfigLexiconKeys($appId);
+
+        \OC::$server->get(IEventDispatcher::class)->dispatchTyped(new AppUpdateEvent($appId));
+        \OC::$server->get(IEventDispatcher::class)->dispatch(ManagerEvent::EVENT_APP_UPDATE, new ManagerEvent(
+            ManagerEvent::EVENT_APP_UPDATE, $appId
+        ));
+
+        return true;
+    }
+
+    /**
+     * @param string $appId
+     * @param string[] $steps
+     * @throws \OC\NeedsUpdateException
+     */
+    public static function executeRepairSteps(string $appId, array $steps) {
+        if (empty($steps)) {
+            return;
+        }
+        // load the app
+        self::loadApp($appId);
+
+        $dispatcher = Server::get(IEventDispatcher::class);
+
+        // load the steps
+        $r = Server::get(Repair::class);
+        foreach ($steps as $step) {
+            try {
+                $r->addStep($step);
+            } catch (Exception $ex) {
+                $dispatcher->dispatchTyped(new RepairErrorEvent($ex->getMessage()));
+                logger('core')->error('Failed to add app migration step ' . $step, ['exception' => $ex]);
+            }
+        }
+        // run the steps
+        $r->run();
+    }
+
+    public static function setupBackgroundJobs(array $jobs) {
+        $queue = \OC::$server->getJobList();
+        foreach ($jobs as $job) {
+            $queue->add($job);
+        }
+    }
+
+    /**
+     * @param string $appId
+     * @param string[] $steps
+     */
+    private static function setupLiveMigrations(string $appId, array $steps) {
+        $queue = \OC::$server->getJobList();
+        foreach ($steps as $step) {
+            $queue->add('OC\Migration\BackgroundRepair', [
+                'app' => $appId,
+                'step' => $step]);
+        }
+    }
+
+    /**
+     * @param \OCP\IConfig $config
+     * @param \OCP\IL10N $l
+     * @param array $info
+     * @throws \Exception
+     */
+    public static function checkAppDependencies(\OCP\IConfig $config, \OCP\IL10N $l, array $info, bool $ignoreMax) {
+        $dependencyAnalyzer = new DependencyAnalyzer(new Platform($config), $l);
+        $missing = $dependencyAnalyzer->analyze($info, $ignoreMax);
+        if (!empty($missing)) {
+            $missingMsg = implode(PHP_EOL, $missing);
+            throw new \Exception(
+                $l->t('App "%1$s" cannot be installed because the following dependencies are not fulfilled: %2$s',
+                    [$info['name'], $missingMsg]
+                )
+            );
+        }
+    }
 }