Completed
Pull Request — master (#796)
by Björn
09:35
created
settings/Controller/AdminSettingsController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -82,6 +82,9 @@
 block discarded – undo
82 82
 
83 83
 	}
84 84
 
85
+	/**
86
+	 * @param string $section
87
+	 */
85 88
 	private function getSettings($section) {
86 89
 		$settings = $this->settingsManager->getAdminSettings($section);
87 90
 		$html = '';
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 namespace OC\Settings\Controller;
25 25
 
26
-use Doctrine\DBAL\Connection;
27 26
 use OCP\AppFramework\Controller;
28 27
 use OCP\AppFramework\Http\TemplateResponse;
29 28
 use OC\Encryption\Manager as EncryptionManager;
Please login to merge, or discard this patch.
lib/private/Settings/Manager.php 1 patch
Doc Comments   +18 added lines patch added patch discarded remove patch
@@ -127,6 +127,9 @@  discard block
 block discarded – undo
127 127
 		]);
128 128
 	}
129 129
 
130
+	/**
131
+	 * @param string $table
132
+	 */
130 133
 	private function add($table, $values) {
131 134
 		$query = $this->dbc->getQueryBuilder();
132 135
 		$values = array_map(function($value) use ($query) {
@@ -160,6 +163,11 @@  discard block
 block discarded – undo
160 163
 		);
161 164
 	}
162 165
 
166
+	/**
167
+	 * @param string $table
168
+	 * @param string $idCol
169
+	 * @param string $id
170
+	 */
163 171
 	private function update($table, $idCol, $id, $values) {
164 172
 		$query = $this->dbc->getQueryBuilder();
165 173
 		$query->update($table);
@@ -189,6 +197,10 @@  discard block
 block discarded – undo
189 197
 	}
190 198
 
191 199
 
200
+	/**
201
+	 * @param string $table
202
+	 * @param string $className
203
+	 */
192 204
 	private function has($table, $className) {
193 205
 		$query = $this->dbc->getQueryBuilder();
194 206
 		$query->select('class')
@@ -278,6 +290,9 @@  discard block
 block discarded – undo
278 290
 		return $sections;
279 291
 	}
280 292
 
293
+	/**
294
+	 * @param string $section
295
+	 */
281 296
 	private function getBuiltInAdminSettings($section) {
282 297
 		$forms = [];
283 298
 		try {
@@ -312,6 +327,9 @@  discard block
 block discarded – undo
312 327
 		return $forms;
313 328
 	}
314 329
 
330
+	/**
331
+	 * @param string $section
332
+	 */
315 333
 	private function getAdminSettingsFromDB($section, &$settings) {
316 334
 		$query = $this->dbc->getQueryBuilder();
317 335
 		$query->select(['class', 'priority'])
Please login to merge, or discard this patch.