Inspection of "Merge pull request #21469 from nextcloud/bugfix/no..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 59093a...6ec804 )

by Roeland

created 2020-06-19 19:28 UTC

Status

Indentation +292 added lines, -292 removed lines patch added patch discarded remove patch

@@ -35,296 +35,296 @@
 block discarded – undo
 
 class RegistrationContext {
 
-	/** @var array[] */
-	private $capabilities = [];
-
-	/** @var array[] */
-	private $crashReporters = [];
-
-	/** @var array[] */
-	private $services = [];
-
-	/** @var array[] */
-	private $aliases = [];
-
-	/** @var array[] */
-	private $parameters = [];
-
-	/** @var array[] */
-	private $eventListeners = [];
-
-	/** @var array[] */
-	private $middlewares = [];
-
-	/** @var ILogger */
-	private $logger;
-
-	public function __construct(ILogger $logger) {
-		$this->logger = $logger;
-	}
-
-	public function for(string $appId): IRegistrationContext {
-		return new class($appId, $this) implements IRegistrationContext {
-			/** @var string */
-			private $appId;
-
-			/** @var RegistrationContext */
-			private $context;
-
-			public function __construct(string $appId, RegistrationContext $context) {
-				$this->appId = $appId;
-				$this->context = $context;
-			}
-
-			public function registerCapability(string $capability): void {
-				$this->context->registerCapability(
-					$this->appId,
-					$capability
-				);
-			}
-
-			public function registerCrashReporter(string $reporterClass): void {
-				$this->context->registerCrashReporter(
-					$this->appId,
-					$reporterClass
-				);
-			}
-
-			public function registerService(string $name, callable $factory, bool $shared = true): void {
-				$this->context->registerService(
-					$this->appId,
-					$name,
-					$factory,
-					$shared
-				);
-			}
-
-			public function registerServiceAlias(string $alias, string $target): void {
-				$this->context->registerServiceAlias(
-					$this->appId,
-					$alias,
-					$target
-				);
-			}
-
-			public function registerParameter(string $name, $value): void {
-				$this->context->registerParameter(
-					$this->appId,
-					$name,
-					$value
-				);
-			}
-
-			public function registerEventListener(string $event, string $listener, int $priority = 0): void {
-				$this->context->registerEventListener(
-					$this->appId,
-					$event,
-					$listener,
-					$priority
-				);
-			}
-
-			public function registerMiddleware(string $class): void {
-				$this->context->registerMiddleware(
-					$this->appId,
-					$class
-				);
-			}
-		};
-	}
-
-	public function registerCapability(string $appId, string $capability): void {
-		$this->capabilities[] = [
-			'appId' => $appId,
-			'capability' => $capability
-		];
-	}
-
-	public function registerCrashReporter(string $appId, string $reporterClass): void {
-		$this->crashReporters[] = [
-			'appId' => $appId,
-			'class' => $reporterClass,
-		];
-	}
-
-	public function registerService(string $appId, string $name, callable $factory, bool $shared = true): void {
-		$this->services[] = [
-			"appId" => $appId,
-			"name" => $name,
-			"factory" => $factory,
-			"sharred" => $shared,
-		];
-	}
-
-	public function registerServiceAlias(string $appId, string $alias, string $target): void {
-		$this->aliases[] = [
-			"appId" => $appId,
-			"alias" => $alias,
-			"target" => $target,
-		];
-	}
-
-	public function registerParameter(string $appId, string $name, $value): void {
-		$this->parameters[] = [
-			"appId" => $appId,
-			"name" => $name,
-			"value" => $value,
-		];
-	}
-
-	public function registerEventListener(string $appId, string $event, string $listener, int $priority = 0): void {
-		$this->eventListeners[] = [
-			"appId" => $appId,
-			"event" => $event,
-			"listener" => $listener,
-			"priority" => $priority,
-		];
-	}
-
-	public function registerMiddleware(string $appId, string $class): void {
-		$this->middlewares[] = [
-			"appId" => $appId,
-			"class" => $class,
-		];
-	}
-
-	/**
-	 * @param App[] $apps
-	 */
-	public function delegateCapabilityRegistrations(array $apps): void {
-		foreach ($this->capabilities as $registration) {
-			try {
-				$apps[$registration['appId']]
-					->getContainer()
-					->registerCapability($registration['capability']);
-			} catch (Throwable $e) {
-				$appId = $registration['appId'];
-				$this->logger->logException($e, [
-					'message' => "Error during capability registration of $appId: " . $e->getMessage(),
-					'level' => ILogger::ERROR,
-				]);
-			}
-		}
-	}
-
-	/**
-	 * @param App[] $apps
-	 */
-	public function delegateCrashReporterRegistrations(array $apps, Registry $registry): void {
-		foreach ($this->crashReporters as $registration) {
-			try {
-				$registry->registerLazy($registration['class']);
-			} catch (Throwable $e) {
-				$appId = $registration['appId'];
-				$this->logger->logException($e, [
-					'message' => "Error during crash reporter registration of $appId: " . $e->getMessage(),
-					'level' => ILogger::ERROR,
-				]);
-			}
-		}
-	}
-
-	public function delegateEventListenerRegistrations(IEventDispatcher $eventDispatcher): void {
-		foreach ($this->eventListeners as $registration) {
-			try {
-				if (isset($registration['priority'])) {
-					$eventDispatcher->addServiceListener(
-						$registration['event'],
-						$registration['listener'],
-						$registration['priority']
-					);
-				} else {
-					$eventDispatcher->addServiceListener(
-						$registration['event'],
-						$registration['listener']
-					);
-				}
-			} catch (Throwable $e) {
-				$appId = $registration['appId'];
-				$this->logger->logException($e, [
-					'message' => "Error during event listener registration of $appId: " . $e->getMessage(),
-					'level' => ILogger::ERROR,
-				]);
-			}
-		}
-	}
-
-	/**
-	 * @param App[] $apps
-	 */
-	public function delegateContainerRegistrations(array $apps): void {
-		foreach ($this->services as $registration) {
-			try {
-				/**
-				 * Register the service and convert the callable into a \Closure if necessary
-				 */
-				$apps[$registration['appId']]
-					->getContainer()
-					->registerService(
-						$registration['name'],
-						Closure::fromCallable($registration['factory']),
-						$registration['shared'] ?? true
-					);
-			} catch (Throwable $e) {
-				$appId = $registration['appId'];
-				$this->logger->logException($e, [
-					'message' => "Error during service registration of $appId: " . $e->getMessage(),
-					'level' => ILogger::ERROR,
-				]);
-			}
-		}
-
-		foreach ($this->aliases as $registration) {
-			try {
-				$apps[$registration['appId']]
-					->getContainer()
-					->registerAlias(
-						$registration['alias'],
-						$registration['target']
-					);
-			} catch (Throwable $e) {
-				$appId = $registration['appId'];
-				$this->logger->logException($e, [
-					'message' => "Error during service alias registration of $appId: " . $e->getMessage(),
-					'level' => ILogger::ERROR,
-				]);
-			}
-		}
-
-		foreach ($this->parameters as $registration) {
-			try {
-				$apps[$registration['appId']]
-					->getContainer()
-					->registerParameter(
-						$registration['name'],
-						$registration['value']
-					);
-			} catch (Throwable $e) {
-				$appId = $registration['appId'];
-				$this->logger->logException($e, [
-					'message' => "Error during service alias registration of $appId: " . $e->getMessage(),
-					'level' => ILogger::ERROR,
-				]);
-			}
-		}
-	}
-
-	/**
-	 * @param App[] $apps
-	 */
-	public function delegateMiddlewareRegistrations(array $apps): void {
-		foreach ($this->middlewares as $middleware) {
-			try {
-				$apps[$middleware['appId']]
-					->getContainer()
-					->registerMiddleWare($middleware['class']);
-			} catch (Throwable $e) {
-				$appId = $middleware['appId'];
-				$this->logger->logException($e, [
-					'message' => "Error during capability registration of $appId: " . $e->getMessage(),
-					'level' => ILogger::ERROR,
-				]);
-			}
-		}
-	}
+    /** @var array[] */
+    private $capabilities = [];
+
+    /** @var array[] */
+    private $crashReporters = [];
+
+    /** @var array[] */
+    private $services = [];
+
+    /** @var array[] */
+    private $aliases = [];
+
+    /** @var array[] */
+    private $parameters = [];
+
+    /** @var array[] */
+    private $eventListeners = [];
+
+    /** @var array[] */
+    private $middlewares = [];
+
+    /** @var ILogger */
+    private $logger;
+
+    public function __construct(ILogger $logger) {
+        $this->logger = $logger;
+    }
+
+    public function for(string $appId): IRegistrationContext {
+        return new class($appId, $this) implements IRegistrationContext {
+            /** @var string */
+            private $appId;
+
+            /** @var RegistrationContext */
+            private $context;
+
+            public function __construct(string $appId, RegistrationContext $context) {
+                $this->appId = $appId;
+                $this->context = $context;
+            }
+
+            public function registerCapability(string $capability): void {
+                $this->context->registerCapability(
+                    $this->appId,
+                    $capability
+                );
+            }
+
+            public function registerCrashReporter(string $reporterClass): void {
+                $this->context->registerCrashReporter(
+                    $this->appId,
+                    $reporterClass
+                );
+            }
+
+            public function registerService(string $name, callable $factory, bool $shared = true): void {
+                $this->context->registerService(
+                    $this->appId,
+                    $name,
+                    $factory,
+                    $shared
+                );
+            }
+
+            public function registerServiceAlias(string $alias, string $target): void {
+                $this->context->registerServiceAlias(
+                    $this->appId,
+                    $alias,
+                    $target
+                );
+            }
+
+            public function registerParameter(string $name, $value): void {
+                $this->context->registerParameter(
+                    $this->appId,
+                    $name,
+                    $value
+                );
+            }
+
+            public function registerEventListener(string $event, string $listener, int $priority = 0): void {
+                $this->context->registerEventListener(
+                    $this->appId,
+                    $event,
+                    $listener,
+                    $priority
+                );
+            }
+
+            public function registerMiddleware(string $class): void {
+                $this->context->registerMiddleware(
+                    $this->appId,
+                    $class
+                );
+            }
+        };
+    }
+
+    public function registerCapability(string $appId, string $capability): void {
+        $this->capabilities[] = [
+            'appId' => $appId,
+            'capability' => $capability
+        ];
+    }
+
+    public function registerCrashReporter(string $appId, string $reporterClass): void {
+        $this->crashReporters[] = [
+            'appId' => $appId,
+            'class' => $reporterClass,
+        ];
+    }
+
+    public function registerService(string $appId, string $name, callable $factory, bool $shared = true): void {
+        $this->services[] = [
+            "appId" => $appId,
+            "name" => $name,
+            "factory" => $factory,
+            "sharred" => $shared,
+        ];
+    }
+
+    public function registerServiceAlias(string $appId, string $alias, string $target): void {
+        $this->aliases[] = [
+            "appId" => $appId,
+            "alias" => $alias,
+            "target" => $target,
+        ];
+    }
+
+    public function registerParameter(string $appId, string $name, $value): void {
+        $this->parameters[] = [
+            "appId" => $appId,
+            "name" => $name,
+            "value" => $value,
+        ];
+    }
+
+    public function registerEventListener(string $appId, string $event, string $listener, int $priority = 0): void {
+        $this->eventListeners[] = [
+            "appId" => $appId,
+            "event" => $event,
+            "listener" => $listener,
+            "priority" => $priority,
+        ];
+    }
+
+    public function registerMiddleware(string $appId, string $class): void {
+        $this->middlewares[] = [
+            "appId" => $appId,
+            "class" => $class,
+        ];
+    }
+
+    /**
+     * @param App[] $apps
+     */
+    public function delegateCapabilityRegistrations(array $apps): void {
+        foreach ($this->capabilities as $registration) {
+            try {
+                $apps[$registration['appId']]
+                    ->getContainer()
+                    ->registerCapability($registration['capability']);
+            } catch (Throwable $e) {
+                $appId = $registration['appId'];
+                $this->logger->logException($e, [
+                    'message' => "Error during capability registration of $appId: " . $e->getMessage(),
+                    'level' => ILogger::ERROR,
+                ]);
+            }
+        }
+    }
+
+    /**
+     * @param App[] $apps
+     */
+    public function delegateCrashReporterRegistrations(array $apps, Registry $registry): void {
+        foreach ($this->crashReporters as $registration) {
+            try {
+                $registry->registerLazy($registration['class']);
+            } catch (Throwable $e) {
+                $appId = $registration['appId'];
+                $this->logger->logException($e, [
+                    'message' => "Error during crash reporter registration of $appId: " . $e->getMessage(),
+                    'level' => ILogger::ERROR,
+                ]);
+            }
+        }
+    }
+
+    public function delegateEventListenerRegistrations(IEventDispatcher $eventDispatcher): void {
+        foreach ($this->eventListeners as $registration) {
+            try {
+                if (isset($registration['priority'])) {
+                    $eventDispatcher->addServiceListener(
+                        $registration['event'],
+                        $registration['listener'],
+                        $registration['priority']
+                    );
+                } else {
+                    $eventDispatcher->addServiceListener(
+                        $registration['event'],
+                        $registration['listener']
+                    );
+                }
+            } catch (Throwable $e) {
+                $appId = $registration['appId'];
+                $this->logger->logException($e, [
+                    'message' => "Error during event listener registration of $appId: " . $e->getMessage(),
+                    'level' => ILogger::ERROR,
+                ]);
+            }
+        }
+    }
+
+    /**
+     * @param App[] $apps
+     */
+    public function delegateContainerRegistrations(array $apps): void {
+        foreach ($this->services as $registration) {
+            try {
+                /**
+                 * Register the service and convert the callable into a \Closure if necessary
+                 */
+                $apps[$registration['appId']]
+                    ->getContainer()
+                    ->registerService(
+                        $registration['name'],
+                        Closure::fromCallable($registration['factory']),
+                        $registration['shared'] ?? true
+                    );
+            } catch (Throwable $e) {
+                $appId = $registration['appId'];
+                $this->logger->logException($e, [
+                    'message' => "Error during service registration of $appId: " . $e->getMessage(),
+                    'level' => ILogger::ERROR,
+                ]);
+            }
+        }
+
+        foreach ($this->aliases as $registration) {
+            try {
+                $apps[$registration['appId']]
+                    ->getContainer()
+                    ->registerAlias(
+                        $registration['alias'],
+                        $registration['target']
+                    );
+            } catch (Throwable $e) {
+                $appId = $registration['appId'];
+                $this->logger->logException($e, [
+                    'message' => "Error during service alias registration of $appId: " . $e->getMessage(),
+                    'level' => ILogger::ERROR,
+                ]);
+            }
+        }
+
+        foreach ($this->parameters as $registration) {
+            try {
+                $apps[$registration['appId']]
+                    ->getContainer()
+                    ->registerParameter(
+                        $registration['name'],
+                        $registration['value']
+                    );
+            } catch (Throwable $e) {
+                $appId = $registration['appId'];
+                $this->logger->logException($e, [
+                    'message' => "Error during service alias registration of $appId: " . $e->getMessage(),
+                    'level' => ILogger::ERROR,
+                ]);
+            }
+        }
+    }
+
+    /**
+     * @param App[] $apps
+     */
+    public function delegateMiddlewareRegistrations(array $apps): void {
+        foreach ($this->middlewares as $middleware) {
+            try {
+                $apps[$middleware['appId']]
+                    ->getContainer()
+                    ->registerMiddleWare($middleware['class']);
+            } catch (Throwable $e) {
+                $appId = $middleware['appId'];
+                $this->logger->logException($e, [
+                    'message' => "Error during capability registration of $appId: " . $e->getMessage(),
+                    'level' => ILogger::ERROR,
+                ]);
+            }
+        }
+    }
 }

Please login to merge, or discard this patch.

		@@ -35,296 +35,296 @@
		block discarded – undo
35	35
36	36	class RegistrationContext {
37	37
38		- /** @var array[] */
39		- private $capabilities = [];
40		-
41		- /** @var array[] */
42		- private $crashReporters = [];
43		-
44		- /** @var array[] */
45		- private $services = [];
46		-
47		- /** @var array[] */
48		- private $aliases = [];
49		-
50		- /** @var array[] */
51		- private $parameters = [];
52		-
53		- /** @var array[] */
54		- private $eventListeners = [];
55		-
56		- /** @var array[] */
57		- private $middlewares = [];
58		-
59		- /** @var ILogger */
60		- private $logger;
61		-
62		- public function __construct(ILogger $logger) {
63		- $this->logger = $logger;
64		- }
65		-
66		- public function for(string $appId): IRegistrationContext {
67		- return new class($appId, $this) implements IRegistrationContext {
68		- /** @var string */
69		- private $appId;
70		-
71		- /** @var RegistrationContext */
72		- private $context;
73		-
74		- public function __construct(string $appId, RegistrationContext $context) {
75		- $this->appId = $appId;
76		- $this->context = $context;
77		- }
78		-
79		- public function registerCapability(string $capability): void {
80		- $this->context->registerCapability(
81		- $this->appId,
82		- $capability
83		- );
84		- }
85		-
86		- public function registerCrashReporter(string $reporterClass): void {
87		- $this->context->registerCrashReporter(
88		- $this->appId,
89		- $reporterClass
90		- );
91		- }
92		-
93		- public function registerService(string $name, callable $factory, bool $shared = true): void {
94		- $this->context->registerService(
95		- $this->appId,
96		- $name,
97		- $factory,
98		- $shared
99		- );
100		- }
101		-
102		- public function registerServiceAlias(string $alias, string $target): void {
103		- $this->context->registerServiceAlias(
104		- $this->appId,
105		- $alias,
106		- $target
107		- );
108		- }
109		-
110		- public function registerParameter(string $name, $value): void {
111		- $this->context->registerParameter(
112		- $this->appId,
113		- $name,
114		- $value
115		- );
116		- }
117		-
118		- public function registerEventListener(string $event, string $listener, int $priority = 0): void {
119		- $this->context->registerEventListener(
120		- $this->appId,
121		- $event,
122		- $listener,
123		- $priority
124		- );
125		- }
126		-
127		- public function registerMiddleware(string $class): void {
128		- $this->context->registerMiddleware(
129		- $this->appId,
130		- $class
131		- );
132		- }
133		- };
134		- }
135		-
136		- public function registerCapability(string $appId, string $capability): void {
137		- $this->capabilities[] = [
138		- 'appId' => $appId,
139		- 'capability' => $capability
140		- ];
141		- }
142		-
143		- public function registerCrashReporter(string $appId, string $reporterClass): void {
144		- $this->crashReporters[] = [
145		- 'appId' => $appId,
146		- 'class' => $reporterClass,
147		- ];
148		- }
149		-
150		- public function registerService(string $appId, string $name, callable $factory, bool $shared = true): void {
151		- $this->services[] = [
152		- "appId" => $appId,
153		- "name" => $name,
154		- "factory" => $factory,
155		- "sharred" => $shared,
156		- ];
157		- }
158		-
159		- public function registerServiceAlias(string $appId, string $alias, string $target): void {
160		- $this->aliases[] = [
161		- "appId" => $appId,
162		- "alias" => $alias,
163		- "target" => $target,
164		- ];
165		- }
166		-
167		- public function registerParameter(string $appId, string $name, $value): void {
168		- $this->parameters[] = [
169		- "appId" => $appId,
170		- "name" => $name,
171		- "value" => $value,
172		- ];
173		- }
174		-
175		- public function registerEventListener(string $appId, string $event, string $listener, int $priority = 0): void {
176		- $this->eventListeners[] = [
177		- "appId" => $appId,
178		- "event" => $event,
179		- "listener" => $listener,
180		- "priority" => $priority,
181		- ];
182		- }
183		-
184		- public function registerMiddleware(string $appId, string $class): void {
185		- $this->middlewares[] = [
186		- "appId" => $appId,
187		- "class" => $class,
188		- ];
189		- }
190		-
191		- /**
192		- * @param App[] $apps
193		- */
194		- public function delegateCapabilityRegistrations(array $apps): void {
195		- foreach ($this->capabilities as $registration) {
196		- try {
197		- $apps[$registration['appId']]
198		- ->getContainer()
199		- ->registerCapability($registration['capability']);
200		- } catch (Throwable $e) {
201		- $appId = $registration['appId'];
202		- $this->logger->logException($e, [
203		- 'message' => "Error during capability registration of $appId: " . $e->getMessage(),
204		- 'level' => ILogger::ERROR,
205		- ]);
206		- }
207		- }
208		- }
209		-
210		- /**
211		- * @param App[] $apps
212		- */
213		- public function delegateCrashReporterRegistrations(array $apps, Registry $registry): void {
214		- foreach ($this->crashReporters as $registration) {
215		- try {
216		- $registry->registerLazy($registration['class']);
217		- } catch (Throwable $e) {
218		- $appId = $registration['appId'];
219		- $this->logger->logException($e, [
220		- 'message' => "Error during crash reporter registration of $appId: " . $e->getMessage(),
221		- 'level' => ILogger::ERROR,
222		- ]);
223		- }
224		- }
225		- }
226		-
227		- public function delegateEventListenerRegistrations(IEventDispatcher $eventDispatcher): void {
228		- foreach ($this->eventListeners as $registration) {
229		- try {
230		- if (isset($registration['priority'])) {
231		- $eventDispatcher->addServiceListener(
232		- $registration['event'],
233		- $registration['listener'],
234		- $registration['priority']
235		- );
236		- } else {
237		- $eventDispatcher->addServiceListener(
238		- $registration['event'],
239		- $registration['listener']
240		- );
241		- }
242		- } catch (Throwable $e) {
243		- $appId = $registration['appId'];
244		- $this->logger->logException($e, [
245		- 'message' => "Error during event listener registration of $appId: " . $e->getMessage(),
246		- 'level' => ILogger::ERROR,
247		- ]);
248		- }
249		- }
250		- }
251		-
252		- /**
253		- * @param App[] $apps
254		- */
255		- public function delegateContainerRegistrations(array $apps): void {
256		- foreach ($this->services as $registration) {
257		- try {
258		- /**
259		- * Register the service and convert the callable into a \Closure if necessary
260		- */
261		- $apps[$registration['appId']]
262		- ->getContainer()
263		- ->registerService(
264		- $registration['name'],
265		- Closure::fromCallable($registration['factory']),
266		- $registration['shared'] ?? true
267		- );
268		- } catch (Throwable $e) {
269		- $appId = $registration['appId'];
270		- $this->logger->logException($e, [
271		- 'message' => "Error during service registration of $appId: " . $e->getMessage(),
272		- 'level' => ILogger::ERROR,
273		- ]);
274		- }
275		- }
276		-
277		- foreach ($this->aliases as $registration) {
278		- try {
279		- $apps[$registration['appId']]
280		- ->getContainer()
281		- ->registerAlias(
282		- $registration['alias'],
283		- $registration['target']
284		- );
285		- } catch (Throwable $e) {
286		- $appId = $registration['appId'];
287		- $this->logger->logException($e, [
288		- 'message' => "Error during service alias registration of $appId: " . $e->getMessage(),
289		- 'level' => ILogger::ERROR,
290		- ]);
291		- }
292		- }
293		-
294		- foreach ($this->parameters as $registration) {
295		- try {
296		- $apps[$registration['appId']]
297		- ->getContainer()
298		- ->registerParameter(
299		- $registration['name'],
300		- $registration['value']
301		- );
302		- } catch (Throwable $e) {
303		- $appId = $registration['appId'];
304		- $this->logger->logException($e, [
305		- 'message' => "Error during service alias registration of $appId: " . $e->getMessage(),
306		- 'level' => ILogger::ERROR,
307		- ]);
308		- }
309		- }
310		- }
311		-
312		- /**
313		- * @param App[] $apps
314		- */
315		- public function delegateMiddlewareRegistrations(array $apps): void {
316		- foreach ($this->middlewares as $middleware) {
317		- try {
318		- $apps[$middleware['appId']]
319		- ->getContainer()
320		- ->registerMiddleWare($middleware['class']);
321		- } catch (Throwable $e) {
322		- $appId = $middleware['appId'];
323		- $this->logger->logException($e, [
324		- 'message' => "Error during capability registration of $appId: " . $e->getMessage(),
325		- 'level' => ILogger::ERROR,
326		- ]);
327		- }
328		- }
329		- }
	38	+ /** @var array[] */
	39	+ private $capabilities = [];
	40	+
	41	+ /** @var array[] */
	42	+ private $crashReporters = [];
	43	+
	44	+ /** @var array[] */
	45	+ private $services = [];
	46	+
	47	+ /** @var array[] */
	48	+ private $aliases = [];
	49	+
	50	+ /** @var array[] */
	51	+ private $parameters = [];
	52	+
	53	+ /** @var array[] */
	54	+ private $eventListeners = [];
	55	+
	56	+ /** @var array[] */
	57	+ private $middlewares = [];
	58	+
	59	+ /** @var ILogger */
	60	+ private $logger;
	61	+
	62	+ public function __construct(ILogger $logger) {
	63	+ $this->logger = $logger;
	64	+ }
	65	+
	66	+ public function for(string $appId): IRegistrationContext {
	67	+ return new class($appId, $this) implements IRegistrationContext {
	68	+ /** @var string */
	69	+ private $appId;
	70	+
	71	+ /** @var RegistrationContext */
	72	+ private $context;
	73	+
	74	+ public function __construct(string $appId, RegistrationContext $context) {
	75	+ $this->appId = $appId;
	76	+ $this->context = $context;
	77	+ }
	78	+
	79	+ public function registerCapability(string $capability): void {
	80	+ $this->context->registerCapability(
	81	+ $this->appId,
	82	+ $capability
	83	+ );
	84	+ }
	85	+
	86	+ public function registerCrashReporter(string $reporterClass): void {
	87	+ $this->context->registerCrashReporter(
	88	+ $this->appId,
	89	+ $reporterClass
	90	+ );
	91	+ }
	92	+
	93	+ public function registerService(string $name, callable $factory, bool $shared = true): void {
	94	+ $this->context->registerService(
	95	+ $this->appId,
	96	+ $name,
	97	+ $factory,
	98	+ $shared
	99	+ );
	100	+ }
	101	+
	102	+ public function registerServiceAlias(string $alias, string $target): void {
	103	+ $this->context->registerServiceAlias(
	104	+ $this->appId,
	105	+ $alias,
	106	+ $target
	107	+ );
	108	+ }
	109	+
	110	+ public function registerParameter(string $name, $value): void {
	111	+ $this->context->registerParameter(
	112	+ $this->appId,
	113	+ $name,
	114	+ $value
	115	+ );
	116	+ }
	117	+
	118	+ public function registerEventListener(string $event, string $listener, int $priority = 0): void {
	119	+ $this->context->registerEventListener(
	120	+ $this->appId,
	121	+ $event,
	122	+ $listener,
	123	+ $priority
	124	+ );
	125	+ }
	126	+
	127	+ public function registerMiddleware(string $class): void {
	128	+ $this->context->registerMiddleware(
	129	+ $this->appId,
	130	+ $class
	131	+ );
	132	+ }
	133	+ };
	134	+ }
	135	+
	136	+ public function registerCapability(string $appId, string $capability): void {
	137	+ $this->capabilities[] = [
	138	+ 'appId' => $appId,
	139	+ 'capability' => $capability
	140	+ ];
	141	+ }
	142	+
	143	+ public function registerCrashReporter(string $appId, string $reporterClass): void {
	144	+ $this->crashReporters[] = [
	145	+ 'appId' => $appId,
	146	+ 'class' => $reporterClass,
	147	+ ];
	148	+ }
	149	+
	150	+ public function registerService(string $appId, string $name, callable $factory, bool $shared = true): void {
	151	+ $this->services[] = [
	152	+ "appId" => $appId,
	153	+ "name" => $name,
	154	+ "factory" => $factory,
	155	+ "sharred" => $shared,
	156	+ ];
	157	+ }
	158	+
	159	+ public function registerServiceAlias(string $appId, string $alias, string $target): void {
	160	+ $this->aliases[] = [
	161	+ "appId" => $appId,
	162	+ "alias" => $alias,
	163	+ "target" => $target,
	164	+ ];
	165	+ }
	166	+
	167	+ public function registerParameter(string $appId, string $name, $value): void {
	168	+ $this->parameters[] = [
	169	+ "appId" => $appId,
	170	+ "name" => $name,
	171	+ "value" => $value,
	172	+ ];
	173	+ }
	174	+
	175	+ public function registerEventListener(string $appId, string $event, string $listener, int $priority = 0): void {
	176	+ $this->eventListeners[] = [
	177	+ "appId" => $appId,
	178	+ "event" => $event,
	179	+ "listener" => $listener,
	180	+ "priority" => $priority,
	181	+ ];
	182	+ }
	183	+
	184	+ public function registerMiddleware(string $appId, string $class): void {
	185	+ $this->middlewares[] = [
	186	+ "appId" => $appId,
	187	+ "class" => $class,
	188	+ ];
	189	+ }
	190	+
	191	+ /**
	192	+ * @param App[] $apps
	193	+ */
	194	+ public function delegateCapabilityRegistrations(array $apps): void {
	195	+ foreach ($this->capabilities as $registration) {
	196	+ try {
	197	+ $apps[$registration['appId']]
	198	+ ->getContainer()
	199	+ ->registerCapability($registration['capability']);
	200	+ } catch (Throwable $e) {
	201	+ $appId = $registration['appId'];
	202	+ $this->logger->logException($e, [
	203	+ 'message' => "Error during capability registration of $appId: " . $e->getMessage(),
	204	+ 'level' => ILogger::ERROR,
	205	+ ]);
	206	+ }
	207	+ }
	208	+ }
	209	+
	210	+ /**
	211	+ * @param App[] $apps
	212	+ */
	213	+ public function delegateCrashReporterRegistrations(array $apps, Registry $registry): void {
	214	+ foreach ($this->crashReporters as $registration) {
	215	+ try {
	216	+ $registry->registerLazy($registration['class']);
	217	+ } catch (Throwable $e) {
	218	+ $appId = $registration['appId'];
	219	+ $this->logger->logException($e, [
	220	+ 'message' => "Error during crash reporter registration of $appId: " . $e->getMessage(),
	221	+ 'level' => ILogger::ERROR,
	222	+ ]);
	223	+ }
	224	+ }
	225	+ }
	226	+
	227	+ public function delegateEventListenerRegistrations(IEventDispatcher $eventDispatcher): void {
	228	+ foreach ($this->eventListeners as $registration) {
	229	+ try {
	230	+ if (isset($registration['priority'])) {
	231	+ $eventDispatcher->addServiceListener(
	232	+ $registration['event'],
	233	+ $registration['listener'],
	234	+ $registration['priority']
	235	+ );
	236	+ } else {
	237	+ $eventDispatcher->addServiceListener(
	238	+ $registration['event'],
	239	+ $registration['listener']
	240	+ );
	241	+ }
	242	+ } catch (Throwable $e) {
	243	+ $appId = $registration['appId'];
	244	+ $this->logger->logException($e, [
	245	+ 'message' => "Error during event listener registration of $appId: " . $e->getMessage(),
	246	+ 'level' => ILogger::ERROR,
	247	+ ]);
	248	+ }
	249	+ }
	250	+ }
	251	+
	252	+ /**
	253	+ * @param App[] $apps
	254	+ */
	255	+ public function delegateContainerRegistrations(array $apps): void {
	256	+ foreach ($this->services as $registration) {
	257	+ try {
	258	+ /**
	259	+ * Register the service and convert the callable into a \Closure if necessary
	260	+ */
	261	+ $apps[$registration['appId']]
	262	+ ->getContainer()
	263	+ ->registerService(
	264	+ $registration['name'],
	265	+ Closure::fromCallable($registration['factory']),
	266	+ $registration['shared'] ?? true
	267	+ );
	268	+ } catch (Throwable $e) {
	269	+ $appId = $registration['appId'];
	270	+ $this->logger->logException($e, [
	271	+ 'message' => "Error during service registration of $appId: " . $e->getMessage(),
	272	+ 'level' => ILogger::ERROR,
	273	+ ]);
	274	+ }
	275	+ }
	276	+
	277	+ foreach ($this->aliases as $registration) {
	278	+ try {
	279	+ $apps[$registration['appId']]
	280	+ ->getContainer()
	281	+ ->registerAlias(
	282	+ $registration['alias'],
	283	+ $registration['target']
	284	+ );
	285	+ } catch (Throwable $e) {
	286	+ $appId = $registration['appId'];
	287	+ $this->logger->logException($e, [
	288	+ 'message' => "Error during service alias registration of $appId: " . $e->getMessage(),
	289	+ 'level' => ILogger::ERROR,
	290	+ ]);
	291	+ }
	292	+ }
	293	+
	294	+ foreach ($this->parameters as $registration) {
	295	+ try {
	296	+ $apps[$registration['appId']]
	297	+ ->getContainer()
	298	+ ->registerParameter(
	299	+ $registration['name'],
	300	+ $registration['value']
	301	+ );
	302	+ } catch (Throwable $e) {
	303	+ $appId = $registration['appId'];
	304	+ $this->logger->logException($e, [
	305	+ 'message' => "Error during service alias registration of $appId: " . $e->getMessage(),
	306	+ 'level' => ILogger::ERROR,
	307	+ ]);
	308	+ }
	309	+ }
	310	+ }
	311	+
	312	+ /**
	313	+ * @param App[] $apps
	314	+ */
	315	+ public function delegateMiddlewareRegistrations(array $apps): void {
	316	+ foreach ($this->middlewares as $middleware) {
	317	+ try {
	318	+ $apps[$middleware['appId']]
	319	+ ->getContainer()
	320	+ ->registerMiddleWare($middleware['class']);
	321	+ } catch (Throwable $e) {
	322	+ $appId = $middleware['appId'];
	323	+ $this->logger->logException($e, [
	324	+ 'message' => "Error during capability registration of $appId: " . $e->getMessage(),
	325	+ 'level' => ILogger::ERROR,
	326	+ ]);
	327	+ }
	328	+ }
	329	+ }
330	330	}

nextcloud / server

Push — master ( 59093a...6ec804 )

Status

Category

Indentation +292 added lines, -292 removed lines patch added patch discarded remove patch