Inspection of "Merge pull request #9846 from nextcloud/feature/no..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e2795b...90f9e0 )

by John

created 2018-06-13 21:19 UTC

Status

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch

@@ -42,53 +42,53 @@
 block discarded – undo
  * @deprecated 14.0.0 Use one of our stricter CSP policies
  */
 class ContentSecurityPolicy extends EmptyContentSecurityPolicy {
-	/** @var bool Whether inline JS snippets are allowed */
-	protected $inlineScriptAllowed = false;
-	/**
-	 * @var bool Whether eval in JS scripts is allowed
-	 * TODO: Disallow per default
-	 * @link https://github.com/owncloud/core/issues/11925
-	 */
-	protected $evalScriptAllowed = true;
-	/** @var array Domains from which scripts can get loaded */
-	protected $allowedScriptDomains = [
-		'\'self\'',
-	];
-	/**
-	 * @var bool Whether inline CSS is allowed
-	 * TODO: Disallow per default
-	 * @link https://github.com/owncloud/core/issues/13458
-	 */
-	protected $inlineStyleAllowed = true;
-	/** @var array Domains from which CSS can get loaded */
-	protected $allowedStyleDomains = [
-		'\'self\'',
-	];
-	/** @var array Domains from which images can get loaded */
-	protected $allowedImageDomains = [
-		'\'self\'',
-		'data:',
-		'blob:',
-	];
-	/** @var array Domains to which connections can be done */
-	protected $allowedConnectDomains = [
-		'\'self\'',
-	];
-	/** @var array Domains from which media elements can be loaded */
-	protected $allowedMediaDomains = [
-		'\'self\'',
-	];
-	/** @var array Domains from which object elements can be loaded */
-	protected $allowedObjectDomains = [];
-	/** @var array Domains from which iframes can be loaded */
-	protected $allowedFrameDomains = [];
-	/** @var array Domains from which fonts can be loaded */
-	protected $allowedFontDomains = [
-		'\'self\'',
-	];
-	/** @var array Domains from which web-workers and nested browsing content can load elements */
-	protected $allowedChildSrcDomains = [];
+    /** @var bool Whether inline JS snippets are allowed */
+    protected $inlineScriptAllowed = false;
+    /**
+     * @var bool Whether eval in JS scripts is allowed
+     * TODO: Disallow per default
+     * @link https://github.com/owncloud/core/issues/11925
+     */
+    protected $evalScriptAllowed = true;
+    /** @var array Domains from which scripts can get loaded */
+    protected $allowedScriptDomains = [
+        '\'self\'',
+    ];
+    /**
+     * @var bool Whether inline CSS is allowed
+     * TODO: Disallow per default
+     * @link https://github.com/owncloud/core/issues/13458
+     */
+    protected $inlineStyleAllowed = true;
+    /** @var array Domains from which CSS can get loaded */
+    protected $allowedStyleDomains = [
+        '\'self\'',
+    ];
+    /** @var array Domains from which images can get loaded */
+    protected $allowedImageDomains = [
+        '\'self\'',
+        'data:',
+        'blob:',
+    ];
+    /** @var array Domains to which connections can be done */
+    protected $allowedConnectDomains = [
+        '\'self\'',
+    ];
+    /** @var array Domains from which media elements can be loaded */
+    protected $allowedMediaDomains = [
+        '\'self\'',
+    ];
+    /** @var array Domains from which object elements can be loaded */
+    protected $allowedObjectDomains = [];
+    /** @var array Domains from which iframes can be loaded */
+    protected $allowedFrameDomains = [];
+    /** @var array Domains from which fonts can be loaded */
+    protected $allowedFontDomains = [
+        '\'self\'',
+    ];
+    /** @var array Domains from which web-workers and nested browsing content can load elements */
+    protected $allowedChildSrcDomains = [];
 
-	/** @var array Domains which can embed this Nextcloud instance */
-	protected $allowedFrameAncestors = [];
+    /** @var array Domains which can embed this Nextcloud instance */
+    protected $allowedFrameAncestors = [];
 }

Please login to merge, or discard this patch.

lib/public/AppFramework/Http/StrictContentSecurityPolicy.php 1 patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

@@ -41,45 +41,45 @@
 block discarded – undo
  * @since 14.0.0
  */
 class StrictContentSecurityPolicy extends EmptyContentSecurityPolicy {
-	/** @var bool Whether inline JS snippets are allowed */
-	protected $inlineScriptAllowed = false;
-	/** @var bool Whether eval in JS scripts is allowed */
-	protected $evalScriptAllowed = false;
-	/** @var array Domains from which scripts can get loaded */
-	protected $allowedScriptDomains = [
-		'\'self\'',
-	];
-	/** @var bool Whether inline CSS is allowed */
-	protected $inlineStyleAllowed = false;
-	/** @var array Domains from which CSS can get loaded */
-	protected $allowedStyleDomains = [
-		'\'self\'',
-	];
-	/** @var array Domains from which images can get loaded */
-	protected $allowedImageDomains = [
-		'\'self\'',
-		'data:',
-		'blob:',
-	];
-	/** @var array Domains to which connections can be done */
-	protected $allowedConnectDomains = [
-		'\'self\'',
-	];
-	/** @var array Domains from which media elements can be loaded */
-	protected $allowedMediaDomains = [
-		'\'self\'',
-	];
-	/** @var array Domains from which object elements can be loaded */
-	protected $allowedObjectDomains = [];
-	/** @var array Domains from which iframes can be loaded */
-	protected $allowedFrameDomains = [];
-	/** @var array Domains from which fonts can be loaded */
-	protected $allowedFontDomains = [
-		'\'self\'',
-	];
-	/** @var array Domains from which web-workers and nested browsing content can load elements */
-	protected $allowedChildSrcDomains = [];
+    /** @var bool Whether inline JS snippets are allowed */
+    protected $inlineScriptAllowed = false;
+    /** @var bool Whether eval in JS scripts is allowed */
+    protected $evalScriptAllowed = false;
+    /** @var array Domains from which scripts can get loaded */
+    protected $allowedScriptDomains = [
+        '\'self\'',
+    ];
+    /** @var bool Whether inline CSS is allowed */
+    protected $inlineStyleAllowed = false;
+    /** @var array Domains from which CSS can get loaded */
+    protected $allowedStyleDomains = [
+        '\'self\'',
+    ];
+    /** @var array Domains from which images can get loaded */
+    protected $allowedImageDomains = [
+        '\'self\'',
+        'data:',
+        'blob:',
+    ];
+    /** @var array Domains to which connections can be done */
+    protected $allowedConnectDomains = [
+        '\'self\'',
+    ];
+    /** @var array Domains from which media elements can be loaded */
+    protected $allowedMediaDomains = [
+        '\'self\'',
+    ];
+    /** @var array Domains from which object elements can be loaded */
+    protected $allowedObjectDomains = [];
+    /** @var array Domains from which iframes can be loaded */
+    protected $allowedFrameDomains = [];
+    /** @var array Domains from which fonts can be loaded */
+    protected $allowedFontDomains = [
+        '\'self\'',
+    ];
+    /** @var array Domains from which web-workers and nested browsing content can load elements */
+    protected $allowedChildSrcDomains = [];
 
-	/** @var array Domains which can embed this Nextcloud instance */
-	protected $allowedFrameAncestors = [];
+    /** @var array Domains which can embed this Nextcloud instance */
+    protected $allowedFrameAncestors = [];
 }

Please login to merge, or discard this patch.

lib/public/AppFramework/Http/StrictEvalContentSecurityPolicy.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -42,10 +42,10 @@
 block discarded – undo
  */
 class StrictEvalContentSecurityPolicy extends ContentSecurityPolicy {
 
-	/**
-	 * @since 14.0.0
-	 */
-	public function __construct() {
-		$this->inlineStyleAllowed = false;
-	}
+    /**
+     * @since 14.0.0
+     */
+    public function __construct() {
+        $this->inlineStyleAllowed = false;
+    }
 }

Please login to merge, or discard this patch.

lib/public/AppFramework/Http/StrictInlineContentSecurityPolicy.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -42,10 +42,10 @@
 block discarded – undo
  */
 class StrictInlineContentSecurityPolicy extends ContentSecurityPolicy {
 
-	/**
-	 * @since 14.0.0
-	 */
-	public function __construct() {
-		$this->inlineStyleAllowed = false;
-	}
+    /**
+     * @since 14.0.0
+     */
+    public function __construct() {
+        $this->inlineStyleAllowed = false;
+    }
 }

Please login to merge, or discard this patch.

		@@ -42,53 +42,53 @@
		block discarded – undo
42	42	* @deprecated 14.0.0 Use one of our stricter CSP policies
43	43	*/
44	44	class ContentSecurityPolicy extends EmptyContentSecurityPolicy {
45		- /** @var bool Whether inline JS snippets are allowed */
46		- protected $inlineScriptAllowed = false;
47		- /**
48		- * @var bool Whether eval in JS scripts is allowed
49		- * TODO: Disallow per default
50		- * @link https://github.com/owncloud/core/issues/11925
51		- */
52		- protected $evalScriptAllowed = true;
53		- /** @var array Domains from which scripts can get loaded */
54		- protected $allowedScriptDomains = [
55		- '\'self\'',
56		- ];
57		- /**
58		- * @var bool Whether inline CSS is allowed
59		- * TODO: Disallow per default
60		- * @link https://github.com/owncloud/core/issues/13458
61		- */
62		- protected $inlineStyleAllowed = true;
63		- /** @var array Domains from which CSS can get loaded */
64		- protected $allowedStyleDomains = [
65		- '\'self\'',
66		- ];
67		- /** @var array Domains from which images can get loaded */
68		- protected $allowedImageDomains = [
69		- '\'self\'',
70		- 'data:',
71		- 'blob:',
72		- ];
73		- /** @var array Domains to which connections can be done */
74		- protected $allowedConnectDomains = [
75		- '\'self\'',
76		- ];
77		- /** @var array Domains from which media elements can be loaded */
78		- protected $allowedMediaDomains = [
79		- '\'self\'',
80		- ];
81		- /** @var array Domains from which object elements can be loaded */
82		- protected $allowedObjectDomains = [];
83		- /** @var array Domains from which iframes can be loaded */
84		- protected $allowedFrameDomains = [];
85		- /** @var array Domains from which fonts can be loaded */
86		- protected $allowedFontDomains = [
87		- '\'self\'',
88		- ];
89		- /** @var array Domains from which web-workers and nested browsing content can load elements */
90		- protected $allowedChildSrcDomains = [];
	45	+ /** @var bool Whether inline JS snippets are allowed */
	46	+ protected $inlineScriptAllowed = false;
	47	+ /**
	48	+ * @var bool Whether eval in JS scripts is allowed
	49	+ * TODO: Disallow per default
	50	+ * @link https://github.com/owncloud/core/issues/11925
	51	+ */
	52	+ protected $evalScriptAllowed = true;
	53	+ /** @var array Domains from which scripts can get loaded */
	54	+ protected $allowedScriptDomains = [
	55	+ '\'self\'',
	56	+ ];
	57	+ /**
	58	+ * @var bool Whether inline CSS is allowed
	59	+ * TODO: Disallow per default
	60	+ * @link https://github.com/owncloud/core/issues/13458
	61	+ */
	62	+ protected $inlineStyleAllowed = true;
	63	+ /** @var array Domains from which CSS can get loaded */
	64	+ protected $allowedStyleDomains = [
	65	+ '\'self\'',
	66	+ ];
	67	+ /** @var array Domains from which images can get loaded */
	68	+ protected $allowedImageDomains = [
	69	+ '\'self\'',
	70	+ 'data:',
	71	+ 'blob:',
	72	+ ];
	73	+ /** @var array Domains to which connections can be done */
	74	+ protected $allowedConnectDomains = [
	75	+ '\'self\'',
	76	+ ];
	77	+ /** @var array Domains from which media elements can be loaded */
	78	+ protected $allowedMediaDomains = [
	79	+ '\'self\'',
	80	+ ];
	81	+ /** @var array Domains from which object elements can be loaded */
	82	+ protected $allowedObjectDomains = [];
	83	+ /** @var array Domains from which iframes can be loaded */
	84	+ protected $allowedFrameDomains = [];
	85	+ /** @var array Domains from which fonts can be loaded */
	86	+ protected $allowedFontDomains = [
	87	+ '\'self\'',
	88	+ ];
	89	+ /** @var array Domains from which web-workers and nested browsing content can load elements */
	90	+ protected $allowedChildSrcDomains = [];
91	91
92		- /** @var array Domains which can embed this Nextcloud instance */
93		- protected $allowedFrameAncestors = [];
	92	+ /** @var array Domains which can embed this Nextcloud instance */
	93	+ protected $allowedFrameAncestors = [];
94	94	}

		@@ -41,45 +41,45 @@
		block discarded – undo
41	41	* @since 14.0.0
42	42	*/
43	43	class StrictContentSecurityPolicy extends EmptyContentSecurityPolicy {
44		- /** @var bool Whether inline JS snippets are allowed */
45		- protected $inlineScriptAllowed = false;
46		- /** @var bool Whether eval in JS scripts is allowed */
47		- protected $evalScriptAllowed = false;
48		- /** @var array Domains from which scripts can get loaded */
49		- protected $allowedScriptDomains = [
50		- '\'self\'',
51		- ];
52		- /** @var bool Whether inline CSS is allowed */
53		- protected $inlineStyleAllowed = false;
54		- /** @var array Domains from which CSS can get loaded */
55		- protected $allowedStyleDomains = [
56		- '\'self\'',
57		- ];
58		- /** @var array Domains from which images can get loaded */
59		- protected $allowedImageDomains = [
60		- '\'self\'',
61		- 'data:',
62		- 'blob:',
63		- ];
64		- /** @var array Domains to which connections can be done */
65		- protected $allowedConnectDomains = [
66		- '\'self\'',
67		- ];
68		- /** @var array Domains from which media elements can be loaded */
69		- protected $allowedMediaDomains = [
70		- '\'self\'',
71		- ];
72		- /** @var array Domains from which object elements can be loaded */
73		- protected $allowedObjectDomains = [];
74		- /** @var array Domains from which iframes can be loaded */
75		- protected $allowedFrameDomains = [];
76		- /** @var array Domains from which fonts can be loaded */
77		- protected $allowedFontDomains = [
78		- '\'self\'',
79		- ];
80		- /** @var array Domains from which web-workers and nested browsing content can load elements */
81		- protected $allowedChildSrcDomains = [];
	44	+ /** @var bool Whether inline JS snippets are allowed */
	45	+ protected $inlineScriptAllowed = false;
	46	+ /** @var bool Whether eval in JS scripts is allowed */
	47	+ protected $evalScriptAllowed = false;
	48	+ /** @var array Domains from which scripts can get loaded */
	49	+ protected $allowedScriptDomains = [
	50	+ '\'self\'',
	51	+ ];
	52	+ /** @var bool Whether inline CSS is allowed */
	53	+ protected $inlineStyleAllowed = false;
	54	+ /** @var array Domains from which CSS can get loaded */
	55	+ protected $allowedStyleDomains = [
	56	+ '\'self\'',
	57	+ ];
	58	+ /** @var array Domains from which images can get loaded */
	59	+ protected $allowedImageDomains = [
	60	+ '\'self\'',
	61	+ 'data:',
	62	+ 'blob:',
	63	+ ];
	64	+ /** @var array Domains to which connections can be done */
	65	+ protected $allowedConnectDomains = [
	66	+ '\'self\'',
	67	+ ];
	68	+ /** @var array Domains from which media elements can be loaded */
	69	+ protected $allowedMediaDomains = [
	70	+ '\'self\'',
	71	+ ];
	72	+ /** @var array Domains from which object elements can be loaded */
	73	+ protected $allowedObjectDomains = [];
	74	+ /** @var array Domains from which iframes can be loaded */
	75	+ protected $allowedFrameDomains = [];
	76	+ /** @var array Domains from which fonts can be loaded */
	77	+ protected $allowedFontDomains = [
	78	+ '\'self\'',
	79	+ ];
	80	+ /** @var array Domains from which web-workers and nested browsing content can load elements */
	81	+ protected $allowedChildSrcDomains = [];
82	82
83		- /** @var array Domains which can embed this Nextcloud instance */
84		- protected $allowedFrameAncestors = [];
	83	+ /** @var array Domains which can embed this Nextcloud instance */
	84	+ protected $allowedFrameAncestors = [];
85	85	}

		@@ -42,10 +42,10 @@
		block discarded – undo
42	42	*/
43	43	class StrictEvalContentSecurityPolicy extends ContentSecurityPolicy {
44	44
45		- /**
46		- * @since 14.0.0
47		- */
48		- public function __construct() {
49		- $this->inlineStyleAllowed = false;
50		- }
	45	+ /**
	46	+ * @since 14.0.0
	47	+ */
	48	+ public function __construct() {
	49	+ $this->inlineStyleAllowed = false;
	50	+ }
51	51	}

		@@ -42,10 +42,10 @@
		block discarded – undo
42	42	*/
43	43	class StrictInlineContentSecurityPolicy extends ContentSecurityPolicy {
44	44
45		- /**
46		- * @since 14.0.0
47		- */
48		- public function __construct() {
49		- $this->inlineStyleAllowed = false;
50		- }
	45	+ /**
	46	+ * @since 14.0.0
	47	+ */
	48	+ public function __construct() {
	49	+ $this->inlineStyleAllowed = false;
	50	+ }
51	51	}

nextcloud / server

Push — master ( e2795b...90f9e0 )

Status

Category

Indentation +48 added lines, -48 removed lines patch added patch discarded remove patch

Indentation +40 added lines, -40 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch