nextcloud / server

lib/private/Image.php

Indentation +1114 added lines, -1114 removed lines

@@ -22,719 +22,719 @@ 
  * Class for basic image manipulation
  */
 class Image implements IImage {
-	// Default memory limit for images to load (256 MBytes).
-	protected const DEFAULT_MEMORY_LIMIT = 256;
-
-	// Default quality for jpeg images
-	protected const DEFAULT_JPEG_QUALITY = 80;
-
-	// Default quality for webp images
-	protected const DEFAULT_WEBP_QUALITY = 80;
-
-	// tmp resource.
-	protected GdImage|false $resource = false;
-	// Default to png if file type isn't evident.
-	protected int $imageType = IMAGETYPE_PNG;
-	// Default to png
-	protected ?string $mimeType = 'image/png';
-	protected ?string $filePath = null;
-	private ?finfo $fileInfo = null;
-	private LoggerInterface $logger;
-	private IAppConfig $appConfig;
-	private IConfig $config;
-	private ?array $exif = null;
-
-	/**
-	 * @throws \InvalidArgumentException in case the $imageRef parameter is not null
-	 */
-	public function __construct(
-		?LoggerInterface $logger = null,
-		?IAppConfig $appConfig = null,
-		?IConfig $config = null,
-	) {
-		$this->logger = $logger ?? Server::get(LoggerInterface::class);
-		$this->appConfig = $appConfig ?? Server::get(IAppConfig::class);
-		$this->config = $config ?? Server::get(IConfig::class);
-
-		if (class_exists(finfo::class)) {
-			$this->fileInfo = new finfo(FILEINFO_MIME_TYPE);
-		}
-	}
-
-	/**
-	 * Determine whether the object contains an image resource.
-	 *
-	 * @psalm-assert-if-true \GdImage $this->resource
-	 * @return bool
-	 */
-	public function valid(): bool {
-		if (is_object($this->resource) && get_class($this->resource) === \GdImage::class) {
-			return true;
-		}
-
-		return false;
-	}
-
-	/**
-	 * Returns the MIME type of the image or null if no image is loaded.
-	 *
-	 * @return string
-	 */
-	public function mimeType(): ?string {
-		return $this->valid() ? $this->mimeType : null;
-	}
-
-	/**
-	 * Returns the width of the image or -1 if no image is loaded.
-	 *
-	 * @return int
-	 */
-	public function width(): int {
-		if ($this->valid()) {
-			return imagesx($this->resource);
-		}
-		return -1;
-	}
-
-	/**
-	 * Returns the height of the image or -1 if no image is loaded.
-	 *
-	 * @return int
-	 */
-	public function height(): int {
-		if ($this->valid()) {
-			return imagesy($this->resource);
-		}
-		return -1;
-	}
-
-	/**
-	 * Returns the width when the image orientation is top-left.
-	 *
-	 * @return int
-	 */
-	public function widthTopLeft(): int {
-		$o = $this->getOrientation();
-		$this->logger->debug('Image->widthTopLeft() Orientation: ' . $o, ['app' => 'core']);
-		switch ($o) {
-			case -1:
-			case 1:
-			case 2: // Not tested
-			case 3:
-			case 4: // Not tested
-				return $this->width();
-			case 5: // Not tested
-			case 6:
-			case 7: // Not tested
-			case 8:
-				return $this->height();
-		}
-		return $this->width();
-	}
-
-	/**
-	 * Returns the height when the image orientation is top-left.
-	 *
-	 * @return int
-	 */
-	public function heightTopLeft(): int {
-		$o = $this->getOrientation();
-		$this->logger->debug('Image->heightTopLeft() Orientation: ' . $o, ['app' => 'core']);
-		switch ($o) {
-			case -1:
-			case 1:
-			case 2: // Not tested
-			case 3:
-			case 4: // Not tested
-				return $this->height();
-			case 5: // Not tested
-			case 6:
-			case 7: // Not tested
-			case 8:
-				return $this->width();
-		}
-		return $this->height();
-	}
-
-	/**
-	 * Outputs the image.
-	 *
-	 * @param string $mimeType
-	 * @return bool
-	 */
-	public function show(?string $mimeType = null): bool {
-		if ($mimeType === null) {
-			$mimeType = $this->mimeType();
-		}
-		if ($mimeType !== null) {
-			header('Content-Type: ' . $mimeType);
-		}
-		return $this->_output(null, $mimeType);
-	}
-
-	/**
-	 * Saves the image.
-	 *
-	 * @param string $filePath
-	 * @param string $mimeType
-	 * @return bool
-	 */
-
-	public function save(?string $filePath = null, ?string $mimeType = null): bool {
-		if ($mimeType === null) {
-			$mimeType = $this->mimeType();
-		}
-		if ($filePath === null) {
-			if ($this->filePath === null) {
-				$this->logger->error(__METHOD__ . '(): called with no path.', ['app' => 'core']);
-				return false;
-			} else {
-				$filePath = $this->filePath;
-			}
-		}
-		return $this->_output($filePath, $mimeType);
-	}
-
-	/**
-	 * Outputs/saves the image.
-	 *
-	 * @throws \Exception
-	 */
-	private function _output(?string $filePath = null, ?string $mimeType = null): bool {
-		if ($filePath !== null && $filePath !== '') {
-			if (!file_exists(dirname($filePath))) {
-				mkdir(dirname($filePath), 0777, true);
-			}
-			$isWritable = is_writable(dirname($filePath));
-			if (!$isWritable) {
-				$this->logger->error(__METHOD__ . '(): Directory \'' . dirname($filePath) . '\' is not writable.', ['app' => 'core']);
-				return false;
-			} elseif (file_exists($filePath) && !is_writable($filePath)) {
-				$this->logger->error(__METHOD__ . '(): File \'' . $filePath . '\' is not writable.', ['app' => 'core']);
-				return false;
-			}
-		}
-		if (!$this->valid()) {
-			return false;
-		}
-
-		$imageType = $this->imageType;
-		if ($mimeType !== null) {
-			switch ($mimeType) {
-				case 'image/gif':
-					$imageType = IMAGETYPE_GIF;
-					break;
-				case 'image/jpeg':
-					$imageType = IMAGETYPE_JPEG;
-					break;
-				case 'image/png':
-					$imageType = IMAGETYPE_PNG;
-					break;
-				case 'image/x-xbitmap':
-					$imageType = IMAGETYPE_XBM;
-					break;
-				case 'image/bmp':
-				case 'image/x-ms-bmp':
-					$imageType = IMAGETYPE_BMP;
-					break;
-				case 'image/webp':
-					$imageType = IMAGETYPE_WEBP;
-					break;
-				default:
-					throw new \Exception('Image::_output(): "' . $mimeType . '" is not supported when forcing a specific output format');
-			}
-		}
-
-		switch ($imageType) {
-			case IMAGETYPE_GIF:
-				$retVal = imagegif($this->resource, $filePath);
-				break;
-			case IMAGETYPE_JPEG:
-				imageinterlace($this->resource, true);
-				$retVal = imagejpeg($this->resource, $filePath, $this->getJpegQuality());
-				break;
-			case IMAGETYPE_PNG:
-				$retVal = imagepng($this->resource, $filePath);
-				break;
-			case IMAGETYPE_XBM:
-				if (function_exists('imagexbm')) {
-					$retVal = imagexbm($this->resource, $filePath);
-				} else {
-					throw new \Exception('Image::_output(): imagexbm() is not supported.');
-				}
-
-				break;
-			case IMAGETYPE_WBMP:
-				$retVal = imagewbmp($this->resource, $filePath);
-				break;
-			case IMAGETYPE_BMP:
-				$retVal = imagebmp($this->resource, $filePath);
-				break;
-			case IMAGETYPE_WEBP:
-				$retVal = imagewebp($this->resource, null, $this->getWebpQuality());
-				break;
-			default:
-				$retVal = imagepng($this->resource, $filePath);
-		}
-		return $retVal;
-	}
-
-	/**
-	 * Prints the image when called as $image().
-	 */
-	public function __invoke() {
-		return $this->show();
-	}
-
-	/**
-	 * @param \GdImage $resource
-	 */
-	public function setResource(\GdImage $resource): void {
-		$this->resource = $resource;
-	}
-
-	/**
-	 * @return false|\GdImage Returns the image resource if any
-	 */
-	public function resource() {
-		return $this->resource;
-	}
-
-	/**
-	 * @return string Returns the mimetype of the data. Returns null if the data is not valid.
-	 */
-	public function dataMimeType(): ?string {
-		if (!$this->valid()) {
-			return null;
-		}
-
-		switch ($this->mimeType) {
-			case 'image/png':
-			case 'image/jpeg':
-			case 'image/gif':
-			case 'image/webp':
-				return $this->mimeType;
-			default:
-				return 'image/png';
-		}
-	}
-
-	/**
-	 * @return null|string Returns the raw image data.
-	 */
-	public function data(): ?string {
-		if (!$this->valid()) {
-			return null;
-		}
-		ob_start();
-		switch ($this->mimeType) {
-			case 'image/png':
-				$res = imagepng($this->resource);
-				break;
-			case 'image/jpeg':
-				imageinterlace($this->resource, true);
-				$quality = $this->getJpegQuality();
-				$res = imagejpeg($this->resource, null, $quality);
-				break;
-			case 'image/gif':
-				$res = imagegif($this->resource);
-				break;
-			case 'image/webp':
-				$res = imagewebp($this->resource, null, $this->getWebpQuality());
-				break;
-			default:
-				$res = imagepng($this->resource);
-				$this->logger->info('Image->data. Could not guess mime-type, defaulting to png', ['app' => 'core']);
-				break;
-		}
-		if (!$res) {
-			$this->logger->error('Image->data. Error getting image data.', ['app' => 'core']);
-		}
-		return ob_get_clean();
-	}
-
-	/**
-	 * @return string - base64 encoded, which is suitable for embedding in a VCard.
-	 */
-	public function __toString(): string {
-		$data = $this->data();
-		if ($data === null) {
-			return '';
-		} else {
-			return base64_encode($data);
-		}
-	}
-
-	protected function getJpegQuality(): int {
-		$quality = $this->appConfig->getValueInt('preview', 'jpeg_quality', self::DEFAULT_JPEG_QUALITY);
-		return min(100, max(10, $quality));
-	}
-
-	protected function getWebpQuality(): int {
-		$quality = $this->appConfig->getValueInt('preview', 'webp_quality', self::DEFAULT_WEBP_QUALITY);
-		return min(100, max(10, $quality));
-	}
-
-	private function isValidExifData(array $exif): bool {
-		if (!isset($exif['Orientation'])) {
-			return false;
-		}
-
-		if (!is_numeric($exif['Orientation'])) {
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * (I'm open for suggestions on better method name ;)
-	 * Get the orientation based on EXIF data.
-	 *
-	 * @return int The orientation or -1 if no EXIF data is available.
-	 */
-	public function getOrientation(): int {
-		if ($this->exif !== null) {
-			return $this->exif['Orientation'];
-		}
-
-		if ($this->imageType !== IMAGETYPE_JPEG) {
-			$this->logger->debug('Image->fixOrientation() Image is not a JPEG.', ['app' => 'core']);
-			return -1;
-		}
-		if (!is_callable('exif_read_data')) {
-			$this->logger->debug('Image->fixOrientation() Exif module not enabled.', ['app' => 'core']);
-			return -1;
-		}
-		if (!$this->valid()) {
-			$this->logger->debug('Image->fixOrientation() No image loaded.', ['app' => 'core']);
-			return -1;
-		}
-		if (is_null($this->filePath) || !is_readable($this->filePath)) {
-			$this->logger->debug('Image->fixOrientation() No readable file path set.', ['app' => 'core']);
-			return -1;
-		}
-		$exif = @exif_read_data($this->filePath, 'IFD0');
-		if ($exif === false || !$this->isValidExifData($exif)) {
-			return -1;
-		}
-		$this->exif = $exif;
-		return (int)$exif['Orientation'];
-	}
-
-	public function readExif(string $data): void {
-		if (!is_callable('exif_read_data')) {
-			$this->logger->debug('Image->fixOrientation() Exif module not enabled.', ['app' => 'core']);
-			return;
-		}
-		if (!$this->valid()) {
-			$this->logger->debug('Image->fixOrientation() No image loaded.', ['app' => 'core']);
-			return;
-		}
-
-		$exif = @exif_read_data('data://image/jpeg;base64,' . base64_encode($data));
-		if ($exif === false || !$this->isValidExifData($exif)) {
-			return;
-		}
-		$this->exif = $exif;
-	}
-
-	/**
-	 * (I'm open for suggestions on better method name ;)
-	 * Fixes orientation based on EXIF data.
-	 *
-	 * @return bool
-	 */
-	public function fixOrientation(): bool {
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$o = $this->getOrientation();
-		$this->logger->debug('Image->fixOrientation() Orientation: ' . $o, ['app' => 'core']);
-		$rotate = 0;
-		$flip = false;
-		switch ($o) {
-			case -1:
-				return false; //Nothing to fix
-			case 1:
-				$rotate = 0;
-				break;
-			case 2:
-				$rotate = 0;
-				$flip = true;
-				break;
-			case 3:
-				$rotate = 180;
-				break;
-			case 4:
-				$rotate = 180;
-				$flip = true;
-				break;
-			case 5:
-				$rotate = 90;
-				$flip = true;
-				break;
-			case 6:
-				$rotate = 270;
-				break;
-			case 7:
-				$rotate = 270;
-				$flip = true;
-				break;
-			case 8:
-				$rotate = 90;
-				break;
-		}
-		if ($flip && function_exists('imageflip')) {
-			imageflip($this->resource, IMG_FLIP_HORIZONTAL);
-		}
-		if ($rotate) {
-			$res = imagerotate($this->resource, $rotate, 0);
-			if ($res) {
-				if (imagealphablending($res, true)) {
-					if (imagesavealpha($res, true)) {
-						imagedestroy($this->resource);
-						$this->resource = $res;
-						return true;
-					} else {
-						$this->logger->debug('Image->fixOrientation() Error during alpha-saving', ['app' => 'core']);
-						return false;
-					}
-				} else {
-					$this->logger->debug('Image->fixOrientation() Error during alpha-blending', ['app' => 'core']);
-					return false;
-				}
-			} else {
-				$this->logger->debug('Image->fixOrientation() Error during orientation fixing', ['app' => 'core']);
-				return false;
-			}
-		}
-		return false;
-	}
-
-	/**
-	 * Loads an image from an open file handle.
-	 * It is the responsibility of the caller to position the pointer at the correct place and to close the handle again.
-	 *
-	 * @param resource $handle
-	 * @return \GdImage|false An image resource or false on error
-	 */
-	public function loadFromFileHandle($handle) {
-		$contents = stream_get_contents($handle);
-		if ($this->loadFromData($contents)) {
-			return $this->resource;
-		}
-		return false;
-	}
-
-	/**
-	 * Check if allocating an image with the given size is allowed.
-	 *
-	 * @param int $width The image width.
-	 * @param int $height The image height.
-	 * @return bool true if allocating is allowed, false otherwise
-	 */
-	private function checkImageMemory($width, $height) {
-		$memory_limit = $this->config->getSystemValueInt('preview_max_memory', self::DEFAULT_MEMORY_LIMIT);
-		if ($memory_limit < 0) {
-			// Not limited.
-			return true;
-		}
-
-		// Assume 32 bits per pixel.
-		if ($width * $height * 4 > $memory_limit * 1024 * 1024) {
-			$this->logger->info('Image size of ' . $width . 'x' . $height . ' would exceed allowed memory limit of ' . $memory_limit . '. You may increase the preview_max_memory in your config.php if you need previews of this image.');
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * Check if loading an image file from the given path is allowed.
-	 *
-	 * @param string $path The path to a local file.
-	 * @return bool true if allocating is allowed, false otherwise
-	 */
-	private function checkImageSize($path) {
-		$size = @getimagesize($path);
-		if (!$size) {
-			return false;
-		}
-
-		$width = $size[0];
-		$height = $size[1];
-		if (!$this->checkImageMemory($width, $height)) {
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * Check if loading an image from the given data is allowed.
-	 *
-	 * @param string $data A string of image data as read from a file.
-	 * @return bool true if allocating is allowed, false otherwise
-	 */
-	private function checkImageDataSize($data) {
-		$size = @getimagesizefromstring($data);
-		if (!$size) {
-			return false;
-		}
-
-		$width = $size[0];
-		$height = $size[1];
-		if (!$this->checkImageMemory($width, $height)) {
-			return false;
-		}
-
-		return true;
-	}
-
-	/**
-	 * Loads an image from a local file.
-	 *
-	 * @param bool|string $imagePath The path to a local file.
-	 * @return bool|\GdImage An image resource or false on error
-	 */
-	public function loadFromFile($imagePath = false) {
-		// exif_imagetype throws "read error!" if file is less than 12 byte
-		if (is_bool($imagePath) || !@is_file($imagePath) || !file_exists($imagePath) || filesize($imagePath) < 12 || !is_readable($imagePath)) {
-			return false;
-		}
-		$iType = exif_imagetype($imagePath);
-		switch ($iType) {
-			case IMAGETYPE_GIF:
-				if (imagetypes() & IMG_GIF) {
-					if (!$this->checkImageSize($imagePath)) {
-						return false;
-					}
-					$this->resource = imagecreatefromgif($imagePath);
-					if ($this->resource) {
-						// Preserve transparency
-						imagealphablending($this->resource, true);
-						imagesavealpha($this->resource, true);
-					} else {
-						$this->logger->debug('Image->loadFromFile, GIF image not valid: ' . $imagePath, ['app' => 'core']);
-					}
-				} else {
-					$this->logger->debug('Image->loadFromFile, GIF images not supported: ' . $imagePath, ['app' => 'core']);
-				}
-				break;
-			case IMAGETYPE_JPEG:
-				if (imagetypes() & IMG_JPG) {
-					if (!$this->checkImageSize($imagePath)) {
-						return false;
-					}
-					if (@getimagesize($imagePath) !== false) {
-						$this->resource = @imagecreatefromjpeg($imagePath);
-					} else {
-						$this->logger->debug('Image->loadFromFile, JPG image not valid: ' . $imagePath, ['app' => 'core']);
-					}
-				} else {
-					$this->logger->debug('Image->loadFromFile, JPG images not supported: ' . $imagePath, ['app' => 'core']);
-				}
-				break;
-			case IMAGETYPE_PNG:
-				if (imagetypes() & IMG_PNG) {
-					if (!$this->checkImageSize($imagePath)) {
-						return false;
-					}
-					$this->resource = @imagecreatefrompng($imagePath);
-					if ($this->resource) {
-						// Preserve transparency
-						imagealphablending($this->resource, true);
-						imagesavealpha($this->resource, true);
-					} else {
-						$this->logger->debug('Image->loadFromFile, PNG image not valid: ' . $imagePath, ['app' => 'core']);
-					}
-				} else {
-					$this->logger->debug('Image->loadFromFile, PNG images not supported: ' . $imagePath, ['app' => 'core']);
-				}
-				break;
-			case IMAGETYPE_XBM:
-				if (imagetypes() & IMG_XPM) {
-					if (!$this->checkImageSize($imagePath)) {
-						return false;
-					}
-					$this->resource = @imagecreatefromxbm($imagePath);
-				} else {
-					$this->logger->debug('Image->loadFromFile, XBM/XPM images not supported: ' . $imagePath, ['app' => 'core']);
-				}
-				break;
-			case IMAGETYPE_WBMP:
-				if (imagetypes() & IMG_WBMP) {
-					if (!$this->checkImageSize($imagePath)) {
-						return false;
-					}
-					$this->resource = @imagecreatefromwbmp($imagePath);
-				} else {
-					$this->logger->debug('Image->loadFromFile, WBMP images not supported: ' . $imagePath, ['app' => 'core']);
-				}
-				break;
-			case IMAGETYPE_BMP:
-				$this->resource = imagecreatefrombmp($imagePath);
-				break;
-			case IMAGETYPE_WEBP:
-				if (imagetypes() & IMG_WEBP) {
-					if (!$this->checkImageSize($imagePath)) {
-						return false;
-					}
-
-					// Check for animated header before generating preview since libgd does not handle them well
-					// Adapted from here: https://stackoverflow.com/a/68491679/4085517 (stripped to only to check for animations + added additional error checking)
-					// Header format details here: https://developers.google.com/speed/webp/docs/riff_container
-
-					// Load up the header data, if any
-					$fp = fopen($imagePath, 'rb');
-					if (!$fp) {
-						return false;
-					}
-					$data = fread($fp, 90);
-					if ($data === false) {
-						return false;
-					}
-					fclose($fp);
-					unset($fp);
-
-					$headerFormat = 'A4Riff/' // get n string
-						. 'I1Filesize/' // get integer (file size but not actual size)
-						. 'A4Webp/' // get n string
-						. 'A4Vp/' // get n string
-						. 'A74Chunk';
-
-					$header = unpack($headerFormat, $data);
-					unset($data, $headerFormat);
-					if ($header === false) {
-						return false;
-					}
-
-					// Check if we're really dealing with a valid WEBP header rather than just one suffixed ".webp"
-					if (!isset($header['Riff']) || strtoupper($header['Riff']) !== 'RIFF') {
-						return false;
-					}
-					if (!isset($header['Webp']) || strtoupper($header['Webp']) !== 'WEBP') {
-						return false;
-					}
-					if (!isset($header['Vp']) || strpos(strtoupper($header['Vp']), 'VP8') === false) {
-						return false;
-					}
-
-					// Check for animation indicators
-					if (strpos(strtoupper($header['Chunk']), 'ANIM') !== false || strpos(strtoupper($header['Chunk']), 'ANMF') !== false) {
-						// Animated so don't let it reach libgd
-						$this->logger->debug('Image->loadFromFile, animated WEBP images not supported: ' . $imagePath, ['app' => 'core']);
-					} else {
-						// We're safe so give it to libgd
-						$this->resource = @imagecreatefromwebp($imagePath);
-					}
-				} else {
-					$this->logger->debug('Image->loadFromFile, WEBP images not supported: ' . $imagePath, ['app' => 'core']);
-				}
-				break;
-				/*
+    // Default memory limit for images to load (256 MBytes).
+    protected const DEFAULT_MEMORY_LIMIT = 256;
+
+    // Default quality for jpeg images
+    protected const DEFAULT_JPEG_QUALITY = 80;
+
+    // Default quality for webp images
+    protected const DEFAULT_WEBP_QUALITY = 80;
+
+    // tmp resource.
+    protected GdImage|false $resource = false;
+    // Default to png if file type isn't evident.
+    protected int $imageType = IMAGETYPE_PNG;
+    // Default to png
+    protected ?string $mimeType = 'image/png';
+    protected ?string $filePath = null;
+    private ?finfo $fileInfo = null;
+    private LoggerInterface $logger;
+    private IAppConfig $appConfig;
+    private IConfig $config;
+    private ?array $exif = null;
+
+    /**
+     * @throws \InvalidArgumentException in case the $imageRef parameter is not null
+     */
+    public function __construct(
+        ?LoggerInterface $logger = null,
+        ?IAppConfig $appConfig = null,
+        ?IConfig $config = null,
+    ) {
+        $this->logger = $logger ?? Server::get(LoggerInterface::class);
+        $this->appConfig = $appConfig ?? Server::get(IAppConfig::class);
+        $this->config = $config ?? Server::get(IConfig::class);
+
+        if (class_exists(finfo::class)) {
+            $this->fileInfo = new finfo(FILEINFO_MIME_TYPE);
+        }
+    }
+
+    /**
+     * Determine whether the object contains an image resource.
+     *
+     * @psalm-assert-if-true \GdImage $this->resource
+     * @return bool
+     */
+    public function valid(): bool {
+        if (is_object($this->resource) && get_class($this->resource) === \GdImage::class) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * Returns the MIME type of the image or null if no image is loaded.
+     *
+     * @return string
+     */
+    public function mimeType(): ?string {
+        return $this->valid() ? $this->mimeType : null;
+    }
+
+    /**
+     * Returns the width of the image or -1 if no image is loaded.
+     *
+     * @return int
+     */
+    public function width(): int {
+        if ($this->valid()) {
+            return imagesx($this->resource);
+        }
+        return -1;
+    }
+
+    /**
+     * Returns the height of the image or -1 if no image is loaded.
+     *
+     * @return int
+     */
+    public function height(): int {
+        if ($this->valid()) {
+            return imagesy($this->resource);
+        }
+        return -1;
+    }
+
+    /**
+     * Returns the width when the image orientation is top-left.
+     *
+     * @return int
+     */
+    public function widthTopLeft(): int {
+        $o = $this->getOrientation();
+        $this->logger->debug('Image->widthTopLeft() Orientation: ' . $o, ['app' => 'core']);
+        switch ($o) {
+            case -1:
+            case 1:
+            case 2: // Not tested
+            case 3:
+            case 4: // Not tested
+                return $this->width();
+            case 5: // Not tested
+            case 6:
+            case 7: // Not tested
+            case 8:
+                return $this->height();
+        }
+        return $this->width();
+    }
+
+    /**
+     * Returns the height when the image orientation is top-left.
+     *
+     * @return int
+     */
+    public function heightTopLeft(): int {
+        $o = $this->getOrientation();
+        $this->logger->debug('Image->heightTopLeft() Orientation: ' . $o, ['app' => 'core']);
+        switch ($o) {
+            case -1:
+            case 1:
+            case 2: // Not tested
+            case 3:
+            case 4: // Not tested
+                return $this->height();
+            case 5: // Not tested
+            case 6:
+            case 7: // Not tested
+            case 8:
+                return $this->width();
+        }
+        return $this->height();
+    }
+
+    /**
+     * Outputs the image.
+     *
+     * @param string $mimeType
+     * @return bool
+     */
+    public function show(?string $mimeType = null): bool {
+        if ($mimeType === null) {
+            $mimeType = $this->mimeType();
+        }
+        if ($mimeType !== null) {
+            header('Content-Type: ' . $mimeType);
+        }
+        return $this->_output(null, $mimeType);
+    }
+
+    /**
+     * Saves the image.
+     *
+     * @param string $filePath
+     * @param string $mimeType
+     * @return bool
+     */
+
+    public function save(?string $filePath = null, ?string $mimeType = null): bool {
+        if ($mimeType === null) {
+            $mimeType = $this->mimeType();
+        }
+        if ($filePath === null) {
+            if ($this->filePath === null) {
+                $this->logger->error(__METHOD__ . '(): called with no path.', ['app' => 'core']);
+                return false;
+            } else {
+                $filePath = $this->filePath;
+            }
+        }
+        return $this->_output($filePath, $mimeType);
+    }
+
+    /**
+     * Outputs/saves the image.
+     *
+     * @throws \Exception
+     */
+    private function _output(?string $filePath = null, ?string $mimeType = null): bool {
+        if ($filePath !== null && $filePath !== '') {
+            if (!file_exists(dirname($filePath))) {
+                mkdir(dirname($filePath), 0777, true);
+            }
+            $isWritable = is_writable(dirname($filePath));
+            if (!$isWritable) {
+                $this->logger->error(__METHOD__ . '(): Directory \'' . dirname($filePath) . '\' is not writable.', ['app' => 'core']);
+                return false;
+            } elseif (file_exists($filePath) && !is_writable($filePath)) {
+                $this->logger->error(__METHOD__ . '(): File \'' . $filePath . '\' is not writable.', ['app' => 'core']);
+                return false;
+            }
+        }
+        if (!$this->valid()) {
+            return false;
+        }
+
+        $imageType = $this->imageType;
+        if ($mimeType !== null) {
+            switch ($mimeType) {
+                case 'image/gif':
+                    $imageType = IMAGETYPE_GIF;
+                    break;
+                case 'image/jpeg':
+                    $imageType = IMAGETYPE_JPEG;
+                    break;
+                case 'image/png':
+                    $imageType = IMAGETYPE_PNG;
+                    break;
+                case 'image/x-xbitmap':
+                    $imageType = IMAGETYPE_XBM;
+                    break;
+                case 'image/bmp':
+                case 'image/x-ms-bmp':
+                    $imageType = IMAGETYPE_BMP;
+                    break;
+                case 'image/webp':
+                    $imageType = IMAGETYPE_WEBP;
+                    break;
+                default:
+                    throw new \Exception('Image::_output(): "' . $mimeType . '" is not supported when forcing a specific output format');
+            }
+        }
+
+        switch ($imageType) {
+            case IMAGETYPE_GIF:
+                $retVal = imagegif($this->resource, $filePath);
+                break;
+            case IMAGETYPE_JPEG:
+                imageinterlace($this->resource, true);
+                $retVal = imagejpeg($this->resource, $filePath, $this->getJpegQuality());
+                break;
+            case IMAGETYPE_PNG:
+                $retVal = imagepng($this->resource, $filePath);
+                break;
+            case IMAGETYPE_XBM:
+                if (function_exists('imagexbm')) {
+                    $retVal = imagexbm($this->resource, $filePath);
+                } else {
+                    throw new \Exception('Image::_output(): imagexbm() is not supported.');
+                }
+
+                break;
+            case IMAGETYPE_WBMP:
+                $retVal = imagewbmp($this->resource, $filePath);
+                break;
+            case IMAGETYPE_BMP:
+                $retVal = imagebmp($this->resource, $filePath);
+                break;
+            case IMAGETYPE_WEBP:
+                $retVal = imagewebp($this->resource, null, $this->getWebpQuality());
+                break;
+            default:
+                $retVal = imagepng($this->resource, $filePath);
+        }
+        return $retVal;
+    }
+
+    /**
+     * Prints the image when called as $image().
+     */
+    public function __invoke() {
+        return $this->show();
+    }
+
+    /**
+     * @param \GdImage $resource
+     */
+    public function setResource(\GdImage $resource): void {
+        $this->resource = $resource;
+    }
+
+    /**
+     * @return false|\GdImage Returns the image resource if any
+     */
+    public function resource() {
+        return $this->resource;
+    }
+
+    /**
+     * @return string Returns the mimetype of the data. Returns null if the data is not valid.
+     */
+    public function dataMimeType(): ?string {
+        if (!$this->valid()) {
+            return null;
+        }
+
+        switch ($this->mimeType) {
+            case 'image/png':
+            case 'image/jpeg':
+            case 'image/gif':
+            case 'image/webp':
+                return $this->mimeType;
+            default:
+                return 'image/png';
+        }
+    }
+
+    /**
+     * @return null|string Returns the raw image data.
+     */
+    public function data(): ?string {
+        if (!$this->valid()) {
+            return null;
+        }
+        ob_start();
+        switch ($this->mimeType) {
+            case 'image/png':
+                $res = imagepng($this->resource);
+                break;
+            case 'image/jpeg':
+                imageinterlace($this->resource, true);
+                $quality = $this->getJpegQuality();
+                $res = imagejpeg($this->resource, null, $quality);
+                break;
+            case 'image/gif':
+                $res = imagegif($this->resource);
+                break;
+            case 'image/webp':
+                $res = imagewebp($this->resource, null, $this->getWebpQuality());
+                break;
+            default:
+                $res = imagepng($this->resource);
+                $this->logger->info('Image->data. Could not guess mime-type, defaulting to png', ['app' => 'core']);
+                break;
+        }
+        if (!$res) {
+            $this->logger->error('Image->data. Error getting image data.', ['app' => 'core']);
+        }
+        return ob_get_clean();
+    }
+
+    /**
+     * @return string - base64 encoded, which is suitable for embedding in a VCard.
+     */
+    public function __toString(): string {
+        $data = $this->data();
+        if ($data === null) {
+            return '';
+        } else {
+            return base64_encode($data);
+        }
+    }
+
+    protected function getJpegQuality(): int {
+        $quality = $this->appConfig->getValueInt('preview', 'jpeg_quality', self::DEFAULT_JPEG_QUALITY);
+        return min(100, max(10, $quality));
+    }
+
+    protected function getWebpQuality(): int {
+        $quality = $this->appConfig->getValueInt('preview', 'webp_quality', self::DEFAULT_WEBP_QUALITY);
+        return min(100, max(10, $quality));
+    }
+
+    private function isValidExifData(array $exif): bool {
+        if (!isset($exif['Orientation'])) {
+            return false;
+        }
+
+        if (!is_numeric($exif['Orientation'])) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * (I'm open for suggestions on better method name ;)
+     * Get the orientation based on EXIF data.
+     *
+     * @return int The orientation or -1 if no EXIF data is available.
+     */
+    public function getOrientation(): int {
+        if ($this->exif !== null) {
+            return $this->exif['Orientation'];
+        }
+
+        if ($this->imageType !== IMAGETYPE_JPEG) {
+            $this->logger->debug('Image->fixOrientation() Image is not a JPEG.', ['app' => 'core']);
+            return -1;
+        }
+        if (!is_callable('exif_read_data')) {
+            $this->logger->debug('Image->fixOrientation() Exif module not enabled.', ['app' => 'core']);
+            return -1;
+        }
+        if (!$this->valid()) {
+            $this->logger->debug('Image->fixOrientation() No image loaded.', ['app' => 'core']);
+            return -1;
+        }
+        if (is_null($this->filePath) || !is_readable($this->filePath)) {
+            $this->logger->debug('Image->fixOrientation() No readable file path set.', ['app' => 'core']);
+            return -1;
+        }
+        $exif = @exif_read_data($this->filePath, 'IFD0');
+        if ($exif === false || !$this->isValidExifData($exif)) {
+            return -1;
+        }
+        $this->exif = $exif;
+        return (int)$exif['Orientation'];
+    }
+
+    public function readExif(string $data): void {
+        if (!is_callable('exif_read_data')) {
+            $this->logger->debug('Image->fixOrientation() Exif module not enabled.', ['app' => 'core']);
+            return;
+        }
+        if (!$this->valid()) {
+            $this->logger->debug('Image->fixOrientation() No image loaded.', ['app' => 'core']);
+            return;
+        }
+
+        $exif = @exif_read_data('data://image/jpeg;base64,' . base64_encode($data));
+        if ($exif === false || !$this->isValidExifData($exif)) {
+            return;
+        }
+        $this->exif = $exif;
+    }
+
+    /**
+     * (I'm open for suggestions on better method name ;)
+     * Fixes orientation based on EXIF data.
+     *
+     * @return bool
+     */
+    public function fixOrientation(): bool {
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $o = $this->getOrientation();
+        $this->logger->debug('Image->fixOrientation() Orientation: ' . $o, ['app' => 'core']);
+        $rotate = 0;
+        $flip = false;
+        switch ($o) {
+            case -1:
+                return false; //Nothing to fix
+            case 1:
+                $rotate = 0;
+                break;
+            case 2:
+                $rotate = 0;
+                $flip = true;
+                break;
+            case 3:
+                $rotate = 180;
+                break;
+            case 4:
+                $rotate = 180;
+                $flip = true;
+                break;
+            case 5:
+                $rotate = 90;
+                $flip = true;
+                break;
+            case 6:
+                $rotate = 270;
+                break;
+            case 7:
+                $rotate = 270;
+                $flip = true;
+                break;
+            case 8:
+                $rotate = 90;
+                break;
+        }
+        if ($flip && function_exists('imageflip')) {
+            imageflip($this->resource, IMG_FLIP_HORIZONTAL);
+        }
+        if ($rotate) {
+            $res = imagerotate($this->resource, $rotate, 0);
+            if ($res) {
+                if (imagealphablending($res, true)) {
+                    if (imagesavealpha($res, true)) {
+                        imagedestroy($this->resource);
+                        $this->resource = $res;
+                        return true;
+                    } else {
+                        $this->logger->debug('Image->fixOrientation() Error during alpha-saving', ['app' => 'core']);
+                        return false;
+                    }
+                } else {
+                    $this->logger->debug('Image->fixOrientation() Error during alpha-blending', ['app' => 'core']);
+                    return false;
+                }
+            } else {
+                $this->logger->debug('Image->fixOrientation() Error during orientation fixing', ['app' => 'core']);
+                return false;
+            }
+        }
+        return false;
+    }
+
+    /**
+     * Loads an image from an open file handle.
+     * It is the responsibility of the caller to position the pointer at the correct place and to close the handle again.
+     *
+     * @param resource $handle
+     * @return \GdImage|false An image resource or false on error
+     */
+    public function loadFromFileHandle($handle) {
+        $contents = stream_get_contents($handle);
+        if ($this->loadFromData($contents)) {
+            return $this->resource;
+        }
+        return false;
+    }
+
+    /**
+     * Check if allocating an image with the given size is allowed.
+     *
+     * @param int $width The image width.
+     * @param int $height The image height.
+     * @return bool true if allocating is allowed, false otherwise
+     */
+    private function checkImageMemory($width, $height) {
+        $memory_limit = $this->config->getSystemValueInt('preview_max_memory', self::DEFAULT_MEMORY_LIMIT);
+        if ($memory_limit < 0) {
+            // Not limited.
+            return true;
+        }
+
+        // Assume 32 bits per pixel.
+        if ($width * $height * 4 > $memory_limit * 1024 * 1024) {
+            $this->logger->info('Image size of ' . $width . 'x' . $height . ' would exceed allowed memory limit of ' . $memory_limit . '. You may increase the preview_max_memory in your config.php if you need previews of this image.');
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * Check if loading an image file from the given path is allowed.
+     *
+     * @param string $path The path to a local file.
+     * @return bool true if allocating is allowed, false otherwise
+     */
+    private function checkImageSize($path) {
+        $size = @getimagesize($path);
+        if (!$size) {
+            return false;
+        }
+
+        $width = $size[0];
+        $height = $size[1];
+        if (!$this->checkImageMemory($width, $height)) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * Check if loading an image from the given data is allowed.
+     *
+     * @param string $data A string of image data as read from a file.
+     * @return bool true if allocating is allowed, false otherwise
+     */
+    private function checkImageDataSize($data) {
+        $size = @getimagesizefromstring($data);
+        if (!$size) {
+            return false;
+        }
+
+        $width = $size[0];
+        $height = $size[1];
+        if (!$this->checkImageMemory($width, $height)) {
+            return false;
+        }
+
+        return true;
+    }
+
+    /**
+     * Loads an image from a local file.
+     *
+     * @param bool|string $imagePath The path to a local file.
+     * @return bool|\GdImage An image resource or false on error
+     */
+    public function loadFromFile($imagePath = false) {
+        // exif_imagetype throws "read error!" if file is less than 12 byte
+        if (is_bool($imagePath) || !@is_file($imagePath) || !file_exists($imagePath) || filesize($imagePath) < 12 || !is_readable($imagePath)) {
+            return false;
+        }
+        $iType = exif_imagetype($imagePath);
+        switch ($iType) {
+            case IMAGETYPE_GIF:
+                if (imagetypes() & IMG_GIF) {
+                    if (!$this->checkImageSize($imagePath)) {
+                        return false;
+                    }
+                    $this->resource = imagecreatefromgif($imagePath);
+                    if ($this->resource) {
+                        // Preserve transparency
+                        imagealphablending($this->resource, true);
+                        imagesavealpha($this->resource, true);
+                    } else {
+                        $this->logger->debug('Image->loadFromFile, GIF image not valid: ' . $imagePath, ['app' => 'core']);
+                    }
+                } else {
+                    $this->logger->debug('Image->loadFromFile, GIF images not supported: ' . $imagePath, ['app' => 'core']);
+                }
+                break;
+            case IMAGETYPE_JPEG:
+                if (imagetypes() & IMG_JPG) {
+                    if (!$this->checkImageSize($imagePath)) {
+                        return false;
+                    }
+                    if (@getimagesize($imagePath) !== false) {
+                        $this->resource = @imagecreatefromjpeg($imagePath);
+                    } else {
+                        $this->logger->debug('Image->loadFromFile, JPG image not valid: ' . $imagePath, ['app' => 'core']);
+                    }
+                } else {
+                    $this->logger->debug('Image->loadFromFile, JPG images not supported: ' . $imagePath, ['app' => 'core']);
+                }
+                break;
+            case IMAGETYPE_PNG:
+                if (imagetypes() & IMG_PNG) {
+                    if (!$this->checkImageSize($imagePath)) {
+                        return false;
+                    }
+                    $this->resource = @imagecreatefrompng($imagePath);
+                    if ($this->resource) {
+                        // Preserve transparency
+                        imagealphablending($this->resource, true);
+                        imagesavealpha($this->resource, true);
+                    } else {
+                        $this->logger->debug('Image->loadFromFile, PNG image not valid: ' . $imagePath, ['app' => 'core']);
+                    }
+                } else {
+                    $this->logger->debug('Image->loadFromFile, PNG images not supported: ' . $imagePath, ['app' => 'core']);
+                }
+                break;
+            case IMAGETYPE_XBM:
+                if (imagetypes() & IMG_XPM) {
+                    if (!$this->checkImageSize($imagePath)) {
+                        return false;
+                    }
+                    $this->resource = @imagecreatefromxbm($imagePath);
+                } else {
+                    $this->logger->debug('Image->loadFromFile, XBM/XPM images not supported: ' . $imagePath, ['app' => 'core']);
+                }
+                break;
+            case IMAGETYPE_WBMP:
+                if (imagetypes() & IMG_WBMP) {
+                    if (!$this->checkImageSize($imagePath)) {
+                        return false;
+                    }
+                    $this->resource = @imagecreatefromwbmp($imagePath);
+                } else {
+                    $this->logger->debug('Image->loadFromFile, WBMP images not supported: ' . $imagePath, ['app' => 'core']);
+                }
+                break;
+            case IMAGETYPE_BMP:
+                $this->resource = imagecreatefrombmp($imagePath);
+                break;
+            case IMAGETYPE_WEBP:
+                if (imagetypes() & IMG_WEBP) {
+                    if (!$this->checkImageSize($imagePath)) {
+                        return false;
+                    }
+
+                    // Check for animated header before generating preview since libgd does not handle them well
+                    // Adapted from here: https://stackoverflow.com/a/68491679/4085517 (stripped to only to check for animations + added additional error checking)
+                    // Header format details here: https://developers.google.com/speed/webp/docs/riff_container
+
+                    // Load up the header data, if any
+                    $fp = fopen($imagePath, 'rb');
+                    if (!$fp) {
+                        return false;
+                    }
+                    $data = fread($fp, 90);
+                    if ($data === false) {
+                        return false;
+                    }
+                    fclose($fp);
+                    unset($fp);
+
+                    $headerFormat = 'A4Riff/' // get n string
+                        . 'I1Filesize/' // get integer (file size but not actual size)
+                        . 'A4Webp/' // get n string
+                        . 'A4Vp/' // get n string
+                        . 'A74Chunk';
+
+                    $header = unpack($headerFormat, $data);
+                    unset($data, $headerFormat);
+                    if ($header === false) {
+                        return false;
+                    }
+
+                    // Check if we're really dealing with a valid WEBP header rather than just one suffixed ".webp"
+                    if (!isset($header['Riff']) || strtoupper($header['Riff']) !== 'RIFF') {
+                        return false;
+                    }
+                    if (!isset($header['Webp']) || strtoupper($header['Webp']) !== 'WEBP') {
+                        return false;
+                    }
+                    if (!isset($header['Vp']) || strpos(strtoupper($header['Vp']), 'VP8') === false) {
+                        return false;
+                    }
+
+                    // Check for animation indicators
+                    if (strpos(strtoupper($header['Chunk']), 'ANIM') !== false || strpos(strtoupper($header['Chunk']), 'ANMF') !== false) {
+                        // Animated so don't let it reach libgd
+                        $this->logger->debug('Image->loadFromFile, animated WEBP images not supported: ' . $imagePath, ['app' => 'core']);
+                    } else {
+                        // We're safe so give it to libgd
+                        $this->resource = @imagecreatefromwebp($imagePath);
+                    }
+                } else {
+                    $this->logger->debug('Image->loadFromFile, WEBP images not supported: ' . $imagePath, ['app' => 'core']);
+                }
+                break;
+                /*
 				case IMAGETYPE_TIFF_II: // (intel byte order)
 					break;
 				case IMAGETYPE_TIFF_MM: // (motorola byte order)
@@ -758,408 +758,408 @@ 
 				case IMAGETYPE_PSD:
 					break;
 				*/
-			default:
-
-				// this is mostly file created from encrypted file
-				$data = file_get_contents($imagePath);
-				if (!$this->checkImageDataSize($data)) {
-					return false;
-				}
-				$this->resource = @imagecreatefromstring($data);
-				$iType = IMAGETYPE_PNG;
-				$this->logger->debug('Image->loadFromFile, Default', ['app' => 'core']);
-				break;
-		}
-		if ($this->valid()) {
-			$this->imageType = $iType;
-			$this->mimeType = image_type_to_mime_type($iType);
-			$this->filePath = $imagePath;
-		}
-		return $this->resource;
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function loadFromData(string $str): GdImage|false {
-		if (!$this->checkImageDataSize($str)) {
-			return false;
-		}
-		$this->resource = @imagecreatefromstring($str);
-		if ($this->fileInfo) {
-			$this->mimeType = $this->fileInfo->buffer($str);
-		}
-		if ($this->valid()) {
-			imagealphablending($this->resource, false);
-			imagesavealpha($this->resource, true);
-		}
-
-		if (!$this->resource) {
-			$this->logger->debug('Image->loadFromFile, could not load', ['app' => 'core']);
-			return false;
-		}
-		return $this->resource;
-	}
-
-	/**
-	 * Loads an image from a base64 encoded string.
-	 *
-	 * @param string $str A string base64 encoded string of image data.
-	 * @return bool|\GdImage An image resource or false on error
-	 */
-	public function loadFromBase64(string $str) {
-		$data = base64_decode($str);
-		if ($data) { // try to load from string data
-			if (!$this->checkImageDataSize($data)) {
-				return false;
-			}
-			$this->resource = @imagecreatefromstring($data);
-			if ($this->fileInfo) {
-				$this->mimeType = $this->fileInfo->buffer($data);
-			}
-			if (!$this->resource) {
-				$this->logger->debug('Image->loadFromBase64, could not load', ['app' => 'core']);
-				return false;
-			}
-			return $this->resource;
-		} else {
-			return false;
-		}
-	}
-
-	/**
-	 * Resizes the image preserving ratio.
-	 *
-	 * @param int $maxSize The maximum size of either the width or height.
-	 * @return bool
-	 */
-	public function resize(int $maxSize): bool {
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$result = $this->resizeNew($maxSize);
-		$this->resource = $result;
-		return $this->valid();
-	}
-
-	private function resizeNew(int $maxSize): \GdImage|false {
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$widthOrig = imagesx($this->resource);
-		$heightOrig = imagesy($this->resource);
-		$ratioOrig = $widthOrig / $heightOrig;
-
-		if ($ratioOrig > 1) {
-			$newHeight = round($maxSize / $ratioOrig);
-			$newWidth = $maxSize;
-		} else {
-			$newWidth = round($maxSize * $ratioOrig);
-			$newHeight = $maxSize;
-		}
-
-		return $this->preciseResizeNew((int)round($newWidth), (int)round($newHeight));
-	}
-
-	/**
-	 * @param int $width
-	 * @param int $height
-	 * @return bool
-	 */
-	public function preciseResize(int $width, int $height): bool {
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$result = $this->preciseResizeNew($width, $height);
-		$this->resource = $result;
-		return $this->valid();
-	}
-
-	public function preciseResizeNew(int $width, int $height): \GdImage|false {
-		if (!($width > 0) || !($height > 0)) {
-			$this->logger->info(__METHOD__ . '(): Requested image size not bigger than 0', ['app' => 'core']);
-			return false;
-		}
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$widthOrig = imagesx($this->resource);
-		$heightOrig = imagesy($this->resource);
-		$process = imagecreatetruecolor($width, $height);
-		if ($process === false) {
-			$this->logger->debug(__METHOD__ . '(): Error creating true color image', ['app' => 'core']);
-			return false;
-		}
-
-		// preserve transparency
-		if ($this->imageType === IMAGETYPE_GIF || $this->imageType === IMAGETYPE_PNG) {
-			$alpha = imagecolorallocatealpha($process, 0, 0, 0, 127);
-			if ($alpha === false) {
-				$alpha = null;
-			}
-			imagecolortransparent($process, $alpha);
-			imagealphablending($process, false);
-			imagesavealpha($process, true);
-		}
-
-		$res = imagecopyresampled($process, $this->resource, 0, 0, 0, 0, $width, $height, $widthOrig, $heightOrig);
-		if ($res === false) {
-			$this->logger->debug(__METHOD__ . '(): Error re-sampling process image', ['app' => 'core']);
-			imagedestroy($process);
-			return false;
-		}
-		return $process;
-	}
-
-	/**
-	 * Crops the image to the middle square. If the image is already square it just returns.
-	 *
-	 * @param int $size maximum size for the result (optional)
-	 * @return bool for success or failure
-	 */
-	public function centerCrop(int $size = 0): bool {
-		if (!$this->valid()) {
-			$this->logger->debug('Image->centerCrop, No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$widthOrig = imagesx($this->resource);
-		$heightOrig = imagesy($this->resource);
-		if ($widthOrig === $heightOrig && $size == 0) {
-			return true;
-		}
-		$ratioOrig = $widthOrig / $heightOrig;
-		$width = $height = min($widthOrig, $heightOrig);
-
-		if ($ratioOrig > 1) {
-			$x = (int)(($widthOrig / 2) - ($width / 2));
-			$y = 0;
-		} else {
-			$y = (int)(($heightOrig / 2) - ($height / 2));
-			$x = 0;
-		}
-		if ($size > 0) {
-			$targetWidth = $size;
-			$targetHeight = $size;
-		} else {
-			$targetWidth = $width;
-			$targetHeight = $height;
-		}
-		$process = imagecreatetruecolor($targetWidth, $targetHeight);
-		if ($process === false) {
-			$this->logger->debug('Image->centerCrop, Error creating true color image', ['app' => 'core']);
-			return false;
-		}
-
-		// preserve transparency
-		if ($this->imageType === IMAGETYPE_GIF || $this->imageType === IMAGETYPE_PNG) {
-			$alpha = imagecolorallocatealpha($process, 0, 0, 0, 127);
-			if ($alpha === false) {
-				$alpha = null;
-			}
-			imagecolortransparent($process, $alpha);
-			imagealphablending($process, false);
-			imagesavealpha($process, true);
-		}
-
-		$result = imagecopyresampled($process, $this->resource, 0, 0, $x, $y, $targetWidth, $targetHeight, $width, $height);
-		if ($result === false) {
-			$this->logger->debug('Image->centerCrop, Error re-sampling process image ' . $width . 'x' . $height, ['app' => 'core']);
-			return false;
-		}
-		imagedestroy($this->resource);
-		$this->resource = $process;
-		return true;
-	}
-
-	/**
-	 * Crops the image from point $x$y with dimension $wx$h.
-	 *
-	 * @param int $x Horizontal position
-	 * @param int $y Vertical position
-	 * @param int $w Width
-	 * @param int $h Height
-	 * @return bool for success or failure
-	 */
-	public function crop(int $x, int $y, int $w, int $h): bool {
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$result = $this->cropNew($x, $y, $w, $h);
-		imagedestroy($this->resource);
-		$this->resource = $result;
-		return $this->valid();
-	}
-
-	/**
-	 * Crops the image from point $x$y with dimension $wx$h.
-	 *
-	 * @param int $x Horizontal position
-	 * @param int $y Vertical position
-	 * @param int $w Width
-	 * @param int $h Height
-	 * @return \GdImage|false
-	 */
-	public function cropNew(int $x, int $y, int $w, int $h) {
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$process = imagecreatetruecolor($w, $h);
-		if ($process === false) {
-			$this->logger->debug(__METHOD__ . '(): Error creating true color image', ['app' => 'core']);
-			return false;
-		}
-
-		// preserve transparency
-		if ($this->imageType === IMAGETYPE_GIF || $this->imageType === IMAGETYPE_PNG) {
-			$alpha = imagecolorallocatealpha($process, 0, 0, 0, 127);
-			if ($alpha === false) {
-				$alpha = null;
-			}
-			imagecolortransparent($process, $alpha);
-			imagealphablending($process, false);
-			imagesavealpha($process, true);
-		}
-
-		$result = imagecopyresampled($process, $this->resource, 0, 0, $x, $y, $w, $h, $w, $h);
-		if ($result === false) {
-			$this->logger->debug(__METHOD__ . '(): Error re-sampling process image ' . $w . 'x' . $h, ['app' => 'core']);
-			return false;
-		}
-		return $process;
-	}
-
-	/**
-	 * Resizes the image to fit within a boundary while preserving ratio.
-	 *
-	 * Warning: Images smaller than $maxWidth x $maxHeight will end up being scaled up
-	 *
-	 * @param int $maxWidth
-	 * @param int $maxHeight
-	 * @return bool
-	 */
-	public function fitIn(int $maxWidth, int $maxHeight): bool {
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$widthOrig = imagesx($this->resource);
-		$heightOrig = imagesy($this->resource);
-		$ratio = $widthOrig / $heightOrig;
-
-		$newWidth = min($maxWidth, $ratio * $maxHeight);
-		$newHeight = min($maxHeight, $maxWidth / $ratio);
-
-		$this->preciseResize((int)round($newWidth), (int)round($newHeight));
-		return true;
-	}
-
-	/**
-	 * Shrinks larger images to fit within specified boundaries while preserving ratio.
-	 *
-	 * @param int $maxWidth
-	 * @param int $maxHeight
-	 * @return bool
-	 */
-	public function scaleDownToFit(int $maxWidth, int $maxHeight): bool {
-		if (!$this->valid()) {
-			$this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
-			return false;
-		}
-		$widthOrig = imagesx($this->resource);
-		$heightOrig = imagesy($this->resource);
-
-		if ($widthOrig > $maxWidth || $heightOrig > $maxHeight) {
-			return $this->fitIn($maxWidth, $maxHeight);
-		}
-
-		return false;
-	}
-
-	public function copy(): IImage {
-		$image = new self($this->logger, $this->appConfig, $this->config);
-		if (!$this->valid()) {
-			/* image is invalid, return an empty one */
-			return $image;
-		}
-		$image->resource = imagecreatetruecolor($this->width(), $this->height());
-		if (!$image->valid()) {
-			/* image creation failed, cannot copy in it */
-			return $image;
-		}
-		imagecopy(
-			$image->resource,
-			$this->resource,
-			0,
-			0,
-			0,
-			0,
-			$this->width(),
-			$this->height()
-		);
-
-		return $image;
-	}
-
-	public function cropCopy(int $x, int $y, int $w, int $h): IImage {
-		$image = new self($this->logger, $this->appConfig, $this->config);
-		$image->imageType = $this->imageType;
-		$image->mimeType = $this->mimeType;
-		$image->resource = $this->cropNew($x, $y, $w, $h);
-
-		return $image;
-	}
-
-	public function preciseResizeCopy(int $width, int $height): IImage {
-		$image = new self($this->logger, $this->appConfig, $this->config);
-		$image->imageType = $this->imageType;
-		$image->mimeType = $this->mimeType;
-		$image->resource = $this->preciseResizeNew($width, $height);
-
-		return $image;
-	}
-
-	public function resizeCopy(int $maxSize): IImage {
-		$image = new self($this->logger, $this->appConfig, $this->config);
-		$image->imageType = $this->imageType;
-		$image->mimeType = $this->mimeType;
-		$image->resource = $this->resizeNew($maxSize);
-
-		return $image;
-	}
-
-	/**
-	 * Destroys the current image and resets the object
-	 */
-	public function destroy(): void {
-		if ($this->valid()) {
-			imagedestroy($this->resource);
-		}
-		$this->resource = false;
-	}
-
-	public function __destruct() {
-		$this->destroy();
-	}
+            default:
+
+                // this is mostly file created from encrypted file
+                $data = file_get_contents($imagePath);
+                if (!$this->checkImageDataSize($data)) {
+                    return false;
+                }
+                $this->resource = @imagecreatefromstring($data);
+                $iType = IMAGETYPE_PNG;
+                $this->logger->debug('Image->loadFromFile, Default', ['app' => 'core']);
+                break;
+        }
+        if ($this->valid()) {
+            $this->imageType = $iType;
+            $this->mimeType = image_type_to_mime_type($iType);
+            $this->filePath = $imagePath;
+        }
+        return $this->resource;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function loadFromData(string $str): GdImage|false {
+        if (!$this->checkImageDataSize($str)) {
+            return false;
+        }
+        $this->resource = @imagecreatefromstring($str);
+        if ($this->fileInfo) {
+            $this->mimeType = $this->fileInfo->buffer($str);
+        }
+        if ($this->valid()) {
+            imagealphablending($this->resource, false);
+            imagesavealpha($this->resource, true);
+        }
+
+        if (!$this->resource) {
+            $this->logger->debug('Image->loadFromFile, could not load', ['app' => 'core']);
+            return false;
+        }
+        return $this->resource;
+    }
+
+    /**
+     * Loads an image from a base64 encoded string.
+     *
+     * @param string $str A string base64 encoded string of image data.
+     * @return bool|\GdImage An image resource or false on error
+     */
+    public function loadFromBase64(string $str) {
+        $data = base64_decode($str);
+        if ($data) { // try to load from string data
+            if (!$this->checkImageDataSize($data)) {
+                return false;
+            }
+            $this->resource = @imagecreatefromstring($data);
+            if ($this->fileInfo) {
+                $this->mimeType = $this->fileInfo->buffer($data);
+            }
+            if (!$this->resource) {
+                $this->logger->debug('Image->loadFromBase64, could not load', ['app' => 'core']);
+                return false;
+            }
+            return $this->resource;
+        } else {
+            return false;
+        }
+    }
+
+    /**
+     * Resizes the image preserving ratio.
+     *
+     * @param int $maxSize The maximum size of either the width or height.
+     * @return bool
+     */
+    public function resize(int $maxSize): bool {
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $result = $this->resizeNew($maxSize);
+        $this->resource = $result;
+        return $this->valid();
+    }
+
+    private function resizeNew(int $maxSize): \GdImage|false {
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $widthOrig = imagesx($this->resource);
+        $heightOrig = imagesy($this->resource);
+        $ratioOrig = $widthOrig / $heightOrig;
+
+        if ($ratioOrig > 1) {
+            $newHeight = round($maxSize / $ratioOrig);
+            $newWidth = $maxSize;
+        } else {
+            $newWidth = round($maxSize * $ratioOrig);
+            $newHeight = $maxSize;
+        }
+
+        return $this->preciseResizeNew((int)round($newWidth), (int)round($newHeight));
+    }
+
+    /**
+     * @param int $width
+     * @param int $height
+     * @return bool
+     */
+    public function preciseResize(int $width, int $height): bool {
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $result = $this->preciseResizeNew($width, $height);
+        $this->resource = $result;
+        return $this->valid();
+    }
+
+    public function preciseResizeNew(int $width, int $height): \GdImage|false {
+        if (!($width > 0) || !($height > 0)) {
+            $this->logger->info(__METHOD__ . '(): Requested image size not bigger than 0', ['app' => 'core']);
+            return false;
+        }
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $widthOrig = imagesx($this->resource);
+        $heightOrig = imagesy($this->resource);
+        $process = imagecreatetruecolor($width, $height);
+        if ($process === false) {
+            $this->logger->debug(__METHOD__ . '(): Error creating true color image', ['app' => 'core']);
+            return false;
+        }
+
+        // preserve transparency
+        if ($this->imageType === IMAGETYPE_GIF || $this->imageType === IMAGETYPE_PNG) {
+            $alpha = imagecolorallocatealpha($process, 0, 0, 0, 127);
+            if ($alpha === false) {
+                $alpha = null;
+            }
+            imagecolortransparent($process, $alpha);
+            imagealphablending($process, false);
+            imagesavealpha($process, true);
+        }
+
+        $res = imagecopyresampled($process, $this->resource, 0, 0, 0, 0, $width, $height, $widthOrig, $heightOrig);
+        if ($res === false) {
+            $this->logger->debug(__METHOD__ . '(): Error re-sampling process image', ['app' => 'core']);
+            imagedestroy($process);
+            return false;
+        }
+        return $process;
+    }
+
+    /**
+     * Crops the image to the middle square. If the image is already square it just returns.
+     *
+     * @param int $size maximum size for the result (optional)
+     * @return bool for success or failure
+     */
+    public function centerCrop(int $size = 0): bool {
+        if (!$this->valid()) {
+            $this->logger->debug('Image->centerCrop, No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $widthOrig = imagesx($this->resource);
+        $heightOrig = imagesy($this->resource);
+        if ($widthOrig === $heightOrig && $size == 0) {
+            return true;
+        }
+        $ratioOrig = $widthOrig / $heightOrig;
+        $width = $height = min($widthOrig, $heightOrig);
+
+        if ($ratioOrig > 1) {
+            $x = (int)(($widthOrig / 2) - ($width / 2));
+            $y = 0;
+        } else {
+            $y = (int)(($heightOrig / 2) - ($height / 2));
+            $x = 0;
+        }
+        if ($size > 0) {
+            $targetWidth = $size;
+            $targetHeight = $size;
+        } else {
+            $targetWidth = $width;
+            $targetHeight = $height;
+        }
+        $process = imagecreatetruecolor($targetWidth, $targetHeight);
+        if ($process === false) {
+            $this->logger->debug('Image->centerCrop, Error creating true color image', ['app' => 'core']);
+            return false;
+        }
+
+        // preserve transparency
+        if ($this->imageType === IMAGETYPE_GIF || $this->imageType === IMAGETYPE_PNG) {
+            $alpha = imagecolorallocatealpha($process, 0, 0, 0, 127);
+            if ($alpha === false) {
+                $alpha = null;
+            }
+            imagecolortransparent($process, $alpha);
+            imagealphablending($process, false);
+            imagesavealpha($process, true);
+        }
+
+        $result = imagecopyresampled($process, $this->resource, 0, 0, $x, $y, $targetWidth, $targetHeight, $width, $height);
+        if ($result === false) {
+            $this->logger->debug('Image->centerCrop, Error re-sampling process image ' . $width . 'x' . $height, ['app' => 'core']);
+            return false;
+        }
+        imagedestroy($this->resource);
+        $this->resource = $process;
+        return true;
+    }
+
+    /**
+     * Crops the image from point $x$y with dimension $wx$h.
+     *
+     * @param int $x Horizontal position
+     * @param int $y Vertical position
+     * @param int $w Width
+     * @param int $h Height
+     * @return bool for success or failure
+     */
+    public function crop(int $x, int $y, int $w, int $h): bool {
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $result = $this->cropNew($x, $y, $w, $h);
+        imagedestroy($this->resource);
+        $this->resource = $result;
+        return $this->valid();
+    }
+
+    /**
+     * Crops the image from point $x$y with dimension $wx$h.
+     *
+     * @param int $x Horizontal position
+     * @param int $y Vertical position
+     * @param int $w Width
+     * @param int $h Height
+     * @return \GdImage|false
+     */
+    public function cropNew(int $x, int $y, int $w, int $h) {
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $process = imagecreatetruecolor($w, $h);
+        if ($process === false) {
+            $this->logger->debug(__METHOD__ . '(): Error creating true color image', ['app' => 'core']);
+            return false;
+        }
+
+        // preserve transparency
+        if ($this->imageType === IMAGETYPE_GIF || $this->imageType === IMAGETYPE_PNG) {
+            $alpha = imagecolorallocatealpha($process, 0, 0, 0, 127);
+            if ($alpha === false) {
+                $alpha = null;
+            }
+            imagecolortransparent($process, $alpha);
+            imagealphablending($process, false);
+            imagesavealpha($process, true);
+        }
+
+        $result = imagecopyresampled($process, $this->resource, 0, 0, $x, $y, $w, $h, $w, $h);
+        if ($result === false) {
+            $this->logger->debug(__METHOD__ . '(): Error re-sampling process image ' . $w . 'x' . $h, ['app' => 'core']);
+            return false;
+        }
+        return $process;
+    }
+
+    /**
+     * Resizes the image to fit within a boundary while preserving ratio.
+     *
+     * Warning: Images smaller than $maxWidth x $maxHeight will end up being scaled up
+     *
+     * @param int $maxWidth
+     * @param int $maxHeight
+     * @return bool
+     */
+    public function fitIn(int $maxWidth, int $maxHeight): bool {
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $widthOrig = imagesx($this->resource);
+        $heightOrig = imagesy($this->resource);
+        $ratio = $widthOrig / $heightOrig;
+
+        $newWidth = min($maxWidth, $ratio * $maxHeight);
+        $newHeight = min($maxHeight, $maxWidth / $ratio);
+
+        $this->preciseResize((int)round($newWidth), (int)round($newHeight));
+        return true;
+    }
+
+    /**
+     * Shrinks larger images to fit within specified boundaries while preserving ratio.
+     *
+     * @param int $maxWidth
+     * @param int $maxHeight
+     * @return bool
+     */
+    public function scaleDownToFit(int $maxWidth, int $maxHeight): bool {
+        if (!$this->valid()) {
+            $this->logger->debug(__METHOD__ . '(): No image loaded', ['app' => 'core']);
+            return false;
+        }
+        $widthOrig = imagesx($this->resource);
+        $heightOrig = imagesy($this->resource);
+
+        if ($widthOrig > $maxWidth || $heightOrig > $maxHeight) {
+            return $this->fitIn($maxWidth, $maxHeight);
+        }
+
+        return false;
+    }
+
+    public function copy(): IImage {
+        $image = new self($this->logger, $this->appConfig, $this->config);
+        if (!$this->valid()) {
+            /* image is invalid, return an empty one */
+            return $image;
+        }
+        $image->resource = imagecreatetruecolor($this->width(), $this->height());
+        if (!$image->valid()) {
+            /* image creation failed, cannot copy in it */
+            return $image;
+        }
+        imagecopy(
+            $image->resource,
+            $this->resource,
+            0,
+            0,
+            0,
+            0,
+            $this->width(),
+            $this->height()
+        );
+
+        return $image;
+    }
+
+    public function cropCopy(int $x, int $y, int $w, int $h): IImage {
+        $image = new self($this->logger, $this->appConfig, $this->config);
+        $image->imageType = $this->imageType;
+        $image->mimeType = $this->mimeType;
+        $image->resource = $this->cropNew($x, $y, $w, $h);
+
+        return $image;
+    }
+
+    public function preciseResizeCopy(int $width, int $height): IImage {
+        $image = new self($this->logger, $this->appConfig, $this->config);
+        $image->imageType = $this->imageType;
+        $image->mimeType = $this->mimeType;
+        $image->resource = $this->preciseResizeNew($width, $height);
+
+        return $image;
+    }
+
+    public function resizeCopy(int $maxSize): IImage {
+        $image = new self($this->logger, $this->appConfig, $this->config);
+        $image->imageType = $this->imageType;
+        $image->mimeType = $this->mimeType;
+        $image->resource = $this->resizeNew($maxSize);
+
+        return $image;
+    }
+
+    /**
+     * Destroys the current image and resets the object
+     */
+    public function destroy(): void {
+        if ($this->valid()) {
+            imagedestroy($this->resource);
+        }
+        $this->resource = false;
+    }
+
+    public function __destruct() {
+        $this->destroy();
+    }
 }
 
 if (!function_exists('exif_imagetype')) {
-	/**
-	 * Workaround if exif_imagetype does not exist
-	 *
-	 * @link https://www.php.net/manual/en/function.exif-imagetype.php#80383
-	 * @param string $fileName
-	 * @return int|false
-	 */
-	function exif_imagetype(string $fileName) {
-		if (($info = getimagesize($fileName)) !== false) {
-			return $info[2];
-		}
-		return false;
-	}
+    /**
+     * Workaround if exif_imagetype does not exist
+     *
+     * @link https://www.php.net/manual/en/function.exif-imagetype.php#80383
+     * @param string $fileName
+     * @return int|false
+     */
+    function exif_imagetype(string $fileName) {
+        if (($info = getimagesize($fileName)) !== false) {
+            return $info[2];
+        }
+        return false;
+    }
 }

lib/private/DB/ConnectionFactory.php

Indentation +246 added lines, -246 removed lines

@@ -21,278 +21,278 @@
  * Takes care of creating and configuring Doctrine connections.
  */
 class ConnectionFactory {
-	/** @var string default database name */
-	public const DEFAULT_DBNAME = 'owncloud';
+    /** @var string default database name */
+    public const DEFAULT_DBNAME = 'owncloud';
 
-	/** @var string default database table prefix */
-	public const DEFAULT_DBTABLEPREFIX = 'oc_';
+    /** @var string default database table prefix */
+    public const DEFAULT_DBTABLEPREFIX = 'oc_';
 
-	/**
-	 * @var array
-	 *
-	 * Array mapping DBMS type to default connection parameters passed to
-	 * \Doctrine\DBAL\DriverManager::getConnection().
-	 */
-	protected $defaultConnectionParams = [
-		'mysql' => [
-			'adapter' => AdapterMySQL::class,
-			'charset' => 'UTF8',
-			'driver' => 'pdo_mysql',
-			'wrapperClass' => Connection::class,
-		],
-		'oci' => [
-			'adapter' => AdapterOCI8::class,
-			'charset' => 'AL32UTF8',
-			'driver' => 'oci8',
-			'wrapperClass' => OracleConnection::class,
-		],
-		'pgsql' => [
-			'adapter' => AdapterPgSql::class,
-			'driver' => 'pdo_pgsql',
-			'wrapperClass' => Connection::class,
-		],
-		'sqlite3' => [
-			'adapter' => AdapterSqlite::class,
-			'driver' => 'pdo_sqlite',
-			'wrapperClass' => Connection::class,
-		],
-	];
+    /**
+     * @var array
+     *
+     * Array mapping DBMS type to default connection parameters passed to
+     * \Doctrine\DBAL\DriverManager::getConnection().
+     */
+    protected $defaultConnectionParams = [
+        'mysql' => [
+            'adapter' => AdapterMySQL::class,
+            'charset' => 'UTF8',
+            'driver' => 'pdo_mysql',
+            'wrapperClass' => Connection::class,
+        ],
+        'oci' => [
+            'adapter' => AdapterOCI8::class,
+            'charset' => 'AL32UTF8',
+            'driver' => 'oci8',
+            'wrapperClass' => OracleConnection::class,
+        ],
+        'pgsql' => [
+            'adapter' => AdapterPgSql::class,
+            'driver' => 'pdo_pgsql',
+            'wrapperClass' => Connection::class,
+        ],
+        'sqlite3' => [
+            'adapter' => AdapterSqlite::class,
+            'driver' => 'pdo_sqlite',
+            'wrapperClass' => Connection::class,
+        ],
+    ];
 
-	private ShardConnectionManager $shardConnectionManager;
-	private ICacheFactory $cacheFactory;
+    private ShardConnectionManager $shardConnectionManager;
+    private ICacheFactory $cacheFactory;
 
-	public function __construct(
-		private SystemConfig $config,
-		?ICacheFactory $cacheFactory = null,
-	) {
-		if ($this->config->getValue('mysql.utf8mb4', false)) {
-			$this->defaultConnectionParams['mysql']['charset'] = 'utf8mb4';
-		}
-		$collationOverride = $this->config->getValue('mysql.collation', null);
-		if ($collationOverride) {
-			$this->defaultConnectionParams['mysql']['collation'] = $collationOverride;
-		}
-		$this->shardConnectionManager = new ShardConnectionManager($this->config, $this);
-		$this->cacheFactory = $cacheFactory ?? Server::get(ICacheFactory::class);
-	}
+    public function __construct(
+        private SystemConfig $config,
+        ?ICacheFactory $cacheFactory = null,
+    ) {
+        if ($this->config->getValue('mysql.utf8mb4', false)) {
+            $this->defaultConnectionParams['mysql']['charset'] = 'utf8mb4';
+        }
+        $collationOverride = $this->config->getValue('mysql.collation', null);
+        if ($collationOverride) {
+            $this->defaultConnectionParams['mysql']['collation'] = $collationOverride;
+        }
+        $this->shardConnectionManager = new ShardConnectionManager($this->config, $this);
+        $this->cacheFactory = $cacheFactory ?? Server::get(ICacheFactory::class);
+    }
 
-	/**
-	 * @brief Get default connection parameters for a given DBMS.
-	 * @param string $type DBMS type
-	 * @throws \InvalidArgumentException If $type is invalid
-	 * @return array Default connection parameters.
-	 */
-	public function getDefaultConnectionParams($type) {
-		$normalizedType = $this->normalizeType($type);
-		if (!isset($this->defaultConnectionParams[$normalizedType])) {
-			throw new \InvalidArgumentException("Unsupported type: $type");
-		}
-		$result = $this->defaultConnectionParams[$normalizedType];
-		/**
-		 * {@see \PDO::MYSQL_ATTR_FOUND_ROWS} may not be defined, e.g. when the MySQL
-		 * driver is missing. In this case, we won't be able to connect anyway.
-		 * In PHP 8.5 it's deprecated and {@see \Pdo\Mysql::ATTR_FOUND_ROWS} should be used,
-		 * but that is only available since PHP 8.4
-		 */
-		if ($normalizedType === 'mysql') {
-			if (PHP_VERSION_ID >= 80500 && class_exists(\Pdo\Mysql::class)) {
-				/** @psalm-suppress UndefinedClass */
-				$result['driverOptions'] = [
-					\Pdo\Mysql::ATTR_FOUND_ROWS => true,
-				];
-			} elseif (PHP_VERSION_ID < 80500 && defined('\PDO::MYSQL_ATTR_FOUND_ROWS')) {
-				$result['driverOptions'] = [
-					\PDO::MYSQL_ATTR_FOUND_ROWS => true,
-				];
-			}
-		}
-		return $result;
-	}
+    /**
+     * @brief Get default connection parameters for a given DBMS.
+     * @param string $type DBMS type
+     * @throws \InvalidArgumentException If $type is invalid
+     * @return array Default connection parameters.
+     */
+    public function getDefaultConnectionParams($type) {
+        $normalizedType = $this->normalizeType($type);
+        if (!isset($this->defaultConnectionParams[$normalizedType])) {
+            throw new \InvalidArgumentException("Unsupported type: $type");
+        }
+        $result = $this->defaultConnectionParams[$normalizedType];
+        /**
+         * {@see \PDO::MYSQL_ATTR_FOUND_ROWS} may not be defined, e.g. when the MySQL
+         * driver is missing. In this case, we won't be able to connect anyway.
+         * In PHP 8.5 it's deprecated and {@see \Pdo\Mysql::ATTR_FOUND_ROWS} should be used,
+         * but that is only available since PHP 8.4
+         */
+        if ($normalizedType === 'mysql') {
+            if (PHP_VERSION_ID >= 80500 && class_exists(\Pdo\Mysql::class)) {
+                /** @psalm-suppress UndefinedClass */
+                $result['driverOptions'] = [
+                    \Pdo\Mysql::ATTR_FOUND_ROWS => true,
+                ];
+            } elseif (PHP_VERSION_ID < 80500 && defined('\PDO::MYSQL_ATTR_FOUND_ROWS')) {
+                $result['driverOptions'] = [
+                    \PDO::MYSQL_ATTR_FOUND_ROWS => true,
+                ];
+            }
+        }
+        return $result;
+    }
 
-	/**
-	 * @brief Get default connection parameters for a given DBMS.
-	 * @param string $type DBMS type
-	 * @param array $additionalConnectionParams Additional connection parameters
-	 * @return \OC\DB\Connection
-	 */
-	public function getConnection(string $type, array $additionalConnectionParams): Connection {
-		$normalizedType = $this->normalizeType($type);
-		$eventManager = new EventManager();
-		$eventManager->addEventSubscriber(new SetTransactionIsolationLevel());
-		$connectionParams = $this->createConnectionParams('', $additionalConnectionParams, $type);
-		switch ($normalizedType) {
-			case 'pgsql':
-				// pg_connect used by Doctrine DBAL does not support URI notation (enclosed in brackets)
-				$matches = [];
-				if (preg_match('/^\[([^\]]+)\]$/', $connectionParams['host'], $matches)) {
-					// Host variable carries a port or socket.
-					$connectionParams['host'] = $matches[1];
-				}
-				break;
+    /**
+     * @brief Get default connection parameters for a given DBMS.
+     * @param string $type DBMS type
+     * @param array $additionalConnectionParams Additional connection parameters
+     * @return \OC\DB\Connection
+     */
+    public function getConnection(string $type, array $additionalConnectionParams): Connection {
+        $normalizedType = $this->normalizeType($type);
+        $eventManager = new EventManager();
+        $eventManager->addEventSubscriber(new SetTransactionIsolationLevel());
+        $connectionParams = $this->createConnectionParams('', $additionalConnectionParams, $type);
+        switch ($normalizedType) {
+            case 'pgsql':
+                // pg_connect used by Doctrine DBAL does not support URI notation (enclosed in brackets)
+                $matches = [];
+                if (preg_match('/^\[([^\]]+)\]$/', $connectionParams['host'], $matches)) {
+                    // Host variable carries a port or socket.
+                    $connectionParams['host'] = $matches[1];
+                }
+                break;
 
-			case 'oci':
-				$eventManager->addEventSubscriber(new OracleSessionInit);
-				$connectionParams = $this->forceConnectionStringOracle($connectionParams);
-				$connectionParams['primary'] = $this->forceConnectionStringOracle($connectionParams['primary']);
-				$connectionParams['replica'] = array_map([$this, 'forceConnectionStringOracle'], $connectionParams['replica']);
-				break;
+            case 'oci':
+                $eventManager->addEventSubscriber(new OracleSessionInit);
+                $connectionParams = $this->forceConnectionStringOracle($connectionParams);
+                $connectionParams['primary'] = $this->forceConnectionStringOracle($connectionParams['primary']);
+                $connectionParams['replica'] = array_map([$this, 'forceConnectionStringOracle'], $connectionParams['replica']);
+                break;
 
-			case 'sqlite3':
-				$journalMode = $connectionParams['sqlite.journal_mode'];
-				$connectionParams['platform'] = new OCSqlitePlatform();
-				$eventManager->addEventSubscriber(new SQLiteSessionInit(true, $journalMode));
-				break;
-		}
-		/** @var Connection $connection */
-		$connection = DriverManager::getConnection(
-			$connectionParams,
-			new Configuration(),
-			$eventManager
-		);
-		return $connection;
-	}
+            case 'sqlite3':
+                $journalMode = $connectionParams['sqlite.journal_mode'];
+                $connectionParams['platform'] = new OCSqlitePlatform();
+                $eventManager->addEventSubscriber(new SQLiteSessionInit(true, $journalMode));
+                break;
+        }
+        /** @var Connection $connection */
+        $connection = DriverManager::getConnection(
+            $connectionParams,
+            new Configuration(),
+            $eventManager
+        );
+        return $connection;
+    }
 
-	/**
-	 * @brief Normalize DBMS type
-	 * @param string $type DBMS type
-	 * @return string Normalized DBMS type
-	 */
-	public function normalizeType($type) {
-		return $type === 'sqlite' ? 'sqlite3' : $type;
-	}
+    /**
+     * @brief Normalize DBMS type
+     * @param string $type DBMS type
+     * @return string Normalized DBMS type
+     */
+    public function normalizeType($type) {
+        return $type === 'sqlite' ? 'sqlite3' : $type;
+    }
 
-	/**
-	 * Checks whether the specified DBMS type is valid.
-	 *
-	 * @param string $type
-	 * @return bool
-	 */
-	public function isValidType($type) {
-		$normalizedType = $this->normalizeType($type);
-		return isset($this->defaultConnectionParams[$normalizedType]);
-	}
+    /**
+     * Checks whether the specified DBMS type is valid.
+     *
+     * @param string $type
+     * @return bool
+     */
+    public function isValidType($type) {
+        $normalizedType = $this->normalizeType($type);
+        return isset($this->defaultConnectionParams[$normalizedType]);
+    }
 
-	/**
-	 * Create the connection parameters for the config
-	 */
-	public function createConnectionParams(string $configPrefix = '', array $additionalConnectionParams = [], ?string $type = null) {
-		// use provided type or if null use type from config
-		$type = $type ?? $this->config->getValue('dbtype', 'sqlite');
+    /**
+     * Create the connection parameters for the config
+     */
+    public function createConnectionParams(string $configPrefix = '', array $additionalConnectionParams = [], ?string $type = null) {
+        // use provided type or if null use type from config
+        $type = $type ?? $this->config->getValue('dbtype', 'sqlite');
 
-		$connectionParams = array_merge($this->getDefaultConnectionParams($type), [
-			'user' => $this->config->getValue($configPrefix . 'dbuser', $this->config->getValue('dbuser', '')),
-			'password' => $this->config->getValue($configPrefix . 'dbpassword', $this->config->getValue('dbpassword', '')),
-		]);
-		$name = $this->config->getValue($configPrefix . 'dbname', $this->config->getValue('dbname', self::DEFAULT_DBNAME));
+        $connectionParams = array_merge($this->getDefaultConnectionParams($type), [
+            'user' => $this->config->getValue($configPrefix . 'dbuser', $this->config->getValue('dbuser', '')),
+            'password' => $this->config->getValue($configPrefix . 'dbpassword', $this->config->getValue('dbpassword', '')),
+        ]);
+        $name = $this->config->getValue($configPrefix . 'dbname', $this->config->getValue('dbname', self::DEFAULT_DBNAME));
 
-		if ($this->normalizeType($type) === 'sqlite3') {
-			$dataDir = $this->config->getValue('datadirectory', \OC::$SERVERROOT . '/data');
-			$connectionParams['path'] = $dataDir . '/' . $name . '.db';
-		} else {
-			$host = $this->config->getValue($configPrefix . 'dbhost', $this->config->getValue('dbhost', ''));
-			$connectionParams = array_merge($connectionParams, $this->splitHostFromPortAndSocket($host));
-			$connectionParams['dbname'] = $name;
-		}
+        if ($this->normalizeType($type) === 'sqlite3') {
+            $dataDir = $this->config->getValue('datadirectory', \OC::$SERVERROOT . '/data');
+            $connectionParams['path'] = $dataDir . '/' . $name . '.db';
+        } else {
+            $host = $this->config->getValue($configPrefix . 'dbhost', $this->config->getValue('dbhost', ''));
+            $connectionParams = array_merge($connectionParams, $this->splitHostFromPortAndSocket($host));
+            $connectionParams['dbname'] = $name;
+        }
 
-		$connectionParams['tablePrefix'] = $this->config->getValue('dbtableprefix', self::DEFAULT_DBTABLEPREFIX);
-		$connectionParams['sqlite.journal_mode'] = $this->config->getValue('sqlite.journal_mode', 'WAL');
+        $connectionParams['tablePrefix'] = $this->config->getValue('dbtableprefix', self::DEFAULT_DBTABLEPREFIX);
+        $connectionParams['sqlite.journal_mode'] = $this->config->getValue('sqlite.journal_mode', 'WAL');
 
-		//additional driver options, eg. for mysql ssl
-		$driverOptions = $this->config->getValue($configPrefix . 'dbdriveroptions', $this->config->getValue('dbdriveroptions', null));
-		if ($driverOptions) {
-			$connectionParams['driverOptions'] = $driverOptions;
-		}
+        //additional driver options, eg. for mysql ssl
+        $driverOptions = $this->config->getValue($configPrefix . 'dbdriveroptions', $this->config->getValue('dbdriveroptions', null));
+        if ($driverOptions) {
+            $connectionParams['driverOptions'] = $driverOptions;
+        }
 
-		// set default table creation options
-		$connectionParams['defaultTableOptions'] = [
-			'collate' => 'utf8_bin',
-			'tablePrefix' => $connectionParams['tablePrefix']
-		];
+        // set default table creation options
+        $connectionParams['defaultTableOptions'] = [
+            'collate' => 'utf8_bin',
+            'tablePrefix' => $connectionParams['tablePrefix']
+        ];
 
-		if ($type === 'pgsql') {
-			$pgsqlSsl = $this->config->getValue('pgsql_ssl', false);
-			if (is_array($pgsqlSsl)) {
-				$connectionParams['sslmode'] = $pgsqlSsl['mode'] ?? '';
-				$connectionParams['sslrootcert'] = $pgsqlSsl['rootcert'] ?? '';
-				$connectionParams['sslcert'] = $pgsqlSsl['cert'] ?? '';
-				$connectionParams['sslkey'] = $pgsqlSsl['key'] ?? '';
-				$connectionParams['sslcrl'] = $pgsqlSsl['crl'] ?? '';
-			}
-		}
+        if ($type === 'pgsql') {
+            $pgsqlSsl = $this->config->getValue('pgsql_ssl', false);
+            if (is_array($pgsqlSsl)) {
+                $connectionParams['sslmode'] = $pgsqlSsl['mode'] ?? '';
+                $connectionParams['sslrootcert'] = $pgsqlSsl['rootcert'] ?? '';
+                $connectionParams['sslcert'] = $pgsqlSsl['cert'] ?? '';
+                $connectionParams['sslkey'] = $pgsqlSsl['key'] ?? '';
+                $connectionParams['sslcrl'] = $pgsqlSsl['crl'] ?? '';
+            }
+        }
 
-		if ($type === 'mysql' && $this->config->getValue('mysql.utf8mb4', false)) {
-			$connectionParams['defaultTableOptions'] = [
-				'collate' => 'utf8mb4_bin',
-				'charset' => 'utf8mb4',
-				'tablePrefix' => $connectionParams['tablePrefix']
-			];
-		}
+        if ($type === 'mysql' && $this->config->getValue('mysql.utf8mb4', false)) {
+            $connectionParams['defaultTableOptions'] = [
+                'collate' => 'utf8mb4_bin',
+                'charset' => 'utf8mb4',
+                'tablePrefix' => $connectionParams['tablePrefix']
+            ];
+        }
 
-		if ($this->config->getValue('dbpersistent', false)) {
-			$connectionParams['persistent'] = true;
-		}
+        if ($this->config->getValue('dbpersistent', false)) {
+            $connectionParams['persistent'] = true;
+        }
 
-		$connectionParams['sharding'] = $this->config->getValue('dbsharding', []);
-		if (!empty($connectionParams['sharding'])) {
-			$connectionParams['shard_connection_manager'] = $this->shardConnectionManager;
-			$connectionParams['auto_increment_handler'] = new AutoIncrementHandler(
-				$this->cacheFactory,
-				$this->shardConnectionManager,
-			);
-		} else {
-			// just in case only the presence could lead to funny behaviour
-			unset($connectionParams['sharding']);
-		}
+        $connectionParams['sharding'] = $this->config->getValue('dbsharding', []);
+        if (!empty($connectionParams['sharding'])) {
+            $connectionParams['shard_connection_manager'] = $this->shardConnectionManager;
+            $connectionParams['auto_increment_handler'] = new AutoIncrementHandler(
+                $this->cacheFactory,
+                $this->shardConnectionManager,
+            );
+        } else {
+            // just in case only the presence could lead to funny behaviour
+            unset($connectionParams['sharding']);
+        }
 
-		$connectionParams = array_merge($connectionParams, $additionalConnectionParams);
+        $connectionParams = array_merge($connectionParams, $additionalConnectionParams);
 
-		$replica = $this->config->getValue($configPrefix . 'dbreplica', $this->config->getValue('dbreplica', [])) ?: [$connectionParams];
-		return array_merge($connectionParams, [
-			'primary' => $connectionParams,
-			'replica' => $replica,
-		]);
-	}
+        $replica = $this->config->getValue($configPrefix . 'dbreplica', $this->config->getValue('dbreplica', [])) ?: [$connectionParams];
+        return array_merge($connectionParams, [
+            'primary' => $connectionParams,
+            'replica' => $replica,
+        ]);
+    }
 
-	/**
-	 * @param string $host
-	 * @return array
-	 */
-	protected function splitHostFromPortAndSocket($host): array {
-		$params = [
-			'host' => $host,
-		];
+    /**
+     * @param string $host
+     * @return array
+     */
+    protected function splitHostFromPortAndSocket($host): array {
+        $params = [
+            'host' => $host,
+        ];
 
-		$matches = [];
-		if (preg_match('/^(.*):([^\]:]+)$/', $host, $matches)) {
-			// Host variable carries a port or socket.
-			$params['host'] = $matches[1];
-			if (is_numeric($matches[2])) {
-				$params['port'] = (int)$matches[2];
-			} else {
-				$params['unix_socket'] = $matches[2];
-			}
-		}
+        $matches = [];
+        if (preg_match('/^(.*):([^\]:]+)$/', $host, $matches)) {
+            // Host variable carries a port or socket.
+            $params['host'] = $matches[1];
+            if (is_numeric($matches[2])) {
+                $params['port'] = (int)$matches[2];
+            } else {
+                $params['unix_socket'] = $matches[2];
+            }
+        }
 
-		return $params;
-	}
+        return $params;
+    }
 
-	protected function forceConnectionStringOracle(array $connectionParams): array {
-		// the driverOptions are unused in dbal and need to be mapped to the parameters
-		if (isset($connectionParams['driverOptions'])) {
-			$connectionParams = array_merge($connectionParams, $connectionParams['driverOptions']);
-		}
-		$host = $connectionParams['host'];
-		$port = $connectionParams['port'] ?? null;
-		$dbName = $connectionParams['dbname'];
+    protected function forceConnectionStringOracle(array $connectionParams): array {
+        // the driverOptions are unused in dbal and need to be mapped to the parameters
+        if (isset($connectionParams['driverOptions'])) {
+            $connectionParams = array_merge($connectionParams, $connectionParams['driverOptions']);
+        }
+        $host = $connectionParams['host'];
+        $port = $connectionParams['port'] ?? null;
+        $dbName = $connectionParams['dbname'];
 
-		// we set the connect string as dbname and unset the host to coerce doctrine into using it as connect string
-		if ($host === '') {
-			$connectionParams['dbname'] = $dbName; // use dbname as easy connect name
-		} else {
-			$connectionParams['dbname'] = '//' . $host . (!empty($port) ? ":{$port}" : '') . '/' . $dbName;
-		}
-		unset($connectionParams['host']);
+        // we set the connect string as dbname and unset the host to coerce doctrine into using it as connect string
+        if ($host === '') {
+            $connectionParams['dbname'] = $dbName; // use dbname as easy connect name
+        } else {
+            $connectionParams['dbname'] = '//' . $host . (!empty($port) ? ":{$port}" : '') . '/' . $dbName;
+        }
+        unset($connectionParams['host']);
 
-		return $connectionParams;
-	}
+        return $connectionParams;
+    }
 }

lib/private/DB/SQLiteSessionInit.php

Indentation +38 added lines, -38 removed lines

@@ -12,46 +12,46 @@
 use Doctrine\DBAL\Events;
 
 class SQLiteSessionInit implements EventSubscriber {
-	/**
-	 * @var bool
-	 */
-	private $caseSensitiveLike;
+    /**
+     * @var bool
+     */
+    private $caseSensitiveLike;
 
-	/**
-	 * @var string
-	 */
-	private $journalMode;
+    /**
+     * @var string
+     */
+    private $journalMode;
 
-	/**
-	 * Configure case sensitive like for each connection
-	 *
-	 * @param bool $caseSensitiveLike
-	 * @param string $journalMode
-	 */
-	public function __construct($caseSensitiveLike, $journalMode) {
-		$this->caseSensitiveLike = $caseSensitiveLike;
-		$this->journalMode = $journalMode;
-	}
+    /**
+     * Configure case sensitive like for each connection
+     *
+     * @param bool $caseSensitiveLike
+     * @param string $journalMode
+     */
+    public function __construct($caseSensitiveLike, $journalMode) {
+        $this->caseSensitiveLike = $caseSensitiveLike;
+        $this->journalMode = $journalMode;
+    }
 
-	/**
-	 * @param ConnectionEventArgs $args
-	 * @return void
-	 */
-	public function postConnect(ConnectionEventArgs $args) {
-		$sensitive = $this->caseSensitiveLike ? 'true' : 'false';
-		$args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
-		$args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
-		/** @var \Doctrine\DBAL\Driver\PDO\Connection $connection */
-		$connection = $args->getConnection()->getWrappedConnection();
-		$pdo = $connection->getWrappedConnection();
-		if (PHP_VERSION_ID >= 80500 && method_exists($pdo, 'createFunction')) {
-			$pdo->createFunction('md5', 'md5', 1);
-		} else {
-			$pdo->sqliteCreateFunction('md5', 'md5', 1);
-		}
-	}
+    /**
+     * @param ConnectionEventArgs $args
+     * @return void
+     */
+    public function postConnect(ConnectionEventArgs $args) {
+        $sensitive = $this->caseSensitiveLike ? 'true' : 'false';
+        $args->getConnection()->executeUpdate('PRAGMA case_sensitive_like = ' . $sensitive);
+        $args->getConnection()->executeUpdate('PRAGMA journal_mode = ' . $this->journalMode);
+        /** @var \Doctrine\DBAL\Driver\PDO\Connection $connection */
+        $connection = $args->getConnection()->getWrappedConnection();
+        $pdo = $connection->getWrappedConnection();
+        if (PHP_VERSION_ID >= 80500 && method_exists($pdo, 'createFunction')) {
+            $pdo->createFunction('md5', 'md5', 1);
+        } else {
+            $pdo->sqliteCreateFunction('md5', 'md5', 1);
+        }
+    }
 
-	public function getSubscribedEvents() {
-		return [Events::postConnect];
-	}
+    public function getSubscribedEvents() {
+        return [Events::postConnect];
+    }
 }

lib/private/Log.php

Indentation +412 added lines, -412 removed lines

@@ -35,416 +35,416 @@
  * MonoLog is an example implementing this interface.
  */
 class Log implements ILogger, IDataLogger {
-	private ?bool $logConditionSatisfied = null;
-	private ?IEventDispatcher $eventDispatcher = null;
-	private int $nestingLevel = 0;
-
-	public function __construct(
-		private IWriter $logger,
-		private SystemConfig $config,
-		private Normalizer $normalizer = new Normalizer(),
-		private ?IRegistry $crashReporters = null,
-	) {
-	}
-
-	public function setEventDispatcher(IEventDispatcher $eventDispatcher): void {
-		$this->eventDispatcher = $eventDispatcher;
-	}
-
-	/**
-	 * System is unusable.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function emergency(string $message, array $context = []): void {
-		$this->log(ILogger::FATAL, $message, $context);
-	}
-
-	/**
-	 * Action must be taken immediately.
-	 *
-	 * Example: Entire website down, database unavailable, etc. This should
-	 * trigger the SMS alerts and wake you up.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function alert(string $message, array $context = []): void {
-		$this->log(ILogger::ERROR, $message, $context);
-	}
-
-	/**
-	 * Critical conditions.
-	 *
-	 * Example: Application component unavailable, unexpected exception.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function critical(string $message, array $context = []): void {
-		$this->log(ILogger::ERROR, $message, $context);
-	}
-
-	/**
-	 * Runtime errors that do not require immediate action but should typically
-	 * be logged and monitored.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function error(string $message, array $context = []): void {
-		$this->log(ILogger::ERROR, $message, $context);
-	}
-
-	/**
-	 * Exceptional occurrences that are not errors.
-	 *
-	 * Example: Use of deprecated APIs, poor use of an API, undesirable things
-	 * that are not necessarily wrong.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function warning(string $message, array $context = []): void {
-		$this->log(ILogger::WARN, $message, $context);
-	}
-
-	/**
-	 * Normal but significant events.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function notice(string $message, array $context = []): void {
-		$this->log(ILogger::INFO, $message, $context);
-	}
-
-	/**
-	 * Interesting events.
-	 *
-	 * Example: User logs in, SQL logs.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function info(string $message, array $context = []): void {
-		$this->log(ILogger::INFO, $message, $context);
-	}
-
-	/**
-	 * Detailed debug information.
-	 *
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function debug(string $message, array $context = []): void {
-		$this->log(ILogger::DEBUG, $message, $context);
-	}
-
-
-	/**
-	 * Logs with an arbitrary level.
-	 *
-	 * @param int $level
-	 * @param string $message
-	 * @param array $context
-	 */
-	public function log(int $level, string $message, array $context = []): void {
-		$minLevel = $this->getLogLevel($context, $message);
-		if ($level < $minLevel
-			&& (($this->crashReporters?->hasReporters() ?? false) === false)
-			&& (($this->eventDispatcher?->hasListeners(BeforeMessageLoggedEvent::class) ?? false) === false)) {
-			return; // no crash reporter, no listeners, we can stop for lower log level
-		}
-
-		$context = array_map($this->normalizer->format(...), $context);
-
-		$app = $context['app'] ?? 'no app in context';
-		$entry = $this->interpolateMessage($context, $message);
-
-		$this->eventDispatcher?->dispatchTyped(new BeforeMessageLoggedEvent($app, $level, $entry));
-
-		$hasBacktrace = isset($entry['exception']);
-		$logBacktrace = $this->config->getValue('log.backtrace', false);
-		if (!$hasBacktrace && $logBacktrace) {
-			$entry['backtrace'] = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
-		}
-
-		try {
-			if ($level >= $minLevel) {
-				$this->writeLog($app, $entry, $level);
-
-				if ($this->crashReporters !== null) {
-					$messageContext = array_merge(
-						$context,
-						[
-							'level' => $level
-						]
-					);
-					$this->crashReporters->delegateMessage($entry['message'], $messageContext);
-				}
-			} else {
-				$this->crashReporters?->delegateBreadcrumb($entry['message'], 'log', $context);
-			}
-		} catch (Throwable $e) {
-			// make sure we dont hard crash if logging fails
-		}
-	}
-
-	public function getLogLevel(array $context, string $message): int {
-		if ($this->nestingLevel > 1) {
-			return ILogger::WARN;
-		}
-
-		$this->nestingLevel++;
-		/**
-		 * @psalm-var array{
-		 *   shared_secret?: string,
-		 *   users?: string[],
-		 *   apps?: string[],
-		 *   matches?: array<array-key, array{
-		 *     shared_secret?: string,
-		 *     users?: string[],
-		 *     apps?: string[],
-		 *     message?: string,
-		 *     loglevel: 0|1|2|3|4,
-		 *   }>
-		 * } $logCondition
-		 */
-		$logCondition = $this->config->getValue('log.condition', []);
-
-		$userId = false;
-
-		/**
-		 * check for a special log condition - this enables an increased log on
-		 * a per request/user base
-		 */
-		if ($this->logConditionSatisfied === null) {
-			// default to false to just process this once per request
-			$this->logConditionSatisfied = false;
-			if (!empty($logCondition)) {
-				// check for secret token in the request
-				if (isset($logCondition['shared_secret']) && $this->checkLogSecret($logCondition['shared_secret'])) {
-					$this->logConditionSatisfied = true;
-				}
-
-				// check for user
-				if (isset($logCondition['users'])) {
-					$user = \OCP\Server::get(IUserSession::class)->getUser();
-
-					if ($user === null) {
-						// User is not known for this request yet
-						$this->logConditionSatisfied = null;
-					} elseif (in_array($user->getUID(), $logCondition['users'], true)) {
-						// if the user matches set the log condition to satisfied
-						$this->logConditionSatisfied = true;
-					} else {
-						$userId = $user->getUID();
-					}
-				}
-			}
-		}
-
-		// if log condition is satisfied change the required log level to DEBUG
-		if ($this->logConditionSatisfied) {
-			$this->nestingLevel--;
-			return ILogger::DEBUG;
-		}
-
-		if ($userId === false && isset($logCondition['matches'])) {
-			$user = \OCP\Server::get(IUserSession::class)->getUser();
-			$userId = $user === null ? false : $user->getUID();
-		}
-
-		if (isset($context['app'])) {
-			/**
-			 * check log condition based on the context of each log message
-			 * once this is met -> change the required log level to debug
-			 */
-			if (in_array($context['app'], $logCondition['apps'] ?? [], true)) {
-				$this->nestingLevel--;
-				return ILogger::DEBUG;
-			}
-		}
-
-		if (!isset($logCondition['matches'])) {
-			$configLogLevel = $this->config->getValue('loglevel', ILogger::WARN);
-			if (is_numeric($configLogLevel)) {
-				$this->nestingLevel--;
-				return min((int)$configLogLevel, ILogger::FATAL);
-			}
-
-			// Invalid configuration, warn the user and fall back to default level of WARN
-			error_log('Nextcloud configuration: "loglevel" is not a valid integer');
-			$this->nestingLevel--;
-			return ILogger::WARN;
-		}
-
-		foreach ($logCondition['matches'] as $option) {
-			if (
-				(!isset($option['shared_secret']) || $this->checkLogSecret($option['shared_secret']))
-				&& (!isset($option['users']) || in_array($userId, $option['users'], true))
-				&& (!isset($option['apps']) || (isset($context['app']) && in_array($context['app'], $option['apps'], true)))
-				&& (!isset($option['message']) || str_contains($message, $option['message']))
-			) {
-				if (!isset($option['apps']) && !isset($option['loglevel']) && !isset($option['message'])) {
-					/* Only user and/or secret are listed as conditions, we can cache the result for the rest of the request */
-					$this->logConditionSatisfied = true;
-					$this->nestingLevel--;
-					return ILogger::DEBUG;
-				}
-				$this->nestingLevel--;
-				return $option['loglevel'] ?? ILogger::DEBUG;
-			}
-		}
-
-		$this->nestingLevel--;
-		return ILogger::WARN;
-	}
-
-	protected function checkLogSecret(string $conditionSecret): bool {
-		$request = \OCP\Server::get(IRequest::class);
-
-		if ($request->getMethod() === 'PUT'
-			&& !str_contains($request->getHeader('Content-Type'), 'application/x-www-form-urlencoded')
-			&& !str_contains($request->getHeader('Content-Type'), 'application/json')) {
-			return hash_equals($conditionSecret, '');
-		}
-
-		// if token is found in the request change set the log condition to satisfied
-		return hash_equals($conditionSecret, $request->getParam('log_secret', ''));
-	}
-
-	/**
-	 * Logs an exception very detailed
-	 *
-	 * @param Exception|Throwable $exception
-	 * @param array $context
-	 * @return void
-	 * @since 8.2.0
-	 */
-	public function logException(Throwable $exception, array $context = []): void {
-		$app = $context['app'] ?? 'no app in context';
-		$level = $context['level'] ?? ILogger::ERROR;
-
-		$minLevel = $this->getLogLevel($context, $context['message'] ?? $exception->getMessage());
-		if ($level < $minLevel
-			&& (($this->crashReporters?->hasReporters() ?? false) === false)
-			&& (($this->eventDispatcher?->hasListeners(BeforeMessageLoggedEvent::class) ?? false) === false)) {
-			return; // no crash reporter, no listeners, we can stop for lower log level
-		}
-
-		// if an error is raised before the autoloader is properly setup, we can't serialize exceptions
-		try {
-			$serializer = $this->getSerializer();
-		} catch (Throwable $e) {
-			$this->error('Failed to load ExceptionSerializer serializer while trying to log ' . $exception->getMessage());
-			return;
-		}
-
-		$context = array_map($this->normalizer->format(...), $context);
-		$data = $context;
-		unset($data['app'], $data['level']);
-
-		$data = array_merge($serializer->serializeException($exception), $data);
-		$data = $this->interpolateMessage($data, isset($context['message']) && $context['message'] !== '' ? $context['message'] : ('Exception thrown: ' . get_class($exception)), 'CustomMessage');
-
-		$this->eventDispatcher?->dispatchTyped(new BeforeMessageLoggedEvent($app, $level, $data));
-
-		try {
-			if ($level >= $minLevel) {
-				if (!$this->logger instanceof IFileBased) {
-					$data = json_encode($data, JSON_PARTIAL_OUTPUT_ON_ERROR | JSON_UNESCAPED_SLASHES);
-				}
-				$this->writeLog($app, $data, $level);
-			}
-
-			$context['level'] = $level;
-			if (!is_null($this->crashReporters)) {
-				$this->crashReporters->delegateReport($exception, $context);
-			}
-		} catch (Throwable $e) {
-			// make sure we dont hard crash if logging fails
-		}
-	}
-
-	public function logData(string $message, array $data, array $context = []): void {
-		$app = $context['app'] ?? 'no app in context';
-		$level = $context['level'] ?? ILogger::ERROR;
-
-		$minLevel = $this->getLogLevel($context, $message);
-		$data = array_map($this->normalizer->format(...), $data);
-
-		try {
-			if ($level >= $minLevel) {
-				$data['message'] = $message;
-				if (!$this->logger instanceof IFileBased) {
-					$data = json_encode($data, JSON_PARTIAL_OUTPUT_ON_ERROR | JSON_UNESCAPED_SLASHES);
-				}
-				$this->writeLog($app, $data, $level);
-			}
-		} catch (Throwable $e) {
-			// make sure we dont hard crash if logging fails
-			error_log('Error when trying to log exception: ' . $e->getMessage() . ' ' . $e->getTraceAsString());
-		}
-	}
-
-	/**
-	 * @param string $app
-	 * @param string|array $entry
-	 * @param int $level
-	 */
-	protected function writeLog(string $app, $entry, int $level): void {
-		$this->logger->write($app, $entry, $level);
-	}
-
-	public function getLogPath():string {
-		if ($this->logger instanceof IFileBased) {
-			return $this->logger->getLogFilePath();
-		}
-		throw new \RuntimeException('Log implementation has no path');
-	}
-
-	/**
-	 * Interpolate $message as defined in PSR-3
-	 *
-	 * Returns an array containing the context without the interpolated
-	 * parameters placeholders and the message as the 'message' - or
-	 * user-defined - key.
-	 */
-	private function interpolateMessage(array $context, string $message, string $messageKey = 'message'): array {
-		$replace = [];
-		$usedContextKeys = [];
-		foreach ($context as $key => $val) {
-			$fullKey = '{' . $key . '}';
-			$replace[$fullKey] = $val;
-			if (str_contains($message, $fullKey)) {
-				$usedContextKeys[$key] = true;
-			}
-		}
-		return array_merge(array_diff_key($context, $usedContextKeys), [$messageKey => strtr($message, $replace)]);
-	}
-
-	/**
-	 * @throws Throwable
-	 */
-	protected function getSerializer(): ExceptionSerializer {
-		$serializer = new ExceptionSerializer($this->config);
-		try {
-			/** @var Coordinator $coordinator */
-			$coordinator = \OCP\Server::get(Coordinator::class);
-			foreach ($coordinator->getRegistrationContext()->getSensitiveMethods() as $registration) {
-				$serializer->enlistSensitiveMethods($registration->getName(), $registration->getValue());
-			}
-			// For not every app might be initialized at this time, we cannot assume that the return value
-			// of getSensitiveMethods() is complete. Running delegates in Coordinator::registerApps() is
-			// not possible due to dependencies on the one hand. On the other it would work only with
-			// adding public methods to the PsrLoggerAdapter and this class.
-			// Thus, serializer cannot be a property.
-		} catch (Throwable $t) {
-			// ignore app-defined sensitive methods in this case - they weren't loaded anyway
-		}
-		return $serializer;
-	}
+    private ?bool $logConditionSatisfied = null;
+    private ?IEventDispatcher $eventDispatcher = null;
+    private int $nestingLevel = 0;
+
+    public function __construct(
+        private IWriter $logger,
+        private SystemConfig $config,
+        private Normalizer $normalizer = new Normalizer(),
+        private ?IRegistry $crashReporters = null,
+    ) {
+    }
+
+    public function setEventDispatcher(IEventDispatcher $eventDispatcher): void {
+        $this->eventDispatcher = $eventDispatcher;
+    }
+
+    /**
+     * System is unusable.
+     *
+     * @param string $message
+     * @param array $context
+     */
+    public function emergency(string $message, array $context = []): void {
+        $this->log(ILogger::FATAL, $message, $context);
+    }
+
+    /**
+     * Action must be taken immediately.
+     *
+     * Example: Entire website down, database unavailable, etc. This should
+     * trigger the SMS alerts and wake you up.
+     *
+     * @param string $message
+     * @param array $context
+     */
+    public function alert(string $message, array $context = []): void {
+        $this->log(ILogger::ERROR, $message, $context);
+    }
+
+    /**
+     * Critical conditions.
+     *
+     * Example: Application component unavailable, unexpected exception.
+     *
+     * @param string $message
+     * @param array $context
+     */
+    public function critical(string $message, array $context = []): void {
+        $this->log(ILogger::ERROR, $message, $context);
+    }
+
+    /**
+     * Runtime errors that do not require immediate action but should typically
+     * be logged and monitored.
+     *
+     * @param string $message
+     * @param array $context
+     */
+    public function error(string $message, array $context = []): void {
+        $this->log(ILogger::ERROR, $message, $context);
+    }
+
+    /**
+     * Exceptional occurrences that are not errors.
+     *
+     * Example: Use of deprecated APIs, poor use of an API, undesirable things
+     * that are not necessarily wrong.
+     *
+     * @param string $message
+     * @param array $context
+     */
+    public function warning(string $message, array $context = []): void {
+        $this->log(ILogger::WARN, $message, $context);
+    }
+
+    /**
+     * Normal but significant events.
+     *
+     * @param string $message
+     * @param array $context
+     */
+    public function notice(string $message, array $context = []): void {
+        $this->log(ILogger::INFO, $message, $context);
+    }
+
+    /**
+     * Interesting events.
+     *
+     * Example: User logs in, SQL logs.
+     *
+     * @param string $message
+     * @param array $context
+     */
+    public function info(string $message, array $context = []): void {
+        $this->log(ILogger::INFO, $message, $context);
+    }
+
+    /**
+     * Detailed debug information.
+     *
+     * @param string $message
+     * @param array $context
+     */
+    public function debug(string $message, array $context = []): void {
+        $this->log(ILogger::DEBUG, $message, $context);
+    }
+
+
+    /**
+     * Logs with an arbitrary level.
+     *
+     * @param int $level
+     * @param string $message
+     * @param array $context
+     */
+    public function log(int $level, string $message, array $context = []): void {
+        $minLevel = $this->getLogLevel($context, $message);
+        if ($level < $minLevel
+            && (($this->crashReporters?->hasReporters() ?? false) === false)
+            && (($this->eventDispatcher?->hasListeners(BeforeMessageLoggedEvent::class) ?? false) === false)) {
+            return; // no crash reporter, no listeners, we can stop for lower log level
+        }
+
+        $context = array_map($this->normalizer->format(...), $context);
+
+        $app = $context['app'] ?? 'no app in context';
+        $entry = $this->interpolateMessage($context, $message);
+
+        $this->eventDispatcher?->dispatchTyped(new BeforeMessageLoggedEvent($app, $level, $entry));
+
+        $hasBacktrace = isset($entry['exception']);
+        $logBacktrace = $this->config->getValue('log.backtrace', false);
+        if (!$hasBacktrace && $logBacktrace) {
+            $entry['backtrace'] = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
+        }
+
+        try {
+            if ($level >= $minLevel) {
+                $this->writeLog($app, $entry, $level);
+
+                if ($this->crashReporters !== null) {
+                    $messageContext = array_merge(
+                        $context,
+                        [
+                            'level' => $level
+                        ]
+                    );
+                    $this->crashReporters->delegateMessage($entry['message'], $messageContext);
+                }
+            } else {
+                $this->crashReporters?->delegateBreadcrumb($entry['message'], 'log', $context);
+            }
+        } catch (Throwable $e) {
+            // make sure we dont hard crash if logging fails
+        }
+    }
+
+    public function getLogLevel(array $context, string $message): int {
+        if ($this->nestingLevel > 1) {
+            return ILogger::WARN;
+        }
+
+        $this->nestingLevel++;
+        /**
+         * @psalm-var array{
+         *   shared_secret?: string,
+         *   users?: string[],
+         *   apps?: string[],
+         *   matches?: array<array-key, array{
+         *     shared_secret?: string,
+         *     users?: string[],
+         *     apps?: string[],
+         *     message?: string,
+         *     loglevel: 0|1|2|3|4,
+         *   }>
+         * } $logCondition
+         */
+        $logCondition = $this->config->getValue('log.condition', []);
+
+        $userId = false;
+
+        /**
+         * check for a special log condition - this enables an increased log on
+         * a per request/user base
+         */
+        if ($this->logConditionSatisfied === null) {
+            // default to false to just process this once per request
+            $this->logConditionSatisfied = false;
+            if (!empty($logCondition)) {
+                // check for secret token in the request
+                if (isset($logCondition['shared_secret']) && $this->checkLogSecret($logCondition['shared_secret'])) {
+                    $this->logConditionSatisfied = true;
+                }
+
+                // check for user
+                if (isset($logCondition['users'])) {
+                    $user = \OCP\Server::get(IUserSession::class)->getUser();
+
+                    if ($user === null) {
+                        // User is not known for this request yet
+                        $this->logConditionSatisfied = null;
+                    } elseif (in_array($user->getUID(), $logCondition['users'], true)) {
+                        // if the user matches set the log condition to satisfied
+                        $this->logConditionSatisfied = true;
+                    } else {
+                        $userId = $user->getUID();
+                    }
+                }
+            }
+        }
+
+        // if log condition is satisfied change the required log level to DEBUG
+        if ($this->logConditionSatisfied) {
+            $this->nestingLevel--;
+            return ILogger::DEBUG;
+        }
+
+        if ($userId === false && isset($logCondition['matches'])) {
+            $user = \OCP\Server::get(IUserSession::class)->getUser();
+            $userId = $user === null ? false : $user->getUID();
+        }
+
+        if (isset($context['app'])) {
+            /**
+             * check log condition based on the context of each log message
+             * once this is met -> change the required log level to debug
+             */
+            if (in_array($context['app'], $logCondition['apps'] ?? [], true)) {
+                $this->nestingLevel--;
+                return ILogger::DEBUG;
+            }
+        }
+
+        if (!isset($logCondition['matches'])) {
+            $configLogLevel = $this->config->getValue('loglevel', ILogger::WARN);
+            if (is_numeric($configLogLevel)) {
+                $this->nestingLevel--;
+                return min((int)$configLogLevel, ILogger::FATAL);
+            }
+
+            // Invalid configuration, warn the user and fall back to default level of WARN
+            error_log('Nextcloud configuration: "loglevel" is not a valid integer');
+            $this->nestingLevel--;
+            return ILogger::WARN;
+        }
+
+        foreach ($logCondition['matches'] as $option) {
+            if (
+                (!isset($option['shared_secret']) || $this->checkLogSecret($option['shared_secret']))
+                && (!isset($option['users']) || in_array($userId, $option['users'], true))
+                && (!isset($option['apps']) || (isset($context['app']) && in_array($context['app'], $option['apps'], true)))
+                && (!isset($option['message']) || str_contains($message, $option['message']))
+            ) {
+                if (!isset($option['apps']) && !isset($option['loglevel']) && !isset($option['message'])) {
+                    /* Only user and/or secret are listed as conditions, we can cache the result for the rest of the request */
+                    $this->logConditionSatisfied = true;
+                    $this->nestingLevel--;
+                    return ILogger::DEBUG;
+                }
+                $this->nestingLevel--;
+                return $option['loglevel'] ?? ILogger::DEBUG;
+            }
+        }
+
+        $this->nestingLevel--;
+        return ILogger::WARN;
+    }
+
+    protected function checkLogSecret(string $conditionSecret): bool {
+        $request = \OCP\Server::get(IRequest::class);
+
+        if ($request->getMethod() === 'PUT'
+            && !str_contains($request->getHeader('Content-Type'), 'application/x-www-form-urlencoded')
+            && !str_contains($request->getHeader('Content-Type'), 'application/json')) {
+            return hash_equals($conditionSecret, '');
+        }
+
+        // if token is found in the request change set the log condition to satisfied
+        return hash_equals($conditionSecret, $request->getParam('log_secret', ''));
+    }
+
+    /**
+     * Logs an exception very detailed
+     *
+     * @param Exception|Throwable $exception
+     * @param array $context
+     * @return void
+     * @since 8.2.0
+     */
+    public function logException(Throwable $exception, array $context = []): void {
+        $app = $context['app'] ?? 'no app in context';
+        $level = $context['level'] ?? ILogger::ERROR;
+
+        $minLevel = $this->getLogLevel($context, $context['message'] ?? $exception->getMessage());
+        if ($level < $minLevel
+            && (($this->crashReporters?->hasReporters() ?? false) === false)
+            && (($this->eventDispatcher?->hasListeners(BeforeMessageLoggedEvent::class) ?? false) === false)) {
+            return; // no crash reporter, no listeners, we can stop for lower log level
+        }
+
+        // if an error is raised before the autoloader is properly setup, we can't serialize exceptions
+        try {
+            $serializer = $this->getSerializer();
+        } catch (Throwable $e) {
+            $this->error('Failed to load ExceptionSerializer serializer while trying to log ' . $exception->getMessage());
+            return;
+        }
+
+        $context = array_map($this->normalizer->format(...), $context);
+        $data = $context;
+        unset($data['app'], $data['level']);
+
+        $data = array_merge($serializer->serializeException($exception), $data);
+        $data = $this->interpolateMessage($data, isset($context['message']) && $context['message'] !== '' ? $context['message'] : ('Exception thrown: ' . get_class($exception)), 'CustomMessage');
+
+        $this->eventDispatcher?->dispatchTyped(new BeforeMessageLoggedEvent($app, $level, $data));
+
+        try {
+            if ($level >= $minLevel) {
+                if (!$this->logger instanceof IFileBased) {
+                    $data = json_encode($data, JSON_PARTIAL_OUTPUT_ON_ERROR | JSON_UNESCAPED_SLASHES);
+                }
+                $this->writeLog($app, $data, $level);
+            }
+
+            $context['level'] = $level;
+            if (!is_null($this->crashReporters)) {
+                $this->crashReporters->delegateReport($exception, $context);
+            }
+        } catch (Throwable $e) {
+            // make sure we dont hard crash if logging fails
+        }
+    }
+
+    public function logData(string $message, array $data, array $context = []): void {
+        $app = $context['app'] ?? 'no app in context';
+        $level = $context['level'] ?? ILogger::ERROR;
+
+        $minLevel = $this->getLogLevel($context, $message);
+        $data = array_map($this->normalizer->format(...), $data);
+
+        try {
+            if ($level >= $minLevel) {
+                $data['message'] = $message;
+                if (!$this->logger instanceof IFileBased) {
+                    $data = json_encode($data, JSON_PARTIAL_OUTPUT_ON_ERROR | JSON_UNESCAPED_SLASHES);
+                }
+                $this->writeLog($app, $data, $level);
+            }
+        } catch (Throwable $e) {
+            // make sure we dont hard crash if logging fails
+            error_log('Error when trying to log exception: ' . $e->getMessage() . ' ' . $e->getTraceAsString());
+        }
+    }
+
+    /**
+     * @param string $app
+     * @param string|array $entry
+     * @param int $level
+     */
+    protected function writeLog(string $app, $entry, int $level): void {
+        $this->logger->write($app, $entry, $level);
+    }
+
+    public function getLogPath():string {
+        if ($this->logger instanceof IFileBased) {
+            return $this->logger->getLogFilePath();
+        }
+        throw new \RuntimeException('Log implementation has no path');
+    }
+
+    /**
+     * Interpolate $message as defined in PSR-3
+     *
+     * Returns an array containing the context without the interpolated
+     * parameters placeholders and the message as the 'message' - or
+     * user-defined - key.
+     */
+    private function interpolateMessage(array $context, string $message, string $messageKey = 'message'): array {
+        $replace = [];
+        $usedContextKeys = [];
+        foreach ($context as $key => $val) {
+            $fullKey = '{' . $key . '}';
+            $replace[$fullKey] = $val;
+            if (str_contains($message, $fullKey)) {
+                $usedContextKeys[$key] = true;
+            }
+        }
+        return array_merge(array_diff_key($context, $usedContextKeys), [$messageKey => strtr($message, $replace)]);
+    }
+
+    /**
+     * @throws Throwable
+     */
+    protected function getSerializer(): ExceptionSerializer {
+        $serializer = new ExceptionSerializer($this->config);
+        try {
+            /** @var Coordinator $coordinator */
+            $coordinator = \OCP\Server::get(Coordinator::class);
+            foreach ($coordinator->getRegistrationContext()->getSensitiveMethods() as $registration) {
+                $serializer->enlistSensitiveMethods($registration->getName(), $registration->getValue());
+            }
+            // For not every app might be initialized at this time, we cannot assume that the return value
+            // of getSensitiveMethods() is complete. Running delegates in Coordinator::registerApps() is
+            // not possible due to dependencies on the one hand. On the other it would work only with
+            // adding public methods to the PsrLoggerAdapter and this class.
+            // Thus, serializer cannot be a property.
+        } catch (Throwable $t) {
+            // ignore app-defined sensitive methods in this case - they weren't loaded anyway
+        }
+        return $serializer;
+    }
 }

Spacing +5 added lines, -5 removed lines

@@ -272,7 +272,7 @@ 
 			$configLogLevel = $this->config->getValue('loglevel', ILogger::WARN);
 			if (is_numeric($configLogLevel)) {
 				$this->nestingLevel--;
-				return min((int)$configLogLevel, ILogger::FATAL);
+				return min((int) $configLogLevel, ILogger::FATAL);
 			}
 
 			// Invalid configuration, warn the user and fall back to default level of WARN
@@ -339,7 +339,7 @@ 
 		try {
 			$serializer = $this->getSerializer();
 		} catch (Throwable $e) {
-			$this->error('Failed to load ExceptionSerializer serializer while trying to log ' . $exception->getMessage());
+			$this->error('Failed to load ExceptionSerializer serializer while trying to log '.$exception->getMessage());
 			return;
 		}
 
@@ -348,7 +348,7 @@ 
 		unset($data['app'], $data['level']);
 
 		$data = array_merge($serializer->serializeException($exception), $data);
-		$data = $this->interpolateMessage($data, isset($context['message']) && $context['message'] !== '' ? $context['message'] : ('Exception thrown: ' . get_class($exception)), 'CustomMessage');
+		$data = $this->interpolateMessage($data, isset($context['message']) && $context['message'] !== '' ? $context['message'] : ('Exception thrown: '.get_class($exception)), 'CustomMessage');
 
 		$this->eventDispatcher?->dispatchTyped(new BeforeMessageLoggedEvent($app, $level, $data));
 
@@ -386,7 +386,7 @@ 
 			}
 		} catch (Throwable $e) {
 			// make sure we dont hard crash if logging fails
-			error_log('Error when trying to log exception: ' . $e->getMessage() . ' ' . $e->getTraceAsString());
+			error_log('Error when trying to log exception: '.$e->getMessage().' '.$e->getTraceAsString());
 		}
 	}
 
@@ -417,7 +417,7 @@ 
 		$replace = [];
 		$usedContextKeys = [];
 		foreach ($context as $key => $val) {
-			$fullKey = '{' . $key . '}';
+			$fullKey = '{'.$key.'}';
 			$replace[$fullKey] = $val;
 			if (str_contains($message, $fullKey)) {
 				$usedContextKeys[$key] = true;

lib/versioncheck.php

Indentation +8 added lines, -8 removed lines

@@ -7,16 +7,16 @@
  */
 // Show warning if a PHP version below 8.2 is used,
 if (PHP_VERSION_ID < 80200) {
-	http_response_code(500);
-	echo 'This version of Nextcloud requires at least PHP 8.2<br/>';
-	echo 'You are currently running ' . PHP_VERSION . '. Please update your PHP version.';
-	exit(1);
+    http_response_code(500);
+    echo 'This version of Nextcloud requires at least PHP 8.2<br/>';
+    echo 'You are currently running ' . PHP_VERSION . '. Please update your PHP version.';
+    exit(1);
 }
 
 // Show warning if >= PHP 8.6 is used as Nextcloud is not compatible with >= PHP 8.6 for now
 if (PHP_VERSION_ID >= 80600) {
-	http_response_code(500);
-	echo 'This version of Nextcloud is not compatible with PHP>=8.6.<br/>';
-	echo 'You are currently running ' . PHP_VERSION . '.';
-	exit(1);
+    http_response_code(500);
+    echo 'This version of Nextcloud is not compatible with PHP>=8.6.<br/>';
+    echo 'You are currently running ' . PHP_VERSION . '.';
+    exit(1);
 }

Spacing +2 added lines, -2 removed lines

@@ -9,7 +9,7 @@ 
 if (PHP_VERSION_ID < 80200) {
 	http_response_code(500);
 	echo 'This version of Nextcloud requires at least PHP 8.2<br/>';
-	echo 'You are currently running ' . PHP_VERSION . '. Please update your PHP version.';
+	echo 'You are currently running '.PHP_VERSION.'. Please update your PHP version.';
 	exit(1);
 }
 
@@ -17,6 +17,6 @@ 
 if (PHP_VERSION_ID >= 80600) {
 	http_response_code(500);
 	echo 'This version of Nextcloud is not compatible with PHP>=8.6.<br/>';
-	echo 'You are currently running ' . PHP_VERSION . '.';
+	echo 'You are currently running '.PHP_VERSION.'.';
 	exit(1);
 }

apps/files_sharing/tests/SharedMountTest.php

Indentation +394 added lines, -394 removed lines

@@ -26,406 +26,406 @@
 #[\PHPUnit\Framework\Attributes\Group('SLOWDB')]
 class SharedMountTest extends TestCase {
 
-	/** @var IGroupManager */
-	private $groupManager;
+    /** @var IGroupManager */
+    private $groupManager;
 
-	/** @var IUserManager */
-	private $userManager;
+    /** @var IUserManager */
+    private $userManager;
 
-	private $folder2;
-
-	protected function setUp(): void {
-		parent::setUp();
+    private $folder2;
+
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->folder = '/folder_share_storage_test';
-		$this->folder2 = '/folder_share_storage_test2';
+        $this->folder = '/folder_share_storage_test';
+        $this->folder2 = '/folder_share_storage_test2';
 
-		$this->filename = '/share-api-storage.txt';
-
-
-		$this->view->mkdir($this->folder);
-		$this->view->mkdir($this->folder2);
-
-		// save file with content
-		$this->view->file_put_contents($this->filename, 'root file');
-		$this->view->file_put_contents($this->folder . $this->filename, 'file in subfolder');
-		$this->view->file_put_contents($this->folder2 . $this->filename, 'file in subfolder2');
-
-		$this->groupManager = Server::get(IGroupManager::class);
-		$this->userManager = Server::get(IUserManager::class);
-	}
-
-	protected function tearDown(): void {
-		if ($this->view) {
-			if ($this->view->file_exists($this->folder)) {
-				$this->view->unlink($this->folder);
-			}
-			if ($this->view->file_exists($this->filename)) {
-				$this->view->unlink($this->filename);
-			}
-		}
-
-		parent::tearDown();
-	}
-
-	/**
-	 * test if the mount point moves up if the parent folder no longer exists
-	 */
-	public function testShareMountLoseParentFolder(): void {
-
-		// share to user
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL);
-		$this->shareManager->acceptShare($share, self::TEST_FILES_SHARING_API_USER2);
-
-		$share->setTarget('/foo/bar' . $this->folder);
-		$this->shareManager->moveShare($share, self::TEST_FILES_SHARING_API_USER2);
-
-		$share = $this->shareManager->getShareById($share->getFullId());
-		$this->assertSame('/foo/bar' . $this->folder, $share->getTarget());
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		// share should have moved up
-
-		$share = $this->shareManager->getShareById($share->getFullId());
-		$this->assertSame($this->folder, $share->getTarget());
-
-		//cleanup
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$this->shareManager->deleteShare($share);
-		$this->view->unlink($this->folder);
-	}
-
-	public function testDeleteParentOfMountPoint(): void {
-		// share to user
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL
-		);
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		$user2View = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
-		$this->assertTrue($user2View->file_exists($this->folder));
-
-		// create a local folder
-		$result = $user2View->mkdir('localfolder');
-		$this->assertTrue($result);
-
-		// move mount point to local folder
-		$result = $user2View->rename($this->folder, '/localfolder/' . $this->folder);
-		$this->assertTrue($result);
-
-		// mount point in the root folder should no longer exist
-		$this->assertFalse($user2View->is_dir($this->folder));
-
-		// delete the local folder
-		$result = $user2View->unlink('/localfolder');
-		$this->assertTrue($result);
-
-		//enforce reload of the mount points
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		//mount point should be back at the root
-		$this->assertTrue($user2View->is_dir($this->folder));
-
-		//cleanup
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$this->view->unlink($this->folder);
-	}
-
-	public function testMoveSharedFile(): void {
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->filename,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE
-		);
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		Filesystem::rename($this->filename, $this->filename . '_renamed');
-
-		$this->assertTrue(Filesystem::file_exists($this->filename . '_renamed'));
-		$this->assertFalse(Filesystem::file_exists($this->filename));
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$this->assertTrue(Filesystem::file_exists($this->filename));
-		$this->assertFalse(Filesystem::file_exists($this->filename . '_renamed'));
-
-		// rename back to original name
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		Filesystem::rename($this->filename . '_renamed', $this->filename);
-		$this->assertFalse(Filesystem::file_exists($this->filename . '_renamed'));
-		$this->assertTrue(Filesystem::file_exists($this->filename));
-
-		//cleanup
-		$this->shareManager->deleteShare($share);
-	}
-
-	/**
-	 * share file with a group if a user renames the file the filename should not change
-	 * for the other users
-	 */
-	public function testMoveGroupShare(): void {
-		$testGroup = $this->groupManager->createGroup('testGroup');
-		$user1 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER1);
-		$user2 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER2);
-		$user3 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER3);
-		$testGroup->addUser($user1);
-		$testGroup->addUser($user2);
-		$testGroup->addUser($user3);
-
-		$fileinfo = $this->view->getFileInfo($this->filename);
-		$share = $this->share(
-			IShare::TYPE_GROUP,
-			$this->filename,
-			self::TEST_FILES_SHARING_API_USER1,
-			'testGroup',
-			Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE
-		);
-		$this->shareManager->acceptShare($share, $user1->getUID());
-		$this->shareManager->acceptShare($share, $user2->getUID());
-		$this->shareManager->acceptShare($share, $user3->getUID());
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-
-		$this->assertTrue(Filesystem::file_exists($this->filename));
-
-		Filesystem::rename($this->filename, 'newFileName');
-
-		$this->assertTrue(Filesystem::file_exists('newFileName'));
-		$this->assertFalse(Filesystem::file_exists($this->filename));
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER3);
-		$this->assertTrue(Filesystem::file_exists($this->filename));
-		$this->assertFalse(Filesystem::file_exists('newFileName'));
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER3);
-		$this->assertTrue(Filesystem::file_exists($this->filename));
-		$this->assertFalse(Filesystem::file_exists('newFileName'));
-
-		//cleanup
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$this->shareManager->deleteShare($share);
-		$testGroup->removeUser($user1);
-		$testGroup->removeUser($user2);
-		$testGroup->removeUser($user3);
-	}
-
-	/**
-	 * @param string $path
-	 * @param string $expectedResult
-	 * @param bool $exception if a exception is expected
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataProviderTestStripUserFilesPath')]
-	public function testStripUserFilesPath($path, $expectedResult, $exception): void {
-		$testClass = new DummyTestClassSharedMount(null, null);
-		try {
-			$result = $testClass->stripUserFilesPathDummy($path);
-			$this->assertSame($expectedResult, $result);
-		} catch (\Exception $e) {
-			if ($exception) {
-				$this->assertSame(10, $e->getCode());
-			} else {
-				$this->assertTrue(false, 'Exception caught, but expected: ' . $expectedResult);
-			}
-		}
-	}
-
-	public static function dataProviderTestStripUserFilesPath() {
-		return [
-			['/user/files/foo.txt', '/foo.txt', false],
-			['/user/files/folder/foo.txt', '/folder/foo.txt', false],
-			['/data/user/files/foo.txt', null, true],
-			['/data/user/files/', null, true],
-			['/files/foo.txt', null, true],
-			['/foo.txt', null, true],
-		];
-	}
-
-	/**
-	 * If the permissions on a group share are upgraded be sure to still respect
-	 * removed shares by a member of that group
-	 */
-	public function testPermissionUpgradeOnUserDeletedGroupShare(): void {
-		$testGroup = $this->groupManager->createGroup('testGroup');
-		$user1 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER1);
-		$user2 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER2);
-		$user3 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER3);
-		$testGroup->addUser($user1);
-		$testGroup->addUser($user2);
-		$testGroup->addUser($user3);
-
-		$connection = Server::get(IDBConnection::class);
-
-		// Share item with group
-		$fileinfo = $this->view->getFileInfo($this->folder);
-		$share = $this->share(
-			IShare::TYPE_GROUP,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			'testGroup',
-			Constants::PERMISSION_READ
-		);
-		$this->shareManager->acceptShare($share, $user1->getUID());
-		$this->shareManager->acceptShare($share, $user2->getUID());
-		$this->shareManager->acceptShare($share, $user3->getUID());
-
-		// Login as user 2 and verify the item exists
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		$this->assertTrue(Filesystem::file_exists($this->folder));
-		$result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2);
-		$this->assertNotEmpty($result);
-		$this->assertEquals(Constants::PERMISSION_READ, $result->getPermissions());
-
-		// Delete the share
-		$this->assertTrue(Filesystem::rmdir($this->folder));
-		$this->assertFalse(Filesystem::file_exists($this->folder));
-
-		// Verify we do not get a share
-		$result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2);
-		$this->assertEquals(0, $result->getPermissions());
-
-		// Login as user 1 again and change permissions
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$share->setPermissions(Constants::PERMISSION_ALL);
-		$share = $this->shareManager->updateShare($share);
-
-		// Login as user 2 and verify
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		$this->assertFalse(Filesystem::file_exists($this->folder));
-		$result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2);
-		$this->assertEquals(0, $result->getPermissions());
-
-		$this->shareManager->deleteShare($share);
-
-		//cleanup
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$testGroup->removeUser($user1);
-		$testGroup->removeUser($user2);
-		$testGroup->removeUser($user3);
-	}
-
-	/**
-	 * test if the mount point gets renamed if a folder exists at the target
-	 */
-	public function testShareMountOverFolder(): void {
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		$this->view2->mkdir('bar');
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-
-		// share to user
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL);
-		$this->shareManager->acceptShare($share, self::TEST_FILES_SHARING_API_USER2);
-
-		$share->setTarget('/bar');
-		$this->shareManager->moveShare($share, self::TEST_FILES_SHARING_API_USER2);
-
-		$share = $this->shareManager->getShareById($share->getFullId());
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		// share should have been moved
-
-		$share = $this->shareManager->getShareById($share->getFullId());
-		$this->assertSame('/bar (2)', $share->getTarget());
-
-		//cleanup
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$this->shareManager->deleteShare($share);
-		$this->view->unlink($this->folder);
-	}
-
-	/**
-	 * test if the mount point gets renamed if another share exists at the target
-	 */
-	public function testShareMountOverShare(): void {
-		// create a shared cache
-		$caches = [];
-		$cacheFactory = $this->createMock(ICacheFactory::class);
-		$cacheFactory->method('createLocal')
-			->willReturnCallback(function (string $prefix) use (&$caches) {
-				if (!isset($caches[$prefix])) {
-					$caches[$prefix] = new ArrayCache($prefix);
-				}
-				return $caches[$prefix];
-			});
-		$cacheFactory->method('createDistributed')
-			->willReturnCallback(function (string $prefix) use (&$caches) {
-				if (!isset($caches[$prefix])) {
-					$caches[$prefix] = new ArrayCache($prefix);
-				}
-				return $caches[$prefix];
-			});
-
-		// hack to overwrite the cache factory, we can't use the proper "overwriteService" since the mount provider is created before this test is called
-		$mountProvider = Server::get(MountProvider::class);
-		$reflectionClass = new \ReflectionClass($mountProvider);
-		$reflectionCacheFactory = $reflectionClass->getProperty('cacheFactory');
-		$reflectionCacheFactory->setValue($mountProvider, $cacheFactory);
-
-		// share to user
-		$share = $this->share(
-			IShare::TYPE_USER,
-			$this->folder,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL);
-		$this->shareManager->acceptShare($share, self::TEST_FILES_SHARING_API_USER2);
-
-		$share->setTarget('/foobar');
-		$this->shareManager->moveShare($share, self::TEST_FILES_SHARING_API_USER2);
-
-
-		// share to user
-		$share2 = $this->share(
-			IShare::TYPE_USER,
-			$this->folder2,
-			self::TEST_FILES_SHARING_API_USER1,
-			self::TEST_FILES_SHARING_API_USER2,
-			Constants::PERMISSION_ALL);
-		$this->shareManager->acceptShare($share2, self::TEST_FILES_SHARING_API_USER2);
-
-		$share2->setTarget('/foobar');
-		$this->shareManager->moveShare($share2, self::TEST_FILES_SHARING_API_USER2);
-
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-		// one of the shares should have been moved
-
-		$share = $this->shareManager->getShareById($share->getFullId());
-		$share2 = $this->shareManager->getShareById($share2->getFullId());
-
-		// we don't know or care which share got the "(2)" just that one of them did
-		$this->assertNotEquals($share->getTarget(), $share2->getTarget());
-		$this->assertSame('/foobar', min($share->getTarget(), $share2->getTarget()));
-		$this->assertSame('/foobar (2)', max($share->getTarget(), $share2->getTarget()));
-
-		//cleanup
-		self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
-		$this->shareManager->deleteShare($share);
-		$this->view->unlink($this->folder);
-	}
+        $this->filename = '/share-api-storage.txt';
+
+
+        $this->view->mkdir($this->folder);
+        $this->view->mkdir($this->folder2);
+
+        // save file with content
+        $this->view->file_put_contents($this->filename, 'root file');
+        $this->view->file_put_contents($this->folder . $this->filename, 'file in subfolder');
+        $this->view->file_put_contents($this->folder2 . $this->filename, 'file in subfolder2');
+
+        $this->groupManager = Server::get(IGroupManager::class);
+        $this->userManager = Server::get(IUserManager::class);
+    }
+
+    protected function tearDown(): void {
+        if ($this->view) {
+            if ($this->view->file_exists($this->folder)) {
+                $this->view->unlink($this->folder);
+            }
+            if ($this->view->file_exists($this->filename)) {
+                $this->view->unlink($this->filename);
+            }
+        }
+
+        parent::tearDown();
+    }
+
+    /**
+     * test if the mount point moves up if the parent folder no longer exists
+     */
+    public function testShareMountLoseParentFolder(): void {
+
+        // share to user
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL);
+        $this->shareManager->acceptShare($share, self::TEST_FILES_SHARING_API_USER2);
+
+        $share->setTarget('/foo/bar' . $this->folder);
+        $this->shareManager->moveShare($share, self::TEST_FILES_SHARING_API_USER2);
+
+        $share = $this->shareManager->getShareById($share->getFullId());
+        $this->assertSame('/foo/bar' . $this->folder, $share->getTarget());
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        // share should have moved up
+
+        $share = $this->shareManager->getShareById($share->getFullId());
+        $this->assertSame($this->folder, $share->getTarget());
+
+        //cleanup
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $this->shareManager->deleteShare($share);
+        $this->view->unlink($this->folder);
+    }
+
+    public function testDeleteParentOfMountPoint(): void {
+        // share to user
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL
+        );
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        $user2View = new View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files');
+        $this->assertTrue($user2View->file_exists($this->folder));
+
+        // create a local folder
+        $result = $user2View->mkdir('localfolder');
+        $this->assertTrue($result);
+
+        // move mount point to local folder
+        $result = $user2View->rename($this->folder, '/localfolder/' . $this->folder);
+        $this->assertTrue($result);
+
+        // mount point in the root folder should no longer exist
+        $this->assertFalse($user2View->is_dir($this->folder));
+
+        // delete the local folder
+        $result = $user2View->unlink('/localfolder');
+        $this->assertTrue($result);
+
+        //enforce reload of the mount points
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        //mount point should be back at the root
+        $this->assertTrue($user2View->is_dir($this->folder));
+
+        //cleanup
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $this->view->unlink($this->folder);
+    }
+
+    public function testMoveSharedFile(): void {
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->filename,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE
+        );
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        Filesystem::rename($this->filename, $this->filename . '_renamed');
+
+        $this->assertTrue(Filesystem::file_exists($this->filename . '_renamed'));
+        $this->assertFalse(Filesystem::file_exists($this->filename));
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $this->assertTrue(Filesystem::file_exists($this->filename));
+        $this->assertFalse(Filesystem::file_exists($this->filename . '_renamed'));
+
+        // rename back to original name
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        Filesystem::rename($this->filename . '_renamed', $this->filename);
+        $this->assertFalse(Filesystem::file_exists($this->filename . '_renamed'));
+        $this->assertTrue(Filesystem::file_exists($this->filename));
+
+        //cleanup
+        $this->shareManager->deleteShare($share);
+    }
+
+    /**
+     * share file with a group if a user renames the file the filename should not change
+     * for the other users
+     */
+    public function testMoveGroupShare(): void {
+        $testGroup = $this->groupManager->createGroup('testGroup');
+        $user1 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER1);
+        $user2 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER2);
+        $user3 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER3);
+        $testGroup->addUser($user1);
+        $testGroup->addUser($user2);
+        $testGroup->addUser($user3);
+
+        $fileinfo = $this->view->getFileInfo($this->filename);
+        $share = $this->share(
+            IShare::TYPE_GROUP,
+            $this->filename,
+            self::TEST_FILES_SHARING_API_USER1,
+            'testGroup',
+            Constants::PERMISSION_READ | Constants::PERMISSION_UPDATE | Constants::PERMISSION_SHARE
+        );
+        $this->shareManager->acceptShare($share, $user1->getUID());
+        $this->shareManager->acceptShare($share, $user2->getUID());
+        $this->shareManager->acceptShare($share, $user3->getUID());
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+
+        $this->assertTrue(Filesystem::file_exists($this->filename));
+
+        Filesystem::rename($this->filename, 'newFileName');
+
+        $this->assertTrue(Filesystem::file_exists('newFileName'));
+        $this->assertFalse(Filesystem::file_exists($this->filename));
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER3);
+        $this->assertTrue(Filesystem::file_exists($this->filename));
+        $this->assertFalse(Filesystem::file_exists('newFileName'));
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER3);
+        $this->assertTrue(Filesystem::file_exists($this->filename));
+        $this->assertFalse(Filesystem::file_exists('newFileName'));
+
+        //cleanup
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $this->shareManager->deleteShare($share);
+        $testGroup->removeUser($user1);
+        $testGroup->removeUser($user2);
+        $testGroup->removeUser($user3);
+    }
+
+    /**
+     * @param string $path
+     * @param string $expectedResult
+     * @param bool $exception if a exception is expected
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataProviderTestStripUserFilesPath')]
+    public function testStripUserFilesPath($path, $expectedResult, $exception): void {
+        $testClass = new DummyTestClassSharedMount(null, null);
+        try {
+            $result = $testClass->stripUserFilesPathDummy($path);
+            $this->assertSame($expectedResult, $result);
+        } catch (\Exception $e) {
+            if ($exception) {
+                $this->assertSame(10, $e->getCode());
+            } else {
+                $this->assertTrue(false, 'Exception caught, but expected: ' . $expectedResult);
+            }
+        }
+    }
+
+    public static function dataProviderTestStripUserFilesPath() {
+        return [
+            ['/user/files/foo.txt', '/foo.txt', false],
+            ['/user/files/folder/foo.txt', '/folder/foo.txt', false],
+            ['/data/user/files/foo.txt', null, true],
+            ['/data/user/files/', null, true],
+            ['/files/foo.txt', null, true],
+            ['/foo.txt', null, true],
+        ];
+    }
+
+    /**
+     * If the permissions on a group share are upgraded be sure to still respect
+     * removed shares by a member of that group
+     */
+    public function testPermissionUpgradeOnUserDeletedGroupShare(): void {
+        $testGroup = $this->groupManager->createGroup('testGroup');
+        $user1 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER1);
+        $user2 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER2);
+        $user3 = $this->userManager->get(self::TEST_FILES_SHARING_API_USER3);
+        $testGroup->addUser($user1);
+        $testGroup->addUser($user2);
+        $testGroup->addUser($user3);
+
+        $connection = Server::get(IDBConnection::class);
+
+        // Share item with group
+        $fileinfo = $this->view->getFileInfo($this->folder);
+        $share = $this->share(
+            IShare::TYPE_GROUP,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            'testGroup',
+            Constants::PERMISSION_READ
+        );
+        $this->shareManager->acceptShare($share, $user1->getUID());
+        $this->shareManager->acceptShare($share, $user2->getUID());
+        $this->shareManager->acceptShare($share, $user3->getUID());
+
+        // Login as user 2 and verify the item exists
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        $this->assertTrue(Filesystem::file_exists($this->folder));
+        $result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2);
+        $this->assertNotEmpty($result);
+        $this->assertEquals(Constants::PERMISSION_READ, $result->getPermissions());
+
+        // Delete the share
+        $this->assertTrue(Filesystem::rmdir($this->folder));
+        $this->assertFalse(Filesystem::file_exists($this->folder));
+
+        // Verify we do not get a share
+        $result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2);
+        $this->assertEquals(0, $result->getPermissions());
+
+        // Login as user 1 again and change permissions
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $share->setPermissions(Constants::PERMISSION_ALL);
+        $share = $this->shareManager->updateShare($share);
+
+        // Login as user 2 and verify
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        $this->assertFalse(Filesystem::file_exists($this->folder));
+        $result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2);
+        $this->assertEquals(0, $result->getPermissions());
+
+        $this->shareManager->deleteShare($share);
+
+        //cleanup
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $testGroup->removeUser($user1);
+        $testGroup->removeUser($user2);
+        $testGroup->removeUser($user3);
+    }
+
+    /**
+     * test if the mount point gets renamed if a folder exists at the target
+     */
+    public function testShareMountOverFolder(): void {
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        $this->view2->mkdir('bar');
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+
+        // share to user
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL);
+        $this->shareManager->acceptShare($share, self::TEST_FILES_SHARING_API_USER2);
+
+        $share->setTarget('/bar');
+        $this->shareManager->moveShare($share, self::TEST_FILES_SHARING_API_USER2);
+
+        $share = $this->shareManager->getShareById($share->getFullId());
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        // share should have been moved
+
+        $share = $this->shareManager->getShareById($share->getFullId());
+        $this->assertSame('/bar (2)', $share->getTarget());
+
+        //cleanup
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $this->shareManager->deleteShare($share);
+        $this->view->unlink($this->folder);
+    }
+
+    /**
+     * test if the mount point gets renamed if another share exists at the target
+     */
+    public function testShareMountOverShare(): void {
+        // create a shared cache
+        $caches = [];
+        $cacheFactory = $this->createMock(ICacheFactory::class);
+        $cacheFactory->method('createLocal')
+            ->willReturnCallback(function (string $prefix) use (&$caches) {
+                if (!isset($caches[$prefix])) {
+                    $caches[$prefix] = new ArrayCache($prefix);
+                }
+                return $caches[$prefix];
+            });
+        $cacheFactory->method('createDistributed')
+            ->willReturnCallback(function (string $prefix) use (&$caches) {
+                if (!isset($caches[$prefix])) {
+                    $caches[$prefix] = new ArrayCache($prefix);
+                }
+                return $caches[$prefix];
+            });
+
+        // hack to overwrite the cache factory, we can't use the proper "overwriteService" since the mount provider is created before this test is called
+        $mountProvider = Server::get(MountProvider::class);
+        $reflectionClass = new \ReflectionClass($mountProvider);
+        $reflectionCacheFactory = $reflectionClass->getProperty('cacheFactory');
+        $reflectionCacheFactory->setValue($mountProvider, $cacheFactory);
+
+        // share to user
+        $share = $this->share(
+            IShare::TYPE_USER,
+            $this->folder,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL);
+        $this->shareManager->acceptShare($share, self::TEST_FILES_SHARING_API_USER2);
+
+        $share->setTarget('/foobar');
+        $this->shareManager->moveShare($share, self::TEST_FILES_SHARING_API_USER2);
+
+
+        // share to user
+        $share2 = $this->share(
+            IShare::TYPE_USER,
+            $this->folder2,
+            self::TEST_FILES_SHARING_API_USER1,
+            self::TEST_FILES_SHARING_API_USER2,
+            Constants::PERMISSION_ALL);
+        $this->shareManager->acceptShare($share2, self::TEST_FILES_SHARING_API_USER2);
+
+        $share2->setTarget('/foobar');
+        $this->shareManager->moveShare($share2, self::TEST_FILES_SHARING_API_USER2);
+
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
+        // one of the shares should have been moved
+
+        $share = $this->shareManager->getShareById($share->getFullId());
+        $share2 = $this->shareManager->getShareById($share2->getFullId());
+
+        // we don't know or care which share got the "(2)" just that one of them did
+        $this->assertNotEquals($share->getTarget(), $share2->getTarget());
+        $this->assertSame('/foobar', min($share->getTarget(), $share2->getTarget()));
+        $this->assertSame('/foobar (2)', max($share->getTarget(), $share2->getTarget()));
+
+        //cleanup
+        self::loginHelper(self::TEST_FILES_SHARING_API_USER1);
+        $this->shareManager->deleteShare($share);
+        $this->view->unlink($this->folder);
+    }
 }
 
 class DummyTestClassSharedMount extends SharedMount {
-	public function __construct($storage, $mountpoint, $arguments = null, $loader = null) {
-		// noop
-	}
+    public function __construct($storage, $mountpoint, $arguments = null, $loader = null) {
+        // noop
+    }
 
-	public function stripUserFilesPathDummy($path) {
-		return $this->stripUserFilesPath($path);
-	}
+    public function stripUserFilesPathDummy($path) {
+        return $this->stripUserFilesPath($path);
+    }
 }

tests/lib/Files/ViewTest.php

Indentation +2775 added lines, -2775 removed lines

@@ -51,40 +51,40 @@ 
 use Test\Traits\UserTrait;
 
 class TemporaryNoTouch extends Temporary {
-	public function touch(string $path, ?int $mtime = null): bool {
-		return false;
-	}
+    public function touch(string $path, ?int $mtime = null): bool {
+        return false;
+    }
 }
 
 class TemporaryNoCross extends Temporary {
-	public function copyFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath, bool $preserveMtime = false): bool {
-		return Common::copyFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath, $preserveMtime);
-	}
+    public function copyFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath, bool $preserveMtime = false): bool {
+        return Common::copyFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath, $preserveMtime);
+    }
 
-	public function moveFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath): bool {
-		return Common::moveFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath);
-	}
+    public function moveFromStorage(IStorage $sourceStorage, string $sourceInternalPath, string $targetInternalPath): bool {
+        return Common::moveFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath);
+    }
 }
 
 class TemporaryNoLocal extends Temporary {
-	public function instanceOfStorage(string $class): bool {
-		if ($class === '\OC\Files\Storage\Local') {
-			return false;
-		} else {
-			return parent::instanceOfStorage($class);
-		}
-	}
+    public function instanceOfStorage(string $class): bool {
+        if ($class === '\OC\Files\Storage\Local') {
+            return false;
+        } else {
+            return parent::instanceOfStorage($class);
+        }
+    }
 }
 
 class TestEventHandler {
-	public function umount() {
-	}
-	public function post_umount() {
-	}
-	public function preCallback() {
-	}
-	public function postCallback() {
-	}
+    public function umount() {
+    }
+    public function post_umount() {
+    }
+    public function preCallback() {
+    }
+    public function postCallback() {
+    }
 }
 
 /**
@@ -96,2757 +96,2757 @@ 
 #[\PHPUnit\Framework\Attributes\Medium]
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class ViewTest extends \Test\TestCase {
-	use UserTrait;
-
-	/**
-	 * @var Storage[] $storages
-	 */
-	private $storages = [];
-
-	/**
-	 * @var string
-	 */
-	private $user;
-
-	/**
-	 * @var IUser
-	 */
-	private $userObject;
-
-	/**
-	 * @var IGroup
-	 */
-	private $groupObject;
-
-	/** @var Storage */
-	private $tempStorage;
-
-	protected function setUp(): void {
-		parent::setUp();
-		\OC_Hook::clear();
-
-		Server::get(IUserManager::class)->clearBackends();
-		Server::get(IUserManager::class)->registerBackend(new \Test\Util\User\Dummy());
-
-		//login
-		$userManager = Server::get(IUserManager::class);
-		$groupManager = Server::get(IGroupManager::class);
-		$this->user = 'test';
-		$this->userObject = $userManager->createUser('test', 'test');
-
-		$this->groupObject = $groupManager->createGroup('group1');
-		$this->groupObject->addUser($this->userObject);
-
-		self::loginAsUser($this->user);
-
-		/** @var IMountManager $manager */
-		$manager = Server::get(IMountManager::class);
-		$manager->removeMount('/test');
-
-		$this->tempStorage = null;
-	}
-
-	protected function tearDown(): void {
-		\OC_User::setUserId($this->user);
-		foreach ($this->storages as $storage) {
-			$cache = $storage->getCache();
-			$ids = $cache->getAll();
-			$cache->clear();
-		}
-
-		if ($this->tempStorage) {
-			system('rm -rf ' . escapeshellarg($this->tempStorage->getDataDir()));
-		}
-
-		self::logout();
-
-		/** @var SetupManager $setupManager */
-		$setupManager = Server::get(SetupManager::class);
-		$setupManager->setupRoot();
-
-		$this->userObject->delete();
-		$this->groupObject->delete();
-
-		$mountProviderCollection = Server::get(IMountProviderCollection::class);
-		self::invokePrivate($mountProviderCollection, 'providers', [[]]);
-
-		parent::tearDown();
-	}
-
-	public function testCacheAPI(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$storage3 = $this->getTestStorage();
-		$root = self::getUniqueID('/');
-		Filesystem::mount($storage1, [], $root . '/');
-		Filesystem::mount($storage2, [], $root . '/substorage');
-		Filesystem::mount($storage3, [], $root . '/folder/anotherstorage');
-		$textSize = strlen("dummy file data\n");
-		$imageSize = filesize(\OC::$SERVERROOT . '/core/img/logo/logo.png');
-		$storageSize = $textSize * 2 + $imageSize;
-
-		$storageInfo = $storage3->getCache()->get('');
-		$this->assertEquals($storageSize, $storageInfo['size']);
-
-		$rootView = new View($root);
-
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		$this->assertEquals($textSize, $cachedData['size']);
-		$this->assertEquals('text/plain', $cachedData['mimetype']);
-		$this->assertNotEquals(-1, $cachedData['permissions']);
-
-		$cachedData = $rootView->getFileInfo('/');
-		$this->assertEquals($storageSize * 3, $cachedData['size']);
-		$this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
-
-		// get cached data excluding mount points
-		$cachedData = $rootView->getFileInfo('/', false);
-		$this->assertEquals($storageSize, $cachedData['size']);
-		$this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
-
-		$cachedData = $rootView->getFileInfo('/folder');
-		$this->assertEquals($storageSize + $textSize, $cachedData['size']);
-		$this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
-
-		$folderData = $rootView->getDirectoryContent('/');
-		/**
-		 * expected entries:
-		 * folder
-		 * foo.png
-		 * foo.txt
-		 * substorage
-		 */
-		$this->assertCount(4, $folderData);
-		$this->assertEquals('folder', $folderData[0]['name']);
-		$this->assertEquals('foo.png', $folderData[1]['name']);
-		$this->assertEquals('foo.txt', $folderData[2]['name']);
-		$this->assertEquals('substorage', $folderData[3]['name']);
-
-		$this->assertEquals($storageSize + $textSize, $folderData[0]['size']);
-		$this->assertEquals($imageSize, $folderData[1]['size']);
-		$this->assertEquals($textSize, $folderData[2]['size']);
-		$this->assertEquals($storageSize, $folderData[3]['size']);
-
-		$folderData = $rootView->getDirectoryContent('/substorage');
-		/**
-		 * expected entries:
-		 * folder
-		 * foo.png
-		 * foo.txt
-		 */
-		$this->assertCount(3, $folderData);
-		$this->assertEquals('folder', $folderData[0]['name']);
-		$this->assertEquals('foo.png', $folderData[1]['name']);
-		$this->assertEquals('foo.txt', $folderData[2]['name']);
-
-		$folderView = new View($root . '/folder');
-		$this->assertEquals($rootView->getFileInfo('/folder'), $folderView->getFileInfo('/'));
-
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		$this->assertFalse($cachedData['encrypted']);
-		$id = $rootView->putFileInfo('/foo.txt', ['encrypted' => true]);
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		$this->assertTrue($cachedData['encrypted']);
-		$this->assertEquals($cachedData['fileid'], $id);
-
-		$this->assertFalse($rootView->getFileInfo('/non/existing'));
-		$this->assertEquals([], $rootView->getDirectoryContent('/non/existing'));
-	}
-
-	public function testGetPath(): void {
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('test');
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$storage3 = $this->getTestStorage();
-
-		Filesystem::mount($storage1, [], '/test/files');
-		Filesystem::mount($storage2, [], '/test/files/substorage');
-		Filesystem::mount($storage3, [], '/test/files/folder/anotherstorage');
-
-		$userMountCache = Server::get(IUserMountCache::class);
-		$userMountCache->registerMounts($user, [
-			new MountPoint($storage1, '/test/files'),
-			new MountPoint($storage2, '/test/files/substorage'),
-			new MountPoint($storage3, '/test/files/folder/anotherstorage'),
-		]);
-
-		$rootView = new View('/test/files');
-
-
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		$id1 = $cachedData->getId();
-		$this->assertEquals('/foo.txt', $rootView->getPath($id1));
-
-		$cachedData = $rootView->getFileInfo('/substorage/foo.txt');
-		$id2 = $cachedData->getId();
-		$this->assertEquals('/substorage/foo.txt', $rootView->getPath($id2));
-
-		$folderView = new View('/test/files/substorage');
-		$this->assertEquals('/foo.txt', $folderView->getPath($id2));
-	}
-
-
-	public function testGetPathNotExisting(): void {
-		$this->expectException(NotFoundException::class);
-
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-
-		$rootView = new View('');
-		$cachedData = $rootView->getFileInfo('/foo.txt');
-		/** @var int $id1 */
-		$id1 = $cachedData['fileid'];
-		$folderView = new View('/substorage');
-		$this->assertNull($folderView->getPath($id1));
-	}
-
-	public function testMountPointOverwrite(): void {
-		$storage1 = $this->getTestStorage(false);
-		$storage2 = $this->getTestStorage();
-		$storage1->mkdir('substorage');
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$folderContent = $rootView->getDirectoryContent('/');
-		$this->assertCount(4, $folderContent);
-	}
-
-	public static function sharingDisabledPermissionProvider(): array {
-		return [
-			['no', '', true],
-			['yes', 'group1', false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('sharingDisabledPermissionProvider')]
-	public function testRemoveSharePermissionWhenSharingDisabledForUser($excludeGroups, $excludeGroupsList, $expectedShareable): void {
-		// Reset sharing disabled for users cache
-		self::invokePrivate(Server::get(ShareDisableChecker::class), 'sharingDisabledForUsersCache', [new CappedMemoryCache()]);
-
-		$config = Server::get(IConfig::class);
-		$oldExcludeGroupsFlag = $config->getAppValue('core', 'shareapi_exclude_groups', 'no');
-		$oldExcludeGroupsList = $config->getAppValue('core', 'shareapi_exclude_groups_list', '');
-		$config->setAppValue('core', 'shareapi_exclude_groups', $excludeGroups);
-		$config->setAppValue('core', 'shareapi_exclude_groups_list', $excludeGroupsList);
-
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/mount');
-
-		$view = new View('/');
-
-		$folderContent = $view->getDirectoryContent('');
-		$this->assertEquals($expectedShareable, $folderContent[0]->isShareable());
-
-		$folderContent = $view->getDirectoryContent('mount');
-		$this->assertEquals($expectedShareable, $folderContent[0]->isShareable());
-
-		$config->setAppValue('core', 'shareapi_exclude_groups', $oldExcludeGroupsFlag);
-		$config->setAppValue('core', 'shareapi_exclude_groups_list', $oldExcludeGroupsList);
-
-		// Reset sharing disabled for users cache
-		self::invokePrivate(Server::get(ShareDisableChecker::class), 'sharingDisabledForUsersCache', [new CappedMemoryCache()]);
-	}
-
-	public function testCacheIncompleteFolder(): void {
-		$storage1 = $this->getTestStorage(false);
-		Filesystem::mount($storage1, [], '/incomplete');
-		$rootView = new View('/incomplete');
-
-		$entries = $rootView->getDirectoryContent('/');
-		$this->assertCount(3, $entries);
-
-		// /folder will already be in the cache but not scanned
-		$entries = $rootView->getDirectoryContent('/folder');
-		$this->assertCount(1, $entries);
-	}
-
-	public function testAutoScan(): void {
-		$storage1 = $this->getTestStorage(false);
-		$storage2 = $this->getTestStorage(false);
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-		$textSize = strlen("dummy file data\n");
-
-		$rootView = new View('');
-
-		$cachedData = $rootView->getFileInfo('/');
-		$this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
-		$this->assertEquals(-1, $cachedData['size']);
-
-		$folderData = $rootView->getDirectoryContent('/substorage/folder');
-		$this->assertEquals('text/plain', $folderData[0]['mimetype']);
-		$this->assertEquals($textSize, $folderData[0]['size']);
-	}
-
-	public function testSearch(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$storage3 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-		Filesystem::mount($storage3, [], '/folder/anotherstorage');
-
-		$rootView = new View('');
-
-		$results = $rootView->search('foo');
-		$this->assertCount(6, $results);
-		$paths = [];
-		foreach ($results as $result) {
-			$this->assertEquals($result['path'], Filesystem::normalizePath($result['path']));
-			$paths[] = $result['path'];
-		}
-		$this->assertContains('/foo.txt', $paths);
-		$this->assertContains('/foo.png', $paths);
-		$this->assertContains('/substorage/foo.txt', $paths);
-		$this->assertContains('/substorage/foo.png', $paths);
-		$this->assertContains('/folder/anotherstorage/foo.txt', $paths);
-		$this->assertContains('/folder/anotherstorage/foo.png', $paths);
-
-		$folderView = new View('/folder');
-		$results = $folderView->search('bar');
-		$this->assertCount(2, $results);
-		$paths = [];
-		foreach ($results as $result) {
-			$paths[] = $result['path'];
-		}
-		$this->assertContains('/anotherstorage/folder/bar.txt', $paths);
-		$this->assertContains('/bar.txt', $paths);
-
-		$results = $folderView->search('foo');
-		$this->assertCount(2, $results);
-		$paths = [];
-		foreach ($results as $result) {
-			$paths[] = $result['path'];
-		}
-		$this->assertContains('/anotherstorage/foo.txt', $paths);
-		$this->assertContains('/anotherstorage/foo.png', $paths);
-
-		$this->assertCount(6, $rootView->searchByMime('text'));
-		$this->assertCount(3, $folderView->searchByMime('text'));
-	}
-
-	public function testWatcher(): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		$storage1->getWatcher()->setPolicy(Watcher::CHECK_ALWAYS);
-
-		$rootView = new View('');
-
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertEquals(16, $cachedData['size']);
-
-		$rootView->putFileInfo('foo.txt', ['storage_mtime' => 10]);
-		$storage1->file_put_contents('foo.txt', 'foo');
-		clearstatcache();
-
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertEquals(3, $cachedData['size']);
-	}
-
-	public function testCopyBetweenStorageNoCross(): void {
-		$storage1 = $this->getTestStorage(true, TemporaryNoCross::class);
-		$storage2 = $this->getTestStorage(true, TemporaryNoCross::class);
-		$this->copyBetweenStorages($storage1, $storage2);
-	}
-
-	public function testCopyBetweenStorageCross(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$this->copyBetweenStorages($storage1, $storage2);
-	}
-
-	public function testCopyBetweenStorageCrossNonLocal(): void {
-		$storage1 = $this->getTestStorage(true, TemporaryNoLocal::class);
-		$storage2 = $this->getTestStorage(true, TemporaryNoLocal::class);
-		$this->copyBetweenStorages($storage1, $storage2);
-	}
-
-	public function copyBetweenStorages($storage1, $storage2) {
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$rootView->mkdir('substorage/emptyfolder');
-		$rootView->copy('substorage', 'anotherfolder');
-		$this->assertTrue($rootView->is_dir('/anotherfolder'));
-		$this->assertTrue($rootView->is_dir('/substorage'));
-		$this->assertTrue($rootView->is_dir('/anotherfolder/emptyfolder'));
-		$this->assertTrue($rootView->is_dir('/substorage/emptyfolder'));
-		$this->assertTrue($rootView->file_exists('/anotherfolder/foo.txt'));
-		$this->assertTrue($rootView->file_exists('/anotherfolder/foo.png'));
-		$this->assertTrue($rootView->file_exists('/anotherfolder/folder/bar.txt'));
-		$this->assertTrue($rootView->file_exists('/substorage/foo.txt'));
-		$this->assertTrue($rootView->file_exists('/substorage/foo.png'));
-		$this->assertTrue($rootView->file_exists('/substorage/folder/bar.txt'));
-	}
-
-	public function testMoveBetweenStorageNoCross(): void {
-		$storage1 = $this->getTestStorage(true, TemporaryNoCross::class);
-		$storage2 = $this->getTestStorage(true, TemporaryNoCross::class);
-		$this->moveBetweenStorages($storage1, $storage2);
-	}
-
-	public function testMoveBetweenStorageCross(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$this->moveBetweenStorages($storage1, $storage2);
-	}
-
-	public function testMoveBetweenStorageCrossNonLocal(): void {
-		$storage1 = $this->getTestStorage(true, TemporaryNoLocal::class);
-		$storage2 = $this->getTestStorage(true, TemporaryNoLocal::class);
-		$this->moveBetweenStorages($storage1, $storage2);
-	}
-
-	public function moveBetweenStorages($storage1, $storage2) {
-		Filesystem::mount($storage1, [], '/' . $this->user . '/');
-		Filesystem::mount($storage2, [], '/' . $this->user . '/substorage');
-
-		$rootView = new View('/' . $this->user);
-		$rootView->rename('foo.txt', 'substorage/folder/foo.txt');
-		$this->assertFalse($rootView->file_exists('foo.txt'));
-		$this->assertTrue($rootView->file_exists('substorage/folder/foo.txt'));
-		$rootView->rename('substorage/folder', 'anotherfolder');
-		$this->assertFalse($rootView->is_dir('substorage/folder'));
-		$this->assertTrue($rootView->file_exists('anotherfolder/foo.txt'));
-		$this->assertTrue($rootView->file_exists('anotherfolder/bar.txt'));
-	}
-
-	public function testUnlink(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$rootView->file_put_contents('/foo.txt', 'asd');
-		$rootView->file_put_contents('/substorage/bar.txt', 'asd');
-
-		$this->assertTrue($rootView->file_exists('foo.txt'));
-		$this->assertTrue($rootView->file_exists('substorage/bar.txt'));
-
-		$this->assertTrue($rootView->unlink('foo.txt'));
-		$this->assertTrue($rootView->unlink('substorage/bar.txt'));
-
-		$this->assertFalse($rootView->file_exists('foo.txt'));
-		$this->assertFalse($rootView->file_exists('substorage/bar.txt'));
-	}
-
-	public static function rmdirOrUnlinkDataProvider(): array {
-		return [['rmdir'], ['unlink']];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('rmdirOrUnlinkDataProvider')]
-	public function testRmdir($method): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-
-		$rootView = new View('');
-		$rootView->mkdir('sub');
-		$rootView->mkdir('sub/deep');
-		$rootView->file_put_contents('/sub/deep/foo.txt', 'asd');
-
-		$this->assertTrue($rootView->file_exists('sub/deep/foo.txt'));
-
-		$this->assertTrue($rootView->$method('sub'));
-
-		$this->assertFalse($rootView->file_exists('sub'));
-	}
-
-	public function testUnlinkRootMustFail(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], '/substorage');
-
-		$rootView = new View('');
-		$rootView->file_put_contents('/foo.txt', 'asd');
-		$rootView->file_put_contents('/substorage/bar.txt', 'asd');
-
-		$this->assertFalse($rootView->unlink(''));
-		$this->assertFalse($rootView->unlink('/'));
-		$this->assertFalse($rootView->unlink('substorage'));
-		$this->assertFalse($rootView->unlink('/substorage'));
-	}
-
-	public function testTouch(): void {
-		$storage = $this->getTestStorage(true, TemporaryNoTouch::class);
-
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-		$oldCachedData = $rootView->getFileInfo('foo.txt');
-
-		$rootView->touch('foo.txt', 500);
-
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertEquals(500, $cachedData['mtime']);
-		$this->assertEquals($oldCachedData['storage_mtime'], $cachedData['storage_mtime']);
-
-		$rootView->putFileInfo('foo.txt', ['storage_mtime' => 1000]); //make sure the watcher detects the change
-		$rootView->file_put_contents('foo.txt', 'asd');
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertGreaterThanOrEqual($oldCachedData['mtime'], $cachedData['mtime']);
-		$this->assertEquals($cachedData['storage_mtime'], $cachedData['mtime']);
-	}
-
-	public function testTouchFloat(): void {
-		$storage = $this->getTestStorage(true, TemporaryNoTouch::class);
-
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-		$oldCachedData = $rootView->getFileInfo('foo.txt');
-
-		$rootView->touch('foo.txt', 500.5);
-
-		$cachedData = $rootView->getFileInfo('foo.txt');
-		$this->assertEquals(500, $cachedData['mtime']);
-	}
-
-	public function testViewHooks(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$defaultRoot = Filesystem::getRoot();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot . '/substorage');
-		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
-
-		$rootView = new View('');
-		$subView = new View($defaultRoot . '/substorage');
-		$this->hookPath = null;
-
-		$rootView->file_put_contents('/foo.txt', 'asd');
-		$this->assertNull($this->hookPath);
-
-		$subView->file_put_contents('/foo.txt', 'asd');
-		$this->assertEquals('/substorage/foo.txt', $this->hookPath);
-	}
-
-	private $hookPath;
-
-	public function dummyHook($params) {
-		$this->hookPath = $params['path'];
-	}
-
-	public function testSearchNotOutsideView(): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-		$storage1->rename('folder', 'foo');
-		$scanner = $storage1->getScanner();
-		$scanner->scan('');
-
-		$view = new View('/foo');
-
-		$result = $view->search('.txt');
-		$this->assertCount(1, $result);
-	}
-
-	/**
-	 * @param bool $scan
-	 * @param string $class
-	 * @return Storage
-	 */
-	private function getTestStorage($scan = true, $class = Temporary::class) {
-		/**
-		 * @var Storage $storage
-		 */
-		$storage = new $class([]);
-		$textData = "dummy file data\n";
-		$imgData = file_get_contents(\OC::$SERVERROOT . '/core/img/logo/logo.png');
-		$storage->mkdir('folder');
-		$storage->file_put_contents('foo.txt', $textData);
-		$storage->file_put_contents('foo.png', $imgData);
-		$storage->file_put_contents('folder/bar.txt', $textData);
-
-		if ($scan) {
-			$scanner = $storage->getScanner();
-			$scanner->scan('');
-		}
-		$this->storages[] = $storage;
-		return $storage;
-	}
-
-	public function testViewHooksIfRootStartsTheSame(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$defaultRoot = Filesystem::getRoot();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot . '_substorage');
-		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
-
-		$subView = new View($defaultRoot . '_substorage');
-		$this->hookPath = null;
-
-		$subView->file_put_contents('/foo.txt', 'asd');
-		$this->assertNull($this->hookPath);
-	}
-
-	private $hookWritePath;
-	private $hookCreatePath;
-	private $hookUpdatePath;
-
-	public function dummyHookWrite($params) {
-		$this->hookWritePath = $params['path'];
-	}
-
-	public function dummyHookUpdate($params) {
-		$this->hookUpdatePath = $params['path'];
-	}
-
-	public function dummyHookCreate($params) {
-		$this->hookCreatePath = $params['path'];
-	}
-
-	public function testEditNoCreateHook(): void {
-		$storage1 = $this->getTestStorage();
-		$storage2 = $this->getTestStorage();
-		$defaultRoot = Filesystem::getRoot();
-		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot);
-		\OC_Hook::connect('OC_Filesystem', 'post_create', $this, 'dummyHookCreate');
-		\OC_Hook::connect('OC_Filesystem', 'post_update', $this, 'dummyHookUpdate');
-		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHookWrite');
-
-		$view = new View($defaultRoot);
-		$this->hookWritePath = $this->hookUpdatePath = $this->hookCreatePath = null;
-
-		$view->file_put_contents('/asd.txt', 'foo');
-		$this->assertEquals('/asd.txt', $this->hookCreatePath);
-		$this->assertNull($this->hookUpdatePath);
-		$this->assertEquals('/asd.txt', $this->hookWritePath);
-
-		$this->hookWritePath = $this->hookUpdatePath = $this->hookCreatePath = null;
-
-		$view->file_put_contents('/asd.txt', 'foo');
-		$this->assertNull($this->hookCreatePath);
-		$this->assertEquals('/asd.txt', $this->hookUpdatePath);
-		$this->assertEquals('/asd.txt', $this->hookWritePath);
-
-		\OC_Hook::clear('OC_Filesystem', 'post_create');
-		\OC_Hook::clear('OC_Filesystem', 'post_update');
-		\OC_Hook::clear('OC_Filesystem', 'post_write');
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('resolvePathTestProvider')]
-	public function testResolvePath($expected, $pathToTest): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-
-		$view = new View('');
-
-		$result = $view->resolvePath($pathToTest);
-		$this->assertEquals($expected, $result[1]);
-
-		$exists = $view->file_exists($pathToTest);
-		$this->assertTrue($exists);
-
-		$exists = $view->file_exists($result[1]);
-		$this->assertTrue($exists);
-	}
-
-	public static function resolvePathTestProvider(): array {
-		return [
-			['foo.txt', 'foo.txt'],
-			['foo.txt', '/foo.txt'],
-			['folder', 'folder'],
-			['folder', '/folder'],
-			['folder', 'folder/'],
-			['folder', '/folder/'],
-			['folder/bar.txt', 'folder/bar.txt'],
-			['folder/bar.txt', '/folder/bar.txt'],
-			['', ''],
-			['', '/'],
-		];
-	}
-
-	public function testUTF8Names(): void {
-		$names = ['虚', '和知しゃ和で', 'regular ascii', 'sɨˈrɪlɪk', 'ѨѬ', 'أنا أحب القراءة كثيرا'];
-
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-		foreach ($names as $name) {
-			$rootView->file_put_contents('/' . $name, 'dummy content');
-		}
-
-		$list = $rootView->getDirectoryContent('/');
-
-		$this->assertCount(count($names), $list);
-		foreach ($list as $item) {
-			$this->assertContains($item['name'], $names);
-		}
-
-		$cache = $storage->getCache();
-		$scanner = $storage->getScanner();
-		$scanner->scan('');
-
-		$list = $cache->getFolderContents('');
-
-		$this->assertCount(count($names), $list);
-		foreach ($list as $item) {
-			$this->assertContains($item['name'], $names);
-		}
-	}
-
-	public function xtestLongPath() {
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-
-		$longPath = '';
-		$ds = DIRECTORY_SEPARATOR;
-		/*
+    use UserTrait;
+
+    /**
+     * @var Storage[] $storages
+     */
+    private $storages = [];
+
+    /**
+     * @var string
+     */
+    private $user;
+
+    /**
+     * @var IUser
+     */
+    private $userObject;
+
+    /**
+     * @var IGroup
+     */
+    private $groupObject;
+
+    /** @var Storage */
+    private $tempStorage;
+
+    protected function setUp(): void {
+        parent::setUp();
+        \OC_Hook::clear();
+
+        Server::get(IUserManager::class)->clearBackends();
+        Server::get(IUserManager::class)->registerBackend(new \Test\Util\User\Dummy());
+
+        //login
+        $userManager = Server::get(IUserManager::class);
+        $groupManager = Server::get(IGroupManager::class);
+        $this->user = 'test';
+        $this->userObject = $userManager->createUser('test', 'test');
+
+        $this->groupObject = $groupManager->createGroup('group1');
+        $this->groupObject->addUser($this->userObject);
+
+        self::loginAsUser($this->user);
+
+        /** @var IMountManager $manager */
+        $manager = Server::get(IMountManager::class);
+        $manager->removeMount('/test');
+
+        $this->tempStorage = null;
+    }
+
+    protected function tearDown(): void {
+        \OC_User::setUserId($this->user);
+        foreach ($this->storages as $storage) {
+            $cache = $storage->getCache();
+            $ids = $cache->getAll();
+            $cache->clear();
+        }
+
+        if ($this->tempStorage) {
+            system('rm -rf ' . escapeshellarg($this->tempStorage->getDataDir()));
+        }
+
+        self::logout();
+
+        /** @var SetupManager $setupManager */
+        $setupManager = Server::get(SetupManager::class);
+        $setupManager->setupRoot();
+
+        $this->userObject->delete();
+        $this->groupObject->delete();
+
+        $mountProviderCollection = Server::get(IMountProviderCollection::class);
+        self::invokePrivate($mountProviderCollection, 'providers', [[]]);
+
+        parent::tearDown();
+    }
+
+    public function testCacheAPI(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $storage3 = $this->getTestStorage();
+        $root = self::getUniqueID('/');
+        Filesystem::mount($storage1, [], $root . '/');
+        Filesystem::mount($storage2, [], $root . '/substorage');
+        Filesystem::mount($storage3, [], $root . '/folder/anotherstorage');
+        $textSize = strlen("dummy file data\n");
+        $imageSize = filesize(\OC::$SERVERROOT . '/core/img/logo/logo.png');
+        $storageSize = $textSize * 2 + $imageSize;
+
+        $storageInfo = $storage3->getCache()->get('');
+        $this->assertEquals($storageSize, $storageInfo['size']);
+
+        $rootView = new View($root);
+
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        $this->assertEquals($textSize, $cachedData['size']);
+        $this->assertEquals('text/plain', $cachedData['mimetype']);
+        $this->assertNotEquals(-1, $cachedData['permissions']);
+
+        $cachedData = $rootView->getFileInfo('/');
+        $this->assertEquals($storageSize * 3, $cachedData['size']);
+        $this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
+
+        // get cached data excluding mount points
+        $cachedData = $rootView->getFileInfo('/', false);
+        $this->assertEquals($storageSize, $cachedData['size']);
+        $this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
+
+        $cachedData = $rootView->getFileInfo('/folder');
+        $this->assertEquals($storageSize + $textSize, $cachedData['size']);
+        $this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
+
+        $folderData = $rootView->getDirectoryContent('/');
+        /**
+         * expected entries:
+         * folder
+         * foo.png
+         * foo.txt
+         * substorage
+         */
+        $this->assertCount(4, $folderData);
+        $this->assertEquals('folder', $folderData[0]['name']);
+        $this->assertEquals('foo.png', $folderData[1]['name']);
+        $this->assertEquals('foo.txt', $folderData[2]['name']);
+        $this->assertEquals('substorage', $folderData[3]['name']);
+
+        $this->assertEquals($storageSize + $textSize, $folderData[0]['size']);
+        $this->assertEquals($imageSize, $folderData[1]['size']);
+        $this->assertEquals($textSize, $folderData[2]['size']);
+        $this->assertEquals($storageSize, $folderData[3]['size']);
+
+        $folderData = $rootView->getDirectoryContent('/substorage');
+        /**
+         * expected entries:
+         * folder
+         * foo.png
+         * foo.txt
+         */
+        $this->assertCount(3, $folderData);
+        $this->assertEquals('folder', $folderData[0]['name']);
+        $this->assertEquals('foo.png', $folderData[1]['name']);
+        $this->assertEquals('foo.txt', $folderData[2]['name']);
+
+        $folderView = new View($root . '/folder');
+        $this->assertEquals($rootView->getFileInfo('/folder'), $folderView->getFileInfo('/'));
+
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        $this->assertFalse($cachedData['encrypted']);
+        $id = $rootView->putFileInfo('/foo.txt', ['encrypted' => true]);
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        $this->assertTrue($cachedData['encrypted']);
+        $this->assertEquals($cachedData['fileid'], $id);
+
+        $this->assertFalse($rootView->getFileInfo('/non/existing'));
+        $this->assertEquals([], $rootView->getDirectoryContent('/non/existing'));
+    }
+
+    public function testGetPath(): void {
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('test');
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $storage3 = $this->getTestStorage();
+
+        Filesystem::mount($storage1, [], '/test/files');
+        Filesystem::mount($storage2, [], '/test/files/substorage');
+        Filesystem::mount($storage3, [], '/test/files/folder/anotherstorage');
+
+        $userMountCache = Server::get(IUserMountCache::class);
+        $userMountCache->registerMounts($user, [
+            new MountPoint($storage1, '/test/files'),
+            new MountPoint($storage2, '/test/files/substorage'),
+            new MountPoint($storage3, '/test/files/folder/anotherstorage'),
+        ]);
+
+        $rootView = new View('/test/files');
+
+
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        $id1 = $cachedData->getId();
+        $this->assertEquals('/foo.txt', $rootView->getPath($id1));
+
+        $cachedData = $rootView->getFileInfo('/substorage/foo.txt');
+        $id2 = $cachedData->getId();
+        $this->assertEquals('/substorage/foo.txt', $rootView->getPath($id2));
+
+        $folderView = new View('/test/files/substorage');
+        $this->assertEquals('/foo.txt', $folderView->getPath($id2));
+    }
+
+
+    public function testGetPathNotExisting(): void {
+        $this->expectException(NotFoundException::class);
+
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+
+        $rootView = new View('');
+        $cachedData = $rootView->getFileInfo('/foo.txt');
+        /** @var int $id1 */
+        $id1 = $cachedData['fileid'];
+        $folderView = new View('/substorage');
+        $this->assertNull($folderView->getPath($id1));
+    }
+
+    public function testMountPointOverwrite(): void {
+        $storage1 = $this->getTestStorage(false);
+        $storage2 = $this->getTestStorage();
+        $storage1->mkdir('substorage');
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $folderContent = $rootView->getDirectoryContent('/');
+        $this->assertCount(4, $folderContent);
+    }
+
+    public static function sharingDisabledPermissionProvider(): array {
+        return [
+            ['no', '', true],
+            ['yes', 'group1', false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('sharingDisabledPermissionProvider')]
+    public function testRemoveSharePermissionWhenSharingDisabledForUser($excludeGroups, $excludeGroupsList, $expectedShareable): void {
+        // Reset sharing disabled for users cache
+        self::invokePrivate(Server::get(ShareDisableChecker::class), 'sharingDisabledForUsersCache', [new CappedMemoryCache()]);
+
+        $config = Server::get(IConfig::class);
+        $oldExcludeGroupsFlag = $config->getAppValue('core', 'shareapi_exclude_groups', 'no');
+        $oldExcludeGroupsList = $config->getAppValue('core', 'shareapi_exclude_groups_list', '');
+        $config->setAppValue('core', 'shareapi_exclude_groups', $excludeGroups);
+        $config->setAppValue('core', 'shareapi_exclude_groups_list', $excludeGroupsList);
+
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/mount');
+
+        $view = new View('/');
+
+        $folderContent = $view->getDirectoryContent('');
+        $this->assertEquals($expectedShareable, $folderContent[0]->isShareable());
+
+        $folderContent = $view->getDirectoryContent('mount');
+        $this->assertEquals($expectedShareable, $folderContent[0]->isShareable());
+
+        $config->setAppValue('core', 'shareapi_exclude_groups', $oldExcludeGroupsFlag);
+        $config->setAppValue('core', 'shareapi_exclude_groups_list', $oldExcludeGroupsList);
+
+        // Reset sharing disabled for users cache
+        self::invokePrivate(Server::get(ShareDisableChecker::class), 'sharingDisabledForUsersCache', [new CappedMemoryCache()]);
+    }
+
+    public function testCacheIncompleteFolder(): void {
+        $storage1 = $this->getTestStorage(false);
+        Filesystem::mount($storage1, [], '/incomplete');
+        $rootView = new View('/incomplete');
+
+        $entries = $rootView->getDirectoryContent('/');
+        $this->assertCount(3, $entries);
+
+        // /folder will already be in the cache but not scanned
+        $entries = $rootView->getDirectoryContent('/folder');
+        $this->assertCount(1, $entries);
+    }
+
+    public function testAutoScan(): void {
+        $storage1 = $this->getTestStorage(false);
+        $storage2 = $this->getTestStorage(false);
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+        $textSize = strlen("dummy file data\n");
+
+        $rootView = new View('');
+
+        $cachedData = $rootView->getFileInfo('/');
+        $this->assertEquals('httpd/unix-directory', $cachedData['mimetype']);
+        $this->assertEquals(-1, $cachedData['size']);
+
+        $folderData = $rootView->getDirectoryContent('/substorage/folder');
+        $this->assertEquals('text/plain', $folderData[0]['mimetype']);
+        $this->assertEquals($textSize, $folderData[0]['size']);
+    }
+
+    public function testSearch(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $storage3 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+        Filesystem::mount($storage3, [], '/folder/anotherstorage');
+
+        $rootView = new View('');
+
+        $results = $rootView->search('foo');
+        $this->assertCount(6, $results);
+        $paths = [];
+        foreach ($results as $result) {
+            $this->assertEquals($result['path'], Filesystem::normalizePath($result['path']));
+            $paths[] = $result['path'];
+        }
+        $this->assertContains('/foo.txt', $paths);
+        $this->assertContains('/foo.png', $paths);
+        $this->assertContains('/substorage/foo.txt', $paths);
+        $this->assertContains('/substorage/foo.png', $paths);
+        $this->assertContains('/folder/anotherstorage/foo.txt', $paths);
+        $this->assertContains('/folder/anotherstorage/foo.png', $paths);
+
+        $folderView = new View('/folder');
+        $results = $folderView->search('bar');
+        $this->assertCount(2, $results);
+        $paths = [];
+        foreach ($results as $result) {
+            $paths[] = $result['path'];
+        }
+        $this->assertContains('/anotherstorage/folder/bar.txt', $paths);
+        $this->assertContains('/bar.txt', $paths);
+
+        $results = $folderView->search('foo');
+        $this->assertCount(2, $results);
+        $paths = [];
+        foreach ($results as $result) {
+            $paths[] = $result['path'];
+        }
+        $this->assertContains('/anotherstorage/foo.txt', $paths);
+        $this->assertContains('/anotherstorage/foo.png', $paths);
+
+        $this->assertCount(6, $rootView->searchByMime('text'));
+        $this->assertCount(3, $folderView->searchByMime('text'));
+    }
+
+    public function testWatcher(): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        $storage1->getWatcher()->setPolicy(Watcher::CHECK_ALWAYS);
+
+        $rootView = new View('');
+
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertEquals(16, $cachedData['size']);
+
+        $rootView->putFileInfo('foo.txt', ['storage_mtime' => 10]);
+        $storage1->file_put_contents('foo.txt', 'foo');
+        clearstatcache();
+
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertEquals(3, $cachedData['size']);
+    }
+
+    public function testCopyBetweenStorageNoCross(): void {
+        $storage1 = $this->getTestStorage(true, TemporaryNoCross::class);
+        $storage2 = $this->getTestStorage(true, TemporaryNoCross::class);
+        $this->copyBetweenStorages($storage1, $storage2);
+    }
+
+    public function testCopyBetweenStorageCross(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $this->copyBetweenStorages($storage1, $storage2);
+    }
+
+    public function testCopyBetweenStorageCrossNonLocal(): void {
+        $storage1 = $this->getTestStorage(true, TemporaryNoLocal::class);
+        $storage2 = $this->getTestStorage(true, TemporaryNoLocal::class);
+        $this->copyBetweenStorages($storage1, $storage2);
+    }
+
+    public function copyBetweenStorages($storage1, $storage2) {
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $rootView->mkdir('substorage/emptyfolder');
+        $rootView->copy('substorage', 'anotherfolder');
+        $this->assertTrue($rootView->is_dir('/anotherfolder'));
+        $this->assertTrue($rootView->is_dir('/substorage'));
+        $this->assertTrue($rootView->is_dir('/anotherfolder/emptyfolder'));
+        $this->assertTrue($rootView->is_dir('/substorage/emptyfolder'));
+        $this->assertTrue($rootView->file_exists('/anotherfolder/foo.txt'));
+        $this->assertTrue($rootView->file_exists('/anotherfolder/foo.png'));
+        $this->assertTrue($rootView->file_exists('/anotherfolder/folder/bar.txt'));
+        $this->assertTrue($rootView->file_exists('/substorage/foo.txt'));
+        $this->assertTrue($rootView->file_exists('/substorage/foo.png'));
+        $this->assertTrue($rootView->file_exists('/substorage/folder/bar.txt'));
+    }
+
+    public function testMoveBetweenStorageNoCross(): void {
+        $storage1 = $this->getTestStorage(true, TemporaryNoCross::class);
+        $storage2 = $this->getTestStorage(true, TemporaryNoCross::class);
+        $this->moveBetweenStorages($storage1, $storage2);
+    }
+
+    public function testMoveBetweenStorageCross(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $this->moveBetweenStorages($storage1, $storage2);
+    }
+
+    public function testMoveBetweenStorageCrossNonLocal(): void {
+        $storage1 = $this->getTestStorage(true, TemporaryNoLocal::class);
+        $storage2 = $this->getTestStorage(true, TemporaryNoLocal::class);
+        $this->moveBetweenStorages($storage1, $storage2);
+    }
+
+    public function moveBetweenStorages($storage1, $storage2) {
+        Filesystem::mount($storage1, [], '/' . $this->user . '/');
+        Filesystem::mount($storage2, [], '/' . $this->user . '/substorage');
+
+        $rootView = new View('/' . $this->user);
+        $rootView->rename('foo.txt', 'substorage/folder/foo.txt');
+        $this->assertFalse($rootView->file_exists('foo.txt'));
+        $this->assertTrue($rootView->file_exists('substorage/folder/foo.txt'));
+        $rootView->rename('substorage/folder', 'anotherfolder');
+        $this->assertFalse($rootView->is_dir('substorage/folder'));
+        $this->assertTrue($rootView->file_exists('anotherfolder/foo.txt'));
+        $this->assertTrue($rootView->file_exists('anotherfolder/bar.txt'));
+    }
+
+    public function testUnlink(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $rootView->file_put_contents('/foo.txt', 'asd');
+        $rootView->file_put_contents('/substorage/bar.txt', 'asd');
+
+        $this->assertTrue($rootView->file_exists('foo.txt'));
+        $this->assertTrue($rootView->file_exists('substorage/bar.txt'));
+
+        $this->assertTrue($rootView->unlink('foo.txt'));
+        $this->assertTrue($rootView->unlink('substorage/bar.txt'));
+
+        $this->assertFalse($rootView->file_exists('foo.txt'));
+        $this->assertFalse($rootView->file_exists('substorage/bar.txt'));
+    }
+
+    public static function rmdirOrUnlinkDataProvider(): array {
+        return [['rmdir'], ['unlink']];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('rmdirOrUnlinkDataProvider')]
+    public function testRmdir($method): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+
+        $rootView = new View('');
+        $rootView->mkdir('sub');
+        $rootView->mkdir('sub/deep');
+        $rootView->file_put_contents('/sub/deep/foo.txt', 'asd');
+
+        $this->assertTrue($rootView->file_exists('sub/deep/foo.txt'));
+
+        $this->assertTrue($rootView->$method('sub'));
+
+        $this->assertFalse($rootView->file_exists('sub'));
+    }
+
+    public function testUnlinkRootMustFail(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], '/substorage');
+
+        $rootView = new View('');
+        $rootView->file_put_contents('/foo.txt', 'asd');
+        $rootView->file_put_contents('/substorage/bar.txt', 'asd');
+
+        $this->assertFalse($rootView->unlink(''));
+        $this->assertFalse($rootView->unlink('/'));
+        $this->assertFalse($rootView->unlink('substorage'));
+        $this->assertFalse($rootView->unlink('/substorage'));
+    }
+
+    public function testTouch(): void {
+        $storage = $this->getTestStorage(true, TemporaryNoTouch::class);
+
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+        $oldCachedData = $rootView->getFileInfo('foo.txt');
+
+        $rootView->touch('foo.txt', 500);
+
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertEquals(500, $cachedData['mtime']);
+        $this->assertEquals($oldCachedData['storage_mtime'], $cachedData['storage_mtime']);
+
+        $rootView->putFileInfo('foo.txt', ['storage_mtime' => 1000]); //make sure the watcher detects the change
+        $rootView->file_put_contents('foo.txt', 'asd');
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertGreaterThanOrEqual($oldCachedData['mtime'], $cachedData['mtime']);
+        $this->assertEquals($cachedData['storage_mtime'], $cachedData['mtime']);
+    }
+
+    public function testTouchFloat(): void {
+        $storage = $this->getTestStorage(true, TemporaryNoTouch::class);
+
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+        $oldCachedData = $rootView->getFileInfo('foo.txt');
+
+        $rootView->touch('foo.txt', 500.5);
+
+        $cachedData = $rootView->getFileInfo('foo.txt');
+        $this->assertEquals(500, $cachedData['mtime']);
+    }
+
+    public function testViewHooks(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $defaultRoot = Filesystem::getRoot();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], $defaultRoot . '/substorage');
+        \OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
+
+        $rootView = new View('');
+        $subView = new View($defaultRoot . '/substorage');
+        $this->hookPath = null;
+
+        $rootView->file_put_contents('/foo.txt', 'asd');
+        $this->assertNull($this->hookPath);
+
+        $subView->file_put_contents('/foo.txt', 'asd');
+        $this->assertEquals('/substorage/foo.txt', $this->hookPath);
+    }
+
+    private $hookPath;
+
+    public function dummyHook($params) {
+        $this->hookPath = $params['path'];
+    }
+
+    public function testSearchNotOutsideView(): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+        $storage1->rename('folder', 'foo');
+        $scanner = $storage1->getScanner();
+        $scanner->scan('');
+
+        $view = new View('/foo');
+
+        $result = $view->search('.txt');
+        $this->assertCount(1, $result);
+    }
+
+    /**
+     * @param bool $scan
+     * @param string $class
+     * @return Storage
+     */
+    private function getTestStorage($scan = true, $class = Temporary::class) {
+        /**
+         * @var Storage $storage
+         */
+        $storage = new $class([]);
+        $textData = "dummy file data\n";
+        $imgData = file_get_contents(\OC::$SERVERROOT . '/core/img/logo/logo.png');
+        $storage->mkdir('folder');
+        $storage->file_put_contents('foo.txt', $textData);
+        $storage->file_put_contents('foo.png', $imgData);
+        $storage->file_put_contents('folder/bar.txt', $textData);
+
+        if ($scan) {
+            $scanner = $storage->getScanner();
+            $scanner->scan('');
+        }
+        $this->storages[] = $storage;
+        return $storage;
+    }
+
+    public function testViewHooksIfRootStartsTheSame(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $defaultRoot = Filesystem::getRoot();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], $defaultRoot . '_substorage');
+        \OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
+
+        $subView = new View($defaultRoot . '_substorage');
+        $this->hookPath = null;
+
+        $subView->file_put_contents('/foo.txt', 'asd');
+        $this->assertNull($this->hookPath);
+    }
+
+    private $hookWritePath;
+    private $hookCreatePath;
+    private $hookUpdatePath;
+
+    public function dummyHookWrite($params) {
+        $this->hookWritePath = $params['path'];
+    }
+
+    public function dummyHookUpdate($params) {
+        $this->hookUpdatePath = $params['path'];
+    }
+
+    public function dummyHookCreate($params) {
+        $this->hookCreatePath = $params['path'];
+    }
+
+    public function testEditNoCreateHook(): void {
+        $storage1 = $this->getTestStorage();
+        $storage2 = $this->getTestStorage();
+        $defaultRoot = Filesystem::getRoot();
+        Filesystem::mount($storage1, [], '/');
+        Filesystem::mount($storage2, [], $defaultRoot);
+        \OC_Hook::connect('OC_Filesystem', 'post_create', $this, 'dummyHookCreate');
+        \OC_Hook::connect('OC_Filesystem', 'post_update', $this, 'dummyHookUpdate');
+        \OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHookWrite');
+
+        $view = new View($defaultRoot);
+        $this->hookWritePath = $this->hookUpdatePath = $this->hookCreatePath = null;
+
+        $view->file_put_contents('/asd.txt', 'foo');
+        $this->assertEquals('/asd.txt', $this->hookCreatePath);
+        $this->assertNull($this->hookUpdatePath);
+        $this->assertEquals('/asd.txt', $this->hookWritePath);
+
+        $this->hookWritePath = $this->hookUpdatePath = $this->hookCreatePath = null;
+
+        $view->file_put_contents('/asd.txt', 'foo');
+        $this->assertNull($this->hookCreatePath);
+        $this->assertEquals('/asd.txt', $this->hookUpdatePath);
+        $this->assertEquals('/asd.txt', $this->hookWritePath);
+
+        \OC_Hook::clear('OC_Filesystem', 'post_create');
+        \OC_Hook::clear('OC_Filesystem', 'post_update');
+        \OC_Hook::clear('OC_Filesystem', 'post_write');
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('resolvePathTestProvider')]
+    public function testResolvePath($expected, $pathToTest): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+
+        $view = new View('');
+
+        $result = $view->resolvePath($pathToTest);
+        $this->assertEquals($expected, $result[1]);
+
+        $exists = $view->file_exists($pathToTest);
+        $this->assertTrue($exists);
+
+        $exists = $view->file_exists($result[1]);
+        $this->assertTrue($exists);
+    }
+
+    public static function resolvePathTestProvider(): array {
+        return [
+            ['foo.txt', 'foo.txt'],
+            ['foo.txt', '/foo.txt'],
+            ['folder', 'folder'],
+            ['folder', '/folder'],
+            ['folder', 'folder/'],
+            ['folder', '/folder/'],
+            ['folder/bar.txt', 'folder/bar.txt'],
+            ['folder/bar.txt', '/folder/bar.txt'],
+            ['', ''],
+            ['', '/'],
+        ];
+    }
+
+    public function testUTF8Names(): void {
+        $names = ['虚', '和知しゃ和で', 'regular ascii', 'sɨˈrɪlɪk', 'ѨѬ', 'أنا أحب القراءة كثيرا'];
+
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+        foreach ($names as $name) {
+            $rootView->file_put_contents('/' . $name, 'dummy content');
+        }
+
+        $list = $rootView->getDirectoryContent('/');
+
+        $this->assertCount(count($names), $list);
+        foreach ($list as $item) {
+            $this->assertContains($item['name'], $names);
+        }
+
+        $cache = $storage->getCache();
+        $scanner = $storage->getScanner();
+        $scanner->scan('');
+
+        $list = $cache->getFolderContents('');
+
+        $this->assertCount(count($names), $list);
+        foreach ($list as $item) {
+            $this->assertContains($item['name'], $names);
+        }
+    }
+
+    public function xtestLongPath() {
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+
+        $longPath = '';
+        $ds = DIRECTORY_SEPARATOR;
+        /*
 		 * 4096 is the maximum path length in file_cache.path in *nix
 		 */
-		$folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
-		$tmpdirLength = strlen(Server::get(ITempManager::class)->getTemporaryFolder());
-		$depth = ((4000 - $tmpdirLength) / 57);
-
-		foreach (range(0, $depth - 1) as $i) {
-			$longPath .= $ds . $folderName;
-			$result = $rootView->mkdir($longPath);
-			$this->assertTrue($result, "mkdir failed on $i - path length: " . strlen($longPath));
-
-			$result = $rootView->file_put_contents($longPath . "{$ds}test.txt", 'lorem');
-			$this->assertEquals(5, $result, "file_put_contents failed on $i");
-
-			$this->assertTrue($rootView->file_exists($longPath));
-			$this->assertTrue($rootView->file_exists($longPath . "{$ds}test.txt"));
-		}
-
-		$cache = $storage->getCache();
-		$scanner = $storage->getScanner();
-		$scanner->scan('');
-
-		$longPath = $folderName;
-		foreach (range(0, $depth - 1) as $i) {
-			$cachedFolder = $cache->get($longPath);
-			$this->assertTrue(is_array($cachedFolder), "No cache entry for folder at $i");
-			$this->assertEquals($folderName, $cachedFolder['name'], "Wrong cache entry for folder at $i");
-
-			$cachedFile = $cache->get($longPath . '/test.txt');
-			$this->assertTrue(is_array($cachedFile), "No cache entry for file at $i");
-			$this->assertEquals('test.txt', $cachedFile['name'], "Wrong cache entry for file at $i");
-
-			$longPath .= $ds . $folderName;
-		}
-	}
-
-	public function testTouchNotSupported(): void {
-		$storage = new TemporaryNoTouch([]);
-		$scanner = $storage->getScanner();
-		Filesystem::mount($storage, [], '/test/');
-		$past = time() - 100;
-		$storage->file_put_contents('test', 'foobar');
-		$scanner->scan('');
-		$view = new View('');
-		$info = $view->getFileInfo('/test/test');
-
-		$view->touch('/test/test', $past);
-		$scanner->scanFile('test', Scanner::REUSE_ETAG);
-
-		$info2 = $view->getFileInfo('/test/test');
-		$this->assertSame($info['etag'], $info2['etag']);
-	}
-
-	public function testWatcherEtagCrossStorage(): void {
-		$storage1 = new Temporary([]);
-		$storage2 = new Temporary([]);
-		$scanner1 = $storage1->getScanner();
-		$scanner2 = $storage2->getScanner();
-		$storage1->mkdir('sub');
-		Filesystem::mount($storage1, [], '/test/');
-		Filesystem::mount($storage2, [], '/test/sub/storage');
-
-		$past = time() - 100;
-		$storage2->file_put_contents('test.txt', 'foobar');
-		$scanner1->scan('');
-		$scanner2->scan('');
-		$view = new View('');
-
-		$storage2->getWatcher('')->setPolicy(Watcher::CHECK_ALWAYS);
-
-		$oldFileInfo = $view->getFileInfo('/test/sub/storage/test.txt');
-		$oldFolderInfo = $view->getFileInfo('/test');
-
-		$storage2->getCache()->update($oldFileInfo->getId(), [
-			'storage_mtime' => $past,
-		]);
-
-		$oldEtag = $oldFolderInfo->getEtag();
-
-		$view->getFileInfo('/test/sub/storage/test.txt');
-		$newFolderInfo = $view->getFileInfo('/test');
-
-		$this->assertNotEquals($newFolderInfo->getEtag(), $oldEtag);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('absolutePathProvider')]
-	public function testGetAbsolutePath($expectedPath, $relativePath): void {
-		$view = new View('/files');
-		$this->assertEquals($expectedPath, $view->getAbsolutePath($relativePath));
-	}
-
-	public function testPartFileInfo(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		Filesystem::mount($storage, [], '/test/');
-		$sizeWritten = $storage->file_put_contents('test.part', 'foobar');
-		$scanner->scan('');
-		$view = new View('/test');
-		$info = $view->getFileInfo('test.part');
-
-		$this->assertInstanceOf('\OCP\Files\FileInfo', $info);
-		$this->assertNull($info->getId());
-		$this->assertEquals(6, $sizeWritten);
-		$this->assertEquals(6, $info->getSize());
-		$this->assertEquals('foobar', $view->file_get_contents('test.part'));
-	}
-
-	public static function absolutePathProvider(): array {
-		return [
-			['/files', ''],
-			['/files/0', '0'],
-			['/files/false', 'false'],
-			['/files/true', 'true'],
-			['/files', '/'],
-			['/files/test', 'test'],
-			['/files/test', '/test'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('chrootRelativePathProvider')]
-	public function testChrootGetRelativePath($root, $absolutePath, $expectedPath): void {
-		$view = new View('/files');
-		$view->chroot($root);
-		$this->assertEquals($expectedPath, $view->getRelativePath($absolutePath));
-	}
-
-	public static function chrootRelativePathProvider(): array {
-		return self::relativePathProvider('/');
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('initRelativePathProvider')]
-	public function testInitGetRelativePath($root, $absolutePath, $expectedPath): void {
-		$view = new View($root);
-		$this->assertEquals($expectedPath, $view->getRelativePath($absolutePath));
-	}
-
-	public static function initRelativePathProvider(): array {
-		return self::relativePathProvider(null);
-	}
-
-	public static function relativePathProvider($missingRootExpectedPath): array {
-		return [
-			// No root - returns the path
-			['', '/files', '/files'],
-			['', '/files/', '/files/'],
-
-			// Root equals path - /
-			['/files/', '/files/', '/'],
-			['/files/', '/files', '/'],
-			['/files', '/files/', '/'],
-			['/files', '/files', '/'],
-
-			// False negatives: chroot fixes those by adding the leading slash.
-			// But setting them up with this root (instead of chroot($root))
-			// will fail them, although they should be the same.
-			// TODO init should be fixed, so it also adds the leading slash
-			['files/', '/files/', $missingRootExpectedPath],
-			['files', '/files/', $missingRootExpectedPath],
-			['files/', '/files', $missingRootExpectedPath],
-			['files', '/files', $missingRootExpectedPath],
-
-			// False negatives: Paths provided to the method should have a leading slash
-			// TODO input should be checked to have a leading slash
-			['/files/', 'files/', null],
-			['/files', 'files/', null],
-			['/files/', 'files', null],
-			['/files', 'files', null],
-
-			// with trailing slashes
-			['/files/', '/files/0', '0'],
-			['/files/', '/files/false', 'false'],
-			['/files/', '/files/true', 'true'],
-			['/files/', '/files/test', 'test'],
-			['/files/', '/files/test/foo', 'test/foo'],
-
-			// without trailing slashes
-			// TODO false expectation: Should match "with trailing slashes"
-			['/files', '/files/0', '/0'],
-			['/files', '/files/false', '/false'],
-			['/files', '/files/true', '/true'],
-			['/files', '/files/test', '/test'],
-			['/files', '/files/test/foo', '/test/foo'],
-
-			// leading slashes
-			['/files/', '/files_trashbin/', null],
-			['/files', '/files_trashbin/', null],
-			['/files/', '/files_trashbin', null],
-			['/files', '/files_trashbin', null],
-
-			// no leading slashes
-			['files/', 'files_trashbin/', null],
-			['files', 'files_trashbin/', null],
-			['files/', 'files_trashbin', null],
-			['files', 'files_trashbin', null],
-
-			// mixed leading slashes
-			['files/', '/files_trashbin/', null],
-			['/files/', 'files_trashbin/', null],
-			['files', '/files_trashbin/', null],
-			['/files', 'files_trashbin/', null],
-			['files/', '/files_trashbin', null],
-			['/files/', 'files_trashbin', null],
-			['files', '/files_trashbin', null],
-			['/files', 'files_trashbin', null],
-
-			['files', 'files_trashbin/test', null],
-			['/files', '/files_trashbin/test', null],
-			['/files', 'files_trashbin/test', null],
-		];
-	}
-
-	public function testFileView(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->file_put_contents('foo.txt', 'bar');
-		Filesystem::mount($storage, [], '/test/');
-		$scanner->scan('');
-		$view = new View('/test/foo.txt');
-
-		$this->assertEquals('bar', $view->file_get_contents(''));
-		$fh = tmpfile();
-		fwrite($fh, 'foo');
-		rewind($fh);
-		$view->file_put_contents('', $fh);
-		$this->assertEquals('foo', $view->file_get_contents(''));
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('tooLongPathDataProvider')]
-	public function testTooLongPath($operation, $param0 = null): void {
-		$this->expectException(InvalidPathException::class);
-
-
-		$longPath = '';
-		// 4000 is the maximum path length in file_cache.path
-		$folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
-		$depth = (4000 / 57);
-		foreach (range(0, $depth + 1) as $i) {
-			$longPath .= '/' . $folderName;
-		}
-
-		$storage = new Temporary([]);
-		$this->tempStorage = $storage; // for later hard cleanup
-		Filesystem::mount($storage, [], '/');
-
-		$rootView = new View('');
-
-		if ($param0 === '@0') {
-			$param0 = $longPath;
-		}
-
-		if ($operation === 'hash') {
-			$param0 = $longPath;
-			$longPath = 'md5';
-		}
-
-		call_user_func([$rootView, $operation], $longPath, $param0);
-	}
-
-	public static function tooLongPathDataProvider(): array {
-		return [
-			['getAbsolutePath'],
-			['getRelativePath'],
-			['getMountPoint'],
-			['resolvePath'],
-			['getLocalFile'],
-			['mkdir'],
-			['rmdir'],
-			['opendir'],
-			['is_dir'],
-			['is_file'],
-			['stat'],
-			['filetype'],
-			['filesize'],
-			['readfile'],
-			['isCreatable'],
-			['isReadable'],
-			['isUpdatable'],
-			['isDeletable'],
-			['isSharable'],
-			['file_exists'],
-			['filemtime'],
-			['touch'],
-			['file_get_contents'],
-			['unlink'],
-			['deleteAll'],
-			['toTmpFile'],
-			['getMimeType'],
-			['free_space'],
-			['getFileInfo'],
-			['getDirectoryContent'],
-			['getOwner'],
-			['getETag'],
-			['file_put_contents', 'ipsum'],
-			['rename', '@0'],
-			['copy', '@0'],
-			['fopen', 'r'],
-			['fromTmpFile', '@0'],
-			['hash'],
-			['hasUpdated', 0],
-			['putFileInfo', []],
-		];
-	}
-
-	public function testRenameCrossStoragePreserveMtime(): void {
-		$storage1 = new Temporary([]);
-		$storage2 = new Temporary([]);
-		$storage1->mkdir('sub');
-		$storage1->mkdir('foo');
-		$storage1->file_put_contents('foo.txt', 'asd');
-		$storage1->file_put_contents('foo/bar.txt', 'asd');
-		Filesystem::mount($storage1, [], '/test/');
-		Filesystem::mount($storage2, [], '/test/sub/storage');
-
-		$view = new View('');
-		$time = time() - 200;
-		$view->touch('/test/foo.txt', $time);
-		$view->touch('/test/foo', $time);
-		$view->touch('/test/foo/bar.txt', $time);
-
-		$view->rename('/test/foo.txt', '/test/sub/storage/foo.txt');
-
-		$this->assertEquals($time, $view->filemtime('/test/sub/storage/foo.txt'));
-
-		$view->rename('/test/foo', '/test/sub/storage/foo');
-
-		$this->assertEquals($time, $view->filemtime('/test/sub/storage/foo/bar.txt'));
-	}
-
-	public function testRenameFailDeleteTargetKeepSource(): void {
-		$this->doTestCopyRenameFail('rename');
-	}
-
-	public function testCopyFailDeleteTargetKeepSource(): void {
-		$this->doTestCopyRenameFail('copy');
-	}
-
-	private function doTestCopyRenameFail($operation) {
-		$storage1 = new Temporary([]);
-		/** @var \PHPUnit\Framework\MockObject\MockObject|Temporary $storage2 */
-		$storage2 = $this->getMockBuilder(TemporaryNoCross::class)
-			->setConstructorArgs([[]])
-			->onlyMethods(['fopen', 'writeStream'])
-			->getMock();
-
-		$storage2->method('writeStream')
-			->willThrowException(new GenericFileException('Failed to copy stream'));
-
-		$storage2->method('fopen')
-			->willReturn(false);
-
-		$storage1->mkdir('sub');
-		$storage1->file_put_contents('foo.txt', '0123456789ABCDEFGH');
-		$storage1->mkdir('dirtomove');
-		$storage1->file_put_contents('dirtomove/indir1.txt', '0123456'); // fits
-		$storage1->file_put_contents('dirtomove/indir2.txt', '0123456789ABCDEFGH'); // doesn't fit
-		$storage2->file_put_contents('existing.txt', '0123');
-		$storage1->getScanner()->scan('');
-		$storage2->getScanner()->scan('');
-		Filesystem::mount($storage1, [], '/test/');
-		Filesystem::mount($storage2, [], '/test/sub/storage');
-
-		// move file
-		$view = new View('');
-		$this->assertTrue($storage1->file_exists('foo.txt'));
-		$this->assertFalse($storage2->file_exists('foo.txt'));
-		$this->assertFalse($view->$operation('/test/foo.txt', '/test/sub/storage/foo.txt'));
-		$this->assertFalse($storage2->file_exists('foo.txt'));
-		$this->assertFalse($storage2->getCache()->get('foo.txt'));
-		$this->assertTrue($storage1->file_exists('foo.txt'));
-
-		// if target exists, it will be deleted too
-		$this->assertFalse($view->$operation('/test/foo.txt', '/test/sub/storage/existing.txt'));
-		$this->assertFalse($storage2->file_exists('existing.txt'));
-		$this->assertFalse($storage2->getCache()->get('existing.txt'));
-		$this->assertTrue($storage1->file_exists('foo.txt'));
-
-		// move folder
-		$this->assertFalse($view->$operation('/test/dirtomove/', '/test/sub/storage/dirtomove/'));
-		// since the move failed, the full source tree is kept
-		$this->assertTrue($storage1->file_exists('dirtomove/indir1.txt'));
-		$this->assertTrue($storage1->file_exists('dirtomove/indir2.txt'));
-		// second file not moved/copied
-		$this->assertFalse($storage2->file_exists('dirtomove/indir2.txt'));
-		$this->assertFalse($storage2->getCache()->get('dirtomove/indir2.txt'));
-	}
-
-	public function testDeleteFailKeepCache(): void {
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->setConstructorArgs([[]])
-			->onlyMethods(['unlink'])
-			->getMock();
-		$storage->expects($this->once())
-			->method('unlink')
-			->willReturn(false);
-		$scanner = $storage->getScanner();
-		$cache = $storage->getCache();
-		$storage->file_put_contents('foo.txt', 'asd');
-		$scanner->scan('');
-		Filesystem::mount($storage, [], '/test/');
-
-		$view = new View('/test');
-
-		$this->assertFalse($view->unlink('foo.txt'));
-		$this->assertTrue($cache->inCache('foo.txt'));
-	}
-
-	public static function directoryTraversalProvider(): array {
-		return [
-			['../test/'],
-			['..\\test\\my/../folder'],
-			['/test/my/../foo\\'],
-		];
-	}
-
-	/**
-	 * @param string $root
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('directoryTraversalProvider')]
-	public function testConstructDirectoryTraversalException($root): void {
-		$this->expectException(\Exception::class);
-
-		new View($root);
-	}
-
-	public function testRenameOverWrite(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->mkdir('sub');
-		$storage->mkdir('foo');
-		$storage->file_put_contents('foo.txt', 'asd');
-		$storage->file_put_contents('foo/bar.txt', 'asd');
-		$scanner->scan('');
-		Filesystem::mount($storage, [], '/test/');
-		$view = new View('');
-		$this->assertTrue($view->rename('/test/foo.txt', '/test/foo/bar.txt'));
-	}
-
-	public function testSetMountOptionsInStorage(): void {
-		$mount = new MountPoint(Temporary::class, '/asd/', [[]], Filesystem::getLoader(), ['foo' => 'bar']);
-		Filesystem::getMountManager()->addMount($mount);
-		/** @var Common $storage */
-		$storage = $mount->getStorage();
-		$this->assertEquals($storage->getMountOption('foo'), 'bar');
-	}
-
-	public function testSetMountOptionsWatcherPolicy(): void {
-		$mount = new MountPoint(Temporary::class, '/asd/', [[]], Filesystem::getLoader(), ['filesystem_check_changes' => Watcher::CHECK_NEVER]);
-		Filesystem::getMountManager()->addMount($mount);
-		/** @var Common $storage */
-		$storage = $mount->getStorage();
-		$watcher = $storage->getWatcher();
-		$this->assertEquals(Watcher::CHECK_NEVER, $watcher->getPolicy());
-	}
-
-	public function testGetAbsolutePathOnNull(): void {
-		$view = new View();
-		$this->assertNull($view->getAbsolutePath(null));
-	}
-
-	public function testGetRelativePathOnNull(): void {
-		$view = new View();
-		$this->assertNull($view->getRelativePath(null));
-	}
-
-
-	public function testNullAsRoot(): void {
-		$this->expectException(\TypeError::class);
-
-		new View(null);
-	}
-
-	/**
-	 * e.g. reading from a folder that's being renamed
-	 *
-	 *
-	 *
-	 * @param string $rootPath
-	 * @param string $pathPrefix
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataLockPaths')]
-	public function testReadFromWriteLockedPath($rootPath, $pathPrefix): void {
-		$this->expectException(LockedException::class);
-
-		$rootPath = str_replace('{folder}', 'files', $rootPath);
-		$pathPrefix = str_replace('{folder}', 'files', $pathPrefix);
-
-		$view = new View($rootPath);
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-		$view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED);
-	}
-
-	/**
-	 * Reading from a files_encryption folder that's being renamed
-	 *
-	 *
-	 * @param string $rootPath
-	 * @param string $pathPrefix
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataLockPaths')]
-	public function testReadFromWriteUnlockablePath($rootPath, $pathPrefix): void {
-		$rootPath = str_replace('{folder}', 'files_encryption', $rootPath);
-		$pathPrefix = str_replace('{folder}', 'files_encryption', $pathPrefix);
-
-		$view = new View($rootPath);
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED));
-	}
-
-	/**
-	 * e.g. writing a file that's being downloaded
-	 *
-	 *
-	 *
-	 * @param string $rootPath
-	 * @param string $pathPrefix
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataLockPaths')]
-	public function testWriteToReadLockedFile($rootPath, $pathPrefix): void {
-		$this->expectException(LockedException::class);
-
-		$rootPath = str_replace('{folder}', 'files', $rootPath);
-		$pathPrefix = str_replace('{folder}', 'files', $pathPrefix);
-
-		$view = new View($rootPath);
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
-		$view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE);
-	}
-
-	/**
-	 * Writing a file that's being downloaded
-	 *
-	 *
-	 * @param string $rootPath
-	 * @param string $pathPrefix
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('dataLockPaths')]
-	public function testWriteToReadUnlockableFile($rootPath, $pathPrefix): void {
-		$rootPath = str_replace('{folder}', 'files_encryption', $rootPath);
-		$pathPrefix = str_replace('{folder}', 'files_encryption', $pathPrefix);
-
-		$view = new View($rootPath);
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-	}
-
-	/**
-	 * Test that locks are on mount point paths instead of mount root
-	 */
-	public function testLockLocalMountPointPathInsteadOfStorageRoot(): void {
-		$lockingProvider = Server::get(ILockingProvider::class);
-		$view = new View('/testuser/files/');
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$mountedStorage = new Temporary([]);
-		Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint');
-
-		$this->assertTrue(
-			$view->lockFile('/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, true),
-			'Can lock mount point'
-		);
-
-		// no exception here because storage root was not locked
-		$mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-
-		$thrown = false;
-		try {
-			$storage->acquireLock('/testuser/files/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-		} catch (LockedException $e) {
-			$thrown = true;
-		}
-		$this->assertTrue($thrown, 'Mount point path was locked on root storage');
-
-		$lockingProvider->releaseAll();
-	}
-
-	/**
-	 * Test that locks are on mount point paths and also mount root when requested
-	 */
-	public function testLockStorageRootButNotLocalMountPoint(): void {
-		$lockingProvider = Server::get(ILockingProvider::class);
-		$view = new View('/testuser/files/');
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$mountedStorage = new Temporary([]);
-		Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint');
-
-		$this->assertTrue(
-			$view->lockFile('/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, false),
-			'Can lock mount point'
-		);
-
-		$thrown = false;
-		try {
-			$mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-		} catch (LockedException $e) {
-			$thrown = true;
-		}
-		$this->assertTrue($thrown, 'Mount point storage root was locked on original storage');
-
-		// local mount point was not locked
-		$storage->acquireLock('/testuser/files/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-
-		$lockingProvider->releaseAll();
-	}
-
-	/**
-	 * Test that locks are on mount point paths and also mount root when requested
-	 */
-	public function testLockMountPointPathFailReleasesBoth(): void {
-		$lockingProvider = Server::get(ILockingProvider::class);
-		$view = new View('/testuser/files/');
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-		$mountedStorage = new Temporary([]);
-		Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint.txt');
-
-		// this would happen if someone is writing on the mount point
-		$mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-
-		$thrown = false;
-		try {
-			// this actually acquires two locks, one on the mount point and one on the storage root,
-			// but the one on the storage root will fail
-			$view->lockFile('/mountpoint.txt', ILockingProvider::LOCK_SHARED);
-		} catch (LockedException $e) {
-			$thrown = true;
-		}
-		$this->assertTrue($thrown, 'Cannot acquire shared lock because storage root is already locked');
-
-		// from here we expect that the lock on the local mount point was released properly
-		// so acquiring an exclusive lock will succeed
-		$storage->acquireLock('/testuser/files/mountpoint.txt', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
-
-		$lockingProvider->releaseAll();
-	}
-
-	public static function dataLockPaths(): array {
-		return [
-			['/testuser/{folder}', ''],
-			['/testuser', '/{folder}'],
-			['', '/testuser/{folder}'],
-		];
-	}
-
-	public static function pathRelativeToFilesProvider(): array {
-		return [
-			['admin/files', ''],
-			['admin/files/x', 'x'],
-			['/admin/files', ''],
-			['/admin/files/sub', 'sub'],
-			['/admin/files/sub/', 'sub'],
-			['/admin/files/sub/sub2', 'sub/sub2'],
-			['//admin//files/sub//sub2', 'sub/sub2'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('pathRelativeToFilesProvider')]
-	public function testGetPathRelativeToFiles($path, $expectedPath): void {
-		$view = new View();
-		$this->assertEquals($expectedPath, $view->getPathRelativeToFiles($path));
-	}
-
-	public static function pathRelativeToFilesProviderExceptionCases(): array {
-		return [
-			[''],
-			['x'],
-			['files'],
-			['/files'],
-			['/admin/files_versions/abc'],
-		];
-	}
-
-	/**
-	 * @param string $path
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('pathRelativeToFilesProviderExceptionCases')]
-	public function testGetPathRelativeToFilesWithInvalidArgument($path): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('$absolutePath must be relative to "files"');
-
-		$view = new View();
-		$view->getPathRelativeToFiles($path);
-	}
-
-	public function testChangeLock(): void {
-		$view = new View('/testuser/files/');
-		$storage = new Temporary([]);
-		Filesystem::mount($storage, [], '/');
-
-		$view->lockFile('/test/sub', ILockingProvider::LOCK_SHARED);
-		$this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
-		$this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
-
-		$view->changeLock('//test/sub', ILockingProvider::LOCK_EXCLUSIVE);
-		$this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
-
-		$view->changeLock('test/sub', ILockingProvider::LOCK_SHARED);
-		$this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
-
-		$view->unlockFile('/test/sub/', ILockingProvider::LOCK_SHARED);
-
-		$this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
-		$this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
-	}
-
-	public static function hookPathProvider(): array {
-		return [
-			['/foo/files', '/foo', true],
-			['/foo/files/bar', '/foo', true],
-			['/foo', '/foo', false],
-			['/foo', '/files/foo', true],
-			['/foo', 'filesfoo', false],
-			['', '/foo/files', true],
-			['', '/foo/files/bar.txt', true],
-		];
-	}
-
-	/**
-	 * @param $root
-	 * @param $path
-	 * @param $shouldEmit
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('hookPathProvider')]
-	public function testHookPaths($root, $path, $shouldEmit): void {
-		$filesystemReflection = new \ReflectionClass(Filesystem::class);
-		$defaultRootValue = $filesystemReflection->getProperty('defaultInstance');
-		$defaultRootValue->setAccessible(true);
-		$oldRoot = $defaultRootValue->getValue();
-		$defaultView = new View('/foo/files');
-		$defaultRootValue->setValue(null, $defaultView);
-		$view = new View($root);
-		$result = self::invokePrivate($view, 'shouldEmitHooks', [$path]);
-		$defaultRootValue->setValue(null, $oldRoot);
-		$this->assertEquals($shouldEmit, $result);
-	}
-
-	/**
-	 * Create test movable mount points
-	 *
-	 * @param array $mountPoints array of mount point locations
-	 * @return array array of MountPoint objects
-	 */
-	private function createTestMovableMountPoints($mountPoints) {
-		$mounts = [];
-		foreach ($mountPoints as $mountPoint) {
-			$storage = $this->getMockBuilder(Storage::class)
-				->onlyMethods([])
-				->getMock();
-			$storage->method('getId')->willReturn('non-null-id');
-			$storage->method('getStorageCache')->willReturnCallback(function () use ($storage) {
-				return new \OC\Files\Cache\Storage($storage, true, Server::get(IDBConnection::class));
-			});
-
-			$mounts[] = $this->getMockBuilder(TestMoveableMountPoint::class)
-				->onlyMethods(['moveMount'])
-				->setConstructorArgs([$storage, $mountPoint])
-				->getMock();
-		}
-
-		/** @var IMountProvider|\PHPUnit\Framework\MockObject\MockObject $mountProvider */
-		$mountProvider = $this->createMock(IMountProvider::class);
-		$mountProvider->expects($this->any())
-			->method('getMountsForUser')
-			->willReturn($mounts);
-
-		$mountProviderCollection = Server::get(IMountProviderCollection::class);
-		$mountProviderCollection->registerProvider($mountProvider);
-
-		return $mounts;
-	}
-
-	/**
-	 * Test mount point move
-	 */
-	public function testMountPointMove(): void {
-		self::loginAsUser($this->user);
-
-		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
-		]);
-		$mount1->expects($this->once())
-			->method('moveMount')
-			->willReturn(true);
-
-		$mount2->expects($this->once())
-			->method('moveMount')
-			->willReturn(true);
-
-		$view = new View('/' . $this->user . '/files/');
-		$view->mkdir('sub');
-
-		$this->assertTrue($view->rename('mount1', 'renamed_mount'), 'Can rename mount point');
-		$this->assertTrue($view->rename('mount2', 'sub/moved_mount'), 'Can move a mount point into a subdirectory');
-	}
-
-	public function testMoveMountPointOverwrite(): void {
-		self::loginAsUser($this->user);
-
-		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
-		]);
-
-		$mount1->expects($this->never())
-			->method('moveMount');
-
-		$mount2->expects($this->never())
-			->method('moveMount');
-
-		$view = new View('/' . $this->user . '/files/');
-
-		$this->expectException(ForbiddenException::class);
-		$view->rename('mount1', 'mount2');
-	}
-
-	public function testMoveMountPointIntoMount(): void {
-		self::loginAsUser($this->user);
-
-		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
-		]);
-
-		$mount1->expects($this->never())
-			->method('moveMount');
-
-		$mount2->expects($this->never())
-			->method('moveMount');
-
-		$view = new View('/' . $this->user . '/files/');
-
-		$this->expectException(ForbiddenException::class);
-		$view->rename('mount1', 'mount2/sub');
-	}
-
-	/**
-	 * Test that moving a mount point into a shared folder is forbidden
-	 */
-	public function testMoveMountPointIntoSharedFolder(): void {
-		self::loginAsUser($this->user);
-
-		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
-		]);
-
-		$mount1->expects($this->never())
-			->method('moveMount');
-
-		$mount2->expects($this->once())
-			->method('moveMount')
-			->willReturn(true);
-
-		$view = new View('/' . $this->user . '/files/');
-		$view->mkdir('shareddir');
-		$view->mkdir('shareddir/sub');
-		$view->mkdir('shareddir/sub2');
-		// Create a similar named but non-shared folder
-		$view->mkdir('shareddir notshared');
-
-		$fileId = $view->getFileInfo('shareddir')->getId();
-		$userObject = Server::get(IUserManager::class)->createUser('test2', 'IHateNonMockableStaticClasses');
-
-		$userFolder = \OC::$server->getUserFolder($this->user);
-		$shareDir = $userFolder->get('shareddir');
-		$shareManager = Server::get(IShareManager::class);
-		$share = $shareManager->newShare();
-		$share->setSharedWith('test2')
-			->setSharedBy($this->user)
-			->setShareType(IShare::TYPE_USER)
-			->setPermissions(Constants::PERMISSION_READ)
-			->setNode($shareDir);
-		$shareManager->createShare($share);
-
-		try {
-			$view->rename('mount1', 'shareddir');
-			$this->fail('Cannot overwrite shared folder');
-		} catch (ForbiddenException $e) {
-
-		}
-		try {
-			$view->rename('mount1', 'shareddir/sub');
-			$this->fail('Cannot move mount point into shared folder');
-		} catch (ForbiddenException $e) {
-
-		}
-		try {
-			$view->rename('mount1', 'shareddir/sub/sub2');
-			$this->fail('Cannot move mount point into shared subfolder');
-		} catch (ForbiddenException $e) {
-
-		}
-		$this->assertTrue($view->rename('mount2', 'shareddir notshared/sub'), 'Can move mount point into a similarly named but non-shared folder');
-
-		$shareManager->deleteShare($share);
-		$userObject->delete();
-	}
-
-	public static function basicOperationProviderForLocks(): array {
-		return [
-			// --- write hook ----
-			[
-				'touch',
-				['touch-create.txt'],
-				'touch-create.txt',
-				'create',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-			],
-			[
-				'fopen',
-				['test-write.txt', 'w'],
-				'test-write.txt',
-				'write',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				null,
-				// exclusive lock stays until fclose
-				ILockingProvider::LOCK_EXCLUSIVE,
-			],
-			[
-				'mkdir',
-				['newdir'],
-				'newdir',
-				'write',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-			],
-			[
-				'file_put_contents',
-				['file_put_contents.txt', 'blah'],
-				'file_put_contents.txt',
-				'write',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				0,
-			],
-
-			// ---- delete hook ----
-			[
-				'rmdir',
-				['dir'],
-				'dir',
-				'delete',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-			],
-			[
-				'unlink',
-				['test.txt'],
-				'test.txt',
-				'delete',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_EXCLUSIVE,
-				ILockingProvider::LOCK_SHARED,
-			],
-
-			// ---- read hook (no post hooks) ----
-			[
-				'file_get_contents',
-				['test.txt'],
-				'test.txt',
-				'read',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				null,
-				false,
-			],
-			[
-				'fopen',
-				['test.txt', 'r'],
-				'test.txt',
-				'read',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-			],
-			[
-				'opendir',
-				['dir'],
-				'dir',
-				'read',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-			],
-
-			// ---- no lock, touch hook ---
-			['touch', ['test.txt'], 'test.txt', 'touch', null, null, null],
-
-			// ---- no hooks, no locks ---
-			['is_dir', ['dir'], 'dir', ''],
-			['is_file', ['dir'], 'dir', ''],
-			[
-				'stat',
-				['dir'],
-				'dir',
-				'',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				false,
-			],
-			[
-				'filetype',
-				['dir'],
-				'dir',
-				'',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				false,
-			],
-			[
-				'filesize',
-				['dir'],
-				'dir',
-				'',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				/* Return an int */
-				100
-			],
-			['isCreatable', ['dir'], 'dir', ''],
-			['isReadable', ['dir'], 'dir', ''],
-			['isUpdatable', ['dir'], 'dir', ''],
-			['isDeletable', ['dir'], 'dir', ''],
-			['isSharable', ['dir'], 'dir', ''],
-			['file_exists', ['dir'], 'dir', ''],
-			[
-				'filemtime',
-				['dir'],
-				'dir',
-				'',
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				ILockingProvider::LOCK_SHARED,
-				null,
-				false,
-			],
-		];
-	}
-
-	/**
-	 * Test whether locks are set before and after the operation
-	 *
-	 *
-	 * @param string $operation operation name on the view
-	 * @param array $operationArgs arguments for the operation
-	 * @param string $lockedPath path of the locked item to check
-	 * @param string $hookType hook type
-	 * @param ?int $expectedLockBefore expected lock during pre hooks
-	 * @param ?int $expectedLockDuring expected lock during operation
-	 * @param ?int $expectedLockAfter expected lock during post hooks
-	 * @param ?int $expectedStrayLock expected lock after returning, should
-	 *                                be null (unlock) for most operations
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('basicOperationProviderForLocks')]
-	public function testLockBasicOperation(
-		string $operation,
-		array $operationArgs,
-		string $lockedPath,
-		string $hookType,
-		?int $expectedLockBefore = ILockingProvider::LOCK_SHARED,
-		?int $expectedLockDuring = ILockingProvider::LOCK_SHARED,
-		?int $expectedLockAfter = ILockingProvider::LOCK_SHARED,
-		?int $expectedStrayLock = null,
-		mixed $returnValue = true,
-	): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary&MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$operation])
-			->getMock();
-
-		/* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
-		Server::get(ITrashManager::class)->pauseTrash();
-		/* Same thing with encryption wrapper */
-		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
-
-		Filesystem::mount($storage, [], $this->user . '/');
-
-		// work directly on disk because mkdir might be mocked
-		$realPath = $storage->getSourcePath('');
-		mkdir($realPath . '/files');
-		mkdir($realPath . '/files/dir');
-		file_put_contents($realPath . '/files/test.txt', 'blah');
-		$storage->getScanner()->scan('files');
-
-		$storage->expects($this->once())
-			->method($operation)
-			->willReturnCallback(
-				function () use ($view, $lockedPath, &$lockTypeDuring, $returnValue) {
-					$lockTypeDuring = $this->getFileLockType($view, $lockedPath);
-
-					return $returnValue;
-				}
-			);
-
-		$this->assertNull($this->getFileLockType($view, $lockedPath), 'File not locked before operation');
-
-		$this->connectMockHooks($hookType, $view, $lockedPath, $lockTypePre, $lockTypePost);
-
-		// do operation
-		call_user_func_array([$view, $operation], $operationArgs);
-
-		if ($hookType !== '') {
-			$this->assertEquals($expectedLockBefore, $lockTypePre, 'File locked properly during pre-hook');
-			$this->assertEquals($expectedLockAfter, $lockTypePost, 'File locked properly during post-hook');
-			$this->assertEquals($expectedLockDuring, $lockTypeDuring, 'File locked properly during operation');
-		} else {
-			$this->assertNull($lockTypeDuring, 'File not locked during operation');
-		}
-
-		$this->assertEquals($expectedStrayLock, $this->getFileLockType($view, $lockedPath));
-
-		/* Resume trash to avoid side effects */
-		Server::get(ITrashManager::class)->resumeTrash();
-	}
-
-	/**
-	 * Test locks for file_put_content with stream.
-	 * This code path uses $storage->fopen instead
-	 */
-	public function testLockFilePutContentWithStream(): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		$path = 'test_file_put_contents.txt';
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods(['fopen'])
-			->getMock();
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-
-		$storage->expects($this->once())
-			->method('fopen')
-			->willReturnCallback(
-				function () use ($view, $path, &$lockTypeDuring) {
-					$lockTypeDuring = $this->getFileLockType($view, $path);
-
-					return fopen('php://temp', 'r+');
-				}
-			);
-
-		$this->connectMockHooks('write', $view, $path, $lockTypePre, $lockTypePost);
-
-		$this->assertNull($this->getFileLockType($view, $path), 'File not locked before operation');
-
-		// do operation
-		$view->file_put_contents($path, fopen('php://temp', 'r+'));
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePre, 'File locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePost, 'File locked properly during post-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File locked properly during operation');
-
-		$this->assertNull($this->getFileLockType($view, $path));
-	}
-
-	/**
-	 * Test locks for fopen with fclose at the end
-	 */
-	public function testLockFopen(): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		$path = 'test_file_put_contents.txt';
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods(['fopen'])
-			->getMock();
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-
-		$storage->expects($this->once())
-			->method('fopen')
-			->willReturnCallback(
-				function () use ($view, $path, &$lockTypeDuring) {
-					$lockTypeDuring = $this->getFileLockType($view, $path);
-
-					return fopen('php://temp', 'r+');
-				}
-			);
-
-		$this->connectMockHooks('write', $view, $path, $lockTypePre, $lockTypePost);
-
-		$this->assertNull($this->getFileLockType($view, $path), 'File not locked before operation');
-
-		// do operation
-		$res = $view->fopen($path, 'w');
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePre, 'File locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File locked properly during operation');
-		$this->assertNull($lockTypePost, 'No post hook, no lock check possible');
-
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File still locked after fopen');
-
-		fclose($res);
-
-		$this->assertNull($this->getFileLockType($view, $path), 'File unlocked after fclose');
-	}
-
-	/**
-	 * Test locks for fopen with fclose at the end
-	 *
-	 *
-	 * @param string $operation operation name on the view
-	 * @param array $operationArgs arguments for the operation
-	 * @param string $path path of the locked item to check
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('basicOperationProviderForLocks')]
-	public function testLockBasicOperationUnlocksAfterException(
-		$operation,
-		$operationArgs,
-		$path,
-	): void {
-		if ($operation === 'touch') {
-			$this->markTestSkipped('touch handles storage exceptions internally');
-		}
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$operation])
-			->getMock();
-
-		/* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
-		Server::get(ITrashManager::class)->pauseTrash();
-		/* Same thing with encryption wrapper */
-		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
-
-		Filesystem::mount($storage, [], $this->user . '/');
-
-		// work directly on disk because mkdir might be mocked
-		$realPath = $storage->getSourcePath('');
-		mkdir($realPath . '/files');
-		mkdir($realPath . '/files/dir');
-		file_put_contents($realPath . '/files/test.txt', 'blah');
-		$storage->getScanner()->scan('files');
-
-		$storage->expects($this->once())
-			->method($operation)
-			->willReturnCallback(
-				function (): void {
-					throw new \Exception('Simulated exception');
-				}
-			);
-
-		$thrown = false;
-		try {
-			call_user_func_array([$view, $operation], $operationArgs);
-		} catch (\Exception $e) {
-			$thrown = true;
-			$this->assertEquals('Simulated exception', $e->getMessage());
-		}
-		$this->assertTrue($thrown, 'Exception was rethrown');
-		$this->assertNull($this->getFileLockType($view, $path), 'File got unlocked after exception');
-
-		/* Resume trash to avoid side effects */
-		Server::get(ITrashManager::class)->resumeTrash();
-	}
-
-	public function testLockBasicOperationUnlocksAfterLockException(): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		$storage = new Temporary([]);
-
-		Filesystem::mount($storage, [], $this->user . '/');
-
-		$storage->mkdir('files');
-		$storage->mkdir('files/dir');
-		$storage->file_put_contents('files/test.txt', 'blah');
-		$storage->getScanner()->scan('files');
-
-		// get a shared lock
-		$handle = $view->fopen('test.txt', 'r');
-
-		$thrown = false;
-		try {
-			// try (and fail) to get a write lock
-			$view->unlink('test.txt');
-		} catch (\Exception $e) {
-			$thrown = true;
-			$this->assertInstanceOf(LockedException::class, $e);
-		}
-		$this->assertTrue($thrown, 'Exception was rethrown');
-
-		// clean shared lock
-		fclose($handle);
-
-		$this->assertNull($this->getFileLockType($view, 'test.txt'), 'File got unlocked');
-	}
-
-	/**
-	 * Test locks for fopen with fclose at the end
-	 *
-	 *
-	 * @param string $operation operation name on the view
-	 * @param array $operationArgs arguments for the operation
-	 * @param string $path path of the locked item to check
-	 * @param string $hookType hook type
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('basicOperationProviderForLocks')]
-	public function testLockBasicOperationUnlocksAfterCancelledHook(
-		$operation,
-		$operationArgs,
-		$path,
-		$hookType,
-	): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$operation])
-			->getMock();
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			$hookType,
-			HookHelper::class,
-			'cancellingCallback'
-		);
-
-		call_user_func_array([$view, $operation], $operationArgs);
-
-		$this->assertNull($this->getFileLockType($view, $path), 'File got unlocked after exception');
-	}
-
-	public static function lockFileRenameOrCopyDataProvider(): array {
-		return [
-			['rename', ILockingProvider::LOCK_EXCLUSIVE],
-			['copy', ILockingProvider::LOCK_SHARED],
-		];
-	}
-
-	/**
-	 * Test locks for rename or copy operation
-	 *
-	 *
-	 * @param string $operation operation to be done on the view
-	 * @param int $expectedLockTypeSourceDuring expected lock type on source file during
-	 *                                          the operation
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('lockFileRenameOrCopyDataProvider')]
-	public function testLockFileRename($operation, $expectedLockTypeSourceDuring): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$operation, 'getMetaData', 'filemtime'])
-			->getMock();
-
-		$storage->expects($this->any())
-			->method('getMetaData')
-			->willReturn([
-				'mtime' => 1885434487,
-				'etag' => '',
-				'mimetype' => 'text/plain',
-				'permissions' => Constants::PERMISSION_ALL,
-				'size' => 3
-			]);
-		$storage->expects($this->any())
-			->method('filemtime')
-			->willReturn(123456789);
-
-		$sourcePath = 'original.txt';
-		$targetPath = 'target.txt';
-
-		/* Disable encryption wrapper to avoid it intercepting mocked call */
-		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-		$view->file_put_contents($sourcePath, 'meh');
-
-		$storage->expects($this->once())
-			->method($operation)
-			->willReturnCallback(
-				function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
-					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
-					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
-
-					return true;
-				}
-			);
-
-		$this->connectMockHooks($operation, $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
-		$this->connectMockHooks($operation, $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
-
-		$view->$operation($sourcePath, $targetPath);
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source file locked properly during pre-hook');
-		$this->assertEquals($expectedLockTypeSourceDuring, $lockTypeSourceDuring, 'Source file locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source file locked properly during post-hook');
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target file locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target file locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target file locked properly during post-hook');
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
-	}
-
-	/**
-	 * simulate a failed copy operation.
-	 * We expect that we catch the exception, free the lock and re-throw it.
-	 *
-	 */
-	public function testLockFileCopyException(): void {
-		$this->expectException(\Exception::class);
-
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods(['copy'])
-			->getMock();
-
-		$sourcePath = 'original.txt';
-		$targetPath = 'target.txt';
-
-		/* Disable encryption wrapper to avoid it intercepting mocked call */
-		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		$storage->mkdir('files');
-		$view->file_put_contents($sourcePath, 'meh');
-
-		$storage->expects($this->once())
-			->method('copy')
-			->willReturnCallback(
-				function (): void {
-					throw new \Exception();
-				}
-			);
-
-		$this->connectMockHooks('copy', $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
-		$this->connectMockHooks('copy', $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
-
-		try {
-			$view->copy($sourcePath, $targetPath);
-		} catch (\Exception $e) {
-			$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
-			$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
-			throw $e;
-		}
-	}
-
-	/**
-	 * Test rename operation: unlock first path when second path was locked
-	 */
-	public function testLockFileRenameUnlockOnException(): void {
-		self::loginAsUser('test');
-
-		$view = new View('/' . $this->user . '/files/');
-
-		$sourcePath = 'original.txt';
-		$targetPath = 'target.txt';
-		$view->file_put_contents($sourcePath, 'meh');
-
-		// simulate that the target path is already locked
-		$view->lockFile($targetPath, ILockingProvider::LOCK_EXCLUSIVE);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $this->getFileLockType($view, $targetPath), 'Target file is locked before operation');
-
-		$thrown = false;
-		try {
-			$view->rename($sourcePath, $targetPath);
-		} catch (LockedException $e) {
-			$thrown = true;
-		}
-
-		$this->assertTrue($thrown, 'LockedException thrown');
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $this->getFileLockType($view, $targetPath), 'Target file still locked after operation');
-
-		$view->unlockFile($targetPath, ILockingProvider::LOCK_EXCLUSIVE);
-	}
-
-	/**
-	 * Test rename operation: unlock first path when second path was locked
-	 */
-	public function testGetOwner(): void {
-		self::loginAsUser('test');
-
-		$view = new View('/test/files/');
-
-		$path = 'foo.txt';
-		$view->file_put_contents($path, 'meh');
-
-		$this->assertEquals('test', $view->getFileInfo($path)->getOwner()->getUID());
-
-		$folderInfo = $view->getDirectoryContent('');
-		$folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
-			return $info->getName() === 'foo.txt';
-		}));
-
-		$this->assertEquals('test', $folderInfo[0]->getOwner()->getUID());
-
-		$subStorage = new Temporary();
-		Filesystem::mount($subStorage, [], '/test/files/asd');
-
-		$folderInfo = $view->getDirectoryContent('');
-		$folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
-			return $info->getName() === 'asd';
-		}));
-
-		$this->assertEquals('test', $folderInfo[0]->getOwner()->getUID());
-	}
-
-	public static function lockFileRenameOrCopyCrossStorageDataProvider(): array {
-		return [
-			['rename', 'moveFromStorage', ILockingProvider::LOCK_EXCLUSIVE],
-			['copy', 'copyFromStorage', ILockingProvider::LOCK_SHARED],
-		];
-	}
-
-	/**
-	 * Test locks for rename or copy operation cross-storage
-	 *
-	 *
-	 * @param string $viewOperation operation to be done on the view
-	 * @param string $storageOperation operation to be mocked on the storage
-	 * @param int $expectedLockTypeSourceDuring expected lock type on source file during
-	 *                                          the operation
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('lockFileRenameOrCopyCrossStorageDataProvider')]
-	public function testLockFileRenameCrossStorage($viewOperation, $storageOperation, $expectedLockTypeSourceDuring): void {
-		$view = new View('/' . $this->user . '/files/');
-
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
-		$storage = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$storageOperation])
-			->getMock();
-		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage2 */
-		$storage2 = $this->getMockBuilder(Temporary::class)
-			->onlyMethods([$storageOperation, 'getMetaData', 'filemtime'])
-			->getMock();
-
-		$storage2->expects($this->any())
-			->method('getMetaData')
-			->willReturn([
-				'mtime' => 1885434487,
-				'etag' => '',
-				'mimetype' => 'text/plain',
-				'permissions' => Constants::PERMISSION_ALL,
-				'size' => 3
-			]);
-		$storage2->expects($this->any())
-			->method('filemtime')
-			->willReturn(123456789);
-
-		$sourcePath = 'original.txt';
-		$targetPath = 'substorage/target.txt';
-
-		/* Disable encryption wrapper to avoid it intercepting mocked call */
-		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
-
-		Filesystem::mount($storage, [], $this->user . '/');
-		Filesystem::mount($storage2, [], $this->user . '/files/substorage');
-		$storage->mkdir('files');
-		$view->file_put_contents($sourcePath, 'meh');
-		$storage2->getUpdater()->update('');
-
-		$storage->expects($this->never())
-			->method($storageOperation);
-		$storage2->expects($this->once())
-			->method($storageOperation)
-			->willReturnCallback(
-				function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
-					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
-					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
-
-					return true;
-				}
-			);
-
-		$this->connectMockHooks($viewOperation, $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
-		$this->connectMockHooks($viewOperation, $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
-
-		$view->$viewOperation($sourcePath, $targetPath);
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source file locked properly during pre-hook');
-		$this->assertEquals($expectedLockTypeSourceDuring, $lockTypeSourceDuring, 'Source file locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source file locked properly during post-hook');
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target file locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target file locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target file locked properly during post-hook');
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
-	}
-
-	/**
-	 * Test locks when moving a mount point
-	 */
-	public function testLockMoveMountPoint(): void {
-		self::loginAsUser('test');
-
-		[$mount] = $this->createTestMovableMountPoints([
-			$this->user . '/files/substorage',
-		]);
-
-		$view = new View('/' . $this->user . '/files/');
-		$view->mkdir('subdir');
-
-		$sourcePath = 'substorage';
-		$targetPath = 'subdir/substorage_moved';
-
-		$mount->expects($this->once())
-			->method('moveMount')
-			->willReturnCallback(
-				function ($target) use ($mount, $view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring, &$lockTypeSharedRootDuring) {
-					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath, true);
-					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath, true);
-
-					$lockTypeSharedRootDuring = $this->getFileLockType($view, $sourcePath, false);
-
-					$mount->setMountPoint($target);
-
-					return true;
-				}
-			);
-
-		$this->connectMockHooks('rename', $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost, true);
-		$this->connectMockHooks('rename', $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost, true);
-		// in pre-hook, mount point is still on $sourcePath
-		$this->connectMockHooks('rename', $view, $sourcePath, $lockTypeSharedRootPre, $dummy, false);
-		// in post-hook, mount point is now on $targetPath
-		$this->connectMockHooks('rename', $view, $targetPath, $dummy, $lockTypeSharedRootPost, false);
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath, false), 'Shared storage root not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $sourcePath, true), 'Source path not locked before operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath, true), 'Target path not locked before operation');
-
-		$view->rename($sourcePath, $targetPath);
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source path locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeSourceDuring, 'Source path locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source path locked properly during post-hook');
-
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target path locked properly during pre-hook');
-		$this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target path locked properly during operation');
-		$this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target path locked properly during post-hook');
-
-		$this->assertNull($lockTypeSharedRootPre, 'Shared storage root not locked during pre-hook');
-		$this->assertNull($lockTypeSharedRootDuring, 'Shared storage root not locked during move');
-		$this->assertNull($lockTypeSharedRootPost, 'Shared storage root not locked during post-hook');
-
-		$this->assertNull($this->getFileLockType($view, $sourcePath, false), 'Shared storage root not locked after operation');
-		$this->assertNull($this->getFileLockType($view, $sourcePath, true), 'Source path not locked after operation');
-		$this->assertNull($this->getFileLockType($view, $targetPath, true), 'Target path not locked after operation');
-	}
-
-	/**
-	 * Connect hook callbacks for hook type
-	 *
-	 * @param string $hookType hook type or null for none
-	 * @param View $view view to check the lock on
-	 * @param string $path path for which to check the lock
-	 * @param int $lockTypePre variable to receive lock type that was active in the pre-hook
-	 * @param int $lockTypePost variable to receive lock type that was active in the post-hook
-	 * @param bool $onMountPoint true to check the mount point instead of the
-	 *                           mounted storage
-	 */
-	private function connectMockHooks($hookType, $view, $path, &$lockTypePre, &$lockTypePost, $onMountPoint = false) {
-		if ($hookType === null) {
-			return;
-		}
-
-		$eventHandler = $this->getMockBuilder(TestEventHandler::class)
-			->onlyMethods(['preCallback', 'postCallback'])
-			->getMock();
-
-		$eventHandler->expects($this->any())
-			->method('preCallback')
-			->willReturnCallback(
-				function () use ($view, $path, $onMountPoint, &$lockTypePre): void {
-					$lockTypePre = $this->getFileLockType($view, $path, $onMountPoint);
-				}
-			);
-		$eventHandler->expects($this->any())
-			->method('postCallback')
-			->willReturnCallback(
-				function () use ($view, $path, $onMountPoint, &$lockTypePost): void {
-					$lockTypePost = $this->getFileLockType($view, $path, $onMountPoint);
-				}
-			);
-
-		if ($hookType !== '') {
-			Util::connectHook(
-				Filesystem::CLASSNAME,
-				$hookType,
-				$eventHandler,
-				'preCallback'
-			);
-			Util::connectHook(
-				Filesystem::CLASSNAME,
-				'post_' . $hookType,
-				$eventHandler,
-				'postCallback'
-			);
-		}
-	}
-
-	/**
-	 * Returns the file lock type
-	 *
-	 * @param View $view view
-	 * @param string $path path
-	 * @param bool $onMountPoint true to check the mount point instead of the
-	 *                           mounted storage
-	 *
-	 * @return int lock type or null if file was not locked
-	 */
-	private function getFileLockType(View $view, $path, $onMountPoint = false) {
-		if ($this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE, $onMountPoint)) {
-			return ILockingProvider::LOCK_EXCLUSIVE;
-		} elseif ($this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED, $onMountPoint)) {
-			return ILockingProvider::LOCK_SHARED;
-		}
-		return null;
-	}
-
-
-	public function testRemoveMoveableMountPoint(): void {
-		$mountPoint = '/' . $this->user . '/files/mount/';
-
-		// Mock the mount point
-		/** @var TestMoveableMountPoint|\PHPUnit\Framework\MockObject\MockObject $mount */
-		$mount = $this->createMock(TestMoveableMountPoint::class);
-		$mount->expects($this->once())
-			->method('getMountPoint')
-			->willReturn($mountPoint);
-		$mount->expects($this->once())
-			->method('removeMount')
-			->willReturn('foo');
-		$mount->expects($this->any())
-			->method('getInternalPath')
-			->willReturn('');
-
-		// Register mount
-		Filesystem::getMountManager()->addMount($mount);
-
-		// Listen for events
-		$eventHandler = $this->getMockBuilder(TestEventHandler::class)
-			->onlyMethods(['umount', 'post_umount'])
-			->getMock();
-		$eventHandler->expects($this->once())
-			->method('umount')
-			->with([Filesystem::signal_param_path => '/mount']);
-		$eventHandler->expects($this->once())
-			->method('post_umount')
-			->with([Filesystem::signal_param_path => '/mount']);
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			'umount',
-			$eventHandler,
-			'umount'
-		);
-		Util::connectHook(
-			Filesystem::CLASSNAME,
-			'post_umount',
-			$eventHandler,
-			'post_umount'
-		);
-
-		//Delete the mountpoint
-		$view = new View('/' . $this->user . '/files');
-		$this->assertEquals('foo', $view->rmdir('mount'));
-	}
-
-	public static function mimeFilterProvider(): array {
-		return [
-			[null, ['test1.txt', 'test2.txt', 'test3.md', 'test4.png']],
-			['text/plain', ['test1.txt', 'test2.txt']],
-			['text/markdown', ['test3.md']],
-			['text', ['test1.txt', 'test2.txt', 'test3.md']],
-		];
-	}
-
-	/**
-	 * @param string $filter
-	 * @param string[] $expected
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('mimeFilterProvider')]
-	public function testGetDirectoryContentMimeFilter($filter, $expected): void {
-		$storage1 = new Temporary();
-		$root = self::getUniqueID('/');
-		Filesystem::mount($storage1, [], $root . '/');
-		$view = new View($root);
-
-		$view->file_put_contents('test1.txt', 'asd');
-		$view->file_put_contents('test2.txt', 'asd');
-		$view->file_put_contents('test3.md', 'asd');
-		$view->file_put_contents('test4.png', '');
-
-		$content = $view->getDirectoryContent('', $filter);
-
-		$files = array_map(function (FileInfo $info) {
-			return $info->getName();
-		}, $content);
-		sort($files);
-
-		$this->assertEquals($expected, $files);
-	}
-
-	public function testFilePutContentsClearsChecksum(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->file_put_contents('foo.txt', 'bar');
-		Filesystem::mount($storage, [], '/test/');
-		$scanner->scan('');
-
-		$view = new View('/test/foo.txt');
-		$view->putFileInfo('.', ['checksum' => '42']);
-
-		$this->assertEquals('bar', $view->file_get_contents(''));
-		$fh = tmpfile();
-		fwrite($fh, 'fooo');
-		rewind($fh);
-		clearstatcache();
-		$view->file_put_contents('', $fh);
-		$this->assertEquals('fooo', $view->file_get_contents(''));
-		$data = $view->getFileInfo('.');
-		$this->assertEquals('', $data->getChecksum());
-	}
-
-	public function testDeleteGhostFile(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$cache = $storage->getCache();
-		$storage->file_put_contents('foo.txt', 'bar');
-		Filesystem::mount($storage, [], '/test/');
-		$scanner->scan('');
-
-		$storage->unlink('foo.txt');
-
-		$this->assertTrue($cache->inCache('foo.txt'));
-
-		$view = new View('/test');
-		$rootInfo = $view->getFileInfo('');
-		$this->assertEquals(3, $rootInfo->getSize());
-		$view->unlink('foo.txt');
-		$newInfo = $view->getFileInfo('');
-
-		$this->assertFalse($cache->inCache('foo.txt'));
-		$this->assertNotEquals($rootInfo->getEtag(), $newInfo->getEtag());
-		$this->assertEquals(0, $newInfo->getSize());
-	}
-
-	public function testDeleteGhostFolder(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$cache = $storage->getCache();
-		$storage->mkdir('foo');
-		$storage->file_put_contents('foo/foo.txt', 'bar');
-		Filesystem::mount($storage, [], '/test/');
-		$scanner->scan('');
-
-		$storage->rmdir('foo');
-
-		$this->assertTrue($cache->inCache('foo'));
-		$this->assertTrue($cache->inCache('foo/foo.txt'));
-
-		$view = new View('/test');
-		$rootInfo = $view->getFileInfo('');
-		$this->assertEquals(3, $rootInfo->getSize());
-		$view->rmdir('foo');
-		$newInfo = $view->getFileInfo('');
-
-		$this->assertFalse($cache->inCache('foo'));
-		$this->assertFalse($cache->inCache('foo/foo.txt'));
-		$this->assertNotEquals($rootInfo->getEtag(), $newInfo->getEtag());
-		$this->assertEquals(0, $newInfo->getSize());
-	}
-
-	public function testCreateParentDirectories(): void {
-		$view = $this->getMockBuilder(View::class)
-			->disableOriginalConstructor()
-			->onlyMethods([
-				'is_file',
-				'file_exists',
-				'mkdir',
-			])
-			->getMock();
-
-		$view->expects($this->exactly(3))
-			->method('is_file')
-			->willReturnMap([
-				['/new', false],
-				['/new/folder', false],
-				['/new/folder/structure', false],
-			]);
-		$view->expects($this->exactly(3))
-			->method('file_exists')
-			->willReturnMap([
-				['/new', true],
-				['/new/folder', false],
-				['/new/folder/structure', false],
-			]);
-
-		$calls = ['/new/folder', '/new/folder/structure'];
-		$view->expects($this->exactly(2))
-			->method('mkdir')
-			->willReturnCallback(function ($dir) use (&$calls): void {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, $dir);
-			});
-
-		$this->assertTrue(self::invokePrivate($view, 'createParentDirectories', ['/new/folder/structure']));
-	}
-
-	public function testCreateParentDirectoriesWithExistingFile(): void {
-		$view = $this->getMockBuilder(View::class)
-			->disableOriginalConstructor()
-			->onlyMethods([
-				'is_file',
-				'file_exists',
-				'mkdir',
-			])
-			->getMock();
-
-		$view
-			->expects($this->once())
-			->method('is_file')
-			->with('/file.txt')
-			->willReturn(true);
-		$this->assertFalse(self::invokePrivate($view, 'createParentDirectories', ['/file.txt/folder/structure']));
-	}
-
-	public function testCacheExtension(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->file_put_contents('foo.txt', 'bar');
-		$scanner->scan('');
-
-		Filesystem::mount($storage, [], '/test/');
-		$view = new View('/test');
-
-		$info = $view->getFileInfo('/foo.txt');
-		$this->assertEquals(0, $info->getUploadTime());
-		$this->assertEquals(0, $info->getCreationTime());
-
-		$view->putFileInfo('/foo.txt', ['upload_time' => 25]);
-
-		$info = $view->getFileInfo('/foo.txt');
-		$this->assertEquals(25, $info->getUploadTime());
-		$this->assertEquals(0, $info->getCreationTime());
-	}
-
-	public function testFopenGone(): void {
-		$storage = new Temporary([]);
-		$scanner = $storage->getScanner();
-		$storage->file_put_contents('foo.txt', 'bar');
-		$scanner->scan('');
-		$cache = $storage->getCache();
-
-		Filesystem::mount($storage, [], '/test/');
-		$view = new View('/test');
-
-		$storage->unlink('foo.txt');
-
-		$this->assertTrue($cache->inCache('foo.txt'));
-
-		$this->assertFalse($view->fopen('foo.txt', 'r'));
-
-		$this->assertFalse($cache->inCache('foo.txt'));
-	}
-
-	public function testMountpointParentsCreated(): void {
-		$storage1 = $this->getTestStorage();
-		Filesystem::mount($storage1, [], '/');
-
-		$storage2 = $this->getTestStorage();
-		Filesystem::mount($storage2, [], '/A/B/C');
-
-		$rootView = new View('');
-
-		$folderData = $rootView->getDirectoryContent('/');
-		$this->assertCount(4, $folderData);
-		$this->assertEquals('folder', $folderData[0]['name']);
-		$this->assertEquals('foo.png', $folderData[1]['name']);
-		$this->assertEquals('foo.txt', $folderData[2]['name']);
-		$this->assertEquals('A', $folderData[3]['name']);
-
-		$folderData = $rootView->getDirectoryContent('/A');
-		$this->assertCount(1, $folderData);
-		$this->assertEquals('B', $folderData[0]['name']);
-
-		$folderData = $rootView->getDirectoryContent('/A/B');
-		$this->assertCount(1, $folderData);
-		$this->assertEquals('C', $folderData[0]['name']);
-
-		$folderData = $rootView->getDirectoryContent('/A/B/C');
-		$this->assertCount(3, $folderData);
-		$this->assertEquals('folder', $folderData[0]['name']);
-		$this->assertEquals('foo.png', $folderData[1]['name']);
-		$this->assertEquals('foo.txt', $folderData[2]['name']);
-	}
-
-	public function testCopyPreservesContent() {
-		$viewUser1 = new View('/' . 'userId' . '/files');
-		$viewUser1->mkdir('');
-		$viewUser1->file_put_contents('foo.txt', 'foo');
-		$viewUser1->copy('foo.txt', 'bar.txt');
-		$this->assertEquals('foo', $viewUser1->file_get_contents('bar.txt'));
-	}
+        $folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
+        $tmpdirLength = strlen(Server::get(ITempManager::class)->getTemporaryFolder());
+        $depth = ((4000 - $tmpdirLength) / 57);
+
+        foreach (range(0, $depth - 1) as $i) {
+            $longPath .= $ds . $folderName;
+            $result = $rootView->mkdir($longPath);
+            $this->assertTrue($result, "mkdir failed on $i - path length: " . strlen($longPath));
+
+            $result = $rootView->file_put_contents($longPath . "{$ds}test.txt", 'lorem');
+            $this->assertEquals(5, $result, "file_put_contents failed on $i");
+
+            $this->assertTrue($rootView->file_exists($longPath));
+            $this->assertTrue($rootView->file_exists($longPath . "{$ds}test.txt"));
+        }
+
+        $cache = $storage->getCache();
+        $scanner = $storage->getScanner();
+        $scanner->scan('');
+
+        $longPath = $folderName;
+        foreach (range(0, $depth - 1) as $i) {
+            $cachedFolder = $cache->get($longPath);
+            $this->assertTrue(is_array($cachedFolder), "No cache entry for folder at $i");
+            $this->assertEquals($folderName, $cachedFolder['name'], "Wrong cache entry for folder at $i");
+
+            $cachedFile = $cache->get($longPath . '/test.txt');
+            $this->assertTrue(is_array($cachedFile), "No cache entry for file at $i");
+            $this->assertEquals('test.txt', $cachedFile['name'], "Wrong cache entry for file at $i");
+
+            $longPath .= $ds . $folderName;
+        }
+    }
+
+    public function testTouchNotSupported(): void {
+        $storage = new TemporaryNoTouch([]);
+        $scanner = $storage->getScanner();
+        Filesystem::mount($storage, [], '/test/');
+        $past = time() - 100;
+        $storage->file_put_contents('test', 'foobar');
+        $scanner->scan('');
+        $view = new View('');
+        $info = $view->getFileInfo('/test/test');
+
+        $view->touch('/test/test', $past);
+        $scanner->scanFile('test', Scanner::REUSE_ETAG);
+
+        $info2 = $view->getFileInfo('/test/test');
+        $this->assertSame($info['etag'], $info2['etag']);
+    }
+
+    public function testWatcherEtagCrossStorage(): void {
+        $storage1 = new Temporary([]);
+        $storage2 = new Temporary([]);
+        $scanner1 = $storage1->getScanner();
+        $scanner2 = $storage2->getScanner();
+        $storage1->mkdir('sub');
+        Filesystem::mount($storage1, [], '/test/');
+        Filesystem::mount($storage2, [], '/test/sub/storage');
+
+        $past = time() - 100;
+        $storage2->file_put_contents('test.txt', 'foobar');
+        $scanner1->scan('');
+        $scanner2->scan('');
+        $view = new View('');
+
+        $storage2->getWatcher('')->setPolicy(Watcher::CHECK_ALWAYS);
+
+        $oldFileInfo = $view->getFileInfo('/test/sub/storage/test.txt');
+        $oldFolderInfo = $view->getFileInfo('/test');
+
+        $storage2->getCache()->update($oldFileInfo->getId(), [
+            'storage_mtime' => $past,
+        ]);
+
+        $oldEtag = $oldFolderInfo->getEtag();
+
+        $view->getFileInfo('/test/sub/storage/test.txt');
+        $newFolderInfo = $view->getFileInfo('/test');
+
+        $this->assertNotEquals($newFolderInfo->getEtag(), $oldEtag);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('absolutePathProvider')]
+    public function testGetAbsolutePath($expectedPath, $relativePath): void {
+        $view = new View('/files');
+        $this->assertEquals($expectedPath, $view->getAbsolutePath($relativePath));
+    }
+
+    public function testPartFileInfo(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        Filesystem::mount($storage, [], '/test/');
+        $sizeWritten = $storage->file_put_contents('test.part', 'foobar');
+        $scanner->scan('');
+        $view = new View('/test');
+        $info = $view->getFileInfo('test.part');
+
+        $this->assertInstanceOf('\OCP\Files\FileInfo', $info);
+        $this->assertNull($info->getId());
+        $this->assertEquals(6, $sizeWritten);
+        $this->assertEquals(6, $info->getSize());
+        $this->assertEquals('foobar', $view->file_get_contents('test.part'));
+    }
+
+    public static function absolutePathProvider(): array {
+        return [
+            ['/files', ''],
+            ['/files/0', '0'],
+            ['/files/false', 'false'],
+            ['/files/true', 'true'],
+            ['/files', '/'],
+            ['/files/test', 'test'],
+            ['/files/test', '/test'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('chrootRelativePathProvider')]
+    public function testChrootGetRelativePath($root, $absolutePath, $expectedPath): void {
+        $view = new View('/files');
+        $view->chroot($root);
+        $this->assertEquals($expectedPath, $view->getRelativePath($absolutePath));
+    }
+
+    public static function chrootRelativePathProvider(): array {
+        return self::relativePathProvider('/');
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('initRelativePathProvider')]
+    public function testInitGetRelativePath($root, $absolutePath, $expectedPath): void {
+        $view = new View($root);
+        $this->assertEquals($expectedPath, $view->getRelativePath($absolutePath));
+    }
+
+    public static function initRelativePathProvider(): array {
+        return self::relativePathProvider(null);
+    }
+
+    public static function relativePathProvider($missingRootExpectedPath): array {
+        return [
+            // No root - returns the path
+            ['', '/files', '/files'],
+            ['', '/files/', '/files/'],
+
+            // Root equals path - /
+            ['/files/', '/files/', '/'],
+            ['/files/', '/files', '/'],
+            ['/files', '/files/', '/'],
+            ['/files', '/files', '/'],
+
+            // False negatives: chroot fixes those by adding the leading slash.
+            // But setting them up with this root (instead of chroot($root))
+            // will fail them, although they should be the same.
+            // TODO init should be fixed, so it also adds the leading slash
+            ['files/', '/files/', $missingRootExpectedPath],
+            ['files', '/files/', $missingRootExpectedPath],
+            ['files/', '/files', $missingRootExpectedPath],
+            ['files', '/files', $missingRootExpectedPath],
+
+            // False negatives: Paths provided to the method should have a leading slash
+            // TODO input should be checked to have a leading slash
+            ['/files/', 'files/', null],
+            ['/files', 'files/', null],
+            ['/files/', 'files', null],
+            ['/files', 'files', null],
+
+            // with trailing slashes
+            ['/files/', '/files/0', '0'],
+            ['/files/', '/files/false', 'false'],
+            ['/files/', '/files/true', 'true'],
+            ['/files/', '/files/test', 'test'],
+            ['/files/', '/files/test/foo', 'test/foo'],
+
+            // without trailing slashes
+            // TODO false expectation: Should match "with trailing slashes"
+            ['/files', '/files/0', '/0'],
+            ['/files', '/files/false', '/false'],
+            ['/files', '/files/true', '/true'],
+            ['/files', '/files/test', '/test'],
+            ['/files', '/files/test/foo', '/test/foo'],
+
+            // leading slashes
+            ['/files/', '/files_trashbin/', null],
+            ['/files', '/files_trashbin/', null],
+            ['/files/', '/files_trashbin', null],
+            ['/files', '/files_trashbin', null],
+
+            // no leading slashes
+            ['files/', 'files_trashbin/', null],
+            ['files', 'files_trashbin/', null],
+            ['files/', 'files_trashbin', null],
+            ['files', 'files_trashbin', null],
+
+            // mixed leading slashes
+            ['files/', '/files_trashbin/', null],
+            ['/files/', 'files_trashbin/', null],
+            ['files', '/files_trashbin/', null],
+            ['/files', 'files_trashbin/', null],
+            ['files/', '/files_trashbin', null],
+            ['/files/', 'files_trashbin', null],
+            ['files', '/files_trashbin', null],
+            ['/files', 'files_trashbin', null],
+
+            ['files', 'files_trashbin/test', null],
+            ['/files', '/files_trashbin/test', null],
+            ['/files', 'files_trashbin/test', null],
+        ];
+    }
+
+    public function testFileView(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->file_put_contents('foo.txt', 'bar');
+        Filesystem::mount($storage, [], '/test/');
+        $scanner->scan('');
+        $view = new View('/test/foo.txt');
+
+        $this->assertEquals('bar', $view->file_get_contents(''));
+        $fh = tmpfile();
+        fwrite($fh, 'foo');
+        rewind($fh);
+        $view->file_put_contents('', $fh);
+        $this->assertEquals('foo', $view->file_get_contents(''));
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('tooLongPathDataProvider')]
+    public function testTooLongPath($operation, $param0 = null): void {
+        $this->expectException(InvalidPathException::class);
+
+
+        $longPath = '';
+        // 4000 is the maximum path length in file_cache.path
+        $folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
+        $depth = (4000 / 57);
+        foreach (range(0, $depth + 1) as $i) {
+            $longPath .= '/' . $folderName;
+        }
+
+        $storage = new Temporary([]);
+        $this->tempStorage = $storage; // for later hard cleanup
+        Filesystem::mount($storage, [], '/');
+
+        $rootView = new View('');
+
+        if ($param0 === '@0') {
+            $param0 = $longPath;
+        }
+
+        if ($operation === 'hash') {
+            $param0 = $longPath;
+            $longPath = 'md5';
+        }
+
+        call_user_func([$rootView, $operation], $longPath, $param0);
+    }
+
+    public static function tooLongPathDataProvider(): array {
+        return [
+            ['getAbsolutePath'],
+            ['getRelativePath'],
+            ['getMountPoint'],
+            ['resolvePath'],
+            ['getLocalFile'],
+            ['mkdir'],
+            ['rmdir'],
+            ['opendir'],
+            ['is_dir'],
+            ['is_file'],
+            ['stat'],
+            ['filetype'],
+            ['filesize'],
+            ['readfile'],
+            ['isCreatable'],
+            ['isReadable'],
+            ['isUpdatable'],
+            ['isDeletable'],
+            ['isSharable'],
+            ['file_exists'],
+            ['filemtime'],
+            ['touch'],
+            ['file_get_contents'],
+            ['unlink'],
+            ['deleteAll'],
+            ['toTmpFile'],
+            ['getMimeType'],
+            ['free_space'],
+            ['getFileInfo'],
+            ['getDirectoryContent'],
+            ['getOwner'],
+            ['getETag'],
+            ['file_put_contents', 'ipsum'],
+            ['rename', '@0'],
+            ['copy', '@0'],
+            ['fopen', 'r'],
+            ['fromTmpFile', '@0'],
+            ['hash'],
+            ['hasUpdated', 0],
+            ['putFileInfo', []],
+        ];
+    }
+
+    public function testRenameCrossStoragePreserveMtime(): void {
+        $storage1 = new Temporary([]);
+        $storage2 = new Temporary([]);
+        $storage1->mkdir('sub');
+        $storage1->mkdir('foo');
+        $storage1->file_put_contents('foo.txt', 'asd');
+        $storage1->file_put_contents('foo/bar.txt', 'asd');
+        Filesystem::mount($storage1, [], '/test/');
+        Filesystem::mount($storage2, [], '/test/sub/storage');
+
+        $view = new View('');
+        $time = time() - 200;
+        $view->touch('/test/foo.txt', $time);
+        $view->touch('/test/foo', $time);
+        $view->touch('/test/foo/bar.txt', $time);
+
+        $view->rename('/test/foo.txt', '/test/sub/storage/foo.txt');
+
+        $this->assertEquals($time, $view->filemtime('/test/sub/storage/foo.txt'));
+
+        $view->rename('/test/foo', '/test/sub/storage/foo');
+
+        $this->assertEquals($time, $view->filemtime('/test/sub/storage/foo/bar.txt'));
+    }
+
+    public function testRenameFailDeleteTargetKeepSource(): void {
+        $this->doTestCopyRenameFail('rename');
+    }
+
+    public function testCopyFailDeleteTargetKeepSource(): void {
+        $this->doTestCopyRenameFail('copy');
+    }
+
+    private function doTestCopyRenameFail($operation) {
+        $storage1 = new Temporary([]);
+        /** @var \PHPUnit\Framework\MockObject\MockObject|Temporary $storage2 */
+        $storage2 = $this->getMockBuilder(TemporaryNoCross::class)
+            ->setConstructorArgs([[]])
+            ->onlyMethods(['fopen', 'writeStream'])
+            ->getMock();
+
+        $storage2->method('writeStream')
+            ->willThrowException(new GenericFileException('Failed to copy stream'));
+
+        $storage2->method('fopen')
+            ->willReturn(false);
+
+        $storage1->mkdir('sub');
+        $storage1->file_put_contents('foo.txt', '0123456789ABCDEFGH');
+        $storage1->mkdir('dirtomove');
+        $storage1->file_put_contents('dirtomove/indir1.txt', '0123456'); // fits
+        $storage1->file_put_contents('dirtomove/indir2.txt', '0123456789ABCDEFGH'); // doesn't fit
+        $storage2->file_put_contents('existing.txt', '0123');
+        $storage1->getScanner()->scan('');
+        $storage2->getScanner()->scan('');
+        Filesystem::mount($storage1, [], '/test/');
+        Filesystem::mount($storage2, [], '/test/sub/storage');
+
+        // move file
+        $view = new View('');
+        $this->assertTrue($storage1->file_exists('foo.txt'));
+        $this->assertFalse($storage2->file_exists('foo.txt'));
+        $this->assertFalse($view->$operation('/test/foo.txt', '/test/sub/storage/foo.txt'));
+        $this->assertFalse($storage2->file_exists('foo.txt'));
+        $this->assertFalse($storage2->getCache()->get('foo.txt'));
+        $this->assertTrue($storage1->file_exists('foo.txt'));
+
+        // if target exists, it will be deleted too
+        $this->assertFalse($view->$operation('/test/foo.txt', '/test/sub/storage/existing.txt'));
+        $this->assertFalse($storage2->file_exists('existing.txt'));
+        $this->assertFalse($storage2->getCache()->get('existing.txt'));
+        $this->assertTrue($storage1->file_exists('foo.txt'));
+
+        // move folder
+        $this->assertFalse($view->$operation('/test/dirtomove/', '/test/sub/storage/dirtomove/'));
+        // since the move failed, the full source tree is kept
+        $this->assertTrue($storage1->file_exists('dirtomove/indir1.txt'));
+        $this->assertTrue($storage1->file_exists('dirtomove/indir2.txt'));
+        // second file not moved/copied
+        $this->assertFalse($storage2->file_exists('dirtomove/indir2.txt'));
+        $this->assertFalse($storage2->getCache()->get('dirtomove/indir2.txt'));
+    }
+
+    public function testDeleteFailKeepCache(): void {
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->setConstructorArgs([[]])
+            ->onlyMethods(['unlink'])
+            ->getMock();
+        $storage->expects($this->once())
+            ->method('unlink')
+            ->willReturn(false);
+        $scanner = $storage->getScanner();
+        $cache = $storage->getCache();
+        $storage->file_put_contents('foo.txt', 'asd');
+        $scanner->scan('');
+        Filesystem::mount($storage, [], '/test/');
+
+        $view = new View('/test');
+
+        $this->assertFalse($view->unlink('foo.txt'));
+        $this->assertTrue($cache->inCache('foo.txt'));
+    }
+
+    public static function directoryTraversalProvider(): array {
+        return [
+            ['../test/'],
+            ['..\\test\\my/../folder'],
+            ['/test/my/../foo\\'],
+        ];
+    }
+
+    /**
+     * @param string $root
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('directoryTraversalProvider')]
+    public function testConstructDirectoryTraversalException($root): void {
+        $this->expectException(\Exception::class);
+
+        new View($root);
+    }
+
+    public function testRenameOverWrite(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->mkdir('sub');
+        $storage->mkdir('foo');
+        $storage->file_put_contents('foo.txt', 'asd');
+        $storage->file_put_contents('foo/bar.txt', 'asd');
+        $scanner->scan('');
+        Filesystem::mount($storage, [], '/test/');
+        $view = new View('');
+        $this->assertTrue($view->rename('/test/foo.txt', '/test/foo/bar.txt'));
+    }
+
+    public function testSetMountOptionsInStorage(): void {
+        $mount = new MountPoint(Temporary::class, '/asd/', [[]], Filesystem::getLoader(), ['foo' => 'bar']);
+        Filesystem::getMountManager()->addMount($mount);
+        /** @var Common $storage */
+        $storage = $mount->getStorage();
+        $this->assertEquals($storage->getMountOption('foo'), 'bar');
+    }
+
+    public function testSetMountOptionsWatcherPolicy(): void {
+        $mount = new MountPoint(Temporary::class, '/asd/', [[]], Filesystem::getLoader(), ['filesystem_check_changes' => Watcher::CHECK_NEVER]);
+        Filesystem::getMountManager()->addMount($mount);
+        /** @var Common $storage */
+        $storage = $mount->getStorage();
+        $watcher = $storage->getWatcher();
+        $this->assertEquals(Watcher::CHECK_NEVER, $watcher->getPolicy());
+    }
+
+    public function testGetAbsolutePathOnNull(): void {
+        $view = new View();
+        $this->assertNull($view->getAbsolutePath(null));
+    }
+
+    public function testGetRelativePathOnNull(): void {
+        $view = new View();
+        $this->assertNull($view->getRelativePath(null));
+    }
+
+
+    public function testNullAsRoot(): void {
+        $this->expectException(\TypeError::class);
+
+        new View(null);
+    }
+
+    /**
+     * e.g. reading from a folder that's being renamed
+     *
+     *
+     *
+     * @param string $rootPath
+     * @param string $pathPrefix
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataLockPaths')]
+    public function testReadFromWriteLockedPath($rootPath, $pathPrefix): void {
+        $this->expectException(LockedException::class);
+
+        $rootPath = str_replace('{folder}', 'files', $rootPath);
+        $pathPrefix = str_replace('{folder}', 'files', $pathPrefix);
+
+        $view = new View($rootPath);
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+        $view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED);
+    }
+
+    /**
+     * Reading from a files_encryption folder that's being renamed
+     *
+     *
+     * @param string $rootPath
+     * @param string $pathPrefix
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataLockPaths')]
+    public function testReadFromWriteUnlockablePath($rootPath, $pathPrefix): void {
+        $rootPath = str_replace('{folder}', 'files_encryption', $rootPath);
+        $pathPrefix = str_replace('{folder}', 'files_encryption', $pathPrefix);
+
+        $view = new View($rootPath);
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+        $this->assertFalse($view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED));
+    }
+
+    /**
+     * e.g. writing a file that's being downloaded
+     *
+     *
+     *
+     * @param string $rootPath
+     * @param string $pathPrefix
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataLockPaths')]
+    public function testWriteToReadLockedFile($rootPath, $pathPrefix): void {
+        $this->expectException(LockedException::class);
+
+        $rootPath = str_replace('{folder}', 'files', $rootPath);
+        $pathPrefix = str_replace('{folder}', 'files', $pathPrefix);
+
+        $view = new View($rootPath);
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
+        $view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE);
+    }
+
+    /**
+     * Writing a file that's being downloaded
+     *
+     *
+     * @param string $rootPath
+     * @param string $pathPrefix
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('dataLockPaths')]
+    public function testWriteToReadUnlockableFile($rootPath, $pathPrefix): void {
+        $rootPath = str_replace('{folder}', 'files_encryption', $rootPath);
+        $pathPrefix = str_replace('{folder}', 'files_encryption', $pathPrefix);
+
+        $view = new View($rootPath);
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
+        $this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+    }
+
+    /**
+     * Test that locks are on mount point paths instead of mount root
+     */
+    public function testLockLocalMountPointPathInsteadOfStorageRoot(): void {
+        $lockingProvider = Server::get(ILockingProvider::class);
+        $view = new View('/testuser/files/');
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $mountedStorage = new Temporary([]);
+        Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint');
+
+        $this->assertTrue(
+            $view->lockFile('/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, true),
+            'Can lock mount point'
+        );
+
+        // no exception here because storage root was not locked
+        $mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+
+        $thrown = false;
+        try {
+            $storage->acquireLock('/testuser/files/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+        } catch (LockedException $e) {
+            $thrown = true;
+        }
+        $this->assertTrue($thrown, 'Mount point path was locked on root storage');
+
+        $lockingProvider->releaseAll();
+    }
+
+    /**
+     * Test that locks are on mount point paths and also mount root when requested
+     */
+    public function testLockStorageRootButNotLocalMountPoint(): void {
+        $lockingProvider = Server::get(ILockingProvider::class);
+        $view = new View('/testuser/files/');
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $mountedStorage = new Temporary([]);
+        Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint');
+
+        $this->assertTrue(
+            $view->lockFile('/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, false),
+            'Can lock mount point'
+        );
+
+        $thrown = false;
+        try {
+            $mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+        } catch (LockedException $e) {
+            $thrown = true;
+        }
+        $this->assertTrue($thrown, 'Mount point storage root was locked on original storage');
+
+        // local mount point was not locked
+        $storage->acquireLock('/testuser/files/mountpoint', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+
+        $lockingProvider->releaseAll();
+    }
+
+    /**
+     * Test that locks are on mount point paths and also mount root when requested
+     */
+    public function testLockMountPointPathFailReleasesBoth(): void {
+        $lockingProvider = Server::get(ILockingProvider::class);
+        $view = new View('/testuser/files/');
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+        $mountedStorage = new Temporary([]);
+        Filesystem::mount($mountedStorage, [], '/testuser/files/mountpoint.txt');
+
+        // this would happen if someone is writing on the mount point
+        $mountedStorage->acquireLock('', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+
+        $thrown = false;
+        try {
+            // this actually acquires two locks, one on the mount point and one on the storage root,
+            // but the one on the storage root will fail
+            $view->lockFile('/mountpoint.txt', ILockingProvider::LOCK_SHARED);
+        } catch (LockedException $e) {
+            $thrown = true;
+        }
+        $this->assertTrue($thrown, 'Cannot acquire shared lock because storage root is already locked');
+
+        // from here we expect that the lock on the local mount point was released properly
+        // so acquiring an exclusive lock will succeed
+        $storage->acquireLock('/testuser/files/mountpoint.txt', ILockingProvider::LOCK_EXCLUSIVE, $lockingProvider);
+
+        $lockingProvider->releaseAll();
+    }
+
+    public static function dataLockPaths(): array {
+        return [
+            ['/testuser/{folder}', ''],
+            ['/testuser', '/{folder}'],
+            ['', '/testuser/{folder}'],
+        ];
+    }
+
+    public static function pathRelativeToFilesProvider(): array {
+        return [
+            ['admin/files', ''],
+            ['admin/files/x', 'x'],
+            ['/admin/files', ''],
+            ['/admin/files/sub', 'sub'],
+            ['/admin/files/sub/', 'sub'],
+            ['/admin/files/sub/sub2', 'sub/sub2'],
+            ['//admin//files/sub//sub2', 'sub/sub2'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('pathRelativeToFilesProvider')]
+    public function testGetPathRelativeToFiles($path, $expectedPath): void {
+        $view = new View();
+        $this->assertEquals($expectedPath, $view->getPathRelativeToFiles($path));
+    }
+
+    public static function pathRelativeToFilesProviderExceptionCases(): array {
+        return [
+            [''],
+            ['x'],
+            ['files'],
+            ['/files'],
+            ['/admin/files_versions/abc'],
+        ];
+    }
+
+    /**
+     * @param string $path
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('pathRelativeToFilesProviderExceptionCases')]
+    public function testGetPathRelativeToFilesWithInvalidArgument($path): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('$absolutePath must be relative to "files"');
+
+        $view = new View();
+        $view->getPathRelativeToFiles($path);
+    }
+
+    public function testChangeLock(): void {
+        $view = new View('/testuser/files/');
+        $storage = new Temporary([]);
+        Filesystem::mount($storage, [], '/');
+
+        $view->lockFile('/test/sub', ILockingProvider::LOCK_SHARED);
+        $this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
+        $this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
+
+        $view->changeLock('//test/sub', ILockingProvider::LOCK_EXCLUSIVE);
+        $this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
+
+        $view->changeLock('test/sub', ILockingProvider::LOCK_SHARED);
+        $this->assertTrue($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
+
+        $view->unlockFile('/test/sub/', ILockingProvider::LOCK_SHARED);
+
+        $this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_SHARED));
+        $this->assertFalse($this->isFileLocked($view, '/test//sub', ILockingProvider::LOCK_EXCLUSIVE));
+    }
+
+    public static function hookPathProvider(): array {
+        return [
+            ['/foo/files', '/foo', true],
+            ['/foo/files/bar', '/foo', true],
+            ['/foo', '/foo', false],
+            ['/foo', '/files/foo', true],
+            ['/foo', 'filesfoo', false],
+            ['', '/foo/files', true],
+            ['', '/foo/files/bar.txt', true],
+        ];
+    }
+
+    /**
+     * @param $root
+     * @param $path
+     * @param $shouldEmit
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('hookPathProvider')]
+    public function testHookPaths($root, $path, $shouldEmit): void {
+        $filesystemReflection = new \ReflectionClass(Filesystem::class);
+        $defaultRootValue = $filesystemReflection->getProperty('defaultInstance');
+        $defaultRootValue->setAccessible(true);
+        $oldRoot = $defaultRootValue->getValue();
+        $defaultView = new View('/foo/files');
+        $defaultRootValue->setValue(null, $defaultView);
+        $view = new View($root);
+        $result = self::invokePrivate($view, 'shouldEmitHooks', [$path]);
+        $defaultRootValue->setValue(null, $oldRoot);
+        $this->assertEquals($shouldEmit, $result);
+    }
+
+    /**
+     * Create test movable mount points
+     *
+     * @param array $mountPoints array of mount point locations
+     * @return array array of MountPoint objects
+     */
+    private function createTestMovableMountPoints($mountPoints) {
+        $mounts = [];
+        foreach ($mountPoints as $mountPoint) {
+            $storage = $this->getMockBuilder(Storage::class)
+                ->onlyMethods([])
+                ->getMock();
+            $storage->method('getId')->willReturn('non-null-id');
+            $storage->method('getStorageCache')->willReturnCallback(function () use ($storage) {
+                return new \OC\Files\Cache\Storage($storage, true, Server::get(IDBConnection::class));
+            });
+
+            $mounts[] = $this->getMockBuilder(TestMoveableMountPoint::class)
+                ->onlyMethods(['moveMount'])
+                ->setConstructorArgs([$storage, $mountPoint])
+                ->getMock();
+        }
+
+        /** @var IMountProvider|\PHPUnit\Framework\MockObject\MockObject $mountProvider */
+        $mountProvider = $this->createMock(IMountProvider::class);
+        $mountProvider->expects($this->any())
+            ->method('getMountsForUser')
+            ->willReturn($mounts);
+
+        $mountProviderCollection = Server::get(IMountProviderCollection::class);
+        $mountProviderCollection->registerProvider($mountProvider);
+
+        return $mounts;
+    }
+
+    /**
+     * Test mount point move
+     */
+    public function testMountPointMove(): void {
+        self::loginAsUser($this->user);
+
+        [$mount1, $mount2] = $this->createTestMovableMountPoints([
+            $this->user . '/files/mount1',
+            $this->user . '/files/mount2',
+        ]);
+        $mount1->expects($this->once())
+            ->method('moveMount')
+            ->willReturn(true);
+
+        $mount2->expects($this->once())
+            ->method('moveMount')
+            ->willReturn(true);
+
+        $view = new View('/' . $this->user . '/files/');
+        $view->mkdir('sub');
+
+        $this->assertTrue($view->rename('mount1', 'renamed_mount'), 'Can rename mount point');
+        $this->assertTrue($view->rename('mount2', 'sub/moved_mount'), 'Can move a mount point into a subdirectory');
+    }
+
+    public function testMoveMountPointOverwrite(): void {
+        self::loginAsUser($this->user);
+
+        [$mount1, $mount2] = $this->createTestMovableMountPoints([
+            $this->user . '/files/mount1',
+            $this->user . '/files/mount2',
+        ]);
+
+        $mount1->expects($this->never())
+            ->method('moveMount');
+
+        $mount2->expects($this->never())
+            ->method('moveMount');
+
+        $view = new View('/' . $this->user . '/files/');
+
+        $this->expectException(ForbiddenException::class);
+        $view->rename('mount1', 'mount2');
+    }
+
+    public function testMoveMountPointIntoMount(): void {
+        self::loginAsUser($this->user);
+
+        [$mount1, $mount2] = $this->createTestMovableMountPoints([
+            $this->user . '/files/mount1',
+            $this->user . '/files/mount2',
+        ]);
+
+        $mount1->expects($this->never())
+            ->method('moveMount');
+
+        $mount2->expects($this->never())
+            ->method('moveMount');
+
+        $view = new View('/' . $this->user . '/files/');
+
+        $this->expectException(ForbiddenException::class);
+        $view->rename('mount1', 'mount2/sub');
+    }
+
+    /**
+     * Test that moving a mount point into a shared folder is forbidden
+     */
+    public function testMoveMountPointIntoSharedFolder(): void {
+        self::loginAsUser($this->user);
+
+        [$mount1, $mount2] = $this->createTestMovableMountPoints([
+            $this->user . '/files/mount1',
+            $this->user . '/files/mount2',
+        ]);
+
+        $mount1->expects($this->never())
+            ->method('moveMount');
+
+        $mount2->expects($this->once())
+            ->method('moveMount')
+            ->willReturn(true);
+
+        $view = new View('/' . $this->user . '/files/');
+        $view->mkdir('shareddir');
+        $view->mkdir('shareddir/sub');
+        $view->mkdir('shareddir/sub2');
+        // Create a similar named but non-shared folder
+        $view->mkdir('shareddir notshared');
+
+        $fileId = $view->getFileInfo('shareddir')->getId();
+        $userObject = Server::get(IUserManager::class)->createUser('test2', 'IHateNonMockableStaticClasses');
+
+        $userFolder = \OC::$server->getUserFolder($this->user);
+        $shareDir = $userFolder->get('shareddir');
+        $shareManager = Server::get(IShareManager::class);
+        $share = $shareManager->newShare();
+        $share->setSharedWith('test2')
+            ->setSharedBy($this->user)
+            ->setShareType(IShare::TYPE_USER)
+            ->setPermissions(Constants::PERMISSION_READ)
+            ->setNode($shareDir);
+        $shareManager->createShare($share);
+
+        try {
+            $view->rename('mount1', 'shareddir');
+            $this->fail('Cannot overwrite shared folder');
+        } catch (ForbiddenException $e) {
+
+        }
+        try {
+            $view->rename('mount1', 'shareddir/sub');
+            $this->fail('Cannot move mount point into shared folder');
+        } catch (ForbiddenException $e) {
+
+        }
+        try {
+            $view->rename('mount1', 'shareddir/sub/sub2');
+            $this->fail('Cannot move mount point into shared subfolder');
+        } catch (ForbiddenException $e) {
+
+        }
+        $this->assertTrue($view->rename('mount2', 'shareddir notshared/sub'), 'Can move mount point into a similarly named but non-shared folder');
+
+        $shareManager->deleteShare($share);
+        $userObject->delete();
+    }
+
+    public static function basicOperationProviderForLocks(): array {
+        return [
+            // --- write hook ----
+            [
+                'touch',
+                ['touch-create.txt'],
+                'touch-create.txt',
+                'create',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+            ],
+            [
+                'fopen',
+                ['test-write.txt', 'w'],
+                'test-write.txt',
+                'write',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                null,
+                // exclusive lock stays until fclose
+                ILockingProvider::LOCK_EXCLUSIVE,
+            ],
+            [
+                'mkdir',
+                ['newdir'],
+                'newdir',
+                'write',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+            ],
+            [
+                'file_put_contents',
+                ['file_put_contents.txt', 'blah'],
+                'file_put_contents.txt',
+                'write',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                0,
+            ],
+
+            // ---- delete hook ----
+            [
+                'rmdir',
+                ['dir'],
+                'dir',
+                'delete',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+            ],
+            [
+                'unlink',
+                ['test.txt'],
+                'test.txt',
+                'delete',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_EXCLUSIVE,
+                ILockingProvider::LOCK_SHARED,
+            ],
+
+            // ---- read hook (no post hooks) ----
+            [
+                'file_get_contents',
+                ['test.txt'],
+                'test.txt',
+                'read',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                null,
+                false,
+            ],
+            [
+                'fopen',
+                ['test.txt', 'r'],
+                'test.txt',
+                'read',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+            ],
+            [
+                'opendir',
+                ['dir'],
+                'dir',
+                'read',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+            ],
+
+            // ---- no lock, touch hook ---
+            ['touch', ['test.txt'], 'test.txt', 'touch', null, null, null],
+
+            // ---- no hooks, no locks ---
+            ['is_dir', ['dir'], 'dir', ''],
+            ['is_file', ['dir'], 'dir', ''],
+            [
+                'stat',
+                ['dir'],
+                'dir',
+                '',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                false,
+            ],
+            [
+                'filetype',
+                ['dir'],
+                'dir',
+                '',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                false,
+            ],
+            [
+                'filesize',
+                ['dir'],
+                'dir',
+                '',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                /* Return an int */
+                100
+            ],
+            ['isCreatable', ['dir'], 'dir', ''],
+            ['isReadable', ['dir'], 'dir', ''],
+            ['isUpdatable', ['dir'], 'dir', ''],
+            ['isDeletable', ['dir'], 'dir', ''],
+            ['isSharable', ['dir'], 'dir', ''],
+            ['file_exists', ['dir'], 'dir', ''],
+            [
+                'filemtime',
+                ['dir'],
+                'dir',
+                '',
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                ILockingProvider::LOCK_SHARED,
+                null,
+                false,
+            ],
+        ];
+    }
+
+    /**
+     * Test whether locks are set before and after the operation
+     *
+     *
+     * @param string $operation operation name on the view
+     * @param array $operationArgs arguments for the operation
+     * @param string $lockedPath path of the locked item to check
+     * @param string $hookType hook type
+     * @param ?int $expectedLockBefore expected lock during pre hooks
+     * @param ?int $expectedLockDuring expected lock during operation
+     * @param ?int $expectedLockAfter expected lock during post hooks
+     * @param ?int $expectedStrayLock expected lock after returning, should
+     *                                be null (unlock) for most operations
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('basicOperationProviderForLocks')]
+    public function testLockBasicOperation(
+        string $operation,
+        array $operationArgs,
+        string $lockedPath,
+        string $hookType,
+        ?int $expectedLockBefore = ILockingProvider::LOCK_SHARED,
+        ?int $expectedLockDuring = ILockingProvider::LOCK_SHARED,
+        ?int $expectedLockAfter = ILockingProvider::LOCK_SHARED,
+        ?int $expectedStrayLock = null,
+        mixed $returnValue = true,
+    ): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary&MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$operation])
+            ->getMock();
+
+        /* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
+        Server::get(ITrashManager::class)->pauseTrash();
+        /* Same thing with encryption wrapper */
+        Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
+
+        Filesystem::mount($storage, [], $this->user . '/');
+
+        // work directly on disk because mkdir might be mocked
+        $realPath = $storage->getSourcePath('');
+        mkdir($realPath . '/files');
+        mkdir($realPath . '/files/dir');
+        file_put_contents($realPath . '/files/test.txt', 'blah');
+        $storage->getScanner()->scan('files');
+
+        $storage->expects($this->once())
+            ->method($operation)
+            ->willReturnCallback(
+                function () use ($view, $lockedPath, &$lockTypeDuring, $returnValue) {
+                    $lockTypeDuring = $this->getFileLockType($view, $lockedPath);
+
+                    return $returnValue;
+                }
+            );
+
+        $this->assertNull($this->getFileLockType($view, $lockedPath), 'File not locked before operation');
+
+        $this->connectMockHooks($hookType, $view, $lockedPath, $lockTypePre, $lockTypePost);
+
+        // do operation
+        call_user_func_array([$view, $operation], $operationArgs);
+
+        if ($hookType !== '') {
+            $this->assertEquals($expectedLockBefore, $lockTypePre, 'File locked properly during pre-hook');
+            $this->assertEquals($expectedLockAfter, $lockTypePost, 'File locked properly during post-hook');
+            $this->assertEquals($expectedLockDuring, $lockTypeDuring, 'File locked properly during operation');
+        } else {
+            $this->assertNull($lockTypeDuring, 'File not locked during operation');
+        }
+
+        $this->assertEquals($expectedStrayLock, $this->getFileLockType($view, $lockedPath));
+
+        /* Resume trash to avoid side effects */
+        Server::get(ITrashManager::class)->resumeTrash();
+    }
+
+    /**
+     * Test locks for file_put_content with stream.
+     * This code path uses $storage->fopen instead
+     */
+    public function testLockFilePutContentWithStream(): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        $path = 'test_file_put_contents.txt';
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods(['fopen'])
+            ->getMock();
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+
+        $storage->expects($this->once())
+            ->method('fopen')
+            ->willReturnCallback(
+                function () use ($view, $path, &$lockTypeDuring) {
+                    $lockTypeDuring = $this->getFileLockType($view, $path);
+
+                    return fopen('php://temp', 'r+');
+                }
+            );
+
+        $this->connectMockHooks('write', $view, $path, $lockTypePre, $lockTypePost);
+
+        $this->assertNull($this->getFileLockType($view, $path), 'File not locked before operation');
+
+        // do operation
+        $view->file_put_contents($path, fopen('php://temp', 'r+'));
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePre, 'File locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePost, 'File locked properly during post-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File locked properly during operation');
+
+        $this->assertNull($this->getFileLockType($view, $path));
+    }
+
+    /**
+     * Test locks for fopen with fclose at the end
+     */
+    public function testLockFopen(): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        $path = 'test_file_put_contents.txt';
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods(['fopen'])
+            ->getMock();
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+
+        $storage->expects($this->once())
+            ->method('fopen')
+            ->willReturnCallback(
+                function () use ($view, $path, &$lockTypeDuring) {
+                    $lockTypeDuring = $this->getFileLockType($view, $path);
+
+                    return fopen('php://temp', 'r+');
+                }
+            );
+
+        $this->connectMockHooks('write', $view, $path, $lockTypePre, $lockTypePost);
+
+        $this->assertNull($this->getFileLockType($view, $path), 'File not locked before operation');
+
+        // do operation
+        $res = $view->fopen($path, 'w');
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypePre, 'File locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File locked properly during operation');
+        $this->assertNull($lockTypePost, 'No post hook, no lock check possible');
+
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeDuring, 'File still locked after fopen');
+
+        fclose($res);
+
+        $this->assertNull($this->getFileLockType($view, $path), 'File unlocked after fclose');
+    }
+
+    /**
+     * Test locks for fopen with fclose at the end
+     *
+     *
+     * @param string $operation operation name on the view
+     * @param array $operationArgs arguments for the operation
+     * @param string $path path of the locked item to check
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('basicOperationProviderForLocks')]
+    public function testLockBasicOperationUnlocksAfterException(
+        $operation,
+        $operationArgs,
+        $path,
+    ): void {
+        if ($operation === 'touch') {
+            $this->markTestSkipped('touch handles storage exceptions internally');
+        }
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$operation])
+            ->getMock();
+
+        /* Pause trash to avoid the trashbin intercepting rmdir and unlink calls */
+        Server::get(ITrashManager::class)->pauseTrash();
+        /* Same thing with encryption wrapper */
+        Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
+
+        Filesystem::mount($storage, [], $this->user . '/');
+
+        // work directly on disk because mkdir might be mocked
+        $realPath = $storage->getSourcePath('');
+        mkdir($realPath . '/files');
+        mkdir($realPath . '/files/dir');
+        file_put_contents($realPath . '/files/test.txt', 'blah');
+        $storage->getScanner()->scan('files');
+
+        $storage->expects($this->once())
+            ->method($operation)
+            ->willReturnCallback(
+                function (): void {
+                    throw new \Exception('Simulated exception');
+                }
+            );
+
+        $thrown = false;
+        try {
+            call_user_func_array([$view, $operation], $operationArgs);
+        } catch (\Exception $e) {
+            $thrown = true;
+            $this->assertEquals('Simulated exception', $e->getMessage());
+        }
+        $this->assertTrue($thrown, 'Exception was rethrown');
+        $this->assertNull($this->getFileLockType($view, $path), 'File got unlocked after exception');
+
+        /* Resume trash to avoid side effects */
+        Server::get(ITrashManager::class)->resumeTrash();
+    }
+
+    public function testLockBasicOperationUnlocksAfterLockException(): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        $storage = new Temporary([]);
+
+        Filesystem::mount($storage, [], $this->user . '/');
+
+        $storage->mkdir('files');
+        $storage->mkdir('files/dir');
+        $storage->file_put_contents('files/test.txt', 'blah');
+        $storage->getScanner()->scan('files');
+
+        // get a shared lock
+        $handle = $view->fopen('test.txt', 'r');
+
+        $thrown = false;
+        try {
+            // try (and fail) to get a write lock
+            $view->unlink('test.txt');
+        } catch (\Exception $e) {
+            $thrown = true;
+            $this->assertInstanceOf(LockedException::class, $e);
+        }
+        $this->assertTrue($thrown, 'Exception was rethrown');
+
+        // clean shared lock
+        fclose($handle);
+
+        $this->assertNull($this->getFileLockType($view, 'test.txt'), 'File got unlocked');
+    }
+
+    /**
+     * Test locks for fopen with fclose at the end
+     *
+     *
+     * @param string $operation operation name on the view
+     * @param array $operationArgs arguments for the operation
+     * @param string $path path of the locked item to check
+     * @param string $hookType hook type
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('basicOperationProviderForLocks')]
+    public function testLockBasicOperationUnlocksAfterCancelledHook(
+        $operation,
+        $operationArgs,
+        $path,
+        $hookType,
+    ): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$operation])
+            ->getMock();
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            $hookType,
+            HookHelper::class,
+            'cancellingCallback'
+        );
+
+        call_user_func_array([$view, $operation], $operationArgs);
+
+        $this->assertNull($this->getFileLockType($view, $path), 'File got unlocked after exception');
+    }
+
+    public static function lockFileRenameOrCopyDataProvider(): array {
+        return [
+            ['rename', ILockingProvider::LOCK_EXCLUSIVE],
+            ['copy', ILockingProvider::LOCK_SHARED],
+        ];
+    }
+
+    /**
+     * Test locks for rename or copy operation
+     *
+     *
+     * @param string $operation operation to be done on the view
+     * @param int $expectedLockTypeSourceDuring expected lock type on source file during
+     *                                          the operation
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('lockFileRenameOrCopyDataProvider')]
+    public function testLockFileRename($operation, $expectedLockTypeSourceDuring): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$operation, 'getMetaData', 'filemtime'])
+            ->getMock();
+
+        $storage->expects($this->any())
+            ->method('getMetaData')
+            ->willReturn([
+                'mtime' => 1885434487,
+                'etag' => '',
+                'mimetype' => 'text/plain',
+                'permissions' => Constants::PERMISSION_ALL,
+                'size' => 3
+            ]);
+        $storage->expects($this->any())
+            ->method('filemtime')
+            ->willReturn(123456789);
+
+        $sourcePath = 'original.txt';
+        $targetPath = 'target.txt';
+
+        /* Disable encryption wrapper to avoid it intercepting mocked call */
+        Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+        $view->file_put_contents($sourcePath, 'meh');
+
+        $storage->expects($this->once())
+            ->method($operation)
+            ->willReturnCallback(
+                function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
+                    $lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
+                    $lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
+
+                    return true;
+                }
+            );
+
+        $this->connectMockHooks($operation, $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
+        $this->connectMockHooks($operation, $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
+
+        $view->$operation($sourcePath, $targetPath);
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source file locked properly during pre-hook');
+        $this->assertEquals($expectedLockTypeSourceDuring, $lockTypeSourceDuring, 'Source file locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source file locked properly during post-hook');
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target file locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target file locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target file locked properly during post-hook');
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
+    }
+
+    /**
+     * simulate a failed copy operation.
+     * We expect that we catch the exception, free the lock and re-throw it.
+     *
+     */
+    public function testLockFileCopyException(): void {
+        $this->expectException(\Exception::class);
+
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods(['copy'])
+            ->getMock();
+
+        $sourcePath = 'original.txt';
+        $targetPath = 'target.txt';
+
+        /* Disable encryption wrapper to avoid it intercepting mocked call */
+        Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        $storage->mkdir('files');
+        $view->file_put_contents($sourcePath, 'meh');
+
+        $storage->expects($this->once())
+            ->method('copy')
+            ->willReturnCallback(
+                function (): void {
+                    throw new \Exception();
+                }
+            );
+
+        $this->connectMockHooks('copy', $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
+        $this->connectMockHooks('copy', $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
+
+        try {
+            $view->copy($sourcePath, $targetPath);
+        } catch (\Exception $e) {
+            $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
+            $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
+            throw $e;
+        }
+    }
+
+    /**
+     * Test rename operation: unlock first path when second path was locked
+     */
+    public function testLockFileRenameUnlockOnException(): void {
+        self::loginAsUser('test');
+
+        $view = new View('/' . $this->user . '/files/');
+
+        $sourcePath = 'original.txt';
+        $targetPath = 'target.txt';
+        $view->file_put_contents($sourcePath, 'meh');
+
+        // simulate that the target path is already locked
+        $view->lockFile($targetPath, ILockingProvider::LOCK_EXCLUSIVE);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $this->getFileLockType($view, $targetPath), 'Target file is locked before operation');
+
+        $thrown = false;
+        try {
+            $view->rename($sourcePath, $targetPath);
+        } catch (LockedException $e) {
+            $thrown = true;
+        }
+
+        $this->assertTrue($thrown, 'LockedException thrown');
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $this->getFileLockType($view, $targetPath), 'Target file still locked after operation');
+
+        $view->unlockFile($targetPath, ILockingProvider::LOCK_EXCLUSIVE);
+    }
+
+    /**
+     * Test rename operation: unlock first path when second path was locked
+     */
+    public function testGetOwner(): void {
+        self::loginAsUser('test');
+
+        $view = new View('/test/files/');
+
+        $path = 'foo.txt';
+        $view->file_put_contents($path, 'meh');
+
+        $this->assertEquals('test', $view->getFileInfo($path)->getOwner()->getUID());
+
+        $folderInfo = $view->getDirectoryContent('');
+        $folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
+            return $info->getName() === 'foo.txt';
+        }));
+
+        $this->assertEquals('test', $folderInfo[0]->getOwner()->getUID());
+
+        $subStorage = new Temporary();
+        Filesystem::mount($subStorage, [], '/test/files/asd');
+
+        $folderInfo = $view->getDirectoryContent('');
+        $folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
+            return $info->getName() === 'asd';
+        }));
+
+        $this->assertEquals('test', $folderInfo[0]->getOwner()->getUID());
+    }
+
+    public static function lockFileRenameOrCopyCrossStorageDataProvider(): array {
+        return [
+            ['rename', 'moveFromStorage', ILockingProvider::LOCK_EXCLUSIVE],
+            ['copy', 'copyFromStorage', ILockingProvider::LOCK_SHARED],
+        ];
+    }
+
+    /**
+     * Test locks for rename or copy operation cross-storage
+     *
+     *
+     * @param string $viewOperation operation to be done on the view
+     * @param string $storageOperation operation to be mocked on the storage
+     * @param int $expectedLockTypeSourceDuring expected lock type on source file during
+     *                                          the operation
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('lockFileRenameOrCopyCrossStorageDataProvider')]
+    public function testLockFileRenameCrossStorage($viewOperation, $storageOperation, $expectedLockTypeSourceDuring): void {
+        $view = new View('/' . $this->user . '/files/');
+
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
+        $storage = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$storageOperation])
+            ->getMock();
+        /** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage2 */
+        $storage2 = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods([$storageOperation, 'getMetaData', 'filemtime'])
+            ->getMock();
+
+        $storage2->expects($this->any())
+            ->method('getMetaData')
+            ->willReturn([
+                'mtime' => 1885434487,
+                'etag' => '',
+                'mimetype' => 'text/plain',
+                'permissions' => Constants::PERMISSION_ALL,
+                'size' => 3
+            ]);
+        $storage2->expects($this->any())
+            ->method('filemtime')
+            ->willReturn(123456789);
+
+        $sourcePath = 'original.txt';
+        $targetPath = 'substorage/target.txt';
+
+        /* Disable encryption wrapper to avoid it intercepting mocked call */
+        Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
+
+        Filesystem::mount($storage, [], $this->user . '/');
+        Filesystem::mount($storage2, [], $this->user . '/files/substorage');
+        $storage->mkdir('files');
+        $view->file_put_contents($sourcePath, 'meh');
+        $storage2->getUpdater()->update('');
+
+        $storage->expects($this->never())
+            ->method($storageOperation);
+        $storage2->expects($this->once())
+            ->method($storageOperation)
+            ->willReturnCallback(
+                function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
+                    $lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
+                    $lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
+
+                    return true;
+                }
+            );
+
+        $this->connectMockHooks($viewOperation, $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost);
+        $this->connectMockHooks($viewOperation, $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked before operation');
+
+        $view->$viewOperation($sourcePath, $targetPath);
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source file locked properly during pre-hook');
+        $this->assertEquals($expectedLockTypeSourceDuring, $lockTypeSourceDuring, 'Source file locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source file locked properly during post-hook');
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target file locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target file locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target file locked properly during post-hook');
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath), 'Source file not locked after operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath), 'Target file not locked after operation');
+    }
+
+    /**
+     * Test locks when moving a mount point
+     */
+    public function testLockMoveMountPoint(): void {
+        self::loginAsUser('test');
+
+        [$mount] = $this->createTestMovableMountPoints([
+            $this->user . '/files/substorage',
+        ]);
+
+        $view = new View('/' . $this->user . '/files/');
+        $view->mkdir('subdir');
+
+        $sourcePath = 'substorage';
+        $targetPath = 'subdir/substorage_moved';
+
+        $mount->expects($this->once())
+            ->method('moveMount')
+            ->willReturnCallback(
+                function ($target) use ($mount, $view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring, &$lockTypeSharedRootDuring) {
+                    $lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath, true);
+                    $lockTypeTargetDuring = $this->getFileLockType($view, $targetPath, true);
+
+                    $lockTypeSharedRootDuring = $this->getFileLockType($view, $sourcePath, false);
+
+                    $mount->setMountPoint($target);
+
+                    return true;
+                }
+            );
+
+        $this->connectMockHooks('rename', $view, $sourcePath, $lockTypeSourcePre, $lockTypeSourcePost, true);
+        $this->connectMockHooks('rename', $view, $targetPath, $lockTypeTargetPre, $lockTypeTargetPost, true);
+        // in pre-hook, mount point is still on $sourcePath
+        $this->connectMockHooks('rename', $view, $sourcePath, $lockTypeSharedRootPre, $dummy, false);
+        // in post-hook, mount point is now on $targetPath
+        $this->connectMockHooks('rename', $view, $targetPath, $dummy, $lockTypeSharedRootPost, false);
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath, false), 'Shared storage root not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $sourcePath, true), 'Source path not locked before operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath, true), 'Target path not locked before operation');
+
+        $view->rename($sourcePath, $targetPath);
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePre, 'Source path locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeSourceDuring, 'Source path locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeSourcePost, 'Source path locked properly during post-hook');
+
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPre, 'Target path locked properly during pre-hook');
+        $this->assertEquals(ILockingProvider::LOCK_EXCLUSIVE, $lockTypeTargetDuring, 'Target path locked properly during operation');
+        $this->assertEquals(ILockingProvider::LOCK_SHARED, $lockTypeTargetPost, 'Target path locked properly during post-hook');
+
+        $this->assertNull($lockTypeSharedRootPre, 'Shared storage root not locked during pre-hook');
+        $this->assertNull($lockTypeSharedRootDuring, 'Shared storage root not locked during move');
+        $this->assertNull($lockTypeSharedRootPost, 'Shared storage root not locked during post-hook');
+
+        $this->assertNull($this->getFileLockType($view, $sourcePath, false), 'Shared storage root not locked after operation');
+        $this->assertNull($this->getFileLockType($view, $sourcePath, true), 'Source path not locked after operation');
+        $this->assertNull($this->getFileLockType($view, $targetPath, true), 'Target path not locked after operation');
+    }
+
+    /**
+     * Connect hook callbacks for hook type
+     *
+     * @param string $hookType hook type or null for none
+     * @param View $view view to check the lock on
+     * @param string $path path for which to check the lock
+     * @param int $lockTypePre variable to receive lock type that was active in the pre-hook
+     * @param int $lockTypePost variable to receive lock type that was active in the post-hook
+     * @param bool $onMountPoint true to check the mount point instead of the
+     *                           mounted storage
+     */
+    private function connectMockHooks($hookType, $view, $path, &$lockTypePre, &$lockTypePost, $onMountPoint = false) {
+        if ($hookType === null) {
+            return;
+        }
+
+        $eventHandler = $this->getMockBuilder(TestEventHandler::class)
+            ->onlyMethods(['preCallback', 'postCallback'])
+            ->getMock();
+
+        $eventHandler->expects($this->any())
+            ->method('preCallback')
+            ->willReturnCallback(
+                function () use ($view, $path, $onMountPoint, &$lockTypePre): void {
+                    $lockTypePre = $this->getFileLockType($view, $path, $onMountPoint);
+                }
+            );
+        $eventHandler->expects($this->any())
+            ->method('postCallback')
+            ->willReturnCallback(
+                function () use ($view, $path, $onMountPoint, &$lockTypePost): void {
+                    $lockTypePost = $this->getFileLockType($view, $path, $onMountPoint);
+                }
+            );
+
+        if ($hookType !== '') {
+            Util::connectHook(
+                Filesystem::CLASSNAME,
+                $hookType,
+                $eventHandler,
+                'preCallback'
+            );
+            Util::connectHook(
+                Filesystem::CLASSNAME,
+                'post_' . $hookType,
+                $eventHandler,
+                'postCallback'
+            );
+        }
+    }
+
+    /**
+     * Returns the file lock type
+     *
+     * @param View $view view
+     * @param string $path path
+     * @param bool $onMountPoint true to check the mount point instead of the
+     *                           mounted storage
+     *
+     * @return int lock type or null if file was not locked
+     */
+    private function getFileLockType(View $view, $path, $onMountPoint = false) {
+        if ($this->isFileLocked($view, $path, ILockingProvider::LOCK_EXCLUSIVE, $onMountPoint)) {
+            return ILockingProvider::LOCK_EXCLUSIVE;
+        } elseif ($this->isFileLocked($view, $path, ILockingProvider::LOCK_SHARED, $onMountPoint)) {
+            return ILockingProvider::LOCK_SHARED;
+        }
+        return null;
+    }
+
+
+    public function testRemoveMoveableMountPoint(): void {
+        $mountPoint = '/' . $this->user . '/files/mount/';
+
+        // Mock the mount point
+        /** @var TestMoveableMountPoint|\PHPUnit\Framework\MockObject\MockObject $mount */
+        $mount = $this->createMock(TestMoveableMountPoint::class);
+        $mount->expects($this->once())
+            ->method('getMountPoint')
+            ->willReturn($mountPoint);
+        $mount->expects($this->once())
+            ->method('removeMount')
+            ->willReturn('foo');
+        $mount->expects($this->any())
+            ->method('getInternalPath')
+            ->willReturn('');
+
+        // Register mount
+        Filesystem::getMountManager()->addMount($mount);
+
+        // Listen for events
+        $eventHandler = $this->getMockBuilder(TestEventHandler::class)
+            ->onlyMethods(['umount', 'post_umount'])
+            ->getMock();
+        $eventHandler->expects($this->once())
+            ->method('umount')
+            ->with([Filesystem::signal_param_path => '/mount']);
+        $eventHandler->expects($this->once())
+            ->method('post_umount')
+            ->with([Filesystem::signal_param_path => '/mount']);
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            'umount',
+            $eventHandler,
+            'umount'
+        );
+        Util::connectHook(
+            Filesystem::CLASSNAME,
+            'post_umount',
+            $eventHandler,
+            'post_umount'
+        );
+
+        //Delete the mountpoint
+        $view = new View('/' . $this->user . '/files');
+        $this->assertEquals('foo', $view->rmdir('mount'));
+    }
+
+    public static function mimeFilterProvider(): array {
+        return [
+            [null, ['test1.txt', 'test2.txt', 'test3.md', 'test4.png']],
+            ['text/plain', ['test1.txt', 'test2.txt']],
+            ['text/markdown', ['test3.md']],
+            ['text', ['test1.txt', 'test2.txt', 'test3.md']],
+        ];
+    }
+
+    /**
+     * @param string $filter
+     * @param string[] $expected
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('mimeFilterProvider')]
+    public function testGetDirectoryContentMimeFilter($filter, $expected): void {
+        $storage1 = new Temporary();
+        $root = self::getUniqueID('/');
+        Filesystem::mount($storage1, [], $root . '/');
+        $view = new View($root);
+
+        $view->file_put_contents('test1.txt', 'asd');
+        $view->file_put_contents('test2.txt', 'asd');
+        $view->file_put_contents('test3.md', 'asd');
+        $view->file_put_contents('test4.png', '');
+
+        $content = $view->getDirectoryContent('', $filter);
+
+        $files = array_map(function (FileInfo $info) {
+            return $info->getName();
+        }, $content);
+        sort($files);
+
+        $this->assertEquals($expected, $files);
+    }
+
+    public function testFilePutContentsClearsChecksum(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->file_put_contents('foo.txt', 'bar');
+        Filesystem::mount($storage, [], '/test/');
+        $scanner->scan('');
+
+        $view = new View('/test/foo.txt');
+        $view->putFileInfo('.', ['checksum' => '42']);
+
+        $this->assertEquals('bar', $view->file_get_contents(''));
+        $fh = tmpfile();
+        fwrite($fh, 'fooo');
+        rewind($fh);
+        clearstatcache();
+        $view->file_put_contents('', $fh);
+        $this->assertEquals('fooo', $view->file_get_contents(''));
+        $data = $view->getFileInfo('.');
+        $this->assertEquals('', $data->getChecksum());
+    }
+
+    public function testDeleteGhostFile(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $cache = $storage->getCache();
+        $storage->file_put_contents('foo.txt', 'bar');
+        Filesystem::mount($storage, [], '/test/');
+        $scanner->scan('');
+
+        $storage->unlink('foo.txt');
+
+        $this->assertTrue($cache->inCache('foo.txt'));
+
+        $view = new View('/test');
+        $rootInfo = $view->getFileInfo('');
+        $this->assertEquals(3, $rootInfo->getSize());
+        $view->unlink('foo.txt');
+        $newInfo = $view->getFileInfo('');
+
+        $this->assertFalse($cache->inCache('foo.txt'));
+        $this->assertNotEquals($rootInfo->getEtag(), $newInfo->getEtag());
+        $this->assertEquals(0, $newInfo->getSize());
+    }
+
+    public function testDeleteGhostFolder(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $cache = $storage->getCache();
+        $storage->mkdir('foo');
+        $storage->file_put_contents('foo/foo.txt', 'bar');
+        Filesystem::mount($storage, [], '/test/');
+        $scanner->scan('');
+
+        $storage->rmdir('foo');
+
+        $this->assertTrue($cache->inCache('foo'));
+        $this->assertTrue($cache->inCache('foo/foo.txt'));
+
+        $view = new View('/test');
+        $rootInfo = $view->getFileInfo('');
+        $this->assertEquals(3, $rootInfo->getSize());
+        $view->rmdir('foo');
+        $newInfo = $view->getFileInfo('');
+
+        $this->assertFalse($cache->inCache('foo'));
+        $this->assertFalse($cache->inCache('foo/foo.txt'));
+        $this->assertNotEquals($rootInfo->getEtag(), $newInfo->getEtag());
+        $this->assertEquals(0, $newInfo->getSize());
+    }
+
+    public function testCreateParentDirectories(): void {
+        $view = $this->getMockBuilder(View::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods([
+                'is_file',
+                'file_exists',
+                'mkdir',
+            ])
+            ->getMock();
+
+        $view->expects($this->exactly(3))
+            ->method('is_file')
+            ->willReturnMap([
+                ['/new', false],
+                ['/new/folder', false],
+                ['/new/folder/structure', false],
+            ]);
+        $view->expects($this->exactly(3))
+            ->method('file_exists')
+            ->willReturnMap([
+                ['/new', true],
+                ['/new/folder', false],
+                ['/new/folder/structure', false],
+            ]);
+
+        $calls = ['/new/folder', '/new/folder/structure'];
+        $view->expects($this->exactly(2))
+            ->method('mkdir')
+            ->willReturnCallback(function ($dir) use (&$calls): void {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, $dir);
+            });
+
+        $this->assertTrue(self::invokePrivate($view, 'createParentDirectories', ['/new/folder/structure']));
+    }
+
+    public function testCreateParentDirectoriesWithExistingFile(): void {
+        $view = $this->getMockBuilder(View::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods([
+                'is_file',
+                'file_exists',
+                'mkdir',
+            ])
+            ->getMock();
+
+        $view
+            ->expects($this->once())
+            ->method('is_file')
+            ->with('/file.txt')
+            ->willReturn(true);
+        $this->assertFalse(self::invokePrivate($view, 'createParentDirectories', ['/file.txt/folder/structure']));
+    }
+
+    public function testCacheExtension(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->file_put_contents('foo.txt', 'bar');
+        $scanner->scan('');
+
+        Filesystem::mount($storage, [], '/test/');
+        $view = new View('/test');
+
+        $info = $view->getFileInfo('/foo.txt');
+        $this->assertEquals(0, $info->getUploadTime());
+        $this->assertEquals(0, $info->getCreationTime());
+
+        $view->putFileInfo('/foo.txt', ['upload_time' => 25]);
+
+        $info = $view->getFileInfo('/foo.txt');
+        $this->assertEquals(25, $info->getUploadTime());
+        $this->assertEquals(0, $info->getCreationTime());
+    }
+
+    public function testFopenGone(): void {
+        $storage = new Temporary([]);
+        $scanner = $storage->getScanner();
+        $storage->file_put_contents('foo.txt', 'bar');
+        $scanner->scan('');
+        $cache = $storage->getCache();
+
+        Filesystem::mount($storage, [], '/test/');
+        $view = new View('/test');
+
+        $storage->unlink('foo.txt');
+
+        $this->assertTrue($cache->inCache('foo.txt'));
+
+        $this->assertFalse($view->fopen('foo.txt', 'r'));
+
+        $this->assertFalse($cache->inCache('foo.txt'));
+    }
+
+    public function testMountpointParentsCreated(): void {
+        $storage1 = $this->getTestStorage();
+        Filesystem::mount($storage1, [], '/');
+
+        $storage2 = $this->getTestStorage();
+        Filesystem::mount($storage2, [], '/A/B/C');
+
+        $rootView = new View('');
+
+        $folderData = $rootView->getDirectoryContent('/');
+        $this->assertCount(4, $folderData);
+        $this->assertEquals('folder', $folderData[0]['name']);
+        $this->assertEquals('foo.png', $folderData[1]['name']);
+        $this->assertEquals('foo.txt', $folderData[2]['name']);
+        $this->assertEquals('A', $folderData[3]['name']);
+
+        $folderData = $rootView->getDirectoryContent('/A');
+        $this->assertCount(1, $folderData);
+        $this->assertEquals('B', $folderData[0]['name']);
+
+        $folderData = $rootView->getDirectoryContent('/A/B');
+        $this->assertCount(1, $folderData);
+        $this->assertEquals('C', $folderData[0]['name']);
+
+        $folderData = $rootView->getDirectoryContent('/A/B/C');
+        $this->assertCount(3, $folderData);
+        $this->assertEquals('folder', $folderData[0]['name']);
+        $this->assertEquals('foo.png', $folderData[1]['name']);
+        $this->assertEquals('foo.txt', $folderData[2]['name']);
+    }
+
+    public function testCopyPreservesContent() {
+        $viewUser1 = new View('/' . 'userId' . '/files');
+        $viewUser1->mkdir('');
+        $viewUser1->file_put_contents('foo.txt', 'foo');
+        $viewUser1->copy('foo.txt', 'bar.txt');
+        $this->assertEquals('foo', $viewUser1->file_get_contents('bar.txt'));
+    }
 }

Spacing +90 added lines, -90 removed lines

@@ -155,7 +155,7 @@ 
 		}
 
 		if ($this->tempStorage) {
-			system('rm -rf ' . escapeshellarg($this->tempStorage->getDataDir()));
+			system('rm -rf '.escapeshellarg($this->tempStorage->getDataDir()));
 		}
 
 		self::logout();
@@ -178,11 +178,11 @@ 
 		$storage2 = $this->getTestStorage();
 		$storage3 = $this->getTestStorage();
 		$root = self::getUniqueID('/');
-		Filesystem::mount($storage1, [], $root . '/');
-		Filesystem::mount($storage2, [], $root . '/substorage');
-		Filesystem::mount($storage3, [], $root . '/folder/anotherstorage');
+		Filesystem::mount($storage1, [], $root.'/');
+		Filesystem::mount($storage2, [], $root.'/substorage');
+		Filesystem::mount($storage3, [], $root.'/folder/anotherstorage');
 		$textSize = strlen("dummy file data\n");
-		$imageSize = filesize(\OC::$SERVERROOT . '/core/img/logo/logo.png');
+		$imageSize = filesize(\OC::$SERVERROOT.'/core/img/logo/logo.png');
 		$storageSize = $textSize * 2 + $imageSize;
 
 		$storageInfo = $storage3->getCache()->get('');
@@ -239,7 +239,7 @@ 
 		$this->assertEquals('foo.png', $folderData[1]['name']);
 		$this->assertEquals('foo.txt', $folderData[2]['name']);
 
-		$folderView = new View($root . '/folder');
+		$folderView = new View($root.'/folder');
 		$this->assertEquals($rootView->getFileInfo('/folder'), $folderView->getFileInfo('/'));
 
 		$cachedData = $rootView->getFileInfo('/foo.txt');
@@ -504,10 +504,10 @@ 
 	}
 
 	public function moveBetweenStorages($storage1, $storage2) {
-		Filesystem::mount($storage1, [], '/' . $this->user . '/');
-		Filesystem::mount($storage2, [], '/' . $this->user . '/substorage');
+		Filesystem::mount($storage1, [], '/'.$this->user.'/');
+		Filesystem::mount($storage2, [], '/'.$this->user.'/substorage');
 
-		$rootView = new View('/' . $this->user);
+		$rootView = new View('/'.$this->user);
 		$rootView->rename('foo.txt', 'substorage/folder/foo.txt');
 		$this->assertFalse($rootView->file_exists('foo.txt'));
 		$this->assertTrue($rootView->file_exists('substorage/folder/foo.txt'));
@@ -614,11 +614,11 @@ 
 		$storage2 = $this->getTestStorage();
 		$defaultRoot = Filesystem::getRoot();
 		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot . '/substorage');
+		Filesystem::mount($storage2, [], $defaultRoot.'/substorage');
 		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
 
 		$rootView = new View('');
-		$subView = new View($defaultRoot . '/substorage');
+		$subView = new View($defaultRoot.'/substorage');
 		$this->hookPath = null;
 
 		$rootView->file_put_contents('/foo.txt', 'asd');
@@ -658,7 +658,7 @@ 
 		 */
 		$storage = new $class([]);
 		$textData = "dummy file data\n";
-		$imgData = file_get_contents(\OC::$SERVERROOT . '/core/img/logo/logo.png');
+		$imgData = file_get_contents(\OC::$SERVERROOT.'/core/img/logo/logo.png');
 		$storage->mkdir('folder');
 		$storage->file_put_contents('foo.txt', $textData);
 		$storage->file_put_contents('foo.png', $imgData);
@@ -677,10 +677,10 @@ 
 		$storage2 = $this->getTestStorage();
 		$defaultRoot = Filesystem::getRoot();
 		Filesystem::mount($storage1, [], '/');
-		Filesystem::mount($storage2, [], $defaultRoot . '_substorage');
+		Filesystem::mount($storage2, [], $defaultRoot.'_substorage');
 		\OC_Hook::connect('OC_Filesystem', 'post_write', $this, 'dummyHook');
 
-		$subView = new View($defaultRoot . '_substorage');
+		$subView = new View($defaultRoot.'_substorage');
 		$this->hookPath = null;
 
 		$subView->file_put_contents('/foo.txt', 'asd');
@@ -773,7 +773,7 @@ 
 
 		$rootView = new View('');
 		foreach ($names as $name) {
-			$rootView->file_put_contents('/' . $name, 'dummy content');
+			$rootView->file_put_contents('/'.$name, 'dummy content');
 		}
 
 		$list = $rootView->getDirectoryContent('/');
@@ -811,15 +811,15 @@ 
 		$depth = ((4000 - $tmpdirLength) / 57);
 
 		foreach (range(0, $depth - 1) as $i) {
-			$longPath .= $ds . $folderName;
+			$longPath .= $ds.$folderName;
 			$result = $rootView->mkdir($longPath);
-			$this->assertTrue($result, "mkdir failed on $i - path length: " . strlen($longPath));
+			$this->assertTrue($result, "mkdir failed on $i - path length: ".strlen($longPath));
 
-			$result = $rootView->file_put_contents($longPath . "{$ds}test.txt", 'lorem');
+			$result = $rootView->file_put_contents($longPath."{$ds}test.txt", 'lorem');
 			$this->assertEquals(5, $result, "file_put_contents failed on $i");
 
 			$this->assertTrue($rootView->file_exists($longPath));
-			$this->assertTrue($rootView->file_exists($longPath . "{$ds}test.txt"));
+			$this->assertTrue($rootView->file_exists($longPath."{$ds}test.txt"));
 		}
 
 		$cache = $storage->getCache();
@@ -832,11 +832,11 @@ 
 			$this->assertTrue(is_array($cachedFolder), "No cache entry for folder at $i");
 			$this->assertEquals($folderName, $cachedFolder['name'], "Wrong cache entry for folder at $i");
 
-			$cachedFile = $cache->get($longPath . '/test.txt');
+			$cachedFile = $cache->get($longPath.'/test.txt');
 			$this->assertTrue(is_array($cachedFile), "No cache entry for file at $i");
 			$this->assertEquals('test.txt', $cachedFile['name'], "Wrong cache entry for file at $i");
 
-			$longPath .= $ds . $folderName;
+			$longPath .= $ds.$folderName;
 		}
 	}
 
@@ -1041,7 +1041,7 @@ 
 		$folderName = 'abcdefghijklmnopqrstuvwxyz012345678901234567890123456789';
 		$depth = (4000 / 57);
 		foreach (range(0, $depth + 1) as $i) {
-			$longPath .= '/' . $folderName;
+			$longPath .= '/'.$folderName;
 		}
 
 		$storage = new Temporary([]);
@@ -1294,8 +1294,8 @@ 
 		$view = new View($rootPath);
 		$storage = new Temporary([]);
 		Filesystem::mount($storage, [], '/');
-		$this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-		$view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED);
+		$this->assertTrue($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+		$view->lockFile($pathPrefix.'/foo/bar/asd', ILockingProvider::LOCK_SHARED);
 	}
 
 	/**
@@ -1313,8 +1313,8 @@ 
 		$view = new View($rootPath);
 		$storage = new Temporary([]);
 		Filesystem::mount($storage, [], '/');
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar/asd', ILockingProvider::LOCK_SHARED));
+		$this->assertFalse($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+		$this->assertFalse($view->lockFile($pathPrefix.'/foo/bar/asd', ILockingProvider::LOCK_SHARED));
 	}
 
 	/**
@@ -1335,8 +1335,8 @@ 
 		$view = new View($rootPath);
 		$storage = new Temporary([]);
 		Filesystem::mount($storage, [], '/');
-		$this->assertTrue($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
-		$view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE);
+		$this->assertTrue($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_SHARED));
+		$view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_EXCLUSIVE);
 	}
 
 	/**
@@ -1354,8 +1354,8 @@ 
 		$view = new View($rootPath);
 		$storage = new Temporary([]);
 		Filesystem::mount($storage, [], '/');
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_SHARED));
-		$this->assertFalse($view->lockFile($pathPrefix . '/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
+		$this->assertFalse($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_SHARED));
+		$this->assertFalse($view->lockFile($pathPrefix.'/foo/bar', ILockingProvider::LOCK_EXCLUSIVE));
 	}
 
 	/**
@@ -1562,7 +1562,7 @@ 
 				->onlyMethods([])
 				->getMock();
 			$storage->method('getId')->willReturn('non-null-id');
-			$storage->method('getStorageCache')->willReturnCallback(function () use ($storage) {
+			$storage->method('getStorageCache')->willReturnCallback(function() use ($storage) {
 				return new \OC\Files\Cache\Storage($storage, true, Server::get(IDBConnection::class));
 			});
 
@@ -1591,8 +1591,8 @@ 
 		self::loginAsUser($this->user);
 
 		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
+			$this->user.'/files/mount1',
+			$this->user.'/files/mount2',
 		]);
 		$mount1->expects($this->once())
 			->method('moveMount')
@@ -1602,7 +1602,7 @@ 
 			->method('moveMount')
 			->willReturn(true);
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 		$view->mkdir('sub');
 
 		$this->assertTrue($view->rename('mount1', 'renamed_mount'), 'Can rename mount point');
@@ -1613,8 +1613,8 @@ 
 		self::loginAsUser($this->user);
 
 		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
+			$this->user.'/files/mount1',
+			$this->user.'/files/mount2',
 		]);
 
 		$mount1->expects($this->never())
@@ -1623,7 +1623,7 @@ 
 		$mount2->expects($this->never())
 			->method('moveMount');
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$this->expectException(ForbiddenException::class);
 		$view->rename('mount1', 'mount2');
@@ -1633,8 +1633,8 @@ 
 		self::loginAsUser($this->user);
 
 		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
+			$this->user.'/files/mount1',
+			$this->user.'/files/mount2',
 		]);
 
 		$mount1->expects($this->never())
@@ -1643,7 +1643,7 @@ 
 		$mount2->expects($this->never())
 			->method('moveMount');
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$this->expectException(ForbiddenException::class);
 		$view->rename('mount1', 'mount2/sub');
@@ -1656,8 +1656,8 @@ 
 		self::loginAsUser($this->user);
 
 		[$mount1, $mount2] = $this->createTestMovableMountPoints([
-			$this->user . '/files/mount1',
-			$this->user . '/files/mount2',
+			$this->user.'/files/mount1',
+			$this->user.'/files/mount2',
 		]);
 
 		$mount1->expects($this->never())
@@ -1667,7 +1667,7 @@ 
 			->method('moveMount')
 			->willReturn(true);
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 		$view->mkdir('shareddir');
 		$view->mkdir('shareddir/sub');
 		$view->mkdir('shareddir/sub2');
@@ -1893,7 +1893,7 @@ 
 		?int $expectedStrayLock = null,
 		mixed $returnValue = true,
 	): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary&MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -1905,19 +1905,19 @@ 
 		/* Same thing with encryption wrapper */
 		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 
 		// work directly on disk because mkdir might be mocked
 		$realPath = $storage->getSourcePath('');
-		mkdir($realPath . '/files');
-		mkdir($realPath . '/files/dir');
-		file_put_contents($realPath . '/files/test.txt', 'blah');
+		mkdir($realPath.'/files');
+		mkdir($realPath.'/files/dir');
+		file_put_contents($realPath.'/files/test.txt', 'blah');
 		$storage->getScanner()->scan('files');
 
 		$storage->expects($this->once())
 			->method($operation)
 			->willReturnCallback(
-				function () use ($view, $lockedPath, &$lockTypeDuring, $returnValue) {
+				function() use ($view, $lockedPath, &$lockTypeDuring, $returnValue) {
 					$lockTypeDuring = $this->getFileLockType($view, $lockedPath);
 
 					return $returnValue;
@@ -1950,7 +1950,7 @@ 
 	 * This code path uses $storage->fopen instead
 	 */
 	public function testLockFilePutContentWithStream(): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$path = 'test_file_put_contents.txt';
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
@@ -1958,13 +1958,13 @@ 
 			->onlyMethods(['fopen'])
 			->getMock();
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 
 		$storage->expects($this->once())
 			->method('fopen')
 			->willReturnCallback(
-				function () use ($view, $path, &$lockTypeDuring) {
+				function() use ($view, $path, &$lockTypeDuring) {
 					$lockTypeDuring = $this->getFileLockType($view, $path);
 
 					return fopen('php://temp', 'r+');
@@ -1989,7 +1989,7 @@ 
 	 * Test locks for fopen with fclose at the end
 	 */
 	public function testLockFopen(): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$path = 'test_file_put_contents.txt';
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
@@ -1997,13 +1997,13 @@ 
 			->onlyMethods(['fopen'])
 			->getMock();
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 
 		$storage->expects($this->once())
 			->method('fopen')
 			->willReturnCallback(
-				function () use ($view, $path, &$lockTypeDuring) {
+				function() use ($view, $path, &$lockTypeDuring) {
 					$lockTypeDuring = $this->getFileLockType($view, $path);
 
 					return fopen('php://temp', 'r+');
@@ -2045,7 +2045,7 @@ 
 		if ($operation === 'touch') {
 			$this->markTestSkipped('touch handles storage exceptions internally');
 		}
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -2057,19 +2057,19 @@ 
 		/* Same thing with encryption wrapper */
 		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 
 		// work directly on disk because mkdir might be mocked
 		$realPath = $storage->getSourcePath('');
-		mkdir($realPath . '/files');
-		mkdir($realPath . '/files/dir');
-		file_put_contents($realPath . '/files/test.txt', 'blah');
+		mkdir($realPath.'/files');
+		mkdir($realPath.'/files/dir');
+		file_put_contents($realPath.'/files/test.txt', 'blah');
 		$storage->getScanner()->scan('files');
 
 		$storage->expects($this->once())
 			->method($operation)
 			->willReturnCallback(
-				function (): void {
+				function(): void {
 					throw new \Exception('Simulated exception');
 				}
 			);
@@ -2089,11 +2089,11 @@ 
 	}
 
 	public function testLockBasicOperationUnlocksAfterLockException(): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$storage = new Temporary([]);
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 
 		$storage->mkdir('files');
 		$storage->mkdir('files/dir');
@@ -2135,14 +2135,14 @@ 
 		$path,
 		$hookType,
 	): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
 			->onlyMethods([$operation])
 			->getMock();
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 
 		Util::connectHook(
@@ -2174,7 +2174,7 @@ 
 	 */
 	#[\PHPUnit\Framework\Attributes\DataProvider('lockFileRenameOrCopyDataProvider')]
 	public function testLockFileRename($operation, $expectedLockTypeSourceDuring): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -2200,14 +2200,14 @@ 
 		/* Disable encryption wrapper to avoid it intercepting mocked call */
 		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 		$view->file_put_contents($sourcePath, 'meh');
 
 		$storage->expects($this->once())
 			->method($operation)
 			->willReturnCallback(
-				function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
+				function() use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
 					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
 					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
 
@@ -2243,7 +2243,7 @@ 
 	public function testLockFileCopyException(): void {
 		$this->expectException(\Exception::class);
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -2256,14 +2256,14 @@ 
 		/* Disable encryption wrapper to avoid it intercepting mocked call */
 		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
 
-		Filesystem::mount($storage, [], $this->user . '/');
+		Filesystem::mount($storage, [], $this->user.'/');
 		$storage->mkdir('files');
 		$view->file_put_contents($sourcePath, 'meh');
 
 		$storage->expects($this->once())
 			->method('copy')
 			->willReturnCallback(
-				function (): void {
+				function(): void {
 					throw new \Exception();
 				}
 			);
@@ -2289,7 +2289,7 @@ 
 	public function testLockFileRenameUnlockOnException(): void {
 		self::loginAsUser('test');
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		$sourcePath = 'original.txt';
 		$targetPath = 'target.txt';
@@ -2330,7 +2330,7 @@ 
 		$this->assertEquals('test', $view->getFileInfo($path)->getOwner()->getUID());
 
 		$folderInfo = $view->getDirectoryContent('');
-		$folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
+		$folderInfo = array_values(array_filter($folderInfo, function(FileInfo $info) {
 			return $info->getName() === 'foo.txt';
 		}));
 
@@ -2340,7 +2340,7 @@ 
 		Filesystem::mount($subStorage, [], '/test/files/asd');
 
 		$folderInfo = $view->getDirectoryContent('');
-		$folderInfo = array_values(array_filter($folderInfo, function (FileInfo $info) {
+		$folderInfo = array_values(array_filter($folderInfo, function(FileInfo $info) {
 			return $info->getName() === 'asd';
 		}));
 
@@ -2365,7 +2365,7 @@ 
 	 */
 	#[\PHPUnit\Framework\Attributes\DataProvider('lockFileRenameOrCopyCrossStorageDataProvider')]
 	public function testLockFileRenameCrossStorage($viewOperation, $storageOperation, $expectedLockTypeSourceDuring): void {
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 
 		/** @var Temporary|\PHPUnit\Framework\MockObject\MockObject $storage */
 		$storage = $this->getMockBuilder(Temporary::class)
@@ -2395,8 +2395,8 @@ 
 		/* Disable encryption wrapper to avoid it intercepting mocked call */
 		Server::get(IStorageFactory::class)->removeStorageWrapper('oc_encryption');
 
-		Filesystem::mount($storage, [], $this->user . '/');
-		Filesystem::mount($storage2, [], $this->user . '/files/substorage');
+		Filesystem::mount($storage, [], $this->user.'/');
+		Filesystem::mount($storage2, [], $this->user.'/files/substorage');
 		$storage->mkdir('files');
 		$view->file_put_contents($sourcePath, 'meh');
 		$storage2->getUpdater()->update('');
@@ -2406,7 +2406,7 @@ 
 		$storage2->expects($this->once())
 			->method($storageOperation)
 			->willReturnCallback(
-				function () use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
+				function() use ($view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring) {
 					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath);
 					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath);
 
@@ -2441,10 +2441,10 @@ 
 		self::loginAsUser('test');
 
 		[$mount] = $this->createTestMovableMountPoints([
-			$this->user . '/files/substorage',
+			$this->user.'/files/substorage',
 		]);
 
-		$view = new View('/' . $this->user . '/files/');
+		$view = new View('/'.$this->user.'/files/');
 		$view->mkdir('subdir');
 
 		$sourcePath = 'substorage';
@@ -2453,7 +2453,7 @@ 
 		$mount->expects($this->once())
 			->method('moveMount')
 			->willReturnCallback(
-				function ($target) use ($mount, $view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring, &$lockTypeSharedRootDuring) {
+				function($target) use ($mount, $view, $sourcePath, $targetPath, &$lockTypeSourceDuring, &$lockTypeTargetDuring, &$lockTypeSharedRootDuring) {
 					$lockTypeSourceDuring = $this->getFileLockType($view, $sourcePath, true);
 					$lockTypeTargetDuring = $this->getFileLockType($view, $targetPath, true);
 
@@ -2518,14 +2518,14 @@ 
 		$eventHandler->expects($this->any())
 			->method('preCallback')
 			->willReturnCallback(
-				function () use ($view, $path, $onMountPoint, &$lockTypePre): void {
+				function() use ($view, $path, $onMountPoint, &$lockTypePre): void {
 					$lockTypePre = $this->getFileLockType($view, $path, $onMountPoint);
 				}
 			);
 		$eventHandler->expects($this->any())
 			->method('postCallback')
 			->willReturnCallback(
-				function () use ($view, $path, $onMountPoint, &$lockTypePost): void {
+				function() use ($view, $path, $onMountPoint, &$lockTypePost): void {
 					$lockTypePost = $this->getFileLockType($view, $path, $onMountPoint);
 				}
 			);
@@ -2539,7 +2539,7 @@ 
 			);
 			Util::connectHook(
 				Filesystem::CLASSNAME,
-				'post_' . $hookType,
+				'post_'.$hookType,
 				$eventHandler,
 				'postCallback'
 			);
@@ -2567,7 +2567,7 @@ 
 
 
 	public function testRemoveMoveableMountPoint(): void {
-		$mountPoint = '/' . $this->user . '/files/mount/';
+		$mountPoint = '/'.$this->user.'/files/mount/';
 
 		// Mock the mount point
 		/** @var TestMoveableMountPoint|\PHPUnit\Framework\MockObject\MockObject $mount */
@@ -2609,7 +2609,7 @@ 
 		);
 
 		//Delete the mountpoint
-		$view = new View('/' . $this->user . '/files');
+		$view = new View('/'.$this->user.'/files');
 		$this->assertEquals('foo', $view->rmdir('mount'));
 	}
 
@@ -2630,7 +2630,7 @@ 
 	public function testGetDirectoryContentMimeFilter($filter, $expected): void {
 		$storage1 = new Temporary();
 		$root = self::getUniqueID('/');
-		Filesystem::mount($storage1, [], $root . '/');
+		Filesystem::mount($storage1, [], $root.'/');
 		$view = new View($root);
 
 		$view->file_put_contents('test1.txt', 'asd');
@@ -2640,7 +2640,7 @@ 
 
 		$content = $view->getDirectoryContent('', $filter);
 
-		$files = array_map(function (FileInfo $info) {
+		$files = array_map(function(FileInfo $info) {
 			return $info->getName();
 		}, $content);
 		sort($files);
@@ -2746,7 +2746,7 @@ 
 		$calls = ['/new/folder', '/new/folder/structure'];
 		$view->expects($this->exactly(2))
 			->method('mkdir')
-			->willReturnCallback(function ($dir) use (&$calls): void {
+			->willReturnCallback(function($dir) use (&$calls): void {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, $dir);
 			});
@@ -2843,7 +2843,7 @@ 
 	}
 
 	public function testCopyPreservesContent() {
-		$viewUser1 = new View('/' . 'userId' . '/files');
+		$viewUser1 = new View('/'.'userId'.'/files');
 		$viewUser1->mkdir('');
 		$viewUser1->file_put_contents('foo.txt', 'foo');
 		$viewUser1->copy('foo.txt', 'bar.txt');

tests/lib/HelperStorageTest.php

Indentation +226 added lines, -226 removed lines

@@ -22,230 +22,230 @@
  */
 #[\PHPUnit\Framework\Attributes\Group('DB')]
 class HelperStorageTest extends \Test\TestCase {
-	use UserTrait;
-
-	/** @var string */
-	private $user;
-	/** @var Storage */
-	private $storageMock;
-	/** @var Storage */
-	private $storage;
-	private bool $savedQuotaIncludeExternalStorage;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->user = $this->getUniqueID('user_');
-		$this->createUser($this->user, $this->user);
-		$this->savedQuotaIncludeExternalStorage = $this->getIncludeExternalStorage();
-
-		Filesystem::tearDown();
-		\OC_User::setUserId($this->user);
-		Filesystem::init($this->user, '/' . $this->user . '/files');
-
-		/** @var IMountManager $manager */
-		$manager = Server::get(IMountManager::class);
-		$manager->removeMount('/' . $this->user);
-
-		$this->storageMock = null;
-	}
-
-	protected function tearDown(): void {
-		$this->setIncludeExternalStorage($this->savedQuotaIncludeExternalStorage);
-		$this->user = null;
-
-		if ($this->storageMock) {
-			$this->storageMock->getCache()->clear();
-			$this->storageMock = null;
-		}
-		Filesystem::tearDown();
-
-		\OC_User::setUserId('');
-		Server::get(IConfig::class)->deleteAllUserValues($this->user);
-
-		parent::tearDown();
-	}
-
-	/**
-	 * Returns a storage mock that returns the given value as
-	 * free space
-	 *
-	 * @param int $freeSpace free space value
-	 * @return Storage
-	 */
-	private function getStorageMock($freeSpace = 12) {
-		$this->storageMock = $this->getMockBuilder(Temporary::class)
-			->onlyMethods(['free_space'])
-			->setConstructorArgs([[]])
-			->getMock();
-
-		$this->storageMock->expects($this->once())
-			->method('free_space')
-			->willReturn($freeSpace);
-		return $this->storageMock;
-	}
-
-	/**
-	 * Test getting the storage info
-	 */
-	public function testGetStorageInfo(): void {
-		$homeStorage = $this->getStorageMock(12);
-		Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
-		$homeStorage->file_put_contents('test.txt', '01234');
-
-		$storageInfo = \OC_Helper::getStorageInfo('');
-		$this->assertEquals(12, $storageInfo['free']);
-		$this->assertEquals(5, $storageInfo['used']);
-		$this->assertEquals(17, $storageInfo['total']);
-	}
-
-	private function getIncludeExternalStorage(): bool {
-		$class = new \ReflectionClass(\OC_Helper::class);
-		$prop = $class->getProperty('quotaIncludeExternalStorage');
-		return $prop->getValue(null) ?? false;
-	}
-
-	private function setIncludeExternalStorage(bool $include) {
-		$class = new \ReflectionClass(\OC_Helper::class);
-		$prop = $class->getProperty('quotaIncludeExternalStorage');
-		$prop->setValue(null, $include);
-	}
-
-	/**
-	 * Test getting the storage info, ignoring extra mount points
-	 */
-	public function testGetStorageInfoExcludingExtStorage(): void {
-		$homeStorage = $this->getStorageMock(12);
-		Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
-		$homeStorage->file_put_contents('test.txt', '01234');
-
-		$extStorage = new Temporary([]);
-		$extStorage->file_put_contents('extfile.txt', 'abcdefghijklmnopq');
-		$extStorage->getScanner()->scan(''); // update root size
-
-		$this->setIncludeExternalStorage(false);
-
-		Filesystem::mount($extStorage, [], '/' . $this->user . '/files/ext');
-
-		$storageInfo = \OC_Helper::getStorageInfo('');
-		$this->assertEquals(12, $storageInfo['free']);
-		$this->assertEquals(5, $storageInfo['used']);
-		$this->assertEquals(17, $storageInfo['total']);
-	}
-
-	/**
-	 * Test getting the storage info, including extra mount points
-	 */
-	public function testGetStorageInfoIncludingExtStorage(): void {
-		$homeStorage = new Temporary([]);
-		Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
-		$homeStorage->file_put_contents('test.txt', '01234');
-
-		$extStorage = new Temporary([]);
-		$extStorage->file_put_contents('extfile.txt', 'abcdefghijklmnopq');
-		$extStorage->getScanner()->scan(''); // update root size
-
-		Filesystem::mount($extStorage, [], '/' . $this->user . '/files/ext');
-
-		$this->setIncludeExternalStorage(true);
-
-		$config = Server::get(IConfig::class);
-		$config->setUserValue($this->user, 'files', 'quota', '25');
-
-		$storageInfo = \OC_Helper::getStorageInfo('');
-		$this->assertEquals(3, $storageInfo['free']);
-		$this->assertEquals(22, $storageInfo['used']);
-		$this->assertEquals(25, $storageInfo['total']);
-
-		$config->setUserValue($this->user, 'files', 'quota', 'default');
-	}
-
-	/**
-	 * Test getting the storage info excluding extra mount points
-	 * when user has no quota set, even when quota ext storage option
-	 * was set
-	 */
-	public function testGetStorageInfoIncludingExtStorageWithNoUserQuota(): void {
-		$homeStorage = $this->getStorageMock(12);
-		Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
-		$homeStorage->file_put_contents('test.txt', '01234');
-
-		$extStorage = new Temporary([]);
-		$extStorage->file_put_contents('extfile.txt', 'abcdefghijklmnopq');
-		$extStorage->getScanner()->scan(''); // update root size
-
-		Filesystem::mount($extStorage, [], '/' . $this->user . '/files/ext');
-
-		$config = Server::get(IConfig::class);
-		$this->setIncludeExternalStorage(true);
-
-		$storageInfo = \OC_Helper::getStorageInfo('');
-		$this->assertEquals(12, $storageInfo['free'], '12 bytes free in home storage');
-		$this->assertEquals(22, $storageInfo['used'], '5 bytes of home storage and 17 bytes of the temporary storage are used');
-		$this->assertEquals(34, $storageInfo['total'], '5 bytes used and 12 bytes free in home storage as well as 17 bytes used in temporary storage');
-	}
-
-
-	/**
-	 * Test getting the storage info with quota enabled
-	 */
-	public function testGetStorageInfoWithQuota(): void {
-		$homeStorage = $this->getStorageMock(12);
-		$homeStorage->file_put_contents('test.txt', '01234');
-		$homeStorage = new Quota(
-			[
-				'storage' => $homeStorage,
-				'quota' => 7
-			]
-		);
-		Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
-
-		$storageInfo = \OC_Helper::getStorageInfo('');
-		$this->assertEquals(2, $storageInfo['free']);
-		$this->assertEquals(5, $storageInfo['used']);
-		$this->assertEquals(7, $storageInfo['total']);
-	}
-
-	/**
-	 * Test getting the storage info when data exceeds quota
-	 */
-	public function testGetStorageInfoWhenSizeExceedsQuota(): void {
-		$homeStorage = $this->getStorageMock(12);
-		$homeStorage->file_put_contents('test.txt', '0123456789');
-		$homeStorage = new Quota(
-			[
-				'storage' => $homeStorage,
-				'quota' => 7
-			]
-		);
-		Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
-
-		$storageInfo = \OC_Helper::getStorageInfo('');
-		$this->assertEquals(0, $storageInfo['free']);
-		$this->assertEquals(10, $storageInfo['used']);
-		// total = quota
-		$this->assertEquals(7, $storageInfo['total']);
-	}
-
-	/**
-	 * Test getting the storage info when the remaining
-	 * free storage space is less than the quota
-	 */
-	public function testGetStorageInfoWhenFreeSpaceLessThanQuota(): void {
-		$homeStorage = $this->getStorageMock(12);
-		$homeStorage->file_put_contents('test.txt', '01234');
-		$homeStorage = new Quota(
-			[
-				'storage' => $homeStorage,
-				'quota' => 18
-			]
-		);
-		Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
-
-		$storageInfo = \OC_Helper::getStorageInfo('');
-		$this->assertEquals(12, $storageInfo['free']);
-		$this->assertEquals(5, $storageInfo['used']);
-		// total = free + used (because quota > total)
-		$this->assertEquals(17, $storageInfo['total']);
-	}
+    use UserTrait;
+
+    /** @var string */
+    private $user;
+    /** @var Storage */
+    private $storageMock;
+    /** @var Storage */
+    private $storage;
+    private bool $savedQuotaIncludeExternalStorage;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->user = $this->getUniqueID('user_');
+        $this->createUser($this->user, $this->user);
+        $this->savedQuotaIncludeExternalStorage = $this->getIncludeExternalStorage();
+
+        Filesystem::tearDown();
+        \OC_User::setUserId($this->user);
+        Filesystem::init($this->user, '/' . $this->user . '/files');
+
+        /** @var IMountManager $manager */
+        $manager = Server::get(IMountManager::class);
+        $manager->removeMount('/' . $this->user);
+
+        $this->storageMock = null;
+    }
+
+    protected function tearDown(): void {
+        $this->setIncludeExternalStorage($this->savedQuotaIncludeExternalStorage);
+        $this->user = null;
+
+        if ($this->storageMock) {
+            $this->storageMock->getCache()->clear();
+            $this->storageMock = null;
+        }
+        Filesystem::tearDown();
+
+        \OC_User::setUserId('');
+        Server::get(IConfig::class)->deleteAllUserValues($this->user);
+
+        parent::tearDown();
+    }
+
+    /**
+     * Returns a storage mock that returns the given value as
+     * free space
+     *
+     * @param int $freeSpace free space value
+     * @return Storage
+     */
+    private function getStorageMock($freeSpace = 12) {
+        $this->storageMock = $this->getMockBuilder(Temporary::class)
+            ->onlyMethods(['free_space'])
+            ->setConstructorArgs([[]])
+            ->getMock();
+
+        $this->storageMock->expects($this->once())
+            ->method('free_space')
+            ->willReturn($freeSpace);
+        return $this->storageMock;
+    }
+
+    /**
+     * Test getting the storage info
+     */
+    public function testGetStorageInfo(): void {
+        $homeStorage = $this->getStorageMock(12);
+        Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
+        $homeStorage->file_put_contents('test.txt', '01234');
+
+        $storageInfo = \OC_Helper::getStorageInfo('');
+        $this->assertEquals(12, $storageInfo['free']);
+        $this->assertEquals(5, $storageInfo['used']);
+        $this->assertEquals(17, $storageInfo['total']);
+    }
+
+    private function getIncludeExternalStorage(): bool {
+        $class = new \ReflectionClass(\OC_Helper::class);
+        $prop = $class->getProperty('quotaIncludeExternalStorage');
+        return $prop->getValue(null) ?? false;
+    }
+
+    private function setIncludeExternalStorage(bool $include) {
+        $class = new \ReflectionClass(\OC_Helper::class);
+        $prop = $class->getProperty('quotaIncludeExternalStorage');
+        $prop->setValue(null, $include);
+    }
+
+    /**
+     * Test getting the storage info, ignoring extra mount points
+     */
+    public function testGetStorageInfoExcludingExtStorage(): void {
+        $homeStorage = $this->getStorageMock(12);
+        Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
+        $homeStorage->file_put_contents('test.txt', '01234');
+
+        $extStorage = new Temporary([]);
+        $extStorage->file_put_contents('extfile.txt', 'abcdefghijklmnopq');
+        $extStorage->getScanner()->scan(''); // update root size
+
+        $this->setIncludeExternalStorage(false);
+
+        Filesystem::mount($extStorage, [], '/' . $this->user . '/files/ext');
+
+        $storageInfo = \OC_Helper::getStorageInfo('');
+        $this->assertEquals(12, $storageInfo['free']);
+        $this->assertEquals(5, $storageInfo['used']);
+        $this->assertEquals(17, $storageInfo['total']);
+    }
+
+    /**
+     * Test getting the storage info, including extra mount points
+     */
+    public function testGetStorageInfoIncludingExtStorage(): void {
+        $homeStorage = new Temporary([]);
+        Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
+        $homeStorage->file_put_contents('test.txt', '01234');
+
+        $extStorage = new Temporary([]);
+        $extStorage->file_put_contents('extfile.txt', 'abcdefghijklmnopq');
+        $extStorage->getScanner()->scan(''); // update root size
+
+        Filesystem::mount($extStorage, [], '/' . $this->user . '/files/ext');
+
+        $this->setIncludeExternalStorage(true);
+
+        $config = Server::get(IConfig::class);
+        $config->setUserValue($this->user, 'files', 'quota', '25');
+
+        $storageInfo = \OC_Helper::getStorageInfo('');
+        $this->assertEquals(3, $storageInfo['free']);
+        $this->assertEquals(22, $storageInfo['used']);
+        $this->assertEquals(25, $storageInfo['total']);
+
+        $config->setUserValue($this->user, 'files', 'quota', 'default');
+    }
+
+    /**
+     * Test getting the storage info excluding extra mount points
+     * when user has no quota set, even when quota ext storage option
+     * was set
+     */
+    public function testGetStorageInfoIncludingExtStorageWithNoUserQuota(): void {
+        $homeStorage = $this->getStorageMock(12);
+        Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
+        $homeStorage->file_put_contents('test.txt', '01234');
+
+        $extStorage = new Temporary([]);
+        $extStorage->file_put_contents('extfile.txt', 'abcdefghijklmnopq');
+        $extStorage->getScanner()->scan(''); // update root size
+
+        Filesystem::mount($extStorage, [], '/' . $this->user . '/files/ext');
+
+        $config = Server::get(IConfig::class);
+        $this->setIncludeExternalStorage(true);
+
+        $storageInfo = \OC_Helper::getStorageInfo('');
+        $this->assertEquals(12, $storageInfo['free'], '12 bytes free in home storage');
+        $this->assertEquals(22, $storageInfo['used'], '5 bytes of home storage and 17 bytes of the temporary storage are used');
+        $this->assertEquals(34, $storageInfo['total'], '5 bytes used and 12 bytes free in home storage as well as 17 bytes used in temporary storage');
+    }
+
+
+    /**
+     * Test getting the storage info with quota enabled
+     */
+    public function testGetStorageInfoWithQuota(): void {
+        $homeStorage = $this->getStorageMock(12);
+        $homeStorage->file_put_contents('test.txt', '01234');
+        $homeStorage = new Quota(
+            [
+                'storage' => $homeStorage,
+                'quota' => 7
+            ]
+        );
+        Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
+
+        $storageInfo = \OC_Helper::getStorageInfo('');
+        $this->assertEquals(2, $storageInfo['free']);
+        $this->assertEquals(5, $storageInfo['used']);
+        $this->assertEquals(7, $storageInfo['total']);
+    }
+
+    /**
+     * Test getting the storage info when data exceeds quota
+     */
+    public function testGetStorageInfoWhenSizeExceedsQuota(): void {
+        $homeStorage = $this->getStorageMock(12);
+        $homeStorage->file_put_contents('test.txt', '0123456789');
+        $homeStorage = new Quota(
+            [
+                'storage' => $homeStorage,
+                'quota' => 7
+            ]
+        );
+        Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
+
+        $storageInfo = \OC_Helper::getStorageInfo('');
+        $this->assertEquals(0, $storageInfo['free']);
+        $this->assertEquals(10, $storageInfo['used']);
+        // total = quota
+        $this->assertEquals(7, $storageInfo['total']);
+    }
+
+    /**
+     * Test getting the storage info when the remaining
+     * free storage space is less than the quota
+     */
+    public function testGetStorageInfoWhenFreeSpaceLessThanQuota(): void {
+        $homeStorage = $this->getStorageMock(12);
+        $homeStorage->file_put_contents('test.txt', '01234');
+        $homeStorage = new Quota(
+            [
+                'storage' => $homeStorage,
+                'quota' => 18
+            ]
+        );
+        Filesystem::mount($homeStorage, [], '/' . $this->user . '/files');
+
+        $storageInfo = \OC_Helper::getStorageInfo('');
+        $this->assertEquals(12, $storageInfo['free']);
+        $this->assertEquals(5, $storageInfo['used']);
+        // total = free + used (because quota > total)
+        $this->assertEquals(17, $storageInfo['total']);
+    }
 }

tests/lib/TestCase.php

Indentation +594 added lines, -594 removed lines

@@ -41,602 +41,602 @@
 use PHPUnit\Framework\Attributes\Group;
 
 if (version_compare(\PHPUnit\Runner\Version::id(), 10, '>=')) {
-	trait OnNotSuccessfulTestTrait {
-		protected function onNotSuccessfulTest(\Throwable $t): never {
-			$this->restoreAllServices();
-
-			// restore database connection
-			if (!$this->IsDatabaseAccessAllowed()) {
-				\OC::$server->registerService(IDBConnection::class, function () {
-					return self::$realDatabase;
-				});
-			}
-
-			parent::onNotSuccessfulTest($t);
-		}
-	}
+    trait OnNotSuccessfulTestTrait {
+        protected function onNotSuccessfulTest(\Throwable $t): never {
+            $this->restoreAllServices();
+
+            // restore database connection
+            if (!$this->IsDatabaseAccessAllowed()) {
+                \OC::$server->registerService(IDBConnection::class, function () {
+                    return self::$realDatabase;
+                });
+            }
+
+            parent::onNotSuccessfulTest($t);
+        }
+    }
 } else {
-	trait OnNotSuccessfulTestTrait {
-		protected function onNotSuccessfulTest(\Throwable $t): void {
-			$this->restoreAllServices();
-
-			// restore database connection
-			if (!$this->IsDatabaseAccessAllowed()) {
-				\OC::$server->registerService(IDBConnection::class, function () {
-					return self::$realDatabase;
-				});
-			}
-
-			parent::onNotSuccessfulTest($t);
-		}
-	}
+    trait OnNotSuccessfulTestTrait {
+        protected function onNotSuccessfulTest(\Throwable $t): void {
+            $this->restoreAllServices();
+
+            // restore database connection
+            if (!$this->IsDatabaseAccessAllowed()) {
+                \OC::$server->registerService(IDBConnection::class, function () {
+                    return self::$realDatabase;
+                });
+            }
+
+            parent::onNotSuccessfulTest($t);
+        }
+    }
 }
 
 abstract class TestCase extends \PHPUnit\Framework\TestCase {
-	/** @var \OC\Command\QueueBus */
-	private $commandBus;
-
-	/** @var IDBConnection */
-	protected static $realDatabase = null;
-
-	/** @var bool */
-	private static $wasDatabaseAllowed = false;
-
-	/** @var array */
-	protected $services = [];
-
-	use OnNotSuccessfulTestTrait;
-
-	/**
-	 * @param string $name
-	 * @param mixed $newService
-	 * @return bool
-	 */
-	public function overwriteService(string $name, $newService): bool {
-		if (isset($this->services[$name])) {
-			return false;
-		}
-
-		try {
-			$this->services[$name] = Server::get($name);
-		} catch (QueryException $e) {
-			$this->services[$name] = false;
-		}
-		$container = \OC::$server->getAppContainerForService($name);
-		$container = $container ?? \OC::$server;
-
-		$container->registerService($name, function () use ($newService) {
-			return $newService;
-		});
-
-		return true;
-	}
-
-	/**
-	 * @param string $name
-	 * @return bool
-	 */
-	public function restoreService(string $name): bool {
-		if (isset($this->services[$name])) {
-			$oldService = $this->services[$name];
-
-			$container = \OC::$server->getAppContainerForService($name);
-			$container = $container ?? \OC::$server;
-
-			if ($oldService !== false) {
-				$container->registerService($name, function () use ($oldService) {
-					return $oldService;
-				});
-			} else {
-				unset($container[$oldService]);
-			}
-
-
-			unset($this->services[$name]);
-			return true;
-		}
-
-		return false;
-	}
-
-	public function restoreAllServices() {
-		if (!empty($this->services)) {
-			if (!empty($this->services)) {
-				foreach ($this->services as $name => $service) {
-					$this->restoreService($name);
-				}
-			}
-		}
-	}
-
-	protected function getTestTraits() {
-		$traits = [];
-		$class = $this;
-		do {
-			$traits = array_merge(class_uses($class), $traits);
-		} while ($class = get_parent_class($class));
-		foreach ($traits as $trait => $same) {
-			$traits = array_merge(class_uses($trait), $traits);
-		}
-		$traits = array_unique($traits);
-		return array_filter($traits, function ($trait) {
-			return substr($trait, 0, 5) === 'Test\\';
-		});
-	}
-
-	protected function setUp(): void {
-		// overwrite the command bus with one we can run ourselves
-		$this->commandBus = new QueueBus();
-		$this->overwriteService('AsyncCommandBus', $this->commandBus);
-		$this->overwriteService(IBus::class, $this->commandBus);
-
-		// detect database access
-		self::$wasDatabaseAllowed = true;
-		if (!$this->IsDatabaseAccessAllowed()) {
-			self::$wasDatabaseAllowed = false;
-			if (is_null(self::$realDatabase)) {
-				self::$realDatabase = Server::get(IDBConnection::class);
-			}
-			\OC::$server->registerService(IDBConnection::class, function (): void {
-				$this->fail('Your test case is not allowed to access the database.');
-			});
-		}
-
-		$traits = $this->getTestTraits();
-		foreach ($traits as $trait) {
-			$methodName = 'setUp' . basename(str_replace('\\', '/', $trait));
-			if (method_exists($this, $methodName)) {
-				call_user_func([$this, $methodName]);
-			}
-		}
-	}
-
-	protected function tearDown(): void {
-		$this->restoreAllServices();
-
-		// restore database connection
-		if (!$this->IsDatabaseAccessAllowed()) {
-			\OC::$server->registerService(IDBConnection::class, function () {
-				return self::$realDatabase;
-			});
-		}
-
-		// further cleanup
-		$hookExceptions = \OC_Hook::$thrownExceptions;
-		\OC_Hook::$thrownExceptions = [];
-		Server::get(ILockingProvider::class)->releaseAll();
-		if (!empty($hookExceptions)) {
-			throw $hookExceptions[0];
-		}
-
-		// fail hard if xml errors have not been cleaned up
-		$errors = libxml_get_errors();
-		libxml_clear_errors();
-		if (!empty($errors)) {
-			self::assertEquals([], $errors, 'There have been xml parsing errors');
-		}
-
-		if ($this->IsDatabaseAccessAllowed()) {
-			Storage::getGlobalCache()->clearCache();
-		}
-
-		// tearDown the traits
-		$traits = $this->getTestTraits();
-		foreach ($traits as $trait) {
-			$methodName = 'tearDown' . basename(str_replace('\\', '/', $trait));
-			if (method_exists($this, $methodName)) {
-				call_user_func([$this, $methodName]);
-			}
-		}
-	}
-
-	/**
-	 * Allows us to test private methods/properties
-	 *
-	 * @param $object
-	 * @param $methodName
-	 * @param array $parameters
-	 * @return mixed
-	 */
-	protected static function invokePrivate($object, $methodName, array $parameters = []) {
-		if (is_string($object)) {
-			$className = $object;
-		} else {
-			$className = get_class($object);
-		}
-		$reflection = new \ReflectionClass($className);
-
-		if ($reflection->hasMethod($methodName)) {
-			$method = $reflection->getMethod($methodName);
-			return $method->invokeArgs($object, $parameters);
-		} elseif ($reflection->hasProperty($methodName)) {
-			$property = $reflection->getProperty($methodName);
-
-			if (!empty($parameters)) {
-				if ($property->isStatic()) {
-					$property->setValue(null, array_pop($parameters));
-				} else {
-					$property->setValue($object, array_pop($parameters));
-				}
-			}
-
-			if (is_object($object)) {
-				return $property->getValue($object);
-			}
-
-			return $property->getValue();
-		} elseif ($reflection->hasConstant($methodName)) {
-			return $reflection->getConstant($methodName);
-		}
-
-		return false;
-	}
-
-	/**
-	 * Returns a unique identifier as uniqid() is not reliable sometimes
-	 *
-	 * @param string $prefix
-	 * @param int $length
-	 * @return string
-	 */
-	protected static function getUniqueID($prefix = '', $length = 13) {
-		return $prefix . Server::get(ISecureRandom::class)->generate(
-			$length,
-			// Do not use dots and slashes as we use the value for file names
-			ISecureRandom::CHAR_DIGITS . ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_UPPER
-		);
-	}
-
-	/**
-	 * Filter methods
-	 *
-	 * Returns all methods of the given class,
-	 * that are public or abstract and not in the ignoreMethods list,
-	 * to be able to fill onlyMethods() with an inverted list.
-	 *
-	 * @param string $className
-	 * @param string[] $filterMethods
-	 * @return string[]
-	 */
-	public function filterClassMethods(string $className, array $filterMethods): array {
-		$class = new \ReflectionClass($className);
-
-		$methods = [];
-		foreach ($class->getMethods() as $method) {
-			if (($method->isPublic() || $method->isAbstract()) && !in_array($method->getName(), $filterMethods, true)) {
-				$methods[] = $method->getName();
-			}
-		}
-
-		return $methods;
-	}
-
-	public static function tearDownAfterClass(): void {
-		if (!self::$wasDatabaseAllowed && self::$realDatabase !== null) {
-			// in case an error is thrown in a test, PHPUnit jumps straight to tearDownAfterClass,
-			// so we need the database again
-			\OC::$server->registerService(IDBConnection::class, function () {
-				return self::$realDatabase;
-			});
-		}
-		$dataDir = Server::get(IConfig::class)->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data-autotest');
-		if (self::$wasDatabaseAllowed && Server::get(IDBConnection::class)) {
-			$db = Server::get(IDBConnection::class);
-			if ($db->inTransaction()) {
-				$db->rollBack();
-				throw new \Exception('There was a transaction still in progress and needed to be rolled back. Please fix this in your test.');
-			}
-			$queryBuilder = $db->getQueryBuilder();
-
-			self::tearDownAfterClassCleanShares($queryBuilder);
-			self::tearDownAfterClassCleanStorages($queryBuilder);
-			self::tearDownAfterClassCleanFileCache($queryBuilder);
-		}
-		self::tearDownAfterClassCleanStrayDataFiles($dataDir);
-		self::tearDownAfterClassCleanStrayHooks();
-		self::tearDownAfterClassCleanStrayLocks();
-
-		// Ensure we start with fresh instances of some classes to reduce side-effects between tests
-		unset(\OC::$server[Factory::class]);
-		unset(\OC::$server[AppFetcher::class]);
-		unset(\OC::$server[Installer::class]);
-		unset(\OC::$server[Updater::class]);
-
-		/** @var SetupManager $setupManager */
-		$setupManager = Server::get(SetupManager::class);
-		$setupManager->tearDown();
-
-		/** @var MountProviderCollection $mountProviderCollection */
-		$mountProviderCollection = Server::get(MountProviderCollection::class);
-		$mountProviderCollection->clearProviders();
-
-		/** @var IConfig $config */
-		$config = Server::get(IConfig::class);
-		$mountProviderCollection->registerProvider(new CacheMountProvider($config));
-		$mountProviderCollection->registerHomeProvider(new LocalHomeMountProvider());
-		$objectStoreConfig = Server::get(PrimaryObjectStoreConfig::class);
-		$mountProviderCollection->registerRootProvider(new RootMountProvider($objectStoreConfig, $config));
-
-		$setupManager->setupRoot();
-
-		parent::tearDownAfterClass();
-	}
-
-	/**
-	 * Remove all entries from the share table
-	 *
-	 * @param IQueryBuilder $queryBuilder
-	 */
-	protected static function tearDownAfterClassCleanShares(IQueryBuilder $queryBuilder) {
-		$queryBuilder->delete('share')
-			->executeStatement();
-	}
-
-	/**
-	 * Remove all entries from the storages table
-	 *
-	 * @param IQueryBuilder $queryBuilder
-	 */
-	protected static function tearDownAfterClassCleanStorages(IQueryBuilder $queryBuilder) {
-		$queryBuilder->delete('storages')
-			->executeStatement();
-	}
-
-	/**
-	 * Remove all entries from the filecache table
-	 *
-	 * @param IQueryBuilder $queryBuilder
-	 */
-	protected static function tearDownAfterClassCleanFileCache(IQueryBuilder $queryBuilder) {
-		$queryBuilder->delete('filecache')
-			->runAcrossAllShards()
-			->executeStatement();
-	}
-
-	/**
-	 * Remove all unused files from the data dir
-	 *
-	 * @param string $dataDir
-	 */
-	protected static function tearDownAfterClassCleanStrayDataFiles($dataDir) {
-		$knownEntries = [
-			'nextcloud.log' => true,
-			'audit.log' => true,
-			'owncloud.db' => true,
-			'.ocdata' => true,
-			'..' => true,
-			'.' => true,
-		];
-
-		if ($dh = opendir($dataDir)) {
-			while (($file = readdir($dh)) !== false) {
-				if (!isset($knownEntries[$file])) {
-					self::tearDownAfterClassCleanStrayDataUnlinkDir($dataDir . '/' . $file);
-				}
-			}
-			closedir($dh);
-		}
-	}
-
-	/**
-	 * Recursive delete files and folders from a given directory
-	 *
-	 * @param string $dir
-	 */
-	protected static function tearDownAfterClassCleanStrayDataUnlinkDir($dir) {
-		if ($dh = @opendir($dir)) {
-			while (($file = readdir($dh)) !== false) {
-				if (Filesystem::isIgnoredDir($file)) {
-					continue;
-				}
-				$path = $dir . '/' . $file;
-				if (is_dir($path)) {
-					self::tearDownAfterClassCleanStrayDataUnlinkDir($path);
-				} else {
-					@unlink($path);
-				}
-			}
-			closedir($dh);
-		}
-		@rmdir($dir);
-	}
-
-	/**
-	 * Clean up the list of hooks
-	 */
-	protected static function tearDownAfterClassCleanStrayHooks() {
-		\OC_Hook::clear();
-	}
-
-	/**
-	 * Clean up the list of locks
-	 */
-	protected static function tearDownAfterClassCleanStrayLocks() {
-		Server::get(ILockingProvider::class)->releaseAll();
-	}
-
-	/**
-	 * Login and setup FS as a given user,
-	 * sets the given user as the current user.
-	 *
-	 * @param string $user user id or empty for a generic FS
-	 */
-	protected static function loginAsUser($user = '') {
-		self::logout();
-		Filesystem::tearDown();
-		\OC_User::setUserId($user);
-		$userObject = Server::get(IUserManager::class)->get($user);
-		if (!is_null($userObject)) {
-			$userObject->updateLastLoginTimestamp();
-		}
-		\OC_Util::setupFS($user);
-		if (Server::get(IUserManager::class)->userExists($user)) {
-			\OC::$server->getUserFolder($user);
-		}
-	}
-
-	/**
-	 * Logout the current user and tear down the filesystem.
-	 */
-	protected static function logout() {
-		\OC_Util::tearDownFS();
-		\OC_User::setUserId('');
-		// needed for fully logout
-		Server::get(IUserSession::class)->setUser(null);
-	}
-
-	/**
-	 * Run all commands pushed to the bus
-	 */
-	protected function runCommands() {
-		// get the user for which the fs is setup
-		$view = Filesystem::getView();
-		if ($view) {
-			[, $user] = explode('/', $view->getRoot());
-		} else {
-			$user = null;
-		}
-
-		\OC_Util::tearDownFS(); // command can't reply on the fs being setup
-		$this->commandBus->run();
-		\OC_Util::tearDownFS();
-
-		if ($user) {
-			\OC_Util::setupFS($user);
-		}
-	}
-
-	/**
-	 * Check if the given path is locked with a given type
-	 *
-	 * @param View $view view
-	 * @param string $path path to check
-	 * @param int $type lock type
-	 * @param bool $onMountPoint true to check the mount point instead of the
-	 *                           mounted storage
-	 *
-	 * @return boolean true if the file is locked with the
-	 *                 given type, false otherwise
-	 */
-	protected function isFileLocked($view, $path, $type, $onMountPoint = false) {
-		// Note: this seems convoluted but is necessary because
-		// the format of the lock key depends on the storage implementation
-		// (in our case mostly md5)
-
-		if ($type === ILockingProvider::LOCK_SHARED) {
-			// to check if the file has a shared lock, try acquiring an exclusive lock
-			$checkType = ILockingProvider::LOCK_EXCLUSIVE;
-		} else {
-			// a shared lock cannot be set if exclusive lock is in place
-			$checkType = ILockingProvider::LOCK_SHARED;
-		}
-		try {
-			$view->lockFile($path, $checkType, $onMountPoint);
-			// no exception, which means the lock of $type is not set
-			// clean up
-			$view->unlockFile($path, $checkType, $onMountPoint);
-			return false;
-		} catch (LockedException $e) {
-			// we could not acquire the counter-lock, which means
-			// the lock of $type was in place
-			return true;
-		}
-	}
-
-	protected function getGroupAnnotations(): array {
-		if (method_exists($this, 'getAnnotations')) {
-			$annotations = $this->getAnnotations();
-			return $annotations['class']['group'] ?? [];
-		}
-
-		$r = new \ReflectionClass($this);
-		$doc = $r->getDocComment();
-
-		if (class_exists(Group::class)) {
-			$attributes = array_map(function (\ReflectionAttribute $attribute) {
-				/** @var Group $group */
-				$group = $attribute->newInstance();
-				return $group->name();
-			}, $r->getAttributes(Group::class));
-			if (count($attributes) > 0) {
-				return $attributes;
-			}
-		}
-		preg_match_all('#@group\s+(.*?)\n#s', $doc, $annotations);
-		return $annotations[1] ?? [];
-	}
-
-	protected function IsDatabaseAccessAllowed(): bool {
-		$annotations = $this->getGroupAnnotations();
-		if (isset($annotations)) {
-			if (in_array('DB', $annotations) || in_array('SLOWDB', $annotations)) {
-				return true;
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * @param string $expectedHtml
-	 * @param string $template
-	 * @param array $vars
-	 */
-	protected function assertTemplate($expectedHtml, $template, $vars = []) {
-		$requestToken = 12345;
-		/** @var Defaults|\PHPUnit\Framework\MockObject\MockObject $l10n */
-		$theme = $this->getMockBuilder('\OCP\Defaults')
-			->disableOriginalConstructor()->getMock();
-		$theme->expects($this->any())
-			->method('getName')
-			->willReturn('Nextcloud');
-		/** @var IL10N|\PHPUnit\Framework\MockObject\MockObject $l10n */
-		$l10n = $this->getMockBuilder(IL10N::class)
-			->disableOriginalConstructor()->getMock();
-		$l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($text, $parameters = []) {
-				return vsprintf($text, $parameters);
-			});
-
-		$t = new Base($template, $requestToken, $l10n, $theme);
-		$buf = $t->fetchPage($vars);
-		$this->assertHtmlStringEqualsHtmlString($expectedHtml, $buf);
-	}
-
-	/**
-	 * @param string $expectedHtml
-	 * @param string $actualHtml
-	 * @param string $message
-	 */
-	protected function assertHtmlStringEqualsHtmlString($expectedHtml, $actualHtml, $message = '') {
-		$expected = new DOMDocument();
-		$expected->preserveWhiteSpace = false;
-		$expected->formatOutput = true;
-		$expected->loadHTML($expectedHtml);
-
-		$actual = new DOMDocument();
-		$actual->preserveWhiteSpace = false;
-		$actual->formatOutput = true;
-		$actual->loadHTML($actualHtml);
-		$this->removeWhitespaces($actual);
-
-		$expectedHtml1 = $expected->saveHTML();
-		$actualHtml1 = $actual->saveHTML();
-		self::assertEquals($expectedHtml1, $actualHtml1, $message);
-	}
-
-
-	private function removeWhitespaces(DOMNode $domNode) {
-		foreach ($domNode->childNodes as $node) {
-			if ($node->hasChildNodes()) {
-				$this->removeWhitespaces($node);
-			} else {
-				if ($node instanceof \DOMText && $node->isWhitespaceInElementContent()) {
-					$domNode->removeChild($node);
-				}
-			}
-		}
-	}
+    /** @var \OC\Command\QueueBus */
+    private $commandBus;
+
+    /** @var IDBConnection */
+    protected static $realDatabase = null;
+
+    /** @var bool */
+    private static $wasDatabaseAllowed = false;
+
+    /** @var array */
+    protected $services = [];
+
+    use OnNotSuccessfulTestTrait;
+
+    /**
+     * @param string $name
+     * @param mixed $newService
+     * @return bool
+     */
+    public function overwriteService(string $name, $newService): bool {
+        if (isset($this->services[$name])) {
+            return false;
+        }
+
+        try {
+            $this->services[$name] = Server::get($name);
+        } catch (QueryException $e) {
+            $this->services[$name] = false;
+        }
+        $container = \OC::$server->getAppContainerForService($name);
+        $container = $container ?? \OC::$server;
+
+        $container->registerService($name, function () use ($newService) {
+            return $newService;
+        });
+
+        return true;
+    }
+
+    /**
+     * @param string $name
+     * @return bool
+     */
+    public function restoreService(string $name): bool {
+        if (isset($this->services[$name])) {
+            $oldService = $this->services[$name];
+
+            $container = \OC::$server->getAppContainerForService($name);
+            $container = $container ?? \OC::$server;
+
+            if ($oldService !== false) {
+                $container->registerService($name, function () use ($oldService) {
+                    return $oldService;
+                });
+            } else {
+                unset($container[$oldService]);
+            }
+
+
+            unset($this->services[$name]);
+            return true;
+        }
+
+        return false;
+    }
+
+    public function restoreAllServices() {
+        if (!empty($this->services)) {
+            if (!empty($this->services)) {
+                foreach ($this->services as $name => $service) {
+                    $this->restoreService($name);
+                }
+            }
+        }
+    }
+
+    protected function getTestTraits() {
+        $traits = [];
+        $class = $this;
+        do {
+            $traits = array_merge(class_uses($class), $traits);
+        } while ($class = get_parent_class($class));
+        foreach ($traits as $trait => $same) {
+            $traits = array_merge(class_uses($trait), $traits);
+        }
+        $traits = array_unique($traits);
+        return array_filter($traits, function ($trait) {
+            return substr($trait, 0, 5) === 'Test\\';
+        });
+    }
+
+    protected function setUp(): void {
+        // overwrite the command bus with one we can run ourselves
+        $this->commandBus = new QueueBus();
+        $this->overwriteService('AsyncCommandBus', $this->commandBus);
+        $this->overwriteService(IBus::class, $this->commandBus);
+
+        // detect database access
+        self::$wasDatabaseAllowed = true;
+        if (!$this->IsDatabaseAccessAllowed()) {
+            self::$wasDatabaseAllowed = false;
+            if (is_null(self::$realDatabase)) {
+                self::$realDatabase = Server::get(IDBConnection::class);
+            }
+            \OC::$server->registerService(IDBConnection::class, function (): void {
+                $this->fail('Your test case is not allowed to access the database.');
+            });
+        }
+
+        $traits = $this->getTestTraits();
+        foreach ($traits as $trait) {
+            $methodName = 'setUp' . basename(str_replace('\\', '/', $trait));
+            if (method_exists($this, $methodName)) {
+                call_user_func([$this, $methodName]);
+            }
+        }
+    }
+
+    protected function tearDown(): void {
+        $this->restoreAllServices();
+
+        // restore database connection
+        if (!$this->IsDatabaseAccessAllowed()) {
+            \OC::$server->registerService(IDBConnection::class, function () {
+                return self::$realDatabase;
+            });
+        }
+
+        // further cleanup
+        $hookExceptions = \OC_Hook::$thrownExceptions;
+        \OC_Hook::$thrownExceptions = [];
+        Server::get(ILockingProvider::class)->releaseAll();
+        if (!empty($hookExceptions)) {
+            throw $hookExceptions[0];
+        }
+
+        // fail hard if xml errors have not been cleaned up
+        $errors = libxml_get_errors();
+        libxml_clear_errors();
+        if (!empty($errors)) {
+            self::assertEquals([], $errors, 'There have been xml parsing errors');
+        }
+
+        if ($this->IsDatabaseAccessAllowed()) {
+            Storage::getGlobalCache()->clearCache();
+        }
+
+        // tearDown the traits
+        $traits = $this->getTestTraits();
+        foreach ($traits as $trait) {
+            $methodName = 'tearDown' . basename(str_replace('\\', '/', $trait));
+            if (method_exists($this, $methodName)) {
+                call_user_func([$this, $methodName]);
+            }
+        }
+    }
+
+    /**
+     * Allows us to test private methods/properties
+     *
+     * @param $object
+     * @param $methodName
+     * @param array $parameters
+     * @return mixed
+     */
+    protected static function invokePrivate($object, $methodName, array $parameters = []) {
+        if (is_string($object)) {
+            $className = $object;
+        } else {
+            $className = get_class($object);
+        }
+        $reflection = new \ReflectionClass($className);
+
+        if ($reflection->hasMethod($methodName)) {
+            $method = $reflection->getMethod($methodName);
+            return $method->invokeArgs($object, $parameters);
+        } elseif ($reflection->hasProperty($methodName)) {
+            $property = $reflection->getProperty($methodName);
+
+            if (!empty($parameters)) {
+                if ($property->isStatic()) {
+                    $property->setValue(null, array_pop($parameters));
+                } else {
+                    $property->setValue($object, array_pop($parameters));
+                }
+            }
+
+            if (is_object($object)) {
+                return $property->getValue($object);
+            }
+
+            return $property->getValue();
+        } elseif ($reflection->hasConstant($methodName)) {
+            return $reflection->getConstant($methodName);
+        }
+
+        return false;
+    }
+
+    /**
+     * Returns a unique identifier as uniqid() is not reliable sometimes
+     *
+     * @param string $prefix
+     * @param int $length
+     * @return string
+     */
+    protected static function getUniqueID($prefix = '', $length = 13) {
+        return $prefix . Server::get(ISecureRandom::class)->generate(
+            $length,
+            // Do not use dots and slashes as we use the value for file names
+            ISecureRandom::CHAR_DIGITS . ISecureRandom::CHAR_LOWER . ISecureRandom::CHAR_UPPER
+        );
+    }
+
+    /**
+     * Filter methods
+     *
+     * Returns all methods of the given class,
+     * that are public or abstract and not in the ignoreMethods list,
+     * to be able to fill onlyMethods() with an inverted list.
+     *
+     * @param string $className
+     * @param string[] $filterMethods
+     * @return string[]
+     */
+    public function filterClassMethods(string $className, array $filterMethods): array {
+        $class = new \ReflectionClass($className);
+
+        $methods = [];
+        foreach ($class->getMethods() as $method) {
+            if (($method->isPublic() || $method->isAbstract()) && !in_array($method->getName(), $filterMethods, true)) {
+                $methods[] = $method->getName();
+            }
+        }
+
+        return $methods;
+    }
+
+    public static function tearDownAfterClass(): void {
+        if (!self::$wasDatabaseAllowed && self::$realDatabase !== null) {
+            // in case an error is thrown in a test, PHPUnit jumps straight to tearDownAfterClass,
+            // so we need the database again
+            \OC::$server->registerService(IDBConnection::class, function () {
+                return self::$realDatabase;
+            });
+        }
+        $dataDir = Server::get(IConfig::class)->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data-autotest');
+        if (self::$wasDatabaseAllowed && Server::get(IDBConnection::class)) {
+            $db = Server::get(IDBConnection::class);
+            if ($db->inTransaction()) {
+                $db->rollBack();
+                throw new \Exception('There was a transaction still in progress and needed to be rolled back. Please fix this in your test.');
+            }
+            $queryBuilder = $db->getQueryBuilder();
+
+            self::tearDownAfterClassCleanShares($queryBuilder);
+            self::tearDownAfterClassCleanStorages($queryBuilder);
+            self::tearDownAfterClassCleanFileCache($queryBuilder);
+        }
+        self::tearDownAfterClassCleanStrayDataFiles($dataDir);
+        self::tearDownAfterClassCleanStrayHooks();
+        self::tearDownAfterClassCleanStrayLocks();
+
+        // Ensure we start with fresh instances of some classes to reduce side-effects between tests
+        unset(\OC::$server[Factory::class]);
+        unset(\OC::$server[AppFetcher::class]);
+        unset(\OC::$server[Installer::class]);
+        unset(\OC::$server[Updater::class]);
+
+        /** @var SetupManager $setupManager */
+        $setupManager = Server::get(SetupManager::class);
+        $setupManager->tearDown();
+
+        /** @var MountProviderCollection $mountProviderCollection */
+        $mountProviderCollection = Server::get(MountProviderCollection::class);
+        $mountProviderCollection->clearProviders();
+
+        /** @var IConfig $config */
+        $config = Server::get(IConfig::class);
+        $mountProviderCollection->registerProvider(new CacheMountProvider($config));
+        $mountProviderCollection->registerHomeProvider(new LocalHomeMountProvider());
+        $objectStoreConfig = Server::get(PrimaryObjectStoreConfig::class);
+        $mountProviderCollection->registerRootProvider(new RootMountProvider($objectStoreConfig, $config));
+
+        $setupManager->setupRoot();
+
+        parent::tearDownAfterClass();
+    }
+
+    /**
+     * Remove all entries from the share table
+     *
+     * @param IQueryBuilder $queryBuilder
+     */
+    protected static function tearDownAfterClassCleanShares(IQueryBuilder $queryBuilder) {
+        $queryBuilder->delete('share')
+            ->executeStatement();
+    }
+
+    /**
+     * Remove all entries from the storages table
+     *
+     * @param IQueryBuilder $queryBuilder
+     */
+    protected static function tearDownAfterClassCleanStorages(IQueryBuilder $queryBuilder) {
+        $queryBuilder->delete('storages')
+            ->executeStatement();
+    }
+
+    /**
+     * Remove all entries from the filecache table
+     *
+     * @param IQueryBuilder $queryBuilder
+     */
+    protected static function tearDownAfterClassCleanFileCache(IQueryBuilder $queryBuilder) {
+        $queryBuilder->delete('filecache')
+            ->runAcrossAllShards()
+            ->executeStatement();
+    }
+
+    /**
+     * Remove all unused files from the data dir
+     *
+     * @param string $dataDir
+     */
+    protected static function tearDownAfterClassCleanStrayDataFiles($dataDir) {
+        $knownEntries = [
+            'nextcloud.log' => true,
+            'audit.log' => true,
+            'owncloud.db' => true,
+            '.ocdata' => true,
+            '..' => true,
+            '.' => true,
+        ];
+
+        if ($dh = opendir($dataDir)) {
+            while (($file = readdir($dh)) !== false) {
+                if (!isset($knownEntries[$file])) {
+                    self::tearDownAfterClassCleanStrayDataUnlinkDir($dataDir . '/' . $file);
+                }
+            }
+            closedir($dh);
+        }
+    }
+
+    /**
+     * Recursive delete files and folders from a given directory
+     *
+     * @param string $dir
+     */
+    protected static function tearDownAfterClassCleanStrayDataUnlinkDir($dir) {
+        if ($dh = @opendir($dir)) {
+            while (($file = readdir($dh)) !== false) {
+                if (Filesystem::isIgnoredDir($file)) {
+                    continue;
+                }
+                $path = $dir . '/' . $file;
+                if (is_dir($path)) {
+                    self::tearDownAfterClassCleanStrayDataUnlinkDir($path);
+                } else {
+                    @unlink($path);
+                }
+            }
+            closedir($dh);
+        }
+        @rmdir($dir);
+    }
+
+    /**
+     * Clean up the list of hooks
+     */
+    protected static function tearDownAfterClassCleanStrayHooks() {
+        \OC_Hook::clear();
+    }
+
+    /**
+     * Clean up the list of locks
+     */
+    protected static function tearDownAfterClassCleanStrayLocks() {
+        Server::get(ILockingProvider::class)->releaseAll();
+    }
+
+    /**
+     * Login and setup FS as a given user,
+     * sets the given user as the current user.
+     *
+     * @param string $user user id or empty for a generic FS
+     */
+    protected static function loginAsUser($user = '') {
+        self::logout();
+        Filesystem::tearDown();
+        \OC_User::setUserId($user);
+        $userObject = Server::get(IUserManager::class)->get($user);
+        if (!is_null($userObject)) {
+            $userObject->updateLastLoginTimestamp();
+        }
+        \OC_Util::setupFS($user);
+        if (Server::get(IUserManager::class)->userExists($user)) {
+            \OC::$server->getUserFolder($user);
+        }
+    }
+
+    /**
+     * Logout the current user and tear down the filesystem.
+     */
+    protected static function logout() {
+        \OC_Util::tearDownFS();
+        \OC_User::setUserId('');
+        // needed for fully logout
+        Server::get(IUserSession::class)->setUser(null);
+    }
+
+    /**
+     * Run all commands pushed to the bus
+     */
+    protected function runCommands() {
+        // get the user for which the fs is setup
+        $view = Filesystem::getView();
+        if ($view) {
+            [, $user] = explode('/', $view->getRoot());
+        } else {
+            $user = null;
+        }
+
+        \OC_Util::tearDownFS(); // command can't reply on the fs being setup
+        $this->commandBus->run();
+        \OC_Util::tearDownFS();
+
+        if ($user) {
+            \OC_Util::setupFS($user);
+        }
+    }
+
+    /**
+     * Check if the given path is locked with a given type
+     *
+     * @param View $view view
+     * @param string $path path to check
+     * @param int $type lock type
+     * @param bool $onMountPoint true to check the mount point instead of the
+     *                           mounted storage
+     *
+     * @return boolean true if the file is locked with the
+     *                 given type, false otherwise
+     */
+    protected function isFileLocked($view, $path, $type, $onMountPoint = false) {
+        // Note: this seems convoluted but is necessary because
+        // the format of the lock key depends on the storage implementation
+        // (in our case mostly md5)
+
+        if ($type === ILockingProvider::LOCK_SHARED) {
+            // to check if the file has a shared lock, try acquiring an exclusive lock
+            $checkType = ILockingProvider::LOCK_EXCLUSIVE;
+        } else {
+            // a shared lock cannot be set if exclusive lock is in place
+            $checkType = ILockingProvider::LOCK_SHARED;
+        }
+        try {
+            $view->lockFile($path, $checkType, $onMountPoint);
+            // no exception, which means the lock of $type is not set
+            // clean up
+            $view->unlockFile($path, $checkType, $onMountPoint);
+            return false;
+        } catch (LockedException $e) {
+            // we could not acquire the counter-lock, which means
+            // the lock of $type was in place
+            return true;
+        }
+    }
+
+    protected function getGroupAnnotations(): array {
+        if (method_exists($this, 'getAnnotations')) {
+            $annotations = $this->getAnnotations();
+            return $annotations['class']['group'] ?? [];
+        }
+
+        $r = new \ReflectionClass($this);
+        $doc = $r->getDocComment();
+
+        if (class_exists(Group::class)) {
+            $attributes = array_map(function (\ReflectionAttribute $attribute) {
+                /** @var Group $group */
+                $group = $attribute->newInstance();
+                return $group->name();
+            }, $r->getAttributes(Group::class));
+            if (count($attributes) > 0) {
+                return $attributes;
+            }
+        }
+        preg_match_all('#@group\s+(.*?)\n#s', $doc, $annotations);
+        return $annotations[1] ?? [];
+    }
+
+    protected function IsDatabaseAccessAllowed(): bool {
+        $annotations = $this->getGroupAnnotations();
+        if (isset($annotations)) {
+            if (in_array('DB', $annotations) || in_array('SLOWDB', $annotations)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * @param string $expectedHtml
+     * @param string $template
+     * @param array $vars
+     */
+    protected function assertTemplate($expectedHtml, $template, $vars = []) {
+        $requestToken = 12345;
+        /** @var Defaults|\PHPUnit\Framework\MockObject\MockObject $l10n */
+        $theme = $this->getMockBuilder('\OCP\Defaults')
+            ->disableOriginalConstructor()->getMock();
+        $theme->expects($this->any())
+            ->method('getName')
+            ->willReturn('Nextcloud');
+        /** @var IL10N|\PHPUnit\Framework\MockObject\MockObject $l10n */
+        $l10n = $this->getMockBuilder(IL10N::class)
+            ->disableOriginalConstructor()->getMock();
+        $l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($text, $parameters = []) {
+                return vsprintf($text, $parameters);
+            });
+
+        $t = new Base($template, $requestToken, $l10n, $theme);
+        $buf = $t->fetchPage($vars);
+        $this->assertHtmlStringEqualsHtmlString($expectedHtml, $buf);
+    }
+
+    /**
+     * @param string $expectedHtml
+     * @param string $actualHtml
+     * @param string $message
+     */
+    protected function assertHtmlStringEqualsHtmlString($expectedHtml, $actualHtml, $message = '') {
+        $expected = new DOMDocument();
+        $expected->preserveWhiteSpace = false;
+        $expected->formatOutput = true;
+        $expected->loadHTML($expectedHtml);
+
+        $actual = new DOMDocument();
+        $actual->preserveWhiteSpace = false;
+        $actual->formatOutput = true;
+        $actual->loadHTML($actualHtml);
+        $this->removeWhitespaces($actual);
+
+        $expectedHtml1 = $expected->saveHTML();
+        $actualHtml1 = $actual->saveHTML();
+        self::assertEquals($expectedHtml1, $actualHtml1, $message);
+    }
+
+
+    private function removeWhitespaces(DOMNode $domNode) {
+        foreach ($domNode->childNodes as $node) {
+            if ($node->hasChildNodes()) {
+                $this->removeWhitespaces($node);
+            } else {
+                if ($node instanceof \DOMText && $node->isWhitespaceInElementContent()) {
+                    $domNode->removeChild($node);
+                }
+            }
+        }
+    }
 }