Completed
Pull Request — master (#3869)
by Björn
21:04 queued 09:08
created
settings/templates/personal.php 1 patch
Spacing   +47 added lines, -47 removed lines patch added patch discarded remove patch
@@ -21,10 +21,10 @@  discard block
 block discarded – undo
21 21
 
22 22
 <div id="app-navigation">
23 23
 	<ul class="with-icon">
24
-	<?php foreach($_['forms'] as $form) {
24
+	<?php foreach ($_['forms'] as $form) {
25 25
 		if (isset($form['anchor'])) {
26
-			$anchor = '#' . $form['anchor'];
27
-			$class = 'nav-icon-' . $form['anchor'];
26
+			$anchor = '#'.$form['anchor'];
27
+			$class = 'nav-icon-'.$form['anchor'];
28 28
 			$sectionName = $form['section-name'];
29 29
 			print_unescaped(sprintf("<li><a href='%s' class='%s'>%s</a></li>", \OCP\Util::sanitizeHTML($anchor),
30 30
 			\OCP\Util::sanitizeHTML($class), \OCP\Util::sanitizeHTML($sectionName)));
@@ -36,11 +36,11 @@  discard block
 block discarded – undo
36 36
 <div id="app-content">
37 37
 
38 38
 <div id="quota" class="section">
39
-	<div style="width:<?php p($_['usage_relative']);?>%"
40
-		<?php if($_['usage_relative'] > 80): ?> class="quota-warning" <?php endif; ?>>
39
+	<div style="width:<?php p($_['usage_relative']); ?>%"
40
+		<?php if ($_['usage_relative'] > 80): ?> class="quota-warning" <?php endif; ?>>
41 41
 		<p id="quotatext">
42 42
 			<?php print_unescaped($l->t('You are using <strong>%s</strong> of <strong>%s</strong>',
43
-			array($_['usage'], $_['total_space'])));?>
43
+			array($_['usage'], $_['total_space']))); ?>
44 44
 		</p>
45 45
 	</div>
46 46
 </div>
@@ -85,11 +85,11 @@  discard block
 block discarded – undo
85 85
 				<span class="icon-password"/>
86 86
 			</h2>
87 87
 			<input type="text" id="displayname" name="displayname"
88
-				<?php if(!$_['displayNameChangeSupported']) { print_unescaped('class="hidden"'); } ?>
88
+				<?php if (!$_['displayNameChangeSupported']) { print_unescaped('class="hidden"'); } ?>
89 89
 				value="<?php p($_['displayName']) ?>"
90 90
 				autocomplete="on" autocapitalize="off" autocorrect="off" />
91
-			<?php if(!$_['displayNameChangeSupported']) { ?>
92
-				<span><?php if(isset($_['displayName']) && !empty($_['displayName'])) { p($_['displayName']); } else { p($l->t('No display name set')); } ?></span>
91
+			<?php if (!$_['displayNameChangeSupported']) { ?>
92
+				<span><?php if (isset($_['displayName']) && !empty($_['displayName'])) { p($_['displayName']); } else { p($l->t('No display name set')); } ?></span>
93 93
 			<?php } ?>
94 94
 			<span class="icon-checkmark hidden"/>
95 95
 			<input type="hidden" id="displaynamescope" value="<?php p($_['displayNameScope']) ?>">
@@ -103,13 +103,13 @@  discard block
 block discarded – undo
103 103
 			</h2>
104 104
 			<span class="verify" id="verify-email">Verify</span>
105 105
 			<input type="email" name="email" id="email" value="<?php p($_['email']); ?>"
106
-				<?php if(!$_['displayNameChangeSupported']) { print_unescaped('class="hidden"'); } ?>
106
+				<?php if (!$_['displayNameChangeSupported']) { print_unescaped('class="hidden"'); } ?>
107 107
 				placeholder="<?php p($l->t('Your email address')); ?>"
108 108
 				autocomplete="on" autocapitalize="off" autocorrect="off" />
109
-			<?php if(!$_['displayNameChangeSupported']) { ?>
110
-				<span><?php if(isset($_['email']) && !empty($_['email'])) { p($_['email']); } else { p($l->t('No email address set')); }?></span>
109
+			<?php if (!$_['displayNameChangeSupported']) { ?>
110
+				<span><?php if (isset($_['email']) && !empty($_['email'])) { p($_['email']); } else { p($l->t('No email address set')); }?></span>
111 111
 			<?php } ?>
112
-			<?php if($_['displayNameChangeSupported']) { ?>
112
+			<?php if ($_['displayNameChangeSupported']) { ?>
113 113
 				<br />
114 114
 				<em><?php p($l->t('For password reset and notifications')); ?></em>
115 115
 			<?php } ?>
@@ -187,19 +187,19 @@  discard block
 block discarded – undo
187 187
 </div>
188 188
 
189 189
 <?php
190
-if($_['passwordChangeSupported']) {
190
+if ($_['passwordChangeSupported']) {
191 191
 	script('jquery-showpassword');
192 192
 ?>
193 193
 <form id="passwordform" class="section">
194
-	<h2 class="inlineblock"><?php p($l->t('Password'));?></h2>
194
+	<h2 class="inlineblock"><?php p($l->t('Password')); ?></h2>
195 195
 	<div id="password-error-msg" class="msg success inlineblock" style="display: none;">Saved</div>
196 196
 	<br>
197 197
 	<label for="pass1" class="hidden-visually"><?php p($l->t('Current password')); ?>: </label>
198 198
 	<input type="password" id="pass1" name="oldpassword"
199
-		placeholder="<?php p($l->t('Current password'));?>"
199
+		placeholder="<?php p($l->t('Current password')); ?>"
200 200
 		autocomplete="off" autocapitalize="off" autocorrect="off" />
201 201
 	<div class="personal-show-container">
202
-		<label for="pass2" class="hidden-visually"><?php p($l->t('New password'));?>: </label>
202
+		<label for="pass2" class="hidden-visually"><?php p($l->t('New password')); ?>: </label>
203 203
 		<input type="password" id="pass2" name="newpassword"
204 204
 			placeholder="<?php p($l->t('New password')); ?>"
205 205
 			data-typetoggle="#personal-show"
@@ -215,44 +215,44 @@  discard block
 block discarded – undo
215 215
 
216 216
 <form id="language" class="section">
217 217
 	<h2>
218
-		<label for="languageinput"><?php p($l->t('Language'));?></label>
218
+		<label for="languageinput"><?php p($l->t('Language')); ?></label>
219 219
 	</h2>
220
-	<select id="languageinput" name="lang" data-placeholder="<?php p($l->t('Language'));?>">
221
-		<option value="<?php p($_['activelanguage']['code']);?>">
222
-			<?php p($_['activelanguage']['name']);?>
220
+	<select id="languageinput" name="lang" data-placeholder="<?php p($l->t('Language')); ?>">
221
+		<option value="<?php p($_['activelanguage']['code']); ?>">
222
+			<?php p($_['activelanguage']['name']); ?>
223 223
 		</option>
224
-		<?php foreach($_['commonlanguages'] as $language):?>
225
-			<option value="<?php p($language['code']);?>">
226
-				<?php p($language['name']);?>
224
+		<?php foreach ($_['commonlanguages'] as $language):?>
225
+			<option value="<?php p($language['code']); ?>">
226
+				<?php p($language['name']); ?>
227 227
 			</option>
228
-		<?php endforeach;?>
228
+		<?php endforeach; ?>
229 229
 		<optgroup label="––––––––––"></optgroup>
230
-		<?php foreach($_['languages'] as $language):?>
231
-			<option value="<?php p($language['code']);?>">
232
-				<?php p($language['name']);?>
230
+		<?php foreach ($_['languages'] as $language):?>
231
+			<option value="<?php p($language['code']); ?>">
232
+				<?php p($language['name']); ?>
233 233
 			</option>
234
-		<?php endforeach;?>
234
+		<?php endforeach; ?>
235 235
 	</select>
236 236
 	<a href="https://www.transifex.com/nextcloud/nextcloud/"
237 237
 		target="_blank" rel="noreferrer">
238
-		<em><?php p($l->t('Help translate'));?></em>
238
+		<em><?php p($l->t('Help translate')); ?></em>
239 239
 	</a>
240 240
 </form>
241 241
 
242 242
 
243 243
 <div id="clientsbox" class="section clientsbox">
244
-	<h2><?php p($l->t('Get the apps to sync your files'));?></h2>
244
+	<h2><?php p($l->t('Get the apps to sync your files')); ?></h2>
245 245
 	<a href="<?php p($_['clients']['desktop']); ?>" rel="noreferrer" target="_blank">
246 246
 		<img src="<?php print_unescaped(image_path('core', 'desktopapp.svg')); ?>"
247
-			 alt="<?php p($l->t('Desktop client'));?>" />
247
+			 alt="<?php p($l->t('Desktop client')); ?>" />
248 248
 	</a>
249 249
 	<a href="<?php p($_['clients']['android']); ?>" rel="noreferrer" target="_blank">
250 250
 		<img src="<?php print_unescaped(image_path('core', 'googleplay.png')); ?>"
251
-			 alt="<?php p($l->t('Android app'));?>" />
251
+			 alt="<?php p($l->t('Android app')); ?>" />
252 252
 	</a>
253 253
 	<a href="<?php p($_['clients']['ios']); ?>" rel="noreferrer" target="_blank">
254 254
 		<img src="<?php print_unescaped(image_path('core', 'appstore.svg')); ?>"
255
-			 alt="<?php p($l->t('iOS app'));?>" />
255
+			 alt="<?php p($l->t('iOS app')); ?>" />
256 256
 	</a>
257 257
 
258 258
 		<p>
@@ -268,19 +268,19 @@  discard block
 block discarded – undo
268 268
 				$l->t('If you want to support the project {contributeopen}join development{linkclose} or {contributeopen}spread the word{linkclose}!'))); ?>
269 269
 		</p>
270 270
 
271
-	<?php if(OC_APP::isEnabled('firstrunwizard')) {?>
272
-		<p><a class="button" href="#" id="showWizard"><?php p($l->t('Show First Run Wizard again'));?></a></p>
271
+	<?php if (OC_APP::isEnabled('firstrunwizard')) {?>
272
+		<p><a class="button" href="#" id="showWizard"><?php p($l->t('Show First Run Wizard again')); ?></a></p>
273 273
 	<?php }?>
274 274
 </div>
275 275
 
276 276
 <div id="sessions" class="section">
277
-	<h2><?php p($l->t('Sessions'));?></h2>
278
-	<span class="hidden-when-empty"><?php p($l->t('Web, desktop and mobile clients currently logged in to your account.'));?></span>
277
+	<h2><?php p($l->t('Sessions')); ?></h2>
278
+	<span class="hidden-when-empty"><?php p($l->t('Web, desktop and mobile clients currently logged in to your account.')); ?></span>
279 279
 	<table class="icon-loading">
280 280
 		<thead class="token-list-header">
281 281
 			<tr>
282
-				<th><?php p($l->t('Device'));?></th>
283
-				<th><?php p($l->t('Last activity'));?></th>
282
+				<th><?php p($l->t('Device')); ?></th>
283
+				<th><?php p($l->t('Last activity')); ?></th>
284 284
 				<th></th>
285 285
 			</tr>
286 286
 		</thead>
@@ -290,13 +290,13 @@  discard block
 block discarded – undo
290 290
 </div>
291 291
 
292 292
 <div id="apppasswords" class="section">
293
-	<h2><?php p($l->t('App passwords'));?></h2>
294
-	<p><?php p($l->t('Passcodes that give an app or device permissions to access your account.'));?></p>
293
+	<h2><?php p($l->t('App passwords')); ?></h2>
294
+	<p><?php p($l->t('Passcodes that give an app or device permissions to access your account.')); ?></p>
295 295
 	<table class="icon-loading">
296 296
 		<thead class="hidden-when-empty">
297 297
 			<tr>
298
-				<th><?php p($l->t('Name'));?></th>
299
-				<th><?php p($l->t('Last activity'));?></th>
298
+				<th><?php p($l->t('Name')); ?></th>
299
+				<th><?php p($l->t('Last activity')); ?></th>
300 300
 				<th></th>
301 301
 			</tr>
302 302
 		</thead>
@@ -325,14 +325,14 @@  discard block
 block discarded – undo
325 325
 	</div>
326 326
 </div>
327 327
 
328
-<?php foreach($_['forms'] as $form) {
328
+<?php foreach ($_['forms'] as $form) {
329 329
 	if (isset($form['form'])) {?>
330
-	<div id="<?php isset($form['anchor']) ? p($form['anchor']) : p('');?>"><?php print_unescaped($form['form']);?></div>
330
+	<div id="<?php isset($form['anchor']) ? p($form['anchor']) : p(''); ?>"><?php print_unescaped($form['form']); ?></div>
331 331
 	<?php }
332 332
 };?>
333 333
 
334 334
 <div class="section">
335
-	<h2><?php p($l->t('Version'));?></h2>
335
+	<h2><?php p($l->t('Version')); ?></h2>
336 336
 	<p><a href="<?php print_unescaped($theme->getBaseUrl()); ?>" target="_blank"><?php p($theme->getTitle()); ?></a> <?php p(OC_Util::getHumanVersion()) ?></p>
337 337
 	<p><?php include('settings.development.notice.php'); ?></p>
338 338
 </div>
Please login to merge, or discard this patch.
apps/lookup_server_connector/lib/UpdateLookupServer.php 1 patch
Indentation   +90 added lines, -90 removed lines patch added patch discarded remove patch
@@ -35,102 +35,102 @@
 block discarded – undo
35 35
  * @package OCA\LookupServerConnector
36 36
  */
37 37
 class UpdateLookupServer {
38
-	/** @var AccountManager */
39
-	private $accountManager;
40
-	/** @var IClientService */
41
-	private $clientService;
42
-	/** @var Signer */
43
-	private $signer;
44
-	/** @var IJobList */
45
-	private $jobList;
46
-	/** @var string URL point to lookup server */
47
-	private $lookupServer = 'https://lookup.nextcloud.com';
38
+    /** @var AccountManager */
39
+    private $accountManager;
40
+    /** @var IClientService */
41
+    private $clientService;
42
+    /** @var Signer */
43
+    private $signer;
44
+    /** @var IJobList */
45
+    private $jobList;
46
+    /** @var string URL point to lookup server */
47
+    private $lookupServer = 'https://lookup.nextcloud.com';
48 48
 
49
-	/**
50
-	 * @param AccountManager $accountManager
51
-	 * @param IClientService $clientService
52
-	 * @param Signer $signer
53
-	 * @param IJobList $jobList
54
-	 * @param string $lookupServer if nothing is given we use the default lookup server
55
-	 */
56
-	public function __construct(AccountManager $accountManager,
57
-								IClientService $clientService,
58
-								Signer $signer,
59
-								IJobList $jobList,
60
-								$lookupServer = '') {
61
-		$this->accountManager = $accountManager;
62
-		$this->clientService = $clientService;
63
-		$this->signer = $signer;
64
-		$this->jobList = $jobList;
65
-		if ($lookupServer !== '') {
66
-			$this->lookupServer = $lookupServer;
67
-		}
68
-		$this->lookupServer = rtrim($this->lookupServer, '/');
69
-		$this->lookupServer .= '/users';
70
-	}
49
+    /**
50
+     * @param AccountManager $accountManager
51
+     * @param IClientService $clientService
52
+     * @param Signer $signer
53
+     * @param IJobList $jobList
54
+     * @param string $lookupServer if nothing is given we use the default lookup server
55
+     */
56
+    public function __construct(AccountManager $accountManager,
57
+                                IClientService $clientService,
58
+                                Signer $signer,
59
+                                IJobList $jobList,
60
+                                $lookupServer = '') {
61
+        $this->accountManager = $accountManager;
62
+        $this->clientService = $clientService;
63
+        $this->signer = $signer;
64
+        $this->jobList = $jobList;
65
+        if ($lookupServer !== '') {
66
+            $this->lookupServer = $lookupServer;
67
+        }
68
+        $this->lookupServer = rtrim($this->lookupServer, '/');
69
+        $this->lookupServer .= '/users';
70
+    }
71 71
 
72
-	/**
73
-	 * @param IUser $user
74
-	 */
75
-	public function userUpdated(IUser $user) {
76
-		$userData = $this->accountManager->getUser($user);
77
-		$publicData = [];
72
+    /**
73
+     * @param IUser $user
74
+     */
75
+    public function userUpdated(IUser $user) {
76
+        $userData = $this->accountManager->getUser($user);
77
+        $publicData = [];
78 78
 
79
-		foreach ($userData as $key => $data) {
80
-			if ($data['scope'] === AccountManager::VISIBILITY_PUBLIC) {
81
-				$publicData[$key] = $data;
82
-			}
83
-		}
79
+        foreach ($userData as $key => $data) {
80
+            if ($data['scope'] === AccountManager::VISIBILITY_PUBLIC) {
81
+                $publicData[$key] = $data;
82
+            }
83
+        }
84 84
 
85
-		$this->sendToLookupServer($user, $publicData);
86
-	}
85
+        $this->sendToLookupServer($user, $publicData);
86
+    }
87 87
 
88
-	/**
89
-	 * send public user data to the lookup server
90
-	 *
91
-	 * @param IUser $user
92
-	 * @param array $publicData
93
-	 */
94
-	protected function sendToLookupServer(IUser $user, array $publicData) {
88
+    /**
89
+     * send public user data to the lookup server
90
+     *
91
+     * @param IUser $user
92
+     * @param array $publicData
93
+     */
94
+    protected function sendToLookupServer(IUser $user, array $publicData) {
95 95
 
96
-		$dataArray = ['federationId' => $user->getCloudId()];
96
+        $dataArray = ['federationId' => $user->getCloudId()];
97 97
 
98
-		if (!empty($publicData)) {
99
-			$dataArray['name'] = isset($publicData[AccountManager::PROPERTY_DISPLAYNAME]) ? $publicData[AccountManager::PROPERTY_DISPLAYNAME]['value'] : '';
100
-			$dataArray['email'] = isset($publicData[AccountManager::PROPERTY_EMAIL]) ? $publicData[AccountManager::PROPERTY_EMAIL]['value'] : '';
101
-			$dataArray['address'] = isset($publicData[AccountManager::PROPERTY_ADDRESS]) ? $publicData[AccountManager::PROPERTY_ADDRESS]['value'] : '';
102
-			$dataArray['website'] = isset($publicData[AccountManager::PROPERTY_WEBSITE]) ? $publicData[AccountManager::PROPERTY_WEBSITE]['value'] : '';
103
-			$dataArray['twitter'] = isset($publicData[AccountManager::PROPERTY_TWITTER]) ? $publicData[AccountManager::PROPERTY_TWITTER]['value'] : '';
104
-			$dataArray['phone'] = isset($publicData[AccountManager::PROPERTY_PHONE]) ? $publicData[AccountManager::PROPERTY_PHONE]['value'] : '';
105
-		}
98
+        if (!empty($publicData)) {
99
+            $dataArray['name'] = isset($publicData[AccountManager::PROPERTY_DISPLAYNAME]) ? $publicData[AccountManager::PROPERTY_DISPLAYNAME]['value'] : '';
100
+            $dataArray['email'] = isset($publicData[AccountManager::PROPERTY_EMAIL]) ? $publicData[AccountManager::PROPERTY_EMAIL]['value'] : '';
101
+            $dataArray['address'] = isset($publicData[AccountManager::PROPERTY_ADDRESS]) ? $publicData[AccountManager::PROPERTY_ADDRESS]['value'] : '';
102
+            $dataArray['website'] = isset($publicData[AccountManager::PROPERTY_WEBSITE]) ? $publicData[AccountManager::PROPERTY_WEBSITE]['value'] : '';
103
+            $dataArray['twitter'] = isset($publicData[AccountManager::PROPERTY_TWITTER]) ? $publicData[AccountManager::PROPERTY_TWITTER]['value'] : '';
104
+            $dataArray['phone'] = isset($publicData[AccountManager::PROPERTY_PHONE]) ? $publicData[AccountManager::PROPERTY_PHONE]['value'] : '';
105
+        }
106 106
 
107
-		$dataArray = $this->signer->sign('lookupserver', $dataArray, $user);
108
-		$httpClient = $this->clientService->newClient();
109
-		try {
110
-			if (empty($publicData)) {
111
-				$httpClient->delete($this->lookupServer,
112
-					[
113
-						'body' => json_encode($dataArray),
114
-						'timeout' => 10,
115
-						'connect_timeout' => 3,
116
-					]
117
-				);
118
-			} else {
119
-				$httpClient->post($this->lookupServer,
120
-					[
121
-						'body' => json_encode($dataArray),
122
-						'timeout' => 10,
123
-						'connect_timeout' => 3,
124
-					]
125
-				);
126
-			}
127
-		} catch (\Exception $e) {
128
-			$this->jobList->add(RetryJob::class,
129
-				[
130
-					'dataArray' => $dataArray,
131
-					'retryNo' => 0,
132
-				]
133
-			);
134
-		}
135
-	}
107
+        $dataArray = $this->signer->sign('lookupserver', $dataArray, $user);
108
+        $httpClient = $this->clientService->newClient();
109
+        try {
110
+            if (empty($publicData)) {
111
+                $httpClient->delete($this->lookupServer,
112
+                    [
113
+                        'body' => json_encode($dataArray),
114
+                        'timeout' => 10,
115
+                        'connect_timeout' => 3,
116
+                    ]
117
+                );
118
+            } else {
119
+                $httpClient->post($this->lookupServer,
120
+                    [
121
+                        'body' => json_encode($dataArray),
122
+                        'timeout' => 10,
123
+                        'connect_timeout' => 3,
124
+                    ]
125
+                );
126
+            }
127
+        } catch (\Exception $e) {
128
+            $this->jobList->add(RetryJob::class,
129
+                [
130
+                    'dataArray' => $dataArray,
131
+                    'retryNo' => 0,
132
+                ]
133
+            );
134
+        }
135
+    }
136 136
 }
Please login to merge, or discard this patch.
apps/lookup_server_connector/appinfo/app.php 1 patch
Indentation   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -22,26 +22,26 @@
 block discarded – undo
22 22
 $dispatcher = \OC::$server->getEventDispatcher();
23 23
 
24 24
 $dispatcher->addListener('OC\AccountManager::userUpdated', function(\Symfony\Component\EventDispatcher\GenericEvent $event) {
25
-	$user = $event->getSubject();
25
+    $user = $event->getSubject();
26 26
 
27
-	$keyManager = new \OC\Security\IdentityProof\Manager(
28
-		\OC::$server->getAppDataDir('identityproof'),
29
-		\OC::$server->getCrypto()
30
-	);
27
+    $keyManager = new \OC\Security\IdentityProof\Manager(
28
+        \OC::$server->getAppDataDir('identityproof'),
29
+        \OC::$server->getCrypto()
30
+    );
31 31
 
32
-	$config = \OC::$server->getConfig();
33
-	$lookupServer = $config->getSystemValue('lookup_server', '');
32
+    $config = \OC::$server->getConfig();
33
+    $lookupServer = $config->getSystemValue('lookup_server', '');
34 34
 
35
-	$updateLookupServer = new \OCA\LookupServerConnector\UpdateLookupServer(
36
-		new \OC\Accounts\AccountManager(\OC::$server->getDatabaseConnection(), \OC::$server->getEventDispatcher()),
37
-		\OC::$server->getHTTPClientService(),
38
-		new \OC\Security\IdentityProof\Signer(
39
-			$keyManager,
40
-			new \OC\AppFramework\Utility\TimeFactory(),
41
-			\OC::$server->getUserManager()
42
-		),
43
-		\OC::$server->getJobList(),
44
-		$lookupServer
45
-	);
46
-	$updateLookupServer->userUpdated($user);
35
+    $updateLookupServer = new \OCA\LookupServerConnector\UpdateLookupServer(
36
+        new \OC\Accounts\AccountManager(\OC::$server->getDatabaseConnection(), \OC::$server->getEventDispatcher()),
37
+        \OC::$server->getHTTPClientService(),
38
+        new \OC\Security\IdentityProof\Signer(
39
+            $keyManager,
40
+            new \OC\AppFramework\Utility\TimeFactory(),
41
+            \OC::$server->getUserManager()
42
+        ),
43
+        \OC::$server->getJobList(),
44
+        $lookupServer
45
+    );
46
+    $updateLookupServer->userUpdated($user);
47 47
 });
Please login to merge, or discard this patch.