nextcloud / server

apps/updatenotification/lib/Notification/Notifier.php

Indentation +137 added lines, -137 removed lines

@@ -36,141 +36,141 @@
 
 class Notifier implements INotifier {
 
-	/** @var IURLGenerator */
-	protected $url;
-
-	/** @var IConfig */
-	protected $config;
-
-	/** @var IManager */
-	protected $notificationManager;
-
-	/** @var IFactory */
-	protected $l10NFactory;
-
-	/** @var IUserSession */
-	protected $userSession;
-
-	/** @var IGroupManager */
-	protected $groupManager;
-
-	/** @var string[] */
-	protected $appVersions;
-
-	/**
-	 * Notifier constructor.
-	 *
-	 * @param IURLGenerator $url
-	 * @param IConfig $config
-	 * @param IManager $notificationManager
-	 * @param IFactory $l10NFactory
-	 * @param IUserSession $userSession
-	 * @param IGroupManager $groupManager
-	 */
-	public function __construct(IURLGenerator $url, IConfig $config, IManager $notificationManager, IFactory $l10NFactory, IUserSession $userSession, IGroupManager $groupManager) {
-		$this->url = $url;
-		$this->notificationManager = $notificationManager;
-		$this->config = $config;
-		$this->l10NFactory = $l10NFactory;
-		$this->userSession = $userSession;
-		$this->groupManager = $groupManager;
-		$this->appVersions = $this->getAppVersions();
-	}
-
-	/**
-	 * @param INotification $notification
-	 * @param string $languageCode The code of the language that should be used to prepare the notification
-	 * @return INotification
-	 * @throws \InvalidArgumentException When the notification was not prepared by a notifier
-	 * @since 9.0.0
-	 */
-	public function prepare(INotification $notification, $languageCode) {
-		if ($notification->getApp() !== 'updatenotification') {
-			throw new \InvalidArgumentException();
-		}
-
-		$l = $this->l10NFactory->get('updatenotification', $languageCode);
-		if ($notification->getSubject() === 'connection_error') {
-			$errors = (int) $this->config->getAppValue('updatenotification', 'update_check_errors', 0);
-			if ($errors === 0) {
-				$this->notificationManager->markProcessed($notification);
-				throw new \InvalidArgumentException();
-			}
-
-			$notification->setParsedSubject($l->t('The update server could not be reached since %d days to check for new updates.', [$errors]))
-				->setParsedMessage($l->t('Please check the nextcloud and server log files for errors.'));
-		} elseif ($notification->getObjectType() === 'core') {
-			$this->updateAlreadyInstalledCheck($notification, $this->getCoreVersions());
-
-			$parameters = $notification->getSubjectParameters();
-			$notification->setParsedSubject($l->t('Update to %1$s is available.', [$parameters['version']]));
-
-			if ($this->isAdmin()) {
-				$notification->setLink($this->url->linkToRouteAbsolute('settings.AdminSettings.index') . '#updater');
-			}
-		} else {
-			$appInfo = $this->getAppInfo($notification->getObjectType());
-			$appName = ($appInfo === null) ? $notification->getObjectType() : $appInfo['name'];
-
-			if (isset($this->appVersions[$notification->getObjectType()])) {
-				$this->updateAlreadyInstalledCheck($notification, $this->appVersions[$notification->getObjectType()]);
-			}
-
-			$notification->setParsedSubject($l->t('Update for %1$s to version %2$s is available.', [$appName, $notification->getObjectId()]))
-				->setRichSubject($l->t('Update for {app} to version %s is available.', $notification->getObjectId()), [
-					'app' => [
-						'type' => 'app',
-						'id' => $notification->getObjectType(),
-						'name' => $appName,
-					]
-				]);
-
-			if ($this->isAdmin()) {
-				$notification->setLink($this->url->linkToRouteAbsolute('settings.AppSettings.viewApps') . '#app-' . $notification->getObjectType());
-			}
-		}
-
-		$notification->setIcon($this->url->getAbsoluteURL($this->url->imagePath('updatenotification', 'notification.svg')));
-
-		return $notification;
-	}
-
-	/**
-	 * Remove the notification and prevent rendering, when the update is installed
-	 *
-	 * @param INotification $notification
-	 * @param string $installedVersion
-	 * @throws \InvalidArgumentException When the update is already installed
-	 */
-	protected function updateAlreadyInstalledCheck(INotification $notification, $installedVersion) {
-		if (version_compare($notification->getObjectId(), $installedVersion, '<=')) {
-			$this->notificationManager->markProcessed($notification);
-			throw new \InvalidArgumentException();
-		}
-	}
-
-	/**
-	 * @return bool
-	 */
-	protected function isAdmin() {
-		$user = $this->userSession->getUser();
-
-		if ($user instanceof IUser) {
-			return $this->groupManager->isAdmin($user->getUID());
-		}
-
-		return false;
-	}
-
-	protected function getCoreVersions() {
-		return implode('.', \OCP\Util::getVersion());
-	}
-
-	protected function getAppVersions() {
-		return \OC_App::getAppVersions();
-	}
-
-	protected function getAppInfo($appId) {
-		return \OC_App::getAppInfo($appId);
-	}
+    /** @var IURLGenerator */
+    protected $url;
+
+    /** @var IConfig */
+    protected $config;
+
+    /** @var IManager */
+    protected $notificationManager;
+
+    /** @var IFactory */
+    protected $l10NFactory;
+
+    /** @var IUserSession */
+    protected $userSession;
+
+    /** @var IGroupManager */
+    protected $groupManager;
+
+    /** @var string[] */
+    protected $appVersions;
+
+    /**
+     * Notifier constructor.
+     *
+     * @param IURLGenerator $url
+     * @param IConfig $config
+     * @param IManager $notificationManager
+     * @param IFactory $l10NFactory
+     * @param IUserSession $userSession
+     * @param IGroupManager $groupManager
+     */
+    public function __construct(IURLGenerator $url, IConfig $config, IManager $notificationManager, IFactory $l10NFactory, IUserSession $userSession, IGroupManager $groupManager) {
+        $this->url = $url;
+        $this->notificationManager = $notificationManager;
+        $this->config = $config;
+        $this->l10NFactory = $l10NFactory;
+        $this->userSession = $userSession;
+        $this->groupManager = $groupManager;
+        $this->appVersions = $this->getAppVersions();
+    }
+
+    /**
+     * @param INotification $notification
+     * @param string $languageCode The code of the language that should be used to prepare the notification
+     * @return INotification
+     * @throws \InvalidArgumentException When the notification was not prepared by a notifier
+     * @since 9.0.0
+     */
+    public function prepare(INotification $notification, $languageCode) {
+        if ($notification->getApp() !== 'updatenotification') {
+            throw new \InvalidArgumentException();
+        }
+
+        $l = $this->l10NFactory->get('updatenotification', $languageCode);
+        if ($notification->getSubject() === 'connection_error') {
+            $errors = (int) $this->config->getAppValue('updatenotification', 'update_check_errors', 0);
+            if ($errors === 0) {
+                $this->notificationManager->markProcessed($notification);
+                throw new \InvalidArgumentException();
+            }
+
+            $notification->setParsedSubject($l->t('The update server could not be reached since %d days to check for new updates.', [$errors]))
+                ->setParsedMessage($l->t('Please check the nextcloud and server log files for errors.'));
+        } elseif ($notification->getObjectType() === 'core') {
+            $this->updateAlreadyInstalledCheck($notification, $this->getCoreVersions());
+
+            $parameters = $notification->getSubjectParameters();
+            $notification->setParsedSubject($l->t('Update to %1$s is available.', [$parameters['version']]));
+
+            if ($this->isAdmin()) {
+                $notification->setLink($this->url->linkToRouteAbsolute('settings.AdminSettings.index') . '#updater');
+            }
+        } else {
+            $appInfo = $this->getAppInfo($notification->getObjectType());
+            $appName = ($appInfo === null) ? $notification->getObjectType() : $appInfo['name'];
+
+            if (isset($this->appVersions[$notification->getObjectType()])) {
+                $this->updateAlreadyInstalledCheck($notification, $this->appVersions[$notification->getObjectType()]);
+            }
+
+            $notification->setParsedSubject($l->t('Update for %1$s to version %2$s is available.', [$appName, $notification->getObjectId()]))
+                ->setRichSubject($l->t('Update for {app} to version %s is available.', $notification->getObjectId()), [
+                    'app' => [
+                        'type' => 'app',
+                        'id' => $notification->getObjectType(),
+                        'name' => $appName,
+                    ]
+                ]);
+
+            if ($this->isAdmin()) {
+                $notification->setLink($this->url->linkToRouteAbsolute('settings.AppSettings.viewApps') . '#app-' . $notification->getObjectType());
+            }
+        }
+
+        $notification->setIcon($this->url->getAbsoluteURL($this->url->imagePath('updatenotification', 'notification.svg')));
+
+        return $notification;
+    }
+
+    /**
+     * Remove the notification and prevent rendering, when the update is installed
+     *
+     * @param INotification $notification
+     * @param string $installedVersion
+     * @throws \InvalidArgumentException When the update is already installed
+     */
+    protected function updateAlreadyInstalledCheck(INotification $notification, $installedVersion) {
+        if (version_compare($notification->getObjectId(), $installedVersion, '<=')) {
+            $this->notificationManager->markProcessed($notification);
+            throw new \InvalidArgumentException();
+        }
+    }
+
+    /**
+     * @return bool
+     */
+    protected function isAdmin() {
+        $user = $this->userSession->getUser();
+
+        if ($user instanceof IUser) {
+            return $this->groupManager->isAdmin($user->getUID());
+        }
+
+        return false;
+    }
+
+    protected function getCoreVersions() {
+        return implode('.', \OCP\Util::getVersion());
+    }
+
+    protected function getAppVersions() {
+        return \OC_App::getAppVersions();
+    }
+
+    protected function getAppInfo($appId) {
+        return \OC_App::getAppInfo($appId);
+    }
 }

apps/updatenotification/lib/Notification/BackgroundJob.php

Indentation +221 added lines, -221 removed lines

@@ -34,225 +34,225 @@
 
 class BackgroundJob extends TimedJob {
 
-	protected $connectionNotifications = [3, 7, 14, 30];
-
-	/** @var IConfig */
-	protected $config;
-
-	/** @var IManager */
-	protected $notificationManager;
-
-	/** @var IGroupManager */
-	protected $groupManager;
-
-	/** @var IAppManager */
-	protected $appManager;
-
-	/** @var IClientService */
-	protected $client;
-
-	/** @var string[] */
-	protected $users;
-
-	/**
-	 * NotificationBackgroundJob constructor.
-	 *
-	 * @param IConfig $config
-	 * @param IManager $notificationManager
-	 * @param IGroupManager $groupManager
-	 * @param IAppManager $appManager
-	 * @param IClientService $client
-	 */
-	public function __construct(IConfig $config, IManager $notificationManager, IGroupManager $groupManager, IAppManager $appManager, IClientService $client) {
-		// Run once a day
-		$this->setInterval(60 * 60 * 24);
-
-		$this->config = $config;
-		$this->notificationManager = $notificationManager;
-		$this->groupManager = $groupManager;
-		$this->appManager = $appManager;
-		$this->client = $client;
-	}
-
-	protected function run($argument) {
-		$this->checkCoreUpdate();
-		$this->checkAppUpdates();
-	}
-
-	/**
-	 * Check for ownCloud update
-	 */
-	protected function checkCoreUpdate() {
-		if (in_array($this->getChannel(), ['daily', 'git'], true)) {
-			// "These aren't the update channels you're looking for." - Ben Obi-Wan Kenobi
-			return;
-		}
-
-		$updater = $this->createVersionCheck();
-
-		$status = $updater->check();
-		if ($status === false) {
-			$errors = 1 + (int) $this->config->getAppValue('updatenotification', 'update_check_errors', 0);
-			$this->config->setAppValue('updatenotification', 'update_check_errors', $errors);
-
-			if (in_array($errors, $this->connectionNotifications, true)) {
-				$this->sendErrorNotifications($errors);
-			}
-		} else if (isset($status['version'])) {
-			$this->config->setAppValue('updatenotification', 'update_check_errors', 0);
-			$this->clearErrorNotifications();
-
-			$this->createNotifications('core', $status['version'], $status['versionstring']);
-		}
-	}
-
-	/**
-	 * Send a message to the admin when the update server could not be reached
-	 * @param int $numDays
-	 */
-	protected function sendErrorNotifications($numDays) {
-		$this->clearErrorNotifications();
-
-		$notification = $this->notificationManager->createNotification();
-		try {
-			$notification->setApp('updatenotification')
-				->setDateTime(new \DateTime())
-				->setObject('updatenotification', 'error')
-				->setSubject('connection_error', ['days' => $numDays]);
-
-			foreach ($this->getUsersToNotify() as $uid) {
-				$notification->setUser($uid);
-				$this->notificationManager->notify($notification);
-			}
-		} catch (\InvalidArgumentException $e) {
-			return;
-		}
-	}
-
-	/**
-	 * Remove error notifications again
-	 */
-	protected function clearErrorNotifications() {
-		$notification = $this->notificationManager->createNotification();
-		try {
-			$notification->setApp('updatenotification')
-				->setSubject('connection_error')
-				->setObject('updatenotification', 'error');
-		} catch (\InvalidArgumentException $e) {
-			return;
-		}
-		$this->notificationManager->markProcessed($notification);
-	}
-
-	/**
-	 * Check all installed apps for updates
-	 */
-	protected function checkAppUpdates() {
-		$apps = $this->appManager->getInstalledApps();
-		foreach ($apps as $app) {
-			$update = $this->isUpdateAvailable($app);
-			if ($update !== false) {
-				$this->createNotifications($app, $update);
-			}
-		}
-	}
-
-	/**
-	 * Create notifications for this app version
-	 *
-	 * @param string $app
-	 * @param string $version
-	 * @param string $visibleVersion
-	 */
-	protected function createNotifications($app, $version, $visibleVersion = '') {
-		$lastNotification = $this->config->getAppValue('updatenotification', $app, false);
-		if ($lastNotification === $version) {
-			// We already notified about this update
-			return;
-		} else if ($lastNotification !== false) {
-			// Delete old updates
-			$this->deleteOutdatedNotifications($app, $lastNotification);
-		}
-
-
-		$notification = $this->notificationManager->createNotification();
-		$notification->setApp('updatenotification')
-			->setDateTime(new \DateTime())
-			->setObject($app, $version);
-
-		if ($visibleVersion !== '') {
-			$notification->setSubject('update_available', ['version' => $visibleVersion]);
-		} else {
-			$notification->setSubject('update_available');
-		}
-
-		foreach ($this->getUsersToNotify() as $uid) {
-			$notification->setUser($uid);
-			$this->notificationManager->notify($notification);
-		}
-
-		$this->config->setAppValue('updatenotification', $app, $version);
-	}
-
-	/**
-	 * @return string[]
-	 */
-	protected function getUsersToNotify() {
-		if ($this->users !== null) {
-			return $this->users;
-		}
-
-		$notifyGroups = json_decode($this->config->getAppValue('updatenotification', 'notify_groups', '["admin"]'), true);
-		$this->users = [];
-		foreach ($notifyGroups as $group) {
-			$groupToNotify = $this->groupManager->get($group);
-			if ($groupToNotify instanceof IGroup) {
-				foreach ($groupToNotify->getUsers() as $user) {
-					$this->users[$user->getUID()] = true;
-				}
-			}
-		}
-
-		$this->users = array_keys($this->users);
-
-		return $this->users;
-	}
-
-	/**
-	 * Delete notifications for old updates
-	 *
-	 * @param string $app
-	 * @param string $version
-	 */
-	protected function deleteOutdatedNotifications($app, $version) {
-		$notification = $this->notificationManager->createNotification();
-		$notification->setApp('updatenotification')
-			->setObject($app, $version);
-		$this->notificationManager->markProcessed($notification);
-	}
-
-	/**
-	 * @return VersionCheck
-	 */
-	protected function createVersionCheck() {
-		return new VersionCheck(
-			$this->client,
-			$this->config
-		);
-	}
-
-	/**
-	 * @return string
-	 */
-	protected function getChannel() {
-		return \OC_Util::getChannel();
-	}
-
-	/**
-	 * @param string $app
-	 * @return string|false
-	 */
-	protected function isUpdateAvailable($app) {
-		return Installer::isUpdateAvailable($app, \OC::$server->getAppFetcher());
-	}
+    protected $connectionNotifications = [3, 7, 14, 30];
+
+    /** @var IConfig */
+    protected $config;
+
+    /** @var IManager */
+    protected $notificationManager;
+
+    /** @var IGroupManager */
+    protected $groupManager;
+
+    /** @var IAppManager */
+    protected $appManager;
+
+    /** @var IClientService */
+    protected $client;
+
+    /** @var string[] */
+    protected $users;
+
+    /**
+     * NotificationBackgroundJob constructor.
+     *
+     * @param IConfig $config
+     * @param IManager $notificationManager
+     * @param IGroupManager $groupManager
+     * @param IAppManager $appManager
+     * @param IClientService $client
+     */
+    public function __construct(IConfig $config, IManager $notificationManager, IGroupManager $groupManager, IAppManager $appManager, IClientService $client) {
+        // Run once a day
+        $this->setInterval(60 * 60 * 24);
+
+        $this->config = $config;
+        $this->notificationManager = $notificationManager;
+        $this->groupManager = $groupManager;
+        $this->appManager = $appManager;
+        $this->client = $client;
+    }
+
+    protected function run($argument) {
+        $this->checkCoreUpdate();
+        $this->checkAppUpdates();
+    }
+
+    /**
+     * Check for ownCloud update
+     */
+    protected function checkCoreUpdate() {
+        if (in_array($this->getChannel(), ['daily', 'git'], true)) {
+            // "These aren't the update channels you're looking for." - Ben Obi-Wan Kenobi
+            return;
+        }
+
+        $updater = $this->createVersionCheck();
+
+        $status = $updater->check();
+        if ($status === false) {
+            $errors = 1 + (int) $this->config->getAppValue('updatenotification', 'update_check_errors', 0);
+            $this->config->setAppValue('updatenotification', 'update_check_errors', $errors);
+
+            if (in_array($errors, $this->connectionNotifications, true)) {
+                $this->sendErrorNotifications($errors);
+            }
+        } else if (isset($status['version'])) {
+            $this->config->setAppValue('updatenotification', 'update_check_errors', 0);
+            $this->clearErrorNotifications();
+
+            $this->createNotifications('core', $status['version'], $status['versionstring']);
+        }
+    }
+
+    /**
+     * Send a message to the admin when the update server could not be reached
+     * @param int $numDays
+     */
+    protected function sendErrorNotifications($numDays) {
+        $this->clearErrorNotifications();
+
+        $notification = $this->notificationManager->createNotification();
+        try {
+            $notification->setApp('updatenotification')
+                ->setDateTime(new \DateTime())
+                ->setObject('updatenotification', 'error')
+                ->setSubject('connection_error', ['days' => $numDays]);
+
+            foreach ($this->getUsersToNotify() as $uid) {
+                $notification->setUser($uid);
+                $this->notificationManager->notify($notification);
+            }
+        } catch (\InvalidArgumentException $e) {
+            return;
+        }
+    }
+
+    /**
+     * Remove error notifications again
+     */
+    protected function clearErrorNotifications() {
+        $notification = $this->notificationManager->createNotification();
+        try {
+            $notification->setApp('updatenotification')
+                ->setSubject('connection_error')
+                ->setObject('updatenotification', 'error');
+        } catch (\InvalidArgumentException $e) {
+            return;
+        }
+        $this->notificationManager->markProcessed($notification);
+    }
+
+    /**
+     * Check all installed apps for updates
+     */
+    protected function checkAppUpdates() {
+        $apps = $this->appManager->getInstalledApps();
+        foreach ($apps as $app) {
+            $update = $this->isUpdateAvailable($app);
+            if ($update !== false) {
+                $this->createNotifications($app, $update);
+            }
+        }
+    }
+
+    /**
+     * Create notifications for this app version
+     *
+     * @param string $app
+     * @param string $version
+     * @param string $visibleVersion
+     */
+    protected function createNotifications($app, $version, $visibleVersion = '') {
+        $lastNotification = $this->config->getAppValue('updatenotification', $app, false);
+        if ($lastNotification === $version) {
+            // We already notified about this update
+            return;
+        } else if ($lastNotification !== false) {
+            // Delete old updates
+            $this->deleteOutdatedNotifications($app, $lastNotification);
+        }
+
+
+        $notification = $this->notificationManager->createNotification();
+        $notification->setApp('updatenotification')
+            ->setDateTime(new \DateTime())
+            ->setObject($app, $version);
+
+        if ($visibleVersion !== '') {
+            $notification->setSubject('update_available', ['version' => $visibleVersion]);
+        } else {
+            $notification->setSubject('update_available');
+        }
+
+        foreach ($this->getUsersToNotify() as $uid) {
+            $notification->setUser($uid);
+            $this->notificationManager->notify($notification);
+        }
+
+        $this->config->setAppValue('updatenotification', $app, $version);
+    }
+
+    /**
+     * @return string[]
+     */
+    protected function getUsersToNotify() {
+        if ($this->users !== null) {
+            return $this->users;
+        }
+
+        $notifyGroups = json_decode($this->config->getAppValue('updatenotification', 'notify_groups', '["admin"]'), true);
+        $this->users = [];
+        foreach ($notifyGroups as $group) {
+            $groupToNotify = $this->groupManager->get($group);
+            if ($groupToNotify instanceof IGroup) {
+                foreach ($groupToNotify->getUsers() as $user) {
+                    $this->users[$user->getUID()] = true;
+                }
+            }
+        }
+
+        $this->users = array_keys($this->users);
+
+        return $this->users;
+    }
+
+    /**
+     * Delete notifications for old updates
+     *
+     * @param string $app
+     * @param string $version
+     */
+    protected function deleteOutdatedNotifications($app, $version) {
+        $notification = $this->notificationManager->createNotification();
+        $notification->setApp('updatenotification')
+            ->setObject($app, $version);
+        $this->notificationManager->markProcessed($notification);
+    }
+
+    /**
+     * @return VersionCheck
+     */
+    protected function createVersionCheck() {
+        return new VersionCheck(
+            $this->client,
+            $this->config
+        );
+    }
+
+    /**
+     * @return string
+     */
+    protected function getChannel() {
+        return \OC_Util::getChannel();
+    }
+
+    /**
+     * @param string $app
+     * @return string|false
+     */
+    protected function isUpdateAvailable($app) {
+        return Installer::isUpdateAvailable($app, \OC::$server->getAppFetcher());
+    }
 }

lib/private/Updater/VersionCheck.php

Indentation +89 added lines, -89 removed lines

@@ -31,95 +31,95 @@
 
 class VersionCheck {
 
-	/** @var IClientService */
-	private $clientService;
+    /** @var IClientService */
+    private $clientService;
 	
-	/** @var IConfig */
-	private $config;
-
-	/**
-	 * @param IClientService $clientService
-	 * @param IConfig $config
-	 */
-	public function __construct(IClientService $clientService,
-								IConfig $config) {
-		$this->clientService = $clientService;
-		$this->config = $config;
-	}
-
-
-	/**
-	 * Check if a new version is available
-	 *
-	 * @return array|bool
-	 */
-	public function check() {
-		// Look up the cache - it is invalidated all 30 minutes
-		if (((int)$this->config->getAppValue('core', 'lastupdatedat') + 1800) > time()) {
-			return json_decode($this->config->getAppValue('core', 'lastupdateResult'), true);
-		}
-
-		$updaterUrl = $this->config->getSystemValue('updater.server.url', 'https://updates.nextcloud.com/updater_server/');
-
-		$this->config->setAppValue('core', 'lastupdatedat', time());
-
-		if ($this->config->getAppValue('core', 'installedat', '') === '') {
-			$this->config->setAppValue('core', 'installedat', microtime(true));
-		}
-
-		$version = Util::getVersion();
-		$version['installed'] = $this->config->getAppValue('core', 'installedat');
-		$version['updated'] = $this->config->getAppValue('core', 'lastupdatedat');
-		$version['updatechannel'] = \OC_Util::getChannel();
-		$version['edition'] = '';
-		$version['build'] = \OC_Util::getBuild();
-		$version['php_major'] = PHP_MAJOR_VERSION;
-		$version['php_minor'] = PHP_MINOR_VERSION;
-		$version['php_release'] = PHP_RELEASE_VERSION;
-		$versionString = implode('x', $version);
-
-		//fetch xml data from updater
-		$url = $updaterUrl . '?version=' . $versionString;
-
-		$tmp = [];
-		try {
-			$xml = $this->getUrlContent($url);
-		} catch (\Exception $e) {
-			return false;
-		}
-
-		if ($xml) {
-			$loadEntities = libxml_disable_entity_loader(true);
-			$data = @simplexml_load_string($xml);
-			libxml_disable_entity_loader($loadEntities);
-			if ($data !== false) {
-				$tmp['version'] = (string)$data->version;
-				$tmp['versionstring'] = (string)$data->versionstring;
-				$tmp['url'] = (string)$data->url;
-				$tmp['web'] = (string)$data->web;
-				$tmp['autoupdater'] = (string)$data->autoupdater;
-			} else {
-				libxml_clear_errors();
-			}
-		} else {
-			$data = [];
-		}
-
-		// Cache the result
-		$this->config->setAppValue('core', 'lastupdateResult', json_encode($data));
-		return $tmp;
-	}
-
-	/**
-	 * @codeCoverageIgnore
-	 * @param string $url
-	 * @return resource|string
-	 * @throws \Exception
-	 */
-	protected function getUrlContent($url) {
-		$client = $this->clientService->newClient();
-		$response = $client->get($url);
-		return $response->getBody();
-	}
+    /** @var IConfig */
+    private $config;
+
+    /**
+     * @param IClientService $clientService
+     * @param IConfig $config
+     */
+    public function __construct(IClientService $clientService,
+                                IConfig $config) {
+        $this->clientService = $clientService;
+        $this->config = $config;
+    }
+
+
+    /**
+     * Check if a new version is available
+     *
+     * @return array|bool
+     */
+    public function check() {
+        // Look up the cache - it is invalidated all 30 minutes
+        if (((int)$this->config->getAppValue('core', 'lastupdatedat') + 1800) > time()) {
+            return json_decode($this->config->getAppValue('core', 'lastupdateResult'), true);
+        }
+
+        $updaterUrl = $this->config->getSystemValue('updater.server.url', 'https://updates.nextcloud.com/updater_server/');
+
+        $this->config->setAppValue('core', 'lastupdatedat', time());
+
+        if ($this->config->getAppValue('core', 'installedat', '') === '') {
+            $this->config->setAppValue('core', 'installedat', microtime(true));
+        }
+
+        $version = Util::getVersion();
+        $version['installed'] = $this->config->getAppValue('core', 'installedat');
+        $version['updated'] = $this->config->getAppValue('core', 'lastupdatedat');
+        $version['updatechannel'] = \OC_Util::getChannel();
+        $version['edition'] = '';
+        $version['build'] = \OC_Util::getBuild();
+        $version['php_major'] = PHP_MAJOR_VERSION;
+        $version['php_minor'] = PHP_MINOR_VERSION;
+        $version['php_release'] = PHP_RELEASE_VERSION;
+        $versionString = implode('x', $version);
+
+        //fetch xml data from updater
+        $url = $updaterUrl . '?version=' . $versionString;
+
+        $tmp = [];
+        try {
+            $xml = $this->getUrlContent($url);
+        } catch (\Exception $e) {
+            return false;
+        }
+
+        if ($xml) {
+            $loadEntities = libxml_disable_entity_loader(true);
+            $data = @simplexml_load_string($xml);
+            libxml_disable_entity_loader($loadEntities);
+            if ($data !== false) {
+                $tmp['version'] = (string)$data->version;
+                $tmp['versionstring'] = (string)$data->versionstring;
+                $tmp['url'] = (string)$data->url;
+                $tmp['web'] = (string)$data->web;
+                $tmp['autoupdater'] = (string)$data->autoupdater;
+            } else {
+                libxml_clear_errors();
+            }
+        } else {
+            $data = [];
+        }
+
+        // Cache the result
+        $this->config->setAppValue('core', 'lastupdateResult', json_encode($data));
+        return $tmp;
+    }
+
+    /**
+     * @codeCoverageIgnore
+     * @param string $url
+     * @return resource|string
+     * @throws \Exception
+     */
+    protected function getUrlContent($url) {
+        $client = $this->clientService->newClient();
+        $response = $client->get($url);
+        return $response->getBody();
+    }
 }
 

Spacing +7 added lines, -7 removed lines

@@ -55,7 +55,7 @@ 
 	 */
 	public function check() {
 		// Look up the cache - it is invalidated all 30 minutes
-		if (((int)$this->config->getAppValue('core', 'lastupdatedat') + 1800) > time()) {
+		if (((int) $this->config->getAppValue('core', 'lastupdatedat') + 1800) > time()) {
 			return json_decode($this->config->getAppValue('core', 'lastupdateResult'), true);
 		}
 
@@ -79,7 +79,7 @@ 
 		$versionString = implode('x', $version);
 
 		//fetch xml data from updater
-		$url = $updaterUrl . '?version=' . $versionString;
+		$url = $updaterUrl.'?version='.$versionString;
 
 		$tmp = [];
 		try {
@@ -93,11 +93,11 @@ 
 			$data = @simplexml_load_string($xml);
 			libxml_disable_entity_loader($loadEntities);
 			if ($data !== false) {
-				$tmp['version'] = (string)$data->version;
-				$tmp['versionstring'] = (string)$data->versionstring;
-				$tmp['url'] = (string)$data->url;
-				$tmp['web'] = (string)$data->web;
-				$tmp['autoupdater'] = (string)$data->autoupdater;
+				$tmp['version'] = (string) $data->version;
+				$tmp['versionstring'] = (string) $data->versionstring;
+				$tmp['url'] = (string) $data->url;
+				$tmp['web'] = (string) $data->web;
+				$tmp['autoupdater'] = (string) $data->autoupdater;
 			} else {
 				libxml_clear_errors();
 			}