nextcloud / server

apps/dav/tests/unit/DAV/ViewOnlyPluginTest.php

Indentation +137 added lines, -137 removed lines

@@ -28,142 +28,142 @@
 use Test\TestCase;
 
 class ViewOnlyPluginTest extends TestCase {
-	private Tree&MockObject $tree;
-	private RequestInterface&MockObject $request;
-	private Folder&MockObject $userFolder;
-	private ViewOnlyPlugin $plugin;
-
-	public function setUp(): void {
-		parent::setUp();
-
-		$this->userFolder = $this->createMock(Folder::class);
-		$this->request = $this->createMock(RequestInterface::class);
-		$this->tree = $this->createMock(Tree::class);
-		$server = $this->createMock(Server::class);
-
-		$this->plugin = new ViewOnlyPlugin(
-			$this->userFolder,
-		);
-		$server->tree = $this->tree;
-
-		$this->plugin->initialize($server);
-	}
-
-	public function testCanGetNonDav(): void {
-		$this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
-		$this->tree->method('getNodeForPath')->willReturn(null);
-
-		$this->assertTrue($this->plugin->checkViewOnly($this->request));
-	}
-
-	public function testCanGetNonShared(): void {
-		$this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
-		$davNode = $this->createMock(DavFile::class);
-		$this->tree->method('getNodeForPath')->willReturn($davNode);
-
-		$file = $this->createMock(File::class);
-		$davNode->method('getNode')->willReturn($file);
-
-		$storage = $this->createMock(IStorage::class);
-		$file->method('getStorage')->willReturn($storage);
-		$storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
-
-		$this->assertTrue($this->plugin->checkViewOnly($this->request));
-	}
-
-	public static function providesDataForCanGet(): array {
-		return [
-			// has attribute permissions-download enabled - can get file
-			[false, true, true, true],
-			// has no attribute permissions-download - can get file
-			[false, null, true, true],
-			// has attribute permissions-download enabled - can get file version
-			[true, true, true, true],
-			// has no attribute permissions-download - can get file version
-			[true, null, true, true],
-			// has attribute permissions-download disabled - cannot get the file
-			[false, false, false, false],
-			// has attribute permissions-download disabled - cannot get the file version
-			[true, false, false, false],
-
-			// Has global allowViewWithoutDownload option enabled
-			// has attribute permissions-download disabled - can get file
-			[false, false, false, true],
-			// has attribute permissions-download disabled - can get file version
-			[true, false, false, true],
-		];
-	}
-
-	/**
-	 * @dataProvider providesDataForCanGet
-	 */
-	public function testCanGet(bool $isVersion, ?bool $attrEnabled, bool $expectCanDownloadFile, bool $allowViewWithoutDownload): void {
-		$nodeInfo = $this->createMock(File::class);
-		if ($isVersion) {
-			$davPath = 'versions/alice/versions/117/123456';
-			$version = $this->createMock(IVersion::class);
-			$version->expects($this->once())
-				->method('getSourceFile')
-				->willReturn($nodeInfo);
-			$davNode = $this->createMock(VersionFile::class);
-			$davNode->expects($this->once())
-				->method('getVersion')
-				->willReturn($version);
-
-			$currentUser = $this->createMock(IUser::class);
-			$currentUser->expects($this->once())
-				->method('getUID')
-				->willReturn('alice');
-			$nodeInfo->expects($this->once())
-				->method('getOwner')
-				->willReturn($currentUser);
-
-			$nodeInfo = $this->createMock(File::class);
-			$owner = $this->createMock(IUser::class);
-			$owner->expects($this->once())
-				->method('getUID')
-				->willReturn('bob');
-			$this->userFolder->expects($this->once())
-				->method('getById')
-				->willReturn([$nodeInfo]);
-			$this->userFolder->expects($this->once())
-				->method('getOwner')
-				->willReturn($owner);
-		} else {
-			$davPath = 'files/path/to/file.odt';
-			$davNode = $this->createMock(DavFile::class);
-			$davNode->method('getNode')->willReturn($nodeInfo);
-		}
-
-		$this->request->expects($this->once())->method('getPath')->willReturn($davPath);
-
-		$this->tree->expects($this->once())
-			->method('getNodeForPath')
-			->with($davPath)
-			->willReturn($davNode);
-
-		$storage = $this->createMock(SharedStorage::class);
-		$share = $this->createMock(IShare::class);
-		$nodeInfo->expects($this->once())
-			->method('getStorage')
-			->willReturn($storage);
-		$storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(true);
-		$storage->method('getShare')->willReturn($share);
-
-		$extAttr = $this->createMock(IAttributes::class);
-		$share->method('getAttributes')->willReturn($extAttr);
-		$extAttr->expects($this->once())
-			->method('getAttribute')
-			->with('permissions', 'download')
-			->willReturn($attrEnabled);
+    private Tree&MockObject $tree;
+    private RequestInterface&MockObject $request;
+    private Folder&MockObject $userFolder;
+    private ViewOnlyPlugin $plugin;
+
+    public function setUp(): void {
+        parent::setUp();
+
+        $this->userFolder = $this->createMock(Folder::class);
+        $this->request = $this->createMock(RequestInterface::class);
+        $this->tree = $this->createMock(Tree::class);
+        $server = $this->createMock(Server::class);
+
+        $this->plugin = new ViewOnlyPlugin(
+            $this->userFolder,
+        );
+        $server->tree = $this->tree;
+
+        $this->plugin->initialize($server);
+    }
+
+    public function testCanGetNonDav(): void {
+        $this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
+        $this->tree->method('getNodeForPath')->willReturn(null);
+
+        $this->assertTrue($this->plugin->checkViewOnly($this->request));
+    }
+
+    public function testCanGetNonShared(): void {
+        $this->request->expects($this->once())->method('getPath')->willReturn('files/test/target');
+        $davNode = $this->createMock(DavFile::class);
+        $this->tree->method('getNodeForPath')->willReturn($davNode);
+
+        $file = $this->createMock(File::class);
+        $davNode->method('getNode')->willReturn($file);
+
+        $storage = $this->createMock(IStorage::class);
+        $file->method('getStorage')->willReturn($storage);
+        $storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
+
+        $this->assertTrue($this->plugin->checkViewOnly($this->request));
+    }
+
+    public static function providesDataForCanGet(): array {
+        return [
+            // has attribute permissions-download enabled - can get file
+            [false, true, true, true],
+            // has no attribute permissions-download - can get file
+            [false, null, true, true],
+            // has attribute permissions-download enabled - can get file version
+            [true, true, true, true],
+            // has no attribute permissions-download - can get file version
+            [true, null, true, true],
+            // has attribute permissions-download disabled - cannot get the file
+            [false, false, false, false],
+            // has attribute permissions-download disabled - cannot get the file version
+            [true, false, false, false],
+
+            // Has global allowViewWithoutDownload option enabled
+            // has attribute permissions-download disabled - can get file
+            [false, false, false, true],
+            // has attribute permissions-download disabled - can get file version
+            [true, false, false, true],
+        ];
+    }
+
+    /**
+     * @dataProvider providesDataForCanGet
+     */
+    public function testCanGet(bool $isVersion, ?bool $attrEnabled, bool $expectCanDownloadFile, bool $allowViewWithoutDownload): void {
+        $nodeInfo = $this->createMock(File::class);
+        if ($isVersion) {
+            $davPath = 'versions/alice/versions/117/123456';
+            $version = $this->createMock(IVersion::class);
+            $version->expects($this->once())
+                ->method('getSourceFile')
+                ->willReturn($nodeInfo);
+            $davNode = $this->createMock(VersionFile::class);
+            $davNode->expects($this->once())
+                ->method('getVersion')
+                ->willReturn($version);
+
+            $currentUser = $this->createMock(IUser::class);
+            $currentUser->expects($this->once())
+                ->method('getUID')
+                ->willReturn('alice');
+            $nodeInfo->expects($this->once())
+                ->method('getOwner')
+                ->willReturn($currentUser);
+
+            $nodeInfo = $this->createMock(File::class);
+            $owner = $this->createMock(IUser::class);
+            $owner->expects($this->once())
+                ->method('getUID')
+                ->willReturn('bob');
+            $this->userFolder->expects($this->once())
+                ->method('getById')
+                ->willReturn([$nodeInfo]);
+            $this->userFolder->expects($this->once())
+                ->method('getOwner')
+                ->willReturn($owner);
+        } else {
+            $davPath = 'files/path/to/file.odt';
+            $davNode = $this->createMock(DavFile::class);
+            $davNode->method('getNode')->willReturn($nodeInfo);
+        }
+
+        $this->request->expects($this->once())->method('getPath')->willReturn($davPath);
+
+        $this->tree->expects($this->once())
+            ->method('getNodeForPath')
+            ->with($davPath)
+            ->willReturn($davNode);
+
+        $storage = $this->createMock(SharedStorage::class);
+        $share = $this->createMock(IShare::class);
+        $nodeInfo->expects($this->once())
+            ->method('getStorage')
+            ->willReturn($storage);
+        $storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(true);
+        $storage->method('getShare')->willReturn($share);
+
+        $extAttr = $this->createMock(IAttributes::class);
+        $share->method('getAttributes')->willReturn($extAttr);
+        $extAttr->expects($this->once())
+            ->method('getAttribute')
+            ->with('permissions', 'download')
+            ->willReturn($attrEnabled);
 		
-		$share->expects($this->once())
-			->method('canSeeContent')
-			->willReturn($allowViewWithoutDownload);
-
-		if (!$expectCanDownloadFile) {
-			$this->expectException(Forbidden::class);
-		}
-		$this->plugin->checkViewOnly($this->request);
-	}
+        $share->expects($this->once())
+            ->method('canSeeContent')
+            ->willReturn($allowViewWithoutDownload);
+
+        if (!$expectCanDownloadFile) {
+            $this->expectException(Forbidden::class);
+        }
+        $this->plugin->checkViewOnly($this->request);
+    }
 }

tests/Core/Controller/PreviewControllerTest.php

Indentation +339 added lines, -339 removed lines

@@ -24,343 +24,343 @@
 
 class PreviewControllerTest extends \Test\TestCase {
 
-	private string $userId;
-	private PreviewController $controller;
-
-	private IRootFolder&MockObject $rootFolder;
-	private IPreview&MockObject $previewManager;
-	private IRequest&MockObject $request;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->userId = 'user';
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->previewManager = $this->createMock(IPreview::class);
-		$this->request = $this->createMock(IRequest::class);
-
-		$this->controller = new PreviewController(
-			'core',
-			$this->request,
-			$this->previewManager,
-			$this->rootFolder,
-			$this->userId,
-			$this->createMock(IMimeIconProvider::class)
-		);
-	}
-
-	public function testInvalidFile(): void {
-		$res = $this->controller->getPreview('');
-		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testInvalidWidth(): void {
-		$res = $this->controller->getPreview('file', 0);
-		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testInvalidHeight(): void {
-		$res = $this->controller->getPreview('file', 10, 0);
-		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testFileNotFound(): void {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willThrowException(new NotFoundException());
-
-		$res = $this->controller->getPreview('file');
-		$expected = new DataResponse([], Http::STATUS_NOT_FOUND);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testNotAFile(): void {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$folder = $this->createMock(Folder::class);
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($folder);
-
-		$res = $this->controller->getPreview('file');
-		$expected = new DataResponse([], Http::STATUS_NOT_FOUND);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testNoPreviewAndNoIcon(): void {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$file = $this->createMock(File::class);
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($file);
-
-		$this->previewManager->method('isAvailable')
-			->with($this->equalTo($file))
-			->willReturn(false);
-
-		$res = $this->controller->getPreview('file', 10, 10, true, false);
-		$expected = new DataResponse([], Http::STATUS_NOT_FOUND);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testNoPreview() {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$file = $this->createMock(File::class);
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($file);
-
-		$storage = $this->createMock(IStorage::class);
-		$file->method('getStorage')
-			->willReturn($storage);
-
-		$this->previewManager->method('isAvailable')
-			->with($this->equalTo($file))
-			->willReturn(true);
-
-		$file->method('isReadable')
-			->willReturn(true);
-
-		$this->previewManager->method('getPreview')
-			->with($this->equalTo($file), 10, 10, false, $this->equalTo('myMode'))
-			->willThrowException(new NotFoundException());
-
-		$res = $this->controller->getPreview('file', 10, 10, true, true, 'myMode');
-		$expected = new DataResponse([], Http::STATUS_NOT_FOUND);
-
-		$this->assertEquals($expected, $res);
-	}
-	public function testFileWithoutReadPermission() {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$file = $this->createMock(File::class);
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($file);
-
-		$this->previewManager->method('isAvailable')
-			->with($this->equalTo($file))
-			->willReturn(true);
-
-		$file->method('isReadable')
-			->willReturn(false);
-
-		$res = $this->controller->getPreview('file', 10, 10, true, true);
-		$expected = new DataResponse([], Http::STATUS_FORBIDDEN);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testFileWithoutDownloadPermission() {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(123);
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($file);
-
-		$this->previewManager->method('isAvailable')
-			->with($this->equalTo($file))
-			->willReturn(true);
-
-		$share = $this->createMock(IShare::class);
-		$share->method('canSeeContent')
-			->willReturn(false);
-
-		$storage = $this->createMock(ISharedStorage::class);
-		$storage->method('instanceOfStorage')
-			->with(ISharedStorage::class)
-			->willReturn(true);
-		$storage->method('getShare')
-			->willReturn($share);
-
-		$file->method('getStorage')
-			->willReturn($storage);
-		$file->method('isReadable')
-			->willReturn(true);
-
-		$this->request->method('getHeader')->willReturn('');
-
-		$res = $this->controller->getPreview('file', 10, 10, true, true);
-		$expected = new DataResponse([], Http::STATUS_FORBIDDEN);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testFileWithoutDownloadPermissionButHeader() {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(123);
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($file);
-
-		$this->previewManager->method('isAvailable')
-			->with($this->equalTo($file))
-			->willReturn(true);
-
-		$share = $this->createMock(IShare::class);
-		$share->method('canSeeContent')
-			->willReturn(false);
-
-		$storage = $this->createMock(ISharedStorage::class);
-		$storage->method('instanceOfStorage')
-			->with(ISharedStorage::class)
-			->willReturn(true);
-		$storage->method('getShare')
-			->willReturn($share);
-
-		$file->method('getStorage')
-			->willReturn($storage);
-		$file->method('isReadable')
-			->willReturn(true);
-
-		$this->request
-			->method('getHeader')
-			->with('x-nc-preview')
-			->willReturn('true');
-
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('my name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->previewManager->method('getPreview')
-			->with($this->equalTo($file), 10, 10, false, $this->equalTo('myMode'))
-			->willReturn($preview);
-		$preview->method('getMimeType')
-			->willReturn('myMime');
-
-		$res = $this->controller->getPreview('file', 10, 10, true, true, 'myMode');
-
-		$this->assertEquals('myMime', $res->getHeaders()['Content-Type']);
-		$this->assertEquals(Http::STATUS_OK, $res->getStatus());
-		$this->assertEquals($preview, $this->invokePrivate($res, 'file'));
-	}
-
-	public function testValidPreview(): void {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(123);
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($file);
-
-		$this->previewManager->method('isAvailable')
-			->with($this->equalTo($file))
-			->willReturn(true);
-
-		$file->method('isReadable')
-			->willReturn(true);
-
-		$storage = $this->createMock(IStorage::class);
-		$file->method('getStorage')
-			->willReturn($storage);
-
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('my name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->previewManager->method('getPreview')
-			->with($this->equalTo($file), 10, 10, false, $this->equalTo('myMode'))
-			->willReturn($preview);
-		$preview->method('getMimeType')
-			->willReturn('myMime');
-
-		$res = $this->controller->getPreview('file', 10, 10, true, true, 'myMode');
-
-		$this->assertEquals('myMime', $res->getHeaders()['Content-Type']);
-		$this->assertEquals(Http::STATUS_OK, $res->getStatus());
-		$this->assertEquals($preview, $this->invokePrivate($res, 'file'));
-	}
-
-	public function testValidPreviewOfShare() {
-		$userFolder = $this->createMock(Folder::class);
-		$this->rootFolder->method('getUserFolder')
-			->with($this->equalTo($this->userId))
-			->willReturn($userFolder);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(123);
-		$userFolder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($file);
-
-		$this->previewManager->method('isAvailable')
-			->with($this->equalTo($file))
-			->willReturn(true);
-
-		// No attributes set -> download permitted
-		$share = $this->createMock(IShare::class);
-		$share->method('canSeeContent')
-			->willReturn(true);
-
-		$storage = $this->createMock(ISharedStorage::class);
-		$storage->method('instanceOfStorage')
-			->with(ISharedStorage::class)
-			->willReturn(true);
-		$storage->method('getShare')
-			->willReturn($share);
-
-		$file->method('getStorage')
-			->willReturn($storage);
-		$file->method('isReadable')
-			->willReturn(true);
-
-		$this->request
-			->method('getHeader')
-			->willReturn('');
-
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('my name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->previewManager->method('getPreview')
-			->with($this->equalTo($file), 10, 10, false, $this->equalTo('myMode'))
-			->willReturn($preview);
-		$preview->method('getMimeType')
-			->willReturn('myMime');
-
-		$res = $this->controller->getPreview('file', 10, 10, true, true, 'myMode');
-
-		$this->assertEquals('myMime', $res->getHeaders()['Content-Type']);
-		$this->assertEquals(Http::STATUS_OK, $res->getStatus());
-		$this->assertEquals($preview, $this->invokePrivate($res, 'file'));
-	}
+    private string $userId;
+    private PreviewController $controller;
+
+    private IRootFolder&MockObject $rootFolder;
+    private IPreview&MockObject $previewManager;
+    private IRequest&MockObject $request;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->userId = 'user';
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->previewManager = $this->createMock(IPreview::class);
+        $this->request = $this->createMock(IRequest::class);
+
+        $this->controller = new PreviewController(
+            'core',
+            $this->request,
+            $this->previewManager,
+            $this->rootFolder,
+            $this->userId,
+            $this->createMock(IMimeIconProvider::class)
+        );
+    }
+
+    public function testInvalidFile(): void {
+        $res = $this->controller->getPreview('');
+        $expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testInvalidWidth(): void {
+        $res = $this->controller->getPreview('file', 0);
+        $expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testInvalidHeight(): void {
+        $res = $this->controller->getPreview('file', 10, 0);
+        $expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testFileNotFound(): void {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willThrowException(new NotFoundException());
+
+        $res = $this->controller->getPreview('file');
+        $expected = new DataResponse([], Http::STATUS_NOT_FOUND);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testNotAFile(): void {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $folder = $this->createMock(Folder::class);
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($folder);
+
+        $res = $this->controller->getPreview('file');
+        $expected = new DataResponse([], Http::STATUS_NOT_FOUND);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testNoPreviewAndNoIcon(): void {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $file = $this->createMock(File::class);
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($file);
+
+        $this->previewManager->method('isAvailable')
+            ->with($this->equalTo($file))
+            ->willReturn(false);
+
+        $res = $this->controller->getPreview('file', 10, 10, true, false);
+        $expected = new DataResponse([], Http::STATUS_NOT_FOUND);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testNoPreview() {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $file = $this->createMock(File::class);
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($file);
+
+        $storage = $this->createMock(IStorage::class);
+        $file->method('getStorage')
+            ->willReturn($storage);
+
+        $this->previewManager->method('isAvailable')
+            ->with($this->equalTo($file))
+            ->willReturn(true);
+
+        $file->method('isReadable')
+            ->willReturn(true);
+
+        $this->previewManager->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, false, $this->equalTo('myMode'))
+            ->willThrowException(new NotFoundException());
+
+        $res = $this->controller->getPreview('file', 10, 10, true, true, 'myMode');
+        $expected = new DataResponse([], Http::STATUS_NOT_FOUND);
+
+        $this->assertEquals($expected, $res);
+    }
+    public function testFileWithoutReadPermission() {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $file = $this->createMock(File::class);
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($file);
+
+        $this->previewManager->method('isAvailable')
+            ->with($this->equalTo($file))
+            ->willReturn(true);
+
+        $file->method('isReadable')
+            ->willReturn(false);
+
+        $res = $this->controller->getPreview('file', 10, 10, true, true);
+        $expected = new DataResponse([], Http::STATUS_FORBIDDEN);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testFileWithoutDownloadPermission() {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(123);
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($file);
+
+        $this->previewManager->method('isAvailable')
+            ->with($this->equalTo($file))
+            ->willReturn(true);
+
+        $share = $this->createMock(IShare::class);
+        $share->method('canSeeContent')
+            ->willReturn(false);
+
+        $storage = $this->createMock(ISharedStorage::class);
+        $storage->method('instanceOfStorage')
+            ->with(ISharedStorage::class)
+            ->willReturn(true);
+        $storage->method('getShare')
+            ->willReturn($share);
+
+        $file->method('getStorage')
+            ->willReturn($storage);
+        $file->method('isReadable')
+            ->willReturn(true);
+
+        $this->request->method('getHeader')->willReturn('');
+
+        $res = $this->controller->getPreview('file', 10, 10, true, true);
+        $expected = new DataResponse([], Http::STATUS_FORBIDDEN);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testFileWithoutDownloadPermissionButHeader() {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(123);
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($file);
+
+        $this->previewManager->method('isAvailable')
+            ->with($this->equalTo($file))
+            ->willReturn(true);
+
+        $share = $this->createMock(IShare::class);
+        $share->method('canSeeContent')
+            ->willReturn(false);
+
+        $storage = $this->createMock(ISharedStorage::class);
+        $storage->method('instanceOfStorage')
+            ->with(ISharedStorage::class)
+            ->willReturn(true);
+        $storage->method('getShare')
+            ->willReturn($share);
+
+        $file->method('getStorage')
+            ->willReturn($storage);
+        $file->method('isReadable')
+            ->willReturn(true);
+
+        $this->request
+            ->method('getHeader')
+            ->with('x-nc-preview')
+            ->willReturn('true');
+
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('my name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->previewManager->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, false, $this->equalTo('myMode'))
+            ->willReturn($preview);
+        $preview->method('getMimeType')
+            ->willReturn('myMime');
+
+        $res = $this->controller->getPreview('file', 10, 10, true, true, 'myMode');
+
+        $this->assertEquals('myMime', $res->getHeaders()['Content-Type']);
+        $this->assertEquals(Http::STATUS_OK, $res->getStatus());
+        $this->assertEquals($preview, $this->invokePrivate($res, 'file'));
+    }
+
+    public function testValidPreview(): void {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(123);
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($file);
+
+        $this->previewManager->method('isAvailable')
+            ->with($this->equalTo($file))
+            ->willReturn(true);
+
+        $file->method('isReadable')
+            ->willReturn(true);
+
+        $storage = $this->createMock(IStorage::class);
+        $file->method('getStorage')
+            ->willReturn($storage);
+
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('my name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->previewManager->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, false, $this->equalTo('myMode'))
+            ->willReturn($preview);
+        $preview->method('getMimeType')
+            ->willReturn('myMime');
+
+        $res = $this->controller->getPreview('file', 10, 10, true, true, 'myMode');
+
+        $this->assertEquals('myMime', $res->getHeaders()['Content-Type']);
+        $this->assertEquals(Http::STATUS_OK, $res->getStatus());
+        $this->assertEquals($preview, $this->invokePrivate($res, 'file'));
+    }
+
+    public function testValidPreviewOfShare() {
+        $userFolder = $this->createMock(Folder::class);
+        $this->rootFolder->method('getUserFolder')
+            ->with($this->equalTo($this->userId))
+            ->willReturn($userFolder);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(123);
+        $userFolder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($file);
+
+        $this->previewManager->method('isAvailable')
+            ->with($this->equalTo($file))
+            ->willReturn(true);
+
+        // No attributes set -> download permitted
+        $share = $this->createMock(IShare::class);
+        $share->method('canSeeContent')
+            ->willReturn(true);
+
+        $storage = $this->createMock(ISharedStorage::class);
+        $storage->method('instanceOfStorage')
+            ->with(ISharedStorage::class)
+            ->willReturn(true);
+        $storage->method('getShare')
+            ->willReturn($share);
+
+        $file->method('getStorage')
+            ->willReturn($storage);
+        $file->method('isReadable')
+            ->willReturn(true);
+
+        $this->request
+            ->method('getHeader')
+            ->willReturn('');
+
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('my name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->previewManager->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, false, $this->equalTo('myMode'))
+            ->willReturn($preview);
+        $preview->method('getMimeType')
+            ->willReturn('myMime');
+
+        $res = $this->controller->getPreview('file', 10, 10, true, true, 'myMode');
+
+        $this->assertEquals('myMime', $res->getHeaders()['Content-Type']);
+        $this->assertEquals(Http::STATUS_OK, $res->getStatus());
+        $this->assertEquals($preview, $this->invokePrivate($res, 'file'));
+    }
 }

build/integration/features/bootstrap/SharingContext.php

Indentation +18 added lines, -18 removed lines

@@ -13,24 +13,24 @@
  * Features context.
  */
 class SharingContext implements Context, SnippetAcceptingContext {
-	use WebDav;
-	use Trashbin;
-	use AppConfiguration;
-	use CommandLine;
-	use Activity;
+    use WebDav;
+    use Trashbin;
+    use AppConfiguration;
+    use CommandLine;
+    use Activity;
 
-	protected function resetAppConfigs() {
-		$this->deleteServerConfig('core', 'shareapi_default_permissions');
-		$this->deleteServerConfig('core', 'shareapi_default_internal_expire_date');
-		$this->deleteServerConfig('core', 'shareapi_internal_expire_after_n_days');
-		$this->deleteServerConfig('core', 'internal_defaultExpDays');
-		$this->deleteServerConfig('core', 'shareapi_enforce_links_password');
-		$this->deleteServerConfig('core', 'shareapi_default_expire_date');
-		$this->deleteServerConfig('core', 'shareapi_expire_after_n_days');
-		$this->deleteServerConfig('core', 'link_defaultExpDays');
-		$this->deleteServerConfig('files_sharing', 'outgoing_server2server_share_enabled');
-		$this->deleteServerConfig('core', 'shareapi_allow_view_without_download');
+    protected function resetAppConfigs() {
+        $this->deleteServerConfig('core', 'shareapi_default_permissions');
+        $this->deleteServerConfig('core', 'shareapi_default_internal_expire_date');
+        $this->deleteServerConfig('core', 'shareapi_internal_expire_after_n_days');
+        $this->deleteServerConfig('core', 'internal_defaultExpDays');
+        $this->deleteServerConfig('core', 'shareapi_enforce_links_password');
+        $this->deleteServerConfig('core', 'shareapi_default_expire_date');
+        $this->deleteServerConfig('core', 'shareapi_expire_after_n_days');
+        $this->deleteServerConfig('core', 'link_defaultExpDays');
+        $this->deleteServerConfig('files_sharing', 'outgoing_server2server_share_enabled');
+        $this->deleteServerConfig('core', 'shareapi_allow_view_without_download');
 
-		$this->runOcc(['config:system:delete', 'share_folder']);
-	}
+        $this->runOcc(['config:system:delete', 'share_folder']);
+    }
 }

core/Controller/PreviewController.php

Indentation +174 added lines, -174 removed lines

@@ -29,178 +29,178 @@
 use OCP\Preview\IMimeIconProvider;
 
 class PreviewController extends Controller {
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		private IPreview $preview,
-		private IRootFolder $root,
-		private ?string $userId,
-		private IMimeIconProvider $mimeIconProvider,
-	) {
-		parent::__construct($appName, $request);
-	}
-
-	/**
-	 * Get a preview by file path
-	 *
-	 * @param string $file Path of the file
-	 * @param int $x Width of the preview. A width of -1 will use the original image width.
-	 * @param int $y Height of the preview. A height of -1 will use the original image height.
-	 * @param bool $a Preserve the aspect ratio
-	 * @param bool $forceIcon Force returning an icon
-	 * @param 'fill'|'cover' $mode How to crop the image
-	 * @param bool $mimeFallback Whether to fallback to the mime icon if no preview is available
-	 * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>|RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
-	 *
-	 * 200: Preview returned
-	 * 303: Redirect to the mime icon url if mimeFallback is true
-	 * 400: Getting preview is not possible
-	 * 403: Getting preview is not allowed
-	 * 404: Preview not found
-	 */
-	#[NoAdminRequired]
-	#[NoCSRFRequired]
-	#[FrontpageRoute(verb: 'GET', url: '/core/preview.png')]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getPreview(
-		string $file = '',
-		int $x = 32,
-		int $y = 32,
-		bool $a = false,
-		bool $forceIcon = true,
-		string $mode = 'fill',
-		bool $mimeFallback = false): Response {
-		if ($file === '' || $x === 0 || $y === 0) {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
-
-		try {
-			$userFolder = $this->root->getUserFolder($this->userId);
-			$node = $userFolder->get($file);
-		} catch (NotFoundException $e) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}
-
-		return $this->fetchPreview($node, $x, $y, $a, $forceIcon, $mode, $mimeFallback);
-	}
-
-	/**
-	 * Get a preview by file ID
-	 *
-	 * @param int $fileId ID of the file
-	 * @param int $x Width of the preview. A width of -1 will use the original image width.
-	 * @param int $y Height of the preview. A height of -1 will use the original image height.
-	 * @param bool $a Preserve the aspect ratio
-	 * @param bool $forceIcon Force returning an icon
-	 * @param 'fill'|'cover' $mode How to crop the image
-	 * @param bool $mimeFallback Whether to fallback to the mime icon if no preview is available
-	 * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>|RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
-	 *
-	 * 200: Preview returned
-	 * 303: Redirect to the mime icon url if mimeFallback is true
-	 * 400: Getting preview is not possible
-	 * 403: Getting preview is not allowed
-	 * 404: Preview not found
-	 */
-	#[NoAdminRequired]
-	#[NoCSRFRequired]
-	#[FrontpageRoute(verb: 'GET', url: '/core/preview')]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getPreviewByFileId(
-		int $fileId = -1,
-		int $x = 32,
-		int $y = 32,
-		bool $a = false,
-		bool $forceIcon = true,
-		string $mode = 'fill',
-		bool $mimeFallback = false) {
-		if ($fileId === -1 || $x === 0 || $y === 0) {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
-
-		$userFolder = $this->root->getUserFolder($this->userId);
-		$node = $userFolder->getFirstNodeById($fileId);
-
-		if (!$node) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}
-
-		return $this->fetchPreview($node, $x, $y, $a, $forceIcon, $mode, $mimeFallback);
-	}
-
-	/**
-	 * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>|RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
-	 */
-	private function fetchPreview(
-		Node $node,
-		int $x,
-		int $y,
-		bool $a,
-		bool $forceIcon,
-		string $mode,
-		bool $mimeFallback = false) : Response {
-		if (!($node instanceof File) || (!$forceIcon && !$this->preview->isAvailable($node))) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}
-		if (!$node->isReadable()) {
-			return new DataResponse([], Http::STATUS_FORBIDDEN);
-		}
-
-		if ($node->getId() <= 0) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}
-
-		// Is this header is set it means our UI is doing a preview for no-download shares
-		// we check a header so we at least prevent people from using the link directly (obfuscation)
-		$isNextcloudPreview = $this->request->getHeader('x-nc-preview') === 'true';
-		$storage = $node->getStorage();
-		if ($isNextcloudPreview === false && $storage->instanceOfStorage(ISharedStorage::class)) {
-			/** @var ISharedStorage $storage */
-			$share = $storage->getShare();
-			if (!$share->canSeeContent()) {
-				return new DataResponse([], Http::STATUS_FORBIDDEN);
-			}
-		}
-
-		try {
-			$f = $this->preview->getPreview($node, $x, $y, !$a, $mode);
-			$response = new FileDisplayResponse($f, Http::STATUS_OK, [
-				'Content-Type' => $f->getMimeType(),
-			]);
-			$response->cacheFor(3600 * 24, false, true);
-			return $response;
-		} catch (NotFoundException $e) {
-			// If we have no preview enabled, we can redirect to the mime icon if any
-			if ($mimeFallback) {
-				if ($url = $this->mimeIconProvider->getMimeIconUrl($node->getMimeType())) {
-					return new RedirectResponse($url);
-				}
-			}
-
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		} catch (\InvalidArgumentException $e) {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
-	}
-
-	/**
-	 * Get a preview by mime
-	 *
-	 * @param string $mime Mime type
-	 * @return RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
-	 *
-	 * 303: The mime icon url
-	 */
-	#[NoCSRFRequired]
-	#[PublicPage]
-	#[FrontpageRoute(verb: 'GET', url: '/core/mimeicon')]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getMimeIconUrl(string $mime = 'application/octet-stream') {
-		$url = $this->mimeIconProvider->getMimeIconUrl($mime);
-		if ($url === null) {
-			$url = $this->mimeIconProvider->getMimeIconUrl('application/octet-stream');
-		}
-
-		return new RedirectResponse($url);
-	}
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        private IPreview $preview,
+        private IRootFolder $root,
+        private ?string $userId,
+        private IMimeIconProvider $mimeIconProvider,
+    ) {
+        parent::__construct($appName, $request);
+    }
+
+    /**
+     * Get a preview by file path
+     *
+     * @param string $file Path of the file
+     * @param int $x Width of the preview. A width of -1 will use the original image width.
+     * @param int $y Height of the preview. A height of -1 will use the original image height.
+     * @param bool $a Preserve the aspect ratio
+     * @param bool $forceIcon Force returning an icon
+     * @param 'fill'|'cover' $mode How to crop the image
+     * @param bool $mimeFallback Whether to fallback to the mime icon if no preview is available
+     * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>|RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
+     *
+     * 200: Preview returned
+     * 303: Redirect to the mime icon url if mimeFallback is true
+     * 400: Getting preview is not possible
+     * 403: Getting preview is not allowed
+     * 404: Preview not found
+     */
+    #[NoAdminRequired]
+    #[NoCSRFRequired]
+    #[FrontpageRoute(verb: 'GET', url: '/core/preview.png')]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getPreview(
+        string $file = '',
+        int $x = 32,
+        int $y = 32,
+        bool $a = false,
+        bool $forceIcon = true,
+        string $mode = 'fill',
+        bool $mimeFallback = false): Response {
+        if ($file === '' || $x === 0 || $y === 0) {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
+
+        try {
+            $userFolder = $this->root->getUserFolder($this->userId);
+            $node = $userFolder->get($file);
+        } catch (NotFoundException $e) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        }
+
+        return $this->fetchPreview($node, $x, $y, $a, $forceIcon, $mode, $mimeFallback);
+    }
+
+    /**
+     * Get a preview by file ID
+     *
+     * @param int $fileId ID of the file
+     * @param int $x Width of the preview. A width of -1 will use the original image width.
+     * @param int $y Height of the preview. A height of -1 will use the original image height.
+     * @param bool $a Preserve the aspect ratio
+     * @param bool $forceIcon Force returning an icon
+     * @param 'fill'|'cover' $mode How to crop the image
+     * @param bool $mimeFallback Whether to fallback to the mime icon if no preview is available
+     * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>|RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
+     *
+     * 200: Preview returned
+     * 303: Redirect to the mime icon url if mimeFallback is true
+     * 400: Getting preview is not possible
+     * 403: Getting preview is not allowed
+     * 404: Preview not found
+     */
+    #[NoAdminRequired]
+    #[NoCSRFRequired]
+    #[FrontpageRoute(verb: 'GET', url: '/core/preview')]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getPreviewByFileId(
+        int $fileId = -1,
+        int $x = 32,
+        int $y = 32,
+        bool $a = false,
+        bool $forceIcon = true,
+        string $mode = 'fill',
+        bool $mimeFallback = false) {
+        if ($fileId === -1 || $x === 0 || $y === 0) {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
+
+        $userFolder = $this->root->getUserFolder($this->userId);
+        $node = $userFolder->getFirstNodeById($fileId);
+
+        if (!$node) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        }
+
+        return $this->fetchPreview($node, $x, $y, $a, $forceIcon, $mode, $mimeFallback);
+    }
+
+    /**
+     * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>|RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
+     */
+    private function fetchPreview(
+        Node $node,
+        int $x,
+        int $y,
+        bool $a,
+        bool $forceIcon,
+        string $mode,
+        bool $mimeFallback = false) : Response {
+        if (!($node instanceof File) || (!$forceIcon && !$this->preview->isAvailable($node))) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        }
+        if (!$node->isReadable()) {
+            return new DataResponse([], Http::STATUS_FORBIDDEN);
+        }
+
+        if ($node->getId() <= 0) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        }
+
+        // Is this header is set it means our UI is doing a preview for no-download shares
+        // we check a header so we at least prevent people from using the link directly (obfuscation)
+        $isNextcloudPreview = $this->request->getHeader('x-nc-preview') === 'true';
+        $storage = $node->getStorage();
+        if ($isNextcloudPreview === false && $storage->instanceOfStorage(ISharedStorage::class)) {
+            /** @var ISharedStorage $storage */
+            $share = $storage->getShare();
+            if (!$share->canSeeContent()) {
+                return new DataResponse([], Http::STATUS_FORBIDDEN);
+            }
+        }
+
+        try {
+            $f = $this->preview->getPreview($node, $x, $y, !$a, $mode);
+            $response = new FileDisplayResponse($f, Http::STATUS_OK, [
+                'Content-Type' => $f->getMimeType(),
+            ]);
+            $response->cacheFor(3600 * 24, false, true);
+            return $response;
+        } catch (NotFoundException $e) {
+            // If we have no preview enabled, we can redirect to the mime icon if any
+            if ($mimeFallback) {
+                if ($url = $this->mimeIconProvider->getMimeIconUrl($node->getMimeType())) {
+                    return new RedirectResponse($url);
+                }
+            }
+
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        } catch (\InvalidArgumentException $e) {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
+    }
+
+    /**
+     * Get a preview by mime
+     *
+     * @param string $mime Mime type
+     * @return RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
+     *
+     * 303: The mime icon url
+     */
+    #[NoCSRFRequired]
+    #[PublicPage]
+    #[FrontpageRoute(verb: 'GET', url: '/core/mimeicon')]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getMimeIconUrl(string $mime = 'application/octet-stream') {
+        $url = $this->mimeIconProvider->getMimeIconUrl($mime);
+        if ($url === null) {
+            $url = $this->mimeIconProvider->getMimeIconUrl('application/octet-stream');
+        }
+
+        return new RedirectResponse($url);
+    }
 }