nextcloud / server

lib/public/Share/IManager.php

Indentation +520 added lines, -520 removed lines

@@ -25,524 +25,524 @@
  * @since 9.0.0
  */
 interface IManager {
-	/**
-	 * Create a Share
-	 *
-	 * @param IShare $share
-	 * @return IShare The share object
-	 * @throws \Exception
-	 * @since 9.0.0
-	 */
-	public function createShare(IShare $share);
-
-	/**
-	 * Update a share.
-	 * The target of the share can't be changed this way: use moveShare
-	 * The share can't be removed this way (permission 0): use deleteShare
-	 * The state can't be changed this way: use acceptShare
-	 *
-	 * @param IShare $share
-	 * @param bool $onlyValid Only updates valid shares, invalid shares will be deleted automatically and are not updated
-	 * @return IShare The share object
-	 * @throws \InvalidArgumentException
-	 * @since 9.0.0
-	 */
-	public function updateShare(IShare $share, bool $onlyValid = true);
-
-	/**
-	 * Accept a share.
-	 *
-	 * @param IShare $share
-	 * @param string $recipientId
-	 * @return IShare The share object
-	 * @throws \InvalidArgumentException
-	 * @since 18.0.0
-	 */
-	public function acceptShare(IShare $share, string $recipientId): IShare;
-
-	/**
-	 * Delete a share
-	 *
-	 * @param IShare $share
-	 * @throws ShareNotFound
-	 * @throws \InvalidArgumentException
-	 * @since 9.0.0
-	 */
-	public function deleteShare(IShare $share);
-
-	/**
-	 * Unshare a file as the recipient.
-	 * This can be different from a regular delete for example when one of
-	 * the users in a groups deletes that share. But the provider should
-	 * handle this.
-	 *
-	 * @param IShare $share
-	 * @param string $recipientId
-	 * @since 9.0.0
-	 */
-	public function deleteFromSelf(IShare $share, $recipientId);
-
-	/**
-	 * Restore the share when it has been deleted
-	 * Certain share types can be restored when they have been deleted
-	 * but the provider should properly handle this\
-	 *
-	 * @param IShare $share The share to restore
-	 * @param string $recipientId The user to restore the share for
-	 * @return IShare The restored share object
-	 * @throws GenericShareException In case restoring the share failed
-	 *
-	 * @since 14.0.0
-	 */
-	public function restoreShare(IShare $share, string $recipientId): IShare;
-
-	/**
-	 * Move the share as a recipient of the share.
-	 * This is updating the share target. So where the recipient has the share mounted.
-	 *
-	 * @param IShare $share
-	 * @param string $recipientId
-	 * @return IShare
-	 * @throws \InvalidArgumentException If $share is a link share or the $recipient does not match
-	 * @since 9.0.0
-	 */
-	public function moveShare(IShare $share, $recipientId);
-
-	/**
-	 * Get all shares shared by (initiated) by the provided user in a folder.
-	 *
-	 * @param string $userId
-	 * @param Folder $node
-	 * @param bool $reshares
-	 * @param bool $shallow Whether the method should stop at the first level, or look into sub-folders.
-	 * @return IShare[][] [$fileId => IShare[], ...]
-	 * @since 11.0.0
-	 */
-	public function getSharesInFolder($userId, Folder $node, $reshares = false, $shallow = true);
-
-	/**
-	 * Get shares shared by (initiated) by the provided user.
-	 *
-	 * @param string $userId
-	 * @param int $shareType
-	 * @param Node|null $path
-	 * @param bool $reshares
-	 * @param int $limit The maximum number of returned results, -1 for all results
-	 * @param int $offset
-	 * @param bool $onlyValid Only returns valid shares, invalid shares will be deleted automatically and are not returned
-	 * @return IShare[]
-	 * @since 9.0.0
-	 */
-	public function getSharesBy($userId, $shareType, $path = null, $reshares = false, $limit = 50, $offset = 0, bool $onlyValid = true);
-
-	/**
-	 * Get shares shared with $user.
-	 * Filter by $node if provided
-	 *
-	 * @param string $userId
-	 * @param int $shareType
-	 * @param Node|null $node
-	 * @param int $limit The maximum number of shares returned, -1 for all
-	 * @param int $offset
-	 * @return IShare[]
-	 * @since 9.0.0
-	 */
-	public function getSharedWith($userId, $shareType, $node = null, $limit = 50, $offset = 0);
-
-	/**
-	 * Get deleted shares shared with $user.
-	 * Filter by $node if provided
-	 *
-	 * @param string $userId
-	 * @param int $shareType
-	 * @param Node|null $node
-	 * @param int $limit The maximum number of shares returned, -1 for all
-	 * @param int $offset
-	 * @return IShare[]
-	 * @since 14.0.0
-	 */
-	public function getDeletedSharedWith($userId, $shareType, $node = null, $limit = 50, $offset = 0);
-
-	/**
-	 * Retrieve a share by the share id.
-	 * If the recipient is set make sure to retrieve the file for that user.
-	 * This makes sure that if a user has moved/deleted a group share this
-	 * is reflected.
-	 *
-	 * @param string $id
-	 * @param string|null $recipient userID of the recipient
-	 * @param bool $onlyValid Only returns valid shares, invalid shares will be deleted automatically and are not returned
-	 * @return IShare
-	 * @throws ShareNotFound
-	 * @since 9.0.0
-	 */
-	public function getShareById($id, $recipient = null, bool $onlyValid = true);
-
-	/**
-	 * Get the share by token possible with password
-	 *
-	 * @param string $token
-	 * @return IShare
-	 * @throws ShareNotFound
-	 * @since 9.0.0
-	 */
-	public function getShareByToken($token);
-
-	/**
-	 * Verify the password of a public share
-	 *
-	 * @param IShare $share
-	 * @param ?string $password
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function checkPassword(IShare $share, $password);
-
-	/**
-	 * The user with UID is deleted.
-	 * All share providers have to cleanup the shares with this user as well
-	 * as shares owned by this user.
-	 * Shares only initiated by this user are fine.
-	 *
-	 * @param string $uid
-	 * @since 9.1.0
-	 */
-	public function userDeleted($uid);
-
-	/**
-	 * The group with $gid is deleted
-	 * We need to clear up all shares to this group
-	 *
-	 * @param string $gid
-	 * @since 9.1.0
-	 */
-	public function groupDeleted($gid);
-
-	/**
-	 * The user $uid is deleted from the group $gid
-	 * All user specific group shares have to be removed
-	 *
-	 * @param string $uid
-	 * @param string $gid
-	 * @since 9.1.0
-	 */
-	public function userDeletedFromGroup($uid, $gid);
-
-	/**
-	 * Get access list to a path. This means
-	 * all the users that can access a given path.
-	 *
-	 * Consider:
-	 * -root
-	 * |-folder1 (23)
-	 *  |-folder2 (32)
-	 *   |-fileA (42)
-	 *
-	 * fileA is shared with user1 and user1@server1 and email1@maildomain1
-	 * folder2 is shared with group2 (user4 is a member of group2)
-	 * folder1 is shared with user2 (renamed to "folder (1)") and user2@server2
-	 *                        and email2@maildomain2
-	 *
-	 * Then the access list to '/folder1/folder2/fileA' with $currentAccess is:
-	 * [
-	 *  users  => [
-	 *      'user1' => ['node_id' => 42, 'node_path' => '/fileA'],
-	 *      'user4' => ['node_id' => 32, 'node_path' => '/folder2'],
-	 *      'user2' => ['node_id' => 23, 'node_path' => '/folder (1)'],
-	 *  ],
-	 *  remote => [
-	 *      'user1@server1' => ['node_id' => 42, 'token' => 'SeCr3t'],
-	 *      'user2@server2' => ['node_id' => 23, 'token' => 'FooBaR'],
-	 *  ],
-	 *  public => bool
-	 *  mail => [
-	 *      'email1@maildomain1' => ['node_id' => 42, 'token' => 'aBcDeFg'],
-	 *      'email2@maildomain2' => ['node_id' => 23, 'token' => 'hIjKlMn'],
-	 *  ]
-	 *
-	 * The access list to '/folder1/folder2/fileA' **without** $currentAccess is:
-	 * [
-	 *  users  => ['user1', 'user2', 'user4'],
-	 *  remote => bool,
-	 *  public => bool
-	 *  mail => ['email1@maildomain1', 'email2@maildomain2']
-	 * ]
-	 *
-	 * This is required for encryption/activity
-	 *
-	 * @param \OCP\Files\Node $path
-	 * @param bool $recursive Should we check all parent folders as well
-	 * @param bool $currentAccess Should the user have currently access to the file
-	 * @return array
-	 * @since 12
-	 */
-	public function getAccessList(\OCP\Files\Node $path, $recursive = true, $currentAccess = false);
-
-	/**
-	 * Instantiates a new share object. This is to be passed to
-	 * createShare.
-	 *
-	 * @return IShare
-	 * @since 9.0.0
-	 */
-	public function newShare();
-
-	/**
-	 * Is the share API enabled
-	 *
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function shareApiEnabled();
-
-	/**
-	 * Is public link sharing enabled
-	 *
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function shareApiAllowLinks();
-
-	/**
-	 * Is password on public link required
-	 *
-	 * @param bool $checkGroupMembership Check group membership exclusion
-	 * @return bool
-	 * @since 9.0.0
-	 * @since 24.0.0 Added optional $checkGroupMembership parameter
-	 */
-	public function shareApiLinkEnforcePassword(bool $checkGroupMembership = true);
-
-	/**
-	 * Is default expire date enabled
-	 *
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function shareApiLinkDefaultExpireDate();
-
-	/**
-	 * Is default expire date enforced
-	 *`
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function shareApiLinkDefaultExpireDateEnforced();
-
-	/**
-	 * Number of default expire days
-	 *
-	 * @return int
-	 * @since 9.0.0
-	 */
-	public function shareApiLinkDefaultExpireDays();
-
-	/**
-	 * Is default internal expire date enabled
-	 *
-	 * @return bool
-	 * @since 22.0.0
-	 */
-	public function shareApiInternalDefaultExpireDate(): bool;
-
-	/**
-	 * Is default remote expire date enabled
-	 *
-	 * @return bool
-	 * @since 22.0.0
-	 */
-	public function shareApiRemoteDefaultExpireDate(): bool;
-
-	/**
-	 * Is default expire date enforced
-	 *
-	 * @return bool
-	 * @since 22.0.0
-	 */
-	public function shareApiInternalDefaultExpireDateEnforced(): bool;
-
-	/**
-	 * Is default expire date enforced for remote shares
-	 *
-	 * @return bool
-	 * @since 22.0.0
-	 */
-	public function shareApiRemoteDefaultExpireDateEnforced(): bool;
-
-	/**
-	 * Number of default expire days
-	 *
-	 * @return int
-	 * @since 22.0.0
-	 */
-	public function shareApiInternalDefaultExpireDays(): int;
-
-	/**
-	 * Number of default expire days for remote shares
-	 *
-	 * @return int
-	 * @since 22.0.0
-	 */
-	public function shareApiRemoteDefaultExpireDays(): int;
-
-	/**
-	 * Allow public upload on link shares
-	 *
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function shareApiLinkAllowPublicUpload();
-
-	/**
-	 * check if user can only share with group members
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function shareWithGroupMembersOnly();
-
-	/**
-	 * If shareWithGroupMembersOnly is enabled, return an optional
-	 * list of groups that must be excluded from the principle of
-	 * belonging to the same group.
-	 * @return array
-	 * @since 27.0.0
-	 */
-	public function shareWithGroupMembersOnlyExcludeGroupsList();
-
-	/**
-	 * Check if users can share with groups
-	 * @return bool
-	 * @since 9.0.1
-	 */
-	public function allowGroupSharing();
-
-	/**
-	 * Check if user enumeration is allowed
-	 *
-	 * @return bool
-	 * @since 19.0.0
-	 */
-	public function allowEnumeration(): bool;
-
-	/**
-	 * Check if user enumeration is limited to the users groups
-	 *
-	 * @return bool
-	 * @since 19.0.0
-	 */
-	public function limitEnumerationToGroups(): bool;
-
-	/**
-	 * Check if user enumeration is limited to the phonebook matches
-	 *
-	 * @return bool
-	 * @since 21.0.1
-	 */
-	public function limitEnumerationToPhone(): bool;
-
-	/**
-	 * Check if user enumeration is allowed to return on full match
-	 *
-	 * @return bool
-	 * @since 21.0.1
-	 */
-	public function allowEnumerationFullMatch(): bool;
-
-	/**
-	 * Check if the search should match the email
-	 *
-	 * @return bool
-	 * @since 25.0.0
-	 */
-	public function matchEmail(): bool;
-
-	/**
-	 * Check if the search should ignore the second in parentheses display name if there is any
-	 *
-	 * @return bool
-	 * @since 25.0.0
-	 */
-	public function ignoreSecondDisplayName(): bool;
-
-
-	/**
-	 * Check if custom tokens are allowed
-	 *
-	 * @since 31.0.0
-	 */
-	public function allowCustomTokens(): bool;
-
-	/**
-	 * Check if the current user can view the share
-	 * even if the download is disabled.
-	 *
-	 * @since 32.0.0
-	 */
-	public function allowViewWithoutDownload(): bool;
-
-	/**
-	 * Check if the current user can enumerate the target user
-	 *
-	 * @param IUser|null $currentUser
-	 * @param IUser $targetUser
-	 * @return bool
-	 * @since 23.0.0
-	 */
-	public function currentUserCanEnumerateTargetUser(?IUser $currentUser, IUser $targetUser): bool;
-
-	/**
-	 * Check if sharing is disabled for the given user
-	 *
-	 * @since 9.0.0
-	 */
-	public function sharingDisabledForUser(?string $userId): bool;
-
-	/**
-	 * Check if outgoing server2server shares are allowed
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function outgoingServer2ServerSharesAllowed();
-
-	/**
-	 * Check if outgoing server2server shares are allowed
-	 * @return bool
-	 * @since 14.0.0
-	 */
-	public function outgoingServer2ServerGroupSharesAllowed();
-
-
-	/**
-	 * Check if a given share provider exists
-	 * @param int $shareType
-	 * @return bool
-	 * @since 11.0.0
-	 */
-	public function shareProviderExists($shareType);
-
-	/**
-	 * @param string $shareProviderClass
-	 * @since 21.0.0
-	 */
-	public function registerShareProvider(string $shareProviderClass): void;
-
-	/**
-	 * @Internal
-	 *
-	 * Get all the shares as iterable to reduce memory overhead
-	 * Note, since this opens up database cursors the iterable should
-	 * be fully itterated.
-	 *
-	 * @return iterable
-	 * @since 18.0.0
-	 */
-	public function getAllShares(): iterable;
-
-	/**
-	 * Generate a unique share token
-	 *
-	 * @throws ShareTokenException Failed to generate a unique token
-	 * @since 31.0.0
-	 */
-	public function generateToken(): string;
+    /**
+     * Create a Share
+     *
+     * @param IShare $share
+     * @return IShare The share object
+     * @throws \Exception
+     * @since 9.0.0
+     */
+    public function createShare(IShare $share);
+
+    /**
+     * Update a share.
+     * The target of the share can't be changed this way: use moveShare
+     * The share can't be removed this way (permission 0): use deleteShare
+     * The state can't be changed this way: use acceptShare
+     *
+     * @param IShare $share
+     * @param bool $onlyValid Only updates valid shares, invalid shares will be deleted automatically and are not updated
+     * @return IShare The share object
+     * @throws \InvalidArgumentException
+     * @since 9.0.0
+     */
+    public function updateShare(IShare $share, bool $onlyValid = true);
+
+    /**
+     * Accept a share.
+     *
+     * @param IShare $share
+     * @param string $recipientId
+     * @return IShare The share object
+     * @throws \InvalidArgumentException
+     * @since 18.0.0
+     */
+    public function acceptShare(IShare $share, string $recipientId): IShare;
+
+    /**
+     * Delete a share
+     *
+     * @param IShare $share
+     * @throws ShareNotFound
+     * @throws \InvalidArgumentException
+     * @since 9.0.0
+     */
+    public function deleteShare(IShare $share);
+
+    /**
+     * Unshare a file as the recipient.
+     * This can be different from a regular delete for example when one of
+     * the users in a groups deletes that share. But the provider should
+     * handle this.
+     *
+     * @param IShare $share
+     * @param string $recipientId
+     * @since 9.0.0
+     */
+    public function deleteFromSelf(IShare $share, $recipientId);
+
+    /**
+     * Restore the share when it has been deleted
+     * Certain share types can be restored when they have been deleted
+     * but the provider should properly handle this\
+     *
+     * @param IShare $share The share to restore
+     * @param string $recipientId The user to restore the share for
+     * @return IShare The restored share object
+     * @throws GenericShareException In case restoring the share failed
+     *
+     * @since 14.0.0
+     */
+    public function restoreShare(IShare $share, string $recipientId): IShare;
+
+    /**
+     * Move the share as a recipient of the share.
+     * This is updating the share target. So where the recipient has the share mounted.
+     *
+     * @param IShare $share
+     * @param string $recipientId
+     * @return IShare
+     * @throws \InvalidArgumentException If $share is a link share or the $recipient does not match
+     * @since 9.0.0
+     */
+    public function moveShare(IShare $share, $recipientId);
+
+    /**
+     * Get all shares shared by (initiated) by the provided user in a folder.
+     *
+     * @param string $userId
+     * @param Folder $node
+     * @param bool $reshares
+     * @param bool $shallow Whether the method should stop at the first level, or look into sub-folders.
+     * @return IShare[][] [$fileId => IShare[], ...]
+     * @since 11.0.0
+     */
+    public function getSharesInFolder($userId, Folder $node, $reshares = false, $shallow = true);
+
+    /**
+     * Get shares shared by (initiated) by the provided user.
+     *
+     * @param string $userId
+     * @param int $shareType
+     * @param Node|null $path
+     * @param bool $reshares
+     * @param int $limit The maximum number of returned results, -1 for all results
+     * @param int $offset
+     * @param bool $onlyValid Only returns valid shares, invalid shares will be deleted automatically and are not returned
+     * @return IShare[]
+     * @since 9.0.0
+     */
+    public function getSharesBy($userId, $shareType, $path = null, $reshares = false, $limit = 50, $offset = 0, bool $onlyValid = true);
+
+    /**
+     * Get shares shared with $user.
+     * Filter by $node if provided
+     *
+     * @param string $userId
+     * @param int $shareType
+     * @param Node|null $node
+     * @param int $limit The maximum number of shares returned, -1 for all
+     * @param int $offset
+     * @return IShare[]
+     * @since 9.0.0
+     */
+    public function getSharedWith($userId, $shareType, $node = null, $limit = 50, $offset = 0);
+
+    /**
+     * Get deleted shares shared with $user.
+     * Filter by $node if provided
+     *
+     * @param string $userId
+     * @param int $shareType
+     * @param Node|null $node
+     * @param int $limit The maximum number of shares returned, -1 for all
+     * @param int $offset
+     * @return IShare[]
+     * @since 14.0.0
+     */
+    public function getDeletedSharedWith($userId, $shareType, $node = null, $limit = 50, $offset = 0);
+
+    /**
+     * Retrieve a share by the share id.
+     * If the recipient is set make sure to retrieve the file for that user.
+     * This makes sure that if a user has moved/deleted a group share this
+     * is reflected.
+     *
+     * @param string $id
+     * @param string|null $recipient userID of the recipient
+     * @param bool $onlyValid Only returns valid shares, invalid shares will be deleted automatically and are not returned
+     * @return IShare
+     * @throws ShareNotFound
+     * @since 9.0.0
+     */
+    public function getShareById($id, $recipient = null, bool $onlyValid = true);
+
+    /**
+     * Get the share by token possible with password
+     *
+     * @param string $token
+     * @return IShare
+     * @throws ShareNotFound
+     * @since 9.0.0
+     */
+    public function getShareByToken($token);
+
+    /**
+     * Verify the password of a public share
+     *
+     * @param IShare $share
+     * @param ?string $password
+     * @return bool
+     * @since 9.0.0
+     */
+    public function checkPassword(IShare $share, $password);
+
+    /**
+     * The user with UID is deleted.
+     * All share providers have to cleanup the shares with this user as well
+     * as shares owned by this user.
+     * Shares only initiated by this user are fine.
+     *
+     * @param string $uid
+     * @since 9.1.0
+     */
+    public function userDeleted($uid);
+
+    /**
+     * The group with $gid is deleted
+     * We need to clear up all shares to this group
+     *
+     * @param string $gid
+     * @since 9.1.0
+     */
+    public function groupDeleted($gid);
+
+    /**
+     * The user $uid is deleted from the group $gid
+     * All user specific group shares have to be removed
+     *
+     * @param string $uid
+     * @param string $gid
+     * @since 9.1.0
+     */
+    public function userDeletedFromGroup($uid, $gid);
+
+    /**
+     * Get access list to a path. This means
+     * all the users that can access a given path.
+     *
+     * Consider:
+     * -root
+     * |-folder1 (23)
+     *  |-folder2 (32)
+     *   |-fileA (42)
+     *
+     * fileA is shared with user1 and user1@server1 and email1@maildomain1
+     * folder2 is shared with group2 (user4 is a member of group2)
+     * folder1 is shared with user2 (renamed to "folder (1)") and user2@server2
+     *                        and email2@maildomain2
+     *
+     * Then the access list to '/folder1/folder2/fileA' with $currentAccess is:
+     * [
+     *  users  => [
+     *      'user1' => ['node_id' => 42, 'node_path' => '/fileA'],
+     *      'user4' => ['node_id' => 32, 'node_path' => '/folder2'],
+     *      'user2' => ['node_id' => 23, 'node_path' => '/folder (1)'],
+     *  ],
+     *  remote => [
+     *      'user1@server1' => ['node_id' => 42, 'token' => 'SeCr3t'],
+     *      'user2@server2' => ['node_id' => 23, 'token' => 'FooBaR'],
+     *  ],
+     *  public => bool
+     *  mail => [
+     *      'email1@maildomain1' => ['node_id' => 42, 'token' => 'aBcDeFg'],
+     *      'email2@maildomain2' => ['node_id' => 23, 'token' => 'hIjKlMn'],
+     *  ]
+     *
+     * The access list to '/folder1/folder2/fileA' **without** $currentAccess is:
+     * [
+     *  users  => ['user1', 'user2', 'user4'],
+     *  remote => bool,
+     *  public => bool
+     *  mail => ['email1@maildomain1', 'email2@maildomain2']
+     * ]
+     *
+     * This is required for encryption/activity
+     *
+     * @param \OCP\Files\Node $path
+     * @param bool $recursive Should we check all parent folders as well
+     * @param bool $currentAccess Should the user have currently access to the file
+     * @return array
+     * @since 12
+     */
+    public function getAccessList(\OCP\Files\Node $path, $recursive = true, $currentAccess = false);
+
+    /**
+     * Instantiates a new share object. This is to be passed to
+     * createShare.
+     *
+     * @return IShare
+     * @since 9.0.0
+     */
+    public function newShare();
+
+    /**
+     * Is the share API enabled
+     *
+     * @return bool
+     * @since 9.0.0
+     */
+    public function shareApiEnabled();
+
+    /**
+     * Is public link sharing enabled
+     *
+     * @return bool
+     * @since 9.0.0
+     */
+    public function shareApiAllowLinks();
+
+    /**
+     * Is password on public link required
+     *
+     * @param bool $checkGroupMembership Check group membership exclusion
+     * @return bool
+     * @since 9.0.0
+     * @since 24.0.0 Added optional $checkGroupMembership parameter
+     */
+    public function shareApiLinkEnforcePassword(bool $checkGroupMembership = true);
+
+    /**
+     * Is default expire date enabled
+     *
+     * @return bool
+     * @since 9.0.0
+     */
+    public function shareApiLinkDefaultExpireDate();
+
+    /**
+     * Is default expire date enforced
+     *`
+     * @return bool
+     * @since 9.0.0
+     */
+    public function shareApiLinkDefaultExpireDateEnforced();
+
+    /**
+     * Number of default expire days
+     *
+     * @return int
+     * @since 9.0.0
+     */
+    public function shareApiLinkDefaultExpireDays();
+
+    /**
+     * Is default internal expire date enabled
+     *
+     * @return bool
+     * @since 22.0.0
+     */
+    public function shareApiInternalDefaultExpireDate(): bool;
+
+    /**
+     * Is default remote expire date enabled
+     *
+     * @return bool
+     * @since 22.0.0
+     */
+    public function shareApiRemoteDefaultExpireDate(): bool;
+
+    /**
+     * Is default expire date enforced
+     *
+     * @return bool
+     * @since 22.0.0
+     */
+    public function shareApiInternalDefaultExpireDateEnforced(): bool;
+
+    /**
+     * Is default expire date enforced for remote shares
+     *
+     * @return bool
+     * @since 22.0.0
+     */
+    public function shareApiRemoteDefaultExpireDateEnforced(): bool;
+
+    /**
+     * Number of default expire days
+     *
+     * @return int
+     * @since 22.0.0
+     */
+    public function shareApiInternalDefaultExpireDays(): int;
+
+    /**
+     * Number of default expire days for remote shares
+     *
+     * @return int
+     * @since 22.0.0
+     */
+    public function shareApiRemoteDefaultExpireDays(): int;
+
+    /**
+     * Allow public upload on link shares
+     *
+     * @return bool
+     * @since 9.0.0
+     */
+    public function shareApiLinkAllowPublicUpload();
+
+    /**
+     * check if user can only share with group members
+     * @return bool
+     * @since 9.0.0
+     */
+    public function shareWithGroupMembersOnly();
+
+    /**
+     * If shareWithGroupMembersOnly is enabled, return an optional
+     * list of groups that must be excluded from the principle of
+     * belonging to the same group.
+     * @return array
+     * @since 27.0.0
+     */
+    public function shareWithGroupMembersOnlyExcludeGroupsList();
+
+    /**
+     * Check if users can share with groups
+     * @return bool
+     * @since 9.0.1
+     */
+    public function allowGroupSharing();
+
+    /**
+     * Check if user enumeration is allowed
+     *
+     * @return bool
+     * @since 19.0.0
+     */
+    public function allowEnumeration(): bool;
+
+    /**
+     * Check if user enumeration is limited to the users groups
+     *
+     * @return bool
+     * @since 19.0.0
+     */
+    public function limitEnumerationToGroups(): bool;
+
+    /**
+     * Check if user enumeration is limited to the phonebook matches
+     *
+     * @return bool
+     * @since 21.0.1
+     */
+    public function limitEnumerationToPhone(): bool;
+
+    /**
+     * Check if user enumeration is allowed to return on full match
+     *
+     * @return bool
+     * @since 21.0.1
+     */
+    public function allowEnumerationFullMatch(): bool;
+
+    /**
+     * Check if the search should match the email
+     *
+     * @return bool
+     * @since 25.0.0
+     */
+    public function matchEmail(): bool;
+
+    /**
+     * Check if the search should ignore the second in parentheses display name if there is any
+     *
+     * @return bool
+     * @since 25.0.0
+     */
+    public function ignoreSecondDisplayName(): bool;
+
+
+    /**
+     * Check if custom tokens are allowed
+     *
+     * @since 31.0.0
+     */
+    public function allowCustomTokens(): bool;
+
+    /**
+     * Check if the current user can view the share
+     * even if the download is disabled.
+     *
+     * @since 32.0.0
+     */
+    public function allowViewWithoutDownload(): bool;
+
+    /**
+     * Check if the current user can enumerate the target user
+     *
+     * @param IUser|null $currentUser
+     * @param IUser $targetUser
+     * @return bool
+     * @since 23.0.0
+     */
+    public function currentUserCanEnumerateTargetUser(?IUser $currentUser, IUser $targetUser): bool;
+
+    /**
+     * Check if sharing is disabled for the given user
+     *
+     * @since 9.0.0
+     */
+    public function sharingDisabledForUser(?string $userId): bool;
+
+    /**
+     * Check if outgoing server2server shares are allowed
+     * @return bool
+     * @since 9.0.0
+     */
+    public function outgoingServer2ServerSharesAllowed();
+
+    /**
+     * Check if outgoing server2server shares are allowed
+     * @return bool
+     * @since 14.0.0
+     */
+    public function outgoingServer2ServerGroupSharesAllowed();
+
+
+    /**
+     * Check if a given share provider exists
+     * @param int $shareType
+     * @return bool
+     * @since 11.0.0
+     */
+    public function shareProviderExists($shareType);
+
+    /**
+     * @param string $shareProviderClass
+     * @since 21.0.0
+     */
+    public function registerShareProvider(string $shareProviderClass): void;
+
+    /**
+     * @Internal
+     *
+     * Get all the shares as iterable to reduce memory overhead
+     * Note, since this opens up database cursors the iterable should
+     * be fully itterated.
+     *
+     * @return iterable
+     * @since 18.0.0
+     */
+    public function getAllShares(): iterable;
+
+    /**
+     * Generate a unique share token
+     *
+     * @throws ShareTokenException Failed to generate a unique token
+     * @since 31.0.0
+     */
+    public function generateToken(): string;
 }

lib/public/Share/IShare.php

Indentation +618 added lines, -618 removed lines

@@ -22,622 +22,622 @@
  * @since 9.0.0
  */
 interface IShare {
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_USER = 0;
-
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_GROUP = 1;
-
-	/**
-	 * @internal
-	 * @since 18.0.0
-	 */
-	public const TYPE_USERGROUP = 2;
-
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_LINK = 3;
-
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_EMAIL = 4;
-
-	/**
-	 * ToDo Check if it is still in use otherwise remove it
-	 * @since 17.0.0
-	 */
-	// public const TYPE_CONTACT = 5;
-
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_REMOTE = 6;
-
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_CIRCLE = 7;
-
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_GUEST = 8;
-
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_REMOTE_GROUP = 9;
-
-	/**
-	 * @since 17.0.0
-	 */
-	public const TYPE_ROOM = 10;
-
-	/**
-	 * Internal type used by RoomShareProvider
-	 * @since 17.0.0
-	 */
-	// const TYPE_USERROOM = 11;
-
-	/**
-	 * @since 21.0.0
-	 */
-	public const TYPE_DECK = 12;
-
-	/**
-	 * @internal
-	 * @since 21.0.0
-	 */
-	public const TYPE_DECK_USER = 13;
-
-	/**
-	 * @since 26.0.0
-	 */
-	public const TYPE_SCIENCEMESH = 15;
-
-	/**
-	 * @since 18.0.0
-	 */
-	public const STATUS_PENDING = 0;
-
-	/**
-	 * @since 18.0.0
-	 */
-	public const STATUS_ACCEPTED = 1;
-
-	/**
-	 * @since 18.0.0
-	 */
-	public const STATUS_REJECTED = 2;
-
-	/**
-	 * Set the internal id of the share
-	 * It is only allowed to set the internal id of a share once.
-	 * Attempts to override the internal id will result in an IllegalIDChangeException
-	 *
-	 * @param string $id
-	 * @return \OCP\Share\IShare
-	 * @throws IllegalIDChangeException
-	 * @throws \InvalidArgumentException
-	 * @since 9.1.0
-	 */
-	public function setId($id);
-
-	/**
-	 * Get the internal id of the share.
-	 *
-	 * @return string
-	 * @since 9.0.0
-	 */
-	public function getId();
-
-	/**
-	 * Get the full share id. This is the <providerid>:<internalid>.
-	 * The full id is unique in the system.
-	 *
-	 * @return string
-	 * @since 9.0.0
-	 * @throws \UnexpectedValueException If the fullId could not be constructed
-	 */
-	public function getFullId();
-
-	/**
-	 * Set the provider id of the share
-	 * It is only allowed to set the provider id of a share once.
-	 * Attempts to override the provider id will result in an IllegalIDChangeException
-	 *
-	 * @param string $id
-	 * @return \OCP\Share\IShare
-	 * @throws IllegalIDChangeException
-	 * @throws \InvalidArgumentException
-	 * @since 9.1.0
-	 */
-	public function setProviderId($id);
-
-	/**
-	 * Set the node of the file/folder that is shared
-	 *
-	 * @param Node $node
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setNode(Node $node);
-
-	/**
-	 * Get the node of the file/folder that is shared
-	 *
-	 * @return File|Folder
-	 * @since 9.0.0
-	 * @throws NotFoundException
-	 */
-	public function getNode();
-
-	/**
-	 * Set file id for lazy evaluation of the node
-	 * @param int $fileId
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setNodeId($fileId);
-
-	/**
-	 * Get the fileid of the node of this share
-	 * @return int
-	 * @since 9.0.0
-	 * @throws NotFoundException
-	 */
-	public function getNodeId(): int;
-
-	/**
-	 * Set the type of node (file/folder)
-	 *
-	 * @param string $type
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setNodeType($type);
-
-	/**
-	 * Get the type of node (file/folder)
-	 *
-	 * @return string
-	 * @since 9.0.0
-	 * @throws NotFoundException
-	 */
-	public function getNodeType();
-
-	/**
-	 * Set the shareType
-	 *
-	 * @param int $shareType
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setShareType($shareType);
-
-	/**
-	 * Get the shareType
-	 *
-	 * @return int
-	 * @since 9.0.0
-	 */
-	public function getShareType();
-
-	/**
-	 * Set the receiver of this share.
-	 *
-	 * @param string $sharedWith
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setSharedWith($sharedWith);
-
-	/**
-	 * Get the receiver of this share.
-	 *
-	 * @return string
-	 * @since 9.0.0
-	 */
-	public function getSharedWith();
-
-	/**
-	 * Set the display name of the receiver of this share.
-	 *
-	 * @param string $displayName
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 14.0.0
-	 */
-	public function setSharedWithDisplayName($displayName);
-
-	/**
-	 * Get the display name of the receiver of this share.
-	 *
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function getSharedWithDisplayName();
-
-	/**
-	 * Set the avatar of the receiver of this share.
-	 *
-	 * @param string $src
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 14.0.0
-	 */
-	public function setSharedWithAvatar($src);
-
-	/**
-	 * Get the avatar of the receiver of this share.
-	 *
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function getSharedWithAvatar();
-
-	/**
-	 * Set the permissions.
-	 * See \OCP\Constants::PERMISSION_*
-	 *
-	 * @param int $permissions
-	 * @return IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setPermissions($permissions);
-
-	/**
-	 * Get the share permissions
-	 * See \OCP\Constants::PERMISSION_*
-	 *
-	 * @return int
-	 * @since 9.0.0
-	 */
-	public function getPermissions();
-
-	/**
-	 * Create share attributes object
-	 *
-	 * @since 25.0.0
-	 * @return IAttributes
-	 */
-	public function newAttributes(): IAttributes;
-
-	/**
-	 * Set share attributes
-	 *
-	 * @param ?IAttributes $attributes
-	 * @since 25.0.0
-	 * @return IShare The modified object
-	 */
-	public function setAttributes(?IAttributes $attributes);
-
-	/**
-	 * Get share attributes
-	 *
-	 * @since 25.0.0
-	 * @return ?IAttributes
-	 */
-	public function getAttributes(): ?IAttributes;
-
-	/**
-	 * Set the accepted status
-	 * See self::STATUS_*
-	 *
-	 * @param int $status
-	 * @return IShare The modified object
-	 * @since 18.0.0
-	 */
-	public function setStatus(int $status): IShare;
-
-	/**
-	 * Get the accepted status
-	 * See self::STATUS_*
-	 *
-	 * @return int
-	 * @since 18.0.0
-	 */
-	public function getStatus(): int;
-
-	/**
-	 * Attach a note to a share
-	 *
-	 * @param string $note
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 14.0.0
-	 */
-	public function setNote($note);
-
-	/**
-	 * Get note attached to a share
-	 *
-	 * @return string
-	 * @since 14.0.0
-	 */
-	public function getNote();
-
-
-	/**
-	 * Set the expiration date
-	 *
-	 * @param \DateTime|null $expireDate
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setExpirationDate(?\DateTime $expireDate);
-
-	/**
-	 * Get the expiration date
-	 *
-	 * @return \DateTime|null
-	 * @since 9.0.0
-	 */
-	public function getExpirationDate();
-
-	/**
-	 * Set overwrite flag for falsy expiry date values
-	 *
-	 * @param bool $noExpirationDate
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 30.0.0
-	 */
-	public function setNoExpirationDate(bool $noExpirationDate);
-
-
-	/**
-	 * Get value of overwrite falsy expiry date flag
-	 *
-	 * @return bool
-	 * @since 30.0.0
-	 */
-	public function getNoExpirationDate();
-
-	/**
-	 * Is the share expired ?
-	 *
-	 * @return boolean
-	 * @since 18.0.0
-	 */
-	public function isExpired();
-
-	/**
-	 * set a label for a share, some shares, e.g. public links can have a label
-	 *
-	 * @param string $label
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 15.0.0
-	 */
-	public function setLabel($label);
-
-	/**
-	 * get label for the share, some shares, e.g. public links can have a label
-	 *
-	 * @return string
-	 * @since 15.0.0
-	 */
-	public function getLabel();
-
-	/**
-	 * Set the sharer of the path.
-	 *
-	 * @param string $sharedBy
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setSharedBy($sharedBy);
-
-	/**
-	 * Get share sharer
-	 *
-	 * @return string
-	 * @since 9.0.0
-	 */
-	public function getSharedBy();
-
-	/**
-	 * Set the original share owner (who owns the path that is shared)
-	 *
-	 * @param string $shareOwner
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setShareOwner($shareOwner);
-
-	/**
-	 * Get the original share owner (who owns the path that is shared)
-	 *
-	 * @return string
-	 * @since 9.0.0
-	 */
-	public function getShareOwner();
-
-	/**
-	 * Set the password for this share.
-	 * When the share is passed to the share manager to be created
-	 * or updated the password will be hashed.
-	 *
-	 * @param string|null $password
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setPassword($password);
-
-	/**
-	 * Get the password of this share.
-	 * If this share is obtained via a shareprovider the password is
-	 * hashed.
-	 *
-	 * @return string|null
-	 * @since 9.0.0
-	 */
-	public function getPassword();
-
-	/**
-	 * Set the password's expiration time of this share.
-	 *
-	 * @return self The modified object
-	 * @since 24.0.0
-	 */
-	public function setPasswordExpirationTime(?\DateTimeInterface $passwordExpirationTime = null): IShare;
-
-	/**
-	 * Get the password's expiration time of this share.
-	 * @since 24.0.0
-	 */
-	public function getPasswordExpirationTime(): ?\DateTimeInterface;
-
-	/**
-	 * Set if the recipient can start a conversation with the owner to get the
-	 * password using Nextcloud Talk.
-	 *
-	 * @param bool $sendPasswordByTalk
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 14.0.0
-	 */
-	public function setSendPasswordByTalk(bool $sendPasswordByTalk);
-
-	/**
-	 * Get if the recipient can start a conversation with the owner to get the
-	 * password using Nextcloud Talk.
-	 * The returned value does not take into account other factors, like Talk
-	 * being enabled for the owner of the share or not; it just cover whether
-	 * the option is enabled for the share itself or not.
-	 *
-	 * @return bool
-	 * @since 14.0.0
-	 */
-	public function getSendPasswordByTalk(): bool;
-
-	/**
-	 * Set the public link token.
-	 *
-	 * @param string $token
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setToken($token);
-
-	/**
-	 * Get the public link token.
-	 *
-	 * @return string
-	 * @since 9.0.0
-	 */
-	public function getToken();
-
-	/**
-	 * Set the target path of this share relative to the recipients user folder.
-	 *
-	 * @param string $target
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setTarget($target);
-
-	/**
-	 * Get the target path of this share relative to the recipients user folder.
-	 *
-	 * @return string
-	 * @since 9.0.0
-	 */
-	public function getTarget();
-
-	/**
-	 * Set the time this share was created
-	 *
-	 * @param \DateTime $shareTime
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setShareTime(\DateTime $shareTime);
-
-	/**
-	 * Get the timestamp this share was created
-	 *
-	 * @return \DateTime
-	 * @since 9.0.0
-	 */
-	public function getShareTime();
-
-	/**
-	 * Set if the recipient should be informed by mail about the share.
-	 *
-	 * @param bool $mailSend
-	 * @return \OCP\Share\IShare The modified object
-	 * @since 9.0.0
-	 */
-	public function setMailSend($mailSend);
-
-	/**
-	 * Get if the recipient should be informed by mail about the share.
-	 *
-	 * @return bool
-	 * @since 9.0.0
-	 */
-	public function getMailSend();
-
-	/**
-	 * Set the cache entry for the shared node
-	 *
-	 * @param ICacheEntry $entry
-	 * @return void
-	 * @since 11.0.0
-	 */
-	public function setNodeCacheEntry(ICacheEntry $entry);
-
-	/**
-	 * Get the cache entry for the shared node
-	 *
-	 * @return null|ICacheEntry
-	 * @since 11.0.0
-	 */
-	public function getNodeCacheEntry();
-
-	/**
-	 * Sets a shares hide download state
-	 * This is mainly for public shares. It will signal that the share page should
-	 * hide download buttons etc.
-	 *
-	 * @param bool $hide
-	 * @return IShare
-	 * @since 15.0.0
-	 */
-	public function setHideDownload(bool $hide): IShare;
-
-	/**
-	 * Gets a shares hide download state
-	 * This is mainly for public shares. It will signal that the share page should
-	 * hide download buttons etc.
-	 *
-	 * @return bool
-	 * @since 15.0.0
-	 */
-	public function getHideDownload(): bool;
-
-	/**
-	 * Sets a flag that stores whether a reminder via email has been sent
-	 *
-	 * @return self The modified object
-	 * @since 31.0.0
-	 */
-	public function setReminderSent(bool $reminderSent): IShare;
-
-	/**
-	 * Gets a flag that stores whether a reminder via email has been sent
-	 *
-	 * @return bool
-	 * @since 31.0.0
-	 */
-	public function getReminderSent(): bool;
-
-	/**
-	 * Check if the current user can see this share files contents.
-	 * This will check the download permissions as well as the global
-	 * admin setting to allow viewing files without downloading.
-	 */
-	public function canSeeContent(): bool;
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_USER = 0;
+
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_GROUP = 1;
+
+    /**
+     * @internal
+     * @since 18.0.0
+     */
+    public const TYPE_USERGROUP = 2;
+
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_LINK = 3;
+
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_EMAIL = 4;
+
+    /**
+     * ToDo Check if it is still in use otherwise remove it
+     * @since 17.0.0
+     */
+    // public const TYPE_CONTACT = 5;
+
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_REMOTE = 6;
+
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_CIRCLE = 7;
+
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_GUEST = 8;
+
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_REMOTE_GROUP = 9;
+
+    /**
+     * @since 17.0.0
+     */
+    public const TYPE_ROOM = 10;
+
+    /**
+     * Internal type used by RoomShareProvider
+     * @since 17.0.0
+     */
+    // const TYPE_USERROOM = 11;
+
+    /**
+     * @since 21.0.0
+     */
+    public const TYPE_DECK = 12;
+
+    /**
+     * @internal
+     * @since 21.0.0
+     */
+    public const TYPE_DECK_USER = 13;
+
+    /**
+     * @since 26.0.0
+     */
+    public const TYPE_SCIENCEMESH = 15;
+
+    /**
+     * @since 18.0.0
+     */
+    public const STATUS_PENDING = 0;
+
+    /**
+     * @since 18.0.0
+     */
+    public const STATUS_ACCEPTED = 1;
+
+    /**
+     * @since 18.0.0
+     */
+    public const STATUS_REJECTED = 2;
+
+    /**
+     * Set the internal id of the share
+     * It is only allowed to set the internal id of a share once.
+     * Attempts to override the internal id will result in an IllegalIDChangeException
+     *
+     * @param string $id
+     * @return \OCP\Share\IShare
+     * @throws IllegalIDChangeException
+     * @throws \InvalidArgumentException
+     * @since 9.1.0
+     */
+    public function setId($id);
+
+    /**
+     * Get the internal id of the share.
+     *
+     * @return string
+     * @since 9.0.0
+     */
+    public function getId();
+
+    /**
+     * Get the full share id. This is the <providerid>:<internalid>.
+     * The full id is unique in the system.
+     *
+     * @return string
+     * @since 9.0.0
+     * @throws \UnexpectedValueException If the fullId could not be constructed
+     */
+    public function getFullId();
+
+    /**
+     * Set the provider id of the share
+     * It is only allowed to set the provider id of a share once.
+     * Attempts to override the provider id will result in an IllegalIDChangeException
+     *
+     * @param string $id
+     * @return \OCP\Share\IShare
+     * @throws IllegalIDChangeException
+     * @throws \InvalidArgumentException
+     * @since 9.1.0
+     */
+    public function setProviderId($id);
+
+    /**
+     * Set the node of the file/folder that is shared
+     *
+     * @param Node $node
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setNode(Node $node);
+
+    /**
+     * Get the node of the file/folder that is shared
+     *
+     * @return File|Folder
+     * @since 9.0.0
+     * @throws NotFoundException
+     */
+    public function getNode();
+
+    /**
+     * Set file id for lazy evaluation of the node
+     * @param int $fileId
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setNodeId($fileId);
+
+    /**
+     * Get the fileid of the node of this share
+     * @return int
+     * @since 9.0.0
+     * @throws NotFoundException
+     */
+    public function getNodeId(): int;
+
+    /**
+     * Set the type of node (file/folder)
+     *
+     * @param string $type
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setNodeType($type);
+
+    /**
+     * Get the type of node (file/folder)
+     *
+     * @return string
+     * @since 9.0.0
+     * @throws NotFoundException
+     */
+    public function getNodeType();
+
+    /**
+     * Set the shareType
+     *
+     * @param int $shareType
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setShareType($shareType);
+
+    /**
+     * Get the shareType
+     *
+     * @return int
+     * @since 9.0.0
+     */
+    public function getShareType();
+
+    /**
+     * Set the receiver of this share.
+     *
+     * @param string $sharedWith
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setSharedWith($sharedWith);
+
+    /**
+     * Get the receiver of this share.
+     *
+     * @return string
+     * @since 9.0.0
+     */
+    public function getSharedWith();
+
+    /**
+     * Set the display name of the receiver of this share.
+     *
+     * @param string $displayName
+     * @return \OCP\Share\IShare The modified object
+     * @since 14.0.0
+     */
+    public function setSharedWithDisplayName($displayName);
+
+    /**
+     * Get the display name of the receiver of this share.
+     *
+     * @return string
+     * @since 14.0.0
+     */
+    public function getSharedWithDisplayName();
+
+    /**
+     * Set the avatar of the receiver of this share.
+     *
+     * @param string $src
+     * @return \OCP\Share\IShare The modified object
+     * @since 14.0.0
+     */
+    public function setSharedWithAvatar($src);
+
+    /**
+     * Get the avatar of the receiver of this share.
+     *
+     * @return string
+     * @since 14.0.0
+     */
+    public function getSharedWithAvatar();
+
+    /**
+     * Set the permissions.
+     * See \OCP\Constants::PERMISSION_*
+     *
+     * @param int $permissions
+     * @return IShare The modified object
+     * @since 9.0.0
+     */
+    public function setPermissions($permissions);
+
+    /**
+     * Get the share permissions
+     * See \OCP\Constants::PERMISSION_*
+     *
+     * @return int
+     * @since 9.0.0
+     */
+    public function getPermissions();
+
+    /**
+     * Create share attributes object
+     *
+     * @since 25.0.0
+     * @return IAttributes
+     */
+    public function newAttributes(): IAttributes;
+
+    /**
+     * Set share attributes
+     *
+     * @param ?IAttributes $attributes
+     * @since 25.0.0
+     * @return IShare The modified object
+     */
+    public function setAttributes(?IAttributes $attributes);
+
+    /**
+     * Get share attributes
+     *
+     * @since 25.0.0
+     * @return ?IAttributes
+     */
+    public function getAttributes(): ?IAttributes;
+
+    /**
+     * Set the accepted status
+     * See self::STATUS_*
+     *
+     * @param int $status
+     * @return IShare The modified object
+     * @since 18.0.0
+     */
+    public function setStatus(int $status): IShare;
+
+    /**
+     * Get the accepted status
+     * See self::STATUS_*
+     *
+     * @return int
+     * @since 18.0.0
+     */
+    public function getStatus(): int;
+
+    /**
+     * Attach a note to a share
+     *
+     * @param string $note
+     * @return \OCP\Share\IShare The modified object
+     * @since 14.0.0
+     */
+    public function setNote($note);
+
+    /**
+     * Get note attached to a share
+     *
+     * @return string
+     * @since 14.0.0
+     */
+    public function getNote();
+
+
+    /**
+     * Set the expiration date
+     *
+     * @param \DateTime|null $expireDate
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setExpirationDate(?\DateTime $expireDate);
+
+    /**
+     * Get the expiration date
+     *
+     * @return \DateTime|null
+     * @since 9.0.0
+     */
+    public function getExpirationDate();
+
+    /**
+     * Set overwrite flag for falsy expiry date values
+     *
+     * @param bool $noExpirationDate
+     * @return \OCP\Share\IShare The modified object
+     * @since 30.0.0
+     */
+    public function setNoExpirationDate(bool $noExpirationDate);
+
+
+    /**
+     * Get value of overwrite falsy expiry date flag
+     *
+     * @return bool
+     * @since 30.0.0
+     */
+    public function getNoExpirationDate();
+
+    /**
+     * Is the share expired ?
+     *
+     * @return boolean
+     * @since 18.0.0
+     */
+    public function isExpired();
+
+    /**
+     * set a label for a share, some shares, e.g. public links can have a label
+     *
+     * @param string $label
+     * @return \OCP\Share\IShare The modified object
+     * @since 15.0.0
+     */
+    public function setLabel($label);
+
+    /**
+     * get label for the share, some shares, e.g. public links can have a label
+     *
+     * @return string
+     * @since 15.0.0
+     */
+    public function getLabel();
+
+    /**
+     * Set the sharer of the path.
+     *
+     * @param string $sharedBy
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setSharedBy($sharedBy);
+
+    /**
+     * Get share sharer
+     *
+     * @return string
+     * @since 9.0.0
+     */
+    public function getSharedBy();
+
+    /**
+     * Set the original share owner (who owns the path that is shared)
+     *
+     * @param string $shareOwner
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setShareOwner($shareOwner);
+
+    /**
+     * Get the original share owner (who owns the path that is shared)
+     *
+     * @return string
+     * @since 9.0.0
+     */
+    public function getShareOwner();
+
+    /**
+     * Set the password for this share.
+     * When the share is passed to the share manager to be created
+     * or updated the password will be hashed.
+     *
+     * @param string|null $password
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setPassword($password);
+
+    /**
+     * Get the password of this share.
+     * If this share is obtained via a shareprovider the password is
+     * hashed.
+     *
+     * @return string|null
+     * @since 9.0.0
+     */
+    public function getPassword();
+
+    /**
+     * Set the password's expiration time of this share.
+     *
+     * @return self The modified object
+     * @since 24.0.0
+     */
+    public function setPasswordExpirationTime(?\DateTimeInterface $passwordExpirationTime = null): IShare;
+
+    /**
+     * Get the password's expiration time of this share.
+     * @since 24.0.0
+     */
+    public function getPasswordExpirationTime(): ?\DateTimeInterface;
+
+    /**
+     * Set if the recipient can start a conversation with the owner to get the
+     * password using Nextcloud Talk.
+     *
+     * @param bool $sendPasswordByTalk
+     * @return \OCP\Share\IShare The modified object
+     * @since 14.0.0
+     */
+    public function setSendPasswordByTalk(bool $sendPasswordByTalk);
+
+    /**
+     * Get if the recipient can start a conversation with the owner to get the
+     * password using Nextcloud Talk.
+     * The returned value does not take into account other factors, like Talk
+     * being enabled for the owner of the share or not; it just cover whether
+     * the option is enabled for the share itself or not.
+     *
+     * @return bool
+     * @since 14.0.0
+     */
+    public function getSendPasswordByTalk(): bool;
+
+    /**
+     * Set the public link token.
+     *
+     * @param string $token
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setToken($token);
+
+    /**
+     * Get the public link token.
+     *
+     * @return string
+     * @since 9.0.0
+     */
+    public function getToken();
+
+    /**
+     * Set the target path of this share relative to the recipients user folder.
+     *
+     * @param string $target
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setTarget($target);
+
+    /**
+     * Get the target path of this share relative to the recipients user folder.
+     *
+     * @return string
+     * @since 9.0.0
+     */
+    public function getTarget();
+
+    /**
+     * Set the time this share was created
+     *
+     * @param \DateTime $shareTime
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setShareTime(\DateTime $shareTime);
+
+    /**
+     * Get the timestamp this share was created
+     *
+     * @return \DateTime
+     * @since 9.0.0
+     */
+    public function getShareTime();
+
+    /**
+     * Set if the recipient should be informed by mail about the share.
+     *
+     * @param bool $mailSend
+     * @return \OCP\Share\IShare The modified object
+     * @since 9.0.0
+     */
+    public function setMailSend($mailSend);
+
+    /**
+     * Get if the recipient should be informed by mail about the share.
+     *
+     * @return bool
+     * @since 9.0.0
+     */
+    public function getMailSend();
+
+    /**
+     * Set the cache entry for the shared node
+     *
+     * @param ICacheEntry $entry
+     * @return void
+     * @since 11.0.0
+     */
+    public function setNodeCacheEntry(ICacheEntry $entry);
+
+    /**
+     * Get the cache entry for the shared node
+     *
+     * @return null|ICacheEntry
+     * @since 11.0.0
+     */
+    public function getNodeCacheEntry();
+
+    /**
+     * Sets a shares hide download state
+     * This is mainly for public shares. It will signal that the share page should
+     * hide download buttons etc.
+     *
+     * @param bool $hide
+     * @return IShare
+     * @since 15.0.0
+     */
+    public function setHideDownload(bool $hide): IShare;
+
+    /**
+     * Gets a shares hide download state
+     * This is mainly for public shares. It will signal that the share page should
+     * hide download buttons etc.
+     *
+     * @return bool
+     * @since 15.0.0
+     */
+    public function getHideDownload(): bool;
+
+    /**
+     * Sets a flag that stores whether a reminder via email has been sent
+     *
+     * @return self The modified object
+     * @since 31.0.0
+     */
+    public function setReminderSent(bool $reminderSent): IShare;
+
+    /**
+     * Gets a flag that stores whether a reminder via email has been sent
+     *
+     * @return bool
+     * @since 31.0.0
+     */
+    public function getReminderSent(): bool;
+
+    /**
+     * Check if the current user can see this share files contents.
+     * This will check the download permissions as well as the global
+     * admin setting to allow viewing files without downloading.
+     */
+    public function canSeeContent(): bool;
 }

lib/private/Share20/Share.php

Indentation +621 added lines, -621 removed lines

@@ -21,626 +21,626 @@
 use OCP\Share\IShare;
 
 class Share implements IShare {
-	/** @var string */
-	private $id;
-	/** @var string */
-	private $providerId;
-	/** @var Node */
-	private $node;
-	/** @var int */
-	private $fileId;
-	/** @var string */
-	private $nodeType;
-	/** @var int */
-	private $shareType;
-	/** @var string */
-	private $sharedWith;
-	/** @var string */
-	private $sharedWithDisplayName;
-	/** @var string */
-	private $sharedWithAvatar;
-	/** @var string */
-	private $sharedBy;
-	/** @var string */
-	private $shareOwner;
-	/** @var int */
-	private $permissions;
-	/** @var IAttributes */
-	private $attributes;
-	/** @var int */
-	private $status;
-	/** @var string */
-	private $note = '';
-	/** @var \DateTime */
-	private $expireDate;
-	/** @var string */
-	private $password;
-	private ?\DateTimeInterface $passwordExpirationTime = null;
-	/** @var bool */
-	private $sendPasswordByTalk = false;
-	/** @var string */
-	private $token;
-	/** @var int */
-	private $parent;
-	/** @var string */
-	private $target;
-	/** @var \DateTime */
-	private $shareTime;
-	/** @var bool */
-	private $mailSend;
-	/** @var ICacheEntry|null */
-	private $nodeCacheEntry;
-	/** @var bool */
-	private $hideDownload = false;
-	private bool $reminderSent = false;
-
-	private string $label = '';
-	private bool $noExpirationDate = false;
-
-	public function __construct(
-		private IRootFolder $rootFolder,
-		private IUserManager $userManager,
-	) {
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setId($id) {
-		/** @var mixed $id Let's be safe until strong typing */
-		if (is_int($id)) {
-			$id = (string)$id;
-		}
-
-		if (!is_string($id)) {
-			throw new \InvalidArgumentException('String expected.');
-		}
-
-		if ($this->id !== null) {
-			throw new IllegalIDChangeException('Not allowed to assign a new internal id to a share');
-		}
-
-		$this->id = trim($id);
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getId() {
-		return $this->id;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getFullId() {
-		if ($this->providerId === null || $this->id === null) {
-			throw new \UnexpectedValueException;
-		}
-		return $this->providerId . ':' . $this->id;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setProviderId($id) {
-		if (!is_string($id)) {
-			throw new \InvalidArgumentException('String expected.');
-		}
-
-		if ($this->providerId !== null) {
-			throw new IllegalIDChangeException('Not allowed to assign a new provider id to a share');
-		}
-
-		$this->providerId = trim($id);
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setNode(Node $node) {
-		$this->fileId = null;
-		$this->nodeType = null;
-		$this->node = $node;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getNode() {
-		if ($this->node === null) {
-			if ($this->shareOwner === null || $this->fileId === null) {
-				throw new NotFoundException();
-			}
-
-			// for federated shares the owner can be a remote user, in this
-			// case we use the initiator
-			if ($this->userManager->userExists($this->shareOwner)) {
-				$userFolder = $this->rootFolder->getUserFolder($this->shareOwner);
-			} else {
-				$userFolder = $this->rootFolder->getUserFolder($this->sharedBy);
-			}
-
-			$node = $userFolder->getFirstNodeById($this->fileId);
-			if (!$node) {
-				throw new NotFoundException('Node for share not found, fileid: ' . $this->fileId);
-			}
-
-			$this->node = $node;
-		}
-
-		return $this->node;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setNodeId($fileId) {
-		$this->node = null;
-		$this->fileId = $fileId;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getNodeId(): int {
-		if ($this->fileId === null) {
-			$this->fileId = $this->getNode()->getId();
-		}
-
-		if ($this->fileId === null) {
-			throw new NotFoundException('Share source not found');
-		} else {
-			return $this->fileId;
-		}
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setNodeType($type) {
-		if ($type !== 'file' && $type !== 'folder') {
-			throw new \InvalidArgumentException();
-		}
-
-		$this->nodeType = $type;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getNodeType() {
-		if ($this->nodeType === null) {
-			if ($this->getNodeCacheEntry()) {
-				$info = $this->getNodeCacheEntry();
-				$this->nodeType = $info->getMimeType() === FileInfo::MIMETYPE_FOLDER ? 'folder' : 'file';
-			} else {
-				$node = $this->getNode();
-				$this->nodeType = $node instanceof File ? 'file' : 'folder';
-			}
-		}
-
-		return $this->nodeType;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setShareType($shareType) {
-		$this->shareType = $shareType;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getShareType() {
-		return $this->shareType;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setSharedWith($sharedWith) {
-		if (!is_string($sharedWith)) {
-			throw new \InvalidArgumentException();
-		}
-		$this->sharedWith = $sharedWith;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getSharedWith() {
-		return $this->sharedWith;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setSharedWithDisplayName($displayName) {
-		if (!is_string($displayName)) {
-			throw new \InvalidArgumentException();
-		}
-		$this->sharedWithDisplayName = $displayName;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getSharedWithDisplayName() {
-		return $this->sharedWithDisplayName;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setSharedWithAvatar($src) {
-		if (!is_string($src)) {
-			throw new \InvalidArgumentException();
-		}
-		$this->sharedWithAvatar = $src;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getSharedWithAvatar() {
-		return $this->sharedWithAvatar;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setPermissions($permissions) {
-		//TODO checks
-
-		$this->permissions = $permissions;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getPermissions() {
-		return $this->permissions;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function newAttributes(): IAttributes {
-		return new ShareAttributes();
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setAttributes(?IAttributes $attributes) {
-		$this->attributes = $attributes;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getAttributes(): ?IAttributes {
-		return $this->attributes;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setStatus(int $status): IShare {
-		$this->status = $status;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getStatus(): int {
-		return $this->status;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setNote($note) {
-		$this->note = $note;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getNote() {
-		if (is_string($this->note)) {
-			return $this->note;
-		}
-		return '';
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setLabel($label) {
-		$this->label = $label;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getLabel() {
-		return $this->label;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setExpirationDate($expireDate) {
-		//TODO checks
-
-		$this->expireDate = $expireDate;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getExpirationDate() {
-		return $this->expireDate;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setNoExpirationDate(bool $noExpirationDate) {
-		$this->noExpirationDate = $noExpirationDate;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getNoExpirationDate(): bool {
-		return $this->noExpirationDate;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function isExpired() {
-		return $this->getExpirationDate() !== null &&
-			$this->getExpirationDate() <= new \DateTime();
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setSharedBy($sharedBy) {
-		if (!is_string($sharedBy)) {
-			throw new \InvalidArgumentException();
-		}
-		//TODO checks
-		$this->sharedBy = $sharedBy;
-
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getSharedBy() {
-		//TODO check if set
-		return $this->sharedBy;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setShareOwner($shareOwner) {
-		if (!is_string($shareOwner)) {
-			throw new \InvalidArgumentException();
-		}
-		//TODO checks
-
-		$this->shareOwner = $shareOwner;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getShareOwner() {
-		//TODO check if set
-		return $this->shareOwner;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setPassword($password) {
-		$this->password = $password;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getPassword() {
-		return $this->password;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setPasswordExpirationTime(?\DateTimeInterface $passwordExpirationTime = null): IShare {
-		$this->passwordExpirationTime = $passwordExpirationTime;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getPasswordExpirationTime(): ?\DateTimeInterface {
-		return $this->passwordExpirationTime;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setSendPasswordByTalk(bool $sendPasswordByTalk) {
-		$this->sendPasswordByTalk = $sendPasswordByTalk;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getSendPasswordByTalk(): bool {
-		return $this->sendPasswordByTalk;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setToken($token) {
-		$this->token = $token;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getToken() {
-		return $this->token;
-	}
-
-	/**
-	 * Set the parent of this share
-	 *
-	 * @param int $parent
-	 * @return IShare
-	 * @deprecated 12.0.0 The new shares do not have parents. This is just here for legacy reasons.
-	 */
-	public function setParent($parent) {
-		$this->parent = $parent;
-		return $this;
-	}
-
-	/**
-	 * Get the parent of this share.
-	 *
-	 * @return int
-	 * @deprecated 12.0.0 The new shares do not have parents. This is just here for legacy reasons.
-	 */
-	public function getParent() {
-		return $this->parent;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setTarget($target) {
-		$this->target = $target;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getTarget() {
-		return $this->target;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setShareTime(\DateTime $shareTime) {
-		$this->shareTime = $shareTime;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getShareTime() {
-		return $this->shareTime;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setMailSend($mailSend) {
-		$this->mailSend = $mailSend;
-		return $this;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getMailSend() {
-		return $this->mailSend;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function setNodeCacheEntry(ICacheEntry $entry) {
-		$this->nodeCacheEntry = $entry;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getNodeCacheEntry() {
-		return $this->nodeCacheEntry;
-	}
-
-	public function setHideDownload(bool $hide): IShare {
-		$this->hideDownload = $hide;
-		return $this;
-	}
-
-	public function getHideDownload(): bool {
-		return $this->hideDownload;
-	}
-
-	public function setReminderSent(bool $reminderSent): IShare {
-		$this->reminderSent = $reminderSent;
-		return $this;
-	}
-
-	public function getReminderSent(): bool {
-		return $this->reminderSent;
-	}
-
-	public function canSeeContent(): bool {
-		$shareManager = Server::get(IManager::class);
-
-		$allowViewWithoutDownload = $shareManager->allowViewWithoutDownload();
-		// If the share manager allows viewing without download, we can always see the content.
-		if ($allowViewWithoutDownload) {
-			return true;
-		}
+    /** @var string */
+    private $id;
+    /** @var string */
+    private $providerId;
+    /** @var Node */
+    private $node;
+    /** @var int */
+    private $fileId;
+    /** @var string */
+    private $nodeType;
+    /** @var int */
+    private $shareType;
+    /** @var string */
+    private $sharedWith;
+    /** @var string */
+    private $sharedWithDisplayName;
+    /** @var string */
+    private $sharedWithAvatar;
+    /** @var string */
+    private $sharedBy;
+    /** @var string */
+    private $shareOwner;
+    /** @var int */
+    private $permissions;
+    /** @var IAttributes */
+    private $attributes;
+    /** @var int */
+    private $status;
+    /** @var string */
+    private $note = '';
+    /** @var \DateTime */
+    private $expireDate;
+    /** @var string */
+    private $password;
+    private ?\DateTimeInterface $passwordExpirationTime = null;
+    /** @var bool */
+    private $sendPasswordByTalk = false;
+    /** @var string */
+    private $token;
+    /** @var int */
+    private $parent;
+    /** @var string */
+    private $target;
+    /** @var \DateTime */
+    private $shareTime;
+    /** @var bool */
+    private $mailSend;
+    /** @var ICacheEntry|null */
+    private $nodeCacheEntry;
+    /** @var bool */
+    private $hideDownload = false;
+    private bool $reminderSent = false;
+
+    private string $label = '';
+    private bool $noExpirationDate = false;
+
+    public function __construct(
+        private IRootFolder $rootFolder,
+        private IUserManager $userManager,
+    ) {
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setId($id) {
+        /** @var mixed $id Let's be safe until strong typing */
+        if (is_int($id)) {
+            $id = (string)$id;
+        }
+
+        if (!is_string($id)) {
+            throw new \InvalidArgumentException('String expected.');
+        }
+
+        if ($this->id !== null) {
+            throw new IllegalIDChangeException('Not allowed to assign a new internal id to a share');
+        }
+
+        $this->id = trim($id);
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getId() {
+        return $this->id;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getFullId() {
+        if ($this->providerId === null || $this->id === null) {
+            throw new \UnexpectedValueException;
+        }
+        return $this->providerId . ':' . $this->id;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setProviderId($id) {
+        if (!is_string($id)) {
+            throw new \InvalidArgumentException('String expected.');
+        }
+
+        if ($this->providerId !== null) {
+            throw new IllegalIDChangeException('Not allowed to assign a new provider id to a share');
+        }
+
+        $this->providerId = trim($id);
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setNode(Node $node) {
+        $this->fileId = null;
+        $this->nodeType = null;
+        $this->node = $node;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getNode() {
+        if ($this->node === null) {
+            if ($this->shareOwner === null || $this->fileId === null) {
+                throw new NotFoundException();
+            }
+
+            // for federated shares the owner can be a remote user, in this
+            // case we use the initiator
+            if ($this->userManager->userExists($this->shareOwner)) {
+                $userFolder = $this->rootFolder->getUserFolder($this->shareOwner);
+            } else {
+                $userFolder = $this->rootFolder->getUserFolder($this->sharedBy);
+            }
+
+            $node = $userFolder->getFirstNodeById($this->fileId);
+            if (!$node) {
+                throw new NotFoundException('Node for share not found, fileid: ' . $this->fileId);
+            }
+
+            $this->node = $node;
+        }
+
+        return $this->node;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setNodeId($fileId) {
+        $this->node = null;
+        $this->fileId = $fileId;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getNodeId(): int {
+        if ($this->fileId === null) {
+            $this->fileId = $this->getNode()->getId();
+        }
+
+        if ($this->fileId === null) {
+            throw new NotFoundException('Share source not found');
+        } else {
+            return $this->fileId;
+        }
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setNodeType($type) {
+        if ($type !== 'file' && $type !== 'folder') {
+            throw new \InvalidArgumentException();
+        }
+
+        $this->nodeType = $type;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getNodeType() {
+        if ($this->nodeType === null) {
+            if ($this->getNodeCacheEntry()) {
+                $info = $this->getNodeCacheEntry();
+                $this->nodeType = $info->getMimeType() === FileInfo::MIMETYPE_FOLDER ? 'folder' : 'file';
+            } else {
+                $node = $this->getNode();
+                $this->nodeType = $node instanceof File ? 'file' : 'folder';
+            }
+        }
+
+        return $this->nodeType;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setShareType($shareType) {
+        $this->shareType = $shareType;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getShareType() {
+        return $this->shareType;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setSharedWith($sharedWith) {
+        if (!is_string($sharedWith)) {
+            throw new \InvalidArgumentException();
+        }
+        $this->sharedWith = $sharedWith;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getSharedWith() {
+        return $this->sharedWith;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setSharedWithDisplayName($displayName) {
+        if (!is_string($displayName)) {
+            throw new \InvalidArgumentException();
+        }
+        $this->sharedWithDisplayName = $displayName;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getSharedWithDisplayName() {
+        return $this->sharedWithDisplayName;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setSharedWithAvatar($src) {
+        if (!is_string($src)) {
+            throw new \InvalidArgumentException();
+        }
+        $this->sharedWithAvatar = $src;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getSharedWithAvatar() {
+        return $this->sharedWithAvatar;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setPermissions($permissions) {
+        //TODO checks
+
+        $this->permissions = $permissions;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getPermissions() {
+        return $this->permissions;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function newAttributes(): IAttributes {
+        return new ShareAttributes();
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setAttributes(?IAttributes $attributes) {
+        $this->attributes = $attributes;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getAttributes(): ?IAttributes {
+        return $this->attributes;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setStatus(int $status): IShare {
+        $this->status = $status;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getStatus(): int {
+        return $this->status;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setNote($note) {
+        $this->note = $note;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getNote() {
+        if (is_string($this->note)) {
+            return $this->note;
+        }
+        return '';
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setLabel($label) {
+        $this->label = $label;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getLabel() {
+        return $this->label;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setExpirationDate($expireDate) {
+        //TODO checks
+
+        $this->expireDate = $expireDate;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getExpirationDate() {
+        return $this->expireDate;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setNoExpirationDate(bool $noExpirationDate) {
+        $this->noExpirationDate = $noExpirationDate;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getNoExpirationDate(): bool {
+        return $this->noExpirationDate;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function isExpired() {
+        return $this->getExpirationDate() !== null &&
+            $this->getExpirationDate() <= new \DateTime();
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setSharedBy($sharedBy) {
+        if (!is_string($sharedBy)) {
+            throw new \InvalidArgumentException();
+        }
+        //TODO checks
+        $this->sharedBy = $sharedBy;
+
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getSharedBy() {
+        //TODO check if set
+        return $this->sharedBy;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setShareOwner($shareOwner) {
+        if (!is_string($shareOwner)) {
+            throw new \InvalidArgumentException();
+        }
+        //TODO checks
+
+        $this->shareOwner = $shareOwner;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getShareOwner() {
+        //TODO check if set
+        return $this->shareOwner;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setPassword($password) {
+        $this->password = $password;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getPassword() {
+        return $this->password;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setPasswordExpirationTime(?\DateTimeInterface $passwordExpirationTime = null): IShare {
+        $this->passwordExpirationTime = $passwordExpirationTime;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getPasswordExpirationTime(): ?\DateTimeInterface {
+        return $this->passwordExpirationTime;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setSendPasswordByTalk(bool $sendPasswordByTalk) {
+        $this->sendPasswordByTalk = $sendPasswordByTalk;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getSendPasswordByTalk(): bool {
+        return $this->sendPasswordByTalk;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setToken($token) {
+        $this->token = $token;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getToken() {
+        return $this->token;
+    }
+
+    /**
+     * Set the parent of this share
+     *
+     * @param int $parent
+     * @return IShare
+     * @deprecated 12.0.0 The new shares do not have parents. This is just here for legacy reasons.
+     */
+    public function setParent($parent) {
+        $this->parent = $parent;
+        return $this;
+    }
+
+    /**
+     * Get the parent of this share.
+     *
+     * @return int
+     * @deprecated 12.0.0 The new shares do not have parents. This is just here for legacy reasons.
+     */
+    public function getParent() {
+        return $this->parent;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setTarget($target) {
+        $this->target = $target;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getTarget() {
+        return $this->target;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setShareTime(\DateTime $shareTime) {
+        $this->shareTime = $shareTime;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getShareTime() {
+        return $this->shareTime;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setMailSend($mailSend) {
+        $this->mailSend = $mailSend;
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getMailSend() {
+        return $this->mailSend;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setNodeCacheEntry(ICacheEntry $entry) {
+        $this->nodeCacheEntry = $entry;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getNodeCacheEntry() {
+        return $this->nodeCacheEntry;
+    }
+
+    public function setHideDownload(bool $hide): IShare {
+        $this->hideDownload = $hide;
+        return $this;
+    }
+
+    public function getHideDownload(): bool {
+        return $this->hideDownload;
+    }
+
+    public function setReminderSent(bool $reminderSent): IShare {
+        $this->reminderSent = $reminderSent;
+        return $this;
+    }
+
+    public function getReminderSent(): bool {
+        return $this->reminderSent;
+    }
+
+    public function canSeeContent(): bool {
+        $shareManager = Server::get(IManager::class);
+
+        $allowViewWithoutDownload = $shareManager->allowViewWithoutDownload();
+        // If the share manager allows viewing without download, we can always see the content.
+        if ($allowViewWithoutDownload) {
+            return true;
+        }
 		
-		// No "allow preview" header set, so we must check if
-		// the share has not explicitly disabled download permissions
-		$attributes = $this->getAttributes();
-		if ($attributes?->getAttribute('permissions', 'download') === false) {
-			return false;
-		}
-
-		return true;
-	}
+        // No "allow preview" header set, so we must check if
+        // the share has not explicitly disabled download permissions
+        $attributes = $this->getAttributes();
+        if ($attributes?->getAttribute('permissions', 'download') === false) {
+            return false;
+        }
+
+        return true;
+    }
 }

lib/private/Share20/Manager.php

Indentation +1987 added lines, -1987 removed lines

@@ -60,2008 +60,2008 @@
  */
 class Manager implements IManager {
 
-	private ?IL10N $l;
-	private LegacyHooks $legacyHooks;
-
-	public function __construct(
-		private LoggerInterface $logger,
-		private IConfig $config,
-		private ISecureRandom $secureRandom,
-		private IHasher $hasher,
-		private IMountManager $mountManager,
-		private IGroupManager $groupManager,
-		private IFactory $l10nFactory,
-		private IProviderFactory $factory,
-		private IUserManager $userManager,
-		private IRootFolder $rootFolder,
-		private IMailer $mailer,
-		private IURLGenerator $urlGenerator,
-		private \OC_Defaults $defaults,
-		private IEventDispatcher $dispatcher,
-		private IUserSession $userSession,
-		private KnownUserService $knownUserService,
-		private ShareDisableChecker $shareDisableChecker,
-		private IDateTimeZone $dateTimeZone,
-		private IAppConfig $appConfig,
-	) {
-		$this->l = $this->l10nFactory->get('lib');
-		// The constructor of LegacyHooks registers the listeners of share events
-		// do not remove if those are not properly migrated
-		$this->legacyHooks = new LegacyHooks($this->dispatcher);
-	}
-
-	/**
-	 * Convert from a full share id to a tuple (providerId, shareId)
-	 *
-	 * @param string $id
-	 * @return string[]
-	 */
-	private function splitFullId($id) {
-		return explode(':', $id, 2);
-	}
-
-	/**
-	 * Verify if a password meets all requirements
-	 *
-	 * @param string $password
-	 * @throws HintException
-	 */
-	protected function verifyPassword($password) {
-		if ($password === null) {
-			// No password is set, check if this is allowed.
-			if ($this->shareApiLinkEnforcePassword()) {
-				throw new \InvalidArgumentException($this->l->t('Passwords are enforced for link and mail shares'));
-			}
-
-			return;
-		}
-
-		// Let others verify the password
-		try {
-			$event = new ValidatePasswordPolicyEvent($password, PasswordContext::SHARING);
-			$this->dispatcher->dispatchTyped($event);
-		} catch (HintException $e) {
-			/* Wrap in a 400 bad request error */
-			throw new HintException($e->getMessage(), $e->getHint(), 400, $e);
-		}
-	}
-
-	/**
-	 * Check for generic requirements before creating a share
-	 *
-	 * @param IShare $share
-	 * @throws \InvalidArgumentException
-	 * @throws GenericShareException
-	 *
-	 * @suppress PhanUndeclaredClassMethod
-	 */
-	protected function generalCreateChecks(IShare $share, bool $isUpdate = false) {
-		if ($share->getShareType() === IShare::TYPE_USER) {
-			// We expect a valid user as sharedWith for user shares
-			if (!$this->userManager->userExists($share->getSharedWith())) {
-				throw new \InvalidArgumentException($this->l->t('Share recipient is not a valid user'));
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_GROUP) {
-			// We expect a valid group as sharedWith for group shares
-			if (!$this->groupManager->groupExists($share->getSharedWith())) {
-				throw new \InvalidArgumentException($this->l->t('Share recipient is not a valid group'));
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_LINK) {
-			// No check for TYPE_EMAIL here as we have a recipient for them
-			if ($share->getSharedWith() !== null) {
-				throw new \InvalidArgumentException($this->l->t('Share recipient should be empty'));
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_EMAIL) {
-			if ($share->getSharedWith() === null) {
-				throw new \InvalidArgumentException($this->l->t('Share recipient should not be empty'));
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_REMOTE) {
-			if ($share->getSharedWith() === null) {
-				throw new \InvalidArgumentException($this->l->t('Share recipient should not be empty'));
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
-			if ($share->getSharedWith() === null) {
-				throw new \InvalidArgumentException($this->l->t('Share recipient should not be empty'));
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_CIRCLE) {
-			$circle = \OCA\Circles\Api\v1\Circles::detailsCircle($share->getSharedWith());
-			if ($circle === null) {
-				throw new \InvalidArgumentException($this->l->t('Share recipient is not a valid circle'));
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_ROOM) {
-		} elseif ($share->getShareType() === IShare::TYPE_DECK) {
-		} elseif ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
-		} else {
-			// We cannot handle other types yet
-			throw new \InvalidArgumentException($this->l->t('Unknown share type'));
-		}
-
-		// Verify the initiator of the share is set
-		if ($share->getSharedBy() === null) {
-			throw new \InvalidArgumentException($this->l->t('Share initiator must be set'));
-		}
-
-		// Cannot share with yourself
-		if ($share->getShareType() === IShare::TYPE_USER &&
-			$share->getSharedWith() === $share->getSharedBy()) {
-			throw new \InvalidArgumentException($this->l->t('Cannot share with yourself'));
-		}
-
-		// The path should be set
-		if ($share->getNode() === null) {
-			throw new \InvalidArgumentException($this->l->t('Shared path must be set'));
-		}
-
-		// And it should be a file or a folder
-		if (!($share->getNode() instanceof \OCP\Files\File) &&
-			!($share->getNode() instanceof \OCP\Files\Folder)) {
-			throw new \InvalidArgumentException($this->l->t('Shared path must be either a file or a folder'));
-		}
-
-		// And you cannot share your rootfolder
-		if ($this->userManager->userExists($share->getSharedBy())) {
-			$userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
-		} else {
-			$userFolder = $this->rootFolder->getUserFolder($share->getShareOwner());
-		}
-		if ($userFolder->getId() === $share->getNode()->getId()) {
-			throw new \InvalidArgumentException($this->l->t('You cannot share your root folder'));
-		}
-
-		// Check if we actually have share permissions
-		if (!$share->getNode()->isShareable()) {
-			throw new GenericShareException($this->l->t('You are not allowed to share %s', [$share->getNode()->getName()]), code: 404);
-		}
-
-		// Permissions should be set
-		if ($share->getPermissions() === null) {
-			throw new \InvalidArgumentException($this->l->t('Valid permissions are required for sharing'));
-		}
-
-		// Permissions must be valid
-		if ($share->getPermissions() < 0 || $share->getPermissions() > \OCP\Constants::PERMISSION_ALL) {
-			throw new \InvalidArgumentException($this->l->t('Valid permissions are required for sharing'));
-		}
-
-		// Single file shares should never have delete or create permissions
-		if (($share->getNode() instanceof File)
-			&& (($share->getPermissions() & (\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_DELETE)) !== 0)) {
-			throw new \InvalidArgumentException($this->l->t('File shares cannot have create or delete permissions'));
-		}
-
-		$permissions = 0;
-		$nodesForUser = $userFolder->getById($share->getNodeId());
-		foreach ($nodesForUser as $node) {
-			if ($node->getInternalPath() === '' && !$node->getMountPoint() instanceof MoveableMount) {
-				// for the root of non-movable mount, the permissions we see if limited by the mount itself,
-				// so we instead use the "raw" permissions from the storage
-				$permissions |= $node->getStorage()->getPermissions('');
-			} else {
-				$permissions |= $node->getPermissions();
-			}
-		}
-
-		// Check that we do not share with more permissions than we have
-		if ($share->getPermissions() & ~$permissions) {
-			$path = $userFolder->getRelativePath($share->getNode()->getPath());
-			throw new GenericShareException($this->l->t('Cannot increase permissions of %s', [$path]), code: 404);
-		}
-
-		// Check that read permissions are always set
-		// Link shares are allowed to have no read permissions to allow upload to hidden folders
-		$noReadPermissionRequired = $share->getShareType() === IShare::TYPE_LINK
-			|| $share->getShareType() === IShare::TYPE_EMAIL;
-		if (!$noReadPermissionRequired &&
-			($share->getPermissions() & \OCP\Constants::PERMISSION_READ) === 0) {
-			throw new \InvalidArgumentException($this->l->t('Shares need at least read permissions'));
-		}
-
-		if ($share->getNode() instanceof \OCP\Files\File) {
-			if ($share->getPermissions() & \OCP\Constants::PERMISSION_DELETE) {
-				throw new GenericShareException($this->l->t('Files cannot be shared with delete permissions'));
-			}
-			if ($share->getPermissions() & \OCP\Constants::PERMISSION_CREATE) {
-				throw new GenericShareException($this->l->t('Files cannot be shared with create permissions'));
-			}
-		}
-	}
-
-	/**
-	 * Validate if the expiration date fits the system settings
-	 *
-	 * @param IShare $share The share to validate the expiration date of
-	 * @return IShare The modified share object
-	 * @throws GenericShareException
-	 * @throws \InvalidArgumentException
-	 * @throws \Exception
-	 */
-	protected function validateExpirationDateInternal(IShare $share) {
-		$isRemote = $share->getShareType() === IShare::TYPE_REMOTE || $share->getShareType() === IShare::TYPE_REMOTE_GROUP;
-
-		$expirationDate = $share->getExpirationDate();
-
-		if ($isRemote) {
-			$defaultExpireDate = $this->shareApiRemoteDefaultExpireDate();
-			$defaultExpireDays = $this->shareApiRemoteDefaultExpireDays();
-			$configProp = 'remote_defaultExpDays';
-			$isEnforced = $this->shareApiRemoteDefaultExpireDateEnforced();
-		} else {
-			$defaultExpireDate = $this->shareApiInternalDefaultExpireDate();
-			$defaultExpireDays = $this->shareApiInternalDefaultExpireDays();
-			$configProp = 'internal_defaultExpDays';
-			$isEnforced = $this->shareApiInternalDefaultExpireDateEnforced();
-		}
-
-		// If $expirationDate is falsy, noExpirationDate is true and expiration not enforced
-		// Then skip expiration date validation as null is accepted
-		if (!$share->getNoExpirationDate() || $isEnforced) {
-			if ($expirationDate !== null) {
-				$expirationDate->setTimezone($this->dateTimeZone->getTimeZone());
-				$expirationDate->setTime(0, 0, 0);
-
-				$date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
-				$date->setTime(0, 0, 0);
-				if ($date >= $expirationDate) {
-					throw new GenericShareException($this->l->t('Expiration date is in the past'), code: 404);
-				}
-			}
-
-			// If expiredate is empty set a default one if there is a default
-			$fullId = null;
-			try {
-				$fullId = $share->getFullId();
-			} catch (\UnexpectedValueException $e) {
-				// This is a new share
-			}
-
-			if ($fullId === null && $expirationDate === null && $defaultExpireDate) {
-				$expirationDate = new \DateTime('now', $this->dateTimeZone->getTimeZone());
-				$expirationDate->setTime(0, 0, 0);
-				$days = (int)$this->config->getAppValue('core', $configProp, (string)$defaultExpireDays);
-				if ($days > $defaultExpireDays) {
-					$days = $defaultExpireDays;
-				}
-				$expirationDate->add(new \DateInterval('P' . $days . 'D'));
-			}
-
-			// If we enforce the expiration date check that is does not exceed
-			if ($isEnforced) {
-				if (empty($expirationDate)) {
-					throw new \InvalidArgumentException($this->l->t('Expiration date is enforced'));
-				}
-
-				$date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
-				$date->setTime(0, 0, 0);
-				$date->add(new \DateInterval('P' . $defaultExpireDays . 'D'));
-				if ($date < $expirationDate) {
-					throw new GenericShareException($this->l->n('Cannot set expiration date more than %n day in the future', 'Cannot set expiration date more than %n days in the future', $defaultExpireDays), code: 404);
-				}
-			}
-		}
-
-		$accepted = true;
-		$message = '';
-		\OCP\Util::emitHook('\OC\Share', 'verifyExpirationDate', [
-			'expirationDate' => &$expirationDate,
-			'accepted' => &$accepted,
-			'message' => &$message,
-			'passwordSet' => $share->getPassword() !== null,
-		]);
-
-		if (!$accepted) {
-			throw new \Exception($message);
-		}
-
-		$share->setExpirationDate($expirationDate);
-
-		return $share;
-	}
-
-	/**
-	 * Validate if the expiration date fits the system settings
-	 *
-	 * @param IShare $share The share to validate the expiration date of
-	 * @return IShare The modified share object
-	 * @throws GenericShareException
-	 * @throws \InvalidArgumentException
-	 * @throws \Exception
-	 */
-	protected function validateExpirationDateLink(IShare $share) {
-		$expirationDate = $share->getExpirationDate();
-		$isEnforced = $this->shareApiLinkDefaultExpireDateEnforced();
-
-		// If $expirationDate is falsy, noExpirationDate is true and expiration not enforced
-		// Then skip expiration date validation as null is accepted
-		if (!($share->getNoExpirationDate() && !$isEnforced)) {
-			if ($expirationDate !== null) {
-				$expirationDate->setTimezone($this->dateTimeZone->getTimeZone());
-				$expirationDate->setTime(0, 0, 0);
-
-				$date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
-				$date->setTime(0, 0, 0);
-				if ($date >= $expirationDate) {
-					throw new GenericShareException($this->l->t('Expiration date is in the past'), code: 404);
-				}
-			}
-
-			// If expiredate is empty set a default one if there is a default
-			$fullId = null;
-			try {
-				$fullId = $share->getFullId();
-			} catch (\UnexpectedValueException $e) {
-				// This is a new share
-			}
-
-			if ($fullId === null && $expirationDate === null && $this->shareApiLinkDefaultExpireDate()) {
-				$expirationDate = new \DateTime('now', $this->dateTimeZone->getTimeZone());
-				$expirationDate->setTime(0, 0, 0);
-
-				$days = (int)$this->config->getAppValue('core', 'link_defaultExpDays', (string)$this->shareApiLinkDefaultExpireDays());
-				if ($days > $this->shareApiLinkDefaultExpireDays()) {
-					$days = $this->shareApiLinkDefaultExpireDays();
-				}
-				$expirationDate->add(new \DateInterval('P' . $days . 'D'));
-			}
-
-			// If we enforce the expiration date check that is does not exceed
-			if ($isEnforced) {
-				if (empty($expirationDate)) {
-					throw new \InvalidArgumentException($this->l->t('Expiration date is enforced'));
-				}
-
-				$date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
-				$date->setTime(0, 0, 0);
-				$date->add(new \DateInterval('P' . $this->shareApiLinkDefaultExpireDays() . 'D'));
-				if ($date < $expirationDate) {
-					throw new GenericShareException(
-						$this->l->n('Cannot set expiration date more than %n day in the future', 'Cannot set expiration date more than %n days in the future', $this->shareApiLinkDefaultExpireDays()),
-						code: 404,
-					);
-				}
-			}
-
-		}
-
-		$accepted = true;
-		$message = '';
-		\OCP\Util::emitHook('\OC\Share', 'verifyExpirationDate', [
-			'expirationDate' => &$expirationDate,
-			'accepted' => &$accepted,
-			'message' => &$message,
-			'passwordSet' => $share->getPassword() !== null,
-		]);
-
-		if (!$accepted) {
-			throw new \Exception($message);
-		}
-
-		$share->setExpirationDate($expirationDate);
-
-		return $share;
-	}
-
-	/**
-	 * Check for pre share requirements for user shares
-	 *
-	 * @param IShare $share
-	 * @throws \Exception
-	 */
-	protected function userCreateChecks(IShare $share) {
-		// Check if we can share with group members only
-		if ($this->shareWithGroupMembersOnly()) {
-			$sharedBy = $this->userManager->get($share->getSharedBy());
-			$sharedWith = $this->userManager->get($share->getSharedWith());
-			// Verify we can share with this user
-			$groups = array_intersect(
-				$this->groupManager->getUserGroupIds($sharedBy),
-				$this->groupManager->getUserGroupIds($sharedWith)
-			);
-
-			// optional excluded groups
-			$excludedGroups = $this->shareWithGroupMembersOnlyExcludeGroupsList();
-			$groups = array_diff($groups, $excludedGroups);
-
-			if (empty($groups)) {
-				throw new \Exception($this->l->t('Sharing is only allowed with group members'));
-			}
-		}
-
-		/*
+    private ?IL10N $l;
+    private LegacyHooks $legacyHooks;
+
+    public function __construct(
+        private LoggerInterface $logger,
+        private IConfig $config,
+        private ISecureRandom $secureRandom,
+        private IHasher $hasher,
+        private IMountManager $mountManager,
+        private IGroupManager $groupManager,
+        private IFactory $l10nFactory,
+        private IProviderFactory $factory,
+        private IUserManager $userManager,
+        private IRootFolder $rootFolder,
+        private IMailer $mailer,
+        private IURLGenerator $urlGenerator,
+        private \OC_Defaults $defaults,
+        private IEventDispatcher $dispatcher,
+        private IUserSession $userSession,
+        private KnownUserService $knownUserService,
+        private ShareDisableChecker $shareDisableChecker,
+        private IDateTimeZone $dateTimeZone,
+        private IAppConfig $appConfig,
+    ) {
+        $this->l = $this->l10nFactory->get('lib');
+        // The constructor of LegacyHooks registers the listeners of share events
+        // do not remove if those are not properly migrated
+        $this->legacyHooks = new LegacyHooks($this->dispatcher);
+    }
+
+    /**
+     * Convert from a full share id to a tuple (providerId, shareId)
+     *
+     * @param string $id
+     * @return string[]
+     */
+    private function splitFullId($id) {
+        return explode(':', $id, 2);
+    }
+
+    /**
+     * Verify if a password meets all requirements
+     *
+     * @param string $password
+     * @throws HintException
+     */
+    protected function verifyPassword($password) {
+        if ($password === null) {
+            // No password is set, check if this is allowed.
+            if ($this->shareApiLinkEnforcePassword()) {
+                throw new \InvalidArgumentException($this->l->t('Passwords are enforced for link and mail shares'));
+            }
+
+            return;
+        }
+
+        // Let others verify the password
+        try {
+            $event = new ValidatePasswordPolicyEvent($password, PasswordContext::SHARING);
+            $this->dispatcher->dispatchTyped($event);
+        } catch (HintException $e) {
+            /* Wrap in a 400 bad request error */
+            throw new HintException($e->getMessage(), $e->getHint(), 400, $e);
+        }
+    }
+
+    /**
+     * Check for generic requirements before creating a share
+     *
+     * @param IShare $share
+     * @throws \InvalidArgumentException
+     * @throws GenericShareException
+     *
+     * @suppress PhanUndeclaredClassMethod
+     */
+    protected function generalCreateChecks(IShare $share, bool $isUpdate = false) {
+        if ($share->getShareType() === IShare::TYPE_USER) {
+            // We expect a valid user as sharedWith for user shares
+            if (!$this->userManager->userExists($share->getSharedWith())) {
+                throw new \InvalidArgumentException($this->l->t('Share recipient is not a valid user'));
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_GROUP) {
+            // We expect a valid group as sharedWith for group shares
+            if (!$this->groupManager->groupExists($share->getSharedWith())) {
+                throw new \InvalidArgumentException($this->l->t('Share recipient is not a valid group'));
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_LINK) {
+            // No check for TYPE_EMAIL here as we have a recipient for them
+            if ($share->getSharedWith() !== null) {
+                throw new \InvalidArgumentException($this->l->t('Share recipient should be empty'));
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_EMAIL) {
+            if ($share->getSharedWith() === null) {
+                throw new \InvalidArgumentException($this->l->t('Share recipient should not be empty'));
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_REMOTE) {
+            if ($share->getSharedWith() === null) {
+                throw new \InvalidArgumentException($this->l->t('Share recipient should not be empty'));
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
+            if ($share->getSharedWith() === null) {
+                throw new \InvalidArgumentException($this->l->t('Share recipient should not be empty'));
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_CIRCLE) {
+            $circle = \OCA\Circles\Api\v1\Circles::detailsCircle($share->getSharedWith());
+            if ($circle === null) {
+                throw new \InvalidArgumentException($this->l->t('Share recipient is not a valid circle'));
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_ROOM) {
+        } elseif ($share->getShareType() === IShare::TYPE_DECK) {
+        } elseif ($share->getShareType() === IShare::TYPE_SCIENCEMESH) {
+        } else {
+            // We cannot handle other types yet
+            throw new \InvalidArgumentException($this->l->t('Unknown share type'));
+        }
+
+        // Verify the initiator of the share is set
+        if ($share->getSharedBy() === null) {
+            throw new \InvalidArgumentException($this->l->t('Share initiator must be set'));
+        }
+
+        // Cannot share with yourself
+        if ($share->getShareType() === IShare::TYPE_USER &&
+            $share->getSharedWith() === $share->getSharedBy()) {
+            throw new \InvalidArgumentException($this->l->t('Cannot share with yourself'));
+        }
+
+        // The path should be set
+        if ($share->getNode() === null) {
+            throw new \InvalidArgumentException($this->l->t('Shared path must be set'));
+        }
+
+        // And it should be a file or a folder
+        if (!($share->getNode() instanceof \OCP\Files\File) &&
+            !($share->getNode() instanceof \OCP\Files\Folder)) {
+            throw new \InvalidArgumentException($this->l->t('Shared path must be either a file or a folder'));
+        }
+
+        // And you cannot share your rootfolder
+        if ($this->userManager->userExists($share->getSharedBy())) {
+            $userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
+        } else {
+            $userFolder = $this->rootFolder->getUserFolder($share->getShareOwner());
+        }
+        if ($userFolder->getId() === $share->getNode()->getId()) {
+            throw new \InvalidArgumentException($this->l->t('You cannot share your root folder'));
+        }
+
+        // Check if we actually have share permissions
+        if (!$share->getNode()->isShareable()) {
+            throw new GenericShareException($this->l->t('You are not allowed to share %s', [$share->getNode()->getName()]), code: 404);
+        }
+
+        // Permissions should be set
+        if ($share->getPermissions() === null) {
+            throw new \InvalidArgumentException($this->l->t('Valid permissions are required for sharing'));
+        }
+
+        // Permissions must be valid
+        if ($share->getPermissions() < 0 || $share->getPermissions() > \OCP\Constants::PERMISSION_ALL) {
+            throw new \InvalidArgumentException($this->l->t('Valid permissions are required for sharing'));
+        }
+
+        // Single file shares should never have delete or create permissions
+        if (($share->getNode() instanceof File)
+            && (($share->getPermissions() & (\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_DELETE)) !== 0)) {
+            throw new \InvalidArgumentException($this->l->t('File shares cannot have create or delete permissions'));
+        }
+
+        $permissions = 0;
+        $nodesForUser = $userFolder->getById($share->getNodeId());
+        foreach ($nodesForUser as $node) {
+            if ($node->getInternalPath() === '' && !$node->getMountPoint() instanceof MoveableMount) {
+                // for the root of non-movable mount, the permissions we see if limited by the mount itself,
+                // so we instead use the "raw" permissions from the storage
+                $permissions |= $node->getStorage()->getPermissions('');
+            } else {
+                $permissions |= $node->getPermissions();
+            }
+        }
+
+        // Check that we do not share with more permissions than we have
+        if ($share->getPermissions() & ~$permissions) {
+            $path = $userFolder->getRelativePath($share->getNode()->getPath());
+            throw new GenericShareException($this->l->t('Cannot increase permissions of %s', [$path]), code: 404);
+        }
+
+        // Check that read permissions are always set
+        // Link shares are allowed to have no read permissions to allow upload to hidden folders
+        $noReadPermissionRequired = $share->getShareType() === IShare::TYPE_LINK
+            || $share->getShareType() === IShare::TYPE_EMAIL;
+        if (!$noReadPermissionRequired &&
+            ($share->getPermissions() & \OCP\Constants::PERMISSION_READ) === 0) {
+            throw new \InvalidArgumentException($this->l->t('Shares need at least read permissions'));
+        }
+
+        if ($share->getNode() instanceof \OCP\Files\File) {
+            if ($share->getPermissions() & \OCP\Constants::PERMISSION_DELETE) {
+                throw new GenericShareException($this->l->t('Files cannot be shared with delete permissions'));
+            }
+            if ($share->getPermissions() & \OCP\Constants::PERMISSION_CREATE) {
+                throw new GenericShareException($this->l->t('Files cannot be shared with create permissions'));
+            }
+        }
+    }
+
+    /**
+     * Validate if the expiration date fits the system settings
+     *
+     * @param IShare $share The share to validate the expiration date of
+     * @return IShare The modified share object
+     * @throws GenericShareException
+     * @throws \InvalidArgumentException
+     * @throws \Exception
+     */
+    protected function validateExpirationDateInternal(IShare $share) {
+        $isRemote = $share->getShareType() === IShare::TYPE_REMOTE || $share->getShareType() === IShare::TYPE_REMOTE_GROUP;
+
+        $expirationDate = $share->getExpirationDate();
+
+        if ($isRemote) {
+            $defaultExpireDate = $this->shareApiRemoteDefaultExpireDate();
+            $defaultExpireDays = $this->shareApiRemoteDefaultExpireDays();
+            $configProp = 'remote_defaultExpDays';
+            $isEnforced = $this->shareApiRemoteDefaultExpireDateEnforced();
+        } else {
+            $defaultExpireDate = $this->shareApiInternalDefaultExpireDate();
+            $defaultExpireDays = $this->shareApiInternalDefaultExpireDays();
+            $configProp = 'internal_defaultExpDays';
+            $isEnforced = $this->shareApiInternalDefaultExpireDateEnforced();
+        }
+
+        // If $expirationDate is falsy, noExpirationDate is true and expiration not enforced
+        // Then skip expiration date validation as null is accepted
+        if (!$share->getNoExpirationDate() || $isEnforced) {
+            if ($expirationDate !== null) {
+                $expirationDate->setTimezone($this->dateTimeZone->getTimeZone());
+                $expirationDate->setTime(0, 0, 0);
+
+                $date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
+                $date->setTime(0, 0, 0);
+                if ($date >= $expirationDate) {
+                    throw new GenericShareException($this->l->t('Expiration date is in the past'), code: 404);
+                }
+            }
+
+            // If expiredate is empty set a default one if there is a default
+            $fullId = null;
+            try {
+                $fullId = $share->getFullId();
+            } catch (\UnexpectedValueException $e) {
+                // This is a new share
+            }
+
+            if ($fullId === null && $expirationDate === null && $defaultExpireDate) {
+                $expirationDate = new \DateTime('now', $this->dateTimeZone->getTimeZone());
+                $expirationDate->setTime(0, 0, 0);
+                $days = (int)$this->config->getAppValue('core', $configProp, (string)$defaultExpireDays);
+                if ($days > $defaultExpireDays) {
+                    $days = $defaultExpireDays;
+                }
+                $expirationDate->add(new \DateInterval('P' . $days . 'D'));
+            }
+
+            // If we enforce the expiration date check that is does not exceed
+            if ($isEnforced) {
+                if (empty($expirationDate)) {
+                    throw new \InvalidArgumentException($this->l->t('Expiration date is enforced'));
+                }
+
+                $date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
+                $date->setTime(0, 0, 0);
+                $date->add(new \DateInterval('P' . $defaultExpireDays . 'D'));
+                if ($date < $expirationDate) {
+                    throw new GenericShareException($this->l->n('Cannot set expiration date more than %n day in the future', 'Cannot set expiration date more than %n days in the future', $defaultExpireDays), code: 404);
+                }
+            }
+        }
+
+        $accepted = true;
+        $message = '';
+        \OCP\Util::emitHook('\OC\Share', 'verifyExpirationDate', [
+            'expirationDate' => &$expirationDate,
+            'accepted' => &$accepted,
+            'message' => &$message,
+            'passwordSet' => $share->getPassword() !== null,
+        ]);
+
+        if (!$accepted) {
+            throw new \Exception($message);
+        }
+
+        $share->setExpirationDate($expirationDate);
+
+        return $share;
+    }
+
+    /**
+     * Validate if the expiration date fits the system settings
+     *
+     * @param IShare $share The share to validate the expiration date of
+     * @return IShare The modified share object
+     * @throws GenericShareException
+     * @throws \InvalidArgumentException
+     * @throws \Exception
+     */
+    protected function validateExpirationDateLink(IShare $share) {
+        $expirationDate = $share->getExpirationDate();
+        $isEnforced = $this->shareApiLinkDefaultExpireDateEnforced();
+
+        // If $expirationDate is falsy, noExpirationDate is true and expiration not enforced
+        // Then skip expiration date validation as null is accepted
+        if (!($share->getNoExpirationDate() && !$isEnforced)) {
+            if ($expirationDate !== null) {
+                $expirationDate->setTimezone($this->dateTimeZone->getTimeZone());
+                $expirationDate->setTime(0, 0, 0);
+
+                $date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
+                $date->setTime(0, 0, 0);
+                if ($date >= $expirationDate) {
+                    throw new GenericShareException($this->l->t('Expiration date is in the past'), code: 404);
+                }
+            }
+
+            // If expiredate is empty set a default one if there is a default
+            $fullId = null;
+            try {
+                $fullId = $share->getFullId();
+            } catch (\UnexpectedValueException $e) {
+                // This is a new share
+            }
+
+            if ($fullId === null && $expirationDate === null && $this->shareApiLinkDefaultExpireDate()) {
+                $expirationDate = new \DateTime('now', $this->dateTimeZone->getTimeZone());
+                $expirationDate->setTime(0, 0, 0);
+
+                $days = (int)$this->config->getAppValue('core', 'link_defaultExpDays', (string)$this->shareApiLinkDefaultExpireDays());
+                if ($days > $this->shareApiLinkDefaultExpireDays()) {
+                    $days = $this->shareApiLinkDefaultExpireDays();
+                }
+                $expirationDate->add(new \DateInterval('P' . $days . 'D'));
+            }
+
+            // If we enforce the expiration date check that is does not exceed
+            if ($isEnforced) {
+                if (empty($expirationDate)) {
+                    throw new \InvalidArgumentException($this->l->t('Expiration date is enforced'));
+                }
+
+                $date = new \DateTime('now', $this->dateTimeZone->getTimeZone());
+                $date->setTime(0, 0, 0);
+                $date->add(new \DateInterval('P' . $this->shareApiLinkDefaultExpireDays() . 'D'));
+                if ($date < $expirationDate) {
+                    throw new GenericShareException(
+                        $this->l->n('Cannot set expiration date more than %n day in the future', 'Cannot set expiration date more than %n days in the future', $this->shareApiLinkDefaultExpireDays()),
+                        code: 404,
+                    );
+                }
+            }
+
+        }
+
+        $accepted = true;
+        $message = '';
+        \OCP\Util::emitHook('\OC\Share', 'verifyExpirationDate', [
+            'expirationDate' => &$expirationDate,
+            'accepted' => &$accepted,
+            'message' => &$message,
+            'passwordSet' => $share->getPassword() !== null,
+        ]);
+
+        if (!$accepted) {
+            throw new \Exception($message);
+        }
+
+        $share->setExpirationDate($expirationDate);
+
+        return $share;
+    }
+
+    /**
+     * Check for pre share requirements for user shares
+     *
+     * @param IShare $share
+     * @throws \Exception
+     */
+    protected function userCreateChecks(IShare $share) {
+        // Check if we can share with group members only
+        if ($this->shareWithGroupMembersOnly()) {
+            $sharedBy = $this->userManager->get($share->getSharedBy());
+            $sharedWith = $this->userManager->get($share->getSharedWith());
+            // Verify we can share with this user
+            $groups = array_intersect(
+                $this->groupManager->getUserGroupIds($sharedBy),
+                $this->groupManager->getUserGroupIds($sharedWith)
+            );
+
+            // optional excluded groups
+            $excludedGroups = $this->shareWithGroupMembersOnlyExcludeGroupsList();
+            $groups = array_diff($groups, $excludedGroups);
+
+            if (empty($groups)) {
+                throw new \Exception($this->l->t('Sharing is only allowed with group members'));
+            }
+        }
+
+        /*
 		 * TODO: Could be costly, fix
 		 *
 		 * Also this is not what we want in the future.. then we want to squash identical shares.
 		 */
-		$provider = $this->factory->getProviderForType(IShare::TYPE_USER);
-		$existingShares = $provider->getSharesByPath($share->getNode());
-		foreach ($existingShares as $existingShare) {
-			// Ignore if it is the same share
-			try {
-				if ($existingShare->getFullId() === $share->getFullId()) {
-					continue;
-				}
-			} catch (\UnexpectedValueException $e) {
-				//Shares are not identical
-			}
-
-			// Identical share already exists
-			if ($existingShare->getSharedWith() === $share->getSharedWith() && $existingShare->getShareType() === $share->getShareType()) {
-				throw new AlreadySharedException($this->l->t('Sharing %s failed, because this item is already shared with the account %s', [$share->getNode()->getName(), $share->getSharedWithDisplayName()]), $existingShare);
-			}
-
-			// The share is already shared with this user via a group share
-			if ($existingShare->getShareType() === IShare::TYPE_GROUP) {
-				$group = $this->groupManager->get($existingShare->getSharedWith());
-				if (!is_null($group)) {
-					$user = $this->userManager->get($share->getSharedWith());
-
-					if ($group->inGroup($user) && $existingShare->getShareOwner() !== $share->getShareOwner()) {
-						throw new AlreadySharedException($this->l->t('Sharing %s failed, because this item is already shared with the account %s', [$share->getNode()->getName(), $share->getSharedWithDisplayName()]), $existingShare);
-					}
-				}
-			}
-		}
-	}
-
-	/**
-	 * Check for pre share requirements for group shares
-	 *
-	 * @param IShare $share
-	 * @throws \Exception
-	 */
-	protected function groupCreateChecks(IShare $share) {
-		// Verify group shares are allowed
-		if (!$this->allowGroupSharing()) {
-			throw new \Exception($this->l->t('Group sharing is now allowed'));
-		}
-
-		// Verify if the user can share with this group
-		if ($this->shareWithGroupMembersOnly()) {
-			$sharedBy = $this->userManager->get($share->getSharedBy());
-			$sharedWith = $this->groupManager->get($share->getSharedWith());
-
-			// optional excluded groups
-			$excludedGroups = $this->shareWithGroupMembersOnlyExcludeGroupsList();
-			if (is_null($sharedWith) || in_array($share->getSharedWith(), $excludedGroups) || !$sharedWith->inGroup($sharedBy)) {
-				throw new \Exception($this->l->t('Sharing is only allowed within your own groups'));
-			}
-		}
-
-		/*
+        $provider = $this->factory->getProviderForType(IShare::TYPE_USER);
+        $existingShares = $provider->getSharesByPath($share->getNode());
+        foreach ($existingShares as $existingShare) {
+            // Ignore if it is the same share
+            try {
+                if ($existingShare->getFullId() === $share->getFullId()) {
+                    continue;
+                }
+            } catch (\UnexpectedValueException $e) {
+                //Shares are not identical
+            }
+
+            // Identical share already exists
+            if ($existingShare->getSharedWith() === $share->getSharedWith() && $existingShare->getShareType() === $share->getShareType()) {
+                throw new AlreadySharedException($this->l->t('Sharing %s failed, because this item is already shared with the account %s', [$share->getNode()->getName(), $share->getSharedWithDisplayName()]), $existingShare);
+            }
+
+            // The share is already shared with this user via a group share
+            if ($existingShare->getShareType() === IShare::TYPE_GROUP) {
+                $group = $this->groupManager->get($existingShare->getSharedWith());
+                if (!is_null($group)) {
+                    $user = $this->userManager->get($share->getSharedWith());
+
+                    if ($group->inGroup($user) && $existingShare->getShareOwner() !== $share->getShareOwner()) {
+                        throw new AlreadySharedException($this->l->t('Sharing %s failed, because this item is already shared with the account %s', [$share->getNode()->getName(), $share->getSharedWithDisplayName()]), $existingShare);
+                    }
+                }
+            }
+        }
+    }
+
+    /**
+     * Check for pre share requirements for group shares
+     *
+     * @param IShare $share
+     * @throws \Exception
+     */
+    protected function groupCreateChecks(IShare $share) {
+        // Verify group shares are allowed
+        if (!$this->allowGroupSharing()) {
+            throw new \Exception($this->l->t('Group sharing is now allowed'));
+        }
+
+        // Verify if the user can share with this group
+        if ($this->shareWithGroupMembersOnly()) {
+            $sharedBy = $this->userManager->get($share->getSharedBy());
+            $sharedWith = $this->groupManager->get($share->getSharedWith());
+
+            // optional excluded groups
+            $excludedGroups = $this->shareWithGroupMembersOnlyExcludeGroupsList();
+            if (is_null($sharedWith) || in_array($share->getSharedWith(), $excludedGroups) || !$sharedWith->inGroup($sharedBy)) {
+                throw new \Exception($this->l->t('Sharing is only allowed within your own groups'));
+            }
+        }
+
+        /*
 		 * TODO: Could be costly, fix
 		 *
 		 * Also this is not what we want in the future.. then we want to squash identical shares.
 		 */
-		$provider = $this->factory->getProviderForType(IShare::TYPE_GROUP);
-		$existingShares = $provider->getSharesByPath($share->getNode());
-		foreach ($existingShares as $existingShare) {
-			try {
-				if ($existingShare->getFullId() === $share->getFullId()) {
-					continue;
-				}
-			} catch (\UnexpectedValueException $e) {
-				//It is a new share so just continue
-			}
-
-			if ($existingShare->getSharedWith() === $share->getSharedWith() && $existingShare->getShareType() === $share->getShareType()) {
-				throw new AlreadySharedException($this->l->t('Path is already shared with this group'), $existingShare);
-			}
-		}
-	}
-
-	/**
-	 * Check for pre share requirements for link shares
-	 *
-	 * @param IShare $share
-	 * @throws \Exception
-	 */
-	protected function linkCreateChecks(IShare $share) {
-		// Are link shares allowed?
-		if (!$this->shareApiAllowLinks()) {
-			throw new \Exception($this->l->t('Link sharing is not allowed'));
-		}
-
-		// Check if public upload is allowed
-		if ($share->getNodeType() === 'folder' && !$this->shareApiLinkAllowPublicUpload() &&
-			($share->getPermissions() & (\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE))) {
-			throw new \InvalidArgumentException($this->l->t('Public upload is not allowed'));
-		}
-	}
-
-	/**
-	 * To make sure we don't get invisible link shares we set the parent
-	 * of a link if it is a reshare. This is a quick word around
-	 * until we can properly display multiple link shares in the UI
-	 *
-	 * See: https://github.com/owncloud/core/issues/22295
-	 *
-	 * FIXME: Remove once multiple link shares can be properly displayed
-	 *
-	 * @param IShare $share
-	 */
-	protected function setLinkParent(IShare $share) {
-		// No sense in checking if the method is not there.
-		if (method_exists($share, 'setParent')) {
-			$storage = $share->getNode()->getStorage();
-			if ($storage->instanceOfStorage(SharedStorage::class)) {
-				/** @var \OCA\Files_Sharing\SharedStorage $storage */
-				$share->setParent($storage->getShareId());
-			}
-		}
-	}
-
-	/**
-	 * @param File|Folder $path
-	 */
-	protected function pathCreateChecks($path) {
-		// Make sure that we do not share a path that contains a shared mountpoint
-		if ($path instanceof \OCP\Files\Folder) {
-			$mounts = $this->mountManager->findIn($path->getPath());
-			foreach ($mounts as $mount) {
-				if ($mount->getStorage()->instanceOfStorage('\OCA\Files_Sharing\ISharedStorage')) {
-					// Using a flat sharing model ensures the file owner can always see who has access.
-					// Allowing parent folder sharing would require tracking inherited access, which adds complexity
-					// and hurts performance/scalability.
-					// So we forbid sharing a parent folder of a share you received.
-					throw new \InvalidArgumentException($this->l->t('You cannot share a folder that contains other shares'));
-				}
-			}
-		}
-	}
-
-	/**
-	 * Check if the user that is sharing can actually share
-	 *
-	 * @param IShare $share
-	 * @throws \Exception
-	 */
-	protected function canShare(IShare $share) {
-		if (!$this->shareApiEnabled()) {
-			throw new \Exception($this->l->t('Sharing is disabled'));
-		}
-
-		if ($this->sharingDisabledForUser($share->getSharedBy())) {
-			throw new \Exception($this->l->t('Sharing is disabled for you'));
-		}
-	}
-
-	/**
-	 * Share a path
-	 *
-	 * @param IShare $share
-	 * @return IShare The share object
-	 * @throws \Exception
-	 *
-	 * TODO: handle link share permissions or check them
-	 */
-	public function createShare(IShare $share) {
-		$this->canShare($share);
-
-		$this->generalCreateChecks($share);
-
-		// Verify if there are any issues with the path
-		$this->pathCreateChecks($share->getNode());
-
-		/*
+        $provider = $this->factory->getProviderForType(IShare::TYPE_GROUP);
+        $existingShares = $provider->getSharesByPath($share->getNode());
+        foreach ($existingShares as $existingShare) {
+            try {
+                if ($existingShare->getFullId() === $share->getFullId()) {
+                    continue;
+                }
+            } catch (\UnexpectedValueException $e) {
+                //It is a new share so just continue
+            }
+
+            if ($existingShare->getSharedWith() === $share->getSharedWith() && $existingShare->getShareType() === $share->getShareType()) {
+                throw new AlreadySharedException($this->l->t('Path is already shared with this group'), $existingShare);
+            }
+        }
+    }
+
+    /**
+     * Check for pre share requirements for link shares
+     *
+     * @param IShare $share
+     * @throws \Exception
+     */
+    protected function linkCreateChecks(IShare $share) {
+        // Are link shares allowed?
+        if (!$this->shareApiAllowLinks()) {
+            throw new \Exception($this->l->t('Link sharing is not allowed'));
+        }
+
+        // Check if public upload is allowed
+        if ($share->getNodeType() === 'folder' && !$this->shareApiLinkAllowPublicUpload() &&
+            ($share->getPermissions() & (\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE | \OCP\Constants::PERMISSION_DELETE))) {
+            throw new \InvalidArgumentException($this->l->t('Public upload is not allowed'));
+        }
+    }
+
+    /**
+     * To make sure we don't get invisible link shares we set the parent
+     * of a link if it is a reshare. This is a quick word around
+     * until we can properly display multiple link shares in the UI
+     *
+     * See: https://github.com/owncloud/core/issues/22295
+     *
+     * FIXME: Remove once multiple link shares can be properly displayed
+     *
+     * @param IShare $share
+     */
+    protected function setLinkParent(IShare $share) {
+        // No sense in checking if the method is not there.
+        if (method_exists($share, 'setParent')) {
+            $storage = $share->getNode()->getStorage();
+            if ($storage->instanceOfStorage(SharedStorage::class)) {
+                /** @var \OCA\Files_Sharing\SharedStorage $storage */
+                $share->setParent($storage->getShareId());
+            }
+        }
+    }
+
+    /**
+     * @param File|Folder $path
+     */
+    protected function pathCreateChecks($path) {
+        // Make sure that we do not share a path that contains a shared mountpoint
+        if ($path instanceof \OCP\Files\Folder) {
+            $mounts = $this->mountManager->findIn($path->getPath());
+            foreach ($mounts as $mount) {
+                if ($mount->getStorage()->instanceOfStorage('\OCA\Files_Sharing\ISharedStorage')) {
+                    // Using a flat sharing model ensures the file owner can always see who has access.
+                    // Allowing parent folder sharing would require tracking inherited access, which adds complexity
+                    // and hurts performance/scalability.
+                    // So we forbid sharing a parent folder of a share you received.
+                    throw new \InvalidArgumentException($this->l->t('You cannot share a folder that contains other shares'));
+                }
+            }
+        }
+    }
+
+    /**
+     * Check if the user that is sharing can actually share
+     *
+     * @param IShare $share
+     * @throws \Exception
+     */
+    protected function canShare(IShare $share) {
+        if (!$this->shareApiEnabled()) {
+            throw new \Exception($this->l->t('Sharing is disabled'));
+        }
+
+        if ($this->sharingDisabledForUser($share->getSharedBy())) {
+            throw new \Exception($this->l->t('Sharing is disabled for you'));
+        }
+    }
+
+    /**
+     * Share a path
+     *
+     * @param IShare $share
+     * @return IShare The share object
+     * @throws \Exception
+     *
+     * TODO: handle link share permissions or check them
+     */
+    public function createShare(IShare $share) {
+        $this->canShare($share);
+
+        $this->generalCreateChecks($share);
+
+        // Verify if there are any issues with the path
+        $this->pathCreateChecks($share->getNode());
+
+        /*
 		 * On creation of a share the owner is always the owner of the path
 		 * Except for mounted federated shares.
 		 */
-		$storage = $share->getNode()->getStorage();
-		if ($storage->instanceOfStorage('OCA\Files_Sharing\External\Storage')) {
-			$parent = $share->getNode()->getParent();
-			while ($parent->getStorage()->instanceOfStorage('OCA\Files_Sharing\External\Storage')) {
-				$parent = $parent->getParent();
-			}
-			$share->setShareOwner($parent->getOwner()->getUID());
-		} else {
-			if ($share->getNode()->getOwner()) {
-				$share->setShareOwner($share->getNode()->getOwner()->getUID());
-			} else {
-				$share->setShareOwner($share->getSharedBy());
-			}
-		}
-
-		try {
-			// Verify share type
-			if ($share->getShareType() === IShare::TYPE_USER) {
-				$this->userCreateChecks($share);
-
-				// Verify the expiration date
-				$share = $this->validateExpirationDateInternal($share);
-			} elseif ($share->getShareType() === IShare::TYPE_GROUP) {
-				$this->groupCreateChecks($share);
-
-				// Verify the expiration date
-				$share = $this->validateExpirationDateInternal($share);
-			} elseif ($share->getShareType() === IShare::TYPE_REMOTE || $share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
-				// Verify the expiration date
-				$share = $this->validateExpirationDateInternal($share);
-			} elseif ($share->getShareType() === IShare::TYPE_LINK
-				|| $share->getShareType() === IShare::TYPE_EMAIL) {
-				$this->linkCreateChecks($share);
-				$this->setLinkParent($share);
-
-				$token = $this->generateToken();
-				// Set the unique token
-				$share->setToken($token);
-
-				// Verify the expiration date
-				$share = $this->validateExpirationDateLink($share);
-
-				// Verify the password
-				$this->verifyPassword($share->getPassword());
-
-				// If a password is set. Hash it!
-				if ($share->getShareType() === IShare::TYPE_LINK
-					&& $share->getPassword() !== null) {
-					$share->setPassword($this->hasher->hash($share->getPassword()));
-				}
-			}
-
-			// Cannot share with the owner
-			if ($share->getShareType() === IShare::TYPE_USER &&
-				$share->getSharedWith() === $share->getShareOwner()) {
-				throw new \InvalidArgumentException($this->l->t('Cannot share with the share owner'));
-			}
-
-			// Generate the target
-			$defaultShareFolder = $this->config->getSystemValue('share_folder', '/');
-			$allowCustomShareFolder = $this->config->getSystemValueBool('sharing.allow_custom_share_folder', true);
-			if ($allowCustomShareFolder) {
-				$shareFolder = $this->config->getUserValue($share->getSharedWith(), Application::APP_ID, 'share_folder', $defaultShareFolder);
-			} else {
-				$shareFolder = $defaultShareFolder;
-			}
-
-			$target = $shareFolder . '/' . $share->getNode()->getName();
-			$target = \OC\Files\Filesystem::normalizePath($target);
-			$share->setTarget($target);
-
-			// Pre share event
-			$event = new Share\Events\BeforeShareCreatedEvent($share);
-			$this->dispatcher->dispatchTyped($event);
-			if ($event->isPropagationStopped() && $event->getError()) {
-				throw new \Exception($event->getError());
-			}
-
-			$oldShare = $share;
-			$provider = $this->factory->getProviderForType($share->getShareType());
-			$share = $provider->create($share);
-
-			// Reuse the node we already have
-			$share->setNode($oldShare->getNode());
-
-			// Reset the target if it is null for the new share
-			if ($share->getTarget() === '') {
-				$share->setTarget($target);
-			}
-		} catch (AlreadySharedException $e) {
-			// If a share for the same target already exists, dont create a new one,
-			// but do trigger the hooks and notifications again
-			$oldShare = $share;
-
-			// Reuse the node we already have
-			$share = $e->getExistingShare();
-			$share->setNode($oldShare->getNode());
-		}
-
-		// Post share event
-		$this->dispatcher->dispatchTyped(new ShareCreatedEvent($share));
-
-		// Send email if needed
-		if ($this->config->getSystemValueBool('sharing.enable_share_mail', true)) {
-			if ($share->getMailSend()) {
-				$provider = $this->factory->getProviderForType($share->getShareType());
-				if ($provider instanceof IShareProviderWithNotification) {
-					$provider->sendMailNotification($share);
-				} else {
-					$this->logger->debug('Share notification not sent because the provider does not support it.', ['app' => 'share']);
-				}
-			} else {
-				$this->logger->debug('Share notification not sent because mailsend is false.', ['app' => 'share']);
-			}
-		} else {
-			$this->logger->debug('Share notification not sent because sharing notification emails is disabled.', ['app' => 'share']);
-		}
-
-		return $share;
-	}
-
-	/**
-	 * Update a share
-	 *
-	 * @param IShare $share
-	 * @return IShare The share object
-	 * @throws \InvalidArgumentException
-	 * @throws HintException
-	 */
-	public function updateShare(IShare $share, bool $onlyValid = true) {
-		$expirationDateUpdated = false;
-
-		$this->canShare($share);
-
-		try {
-			$originalShare = $this->getShareById($share->getFullId(), onlyValid: $onlyValid);
-		} catch (\UnexpectedValueException $e) {
-			throw new \InvalidArgumentException($this->l->t('Share does not have a full ID'));
-		}
-
-		// We cannot change the share type!
-		if ($share->getShareType() !== $originalShare->getShareType()) {
-			throw new \InvalidArgumentException($this->l->t('Cannot change share type'));
-		}
-
-		// We can only change the recipient on user shares
-		if ($share->getSharedWith() !== $originalShare->getSharedWith() &&
-			$share->getShareType() !== IShare::TYPE_USER) {
-			throw new \InvalidArgumentException($this->l->t('Can only update recipient on user shares'));
-		}
-
-		// Cannot share with the owner
-		if ($share->getShareType() === IShare::TYPE_USER &&
-			$share->getSharedWith() === $share->getShareOwner()) {
-			throw new \InvalidArgumentException($this->l->t('Cannot share with the share owner'));
-		}
-
-		$this->generalCreateChecks($share, true);
-
-		if ($share->getShareType() === IShare::TYPE_USER) {
-			$this->userCreateChecks($share);
-
-			if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
-				// Verify the expiration date
-				$this->validateExpirationDateInternal($share);
-				$expirationDateUpdated = true;
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_GROUP) {
-			$this->groupCreateChecks($share);
-
-			if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
-				// Verify the expiration date
-				$this->validateExpirationDateInternal($share);
-				$expirationDateUpdated = true;
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_LINK
-			|| $share->getShareType() === IShare::TYPE_EMAIL) {
-			$this->linkCreateChecks($share);
-
-			// The new password is not set again if it is the same as the old
-			// one, unless when switching from sending by Talk to sending by
-			// mail.
-			$plainTextPassword = $share->getPassword();
-			$updatedPassword = $this->updateSharePasswordIfNeeded($share, $originalShare);
-
-			/**
-			 * Cannot enable the getSendPasswordByTalk if there is no password set
-			 */
-			if (empty($plainTextPassword) && $share->getSendPasswordByTalk()) {
-				throw new \InvalidArgumentException($this->l->t('Cannot enable sending the password by Talk with an empty password'));
-			}
-
-			/**
-			 * If we're in a mail share, we need to force a password change
-			 * as either the user is not aware of the password or is already (received by mail)
-			 * Thus the SendPasswordByTalk feature would not make sense
-			 */
-			if (!$updatedPassword && $share->getShareType() === IShare::TYPE_EMAIL) {
-				if (!$originalShare->getSendPasswordByTalk() && $share->getSendPasswordByTalk()) {
-					throw new \InvalidArgumentException($this->l->t('Cannot enable sending the password by Talk without setting a new password'));
-				}
-				if ($originalShare->getSendPasswordByTalk() && !$share->getSendPasswordByTalk()) {
-					throw new \InvalidArgumentException($this->l->t('Cannot disable sending the password by Talk without setting a new password'));
-				}
-			}
-
-			if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
-				// Verify the expiration date
-				$this->validateExpirationDateLink($share);
-				$expirationDateUpdated = true;
-			}
-		} elseif ($share->getShareType() === IShare::TYPE_REMOTE || $share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
-			if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
-				// Verify the expiration date
-				$this->validateExpirationDateInternal($share);
-				$expirationDateUpdated = true;
-			}
-		}
-
-		$this->pathCreateChecks($share->getNode());
-
-		// Now update the share!
-		$provider = $this->factory->getProviderForType($share->getShareType());
-		if ($share->getShareType() === IShare::TYPE_EMAIL) {
-			$share = $provider->update($share, $plainTextPassword);
-		} else {
-			$share = $provider->update($share);
-		}
-
-		if ($expirationDateUpdated === true) {
-			\OC_Hook::emit(Share::class, 'post_set_expiration_date', [
-				'itemType' => $share->getNode() instanceof \OCP\Files\File ? 'file' : 'folder',
-				'itemSource' => $share->getNode()->getId(),
-				'date' => $share->getExpirationDate(),
-				'uidOwner' => $share->getSharedBy(),
-			]);
-		}
-
-		if ($share->getPassword() !== $originalShare->getPassword()) {
-			\OC_Hook::emit(Share::class, 'post_update_password', [
-				'itemType' => $share->getNode() instanceof \OCP\Files\File ? 'file' : 'folder',
-				'itemSource' => $share->getNode()->getId(),
-				'uidOwner' => $share->getSharedBy(),
-				'token' => $share->getToken(),
-				'disabled' => is_null($share->getPassword()),
-			]);
-		}
-
-		if ($share->getPermissions() !== $originalShare->getPermissions()) {
-			if ($this->userManager->userExists($share->getShareOwner())) {
-				$userFolder = $this->rootFolder->getUserFolder($share->getShareOwner());
-			} else {
-				$userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
-			}
-			\OC_Hook::emit(Share::class, 'post_update_permissions', [
-				'itemType' => $share->getNode() instanceof \OCP\Files\File ? 'file' : 'folder',
-				'itemSource' => $share->getNode()->getId(),
-				'shareType' => $share->getShareType(),
-				'shareWith' => $share->getSharedWith(),
-				'uidOwner' => $share->getSharedBy(),
-				'permissions' => $share->getPermissions(),
-				'attributes' => $share->getAttributes() !== null ? $share->getAttributes()->toArray() : null,
-				'path' => $userFolder->getRelativePath($share->getNode()->getPath()),
-			]);
-		}
-
-		return $share;
-	}
-
-	/**
-	 * Accept a share.
-	 *
-	 * @param IShare $share
-	 * @param string $recipientId
-	 * @return IShare The share object
-	 * @throws \InvalidArgumentException Thrown if the provider does not implement `IShareProviderSupportsAccept`
-	 * @since 9.0.0
-	 */
-	public function acceptShare(IShare $share, string $recipientId): IShare {
-		[$providerId,] = $this->splitFullId($share->getFullId());
-		$provider = $this->factory->getProvider($providerId);
-
-		if (!($provider instanceof IShareProviderSupportsAccept)) {
-			throw new \InvalidArgumentException($this->l->t('Share provider does not support accepting'));
-		}
-		/** @var IShareProvider&IShareProviderSupportsAccept $provider */
-		$provider->acceptShare($share, $recipientId);
-
-		$event = new ShareAcceptedEvent($share);
-		$this->dispatcher->dispatchTyped($event);
-
-		return $share;
-	}
-
-	/**
-	 * Updates the password of the given share if it is not the same as the
-	 * password of the original share.
-	 *
-	 * @param IShare $share the share to update its password.
-	 * @param IShare $originalShare the original share to compare its
-	 *                              password with.
-	 * @return boolean whether the password was updated or not.
-	 */
-	private function updateSharePasswordIfNeeded(IShare $share, IShare $originalShare) {
-		$passwordsAreDifferent = ($share->getPassword() !== $originalShare->getPassword()) &&
-			(($share->getPassword() !== null && $originalShare->getPassword() === null) ||
-				($share->getPassword() === null && $originalShare->getPassword() !== null) ||
-				($share->getPassword() !== null && $originalShare->getPassword() !== null &&
-					!$this->hasher->verify($share->getPassword(), $originalShare->getPassword())));
-
-		// Password updated.
-		if ($passwordsAreDifferent) {
-			// Verify the password
-			$this->verifyPassword($share->getPassword());
-
-			// If a password is set. Hash it!
-			if (!empty($share->getPassword())) {
-				$share->setPassword($this->hasher->hash($share->getPassword()));
-				if ($share->getShareType() === IShare::TYPE_EMAIL) {
-					// Shares shared by email have temporary passwords
-					$this->setSharePasswordExpirationTime($share);
-				}
-
-				return true;
-			} else {
-				// Empty string and null are seen as NOT password protected
-				$share->setPassword(null);
-				if ($share->getShareType() === IShare::TYPE_EMAIL) {
-					$share->setPasswordExpirationTime(null);
-				}
-				return true;
-			}
-		} else {
-			// Reset the password to the original one, as it is either the same
-			// as the "new" password or a hashed version of it.
-			$share->setPassword($originalShare->getPassword());
-		}
-
-		return false;
-	}
-
-	/**
-	 * Set the share's password expiration time
-	 */
-	private function setSharePasswordExpirationTime(IShare $share): void {
-		if (!$this->config->getSystemValueBool('sharing.enable_mail_link_password_expiration', false)) {
-			// Sets password expiration date to NULL
-			$share->setPasswordExpirationTime();
-			return;
-		}
-		// Sets password expiration date
-		$expirationTime = null;
-		$now = new \DateTime();
-		$expirationInterval = $this->config->getSystemValue('sharing.mail_link_password_expiration_interval', 3600);
-		$expirationTime = $now->add(new \DateInterval('PT' . $expirationInterval . 'S'));
-		$share->setPasswordExpirationTime($expirationTime);
-	}
-
-
-	/**
-	 * Delete all the children of this share
-	 * FIXME: remove once https://github.com/owncloud/core/pull/21660 is in
-	 *
-	 * @param IShare $share
-	 * @return IShare[] List of deleted shares
-	 */
-	protected function deleteChildren(IShare $share) {
-		$deletedShares = [];
-
-		$provider = $this->factory->getProviderForType($share->getShareType());
-
-		foreach ($provider->getChildren($share) as $child) {
-			$this->dispatcher->dispatchTyped(new BeforeShareDeletedEvent($child));
-
-			$deletedChildren = $this->deleteChildren($child);
-			$deletedShares = array_merge($deletedShares, $deletedChildren);
-
-			$provider->delete($child);
-			$this->dispatcher->dispatchTyped(new ShareDeletedEvent($child));
-			$deletedShares[] = $child;
-		}
-
-		return $deletedShares;
-	}
-
-	/** Promote re-shares into direct shares so that target user keeps access */
-	protected function promoteReshares(IShare $share): void {
-		try {
-			$node = $share->getNode();
-		} catch (NotFoundException) {
-			/* Skip if node not found */
-			return;
-		}
-
-		$userIds = [];
-
-		if ($share->getShareType() === IShare::TYPE_USER) {
-			$userIds[] = $share->getSharedWith();
-		} elseif ($share->getShareType() === IShare::TYPE_GROUP) {
-			$group = $this->groupManager->get($share->getSharedWith());
-			$users = $group?->getUsers() ?? [];
-
-			foreach ($users as $user) {
-				/* Skip share owner */
-				if ($user->getUID() === $share->getShareOwner() || $user->getUID() === $share->getSharedBy()) {
-					continue;
-				}
-				$userIds[] = $user->getUID();
-			}
-		} else {
-			/* We only support user and group shares */
-			return;
-		}
-
-		$reshareRecords = [];
-		$shareTypes = [
-			IShare::TYPE_GROUP,
-			IShare::TYPE_USER,
-			IShare::TYPE_LINK,
-			IShare::TYPE_REMOTE,
-			IShare::TYPE_EMAIL,
-		];
-
-		foreach ($userIds as $userId) {
-			foreach ($shareTypes as $shareType) {
-				try {
-					$provider = $this->factory->getProviderForType($shareType);
-				} catch (ProviderException $e) {
-					continue;
-				}
-
-				if ($node instanceof Folder) {
-					/* We need to get all shares by this user to get subshares */
-					$shares = $provider->getSharesBy($userId, $shareType, null, false, -1, 0);
-
-					foreach ($shares as $share) {
-						try {
-							$path = $share->getNode()->getPath();
-						} catch (NotFoundException) {
-							/* Ignore share of non-existing node */
-							continue;
-						}
-						if ($node->getRelativePath($path) !== null) {
-							/* If relative path is not null it means the shared node is the same or in a subfolder */
-							$reshareRecords[] = $share;
-						}
-					}
-				} else {
-					$shares = $provider->getSharesBy($userId, $shareType, $node, false, -1, 0);
-					foreach ($shares as $child) {
-						$reshareRecords[] = $child;
-					}
-				}
-			}
-		}
-
-		foreach ($reshareRecords as $child) {
-			try {
-				/* Check if the share is still valid (means the resharer still has access to the file through another mean) */
-				$this->generalCreateChecks($child);
-			} catch (GenericShareException $e) {
-				/* The check is invalid, promote it to a direct share from the sharer of parent share */
-				$this->logger->debug('Promote reshare because of exception ' . $e->getMessage(), ['exception' => $e, 'fullId' => $child->getFullId()]);
-				try {
-					$child->setSharedBy($share->getSharedBy());
-					$this->updateShare($child);
-				} catch (GenericShareException|\InvalidArgumentException $e) {
-					$this->logger->warning('Failed to promote reshare because of exception ' . $e->getMessage(), ['exception' => $e, 'fullId' => $child->getFullId()]);
-				}
-			}
-		}
-	}
-
-	/**
-	 * Delete a share
-	 *
-	 * @param IShare $share
-	 * @throws ShareNotFound
-	 * @throws \InvalidArgumentException
-	 */
-	public function deleteShare(IShare $share) {
-		try {
-			$share->getFullId();
-		} catch (\UnexpectedValueException $e) {
-			throw new \InvalidArgumentException($this->l->t('Share does not have a full ID'));
-		}
-
-		$this->dispatcher->dispatchTyped(new BeforeShareDeletedEvent($share));
-
-		// Get all children and delete them as well
-		$this->deleteChildren($share);
-
-		// Do the actual delete
-		$provider = $this->factory->getProviderForType($share->getShareType());
-		$provider->delete($share);
-
-		$this->dispatcher->dispatchTyped(new ShareDeletedEvent($share));
-
-		// Promote reshares of the deleted share
-		$this->promoteReshares($share);
-	}
-
-
-	/**
-	 * Unshare a file as the recipient.
-	 * This can be different from a regular delete for example when one of
-	 * the users in a groups deletes that share. But the provider should
-	 * handle this.
-	 *
-	 * @param IShare $share
-	 * @param string $recipientId
-	 */
-	public function deleteFromSelf(IShare $share, $recipientId) {
-		[$providerId,] = $this->splitFullId($share->getFullId());
-		$provider = $this->factory->getProvider($providerId);
-
-		$provider->deleteFromSelf($share, $recipientId);
-		$event = new ShareDeletedFromSelfEvent($share);
-		$this->dispatcher->dispatchTyped($event);
-	}
-
-	public function restoreShare(IShare $share, string $recipientId): IShare {
-		[$providerId,] = $this->splitFullId($share->getFullId());
-		$provider = $this->factory->getProvider($providerId);
-
-		return $provider->restore($share, $recipientId);
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function moveShare(IShare $share, $recipientId) {
-		if ($share->getShareType() === IShare::TYPE_LINK
-			|| $share->getShareType() === IShare::TYPE_EMAIL) {
-			throw new \InvalidArgumentException($this->l->t('Cannot change target of link share'));
-		}
-
-		if ($share->getShareType() === IShare::TYPE_USER && $share->getSharedWith() !== $recipientId) {
-			throw new \InvalidArgumentException($this->l->t('Invalid share recipient'));
-		}
-
-		if ($share->getShareType() === IShare::TYPE_GROUP) {
-			$sharedWith = $this->groupManager->get($share->getSharedWith());
-			if (is_null($sharedWith)) {
-				throw new \InvalidArgumentException($this->l->t('Group "%s" does not exist', [$share->getSharedWith()]));
-			}
-			$recipient = $this->userManager->get($recipientId);
-			if (!$sharedWith->inGroup($recipient)) {
-				throw new \InvalidArgumentException($this->l->t('Invalid share recipient'));
-			}
-		}
-
-		[$providerId,] = $this->splitFullId($share->getFullId());
-		$provider = $this->factory->getProvider($providerId);
-
-		return $provider->move($share, $recipientId);
-	}
-
-	public function getSharesInFolder($userId, Folder $node, $reshares = false, $shallow = true) {
-		$providers = $this->factory->getAllProviders();
-		if (!$shallow) {
-			throw new \Exception('non-shallow getSharesInFolder is no longer supported');
-		}
-
-		$isOwnerless = $node->getMountPoint() instanceof IShareOwnerlessMount;
-
-		$shares = [];
-		foreach ($providers as $provider) {
-			if ($isOwnerless) {
-				// If the provider does not implement the additional interface,
-				// we lack a performant way of querying all shares and therefore ignore the provider.
-				if ($provider instanceof IShareProviderSupportsAllSharesInFolder) {
-					foreach ($provider->getAllSharesInFolder($node) as $fid => $data) {
-						$shares[$fid] ??= [];
-						$shares[$fid] = array_merge($shares[$fid], $data);
-					}
-				}
-			} else {
-				foreach ($provider->getSharesInFolder($userId, $node, $reshares) as $fid => $data) {
-					$shares[$fid] ??= [];
-					$shares[$fid] = array_merge($shares[$fid], $data);
-				}
-			}
-		}
-
-		return $shares;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getSharesBy($userId, $shareType, $path = null, $reshares = false, $limit = 50, $offset = 0, bool $onlyValid = true) {
-		if ($path !== null &&
-			!($path instanceof \OCP\Files\File) &&
-			!($path instanceof \OCP\Files\Folder)) {
-			throw new \InvalidArgumentException($this->l->t('Invalid path'));
-		}
-
-		try {
-			$provider = $this->factory->getProviderForType($shareType);
-		} catch (ProviderException $e) {
-			return [];
-		}
-
-		if ($path?->getMountPoint() instanceof IShareOwnerlessMount) {
-			$shares = array_filter($provider->getSharesByPath($path), static fn (IShare $share) => $share->getShareType() === $shareType);
-		} else {
-			$shares = $provider->getSharesBy($userId, $shareType, $path, $reshares, $limit, $offset);
-		}
-
-		/*
+        $storage = $share->getNode()->getStorage();
+        if ($storage->instanceOfStorage('OCA\Files_Sharing\External\Storage')) {
+            $parent = $share->getNode()->getParent();
+            while ($parent->getStorage()->instanceOfStorage('OCA\Files_Sharing\External\Storage')) {
+                $parent = $parent->getParent();
+            }
+            $share->setShareOwner($parent->getOwner()->getUID());
+        } else {
+            if ($share->getNode()->getOwner()) {
+                $share->setShareOwner($share->getNode()->getOwner()->getUID());
+            } else {
+                $share->setShareOwner($share->getSharedBy());
+            }
+        }
+
+        try {
+            // Verify share type
+            if ($share->getShareType() === IShare::TYPE_USER) {
+                $this->userCreateChecks($share);
+
+                // Verify the expiration date
+                $share = $this->validateExpirationDateInternal($share);
+            } elseif ($share->getShareType() === IShare::TYPE_GROUP) {
+                $this->groupCreateChecks($share);
+
+                // Verify the expiration date
+                $share = $this->validateExpirationDateInternal($share);
+            } elseif ($share->getShareType() === IShare::TYPE_REMOTE || $share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
+                // Verify the expiration date
+                $share = $this->validateExpirationDateInternal($share);
+            } elseif ($share->getShareType() === IShare::TYPE_LINK
+                || $share->getShareType() === IShare::TYPE_EMAIL) {
+                $this->linkCreateChecks($share);
+                $this->setLinkParent($share);
+
+                $token = $this->generateToken();
+                // Set the unique token
+                $share->setToken($token);
+
+                // Verify the expiration date
+                $share = $this->validateExpirationDateLink($share);
+
+                // Verify the password
+                $this->verifyPassword($share->getPassword());
+
+                // If a password is set. Hash it!
+                if ($share->getShareType() === IShare::TYPE_LINK
+                    && $share->getPassword() !== null) {
+                    $share->setPassword($this->hasher->hash($share->getPassword()));
+                }
+            }
+
+            // Cannot share with the owner
+            if ($share->getShareType() === IShare::TYPE_USER &&
+                $share->getSharedWith() === $share->getShareOwner()) {
+                throw new \InvalidArgumentException($this->l->t('Cannot share with the share owner'));
+            }
+
+            // Generate the target
+            $defaultShareFolder = $this->config->getSystemValue('share_folder', '/');
+            $allowCustomShareFolder = $this->config->getSystemValueBool('sharing.allow_custom_share_folder', true);
+            if ($allowCustomShareFolder) {
+                $shareFolder = $this->config->getUserValue($share->getSharedWith(), Application::APP_ID, 'share_folder', $defaultShareFolder);
+            } else {
+                $shareFolder = $defaultShareFolder;
+            }
+
+            $target = $shareFolder . '/' . $share->getNode()->getName();
+            $target = \OC\Files\Filesystem::normalizePath($target);
+            $share->setTarget($target);
+
+            // Pre share event
+            $event = new Share\Events\BeforeShareCreatedEvent($share);
+            $this->dispatcher->dispatchTyped($event);
+            if ($event->isPropagationStopped() && $event->getError()) {
+                throw new \Exception($event->getError());
+            }
+
+            $oldShare = $share;
+            $provider = $this->factory->getProviderForType($share->getShareType());
+            $share = $provider->create($share);
+
+            // Reuse the node we already have
+            $share->setNode($oldShare->getNode());
+
+            // Reset the target if it is null for the new share
+            if ($share->getTarget() === '') {
+                $share->setTarget($target);
+            }
+        } catch (AlreadySharedException $e) {
+            // If a share for the same target already exists, dont create a new one,
+            // but do trigger the hooks and notifications again
+            $oldShare = $share;
+
+            // Reuse the node we already have
+            $share = $e->getExistingShare();
+            $share->setNode($oldShare->getNode());
+        }
+
+        // Post share event
+        $this->dispatcher->dispatchTyped(new ShareCreatedEvent($share));
+
+        // Send email if needed
+        if ($this->config->getSystemValueBool('sharing.enable_share_mail', true)) {
+            if ($share->getMailSend()) {
+                $provider = $this->factory->getProviderForType($share->getShareType());
+                if ($provider instanceof IShareProviderWithNotification) {
+                    $provider->sendMailNotification($share);
+                } else {
+                    $this->logger->debug('Share notification not sent because the provider does not support it.', ['app' => 'share']);
+                }
+            } else {
+                $this->logger->debug('Share notification not sent because mailsend is false.', ['app' => 'share']);
+            }
+        } else {
+            $this->logger->debug('Share notification not sent because sharing notification emails is disabled.', ['app' => 'share']);
+        }
+
+        return $share;
+    }
+
+    /**
+     * Update a share
+     *
+     * @param IShare $share
+     * @return IShare The share object
+     * @throws \InvalidArgumentException
+     * @throws HintException
+     */
+    public function updateShare(IShare $share, bool $onlyValid = true) {
+        $expirationDateUpdated = false;
+
+        $this->canShare($share);
+
+        try {
+            $originalShare = $this->getShareById($share->getFullId(), onlyValid: $onlyValid);
+        } catch (\UnexpectedValueException $e) {
+            throw new \InvalidArgumentException($this->l->t('Share does not have a full ID'));
+        }
+
+        // We cannot change the share type!
+        if ($share->getShareType() !== $originalShare->getShareType()) {
+            throw new \InvalidArgumentException($this->l->t('Cannot change share type'));
+        }
+
+        // We can only change the recipient on user shares
+        if ($share->getSharedWith() !== $originalShare->getSharedWith() &&
+            $share->getShareType() !== IShare::TYPE_USER) {
+            throw new \InvalidArgumentException($this->l->t('Can only update recipient on user shares'));
+        }
+
+        // Cannot share with the owner
+        if ($share->getShareType() === IShare::TYPE_USER &&
+            $share->getSharedWith() === $share->getShareOwner()) {
+            throw new \InvalidArgumentException($this->l->t('Cannot share with the share owner'));
+        }
+
+        $this->generalCreateChecks($share, true);
+
+        if ($share->getShareType() === IShare::TYPE_USER) {
+            $this->userCreateChecks($share);
+
+            if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
+                // Verify the expiration date
+                $this->validateExpirationDateInternal($share);
+                $expirationDateUpdated = true;
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_GROUP) {
+            $this->groupCreateChecks($share);
+
+            if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
+                // Verify the expiration date
+                $this->validateExpirationDateInternal($share);
+                $expirationDateUpdated = true;
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_LINK
+            || $share->getShareType() === IShare::TYPE_EMAIL) {
+            $this->linkCreateChecks($share);
+
+            // The new password is not set again if it is the same as the old
+            // one, unless when switching from sending by Talk to sending by
+            // mail.
+            $plainTextPassword = $share->getPassword();
+            $updatedPassword = $this->updateSharePasswordIfNeeded($share, $originalShare);
+
+            /**
+             * Cannot enable the getSendPasswordByTalk if there is no password set
+             */
+            if (empty($plainTextPassword) && $share->getSendPasswordByTalk()) {
+                throw new \InvalidArgumentException($this->l->t('Cannot enable sending the password by Talk with an empty password'));
+            }
+
+            /**
+             * If we're in a mail share, we need to force a password change
+             * as either the user is not aware of the password or is already (received by mail)
+             * Thus the SendPasswordByTalk feature would not make sense
+             */
+            if (!$updatedPassword && $share->getShareType() === IShare::TYPE_EMAIL) {
+                if (!$originalShare->getSendPasswordByTalk() && $share->getSendPasswordByTalk()) {
+                    throw new \InvalidArgumentException($this->l->t('Cannot enable sending the password by Talk without setting a new password'));
+                }
+                if ($originalShare->getSendPasswordByTalk() && !$share->getSendPasswordByTalk()) {
+                    throw new \InvalidArgumentException($this->l->t('Cannot disable sending the password by Talk without setting a new password'));
+                }
+            }
+
+            if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
+                // Verify the expiration date
+                $this->validateExpirationDateLink($share);
+                $expirationDateUpdated = true;
+            }
+        } elseif ($share->getShareType() === IShare::TYPE_REMOTE || $share->getShareType() === IShare::TYPE_REMOTE_GROUP) {
+            if ($share->getExpirationDate() != $originalShare->getExpirationDate()) {
+                // Verify the expiration date
+                $this->validateExpirationDateInternal($share);
+                $expirationDateUpdated = true;
+            }
+        }
+
+        $this->pathCreateChecks($share->getNode());
+
+        // Now update the share!
+        $provider = $this->factory->getProviderForType($share->getShareType());
+        if ($share->getShareType() === IShare::TYPE_EMAIL) {
+            $share = $provider->update($share, $plainTextPassword);
+        } else {
+            $share = $provider->update($share);
+        }
+
+        if ($expirationDateUpdated === true) {
+            \OC_Hook::emit(Share::class, 'post_set_expiration_date', [
+                'itemType' => $share->getNode() instanceof \OCP\Files\File ? 'file' : 'folder',
+                'itemSource' => $share->getNode()->getId(),
+                'date' => $share->getExpirationDate(),
+                'uidOwner' => $share->getSharedBy(),
+            ]);
+        }
+
+        if ($share->getPassword() !== $originalShare->getPassword()) {
+            \OC_Hook::emit(Share::class, 'post_update_password', [
+                'itemType' => $share->getNode() instanceof \OCP\Files\File ? 'file' : 'folder',
+                'itemSource' => $share->getNode()->getId(),
+                'uidOwner' => $share->getSharedBy(),
+                'token' => $share->getToken(),
+                'disabled' => is_null($share->getPassword()),
+            ]);
+        }
+
+        if ($share->getPermissions() !== $originalShare->getPermissions()) {
+            if ($this->userManager->userExists($share->getShareOwner())) {
+                $userFolder = $this->rootFolder->getUserFolder($share->getShareOwner());
+            } else {
+                $userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
+            }
+            \OC_Hook::emit(Share::class, 'post_update_permissions', [
+                'itemType' => $share->getNode() instanceof \OCP\Files\File ? 'file' : 'folder',
+                'itemSource' => $share->getNode()->getId(),
+                'shareType' => $share->getShareType(),
+                'shareWith' => $share->getSharedWith(),
+                'uidOwner' => $share->getSharedBy(),
+                'permissions' => $share->getPermissions(),
+                'attributes' => $share->getAttributes() !== null ? $share->getAttributes()->toArray() : null,
+                'path' => $userFolder->getRelativePath($share->getNode()->getPath()),
+            ]);
+        }
+
+        return $share;
+    }
+
+    /**
+     * Accept a share.
+     *
+     * @param IShare $share
+     * @param string $recipientId
+     * @return IShare The share object
+     * @throws \InvalidArgumentException Thrown if the provider does not implement `IShareProviderSupportsAccept`
+     * @since 9.0.0
+     */
+    public function acceptShare(IShare $share, string $recipientId): IShare {
+        [$providerId,] = $this->splitFullId($share->getFullId());
+        $provider = $this->factory->getProvider($providerId);
+
+        if (!($provider instanceof IShareProviderSupportsAccept)) {
+            throw new \InvalidArgumentException($this->l->t('Share provider does not support accepting'));
+        }
+        /** @var IShareProvider&IShareProviderSupportsAccept $provider */
+        $provider->acceptShare($share, $recipientId);
+
+        $event = new ShareAcceptedEvent($share);
+        $this->dispatcher->dispatchTyped($event);
+
+        return $share;
+    }
+
+    /**
+     * Updates the password of the given share if it is not the same as the
+     * password of the original share.
+     *
+     * @param IShare $share the share to update its password.
+     * @param IShare $originalShare the original share to compare its
+     *                              password with.
+     * @return boolean whether the password was updated or not.
+     */
+    private function updateSharePasswordIfNeeded(IShare $share, IShare $originalShare) {
+        $passwordsAreDifferent = ($share->getPassword() !== $originalShare->getPassword()) &&
+            (($share->getPassword() !== null && $originalShare->getPassword() === null) ||
+                ($share->getPassword() === null && $originalShare->getPassword() !== null) ||
+                ($share->getPassword() !== null && $originalShare->getPassword() !== null &&
+                    !$this->hasher->verify($share->getPassword(), $originalShare->getPassword())));
+
+        // Password updated.
+        if ($passwordsAreDifferent) {
+            // Verify the password
+            $this->verifyPassword($share->getPassword());
+
+            // If a password is set. Hash it!
+            if (!empty($share->getPassword())) {
+                $share->setPassword($this->hasher->hash($share->getPassword()));
+                if ($share->getShareType() === IShare::TYPE_EMAIL) {
+                    // Shares shared by email have temporary passwords
+                    $this->setSharePasswordExpirationTime($share);
+                }
+
+                return true;
+            } else {
+                // Empty string and null are seen as NOT password protected
+                $share->setPassword(null);
+                if ($share->getShareType() === IShare::TYPE_EMAIL) {
+                    $share->setPasswordExpirationTime(null);
+                }
+                return true;
+            }
+        } else {
+            // Reset the password to the original one, as it is either the same
+            // as the "new" password or a hashed version of it.
+            $share->setPassword($originalShare->getPassword());
+        }
+
+        return false;
+    }
+
+    /**
+     * Set the share's password expiration time
+     */
+    private function setSharePasswordExpirationTime(IShare $share): void {
+        if (!$this->config->getSystemValueBool('sharing.enable_mail_link_password_expiration', false)) {
+            // Sets password expiration date to NULL
+            $share->setPasswordExpirationTime();
+            return;
+        }
+        // Sets password expiration date
+        $expirationTime = null;
+        $now = new \DateTime();
+        $expirationInterval = $this->config->getSystemValue('sharing.mail_link_password_expiration_interval', 3600);
+        $expirationTime = $now->add(new \DateInterval('PT' . $expirationInterval . 'S'));
+        $share->setPasswordExpirationTime($expirationTime);
+    }
+
+
+    /**
+     * Delete all the children of this share
+     * FIXME: remove once https://github.com/owncloud/core/pull/21660 is in
+     *
+     * @param IShare $share
+     * @return IShare[] List of deleted shares
+     */
+    protected function deleteChildren(IShare $share) {
+        $deletedShares = [];
+
+        $provider = $this->factory->getProviderForType($share->getShareType());
+
+        foreach ($provider->getChildren($share) as $child) {
+            $this->dispatcher->dispatchTyped(new BeforeShareDeletedEvent($child));
+
+            $deletedChildren = $this->deleteChildren($child);
+            $deletedShares = array_merge($deletedShares, $deletedChildren);
+
+            $provider->delete($child);
+            $this->dispatcher->dispatchTyped(new ShareDeletedEvent($child));
+            $deletedShares[] = $child;
+        }
+
+        return $deletedShares;
+    }
+
+    /** Promote re-shares into direct shares so that target user keeps access */
+    protected function promoteReshares(IShare $share): void {
+        try {
+            $node = $share->getNode();
+        } catch (NotFoundException) {
+            /* Skip if node not found */
+            return;
+        }
+
+        $userIds = [];
+
+        if ($share->getShareType() === IShare::TYPE_USER) {
+            $userIds[] = $share->getSharedWith();
+        } elseif ($share->getShareType() === IShare::TYPE_GROUP) {
+            $group = $this->groupManager->get($share->getSharedWith());
+            $users = $group?->getUsers() ?? [];
+
+            foreach ($users as $user) {
+                /* Skip share owner */
+                if ($user->getUID() === $share->getShareOwner() || $user->getUID() === $share->getSharedBy()) {
+                    continue;
+                }
+                $userIds[] = $user->getUID();
+            }
+        } else {
+            /* We only support user and group shares */
+            return;
+        }
+
+        $reshareRecords = [];
+        $shareTypes = [
+            IShare::TYPE_GROUP,
+            IShare::TYPE_USER,
+            IShare::TYPE_LINK,
+            IShare::TYPE_REMOTE,
+            IShare::TYPE_EMAIL,
+        ];
+
+        foreach ($userIds as $userId) {
+            foreach ($shareTypes as $shareType) {
+                try {
+                    $provider = $this->factory->getProviderForType($shareType);
+                } catch (ProviderException $e) {
+                    continue;
+                }
+
+                if ($node instanceof Folder) {
+                    /* We need to get all shares by this user to get subshares */
+                    $shares = $provider->getSharesBy($userId, $shareType, null, false, -1, 0);
+
+                    foreach ($shares as $share) {
+                        try {
+                            $path = $share->getNode()->getPath();
+                        } catch (NotFoundException) {
+                            /* Ignore share of non-existing node */
+                            continue;
+                        }
+                        if ($node->getRelativePath($path) !== null) {
+                            /* If relative path is not null it means the shared node is the same or in a subfolder */
+                            $reshareRecords[] = $share;
+                        }
+                    }
+                } else {
+                    $shares = $provider->getSharesBy($userId, $shareType, $node, false, -1, 0);
+                    foreach ($shares as $child) {
+                        $reshareRecords[] = $child;
+                    }
+                }
+            }
+        }
+
+        foreach ($reshareRecords as $child) {
+            try {
+                /* Check if the share is still valid (means the resharer still has access to the file through another mean) */
+                $this->generalCreateChecks($child);
+            } catch (GenericShareException $e) {
+                /* The check is invalid, promote it to a direct share from the sharer of parent share */
+                $this->logger->debug('Promote reshare because of exception ' . $e->getMessage(), ['exception' => $e, 'fullId' => $child->getFullId()]);
+                try {
+                    $child->setSharedBy($share->getSharedBy());
+                    $this->updateShare($child);
+                } catch (GenericShareException|\InvalidArgumentException $e) {
+                    $this->logger->warning('Failed to promote reshare because of exception ' . $e->getMessage(), ['exception' => $e, 'fullId' => $child->getFullId()]);
+                }
+            }
+        }
+    }
+
+    /**
+     * Delete a share
+     *
+     * @param IShare $share
+     * @throws ShareNotFound
+     * @throws \InvalidArgumentException
+     */
+    public function deleteShare(IShare $share) {
+        try {
+            $share->getFullId();
+        } catch (\UnexpectedValueException $e) {
+            throw new \InvalidArgumentException($this->l->t('Share does not have a full ID'));
+        }
+
+        $this->dispatcher->dispatchTyped(new BeforeShareDeletedEvent($share));
+
+        // Get all children and delete them as well
+        $this->deleteChildren($share);
+
+        // Do the actual delete
+        $provider = $this->factory->getProviderForType($share->getShareType());
+        $provider->delete($share);
+
+        $this->dispatcher->dispatchTyped(new ShareDeletedEvent($share));
+
+        // Promote reshares of the deleted share
+        $this->promoteReshares($share);
+    }
+
+
+    /**
+     * Unshare a file as the recipient.
+     * This can be different from a regular delete for example when one of
+     * the users in a groups deletes that share. But the provider should
+     * handle this.
+     *
+     * @param IShare $share
+     * @param string $recipientId
+     */
+    public function deleteFromSelf(IShare $share, $recipientId) {
+        [$providerId,] = $this->splitFullId($share->getFullId());
+        $provider = $this->factory->getProvider($providerId);
+
+        $provider->deleteFromSelf($share, $recipientId);
+        $event = new ShareDeletedFromSelfEvent($share);
+        $this->dispatcher->dispatchTyped($event);
+    }
+
+    public function restoreShare(IShare $share, string $recipientId): IShare {
+        [$providerId,] = $this->splitFullId($share->getFullId());
+        $provider = $this->factory->getProvider($providerId);
+
+        return $provider->restore($share, $recipientId);
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function moveShare(IShare $share, $recipientId) {
+        if ($share->getShareType() === IShare::TYPE_LINK
+            || $share->getShareType() === IShare::TYPE_EMAIL) {
+            throw new \InvalidArgumentException($this->l->t('Cannot change target of link share'));
+        }
+
+        if ($share->getShareType() === IShare::TYPE_USER && $share->getSharedWith() !== $recipientId) {
+            throw new \InvalidArgumentException($this->l->t('Invalid share recipient'));
+        }
+
+        if ($share->getShareType() === IShare::TYPE_GROUP) {
+            $sharedWith = $this->groupManager->get($share->getSharedWith());
+            if (is_null($sharedWith)) {
+                throw new \InvalidArgumentException($this->l->t('Group "%s" does not exist', [$share->getSharedWith()]));
+            }
+            $recipient = $this->userManager->get($recipientId);
+            if (!$sharedWith->inGroup($recipient)) {
+                throw new \InvalidArgumentException($this->l->t('Invalid share recipient'));
+            }
+        }
+
+        [$providerId,] = $this->splitFullId($share->getFullId());
+        $provider = $this->factory->getProvider($providerId);
+
+        return $provider->move($share, $recipientId);
+    }
+
+    public function getSharesInFolder($userId, Folder $node, $reshares = false, $shallow = true) {
+        $providers = $this->factory->getAllProviders();
+        if (!$shallow) {
+            throw new \Exception('non-shallow getSharesInFolder is no longer supported');
+        }
+
+        $isOwnerless = $node->getMountPoint() instanceof IShareOwnerlessMount;
+
+        $shares = [];
+        foreach ($providers as $provider) {
+            if ($isOwnerless) {
+                // If the provider does not implement the additional interface,
+                // we lack a performant way of querying all shares and therefore ignore the provider.
+                if ($provider instanceof IShareProviderSupportsAllSharesInFolder) {
+                    foreach ($provider->getAllSharesInFolder($node) as $fid => $data) {
+                        $shares[$fid] ??= [];
+                        $shares[$fid] = array_merge($shares[$fid], $data);
+                    }
+                }
+            } else {
+                foreach ($provider->getSharesInFolder($userId, $node, $reshares) as $fid => $data) {
+                    $shares[$fid] ??= [];
+                    $shares[$fid] = array_merge($shares[$fid], $data);
+                }
+            }
+        }
+
+        return $shares;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getSharesBy($userId, $shareType, $path = null, $reshares = false, $limit = 50, $offset = 0, bool $onlyValid = true) {
+        if ($path !== null &&
+            !($path instanceof \OCP\Files\File) &&
+            !($path instanceof \OCP\Files\Folder)) {
+            throw new \InvalidArgumentException($this->l->t('Invalid path'));
+        }
+
+        try {
+            $provider = $this->factory->getProviderForType($shareType);
+        } catch (ProviderException $e) {
+            return [];
+        }
+
+        if ($path?->getMountPoint() instanceof IShareOwnerlessMount) {
+            $shares = array_filter($provider->getSharesByPath($path), static fn (IShare $share) => $share->getShareType() === $shareType);
+        } else {
+            $shares = $provider->getSharesBy($userId, $shareType, $path, $reshares, $limit, $offset);
+        }
+
+        /*
 		 * Work around so we don't return expired shares but still follow
 		 * proper pagination.
 		 */
 
-		$shares2 = [];
-
-		while (true) {
-			$added = 0;
-			foreach ($shares as $share) {
-				if ($onlyValid) {
-					try {
-						$this->checkShare($share);
-					} catch (ShareNotFound $e) {
-						// Ignore since this basically means the share is deleted
-						continue;
-					}
-				}
-
-				$added++;
-				$shares2[] = $share;
-
-				if (count($shares2) === $limit) {
-					break;
-				}
-			}
-
-			// If we did not fetch more shares than the limit then there are no more shares
-			if (count($shares) < $limit) {
-				break;
-			}
-
-			if (count($shares2) === $limit) {
-				break;
-			}
-
-			// If there was no limit on the select we are done
-			if ($limit === -1) {
-				break;
-			}
-
-			$offset += $added;
-
-			// Fetch again $limit shares
-			if ($path?->getMountPoint() instanceof IShareOwnerlessMount) {
-				// We already fetched all shares, so end here
-				$shares = [];
-			} else {
-				$shares = $provider->getSharesBy($userId, $shareType, $path, $reshares, $limit, $offset);
-			}
-
-			// No more shares means we are done
-			if (empty($shares)) {
-				break;
-			}
-		}
-
-		$shares = $shares2;
-
-		return $shares;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getSharedWith($userId, $shareType, $node = null, $limit = 50, $offset = 0) {
-		try {
-			$provider = $this->factory->getProviderForType($shareType);
-		} catch (ProviderException $e) {
-			return [];
-		}
-
-		$shares = $provider->getSharedWith($userId, $shareType, $node, $limit, $offset);
-
-		// remove all shares which are already expired
-		foreach ($shares as $key => $share) {
-			try {
-				$this->checkShare($share);
-			} catch (ShareNotFound $e) {
-				unset($shares[$key]);
-			}
-		}
-
-		return $shares;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getDeletedSharedWith($userId, $shareType, $node = null, $limit = 50, $offset = 0) {
-		$shares = $this->getSharedWith($userId, $shareType, $node, $limit, $offset);
-
-		// Only get deleted shares
-		$shares = array_filter($shares, function (IShare $share) {
-			return $share->getPermissions() === 0;
-		});
-
-		// Only get shares where the owner still exists
-		$shares = array_filter($shares, function (IShare $share) {
-			return $this->userManager->userExists($share->getShareOwner());
-		});
-
-		return $shares;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getShareById($id, $recipient = null, bool $onlyValid = true) {
-		if ($id === null) {
-			throw new ShareNotFound();
-		}
-
-		[$providerId, $id] = $this->splitFullId($id);
-
-		try {
-			$provider = $this->factory->getProvider($providerId);
-		} catch (ProviderException $e) {
-			throw new ShareNotFound();
-		}
-
-		$share = $provider->getShareById($id, $recipient);
-
-		if ($onlyValid) {
-			$this->checkShare($share);
-		}
-
-		return $share;
-	}
-
-	/**
-	 * Get all the shares for a given path
-	 *
-	 * @param \OCP\Files\Node $path
-	 * @param int $page
-	 * @param int $perPage
-	 *
-	 * @return Share[]
-	 */
-	public function getSharesByPath(\OCP\Files\Node $path, $page = 0, $perPage = 50) {
-		return [];
-	}
-
-	/**
-	 * Get the share by token possible with password
-	 *
-	 * @param string $token
-	 * @return IShare
-	 *
-	 * @throws ShareNotFound
-	 */
-	public function getShareByToken($token) {
-		// tokens cannot be valid local user names
-		if ($this->userManager->userExists($token)) {
-			throw new ShareNotFound();
-		}
-		$share = null;
-		try {
-			if ($this->shareApiAllowLinks()) {
-				$provider = $this->factory->getProviderForType(IShare::TYPE_LINK);
-				$share = $provider->getShareByToken($token);
-			}
-		} catch (ProviderException $e) {
-		} catch (ShareNotFound $e) {
-		}
-
-
-		// If it is not a link share try to fetch a federated share by token
-		if ($share === null) {
-			try {
-				$provider = $this->factory->getProviderForType(IShare::TYPE_REMOTE);
-				$share = $provider->getShareByToken($token);
-			} catch (ProviderException $e) {
-			} catch (ShareNotFound $e) {
-			}
-		}
-
-		// If it is not a link share try to fetch a mail share by token
-		if ($share === null && $this->shareProviderExists(IShare::TYPE_EMAIL)) {
-			try {
-				$provider = $this->factory->getProviderForType(IShare::TYPE_EMAIL);
-				$share = $provider->getShareByToken($token);
-			} catch (ProviderException $e) {
-			} catch (ShareNotFound $e) {
-			}
-		}
-
-		if ($share === null && $this->shareProviderExists(IShare::TYPE_CIRCLE)) {
-			try {
-				$provider = $this->factory->getProviderForType(IShare::TYPE_CIRCLE);
-				$share = $provider->getShareByToken($token);
-			} catch (ProviderException $e) {
-			} catch (ShareNotFound $e) {
-			}
-		}
-
-		if ($share === null && $this->shareProviderExists(IShare::TYPE_ROOM)) {
-			try {
-				$provider = $this->factory->getProviderForType(IShare::TYPE_ROOM);
-				$share = $provider->getShareByToken($token);
-			} catch (ProviderException $e) {
-			} catch (ShareNotFound $e) {
-			}
-		}
-
-		if ($share === null) {
-			throw new ShareNotFound($this->l->t('The requested share does not exist anymore'));
-		}
-
-		$this->checkShare($share);
-
-		/*
+        $shares2 = [];
+
+        while (true) {
+            $added = 0;
+            foreach ($shares as $share) {
+                if ($onlyValid) {
+                    try {
+                        $this->checkShare($share);
+                    } catch (ShareNotFound $e) {
+                        // Ignore since this basically means the share is deleted
+                        continue;
+                    }
+                }
+
+                $added++;
+                $shares2[] = $share;
+
+                if (count($shares2) === $limit) {
+                    break;
+                }
+            }
+
+            // If we did not fetch more shares than the limit then there are no more shares
+            if (count($shares) < $limit) {
+                break;
+            }
+
+            if (count($shares2) === $limit) {
+                break;
+            }
+
+            // If there was no limit on the select we are done
+            if ($limit === -1) {
+                break;
+            }
+
+            $offset += $added;
+
+            // Fetch again $limit shares
+            if ($path?->getMountPoint() instanceof IShareOwnerlessMount) {
+                // We already fetched all shares, so end here
+                $shares = [];
+            } else {
+                $shares = $provider->getSharesBy($userId, $shareType, $path, $reshares, $limit, $offset);
+            }
+
+            // No more shares means we are done
+            if (empty($shares)) {
+                break;
+            }
+        }
+
+        $shares = $shares2;
+
+        return $shares;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getSharedWith($userId, $shareType, $node = null, $limit = 50, $offset = 0) {
+        try {
+            $provider = $this->factory->getProviderForType($shareType);
+        } catch (ProviderException $e) {
+            return [];
+        }
+
+        $shares = $provider->getSharedWith($userId, $shareType, $node, $limit, $offset);
+
+        // remove all shares which are already expired
+        foreach ($shares as $key => $share) {
+            try {
+                $this->checkShare($share);
+            } catch (ShareNotFound $e) {
+                unset($shares[$key]);
+            }
+        }
+
+        return $shares;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getDeletedSharedWith($userId, $shareType, $node = null, $limit = 50, $offset = 0) {
+        $shares = $this->getSharedWith($userId, $shareType, $node, $limit, $offset);
+
+        // Only get deleted shares
+        $shares = array_filter($shares, function (IShare $share) {
+            return $share->getPermissions() === 0;
+        });
+
+        // Only get shares where the owner still exists
+        $shares = array_filter($shares, function (IShare $share) {
+            return $this->userManager->userExists($share->getShareOwner());
+        });
+
+        return $shares;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getShareById($id, $recipient = null, bool $onlyValid = true) {
+        if ($id === null) {
+            throw new ShareNotFound();
+        }
+
+        [$providerId, $id] = $this->splitFullId($id);
+
+        try {
+            $provider = $this->factory->getProvider($providerId);
+        } catch (ProviderException $e) {
+            throw new ShareNotFound();
+        }
+
+        $share = $provider->getShareById($id, $recipient);
+
+        if ($onlyValid) {
+            $this->checkShare($share);
+        }
+
+        return $share;
+    }
+
+    /**
+     * Get all the shares for a given path
+     *
+     * @param \OCP\Files\Node $path
+     * @param int $page
+     * @param int $perPage
+     *
+     * @return Share[]
+     */
+    public function getSharesByPath(\OCP\Files\Node $path, $page = 0, $perPage = 50) {
+        return [];
+    }
+
+    /**
+     * Get the share by token possible with password
+     *
+     * @param string $token
+     * @return IShare
+     *
+     * @throws ShareNotFound
+     */
+    public function getShareByToken($token) {
+        // tokens cannot be valid local user names
+        if ($this->userManager->userExists($token)) {
+            throw new ShareNotFound();
+        }
+        $share = null;
+        try {
+            if ($this->shareApiAllowLinks()) {
+                $provider = $this->factory->getProviderForType(IShare::TYPE_LINK);
+                $share = $provider->getShareByToken($token);
+            }
+        } catch (ProviderException $e) {
+        } catch (ShareNotFound $e) {
+        }
+
+
+        // If it is not a link share try to fetch a federated share by token
+        if ($share === null) {
+            try {
+                $provider = $this->factory->getProviderForType(IShare::TYPE_REMOTE);
+                $share = $provider->getShareByToken($token);
+            } catch (ProviderException $e) {
+            } catch (ShareNotFound $e) {
+            }
+        }
+
+        // If it is not a link share try to fetch a mail share by token
+        if ($share === null && $this->shareProviderExists(IShare::TYPE_EMAIL)) {
+            try {
+                $provider = $this->factory->getProviderForType(IShare::TYPE_EMAIL);
+                $share = $provider->getShareByToken($token);
+            } catch (ProviderException $e) {
+            } catch (ShareNotFound $e) {
+            }
+        }
+
+        if ($share === null && $this->shareProviderExists(IShare::TYPE_CIRCLE)) {
+            try {
+                $provider = $this->factory->getProviderForType(IShare::TYPE_CIRCLE);
+                $share = $provider->getShareByToken($token);
+            } catch (ProviderException $e) {
+            } catch (ShareNotFound $e) {
+            }
+        }
+
+        if ($share === null && $this->shareProviderExists(IShare::TYPE_ROOM)) {
+            try {
+                $provider = $this->factory->getProviderForType(IShare::TYPE_ROOM);
+                $share = $provider->getShareByToken($token);
+            } catch (ProviderException $e) {
+            } catch (ShareNotFound $e) {
+            }
+        }
+
+        if ($share === null) {
+            throw new ShareNotFound($this->l->t('The requested share does not exist anymore'));
+        }
+
+        $this->checkShare($share);
+
+        /*
 		 * Reduce the permissions for link or email shares if public upload is not enabled
 		 */
-		if (($share->getShareType() === IShare::TYPE_LINK || $share->getShareType() === IShare::TYPE_EMAIL)
-			&& $share->getNodeType() === 'folder' && !$this->shareApiLinkAllowPublicUpload()) {
-			$share->setPermissions($share->getPermissions() & ~(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE));
-		}
-
-		return $share;
-	}
-
-	/**
-	 * Check expire date and disabled owner
-	 *
-	 * @throws ShareNotFound
-	 */
-	protected function checkShare(IShare $share): void {
-		if ($share->isExpired()) {
-			$this->deleteShare($share);
-			throw new ShareNotFound($this->l->t('The requested share does not exist anymore'));
-		}
-		if ($this->config->getAppValue('files_sharing', 'hide_disabled_user_shares', 'no') === 'yes') {
-			$uids = array_unique([$share->getShareOwner(),$share->getSharedBy()]);
-			foreach ($uids as $uid) {
-				$user = $this->userManager->get($uid);
-				if ($user?->isEnabled() === false) {
-					throw new ShareNotFound($this->l->t('The requested share comes from a disabled user'));
-				}
-			}
-		}
-	}
-
-	/**
-	 * Verify the password of a public share
-	 *
-	 * @param IShare $share
-	 * @param ?string $password
-	 * @return bool
-	 */
-	public function checkPassword(IShare $share, $password) {
-
-		// if there is no password on the share object / passsword is null, there is nothing to check
-		if ($password === null || $share->getPassword() === null) {
-			return false;
-		}
-
-		// Makes sure password hasn't expired
-		$expirationTime = $share->getPasswordExpirationTime();
-		if ($expirationTime !== null && $expirationTime < new \DateTime()) {
-			return false;
-		}
-
-		$newHash = '';
-		if (!$this->hasher->verify($password, $share->getPassword(), $newHash)) {
-			return false;
-		}
-
-		if (!empty($newHash)) {
-			$share->setPassword($newHash);
-			$provider = $this->factory->getProviderForType($share->getShareType());
-			$provider->update($share);
-		}
-
-		return true;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function userDeleted($uid) {
-		$types = [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_LINK, IShare::TYPE_REMOTE, IShare::TYPE_EMAIL];
-
-		foreach ($types as $type) {
-			try {
-				$provider = $this->factory->getProviderForType($type);
-			} catch (ProviderException $e) {
-				continue;
-			}
-			$provider->userDeleted($uid, $type);
-		}
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function groupDeleted($gid) {
-		foreach ([IShare::TYPE_GROUP, IShare::TYPE_REMOTE_GROUP] as $type) {
-			try {
-				$provider = $this->factory->getProviderForType($type);
-			} catch (ProviderException $e) {
-				continue;
-			}
-			$provider->groupDeleted($gid);
-		}
-
-		$excludedGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups_list', '');
-		if ($excludedGroups === '') {
-			return;
-		}
-
-		$excludedGroups = json_decode($excludedGroups, true);
-		if (json_last_error() !== JSON_ERROR_NONE) {
-			return;
-		}
-
-		$excludedGroups = array_diff($excludedGroups, [$gid]);
-		$this->config->setAppValue('core', 'shareapi_exclude_groups_list', json_encode($excludedGroups));
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function userDeletedFromGroup($uid, $gid) {
-		foreach ([IShare::TYPE_GROUP, IShare::TYPE_REMOTE_GROUP] as $type) {
-			try {
-				$provider = $this->factory->getProviderForType($type);
-			} catch (ProviderException $e) {
-				continue;
-			}
-			$provider->userDeletedFromGroup($uid, $gid);
-		}
-	}
-
-	/**
-	 * Get access list to a path. This means
-	 * all the users that can access a given path.
-	 *
-	 * Consider:
-	 * -root
-	 * |-folder1 (23)
-	 *  |-folder2 (32)
-	 *   |-fileA (42)
-	 *
-	 * fileA is shared with user1 and user1@server1 and email1@maildomain1
-	 * folder2 is shared with group2 (user4 is a member of group2)
-	 * folder1 is shared with user2 (renamed to "folder (1)") and user2@server2
-	 *                        and email2@maildomain2
-	 *
-	 * Then the access list to '/folder1/folder2/fileA' with $currentAccess is:
-	 * [
-	 *  users  => [
-	 *      'user1' => ['node_id' => 42, 'node_path' => '/fileA'],
-	 *      'user4' => ['node_id' => 32, 'node_path' => '/folder2'],
-	 *      'user2' => ['node_id' => 23, 'node_path' => '/folder (1)'],
-	 *  ],
-	 *  remote => [
-	 *      'user1@server1' => ['node_id' => 42, 'token' => 'SeCr3t'],
-	 *      'user2@server2' => ['node_id' => 23, 'token' => 'FooBaR'],
-	 *  ],
-	 *  public => bool
-	 *  mail => [
-	 *      'email1@maildomain1' => ['node_id' => 42, 'token' => 'aBcDeFg'],
-	 *      'email2@maildomain2' => ['node_id' => 23, 'token' => 'hIjKlMn'],
-	 *  ]
-	 * ]
-	 *
-	 * The access list to '/folder1/folder2/fileA' **without** $currentAccess is:
-	 * [
-	 *  users  => ['user1', 'user2', 'user4'],
-	 *  remote => bool,
-	 *  public => bool
-	 *  mail => ['email1@maildomain1', 'email2@maildomain2']
-	 * ]
-	 *
-	 * This is required for encryption/activity
-	 *
-	 * @param \OCP\Files\Node $path
-	 * @param bool $recursive Should we check all parent folders as well
-	 * @param bool $currentAccess Ensure the recipient has access to the file (e.g. did not unshare it)
-	 * @return array
-	 */
-	public function getAccessList(\OCP\Files\Node $path, $recursive = true, $currentAccess = false) {
-		$owner = $path->getOwner();
-
-		if ($owner === null) {
-			return [];
-		}
-
-		$owner = $owner->getUID();
-
-		if ($currentAccess) {
-			$al = ['users' => [], 'remote' => [], 'public' => false, 'mail' => []];
-		} else {
-			$al = ['users' => [], 'remote' => false, 'public' => false, 'mail' => []];
-		}
-		if (!$this->userManager->userExists($owner)) {
-			return $al;
-		}
-
-		//Get node for the owner and correct the owner in case of external storage
-		$userFolder = $this->rootFolder->getUserFolder($owner);
-		if ($path->getId() !== $userFolder->getId() && !$userFolder->isSubNode($path)) {
-			$path = $userFolder->getFirstNodeById($path->getId());
-			if ($path === null || $path->getOwner() === null) {
-				return [];
-			}
-			$owner = $path->getOwner()->getUID();
-		}
-
-		$providers = $this->factory->getAllProviders();
-
-		/** @var Node[] $nodes */
-		$nodes = [];
-
-
-		if ($currentAccess) {
-			$ownerPath = $path->getPath();
-			$ownerPath = explode('/', $ownerPath, 4);
-			if (count($ownerPath) < 4) {
-				$ownerPath = '';
-			} else {
-				$ownerPath = $ownerPath[3];
-			}
-			$al['users'][$owner] = [
-				'node_id' => $path->getId(),
-				'node_path' => '/' . $ownerPath,
-			];
-		} else {
-			$al['users'][] = $owner;
-		}
-
-		// Collect all the shares
-		while ($path->getPath() !== $userFolder->getPath()) {
-			$nodes[] = $path;
-			if (!$recursive) {
-				break;
-			}
-			$path = $path->getParent();
-		}
-
-		foreach ($providers as $provider) {
-			$tmp = $provider->getAccessList($nodes, $currentAccess);
-
-			foreach ($tmp as $k => $v) {
-				if (isset($al[$k])) {
-					if (is_array($al[$k])) {
-						if ($currentAccess) {
-							$al[$k] += $v;
-						} else {
-							$al[$k] = array_merge($al[$k], $v);
-							$al[$k] = array_unique($al[$k]);
-							$al[$k] = array_values($al[$k]);
-						}
-					} else {
-						$al[$k] = $al[$k] || $v;
-					}
-				} else {
-					$al[$k] = $v;
-				}
-			}
-		}
-
-		return $al;
-	}
-
-	/**
-	 * Create a new share
-	 *
-	 * @return IShare
-	 */
-	public function newShare() {
-		return new \OC\Share20\Share($this->rootFolder, $this->userManager);
-	}
-
-	/**
-	 * Is the share API enabled
-	 *
-	 * @return bool
-	 */
-	public function shareApiEnabled() {
-		return $this->config->getAppValue('core', 'shareapi_enabled', 'yes') === 'yes';
-	}
-
-	/**
-	 * Is public link sharing enabled
-	 *
-	 * @return bool
-	 */
-	public function shareApiAllowLinks() {
-		if ($this->config->getAppValue('core', 'shareapi_allow_links', 'yes') !== 'yes') {
-			return false;
-		}
-
-		$user = $this->userSession->getUser();
-		if ($user) {
-			$excludedGroups = json_decode($this->config->getAppValue('core', 'shareapi_allow_links_exclude_groups', '[]'));
-			if ($excludedGroups) {
-				$userGroups = $this->groupManager->getUserGroupIds($user);
-				return !(bool)array_intersect($excludedGroups, $userGroups);
-			}
-		}
-
-		return true;
-	}
-
-	/**
-	 * Is password on public link requires
-	 *
-	 * @param bool Check group membership exclusion
-	 * @return bool
-	 */
-	public function shareApiLinkEnforcePassword(bool $checkGroupMembership = true) {
-		$excludedGroups = $this->config->getAppValue('core', 'shareapi_enforce_links_password_excluded_groups', '');
-		if ($excludedGroups !== '' && $checkGroupMembership) {
-			$excludedGroups = json_decode($excludedGroups);
-			$user = $this->userSession->getUser();
-			if ($user) {
-				$userGroups = $this->groupManager->getUserGroupIds($user);
-				if ((bool)array_intersect($excludedGroups, $userGroups)) {
-					return false;
-				}
-			}
-		}
-		return $this->config->getAppValue('core', 'shareapi_enforce_links_password', 'no') === 'yes';
-	}
-
-	/**
-	 * Is default link expire date enabled
-	 *
-	 * @return bool
-	 */
-	public function shareApiLinkDefaultExpireDate() {
-		return $this->config->getAppValue('core', 'shareapi_default_expire_date', 'no') === 'yes';
-	}
-
-	/**
-	 * Is default link expire date enforced
-	 *`
-	 *
-	 * @return bool
-	 */
-	public function shareApiLinkDefaultExpireDateEnforced() {
-		return $this->shareApiLinkDefaultExpireDate() &&
-			$this->config->getAppValue('core', 'shareapi_enforce_expire_date', 'no') === 'yes';
-	}
-
-
-	/**
-	 * Number of default link expire days
-	 *
-	 * @return int
-	 */
-	public function shareApiLinkDefaultExpireDays() {
-		return (int)$this->config->getAppValue('core', 'shareapi_expire_after_n_days', '7');
-	}
-
-	/**
-	 * Is default internal expire date enabled
-	 *
-	 * @return bool
-	 */
-	public function shareApiInternalDefaultExpireDate(): bool {
-		return $this->config->getAppValue('core', 'shareapi_default_internal_expire_date', 'no') === 'yes';
-	}
-
-	/**
-	 * Is default remote expire date enabled
-	 *
-	 * @return bool
-	 */
-	public function shareApiRemoteDefaultExpireDate(): bool {
-		return $this->config->getAppValue('core', 'shareapi_default_remote_expire_date', 'no') === 'yes';
-	}
-
-	/**
-	 * Is default expire date enforced
-	 *
-	 * @return bool
-	 */
-	public function shareApiInternalDefaultExpireDateEnforced(): bool {
-		return $this->shareApiInternalDefaultExpireDate() &&
-			$this->config->getAppValue('core', 'shareapi_enforce_internal_expire_date', 'no') === 'yes';
-	}
-
-	/**
-	 * Is default expire date enforced for remote shares
-	 *
-	 * @return bool
-	 */
-	public function shareApiRemoteDefaultExpireDateEnforced(): bool {
-		return $this->shareApiRemoteDefaultExpireDate() &&
-			$this->config->getAppValue('core', 'shareapi_enforce_remote_expire_date', 'no') === 'yes';
-	}
-
-	/**
-	 * Number of default expire days
-	 *
-	 * @return int
-	 */
-	public function shareApiInternalDefaultExpireDays(): int {
-		return (int)$this->config->getAppValue('core', 'shareapi_internal_expire_after_n_days', '7');
-	}
-
-	/**
-	 * Number of default expire days for remote shares
-	 *
-	 * @return int
-	 */
-	public function shareApiRemoteDefaultExpireDays(): int {
-		return (int)$this->config->getAppValue('core', 'shareapi_remote_expire_after_n_days', '7');
-	}
-
-	/**
-	 * Allow public upload on link shares
-	 *
-	 * @return bool
-	 */
-	public function shareApiLinkAllowPublicUpload() {
-		return $this->config->getAppValue('core', 'shareapi_allow_public_upload', 'yes') === 'yes';
-	}
-
-	/**
-	 * check if user can only share with group members
-	 *
-	 * @return bool
-	 */
-	public function shareWithGroupMembersOnly() {
-		return $this->config->getAppValue('core', 'shareapi_only_share_with_group_members', 'no') === 'yes';
-	}
-
-	/**
-	 * If shareWithGroupMembersOnly is enabled, return an optional
-	 * list of groups that must be excluded from the principle of
-	 * belonging to the same group.
-	 *
-	 * @return array
-	 */
-	public function shareWithGroupMembersOnlyExcludeGroupsList() {
-		if (!$this->shareWithGroupMembersOnly()) {
-			return [];
-		}
-		$excludeGroups = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members_exclude_group_list', '');
-		return json_decode($excludeGroups, true) ?? [];
-	}
-
-	/**
-	 * Check if users can share with groups
-	 *
-	 * @return bool
-	 */
-	public function allowGroupSharing() {
-		return $this->config->getAppValue('core', 'shareapi_allow_group_sharing', 'yes') === 'yes';
-	}
-
-	public function allowEnumeration(): bool {
-		return $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes';
-	}
-
-	public function limitEnumerationToGroups(): bool {
-		return $this->allowEnumeration() &&
-			$this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_group', 'no') === 'yes';
-	}
-
-	public function limitEnumerationToPhone(): bool {
-		return $this->allowEnumeration() &&
-			$this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_phone', 'no') === 'yes';
-	}
-
-	public function allowEnumerationFullMatch(): bool {
-		return $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match', 'yes') === 'yes';
-	}
-
-	public function matchEmail(): bool {
-		return $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match_email', 'yes') === 'yes';
-	}
-
-	public function ignoreSecondDisplayName(): bool {
-		return $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match_ignore_second_dn', 'no') === 'yes';
-	}
-
-	public function allowCustomTokens(): bool {
-		return $this->appConfig->getValueBool('core', 'shareapi_allow_custom_tokens', false);
-	}
-
-	public function allowViewWithoutDownload(): bool {
-		return $this->appConfig->getValueBool('core', 'shareapi_allow_view_without_download', true);
-	}
-
-	public function currentUserCanEnumerateTargetUser(?IUser $currentUser, IUser $targetUser): bool {
-		if ($this->allowEnumerationFullMatch()) {
-			return true;
-		}
-
-		if (!$this->allowEnumeration()) {
-			return false;
-		}
-
-		if (!$this->limitEnumerationToPhone() && !$this->limitEnumerationToGroups()) {
-			// Enumeration is enabled and not restricted: OK
-			return true;
-		}
-
-		if (!$currentUser instanceof IUser) {
-			// Enumeration restrictions require an account
-			return false;
-		}
-
-		// Enumeration is limited to phone match
-		if ($this->limitEnumerationToPhone() && $this->knownUserService->isKnownToUser($currentUser->getUID(), $targetUser->getUID())) {
-			return true;
-		}
-
-		// Enumeration is limited to groups
-		if ($this->limitEnumerationToGroups()) {
-			$currentUserGroupIds = $this->groupManager->getUserGroupIds($currentUser);
-			$targetUserGroupIds = $this->groupManager->getUserGroupIds($targetUser);
-			if (!empty(array_intersect($currentUserGroupIds, $targetUserGroupIds))) {
-				return true;
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Check if sharing is disabled for the current user
-	 */
-	public function sharingDisabledForUser(?string $userId): bool {
-		return $this->shareDisableChecker->sharingDisabledForUser($userId);
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function outgoingServer2ServerSharesAllowed() {
-		return $this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes') === 'yes';
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function outgoingServer2ServerGroupSharesAllowed() {
-		return $this->config->getAppValue('files_sharing', 'outgoing_server2server_group_share_enabled', 'no') === 'yes';
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function shareProviderExists($shareType) {
-		try {
-			$this->factory->getProviderForType($shareType);
-		} catch (ProviderException $e) {
-			return false;
-		}
-
-		return true;
-	}
-
-	public function registerShareProvider(string $shareProviderClass): void {
-		$this->factory->registerProvider($shareProviderClass);
-	}
-
-	public function getAllShares(): iterable {
-		$providers = $this->factory->getAllProviders();
-
-		foreach ($providers as $provider) {
-			yield from $provider->getAllShares();
-		}
-	}
-
-	public function generateToken(): string {
-		// Initial token length
-		$tokenLength = \OC\Share\Helper::getTokenLength();
-
-		do {
-			$tokenExists = false;
-
-			for ($i = 0; $i <= 2; $i++) {
-				// Generate a new token
-				$token = $this->secureRandom->generate(
-					$tokenLength,
-					ISecureRandom::CHAR_HUMAN_READABLE,
-				);
-
-				try {
-					// Try to fetch a share with the generated token
-					$this->getShareByToken($token);
-					$tokenExists = true; // Token exists, we need to try again
-				} catch (ShareNotFound $e) {
-					// Token is unique, exit the loop
-					$tokenExists = false;
-					break;
-				}
-			}
-
-			// If we've reached the maximum attempts and the token still exists, increase the token length
-			if ($tokenExists) {
-				$tokenLength++;
-
-				// Check if the token length exceeds the maximum allowed length
-				if ($tokenLength > \OC\Share\Constants::MAX_TOKEN_LENGTH) {
-					throw new ShareTokenException('Unable to generate a unique share token. Maximum token length exceeded.');
-				}
-			}
-		} while ($tokenExists);
-
-		return $token;
-	}
+        if (($share->getShareType() === IShare::TYPE_LINK || $share->getShareType() === IShare::TYPE_EMAIL)
+            && $share->getNodeType() === 'folder' && !$this->shareApiLinkAllowPublicUpload()) {
+            $share->setPermissions($share->getPermissions() & ~(\OCP\Constants::PERMISSION_CREATE | \OCP\Constants::PERMISSION_UPDATE));
+        }
+
+        return $share;
+    }
+
+    /**
+     * Check expire date and disabled owner
+     *
+     * @throws ShareNotFound
+     */
+    protected function checkShare(IShare $share): void {
+        if ($share->isExpired()) {
+            $this->deleteShare($share);
+            throw new ShareNotFound($this->l->t('The requested share does not exist anymore'));
+        }
+        if ($this->config->getAppValue('files_sharing', 'hide_disabled_user_shares', 'no') === 'yes') {
+            $uids = array_unique([$share->getShareOwner(),$share->getSharedBy()]);
+            foreach ($uids as $uid) {
+                $user = $this->userManager->get($uid);
+                if ($user?->isEnabled() === false) {
+                    throw new ShareNotFound($this->l->t('The requested share comes from a disabled user'));
+                }
+            }
+        }
+    }
+
+    /**
+     * Verify the password of a public share
+     *
+     * @param IShare $share
+     * @param ?string $password
+     * @return bool
+     */
+    public function checkPassword(IShare $share, $password) {
+
+        // if there is no password on the share object / passsword is null, there is nothing to check
+        if ($password === null || $share->getPassword() === null) {
+            return false;
+        }
+
+        // Makes sure password hasn't expired
+        $expirationTime = $share->getPasswordExpirationTime();
+        if ($expirationTime !== null && $expirationTime < new \DateTime()) {
+            return false;
+        }
+
+        $newHash = '';
+        if (!$this->hasher->verify($password, $share->getPassword(), $newHash)) {
+            return false;
+        }
+
+        if (!empty($newHash)) {
+            $share->setPassword($newHash);
+            $provider = $this->factory->getProviderForType($share->getShareType());
+            $provider->update($share);
+        }
+
+        return true;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function userDeleted($uid) {
+        $types = [IShare::TYPE_USER, IShare::TYPE_GROUP, IShare::TYPE_LINK, IShare::TYPE_REMOTE, IShare::TYPE_EMAIL];
+
+        foreach ($types as $type) {
+            try {
+                $provider = $this->factory->getProviderForType($type);
+            } catch (ProviderException $e) {
+                continue;
+            }
+            $provider->userDeleted($uid, $type);
+        }
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function groupDeleted($gid) {
+        foreach ([IShare::TYPE_GROUP, IShare::TYPE_REMOTE_GROUP] as $type) {
+            try {
+                $provider = $this->factory->getProviderForType($type);
+            } catch (ProviderException $e) {
+                continue;
+            }
+            $provider->groupDeleted($gid);
+        }
+
+        $excludedGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups_list', '');
+        if ($excludedGroups === '') {
+            return;
+        }
+
+        $excludedGroups = json_decode($excludedGroups, true);
+        if (json_last_error() !== JSON_ERROR_NONE) {
+            return;
+        }
+
+        $excludedGroups = array_diff($excludedGroups, [$gid]);
+        $this->config->setAppValue('core', 'shareapi_exclude_groups_list', json_encode($excludedGroups));
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function userDeletedFromGroup($uid, $gid) {
+        foreach ([IShare::TYPE_GROUP, IShare::TYPE_REMOTE_GROUP] as $type) {
+            try {
+                $provider = $this->factory->getProviderForType($type);
+            } catch (ProviderException $e) {
+                continue;
+            }
+            $provider->userDeletedFromGroup($uid, $gid);
+        }
+    }
+
+    /**
+     * Get access list to a path. This means
+     * all the users that can access a given path.
+     *
+     * Consider:
+     * -root
+     * |-folder1 (23)
+     *  |-folder2 (32)
+     *   |-fileA (42)
+     *
+     * fileA is shared with user1 and user1@server1 and email1@maildomain1
+     * folder2 is shared with group2 (user4 is a member of group2)
+     * folder1 is shared with user2 (renamed to "folder (1)") and user2@server2
+     *                        and email2@maildomain2
+     *
+     * Then the access list to '/folder1/folder2/fileA' with $currentAccess is:
+     * [
+     *  users  => [
+     *      'user1' => ['node_id' => 42, 'node_path' => '/fileA'],
+     *      'user4' => ['node_id' => 32, 'node_path' => '/folder2'],
+     *      'user2' => ['node_id' => 23, 'node_path' => '/folder (1)'],
+     *  ],
+     *  remote => [
+     *      'user1@server1' => ['node_id' => 42, 'token' => 'SeCr3t'],
+     *      'user2@server2' => ['node_id' => 23, 'token' => 'FooBaR'],
+     *  ],
+     *  public => bool
+     *  mail => [
+     *      'email1@maildomain1' => ['node_id' => 42, 'token' => 'aBcDeFg'],
+     *      'email2@maildomain2' => ['node_id' => 23, 'token' => 'hIjKlMn'],
+     *  ]
+     * ]
+     *
+     * The access list to '/folder1/folder2/fileA' **without** $currentAccess is:
+     * [
+     *  users  => ['user1', 'user2', 'user4'],
+     *  remote => bool,
+     *  public => bool
+     *  mail => ['email1@maildomain1', 'email2@maildomain2']
+     * ]
+     *
+     * This is required for encryption/activity
+     *
+     * @param \OCP\Files\Node $path
+     * @param bool $recursive Should we check all parent folders as well
+     * @param bool $currentAccess Ensure the recipient has access to the file (e.g. did not unshare it)
+     * @return array
+     */
+    public function getAccessList(\OCP\Files\Node $path, $recursive = true, $currentAccess = false) {
+        $owner = $path->getOwner();
+
+        if ($owner === null) {
+            return [];
+        }
+
+        $owner = $owner->getUID();
+
+        if ($currentAccess) {
+            $al = ['users' => [], 'remote' => [], 'public' => false, 'mail' => []];
+        } else {
+            $al = ['users' => [], 'remote' => false, 'public' => false, 'mail' => []];
+        }
+        if (!$this->userManager->userExists($owner)) {
+            return $al;
+        }
+
+        //Get node for the owner and correct the owner in case of external storage
+        $userFolder = $this->rootFolder->getUserFolder($owner);
+        if ($path->getId() !== $userFolder->getId() && !$userFolder->isSubNode($path)) {
+            $path = $userFolder->getFirstNodeById($path->getId());
+            if ($path === null || $path->getOwner() === null) {
+                return [];
+            }
+            $owner = $path->getOwner()->getUID();
+        }
+
+        $providers = $this->factory->getAllProviders();
+
+        /** @var Node[] $nodes */
+        $nodes = [];
+
+
+        if ($currentAccess) {
+            $ownerPath = $path->getPath();
+            $ownerPath = explode('/', $ownerPath, 4);
+            if (count($ownerPath) < 4) {
+                $ownerPath = '';
+            } else {
+                $ownerPath = $ownerPath[3];
+            }
+            $al['users'][$owner] = [
+                'node_id' => $path->getId(),
+                'node_path' => '/' . $ownerPath,
+            ];
+        } else {
+            $al['users'][] = $owner;
+        }
+
+        // Collect all the shares
+        while ($path->getPath() !== $userFolder->getPath()) {
+            $nodes[] = $path;
+            if (!$recursive) {
+                break;
+            }
+            $path = $path->getParent();
+        }
+
+        foreach ($providers as $provider) {
+            $tmp = $provider->getAccessList($nodes, $currentAccess);
+
+            foreach ($tmp as $k => $v) {
+                if (isset($al[$k])) {
+                    if (is_array($al[$k])) {
+                        if ($currentAccess) {
+                            $al[$k] += $v;
+                        } else {
+                            $al[$k] = array_merge($al[$k], $v);
+                            $al[$k] = array_unique($al[$k]);
+                            $al[$k] = array_values($al[$k]);
+                        }
+                    } else {
+                        $al[$k] = $al[$k] || $v;
+                    }
+                } else {
+                    $al[$k] = $v;
+                }
+            }
+        }
+
+        return $al;
+    }
+
+    /**
+     * Create a new share
+     *
+     * @return IShare
+     */
+    public function newShare() {
+        return new \OC\Share20\Share($this->rootFolder, $this->userManager);
+    }
+
+    /**
+     * Is the share API enabled
+     *
+     * @return bool
+     */
+    public function shareApiEnabled() {
+        return $this->config->getAppValue('core', 'shareapi_enabled', 'yes') === 'yes';
+    }
+
+    /**
+     * Is public link sharing enabled
+     *
+     * @return bool
+     */
+    public function shareApiAllowLinks() {
+        if ($this->config->getAppValue('core', 'shareapi_allow_links', 'yes') !== 'yes') {
+            return false;
+        }
+
+        $user = $this->userSession->getUser();
+        if ($user) {
+            $excludedGroups = json_decode($this->config->getAppValue('core', 'shareapi_allow_links_exclude_groups', '[]'));
+            if ($excludedGroups) {
+                $userGroups = $this->groupManager->getUserGroupIds($user);
+                return !(bool)array_intersect($excludedGroups, $userGroups);
+            }
+        }
+
+        return true;
+    }
+
+    /**
+     * Is password on public link requires
+     *
+     * @param bool Check group membership exclusion
+     * @return bool
+     */
+    public function shareApiLinkEnforcePassword(bool $checkGroupMembership = true) {
+        $excludedGroups = $this->config->getAppValue('core', 'shareapi_enforce_links_password_excluded_groups', '');
+        if ($excludedGroups !== '' && $checkGroupMembership) {
+            $excludedGroups = json_decode($excludedGroups);
+            $user = $this->userSession->getUser();
+            if ($user) {
+                $userGroups = $this->groupManager->getUserGroupIds($user);
+                if ((bool)array_intersect($excludedGroups, $userGroups)) {
+                    return false;
+                }
+            }
+        }
+        return $this->config->getAppValue('core', 'shareapi_enforce_links_password', 'no') === 'yes';
+    }
+
+    /**
+     * Is default link expire date enabled
+     *
+     * @return bool
+     */
+    public function shareApiLinkDefaultExpireDate() {
+        return $this->config->getAppValue('core', 'shareapi_default_expire_date', 'no') === 'yes';
+    }
+
+    /**
+     * Is default link expire date enforced
+     *`
+     *
+     * @return bool
+     */
+    public function shareApiLinkDefaultExpireDateEnforced() {
+        return $this->shareApiLinkDefaultExpireDate() &&
+            $this->config->getAppValue('core', 'shareapi_enforce_expire_date', 'no') === 'yes';
+    }
+
+
+    /**
+     * Number of default link expire days
+     *
+     * @return int
+     */
+    public function shareApiLinkDefaultExpireDays() {
+        return (int)$this->config->getAppValue('core', 'shareapi_expire_after_n_days', '7');
+    }
+
+    /**
+     * Is default internal expire date enabled
+     *
+     * @return bool
+     */
+    public function shareApiInternalDefaultExpireDate(): bool {
+        return $this->config->getAppValue('core', 'shareapi_default_internal_expire_date', 'no') === 'yes';
+    }
+
+    /**
+     * Is default remote expire date enabled
+     *
+     * @return bool
+     */
+    public function shareApiRemoteDefaultExpireDate(): bool {
+        return $this->config->getAppValue('core', 'shareapi_default_remote_expire_date', 'no') === 'yes';
+    }
+
+    /**
+     * Is default expire date enforced
+     *
+     * @return bool
+     */
+    public function shareApiInternalDefaultExpireDateEnforced(): bool {
+        return $this->shareApiInternalDefaultExpireDate() &&
+            $this->config->getAppValue('core', 'shareapi_enforce_internal_expire_date', 'no') === 'yes';
+    }
+
+    /**
+     * Is default expire date enforced for remote shares
+     *
+     * @return bool
+     */
+    public function shareApiRemoteDefaultExpireDateEnforced(): bool {
+        return $this->shareApiRemoteDefaultExpireDate() &&
+            $this->config->getAppValue('core', 'shareapi_enforce_remote_expire_date', 'no') === 'yes';
+    }
+
+    /**
+     * Number of default expire days
+     *
+     * @return int
+     */
+    public function shareApiInternalDefaultExpireDays(): int {
+        return (int)$this->config->getAppValue('core', 'shareapi_internal_expire_after_n_days', '7');
+    }
+
+    /**
+     * Number of default expire days for remote shares
+     *
+     * @return int
+     */
+    public function shareApiRemoteDefaultExpireDays(): int {
+        return (int)$this->config->getAppValue('core', 'shareapi_remote_expire_after_n_days', '7');
+    }
+
+    /**
+     * Allow public upload on link shares
+     *
+     * @return bool
+     */
+    public function shareApiLinkAllowPublicUpload() {
+        return $this->config->getAppValue('core', 'shareapi_allow_public_upload', 'yes') === 'yes';
+    }
+
+    /**
+     * check if user can only share with group members
+     *
+     * @return bool
+     */
+    public function shareWithGroupMembersOnly() {
+        return $this->config->getAppValue('core', 'shareapi_only_share_with_group_members', 'no') === 'yes';
+    }
+
+    /**
+     * If shareWithGroupMembersOnly is enabled, return an optional
+     * list of groups that must be excluded from the principle of
+     * belonging to the same group.
+     *
+     * @return array
+     */
+    public function shareWithGroupMembersOnlyExcludeGroupsList() {
+        if (!$this->shareWithGroupMembersOnly()) {
+            return [];
+        }
+        $excludeGroups = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members_exclude_group_list', '');
+        return json_decode($excludeGroups, true) ?? [];
+    }
+
+    /**
+     * Check if users can share with groups
+     *
+     * @return bool
+     */
+    public function allowGroupSharing() {
+        return $this->config->getAppValue('core', 'shareapi_allow_group_sharing', 'yes') === 'yes';
+    }
+
+    public function allowEnumeration(): bool {
+        return $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes';
+    }
+
+    public function limitEnumerationToGroups(): bool {
+        return $this->allowEnumeration() &&
+            $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_group', 'no') === 'yes';
+    }
+
+    public function limitEnumerationToPhone(): bool {
+        return $this->allowEnumeration() &&
+            $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_phone', 'no') === 'yes';
+    }
+
+    public function allowEnumerationFullMatch(): bool {
+        return $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match', 'yes') === 'yes';
+    }
+
+    public function matchEmail(): bool {
+        return $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match_email', 'yes') === 'yes';
+    }
+
+    public function ignoreSecondDisplayName(): bool {
+        return $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match_ignore_second_dn', 'no') === 'yes';
+    }
+
+    public function allowCustomTokens(): bool {
+        return $this->appConfig->getValueBool('core', 'shareapi_allow_custom_tokens', false);
+    }
+
+    public function allowViewWithoutDownload(): bool {
+        return $this->appConfig->getValueBool('core', 'shareapi_allow_view_without_download', true);
+    }
+
+    public function currentUserCanEnumerateTargetUser(?IUser $currentUser, IUser $targetUser): bool {
+        if ($this->allowEnumerationFullMatch()) {
+            return true;
+        }
+
+        if (!$this->allowEnumeration()) {
+            return false;
+        }
+
+        if (!$this->limitEnumerationToPhone() && !$this->limitEnumerationToGroups()) {
+            // Enumeration is enabled and not restricted: OK
+            return true;
+        }
+
+        if (!$currentUser instanceof IUser) {
+            // Enumeration restrictions require an account
+            return false;
+        }
+
+        // Enumeration is limited to phone match
+        if ($this->limitEnumerationToPhone() && $this->knownUserService->isKnownToUser($currentUser->getUID(), $targetUser->getUID())) {
+            return true;
+        }
+
+        // Enumeration is limited to groups
+        if ($this->limitEnumerationToGroups()) {
+            $currentUserGroupIds = $this->groupManager->getUserGroupIds($currentUser);
+            $targetUserGroupIds = $this->groupManager->getUserGroupIds($targetUser);
+            if (!empty(array_intersect($currentUserGroupIds, $targetUserGroupIds))) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Check if sharing is disabled for the current user
+     */
+    public function sharingDisabledForUser(?string $userId): bool {
+        return $this->shareDisableChecker->sharingDisabledForUser($userId);
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function outgoingServer2ServerSharesAllowed() {
+        return $this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes') === 'yes';
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function outgoingServer2ServerGroupSharesAllowed() {
+        return $this->config->getAppValue('files_sharing', 'outgoing_server2server_group_share_enabled', 'no') === 'yes';
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function shareProviderExists($shareType) {
+        try {
+            $this->factory->getProviderForType($shareType);
+        } catch (ProviderException $e) {
+            return false;
+        }
+
+        return true;
+    }
+
+    public function registerShareProvider(string $shareProviderClass): void {
+        $this->factory->registerProvider($shareProviderClass);
+    }
+
+    public function getAllShares(): iterable {
+        $providers = $this->factory->getAllProviders();
+
+        foreach ($providers as $provider) {
+            yield from $provider->getAllShares();
+        }
+    }
+
+    public function generateToken(): string {
+        // Initial token length
+        $tokenLength = \OC\Share\Helper::getTokenLength();
+
+        do {
+            $tokenExists = false;
+
+            for ($i = 0; $i <= 2; $i++) {
+                // Generate a new token
+                $token = $this->secureRandom->generate(
+                    $tokenLength,
+                    ISecureRandom::CHAR_HUMAN_READABLE,
+                );
+
+                try {
+                    // Try to fetch a share with the generated token
+                    $this->getShareByToken($token);
+                    $tokenExists = true; // Token exists, we need to try again
+                } catch (ShareNotFound $e) {
+                    // Token is unique, exit the loop
+                    $tokenExists = false;
+                    break;
+                }
+            }
+
+            // If we've reached the maximum attempts and the token still exists, increase the token length
+            if ($tokenExists) {
+                $tokenLength++;
+
+                // Check if the token length exceeds the maximum allowed length
+                if ($tokenLength > \OC\Share\Constants::MAX_TOKEN_LENGTH) {
+                    throw new ShareTokenException('Unable to generate a unique share token. Maximum token length exceeded.');
+                }
+            }
+        } while ($tokenExists);
+
+        return $token;
+    }
 }

apps/settings/lib/Settings/Admin/Sharing.php

Indentation +91 added lines, -91 removed lines

@@ -17,104 +17,104 @@
 use OCP\Util;
 
 class Sharing implements IDelegatedSettings {
-	public function __construct(
-		private IConfig $config,
-		private IL10N $l,
-		private IManager $shareManager,
-		private IAppManager $appManager,
-		private IURLGenerator $urlGenerator,
-		private IInitialState $initialState,
-		private string $appName,
-	) {
-	}
+    public function __construct(
+        private IConfig $config,
+        private IL10N $l,
+        private IManager $shareManager,
+        private IAppManager $appManager,
+        private IURLGenerator $urlGenerator,
+        private IInitialState $initialState,
+        private string $appName,
+    ) {
+    }
 
-	/**
-	 * @return TemplateResponse
-	 */
-	public function getForm() {
-		$excludedGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups_list', '');
-		$linksExcludedGroups = $this->config->getAppValue('core', 'shareapi_allow_links_exclude_groups', '');
-		$excludedPasswordGroups = $this->config->getAppValue('core', 'shareapi_enforce_links_password_excluded_groups', '');
-		$onlyShareWithGroupMembersExcludeGroupList = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members_exclude_group_list', '');
+    /**
+     * @return TemplateResponse
+     */
+    public function getForm() {
+        $excludedGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups_list', '');
+        $linksExcludedGroups = $this->config->getAppValue('core', 'shareapi_allow_links_exclude_groups', '');
+        $excludedPasswordGroups = $this->config->getAppValue('core', 'shareapi_enforce_links_password_excluded_groups', '');
+        $onlyShareWithGroupMembersExcludeGroupList = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members_exclude_group_list', '');
 
-		$parameters = [
-			// Built-In Sharing
-			'enabled' => $this->getHumanBooleanConfig('core', 'shareapi_enabled', true),
-			'allowGroupSharing' => $this->getHumanBooleanConfig('core', 'shareapi_allow_group_sharing', true),
-			'allowLinks' => $this->getHumanBooleanConfig('core', 'shareapi_allow_links', true),
-			'allowLinksExcludeGroups' => json_decode($linksExcludedGroups, true) ?? [],
-			'allowPublicUpload' => $this->getHumanBooleanConfig('core', 'shareapi_allow_public_upload', true),
-			'allowResharing' => $this->getHumanBooleanConfig('core', 'shareapi_allow_resharing', true),
-			'allowShareDialogUserEnumeration' => $this->getHumanBooleanConfig('core', 'shareapi_allow_share_dialog_user_enumeration', true),
-			'restrictUserEnumerationToGroup' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_to_group'),
-			'restrictUserEnumerationToPhone' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_to_phone'),
-			'restrictUserEnumerationFullMatch' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_full_match', true),
-			'restrictUserEnumerationFullMatchUserId' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_full_match_userid', true),
-			'restrictUserEnumerationFullMatchEmail' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_full_match_email', true),
-			'restrictUserEnumerationFullMatchIgnoreSecondDN' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_full_match_ignore_second_dn'),
-			'enforceLinksPassword' => Util::isPublicLinkPasswordRequired(false),
-			'enforceLinksPasswordExcludedGroups' => json_decode($excludedPasswordGroups) ?? [],
-			'enforceLinksPasswordExcludedGroupsEnabled' => $this->config->getSystemValueBool('sharing.allow_disabled_password_enforcement_groups', false),
-			'onlyShareWithGroupMembers' => $this->shareManager->shareWithGroupMembersOnly(),
-			'onlyShareWithGroupMembersExcludeGroupList' => json_decode($onlyShareWithGroupMembersExcludeGroupList) ?? [],
-			'defaultExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_default_expire_date'),
-			'expireAfterNDays' => $this->config->getAppValue('core', 'shareapi_expire_after_n_days', '7'),
-			'enforceExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_enforce_expire_date'),
-			'excludeGroups' => $this->config->getAppValue('core', 'shareapi_exclude_groups', 'no'),
-			'excludeGroupsList' => json_decode($excludedGroups, true) ?? [],
-			'publicShareDisclaimerText' => $this->config->getAppValue('core', 'shareapi_public_link_disclaimertext'),
-			'enableLinkPasswordByDefault' => $this->getHumanBooleanConfig('core', 'shareapi_enable_link_password_by_default'),
-			'defaultPermissions' => (int)$this->config->getAppValue('core', 'shareapi_default_permissions', (string)Constants::PERMISSION_ALL),
-			'defaultInternalExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_default_internal_expire_date'),
-			'internalExpireAfterNDays' => $this->config->getAppValue('core', 'shareapi_internal_expire_after_n_days', '7'),
-			'enforceInternalExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_enforce_internal_expire_date'),
-			'defaultRemoteExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_default_remote_expire_date'),
-			'remoteExpireAfterNDays' => $this->config->getAppValue('core', 'shareapi_remote_expire_after_n_days', '7'),
-			'enforceRemoteExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_enforce_remote_expire_date'),
-			'allowCustomTokens' => $this->shareManager->allowCustomTokens(),
-			'allowViewWithoutDownload' => $this->shareManager->allowViewWithoutDownload(),
-		];
+        $parameters = [
+            // Built-In Sharing
+            'enabled' => $this->getHumanBooleanConfig('core', 'shareapi_enabled', true),
+            'allowGroupSharing' => $this->getHumanBooleanConfig('core', 'shareapi_allow_group_sharing', true),
+            'allowLinks' => $this->getHumanBooleanConfig('core', 'shareapi_allow_links', true),
+            'allowLinksExcludeGroups' => json_decode($linksExcludedGroups, true) ?? [],
+            'allowPublicUpload' => $this->getHumanBooleanConfig('core', 'shareapi_allow_public_upload', true),
+            'allowResharing' => $this->getHumanBooleanConfig('core', 'shareapi_allow_resharing', true),
+            'allowShareDialogUserEnumeration' => $this->getHumanBooleanConfig('core', 'shareapi_allow_share_dialog_user_enumeration', true),
+            'restrictUserEnumerationToGroup' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_to_group'),
+            'restrictUserEnumerationToPhone' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_to_phone'),
+            'restrictUserEnumerationFullMatch' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_full_match', true),
+            'restrictUserEnumerationFullMatchUserId' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_full_match_userid', true),
+            'restrictUserEnumerationFullMatchEmail' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_full_match_email', true),
+            'restrictUserEnumerationFullMatchIgnoreSecondDN' => $this->getHumanBooleanConfig('core', 'shareapi_restrict_user_enumeration_full_match_ignore_second_dn'),
+            'enforceLinksPassword' => Util::isPublicLinkPasswordRequired(false),
+            'enforceLinksPasswordExcludedGroups' => json_decode($excludedPasswordGroups) ?? [],
+            'enforceLinksPasswordExcludedGroupsEnabled' => $this->config->getSystemValueBool('sharing.allow_disabled_password_enforcement_groups', false),
+            'onlyShareWithGroupMembers' => $this->shareManager->shareWithGroupMembersOnly(),
+            'onlyShareWithGroupMembersExcludeGroupList' => json_decode($onlyShareWithGroupMembersExcludeGroupList) ?? [],
+            'defaultExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_default_expire_date'),
+            'expireAfterNDays' => $this->config->getAppValue('core', 'shareapi_expire_after_n_days', '7'),
+            'enforceExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_enforce_expire_date'),
+            'excludeGroups' => $this->config->getAppValue('core', 'shareapi_exclude_groups', 'no'),
+            'excludeGroupsList' => json_decode($excludedGroups, true) ?? [],
+            'publicShareDisclaimerText' => $this->config->getAppValue('core', 'shareapi_public_link_disclaimertext'),
+            'enableLinkPasswordByDefault' => $this->getHumanBooleanConfig('core', 'shareapi_enable_link_password_by_default'),
+            'defaultPermissions' => (int)$this->config->getAppValue('core', 'shareapi_default_permissions', (string)Constants::PERMISSION_ALL),
+            'defaultInternalExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_default_internal_expire_date'),
+            'internalExpireAfterNDays' => $this->config->getAppValue('core', 'shareapi_internal_expire_after_n_days', '7'),
+            'enforceInternalExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_enforce_internal_expire_date'),
+            'defaultRemoteExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_default_remote_expire_date'),
+            'remoteExpireAfterNDays' => $this->config->getAppValue('core', 'shareapi_remote_expire_after_n_days', '7'),
+            'enforceRemoteExpireDate' => $this->getHumanBooleanConfig('core', 'shareapi_enforce_remote_expire_date'),
+            'allowCustomTokens' => $this->shareManager->allowCustomTokens(),
+            'allowViewWithoutDownload' => $this->shareManager->allowViewWithoutDownload(),
+        ];
 
-		$this->initialState->provideInitialState('sharingAppEnabled', $this->appManager->isEnabledForUser('files_sharing'));
-		$this->initialState->provideInitialState('sharingDocumentation', $this->urlGenerator->linkToDocs('admin-sharing'));
-		$this->initialState->provideInitialState('sharingSettings', $parameters);
+        $this->initialState->provideInitialState('sharingAppEnabled', $this->appManager->isEnabledForUser('files_sharing'));
+        $this->initialState->provideInitialState('sharingDocumentation', $this->urlGenerator->linkToDocs('admin-sharing'));
+        $this->initialState->provideInitialState('sharingSettings', $parameters);
 
-		Util::addScript($this->appName, 'vue-settings-admin-sharing');
-		return new TemplateResponse($this->appName, 'settings/admin/sharing', [], '');
-	}
+        Util::addScript($this->appName, 'vue-settings-admin-sharing');
+        return new TemplateResponse($this->appName, 'settings/admin/sharing', [], '');
+    }
 
-	/**
-	 * Helper function to retrive boolean values from human readable strings ('yes' / 'no')
-	 */
-	private function getHumanBooleanConfig(string $app, string $key, bool $default = false): bool {
-		return $this->config->getAppValue($app, $key, $default ? 'yes' : 'no') === 'yes';
-	}
+    /**
+     * Helper function to retrive boolean values from human readable strings ('yes' / 'no')
+     */
+    private function getHumanBooleanConfig(string $app, string $key, bool $default = false): bool {
+        return $this->config->getAppValue($app, $key, $default ? 'yes' : 'no') === 'yes';
+    }
 
-	/**
-	 * @return string the section ID, e.g. 'sharing'
-	 */
-	public function getSection() {
-		return 'sharing';
-	}
+    /**
+     * @return string the section ID, e.g. 'sharing'
+     */
+    public function getSection() {
+        return 'sharing';
+    }
 
-	/**
-	 * @return int whether the form should be rather on the top or bottom of
-	 *             the admin section. The forms are arranged in ascending order of the
-	 *             priority values. It is required to return a value between 0 and 100.
-	 *
-	 * E.g.: 70
-	 */
-	public function getPriority() {
-		return 0;
-	}
+    /**
+     * @return int whether the form should be rather on the top or bottom of
+     *             the admin section. The forms are arranged in ascending order of the
+     *             priority values. It is required to return a value between 0 and 100.
+     *
+     * E.g.: 70
+     */
+    public function getPriority() {
+        return 0;
+    }
 
-	public function getAuthorizedAppConfig(): array {
-		return [
-			'core' => ['/shareapi_.*/'],
-		];
-	}
+    public function getAuthorizedAppConfig(): array {
+        return [
+            'core' => ['/shareapi_.*/'],
+        ];
+    }
 
-	public function getName(): ?string {
-		return null;
-	}
+    public function getName(): ?string {
+        return null;
+    }
 }

apps/files/lib/Controller/ApiController.php

Indentation +406 added lines, -406 removed lines

@@ -53,410 +53,410 @@
  * @package OCA\Files\Controller
  */
 class ApiController extends Controller {
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		private IUserSession $userSession,
-		private TagService $tagService,
-		private IPreview $previewManager,
-		private IManager $shareManager,
-		private IConfig $config,
-		private ?Folder $userFolder,
-		private UserConfig $userConfig,
-		private ViewConfig $viewConfig,
-		private IL10N $l10n,
-		private IRootFolder $rootFolder,
-		private LoggerInterface $logger,
-	) {
-		parent::__construct($appName, $request);
-	}
-
-	/**
-	 * Gets a thumbnail of the specified file
-	 *
-	 * @since API version 1.0
-	 * @deprecated 32.0.0 Use the preview endpoint provided by core instead
-	 *
-	 * @param int $x Width of the thumbnail
-	 * @param int $y Height of the thumbnail
-	 * @param string $file URL-encoded filename
-	 * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND, array{message?: string}, array{}>
-	 *
-	 * 200: Thumbnail returned
-	 * 400: Getting thumbnail is not possible
-	 * 404: File not found
-	 */
-	#[NoAdminRequired]
-	#[NoCSRFRequired]
-	#[StrictCookiesRequired]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getThumbnail($x, $y, $file) {
-		if ($x < 1 || $y < 1) {
-			return new DataResponse(['message' => 'Requested size must be numeric and a positive value.'], Http::STATUS_BAD_REQUEST);
-		}
-
-		try {
-			$file = $this->userFolder?->get($file);
-			if ($file === null
-				|| !($file instanceof File)
-				|| ($file->getId() <= 0)
-			) {
-				throw new NotFoundException();
-			}
-
-			// Validate the user is allowed to download the file (preview is some kind of download)
-			/** @var ISharedStorage $storage */
-			$storage = $file->getStorage();
-			if ($storage->instanceOfStorage(ISharedStorage::class)) {
-				/** @var IShare $share */
-				$share = $storage->getShare();
-				if (!$share->canSeeContent()) {
-					throw new NotFoundException();
-				}
-			}
-
-			$preview = $this->previewManager->getPreview($file, $x, $y, true);
-
-			return new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => $preview->getMimeType()]);
-		} catch (NotFoundException|NotPermittedException|InvalidPathException) {
-			return new DataResponse(['message' => 'File not found.'], Http::STATUS_NOT_FOUND);
-		} catch (\Exception $e) {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
-	}
-
-	/**
-	 * Updates the info of the specified file path
-	 * The passed tags are absolute, which means they will
-	 * replace the actual tag selection.
-	 *
-	 * @param string $path path
-	 * @param array|string $tags array of tags
-	 * @return DataResponse
-	 */
-	#[NoAdminRequired]
-	public function updateFileTags($path, $tags = null) {
-		$result = [];
-		// if tags specified or empty array, update tags
-		if (!is_null($tags)) {
-			try {
-				$this->tagService->updateFileTags($path, $tags);
-			} catch (NotFoundException $e) {
-				return new DataResponse([
-					'message' => $e->getMessage()
-				], Http::STATUS_NOT_FOUND);
-			} catch (StorageNotAvailableException $e) {
-				return new DataResponse([
-					'message' => $e->getMessage()
-				], Http::STATUS_SERVICE_UNAVAILABLE);
-			} catch (\Exception $e) {
-				return new DataResponse([
-					'message' => $e->getMessage()
-				], Http::STATUS_NOT_FOUND);
-			}
-			$result['tags'] = $tags;
-		}
-		return new DataResponse($result);
-	}
-
-	/**
-	 * @param \OCP\Files\Node[] $nodes
-	 * @return array
-	 */
-	private function formatNodes(array $nodes) {
-		$shareTypesForNodes = $this->getShareTypesForNodes($nodes);
-		return array_values(array_map(function (Node $node) use ($shareTypesForNodes) {
-			$shareTypes = $shareTypesForNodes[$node->getId()] ?? [];
-			$file = Helper::formatFileInfo($node->getFileInfo());
-			$file['hasPreview'] = $this->previewManager->isAvailable($node);
-			$parts = explode('/', dirname($node->getPath()), 4);
-			if (isset($parts[3])) {
-				$file['path'] = '/' . $parts[3];
-			} else {
-				$file['path'] = '/';
-			}
-			if (!empty($shareTypes)) {
-				$file['shareTypes'] = $shareTypes;
-			}
-			return $file;
-		}, $nodes));
-	}
-
-	/**
-	 * Get the share types for each node
-	 *
-	 * @param \OCP\Files\Node[] $nodes
-	 * @return array<int, int[]> list of share types for each fileid
-	 */
-	private function getShareTypesForNodes(array $nodes): array {
-		$userId = $this->userSession->getUser()->getUID();
-		$requestedShareTypes = [
-			IShare::TYPE_USER,
-			IShare::TYPE_GROUP,
-			IShare::TYPE_LINK,
-			IShare::TYPE_REMOTE,
-			IShare::TYPE_EMAIL,
-			IShare::TYPE_ROOM,
-			IShare::TYPE_DECK,
-			IShare::TYPE_SCIENCEMESH,
-		];
-		$shareTypes = [];
-
-		$nodeIds = array_map(function (Node $node) {
-			return $node->getId();
-		}, $nodes);
-
-		foreach ($requestedShareTypes as $shareType) {
-			$nodesLeft = array_combine($nodeIds, array_fill(0, count($nodeIds), true));
-			$offset = 0;
-
-			// fetch shares until we've either found shares for all nodes or there are no more shares left
-			while (count($nodesLeft) > 0) {
-				$shares = $this->shareManager->getSharesBy($userId, $shareType, null, false, 100, $offset);
-				foreach ($shares as $share) {
-					$fileId = $share->getNodeId();
-					if (isset($nodesLeft[$fileId])) {
-						if (!isset($shareTypes[$fileId])) {
-							$shareTypes[$fileId] = [];
-						}
-						$shareTypes[$fileId][] = $shareType;
-						unset($nodesLeft[$fileId]);
-					}
-				}
-
-				if (count($shares) < 100) {
-					break;
-				} else {
-					$offset += count($shares);
-				}
-			}
-		}
-		return $shareTypes;
-	}
-
-	/**
-	 * Returns a list of recently modified files.
-	 *
-	 * @return DataResponse
-	 */
-	#[NoAdminRequired]
-	public function getRecentFiles() {
-		$nodes = $this->userFolder->getRecent(100);
-		$files = $this->formatNodes($nodes);
-		return new DataResponse(['files' => $files]);
-	}
-
-	/**
-	 * @param \OCP\Files\Node[] $nodes
-	 * @param int $depth The depth to traverse into the contents of each node
-	 */
-	private function getChildren(array $nodes, int $depth = 1, int $currentDepth = 0): array {
-		if ($currentDepth >= $depth) {
-			return [];
-		}
-
-		$children = [];
-		foreach ($nodes as $node) {
-			if (!($node instanceof Folder)) {
-				continue;
-			}
-
-			$basename = basename($node->getPath());
-			$entry = [
-				'id' => $node->getId(),
-				'basename' => $basename,
-				'children' => $this->getChildren($node->getDirectoryListing(), $depth, $currentDepth + 1),
-			];
-			$displayName = $node->getName();
-			if ($basename !== $displayName) {
-				$entry['displayName'] = $displayName;
-			}
-			$children[] = $entry;
-		}
-		return $children;
-	}
-
-	/**
-	 * Returns the folder tree of the user
-	 *
-	 * @param string $path The path relative to the user folder
-	 * @param int $depth The depth of the tree
-	 *
-	 * @return JSONResponse<Http::STATUS_OK, FilesFolderTree, array{}>|JSONResponse<Http::STATUS_UNAUTHORIZED|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND, array{message: string}, array{}>
-	 *
-	 * 200: Folder tree returned successfully
-	 * 400: Invalid folder path
-	 * 401: Unauthorized
-	 * 404: Folder not found
-	 */
-	#[NoAdminRequired]
-	#[ApiRoute(verb: 'GET', url: '/api/v1/folder-tree')]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getFolderTree(string $path = '/', int $depth = 1): JSONResponse {
-		$user = $this->userSession->getUser();
-		if (!($user instanceof IUser)) {
-			return new JSONResponse([
-				'message' => $this->l10n->t('Failed to authorize'),
-			], Http::STATUS_UNAUTHORIZED);
-		}
-		try {
-			$userFolder = $this->rootFolder->getUserFolder($user->getUID());
-			$userFolderPath = $userFolder->getPath();
-			$fullPath = implode('/', [$userFolderPath, trim($path, '/')]);
-			$node = $this->rootFolder->get($fullPath);
-			if (!($node instanceof Folder)) {
-				return new JSONResponse([
-					'message' => $this->l10n->t('Invalid folder path'),
-				], Http::STATUS_BAD_REQUEST);
-			}
-			$nodes = $node->getDirectoryListing();
-			$tree = $this->getChildren($nodes, $depth);
-		} catch (NotFoundException $e) {
-			return new JSONResponse([
-				'message' => $this->l10n->t('Folder not found'),
-			], Http::STATUS_NOT_FOUND);
-		} catch (Throwable $th) {
-			$this->logger->error($th->getMessage(), ['exception' => $th]);
-			$tree = [];
-		}
-		return new JSONResponse($tree);
-	}
-
-	/**
-	 * Returns the current logged-in user's storage stats.
-	 *
-	 * @param ?string $dir the directory to get the storage stats from
-	 * @return JSONResponse
-	 */
-	#[NoAdminRequired]
-	public function getStorageStats($dir = '/'): JSONResponse {
-		$storageInfo = \OC_Helper::getStorageInfo($dir ?: '/');
-		$response = new JSONResponse(['message' => 'ok', 'data' => $storageInfo]);
-		$response->cacheFor(5 * 60);
-		return $response;
-	}
-
-	/**
-	 * Set a user view config
-	 *
-	 * @param string $view
-	 * @param string $key
-	 * @param string|bool $value
-	 * @return JSONResponse
-	 */
-	#[NoAdminRequired]
-	public function setViewConfig(string $view, string $key, $value): JSONResponse {
-		try {
-			$this->viewConfig->setConfig($view, $key, (string)$value);
-		} catch (\InvalidArgumentException $e) {
-			return new JSONResponse(['message' => $e->getMessage()], Http::STATUS_BAD_REQUEST);
-		}
-
-		return new JSONResponse(['message' => 'ok', 'data' => $this->viewConfig->getConfig($view)]);
-	}
-
-
-	/**
-	 * Get the user view config
-	 *
-	 * @return JSONResponse
-	 */
-	#[NoAdminRequired]
-	public function getViewConfigs(): JSONResponse {
-		return new JSONResponse(['message' => 'ok', 'data' => $this->viewConfig->getConfigs()]);
-	}
-
-	/**
-	 * Set a user config
-	 *
-	 * @param string $key
-	 * @param string|bool $value
-	 * @return JSONResponse
-	 */
-	#[NoAdminRequired]
-	public function setConfig(string $key, $value): JSONResponse {
-		try {
-			$this->userConfig->setConfig($key, (string)$value);
-		} catch (\InvalidArgumentException $e) {
-			return new JSONResponse(['message' => $e->getMessage()], Http::STATUS_BAD_REQUEST);
-		}
-
-		return new JSONResponse(['message' => 'ok', 'data' => ['key' => $key, 'value' => $value]]);
-	}
-
-
-	/**
-	 * Get the user config
-	 *
-	 * @return JSONResponse
-	 */
-	#[NoAdminRequired]
-	public function getConfigs(): JSONResponse {
-		return new JSONResponse(['message' => 'ok', 'data' => $this->userConfig->getConfigs()]);
-	}
-
-	/**
-	 * Toggle default for showing/hiding hidden files
-	 *
-	 * @param bool $value
-	 * @return Response
-	 * @throws PreConditionNotMetException
-	 */
-	#[NoAdminRequired]
-	public function showHiddenFiles(bool $value): Response {
-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', $value ? '1' : '0');
-		return new Response();
-	}
-
-	/**
-	 * Toggle default for cropping preview images
-	 *
-	 * @param bool $value
-	 * @return Response
-	 * @throws PreConditionNotMetException
-	 */
-	#[NoAdminRequired]
-	public function cropImagePreviews(bool $value): Response {
-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', $value ? '1' : '0');
-		return new Response();
-	}
-
-	/**
-	 * Toggle default for files grid view
-	 *
-	 * @param bool $show
-	 * @return Response
-	 * @throws PreConditionNotMetException
-	 */
-	#[NoAdminRequired]
-	public function showGridView(bool $show): Response {
-		$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', $show ? '1' : '0');
-		return new Response();
-	}
-
-	/**
-	 * Get default settings for the grid view
-	 */
-	#[NoAdminRequired]
-	public function getGridView() {
-		$status = $this->config->getUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', '0') === '1';
-		return new JSONResponse(['gridview' => $status]);
-	}
-
-	#[PublicPage]
-	#[NoCSRFRequired]
-	#[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)]
-	public function serviceWorker(): StreamResponse {
-		$response = new StreamResponse(__DIR__ . '/../../../../dist/preview-service-worker.js');
-		$response->setHeaders([
-			'Content-Type' => 'application/javascript',
-			'Service-Worker-Allowed' => '/'
-		]);
-		$policy = new ContentSecurityPolicy();
-		$policy->addAllowedWorkerSrcDomain("'self'");
-		$policy->addAllowedScriptDomain("'self'");
-		$policy->addAllowedConnectDomain("'self'");
-		$response->setContentSecurityPolicy($policy);
-		return $response;
-	}
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        private IUserSession $userSession,
+        private TagService $tagService,
+        private IPreview $previewManager,
+        private IManager $shareManager,
+        private IConfig $config,
+        private ?Folder $userFolder,
+        private UserConfig $userConfig,
+        private ViewConfig $viewConfig,
+        private IL10N $l10n,
+        private IRootFolder $rootFolder,
+        private LoggerInterface $logger,
+    ) {
+        parent::__construct($appName, $request);
+    }
+
+    /**
+     * Gets a thumbnail of the specified file
+     *
+     * @since API version 1.0
+     * @deprecated 32.0.0 Use the preview endpoint provided by core instead
+     *
+     * @param int $x Width of the thumbnail
+     * @param int $y Height of the thumbnail
+     * @param string $file URL-encoded filename
+     * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND, array{message?: string}, array{}>
+     *
+     * 200: Thumbnail returned
+     * 400: Getting thumbnail is not possible
+     * 404: File not found
+     */
+    #[NoAdminRequired]
+    #[NoCSRFRequired]
+    #[StrictCookiesRequired]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getThumbnail($x, $y, $file) {
+        if ($x < 1 || $y < 1) {
+            return new DataResponse(['message' => 'Requested size must be numeric and a positive value.'], Http::STATUS_BAD_REQUEST);
+        }
+
+        try {
+            $file = $this->userFolder?->get($file);
+            if ($file === null
+                || !($file instanceof File)
+                || ($file->getId() <= 0)
+            ) {
+                throw new NotFoundException();
+            }
+
+            // Validate the user is allowed to download the file (preview is some kind of download)
+            /** @var ISharedStorage $storage */
+            $storage = $file->getStorage();
+            if ($storage->instanceOfStorage(ISharedStorage::class)) {
+                /** @var IShare $share */
+                $share = $storage->getShare();
+                if (!$share->canSeeContent()) {
+                    throw new NotFoundException();
+                }
+            }
+
+            $preview = $this->previewManager->getPreview($file, $x, $y, true);
+
+            return new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => $preview->getMimeType()]);
+        } catch (NotFoundException|NotPermittedException|InvalidPathException) {
+            return new DataResponse(['message' => 'File not found.'], Http::STATUS_NOT_FOUND);
+        } catch (\Exception $e) {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
+    }
+
+    /**
+     * Updates the info of the specified file path
+     * The passed tags are absolute, which means they will
+     * replace the actual tag selection.
+     *
+     * @param string $path path
+     * @param array|string $tags array of tags
+     * @return DataResponse
+     */
+    #[NoAdminRequired]
+    public function updateFileTags($path, $tags = null) {
+        $result = [];
+        // if tags specified or empty array, update tags
+        if (!is_null($tags)) {
+            try {
+                $this->tagService->updateFileTags($path, $tags);
+            } catch (NotFoundException $e) {
+                return new DataResponse([
+                    'message' => $e->getMessage()
+                ], Http::STATUS_NOT_FOUND);
+            } catch (StorageNotAvailableException $e) {
+                return new DataResponse([
+                    'message' => $e->getMessage()
+                ], Http::STATUS_SERVICE_UNAVAILABLE);
+            } catch (\Exception $e) {
+                return new DataResponse([
+                    'message' => $e->getMessage()
+                ], Http::STATUS_NOT_FOUND);
+            }
+            $result['tags'] = $tags;
+        }
+        return new DataResponse($result);
+    }
+
+    /**
+     * @param \OCP\Files\Node[] $nodes
+     * @return array
+     */
+    private function formatNodes(array $nodes) {
+        $shareTypesForNodes = $this->getShareTypesForNodes($nodes);
+        return array_values(array_map(function (Node $node) use ($shareTypesForNodes) {
+            $shareTypes = $shareTypesForNodes[$node->getId()] ?? [];
+            $file = Helper::formatFileInfo($node->getFileInfo());
+            $file['hasPreview'] = $this->previewManager->isAvailable($node);
+            $parts = explode('/', dirname($node->getPath()), 4);
+            if (isset($parts[3])) {
+                $file['path'] = '/' . $parts[3];
+            } else {
+                $file['path'] = '/';
+            }
+            if (!empty($shareTypes)) {
+                $file['shareTypes'] = $shareTypes;
+            }
+            return $file;
+        }, $nodes));
+    }
+
+    /**
+     * Get the share types for each node
+     *
+     * @param \OCP\Files\Node[] $nodes
+     * @return array<int, int[]> list of share types for each fileid
+     */
+    private function getShareTypesForNodes(array $nodes): array {
+        $userId = $this->userSession->getUser()->getUID();
+        $requestedShareTypes = [
+            IShare::TYPE_USER,
+            IShare::TYPE_GROUP,
+            IShare::TYPE_LINK,
+            IShare::TYPE_REMOTE,
+            IShare::TYPE_EMAIL,
+            IShare::TYPE_ROOM,
+            IShare::TYPE_DECK,
+            IShare::TYPE_SCIENCEMESH,
+        ];
+        $shareTypes = [];
+
+        $nodeIds = array_map(function (Node $node) {
+            return $node->getId();
+        }, $nodes);
+
+        foreach ($requestedShareTypes as $shareType) {
+            $nodesLeft = array_combine($nodeIds, array_fill(0, count($nodeIds), true));
+            $offset = 0;
+
+            // fetch shares until we've either found shares for all nodes or there are no more shares left
+            while (count($nodesLeft) > 0) {
+                $shares = $this->shareManager->getSharesBy($userId, $shareType, null, false, 100, $offset);
+                foreach ($shares as $share) {
+                    $fileId = $share->getNodeId();
+                    if (isset($nodesLeft[$fileId])) {
+                        if (!isset($shareTypes[$fileId])) {
+                            $shareTypes[$fileId] = [];
+                        }
+                        $shareTypes[$fileId][] = $shareType;
+                        unset($nodesLeft[$fileId]);
+                    }
+                }
+
+                if (count($shares) < 100) {
+                    break;
+                } else {
+                    $offset += count($shares);
+                }
+            }
+        }
+        return $shareTypes;
+    }
+
+    /**
+     * Returns a list of recently modified files.
+     *
+     * @return DataResponse
+     */
+    #[NoAdminRequired]
+    public function getRecentFiles() {
+        $nodes = $this->userFolder->getRecent(100);
+        $files = $this->formatNodes($nodes);
+        return new DataResponse(['files' => $files]);
+    }
+
+    /**
+     * @param \OCP\Files\Node[] $nodes
+     * @param int $depth The depth to traverse into the contents of each node
+     */
+    private function getChildren(array $nodes, int $depth = 1, int $currentDepth = 0): array {
+        if ($currentDepth >= $depth) {
+            return [];
+        }
+
+        $children = [];
+        foreach ($nodes as $node) {
+            if (!($node instanceof Folder)) {
+                continue;
+            }
+
+            $basename = basename($node->getPath());
+            $entry = [
+                'id' => $node->getId(),
+                'basename' => $basename,
+                'children' => $this->getChildren($node->getDirectoryListing(), $depth, $currentDepth + 1),
+            ];
+            $displayName = $node->getName();
+            if ($basename !== $displayName) {
+                $entry['displayName'] = $displayName;
+            }
+            $children[] = $entry;
+        }
+        return $children;
+    }
+
+    /**
+     * Returns the folder tree of the user
+     *
+     * @param string $path The path relative to the user folder
+     * @param int $depth The depth of the tree
+     *
+     * @return JSONResponse<Http::STATUS_OK, FilesFolderTree, array{}>|JSONResponse<Http::STATUS_UNAUTHORIZED|Http::STATUS_BAD_REQUEST|Http::STATUS_NOT_FOUND, array{message: string}, array{}>
+     *
+     * 200: Folder tree returned successfully
+     * 400: Invalid folder path
+     * 401: Unauthorized
+     * 404: Folder not found
+     */
+    #[NoAdminRequired]
+    #[ApiRoute(verb: 'GET', url: '/api/v1/folder-tree')]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getFolderTree(string $path = '/', int $depth = 1): JSONResponse {
+        $user = $this->userSession->getUser();
+        if (!($user instanceof IUser)) {
+            return new JSONResponse([
+                'message' => $this->l10n->t('Failed to authorize'),
+            ], Http::STATUS_UNAUTHORIZED);
+        }
+        try {
+            $userFolder = $this->rootFolder->getUserFolder($user->getUID());
+            $userFolderPath = $userFolder->getPath();
+            $fullPath = implode('/', [$userFolderPath, trim($path, '/')]);
+            $node = $this->rootFolder->get($fullPath);
+            if (!($node instanceof Folder)) {
+                return new JSONResponse([
+                    'message' => $this->l10n->t('Invalid folder path'),
+                ], Http::STATUS_BAD_REQUEST);
+            }
+            $nodes = $node->getDirectoryListing();
+            $tree = $this->getChildren($nodes, $depth);
+        } catch (NotFoundException $e) {
+            return new JSONResponse([
+                'message' => $this->l10n->t('Folder not found'),
+            ], Http::STATUS_NOT_FOUND);
+        } catch (Throwable $th) {
+            $this->logger->error($th->getMessage(), ['exception' => $th]);
+            $tree = [];
+        }
+        return new JSONResponse($tree);
+    }
+
+    /**
+     * Returns the current logged-in user's storage stats.
+     *
+     * @param ?string $dir the directory to get the storage stats from
+     * @return JSONResponse
+     */
+    #[NoAdminRequired]
+    public function getStorageStats($dir = '/'): JSONResponse {
+        $storageInfo = \OC_Helper::getStorageInfo($dir ?: '/');
+        $response = new JSONResponse(['message' => 'ok', 'data' => $storageInfo]);
+        $response->cacheFor(5 * 60);
+        return $response;
+    }
+
+    /**
+     * Set a user view config
+     *
+     * @param string $view
+     * @param string $key
+     * @param string|bool $value
+     * @return JSONResponse
+     */
+    #[NoAdminRequired]
+    public function setViewConfig(string $view, string $key, $value): JSONResponse {
+        try {
+            $this->viewConfig->setConfig($view, $key, (string)$value);
+        } catch (\InvalidArgumentException $e) {
+            return new JSONResponse(['message' => $e->getMessage()], Http::STATUS_BAD_REQUEST);
+        }
+
+        return new JSONResponse(['message' => 'ok', 'data' => $this->viewConfig->getConfig($view)]);
+    }
+
+
+    /**
+     * Get the user view config
+     *
+     * @return JSONResponse
+     */
+    #[NoAdminRequired]
+    public function getViewConfigs(): JSONResponse {
+        return new JSONResponse(['message' => 'ok', 'data' => $this->viewConfig->getConfigs()]);
+    }
+
+    /**
+     * Set a user config
+     *
+     * @param string $key
+     * @param string|bool $value
+     * @return JSONResponse
+     */
+    #[NoAdminRequired]
+    public function setConfig(string $key, $value): JSONResponse {
+        try {
+            $this->userConfig->setConfig($key, (string)$value);
+        } catch (\InvalidArgumentException $e) {
+            return new JSONResponse(['message' => $e->getMessage()], Http::STATUS_BAD_REQUEST);
+        }
+
+        return new JSONResponse(['message' => 'ok', 'data' => ['key' => $key, 'value' => $value]]);
+    }
+
+
+    /**
+     * Get the user config
+     *
+     * @return JSONResponse
+     */
+    #[NoAdminRequired]
+    public function getConfigs(): JSONResponse {
+        return new JSONResponse(['message' => 'ok', 'data' => $this->userConfig->getConfigs()]);
+    }
+
+    /**
+     * Toggle default for showing/hiding hidden files
+     *
+     * @param bool $value
+     * @return Response
+     * @throws PreConditionNotMetException
+     */
+    #[NoAdminRequired]
+    public function showHiddenFiles(bool $value): Response {
+        $this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', $value ? '1' : '0');
+        return new Response();
+    }
+
+    /**
+     * Toggle default for cropping preview images
+     *
+     * @param bool $value
+     * @return Response
+     * @throws PreConditionNotMetException
+     */
+    #[NoAdminRequired]
+    public function cropImagePreviews(bool $value): Response {
+        $this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', $value ? '1' : '0');
+        return new Response();
+    }
+
+    /**
+     * Toggle default for files grid view
+     *
+     * @param bool $show
+     * @return Response
+     * @throws PreConditionNotMetException
+     */
+    #[NoAdminRequired]
+    public function showGridView(bool $show): Response {
+        $this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', $show ? '1' : '0');
+        return new Response();
+    }
+
+    /**
+     * Get default settings for the grid view
+     */
+    #[NoAdminRequired]
+    public function getGridView() {
+        $status = $this->config->getUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', '0') === '1';
+        return new JSONResponse(['gridview' => $status]);
+    }
+
+    #[PublicPage]
+    #[NoCSRFRequired]
+    #[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)]
+    public function serviceWorker(): StreamResponse {
+        $response = new StreamResponse(__DIR__ . '/../../../../dist/preview-service-worker.js');
+        $response->setHeaders([
+            'Content-Type' => 'application/javascript',
+            'Service-Worker-Allowed' => '/'
+        ]);
+        $policy = new ContentSecurityPolicy();
+        $policy->addAllowedWorkerSrcDomain("'self'");
+        $policy->addAllowedScriptDomain("'self'");
+        $policy->addAllowedConnectDomain("'self'");
+        $response->setContentSecurityPolicy($policy);
+        return $response;
+    }
 }

apps/files/tests/Controller/ApiControllerTest.php

Indentation +256 added lines, -256 removed lines

@@ -41,260 +41,260 @@
  * @package OCA\Files\Controller
  */
 class ApiControllerTest extends TestCase {
-	private string $appName = 'files';
-	private IUser $user;
-	private IRequest $request;
-	private TagService $tagService;
-	private IPreview&MockObject $preview;
-	private ApiController $apiController;
-	private IManager $shareManager;
-	private IConfig $config;
-	private Folder&MockObject $userFolder;
-	private UserConfig&MockObject $userConfig;
-	private ViewConfig&MockObject $viewConfig;
-	private IL10N&MockObject $l10n;
-	private IRootFolder&MockObject $rootFolder;
-	private LoggerInterface&MockObject $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->request = $this->createMock(IRequest::class);
-		$this->user = $this->createMock(IUser::class);
-		$this->user->expects($this->any())
-			->method('getUID')
-			->willReturn('user1');
-		$userSession = $this->createMock(IUserSession::class);
-		$userSession->expects($this->any())
-			->method('getUser')
-			->willReturn($this->user);
-		$this->tagService = $this->createMock(TagService::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->preview = $this->createMock(IPreview::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->userFolder = $this->createMock(Folder::class);
-		$this->userConfig = $this->createMock(UserConfig::class);
-		$this->viewConfig = $this->createMock(ViewConfig::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->rootFolder = $this->createMock(IRootFolder::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->apiController = new ApiController(
-			$this->appName,
-			$this->request,
-			$userSession,
-			$this->tagService,
-			$this->preview,
-			$this->shareManager,
-			$this->config,
-			$this->userFolder,
-			$this->userConfig,
-			$this->viewConfig,
-			$this->l10n,
-			$this->rootFolder,
-			$this->logger,
-		);
-	}
-
-	public function testUpdateFileTagsEmpty(): void {
-		$expected = new DataResponse([]);
-		$this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt'));
-	}
-
-	public function testUpdateFileTagsWorking(): void {
-		$this->tagService->expects($this->once())
-			->method('updateFileTags')
-			->with('/path.txt', ['Tag1', 'Tag2']);
-
-		$expected = new DataResponse([
-			'tags' => [
-				'Tag1',
-				'Tag2'
-			],
-		]);
-		$this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt', ['Tag1', 'Tag2']));
-	}
-
-	public function testUpdateFileTagsNotFoundException(): void {
-		$this->tagService->expects($this->once())
-			->method('updateFileTags')
-			->with('/path.txt', ['Tag1', 'Tag2'])
-			->will($this->throwException(new NotFoundException('My error message')));
-
-		$expected = new DataResponse(['message' => 'My error message'], Http::STATUS_NOT_FOUND);
-		$this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt', ['Tag1', 'Tag2']));
-	}
-
-	public function testUpdateFileTagsStorageNotAvailableException(): void {
-		$this->tagService->expects($this->once())
-			->method('updateFileTags')
-			->with('/path.txt', ['Tag1', 'Tag2'])
-			->will($this->throwException(new StorageNotAvailableException('My error message')));
-
-		$expected = new DataResponse(['message' => 'My error message'], Http::STATUS_SERVICE_UNAVAILABLE);
-		$this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt', ['Tag1', 'Tag2']));
-	}
-
-	public function testUpdateFileTagsStorageGenericException(): void {
-		$this->tagService->expects($this->once())
-			->method('updateFileTags')
-			->with('/path.txt', ['Tag1', 'Tag2'])
-			->will($this->throwException(new \Exception('My error message')));
-
-		$expected = new DataResponse(['message' => 'My error message'], Http::STATUS_NOT_FOUND);
-		$this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt', ['Tag1', 'Tag2']));
-	}
-
-	public function testGetThumbnailInvalidSize(): void {
-		$this->userFolder->method('get')
-			->with($this->equalTo(''))
-			->willThrowException(new NotFoundException());
-		$expected = new DataResponse(['message' => 'Requested size must be numeric and a positive value.'], Http::STATUS_BAD_REQUEST);
-		$this->assertEquals($expected, $this->apiController->getThumbnail(0, 0, ''));
-	}
-
-	public function testGetThumbnailInvalidImage(): void {
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(123);
-		$file->method('getStorage')->willReturn($storage);
-		$this->userFolder->method('get')
-			->with($this->equalTo('unknown.jpg'))
-			->willReturn($file);
-		$this->preview->expects($this->once())
-			->method('getPreview')
-			->with($file, 10, 10, true)
-			->willThrowException(new NotFoundException());
-		$expected = new DataResponse(['message' => 'File not found.'], Http::STATUS_NOT_FOUND);
-		$this->assertEquals($expected, $this->apiController->getThumbnail(10, 10, 'unknown.jpg'));
-	}
-
-	public function testGetThumbnailInvalidPartFile(): void {
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(0);
-		$this->userFolder->method('get')
-			->with($this->equalTo('unknown.jpg'))
-			->willReturn($file);
-		$expected = new DataResponse(['message' => 'File not found.'], Http::STATUS_NOT_FOUND);
-		$this->assertEquals($expected, $this->apiController->getThumbnail(10, 10, 'unknown.jpg'));
-	}
-
-	public function testGetThumbnailSharedNoDownload(): void {
-		$share = $this->createMock(IShare::class);
-		$share->expects(self::once())
-			->method('canSeeContent')
-			->willReturn(false);
-
-		$storage = $this->createMock(ISharedStorage::class);
-		$storage->expects(self::once())
-			->method('instanceOfStorage')
-			->with(ISharedStorage::class)
-			->willReturn(true);
-		$storage->expects(self::once())
-			->method('getShare')
-			->willReturn($share);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(123);
-		$file->method('getStorage')->willReturn($storage);
-
-		$this->userFolder->method('get')
-			->with('unknown.jpg')
-			->willReturn($file);
-
-		$this->preview->expects($this->never())
-			->method('getPreview');
-
-		$expected = new DataResponse(['message' => 'File not found.'], Http::STATUS_NOT_FOUND);
-		$this->assertEquals($expected, $this->apiController->getThumbnail(10, 10, 'unknown.jpg'));
-	}
-
-	public function testGetThumbnailShared(): void {
-		$share = $this->createMock(IShare::class);
-		$share->expects(self::once())
-			->method('canSeeContent')
-			->willReturn(true);
-
-		$storage = $this->createMock(ISharedStorage::class);
-		$storage->expects(self::once())
-			->method('instanceOfStorage')
-			->with(ISharedStorage::class)
-			->willReturn(true);
-		$storage->expects(self::once())
-			->method('getShare')
-			->willReturn($share);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(123);
-		$file->method('getStorage')->willReturn($storage);
-
-		$this->userFolder->method('get')
-			->with($this->equalTo('known.jpg'))
-			->willReturn($file);
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('my name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->preview->expects($this->once())
-			->method('getPreview')
-			->with($this->equalTo($file), 10, 10, true)
-			->willReturn($preview);
-
-		$ret = $this->apiController->getThumbnail(10, 10, 'known.jpg');
-
-		$this->assertEquals(Http::STATUS_OK, $ret->getStatus());
-		$this->assertInstanceOf(FileDisplayResponse::class, $ret);
-	}
-
-	public function testGetThumbnail(): void {
-		$storage = $this->createMock(IStorage::class);
-		$storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
-
-		$file = $this->createMock(File::class);
-		$file->method('getId')->willReturn(123);
-		$file->method('getStorage')->willReturn($storage);
-
-		$this->userFolder->method('get')
-			->with($this->equalTo('known.jpg'))
-			->willReturn($file);
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('my name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->preview->expects($this->once())
-			->method('getPreview')
-			->with($this->equalTo($file), 10, 10, true)
-			->willReturn($preview);
-
-		$ret = $this->apiController->getThumbnail(10, 10, 'known.jpg');
-
-		$this->assertEquals(Http::STATUS_OK, $ret->getStatus());
-		$this->assertInstanceOf(FileDisplayResponse::class, $ret);
-	}
-
-	public function testShowHiddenFiles(): void {
-		$show = false;
-
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with($this->user->getUID(), 'files', 'show_hidden', '0');
-
-		$expected = new Response();
-		$actual = $this->apiController->showHiddenFiles($show);
-
-		$this->assertEquals($expected, $actual);
-	}
-
-	public function testCropImagePreviews(): void {
-		$crop = true;
-
-		$this->config->expects($this->once())
-			->method('setUserValue')
-			->with($this->user->getUID(), 'files', 'crop_image_previews', '1');
-
-		$expected = new Response();
-		$actual = $this->apiController->cropImagePreviews($crop);
-
-		$this->assertEquals($expected, $actual);
-	}
+    private string $appName = 'files';
+    private IUser $user;
+    private IRequest $request;
+    private TagService $tagService;
+    private IPreview&MockObject $preview;
+    private ApiController $apiController;
+    private IManager $shareManager;
+    private IConfig $config;
+    private Folder&MockObject $userFolder;
+    private UserConfig&MockObject $userConfig;
+    private ViewConfig&MockObject $viewConfig;
+    private IL10N&MockObject $l10n;
+    private IRootFolder&MockObject $rootFolder;
+    private LoggerInterface&MockObject $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->request = $this->createMock(IRequest::class);
+        $this->user = $this->createMock(IUser::class);
+        $this->user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('user1');
+        $userSession = $this->createMock(IUserSession::class);
+        $userSession->expects($this->any())
+            ->method('getUser')
+            ->willReturn($this->user);
+        $this->tagService = $this->createMock(TagService::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->preview = $this->createMock(IPreview::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->userFolder = $this->createMock(Folder::class);
+        $this->userConfig = $this->createMock(UserConfig::class);
+        $this->viewConfig = $this->createMock(ViewConfig::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->rootFolder = $this->createMock(IRootFolder::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->apiController = new ApiController(
+            $this->appName,
+            $this->request,
+            $userSession,
+            $this->tagService,
+            $this->preview,
+            $this->shareManager,
+            $this->config,
+            $this->userFolder,
+            $this->userConfig,
+            $this->viewConfig,
+            $this->l10n,
+            $this->rootFolder,
+            $this->logger,
+        );
+    }
+
+    public function testUpdateFileTagsEmpty(): void {
+        $expected = new DataResponse([]);
+        $this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt'));
+    }
+
+    public function testUpdateFileTagsWorking(): void {
+        $this->tagService->expects($this->once())
+            ->method('updateFileTags')
+            ->with('/path.txt', ['Tag1', 'Tag2']);
+
+        $expected = new DataResponse([
+            'tags' => [
+                'Tag1',
+                'Tag2'
+            ],
+        ]);
+        $this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt', ['Tag1', 'Tag2']));
+    }
+
+    public function testUpdateFileTagsNotFoundException(): void {
+        $this->tagService->expects($this->once())
+            ->method('updateFileTags')
+            ->with('/path.txt', ['Tag1', 'Tag2'])
+            ->will($this->throwException(new NotFoundException('My error message')));
+
+        $expected = new DataResponse(['message' => 'My error message'], Http::STATUS_NOT_FOUND);
+        $this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt', ['Tag1', 'Tag2']));
+    }
+
+    public function testUpdateFileTagsStorageNotAvailableException(): void {
+        $this->tagService->expects($this->once())
+            ->method('updateFileTags')
+            ->with('/path.txt', ['Tag1', 'Tag2'])
+            ->will($this->throwException(new StorageNotAvailableException('My error message')));
+
+        $expected = new DataResponse(['message' => 'My error message'], Http::STATUS_SERVICE_UNAVAILABLE);
+        $this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt', ['Tag1', 'Tag2']));
+    }
+
+    public function testUpdateFileTagsStorageGenericException(): void {
+        $this->tagService->expects($this->once())
+            ->method('updateFileTags')
+            ->with('/path.txt', ['Tag1', 'Tag2'])
+            ->will($this->throwException(new \Exception('My error message')));
+
+        $expected = new DataResponse(['message' => 'My error message'], Http::STATUS_NOT_FOUND);
+        $this->assertEquals($expected, $this->apiController->updateFileTags('/path.txt', ['Tag1', 'Tag2']));
+    }
+
+    public function testGetThumbnailInvalidSize(): void {
+        $this->userFolder->method('get')
+            ->with($this->equalTo(''))
+            ->willThrowException(new NotFoundException());
+        $expected = new DataResponse(['message' => 'Requested size must be numeric and a positive value.'], Http::STATUS_BAD_REQUEST);
+        $this->assertEquals($expected, $this->apiController->getThumbnail(0, 0, ''));
+    }
+
+    public function testGetThumbnailInvalidImage(): void {
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(123);
+        $file->method('getStorage')->willReturn($storage);
+        $this->userFolder->method('get')
+            ->with($this->equalTo('unknown.jpg'))
+            ->willReturn($file);
+        $this->preview->expects($this->once())
+            ->method('getPreview')
+            ->with($file, 10, 10, true)
+            ->willThrowException(new NotFoundException());
+        $expected = new DataResponse(['message' => 'File not found.'], Http::STATUS_NOT_FOUND);
+        $this->assertEquals($expected, $this->apiController->getThumbnail(10, 10, 'unknown.jpg'));
+    }
+
+    public function testGetThumbnailInvalidPartFile(): void {
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(0);
+        $this->userFolder->method('get')
+            ->with($this->equalTo('unknown.jpg'))
+            ->willReturn($file);
+        $expected = new DataResponse(['message' => 'File not found.'], Http::STATUS_NOT_FOUND);
+        $this->assertEquals($expected, $this->apiController->getThumbnail(10, 10, 'unknown.jpg'));
+    }
+
+    public function testGetThumbnailSharedNoDownload(): void {
+        $share = $this->createMock(IShare::class);
+        $share->expects(self::once())
+            ->method('canSeeContent')
+            ->willReturn(false);
+
+        $storage = $this->createMock(ISharedStorage::class);
+        $storage->expects(self::once())
+            ->method('instanceOfStorage')
+            ->with(ISharedStorage::class)
+            ->willReturn(true);
+        $storage->expects(self::once())
+            ->method('getShare')
+            ->willReturn($share);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(123);
+        $file->method('getStorage')->willReturn($storage);
+
+        $this->userFolder->method('get')
+            ->with('unknown.jpg')
+            ->willReturn($file);
+
+        $this->preview->expects($this->never())
+            ->method('getPreview');
+
+        $expected = new DataResponse(['message' => 'File not found.'], Http::STATUS_NOT_FOUND);
+        $this->assertEquals($expected, $this->apiController->getThumbnail(10, 10, 'unknown.jpg'));
+    }
+
+    public function testGetThumbnailShared(): void {
+        $share = $this->createMock(IShare::class);
+        $share->expects(self::once())
+            ->method('canSeeContent')
+            ->willReturn(true);
+
+        $storage = $this->createMock(ISharedStorage::class);
+        $storage->expects(self::once())
+            ->method('instanceOfStorage')
+            ->with(ISharedStorage::class)
+            ->willReturn(true);
+        $storage->expects(self::once())
+            ->method('getShare')
+            ->willReturn($share);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(123);
+        $file->method('getStorage')->willReturn($storage);
+
+        $this->userFolder->method('get')
+            ->with($this->equalTo('known.jpg'))
+            ->willReturn($file);
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('my name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->preview->expects($this->once())
+            ->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, true)
+            ->willReturn($preview);
+
+        $ret = $this->apiController->getThumbnail(10, 10, 'known.jpg');
+
+        $this->assertEquals(Http::STATUS_OK, $ret->getStatus());
+        $this->assertInstanceOf(FileDisplayResponse::class, $ret);
+    }
+
+    public function testGetThumbnail(): void {
+        $storage = $this->createMock(IStorage::class);
+        $storage->method('instanceOfStorage')->with(ISharedStorage::class)->willReturn(false);
+
+        $file = $this->createMock(File::class);
+        $file->method('getId')->willReturn(123);
+        $file->method('getStorage')->willReturn($storage);
+
+        $this->userFolder->method('get')
+            ->with($this->equalTo('known.jpg'))
+            ->willReturn($file);
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('my name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->preview->expects($this->once())
+            ->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, true)
+            ->willReturn($preview);
+
+        $ret = $this->apiController->getThumbnail(10, 10, 'known.jpg');
+
+        $this->assertEquals(Http::STATUS_OK, $ret->getStatus());
+        $this->assertInstanceOf(FileDisplayResponse::class, $ret);
+    }
+
+    public function testShowHiddenFiles(): void {
+        $show = false;
+
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with($this->user->getUID(), 'files', 'show_hidden', '0');
+
+        $expected = new Response();
+        $actual = $this->apiController->showHiddenFiles($show);
+
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testCropImagePreviews(): void {
+        $crop = true;
+
+        $this->config->expects($this->once())
+            ->method('setUserValue')
+            ->with($this->user->getUID(), 'files', 'crop_image_previews', '1');
+
+        $expected = new Response();
+        $actual = $this->apiController->cropImagePreviews($crop);
+
+        $this->assertEquals($expected, $actual);
+    }
 }

apps/files_sharing/lib/Controller/PublicPreviewController.php

Indentation +176 added lines, -176 removed lines

@@ -26,180 +26,180 @@
 
 class PublicPreviewController extends PublicShareController {
 
-	/** @var IShare */
-	private $share;
-
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		private ShareManager $shareManager,
-		ISession $session,
-		private IPreview $previewManager,
-		private IMimeIconProvider $mimeIconProvider,
-	) {
-		parent::__construct($appName, $request, $session);
-	}
-
-	protected function getPasswordHash(): ?string {
-		return $this->share->getPassword();
-	}
-
-	public function isValidToken(): bool {
-		try {
-			$this->share = $this->shareManager->getShareByToken($this->getToken());
-			return true;
-		} catch (ShareNotFound $e) {
-			return false;
-		}
-	}
-
-	protected function isPasswordProtected(): bool {
-		return $this->share->getPassword() !== null;
-	}
-
-
-	/**
-	 * Get a preview for a shared file
-	 *
-	 * @param string $token Token of the share
-	 * @param string $file File in the share
-	 * @param int $x Width of the preview
-	 * @param int $y Height of the preview
-	 * @param bool $a Whether to not crop the preview
-	 * @param bool $mimeFallback Whether to fallback to the mime icon if no preview is available
-	 * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>|RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
-	 *
-	 * 200: Preview returned
-	 * 303: Redirect to the mime icon url if mimeFallback is true
-	 * 400: Getting preview is not possible
-	 * 403: Getting preview is not allowed
-	 * 404: Share or preview not found
-	 */
-	#[PublicPage]
-	#[NoCSRFRequired]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function getPreview(
-		string $token,
-		string $file = '',
-		int $x = 32,
-		int $y = 32,
-		$a = false,
-		bool $mimeFallback = false,
-	) {
-		$cacheForSeconds = 60 * 60 * 24; // 1 day
-
-		if ($token === '' || $x === 0 || $y === 0) {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
-
-		try {
-			$share = $this->shareManager->getShareByToken($token);
-		} catch (ShareNotFound $e) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}
-
-		if (($share->getPermissions() & Constants::PERMISSION_READ) === 0) {
-			return new DataResponse([], Http::STATUS_FORBIDDEN);
-		}
-
-		// Only explicitly set to false will forbid the download!
-		$downloadForbidden = !$share->canSeeContent();
-
-		// Is this header is set it means our UI is doing a preview for no-download shares
-		// we check a header so we at least prevent people from using the link directly (obfuscation)
-		$isPublicPreview = $this->request->getHeader('x-nc-preview') === 'true';
-
-		if ($isPublicPreview && $downloadForbidden) {
-			// Only cache for 15 minutes on public preview requests to quickly remove from cache
-			$cacheForSeconds = 15 * 60;
-		} elseif ($downloadForbidden) {
-			// This is not a public share preview so we only allow a preview if download permissions are granted
-			return new DataResponse([], Http::STATUS_FORBIDDEN);
-		}
-
-		try {
-			$node = $share->getNode();
-			if ($node instanceof Folder) {
-				$file = $node->get($file);
-			} else {
-				$file = $node;
-			}
-
-			$f = $this->previewManager->getPreview($file, $x, $y, !$a);
-			$response = new FileDisplayResponse($f, Http::STATUS_OK, ['Content-Type' => $f->getMimeType()]);
-			$response->cacheFor($cacheForSeconds);
-			return $response;
-		} catch (NotFoundException $e) {
-			// If we have no preview enabled, we can redirect to the mime icon if any
-			if ($mimeFallback) {
-				if ($url = $this->mimeIconProvider->getMimeIconUrl($file->getMimeType())) {
-					return new RedirectResponse($url);
-				}
-			}
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		} catch (\InvalidArgumentException $e) {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
-	}
-
-	/**
-	 * @NoSameSiteCookieRequired
-	 *
-	 * Get a direct link preview for a shared file
-	 *
-	 * @param string $token Token of the share
-	 * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>
-	 *
-	 * 200: Preview returned
-	 * 400: Getting preview is not possible
-	 * 403: Getting preview is not allowed
-	 * 404: Share or preview not found
-	 */
-	#[PublicPage]
-	#[NoCSRFRequired]
-	#[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
-	public function directLink(string $token) {
-		// No token no image
-		if ($token === '') {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
-
-		// No share no image
-		try {
-			$share = $this->shareManager->getShareByToken($token);
-		} catch (ShareNotFound $e) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		}
-
-		// No permissions no image
-		if (($share->getPermissions() & Constants::PERMISSION_READ) === 0) {
-			return new DataResponse([], Http::STATUS_FORBIDDEN);
-		}
-
-		// Password protected shares have no direct link!
-		if ($share->getPassword() !== null) {
-			return new DataResponse([], Http::STATUS_FORBIDDEN);
-		}
-
-		if (!$share->canSeeContent()) {
-			return new DataResponse([], Http::STATUS_FORBIDDEN);
-		}
-
-		try {
-			$node = $share->getNode();
-			if ($node instanceof Folder) {
-				// Direct link only works for single files
-				return new DataResponse([], Http::STATUS_BAD_REQUEST);
-			}
-
-			$f = $this->previewManager->getPreview($node, -1, -1, false);
-			$response = new FileDisplayResponse($f, Http::STATUS_OK, ['Content-Type' => $f->getMimeType()]);
-			$response->cacheFor(3600 * 24);
-			return $response;
-		} catch (NotFoundException $e) {
-			return new DataResponse([], Http::STATUS_NOT_FOUND);
-		} catch (\InvalidArgumentException $e) {
-			return new DataResponse([], Http::STATUS_BAD_REQUEST);
-		}
-	}
+    /** @var IShare */
+    private $share;
+
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        private ShareManager $shareManager,
+        ISession $session,
+        private IPreview $previewManager,
+        private IMimeIconProvider $mimeIconProvider,
+    ) {
+        parent::__construct($appName, $request, $session);
+    }
+
+    protected function getPasswordHash(): ?string {
+        return $this->share->getPassword();
+    }
+
+    public function isValidToken(): bool {
+        try {
+            $this->share = $this->shareManager->getShareByToken($this->getToken());
+            return true;
+        } catch (ShareNotFound $e) {
+            return false;
+        }
+    }
+
+    protected function isPasswordProtected(): bool {
+        return $this->share->getPassword() !== null;
+    }
+
+
+    /**
+     * Get a preview for a shared file
+     *
+     * @param string $token Token of the share
+     * @param string $file File in the share
+     * @param int $x Width of the preview
+     * @param int $y Height of the preview
+     * @param bool $a Whether to not crop the preview
+     * @param bool $mimeFallback Whether to fallback to the mime icon if no preview is available
+     * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>|RedirectResponse<Http::STATUS_SEE_OTHER, array{}>
+     *
+     * 200: Preview returned
+     * 303: Redirect to the mime icon url if mimeFallback is true
+     * 400: Getting preview is not possible
+     * 403: Getting preview is not allowed
+     * 404: Share or preview not found
+     */
+    #[PublicPage]
+    #[NoCSRFRequired]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function getPreview(
+        string $token,
+        string $file = '',
+        int $x = 32,
+        int $y = 32,
+        $a = false,
+        bool $mimeFallback = false,
+    ) {
+        $cacheForSeconds = 60 * 60 * 24; // 1 day
+
+        if ($token === '' || $x === 0 || $y === 0) {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
+
+        try {
+            $share = $this->shareManager->getShareByToken($token);
+        } catch (ShareNotFound $e) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        }
+
+        if (($share->getPermissions() & Constants::PERMISSION_READ) === 0) {
+            return new DataResponse([], Http::STATUS_FORBIDDEN);
+        }
+
+        // Only explicitly set to false will forbid the download!
+        $downloadForbidden = !$share->canSeeContent();
+
+        // Is this header is set it means our UI is doing a preview for no-download shares
+        // we check a header so we at least prevent people from using the link directly (obfuscation)
+        $isPublicPreview = $this->request->getHeader('x-nc-preview') === 'true';
+
+        if ($isPublicPreview && $downloadForbidden) {
+            // Only cache for 15 minutes on public preview requests to quickly remove from cache
+            $cacheForSeconds = 15 * 60;
+        } elseif ($downloadForbidden) {
+            // This is not a public share preview so we only allow a preview if download permissions are granted
+            return new DataResponse([], Http::STATUS_FORBIDDEN);
+        }
+
+        try {
+            $node = $share->getNode();
+            if ($node instanceof Folder) {
+                $file = $node->get($file);
+            } else {
+                $file = $node;
+            }
+
+            $f = $this->previewManager->getPreview($file, $x, $y, !$a);
+            $response = new FileDisplayResponse($f, Http::STATUS_OK, ['Content-Type' => $f->getMimeType()]);
+            $response->cacheFor($cacheForSeconds);
+            return $response;
+        } catch (NotFoundException $e) {
+            // If we have no preview enabled, we can redirect to the mime icon if any
+            if ($mimeFallback) {
+                if ($url = $this->mimeIconProvider->getMimeIconUrl($file->getMimeType())) {
+                    return new RedirectResponse($url);
+                }
+            }
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        } catch (\InvalidArgumentException $e) {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
+    }
+
+    /**
+     * @NoSameSiteCookieRequired
+     *
+     * Get a direct link preview for a shared file
+     *
+     * @param string $token Token of the share
+     * @return FileDisplayResponse<Http::STATUS_OK, array{Content-Type: string}>|DataResponse<Http::STATUS_BAD_REQUEST|Http::STATUS_FORBIDDEN|Http::STATUS_NOT_FOUND, list<empty>, array{}>
+     *
+     * 200: Preview returned
+     * 400: Getting preview is not possible
+     * 403: Getting preview is not allowed
+     * 404: Share or preview not found
+     */
+    #[PublicPage]
+    #[NoCSRFRequired]
+    #[OpenAPI(scope: OpenAPI::SCOPE_DEFAULT)]
+    public function directLink(string $token) {
+        // No token no image
+        if ($token === '') {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
+
+        // No share no image
+        try {
+            $share = $this->shareManager->getShareByToken($token);
+        } catch (ShareNotFound $e) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        }
+
+        // No permissions no image
+        if (($share->getPermissions() & Constants::PERMISSION_READ) === 0) {
+            return new DataResponse([], Http::STATUS_FORBIDDEN);
+        }
+
+        // Password protected shares have no direct link!
+        if ($share->getPassword() !== null) {
+            return new DataResponse([], Http::STATUS_FORBIDDEN);
+        }
+
+        if (!$share->canSeeContent()) {
+            return new DataResponse([], Http::STATUS_FORBIDDEN);
+        }
+
+        try {
+            $node = $share->getNode();
+            if ($node instanceof Folder) {
+                // Direct link only works for single files
+                return new DataResponse([], Http::STATUS_BAD_REQUEST);
+            }
+
+            $f = $this->previewManager->getPreview($node, -1, -1, false);
+            $response = new FileDisplayResponse($f, Http::STATUS_OK, ['Content-Type' => $f->getMimeType()]);
+            $response->cacheFor(3600 * 24);
+            return $response;
+        } catch (NotFoundException $e) {
+            return new DataResponse([], Http::STATUS_NOT_FOUND);
+        } catch (\InvalidArgumentException $e) {
+            return new DataResponse([], Http::STATUS_BAD_REQUEST);
+        }
+    }
 }

apps/files_sharing/tests/Controller/PublicPreviewControllerTest.php

Indentation +245 added lines, -245 removed lines

@@ -27,265 +27,265 @@
 
 class PublicPreviewControllerTest extends TestCase {
 
-	private IPreview&MockObject $previewManager;
-	private IManager&MockObject $shareManager;
-	private ITimeFactory&MockObject $timeFactory;
-	private IRequest&MockObject $request;
+    private IPreview&MockObject $previewManager;
+    private IManager&MockObject $shareManager;
+    private ITimeFactory&MockObject $timeFactory;
+    private IRequest&MockObject $request;
 
-	private PublicPreviewController $controller;
+    private PublicPreviewController $controller;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->previewManager = $this->createMock(IPreview::class);
-		$this->shareManager = $this->createMock(IManager::class);
-		$this->timeFactory = $this->createMock(ITimeFactory::class);
-		$this->request = $this->createMock(IRequest::class);
+        $this->previewManager = $this->createMock(IPreview::class);
+        $this->shareManager = $this->createMock(IManager::class);
+        $this->timeFactory = $this->createMock(ITimeFactory::class);
+        $this->request = $this->createMock(IRequest::class);
 
-		$this->timeFactory->method('getTime')
-			->willReturn(1337);
+        $this->timeFactory->method('getTime')
+            ->willReturn(1337);
 
-		$this->overwriteService(ITimeFactory::class, $this->timeFactory);
+        $this->overwriteService(ITimeFactory::class, $this->timeFactory);
 
-		$this->controller = new PublicPreviewController(
-			'files_sharing',
-			$this->request,
-			$this->shareManager,
-			$this->createMock(ISession::class),
-			$this->previewManager,
-			$this->createMock(IMimeIconProvider::class),
-		);
-	}
+        $this->controller = new PublicPreviewController(
+            'files_sharing',
+            $this->request,
+            $this->shareManager,
+            $this->createMock(ISession::class),
+            $this->previewManager,
+            $this->createMock(IMimeIconProvider::class),
+        );
+    }
 
-	public function testInvalidToken(): void {
-		$res = $this->controller->getPreview('', 'file', 10, 10, '');
-		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+    public function testInvalidToken(): void {
+        $res = $this->controller->getPreview('', 'file', 10, 10, '');
+        $expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
 
-		$this->assertEquals($expected, $res);
-	}
+        $this->assertEquals($expected, $res);
+    }
 
-	public function testInvalidWidth(): void {
-		$res = $this->controller->getPreview('token', 'file', 0);
-		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+    public function testInvalidWidth(): void {
+        $res = $this->controller->getPreview('token', 'file', 0);
+        $expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
 
-		$this->assertEquals($expected, $res);
-	}
+        $this->assertEquals($expected, $res);
+    }
 
-	public function testInvalidHeight(): void {
-		$res = $this->controller->getPreview('token', 'file', 10, 0);
-		$expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
+    public function testInvalidHeight(): void {
+        $res = $this->controller->getPreview('token', 'file', 10, 0);
+        $expected = new DataResponse([], Http::STATUS_BAD_REQUEST);
 
-		$this->assertEquals($expected, $res);
-	}
+        $this->assertEquals($expected, $res);
+    }
 
-	public function testInvalidShare(): void {
-		$this->shareManager->method('getShareByToken')
-			->with($this->equalTo('token'))
-			->willThrowException(new ShareNotFound());
-
-		$res = $this->controller->getPreview('token', 'file', 10, 10);
-		$expected = new DataResponse([], Http::STATUS_NOT_FOUND);
+    public function testInvalidShare(): void {
+        $this->shareManager->method('getShareByToken')
+            ->with($this->equalTo('token'))
+            ->willThrowException(new ShareNotFound());
+
+        $res = $this->controller->getPreview('token', 'file', 10, 10);
+        $expected = new DataResponse([], Http::STATUS_NOT_FOUND);
 
-		$this->assertEquals($expected, $res);
-	}
+        $this->assertEquals($expected, $res);
+    }
 
-	public function testShareNotAccessable(): void {
-		$share = $this->createMock(IShare::class);
-		$this->shareManager->method('getShareByToken')
-			->with($this->equalTo('token'))
-			->willReturn($share);
-
-		$share->method('getPermissions')
-			->willReturn(0);
-
-		$res = $this->controller->getPreview('token', 'file', 10, 10);
-		$expected = new DataResponse([], Http::STATUS_FORBIDDEN);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testShareNoDownload() {
-		$share = $this->createMock(IShare::class);
-		$this->shareManager->method('getShareByToken')
-			->with($this->equalTo('token'))
-			->willReturn($share);
+    public function testShareNotAccessable(): void {
+        $share = $this->createMock(IShare::class);
+        $this->shareManager->method('getShareByToken')
+            ->with($this->equalTo('token'))
+            ->willReturn($share);
+
+        $share->method('getPermissions')
+            ->willReturn(0);
+
+        $res = $this->controller->getPreview('token', 'file', 10, 10);
+        $expected = new DataResponse([], Http::STATUS_FORBIDDEN);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testShareNoDownload() {
+        $share = $this->createMock(IShare::class);
+        $this->shareManager->method('getShareByToken')
+            ->with($this->equalTo('token'))
+            ->willReturn($share);
 
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-
-		$share->method('canSeeContent')
-			->willReturn(false);
-
-		$res = $this->controller->getPreview('token', 'file', 10, 10);
-		$expected = new DataResponse([], Http::STATUS_FORBIDDEN);
-
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testShareNoDownloadButPreviewHeader() {
-		$share = $this->createMock(IShare::class);
-		$this->shareManager->method('getShareByToken')
-			->with($this->equalTo('token'))
-			->willReturn($share);
-
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-
-		$share->method('canSeeContent')
-			->willReturn(false);
-
-		$this->request->method('getHeader')
-			->with('x-nc-preview')
-			->willReturn('true');
-
-		$file = $this->createMock(File::class);
-		$share->method('getNode')
-			->willReturn($file);
-
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->previewManager->method('getPreview')
-			->with($this->equalTo($file), 10, 10, false)
-			->willReturn($preview);
-
-		$preview->method('getMimeType')
-			->willReturn('myMime');
-
-		$res = $this->controller->getPreview('token', 'file', 10, 10, true);
-		$expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'myMime']);
-		$expected->cacheFor(15 * 60);
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testShareWithAttributes() {
-		$share = $this->createMock(IShare::class);
-		$this->shareManager->method('getShareByToken')
-			->with($this->equalTo('token'))
-			->willReturn($share);
-
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-
-		$share->method('canSeeContent')
-			->willReturn(true);
-
-		$this->request->method('getHeader')
-			->with('x-nc-preview')
-			->willReturn('true');
-
-		$file = $this->createMock(File::class);
-		$share->method('getNode')
-			->willReturn($file);
-
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->previewManager->method('getPreview')
-			->with($this->equalTo($file), 10, 10, false)
-			->willReturn($preview);
-
-		$preview->method('getMimeType')
-			->willReturn('myMime');
-
-		$res = $this->controller->getPreview('token', 'file', 10, 10, true);
-		$expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'myMime']);
-		$expected->cacheFor(3600 * 24);
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testPreviewFile() {
-		$share = $this->createMock(IShare::class);
-		$this->shareManager->method('getShareByToken')
-			->with($this->equalTo('token'))
-			->willReturn($share);
-
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-
-		$file = $this->createMock(File::class);
-		$share->method('getNode')
-			->willReturn($file);
-
-		$share->method('canSeeContent')
-			->willReturn(true);
-
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->previewManager->method('getPreview')
-			->with($this->equalTo($file), 10, 10, false)
-			->willReturn($preview);
-
-		$preview->method('getMimeType')
-			->willReturn('myMime');
-
-		$res = $this->controller->getPreview('token', 'file', 10, 10, true);
-		$expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'myMime']);
-		$expected->cacheFor(3600 * 24);
-		$this->assertEquals($expected, $res);
-	}
-
-	public function testPreviewFolderInvalidFile(): void {
-		$share = $this->createMock(IShare::class);
-		$this->shareManager->method('getShareByToken')
-			->with($this->equalTo('token'))
-			->willReturn($share);
-
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-
-		$folder = $this->createMock(Folder::class);
-		$share->method('getNode')
-			->willReturn($folder);
-
-		$share->method('canSeeContent')
-			->willReturn(true);
-
-		$folder->method('get')
-			->with($this->equalTo('file'))
-			->willThrowException(new NotFoundException());
-
-		$res = $this->controller->getPreview('token', 'file', 10, 10, true);
-		$expected = new DataResponse([], Http::STATUS_NOT_FOUND);
-		$this->assertEquals($expected, $res);
-	}
-
-
-	public function testPreviewFolderValidFile(): void {
-		$share = $this->createMock(IShare::class);
-		$this->shareManager->method('getShareByToken')
-			->with($this->equalTo('token'))
-			->willReturn($share);
-
-		$share->method('getPermissions')
-			->willReturn(Constants::PERMISSION_READ);
-
-		$folder = $this->createMock(Folder::class);
-		$share->method('getNode')
-			->willReturn($folder);
-
-		$share->method('canSeeContent')
-			->willReturn(true);
-
-		$file = $this->createMock(File::class);
-		$folder->method('get')
-			->with($this->equalTo('file'))
-			->willReturn($file);
-
-		$preview = $this->createMock(ISimpleFile::class);
-		$preview->method('getName')->willReturn('name');
-		$preview->method('getMTime')->willReturn(42);
-		$this->previewManager->method('getPreview')
-			->with($this->equalTo($file), 10, 10, false)
-			->willReturn($preview);
-
-		$preview->method('getMimeType')
-			->willReturn('myMime');
-
-		$res = $this->controller->getPreview('token', 'file', 10, 10, true);
-		$expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'myMime']);
-		$expected->cacheFor(3600 * 24);
-		$this->assertEquals($expected, $res);
-	}
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+
+        $share->method('canSeeContent')
+            ->willReturn(false);
+
+        $res = $this->controller->getPreview('token', 'file', 10, 10);
+        $expected = new DataResponse([], Http::STATUS_FORBIDDEN);
+
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testShareNoDownloadButPreviewHeader() {
+        $share = $this->createMock(IShare::class);
+        $this->shareManager->method('getShareByToken')
+            ->with($this->equalTo('token'))
+            ->willReturn($share);
+
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+
+        $share->method('canSeeContent')
+            ->willReturn(false);
+
+        $this->request->method('getHeader')
+            ->with('x-nc-preview')
+            ->willReturn('true');
+
+        $file = $this->createMock(File::class);
+        $share->method('getNode')
+            ->willReturn($file);
+
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->previewManager->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, false)
+            ->willReturn($preview);
+
+        $preview->method('getMimeType')
+            ->willReturn('myMime');
+
+        $res = $this->controller->getPreview('token', 'file', 10, 10, true);
+        $expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'myMime']);
+        $expected->cacheFor(15 * 60);
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testShareWithAttributes() {
+        $share = $this->createMock(IShare::class);
+        $this->shareManager->method('getShareByToken')
+            ->with($this->equalTo('token'))
+            ->willReturn($share);
+
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+
+        $share->method('canSeeContent')
+            ->willReturn(true);
+
+        $this->request->method('getHeader')
+            ->with('x-nc-preview')
+            ->willReturn('true');
+
+        $file = $this->createMock(File::class);
+        $share->method('getNode')
+            ->willReturn($file);
+
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->previewManager->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, false)
+            ->willReturn($preview);
+
+        $preview->method('getMimeType')
+            ->willReturn('myMime');
+
+        $res = $this->controller->getPreview('token', 'file', 10, 10, true);
+        $expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'myMime']);
+        $expected->cacheFor(3600 * 24);
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testPreviewFile() {
+        $share = $this->createMock(IShare::class);
+        $this->shareManager->method('getShareByToken')
+            ->with($this->equalTo('token'))
+            ->willReturn($share);
+
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+
+        $file = $this->createMock(File::class);
+        $share->method('getNode')
+            ->willReturn($file);
+
+        $share->method('canSeeContent')
+            ->willReturn(true);
+
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->previewManager->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, false)
+            ->willReturn($preview);
+
+        $preview->method('getMimeType')
+            ->willReturn('myMime');
+
+        $res = $this->controller->getPreview('token', 'file', 10, 10, true);
+        $expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'myMime']);
+        $expected->cacheFor(3600 * 24);
+        $this->assertEquals($expected, $res);
+    }
+
+    public function testPreviewFolderInvalidFile(): void {
+        $share = $this->createMock(IShare::class);
+        $this->shareManager->method('getShareByToken')
+            ->with($this->equalTo('token'))
+            ->willReturn($share);
+
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+
+        $folder = $this->createMock(Folder::class);
+        $share->method('getNode')
+            ->willReturn($folder);
+
+        $share->method('canSeeContent')
+            ->willReturn(true);
+
+        $folder->method('get')
+            ->with($this->equalTo('file'))
+            ->willThrowException(new NotFoundException());
+
+        $res = $this->controller->getPreview('token', 'file', 10, 10, true);
+        $expected = new DataResponse([], Http::STATUS_NOT_FOUND);
+        $this->assertEquals($expected, $res);
+    }
+
+
+    public function testPreviewFolderValidFile(): void {
+        $share = $this->createMock(IShare::class);
+        $this->shareManager->method('getShareByToken')
+            ->with($this->equalTo('token'))
+            ->willReturn($share);
+
+        $share->method('getPermissions')
+            ->willReturn(Constants::PERMISSION_READ);
+
+        $folder = $this->createMock(Folder::class);
+        $share->method('getNode')
+            ->willReturn($folder);
+
+        $share->method('canSeeContent')
+            ->willReturn(true);
+
+        $file = $this->createMock(File::class);
+        $folder->method('get')
+            ->with($this->equalTo('file'))
+            ->willReturn($file);
+
+        $preview = $this->createMock(ISimpleFile::class);
+        $preview->method('getName')->willReturn('name');
+        $preview->method('getMTime')->willReturn(42);
+        $this->previewManager->method('getPreview')
+            ->with($this->equalTo($file), 10, 10, false)
+            ->willReturn($preview);
+
+        $preview->method('getMimeType')
+            ->willReturn('myMime');
+
+        $res = $this->controller->getPreview('token', 'file', 10, 10, true);
+        $expected = new FileDisplayResponse($preview, Http::STATUS_OK, ['Content-Type' => 'myMime']);
+        $expected->cacheFor(3600 * 24);
+        $this->assertEquals($expected, $res);
+    }
 }