nextcloud / server

lib/public/IUserManager.php

Indentation +220 added lines, -220 removed lines

@@ -24,224 +24,224 @@
  * @since 8.0.0
  */
 interface IUserManager {
-	/**
-	 * @since 26.0.0
-	 */
-	public const MAX_PASSWORD_LENGTH = 469;
-
-	/**
-	 * register a user backend
-	 *
-	 * @since 8.0.0
-	 * @return void
-	 */
-	public function registerBackend(UserInterface $backend);
-
-	/**
-	 * Get the active backends
-	 * @return UserInterface[]
-	 * @since 8.0.0
-	 */
-	public function getBackends();
-
-	/**
-	 * remove a user backend
-	 *
-	 * @since 8.0.0
-	 * @return void
-	 */
-	public function removeBackend(UserInterface $backend);
-
-	/**
-	 * remove all user backends
-	 * @since 8.0.0
-	 * @return void
-	 */
-	public function clearBackends();
-
-	/**
-	 * get a user by user id
-	 *
-	 * @param string $uid
-	 * @return \OCP\IUser|null Either the user or null if the specified user does not exist
-	 * @since 8.0.0
-	 */
-	public function get($uid);
-
-	/**
-	 * Get the display name of a user
-	 *
-	 * @param string $uid
-	 * @return string|null
-	 * @since 25.0.0
-	 */
-	public function getDisplayName(string $uid): ?string;
-
-	/**
-	 * check if a user exists
-	 *
-	 * @param string $uid
-	 * @return bool
-	 * @since 8.0.0
-	 */
-	public function userExists($uid);
-
-	/**
-	 * Check if the password is valid for the user
-	 *
-	 * @param string $loginName
-	 * @param string $password
-	 * @return IUser|false the User object on success, false otherwise
-	 * @since 8.0.0
-	 */
-	public function checkPassword($loginName, $password);
-
-	/**
-	 * search by user id
-	 *
-	 * @param string $pattern
-	 * @param int $limit
-	 * @param int $offset
-	 * @return \OCP\IUser[]
-	 * @since 8.0.0
-	 */
-	public function search($pattern, $limit = null, $offset = null);
-
-	/**
-	 * search by displayName
-	 *
-	 * @param string $pattern
-	 * @param int $limit
-	 * @param int $offset
-	 * @return \OCP\IUser[]
-	 * @since 8.0.0
-	 */
-	public function searchDisplayName($pattern, $limit = null, $offset = null);
-
-	/**
-	 * @return IUser[]
-	 * @since 28.0.0
-	 * @since 30.0.0 $search parameter added
-	 */
-	public function getDisabledUsers(?int $limit = null, int $offset = 0, string $search = ''): array;
-
-	/**
-	 * Search known users (from phonebook sync) by displayName
-	 *
-	 * @param string $searcher
-	 * @param string $pattern
-	 * @param int|null $limit
-	 * @param int|null $offset
-	 * @return IUser[]
-	 * @since 21.0.1
-	 */
-	public function searchKnownUsersByDisplayName(string $searcher, string $pattern, ?int $limit = null, ?int $offset = null): array;
-
-	/**
-	 * @param string $uid
-	 * @param string $password
-	 * @throws \InvalidArgumentException
-	 * @return false|\OCP\IUser the created user or false
-	 * @since 8.0.0
-	 */
-	public function createUser($uid, $password);
-
-	/**
-	 * @param string $uid
-	 * @param string $password
-	 * @param UserInterface $backend
-	 * @return IUser|null
-	 * @throws \InvalidArgumentException
-	 * @since 12.0.0
-	 */
-	public function createUserFromBackend($uid, $password, UserInterface $backend);
-
-	/**
-	 * Get how many users per backend exist (if supported by backend)
-	 *
-	 * @return array<string, int> an array of backend class name as key and count number as value
-	 * @since 8.0.0
-	 */
-	public function countUsers();
-
-	/**
-	 * Get how many users exists in total, whithin limit
-	 *
-	 * @param int $limit Limit the count to avoid resource waste. 0 to disable
-	 * @param bool $onlyMappedUsers Count mapped users instead of all users for compatible backends
-	 *
-	 * @since 31.0.0
-	 */
-	public function countUsersTotal(int $limit = 0, bool $onlyMappedUsers = false): int|false;
-
-	/**
-	 * @param \Closure $callback
-	 * @psalm-param \Closure(\OCP\IUser):void $callback
-	 * @param string $search
-	 * @since 9.0.0
-	 */
-	public function callForAllUsers(\Closure $callback, $search = '');
-
-	/**
-	 * returns how many users have logged in once
-	 *
-	 * @return int
-	 * @since 11.0.0
-	 */
-	public function countDisabledUsers();
-
-	/**
-	 * returns how many users have logged in once
-	 *
-	 * @return int
-	 * @since 11.0.0
-	 */
-	public function countSeenUsers();
-
-	/**
-	 * @param \Closure $callback
-	 * @psalm-param \Closure(\OCP\IUser):?bool $callback
-	 * @since 11.0.0
-	 */
-	public function callForSeenUsers(\Closure $callback);
-
-	/**
-	 * returns all users having the provided email set as system email address
-	 *
-	 * @param string $email
-	 * @return IUser[]
-	 * @since 9.1.0
-	 */
-	public function getByEmail($email);
-
-	/**
-	 * @param string $uid The user ID to validate
-	 * @param bool $checkDataDirectory Whether it should be checked if files for the ID exist inside the data directory
-	 * @throws \InvalidArgumentException Message is an already translated string with a reason why the ID is not valid
-	 * @since 26.0.0
-	 */
-	public function validateUserId(string $uid, bool $checkDataDirectory = false): void;
-
-	/**
-	 * Gets the list of users sorted by lastLogin, from most recent to least recent
-	 *
-	 * @param int|null $limit how many records to fetch
-	 * @param int $offset from which offset to fetch
-	 * @param string $search search users based on search params
-	 * @return list<string> list of user IDs
-	 * @since 30.0.0
-	 */
-	public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array;
-
-	/**
-	 * Gets the list of users.
-	 * An iterator is returned allowing the caller to stop the iteration at any time.
-	 * The offset argument allows the caller to continue the iteration at a specific offset.
-	 *
-	 * @param int $offset from which offset to fetch
-	 * @param int|null $limit maximum number of records to fetch
-	 * @return \Iterator<IUser> list of IUser object
-	 * @since 32.0.0
-	 */
-	public function getSeenUsers(int $offset = 0, ?int $limit = null): \Iterator;
+    /**
+     * @since 26.0.0
+     */
+    public const MAX_PASSWORD_LENGTH = 469;
+
+    /**
+     * register a user backend
+     *
+     * @since 8.0.0
+     * @return void
+     */
+    public function registerBackend(UserInterface $backend);
+
+    /**
+     * Get the active backends
+     * @return UserInterface[]
+     * @since 8.0.0
+     */
+    public function getBackends();
+
+    /**
+     * remove a user backend
+     *
+     * @since 8.0.0
+     * @return void
+     */
+    public function removeBackend(UserInterface $backend);
+
+    /**
+     * remove all user backends
+     * @since 8.0.0
+     * @return void
+     */
+    public function clearBackends();
+
+    /**
+     * get a user by user id
+     *
+     * @param string $uid
+     * @return \OCP\IUser|null Either the user or null if the specified user does not exist
+     * @since 8.0.0
+     */
+    public function get($uid);
+
+    /**
+     * Get the display name of a user
+     *
+     * @param string $uid
+     * @return string|null
+     * @since 25.0.0
+     */
+    public function getDisplayName(string $uid): ?string;
+
+    /**
+     * check if a user exists
+     *
+     * @param string $uid
+     * @return bool
+     * @since 8.0.0
+     */
+    public function userExists($uid);
+
+    /**
+     * Check if the password is valid for the user
+     *
+     * @param string $loginName
+     * @param string $password
+     * @return IUser|false the User object on success, false otherwise
+     * @since 8.0.0
+     */
+    public function checkPassword($loginName, $password);
+
+    /**
+     * search by user id
+     *
+     * @param string $pattern
+     * @param int $limit
+     * @param int $offset
+     * @return \OCP\IUser[]
+     * @since 8.0.0
+     */
+    public function search($pattern, $limit = null, $offset = null);
+
+    /**
+     * search by displayName
+     *
+     * @param string $pattern
+     * @param int $limit
+     * @param int $offset
+     * @return \OCP\IUser[]
+     * @since 8.0.0
+     */
+    public function searchDisplayName($pattern, $limit = null, $offset = null);
+
+    /**
+     * @return IUser[]
+     * @since 28.0.0
+     * @since 30.0.0 $search parameter added
+     */
+    public function getDisabledUsers(?int $limit = null, int $offset = 0, string $search = ''): array;
+
+    /**
+     * Search known users (from phonebook sync) by displayName
+     *
+     * @param string $searcher
+     * @param string $pattern
+     * @param int|null $limit
+     * @param int|null $offset
+     * @return IUser[]
+     * @since 21.0.1
+     */
+    public function searchKnownUsersByDisplayName(string $searcher, string $pattern, ?int $limit = null, ?int $offset = null): array;
+
+    /**
+     * @param string $uid
+     * @param string $password
+     * @throws \InvalidArgumentException
+     * @return false|\OCP\IUser the created user or false
+     * @since 8.0.0
+     */
+    public function createUser($uid, $password);
+
+    /**
+     * @param string $uid
+     * @param string $password
+     * @param UserInterface $backend
+     * @return IUser|null
+     * @throws \InvalidArgumentException
+     * @since 12.0.0
+     */
+    public function createUserFromBackend($uid, $password, UserInterface $backend);
+
+    /**
+     * Get how many users per backend exist (if supported by backend)
+     *
+     * @return array<string, int> an array of backend class name as key and count number as value
+     * @since 8.0.0
+     */
+    public function countUsers();
+
+    /**
+     * Get how many users exists in total, whithin limit
+     *
+     * @param int $limit Limit the count to avoid resource waste. 0 to disable
+     * @param bool $onlyMappedUsers Count mapped users instead of all users for compatible backends
+     *
+     * @since 31.0.0
+     */
+    public function countUsersTotal(int $limit = 0, bool $onlyMappedUsers = false): int|false;
+
+    /**
+     * @param \Closure $callback
+     * @psalm-param \Closure(\OCP\IUser):void $callback
+     * @param string $search
+     * @since 9.0.0
+     */
+    public function callForAllUsers(\Closure $callback, $search = '');
+
+    /**
+     * returns how many users have logged in once
+     *
+     * @return int
+     * @since 11.0.0
+     */
+    public function countDisabledUsers();
+
+    /**
+     * returns how many users have logged in once
+     *
+     * @return int
+     * @since 11.0.0
+     */
+    public function countSeenUsers();
+
+    /**
+     * @param \Closure $callback
+     * @psalm-param \Closure(\OCP\IUser):?bool $callback
+     * @since 11.0.0
+     */
+    public function callForSeenUsers(\Closure $callback);
+
+    /**
+     * returns all users having the provided email set as system email address
+     *
+     * @param string $email
+     * @return IUser[]
+     * @since 9.1.0
+     */
+    public function getByEmail($email);
+
+    /**
+     * @param string $uid The user ID to validate
+     * @param bool $checkDataDirectory Whether it should be checked if files for the ID exist inside the data directory
+     * @throws \InvalidArgumentException Message is an already translated string with a reason why the ID is not valid
+     * @since 26.0.0
+     */
+    public function validateUserId(string $uid, bool $checkDataDirectory = false): void;
+
+    /**
+     * Gets the list of users sorted by lastLogin, from most recent to least recent
+     *
+     * @param int|null $limit how many records to fetch
+     * @param int $offset from which offset to fetch
+     * @param string $search search users based on search params
+     * @return list<string> list of user IDs
+     * @since 30.0.0
+     */
+    public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array;
+
+    /**
+     * Gets the list of users.
+     * An iterator is returned allowing the caller to stop the iteration at any time.
+     * The offset argument allows the caller to continue the iteration at a specific offset.
+     *
+     * @param int $offset from which offset to fetch
+     * @param int|null $limit maximum number of records to fetch
+     * @return \Iterator<IUser> list of IUser object
+     * @since 32.0.0
+     */
+    public function getSeenUsers(int $offset = 0, ?int $limit = null): \Iterator;
 }

lib/private/User/Manager.php

Indentation +785 added lines, -785 removed lines

@@ -53,789 +53,789 @@
  * @package OC\User
  */
 class Manager extends PublicEmitter implements IUserManager {
-	/**
-	 * @var UserInterface[] $backends
-	 */
-	private array $backends = [];
-
-	/**
-	 * @var array<string,\OC\User\User> $cachedUsers
-	 */
-	private array $cachedUsers = [];
-
-	private ICache $cache;
-
-	private DisplayNameCache $displayNameCache;
-
-	public function __construct(
-		private IConfig $config,
-		ICacheFactory $cacheFactory,
-		private IEventDispatcher $eventDispatcher,
-		private LoggerInterface $logger,
-	) {
-		$this->cache = new WithLocalCache($cacheFactory->createDistributed('user_backend_map'));
-		$this->listen('\OC\User', 'postDelete', function (IUser $user): void {
-			unset($this->cachedUsers[$user->getUID()]);
-		});
-		$this->displayNameCache = new DisplayNameCache($cacheFactory, $this);
-	}
-
-	/**
-	 * Get the active backends
-	 * @return UserInterface[]
-	 */
-	public function getBackends(): array {
-		return $this->backends;
-	}
-
-	public function registerBackend(UserInterface $backend): void {
-		$this->backends[] = $backend;
-	}
-
-	public function removeBackend(UserInterface $backend): void {
-		$this->cachedUsers = [];
-		if (($i = array_search($backend, $this->backends)) !== false) {
-			unset($this->backends[$i]);
-		}
-	}
-
-	public function clearBackends(): void {
-		$this->cachedUsers = [];
-		$this->backends = [];
-	}
-
-	/**
-	 * get a user by user id
-	 *
-	 * @param string $uid
-	 * @return \OC\User\User|null Either the user or null if the specified user does not exist
-	 */
-	public function get($uid) {
-		if (is_null($uid) || $uid === '' || $uid === false) {
-			return null;
-		}
-		if (isset($this->cachedUsers[$uid])) { //check the cache first to prevent having to loop over the backends
-			return $this->cachedUsers[$uid];
-		}
-
-		if (strlen($uid) > IUser::MAX_USERID_LENGTH) {
-			return null;
-		}
-
-		$cachedBackend = $this->cache->get(sha1($uid));
-		if ($cachedBackend !== null && isset($this->backends[$cachedBackend])) {
-			// Cache has the info of the user backend already, so ask that one directly
-			$backend = $this->backends[$cachedBackend];
-			if ($backend->userExists($uid)) {
-				return $this->getUserObject($uid, $backend);
-			}
-		}
-
-		foreach ($this->backends as $i => $backend) {
-			if ($i === $cachedBackend) {
-				// Tried that one already
-				continue;
-			}
-
-			if ($backend->userExists($uid)) {
-				// Hash $uid to ensure that only valid characters are used for the cache key
-				$this->cache->set(sha1($uid), $i, 300);
-				return $this->getUserObject($uid, $backend);
-			}
-		}
-		return null;
-	}
-
-	public function getDisplayName(string $uid): ?string {
-		return $this->displayNameCache->getDisplayName($uid);
-	}
-
-	/**
-	 * get or construct the user object
-	 *
-	 * @param string $uid
-	 * @param \OCP\UserInterface $backend
-	 * @param bool $cacheUser If false the newly created user object will not be cached
-	 * @return \OC\User\User
-	 */
-	public function getUserObject($uid, $backend, $cacheUser = true) {
-		if ($backend instanceof IGetRealUIDBackend) {
-			$uid = $backend->getRealUID($uid);
-		}
-
-		if (isset($this->cachedUsers[$uid])) {
-			return $this->cachedUsers[$uid];
-		}
-
-		$user = new User($uid, $backend, $this->eventDispatcher, $this, $this->config);
-		if ($cacheUser) {
-			$this->cachedUsers[$uid] = $user;
-		}
-		return $user;
-	}
-
-	/**
-	 * check if a user exists
-	 *
-	 * @param string $uid
-	 * @return bool
-	 */
-	public function userExists($uid) {
-		if (strlen($uid) > IUser::MAX_USERID_LENGTH) {
-			return false;
-		}
-
-		$user = $this->get($uid);
-		return ($user !== null);
-	}
-
-	/**
-	 * Check if the password is valid for the user
-	 *
-	 * @param string $loginName
-	 * @param string $password
-	 * @return IUser|false the User object on success, false otherwise
-	 */
-	public function checkPassword($loginName, $password) {
-		$result = $this->checkPasswordNoLogging($loginName, $password);
-
-		if ($result === false) {
-			$this->logger->warning('Login failed: \'' . $loginName . '\' (Remote IP: \'' . \OC::$server->getRequest()->getRemoteAddress() . '\')', ['app' => 'core']);
-		}
-
-		return $result;
-	}
-
-	/**
-	 * Check if the password is valid for the user
-	 *
-	 * @internal
-	 * @param string $loginName
-	 * @param string $password
-	 * @return IUser|false the User object on success, false otherwise
-	 */
-	public function checkPasswordNoLogging($loginName, $password) {
-		$loginName = str_replace("\0", '', $loginName);
-		$password = str_replace("\0", '', $password);
-
-		$cachedBackend = $this->cache->get($loginName);
-		if ($cachedBackend !== null && isset($this->backends[$cachedBackend])) {
-			$backends = [$this->backends[$cachedBackend]];
-		} else {
-			$backends = $this->backends;
-		}
-		foreach ($backends as $backend) {
-			if ($backend instanceof ICheckPasswordBackend || $backend->implementsActions(Backend::CHECK_PASSWORD)) {
-				/** @var ICheckPasswordBackend $backend */
-				$uid = $backend->checkPassword($loginName, $password);
-				if ($uid !== false) {
-					return $this->getUserObject($uid, $backend);
-				}
-			}
-		}
-
-		// since http basic auth doesn't provide a standard way of handling non ascii password we allow password to be urlencoded
-		// we only do this decoding after using the plain password fails to maintain compatibility with any password that happens
-		// to contain urlencoded patterns by "accident".
-		$password = urldecode($password);
-
-		foreach ($backends as $backend) {
-			if ($backend instanceof ICheckPasswordBackend || $backend->implementsActions(Backend::CHECK_PASSWORD)) {
-				/** @var ICheckPasswordBackend|UserInterface $backend */
-				$uid = $backend->checkPassword($loginName, $password);
-				if ($uid !== false) {
-					return $this->getUserObject($uid, $backend);
-				}
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * Search by user id
-	 *
-	 * @param string $pattern
-	 * @param int $limit
-	 * @param int $offset
-	 * @return IUser[]
-	 * @deprecated 27.0.0, use searchDisplayName instead
-	 */
-	public function search($pattern, $limit = null, $offset = null) {
-		$users = [];
-		foreach ($this->backends as $backend) {
-			$backendUsers = $backend->getUsers($pattern, $limit, $offset);
-			if (is_array($backendUsers)) {
-				foreach ($backendUsers as $uid) {
-					$users[$uid] = new LazyUser($uid, $this, null, $backend);
-				}
-			}
-		}
-
-		uasort($users, function (IUser $a, IUser $b) {
-			return strcasecmp($a->getUID(), $b->getUID());
-		});
-		return $users;
-	}
-
-	/**
-	 * Search by displayName
-	 *
-	 * @param string $pattern
-	 * @param int $limit
-	 * @param int $offset
-	 * @return IUser[]
-	 */
-	public function searchDisplayName($pattern, $limit = null, $offset = null) {
-		$users = [];
-		foreach ($this->backends as $backend) {
-			$backendUsers = $backend->getDisplayNames($pattern, $limit, $offset);
-			if (is_array($backendUsers)) {
-				foreach ($backendUsers as $uid => $displayName) {
-					$users[] = new LazyUser($uid, $this, $displayName, $backend);
-				}
-			}
-		}
-
-		usort($users, function (IUser $a, IUser $b) {
-			return strcasecmp($a->getDisplayName(), $b->getDisplayName());
-		});
-		return $users;
-	}
-
-	/**
-	 * @return IUser[]
-	 */
-	public function getDisabledUsers(?int $limit = null, int $offset = 0, string $search = ''): array {
-		$users = $this->config->getUsersForUserValue('core', 'enabled', 'false');
-		$users = array_combine(
-			$users,
-			array_map(
-				fn (string $uid): IUser => new LazyUser($uid, $this),
-				$users
-			)
-		);
-		if ($search !== '') {
-			$users = array_filter(
-				$users,
-				function (IUser $user) use ($search): bool {
-					try {
-						return mb_stripos($user->getUID(), $search) !== false
-						|| mb_stripos($user->getDisplayName(), $search) !== false
-						|| mb_stripos($user->getEMailAddress() ?? '', $search) !== false;
-					} catch (NoUserException $ex) {
-						$this->logger->error('Error while filtering disabled users', ['exception' => $ex, 'userUID' => $user->getUID()]);
-						return false;
-					}
-				});
-		}
-
-		$tempLimit = ($limit === null ? null : $limit + $offset);
-		foreach ($this->backends as $backend) {
-			if (($tempLimit !== null) && (count($users) >= $tempLimit)) {
-				break;
-			}
-			if ($backend instanceof IProvideEnabledStateBackend) {
-				$backendUsers = $backend->getDisabledUserList(($tempLimit === null ? null : $tempLimit - count($users)), 0, $search);
-				foreach ($backendUsers as $uid) {
-					$users[$uid] = new LazyUser($uid, $this, null, $backend);
-				}
-			}
-		}
-
-		return array_slice($users, $offset, $limit);
-	}
-
-	/**
-	 * Search known users (from phonebook sync) by displayName
-	 *
-	 * @param string $searcher
-	 * @param string $pattern
-	 * @param int|null $limit
-	 * @param int|null $offset
-	 * @return IUser[]
-	 */
-	public function searchKnownUsersByDisplayName(string $searcher, string $pattern, ?int $limit = null, ?int $offset = null): array {
-		$users = [];
-		foreach ($this->backends as $backend) {
-			if ($backend instanceof ISearchKnownUsersBackend) {
-				$backendUsers = $backend->searchKnownUsersByDisplayName($searcher, $pattern, $limit, $offset);
-			} else {
-				// Better than nothing, but filtering after pagination can remove lots of results.
-				$backendUsers = $backend->getDisplayNames($pattern, $limit, $offset);
-			}
-			if (is_array($backendUsers)) {
-				foreach ($backendUsers as $uid => $displayName) {
-					$users[] = $this->getUserObject($uid, $backend);
-				}
-			}
-		}
-
-		usort($users, function ($a, $b) {
-			/**
-			 * @var IUser $a
-			 * @var IUser $b
-			 */
-			return strcasecmp($a->getDisplayName(), $b->getDisplayName());
-		});
-		return $users;
-	}
-
-	/**
-	 * @param string $uid
-	 * @param string $password
-	 * @return false|IUser the created user or false
-	 * @throws \InvalidArgumentException
-	 * @throws HintException
-	 */
-	public function createUser($uid, $password) {
-		// DI injection is not used here as IRegistry needs the user manager itself for user count and thus it would create a cyclic dependency
-		/** @var IAssertion $assertion */
-		$assertion = \OC::$server->get(IAssertion::class);
-		$assertion->createUserIsLegit();
-
-		$localBackends = [];
-		foreach ($this->backends as $backend) {
-			if ($backend instanceof Database) {
-				// First check if there is another user backend
-				$localBackends[] = $backend;
-				continue;
-			}
-
-			if ($backend->implementsActions(Backend::CREATE_USER)) {
-				return $this->createUserFromBackend($uid, $password, $backend);
-			}
-		}
-
-		foreach ($localBackends as $backend) {
-			if ($backend->implementsActions(Backend::CREATE_USER)) {
-				return $this->createUserFromBackend($uid, $password, $backend);
-			}
-		}
-
-		return false;
-	}
-
-	/**
-	 * @param string $uid
-	 * @param string $password
-	 * @param UserInterface $backend
-	 * @return IUser|false
-	 * @throws \InvalidArgumentException
-	 */
-	public function createUserFromBackend($uid, $password, UserInterface $backend) {
-		$l = \OCP\Util::getL10N('lib');
-
-		$this->validateUserId($uid, true);
-
-		// No empty password
-		if (trim($password) === '') {
-			throw new \InvalidArgumentException($l->t('A valid password must be provided'));
-		}
-
-		// Check if user already exists
-		if ($this->userExists($uid)) {
-			throw new \InvalidArgumentException($l->t('The Login is already being used'));
-		}
-
-		/** @deprecated 21.0.0 use BeforeUserCreatedEvent event with the IEventDispatcher instead */
-		$this->emit('\OC\User', 'preCreateUser', [$uid, $password]);
-		$this->eventDispatcher->dispatchTyped(new BeforeUserCreatedEvent($uid, $password));
-		$state = $backend->createUser($uid, $password);
-		if ($state === false) {
-			throw new \InvalidArgumentException($l->t('Could not create account'));
-		}
-		$user = $this->getUserObject($uid, $backend);
-		if ($user instanceof IUser) {
-			/** @deprecated 21.0.0 use UserCreatedEvent event with the IEventDispatcher instead */
-			$this->emit('\OC\User', 'postCreateUser', [$user, $password]);
-			$this->eventDispatcher->dispatchTyped(new UserCreatedEvent($user, $password));
-			return $user;
-		}
-		return false;
-	}
-
-	/**
-	 * returns how many users per backend exist (if supported by backend)
-	 *
-	 * @param boolean $hasLoggedIn when true only users that have a lastLogin
-	 *                             entry in the preferences table will be affected
-	 * @return array<string, int> an array of backend class as key and count number as value
-	 */
-	public function countUsers() {
-		$userCountStatistics = [];
-		foreach ($this->backends as $backend) {
-			if ($backend instanceof ICountUsersBackend || $backend->implementsActions(Backend::COUNT_USERS)) {
-				/** @var ICountUsersBackend|IUserBackend $backend */
-				$backendUsers = $backend->countUsers();
-				if ($backendUsers !== false) {
-					if ($backend instanceof IUserBackend) {
-						$name = $backend->getBackendName();
-					} else {
-						$name = get_class($backend);
-					}
-					if (isset($userCountStatistics[$name])) {
-						$userCountStatistics[$name] += $backendUsers;
-					} else {
-						$userCountStatistics[$name] = $backendUsers;
-					}
-				}
-			}
-		}
-		return $userCountStatistics;
-	}
-
-	public function countUsersTotal(int $limit = 0, bool $onlyMappedUsers = false): int|false {
-		$userCount = false;
-
-		foreach ($this->backends as $backend) {
-			if ($onlyMappedUsers && $backend instanceof ICountMappedUsersBackend) {
-				$backendUsers = $backend->countMappedUsers();
-			} elseif ($backend instanceof ILimitAwareCountUsersBackend) {
-				$backendUsers = $backend->countUsers($limit);
-			} elseif ($backend instanceof ICountUsersBackend || $backend->implementsActions(Backend::COUNT_USERS)) {
-				/** @var ICountUsersBackend $backend */
-				$backendUsers = $backend->countUsers();
-			} else {
-				$this->logger->debug('Skip backend for user count: ' . get_class($backend));
-				continue;
-			}
-			if ($backendUsers !== false) {
-				$userCount = (int)$userCount + $backendUsers;
-				if ($limit > 0) {
-					if ($userCount >= $limit) {
-						break;
-					}
-					$limit -= $userCount;
-				}
-			} else {
-				$this->logger->warning('Can not determine user count for ' . get_class($backend));
-			}
-		}
-		return $userCount;
-	}
-
-	/**
-	 * returns how many users per backend exist in the requested groups (if supported by backend)
-	 *
-	 * @param IGroup[] $groups an array of groups to search in
-	 * @param int $limit limit to stop counting
-	 * @return array{int,int} total number of users, and number of disabled users in the given groups, below $limit. If limit is reached, -1 is returned for number of disabled users
-	 */
-	public function countUsersAndDisabledUsersOfGroups(array $groups, int $limit): array {
-		$users = [];
-		$disabled = [];
-		foreach ($groups as $group) {
-			foreach ($group->getUsers() as $user) {
-				$users[$user->getUID()] = 1;
-				if (!$user->isEnabled()) {
-					$disabled[$user->getUID()] = 1;
-				}
-				if (count($users) >= $limit) {
-					return [count($users),-1];
-				}
-			}
-		}
-		return [count($users),count($disabled)];
-	}
-
-	/**
-	 * The callback is executed for each user on each backend.
-	 * If the callback returns false no further users will be retrieved.
-	 *
-	 * @psalm-param \Closure(\OCP\IUser):?bool $callback
-	 * @param string $search
-	 * @param boolean $onlySeen when true only users that have a lastLogin entry
-	 *                          in the preferences table will be affected
-	 * @since 9.0.0
-	 */
-	public function callForAllUsers(\Closure $callback, $search = '', $onlySeen = false) {
-		if ($onlySeen) {
-			$this->callForSeenUsers($callback);
-		} else {
-			foreach ($this->getBackends() as $backend) {
-				$limit = 500;
-				$offset = 0;
-				do {
-					$users = $backend->getUsers($search, $limit, $offset);
-					foreach ($users as $uid) {
-						if (!$backend->userExists($uid)) {
-							continue;
-						}
-						$user = $this->getUserObject($uid, $backend, false);
-						$return = $callback($user);
-						if ($return === false) {
-							break;
-						}
-					}
-					$offset += $limit;
-				} while (count($users) >= $limit);
-			}
-		}
-	}
-
-	/**
-	 * returns how many users are disabled
-	 *
-	 * @return int
-	 * @since 12.0.0
-	 */
-	public function countDisabledUsers(): int {
-		$queryBuilder = \OC::$server->getDatabaseConnection()->getQueryBuilder();
-		$queryBuilder->select($queryBuilder->func()->count('*'))
-			->from('preferences')
-			->where($queryBuilder->expr()->eq('appid', $queryBuilder->createNamedParameter('core')))
-			->andWhere($queryBuilder->expr()->eq('configkey', $queryBuilder->createNamedParameter('enabled')))
-			->andWhere($queryBuilder->expr()->eq('configvalue', $queryBuilder->createNamedParameter('false'), IQueryBuilder::PARAM_STR));
-
-
-		$result = $queryBuilder->executeQuery();
-		$count = $result->fetchOne();
-		$result->closeCursor();
-
-		if ($count !== false) {
-			$count = (int)$count;
-		} else {
-			$count = 0;
-		}
-
-		return $count;
-	}
-
-	/**
-	 * returns how many users have logged in once
-	 *
-	 * @return int
-	 * @since 11.0.0
-	 */
-	public function countSeenUsers() {
-		$queryBuilder = \OC::$server->getDatabaseConnection()->getQueryBuilder();
-		$queryBuilder->select($queryBuilder->func()->count('*'))
-			->from('preferences')
-			->where($queryBuilder->expr()->eq('appid', $queryBuilder->createNamedParameter('login')))
-			->andWhere($queryBuilder->expr()->eq('configkey', $queryBuilder->createNamedParameter('lastLogin')));
-
-		$query = $queryBuilder->executeQuery();
-
-		$result = (int)$query->fetchOne();
-		$query->closeCursor();
-
-		return $result;
-	}
-
-	public function callForSeenUsers(\Closure $callback) {
-		$users = $this->getSeenUsers();
-		foreach ($users as $user) {
-			$return = $callback($user);
-			if ($return === false) {
-				return;
-			}
-		}
-	}
-
-	/**
-	 * Getting all userIds that have a lastLogin value requires checking the
-	 * value in php because on oracle you cannot use a clob in a where clause,
-	 * preventing us from doing a not null or length(value) > 0 check.
-	 *
-	 * @param int $limit
-	 * @param int $offset
-	 * @return string[] with user ids
-	 */
-	private function getSeenUserIds($limit = null, $offset = null) {
-		$queryBuilder = \OC::$server->getDatabaseConnection()->getQueryBuilder();
-		$queryBuilder->select(['userid'])
-			->from('preferences')
-			->where($queryBuilder->expr()->eq(
-				'appid', $queryBuilder->createNamedParameter('login'))
-			)
-			->andWhere($queryBuilder->expr()->eq(
-				'configkey', $queryBuilder->createNamedParameter('lastLogin'))
-			)
-			->andWhere($queryBuilder->expr()->isNotNull('configvalue')
-			);
-
-		if ($limit !== null) {
-			$queryBuilder->setMaxResults($limit);
-		}
-		if ($offset !== null) {
-			$queryBuilder->setFirstResult($offset);
-		}
-		$query = $queryBuilder->executeQuery();
-		$result = [];
-
-		while ($row = $query->fetch()) {
-			$result[] = $row['userid'];
-		}
-
-		$query->closeCursor();
-
-		return $result;
-	}
-
-	/**
-	 * @param string $email
-	 * @return IUser[]
-	 * @since 9.1.0
-	 */
-	public function getByEmail($email) {
-		// looking for 'email' only (and not primary_mail) is intentional
-		$userIds = $this->config->getUsersForUserValueCaseInsensitive('settings', 'email', $email);
-
-		$users = array_map(function ($uid) {
-			return $this->get($uid);
-		}, $userIds);
-
-		return array_values(array_filter($users, function ($u) {
-			return ($u instanceof IUser);
-		}));
-	}
-
-	/**
-	 * @param string $uid
-	 * @param bool $checkDataDirectory
-	 * @throws \InvalidArgumentException Message is an already translated string with a reason why the id is not valid
-	 * @since 26.0.0
-	 */
-	public function validateUserId(string $uid, bool $checkDataDirectory = false): void {
-		$l = Server::get(IFactory::class)->get('lib');
-
-		// Check the ID for bad characters
-		// Allowed are: "a-z", "A-Z", "0-9", spaces and "_.@-'"
-		if (preg_match('/[^a-zA-Z0-9 _.@\-\']/', $uid)) {
-			throw new \InvalidArgumentException($l->t('Only the following characters are allowed in an Login:'
-				. ' "a-z", "A-Z", "0-9", spaces and "_.@-\'"'));
-		}
-
-		// No empty user ID
-		if (trim($uid) === '') {
-			throw new \InvalidArgumentException($l->t('A valid Login must be provided'));
-		}
-
-		// No whitespace at the beginning or at the end
-		if (trim($uid) !== $uid) {
-			throw new \InvalidArgumentException($l->t('Login contains whitespace at the beginning or at the end'));
-		}
-
-		// User ID only consists of 1 or 2 dots (directory traversal)
-		if ($uid === '.' || $uid === '..') {
-			throw new \InvalidArgumentException($l->t('Login must not consist of dots only'));
-		}
-
-		// User ID is too long
-		if (strlen($uid) > IUser::MAX_USERID_LENGTH) {
-			// TRANSLATORS User ID is too long
-			throw new \InvalidArgumentException($l->t('Username is too long'));
-		}
-
-		if (!$this->verifyUid($uid, $checkDataDirectory)) {
-			throw new \InvalidArgumentException($l->t('Login is invalid because files already exist for this user'));
-		}
-	}
-
-	/**
-	 * Gets the list of user ids sorted by lastLogin, from most recent to least recent
-	 *
-	 * @param int|null $limit how many users to fetch (default: 25, max: 100)
-	 * @param int $offset from which offset to fetch
-	 * @param string $search search users based on search params
-	 * @return list<string> list of user IDs
-	 */
-	public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array {
-		// We can't load all users who already logged in
-		$limit = min(100, $limit ?: 25);
-
-		$connection = \OC::$server->getDatabaseConnection();
-		$queryBuilder = $connection->getQueryBuilder();
-		$queryBuilder->select('pref_login.userid')
-			->from('preferences', 'pref_login')
-			->where($queryBuilder->expr()->eq('pref_login.appid', $queryBuilder->expr()->literal('login')))
-			->andWhere($queryBuilder->expr()->eq('pref_login.configkey', $queryBuilder->expr()->literal('lastLogin')))
-			->setFirstResult($offset)
-			->setMaxResults($limit)
-		;
-
-		// Oracle don't want to run ORDER BY on CLOB column
-		$loginOrder = $connection->getDatabasePlatform() instanceof OraclePlatform
-			? $queryBuilder->expr()->castColumn('pref_login.configvalue', IQueryBuilder::PARAM_INT)
-			: 'pref_login.configvalue';
-		$queryBuilder
-			->orderBy($loginOrder, 'DESC')
-			->addOrderBy($queryBuilder->func()->lower('pref_login.userid'), 'ASC');
-
-		if ($search !== '') {
-			$displayNameMatches = $this->searchDisplayName($search);
-			$matchedUids = array_map(static fn (IUser $u): string => $u->getUID(), $displayNameMatches);
-
-			$queryBuilder
-				->leftJoin('pref_login', 'preferences', 'pref_email', $queryBuilder->expr()->andX(
-					$queryBuilder->expr()->eq('pref_login.userid', 'pref_email.userid'),
-					$queryBuilder->expr()->eq('pref_email.appid', $queryBuilder->expr()->literal('settings')),
-					$queryBuilder->expr()->eq('pref_email.configkey', $queryBuilder->expr()->literal('email')),
-				))
-				->andWhere($queryBuilder->expr()->orX(
-					$queryBuilder->expr()->in('pref_login.userid', $queryBuilder->createNamedParameter($matchedUids, IQueryBuilder::PARAM_STR_ARRAY)),
-				));
-		}
-
-		/** @var list<string> */
-		$list = $queryBuilder->executeQuery()->fetchAll(\PDO::FETCH_COLUMN);
-
-		return $list;
-	}
-
-	private function verifyUid(string $uid, bool $checkDataDirectory = false): bool {
-		$appdata = 'appdata_' . $this->config->getSystemValueString('instanceid');
-
-		if (\in_array($uid, [
-			'.htaccess',
-			'files_external',
-			'__groupfolders',
-			'.ncdata',
-			'owncloud.log',
-			'nextcloud.log',
-			'updater.log',
-			'audit.log',
-			$appdata], true)) {
-			return false;
-		}
-
-		if (!$checkDataDirectory) {
-			return true;
-		}
-
-		$dataDirectory = $this->config->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data');
-
-		return !file_exists(rtrim($dataDirectory, '/') . '/' . $uid);
-	}
-
-	public function getDisplayNameCache(): DisplayNameCache {
-		return $this->displayNameCache;
-	}
-
-	public function getSeenUsers(int $offset = 0, ?int $limit = null): \Iterator {
-		$maxBatchSize = 1000;
-
-		do {
-			if ($limit !== null) {
-				$batchSize = min($limit, $maxBatchSize);
-				$limit -= $batchSize;
-			} else {
-				$batchSize = $maxBatchSize;
-			}
-
-			$userIds = $this->getSeenUserIds($batchSize, $offset);
-			$offset += $batchSize;
-
-			foreach ($userIds as $userId) {
-				foreach ($this->backends as $backend) {
-					if ($backend->userExists($userId)) {
-						$user = new LazyUser($userId, $this, null, $backend);
-						yield $user;
-						break;
-					}
-				}
-			}
-		} while (count($userIds) === $batchSize && $limit !== 0);
-	}
+    /**
+     * @var UserInterface[] $backends
+     */
+    private array $backends = [];
+
+    /**
+     * @var array<string,\OC\User\User> $cachedUsers
+     */
+    private array $cachedUsers = [];
+
+    private ICache $cache;
+
+    private DisplayNameCache $displayNameCache;
+
+    public function __construct(
+        private IConfig $config,
+        ICacheFactory $cacheFactory,
+        private IEventDispatcher $eventDispatcher,
+        private LoggerInterface $logger,
+    ) {
+        $this->cache = new WithLocalCache($cacheFactory->createDistributed('user_backend_map'));
+        $this->listen('\OC\User', 'postDelete', function (IUser $user): void {
+            unset($this->cachedUsers[$user->getUID()]);
+        });
+        $this->displayNameCache = new DisplayNameCache($cacheFactory, $this);
+    }
+
+    /**
+     * Get the active backends
+     * @return UserInterface[]
+     */
+    public function getBackends(): array {
+        return $this->backends;
+    }
+
+    public function registerBackend(UserInterface $backend): void {
+        $this->backends[] = $backend;
+    }
+
+    public function removeBackend(UserInterface $backend): void {
+        $this->cachedUsers = [];
+        if (($i = array_search($backend, $this->backends)) !== false) {
+            unset($this->backends[$i]);
+        }
+    }
+
+    public function clearBackends(): void {
+        $this->cachedUsers = [];
+        $this->backends = [];
+    }
+
+    /**
+     * get a user by user id
+     *
+     * @param string $uid
+     * @return \OC\User\User|null Either the user or null if the specified user does not exist
+     */
+    public function get($uid) {
+        if (is_null($uid) || $uid === '' || $uid === false) {
+            return null;
+        }
+        if (isset($this->cachedUsers[$uid])) { //check the cache first to prevent having to loop over the backends
+            return $this->cachedUsers[$uid];
+        }
+
+        if (strlen($uid) > IUser::MAX_USERID_LENGTH) {
+            return null;
+        }
+
+        $cachedBackend = $this->cache->get(sha1($uid));
+        if ($cachedBackend !== null && isset($this->backends[$cachedBackend])) {
+            // Cache has the info of the user backend already, so ask that one directly
+            $backend = $this->backends[$cachedBackend];
+            if ($backend->userExists($uid)) {
+                return $this->getUserObject($uid, $backend);
+            }
+        }
+
+        foreach ($this->backends as $i => $backend) {
+            if ($i === $cachedBackend) {
+                // Tried that one already
+                continue;
+            }
+
+            if ($backend->userExists($uid)) {
+                // Hash $uid to ensure that only valid characters are used for the cache key
+                $this->cache->set(sha1($uid), $i, 300);
+                return $this->getUserObject($uid, $backend);
+            }
+        }
+        return null;
+    }
+
+    public function getDisplayName(string $uid): ?string {
+        return $this->displayNameCache->getDisplayName($uid);
+    }
+
+    /**
+     * get or construct the user object
+     *
+     * @param string $uid
+     * @param \OCP\UserInterface $backend
+     * @param bool $cacheUser If false the newly created user object will not be cached
+     * @return \OC\User\User
+     */
+    public function getUserObject($uid, $backend, $cacheUser = true) {
+        if ($backend instanceof IGetRealUIDBackend) {
+            $uid = $backend->getRealUID($uid);
+        }
+
+        if (isset($this->cachedUsers[$uid])) {
+            return $this->cachedUsers[$uid];
+        }
+
+        $user = new User($uid, $backend, $this->eventDispatcher, $this, $this->config);
+        if ($cacheUser) {
+            $this->cachedUsers[$uid] = $user;
+        }
+        return $user;
+    }
+
+    /**
+     * check if a user exists
+     *
+     * @param string $uid
+     * @return bool
+     */
+    public function userExists($uid) {
+        if (strlen($uid) > IUser::MAX_USERID_LENGTH) {
+            return false;
+        }
+
+        $user = $this->get($uid);
+        return ($user !== null);
+    }
+
+    /**
+     * Check if the password is valid for the user
+     *
+     * @param string $loginName
+     * @param string $password
+     * @return IUser|false the User object on success, false otherwise
+     */
+    public function checkPassword($loginName, $password) {
+        $result = $this->checkPasswordNoLogging($loginName, $password);
+
+        if ($result === false) {
+            $this->logger->warning('Login failed: \'' . $loginName . '\' (Remote IP: \'' . \OC::$server->getRequest()->getRemoteAddress() . '\')', ['app' => 'core']);
+        }
+
+        return $result;
+    }
+
+    /**
+     * Check if the password is valid for the user
+     *
+     * @internal
+     * @param string $loginName
+     * @param string $password
+     * @return IUser|false the User object on success, false otherwise
+     */
+    public function checkPasswordNoLogging($loginName, $password) {
+        $loginName = str_replace("\0", '', $loginName);
+        $password = str_replace("\0", '', $password);
+
+        $cachedBackend = $this->cache->get($loginName);
+        if ($cachedBackend !== null && isset($this->backends[$cachedBackend])) {
+            $backends = [$this->backends[$cachedBackend]];
+        } else {
+            $backends = $this->backends;
+        }
+        foreach ($backends as $backend) {
+            if ($backend instanceof ICheckPasswordBackend || $backend->implementsActions(Backend::CHECK_PASSWORD)) {
+                /** @var ICheckPasswordBackend $backend */
+                $uid = $backend->checkPassword($loginName, $password);
+                if ($uid !== false) {
+                    return $this->getUserObject($uid, $backend);
+                }
+            }
+        }
+
+        // since http basic auth doesn't provide a standard way of handling non ascii password we allow password to be urlencoded
+        // we only do this decoding after using the plain password fails to maintain compatibility with any password that happens
+        // to contain urlencoded patterns by "accident".
+        $password = urldecode($password);
+
+        foreach ($backends as $backend) {
+            if ($backend instanceof ICheckPasswordBackend || $backend->implementsActions(Backend::CHECK_PASSWORD)) {
+                /** @var ICheckPasswordBackend|UserInterface $backend */
+                $uid = $backend->checkPassword($loginName, $password);
+                if ($uid !== false) {
+                    return $this->getUserObject($uid, $backend);
+                }
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Search by user id
+     *
+     * @param string $pattern
+     * @param int $limit
+     * @param int $offset
+     * @return IUser[]
+     * @deprecated 27.0.0, use searchDisplayName instead
+     */
+    public function search($pattern, $limit = null, $offset = null) {
+        $users = [];
+        foreach ($this->backends as $backend) {
+            $backendUsers = $backend->getUsers($pattern, $limit, $offset);
+            if (is_array($backendUsers)) {
+                foreach ($backendUsers as $uid) {
+                    $users[$uid] = new LazyUser($uid, $this, null, $backend);
+                }
+            }
+        }
+
+        uasort($users, function (IUser $a, IUser $b) {
+            return strcasecmp($a->getUID(), $b->getUID());
+        });
+        return $users;
+    }
+
+    /**
+     * Search by displayName
+     *
+     * @param string $pattern
+     * @param int $limit
+     * @param int $offset
+     * @return IUser[]
+     */
+    public function searchDisplayName($pattern, $limit = null, $offset = null) {
+        $users = [];
+        foreach ($this->backends as $backend) {
+            $backendUsers = $backend->getDisplayNames($pattern, $limit, $offset);
+            if (is_array($backendUsers)) {
+                foreach ($backendUsers as $uid => $displayName) {
+                    $users[] = new LazyUser($uid, $this, $displayName, $backend);
+                }
+            }
+        }
+
+        usort($users, function (IUser $a, IUser $b) {
+            return strcasecmp($a->getDisplayName(), $b->getDisplayName());
+        });
+        return $users;
+    }
+
+    /**
+     * @return IUser[]
+     */
+    public function getDisabledUsers(?int $limit = null, int $offset = 0, string $search = ''): array {
+        $users = $this->config->getUsersForUserValue('core', 'enabled', 'false');
+        $users = array_combine(
+            $users,
+            array_map(
+                fn (string $uid): IUser => new LazyUser($uid, $this),
+                $users
+            )
+        );
+        if ($search !== '') {
+            $users = array_filter(
+                $users,
+                function (IUser $user) use ($search): bool {
+                    try {
+                        return mb_stripos($user->getUID(), $search) !== false
+                        || mb_stripos($user->getDisplayName(), $search) !== false
+                        || mb_stripos($user->getEMailAddress() ?? '', $search) !== false;
+                    } catch (NoUserException $ex) {
+                        $this->logger->error('Error while filtering disabled users', ['exception' => $ex, 'userUID' => $user->getUID()]);
+                        return false;
+                    }
+                });
+        }
+
+        $tempLimit = ($limit === null ? null : $limit + $offset);
+        foreach ($this->backends as $backend) {
+            if (($tempLimit !== null) && (count($users) >= $tempLimit)) {
+                break;
+            }
+            if ($backend instanceof IProvideEnabledStateBackend) {
+                $backendUsers = $backend->getDisabledUserList(($tempLimit === null ? null : $tempLimit - count($users)), 0, $search);
+                foreach ($backendUsers as $uid) {
+                    $users[$uid] = new LazyUser($uid, $this, null, $backend);
+                }
+            }
+        }
+
+        return array_slice($users, $offset, $limit);
+    }
+
+    /**
+     * Search known users (from phonebook sync) by displayName
+     *
+     * @param string $searcher
+     * @param string $pattern
+     * @param int|null $limit
+     * @param int|null $offset
+     * @return IUser[]
+     */
+    public function searchKnownUsersByDisplayName(string $searcher, string $pattern, ?int $limit = null, ?int $offset = null): array {
+        $users = [];
+        foreach ($this->backends as $backend) {
+            if ($backend instanceof ISearchKnownUsersBackend) {
+                $backendUsers = $backend->searchKnownUsersByDisplayName($searcher, $pattern, $limit, $offset);
+            } else {
+                // Better than nothing, but filtering after pagination can remove lots of results.
+                $backendUsers = $backend->getDisplayNames($pattern, $limit, $offset);
+            }
+            if (is_array($backendUsers)) {
+                foreach ($backendUsers as $uid => $displayName) {
+                    $users[] = $this->getUserObject($uid, $backend);
+                }
+            }
+        }
+
+        usort($users, function ($a, $b) {
+            /**
+             * @var IUser $a
+             * @var IUser $b
+             */
+            return strcasecmp($a->getDisplayName(), $b->getDisplayName());
+        });
+        return $users;
+    }
+
+    /**
+     * @param string $uid
+     * @param string $password
+     * @return false|IUser the created user or false
+     * @throws \InvalidArgumentException
+     * @throws HintException
+     */
+    public function createUser($uid, $password) {
+        // DI injection is not used here as IRegistry needs the user manager itself for user count and thus it would create a cyclic dependency
+        /** @var IAssertion $assertion */
+        $assertion = \OC::$server->get(IAssertion::class);
+        $assertion->createUserIsLegit();
+
+        $localBackends = [];
+        foreach ($this->backends as $backend) {
+            if ($backend instanceof Database) {
+                // First check if there is another user backend
+                $localBackends[] = $backend;
+                continue;
+            }
+
+            if ($backend->implementsActions(Backend::CREATE_USER)) {
+                return $this->createUserFromBackend($uid, $password, $backend);
+            }
+        }
+
+        foreach ($localBackends as $backend) {
+            if ($backend->implementsActions(Backend::CREATE_USER)) {
+                return $this->createUserFromBackend($uid, $password, $backend);
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * @param string $uid
+     * @param string $password
+     * @param UserInterface $backend
+     * @return IUser|false
+     * @throws \InvalidArgumentException
+     */
+    public function createUserFromBackend($uid, $password, UserInterface $backend) {
+        $l = \OCP\Util::getL10N('lib');
+
+        $this->validateUserId($uid, true);
+
+        // No empty password
+        if (trim($password) === '') {
+            throw new \InvalidArgumentException($l->t('A valid password must be provided'));
+        }
+
+        // Check if user already exists
+        if ($this->userExists($uid)) {
+            throw new \InvalidArgumentException($l->t('The Login is already being used'));
+        }
+
+        /** @deprecated 21.0.0 use BeforeUserCreatedEvent event with the IEventDispatcher instead */
+        $this->emit('\OC\User', 'preCreateUser', [$uid, $password]);
+        $this->eventDispatcher->dispatchTyped(new BeforeUserCreatedEvent($uid, $password));
+        $state = $backend->createUser($uid, $password);
+        if ($state === false) {
+            throw new \InvalidArgumentException($l->t('Could not create account'));
+        }
+        $user = $this->getUserObject($uid, $backend);
+        if ($user instanceof IUser) {
+            /** @deprecated 21.0.0 use UserCreatedEvent event with the IEventDispatcher instead */
+            $this->emit('\OC\User', 'postCreateUser', [$user, $password]);
+            $this->eventDispatcher->dispatchTyped(new UserCreatedEvent($user, $password));
+            return $user;
+        }
+        return false;
+    }
+
+    /**
+     * returns how many users per backend exist (if supported by backend)
+     *
+     * @param boolean $hasLoggedIn when true only users that have a lastLogin
+     *                             entry in the preferences table will be affected
+     * @return array<string, int> an array of backend class as key and count number as value
+     */
+    public function countUsers() {
+        $userCountStatistics = [];
+        foreach ($this->backends as $backend) {
+            if ($backend instanceof ICountUsersBackend || $backend->implementsActions(Backend::COUNT_USERS)) {
+                /** @var ICountUsersBackend|IUserBackend $backend */
+                $backendUsers = $backend->countUsers();
+                if ($backendUsers !== false) {
+                    if ($backend instanceof IUserBackend) {
+                        $name = $backend->getBackendName();
+                    } else {
+                        $name = get_class($backend);
+                    }
+                    if (isset($userCountStatistics[$name])) {
+                        $userCountStatistics[$name] += $backendUsers;
+                    } else {
+                        $userCountStatistics[$name] = $backendUsers;
+                    }
+                }
+            }
+        }
+        return $userCountStatistics;
+    }
+
+    public function countUsersTotal(int $limit = 0, bool $onlyMappedUsers = false): int|false {
+        $userCount = false;
+
+        foreach ($this->backends as $backend) {
+            if ($onlyMappedUsers && $backend instanceof ICountMappedUsersBackend) {
+                $backendUsers = $backend->countMappedUsers();
+            } elseif ($backend instanceof ILimitAwareCountUsersBackend) {
+                $backendUsers = $backend->countUsers($limit);
+            } elseif ($backend instanceof ICountUsersBackend || $backend->implementsActions(Backend::COUNT_USERS)) {
+                /** @var ICountUsersBackend $backend */
+                $backendUsers = $backend->countUsers();
+            } else {
+                $this->logger->debug('Skip backend for user count: ' . get_class($backend));
+                continue;
+            }
+            if ($backendUsers !== false) {
+                $userCount = (int)$userCount + $backendUsers;
+                if ($limit > 0) {
+                    if ($userCount >= $limit) {
+                        break;
+                    }
+                    $limit -= $userCount;
+                }
+            } else {
+                $this->logger->warning('Can not determine user count for ' . get_class($backend));
+            }
+        }
+        return $userCount;
+    }
+
+    /**
+     * returns how many users per backend exist in the requested groups (if supported by backend)
+     *
+     * @param IGroup[] $groups an array of groups to search in
+     * @param int $limit limit to stop counting
+     * @return array{int,int} total number of users, and number of disabled users in the given groups, below $limit. If limit is reached, -1 is returned for number of disabled users
+     */
+    public function countUsersAndDisabledUsersOfGroups(array $groups, int $limit): array {
+        $users = [];
+        $disabled = [];
+        foreach ($groups as $group) {
+            foreach ($group->getUsers() as $user) {
+                $users[$user->getUID()] = 1;
+                if (!$user->isEnabled()) {
+                    $disabled[$user->getUID()] = 1;
+                }
+                if (count($users) >= $limit) {
+                    return [count($users),-1];
+                }
+            }
+        }
+        return [count($users),count($disabled)];
+    }
+
+    /**
+     * The callback is executed for each user on each backend.
+     * If the callback returns false no further users will be retrieved.
+     *
+     * @psalm-param \Closure(\OCP\IUser):?bool $callback
+     * @param string $search
+     * @param boolean $onlySeen when true only users that have a lastLogin entry
+     *                          in the preferences table will be affected
+     * @since 9.0.0
+     */
+    public function callForAllUsers(\Closure $callback, $search = '', $onlySeen = false) {
+        if ($onlySeen) {
+            $this->callForSeenUsers($callback);
+        } else {
+            foreach ($this->getBackends() as $backend) {
+                $limit = 500;
+                $offset = 0;
+                do {
+                    $users = $backend->getUsers($search, $limit, $offset);
+                    foreach ($users as $uid) {
+                        if (!$backend->userExists($uid)) {
+                            continue;
+                        }
+                        $user = $this->getUserObject($uid, $backend, false);
+                        $return = $callback($user);
+                        if ($return === false) {
+                            break;
+                        }
+                    }
+                    $offset += $limit;
+                } while (count($users) >= $limit);
+            }
+        }
+    }
+
+    /**
+     * returns how many users are disabled
+     *
+     * @return int
+     * @since 12.0.0
+     */
+    public function countDisabledUsers(): int {
+        $queryBuilder = \OC::$server->getDatabaseConnection()->getQueryBuilder();
+        $queryBuilder->select($queryBuilder->func()->count('*'))
+            ->from('preferences')
+            ->where($queryBuilder->expr()->eq('appid', $queryBuilder->createNamedParameter('core')))
+            ->andWhere($queryBuilder->expr()->eq('configkey', $queryBuilder->createNamedParameter('enabled')))
+            ->andWhere($queryBuilder->expr()->eq('configvalue', $queryBuilder->createNamedParameter('false'), IQueryBuilder::PARAM_STR));
+
+
+        $result = $queryBuilder->executeQuery();
+        $count = $result->fetchOne();
+        $result->closeCursor();
+
+        if ($count !== false) {
+            $count = (int)$count;
+        } else {
+            $count = 0;
+        }
+
+        return $count;
+    }
+
+    /**
+     * returns how many users have logged in once
+     *
+     * @return int
+     * @since 11.0.0
+     */
+    public function countSeenUsers() {
+        $queryBuilder = \OC::$server->getDatabaseConnection()->getQueryBuilder();
+        $queryBuilder->select($queryBuilder->func()->count('*'))
+            ->from('preferences')
+            ->where($queryBuilder->expr()->eq('appid', $queryBuilder->createNamedParameter('login')))
+            ->andWhere($queryBuilder->expr()->eq('configkey', $queryBuilder->createNamedParameter('lastLogin')));
+
+        $query = $queryBuilder->executeQuery();
+
+        $result = (int)$query->fetchOne();
+        $query->closeCursor();
+
+        return $result;
+    }
+
+    public function callForSeenUsers(\Closure $callback) {
+        $users = $this->getSeenUsers();
+        foreach ($users as $user) {
+            $return = $callback($user);
+            if ($return === false) {
+                return;
+            }
+        }
+    }
+
+    /**
+     * Getting all userIds that have a lastLogin value requires checking the
+     * value in php because on oracle you cannot use a clob in a where clause,
+     * preventing us from doing a not null or length(value) > 0 check.
+     *
+     * @param int $limit
+     * @param int $offset
+     * @return string[] with user ids
+     */
+    private function getSeenUserIds($limit = null, $offset = null) {
+        $queryBuilder = \OC::$server->getDatabaseConnection()->getQueryBuilder();
+        $queryBuilder->select(['userid'])
+            ->from('preferences')
+            ->where($queryBuilder->expr()->eq(
+                'appid', $queryBuilder->createNamedParameter('login'))
+            )
+            ->andWhere($queryBuilder->expr()->eq(
+                'configkey', $queryBuilder->createNamedParameter('lastLogin'))
+            )
+            ->andWhere($queryBuilder->expr()->isNotNull('configvalue')
+            );
+
+        if ($limit !== null) {
+            $queryBuilder->setMaxResults($limit);
+        }
+        if ($offset !== null) {
+            $queryBuilder->setFirstResult($offset);
+        }
+        $query = $queryBuilder->executeQuery();
+        $result = [];
+
+        while ($row = $query->fetch()) {
+            $result[] = $row['userid'];
+        }
+
+        $query->closeCursor();
+
+        return $result;
+    }
+
+    /**
+     * @param string $email
+     * @return IUser[]
+     * @since 9.1.0
+     */
+    public function getByEmail($email) {
+        // looking for 'email' only (and not primary_mail) is intentional
+        $userIds = $this->config->getUsersForUserValueCaseInsensitive('settings', 'email', $email);
+
+        $users = array_map(function ($uid) {
+            return $this->get($uid);
+        }, $userIds);
+
+        return array_values(array_filter($users, function ($u) {
+            return ($u instanceof IUser);
+        }));
+    }
+
+    /**
+     * @param string $uid
+     * @param bool $checkDataDirectory
+     * @throws \InvalidArgumentException Message is an already translated string with a reason why the id is not valid
+     * @since 26.0.0
+     */
+    public function validateUserId(string $uid, bool $checkDataDirectory = false): void {
+        $l = Server::get(IFactory::class)->get('lib');
+
+        // Check the ID for bad characters
+        // Allowed are: "a-z", "A-Z", "0-9", spaces and "_.@-'"
+        if (preg_match('/[^a-zA-Z0-9 _.@\-\']/', $uid)) {
+            throw new \InvalidArgumentException($l->t('Only the following characters are allowed in an Login:'
+                . ' "a-z", "A-Z", "0-9", spaces and "_.@-\'"'));
+        }
+
+        // No empty user ID
+        if (trim($uid) === '') {
+            throw new \InvalidArgumentException($l->t('A valid Login must be provided'));
+        }
+
+        // No whitespace at the beginning or at the end
+        if (trim($uid) !== $uid) {
+            throw new \InvalidArgumentException($l->t('Login contains whitespace at the beginning or at the end'));
+        }
+
+        // User ID only consists of 1 or 2 dots (directory traversal)
+        if ($uid === '.' || $uid === '..') {
+            throw new \InvalidArgumentException($l->t('Login must not consist of dots only'));
+        }
+
+        // User ID is too long
+        if (strlen($uid) > IUser::MAX_USERID_LENGTH) {
+            // TRANSLATORS User ID is too long
+            throw new \InvalidArgumentException($l->t('Username is too long'));
+        }
+
+        if (!$this->verifyUid($uid, $checkDataDirectory)) {
+            throw new \InvalidArgumentException($l->t('Login is invalid because files already exist for this user'));
+        }
+    }
+
+    /**
+     * Gets the list of user ids sorted by lastLogin, from most recent to least recent
+     *
+     * @param int|null $limit how many users to fetch (default: 25, max: 100)
+     * @param int $offset from which offset to fetch
+     * @param string $search search users based on search params
+     * @return list<string> list of user IDs
+     */
+    public function getLastLoggedInUsers(?int $limit = null, int $offset = 0, string $search = ''): array {
+        // We can't load all users who already logged in
+        $limit = min(100, $limit ?: 25);
+
+        $connection = \OC::$server->getDatabaseConnection();
+        $queryBuilder = $connection->getQueryBuilder();
+        $queryBuilder->select('pref_login.userid')
+            ->from('preferences', 'pref_login')
+            ->where($queryBuilder->expr()->eq('pref_login.appid', $queryBuilder->expr()->literal('login')))
+            ->andWhere($queryBuilder->expr()->eq('pref_login.configkey', $queryBuilder->expr()->literal('lastLogin')))
+            ->setFirstResult($offset)
+            ->setMaxResults($limit)
+        ;
+
+        // Oracle don't want to run ORDER BY on CLOB column
+        $loginOrder = $connection->getDatabasePlatform() instanceof OraclePlatform
+            ? $queryBuilder->expr()->castColumn('pref_login.configvalue', IQueryBuilder::PARAM_INT)
+            : 'pref_login.configvalue';
+        $queryBuilder
+            ->orderBy($loginOrder, 'DESC')
+            ->addOrderBy($queryBuilder->func()->lower('pref_login.userid'), 'ASC');
+
+        if ($search !== '') {
+            $displayNameMatches = $this->searchDisplayName($search);
+            $matchedUids = array_map(static fn (IUser $u): string => $u->getUID(), $displayNameMatches);
+
+            $queryBuilder
+                ->leftJoin('pref_login', 'preferences', 'pref_email', $queryBuilder->expr()->andX(
+                    $queryBuilder->expr()->eq('pref_login.userid', 'pref_email.userid'),
+                    $queryBuilder->expr()->eq('pref_email.appid', $queryBuilder->expr()->literal('settings')),
+                    $queryBuilder->expr()->eq('pref_email.configkey', $queryBuilder->expr()->literal('email')),
+                ))
+                ->andWhere($queryBuilder->expr()->orX(
+                    $queryBuilder->expr()->in('pref_login.userid', $queryBuilder->createNamedParameter($matchedUids, IQueryBuilder::PARAM_STR_ARRAY)),
+                ));
+        }
+
+        /** @var list<string> */
+        $list = $queryBuilder->executeQuery()->fetchAll(\PDO::FETCH_COLUMN);
+
+        return $list;
+    }
+
+    private function verifyUid(string $uid, bool $checkDataDirectory = false): bool {
+        $appdata = 'appdata_' . $this->config->getSystemValueString('instanceid');
+
+        if (\in_array($uid, [
+            '.htaccess',
+            'files_external',
+            '__groupfolders',
+            '.ncdata',
+            'owncloud.log',
+            'nextcloud.log',
+            'updater.log',
+            'audit.log',
+            $appdata], true)) {
+            return false;
+        }
+
+        if (!$checkDataDirectory) {
+            return true;
+        }
+
+        $dataDirectory = $this->config->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data');
+
+        return !file_exists(rtrim($dataDirectory, '/') . '/' . $uid);
+    }
+
+    public function getDisplayNameCache(): DisplayNameCache {
+        return $this->displayNameCache;
+    }
+
+    public function getSeenUsers(int $offset = 0, ?int $limit = null): \Iterator {
+        $maxBatchSize = 1000;
+
+        do {
+            if ($limit !== null) {
+                $batchSize = min($limit, $maxBatchSize);
+                $limit -= $batchSize;
+            } else {
+                $batchSize = $maxBatchSize;
+            }
+
+            $userIds = $this->getSeenUserIds($batchSize, $offset);
+            $offset += $batchSize;
+
+            foreach ($userIds as $userId) {
+                foreach ($this->backends as $backend) {
+                    if ($backend->userExists($userId)) {
+                        $user = new LazyUser($userId, $this, null, $backend);
+                        yield $user;
+                        break;
+                    }
+                }
+            }
+        } while (count($userIds) === $batchSize && $limit !== 0);
+    }
 }

apps/files_trashbin/lib/BackgroundJob/ExpireTrash.php

Indentation +114 added lines, -114 removed lines

@@ -22,118 +22,118 @@
 use Psr\Log\LoggerInterface;
 
 class ExpireTrash extends TimedJob {
-	public const TOGGLE_CONFIG_KEY_NAME = 'background_job_expire_trash';
-	public const OFFSET_CONFIG_KEY_NAME = 'background_job_expire_trash_offset';
-	private const THIRTY_MINUTES = 30 * 60;
-	private const USER_BATCH_SIZE = 10;
-
-	public function __construct(
-		private IAppConfig $appConfig,
-		private IUserManager $userManager,
-		private Expiration $expiration,
-		private LoggerInterface $logger,
-		private SetupManager $setupManager,
-		private ILockingProvider $lockingProvider,
-		ITimeFactory $time,
-	) {
-		parent::__construct($time);
-		$this->setInterval(self::THIRTY_MINUTES);
-	}
-
-	protected function run($argument) {
-		$backgroundJob = $this->appConfig->getValueBool(Application::APP_ID, self::TOGGLE_CONFIG_KEY_NAME, true);
-		if (!$backgroundJob) {
-			return;
-		}
-
-		$maxAge = $this->expiration->getMaxAgeAsTimestamp();
-		if (!$maxAge) {
-			return;
-		}
-
-		$startTime = time();
-
-		// Process users in batches of 10, but don't run for more than 30 minutes
-		while (time() < $startTime + self::THIRTY_MINUTES) {
-			$offset = $this->getNextOffset();
-			$users = $this->userManager->getSeenUsers($offset, self::USER_BATCH_SIZE);
-			$count = 0;
-
-			foreach ($users as $user) {
-				$uid = $user->getUID();
-				$count++;
-
-				try {
-					if ($this->setupFS($user)) {
-						$dirContent = Helper::getTrashFiles('/', $uid, 'mtime');
-						Trashbin::deleteExpiredFiles($dirContent, $uid);
-					}
-				} catch (\Throwable $e) {
-					$this->logger->error('Error while expiring trashbin for user ' . $uid, ['exception' => $e]);
-				} finally {
-					$this->setupManager->tearDown();
-				}
-			}
-
-			// If the last batch was not full it means that we reached the end of the user list.
-			if ($count < self::USER_BATCH_SIZE) {
-				$this->resetOffset();
-			}
-		}
-	}
-
-	/**
-	 * Act on behalf on trash item owner
-	 */
-	protected function setupFS(IUser $user): bool {
-		$this->setupManager->setupForUser($user);
-
-		// Check if this user has a trashbin directory
-		$view = new View('/' . $user->getUID());
-		if (!$view->is_dir('/files_trashbin/files')) {
-			return false;
-		}
-
-		return true;
-	}
-
-	private function getNextOffset(): int {
-		return $this->runMutexOperation(function () {
-			$this->appConfig->clearCache();
-
-			$offset = $this->appConfig->getValueInt(Application::APP_ID, self::OFFSET_CONFIG_KEY_NAME, 0);
-			$this->appConfig->setValueInt(Application::APP_ID, self::OFFSET_CONFIG_KEY_NAME, $offset + self::USER_BATCH_SIZE);
-
-			return $offset;
-		});
-
-	}
-
-	private function resetOffset() {
-		$this->runMutexOperation(function () {
-			$this->appConfig->setValueInt(Application::APP_ID, self::OFFSET_CONFIG_KEY_NAME, 0);
-		});
-	}
-
-	private function runMutexOperation($operation): mixed {
-		$acquired = false;
-
-		while ($acquired === false) {
-			try {
-				$this->lockingProvider->acquireLock(self::OFFSET_CONFIG_KEY_NAME, ILockingProvider::LOCK_EXCLUSIVE, 'Expire trashbin background job offset');
-				$acquired = true;
-			} catch (\OCP\Lock\LockedException $e) {
-				// wait a bit and try again
-				usleep(100000);
-			}
-		}
-
-		try {
-			$result = $operation();
-		} finally {
-			$this->lockingProvider->releaseLock(self::OFFSET_CONFIG_KEY_NAME, ILockingProvider::LOCK_EXCLUSIVE);
-		}
-
-		return $result;
-	}
+    public const TOGGLE_CONFIG_KEY_NAME = 'background_job_expire_trash';
+    public const OFFSET_CONFIG_KEY_NAME = 'background_job_expire_trash_offset';
+    private const THIRTY_MINUTES = 30 * 60;
+    private const USER_BATCH_SIZE = 10;
+
+    public function __construct(
+        private IAppConfig $appConfig,
+        private IUserManager $userManager,
+        private Expiration $expiration,
+        private LoggerInterface $logger,
+        private SetupManager $setupManager,
+        private ILockingProvider $lockingProvider,
+        ITimeFactory $time,
+    ) {
+        parent::__construct($time);
+        $this->setInterval(self::THIRTY_MINUTES);
+    }
+
+    protected function run($argument) {
+        $backgroundJob = $this->appConfig->getValueBool(Application::APP_ID, self::TOGGLE_CONFIG_KEY_NAME, true);
+        if (!$backgroundJob) {
+            return;
+        }
+
+        $maxAge = $this->expiration->getMaxAgeAsTimestamp();
+        if (!$maxAge) {
+            return;
+        }
+
+        $startTime = time();
+
+        // Process users in batches of 10, but don't run for more than 30 minutes
+        while (time() < $startTime + self::THIRTY_MINUTES) {
+            $offset = $this->getNextOffset();
+            $users = $this->userManager->getSeenUsers($offset, self::USER_BATCH_SIZE);
+            $count = 0;
+
+            foreach ($users as $user) {
+                $uid = $user->getUID();
+                $count++;
+
+                try {
+                    if ($this->setupFS($user)) {
+                        $dirContent = Helper::getTrashFiles('/', $uid, 'mtime');
+                        Trashbin::deleteExpiredFiles($dirContent, $uid);
+                    }
+                } catch (\Throwable $e) {
+                    $this->logger->error('Error while expiring trashbin for user ' . $uid, ['exception' => $e]);
+                } finally {
+                    $this->setupManager->tearDown();
+                }
+            }
+
+            // If the last batch was not full it means that we reached the end of the user list.
+            if ($count < self::USER_BATCH_SIZE) {
+                $this->resetOffset();
+            }
+        }
+    }
+
+    /**
+     * Act on behalf on trash item owner
+     */
+    protected function setupFS(IUser $user): bool {
+        $this->setupManager->setupForUser($user);
+
+        // Check if this user has a trashbin directory
+        $view = new View('/' . $user->getUID());
+        if (!$view->is_dir('/files_trashbin/files')) {
+            return false;
+        }
+
+        return true;
+    }
+
+    private function getNextOffset(): int {
+        return $this->runMutexOperation(function () {
+            $this->appConfig->clearCache();
+
+            $offset = $this->appConfig->getValueInt(Application::APP_ID, self::OFFSET_CONFIG_KEY_NAME, 0);
+            $this->appConfig->setValueInt(Application::APP_ID, self::OFFSET_CONFIG_KEY_NAME, $offset + self::USER_BATCH_SIZE);
+
+            return $offset;
+        });
+
+    }
+
+    private function resetOffset() {
+        $this->runMutexOperation(function () {
+            $this->appConfig->setValueInt(Application::APP_ID, self::OFFSET_CONFIG_KEY_NAME, 0);
+        });
+    }
+
+    private function runMutexOperation($operation): mixed {
+        $acquired = false;
+
+        while ($acquired === false) {
+            try {
+                $this->lockingProvider->acquireLock(self::OFFSET_CONFIG_KEY_NAME, ILockingProvider::LOCK_EXCLUSIVE, 'Expire trashbin background job offset');
+                $acquired = true;
+            } catch (\OCP\Lock\LockedException $e) {
+                // wait a bit and try again
+                usleep(100000);
+            }
+        }
+
+        try {
+            $result = $operation();
+        } finally {
+            $this->lockingProvider->releaseLock(self::OFFSET_CONFIG_KEY_NAME, ILockingProvider::LOCK_EXCLUSIVE);
+        }
+
+        return $result;
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -69,7 +69,7 @@ 
 						Trashbin::deleteExpiredFiles($dirContent, $uid);
 					}
 				} catch (\Throwable $e) {
-					$this->logger->error('Error while expiring trashbin for user ' . $uid, ['exception' => $e]);
+					$this->logger->error('Error while expiring trashbin for user '.$uid, ['exception' => $e]);
 				} finally {
 					$this->setupManager->tearDown();
 				}
@@ -89,7 +89,7 @@ 
 		$this->setupManager->setupForUser($user);
 
 		// Check if this user has a trashbin directory
-		$view = new View('/' . $user->getUID());
+		$view = new View('/'.$user->getUID());
 		if (!$view->is_dir('/files_trashbin/files')) {
 			return false;
 		}
@@ -98,7 +98,7 @@ 
 	}
 
 	private function getNextOffset(): int {
-		return $this->runMutexOperation(function () {
+		return $this->runMutexOperation(function() {
 			$this->appConfig->clearCache();
 
 			$offset = $this->appConfig->getValueInt(Application::APP_ID, self::OFFSET_CONFIG_KEY_NAME, 0);
@@ -110,7 +110,7 @@ 
 	}
 
 	private function resetOffset() {
-		$this->runMutexOperation(function () {
+		$this->runMutexOperation(function() {
 			$this->appConfig->setValueInt(Application::APP_ID, self::OFFSET_CONFIG_KEY_NAME, 0);
 		});
 	}

apps/files_trashbin/tests/BackgroundJob/ExpireTrashTest.php

Indentation +60 added lines, -60 removed lines

@@ -23,72 +23,72 @@
 use Test\TestCase;
 
 class ExpireTrashTest extends TestCase {
-	private IAppConfig&MockObject $appConfig;
-	private IUserManager&MockObject $userManager;
-	private Expiration&MockObject $expiration;
-	private IJobList&MockObject $jobList;
-	private LoggerInterface&MockObject $logger;
-	private ITimeFactory&MockObject $time;
-	private SetupManager&MockObject $setupManager;
-	private ILockingProvider&MockObject $lockingProvider;
+    private IAppConfig&MockObject $appConfig;
+    private IUserManager&MockObject $userManager;
+    private Expiration&MockObject $expiration;
+    private IJobList&MockObject $jobList;
+    private LoggerInterface&MockObject $logger;
+    private ITimeFactory&MockObject $time;
+    private SetupManager&MockObject $setupManager;
+    private ILockingProvider&MockObject $lockingProvider;
 
-	protected function setUp(): void {
-		parent::setUp();
+    protected function setUp(): void {
+        parent::setUp();
 
-		$this->appConfig = $this->createMock(IAppConfig::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->expiration = $this->createMock(Expiration::class);
-		$this->jobList = $this->createMock(IJobList::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->setupManager = $this->createMock(SetupManager::class);
-		$this->lockingProvider = $this->createMock(ILockingProvider::class);
+        $this->appConfig = $this->createMock(IAppConfig::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->expiration = $this->createMock(Expiration::class);
+        $this->jobList = $this->createMock(IJobList::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->setupManager = $this->createMock(SetupManager::class);
+        $this->lockingProvider = $this->createMock(ILockingProvider::class);
 
-		$this->time = $this->createMock(ITimeFactory::class);
-		$this->time->method('getTime')
-			->willReturn(999999999);
+        $this->time = $this->createMock(ITimeFactory::class);
+        $this->time->method('getTime')
+            ->willReturn(999999999);
 
-		$this->jobList->expects($this->once())
-			->method('setLastRun');
-		$this->jobList->expects($this->once())
-			->method('setExecutionTime');
-	}
+        $this->jobList->expects($this->once())
+            ->method('setLastRun');
+        $this->jobList->expects($this->once())
+            ->method('setExecutionTime');
+    }
 
-	public function testConstructAndRun(): void {
-		$this->appConfig->method('getValueBool')
-			->with(Application::APP_ID, ExpireTrash::TOGGLE_CONFIG_KEY_NAME, true)
-			->willReturn(true);
-		$this->appConfig->method('getValueInt')
-			->with(Application::APP_ID, ExpireTrash::OFFSET_CONFIG_KEY_NAME, 0)
-			->willReturn(0);
+    public function testConstructAndRun(): void {
+        $this->appConfig->method('getValueBool')
+            ->with(Application::APP_ID, ExpireTrash::TOGGLE_CONFIG_KEY_NAME, true)
+            ->willReturn(true);
+        $this->appConfig->method('getValueInt')
+            ->with(Application::APP_ID, ExpireTrash::OFFSET_CONFIG_KEY_NAME, 0)
+            ->willReturn(0);
 
-		$job = new ExpireTrash(
-			$this->appConfig,
-			$this->userManager,
-			$this->expiration,
-			$this->logger,
-			$this->setupManager,
-			$this->lockingProvider,
-			$this->time,
-		);
-		$job->start($this->jobList);
-	}
+        $job = new ExpireTrash(
+            $this->appConfig,
+            $this->userManager,
+            $this->expiration,
+            $this->logger,
+            $this->setupManager,
+            $this->lockingProvider,
+            $this->time,
+        );
+        $job->start($this->jobList);
+    }
 
-	public function testBackgroundJobDeactivated(): void {
-		$this->appConfig->method('getValueBool')
-			->with(Application::APP_ID, ExpireTrash::TOGGLE_CONFIG_KEY_NAME, true)
-			->willReturn(false);
-		$this->expiration->expects($this->never())
-			->method('getMaxAgeAsTimestamp');
+    public function testBackgroundJobDeactivated(): void {
+        $this->appConfig->method('getValueBool')
+            ->with(Application::APP_ID, ExpireTrash::TOGGLE_CONFIG_KEY_NAME, true)
+            ->willReturn(false);
+        $this->expiration->expects($this->never())
+            ->method('getMaxAgeAsTimestamp');
 
-		$job = new ExpireTrash(
-			$this->appConfig,
-			$this->userManager,
-			$this->expiration,
-			$this->logger,
-			$this->setupManager,
-			$this->lockingProvider,
-			$this->time,
-		);
-		$job->start($this->jobList);
-	}
+        $job = new ExpireTrash(
+            $this->appConfig,
+            $this->userManager,
+            $this->expiration,
+            $this->logger,
+            $this->setupManager,
+            $this->lockingProvider,
+            $this->time,
+        );
+        $job->start($this->jobList);
+    }
 }