nextcloud / server

tests/lib/SystemTag/SystemTagManagerTest.php

Indentation +558 added lines, -558 removed lines

@@ -30,562 +30,562 @@
  * @package Test\SystemTag
  */
 class SystemTagManagerTest extends TestCase {
-	private ISystemTagManager $tagManager;
-	private IDBConnection $connection;
-	private IGroupManager $groupManager;
-	private IUserSession $userSession;
-	private IAppConfig $appConfig;
-	private IEventDispatcher $dispatcher;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->connection = Server::get(IDBConnection::class);
-
-		$this->dispatcher = $this->createMock(IEventDispatcher::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->appConfig = $this->createMock(IAppConfig::class);
-
-		$this->tagManager = new SystemTagManager(
-			$this->connection,
-			$this->groupManager,
-			$this->dispatcher,
-			$this->userSession,
-			$this->appConfig,
-		);
-		$this->pruneTagsTables();
-	}
-
-	protected function tearDown(): void {
-		$this->pruneTagsTables();
-		\OC::$CLI = true;
-		parent::tearDown();
-	}
-
-	protected function pruneTagsTables() {
-		$query = $this->connection->getQueryBuilder();
-		$query->delete(SystemTagObjectMapper::RELATION_TABLE)->execute();
-		$query->delete(SystemTagManager::TAG_TABLE)->execute();
-	}
-
-	public static function getAllTagsDataProvider(): array {
-		return [
-			[
-				// no tags at all
-				[]
-			],
-			[
-				// simple
-				[
-					['one', false, false],
-					['two', false, false],
-				]
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('getAllTagsDataProvider')]
-	public function testGetAllTags($testTags): void {
-		$testTagsById = [];
-		foreach ($testTags as $testTag) {
-			$tag = $this->tagManager->createTag($testTag[0], $testTag[1], $testTag[2]);
-			$testTagsById[$tag->getId()] = $tag;
-		}
-
-		$tagList = $this->tagManager->getAllTags();
-
-		$this->assertCount(count($testTags), $tagList);
-
-		foreach ($testTagsById as $testTagId => $testTag) {
-			$this->assertTrue(isset($tagList[$testTagId]));
-			$this->assertSameTag($tagList[$testTagId], $testTag);
-		}
-	}
-
-	public static function getAllTagsFilteredDataProvider(): array {
-		return [
-			[
-				[
-					// no tags at all
-				],
-				null,
-				null,
-				[]
-			],
-			// filter by visible only
-			[
-				// none visible
-				[
-					['one', false, false],
-					['two', false, false],
-				],
-				true,
-				null,
-				[]
-			],
-			[
-				// one visible
-				[
-					['one', true, false],
-					['two', false, false],
-				],
-				true,
-				null,
-				[
-					['one', true, false],
-				]
-			],
-			[
-				// one invisible
-				[
-					['one', true, false],
-					['two', false, false],
-				],
-				false,
-				null,
-				[
-					['two', false, false],
-				]
-			],
-			// filter by name pattern
-			[
-				[
-					['one', true, false],
-					['one_different', false, false],
-					['two', true, false],
-				],
-				null,
-				'on',
-				[
-					['one', true, false],
-					['one_different', false, false],
-				]
-			],
-			// filter by name pattern and visibility
-			[
-				// one visible
-				[
-					['one', true, false],
-					['two', true, false],
-					['one_different', false, false],
-				],
-				true,
-				'on',
-				[
-					['one', true, false],
-				]
-			],
-			// filter by name pattern in the middle
-			[
-				// one visible
-				[
-					['abcdefghi', true, false],
-					['two', true, false],
-				],
-				null,
-				'def',
-				[
-					['abcdefghi', true, false],
-				]
-			]
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('getAllTagsFilteredDataProvider')]
-	public function testGetAllTagsFiltered($testTags, $visibilityFilter, $nameSearch, $expectedResults): void {
-		foreach ($testTags as $testTag) {
-			$this->tagManager->createTag($testTag[0], $testTag[1], $testTag[2]);
-		}
-
-		$testTagsById = [];
-		foreach ($expectedResults as $expectedTag) {
-			$tag = $this->tagManager->getTag($expectedTag[0], $expectedTag[1], $expectedTag[2]);
-			$testTagsById[$tag->getId()] = $tag;
-		}
-
-		$tagList = $this->tagManager->getAllTags($visibilityFilter, $nameSearch);
-
-		$this->assertCount(count($testTagsById), $tagList);
-
-		foreach ($testTagsById as $testTagId => $testTag) {
-			$this->assertTrue(isset($tagList[$testTagId]));
-			$this->assertSameTag($tagList[$testTagId], $testTag);
-		}
-	}
-
-	public static function oneTagMultipleFlagsProvider(): array {
-		return [
-			['one', false, false],
-			['one', true, false],
-			['one', false, true],
-			['one', true, true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('oneTagMultipleFlagsProvider')]
-	public function testCreateDuplicate($name, $userVisible, $userAssignable): void {
-		$this->expectException(TagAlreadyExistsException::class);
-
-		try {
-			$this->tagManager->createTag($name, $userVisible, $userAssignable);
-		} catch (\Exception $e) {
-			$this->assertTrue(false, 'No exception thrown for the first create call');
-		}
-		$this->tagManager->createTag($name, $userVisible, $userAssignable);
-	}
-
-	public function testCreateDuplicateWithDifferentFlags(): void {
-		$this->expectException(TagAlreadyExistsException::class);
-
-		// Create a tag with specific flags
-		$this->tagManager->createTag('duplicate', true, false);
-		// Try to create a tag with the same name but different flags - should fail
-		$this->tagManager->createTag('duplicate', false, true);
-	}
-
-	public function testCreateOverlongName(): void {
-		$tag = $this->tagManager->createTag('Zona circundante do Palácio Nacional da Ajuda (Jardim das Damas, Salão de Física, Torre Sineira, Paço Velho e Jardim Botânico)', true, true);
-		$this->assertSame('Zona circundante do Palácio Nacional da Ajuda (Jardim das Damas', $tag->getName()); // 63 characters but 64 bytes due to "á"
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('oneTagMultipleFlagsProvider')]
-	public function testGetExistingTag($name, $userVisible, $userAssignable): void {
-		$tag1 = $this->tagManager->createTag($name, $userVisible, $userAssignable);
-		$tag2 = $this->tagManager->getTag($name, $userVisible, $userAssignable);
-
-		$this->assertSameTag($tag1, $tag2);
-	}
-
-	public function testGetExistingTagById(): void {
-		$tag1 = $this->tagManager->createTag('one', true, false);
-		$tag2 = $this->tagManager->createTag('two', false, true);
-
-		$tagList = $this->tagManager->getTagsByIds([$tag1->getId(), $tag2->getId()]);
-
-		$this->assertCount(2, $tagList);
-
-		$this->assertSameTag($tag1, $tagList[$tag1->getId()]);
-		$this->assertSameTag($tag2, $tagList[$tag2->getId()]);
-	}
-
-
-	public function testGetNonExistingTag(): void {
-		$this->expectException(TagNotFoundException::class);
-
-		$this->tagManager->getTag('nonexist', false, false);
-	}
-
-
-	public function testGetNonExistingTagsById(): void {
-		$this->expectException(TagNotFoundException::class);
-
-		$tag1 = $this->tagManager->createTag('one', true, false);
-		$this->tagManager->getTagsByIds([$tag1->getId(), 100, 101]);
-	}
-
-
-	public function testGetInvalidTagIdFormat(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$tag1 = $this->tagManager->createTag('one', true, false);
-		$this->tagManager->getTagsByIds([$tag1->getId() . 'suffix']);
-	}
-
-	public static function updateTagProvider(): array {
-		return [
-			[
-				// update name
-				['one', true, true, '0082c9'],
-				['two', true, true, '0082c9']
-			],
-			[
-				// update one flag
-				['one', false, true, null],
-				['one', true, true, '0082c9']
-			],
-			[
-				// update all flags
-				['one', false, false, '0082c9'],
-				['one', true, true, null]
-			],
-			[
-				// update all
-				['one', false, false, '0082c9'],
-				['two', true, true, '0082c9']
-			],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('updateTagProvider')]
-	public function testUpdateTag($tagCreate, $tagUpdated): void {
-		$tag1 = $this->tagManager->createTag(
-			$tagCreate[0],
-			$tagCreate[1],
-			$tagCreate[2],
-			$tagCreate[3],
-		);
-		$this->tagManager->updateTag(
-			$tag1->getId(),
-			$tagUpdated[0],
-			$tagUpdated[1],
-			$tagUpdated[2],
-			$tagUpdated[3],
-		);
-		$tag2 = $this->tagManager->getTag(
-			$tagUpdated[0],
-			$tagUpdated[1],
-			$tagUpdated[2],
-			$tagUpdated[3],
-		);
-
-		$this->assertEquals($tag2->getId(), $tag1->getId());
-		$this->assertEquals($tag2->getName(), $tagUpdated[0]);
-		$this->assertEquals($tag2->isUserVisible(), $tagUpdated[1]);
-		$this->assertEquals($tag2->isUserAssignable(), $tagUpdated[2]);
-		$this->assertEquals($tag2->getColor(), $tagUpdated[3]);
-
-	}
-
-	public function testUpdateTagToExistingName(): void {
-		$this->expectException(TagAlreadyExistsException::class);
-
-		// Create two different tags
-		$tag1 = $this->tagManager->createTag('first', true, true);
-		$tag2 = $this->tagManager->createTag('second', false, false);
-
-		// Try to update tag2 to have the same name as tag1 - should fail
-		$this->tagManager->updateTag(
-			$tag2->getId(),
-			'first',
-			false,
-			false,
-			null
-		);
-	}
-
-	public function testDeleteTags(): void {
-		$tag1 = $this->tagManager->createTag('one', true, false);
-		$tag2 = $this->tagManager->createTag('two', false, true);
-
-		$this->tagManager->deleteTags([$tag1->getId(), $tag2->getId()]);
-
-		$this->assertEmpty($this->tagManager->getAllTags());
-	}
-
-
-	public function testDeleteNonExistingTag(): void {
-		$this->expectException(TagNotFoundException::class);
-
-		$this->tagManager->deleteTags([100]);
-	}
-
-	public function testDeleteTagRemovesRelations(): void {
-		$tag1 = $this->tagManager->createTag('one', true, false);
-		$tag2 = $this->tagManager->createTag('two', true, true);
-
-		$tagMapper = new SystemTagObjectMapper($this->connection, $this->tagManager, $this->dispatcher);
-
-		$tagMapper->assignTags(1, 'testtype', $tag1->getId());
-		$tagMapper->assignTags(1, 'testtype', $tag2->getId());
-		$tagMapper->assignTags(2, 'testtype', $tag1->getId());
-
-		$this->tagManager->deleteTags($tag1->getId());
-
-		$tagIdMapping = $tagMapper->getTagIdsForObjects(
-			[1, 2],
-			'testtype'
-		);
-
-		$this->assertEquals([
-			1 => [$tag2->getId()],
-			2 => [],
-		], $tagIdMapping);
-	}
-
-	public static function visibilityCheckProvider(): array {
-		return [
-			[false, false, false, false],
-			[true, false, false, true],
-			[false, false, true, true],
-			[true, false, true, true],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('visibilityCheckProvider')]
-	public function testVisibilityCheck($userVisible, $userAssignable, $isAdmin, $expectedResult): void {
-		$user = $this->getMockBuilder(IUser::class)->getMock();
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('test');
-		$tag1 = $this->tagManager->createTag('one', $userVisible, $userAssignable);
-
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->with('test')
-			->willReturn($isAdmin);
-
-		$this->assertEquals($expectedResult, $this->tagManager->canUserSeeTag($tag1, $user));
-	}
-
-	public static function assignabilityCheckProvider(): array {
-		return [
-			// no groups
-			[false, false, false, false],
-			[true, false, false, false],
-			[true, true, false, true],
-			[false, true, false, false],
-			// admin rulez
-			[false, false, true, true],
-			[false, true, true, true],
-			[true, false, true, true],
-			[true, true, true, true],
-			// ignored groups
-			[false, false, false, false, ['group1'], ['group1']],
-			[true, true, false, true, ['group1'], ['group1']],
-			[true, true, false, true, ['group1'], ['anothergroup']],
-			[false, true, false, false, ['group1'], ['group1']],
-			// admin has precedence over groups
-			[false, false, true, true, ['group1'], ['anothergroup']],
-			[false, true, true, true, ['group1'], ['anothergroup']],
-			[true, false, true, true, ['group1'], ['anothergroup']],
-			[true, true, true, true, ['group1'], ['anothergroup']],
-			// groups only checked when visible and user non-assignable and non-admin
-			[true, false, false, false, ['group1'], ['anothergroup1']],
-			[true, false, false, true, ['group1'], ['group1']],
-			[true, false, false, true, ['group1', 'group2'], ['group2', 'group3']],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('assignabilityCheckProvider')]
-	public function testAssignabilityCheck($userVisible, $userAssignable, $isAdmin, $expectedResult, $userGroupIds = [], $tagGroupIds = []): void {
-		$user = $this->getMockBuilder(IUser::class)->getMock();
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('test');
-		$tag1 = $this->tagManager->createTag('one', $userVisible, $userAssignable);
-		$this->tagManager->setTagGroups($tag1, $tagGroupIds);
-
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->with('test')
-			->willReturn($isAdmin);
-		$this->groupManager->expects($this->any())
-			->method('getUserGroupIds')
-			->with($user)
-			->willReturn($userGroupIds);
-
-		$this->assertEquals($expectedResult, $this->tagManager->canUserAssignTag($tag1, $user));
-	}
-
-	public function testTagGroups(): void {
-		$tag1 = $this->tagManager->createTag('tag1', true, false);
-		$tag2 = $this->tagManager->createTag('tag2', true, false);
-		$this->tagManager->setTagGroups($tag1, ['group1', 'group2']);
-		$this->tagManager->setTagGroups($tag2, ['group2', 'group3']);
-
-		$this->assertEquals(['group1', 'group2'], $this->tagManager->getTagGroups($tag1));
-		$this->assertEquals(['group2', 'group3'], $this->tagManager->getTagGroups($tag2));
-
-		// change groups
-		$this->tagManager->setTagGroups($tag1, ['group3', 'group4']);
-		$this->tagManager->setTagGroups($tag2, []);
-
-		$this->assertEquals(['group3', 'group4'], $this->tagManager->getTagGroups($tag1));
-		$this->assertEquals([], $this->tagManager->getTagGroups($tag2));
-	}
-
-	/**
-	 * empty groupIds should be ignored
-	 */
-	public function testEmptyTagGroup(): void {
-		$tag1 = $this->tagManager->createTag('tag1', true, false);
-		$this->tagManager->setTagGroups($tag1, ['']);
-		$this->assertEquals([], $this->tagManager->getTagGroups($tag1));
-	}
-
-	public static function allowedToCreateProvider(): array {
-		return [
-			[true, null, true],
-			[true, null, false],
-			[false, true, true],
-			[false, true, false],
-			[false, false, false],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('allowedToCreateProvider')]
-	public function testAllowedToCreateTag(bool $isCli, ?bool $isAdmin, bool $isRestricted): void {
-		$oldCli = \OC::$CLI;
-		\OC::$CLI = $isCli;
-
-		$user = $this->getMockBuilder(IUser::class)->getMock();
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('test');
-		$this->userSession->expects($this->any())
-			->method('getUser')
-			->willReturn($isAdmin === null ? null : $user);
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->with('test')
-			->willReturn($isAdmin);
-		$this->appConfig->expects($this->any())
-			->method('getValueBool')
-			->with('systemtags', 'restrict_creation_to_admin')
-			->willReturn($isRestricted);
-
-		$name = uniqid('tag_', true);
-		$tag = $this->tagManager->createTag($name, true, true);
-		$this->assertEquals($tag->getName(), $name);
-		$this->tagManager->deleteTags($tag->getId());
-
-		\OC::$CLI = $oldCli;
-	}
-
-	public static function disallowedToCreateProvider(): array {
-		return [
-			[false],
-			[null],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('disallowedToCreateProvider')]
-	public function testDisallowedToCreateTag(?bool $isAdmin): void {
-		$oldCli = \OC::$CLI;
-		\OC::$CLI = false;
-
-		$user = $this->getMockBuilder(IUser::class)->getMock();
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn('test');
-		$this->userSession->expects($this->any())
-			->method('getUser')
-			->willReturn($isAdmin === null ? null : $user);
-		$this->groupManager->expects($this->any())
-			->method('isAdmin')
-			->with('test')
-			->willReturn($isAdmin);
-		$this->appConfig->expects($this->any())
-			->method('getValueBool')
-			->with('systemtags', 'restrict_creation_to_admin')
-			->willReturn(true);
-
-		$this->expectException(\Exception::class);
-		$tag = $this->tagManager->createTag(uniqid('tag_', true), true, true);
-
-		\OC::$CLI = $oldCli;
-	}
-
-
-	/**
-	 * @param ISystemTag $tag1
-	 * @param ISystemTag $tag2
-	 */
-	private function assertSameTag($tag1, $tag2) {
-		$this->assertEquals($tag1->getId(), $tag2->getId());
-		$this->assertEquals($tag1->getName(), $tag2->getName());
-		$this->assertEquals($tag1->isUserVisible(), $tag2->isUserVisible());
-		$this->assertEquals($tag1->isUserAssignable(), $tag2->isUserAssignable());
-	}
+    private ISystemTagManager $tagManager;
+    private IDBConnection $connection;
+    private IGroupManager $groupManager;
+    private IUserSession $userSession;
+    private IAppConfig $appConfig;
+    private IEventDispatcher $dispatcher;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->connection = Server::get(IDBConnection::class);
+
+        $this->dispatcher = $this->createMock(IEventDispatcher::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->appConfig = $this->createMock(IAppConfig::class);
+
+        $this->tagManager = new SystemTagManager(
+            $this->connection,
+            $this->groupManager,
+            $this->dispatcher,
+            $this->userSession,
+            $this->appConfig,
+        );
+        $this->pruneTagsTables();
+    }
+
+    protected function tearDown(): void {
+        $this->pruneTagsTables();
+        \OC::$CLI = true;
+        parent::tearDown();
+    }
+
+    protected function pruneTagsTables() {
+        $query = $this->connection->getQueryBuilder();
+        $query->delete(SystemTagObjectMapper::RELATION_TABLE)->execute();
+        $query->delete(SystemTagManager::TAG_TABLE)->execute();
+    }
+
+    public static function getAllTagsDataProvider(): array {
+        return [
+            [
+                // no tags at all
+                []
+            ],
+            [
+                // simple
+                [
+                    ['one', false, false],
+                    ['two', false, false],
+                ]
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('getAllTagsDataProvider')]
+    public function testGetAllTags($testTags): void {
+        $testTagsById = [];
+        foreach ($testTags as $testTag) {
+            $tag = $this->tagManager->createTag($testTag[0], $testTag[1], $testTag[2]);
+            $testTagsById[$tag->getId()] = $tag;
+        }
+
+        $tagList = $this->tagManager->getAllTags();
+
+        $this->assertCount(count($testTags), $tagList);
+
+        foreach ($testTagsById as $testTagId => $testTag) {
+            $this->assertTrue(isset($tagList[$testTagId]));
+            $this->assertSameTag($tagList[$testTagId], $testTag);
+        }
+    }
+
+    public static function getAllTagsFilteredDataProvider(): array {
+        return [
+            [
+                [
+                    // no tags at all
+                ],
+                null,
+                null,
+                []
+            ],
+            // filter by visible only
+            [
+                // none visible
+                [
+                    ['one', false, false],
+                    ['two', false, false],
+                ],
+                true,
+                null,
+                []
+            ],
+            [
+                // one visible
+                [
+                    ['one', true, false],
+                    ['two', false, false],
+                ],
+                true,
+                null,
+                [
+                    ['one', true, false],
+                ]
+            ],
+            [
+                // one invisible
+                [
+                    ['one', true, false],
+                    ['two', false, false],
+                ],
+                false,
+                null,
+                [
+                    ['two', false, false],
+                ]
+            ],
+            // filter by name pattern
+            [
+                [
+                    ['one', true, false],
+                    ['one_different', false, false],
+                    ['two', true, false],
+                ],
+                null,
+                'on',
+                [
+                    ['one', true, false],
+                    ['one_different', false, false],
+                ]
+            ],
+            // filter by name pattern and visibility
+            [
+                // one visible
+                [
+                    ['one', true, false],
+                    ['two', true, false],
+                    ['one_different', false, false],
+                ],
+                true,
+                'on',
+                [
+                    ['one', true, false],
+                ]
+            ],
+            // filter by name pattern in the middle
+            [
+                // one visible
+                [
+                    ['abcdefghi', true, false],
+                    ['two', true, false],
+                ],
+                null,
+                'def',
+                [
+                    ['abcdefghi', true, false],
+                ]
+            ]
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('getAllTagsFilteredDataProvider')]
+    public function testGetAllTagsFiltered($testTags, $visibilityFilter, $nameSearch, $expectedResults): void {
+        foreach ($testTags as $testTag) {
+            $this->tagManager->createTag($testTag[0], $testTag[1], $testTag[2]);
+        }
+
+        $testTagsById = [];
+        foreach ($expectedResults as $expectedTag) {
+            $tag = $this->tagManager->getTag($expectedTag[0], $expectedTag[1], $expectedTag[2]);
+            $testTagsById[$tag->getId()] = $tag;
+        }
+
+        $tagList = $this->tagManager->getAllTags($visibilityFilter, $nameSearch);
+
+        $this->assertCount(count($testTagsById), $tagList);
+
+        foreach ($testTagsById as $testTagId => $testTag) {
+            $this->assertTrue(isset($tagList[$testTagId]));
+            $this->assertSameTag($tagList[$testTagId], $testTag);
+        }
+    }
+
+    public static function oneTagMultipleFlagsProvider(): array {
+        return [
+            ['one', false, false],
+            ['one', true, false],
+            ['one', false, true],
+            ['one', true, true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('oneTagMultipleFlagsProvider')]
+    public function testCreateDuplicate($name, $userVisible, $userAssignable): void {
+        $this->expectException(TagAlreadyExistsException::class);
+
+        try {
+            $this->tagManager->createTag($name, $userVisible, $userAssignable);
+        } catch (\Exception $e) {
+            $this->assertTrue(false, 'No exception thrown for the first create call');
+        }
+        $this->tagManager->createTag($name, $userVisible, $userAssignable);
+    }
+
+    public function testCreateDuplicateWithDifferentFlags(): void {
+        $this->expectException(TagAlreadyExistsException::class);
+
+        // Create a tag with specific flags
+        $this->tagManager->createTag('duplicate', true, false);
+        // Try to create a tag with the same name but different flags - should fail
+        $this->tagManager->createTag('duplicate', false, true);
+    }
+
+    public function testCreateOverlongName(): void {
+        $tag = $this->tagManager->createTag('Zona circundante do Palácio Nacional da Ajuda (Jardim das Damas, Salão de Física, Torre Sineira, Paço Velho e Jardim Botânico)', true, true);
+        $this->assertSame('Zona circundante do Palácio Nacional da Ajuda (Jardim das Damas', $tag->getName()); // 63 characters but 64 bytes due to "á"
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('oneTagMultipleFlagsProvider')]
+    public function testGetExistingTag($name, $userVisible, $userAssignable): void {
+        $tag1 = $this->tagManager->createTag($name, $userVisible, $userAssignable);
+        $tag2 = $this->tagManager->getTag($name, $userVisible, $userAssignable);
+
+        $this->assertSameTag($tag1, $tag2);
+    }
+
+    public function testGetExistingTagById(): void {
+        $tag1 = $this->tagManager->createTag('one', true, false);
+        $tag2 = $this->tagManager->createTag('two', false, true);
+
+        $tagList = $this->tagManager->getTagsByIds([$tag1->getId(), $tag2->getId()]);
+
+        $this->assertCount(2, $tagList);
+
+        $this->assertSameTag($tag1, $tagList[$tag1->getId()]);
+        $this->assertSameTag($tag2, $tagList[$tag2->getId()]);
+    }
+
+
+    public function testGetNonExistingTag(): void {
+        $this->expectException(TagNotFoundException::class);
+
+        $this->tagManager->getTag('nonexist', false, false);
+    }
+
+
+    public function testGetNonExistingTagsById(): void {
+        $this->expectException(TagNotFoundException::class);
+
+        $tag1 = $this->tagManager->createTag('one', true, false);
+        $this->tagManager->getTagsByIds([$tag1->getId(), 100, 101]);
+    }
+
+
+    public function testGetInvalidTagIdFormat(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $tag1 = $this->tagManager->createTag('one', true, false);
+        $this->tagManager->getTagsByIds([$tag1->getId() . 'suffix']);
+    }
+
+    public static function updateTagProvider(): array {
+        return [
+            [
+                // update name
+                ['one', true, true, '0082c9'],
+                ['two', true, true, '0082c9']
+            ],
+            [
+                // update one flag
+                ['one', false, true, null],
+                ['one', true, true, '0082c9']
+            ],
+            [
+                // update all flags
+                ['one', false, false, '0082c9'],
+                ['one', true, true, null]
+            ],
+            [
+                // update all
+                ['one', false, false, '0082c9'],
+                ['two', true, true, '0082c9']
+            ],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('updateTagProvider')]
+    public function testUpdateTag($tagCreate, $tagUpdated): void {
+        $tag1 = $this->tagManager->createTag(
+            $tagCreate[0],
+            $tagCreate[1],
+            $tagCreate[2],
+            $tagCreate[3],
+        );
+        $this->tagManager->updateTag(
+            $tag1->getId(),
+            $tagUpdated[0],
+            $tagUpdated[1],
+            $tagUpdated[2],
+            $tagUpdated[3],
+        );
+        $tag2 = $this->tagManager->getTag(
+            $tagUpdated[0],
+            $tagUpdated[1],
+            $tagUpdated[2],
+            $tagUpdated[3],
+        );
+
+        $this->assertEquals($tag2->getId(), $tag1->getId());
+        $this->assertEquals($tag2->getName(), $tagUpdated[0]);
+        $this->assertEquals($tag2->isUserVisible(), $tagUpdated[1]);
+        $this->assertEquals($tag2->isUserAssignable(), $tagUpdated[2]);
+        $this->assertEquals($tag2->getColor(), $tagUpdated[3]);
+
+    }
+
+    public function testUpdateTagToExistingName(): void {
+        $this->expectException(TagAlreadyExistsException::class);
+
+        // Create two different tags
+        $tag1 = $this->tagManager->createTag('first', true, true);
+        $tag2 = $this->tagManager->createTag('second', false, false);
+
+        // Try to update tag2 to have the same name as tag1 - should fail
+        $this->tagManager->updateTag(
+            $tag2->getId(),
+            'first',
+            false,
+            false,
+            null
+        );
+    }
+
+    public function testDeleteTags(): void {
+        $tag1 = $this->tagManager->createTag('one', true, false);
+        $tag2 = $this->tagManager->createTag('two', false, true);
+
+        $this->tagManager->deleteTags([$tag1->getId(), $tag2->getId()]);
+
+        $this->assertEmpty($this->tagManager->getAllTags());
+    }
+
+
+    public function testDeleteNonExistingTag(): void {
+        $this->expectException(TagNotFoundException::class);
+
+        $this->tagManager->deleteTags([100]);
+    }
+
+    public function testDeleteTagRemovesRelations(): void {
+        $tag1 = $this->tagManager->createTag('one', true, false);
+        $tag2 = $this->tagManager->createTag('two', true, true);
+
+        $tagMapper = new SystemTagObjectMapper($this->connection, $this->tagManager, $this->dispatcher);
+
+        $tagMapper->assignTags(1, 'testtype', $tag1->getId());
+        $tagMapper->assignTags(1, 'testtype', $tag2->getId());
+        $tagMapper->assignTags(2, 'testtype', $tag1->getId());
+
+        $this->tagManager->deleteTags($tag1->getId());
+
+        $tagIdMapping = $tagMapper->getTagIdsForObjects(
+            [1, 2],
+            'testtype'
+        );
+
+        $this->assertEquals([
+            1 => [$tag2->getId()],
+            2 => [],
+        ], $tagIdMapping);
+    }
+
+    public static function visibilityCheckProvider(): array {
+        return [
+            [false, false, false, false],
+            [true, false, false, true],
+            [false, false, true, true],
+            [true, false, true, true],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('visibilityCheckProvider')]
+    public function testVisibilityCheck($userVisible, $userAssignable, $isAdmin, $expectedResult): void {
+        $user = $this->getMockBuilder(IUser::class)->getMock();
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('test');
+        $tag1 = $this->tagManager->createTag('one', $userVisible, $userAssignable);
+
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->with('test')
+            ->willReturn($isAdmin);
+
+        $this->assertEquals($expectedResult, $this->tagManager->canUserSeeTag($tag1, $user));
+    }
+
+    public static function assignabilityCheckProvider(): array {
+        return [
+            // no groups
+            [false, false, false, false],
+            [true, false, false, false],
+            [true, true, false, true],
+            [false, true, false, false],
+            // admin rulez
+            [false, false, true, true],
+            [false, true, true, true],
+            [true, false, true, true],
+            [true, true, true, true],
+            // ignored groups
+            [false, false, false, false, ['group1'], ['group1']],
+            [true, true, false, true, ['group1'], ['group1']],
+            [true, true, false, true, ['group1'], ['anothergroup']],
+            [false, true, false, false, ['group1'], ['group1']],
+            // admin has precedence over groups
+            [false, false, true, true, ['group1'], ['anothergroup']],
+            [false, true, true, true, ['group1'], ['anothergroup']],
+            [true, false, true, true, ['group1'], ['anothergroup']],
+            [true, true, true, true, ['group1'], ['anothergroup']],
+            // groups only checked when visible and user non-assignable and non-admin
+            [true, false, false, false, ['group1'], ['anothergroup1']],
+            [true, false, false, true, ['group1'], ['group1']],
+            [true, false, false, true, ['group1', 'group2'], ['group2', 'group3']],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('assignabilityCheckProvider')]
+    public function testAssignabilityCheck($userVisible, $userAssignable, $isAdmin, $expectedResult, $userGroupIds = [], $tagGroupIds = []): void {
+        $user = $this->getMockBuilder(IUser::class)->getMock();
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('test');
+        $tag1 = $this->tagManager->createTag('one', $userVisible, $userAssignable);
+        $this->tagManager->setTagGroups($tag1, $tagGroupIds);
+
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->with('test')
+            ->willReturn($isAdmin);
+        $this->groupManager->expects($this->any())
+            ->method('getUserGroupIds')
+            ->with($user)
+            ->willReturn($userGroupIds);
+
+        $this->assertEquals($expectedResult, $this->tagManager->canUserAssignTag($tag1, $user));
+    }
+
+    public function testTagGroups(): void {
+        $tag1 = $this->tagManager->createTag('tag1', true, false);
+        $tag2 = $this->tagManager->createTag('tag2', true, false);
+        $this->tagManager->setTagGroups($tag1, ['group1', 'group2']);
+        $this->tagManager->setTagGroups($tag2, ['group2', 'group3']);
+
+        $this->assertEquals(['group1', 'group2'], $this->tagManager->getTagGroups($tag1));
+        $this->assertEquals(['group2', 'group3'], $this->tagManager->getTagGroups($tag2));
+
+        // change groups
+        $this->tagManager->setTagGroups($tag1, ['group3', 'group4']);
+        $this->tagManager->setTagGroups($tag2, []);
+
+        $this->assertEquals(['group3', 'group4'], $this->tagManager->getTagGroups($tag1));
+        $this->assertEquals([], $this->tagManager->getTagGroups($tag2));
+    }
+
+    /**
+     * empty groupIds should be ignored
+     */
+    public function testEmptyTagGroup(): void {
+        $tag1 = $this->tagManager->createTag('tag1', true, false);
+        $this->tagManager->setTagGroups($tag1, ['']);
+        $this->assertEquals([], $this->tagManager->getTagGroups($tag1));
+    }
+
+    public static function allowedToCreateProvider(): array {
+        return [
+            [true, null, true],
+            [true, null, false],
+            [false, true, true],
+            [false, true, false],
+            [false, false, false],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('allowedToCreateProvider')]
+    public function testAllowedToCreateTag(bool $isCli, ?bool $isAdmin, bool $isRestricted): void {
+        $oldCli = \OC::$CLI;
+        \OC::$CLI = $isCli;
+
+        $user = $this->getMockBuilder(IUser::class)->getMock();
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('test');
+        $this->userSession->expects($this->any())
+            ->method('getUser')
+            ->willReturn($isAdmin === null ? null : $user);
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->with('test')
+            ->willReturn($isAdmin);
+        $this->appConfig->expects($this->any())
+            ->method('getValueBool')
+            ->with('systemtags', 'restrict_creation_to_admin')
+            ->willReturn($isRestricted);
+
+        $name = uniqid('tag_', true);
+        $tag = $this->tagManager->createTag($name, true, true);
+        $this->assertEquals($tag->getName(), $name);
+        $this->tagManager->deleteTags($tag->getId());
+
+        \OC::$CLI = $oldCli;
+    }
+
+    public static function disallowedToCreateProvider(): array {
+        return [
+            [false],
+            [null],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('disallowedToCreateProvider')]
+    public function testDisallowedToCreateTag(?bool $isAdmin): void {
+        $oldCli = \OC::$CLI;
+        \OC::$CLI = false;
+
+        $user = $this->getMockBuilder(IUser::class)->getMock();
+        $user->expects($this->any())
+            ->method('getUID')
+            ->willReturn('test');
+        $this->userSession->expects($this->any())
+            ->method('getUser')
+            ->willReturn($isAdmin === null ? null : $user);
+        $this->groupManager->expects($this->any())
+            ->method('isAdmin')
+            ->with('test')
+            ->willReturn($isAdmin);
+        $this->appConfig->expects($this->any())
+            ->method('getValueBool')
+            ->with('systemtags', 'restrict_creation_to_admin')
+            ->willReturn(true);
+
+        $this->expectException(\Exception::class);
+        $tag = $this->tagManager->createTag(uniqid('tag_', true), true, true);
+
+        \OC::$CLI = $oldCli;
+    }
+
+
+    /**
+     * @param ISystemTag $tag1
+     * @param ISystemTag $tag2
+     */
+    private function assertSameTag($tag1, $tag2) {
+        $this->assertEquals($tag1->getId(), $tag2->getId());
+        $this->assertEquals($tag1->getName(), $tag2->getName());
+        $this->assertEquals($tag1->isUserVisible(), $tag2->isUserVisible());
+        $this->assertEquals($tag1->isUserAssignable(), $tag2->isUserAssignable());
+    }
 }

lib/private/SystemTag/SystemTagManager.php

Indentation +417 added lines, -417 removed lines

@@ -28,422 +28,422 @@
  * Manager class for system tags
  */
 class SystemTagManager implements ISystemTagManager {
-	public const TAG_TABLE = 'systemtag';
-	public const TAG_GROUP_TABLE = 'systemtag_group';
-
-	/**
-	 * Prepared query for selecting tags directly
-	 */
-	private IQueryBuilder $selectTagQuery;
-
-	public function __construct(
-		protected IDBConnection $connection,
-		protected IGroupManager $groupManager,
-		protected IEventDispatcher $dispatcher,
-		private IUserSession $userSession,
-		private IAppConfig $appConfig,
-	) {
-		$query = $this->connection->getQueryBuilder();
-		$this->selectTagQuery = $query->select('*')
-			->from(self::TAG_TABLE)
-			->where($query->expr()->eq('name', $query->createParameter('name')))
-			->andWhere($query->expr()->eq('visibility', $query->createParameter('visibility')))
-			->andWhere($query->expr()->eq('editable', $query->createParameter('editable')));
-	}
-
-	public function getTagsByIds($tagIds, ?IUser $user = null): array {
-		if (!\is_array($tagIds)) {
-			$tagIds = [$tagIds];
-		}
-
-		$tags = [];
-
-		// note: not all databases will fail if it's a string or starts with a number
-		foreach ($tagIds as $tagId) {
-			if (!is_numeric($tagId)) {
-				throw new \InvalidArgumentException('Tag id must be integer');
-			}
-		}
-
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')
-			->from(self::TAG_TABLE)
-			->where($query->expr()->in('id', $query->createParameter('tagids')))
-			->addOrderBy('name', 'ASC')
-			->addOrderBy('visibility', 'ASC')
-			->addOrderBy('editable', 'ASC')
-			->setParameter('tagids', $tagIds, IQueryBuilder::PARAM_INT_ARRAY);
-
-		$result = $query->execute();
-		while ($row = $result->fetch()) {
-			$tag = $this->createSystemTagFromRow($row);
-			if ($user && !$this->canUserSeeTag($tag, $user)) {
-				// if a user is given, hide invisible tags
-				continue;
-			}
-			$tags[$row['id']] = $tag;
-		}
-
-		$result->closeCursor();
-
-		if (\count($tags) !== \count($tagIds)) {
-			throw new TagNotFoundException(
-				'Tag id(s) not found', 0, null, array_diff($tagIds, array_keys($tags))
-			);
-		}
-
-		return $tags;
-	}
-
-	public function getAllTags($visibilityFilter = null, $nameSearchPattern = null): array {
-		$tags = [];
-
-		$query = $this->connection->getQueryBuilder();
-		$query->select('*')
-			->from(self::TAG_TABLE);
-
-		if (!\is_null($visibilityFilter)) {
-			$query->andWhere($query->expr()->eq('visibility', $query->createNamedParameter((int)$visibilityFilter)));
-		}
-
-		if (!empty($nameSearchPattern)) {
-			$query->andWhere(
-				$query->expr()->iLike(
-					'name',
-					$query->createNamedParameter('%' . $this->connection->escapeLikeParameter($nameSearchPattern) . '%')
-				)
-			);
-		}
-
-		$query
-			->addOrderBy('name', 'ASC')
-			->addOrderBy('visibility', 'ASC')
-			->addOrderBy('editable', 'ASC');
-
-		$result = $query->executeQuery();
-		while ($row = $result->fetch()) {
-			$tags[$row['id']] = $this->createSystemTagFromRow($row);
-		}
-
-		$result->closeCursor();
-
-		return $tags;
-	}
-
-	public function getTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag {
-		// Length of name column is 64
-		$truncatedTagName = substr($tagName, 0, 64);
-		$result = $this->selectTagQuery
-			->setParameter('name', $truncatedTagName)
-			->setParameter('visibility', $userVisible ? 1 : 0)
-			->setParameter('editable', $userAssignable ? 1 : 0)
-			->execute();
-
-		$row = $result->fetch();
-		$result->closeCursor();
-		if (!$row) {
-			throw new TagNotFoundException(
-				'Tag ("' . $truncatedTagName . '", ' . $userVisible . ', ' . $userAssignable . ') does not exist'
-			);
-		}
-
-		return $this->createSystemTagFromRow($row);
-	}
-
-	public function createTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag {
-		$user = $this->userSession->getUser();
-		if (!$this->canUserCreateTag($user)) {
-			throw new TagCreationForbiddenException();
-		}
-
-		// Check if tag already exists (case-insensitive)
-		$existingTags = $this->getAllTags(null, $tagName);
-		foreach ($existingTags as $existingTag) {
-			if (mb_strtolower($existingTag->getName()) === mb_strtolower($tagName)) {
-				throw new TagAlreadyExistsException('Tag ' . $tagName . ' already exists');
-			}
-		}
-
-		// Length of name column is 64
-		$truncatedTagName = substr($tagName, 0, 64);
-		$query = $this->connection->getQueryBuilder();
-		$query->insert(self::TAG_TABLE)
-			->values([
-				'name' => $query->createNamedParameter($truncatedTagName),
-				'visibility' => $query->createNamedParameter($userVisible ? 1 : 0),
-				'editable' => $query->createNamedParameter($userAssignable ? 1 : 0),
-				'etag' => $query->createNamedParameter(md5((string)time())),
-			]);
-
-		try {
-			$query->execute();
-		} catch (UniqueConstraintViolationException $e) {
-			throw new TagAlreadyExistsException(
-				'Tag ("' . $truncatedTagName . '", ' . $userVisible . ', ' . $userAssignable . ') already exists',
-				0,
-				$e
-			);
-		}
-
-		$tagId = $query->getLastInsertId();
-
-		$tag = new SystemTag(
-			(string)$tagId,
-			$truncatedTagName,
-			$userVisible,
-			$userAssignable
-		);
-
-		$this->dispatcher->dispatch(ManagerEvent::EVENT_CREATE, new ManagerEvent(
-			ManagerEvent::EVENT_CREATE, $tag
-		));
-
-		return $tag;
-	}
-
-	public function updateTag(
-		string $tagId,
-		string $newName,
-		bool $userVisible,
-		bool $userAssignable,
-		?string $color,
-	): void {
-		try {
-			$tags = $this->getTagsByIds($tagId);
-		} catch (TagNotFoundException $e) {
-			throw new TagNotFoundException(
-				'Tag does not exist', 0, null, [$tagId]
-			);
-		}
-
-		$user = $this->userSession->getUser();
-		if (!$this->canUserUpdateTag($user)) {
-			throw new TagUpdateForbiddenException();
-		}
-
-		$beforeUpdate = array_shift($tags);
-		// Length of name column is 64
-		$newName = trim($newName);
-		$truncatedNewName = substr($newName, 0, 64);
-		$afterUpdate = new SystemTag(
-			$tagId,
-			$truncatedNewName,
-			$userVisible,
-			$userAssignable,
-			$beforeUpdate->getETag(),
-			$color
-		);
-
-		// Check if tag already exists (case-insensitive)
-		$existingTags = $this->getAllTags(null, $truncatedNewName);
-		foreach ($existingTags as $existingTag) {
-			if (mb_strtolower($existingTag->getName()) === mb_strtolower($truncatedNewName)
-				&& $existingTag->getId() !== $tagId) {
-				throw new TagAlreadyExistsException('Tag ' . $truncatedNewName . ' already exists');
-			}
-		}
-
-		$query = $this->connection->getQueryBuilder();
-		$query->update(self::TAG_TABLE)
-			->set('name', $query->createParameter('name'))
-			->set('visibility', $query->createParameter('visibility'))
-			->set('editable', $query->createParameter('editable'))
-			->set('color', $query->createParameter('color'))
-			->where($query->expr()->eq('id', $query->createParameter('tagid')))
-			->setParameter('name', $truncatedNewName)
-			->setParameter('visibility', $userVisible ? 1 : 0)
-			->setParameter('editable', $userAssignable ? 1 : 0)
-			->setParameter('tagid', $tagId)
-			->setParameter('color', $color);
-
-		try {
-			if ($query->execute() === 0) {
-				throw new TagNotFoundException(
-					'Tag does not exist', 0, null, [$tagId]
-				);
-			}
-		} catch (UniqueConstraintViolationException $e) {
-			throw new TagAlreadyExistsException(
-				'Tag ("' . $newName . '", ' . $userVisible . ', ' . $userAssignable . ') already exists',
-				0,
-				$e
-			);
-		}
-
-		$this->dispatcher->dispatch(ManagerEvent::EVENT_UPDATE, new ManagerEvent(
-			ManagerEvent::EVENT_UPDATE, $afterUpdate, $beforeUpdate
-		));
-	}
-
-	public function deleteTags($tagIds): void {
-		if (!\is_array($tagIds)) {
-			$tagIds = [$tagIds];
-		}
-
-		$tagNotFoundException = null;
-		$tags = [];
-		try {
-			$tags = $this->getTagsByIds($tagIds);
-		} catch (TagNotFoundException $e) {
-			$tagNotFoundException = $e;
-
-			// Get existing tag objects for the hooks later
-			$existingTags = array_diff($tagIds, $tagNotFoundException->getMissingTags());
-			if (!empty($existingTags)) {
-				try {
-					$tags = $this->getTagsByIds($existingTags);
-				} catch (TagNotFoundException $e) {
-					// Ignore further errors...
-				}
-			}
-		}
-
-		// delete relationships first
-		$query = $this->connection->getQueryBuilder();
-		$query->delete(SystemTagObjectMapper::RELATION_TABLE)
-			->where($query->expr()->in('systemtagid', $query->createParameter('tagids')))
-			->setParameter('tagids', $tagIds, IQueryBuilder::PARAM_INT_ARRAY)
-			->execute();
-
-		$query = $this->connection->getQueryBuilder();
-		$query->delete(self::TAG_TABLE)
-			->where($query->expr()->in('id', $query->createParameter('tagids')))
-			->setParameter('tagids', $tagIds, IQueryBuilder::PARAM_INT_ARRAY)
-			->execute();
-
-		foreach ($tags as $tag) {
-			$this->dispatcher->dispatch(ManagerEvent::EVENT_DELETE, new ManagerEvent(
-				ManagerEvent::EVENT_DELETE, $tag
-			));
-		}
-
-		if ($tagNotFoundException !== null) {
-			throw new TagNotFoundException(
-				'Tag id(s) not found', 0, $tagNotFoundException, $tagNotFoundException->getMissingTags()
-			);
-		}
-	}
-
-	public function canUserAssignTag(ISystemTag $tag, ?IUser $user): bool {
-		if ($user === null) {
-			return false;
-		}
-
-		// early check to avoid unneeded group lookups
-		if ($tag->isUserAssignable() && $tag->isUserVisible()) {
-			return true;
-		}
-
-		if ($this->groupManager->isAdmin($user->getUID())) {
-			return true;
-		}
-
-		if (!$tag->isUserVisible()) {
-			return false;
-		}
-
-		$groupIds = $this->groupManager->getUserGroupIds($user);
-		if (!empty($groupIds)) {
-			$matchingGroups = array_intersect($groupIds, $this->getTagGroups($tag));
-			if (!empty($matchingGroups)) {
-				return true;
-			}
-		}
-
-		return false;
-	}
-
-	public function canUserCreateTag(?IUser $user): bool {
-		if ($user === null) {
-			// If no user given, allows only calls from CLI
-			return \OC::$CLI;
-		}
-
-		if ($this->appConfig->getValueBool('systemtags', 'restrict_creation_to_admin', false) === false) {
-			return true;
-		}
-
-		return $this->groupManager->isAdmin($user->getUID());
-	}
-
-	public function canUserUpdateTag(?IUser $user): bool {
-		// We currently have no different permissions for updating tags than for creating them
-		return $this->canUserCreateTag($user);
-	}
-
-	public function canUserSeeTag(ISystemTag $tag, ?IUser $user): bool {
-		// If no user, then we only show public tags
-		if (!$user && $tag->getAccessLevel() === ISystemTag::ACCESS_LEVEL_PUBLIC) {
-			return true;
-		}
-
-		if ($tag->isUserVisible()) {
-			return true;
-		}
-
-		// if not returned yet, and user is not logged in, then the tag is not visible
-		if ($user === null) {
-			return false;
-		}
-
-		if ($this->groupManager->isAdmin($user->getUID())) {
-			return true;
-		}
-
-		return false;
-	}
-
-	private function createSystemTagFromRow($row): SystemTag {
-		return new SystemTag((string)$row['id'], $row['name'], (bool)$row['visibility'], (bool)$row['editable'], $row['etag'], $row['color']);
-	}
-
-	public function setTagGroups(ISystemTag $tag, array $groupIds): void {
-		// delete relationships first
-		$this->connection->beginTransaction();
-		try {
-			$query = $this->connection->getQueryBuilder();
-			$query->delete(self::TAG_GROUP_TABLE)
-				->where($query->expr()->eq('systemtagid', $query->createNamedParameter($tag->getId())))
-				->execute();
-
-			// add each group id
-			$query = $this->connection->getQueryBuilder();
-			$query->insert(self::TAG_GROUP_TABLE)
-				->values([
-					'systemtagid' => $query->createNamedParameter($tag->getId()),
-					'gid' => $query->createParameter('gid'),
-				]);
-			foreach ($groupIds as $groupId) {
-				if ($groupId === '') {
-					continue;
-				}
-				$query->setParameter('gid', $groupId);
-				$query->execute();
-			}
-
-			$this->connection->commit();
-		} catch (\Exception $e) {
-			$this->connection->rollBack();
-			throw $e;
-		}
-	}
-
-	public function getTagGroups(ISystemTag $tag): array {
-		$groupIds = [];
-		$query = $this->connection->getQueryBuilder();
-		$query->select('gid')
-			->from(self::TAG_GROUP_TABLE)
-			->where($query->expr()->eq('systemtagid', $query->createNamedParameter($tag->getId())))
-			->orderBy('gid');
-
-		$result = $query->execute();
-		while ($row = $result->fetch()) {
-			$groupIds[] = $row['gid'];
-		}
-
-		$result->closeCursor();
-
-		return $groupIds;
-	}
+    public const TAG_TABLE = 'systemtag';
+    public const TAG_GROUP_TABLE = 'systemtag_group';
+
+    /**
+     * Prepared query for selecting tags directly
+     */
+    private IQueryBuilder $selectTagQuery;
+
+    public function __construct(
+        protected IDBConnection $connection,
+        protected IGroupManager $groupManager,
+        protected IEventDispatcher $dispatcher,
+        private IUserSession $userSession,
+        private IAppConfig $appConfig,
+    ) {
+        $query = $this->connection->getQueryBuilder();
+        $this->selectTagQuery = $query->select('*')
+            ->from(self::TAG_TABLE)
+            ->where($query->expr()->eq('name', $query->createParameter('name')))
+            ->andWhere($query->expr()->eq('visibility', $query->createParameter('visibility')))
+            ->andWhere($query->expr()->eq('editable', $query->createParameter('editable')));
+    }
+
+    public function getTagsByIds($tagIds, ?IUser $user = null): array {
+        if (!\is_array($tagIds)) {
+            $tagIds = [$tagIds];
+        }
+
+        $tags = [];
+
+        // note: not all databases will fail if it's a string or starts with a number
+        foreach ($tagIds as $tagId) {
+            if (!is_numeric($tagId)) {
+                throw new \InvalidArgumentException('Tag id must be integer');
+            }
+        }
+
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')
+            ->from(self::TAG_TABLE)
+            ->where($query->expr()->in('id', $query->createParameter('tagids')))
+            ->addOrderBy('name', 'ASC')
+            ->addOrderBy('visibility', 'ASC')
+            ->addOrderBy('editable', 'ASC')
+            ->setParameter('tagids', $tagIds, IQueryBuilder::PARAM_INT_ARRAY);
+
+        $result = $query->execute();
+        while ($row = $result->fetch()) {
+            $tag = $this->createSystemTagFromRow($row);
+            if ($user && !$this->canUserSeeTag($tag, $user)) {
+                // if a user is given, hide invisible tags
+                continue;
+            }
+            $tags[$row['id']] = $tag;
+        }
+
+        $result->closeCursor();
+
+        if (\count($tags) !== \count($tagIds)) {
+            throw new TagNotFoundException(
+                'Tag id(s) not found', 0, null, array_diff($tagIds, array_keys($tags))
+            );
+        }
+
+        return $tags;
+    }
+
+    public function getAllTags($visibilityFilter = null, $nameSearchPattern = null): array {
+        $tags = [];
+
+        $query = $this->connection->getQueryBuilder();
+        $query->select('*')
+            ->from(self::TAG_TABLE);
+
+        if (!\is_null($visibilityFilter)) {
+            $query->andWhere($query->expr()->eq('visibility', $query->createNamedParameter((int)$visibilityFilter)));
+        }
+
+        if (!empty($nameSearchPattern)) {
+            $query->andWhere(
+                $query->expr()->iLike(
+                    'name',
+                    $query->createNamedParameter('%' . $this->connection->escapeLikeParameter($nameSearchPattern) . '%')
+                )
+            );
+        }
+
+        $query
+            ->addOrderBy('name', 'ASC')
+            ->addOrderBy('visibility', 'ASC')
+            ->addOrderBy('editable', 'ASC');
+
+        $result = $query->executeQuery();
+        while ($row = $result->fetch()) {
+            $tags[$row['id']] = $this->createSystemTagFromRow($row);
+        }
+
+        $result->closeCursor();
+
+        return $tags;
+    }
+
+    public function getTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag {
+        // Length of name column is 64
+        $truncatedTagName = substr($tagName, 0, 64);
+        $result = $this->selectTagQuery
+            ->setParameter('name', $truncatedTagName)
+            ->setParameter('visibility', $userVisible ? 1 : 0)
+            ->setParameter('editable', $userAssignable ? 1 : 0)
+            ->execute();
+
+        $row = $result->fetch();
+        $result->closeCursor();
+        if (!$row) {
+            throw new TagNotFoundException(
+                'Tag ("' . $truncatedTagName . '", ' . $userVisible . ', ' . $userAssignable . ') does not exist'
+            );
+        }
+
+        return $this->createSystemTagFromRow($row);
+    }
+
+    public function createTag(string $tagName, bool $userVisible, bool $userAssignable): ISystemTag {
+        $user = $this->userSession->getUser();
+        if (!$this->canUserCreateTag($user)) {
+            throw new TagCreationForbiddenException();
+        }
+
+        // Check if tag already exists (case-insensitive)
+        $existingTags = $this->getAllTags(null, $tagName);
+        foreach ($existingTags as $existingTag) {
+            if (mb_strtolower($existingTag->getName()) === mb_strtolower($tagName)) {
+                throw new TagAlreadyExistsException('Tag ' . $tagName . ' already exists');
+            }
+        }
+
+        // Length of name column is 64
+        $truncatedTagName = substr($tagName, 0, 64);
+        $query = $this->connection->getQueryBuilder();
+        $query->insert(self::TAG_TABLE)
+            ->values([
+                'name' => $query->createNamedParameter($truncatedTagName),
+                'visibility' => $query->createNamedParameter($userVisible ? 1 : 0),
+                'editable' => $query->createNamedParameter($userAssignable ? 1 : 0),
+                'etag' => $query->createNamedParameter(md5((string)time())),
+            ]);
+
+        try {
+            $query->execute();
+        } catch (UniqueConstraintViolationException $e) {
+            throw new TagAlreadyExistsException(
+                'Tag ("' . $truncatedTagName . '", ' . $userVisible . ', ' . $userAssignable . ') already exists',
+                0,
+                $e
+            );
+        }
+
+        $tagId = $query->getLastInsertId();
+
+        $tag = new SystemTag(
+            (string)$tagId,
+            $truncatedTagName,
+            $userVisible,
+            $userAssignable
+        );
+
+        $this->dispatcher->dispatch(ManagerEvent::EVENT_CREATE, new ManagerEvent(
+            ManagerEvent::EVENT_CREATE, $tag
+        ));
+
+        return $tag;
+    }
+
+    public function updateTag(
+        string $tagId,
+        string $newName,
+        bool $userVisible,
+        bool $userAssignable,
+        ?string $color,
+    ): void {
+        try {
+            $tags = $this->getTagsByIds($tagId);
+        } catch (TagNotFoundException $e) {
+            throw new TagNotFoundException(
+                'Tag does not exist', 0, null, [$tagId]
+            );
+        }
+
+        $user = $this->userSession->getUser();
+        if (!$this->canUserUpdateTag($user)) {
+            throw new TagUpdateForbiddenException();
+        }
+
+        $beforeUpdate = array_shift($tags);
+        // Length of name column is 64
+        $newName = trim($newName);
+        $truncatedNewName = substr($newName, 0, 64);
+        $afterUpdate = new SystemTag(
+            $tagId,
+            $truncatedNewName,
+            $userVisible,
+            $userAssignable,
+            $beforeUpdate->getETag(),
+            $color
+        );
+
+        // Check if tag already exists (case-insensitive)
+        $existingTags = $this->getAllTags(null, $truncatedNewName);
+        foreach ($existingTags as $existingTag) {
+            if (mb_strtolower($existingTag->getName()) === mb_strtolower($truncatedNewName)
+                && $existingTag->getId() !== $tagId) {
+                throw new TagAlreadyExistsException('Tag ' . $truncatedNewName . ' already exists');
+            }
+        }
+
+        $query = $this->connection->getQueryBuilder();
+        $query->update(self::TAG_TABLE)
+            ->set('name', $query->createParameter('name'))
+            ->set('visibility', $query->createParameter('visibility'))
+            ->set('editable', $query->createParameter('editable'))
+            ->set('color', $query->createParameter('color'))
+            ->where($query->expr()->eq('id', $query->createParameter('tagid')))
+            ->setParameter('name', $truncatedNewName)
+            ->setParameter('visibility', $userVisible ? 1 : 0)
+            ->setParameter('editable', $userAssignable ? 1 : 0)
+            ->setParameter('tagid', $tagId)
+            ->setParameter('color', $color);
+
+        try {
+            if ($query->execute() === 0) {
+                throw new TagNotFoundException(
+                    'Tag does not exist', 0, null, [$tagId]
+                );
+            }
+        } catch (UniqueConstraintViolationException $e) {
+            throw new TagAlreadyExistsException(
+                'Tag ("' . $newName . '", ' . $userVisible . ', ' . $userAssignable . ') already exists',
+                0,
+                $e
+            );
+        }
+
+        $this->dispatcher->dispatch(ManagerEvent::EVENT_UPDATE, new ManagerEvent(
+            ManagerEvent::EVENT_UPDATE, $afterUpdate, $beforeUpdate
+        ));
+    }
+
+    public function deleteTags($tagIds): void {
+        if (!\is_array($tagIds)) {
+            $tagIds = [$tagIds];
+        }
+
+        $tagNotFoundException = null;
+        $tags = [];
+        try {
+            $tags = $this->getTagsByIds($tagIds);
+        } catch (TagNotFoundException $e) {
+            $tagNotFoundException = $e;
+
+            // Get existing tag objects for the hooks later
+            $existingTags = array_diff($tagIds, $tagNotFoundException->getMissingTags());
+            if (!empty($existingTags)) {
+                try {
+                    $tags = $this->getTagsByIds($existingTags);
+                } catch (TagNotFoundException $e) {
+                    // Ignore further errors...
+                }
+            }
+        }
+
+        // delete relationships first
+        $query = $this->connection->getQueryBuilder();
+        $query->delete(SystemTagObjectMapper::RELATION_TABLE)
+            ->where($query->expr()->in('systemtagid', $query->createParameter('tagids')))
+            ->setParameter('tagids', $tagIds, IQueryBuilder::PARAM_INT_ARRAY)
+            ->execute();
+
+        $query = $this->connection->getQueryBuilder();
+        $query->delete(self::TAG_TABLE)
+            ->where($query->expr()->in('id', $query->createParameter('tagids')))
+            ->setParameter('tagids', $tagIds, IQueryBuilder::PARAM_INT_ARRAY)
+            ->execute();
+
+        foreach ($tags as $tag) {
+            $this->dispatcher->dispatch(ManagerEvent::EVENT_DELETE, new ManagerEvent(
+                ManagerEvent::EVENT_DELETE, $tag
+            ));
+        }
+
+        if ($tagNotFoundException !== null) {
+            throw new TagNotFoundException(
+                'Tag id(s) not found', 0, $tagNotFoundException, $tagNotFoundException->getMissingTags()
+            );
+        }
+    }
+
+    public function canUserAssignTag(ISystemTag $tag, ?IUser $user): bool {
+        if ($user === null) {
+            return false;
+        }
+
+        // early check to avoid unneeded group lookups
+        if ($tag->isUserAssignable() && $tag->isUserVisible()) {
+            return true;
+        }
+
+        if ($this->groupManager->isAdmin($user->getUID())) {
+            return true;
+        }
+
+        if (!$tag->isUserVisible()) {
+            return false;
+        }
+
+        $groupIds = $this->groupManager->getUserGroupIds($user);
+        if (!empty($groupIds)) {
+            $matchingGroups = array_intersect($groupIds, $this->getTagGroups($tag));
+            if (!empty($matchingGroups)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    public function canUserCreateTag(?IUser $user): bool {
+        if ($user === null) {
+            // If no user given, allows only calls from CLI
+            return \OC::$CLI;
+        }
+
+        if ($this->appConfig->getValueBool('systemtags', 'restrict_creation_to_admin', false) === false) {
+            return true;
+        }
+
+        return $this->groupManager->isAdmin($user->getUID());
+    }
+
+    public function canUserUpdateTag(?IUser $user): bool {
+        // We currently have no different permissions for updating tags than for creating them
+        return $this->canUserCreateTag($user);
+    }
+
+    public function canUserSeeTag(ISystemTag $tag, ?IUser $user): bool {
+        // If no user, then we only show public tags
+        if (!$user && $tag->getAccessLevel() === ISystemTag::ACCESS_LEVEL_PUBLIC) {
+            return true;
+        }
+
+        if ($tag->isUserVisible()) {
+            return true;
+        }
+
+        // if not returned yet, and user is not logged in, then the tag is not visible
+        if ($user === null) {
+            return false;
+        }
+
+        if ($this->groupManager->isAdmin($user->getUID())) {
+            return true;
+        }
+
+        return false;
+    }
+
+    private function createSystemTagFromRow($row): SystemTag {
+        return new SystemTag((string)$row['id'], $row['name'], (bool)$row['visibility'], (bool)$row['editable'], $row['etag'], $row['color']);
+    }
+
+    public function setTagGroups(ISystemTag $tag, array $groupIds): void {
+        // delete relationships first
+        $this->connection->beginTransaction();
+        try {
+            $query = $this->connection->getQueryBuilder();
+            $query->delete(self::TAG_GROUP_TABLE)
+                ->where($query->expr()->eq('systemtagid', $query->createNamedParameter($tag->getId())))
+                ->execute();
+
+            // add each group id
+            $query = $this->connection->getQueryBuilder();
+            $query->insert(self::TAG_GROUP_TABLE)
+                ->values([
+                    'systemtagid' => $query->createNamedParameter($tag->getId()),
+                    'gid' => $query->createParameter('gid'),
+                ]);
+            foreach ($groupIds as $groupId) {
+                if ($groupId === '') {
+                    continue;
+                }
+                $query->setParameter('gid', $groupId);
+                $query->execute();
+            }
+
+            $this->connection->commit();
+        } catch (\Exception $e) {
+            $this->connection->rollBack();
+            throw $e;
+        }
+    }
+
+    public function getTagGroups(ISystemTag $tag): array {
+        $groupIds = [];
+        $query = $this->connection->getQueryBuilder();
+        $query->select('gid')
+            ->from(self::TAG_GROUP_TABLE)
+            ->where($query->expr()->eq('systemtagid', $query->createNamedParameter($tag->getId())))
+            ->orderBy('gid');
+
+        $result = $query->execute();
+        while ($row = $result->fetch()) {
+            $groupIds[] = $row['gid'];
+        }
+
+        $result->closeCursor();
+
+        return $groupIds;
+    }
 
 }

Spacing +10 added lines, -10 removed lines

@@ -103,14 +103,14 @@ 
 			->from(self::TAG_TABLE);
 
 		if (!\is_null($visibilityFilter)) {
-			$query->andWhere($query->expr()->eq('visibility', $query->createNamedParameter((int)$visibilityFilter)));
+			$query->andWhere($query->expr()->eq('visibility', $query->createNamedParameter((int) $visibilityFilter)));
 		}
 
 		if (!empty($nameSearchPattern)) {
 			$query->andWhere(
 				$query->expr()->iLike(
 					'name',
-					$query->createNamedParameter('%' . $this->connection->escapeLikeParameter($nameSearchPattern) . '%')
+					$query->createNamedParameter('%'.$this->connection->escapeLikeParameter($nameSearchPattern).'%')
 				)
 			);
 		}
@@ -143,7 +143,7 @@ 
 		$result->closeCursor();
 		if (!$row) {
 			throw new TagNotFoundException(
-				'Tag ("' . $truncatedTagName . '", ' . $userVisible . ', ' . $userAssignable . ') does not exist'
+				'Tag ("'.$truncatedTagName.'", '.$userVisible.', '.$userAssignable.') does not exist'
 			);
 		}
 
@@ -160,7 +160,7 @@ 
 		$existingTags = $this->getAllTags(null, $tagName);
 		foreach ($existingTags as $existingTag) {
 			if (mb_strtolower($existingTag->getName()) === mb_strtolower($tagName)) {
-				throw new TagAlreadyExistsException('Tag ' . $tagName . ' already exists');
+				throw new TagAlreadyExistsException('Tag '.$tagName.' already exists');
 			}
 		}
 
@@ -172,14 +172,14 @@ 
 				'name' => $query->createNamedParameter($truncatedTagName),
 				'visibility' => $query->createNamedParameter($userVisible ? 1 : 0),
 				'editable' => $query->createNamedParameter($userAssignable ? 1 : 0),
-				'etag' => $query->createNamedParameter(md5((string)time())),
+				'etag' => $query->createNamedParameter(md5((string) time())),
 			]);
 
 		try {
 			$query->execute();
 		} catch (UniqueConstraintViolationException $e) {
 			throw new TagAlreadyExistsException(
-				'Tag ("' . $truncatedTagName . '", ' . $userVisible . ', ' . $userAssignable . ') already exists',
+				'Tag ("'.$truncatedTagName.'", '.$userVisible.', '.$userAssignable.') already exists',
 				0,
 				$e
 			);
@@ -188,7 +188,7 @@ 
 		$tagId = $query->getLastInsertId();
 
 		$tag = new SystemTag(
-			(string)$tagId,
+			(string) $tagId,
 			$truncatedTagName,
 			$userVisible,
 			$userAssignable
@@ -239,7 +239,7 @@ 
 		foreach ($existingTags as $existingTag) {
 			if (mb_strtolower($existingTag->getName()) === mb_strtolower($truncatedNewName)
 				&& $existingTag->getId() !== $tagId) {
-				throw new TagAlreadyExistsException('Tag ' . $truncatedNewName . ' already exists');
+				throw new TagAlreadyExistsException('Tag '.$truncatedNewName.' already exists');
 			}
 		}
 
@@ -264,7 +264,7 @@ 
 			}
 		} catch (UniqueConstraintViolationException $e) {
 			throw new TagAlreadyExistsException(
-				'Tag ("' . $newName . '", ' . $userVisible . ', ' . $userAssignable . ') already exists',
+				'Tag ("'.$newName.'", '.$userVisible.', '.$userAssignable.') already exists',
 				0,
 				$e
 			);
@@ -394,7 +394,7 @@ 
 	}
 
 	private function createSystemTagFromRow($row): SystemTag {
-		return new SystemTag((string)$row['id'], $row['name'], (bool)$row['visibility'], (bool)$row['editable'], $row['etag'], $row['color']);
+		return new SystemTag((string) $row['id'], $row['name'], (bool) $row['visibility'], (bool) $row['editable'], $row['etag'], $row['color']);
 	}
 
 	public function setTagGroups(ISystemTag $tag, array $groupIds): void {