nextcloud / server

tests/lib/L10N/FactoryTest.php

Indentation +761 added lines, -761 removed lines

@@ -24,765 +24,765 @@
 use Test\TestCase;
 
 class FactoryTest extends TestCase {
-	/** @var IConfig|MockObject */
-	protected $config;
-
-	/** @var IRequest|MockObject */
-	protected $request;
-
-	/** @var IUserSession|MockObject */
-	protected $userSession;
-
-	/** @var ICacheFactory|MockObject */
-	protected $cacheFactory;
-
-	/** @var string */
-	protected $serverRoot;
-
-	/** @var IAppManager|MockObject */
-	protected IAppManager $appManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->config = $this->createMock(IConfig::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->cacheFactory = $this->createMock(ICacheFactory::class);
-		$this->appManager = $this->createMock(IAppManager::class);
-
-		$this->serverRoot = \OC::$SERVERROOT;
-
-		$this->config
-			->method('getSystemValueBool')
-			->willReturnMap([
-				['installed', false, true],
-			]);
-	}
-
-	/**
-	 * @param string[] $methods
-	 * @param bool $mockRequestGetHeaderMethod
-	 *
-	 * @return Factory|MockObject
-	 */
-	protected function getFactory(array $methods = [], $mockRequestGetHeaderMethod = false) {
-		if ($mockRequestGetHeaderMethod) {
-			$this->request->expects(self::any())
-				->method('getHeader')
-				->willReturn('');
-		}
-
-		if (!empty($methods)) {
-			return $this->getMockBuilder(Factory::class)
-				->setConstructorArgs([
-					$this->config,
-					$this->request,
-					$this->userSession,
-					$this->cacheFactory,
-					$this->serverRoot,
-					$this->appManager,
-				])
-				->onlyMethods($methods)
-				->getMock();
-		}
-
-		return new Factory($this->config, $this->request, $this->userSession, $this->cacheFactory, $this->serverRoot, $this->appManager);
-	}
-
-	public static function dataFindAvailableLanguages(): array {
-		return [
-			[null],
-			['files'],
-		];
-	}
-
-	public function testFindLanguageWithExistingRequestLanguageAndNoApp(): void {
-		$factory = $this->getFactory(['languageExists']);
-		$this->invokePrivate($factory, 'requestLanguage', ['de']);
-		$factory->expects(self::once())
-			->method('languageExists')
-			->with(null, 'de')
-			->willReturn(true);
-
-		self::assertSame('de', $factory->findLanguage());
-	}
-
-	public function testFindLanguageWithExistingRequestLanguageAndApp(): void {
-		$factory = $this->getFactory(['languageExists']);
-		$this->invokePrivate($factory, 'requestLanguage', ['de']);
-		$factory->expects(self::once())
-			->method('languageExists')
-			->with('MyApp', 'de')
-			->willReturn(true);
-
-		self::assertSame('de', $factory->findLanguage('MyApp'));
-	}
-
-	public function testFindLanguageWithNotExistingRequestLanguageAndExistingStoredUserLanguage(): void {
-		$factory = $this->getFactory(['languageExists']);
-		$this->invokePrivate($factory, 'requestLanguage', ['de']);
-		$factory->expects($this->exactly(2))
-			->method('languageExists')
-			->willReturnMap([
-				['MyApp', 'de', false],
-				['MyApp', 'jp', true],
-			]);
-		$this->config
-			->expects($this->exactly(1))
-			->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false],
-			]);
-		$user = $this->createMock(IUser::class);
-		$user->expects(self::once())
-			->method('getUID')
-			->willReturn('MyUserUid');
-		$this->userSession
-			->expects(self::exactly(2))
-			->method('getUser')
-			->willReturn($user);
-		$this->config
-			->expects(self::once())
-			->method('getUserValue')
-			->with('MyUserUid', 'core', 'lang', null)
-			->willReturn('jp');
-
-		self::assertSame('jp', $factory->findLanguage('MyApp'));
-	}
-
-	public function testFindLanguageWithNotExistingRequestLanguageAndNotExistingStoredUserLanguage(): void {
-		$factory = $this->getFactory(['languageExists'], true);
-		$this->invokePrivate($factory, 'requestLanguage', ['de']);
-		$factory->expects($this->exactly(3))
-			->method('languageExists')
-			->willReturnMap([
-				['MyApp', 'de', false],
-				['MyApp', 'jp', false],
-				['MyApp', 'es', true],
-			]);
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false],
-				['default_language', false, 'es']
-			]);
-		$user = $this->createMock(IUser::class);
-		$user->expects(self::once())
-			->method('getUID')
-			->willReturn('MyUserUid');
-		$this->userSession
-			->expects(self::exactly(2))
-			->method('getUser')
-			->willReturn($user);
-		$this->config
-			->expects(self::once())
-			->method('getUserValue')
-			->with('MyUserUid', 'core', 'lang', null)
-			->willReturn('jp');
-
-		self::assertSame('es', $factory->findLanguage('MyApp'));
-	}
-
-	public function testFindLanguageWithNotExistingRequestLanguageAndNotExistingStoredUserLanguageAndNotExistingDefault(): void {
-		$factory = $this->getFactory(['languageExists'], true);
-		$this->invokePrivate($factory, 'requestLanguage', ['de']);
-		$factory->expects($this->exactly(3))
-			->method('languageExists')
-			->willReturnMap([
-				['MyApp', 'de', false],
-				['MyApp', 'jp', false],
-				['MyApp', 'es', false],
-			]);
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false],
-				['default_language', false, 'es']
-			]);
-		$user = $this->createMock(IUser::class);
-		$user->expects(self::once())
-			->method('getUID')
-			->willReturn('MyUserUid');
-		$this->userSession
-			->expects(self::exactly(2))
-			->method('getUser')
-			->willReturn($user);
-		$this->config
-			->expects(self::once())
-			->method('getUserValue')
-			->with('MyUserUid', 'core', 'lang', null)
-			->willReturn('jp');
-		$this->config
-			->expects(self::never())
-			->method('setUserValue');
-
-		self::assertSame('en', $factory->findLanguage('MyApp'));
-	}
-
-	public function testFindLanguageWithNotExistingRequestLanguageAndNotExistingStoredUserLanguageAndNotExistingDefaultAndNoAppInScope(): void {
-		$factory = $this->getFactory(['languageExists'], true);
-		$this->invokePrivate($factory, 'requestLanguage', ['de']);
-		$factory->expects($this->exactly(3))
-			->method('languageExists')
-			->willReturnMap([
-				['MyApp', 'de', false],
-				['MyApp', 'jp', false],
-				['MyApp', 'es', false],
-			]);
-		$this->config
-			->expects($this->exactly(2))
-			->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false],
-				['default_language', false, 'es']
-			]);
-		$user = $this->createMock(IUser::class);
-		$user->expects(self::once())
-			->method('getUID')
-			->willReturn('MyUserUid');
-		$this->userSession
-			->expects(self::exactly(2))
-			->method('getUser')
-			->willReturn($user);
-		$this->config
-			->expects(self::once())
-			->method('getUserValue')
-			->with('MyUserUid', 'core', 'lang', null)
-			->willReturn('jp');
-		$this->config
-			->expects(self::never())
-			->method('setUserValue')
-			->with('MyUserUid', 'core', 'lang', 'en');
-
-
-		self::assertSame('en', $factory->findLanguage('MyApp'));
-	}
-
-	public function testFindLanguageWithForcedLanguage(): void {
-		$factory = $this->getFactory(['languageExists']);
-		$this->config
-			->expects($this->once())
-			->method('getSystemValue')
-			->with('force_language', false)
-			->willReturn('de');
-
-		$factory->expects($this->once())
-			->method('languageExists')
-			->with('MyApp', 'de')
-			->willReturn(true);
-
-		self::assertSame('de', $factory->findLanguage('MyApp'));
-	}
-
-	/**
-	 * @dataProvider dataFindAvailableLanguages
-	 *
-	 * @param string|null $app
-	 */
-	public function testFindAvailableLanguages($app): void {
-		$factory = $this->getFactory(['findL10nDir']);
-		$factory->expects(self::once())
-			->method('findL10nDir')
-			->with($app)
-			->willReturn(\OC::$SERVERROOT . '/tests/data/l10n/');
-
-		self::assertEqualsCanonicalizing(['cs', 'de', 'en', 'ru'], $factory->findAvailableLanguages($app));
-	}
-
-	public static function dataLanguageExists(): array {
-		return [
-			[null, 'en', [], true],
-			[null, 'de', [], false],
-			[null, 'de', ['ru'], false],
-			[null, 'de', ['ru', 'de'], true],
-			['files', 'en', [], true],
-			['files', 'de', [], false],
-			['files', 'de', ['ru'], false],
-			['files', 'de', ['de', 'ru'], true],
-		];
-	}
-
-	public function testFindAvailableLanguagesWithThemes(): void {
-		$this->serverRoot .= '/tests/data';
-		$app = 'files';
-
-		$factory = $this->getFactory(['findL10nDir']);
-		$factory->expects(self::once())
-			->method('findL10nDir')
-			->with($app)
-			->willReturn($this->serverRoot . '/apps/files/l10n/');
-		$this->config
-			->expects(self::once())
-			->method('getSystemValueString')
-			->with('theme')
-			->willReturn('abc');
-
-		self::assertEqualsCanonicalizing(['en', 'zz'], $factory->findAvailableLanguages($app));
-	}
-
-	/**
-	 * @dataProvider dataLanguageExists
-	 *
-	 * @param string|null $app
-	 * @param string $lang
-	 * @param string[] $availableLanguages
-	 * @param string $expected
-	 */
-	public function testLanguageExists($app, $lang, array $availableLanguages, $expected): void {
-		$factory = $this->getFactory(['findAvailableLanguages']);
-		$factory->expects(($lang === 'en') ? self::never() : self::once())
-			->method('findAvailableLanguages')
-			->with($app)
-			->willReturn($availableLanguages);
-
-		self::assertSame($expected, $factory->languageExists($app, $lang));
-	}
-
-	public static function dataSetLanguageFromRequest(): array {
-		return [
-			// Language is available
-			[null, 'de', ['de'], 'de'],
-			[null, 'de,en', ['de'], 'de'],
-			[null, 'de-DE,en-US;q=0.8,en;q=0.6', ['de'], 'de'],
-			// Language is not available
-			[null, 'de', ['ru'], new LanguageNotFoundException()],
-			[null, 'de,en', ['ru', 'en'], 'en'],
-			[null, 'de-DE,en-US;q=0.8,en;q=0.6', ['ru', 'en'], 'en'],
-
-			// Language for app
-			['files_pdfviewer', 'de', ['de'], 'de'],
-			['files_pdfviewer', 'de,en', ['de'], 'de'],
-			['files_pdfviewer', 'de-DE,en-US;q=0.8,en;q=0.6', ['de'], 'de'],
-			// Language for app is not available
-			['files_pdfviewer', 'de', ['ru'], new LanguageNotFoundException()],
-			['files_pdfviewer', 'de,en', ['ru', 'en'], 'en'],
-			['files_pdfviewer', 'de-DE,en-US;q=0.8,en;q=0.6', ['ru', 'en'], 'en'],
-		];
-	}
-
-	/**
-	 * @dataProvider dataSetLanguageFromRequest
-	 *
-	 * @param string|null $app
-	 * @param string $header
-	 * @param string[] $availableLanguages
-	 * @param string $expected
-	 */
-	public function testGetLanguageFromRequest($app, $header, array $availableLanguages, $expected): void {
-		$factory = $this->getFactory(['findAvailableLanguages', 'respectDefaultLanguage']);
-		$factory->expects(self::once())
-			->method('findAvailableLanguages')
-			->with($app)
-			->willReturn($availableLanguages);
-
-		$factory->expects(self::any())
-			->method('respectDefaultLanguage')->willReturnCallback(function ($app, $lang) {
-				return $lang;
-			});
-
-		$this->request->expects(self::once())
-			->method('getHeader')
-			->with('ACCEPT_LANGUAGE')
-			->willReturn($header);
-
-		if ($expected instanceof LanguageNotFoundException) {
-			$this->expectException(LanguageNotFoundException::class);
-			self::invokePrivate($factory, 'getLanguageFromRequest', [$app]);
-		} else {
-			self::assertSame($expected, self::invokePrivate($factory, 'getLanguageFromRequest', [$app]), 'Asserting returned language');
-		}
-	}
-
-	public static function dataGetL10nFilesForApp(): array {
-		return [
-			['', 'de', [\OC::$SERVERROOT . '/core/l10n/de.json']],
-			['core', 'ru', [\OC::$SERVERROOT . '/core/l10n/ru.json']],
-			['lib', 'ru', [\OC::$SERVERROOT . '/lib/l10n/ru.json']],
-			['settings', 'de', [\OC::$SERVERROOT . '/apps/settings/l10n/de.json']],
-			['files', 'de', [\OC::$SERVERROOT . '/apps/files/l10n/de.json']],
-			['files', '_lang_never_exists_', []],
-			['_app_never_exists_', 'de', [\OC::$SERVERROOT . '/core/l10n/de.json']],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetL10nFilesForApp
-	 *
-	 * @param string $app
-	 * @param string $expected
-	 */
-	public function testGetL10nFilesForApp($app, $lang, $expected): void {
-		$factory = $this->getFactory();
-		if (in_array($app, ['settings','files'])) {
-			$this->appManager
-				->method('getAppPath')
-				->with($app)
-				->willReturn(\OC::$SERVERROOT . '/apps/' . $app);
-		} else {
-			$this->appManager
-				->method('getAppPath')
-				->with($app)
-				->willThrowException(new AppPathNotFoundException());
-		}
-		self::assertSame($expected, $this->invokePrivate($factory, 'getL10nFilesForApp', [$app, $lang]));
-	}
-
-	public static function dataFindL10NDir(): array {
-		return [
-			['', \OC::$SERVERROOT . '/core/l10n/'],
-			['core', \OC::$SERVERROOT . '/core/l10n/'],
-			['lib', \OC::$SERVERROOT . '/lib/l10n/'],
-			['settings', \OC::$SERVERROOT . '/apps/settings/l10n/'],
-			['files', \OC::$SERVERROOT . '/apps/files/l10n/'],
-			['_app_never_exists_', \OC::$SERVERROOT . '/core/l10n/'],
-		];
-	}
-
-	/**
-	 * @dataProvider dataFindL10NDir
-	 *
-	 * @param string $app
-	 * @param string $expected
-	 */
-	public function testFindL10NDir($app, $expected): void {
-		$factory = $this->getFactory();
-		if (in_array($app, ['settings','files'])) {
-			$this->appManager
-				->method('getAppPath')
-				->with($app)
-				->willReturn(\OC::$SERVERROOT . '/apps/' . $app);
-		} else {
-			$this->appManager
-				->method('getAppPath')
-				->with($app)
-				->willThrowException(new AppPathNotFoundException());
-		}
-		self::assertSame($expected, $this->invokePrivate($factory, 'findL10nDir', [$app]));
-	}
-
-	public static function dataFindLanguage(): array {
-		return [
-			// Not logged in
-			[false, [], 'en'],
-			[false, ['fr'], 'fr'],
-			[false, ['de', 'fr'], 'de'],
-			[false, ['nl', 'de', 'fr'], 'de'],
-
-			[true, [], 'en'],
-			[true, ['fr'], 'fr'],
-			[true, ['de', 'fr'], 'de'],
-			[true, ['nl', 'de', 'fr'], 'nl'],
-		];
-	}
-
-	/**
-	 * @dataProvider dataFindLanguage
-	 *
-	 * @param bool $loggedIn
-	 * @param array $availableLang
-	 * @param string $expected
-	 */
-	public function testFindLanguage($loggedIn, $availableLang, $expected): void {
-		$userLang = 'nl';
-		$browserLang = 'de';
-		$defaultLang = 'fr';
-
-		$this->config->expects(self::any())
-			->method('getSystemValue')
-			->willReturnCallback(function ($var, $default) use ($defaultLang) {
-				if ($var === 'default_language') {
-					return $defaultLang;
-				} else {
-					return $default;
-				}
-			});
-
-		if ($loggedIn) {
-			$user = $this->createMock(IUser::class);
-			$user->expects(self::any())
-				->method('getUID')
-				->willReturn('MyUserUid');
-			$this->userSession
-				->expects(self::any())
-				->method('getUser')
-				->willReturn($user);
-			$this->config->expects(self::any())
-				->method('getUserValue')
-				->with('MyUserUid', 'core', 'lang', null)
-				->willReturn($userLang);
-		} else {
-			$this->userSession
-				->expects(self::any())
-				->method('getUser')
-				->willReturn(null);
-		}
-
-		$this->request->expects(self::any())
-			->method('getHeader')
-			->with($this->equalTo('ACCEPT_LANGUAGE'))
-			->willReturn($browserLang);
-
-		$factory = $this->getFactory(['languageExists', 'findAvailableLanguages', 'respectDefaultLanguage']);
-		$factory->expects(self::any())
-			->method('languageExists')
-			->willReturnCallback(function ($app, $lang) use ($availableLang) {
-				return in_array($lang, $availableLang);
-			});
-		$factory->expects(self::any())
-			->method('findAvailableLanguages')
-			->willReturnCallback(function ($app) use ($availableLang) {
-				return $availableLang;
-			});
-		$factory->expects(self::any())
-			->method('respectDefaultLanguage')->willReturnCallback(function ($app, $lang) {
-				return $lang;
-			});
-
-		$lang = $factory->findLanguage();
-
-		self::assertSame($expected, $lang);
-	}
-
-	public function testFindGenericLanguageByEnforcedLanguage(): void {
-		$factory = $this->getFactory();
-		$this->config->expects(self::once())
-			->method('getSystemValue')
-			->with('force_language', false)
-			->willReturn('cz');
-
-		$lang = $factory->findGenericLanguage();
-
-		self::assertSame('cz', $lang);
-	}
-
-	public function testFindGenericLanguageByDefaultLanguage(): void {
-		$factory = $this->getFactory(['languageExists']);
-		$this->config->expects(self::exactly(2))
-			->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false,],
-				['default_language', false, 'cz',],
-			]);
-		$factory->expects(self::once())
-			->method('languageExists')
-			->with(null, 'cz')
-			->willReturn(true);
-
-		$lang = $factory->findGenericLanguage();
-
-		self::assertSame('cz', $lang);
-	}
-
-	public function testFindGenericLanguageByUserLanguage(): void {
-		$factory = $this->getFactory();
-		$this->config->expects(self::exactly(2))
-			->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false,],
-				['default_language', false, false,],
-			]);
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects(self::once())
-			->method('getUser')
-			->willReturn($user);
-		$user->method('getUID')->willReturn('user123');
-		$this->config->expects(self::once())
-			->method('getUserValue')
-			->with('user123', 'core', 'lang', null)
-			->willReturn('cz');
-
-		$lang = $factory->findGenericLanguage();
-
-		self::assertSame('cz', $lang);
-	}
-
-	public function testFindGenericLanguageByRequestLanguage(): void {
-		$factory = $this->getFactory(['findAvailableLanguages', 'languageExists']);
-		$this->config->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false,],
-				['default_language', false, false,],
-			]);
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects(self::once())
-			->method('getUser')
-			->willReturn($user);
-		$user->method('getUID')->willReturn('user123');
-		$this->config->expects(self::once())
-			->method('getUserValue')
-			->with('user123', 'core', 'lang', null)
-			->willReturn(null);
-		$this->request->expects(self::once())
-			->method('getHeader')
-			->with('ACCEPT_LANGUAGE')
-			->willReturn('cz');
-		$factory->expects(self::once())
-			->method('findAvailableLanguages')
-			->with(null)
-			->willReturn(['cz']);
-
-		$lang = $factory->findGenericLanguage();
-
-		self::assertSame('cz', $lang);
-	}
-
-	public function testFindGenericLanguageFallback(): void {
-		$factory = $this->getFactory(['findAvailableLanguages', 'languageExists']);
-		$this->config->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false,],
-				['default_language', false, false,],
-			]);
-		$user = $this->createMock(IUser::class);
-		$this->userSession->expects(self::once())
-			->method('getUser')
-			->willReturn($user);
-		$user->method('getUID')->willReturn('user123');
-		$this->config->expects(self::once())
-			->method('getUserValue')
-			->with('user123', 'core', 'lang', null)
-			->willReturn(null);
-		$this->request->expects(self::once())
-			->method('getHeader')
-			->with('ACCEPT_LANGUAGE')
-			->willReturn('');
-		$factory->expects(self::never())
-			->method('findAvailableLanguages');
-		$factory->expects(self::never())
-			->method('languageExists');
-
-		$lang = $factory->findGenericLanguage();
-
-		self::assertSame('en', $lang);
-	}
-
-	public static function dataTestRespectDefaultLanguage(): array {
-		return [
-			['de', 'de_DE', true, 'de_DE'],
-			['de', 'de', true, 'de'],
-			['de', false, true, 'de'],
-			['fr', 'de_DE', true, 'fr'],
-		];
-	}
-
-	/**
-	 * test if we respect default language if possible
-	 *
-	 * @dataProvider dataTestRespectDefaultLanguage
-	 *
-	 * @param string $lang
-	 * @param string $defaultLanguage
-	 * @param bool $langExists
-	 * @param string $expected
-	 */
-	public function testRespectDefaultLanguage($lang, $defaultLanguage, $langExists, $expected): void {
-		$factory = $this->getFactory(['languageExists']);
-		$factory->expects(self::any())
-			->method('languageExists')->willReturn($langExists);
-		$this->config->expects(self::any())
-			->method('getSystemValue')->with('default_language', false)->willReturn($defaultLanguage);
-
-		$result = $this->invokePrivate($factory, 'respectDefaultLanguage', ['app', $lang]);
-		self::assertSame($expected, $result);
-	}
-
-	public static function dataTestReduceToLanguages(): array {
-		return [
-			['en', ['en', 'de', 'fr', 'it', 'es'], ['en', 'fr', 'de'], ['en', 'fr', 'de']],
-			['en', ['en', 'de', 'fr', 'it', 'es'], ['en', 'de'], ['en', 'de']],
-			['en', ['en', 'de', 'fr', 'it', 'es'], [], ['de', 'en', 'es', 'fr', 'it']],
-		];
-	}
-
-	/**
-	 * test
-	 * - if available languages set can be reduced by configuration
-	 * - if available languages set is not reduced to an empty set if
-	 *   the reduce config is an empty set
-	 *
-	 * @dataProvider dataTestReduceToLanguages
-	 *
-	 * @param string $lang
-	 * @param array $availableLanguages
-	 * @param array $reducedLanguageSet
-	 * @param array $expected
-	 */
-	public function testReduceLanguagesByConfiguration(string $lang, array $availableLanguages, array $reducedLanguageSet, array $expected): void {
-		$factory = $this->getFactory(['findAvailableLanguages', 'languageExists']);
-		$factory->expects(self::any())
-			->method('languageExists')->willReturn(true);
-		$factory->expects(self::any())
-			->method('findAvailableLanguages')
-			->willReturnCallback(function ($app) use ($availableLanguages) {
-				return $availableLanguages;
-			});
-
-		$this->config
-			->method('getSystemValue')
-			->willReturnMap([
-				['force_language', false, false],
-				['default_language', false, $lang],
-				['reduce_to_languages', [], $reducedLanguageSet]
-			]);
-
-		$result = $this->invokePrivate($factory, 'getLanguages');
-		$commonLanguagesCodes = array_map(function ($lang) {
-			return $lang['code'];
-		}, $result['commonLanguages']);
-
-		self::assertEqualsCanonicalizing($expected, $commonLanguagesCodes);
-	}
-
-	public static function languageIteratorRequestProvider(): array {
-		return [
-			[ true, true],
-			[ false, true],
-			[ false, false],
-		];
-	}
-
-	/**
-	 * @dataProvider languageIteratorRequestProvider
-	 */
-	public function testGetLanguageIterator(bool $hasSession, bool $mockUser): void {
-		$factory = $this->getFactory();
-		$user = null;
-
-		if (!$mockUser) {
-			$matcher = $this->userSession->expects(self::once())
-				->method('getUser');
-
-			if ($hasSession) {
-				$matcher->willReturn($this->createMock(IUser::class));
-			} else {
-				$this->expectException(\RuntimeException::class);
-			}
-		} else {
-			$user = $this->createMock(IUser::class);
-		}
-
-		$iterator = $factory->getLanguageIterator($user);
-		self::assertInstanceOf(ILanguageIterator::class, $iterator);
-	}
-
-	public static function dataGetLanguageDirection(): array {
-		return [
-			['en', 'ltr'],
-			['de', 'ltr'],
-			['fa', 'rtl'],
-			['ar', 'rtl']
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetLanguageDirection
-	 */
-	public function testGetLanguageDirection(string $language, string $expectedDirection) {
-		$factory = $this->getFactory();
-
-		self::assertEquals($expectedDirection, $factory->getLanguageDirection($language));
-	}
+    /** @var IConfig|MockObject */
+    protected $config;
+
+    /** @var IRequest|MockObject */
+    protected $request;
+
+    /** @var IUserSession|MockObject */
+    protected $userSession;
+
+    /** @var ICacheFactory|MockObject */
+    protected $cacheFactory;
+
+    /** @var string */
+    protected $serverRoot;
+
+    /** @var IAppManager|MockObject */
+    protected IAppManager $appManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->config = $this->createMock(IConfig::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->cacheFactory = $this->createMock(ICacheFactory::class);
+        $this->appManager = $this->createMock(IAppManager::class);
+
+        $this->serverRoot = \OC::$SERVERROOT;
+
+        $this->config
+            ->method('getSystemValueBool')
+            ->willReturnMap([
+                ['installed', false, true],
+            ]);
+    }
+
+    /**
+     * @param string[] $methods
+     * @param bool $mockRequestGetHeaderMethod
+     *
+     * @return Factory|MockObject
+     */
+    protected function getFactory(array $methods = [], $mockRequestGetHeaderMethod = false) {
+        if ($mockRequestGetHeaderMethod) {
+            $this->request->expects(self::any())
+                ->method('getHeader')
+                ->willReturn('');
+        }
+
+        if (!empty($methods)) {
+            return $this->getMockBuilder(Factory::class)
+                ->setConstructorArgs([
+                    $this->config,
+                    $this->request,
+                    $this->userSession,
+                    $this->cacheFactory,
+                    $this->serverRoot,
+                    $this->appManager,
+                ])
+                ->onlyMethods($methods)
+                ->getMock();
+        }
+
+        return new Factory($this->config, $this->request, $this->userSession, $this->cacheFactory, $this->serverRoot, $this->appManager);
+    }
+
+    public static function dataFindAvailableLanguages(): array {
+        return [
+            [null],
+            ['files'],
+        ];
+    }
+
+    public function testFindLanguageWithExistingRequestLanguageAndNoApp(): void {
+        $factory = $this->getFactory(['languageExists']);
+        $this->invokePrivate($factory, 'requestLanguage', ['de']);
+        $factory->expects(self::once())
+            ->method('languageExists')
+            ->with(null, 'de')
+            ->willReturn(true);
+
+        self::assertSame('de', $factory->findLanguage());
+    }
+
+    public function testFindLanguageWithExistingRequestLanguageAndApp(): void {
+        $factory = $this->getFactory(['languageExists']);
+        $this->invokePrivate($factory, 'requestLanguage', ['de']);
+        $factory->expects(self::once())
+            ->method('languageExists')
+            ->with('MyApp', 'de')
+            ->willReturn(true);
+
+        self::assertSame('de', $factory->findLanguage('MyApp'));
+    }
+
+    public function testFindLanguageWithNotExistingRequestLanguageAndExistingStoredUserLanguage(): void {
+        $factory = $this->getFactory(['languageExists']);
+        $this->invokePrivate($factory, 'requestLanguage', ['de']);
+        $factory->expects($this->exactly(2))
+            ->method('languageExists')
+            ->willReturnMap([
+                ['MyApp', 'de', false],
+                ['MyApp', 'jp', true],
+            ]);
+        $this->config
+            ->expects($this->exactly(1))
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false],
+            ]);
+        $user = $this->createMock(IUser::class);
+        $user->expects(self::once())
+            ->method('getUID')
+            ->willReturn('MyUserUid');
+        $this->userSession
+            ->expects(self::exactly(2))
+            ->method('getUser')
+            ->willReturn($user);
+        $this->config
+            ->expects(self::once())
+            ->method('getUserValue')
+            ->with('MyUserUid', 'core', 'lang', null)
+            ->willReturn('jp');
+
+        self::assertSame('jp', $factory->findLanguage('MyApp'));
+    }
+
+    public function testFindLanguageWithNotExistingRequestLanguageAndNotExistingStoredUserLanguage(): void {
+        $factory = $this->getFactory(['languageExists'], true);
+        $this->invokePrivate($factory, 'requestLanguage', ['de']);
+        $factory->expects($this->exactly(3))
+            ->method('languageExists')
+            ->willReturnMap([
+                ['MyApp', 'de', false],
+                ['MyApp', 'jp', false],
+                ['MyApp', 'es', true],
+            ]);
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false],
+                ['default_language', false, 'es']
+            ]);
+        $user = $this->createMock(IUser::class);
+        $user->expects(self::once())
+            ->method('getUID')
+            ->willReturn('MyUserUid');
+        $this->userSession
+            ->expects(self::exactly(2))
+            ->method('getUser')
+            ->willReturn($user);
+        $this->config
+            ->expects(self::once())
+            ->method('getUserValue')
+            ->with('MyUserUid', 'core', 'lang', null)
+            ->willReturn('jp');
+
+        self::assertSame('es', $factory->findLanguage('MyApp'));
+    }
+
+    public function testFindLanguageWithNotExistingRequestLanguageAndNotExistingStoredUserLanguageAndNotExistingDefault(): void {
+        $factory = $this->getFactory(['languageExists'], true);
+        $this->invokePrivate($factory, 'requestLanguage', ['de']);
+        $factory->expects($this->exactly(3))
+            ->method('languageExists')
+            ->willReturnMap([
+                ['MyApp', 'de', false],
+                ['MyApp', 'jp', false],
+                ['MyApp', 'es', false],
+            ]);
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false],
+                ['default_language', false, 'es']
+            ]);
+        $user = $this->createMock(IUser::class);
+        $user->expects(self::once())
+            ->method('getUID')
+            ->willReturn('MyUserUid');
+        $this->userSession
+            ->expects(self::exactly(2))
+            ->method('getUser')
+            ->willReturn($user);
+        $this->config
+            ->expects(self::once())
+            ->method('getUserValue')
+            ->with('MyUserUid', 'core', 'lang', null)
+            ->willReturn('jp');
+        $this->config
+            ->expects(self::never())
+            ->method('setUserValue');
+
+        self::assertSame('en', $factory->findLanguage('MyApp'));
+    }
+
+    public function testFindLanguageWithNotExistingRequestLanguageAndNotExistingStoredUserLanguageAndNotExistingDefaultAndNoAppInScope(): void {
+        $factory = $this->getFactory(['languageExists'], true);
+        $this->invokePrivate($factory, 'requestLanguage', ['de']);
+        $factory->expects($this->exactly(3))
+            ->method('languageExists')
+            ->willReturnMap([
+                ['MyApp', 'de', false],
+                ['MyApp', 'jp', false],
+                ['MyApp', 'es', false],
+            ]);
+        $this->config
+            ->expects($this->exactly(2))
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false],
+                ['default_language', false, 'es']
+            ]);
+        $user = $this->createMock(IUser::class);
+        $user->expects(self::once())
+            ->method('getUID')
+            ->willReturn('MyUserUid');
+        $this->userSession
+            ->expects(self::exactly(2))
+            ->method('getUser')
+            ->willReturn($user);
+        $this->config
+            ->expects(self::once())
+            ->method('getUserValue')
+            ->with('MyUserUid', 'core', 'lang', null)
+            ->willReturn('jp');
+        $this->config
+            ->expects(self::never())
+            ->method('setUserValue')
+            ->with('MyUserUid', 'core', 'lang', 'en');
+
+
+        self::assertSame('en', $factory->findLanguage('MyApp'));
+    }
+
+    public function testFindLanguageWithForcedLanguage(): void {
+        $factory = $this->getFactory(['languageExists']);
+        $this->config
+            ->expects($this->once())
+            ->method('getSystemValue')
+            ->with('force_language', false)
+            ->willReturn('de');
+
+        $factory->expects($this->once())
+            ->method('languageExists')
+            ->with('MyApp', 'de')
+            ->willReturn(true);
+
+        self::assertSame('de', $factory->findLanguage('MyApp'));
+    }
+
+    /**
+     * @dataProvider dataFindAvailableLanguages
+     *
+     * @param string|null $app
+     */
+    public function testFindAvailableLanguages($app): void {
+        $factory = $this->getFactory(['findL10nDir']);
+        $factory->expects(self::once())
+            ->method('findL10nDir')
+            ->with($app)
+            ->willReturn(\OC::$SERVERROOT . '/tests/data/l10n/');
+
+        self::assertEqualsCanonicalizing(['cs', 'de', 'en', 'ru'], $factory->findAvailableLanguages($app));
+    }
+
+    public static function dataLanguageExists(): array {
+        return [
+            [null, 'en', [], true],
+            [null, 'de', [], false],
+            [null, 'de', ['ru'], false],
+            [null, 'de', ['ru', 'de'], true],
+            ['files', 'en', [], true],
+            ['files', 'de', [], false],
+            ['files', 'de', ['ru'], false],
+            ['files', 'de', ['de', 'ru'], true],
+        ];
+    }
+
+    public function testFindAvailableLanguagesWithThemes(): void {
+        $this->serverRoot .= '/tests/data';
+        $app = 'files';
+
+        $factory = $this->getFactory(['findL10nDir']);
+        $factory->expects(self::once())
+            ->method('findL10nDir')
+            ->with($app)
+            ->willReturn($this->serverRoot . '/apps/files/l10n/');
+        $this->config
+            ->expects(self::once())
+            ->method('getSystemValueString')
+            ->with('theme')
+            ->willReturn('abc');
+
+        self::assertEqualsCanonicalizing(['en', 'zz'], $factory->findAvailableLanguages($app));
+    }
+
+    /**
+     * @dataProvider dataLanguageExists
+     *
+     * @param string|null $app
+     * @param string $lang
+     * @param string[] $availableLanguages
+     * @param string $expected
+     */
+    public function testLanguageExists($app, $lang, array $availableLanguages, $expected): void {
+        $factory = $this->getFactory(['findAvailableLanguages']);
+        $factory->expects(($lang === 'en') ? self::never() : self::once())
+            ->method('findAvailableLanguages')
+            ->with($app)
+            ->willReturn($availableLanguages);
+
+        self::assertSame($expected, $factory->languageExists($app, $lang));
+    }
+
+    public static function dataSetLanguageFromRequest(): array {
+        return [
+            // Language is available
+            [null, 'de', ['de'], 'de'],
+            [null, 'de,en', ['de'], 'de'],
+            [null, 'de-DE,en-US;q=0.8,en;q=0.6', ['de'], 'de'],
+            // Language is not available
+            [null, 'de', ['ru'], new LanguageNotFoundException()],
+            [null, 'de,en', ['ru', 'en'], 'en'],
+            [null, 'de-DE,en-US;q=0.8,en;q=0.6', ['ru', 'en'], 'en'],
+
+            // Language for app
+            ['files_pdfviewer', 'de', ['de'], 'de'],
+            ['files_pdfviewer', 'de,en', ['de'], 'de'],
+            ['files_pdfviewer', 'de-DE,en-US;q=0.8,en;q=0.6', ['de'], 'de'],
+            // Language for app is not available
+            ['files_pdfviewer', 'de', ['ru'], new LanguageNotFoundException()],
+            ['files_pdfviewer', 'de,en', ['ru', 'en'], 'en'],
+            ['files_pdfviewer', 'de-DE,en-US;q=0.8,en;q=0.6', ['ru', 'en'], 'en'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataSetLanguageFromRequest
+     *
+     * @param string|null $app
+     * @param string $header
+     * @param string[] $availableLanguages
+     * @param string $expected
+     */
+    public function testGetLanguageFromRequest($app, $header, array $availableLanguages, $expected): void {
+        $factory = $this->getFactory(['findAvailableLanguages', 'respectDefaultLanguage']);
+        $factory->expects(self::once())
+            ->method('findAvailableLanguages')
+            ->with($app)
+            ->willReturn($availableLanguages);
+
+        $factory->expects(self::any())
+            ->method('respectDefaultLanguage')->willReturnCallback(function ($app, $lang) {
+                return $lang;
+            });
+
+        $this->request->expects(self::once())
+            ->method('getHeader')
+            ->with('ACCEPT_LANGUAGE')
+            ->willReturn($header);
+
+        if ($expected instanceof LanguageNotFoundException) {
+            $this->expectException(LanguageNotFoundException::class);
+            self::invokePrivate($factory, 'getLanguageFromRequest', [$app]);
+        } else {
+            self::assertSame($expected, self::invokePrivate($factory, 'getLanguageFromRequest', [$app]), 'Asserting returned language');
+        }
+    }
+
+    public static function dataGetL10nFilesForApp(): array {
+        return [
+            ['', 'de', [\OC::$SERVERROOT . '/core/l10n/de.json']],
+            ['core', 'ru', [\OC::$SERVERROOT . '/core/l10n/ru.json']],
+            ['lib', 'ru', [\OC::$SERVERROOT . '/lib/l10n/ru.json']],
+            ['settings', 'de', [\OC::$SERVERROOT . '/apps/settings/l10n/de.json']],
+            ['files', 'de', [\OC::$SERVERROOT . '/apps/files/l10n/de.json']],
+            ['files', '_lang_never_exists_', []],
+            ['_app_never_exists_', 'de', [\OC::$SERVERROOT . '/core/l10n/de.json']],
+        ];
+    }
+
+    /**
+     * @dataProvider dataGetL10nFilesForApp
+     *
+     * @param string $app
+     * @param string $expected
+     */
+    public function testGetL10nFilesForApp($app, $lang, $expected): void {
+        $factory = $this->getFactory();
+        if (in_array($app, ['settings','files'])) {
+            $this->appManager
+                ->method('getAppPath')
+                ->with($app)
+                ->willReturn(\OC::$SERVERROOT . '/apps/' . $app);
+        } else {
+            $this->appManager
+                ->method('getAppPath')
+                ->with($app)
+                ->willThrowException(new AppPathNotFoundException());
+        }
+        self::assertSame($expected, $this->invokePrivate($factory, 'getL10nFilesForApp', [$app, $lang]));
+    }
+
+    public static function dataFindL10NDir(): array {
+        return [
+            ['', \OC::$SERVERROOT . '/core/l10n/'],
+            ['core', \OC::$SERVERROOT . '/core/l10n/'],
+            ['lib', \OC::$SERVERROOT . '/lib/l10n/'],
+            ['settings', \OC::$SERVERROOT . '/apps/settings/l10n/'],
+            ['files', \OC::$SERVERROOT . '/apps/files/l10n/'],
+            ['_app_never_exists_', \OC::$SERVERROOT . '/core/l10n/'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataFindL10NDir
+     *
+     * @param string $app
+     * @param string $expected
+     */
+    public function testFindL10NDir($app, $expected): void {
+        $factory = $this->getFactory();
+        if (in_array($app, ['settings','files'])) {
+            $this->appManager
+                ->method('getAppPath')
+                ->with($app)
+                ->willReturn(\OC::$SERVERROOT . '/apps/' . $app);
+        } else {
+            $this->appManager
+                ->method('getAppPath')
+                ->with($app)
+                ->willThrowException(new AppPathNotFoundException());
+        }
+        self::assertSame($expected, $this->invokePrivate($factory, 'findL10nDir', [$app]));
+    }
+
+    public static function dataFindLanguage(): array {
+        return [
+            // Not logged in
+            [false, [], 'en'],
+            [false, ['fr'], 'fr'],
+            [false, ['de', 'fr'], 'de'],
+            [false, ['nl', 'de', 'fr'], 'de'],
+
+            [true, [], 'en'],
+            [true, ['fr'], 'fr'],
+            [true, ['de', 'fr'], 'de'],
+            [true, ['nl', 'de', 'fr'], 'nl'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataFindLanguage
+     *
+     * @param bool $loggedIn
+     * @param array $availableLang
+     * @param string $expected
+     */
+    public function testFindLanguage($loggedIn, $availableLang, $expected): void {
+        $userLang = 'nl';
+        $browserLang = 'de';
+        $defaultLang = 'fr';
+
+        $this->config->expects(self::any())
+            ->method('getSystemValue')
+            ->willReturnCallback(function ($var, $default) use ($defaultLang) {
+                if ($var === 'default_language') {
+                    return $defaultLang;
+                } else {
+                    return $default;
+                }
+            });
+
+        if ($loggedIn) {
+            $user = $this->createMock(IUser::class);
+            $user->expects(self::any())
+                ->method('getUID')
+                ->willReturn('MyUserUid');
+            $this->userSession
+                ->expects(self::any())
+                ->method('getUser')
+                ->willReturn($user);
+            $this->config->expects(self::any())
+                ->method('getUserValue')
+                ->with('MyUserUid', 'core', 'lang', null)
+                ->willReturn($userLang);
+        } else {
+            $this->userSession
+                ->expects(self::any())
+                ->method('getUser')
+                ->willReturn(null);
+        }
+
+        $this->request->expects(self::any())
+            ->method('getHeader')
+            ->with($this->equalTo('ACCEPT_LANGUAGE'))
+            ->willReturn($browserLang);
+
+        $factory = $this->getFactory(['languageExists', 'findAvailableLanguages', 'respectDefaultLanguage']);
+        $factory->expects(self::any())
+            ->method('languageExists')
+            ->willReturnCallback(function ($app, $lang) use ($availableLang) {
+                return in_array($lang, $availableLang);
+            });
+        $factory->expects(self::any())
+            ->method('findAvailableLanguages')
+            ->willReturnCallback(function ($app) use ($availableLang) {
+                return $availableLang;
+            });
+        $factory->expects(self::any())
+            ->method('respectDefaultLanguage')->willReturnCallback(function ($app, $lang) {
+                return $lang;
+            });
+
+        $lang = $factory->findLanguage();
+
+        self::assertSame($expected, $lang);
+    }
+
+    public function testFindGenericLanguageByEnforcedLanguage(): void {
+        $factory = $this->getFactory();
+        $this->config->expects(self::once())
+            ->method('getSystemValue')
+            ->with('force_language', false)
+            ->willReturn('cz');
+
+        $lang = $factory->findGenericLanguage();
+
+        self::assertSame('cz', $lang);
+    }
+
+    public function testFindGenericLanguageByDefaultLanguage(): void {
+        $factory = $this->getFactory(['languageExists']);
+        $this->config->expects(self::exactly(2))
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false,],
+                ['default_language', false, 'cz',],
+            ]);
+        $factory->expects(self::once())
+            ->method('languageExists')
+            ->with(null, 'cz')
+            ->willReturn(true);
+
+        $lang = $factory->findGenericLanguage();
+
+        self::assertSame('cz', $lang);
+    }
+
+    public function testFindGenericLanguageByUserLanguage(): void {
+        $factory = $this->getFactory();
+        $this->config->expects(self::exactly(2))
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false,],
+                ['default_language', false, false,],
+            ]);
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects(self::once())
+            ->method('getUser')
+            ->willReturn($user);
+        $user->method('getUID')->willReturn('user123');
+        $this->config->expects(self::once())
+            ->method('getUserValue')
+            ->with('user123', 'core', 'lang', null)
+            ->willReturn('cz');
+
+        $lang = $factory->findGenericLanguage();
+
+        self::assertSame('cz', $lang);
+    }
+
+    public function testFindGenericLanguageByRequestLanguage(): void {
+        $factory = $this->getFactory(['findAvailableLanguages', 'languageExists']);
+        $this->config->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false,],
+                ['default_language', false, false,],
+            ]);
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects(self::once())
+            ->method('getUser')
+            ->willReturn($user);
+        $user->method('getUID')->willReturn('user123');
+        $this->config->expects(self::once())
+            ->method('getUserValue')
+            ->with('user123', 'core', 'lang', null)
+            ->willReturn(null);
+        $this->request->expects(self::once())
+            ->method('getHeader')
+            ->with('ACCEPT_LANGUAGE')
+            ->willReturn('cz');
+        $factory->expects(self::once())
+            ->method('findAvailableLanguages')
+            ->with(null)
+            ->willReturn(['cz']);
+
+        $lang = $factory->findGenericLanguage();
+
+        self::assertSame('cz', $lang);
+    }
+
+    public function testFindGenericLanguageFallback(): void {
+        $factory = $this->getFactory(['findAvailableLanguages', 'languageExists']);
+        $this->config->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false,],
+                ['default_language', false, false,],
+            ]);
+        $user = $this->createMock(IUser::class);
+        $this->userSession->expects(self::once())
+            ->method('getUser')
+            ->willReturn($user);
+        $user->method('getUID')->willReturn('user123');
+        $this->config->expects(self::once())
+            ->method('getUserValue')
+            ->with('user123', 'core', 'lang', null)
+            ->willReturn(null);
+        $this->request->expects(self::once())
+            ->method('getHeader')
+            ->with('ACCEPT_LANGUAGE')
+            ->willReturn('');
+        $factory->expects(self::never())
+            ->method('findAvailableLanguages');
+        $factory->expects(self::never())
+            ->method('languageExists');
+
+        $lang = $factory->findGenericLanguage();
+
+        self::assertSame('en', $lang);
+    }
+
+    public static function dataTestRespectDefaultLanguage(): array {
+        return [
+            ['de', 'de_DE', true, 'de_DE'],
+            ['de', 'de', true, 'de'],
+            ['de', false, true, 'de'],
+            ['fr', 'de_DE', true, 'fr'],
+        ];
+    }
+
+    /**
+     * test if we respect default language if possible
+     *
+     * @dataProvider dataTestRespectDefaultLanguage
+     *
+     * @param string $lang
+     * @param string $defaultLanguage
+     * @param bool $langExists
+     * @param string $expected
+     */
+    public function testRespectDefaultLanguage($lang, $defaultLanguage, $langExists, $expected): void {
+        $factory = $this->getFactory(['languageExists']);
+        $factory->expects(self::any())
+            ->method('languageExists')->willReturn($langExists);
+        $this->config->expects(self::any())
+            ->method('getSystemValue')->with('default_language', false)->willReturn($defaultLanguage);
+
+        $result = $this->invokePrivate($factory, 'respectDefaultLanguage', ['app', $lang]);
+        self::assertSame($expected, $result);
+    }
+
+    public static function dataTestReduceToLanguages(): array {
+        return [
+            ['en', ['en', 'de', 'fr', 'it', 'es'], ['en', 'fr', 'de'], ['en', 'fr', 'de']],
+            ['en', ['en', 'de', 'fr', 'it', 'es'], ['en', 'de'], ['en', 'de']],
+            ['en', ['en', 'de', 'fr', 'it', 'es'], [], ['de', 'en', 'es', 'fr', 'it']],
+        ];
+    }
+
+    /**
+     * test
+     * - if available languages set can be reduced by configuration
+     * - if available languages set is not reduced to an empty set if
+     *   the reduce config is an empty set
+     *
+     * @dataProvider dataTestReduceToLanguages
+     *
+     * @param string $lang
+     * @param array $availableLanguages
+     * @param array $reducedLanguageSet
+     * @param array $expected
+     */
+    public function testReduceLanguagesByConfiguration(string $lang, array $availableLanguages, array $reducedLanguageSet, array $expected): void {
+        $factory = $this->getFactory(['findAvailableLanguages', 'languageExists']);
+        $factory->expects(self::any())
+            ->method('languageExists')->willReturn(true);
+        $factory->expects(self::any())
+            ->method('findAvailableLanguages')
+            ->willReturnCallback(function ($app) use ($availableLanguages) {
+                return $availableLanguages;
+            });
+
+        $this->config
+            ->method('getSystemValue')
+            ->willReturnMap([
+                ['force_language', false, false],
+                ['default_language', false, $lang],
+                ['reduce_to_languages', [], $reducedLanguageSet]
+            ]);
+
+        $result = $this->invokePrivate($factory, 'getLanguages');
+        $commonLanguagesCodes = array_map(function ($lang) {
+            return $lang['code'];
+        }, $result['commonLanguages']);
+
+        self::assertEqualsCanonicalizing($expected, $commonLanguagesCodes);
+    }
+
+    public static function languageIteratorRequestProvider(): array {
+        return [
+            [ true, true],
+            [ false, true],
+            [ false, false],
+        ];
+    }
+
+    /**
+     * @dataProvider languageIteratorRequestProvider
+     */
+    public function testGetLanguageIterator(bool $hasSession, bool $mockUser): void {
+        $factory = $this->getFactory();
+        $user = null;
+
+        if (!$mockUser) {
+            $matcher = $this->userSession->expects(self::once())
+                ->method('getUser');
+
+            if ($hasSession) {
+                $matcher->willReturn($this->createMock(IUser::class));
+            } else {
+                $this->expectException(\RuntimeException::class);
+            }
+        } else {
+            $user = $this->createMock(IUser::class);
+        }
+
+        $iterator = $factory->getLanguageIterator($user);
+        self::assertInstanceOf(ILanguageIterator::class, $iterator);
+    }
+
+    public static function dataGetLanguageDirection(): array {
+        return [
+            ['en', 'ltr'],
+            ['de', 'ltr'],
+            ['fa', 'rtl'],
+            ['ar', 'rtl']
+        ];
+    }
+
+    /**
+     * @dataProvider dataGetLanguageDirection
+     */
+    public function testGetLanguageDirection(string $language, string $expectedDirection) {
+        $factory = $this->getFactory();
+
+        self::assertEquals($expectedDirection, $factory->getLanguageDirection($language));
+    }
 }

Spacing +36 added lines, -36 removed lines

@@ -287,7 +287,7 @@ 
 		$factory->expects(self::once())
 			->method('findL10nDir')
 			->with($app)
-			->willReturn(\OC::$SERVERROOT . '/tests/data/l10n/');
+			->willReturn(\OC::$SERVERROOT.'/tests/data/l10n/');
 
 		self::assertEqualsCanonicalizing(['cs', 'de', 'en', 'ru'], $factory->findAvailableLanguages($app));
 	}
@@ -313,7 +313,7 @@ 
 		$factory->expects(self::once())
 			->method('findL10nDir')
 			->with($app)
-			->willReturn($this->serverRoot . '/apps/files/l10n/');
+			->willReturn($this->serverRoot.'/apps/files/l10n/');
 		$this->config
 			->expects(self::once())
 			->method('getSystemValueString')
@@ -379,7 +379,7 @@ 
 			->willReturn($availableLanguages);
 
 		$factory->expects(self::any())
-			->method('respectDefaultLanguage')->willReturnCallback(function ($app, $lang) {
+			->method('respectDefaultLanguage')->willReturnCallback(function($app, $lang) {
 				return $lang;
 			});
 
@@ -398,13 +398,13 @@ 
 
 	public static function dataGetL10nFilesForApp(): array {
 		return [
-			['', 'de', [\OC::$SERVERROOT . '/core/l10n/de.json']],
-			['core', 'ru', [\OC::$SERVERROOT . '/core/l10n/ru.json']],
-			['lib', 'ru', [\OC::$SERVERROOT . '/lib/l10n/ru.json']],
-			['settings', 'de', [\OC::$SERVERROOT . '/apps/settings/l10n/de.json']],
-			['files', 'de', [\OC::$SERVERROOT . '/apps/files/l10n/de.json']],
+			['', 'de', [\OC::$SERVERROOT.'/core/l10n/de.json']],
+			['core', 'ru', [\OC::$SERVERROOT.'/core/l10n/ru.json']],
+			['lib', 'ru', [\OC::$SERVERROOT.'/lib/l10n/ru.json']],
+			['settings', 'de', [\OC::$SERVERROOT.'/apps/settings/l10n/de.json']],
+			['files', 'de', [\OC::$SERVERROOT.'/apps/files/l10n/de.json']],
 			['files', '_lang_never_exists_', []],
-			['_app_never_exists_', 'de', [\OC::$SERVERROOT . '/core/l10n/de.json']],
+			['_app_never_exists_', 'de', [\OC::$SERVERROOT.'/core/l10n/de.json']],
 		];
 	}
 
@@ -416,11 +416,11 @@ 
 	 */
 	public function testGetL10nFilesForApp($app, $lang, $expected): void {
 		$factory = $this->getFactory();
-		if (in_array($app, ['settings','files'])) {
+		if (in_array($app, ['settings', 'files'])) {
 			$this->appManager
 				->method('getAppPath')
 				->with($app)
-				->willReturn(\OC::$SERVERROOT . '/apps/' . $app);
+				->willReturn(\OC::$SERVERROOT.'/apps/'.$app);
 		} else {
 			$this->appManager
 				->method('getAppPath')
@@ -432,12 +432,12 @@ 
 
 	public static function dataFindL10NDir(): array {
 		return [
-			['', \OC::$SERVERROOT . '/core/l10n/'],
-			['core', \OC::$SERVERROOT . '/core/l10n/'],
-			['lib', \OC::$SERVERROOT . '/lib/l10n/'],
-			['settings', \OC::$SERVERROOT . '/apps/settings/l10n/'],
-			['files', \OC::$SERVERROOT . '/apps/files/l10n/'],
-			['_app_never_exists_', \OC::$SERVERROOT . '/core/l10n/'],
+			['', \OC::$SERVERROOT.'/core/l10n/'],
+			['core', \OC::$SERVERROOT.'/core/l10n/'],
+			['lib', \OC::$SERVERROOT.'/lib/l10n/'],
+			['settings', \OC::$SERVERROOT.'/apps/settings/l10n/'],
+			['files', \OC::$SERVERROOT.'/apps/files/l10n/'],
+			['_app_never_exists_', \OC::$SERVERROOT.'/core/l10n/'],
 		];
 	}
 
@@ -449,11 +449,11 @@ 
 	 */
 	public function testFindL10NDir($app, $expected): void {
 		$factory = $this->getFactory();
-		if (in_array($app, ['settings','files'])) {
+		if (in_array($app, ['settings', 'files'])) {
 			$this->appManager
 				->method('getAppPath')
 				->with($app)
-				->willReturn(\OC::$SERVERROOT . '/apps/' . $app);
+				->willReturn(\OC::$SERVERROOT.'/apps/'.$app);
 		} else {
 			$this->appManager
 				->method('getAppPath')
@@ -492,7 +492,7 @@ 
 
 		$this->config->expects(self::any())
 			->method('getSystemValue')
-			->willReturnCallback(function ($var, $default) use ($defaultLang) {
+			->willReturnCallback(function($var, $default) use ($defaultLang) {
 				if ($var === 'default_language') {
 					return $defaultLang;
 				} else {
@@ -528,16 +528,16 @@ 
 		$factory = $this->getFactory(['languageExists', 'findAvailableLanguages', 'respectDefaultLanguage']);
 		$factory->expects(self::any())
 			->method('languageExists')
-			->willReturnCallback(function ($app, $lang) use ($availableLang) {
+			->willReturnCallback(function($app, $lang) use ($availableLang) {
 				return in_array($lang, $availableLang);
 			});
 		$factory->expects(self::any())
 			->method('findAvailableLanguages')
-			->willReturnCallback(function ($app) use ($availableLang) {
+			->willReturnCallback(function($app) use ($availableLang) {
 				return $availableLang;
 			});
 		$factory->expects(self::any())
-			->method('respectDefaultLanguage')->willReturnCallback(function ($app, $lang) {
+			->method('respectDefaultLanguage')->willReturnCallback(function($app, $lang) {
 				return $lang;
 			});
 
@@ -563,8 +563,8 @@ 
 		$this->config->expects(self::exactly(2))
 			->method('getSystemValue')
 			->willReturnMap([
-				['force_language', false, false,],
-				['default_language', false, 'cz',],
+				['force_language', false, false, ],
+				['default_language', false, 'cz', ],
 			]);
 		$factory->expects(self::once())
 			->method('languageExists')
@@ -581,8 +581,8 @@ 
 		$this->config->expects(self::exactly(2))
 			->method('getSystemValue')
 			->willReturnMap([
-				['force_language', false, false,],
-				['default_language', false, false,],
+				['force_language', false, false, ],
+				['default_language', false, false, ],
 			]);
 		$user = $this->createMock(IUser::class);
 		$this->userSession->expects(self::once())
@@ -603,8 +603,8 @@ 
 		$factory = $this->getFactory(['findAvailableLanguages', 'languageExists']);
 		$this->config->method('getSystemValue')
 			->willReturnMap([
-				['force_language', false, false,],
-				['default_language', false, false,],
+				['force_language', false, false, ],
+				['default_language', false, false, ],
 			]);
 		$user = $this->createMock(IUser::class);
 		$this->userSession->expects(self::once())
@@ -633,8 +633,8 @@ 
 		$factory = $this->getFactory(['findAvailableLanguages', 'languageExists']);
 		$this->config->method('getSystemValue')
 			->willReturnMap([
-				['force_language', false, false,],
-				['default_language', false, false,],
+				['force_language', false, false, ],
+				['default_language', false, false, ],
 			]);
 		$user = $this->createMock(IUser::class);
 		$this->userSession->expects(self::once())
@@ -716,7 +716,7 @@ 
 			->method('languageExists')->willReturn(true);
 		$factory->expects(self::any())
 			->method('findAvailableLanguages')
-			->willReturnCallback(function ($app) use ($availableLanguages) {
+			->willReturnCallback(function($app) use ($availableLanguages) {
 				return $availableLanguages;
 			});
 
@@ -729,7 +729,7 @@ 
 			]);
 
 		$result = $this->invokePrivate($factory, 'getLanguages');
-		$commonLanguagesCodes = array_map(function ($lang) {
+		$commonLanguagesCodes = array_map(function($lang) {
 			return $lang['code'];
 		}, $result['commonLanguages']);
 
@@ -738,9 +738,9 @@ 
 
 	public static function languageIteratorRequestProvider(): array {
 		return [
-			[ true, true],
-			[ false, true],
-			[ false, false],
+			[true, true],
+			[false, true],
+			[false, false],
 		];
 	}
 

tests/lib/Security/IdentityProof/ManagerTest.php

Indentation +189 added lines, -189 removed lines

@@ -24,193 +24,193 @@
 use Test\TestCase;
 
 class ManagerTest extends TestCase {
-	/** @var Factory|MockObject */
-	private $factory;
-	/** @var IAppData|MockObject */
-	private $appData;
-	/** @var ICrypto|MockObject */
-	private $crypto;
-	/** @var Manager|MockObject */
-	private $manager;
-	/** @var IConfig|MockObject */
-	private $config;
-	/** @var LoggerInterface|MockObject */
-	private $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		/** @var Factory|\PHPUnit\Framework\MockObject\MockObject $factory */
-		$this->factory = $this->createMock(Factory::class);
-		$this->appData = $this->createMock(AppData::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->factory->expects($this->any())
-			->method('get')
-			->with('identityproof')
-			->willReturn($this->appData);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->crypto = $this->createMock(ICrypto::class);
-		$this->manager = $this->getManager(['generateKeyPair']);
-	}
-
-	/**
-	 * create manager object
-	 *
-	 * @param array $setMethods
-	 * @return Manager|\PHPUnit\Framework\MockObject\MockObject
-	 */
-	protected function getManager($setMethods = []) {
-		if (empty($setMethods)) {
-			return new Manager(
-				$this->factory,
-				$this->crypto,
-				$this->config,
-				$this->logger
-			);
-		} else {
-			return $this->getMockBuilder(Manager::class)
-				->setConstructorArgs([
-					$this->factory,
-					$this->crypto,
-					$this->config,
-					$this->logger
-				])
-				->onlyMethods($setMethods)
-				->getMock();
-		}
-	}
-
-	public function testGetKeyWithExistingKey(): void {
-		$user = $this->createMock(IUser::class);
-		$user
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('MyUid');
-		$folder = $this->createMock(ISimpleFolder::class);
-		$privateFile = $this->createMock(ISimpleFile::class);
-		$privateFile
-			->expects($this->once())
-			->method('getContent')
-			->willReturn('EncryptedPrivateKey');
-		$publicFile = $this->createMock(ISimpleFile::class);
-		$publicFile
-			->expects($this->once())
-			->method('getContent')
-			->willReturn('MyPublicKey');
-		$this->crypto
-			->expects($this->once())
-			->method('decrypt')
-			->with('EncryptedPrivateKey')
-			->willReturn('MyPrivateKey');
-		$folder
-			->expects($this->exactly(2))
-			->method('getFile')
-			->willReturnMap([
-				['private', $privateFile],
-				['public', $publicFile],
-			]);
-		$this->appData
-			->expects($this->once())
-			->method('getFolder')
-			->with('user-MyUid')
-			->willReturn($folder);
-
-		$expected = new Key('MyPublicKey', 'MyPrivateKey');
-		$this->assertEquals($expected, $this->manager->getKey($user));
-	}
-
-	public function testGetKeyWithNotExistingKey(): void {
-		$user = $this->createMock(IUser::class);
-		$user
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('MyUid');
-		$this->manager
-			->expects($this->once())
-			->method('generateKeyPair')
-			->willReturn(['MyNewPublicKey', 'MyNewPrivateKey']);
-		$this->appData
-			->expects($this->once())
-			->method('newFolder')
-			->with('user-MyUid');
-		$folder = $this->createMock(ISimpleFolder::class);
-		$this->crypto
-			->expects($this->once())
-			->method('encrypt')
-			->with('MyNewPrivateKey')
-			->willReturn('MyNewEncryptedPrivateKey');
-		$privateFile = $this->createMock(ISimpleFile::class);
-		$privateFile
-			->expects($this->once())
-			->method('putContent')
-			->with('MyNewEncryptedPrivateKey');
-		$publicFile = $this->createMock(ISimpleFile::class);
-		$publicFile
-			->expects($this->once())
-			->method('putContent')
-			->with('MyNewPublicKey');
-		$folder
-			->expects($this->exactly(2))
-			->method('newFile')
-			->willReturnMap([
-				['private', null, $privateFile],
-				['public', null, $publicFile],
-			]);
-		$this->appData
-			->expects($this->exactly(2))
-			->method('getFolder')
-			->with('user-MyUid')
-			->willReturnOnConsecutiveCalls(
-				$this->throwException(new \Exception()),
-				$folder
-			);
-
-
-		$expected = new Key('MyNewPublicKey', 'MyNewPrivateKey');
-		$this->assertEquals($expected, $this->manager->getKey($user));
-	}
-
-	public function testGenerateKeyPair(): void {
-		$manager = $this->getManager();
-		$data = 'MyTestData';
-
-		[$resultPublicKey, $resultPrivateKey] = self::invokePrivate($manager, 'generateKeyPair');
-		openssl_sign($data, $signature, $resultPrivateKey);
-		$details = openssl_pkey_get_details(openssl_pkey_get_public($resultPublicKey));
-
-		$this->assertSame(1, openssl_verify($data, $signature, $resultPublicKey));
-		$this->assertSame(2048, $details['bits']);
-	}
-
-	public function testGetSystemKey(): void {
-		$manager = $this->getManager(['retrieveKey']);
-
-		/** @var Key|\PHPUnit\Framework\MockObject\MockObject $key */
-		$key = $this->createMock(Key::class);
-
-		$this->config->expects($this->once())->method('getSystemValue')
-			->with('instanceid', null)->willReturn('instanceId');
-
-		$manager->expects($this->once())->method('retrieveKey')->with('system-instanceId')
-			->willReturn($key);
-
-		$this->assertSame($key, $manager->getSystemKey());
-	}
-
-
-
-	public function testGetSystemKeyFailure(): void {
-		$this->expectException(\RuntimeException::class);
-
-		$manager = $this->getManager(['retrieveKey']);
-
-		/** @var Key|\PHPUnit\Framework\MockObject\MockObject $key */
-		$key = $this->createMock(Key::class);
-
-		$this->config->expects($this->once())->method('getSystemValue')
-			->with('instanceid', null)->willReturn(null);
-
-		$manager->getSystemKey();
-	}
+    /** @var Factory|MockObject */
+    private $factory;
+    /** @var IAppData|MockObject */
+    private $appData;
+    /** @var ICrypto|MockObject */
+    private $crypto;
+    /** @var Manager|MockObject */
+    private $manager;
+    /** @var IConfig|MockObject */
+    private $config;
+    /** @var LoggerInterface|MockObject */
+    private $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        /** @var Factory|\PHPUnit\Framework\MockObject\MockObject $factory */
+        $this->factory = $this->createMock(Factory::class);
+        $this->appData = $this->createMock(AppData::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->factory->expects($this->any())
+            ->method('get')
+            ->with('identityproof')
+            ->willReturn($this->appData);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->crypto = $this->createMock(ICrypto::class);
+        $this->manager = $this->getManager(['generateKeyPair']);
+    }
+
+    /**
+     * create manager object
+     *
+     * @param array $setMethods
+     * @return Manager|\PHPUnit\Framework\MockObject\MockObject
+     */
+    protected function getManager($setMethods = []) {
+        if (empty($setMethods)) {
+            return new Manager(
+                $this->factory,
+                $this->crypto,
+                $this->config,
+                $this->logger
+            );
+        } else {
+            return $this->getMockBuilder(Manager::class)
+                ->setConstructorArgs([
+                    $this->factory,
+                    $this->crypto,
+                    $this->config,
+                    $this->logger
+                ])
+                ->onlyMethods($setMethods)
+                ->getMock();
+        }
+    }
+
+    public function testGetKeyWithExistingKey(): void {
+        $user = $this->createMock(IUser::class);
+        $user
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('MyUid');
+        $folder = $this->createMock(ISimpleFolder::class);
+        $privateFile = $this->createMock(ISimpleFile::class);
+        $privateFile
+            ->expects($this->once())
+            ->method('getContent')
+            ->willReturn('EncryptedPrivateKey');
+        $publicFile = $this->createMock(ISimpleFile::class);
+        $publicFile
+            ->expects($this->once())
+            ->method('getContent')
+            ->willReturn('MyPublicKey');
+        $this->crypto
+            ->expects($this->once())
+            ->method('decrypt')
+            ->with('EncryptedPrivateKey')
+            ->willReturn('MyPrivateKey');
+        $folder
+            ->expects($this->exactly(2))
+            ->method('getFile')
+            ->willReturnMap([
+                ['private', $privateFile],
+                ['public', $publicFile],
+            ]);
+        $this->appData
+            ->expects($this->once())
+            ->method('getFolder')
+            ->with('user-MyUid')
+            ->willReturn($folder);
+
+        $expected = new Key('MyPublicKey', 'MyPrivateKey');
+        $this->assertEquals($expected, $this->manager->getKey($user));
+    }
+
+    public function testGetKeyWithNotExistingKey(): void {
+        $user = $this->createMock(IUser::class);
+        $user
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('MyUid');
+        $this->manager
+            ->expects($this->once())
+            ->method('generateKeyPair')
+            ->willReturn(['MyNewPublicKey', 'MyNewPrivateKey']);
+        $this->appData
+            ->expects($this->once())
+            ->method('newFolder')
+            ->with('user-MyUid');
+        $folder = $this->createMock(ISimpleFolder::class);
+        $this->crypto
+            ->expects($this->once())
+            ->method('encrypt')
+            ->with('MyNewPrivateKey')
+            ->willReturn('MyNewEncryptedPrivateKey');
+        $privateFile = $this->createMock(ISimpleFile::class);
+        $privateFile
+            ->expects($this->once())
+            ->method('putContent')
+            ->with('MyNewEncryptedPrivateKey');
+        $publicFile = $this->createMock(ISimpleFile::class);
+        $publicFile
+            ->expects($this->once())
+            ->method('putContent')
+            ->with('MyNewPublicKey');
+        $folder
+            ->expects($this->exactly(2))
+            ->method('newFile')
+            ->willReturnMap([
+                ['private', null, $privateFile],
+                ['public', null, $publicFile],
+            ]);
+        $this->appData
+            ->expects($this->exactly(2))
+            ->method('getFolder')
+            ->with('user-MyUid')
+            ->willReturnOnConsecutiveCalls(
+                $this->throwException(new \Exception()),
+                $folder
+            );
+
+
+        $expected = new Key('MyNewPublicKey', 'MyNewPrivateKey');
+        $this->assertEquals($expected, $this->manager->getKey($user));
+    }
+
+    public function testGenerateKeyPair(): void {
+        $manager = $this->getManager();
+        $data = 'MyTestData';
+
+        [$resultPublicKey, $resultPrivateKey] = self::invokePrivate($manager, 'generateKeyPair');
+        openssl_sign($data, $signature, $resultPrivateKey);
+        $details = openssl_pkey_get_details(openssl_pkey_get_public($resultPublicKey));
+
+        $this->assertSame(1, openssl_verify($data, $signature, $resultPublicKey));
+        $this->assertSame(2048, $details['bits']);
+    }
+
+    public function testGetSystemKey(): void {
+        $manager = $this->getManager(['retrieveKey']);
+
+        /** @var Key|\PHPUnit\Framework\MockObject\MockObject $key */
+        $key = $this->createMock(Key::class);
+
+        $this->config->expects($this->once())->method('getSystemValue')
+            ->with('instanceid', null)->willReturn('instanceId');
+
+        $manager->expects($this->once())->method('retrieveKey')->with('system-instanceId')
+            ->willReturn($key);
+
+        $this->assertSame($key, $manager->getSystemKey());
+    }
+
+
+
+    public function testGetSystemKeyFailure(): void {
+        $this->expectException(\RuntimeException::class);
+
+        $manager = $this->getManager(['retrieveKey']);
+
+        /** @var Key|\PHPUnit\Framework\MockObject\MockObject $key */
+        $key = $this->createMock(Key::class);
+
+        $this->config->expects($this->once())->method('getSystemValue')
+            ->with('instanceid', null)->willReturn(null);
+
+        $manager->getSystemKey();
+    }
 }

tests/lib/Settings/ManagerTest.php

Indentation +197 added lines, -197 removed lines

@@ -22,201 +22,201 @@
 use Test\TestCase;
 
 class ManagerTest extends TestCase {
-	/** @var Manager|MockObject */
-	private $manager;
-	/** @var LoggerInterface|MockObject */
-	private $logger;
-	/** @var IDBConnection|MockObject */
-	private $l10n;
-	/** @var IFactory|MockObject */
-	private $l10nFactory;
-	/** @var IURLGenerator|MockObject */
-	private $url;
-	/** @var IServerContainer|MockObject */
-	private $container;
-	/** @var AuthorizedGroupMapper|MockObject */
-	private $mapper;
-	/** @var IGroupManager|MockObject */
-	private $groupManager;
-	/** @var ISubAdmin|MockObject */
-	private $subAdmin;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->l10nFactory = $this->createMock(IFactory::class);
-		$this->url = $this->createMock(IURLGenerator::class);
-		$this->container = $this->createMock(IServerContainer::class);
-		$this->mapper = $this->createMock(AuthorizedGroupMapper::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->subAdmin = $this->createMock(ISubAdmin::class);
-
-		$this->manager = new Manager(
-			$this->logger,
-			$this->l10nFactory,
-			$this->url,
-			$this->container,
-			$this->mapper,
-			$this->groupManager,
-			$this->subAdmin,
-		);
-	}
-
-	public function testGetAdminSections(): void {
-		$this->manager->registerSection('admin', \OCA\WorkflowEngine\Settings\Section::class);
-
-		$section = \OC::$server->query(\OCA\WorkflowEngine\Settings\Section::class);
-		$this->container->method('get')
-			->with(\OCA\WorkflowEngine\Settings\Section::class)
-			->willReturn($section);
-
-		$this->assertEquals([
-			55 => [$section],
-		], $this->manager->getAdminSections());
-	}
-
-	public function testGetPersonalSections(): void {
-		$this->manager->registerSection('personal', \OCA\WorkflowEngine\Settings\Section::class);
-
-		$section = \OC::$server->query(\OCA\WorkflowEngine\Settings\Section::class);
-		$this->container->method('get')
-			->with(\OCA\WorkflowEngine\Settings\Section::class)
-			->willReturn($section);
-
-		$this->assertEquals([
-			55 => [$section],
-		], $this->manager->getPersonalSections());
-	}
-
-	public function testGetAdminSectionsEmptySection(): void {
-		$this->assertEquals([], $this->manager->getAdminSections());
-	}
-
-	public function testGetPersonalSectionsEmptySection(): void {
-		$this->l10nFactory
-			->expects($this->once())
-			->method('get')
-			->with('lib')
-			->willReturn($this->l10n);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnArgument(0);
-
-		$this->assertEquals([], $this->manager->getPersonalSections());
-	}
-
-	public function testGetAdminSettings(): void {
-		$section = $this->createMock(ISettings::class);
-		$section->method('getPriority')
-			->willReturn(13);
-		$section->method('getSection')
-			->willReturn('sharing');
-		$this->container->method('get')
-			->with('myAdminClass')
-			->willReturn($section);
-
-		$this->manager->registerSetting('admin', 'myAdminClass');
-		$settings = $this->manager->getAdminSettings('sharing');
-
-		$this->assertEquals([
-			13 => [$section]
-		], $settings);
-	}
-
-	public function testGetAdminSettingsAsSubAdmin(): void {
-		$section = $this->createMock(ISettings::class);
-		$section->method('getPriority')
-			->willReturn(13);
-		$section->method('getSection')
-			->willReturn('sharing');
-		$this->container->method('get')
-			->with('myAdminClass')
-			->willReturn($section);
-
-		$this->manager->registerSetting('admin', 'myAdminClass');
-		$settings = $this->manager->getAdminSettings('sharing', true);
-
-		$this->assertEquals([], $settings);
-	}
-
-	public function testGetSubAdminSettingsAsSubAdmin(): void {
-		$section = $this->createMock(ISubAdminSettings::class);
-		$section->method('getPriority')
-			->willReturn(13);
-		$section->method('getSection')
-			->willReturn('sharing');
-		$this->container->expects($this->once())
-			->method('get')
-			->with('mySubAdminClass')
-			->willReturn($section);
-
-		$this->manager->registerSetting('admin', 'mySubAdminClass');
-		$settings = $this->manager->getAdminSettings('sharing', true);
-
-		$this->assertEquals([
-			13 => [$section]
-		], $settings);
-	}
-
-	public function testGetPersonalSettings(): void {
-		$section = $this->createMock(ISettings::class);
-		$section->method('getPriority')
-			->willReturn(16);
-		$section->method('getSection')
-			->willReturn('security');
-		$section2 = $this->createMock(ISettings::class);
-		$section2->method('getPriority')
-			->willReturn(100);
-		$section2->method('getSection')
-			->willReturn('security');
-
-		$this->manager->registerSetting('personal', 'section1');
-		$this->manager->registerSetting('personal', 'section2');
-
-		$this->container->expects($this->exactly(2))
-			->method('get')
-			->willReturnMap([
-				['section1', $section],
-				['section2', $section2],
-			]);
-
-		$settings = $this->manager->getPersonalSettings('security');
-
-		$this->assertEquals([
-			16 => [$section],
-			100 => [$section2],
-		], $settings);
-	}
-
-	public function testSameSectionAsPersonalAndAdmin(): void {
-		$this->l10nFactory
-			->expects($this->once())
-			->method('get')
-			->with('lib')
-			->willReturn($this->l10n);
-		$this->l10n
-			->expects($this->any())
-			->method('t')
-			->willReturnArgument(0);
-
-		$this->manager->registerSection('personal', \OCA\WorkflowEngine\Settings\Section::class);
-		$this->manager->registerSection('admin', \OCA\WorkflowEngine\Settings\Section::class);
-
-
-		$section = \OC::$server->query(\OCA\WorkflowEngine\Settings\Section::class);
-		$this->container->method('get')
-			->with(\OCA\WorkflowEngine\Settings\Section::class)
-			->willReturn($section);
-
-		$this->assertEquals([
-			55 => [$section],
-		], $this->manager->getPersonalSections());
-
-		$this->assertEquals([
-			55 => [$section],
-		], $this->manager->getAdminSections());
-	}
+    /** @var Manager|MockObject */
+    private $manager;
+    /** @var LoggerInterface|MockObject */
+    private $logger;
+    /** @var IDBConnection|MockObject */
+    private $l10n;
+    /** @var IFactory|MockObject */
+    private $l10nFactory;
+    /** @var IURLGenerator|MockObject */
+    private $url;
+    /** @var IServerContainer|MockObject */
+    private $container;
+    /** @var AuthorizedGroupMapper|MockObject */
+    private $mapper;
+    /** @var IGroupManager|MockObject */
+    private $groupManager;
+    /** @var ISubAdmin|MockObject */
+    private $subAdmin;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->l10nFactory = $this->createMock(IFactory::class);
+        $this->url = $this->createMock(IURLGenerator::class);
+        $this->container = $this->createMock(IServerContainer::class);
+        $this->mapper = $this->createMock(AuthorizedGroupMapper::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->subAdmin = $this->createMock(ISubAdmin::class);
+
+        $this->manager = new Manager(
+            $this->logger,
+            $this->l10nFactory,
+            $this->url,
+            $this->container,
+            $this->mapper,
+            $this->groupManager,
+            $this->subAdmin,
+        );
+    }
+
+    public function testGetAdminSections(): void {
+        $this->manager->registerSection('admin', \OCA\WorkflowEngine\Settings\Section::class);
+
+        $section = \OC::$server->query(\OCA\WorkflowEngine\Settings\Section::class);
+        $this->container->method('get')
+            ->with(\OCA\WorkflowEngine\Settings\Section::class)
+            ->willReturn($section);
+
+        $this->assertEquals([
+            55 => [$section],
+        ], $this->manager->getAdminSections());
+    }
+
+    public function testGetPersonalSections(): void {
+        $this->manager->registerSection('personal', \OCA\WorkflowEngine\Settings\Section::class);
+
+        $section = \OC::$server->query(\OCA\WorkflowEngine\Settings\Section::class);
+        $this->container->method('get')
+            ->with(\OCA\WorkflowEngine\Settings\Section::class)
+            ->willReturn($section);
+
+        $this->assertEquals([
+            55 => [$section],
+        ], $this->manager->getPersonalSections());
+    }
+
+    public function testGetAdminSectionsEmptySection(): void {
+        $this->assertEquals([], $this->manager->getAdminSections());
+    }
+
+    public function testGetPersonalSectionsEmptySection(): void {
+        $this->l10nFactory
+            ->expects($this->once())
+            ->method('get')
+            ->with('lib')
+            ->willReturn($this->l10n);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnArgument(0);
+
+        $this->assertEquals([], $this->manager->getPersonalSections());
+    }
+
+    public function testGetAdminSettings(): void {
+        $section = $this->createMock(ISettings::class);
+        $section->method('getPriority')
+            ->willReturn(13);
+        $section->method('getSection')
+            ->willReturn('sharing');
+        $this->container->method('get')
+            ->with('myAdminClass')
+            ->willReturn($section);
+
+        $this->manager->registerSetting('admin', 'myAdminClass');
+        $settings = $this->manager->getAdminSettings('sharing');
+
+        $this->assertEquals([
+            13 => [$section]
+        ], $settings);
+    }
+
+    public function testGetAdminSettingsAsSubAdmin(): void {
+        $section = $this->createMock(ISettings::class);
+        $section->method('getPriority')
+            ->willReturn(13);
+        $section->method('getSection')
+            ->willReturn('sharing');
+        $this->container->method('get')
+            ->with('myAdminClass')
+            ->willReturn($section);
+
+        $this->manager->registerSetting('admin', 'myAdminClass');
+        $settings = $this->manager->getAdminSettings('sharing', true);
+
+        $this->assertEquals([], $settings);
+    }
+
+    public function testGetSubAdminSettingsAsSubAdmin(): void {
+        $section = $this->createMock(ISubAdminSettings::class);
+        $section->method('getPriority')
+            ->willReturn(13);
+        $section->method('getSection')
+            ->willReturn('sharing');
+        $this->container->expects($this->once())
+            ->method('get')
+            ->with('mySubAdminClass')
+            ->willReturn($section);
+
+        $this->manager->registerSetting('admin', 'mySubAdminClass');
+        $settings = $this->manager->getAdminSettings('sharing', true);
+
+        $this->assertEquals([
+            13 => [$section]
+        ], $settings);
+    }
+
+    public function testGetPersonalSettings(): void {
+        $section = $this->createMock(ISettings::class);
+        $section->method('getPriority')
+            ->willReturn(16);
+        $section->method('getSection')
+            ->willReturn('security');
+        $section2 = $this->createMock(ISettings::class);
+        $section2->method('getPriority')
+            ->willReturn(100);
+        $section2->method('getSection')
+            ->willReturn('security');
+
+        $this->manager->registerSetting('personal', 'section1');
+        $this->manager->registerSetting('personal', 'section2');
+
+        $this->container->expects($this->exactly(2))
+            ->method('get')
+            ->willReturnMap([
+                ['section1', $section],
+                ['section2', $section2],
+            ]);
+
+        $settings = $this->manager->getPersonalSettings('security');
+
+        $this->assertEquals([
+            16 => [$section],
+            100 => [$section2],
+        ], $settings);
+    }
+
+    public function testSameSectionAsPersonalAndAdmin(): void {
+        $this->l10nFactory
+            ->expects($this->once())
+            ->method('get')
+            ->with('lib')
+            ->willReturn($this->l10n);
+        $this->l10n
+            ->expects($this->any())
+            ->method('t')
+            ->willReturnArgument(0);
+
+        $this->manager->registerSection('personal', \OCA\WorkflowEngine\Settings\Section::class);
+        $this->manager->registerSection('admin', \OCA\WorkflowEngine\Settings\Section::class);
+
+
+        $section = \OC::$server->query(\OCA\WorkflowEngine\Settings\Section::class);
+        $this->container->method('get')
+            ->with(\OCA\WorkflowEngine\Settings\Section::class)
+            ->willReturn($section);
+
+        $this->assertEquals([
+            55 => [$section],
+        ], $this->manager->getPersonalSections());
+
+        $this->assertEquals([
+            55 => [$section],
+        ], $this->manager->getAdminSections());
+    }
 }

tests/lib/OCS/ProviderTest.php

Indentation +180 added lines, -180 removed lines

@@ -10,184 +10,184 @@
 use OC\OCS\Provider;
 
 class ProviderTest extends \Test\TestCase {
-	/** @var \OCP\IRequest */
-	private $request;
-	/** @var \OCP\App\IAppManager */
-	private $appManager;
-	/** @var Provider */
-	private $ocsProvider;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->request = $this->getMockBuilder('\\OCP\\IRequest')->getMock();
-		$this->appManager = $this->getMockBuilder('\\OCP\\App\\IAppManager')->getMock();
-		$this->ocsProvider = new Provider('ocs_provider', $this->request, $this->appManager);
-	}
-
-	public function testBuildProviderListWithoutAnythingEnabled(): void {
-		$this->appManager
-			->expects($this->exactly(4))
-			->method('isEnabledForUser')
-			->willReturnMap([
-				['files_sharing', null, false],
-				['federation', null, false],
-				['activity', null, false],
-				['provisioning_api', null, false],
-			]);
-
-		$expected = new \OCP\AppFramework\Http\JSONResponse(
-			[
-				'version' => 2,
-				'services' => [
-					'PRIVATE_DATA' => [
-						'version' => 1,
-						'endpoints' => [
-							'store' => '/ocs/v2.php/privatedata/setattribute',
-							'read' => '/ocs/v2.php/privatedata/getattribute',
-							'delete' => '/ocs/v2.php/privatedata/deleteattribute',
-						],
-					],
-				],
-			]
-		);
-
-		$this->assertEquals($expected, $this->ocsProvider->buildProviderList());
-	}
-
-	public function testBuildProviderListWithSharingEnabled(): void {
-		$this->appManager
-			->expects($this->exactly(4))
-			->method('isEnabledForUser')
-			->willReturnMap([
-				['files_sharing', null, true],
-				['federation', null, false],
-				['activity', null, false],
-				['provisioning_api', null, false],
-			]);
-
-		$expected = new \OCP\AppFramework\Http\JSONResponse(
-			[
-				'version' => 2,
-				'services' => [
-					'PRIVATE_DATA' => [
-						'version' => 1,
-						'endpoints' => [
-							'store' => '/ocs/v2.php/privatedata/setattribute',
-							'read' => '/ocs/v2.php/privatedata/getattribute',
-							'delete' => '/ocs/v2.php/privatedata/deleteattribute',
-						],
-					],
-					'FEDERATED_SHARING' => [
-						'version' => 1,
-						'endpoints' => [
-							'share' => '/ocs/v2.php/cloud/shares',
-							'webdav' => '/public.php/webdav/',
-						],
-					],
-					'SHARING' => [
-						'version' => 1,
-						'endpoints' => [
-							'share' => '/ocs/v2.php/apps/files_sharing/api/v1/shares',
-						],
-					],
-				],
-			]
-		);
-
-		$this->assertEquals($expected, $this->ocsProvider->buildProviderList());
-	}
-
-	public function testBuildProviderListWithFederationEnabled(): void {
-		$this->appManager
-			->expects($this->exactly(4))
-			->method('isEnabledForUser')
-			->willReturnMap([
-				['files_sharing', null, false],
-				['federation', null, true],
-				['activity', null, false],
-				['provisioning_api', null, false],
-			]);
-
-		$expected = new \OCP\AppFramework\Http\JSONResponse(
-			[
-				'version' => 2,
-				'services' => [
-					'PRIVATE_DATA' => [
-						'version' => 1,
-						'endpoints' => [
-							'store' => '/ocs/v2.php/privatedata/setattribute',
-							'read' => '/ocs/v2.php/privatedata/getattribute',
-							'delete' => '/ocs/v2.php/privatedata/deleteattribute',
-						],
-					],
-					'FEDERATED_SHARING' => [
-						'version' => 1,
-						'endpoints' => [
-							'shared-secret' => '/ocs/v2.php/cloud/shared-secret',
-							'system-address-book' => '/remote.php/dav/addressbooks/system/system/system',
-							'carddav-user' => 'system'
-						],
-					],
-				],
-			]
-		);
-
-		$this->assertEquals($expected, $this->ocsProvider->buildProviderList());
-	}
-
-	public function testBuildProviderListWithEverythingEnabled(): void {
-		$this->appManager
-			->expects($this->any())
-			->method('isEnabledForUser')
-			->willReturn(true);
-
-		$expected = new \OCP\AppFramework\Http\JSONResponse(
-			[
-				'version' => 2,
-				'services' => [
-					'PRIVATE_DATA' => [
-						'version' => 1,
-						'endpoints' => [
-							'store' => '/ocs/v2.php/privatedata/setattribute',
-							'read' => '/ocs/v2.php/privatedata/getattribute',
-							'delete' => '/ocs/v2.php/privatedata/deleteattribute',
-						],
-					],
-					'FEDERATED_SHARING' => [
-						'version' => 1,
-						'endpoints' => [
-							'share' => '/ocs/v2.php/cloud/shares',
-							'webdav' => '/public.php/webdav/',
-							'shared-secret' => '/ocs/v2.php/cloud/shared-secret',
-							'system-address-book' => '/remote.php/dav/addressbooks/system/system/system',
-							'carddav-user' => 'system'
-						],
-					],
-					'SHARING' => [
-						'version' => 1,
-						'endpoints' => [
-							'share' => '/ocs/v2.php/apps/files_sharing/api/v1/shares',
-						],
-					],
-					'ACTIVITY' => [
-						'version' => 1,
-						'endpoints' => [
-							'list' => '/ocs/v2.php/cloud/activity',
-						],
-					],
-					'PROVISIONING' => [
-						'version' => 1,
-						'endpoints' => [
-							'user' => '/ocs/v2.php/cloud/users',
-							'groups' => '/ocs/v2.php/cloud/groups',
-							'apps' => '/ocs/v2.php/cloud/apps',
-						],
-					],
-				],
-			]
-		);
-
-		$this->assertEquals($expected, $this->ocsProvider->buildProviderList());
-	}
+    /** @var \OCP\IRequest */
+    private $request;
+    /** @var \OCP\App\IAppManager */
+    private $appManager;
+    /** @var Provider */
+    private $ocsProvider;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->request = $this->getMockBuilder('\\OCP\\IRequest')->getMock();
+        $this->appManager = $this->getMockBuilder('\\OCP\\App\\IAppManager')->getMock();
+        $this->ocsProvider = new Provider('ocs_provider', $this->request, $this->appManager);
+    }
+
+    public function testBuildProviderListWithoutAnythingEnabled(): void {
+        $this->appManager
+            ->expects($this->exactly(4))
+            ->method('isEnabledForUser')
+            ->willReturnMap([
+                ['files_sharing', null, false],
+                ['federation', null, false],
+                ['activity', null, false],
+                ['provisioning_api', null, false],
+            ]);
+
+        $expected = new \OCP\AppFramework\Http\JSONResponse(
+            [
+                'version' => 2,
+                'services' => [
+                    'PRIVATE_DATA' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'store' => '/ocs/v2.php/privatedata/setattribute',
+                            'read' => '/ocs/v2.php/privatedata/getattribute',
+                            'delete' => '/ocs/v2.php/privatedata/deleteattribute',
+                        ],
+                    ],
+                ],
+            ]
+        );
+
+        $this->assertEquals($expected, $this->ocsProvider->buildProviderList());
+    }
+
+    public function testBuildProviderListWithSharingEnabled(): void {
+        $this->appManager
+            ->expects($this->exactly(4))
+            ->method('isEnabledForUser')
+            ->willReturnMap([
+                ['files_sharing', null, true],
+                ['federation', null, false],
+                ['activity', null, false],
+                ['provisioning_api', null, false],
+            ]);
+
+        $expected = new \OCP\AppFramework\Http\JSONResponse(
+            [
+                'version' => 2,
+                'services' => [
+                    'PRIVATE_DATA' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'store' => '/ocs/v2.php/privatedata/setattribute',
+                            'read' => '/ocs/v2.php/privatedata/getattribute',
+                            'delete' => '/ocs/v2.php/privatedata/deleteattribute',
+                        ],
+                    ],
+                    'FEDERATED_SHARING' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'share' => '/ocs/v2.php/cloud/shares',
+                            'webdav' => '/public.php/webdav/',
+                        ],
+                    ],
+                    'SHARING' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'share' => '/ocs/v2.php/apps/files_sharing/api/v1/shares',
+                        ],
+                    ],
+                ],
+            ]
+        );
+
+        $this->assertEquals($expected, $this->ocsProvider->buildProviderList());
+    }
+
+    public function testBuildProviderListWithFederationEnabled(): void {
+        $this->appManager
+            ->expects($this->exactly(4))
+            ->method('isEnabledForUser')
+            ->willReturnMap([
+                ['files_sharing', null, false],
+                ['federation', null, true],
+                ['activity', null, false],
+                ['provisioning_api', null, false],
+            ]);
+
+        $expected = new \OCP\AppFramework\Http\JSONResponse(
+            [
+                'version' => 2,
+                'services' => [
+                    'PRIVATE_DATA' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'store' => '/ocs/v2.php/privatedata/setattribute',
+                            'read' => '/ocs/v2.php/privatedata/getattribute',
+                            'delete' => '/ocs/v2.php/privatedata/deleteattribute',
+                        ],
+                    ],
+                    'FEDERATED_SHARING' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'shared-secret' => '/ocs/v2.php/cloud/shared-secret',
+                            'system-address-book' => '/remote.php/dav/addressbooks/system/system/system',
+                            'carddav-user' => 'system'
+                        ],
+                    ],
+                ],
+            ]
+        );
+
+        $this->assertEquals($expected, $this->ocsProvider->buildProviderList());
+    }
+
+    public function testBuildProviderListWithEverythingEnabled(): void {
+        $this->appManager
+            ->expects($this->any())
+            ->method('isEnabledForUser')
+            ->willReturn(true);
+
+        $expected = new \OCP\AppFramework\Http\JSONResponse(
+            [
+                'version' => 2,
+                'services' => [
+                    'PRIVATE_DATA' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'store' => '/ocs/v2.php/privatedata/setattribute',
+                            'read' => '/ocs/v2.php/privatedata/getattribute',
+                            'delete' => '/ocs/v2.php/privatedata/deleteattribute',
+                        ],
+                    ],
+                    'FEDERATED_SHARING' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'share' => '/ocs/v2.php/cloud/shares',
+                            'webdav' => '/public.php/webdav/',
+                            'shared-secret' => '/ocs/v2.php/cloud/shared-secret',
+                            'system-address-book' => '/remote.php/dav/addressbooks/system/system/system',
+                            'carddav-user' => 'system'
+                        ],
+                    ],
+                    'SHARING' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'share' => '/ocs/v2.php/apps/files_sharing/api/v1/shares',
+                        ],
+                    ],
+                    'ACTIVITY' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'list' => '/ocs/v2.php/cloud/activity',
+                        ],
+                    ],
+                    'PROVISIONING' => [
+                        'version' => 1,
+                        'endpoints' => [
+                            'user' => '/ocs/v2.php/cloud/users',
+                            'groups' => '/ocs/v2.php/cloud/groups',
+                            'apps' => '/ocs/v2.php/cloud/apps',
+                        ],
+                    ],
+                ],
+            ]
+        );
+
+        $this->assertEquals($expected, $this->ocsProvider->buildProviderList());
+    }
 }

tests/lib/Updater/ChangesCheckTest.php

Indentation +294 added lines, -294 removed lines

@@ -20,92 +20,92 @@ 
 use Test\TestCase;
 
 class ChangesCheckTest extends TestCase {
-	/** @var IClientService|\PHPUnit\Framework\MockObject\MockObject */
-	protected $clientService;
-
-	/** @var ChangesCheck */
-	protected $checker;
-
-	/** @var ChangesMapper|\PHPUnit\Framework\MockObject\MockObject */
-	protected $mapper;
-
-	/** @var LoggerInterface|\PHPUnit\Framework\MockObject\MockObject */
-	protected $logger;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->clientService = $this->createMock(IClientService::class);
-		$this->mapper = $this->createMock(ChangesMapper::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->checker = new ChangesCheck($this->clientService, $this->mapper, $this->logger);
-	}
-
-	public static function statusCodeProvider(): array {
-		return [
-			[200, ChangesCheck::RESPONSE_HAS_CONTENT],
-			[304, ChangesCheck::RESPONSE_USE_CACHE],
-			[404, ChangesCheck::RESPONSE_NO_CONTENT],
-			[418, ChangesCheck::RESPONSE_NO_CONTENT],
-		];
-	}
-
-	/**
-	 * @dataProvider statusCodeProvider
-	 */
-	public function testEvaluateResponse(int $statusCode, int $expected): void {
-		$response = $this->createMock(IResponse::class);
-		$response->expects($this->atLeastOnce())
-			->method('getStatusCode')
-			->willReturn($statusCode);
-
-		if (!in_array($statusCode, [200, 304, 404])) {
-			$this->logger->expects($this->once())
-				->method('debug');
-		}
-
-		$evaluation = $this->invokePrivate($this->checker, 'evaluateResponse', [$response]);
-		$this->assertSame($expected, $evaluation);
-	}
-
-	public function testCacheResultInsert(): void {
-		$version = '13.0.4';
-		$entry = $this->createMock(Changes::class);
-		$entry->expects($this->exactly(2))
-			->method('__call')
-			->willReturnMap([
-				['getVersion', [], ''],
-				['setVersion', [$version], null],
-			]);
-
-		$this->mapper->expects($this->once())
-			->method('insert');
-		$this->mapper->expects($this->never())
-			->method('update');
-
-		$this->invokePrivate($this->checker, 'cacheResult', [$entry, $version]);
-	}
-
-	public function testCacheResultUpdate(): void {
-		$version = '13.0.4';
-		$entry = $this->createMock(Changes::class);
-		$entry->expects($this->once())
-			->method('__call')
-			->willReturn($version);
-
-		$this->mapper->expects($this->never())
-			->method('insert');
-		$this->mapper->expects($this->once())
-			->method('update');
-
-		$this->invokePrivate($this->checker, 'cacheResult', [$entry, $version]);
-	}
-
-	public static function changesXMLProvider(): array {
-		return [
-			[ # 0 - full example
-				'<?xml version="1.0" encoding="utf-8" ?>
+    /** @var IClientService|\PHPUnit\Framework\MockObject\MockObject */
+    protected $clientService;
+
+    /** @var ChangesCheck */
+    protected $checker;
+
+    /** @var ChangesMapper|\PHPUnit\Framework\MockObject\MockObject */
+    protected $mapper;
+
+    /** @var LoggerInterface|\PHPUnit\Framework\MockObject\MockObject */
+    protected $logger;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->clientService = $this->createMock(IClientService::class);
+        $this->mapper = $this->createMock(ChangesMapper::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->checker = new ChangesCheck($this->clientService, $this->mapper, $this->logger);
+    }
+
+    public static function statusCodeProvider(): array {
+        return [
+            [200, ChangesCheck::RESPONSE_HAS_CONTENT],
+            [304, ChangesCheck::RESPONSE_USE_CACHE],
+            [404, ChangesCheck::RESPONSE_NO_CONTENT],
+            [418, ChangesCheck::RESPONSE_NO_CONTENT],
+        ];
+    }
+
+    /**
+     * @dataProvider statusCodeProvider
+     */
+    public function testEvaluateResponse(int $statusCode, int $expected): void {
+        $response = $this->createMock(IResponse::class);
+        $response->expects($this->atLeastOnce())
+            ->method('getStatusCode')
+            ->willReturn($statusCode);
+
+        if (!in_array($statusCode, [200, 304, 404])) {
+            $this->logger->expects($this->once())
+                ->method('debug');
+        }
+
+        $evaluation = $this->invokePrivate($this->checker, 'evaluateResponse', [$response]);
+        $this->assertSame($expected, $evaluation);
+    }
+
+    public function testCacheResultInsert(): void {
+        $version = '13.0.4';
+        $entry = $this->createMock(Changes::class);
+        $entry->expects($this->exactly(2))
+            ->method('__call')
+            ->willReturnMap([
+                ['getVersion', [], ''],
+                ['setVersion', [$version], null],
+            ]);
+
+        $this->mapper->expects($this->once())
+            ->method('insert');
+        $this->mapper->expects($this->never())
+            ->method('update');
+
+        $this->invokePrivate($this->checker, 'cacheResult', [$entry, $version]);
+    }
+
+    public function testCacheResultUpdate(): void {
+        $version = '13.0.4';
+        $entry = $this->createMock(Changes::class);
+        $entry->expects($this->once())
+            ->method('__call')
+            ->willReturn($version);
+
+        $this->mapper->expects($this->never())
+            ->method('insert');
+        $this->mapper->expects($this->once())
+            ->method('update');
+
+        $this->invokePrivate($this->checker, 'cacheResult', [$entry, $version]);
+    }
+
+    public static function changesXMLProvider(): array {
+        return [
+            [ # 0 - full example
+                '<?xml version="1.0" encoding="utf-8" ?>
 <release xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://updates.nextcloud.com/changelog_server/schema.xsd"
          version="13.0.0">
@@ -133,36 +133,36 @@ 
         </admin>
     </whatsNew>
 </release>',
-				[
-					'changelogURL' => 'https://nextcloud.com/changelog/#13-0-0',
-					'whatsNew' => [
-						'en' => [
-							'regular' => [
-								'Refined user interface',
-								'End-to-end Encryption',
-								'Video and Text Chat'
-							],
-							'admin' => [
-								'Changes to the Nginx configuration',
-								'Theming: CSS files were consolidated'
-							],
-						],
-						'de' => [
-							'regular' => [
-								'Überarbeitete Benutzerschnittstelle',
-								'Ende-zu-Ende Verschlüsselung',
-								'Video- und Text-Chat'
-							],
-							'admin' => [
-								'Änderungen an der Nginx Konfiguration',
-								'Theming: CSS Dateien wurden konsolidiert'
-							],
-						],
-					],
-				]
-			],
-			[ # 1- admin part not translated
-				'<?xml version="1.0" encoding="utf-8" ?>
+                [
+                    'changelogURL' => 'https://nextcloud.com/changelog/#13-0-0',
+                    'whatsNew' => [
+                        'en' => [
+                            'regular' => [
+                                'Refined user interface',
+                                'End-to-end Encryption',
+                                'Video and Text Chat'
+                            ],
+                            'admin' => [
+                                'Changes to the Nginx configuration',
+                                'Theming: CSS files were consolidated'
+                            ],
+                        ],
+                        'de' => [
+                            'regular' => [
+                                'Überarbeitete Benutzerschnittstelle',
+                                'Ende-zu-Ende Verschlüsselung',
+                                'Video- und Text-Chat'
+                            ],
+                            'admin' => [
+                                'Änderungen an der Nginx Konfiguration',
+                                'Theming: CSS Dateien wurden konsolidiert'
+                            ],
+                        ],
+                    ],
+                ]
+            ],
+            [ # 1- admin part not translated
+                '<?xml version="1.0" encoding="utf-8" ?>
 <release xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://updates.nextcloud.com/changelog_server/schema.xsd"
          version="13.0.0">
@@ -186,34 +186,34 @@ 
         </regular>
     </whatsNew>
 </release>',
-				[
-					'changelogURL' => 'https://nextcloud.com/changelog/#13-0-0',
-					'whatsNew' => [
-						'en' => [
-							'regular' => [
-								'Refined user interface',
-								'End-to-end Encryption',
-								'Video and Text Chat'
-							],
-							'admin' => [
-								'Changes to the Nginx configuration',
-								'Theming: CSS files were consolidated'
-							],
-						],
-						'de' => [
-							'regular' => [
-								'Überarbeitete Benutzerschnittstelle',
-								'Ende-zu-Ende Verschlüsselung',
-								'Video- und Text-Chat'
-							],
-							'admin' => [
-							],
-						],
-					],
-				]
-			],
-			[ # 2 - minimal set
-				'<?xml version="1.0" encoding="utf-8" ?>
+                [
+                    'changelogURL' => 'https://nextcloud.com/changelog/#13-0-0',
+                    'whatsNew' => [
+                        'en' => [
+                            'regular' => [
+                                'Refined user interface',
+                                'End-to-end Encryption',
+                                'Video and Text Chat'
+                            ],
+                            'admin' => [
+                                'Changes to the Nginx configuration',
+                                'Theming: CSS files were consolidated'
+                            ],
+                        ],
+                        'de' => [
+                            'regular' => [
+                                'Überarbeitete Benutzerschnittstelle',
+                                'Ende-zu-Ende Verschlüsselung',
+                                'Video- und Text-Chat'
+                            ],
+                            'admin' => [
+                            ],
+                        ],
+                    ],
+                ]
+            ],
+            [ # 2 - minimal set
+                '<?xml version="1.0" encoding="utf-8" ?>
 <release xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://updates.nextcloud.com/changelog_server/schema.xsd"
          version="13.0.0">
@@ -226,22 +226,22 @@ 
         </regular>
     </whatsNew>
 </release>',
-				[
-					'changelogURL' => 'https://nextcloud.com/changelog/#13-0-0',
-					'whatsNew' => [
-						'en' => [
-							'regular' => [
-								'Refined user interface',
-								'End-to-end Encryption',
-								'Video and Text Chat'
-							],
-							'admin' => [],
-						],
-					],
-				]
-			],
-			[ # 3 - minimal set (procrastinator edition)
-				'<?xml version="1.0" encoding="utf-8" ?>
+                [
+                    'changelogURL' => 'https://nextcloud.com/changelog/#13-0-0',
+                    'whatsNew' => [
+                        'en' => [
+                            'regular' => [
+                                'Refined user interface',
+                                'End-to-end Encryption',
+                                'Video and Text Chat'
+                            ],
+                            'admin' => [],
+                        ],
+                    ],
+                ]
+            ],
+            [ # 3 - minimal set (procrastinator edition)
+                '<?xml version="1.0" encoding="utf-8" ?>
 <release xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://updates.nextcloud.com/changelog_server/schema.xsd"
          version="13.0.0">
@@ -252,138 +252,138 @@ 
         </regular>
     </whatsNew>
 </release>',
-				[
-					'changelogURL' => 'https://nextcloud.com/changelog/#13-0-0',
-					'whatsNew' => [
-						'en' => [
-							'regular' => [
-								'Write this tomorrow',
-							],
-							'admin' => [],
-						],
-					],
-				]
-			],
-			[ # 4 - empty
-				'',
-				[]
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider changesXMLProvider
-	 */
-	public function testExtractData(string $body, array $expected): void {
-		$actual = $this->invokePrivate($this->checker, 'extractData', [$body]);
-		$this->assertSame($expected, $actual);
-	}
-
-	public static function etagProvider() {
-		return [
-			[''],
-			['a27aab83d8205d73978435076e53d143']
-		];
-	}
-
-	/**
-	 * @dataProvider etagProvider
-	 */
-	public function testQueryChangesServer(string $etag): void {
-		$uri = 'https://changes.nextcloud.server/?13.0.5';
-		$entry = $this->createMock(Changes::class);
-		$entry->expects($this->any())
-			->method('__call')
-			->willReturn($etag);
-
-		$expectedHeaders = $etag === '' ? [] : ['If-None-Match' => [$etag]];
-
-		$client = $this->createMock(IClient::class);
-		$client->expects($this->once())
-			->method('get')
-			->with($uri, ['headers' => $expectedHeaders])
-			->willReturn($this->createMock(IResponse::class));
-
-		$this->clientService->expects($this->once())
-			->method('newClient')
-			->willReturn($client);
-
-		$response = $this->invokePrivate($this->checker, 'queryChangesServer', [$uri, $entry]);
-		$this->assertInstanceOf(IResponse::class, $response);
-	}
-
-	public static function versionProvider(): array {
-		return [
-			['13.0.7', '13.0.7'],
-			['13.0.7.3', '13.0.7'],
-			['13.0.7.3.42', '13.0.7'],
-			['13.0', '13.0.0'],
-			['13', '13.0.0'],
-			['', '0.0.0'],
-		];
-	}
-
-	/**
-	 * @dataProvider versionProvider
-	 */
-	public function testNormalizeVersion(string $input, string $expected): void {
-		$normalized = $this->checker->normalizeVersion($input);
-		$this->assertSame($expected, $normalized);
-	}
-
-	public static function changeDataProvider():array {
-		$testDataFound = $testDataNotFound = self::versionProvider();
-		array_walk($testDataFound, static function (&$params) {
-			$params[] = true;
-		});
-		array_walk($testDataNotFound, static function (&$params) {
-			$params[] = false;
-		});
-		return array_merge($testDataFound, $testDataNotFound);
-	}
-
-	/**
-	 * @dataProvider changeDataProvider
-	 *
-	 */
-	public function testGetChangesForVersion(string $inputVersion, string $normalizedVersion, bool $isFound): void {
-		$mocker = $this->mapper->expects($this->once())
-			->method('getChanges')
-			->with($normalizedVersion);
-
-		if (!$isFound) {
-			$this->expectException(DoesNotExistException::class);
-			$mocker->willThrowException(new DoesNotExistException('Changes info is not present'));
-		} else {
-			$entry = $this->createMock(Changes::class);
-			$entry->expects($this->once())
-				->method('__call')
-				->with('getData')
-				->willReturn('{"changelogURL":"https:\/\/nextcloud.com\/changelog\/#13-0-0","whatsNew":{"en":{"regular":["Refined user interface","End-to-end Encryption","Video and Text Chat"],"admin":["Changes to the Nginx configuration","Theming: CSS files were consolidated"]},"de":{"regular":["\u00dcberarbeitete Benutzerschnittstelle","Ende-zu-Ende Verschl\u00fcsselung","Video- und Text-Chat"],"admin":["\u00c4nderungen an der Nginx Konfiguration","Theming: CSS Dateien wurden konsolidiert"]}}}');
-
-			$mocker->willReturn($entry);
-		}
-
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$data = $this->checker->getChangesForVersion($inputVersion);
-		$this->assertTrue(isset($data['whatsNew']['en']['regular']));
-		$this->assertTrue(isset($data['changelogURL']));
-	}
-
-	public function testGetChangesForVersionEmptyData(): void {
-		$entry = $this->createMock(Changes::class);
-		$entry->expects($this->once())
-			->method('__call')
-			->with('getData')
-			->willReturn('');
-
-		$this->mapper->expects($this->once())
-			->method('getChanges')
-			->with('13.0.7')
-			->willReturn($entry);
-
-		$this->expectException(DoesNotExistException::class);
-		/** @noinspection PhpUnhandledExceptionInspection */
-		$this->checker->getChangesForVersion('13.0.7');
-	}
+                [
+                    'changelogURL' => 'https://nextcloud.com/changelog/#13-0-0',
+                    'whatsNew' => [
+                        'en' => [
+                            'regular' => [
+                                'Write this tomorrow',
+                            ],
+                            'admin' => [],
+                        ],
+                    ],
+                ]
+            ],
+            [ # 4 - empty
+                '',
+                []
+            ],
+        ];
+    }
+
+    /**
+     * @dataProvider changesXMLProvider
+     */
+    public function testExtractData(string $body, array $expected): void {
+        $actual = $this->invokePrivate($this->checker, 'extractData', [$body]);
+        $this->assertSame($expected, $actual);
+    }
+
+    public static function etagProvider() {
+        return [
+            [''],
+            ['a27aab83d8205d73978435076e53d143']
+        ];
+    }
+
+    /**
+     * @dataProvider etagProvider
+     */
+    public function testQueryChangesServer(string $etag): void {
+        $uri = 'https://changes.nextcloud.server/?13.0.5';
+        $entry = $this->createMock(Changes::class);
+        $entry->expects($this->any())
+            ->method('__call')
+            ->willReturn($etag);
+
+        $expectedHeaders = $etag === '' ? [] : ['If-None-Match' => [$etag]];
+
+        $client = $this->createMock(IClient::class);
+        $client->expects($this->once())
+            ->method('get')
+            ->with($uri, ['headers' => $expectedHeaders])
+            ->willReturn($this->createMock(IResponse::class));
+
+        $this->clientService->expects($this->once())
+            ->method('newClient')
+            ->willReturn($client);
+
+        $response = $this->invokePrivate($this->checker, 'queryChangesServer', [$uri, $entry]);
+        $this->assertInstanceOf(IResponse::class, $response);
+    }
+
+    public static function versionProvider(): array {
+        return [
+            ['13.0.7', '13.0.7'],
+            ['13.0.7.3', '13.0.7'],
+            ['13.0.7.3.42', '13.0.7'],
+            ['13.0', '13.0.0'],
+            ['13', '13.0.0'],
+            ['', '0.0.0'],
+        ];
+    }
+
+    /**
+     * @dataProvider versionProvider
+     */
+    public function testNormalizeVersion(string $input, string $expected): void {
+        $normalized = $this->checker->normalizeVersion($input);
+        $this->assertSame($expected, $normalized);
+    }
+
+    public static function changeDataProvider():array {
+        $testDataFound = $testDataNotFound = self::versionProvider();
+        array_walk($testDataFound, static function (&$params) {
+            $params[] = true;
+        });
+        array_walk($testDataNotFound, static function (&$params) {
+            $params[] = false;
+        });
+        return array_merge($testDataFound, $testDataNotFound);
+    }
+
+    /**
+     * @dataProvider changeDataProvider
+     *
+     */
+    public function testGetChangesForVersion(string $inputVersion, string $normalizedVersion, bool $isFound): void {
+        $mocker = $this->mapper->expects($this->once())
+            ->method('getChanges')
+            ->with($normalizedVersion);
+
+        if (!$isFound) {
+            $this->expectException(DoesNotExistException::class);
+            $mocker->willThrowException(new DoesNotExistException('Changes info is not present'));
+        } else {
+            $entry = $this->createMock(Changes::class);
+            $entry->expects($this->once())
+                ->method('__call')
+                ->with('getData')
+                ->willReturn('{"changelogURL":"https:\/\/nextcloud.com\/changelog\/#13-0-0","whatsNew":{"en":{"regular":["Refined user interface","End-to-end Encryption","Video and Text Chat"],"admin":["Changes to the Nginx configuration","Theming: CSS files were consolidated"]},"de":{"regular":["\u00dcberarbeitete Benutzerschnittstelle","Ende-zu-Ende Verschl\u00fcsselung","Video- und Text-Chat"],"admin":["\u00c4nderungen an der Nginx Konfiguration","Theming: CSS Dateien wurden konsolidiert"]}}}');
+
+            $mocker->willReturn($entry);
+        }
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $data = $this->checker->getChangesForVersion($inputVersion);
+        $this->assertTrue(isset($data['whatsNew']['en']['regular']));
+        $this->assertTrue(isset($data['changelogURL']));
+    }
+
+    public function testGetChangesForVersionEmptyData(): void {
+        $entry = $this->createMock(Changes::class);
+        $entry->expects($this->once())
+            ->method('__call')
+            ->with('getData')
+            ->willReturn('');
+
+        $this->mapper->expects($this->once())
+            ->method('getChanges')
+            ->with('13.0.7')
+            ->willReturn($entry);
+
+        $this->expectException(DoesNotExistException::class);
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $this->checker->getChangesForVersion('13.0.7');
+    }
 }

Spacing +7 added lines, -7 removed lines

@@ -104,7 +104,7 @@ 
 
 	public static function changesXMLProvider(): array {
 		return [
-			[ # 0 - full example
+			[# 0 - full example
 				'<?xml version="1.0" encoding="utf-8" ?>
 <release xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://updates.nextcloud.com/changelog_server/schema.xsd"
@@ -161,7 +161,7 @@ 
 					],
 				]
 			],
-			[ # 1- admin part not translated
+			[# 1- admin part not translated
 				'<?xml version="1.0" encoding="utf-8" ?>
 <release xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://updates.nextcloud.com/changelog_server/schema.xsd"
@@ -212,7 +212,7 @@ 
 					],
 				]
 			],
-			[ # 2 - minimal set
+			[# 2 - minimal set
 				'<?xml version="1.0" encoding="utf-8" ?>
 <release xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://updates.nextcloud.com/changelog_server/schema.xsd"
@@ -240,7 +240,7 @@ 
 					],
 				]
 			],
-			[ # 3 - minimal set (procrastinator edition)
+			[# 3 - minimal set (procrastinator edition)
 				'<?xml version="1.0" encoding="utf-8" ?>
 <release xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="https://updates.nextcloud.com/changelog_server/schema.xsd"
@@ -264,7 +264,7 @@ 
 					],
 				]
 			],
-			[ # 4 - empty
+			[# 4 - empty
 				'',
 				[]
 			],
@@ -333,10 +333,10 @@ 
 
 	public static function changeDataProvider():array {
 		$testDataFound = $testDataNotFound = self::versionProvider();
-		array_walk($testDataFound, static function (&$params) {
+		array_walk($testDataFound, static function(&$params) {
 			$params[] = true;
 		});
-		array_walk($testDataNotFound, static function (&$params) {
+		array_walk($testDataNotFound, static function(&$params) {
 			$params[] = false;
 		});
 		return array_merge($testDataFound, $testDataNotFound);

tests/lib/DB/MigrationsTest.php

Indentation +898 added lines, -898 removed lines

@@ -41,902 +41,902 @@
  * @package Test\DB
  */
 class MigrationsTest extends \Test\TestCase {
-	private MigrationService|MockObject $migrationService;
-	private MockObject|IDBConnection $db;
-	private IAppManager $appManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->db = $this->createMock(Connection::class);
-		$this->db->expects($this->any())->method('getPrefix')->willReturn('test_oc_');
-		$this->migrationService = new MigrationService('testing', $this->db);
-
-		$this->appManager = Server::get(IAppManager::class);
-	}
-
-	public function testGetters(): void {
-		$this->assertEquals('testing', $this->migrationService->getApp());
-		$this->assertEquals(\OC::$SERVERROOT . '/apps/testing/lib/Migration', $this->migrationService->getMigrationsDirectory());
-		$this->assertEquals('OCA\Testing\Migration', $this->migrationService->getMigrationsNamespace());
-		$this->assertEquals('test_oc_migrations', $this->migrationService->getMigrationsTableName());
-	}
-
-	public function testCore(): void {
-		$this->migrationService = new MigrationService('core', $this->db);
-
-		$this->assertEquals('core', $this->migrationService->getApp());
-		$this->assertEquals(\OC::$SERVERROOT . '/core/Migrations', $this->migrationService->getMigrationsDirectory());
-		$this->assertEquals('OC\Core\Migrations', $this->migrationService->getMigrationsNamespace());
-		$this->assertEquals('test_oc_migrations', $this->migrationService->getMigrationsTableName());
-	}
-
-
-	public function testExecuteUnknownStep(): void {
-		$this->expectException(\InvalidArgumentException::class);
-		$this->expectExceptionMessage('Version 20170130180000 is unknown.');
-
-		$this->migrationService->executeStep('20170130180000');
-	}
-
-
-	public function testUnknownApp(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('App not found');
-
-		$migrationService = new MigrationService('unknown-bloody-app', $this->db);
-	}
-
-
-	public function testExecuteStepWithUnknownClass(): void {
-		$this->expectException(\Exception::class);
-		$this->expectExceptionMessage('Migration step \'X\' is unknown');
-
-		$this->migrationService = $this->getMockBuilder(MigrationService::class)
-			->onlyMethods(['findMigrations'])
-			->setConstructorArgs(['testing', $this->db])
-			->getMock();
-		$this->migrationService->expects($this->any())->method('findMigrations')->willReturn(
-			['20170130180000' => 'X', '20170130180001' => 'Y', '20170130180002' => 'Z', '20170130180003' => 'A']
-		);
-		$this->migrationService->executeStep('20170130180000');
-	}
-
-	public function testExecuteStepWithSchemaChange(): void {
-		$schema = $this->createMock(Schema::class);
-		$this->db->expects($this->any())
-			->method('createSchema')
-			->willReturn($schema);
-
-		$this->db->expects($this->once())
-			->method('migrateToSchema');
-
-		$wrappedSchema = $this->createMock(Schema::class);
-		$wrappedSchema->expects($this->exactly(2))
-			->method('getTables')
-			->willReturn([]);
-		$wrappedSchema->expects($this->exactly(2))
-			->method('getSequences')
-			->willReturn([]);
-
-		$schemaResult = $this->createMock(SchemaWrapper::class);
-		$schemaResult->expects($this->once())
-			->method('getWrappedSchema')
-			->willReturn($wrappedSchema);
-
-		$step = $this->createMock(IMigrationStep::class);
-		$step->expects($this->once())
-			->method('preSchemaChange');
-		$step->expects($this->once())
-			->method('changeSchema')
-			->willReturn($schemaResult);
-		$step->expects($this->once())
-			->method('postSchemaChange');
-
-		$this->migrationService = $this->getMockBuilder(MigrationService::class)
-			->onlyMethods(['createInstance'])
-			->setConstructorArgs(['testing', $this->db])
-			->getMock();
-
-		$this->migrationService->expects($this->any())
-			->method('createInstance')
-			->with('20170130180000')
-			->willReturn($step);
-		$this->migrationService->executeStep('20170130180000');
-	}
-
-	public function testExecuteStepWithoutSchemaChange(): void {
-		$schema = $this->createMock(Schema::class);
-		$this->db->expects($this->any())
-			->method('createSchema')
-			->willReturn($schema);
-
-		$this->db->expects($this->never())
-			->method('migrateToSchema');
-
-		$step = $this->createMock(IMigrationStep::class);
-		$step->expects($this->once())
-			->method('preSchemaChange');
-		$step->expects($this->once())
-			->method('changeSchema')
-			->willReturn(null);
-		$step->expects($this->once())
-			->method('postSchemaChange');
-
-		$this->migrationService = $this->getMockBuilder(MigrationService::class)
-			->onlyMethods(['createInstance'])
-			->setConstructorArgs(['testing', $this->db])
-			->getMock();
-
-		$this->migrationService->expects($this->any())
-			->method('createInstance')
-			->with('20170130180000')
-			->willReturn($step);
-		$this->migrationService->executeStep('20170130180000');
-	}
-
-	public function dataGetMigration() {
-		return [
-			['current', '20170130180001'],
-			['prev', '20170130180000'],
-			['next', '20170130180002'],
-			['latest', '20170130180003'],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetMigration
-	 * @param string $alias
-	 * @param string $expected
-	 */
-	public function testGetMigration($alias, $expected): void {
-		$this->migrationService = $this->getMockBuilder(MigrationService::class)
-			->onlyMethods(['getMigratedVersions', 'findMigrations'])
-			->setConstructorArgs(['testing', $this->db])
-			->getMock();
-		$this->migrationService->expects($this->any())->method('getMigratedVersions')->willReturn(
-			['20170130180000', '20170130180001']
-		);
-		$this->migrationService->expects($this->any())->method('findMigrations')->willReturn(
-			['20170130180000' => 'X', '20170130180001' => 'Y', '20170130180002' => 'Z', '20170130180003' => 'A']
-		);
-
-		$this->assertEquals(
-			['20170130180000', '20170130180001', '20170130180002', '20170130180003'],
-			$this->migrationService->getAvailableVersions());
-
-		$migration = $this->migrationService->getMigration($alias);
-		$this->assertEquals($expected, $migration);
-	}
-
-	public function testMigrate(): void {
-		$this->migrationService = $this->getMockBuilder(MigrationService::class)
-			->onlyMethods(['getMigratedVersions', 'findMigrations', 'executeStep'])
-			->setConstructorArgs(['testing', $this->db])
-			->getMock();
-		$this->migrationService->method('getMigratedVersions')
-			->willReturn(
-				['20170130180000', '20170130180001']
-			);
-		$this->migrationService->method('findMigrations')
-			->willReturn(
-				['20170130180000' => 'X', '20170130180001' => 'Y', '20170130180002' => 'Z', '20170130180003' => 'A']
-			);
-
-		$this->assertEquals(
-			['20170130180000', '20170130180001', '20170130180002', '20170130180003'],
-			$this->migrationService->getAvailableVersions()
-		);
-
-		$calls = [
-			['20170130180002', false],
-			['20170130180003', false],
-		];
-		$this->migrationService->expects($this->exactly(2))
-			->method('executeStep')
-			->willReturnCallback(function () use (&$calls) {
-				$expected = array_shift($calls);
-				$this->assertEquals($expected, func_get_args());
-			});
-		$this->migrationService->migrate();
-	}
-
-	public function testEnsureOracleConstraintsValid(): void {
-		$column = $this->createMock(Column::class);
-		$column->expects($this->once())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$index = $this->createMock(Index::class);
-		$index->expects($this->once())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$foreignKey = $this->createMock(ForeignKeyConstraint::class);
-		$foreignKey->expects($this->once())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->atLeastOnce())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$sequence = $this->createMock(Sequence::class);
-		$sequence->expects($this->atLeastOnce())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$primaryKey = $this->createMock(Index::class);
-		$primaryKey->expects($this->once())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([$column]);
-		$table->expects($this->once())
-			->method('getIndexes')
-			->willReturn([$index]);
-		$table->expects($this->once())
-			->method('getForeignKeys')
-			->willReturn([$foreignKey]);
-		$table->expects($this->once())
-			->method('getPrimaryKey')
-			->willReturn($primaryKey);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-		$schema->expects($this->once())
-			->method('getSequences')
-			->willReturn([$sequence]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-	public function testEnsureOracleConstraintsValidWithPrimaryKey(): void {
-		$index = $this->createMock(Index::class);
-		$index->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 26));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getIndexes')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getForeignKeys')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getPrimaryKey')
-			->willReturn($index);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-		$schema->expects($this->once())
-			->method('getSequences')
-			->willReturn([]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-	public function testEnsureOracleConstraintsValidWithPrimaryKeyDefault(): void {
-		$defaultName = 'PRIMARY';
-		if ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_POSTGRES) {
-			$defaultName = \str_repeat('a', 26) . '_' . \str_repeat('b', 30) . '_seq';
-		} elseif ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_ORACLE) {
-			$defaultName = \str_repeat('a', 26) . '_seq';
-		}
-
-		$index = $this->createMock(Index::class);
-		$index->expects($this->any())
-			->method('getName')
-			->willReturn($defaultName);
-		$index->expects($this->any())
-			->method('getColumns')
-			->willReturn([\str_repeat('b', 30)]);
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 25));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getIndexes')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getForeignKeys')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getPrimaryKey')
-			->willReturn($index);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-		$schema->expects($this->once())
-			->method('getSequences')
-			->willReturn([]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsTooLongTableName(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 31));
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsTooLongPrimaryWithDefault(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$defaultName = 'PRIMARY';
-		if ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_POSTGRES) {
-			$defaultName = \str_repeat('a', 27) . '_' . \str_repeat('b', 30) . '_seq';
-		} elseif ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_ORACLE) {
-			$defaultName = \str_repeat('a', 27) . '_seq';
-		}
-
-		$index = $this->createMock(Index::class);
-		$index->expects($this->any())
-			->method('getName')
-			->willReturn($defaultName);
-		$index->expects($this->any())
-			->method('getColumns')
-			->willReturn([\str_repeat('b', 30)]);
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 27));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getIndexes')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getForeignKeys')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getPrimaryKey')
-			->willReturn($index);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsTooLongPrimaryWithName(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$index = $this->createMock(Index::class);
-		$index->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 31));
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 26));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getIndexes')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getForeignKeys')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getPrimaryKey')
-			->willReturn($index);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsTooLongColumnName(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$column = $this->createMock(Column::class);
-		$column->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 31));
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([$column]);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsTooLongIndexName(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$index = $this->createMock(Index::class);
-		$index->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 31));
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getIndexes')
-			->willReturn([$index]);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsTooLongForeignKeyName(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$foreignKey = $this->createMock(ForeignKeyConstraint::class);
-		$foreignKey->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 31));
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getIndexes')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getForeignKeys')
-			->willReturn([$foreignKey]);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsNoPrimaryKey(): void {
-		$this->markTestSkipped('Test disabled for now due to multiple reasons, see https://github.com/nextcloud/server/pull/31580#issuecomment-1069182234 for details.');
-		$this->expectException(\InvalidArgumentException::class);
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->atLeastOnce())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getIndexes')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getForeignKeys')
-			->willReturn([]);
-		$table->expects($this->once())
-			->method('getPrimaryKey')
-			->willReturn(null);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-		$schema->expects($this->once())
-			->method('getSequences')
-			->willReturn([]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsTooLongSequenceName(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$sequence = $this->createMock(Sequence::class);
-		$sequence->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 31));
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([]);
-		$schema->expects($this->once())
-			->method('getSequences')
-			->willReturn([$sequence]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsBooleanNotNull(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$column = $this->createMock(Column::class);
-		$column->expects($this->any())
-			->method('getName')
-			->willReturn('aaaa');
-		$column->expects($this->any())
-			->method('getType')
-			->willReturn(Type::getType('boolean'));
-		$column->expects($this->any())
-			->method('getNotnull')
-			->willReturn(true);
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([$column]);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testEnsureOracleConstraintsStringLength4000(): void {
-		$this->expectException(\InvalidArgumentException::class);
-
-		$column = $this->createMock(Column::class);
-		$column->expects($this->any())
-			->method('getName')
-			->willReturn('aaaa');
-		$column->expects($this->any())
-			->method('getType')
-			->willReturn(Type::getType('string'));
-		$column->expects($this->any())
-			->method('getLength')
-			->willReturn(4001);
-
-		$table = $this->createMock(Table::class);
-		$table->expects($this->any())
-			->method('getName')
-			->willReturn(\str_repeat('a', 30));
-
-		$table->expects($this->once())
-			->method('getColumns')
-			->willReturn([$column]);
-
-		$schema = $this->createMock(Schema::class);
-		$schema->expects($this->once())
-			->method('getTables')
-			->willReturn([$table]);
-
-		$sourceSchema = $this->createMock(Schema::class);
-		$sourceSchema->expects($this->any())
-			->method('getTable')
-			->willThrowException(new SchemaException());
-		$sourceSchema->expects($this->any())
-			->method('hasSequence')
-			->willReturn(false);
-
-		self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
-	}
-
-
-	public function testExtractMigrationAttributes(): void {
-		$metadataManager = Server::get(MetadataManager::class);
-		$this->appManager->loadApp('testing');
-
-		$this->assertEquals($this->getMigrationMetadata(), json_decode(json_encode($metadataManager->extractMigrationAttributes('testing')), true));
-
-		$this->appManager->disableApp('testing');
-	}
-
-	public function testDeserializeMigrationMetadata(): void {
-		$metadataManager = Server::get(MetadataManager::class);
-		$this->assertEquals(
-			[
-				'core' => [],
-				'apps' => [
-					'testing' => [
-						'30000Date20240102030405' => [
-							new DropTable('old_table'),
-							new CreateTable('new_table',
-								description: 'Table is used to store things, but also to get more things',
-								notes:       ['this is a notice', 'and another one, if really needed']
-							),
-							new AddColumn('my_table'),
-							new AddColumn('my_table', 'another_field'),
-							new AddColumn('other_table', 'last_one', ColumnType::DATE),
-							new AddIndex('my_table'),
-							new AddIndex('my_table', IndexType::PRIMARY),
-							new DropColumn('other_table'),
-							new DropColumn('other_table', 'old_column',
-								description: 'field is not used anymore and replaced by \'last_one\''
-							),
-							new DropIndex('other_table'),
-							new ModifyColumn('other_table'),
-							new ModifyColumn('other_table', 'this_field'),
-							new ModifyColumn('other_table', 'this_field', ColumnType::BIGINT)
-						]
-					]
-				]
-			],
-			$metadataManager->getMigrationsAttributesFromReleaseMetadata(
-				[
-					'core' => [],
-					'apps' => ['testing' => $this->getMigrationMetadata()]
-				]
-			)
-		);
-	}
-
-	private function getMigrationMetadata(): array {
-		return [
-			'30000Date20240102030405' => [
-				[
-					'class' => 'OCP\\Migration\\Attributes\\DropTable',
-					'table' => 'old_table',
-					'description' => '',
-					'notes' => [],
-					'columns' => []
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\CreateTable',
-					'table' => 'new_table',
-					'description' => 'Table is used to store things, but also to get more things',
-					'notes' =>
-						[
-							'this is a notice',
-							'and another one, if really needed'
-						],
-					'columns' => []
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\AddColumn',
-					'table' => 'my_table',
-					'description' => '',
-					'notes' => [],
-					'name' => '',
-					'type' => ''
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\AddColumn',
-					'table' => 'my_table',
-					'description' => '',
-					'notes' => [],
-					'name' => 'another_field',
-					'type' => ''
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\AddColumn',
-					'table' => 'other_table',
-					'description' => '',
-					'notes' => [],
-					'name' => 'last_one',
-					'type' => 'date'
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\AddIndex',
-					'table' => 'my_table',
-					'description' => '',
-					'notes' => [],
-					'type' => ''
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\AddIndex',
-					'table' => 'my_table',
-					'description' => '',
-					'notes' => [],
-					'type' => 'primary'
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\DropColumn',
-					'table' => 'other_table',
-					'description' => '',
-					'notes' => [],
-					'name' => '',
-					'type' => ''
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\DropColumn',
-					'table' => 'other_table',
-					'description' => 'field is not used anymore and replaced by \'last_one\'',
-					'notes' => [],
-					'name' => 'old_column',
-					'type' => ''
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\DropIndex',
-					'table' => 'other_table',
-					'description' => '',
-					'notes' => [],
-					'type' => ''
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\ModifyColumn',
-					'table' => 'other_table',
-					'description' => '',
-					'notes' => [],
-					'name' => '',
-					'type' => ''
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\ModifyColumn',
-					'table' => 'other_table',
-					'description' => '',
-					'notes' => [],
-					'name' => 'this_field',
-					'type' => ''
-				],
-				[
-					'class' => 'OCP\\Migration\\Attributes\\ModifyColumn',
-					'table' => 'other_table',
-					'description' => '',
-					'notes' => [],
-					'name' => 'this_field',
-					'type' => 'bigint'
-				],
-			]
-		];
-	}
+    private MigrationService|MockObject $migrationService;
+    private MockObject|IDBConnection $db;
+    private IAppManager $appManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->db = $this->createMock(Connection::class);
+        $this->db->expects($this->any())->method('getPrefix')->willReturn('test_oc_');
+        $this->migrationService = new MigrationService('testing', $this->db);
+
+        $this->appManager = Server::get(IAppManager::class);
+    }
+
+    public function testGetters(): void {
+        $this->assertEquals('testing', $this->migrationService->getApp());
+        $this->assertEquals(\OC::$SERVERROOT . '/apps/testing/lib/Migration', $this->migrationService->getMigrationsDirectory());
+        $this->assertEquals('OCA\Testing\Migration', $this->migrationService->getMigrationsNamespace());
+        $this->assertEquals('test_oc_migrations', $this->migrationService->getMigrationsTableName());
+    }
+
+    public function testCore(): void {
+        $this->migrationService = new MigrationService('core', $this->db);
+
+        $this->assertEquals('core', $this->migrationService->getApp());
+        $this->assertEquals(\OC::$SERVERROOT . '/core/Migrations', $this->migrationService->getMigrationsDirectory());
+        $this->assertEquals('OC\Core\Migrations', $this->migrationService->getMigrationsNamespace());
+        $this->assertEquals('test_oc_migrations', $this->migrationService->getMigrationsTableName());
+    }
+
+
+    public function testExecuteUnknownStep(): void {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Version 20170130180000 is unknown.');
+
+        $this->migrationService->executeStep('20170130180000');
+    }
+
+
+    public function testUnknownApp(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('App not found');
+
+        $migrationService = new MigrationService('unknown-bloody-app', $this->db);
+    }
+
+
+    public function testExecuteStepWithUnknownClass(): void {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Migration step \'X\' is unknown');
+
+        $this->migrationService = $this->getMockBuilder(MigrationService::class)
+            ->onlyMethods(['findMigrations'])
+            ->setConstructorArgs(['testing', $this->db])
+            ->getMock();
+        $this->migrationService->expects($this->any())->method('findMigrations')->willReturn(
+            ['20170130180000' => 'X', '20170130180001' => 'Y', '20170130180002' => 'Z', '20170130180003' => 'A']
+        );
+        $this->migrationService->executeStep('20170130180000');
+    }
+
+    public function testExecuteStepWithSchemaChange(): void {
+        $schema = $this->createMock(Schema::class);
+        $this->db->expects($this->any())
+            ->method('createSchema')
+            ->willReturn($schema);
+
+        $this->db->expects($this->once())
+            ->method('migrateToSchema');
+
+        $wrappedSchema = $this->createMock(Schema::class);
+        $wrappedSchema->expects($this->exactly(2))
+            ->method('getTables')
+            ->willReturn([]);
+        $wrappedSchema->expects($this->exactly(2))
+            ->method('getSequences')
+            ->willReturn([]);
+
+        $schemaResult = $this->createMock(SchemaWrapper::class);
+        $schemaResult->expects($this->once())
+            ->method('getWrappedSchema')
+            ->willReturn($wrappedSchema);
+
+        $step = $this->createMock(IMigrationStep::class);
+        $step->expects($this->once())
+            ->method('preSchemaChange');
+        $step->expects($this->once())
+            ->method('changeSchema')
+            ->willReturn($schemaResult);
+        $step->expects($this->once())
+            ->method('postSchemaChange');
+
+        $this->migrationService = $this->getMockBuilder(MigrationService::class)
+            ->onlyMethods(['createInstance'])
+            ->setConstructorArgs(['testing', $this->db])
+            ->getMock();
+
+        $this->migrationService->expects($this->any())
+            ->method('createInstance')
+            ->with('20170130180000')
+            ->willReturn($step);
+        $this->migrationService->executeStep('20170130180000');
+    }
+
+    public function testExecuteStepWithoutSchemaChange(): void {
+        $schema = $this->createMock(Schema::class);
+        $this->db->expects($this->any())
+            ->method('createSchema')
+            ->willReturn($schema);
+
+        $this->db->expects($this->never())
+            ->method('migrateToSchema');
+
+        $step = $this->createMock(IMigrationStep::class);
+        $step->expects($this->once())
+            ->method('preSchemaChange');
+        $step->expects($this->once())
+            ->method('changeSchema')
+            ->willReturn(null);
+        $step->expects($this->once())
+            ->method('postSchemaChange');
+
+        $this->migrationService = $this->getMockBuilder(MigrationService::class)
+            ->onlyMethods(['createInstance'])
+            ->setConstructorArgs(['testing', $this->db])
+            ->getMock();
+
+        $this->migrationService->expects($this->any())
+            ->method('createInstance')
+            ->with('20170130180000')
+            ->willReturn($step);
+        $this->migrationService->executeStep('20170130180000');
+    }
+
+    public function dataGetMigration() {
+        return [
+            ['current', '20170130180001'],
+            ['prev', '20170130180000'],
+            ['next', '20170130180002'],
+            ['latest', '20170130180003'],
+        ];
+    }
+
+    /**
+     * @dataProvider dataGetMigration
+     * @param string $alias
+     * @param string $expected
+     */
+    public function testGetMigration($alias, $expected): void {
+        $this->migrationService = $this->getMockBuilder(MigrationService::class)
+            ->onlyMethods(['getMigratedVersions', 'findMigrations'])
+            ->setConstructorArgs(['testing', $this->db])
+            ->getMock();
+        $this->migrationService->expects($this->any())->method('getMigratedVersions')->willReturn(
+            ['20170130180000', '20170130180001']
+        );
+        $this->migrationService->expects($this->any())->method('findMigrations')->willReturn(
+            ['20170130180000' => 'X', '20170130180001' => 'Y', '20170130180002' => 'Z', '20170130180003' => 'A']
+        );
+
+        $this->assertEquals(
+            ['20170130180000', '20170130180001', '20170130180002', '20170130180003'],
+            $this->migrationService->getAvailableVersions());
+
+        $migration = $this->migrationService->getMigration($alias);
+        $this->assertEquals($expected, $migration);
+    }
+
+    public function testMigrate(): void {
+        $this->migrationService = $this->getMockBuilder(MigrationService::class)
+            ->onlyMethods(['getMigratedVersions', 'findMigrations', 'executeStep'])
+            ->setConstructorArgs(['testing', $this->db])
+            ->getMock();
+        $this->migrationService->method('getMigratedVersions')
+            ->willReturn(
+                ['20170130180000', '20170130180001']
+            );
+        $this->migrationService->method('findMigrations')
+            ->willReturn(
+                ['20170130180000' => 'X', '20170130180001' => 'Y', '20170130180002' => 'Z', '20170130180003' => 'A']
+            );
+
+        $this->assertEquals(
+            ['20170130180000', '20170130180001', '20170130180002', '20170130180003'],
+            $this->migrationService->getAvailableVersions()
+        );
+
+        $calls = [
+            ['20170130180002', false],
+            ['20170130180003', false],
+        ];
+        $this->migrationService->expects($this->exactly(2))
+            ->method('executeStep')
+            ->willReturnCallback(function () use (&$calls) {
+                $expected = array_shift($calls);
+                $this->assertEquals($expected, func_get_args());
+            });
+        $this->migrationService->migrate();
+    }
+
+    public function testEnsureOracleConstraintsValid(): void {
+        $column = $this->createMock(Column::class);
+        $column->expects($this->once())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $index = $this->createMock(Index::class);
+        $index->expects($this->once())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $foreignKey = $this->createMock(ForeignKeyConstraint::class);
+        $foreignKey->expects($this->once())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->atLeastOnce())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $sequence = $this->createMock(Sequence::class);
+        $sequence->expects($this->atLeastOnce())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $primaryKey = $this->createMock(Index::class);
+        $primaryKey->expects($this->once())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([$column]);
+        $table->expects($this->once())
+            ->method('getIndexes')
+            ->willReturn([$index]);
+        $table->expects($this->once())
+            ->method('getForeignKeys')
+            ->willReturn([$foreignKey]);
+        $table->expects($this->once())
+            ->method('getPrimaryKey')
+            ->willReturn($primaryKey);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+        $schema->expects($this->once())
+            ->method('getSequences')
+            ->willReturn([$sequence]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+    public function testEnsureOracleConstraintsValidWithPrimaryKey(): void {
+        $index = $this->createMock(Index::class);
+        $index->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 26));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getIndexes')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getForeignKeys')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getPrimaryKey')
+            ->willReturn($index);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+        $schema->expects($this->once())
+            ->method('getSequences')
+            ->willReturn([]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+    public function testEnsureOracleConstraintsValidWithPrimaryKeyDefault(): void {
+        $defaultName = 'PRIMARY';
+        if ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_POSTGRES) {
+            $defaultName = \str_repeat('a', 26) . '_' . \str_repeat('b', 30) . '_seq';
+        } elseif ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_ORACLE) {
+            $defaultName = \str_repeat('a', 26) . '_seq';
+        }
+
+        $index = $this->createMock(Index::class);
+        $index->expects($this->any())
+            ->method('getName')
+            ->willReturn($defaultName);
+        $index->expects($this->any())
+            ->method('getColumns')
+            ->willReturn([\str_repeat('b', 30)]);
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 25));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getIndexes')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getForeignKeys')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getPrimaryKey')
+            ->willReturn($index);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+        $schema->expects($this->once())
+            ->method('getSequences')
+            ->willReturn([]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsTooLongTableName(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 31));
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsTooLongPrimaryWithDefault(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $defaultName = 'PRIMARY';
+        if ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_POSTGRES) {
+            $defaultName = \str_repeat('a', 27) . '_' . \str_repeat('b', 30) . '_seq';
+        } elseif ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_ORACLE) {
+            $defaultName = \str_repeat('a', 27) . '_seq';
+        }
+
+        $index = $this->createMock(Index::class);
+        $index->expects($this->any())
+            ->method('getName')
+            ->willReturn($defaultName);
+        $index->expects($this->any())
+            ->method('getColumns')
+            ->willReturn([\str_repeat('b', 30)]);
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 27));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getIndexes')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getForeignKeys')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getPrimaryKey')
+            ->willReturn($index);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsTooLongPrimaryWithName(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $index = $this->createMock(Index::class);
+        $index->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 31));
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 26));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getIndexes')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getForeignKeys')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getPrimaryKey')
+            ->willReturn($index);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsTooLongColumnName(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $column = $this->createMock(Column::class);
+        $column->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 31));
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([$column]);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsTooLongIndexName(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $index = $this->createMock(Index::class);
+        $index->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 31));
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getIndexes')
+            ->willReturn([$index]);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsTooLongForeignKeyName(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $foreignKey = $this->createMock(ForeignKeyConstraint::class);
+        $foreignKey->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 31));
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getIndexes')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getForeignKeys')
+            ->willReturn([$foreignKey]);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsNoPrimaryKey(): void {
+        $this->markTestSkipped('Test disabled for now due to multiple reasons, see https://github.com/nextcloud/server/pull/31580#issuecomment-1069182234 for details.');
+        $this->expectException(\InvalidArgumentException::class);
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->atLeastOnce())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getIndexes')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getForeignKeys')
+            ->willReturn([]);
+        $table->expects($this->once())
+            ->method('getPrimaryKey')
+            ->willReturn(null);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+        $schema->expects($this->once())
+            ->method('getSequences')
+            ->willReturn([]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsTooLongSequenceName(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $sequence = $this->createMock(Sequence::class);
+        $sequence->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 31));
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([]);
+        $schema->expects($this->once())
+            ->method('getSequences')
+            ->willReturn([$sequence]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsBooleanNotNull(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $column = $this->createMock(Column::class);
+        $column->expects($this->any())
+            ->method('getName')
+            ->willReturn('aaaa');
+        $column->expects($this->any())
+            ->method('getType')
+            ->willReturn(Type::getType('boolean'));
+        $column->expects($this->any())
+            ->method('getNotnull')
+            ->willReturn(true);
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([$column]);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testEnsureOracleConstraintsStringLength4000(): void {
+        $this->expectException(\InvalidArgumentException::class);
+
+        $column = $this->createMock(Column::class);
+        $column->expects($this->any())
+            ->method('getName')
+            ->willReturn('aaaa');
+        $column->expects($this->any())
+            ->method('getType')
+            ->willReturn(Type::getType('string'));
+        $column->expects($this->any())
+            ->method('getLength')
+            ->willReturn(4001);
+
+        $table = $this->createMock(Table::class);
+        $table->expects($this->any())
+            ->method('getName')
+            ->willReturn(\str_repeat('a', 30));
+
+        $table->expects($this->once())
+            ->method('getColumns')
+            ->willReturn([$column]);
+
+        $schema = $this->createMock(Schema::class);
+        $schema->expects($this->once())
+            ->method('getTables')
+            ->willReturn([$table]);
+
+        $sourceSchema = $this->createMock(Schema::class);
+        $sourceSchema->expects($this->any())
+            ->method('getTable')
+            ->willThrowException(new SchemaException());
+        $sourceSchema->expects($this->any())
+            ->method('hasSequence')
+            ->willReturn(false);
+
+        self::invokePrivate($this->migrationService, 'ensureOracleConstraints', [$sourceSchema, $schema, 3]);
+    }
+
+
+    public function testExtractMigrationAttributes(): void {
+        $metadataManager = Server::get(MetadataManager::class);
+        $this->appManager->loadApp('testing');
+
+        $this->assertEquals($this->getMigrationMetadata(), json_decode(json_encode($metadataManager->extractMigrationAttributes('testing')), true));
+
+        $this->appManager->disableApp('testing');
+    }
+
+    public function testDeserializeMigrationMetadata(): void {
+        $metadataManager = Server::get(MetadataManager::class);
+        $this->assertEquals(
+            [
+                'core' => [],
+                'apps' => [
+                    'testing' => [
+                        '30000Date20240102030405' => [
+                            new DropTable('old_table'),
+                            new CreateTable('new_table',
+                                description: 'Table is used to store things, but also to get more things',
+                                notes:       ['this is a notice', 'and another one, if really needed']
+                            ),
+                            new AddColumn('my_table'),
+                            new AddColumn('my_table', 'another_field'),
+                            new AddColumn('other_table', 'last_one', ColumnType::DATE),
+                            new AddIndex('my_table'),
+                            new AddIndex('my_table', IndexType::PRIMARY),
+                            new DropColumn('other_table'),
+                            new DropColumn('other_table', 'old_column',
+                                description: 'field is not used anymore and replaced by \'last_one\''
+                            ),
+                            new DropIndex('other_table'),
+                            new ModifyColumn('other_table'),
+                            new ModifyColumn('other_table', 'this_field'),
+                            new ModifyColumn('other_table', 'this_field', ColumnType::BIGINT)
+                        ]
+                    ]
+                ]
+            ],
+            $metadataManager->getMigrationsAttributesFromReleaseMetadata(
+                [
+                    'core' => [],
+                    'apps' => ['testing' => $this->getMigrationMetadata()]
+                ]
+            )
+        );
+    }
+
+    private function getMigrationMetadata(): array {
+        return [
+            '30000Date20240102030405' => [
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\DropTable',
+                    'table' => 'old_table',
+                    'description' => '',
+                    'notes' => [],
+                    'columns' => []
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\CreateTable',
+                    'table' => 'new_table',
+                    'description' => 'Table is used to store things, but also to get more things',
+                    'notes' =>
+                        [
+                            'this is a notice',
+                            'and another one, if really needed'
+                        ],
+                    'columns' => []
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\AddColumn',
+                    'table' => 'my_table',
+                    'description' => '',
+                    'notes' => [],
+                    'name' => '',
+                    'type' => ''
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\AddColumn',
+                    'table' => 'my_table',
+                    'description' => '',
+                    'notes' => [],
+                    'name' => 'another_field',
+                    'type' => ''
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\AddColumn',
+                    'table' => 'other_table',
+                    'description' => '',
+                    'notes' => [],
+                    'name' => 'last_one',
+                    'type' => 'date'
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\AddIndex',
+                    'table' => 'my_table',
+                    'description' => '',
+                    'notes' => [],
+                    'type' => ''
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\AddIndex',
+                    'table' => 'my_table',
+                    'description' => '',
+                    'notes' => [],
+                    'type' => 'primary'
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\DropColumn',
+                    'table' => 'other_table',
+                    'description' => '',
+                    'notes' => [],
+                    'name' => '',
+                    'type' => ''
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\DropColumn',
+                    'table' => 'other_table',
+                    'description' => 'field is not used anymore and replaced by \'last_one\'',
+                    'notes' => [],
+                    'name' => 'old_column',
+                    'type' => ''
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\DropIndex',
+                    'table' => 'other_table',
+                    'description' => '',
+                    'notes' => [],
+                    'type' => ''
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\ModifyColumn',
+                    'table' => 'other_table',
+                    'description' => '',
+                    'notes' => [],
+                    'name' => '',
+                    'type' => ''
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\ModifyColumn',
+                    'table' => 'other_table',
+                    'description' => '',
+                    'notes' => [],
+                    'name' => 'this_field',
+                    'type' => ''
+                ],
+                [
+                    'class' => 'OCP\\Migration\\Attributes\\ModifyColumn',
+                    'table' => 'other_table',
+                    'description' => '',
+                    'notes' => [],
+                    'name' => 'this_field',
+                    'type' => 'bigint'
+                ],
+            ]
+        ];
+    }
 }

Spacing +9 added lines, -9 removed lines

@@ -41,8 +41,8 @@ 
  * @package Test\DB
  */
 class MigrationsTest extends \Test\TestCase {
-	private MigrationService|MockObject $migrationService;
-	private MockObject|IDBConnection $db;
+	private MigrationService | MockObject $migrationService;
+	private MockObject | IDBConnection $db;
 	private IAppManager $appManager;
 
 	protected function setUp(): void {
@@ -57,7 +57,7 @@ 
 
 	public function testGetters(): void {
 		$this->assertEquals('testing', $this->migrationService->getApp());
-		$this->assertEquals(\OC::$SERVERROOT . '/apps/testing/lib/Migration', $this->migrationService->getMigrationsDirectory());
+		$this->assertEquals(\OC::$SERVERROOT.'/apps/testing/lib/Migration', $this->migrationService->getMigrationsDirectory());
 		$this->assertEquals('OCA\Testing\Migration', $this->migrationService->getMigrationsNamespace());
 		$this->assertEquals('test_oc_migrations', $this->migrationService->getMigrationsTableName());
 	}
@@ -66,7 +66,7 @@ 
 		$this->migrationService = new MigrationService('core', $this->db);
 
 		$this->assertEquals('core', $this->migrationService->getApp());
-		$this->assertEquals(\OC::$SERVERROOT . '/core/Migrations', $this->migrationService->getMigrationsDirectory());
+		$this->assertEquals(\OC::$SERVERROOT.'/core/Migrations', $this->migrationService->getMigrationsDirectory());
 		$this->assertEquals('OC\Core\Migrations', $this->migrationService->getMigrationsNamespace());
 		$this->assertEquals('test_oc_migrations', $this->migrationService->getMigrationsTableName());
 	}
@@ -234,7 +234,7 @@ 
 		];
 		$this->migrationService->expects($this->exactly(2))
 			->method('executeStep')
-			->willReturnCallback(function () use (&$calls) {
+			->willReturnCallback(function() use (&$calls) {
 				$expected = array_shift($calls);
 				$this->assertEquals($expected, func_get_args());
 			});
@@ -350,9 +350,9 @@ 
 	public function testEnsureOracleConstraintsValidWithPrimaryKeyDefault(): void {
 		$defaultName = 'PRIMARY';
 		if ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_POSTGRES) {
-			$defaultName = \str_repeat('a', 26) . '_' . \str_repeat('b', 30) . '_seq';
+			$defaultName = \str_repeat('a', 26).'_'.\str_repeat('b', 30).'_seq';
 		} elseif ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_ORACLE) {
-			$defaultName = \str_repeat('a', 26) . '_seq';
+			$defaultName = \str_repeat('a', 26).'_seq';
 		}
 
 		$index = $this->createMock(Index::class);
@@ -431,9 +431,9 @@ 
 
 		$defaultName = 'PRIMARY';
 		if ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_POSTGRES) {
-			$defaultName = \str_repeat('a', 27) . '_' . \str_repeat('b', 30) . '_seq';
+			$defaultName = \str_repeat('a', 27).'_'.\str_repeat('b', 30).'_seq';
 		} elseif ($this->db->getDatabaseProvider() === IDBConnection::PLATFORM_ORACLE) {
-			$defaultName = \str_repeat('a', 27) . '_seq';
+			$defaultName = \str_repeat('a', 27).'_seq';
 		}
 
 		$index = $this->createMock(Index::class);

tests/lib/User/AvailabilityCoordinatorTest.php

Indentation +194 added lines, -194 removed lines

@@ -23,198 +23,198 @@
 use Test\TestCase;
 
 class AvailabilityCoordinatorTest extends TestCase {
-	private AvailabilityCoordinator $availabilityCoordinator;
-	private ICacheFactory $cacheFactory;
-	private ICache $cache;
-	private IConfig|MockObject $config;
-	private AbsenceService $absenceService;
-	private LoggerInterface $logger;
-	private MockObject|TimezoneService $timezoneService;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->cacheFactory = $this->createMock(ICacheFactory::class);
-		$this->cache = $this->createMock(ICache::class);
-		$this->absenceService = $this->createMock(AbsenceService::class);
-		$this->config = $this->createMock(IConfig::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->timezoneService = $this->createMock(TimezoneService::class);
-
-		$this->cacheFactory->expects(self::once())
-			->method('createLocal')
-			->willReturn($this->cache);
-
-		$this->availabilityCoordinator = new AvailabilityCoordinator(
-			$this->cacheFactory,
-			$this->config,
-			$this->absenceService,
-			$this->logger,
-			$this->timezoneService,
-		);
-	}
-
-	public function testIsEnabled(): void {
-		$this->config->expects(self::once())
-			->method('getAppValue')
-			->with('dav', 'hide_absence_settings', 'no')
-			->willReturn('no');
-
-		$isEnabled = $this->availabilityCoordinator->isEnabled();
-
-		self::assertTrue($isEnabled);
-	}
-
-	public function testGetOutOfOfficeDataInEffect(): void {
-		$absence = new Absence();
-		$absence->setId(420);
-		$absence->setUserId('user');
-		$absence->setFirstDay('2023-10-01');
-		$absence->setLastDay('2023-10-08');
-		$absence->setStatus('Vacation');
-		$absence->setMessage('On vacation');
-		$absence->setReplacementUserId('batman');
-		$absence->setReplacementUserDisplayName('Bruce Wayne');
-		$this->timezoneService->method('getUserTimezone')->with('user')->willReturn('Europe/Berlin');
-
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-
-		$this->cache->expects(self::exactly(2))
-			->method('get')
-			->willReturnOnConsecutiveCalls(null, null);
-		$this->absenceService->expects(self::once())
-			->method('getAbsence')
-			->with($user->getUID())
-			->willReturn($absence);
-
-		$calls = [
-			[$user->getUID() . '_timezone', 'Europe/Berlin', 3600],
-			[$user->getUID(), '{"id":"420","startDate":1696111200,"endDate":1696802340,"shortMessage":"Vacation","message":"On vacation","replacementUserId":"batman","replacementUserDisplayName":"Bruce Wayne"}', 300],
-		];
-		$this->cache->expects(self::exactly(2))
-			->method('set')
-			->willReturnCallback(static function () use (&$calls): void {
-				$expected = array_shift($calls);
-				self::assertEquals($expected, func_get_args());
-			});
-
-		$expected = new OutOfOfficeData(
-			'420',
-			$user,
-			1696111200,
-			1696802340,
-			'Vacation',
-			'On vacation',
-			'batman',
-			'Bruce Wayne',
-		);
-		$actual = $this->availabilityCoordinator->getCurrentOutOfOfficeData($user);
-		self::assertEquals($expected, $actual);
-	}
-
-	public function testGetOutOfOfficeDataCachedAll(): void {
-		$absence = new Absence();
-		$absence->setId(420);
-		$absence->setUserId('user');
-		$absence->setFirstDay('2023-10-01');
-		$absence->setLastDay('2023-10-08');
-		$absence->setStatus('Vacation');
-		$absence->setMessage('On vacation');
-		$absence->setReplacementUserId('batman');
-		$absence->setReplacementUserDisplayName('Bruce Wayne');
-
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-
-		$this->cache->expects(self::exactly(2))
-			->method('get')
-			->willReturnOnConsecutiveCalls('UTC', '{"id":"420","startDate":1696118400,"endDate":1696809540,"shortMessage":"Vacation","message":"On vacation","replacementUserId":"batman","replacementUserDisplayName":"Bruce Wayne"}');
-		$this->absenceService->expects(self::never())
-			->method('getAbsence');
-		$this->cache->expects(self::exactly(1))
-			->method('set');
-
-		$expected = new OutOfOfficeData(
-			'420',
-			$user,
-			1696118400,
-			1696809540,
-			'Vacation',
-			'On vacation',
-			'batman',
-			'Bruce Wayne'
-		);
-		$actual = $this->availabilityCoordinator->getCurrentOutOfOfficeData($user);
-		self::assertEquals($expected, $actual);
-	}
-
-	public function testGetOutOfOfficeDataNoData(): void {
-		$absence = new Absence();
-		$absence->setId(420);
-		$absence->setUserId('user');
-		$absence->setFirstDay('2023-10-01');
-		$absence->setLastDay('2023-10-08');
-		$absence->setStatus('Vacation');
-		$absence->setMessage('On vacation');
-
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-
-		$this->cache->expects(self::exactly(2))
-			->method('get')
-			->willReturnOnConsecutiveCalls('UTC', null);
-		$this->absenceService->expects(self::once())
-			->method('getAbsence')
-			->willReturn(null);
-		$this->cache->expects(self::never())
-			->method('set');
-
-		$actual = $this->availabilityCoordinator->getCurrentOutOfOfficeData($user);
-		self::assertNull($actual);
-	}
-
-	public function testGetOutOfOfficeDataWithInvalidCachedData(): void {
-		$absence = new Absence();
-		$absence->setId(420);
-		$absence->setUserId('user');
-		$absence->setFirstDay('2023-10-01');
-		$absence->setLastDay('2023-10-08');
-		$absence->setStatus('Vacation');
-		$absence->setMessage('On vacation');
-		$absence->setReplacementUserId('batman');
-		$absence->setReplacementUserDisplayName('Bruce Wayne');
-		$this->timezoneService->method('getUserTimezone')->with('user')->willReturn('Europe/Berlin');
-
-		$user = $this->createMock(IUser::class);
-		$user->method('getUID')
-			->willReturn('user');
-
-		$this->cache->expects(self::exactly(2))
-			->method('get')
-			->willReturnOnConsecutiveCalls('UTC', '{"id":"420",}');
-		$this->absenceService->expects(self::once())
-			->method('getAbsence')
-			->with('user')
-			->willReturn($absence);
-		$this->cache->expects(self::once())
-			->method('set')
-			->with('user', '{"id":"420","startDate":1696118400,"endDate":1696809540,"shortMessage":"Vacation","message":"On vacation","replacementUserId":"batman","replacementUserDisplayName":"Bruce Wayne"}', 300);
-
-		$expected = new OutOfOfficeData(
-			'420',
-			$user,
-			1696118400,
-			1696809540,
-			'Vacation',
-			'On vacation',
-			'batman',
-			'Bruce Wayne'
-		);
-		$actual = $this->availabilityCoordinator->getCurrentOutOfOfficeData($user);
-		self::assertEquals($expected, $actual);
-	}
+    private AvailabilityCoordinator $availabilityCoordinator;
+    private ICacheFactory $cacheFactory;
+    private ICache $cache;
+    private IConfig|MockObject $config;
+    private AbsenceService $absenceService;
+    private LoggerInterface $logger;
+    private MockObject|TimezoneService $timezoneService;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->cacheFactory = $this->createMock(ICacheFactory::class);
+        $this->cache = $this->createMock(ICache::class);
+        $this->absenceService = $this->createMock(AbsenceService::class);
+        $this->config = $this->createMock(IConfig::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->timezoneService = $this->createMock(TimezoneService::class);
+
+        $this->cacheFactory->expects(self::once())
+            ->method('createLocal')
+            ->willReturn($this->cache);
+
+        $this->availabilityCoordinator = new AvailabilityCoordinator(
+            $this->cacheFactory,
+            $this->config,
+            $this->absenceService,
+            $this->logger,
+            $this->timezoneService,
+        );
+    }
+
+    public function testIsEnabled(): void {
+        $this->config->expects(self::once())
+            ->method('getAppValue')
+            ->with('dav', 'hide_absence_settings', 'no')
+            ->willReturn('no');
+
+        $isEnabled = $this->availabilityCoordinator->isEnabled();
+
+        self::assertTrue($isEnabled);
+    }
+
+    public function testGetOutOfOfficeDataInEffect(): void {
+        $absence = new Absence();
+        $absence->setId(420);
+        $absence->setUserId('user');
+        $absence->setFirstDay('2023-10-01');
+        $absence->setLastDay('2023-10-08');
+        $absence->setStatus('Vacation');
+        $absence->setMessage('On vacation');
+        $absence->setReplacementUserId('batman');
+        $absence->setReplacementUserDisplayName('Bruce Wayne');
+        $this->timezoneService->method('getUserTimezone')->with('user')->willReturn('Europe/Berlin');
+
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+
+        $this->cache->expects(self::exactly(2))
+            ->method('get')
+            ->willReturnOnConsecutiveCalls(null, null);
+        $this->absenceService->expects(self::once())
+            ->method('getAbsence')
+            ->with($user->getUID())
+            ->willReturn($absence);
+
+        $calls = [
+            [$user->getUID() . '_timezone', 'Europe/Berlin', 3600],
+            [$user->getUID(), '{"id":"420","startDate":1696111200,"endDate":1696802340,"shortMessage":"Vacation","message":"On vacation","replacementUserId":"batman","replacementUserDisplayName":"Bruce Wayne"}', 300],
+        ];
+        $this->cache->expects(self::exactly(2))
+            ->method('set')
+            ->willReturnCallback(static function () use (&$calls): void {
+                $expected = array_shift($calls);
+                self::assertEquals($expected, func_get_args());
+            });
+
+        $expected = new OutOfOfficeData(
+            '420',
+            $user,
+            1696111200,
+            1696802340,
+            'Vacation',
+            'On vacation',
+            'batman',
+            'Bruce Wayne',
+        );
+        $actual = $this->availabilityCoordinator->getCurrentOutOfOfficeData($user);
+        self::assertEquals($expected, $actual);
+    }
+
+    public function testGetOutOfOfficeDataCachedAll(): void {
+        $absence = new Absence();
+        $absence->setId(420);
+        $absence->setUserId('user');
+        $absence->setFirstDay('2023-10-01');
+        $absence->setLastDay('2023-10-08');
+        $absence->setStatus('Vacation');
+        $absence->setMessage('On vacation');
+        $absence->setReplacementUserId('batman');
+        $absence->setReplacementUserDisplayName('Bruce Wayne');
+
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+
+        $this->cache->expects(self::exactly(2))
+            ->method('get')
+            ->willReturnOnConsecutiveCalls('UTC', '{"id":"420","startDate":1696118400,"endDate":1696809540,"shortMessage":"Vacation","message":"On vacation","replacementUserId":"batman","replacementUserDisplayName":"Bruce Wayne"}');
+        $this->absenceService->expects(self::never())
+            ->method('getAbsence');
+        $this->cache->expects(self::exactly(1))
+            ->method('set');
+
+        $expected = new OutOfOfficeData(
+            '420',
+            $user,
+            1696118400,
+            1696809540,
+            'Vacation',
+            'On vacation',
+            'batman',
+            'Bruce Wayne'
+        );
+        $actual = $this->availabilityCoordinator->getCurrentOutOfOfficeData($user);
+        self::assertEquals($expected, $actual);
+    }
+
+    public function testGetOutOfOfficeDataNoData(): void {
+        $absence = new Absence();
+        $absence->setId(420);
+        $absence->setUserId('user');
+        $absence->setFirstDay('2023-10-01');
+        $absence->setLastDay('2023-10-08');
+        $absence->setStatus('Vacation');
+        $absence->setMessage('On vacation');
+
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+
+        $this->cache->expects(self::exactly(2))
+            ->method('get')
+            ->willReturnOnConsecutiveCalls('UTC', null);
+        $this->absenceService->expects(self::once())
+            ->method('getAbsence')
+            ->willReturn(null);
+        $this->cache->expects(self::never())
+            ->method('set');
+
+        $actual = $this->availabilityCoordinator->getCurrentOutOfOfficeData($user);
+        self::assertNull($actual);
+    }
+
+    public function testGetOutOfOfficeDataWithInvalidCachedData(): void {
+        $absence = new Absence();
+        $absence->setId(420);
+        $absence->setUserId('user');
+        $absence->setFirstDay('2023-10-01');
+        $absence->setLastDay('2023-10-08');
+        $absence->setStatus('Vacation');
+        $absence->setMessage('On vacation');
+        $absence->setReplacementUserId('batman');
+        $absence->setReplacementUserDisplayName('Bruce Wayne');
+        $this->timezoneService->method('getUserTimezone')->with('user')->willReturn('Europe/Berlin');
+
+        $user = $this->createMock(IUser::class);
+        $user->method('getUID')
+            ->willReturn('user');
+
+        $this->cache->expects(self::exactly(2))
+            ->method('get')
+            ->willReturnOnConsecutiveCalls('UTC', '{"id":"420",}');
+        $this->absenceService->expects(self::once())
+            ->method('getAbsence')
+            ->with('user')
+            ->willReturn($absence);
+        $this->cache->expects(self::once())
+            ->method('set')
+            ->with('user', '{"id":"420","startDate":1696118400,"endDate":1696809540,"shortMessage":"Vacation","message":"On vacation","replacementUserId":"batman","replacementUserDisplayName":"Bruce Wayne"}', 300);
+
+        $expected = new OutOfOfficeData(
+            '420',
+            $user,
+            1696118400,
+            1696809540,
+            'Vacation',
+            'On vacation',
+            'batman',
+            'Bruce Wayne'
+        );
+        $actual = $this->availabilityCoordinator->getCurrentOutOfOfficeData($user);
+        self::assertEquals($expected, $actual);
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -26,10 +26,10 @@ 
 	private AvailabilityCoordinator $availabilityCoordinator;
 	private ICacheFactory $cacheFactory;
 	private ICache $cache;
-	private IConfig|MockObject $config;
+	private IConfig | MockObject $config;
 	private AbsenceService $absenceService;
 	private LoggerInterface $logger;
-	private MockObject|TimezoneService $timezoneService;
+	private MockObject | TimezoneService $timezoneService;
 
 	protected function setUp(): void {
 		parent::setUp();
@@ -90,12 +90,12 @@ 
 			->willReturn($absence);
 
 		$calls = [
-			[$user->getUID() . '_timezone', 'Europe/Berlin', 3600],
+			[$user->getUID().'_timezone', 'Europe/Berlin', 3600],
 			[$user->getUID(), '{"id":"420","startDate":1696111200,"endDate":1696802340,"shortMessage":"Vacation","message":"On vacation","replacementUserId":"batman","replacementUserDisplayName":"Bruce Wayne"}', 300],
 		];
 		$this->cache->expects(self::exactly(2))
 			->method('set')
-			->willReturnCallback(static function () use (&$calls): void {
+			->willReturnCallback(static function() use (&$calls): void {
 				$expected = array_shift($calls);
 				self::assertEquals($expected, func_get_args());
 			});

tests/lib/Collaboration/Resources/ProviderManagerTest.php

Indentation +78 added lines, -78 removed lines

@@ -17,82 +17,82 @@
 use Test\TestCase;
 
 class ProviderManagerTest extends TestCase {
-	/** @var IServerContainer */
-	protected $serverContainer;
-	/** @var LoggerInterface */
-	protected $logger;
-	/** @var IProviderManager */
-	protected $providerManager;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->serverContainer = $this->createMock(IServerContainer::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-
-		$this->providerManager = new class($this->serverContainer, $this->logger) extends ProviderManager {
-			public function countProviders(): int {
-				return count($this->providers);
-			}
-		};
-	}
-
-	public function testRegisterResourceProvider(): void {
-		$this->providerManager->registerResourceProvider('AwesomeResourceProvider');
-		$this->assertSame(1, $this->providerManager->countProviders());
-	}
-
-	public function testGetResourceProvidersNoProvider(): void {
-		$this->assertCount(0, $this->providerManager->getResourceProviders());
-	}
-
-	public function testGetResourceProvidersValidProvider(): void {
-		$this->serverContainer->expects($this->once())
-			->method('query')
-			->with($this->equalTo(ResourceProvider::class))
-			->willReturn($this->createMock(ResourceProvider::class));
-
-		$this->providerManager->registerResourceProvider(ResourceProvider::class);
-		$resourceProviders = $this->providerManager->getResourceProviders();
-
-		$this->assertCount(1, $resourceProviders);
-		$this->assertInstanceOf(ResourceProvider::class, $resourceProviders[0]);
-	}
-
-	public function testGetResourceProvidersInvalidProvider(): void {
-		$this->serverContainer->expects($this->once())
-			->method('query')
-			->with($this->equalTo('InvalidResourceProvider'))
-			->willThrowException(new QueryException('A meaningful error message'));
-
-		$this->logger->expects($this->once())
-			->method('error');
-
-		$this->providerManager->registerResourceProvider('InvalidResourceProvider');
-		$resourceProviders = $this->providerManager->getResourceProviders();
-
-		$this->assertCount(0, $resourceProviders);
-	}
-
-	public function testGetResourceProvidersValidAndInvalidProvider(): void {
-		$this->serverContainer->expects($this->exactly(2))
-			->method('query')
-			->willReturnCallback(function (string $service) {
-				if ($service === 'InvalidResourceProvider') {
-					throw new QueryException('A meaningful error message');
-				}
-				if ($service === ResourceProvider::class) {
-					return $this->createMock(ResourceProvider::class);
-				}
-			});
-
-		$this->logger->expects($this->once())
-			->method('error');
-
-		$this->providerManager->registerResourceProvider('InvalidResourceProvider');
-		$this->providerManager->registerResourceProvider(ResourceProvider::class);
-		$resourceProviders = $this->providerManager->getResourceProviders();
-
-		$this->assertCount(1, $resourceProviders);
-	}
+    /** @var IServerContainer */
+    protected $serverContainer;
+    /** @var LoggerInterface */
+    protected $logger;
+    /** @var IProviderManager */
+    protected $providerManager;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->serverContainer = $this->createMock(IServerContainer::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+
+        $this->providerManager = new class($this->serverContainer, $this->logger) extends ProviderManager {
+            public function countProviders(): int {
+                return count($this->providers);
+            }
+        };
+    }
+
+    public function testRegisterResourceProvider(): void {
+        $this->providerManager->registerResourceProvider('AwesomeResourceProvider');
+        $this->assertSame(1, $this->providerManager->countProviders());
+    }
+
+    public function testGetResourceProvidersNoProvider(): void {
+        $this->assertCount(0, $this->providerManager->getResourceProviders());
+    }
+
+    public function testGetResourceProvidersValidProvider(): void {
+        $this->serverContainer->expects($this->once())
+            ->method('query')
+            ->with($this->equalTo(ResourceProvider::class))
+            ->willReturn($this->createMock(ResourceProvider::class));
+
+        $this->providerManager->registerResourceProvider(ResourceProvider::class);
+        $resourceProviders = $this->providerManager->getResourceProviders();
+
+        $this->assertCount(1, $resourceProviders);
+        $this->assertInstanceOf(ResourceProvider::class, $resourceProviders[0]);
+    }
+
+    public function testGetResourceProvidersInvalidProvider(): void {
+        $this->serverContainer->expects($this->once())
+            ->method('query')
+            ->with($this->equalTo('InvalidResourceProvider'))
+            ->willThrowException(new QueryException('A meaningful error message'));
+
+        $this->logger->expects($this->once())
+            ->method('error');
+
+        $this->providerManager->registerResourceProvider('InvalidResourceProvider');
+        $resourceProviders = $this->providerManager->getResourceProviders();
+
+        $this->assertCount(0, $resourceProviders);
+    }
+
+    public function testGetResourceProvidersValidAndInvalidProvider(): void {
+        $this->serverContainer->expects($this->exactly(2))
+            ->method('query')
+            ->willReturnCallback(function (string $service) {
+                if ($service === 'InvalidResourceProvider') {
+                    throw new QueryException('A meaningful error message');
+                }
+                if ($service === ResourceProvider::class) {
+                    return $this->createMock(ResourceProvider::class);
+                }
+            });
+
+        $this->logger->expects($this->once())
+            ->method('error');
+
+        $this->providerManager->registerResourceProvider('InvalidResourceProvider');
+        $this->providerManager->registerResourceProvider(ResourceProvider::class);
+        $resourceProviders = $this->providerManager->getResourceProviders();
+
+        $this->assertCount(1, $resourceProviders);
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
 	public function testGetResourceProvidersValidAndInvalidProvider(): void {
 		$this->serverContainer->expects($this->exactly(2))
 			->method('query')
-			->willReturnCallback(function (string $service) {
+			->willReturnCallback(function(string $service) {
 				if ($service === 'InvalidResourceProvider') {
 					throw new QueryException('A meaningful error message');
 				}

tests/lib/Log/LogFactoryTest.php

Indentation +123 added lines, -123 removed lines

@@ -21,127 +21,127 @@
  * @package Test\Log
  */
 class LogFactoryTest extends TestCase {
-	/** @var IServerContainer|\PHPUnit\Framework\MockObject\MockObject */
-	protected $c;
-
-	/** @var LogFactory */
-	protected $factory;
-
-	/** @var SystemConfig|\PHPUnit\Framework\MockObject\MockObject */
-	protected $systemConfig;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->c = $this->createMock(IServerContainer::class);
-		$this->systemConfig = $this->createMock(SystemConfig::class);
-
-		$this->factory = new LogFactory($this->c, $this->systemConfig);
-	}
-
-	public static function fileTypeProvider(): array {
-		return [
-			[
-				'file'
-			],
-			[
-				'nextcloud'
-			],
-			[
-				'owncloud'
-			],
-			[
-				'krzxkyr_default'
-			]
-		];
-	}
-
-	/**
-	 * @param string $type
-	 * @dataProvider fileTypeProvider
-	 * @throws \OCP\AppFramework\QueryException
-	 */
-	public function testFile(string $type): void {
-		$datadir = \OC::$SERVERROOT . '/data';
-		$defaultLog = $datadir . '/nextcloud.log';
-
-		$this->systemConfig->expects($this->exactly(3))
-			->method('getValue')
-			->willReturnMap([
-				['datadirectory', $datadir, $datadir],
-				['logfile', $defaultLog, $defaultLog],
-				['logfilemode', 0640, 0640],
-			]);
-
-		$log = $this->factory->get($type);
-		$this->assertInstanceOf(File::class, $log);
-	}
-
-	public static function logFilePathProvider():array {
-		return [
-			[
-				'/dev/null',
-				'/dev/null'
-			],
-			[
-				'/xdev/youshallfallback',
-				\OC::$SERVERROOT . '/data/nextcloud.log'
-			]
-		];
-	}
-
-	/**
-	 * @dataProvider logFilePathProvider
-	 * @throws \OCP\AppFramework\QueryException
-	 */
-	public function testFileCustomPath($path, $expected): void {
-		$datadir = \OC::$SERVERROOT . '/data';
-		$defaultLog = $datadir . '/nextcloud.log';
-
-		$this->systemConfig->expects($this->exactly(3))
-			->method('getValue')
-			->willReturnMap([
-				['datadirectory', $datadir, $datadir],
-				['logfile', $defaultLog, $path],
-				['logfilemode', 0640, 0640],
-			]);
-
-		$log = $this->factory->get('file');
-		$this->assertInstanceOf(File::class, $log);
-		$this->assertSame($expected, $log->getLogFilePath());
-	}
-
-	/**
-	 * @throws \OCP\AppFramework\QueryException
-	 */
-	public function testErrorLog(): void {
-		$log = $this->factory->get('errorlog');
-		$this->assertInstanceOf(Errorlog::class, $log);
-	}
-
-	/**
-	 * @throws \OCP\AppFramework\QueryException
-	 */
-	public function testSystemLog(): void {
-		$this->c->expects($this->once())
-			->method('resolve')
-			->with(Syslog::class)
-			->willReturn($this->createMock(Syslog::class));
-
-		$log = $this->factory->get('syslog');
-		$this->assertInstanceOf(Syslog::class, $log);
-	}
-
-	/**
-	 * @throws \OCP\AppFramework\QueryException
-	 */
-	public function testSystemdLog(): void {
-		$this->c->expects($this->once())
-			->method('resolve')
-			->with(Systemdlog::class)
-			->willReturn($this->createMock(Systemdlog::class));
-
-		$log = $this->factory->get('systemd');
-		$this->assertInstanceOf(Systemdlog::class, $log);
-	}
+    /** @var IServerContainer|\PHPUnit\Framework\MockObject\MockObject */
+    protected $c;
+
+    /** @var LogFactory */
+    protected $factory;
+
+    /** @var SystemConfig|\PHPUnit\Framework\MockObject\MockObject */
+    protected $systemConfig;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->c = $this->createMock(IServerContainer::class);
+        $this->systemConfig = $this->createMock(SystemConfig::class);
+
+        $this->factory = new LogFactory($this->c, $this->systemConfig);
+    }
+
+    public static function fileTypeProvider(): array {
+        return [
+            [
+                'file'
+            ],
+            [
+                'nextcloud'
+            ],
+            [
+                'owncloud'
+            ],
+            [
+                'krzxkyr_default'
+            ]
+        ];
+    }
+
+    /**
+     * @param string $type
+     * @dataProvider fileTypeProvider
+     * @throws \OCP\AppFramework\QueryException
+     */
+    public function testFile(string $type): void {
+        $datadir = \OC::$SERVERROOT . '/data';
+        $defaultLog = $datadir . '/nextcloud.log';
+
+        $this->systemConfig->expects($this->exactly(3))
+            ->method('getValue')
+            ->willReturnMap([
+                ['datadirectory', $datadir, $datadir],
+                ['logfile', $defaultLog, $defaultLog],
+                ['logfilemode', 0640, 0640],
+            ]);
+
+        $log = $this->factory->get($type);
+        $this->assertInstanceOf(File::class, $log);
+    }
+
+    public static function logFilePathProvider():array {
+        return [
+            [
+                '/dev/null',
+                '/dev/null'
+            ],
+            [
+                '/xdev/youshallfallback',
+                \OC::$SERVERROOT . '/data/nextcloud.log'
+            ]
+        ];
+    }
+
+    /**
+     * @dataProvider logFilePathProvider
+     * @throws \OCP\AppFramework\QueryException
+     */
+    public function testFileCustomPath($path, $expected): void {
+        $datadir = \OC::$SERVERROOT . '/data';
+        $defaultLog = $datadir . '/nextcloud.log';
+
+        $this->systemConfig->expects($this->exactly(3))
+            ->method('getValue')
+            ->willReturnMap([
+                ['datadirectory', $datadir, $datadir],
+                ['logfile', $defaultLog, $path],
+                ['logfilemode', 0640, 0640],
+            ]);
+
+        $log = $this->factory->get('file');
+        $this->assertInstanceOf(File::class, $log);
+        $this->assertSame($expected, $log->getLogFilePath());
+    }
+
+    /**
+     * @throws \OCP\AppFramework\QueryException
+     */
+    public function testErrorLog(): void {
+        $log = $this->factory->get('errorlog');
+        $this->assertInstanceOf(Errorlog::class, $log);
+    }
+
+    /**
+     * @throws \OCP\AppFramework\QueryException
+     */
+    public function testSystemLog(): void {
+        $this->c->expects($this->once())
+            ->method('resolve')
+            ->with(Syslog::class)
+            ->willReturn($this->createMock(Syslog::class));
+
+        $log = $this->factory->get('syslog');
+        $this->assertInstanceOf(Syslog::class, $log);
+    }
+
+    /**
+     * @throws \OCP\AppFramework\QueryException
+     */
+    public function testSystemdLog(): void {
+        $this->c->expects($this->once())
+            ->method('resolve')
+            ->with(Systemdlog::class)
+            ->willReturn($this->createMock(Systemdlog::class));
+
+        $log = $this->factory->get('systemd');
+        $this->assertInstanceOf(Systemdlog::class, $log);
+    }
 }