nextcloud / server

apps/files_external/lib/Controller/AjaxController.php

Indentation +106 added lines, -106 removed lines

@@ -21,122 +21,122 @@
 use OCP\IUserSession;
 
 class AjaxController extends Controller {
-	/**
-	 * @param string $appName
-	 * @param IRequest $request
-	 * @param RSA $rsaMechanism
-	 * @param GlobalAuth $globalAuth
-	 * @param IUserSession $userSession
-	 * @param IGroupManager $groupManager
-	 */
-	public function __construct(
-		$appName,
-		IRequest $request,
-		private RSA $rsaMechanism,
-		private GlobalAuth $globalAuth,
-		private IUserSession $userSession,
-		private IGroupManager $groupManager,
-		private IUserManager $userManager,
-		private IL10N $l10n,
-	) {
-		parent::__construct($appName, $request);
-	}
+    /**
+     * @param string $appName
+     * @param IRequest $request
+     * @param RSA $rsaMechanism
+     * @param GlobalAuth $globalAuth
+     * @param IUserSession $userSession
+     * @param IGroupManager $groupManager
+     */
+    public function __construct(
+        $appName,
+        IRequest $request,
+        private RSA $rsaMechanism,
+        private GlobalAuth $globalAuth,
+        private IUserSession $userSession,
+        private IGroupManager $groupManager,
+        private IUserManager $userManager,
+        private IL10N $l10n,
+    ) {
+        parent::__construct($appName, $request);
+    }
 
 
-	/**
-	 * Legacy endpoint for oauth2 callback
-	 */
-	#[NoAdminRequired()]
-	public function oauth2Callback(): JSONResponse {
-		return new JSONResponse(['status' => 'success']);
-	}
+    /**
+     * Legacy endpoint for oauth2 callback
+     */
+    #[NoAdminRequired()]
+    public function oauth2Callback(): JSONResponse {
+        return new JSONResponse(['status' => 'success']);
+    }
 
-	/**
-	 * Returns a list of users and groups that match the given pattern.
-	 * Used for user and group picker in the admin settings.
-	 *
-	 * @param string $pattern The search pattern
-	 * @param int|null $limit The maximum number of results to return
-	 * @param int|null $offset The offset from which to start returning results
-	 * @return JSONResponse
-	 */
-	public function getApplicableEntities(string $pattern = '', ?int $limit = null, ?int $offset = null): JSONResponse {
-		$groups = [];
-		foreach ($this->groupManager->search($pattern, $limit, $offset) as $group) {
-			$groups[$group->getGID()] = $group->getDisplayName();
-		}
+    /**
+     * Returns a list of users and groups that match the given pattern.
+     * Used for user and group picker in the admin settings.
+     *
+     * @param string $pattern The search pattern
+     * @param int|null $limit The maximum number of results to return
+     * @param int|null $offset The offset from which to start returning results
+     * @return JSONResponse
+     */
+    public function getApplicableEntities(string $pattern = '', ?int $limit = null, ?int $offset = null): JSONResponse {
+        $groups = [];
+        foreach ($this->groupManager->search($pattern, $limit, $offset) as $group) {
+            $groups[$group->getGID()] = $group->getDisplayName();
+        }
 
-		$users = [];
-		foreach ($this->userManager->searchDisplayName($pattern, $limit, $offset) as $user) {
-			$users[$user->getUID()] = $user->getDisplayName();
-		}
+        $users = [];
+        foreach ($this->userManager->searchDisplayName($pattern, $limit, $offset) as $user) {
+            $users[$user->getUID()] = $user->getDisplayName();
+        }
 
-		$results = ['groups' => $groups, 'users' => $users];
-		return new JSONResponse($results);
-	}
+        $results = ['groups' => $groups, 'users' => $users];
+        return new JSONResponse($results);
+    }
 
-	/**
-	 * @param int $keyLength
-	 * @return array
-	 */
-	private function generateSshKeys($keyLength) {
-		$key = $this->rsaMechanism->createKey($keyLength);
-		// Replace the placeholder label with a more meaningful one
-		$key['publickey'] = str_replace('phpseclib-generated-key', gethostname(), $key['publickey']);
+    /**
+     * @param int $keyLength
+     * @return array
+     */
+    private function generateSshKeys($keyLength) {
+        $key = $this->rsaMechanism->createKey($keyLength);
+        // Replace the placeholder label with a more meaningful one
+        $key['publickey'] = str_replace('phpseclib-generated-key', gethostname(), $key['publickey']);
 
-		return $key;
-	}
+        return $key;
+    }
 
-	/**
-	 * Generates an SSH public/private key pair.
-	 *
-	 * @param int $keyLength
-	 */
-	#[NoAdminRequired]
-	public function getSshKeys($keyLength = 1024) {
-		$key = $this->generateSshKeys($keyLength);
-		return new JSONResponse([
-			'data' => [
-				'private_key' => $key['privatekey'],
-				'public_key' => $key['publickey']
-			],
-			'status' => 'success',
-		]);
-	}
+    /**
+     * Generates an SSH public/private key pair.
+     *
+     * @param int $keyLength
+     */
+    #[NoAdminRequired]
+    public function getSshKeys($keyLength = 1024) {
+        $key = $this->generateSshKeys($keyLength);
+        return new JSONResponse([
+            'data' => [
+                'private_key' => $key['privatekey'],
+                'public_key' => $key['publickey']
+            ],
+            'status' => 'success',
+        ]);
+    }
 
-	/**
-	 * @param string $uid
-	 * @param string $user
-	 * @param string $password
-	 * @return JSONResponse
-	 */
-	#[NoAdminRequired]
-	#[PasswordConfirmationRequired(strict: true)]
-	public function saveGlobalCredentials($uid, $user, $password): JSONResponse {
-		$currentUser = $this->userSession->getUser();
-		if ($currentUser === null) {
-			return new JSONResponse([
-				'status' => 'error',
-				'message' => $this->l10n->t('You are not logged in'),
-			], Http::STATUS_UNAUTHORIZED);
-		}
+    /**
+     * @param string $uid
+     * @param string $user
+     * @param string $password
+     * @return JSONResponse
+     */
+    #[NoAdminRequired]
+    #[PasswordConfirmationRequired(strict: true)]
+    public function saveGlobalCredentials($uid, $user, $password): JSONResponse {
+        $currentUser = $this->userSession->getUser();
+        if ($currentUser === null) {
+            return new JSONResponse([
+                'status' => 'error',
+                'message' => $this->l10n->t('You are not logged in'),
+            ], Http::STATUS_UNAUTHORIZED);
+        }
 
-		// Non-admins can only edit their own credentials
-		// Admin can edit global credentials
-		$allowedToEdit = $uid === ''
-			? $this->groupManager->isAdmin($currentUser->getUID())
-			: $currentUser->getUID() === $uid;
+        // Non-admins can only edit their own credentials
+        // Admin can edit global credentials
+        $allowedToEdit = $uid === ''
+            ? $this->groupManager->isAdmin($currentUser->getUID())
+            : $currentUser->getUID() === $uid;
 
-		if ($allowedToEdit) {
-			$this->globalAuth->saveAuth($uid, $user, $password);
-			return new JSONResponse([
-				'status' => 'success',
-			]);
-		}
+        if ($allowedToEdit) {
+            $this->globalAuth->saveAuth($uid, $user, $password);
+            return new JSONResponse([
+                'status' => 'success',
+            ]);
+        }
 
-		return new JSONResponse([
-			'status' => 'success',
-			'message' => $this->l10n->t('Permission denied'),
-		], Http::STATUS_FORBIDDEN);
-	}
+        return new JSONResponse([
+            'status' => 'success',
+            'message' => $this->l10n->t('Permission denied'),
+        ], Http::STATUS_FORBIDDEN);
+    }
 }

apps/files_external/tests/Controller/AjaxControllerTest.php

Indentation +132 added lines, -132 removed lines

@@ -21,136 +21,136 @@
 use Test\TestCase;
 
 class AjaxControllerTest extends TestCase {
-	private IRequest&MockObject $request;
-	private RSA&MockObject $rsa;
-	private GlobalAuth&MockObject $globalAuth;
-	private IUserSession&MockObject $userSession;
-	private IGroupManager&MockObject $groupManager;
-	private IUserManager&MockObject $userManager;
-	private IL10N&MockObject $l10n;
-	private AjaxController $ajaxController;
-
-	protected function setUp(): void {
-		$this->request = $this->createMock(IRequest::class);
-		$this->rsa = $this->createMock(RSA::class);
-		$this->globalAuth = $this->createMock(GlobalAuth::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->groupManager = $this->createMock(IGroupManager::class);
-		$this->userManager = $this->createMock(IUserManager::class);
-		$this->l10n = $this->createMock(IL10N::class);
-
-		$this->ajaxController = new AjaxController(
-			'files_external',
-			$this->request,
-			$this->rsa,
-			$this->globalAuth,
-			$this->userSession,
-			$this->groupManager,
-			$this->userManager,
-			$this->l10n,
-		);
-
-		$this->l10n->expects($this->any())
-			->method('t')
-			->willReturnCallback(function ($string, $args) {
-				if (!is_array($args)) {
-					$args = [$args];
-				}
-				return vsprintf($string, $args);
-			});
-
-		parent::setUp();
-	}
-
-	public function testGetSshKeys(): void {
-		$this->rsa
-			->expects($this->once())
-			->method('createKey')
-			->willReturn([
-				'privatekey' => 'MyPrivateKey',
-				'publickey' => 'MyPublicKey',
-			]);
-
-		$expected = new JSONResponse(
-			[
-				'data' => [
-					'private_key' => 'MyPrivateKey',
-					'public_key' => 'MyPublicKey',
-				],
-				'status' => 'success',
-			]
-		);
-		$this->assertEquals($expected, $this->ajaxController->getSshKeys());
-	}
-
-	public function testSaveGlobalCredentialsAsAdminForAnotherUser(): void {
-		$user = $this->createMock(IUser::class);
-		$user
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('MyAdminUid');
-		$this->userSession
-			->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-		$this->globalAuth
-			->expects($this->never())
-			->method('saveAuth');
-
-		$response = $this->ajaxController->saveGlobalCredentials('UidOfTestUser', 'test', 'password');
-		$this->assertSame($response->getStatus(), 403);
-		$this->assertSame('Permission denied', $response->getData()['message']);
-	}
-
-	public function testSaveGlobalCredentialsAsAdminForSelf(): void {
-		$user = $this->createMock(IUser::class);
-		$user
-			->expects($this->once())
-			->method('getUID')
-			->willReturn('MyAdminUid');
-		$this->userSession
-			->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-		$this->globalAuth
-			->expects($this->once())
-			->method('saveAuth')
-			->with('MyAdminUid', 'test', 'password');
-
-		$response = $this->ajaxController->saveGlobalCredentials('MyAdminUid', 'test', 'password');
-		$this->assertSame($response->getStatus(), 200);
-	}
-
-	public function testSaveGlobalCredentialsAsNormalUserForSelf(): void {
-		$user = $this->createMock(IUser::class);
-		$user
-			->method('getUID')
-			->willReturn('MyUserUid');
-		$this->userSession
-			->method('getUser')
-			->willReturn($user);
-		$this->globalAuth
-			->method('saveAuth')
-			->with('MyUserUid', 'test', 'password');
-
-		$response = $this->ajaxController->saveGlobalCredentials('MyUserUid', 'test', 'password');
-		$this->assertSame($response->getStatus(), 200);
-	}
-
-	public function testSaveGlobalCredentialsAsNormalUserForAnotherUser(): void {
-		$user = $this->createMock(IUser::class);
-		$user
-			->method('getUID')
-			->willReturn('MyUserUid');
-		$this->userSession
-			->method('getUser')
-			->willReturn($user);
-		$this->globalAuth
-			->expects($this->never())
-			->method('saveAuth');
-
-		$response = $this->ajaxController->saveGlobalCredentials('AnotherUserUid', 'test', 'password');
-		$this->assertSame($response->getStatus(), 403);
-		$this->assertSame('Permission denied', $response->getData()['message']);
-	}
+    private IRequest&MockObject $request;
+    private RSA&MockObject $rsa;
+    private GlobalAuth&MockObject $globalAuth;
+    private IUserSession&MockObject $userSession;
+    private IGroupManager&MockObject $groupManager;
+    private IUserManager&MockObject $userManager;
+    private IL10N&MockObject $l10n;
+    private AjaxController $ajaxController;
+
+    protected function setUp(): void {
+        $this->request = $this->createMock(IRequest::class);
+        $this->rsa = $this->createMock(RSA::class);
+        $this->globalAuth = $this->createMock(GlobalAuth::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->groupManager = $this->createMock(IGroupManager::class);
+        $this->userManager = $this->createMock(IUserManager::class);
+        $this->l10n = $this->createMock(IL10N::class);
+
+        $this->ajaxController = new AjaxController(
+            'files_external',
+            $this->request,
+            $this->rsa,
+            $this->globalAuth,
+            $this->userSession,
+            $this->groupManager,
+            $this->userManager,
+            $this->l10n,
+        );
+
+        $this->l10n->expects($this->any())
+            ->method('t')
+            ->willReturnCallback(function ($string, $args) {
+                if (!is_array($args)) {
+                    $args = [$args];
+                }
+                return vsprintf($string, $args);
+            });
+
+        parent::setUp();
+    }
+
+    public function testGetSshKeys(): void {
+        $this->rsa
+            ->expects($this->once())
+            ->method('createKey')
+            ->willReturn([
+                'privatekey' => 'MyPrivateKey',
+                'publickey' => 'MyPublicKey',
+            ]);
+
+        $expected = new JSONResponse(
+            [
+                'data' => [
+                    'private_key' => 'MyPrivateKey',
+                    'public_key' => 'MyPublicKey',
+                ],
+                'status' => 'success',
+            ]
+        );
+        $this->assertEquals($expected, $this->ajaxController->getSshKeys());
+    }
+
+    public function testSaveGlobalCredentialsAsAdminForAnotherUser(): void {
+        $user = $this->createMock(IUser::class);
+        $user
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('MyAdminUid');
+        $this->userSession
+            ->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+        $this->globalAuth
+            ->expects($this->never())
+            ->method('saveAuth');
+
+        $response = $this->ajaxController->saveGlobalCredentials('UidOfTestUser', 'test', 'password');
+        $this->assertSame($response->getStatus(), 403);
+        $this->assertSame('Permission denied', $response->getData()['message']);
+    }
+
+    public function testSaveGlobalCredentialsAsAdminForSelf(): void {
+        $user = $this->createMock(IUser::class);
+        $user
+            ->expects($this->once())
+            ->method('getUID')
+            ->willReturn('MyAdminUid');
+        $this->userSession
+            ->expects($this->once())
+            ->method('getUser')
+            ->willReturn($user);
+        $this->globalAuth
+            ->expects($this->once())
+            ->method('saveAuth')
+            ->with('MyAdminUid', 'test', 'password');
+
+        $response = $this->ajaxController->saveGlobalCredentials('MyAdminUid', 'test', 'password');
+        $this->assertSame($response->getStatus(), 200);
+    }
+
+    public function testSaveGlobalCredentialsAsNormalUserForSelf(): void {
+        $user = $this->createMock(IUser::class);
+        $user
+            ->method('getUID')
+            ->willReturn('MyUserUid');
+        $this->userSession
+            ->method('getUser')
+            ->willReturn($user);
+        $this->globalAuth
+            ->method('saveAuth')
+            ->with('MyUserUid', 'test', 'password');
+
+        $response = $this->ajaxController->saveGlobalCredentials('MyUserUid', 'test', 'password');
+        $this->assertSame($response->getStatus(), 200);
+    }
+
+    public function testSaveGlobalCredentialsAsNormalUserForAnotherUser(): void {
+        $user = $this->createMock(IUser::class);
+        $user
+            ->method('getUID')
+            ->willReturn('MyUserUid');
+        $this->userSession
+            ->method('getUser')
+            ->willReturn($user);
+        $this->globalAuth
+            ->expects($this->never())
+            ->method('saveAuth');
+
+        $response = $this->ajaxController->saveGlobalCredentials('AnotherUserUid', 'test', 'password');
+        $this->assertSame($response->getStatus(), 403);
+        $this->assertSame('Permission denied', $response->getData()['message']);
+    }
 }

apps/files_external/appinfo/routes.php

Indentation +34 added lines, -34 removed lines

@@ -7,38 +7,38 @@
  */
 
 return [
-	'resources' => [
-		'global_storages' => ['url' => '/globalstorages'],
-		'user_storages' => ['url' => '/userstorages'],
-		'user_global_storages' => ['url' => '/userglobalstorages'],
-	],
-	'routes' => [
-		[
-			'name' => 'Ajax#getApplicableEntities',
-			'url' => '/ajax/applicable',
-			'verb' => 'GET',
-		],
-		[
-			'name' => 'Ajax#oauth2Callback',
-			'url' => '/ajax/oauth2.php',
-			'verb' => 'GET',
-		],
-		[
-			'name' => 'Ajax#getSshKeys',
-			'url' => '/ajax/public_key.php',
-			'verb' => 'POST',
-		],
-		[
-			'name' => 'Ajax#saveGlobalCredentials',
-			'url' => '/globalcredentials',
-			'verb' => 'POST',
-		],
-	],
-	'ocs' => [
-		[
-			'name' => 'Api#getUserMounts',
-			'url' => '/api/v1/mounts',
-			'verb' => 'GET',
-		],
-	],
+    'resources' => [
+        'global_storages' => ['url' => '/globalstorages'],
+        'user_storages' => ['url' => '/userstorages'],
+        'user_global_storages' => ['url' => '/userglobalstorages'],
+    ],
+    'routes' => [
+        [
+            'name' => 'Ajax#getApplicableEntities',
+            'url' => '/ajax/applicable',
+            'verb' => 'GET',
+        ],
+        [
+            'name' => 'Ajax#oauth2Callback',
+            'url' => '/ajax/oauth2.php',
+            'verb' => 'GET',
+        ],
+        [
+            'name' => 'Ajax#getSshKeys',
+            'url' => '/ajax/public_key.php',
+            'verb' => 'POST',
+        ],
+        [
+            'name' => 'Ajax#saveGlobalCredentials',
+            'url' => '/globalcredentials',
+            'verb' => 'POST',
+        ],
+    ],
+    'ocs' => [
+        [
+            'name' => 'Api#getUserMounts',
+            'url' => '/api/v1/mounts',
+            'verb' => 'GET',
+        ],
+    ],
 ];

tests/lib/UrlGeneratorTest.php

Indentation +255 added lines, -255 removed lines

@@ -22,259 +22,259 @@
  * @package Test
  */
 class UrlGeneratorTest extends \Test\TestCase {
-	/** @var \PHPUnit\Framework\MockObject\MockObject|IConfig */
-	private $config;
-	/** @var \PHPUnit\Framework\MockObject\MockObject|IUserSession */
-	private $userSession;
-	/** @var \PHPUnit\Framework\MockObject\MockObject|ICacheFactory */
-	private $cacheFactory;
-	/** @var \PHPUnit\Framework\MockObject\MockObject|IRequest */
-	private $request;
-	/** @var \PHPUnit\Framework\MockObject\MockObject|Router */
-	private $router;
-	/** @var IURLGenerator */
-	private $urlGenerator;
-	/** @var string */
-	private $originalWebRoot;
-
-	protected function setUp(): void {
-		parent::setUp();
-		$this->config = $this->createMock(IConfig::class);
-		$this->userSession = $this->createMock(IUserSession::class);
-		$this->cacheFactory = $this->createMock(ICacheFactory::class);
-		$this->request = $this->createMock(IRequest::class);
-		$this->router = $this->createMock(Router::class);
-		$this->urlGenerator = new URLGenerator(
-			$this->config,
-			$this->userSession,
-			$this->cacheFactory,
-			$this->request,
-			$this->router
-		);
-		$this->originalWebRoot = \OC::$WEBROOT;
-	}
-
-	protected function tearDown(): void {
-		// Reset webRoot
-		\OC::$WEBROOT = $this->originalWebRoot;
-	}
-
-	private function mockBaseUrl() {
-		$this->request->expects($this->once())
-			->method('getServerProtocol')
-			->willReturn('http');
-		$this->request->expects($this->once())
-			->method('getServerHost')
-			->willReturn('localhost');
-	}
-
-	/**
-	 * @small
-	 * test linkTo URL construction
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideDocRootAppUrlParts')]
-	public function testLinkToDocRoot($app, $file, $args, $expectedResult): void {
-		\OC::$WEBROOT = '';
-		$result = $this->urlGenerator->linkTo($app, $file, $args);
-		$this->assertEquals($expectedResult, $result);
-	}
-
-	/**
-	 * @small
-	 * test linkTo URL construction in sub directory
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideSubDirAppUrlParts')]
-	public function testLinkToSubDir($app, $file, $args, $expectedResult): void {
-		\OC::$WEBROOT = '/nextcloud';
-		$result = $this->urlGenerator->linkTo($app, $file, $args);
-		$this->assertEquals($expectedResult, $result);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideRoutes')]
-	public function testLinkToRouteAbsolute($route, $expected): void {
-		$this->mockBaseUrl();
-		\OC::$WEBROOT = '/nextcloud';
-		$this->router->expects($this->once())
-			->method('generate')
-			->willReturnCallback(function ($routeName, $parameters) {
-				if ($routeName === 'core.Preview.getPreview') {
-					return '/index.php/core/preview.png';
-				} elseif ($routeName === 'cloud_federation_api.requesthandlercontroller.addShare') {
-					return '/index.php/ocm/shares';
-				}
-			});
-		$result = $this->urlGenerator->linkToRouteAbsolute($route);
-		$this->assertEquals($expected, $result);
-	}
-
-	public static function provideRoutes(): array {
-		return [
-			['core.Preview.getPreview', 'http://localhost/nextcloud/index.php/core/preview.png'],
-			['cloud_federation_api.requesthandlercontroller.addShare', 'http://localhost/nextcloud/index.php/ocm/shares'],
-		];
-	}
-
-	public static function provideDocRootAppUrlParts(): array {
-		return [
-			['user_ldap', 'ajax/wizard.php', [], '/index.php/apps/user_ldap/ajax/wizard.php'],
-			['user_ldap', 'ajax/wizard.php', ['trut' => 'trat', 'dut' => 'dat'], '/index.php/apps/user_ldap/ajax/wizard.php?trut=trat&dut=dat'],
-			['', 'index.php', ['trut' => 'trat', 'dut' => 'dat'], '/index.php?trut=trat&dut=dat'],
-		];
-	}
-
-	public static function provideSubDirAppUrlParts(): array {
-		return [
-			['user_ldap', 'ajax/wizard.php', [], '/nextcloud/index.php/apps/user_ldap/ajax/wizard.php'],
-			['user_ldap', 'ajax/wizard.php', ['trut' => 'trat', 'dut' => 'dat'], '/nextcloud/index.php/apps/user_ldap/ajax/wizard.php?trut=trat&dut=dat'],
-			['', 'index.php', ['trut' => 'trat', 'dut' => 'dat'], '/nextcloud/index.php?trut=trat&dut=dat'],
-		];
-	}
-
-	/**
-	 * @small
-	 * test absolute URL construction
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideDocRootURLs')]
-	public function testGetAbsoluteURLDocRoot($url, $expectedResult): void {
-		$this->mockBaseUrl();
-		\OC::$WEBROOT = '';
-		$result = $this->urlGenerator->getAbsoluteURL($url);
-		$this->assertEquals($expectedResult, $result);
-	}
-
-	/**
-	 * @small
-	 * test absolute URL construction
-	 */
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideSubDirURLs')]
-	public function testGetAbsoluteURLSubDir($url, $expectedResult): void {
-		$this->mockBaseUrl();
-		\OC::$WEBROOT = '/nextcloud';
-		$result = $this->urlGenerator->getAbsoluteURL($url);
-		$this->assertEquals($expectedResult, $result);
-	}
-
-	public static function provideDocRootURLs(): array {
-		return [
-			['index.php', 'http://localhost/index.php'],
-			['/index.php', 'http://localhost/index.php'],
-			['/apps/index.php', 'http://localhost/apps/index.php'],
-			['apps/index.php', 'http://localhost/apps/index.php'],
-		];
-	}
-
-	public static function provideSubDirURLs(): array {
-		return [
-			['', 'http://localhost/nextcloud/'],
-			['/', 'http://localhost/nextcloud/'],
-			['index.php', 'http://localhost/nextcloud/index.php'],
-			['/index.php', 'http://localhost/nextcloud/index.php'],
-			['/apps/index.php', 'http://localhost/nextcloud/apps/index.php'],
-			['apps/index.php', 'http://localhost/nextcloud/apps/index.php'],
-		];
-	}
-
-	public function testGetBaseUrl(): void {
-		$this->mockBaseUrl();
-		\OC::$WEBROOT = '/nextcloud';
-		$actual = $this->urlGenerator->getBaseUrl();
-		$expected = 'http://localhost/nextcloud';
-		$this->assertEquals($expected, $actual);
-	}
-
-	public function testGetWebroot(): void {
-		\OC::$WEBROOT = '/nextcloud';
-		$actual = $this->urlGenerator->getWebroot();
-		$this->assertEquals(\OC::$WEBROOT, $actual);
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('provideOCSRoutes')]
-	public function testLinkToOCSRouteAbsolute(string $route, bool $ignoreFrontController, string $expected): void {
-		$this->mockBaseUrl();
-		\OC::$WEBROOT = '/nextcloud';
-		$this->router->expects($this->once())
-			->method('generate')
-			->willReturnCallback(function (string $routeName, array $parameters) use ($ignoreFrontController) {
-				if ($routeName === 'ocs.core.OCS.getCapabilities') {
-					if (!$ignoreFrontController) {
-						return '/nextcloud/index.php/ocsapp/cloud/capabilities';
-					}
-					return '/nextcloud/ocsapp/cloud/capabilities';
-				} elseif ($routeName === 'ocs.core.WhatsNew.dismiss') {
-					if (!$ignoreFrontController) {
-						return '/nextcloud/index.php/ocsapp/core/whatsnew';
-					}
-					return '/nextcloud/ocsapp/core/whatsnew';
-				}
-			});
-		$result = $this->urlGenerator->linkToOCSRouteAbsolute($route);
-		$this->assertEquals($expected, $result);
-	}
-
-	public static function provideOCSRoutes(): array {
-		return [
-			['core.OCS.getCapabilities', false, 'http://localhost/nextcloud/ocs/v2.php/cloud/capabilities'],
-			['core.OCS.getCapabilities', true, 'http://localhost/nextcloud/ocs/v2.php/cloud/capabilities'],
-			['core.WhatsNew.dismiss', false, 'http://localhost/nextcloud/ocs/v2.php/core/whatsnew'],
-			['core.WhatsNew.dismiss', true, 'http://localhost/nextcloud/ocs/v2.php/core/whatsnew'],
-		];
-	}
-
-	private function mockLinkToDefaultPageUrl(bool $ignoreFrontControllerConfig = false) {
-		$this->config->expects($this->once())
-			->method('getAppValue')
-			->with('core', 'defaultpage')
-			->willReturn('');
-
-		$this->config->expects($this->once())
-			->method('getSystemValueBool')
-			->with('htaccess.IgnoreFrontController', $this->anything())
-			->willReturn($ignoreFrontControllerConfig);
-	}
-
-	public function testLinkToDefaultPageUrlWithRedirectUrlWithoutFrontController(): void {
-		$this->mockBaseUrl();
-
-		$_REQUEST['redirect_url'] = 'myRedirectUrl.com';
-		$this->assertSame('http://localhost' . \OC::$WEBROOT . '/myRedirectUrl.com', $this->urlGenerator->linkToDefaultPageUrl());
-	}
-
-	public function testLinkToDefaultPageUrlWithRedirectUrlRedirectBypassWithoutFrontController(): void {
-		$this->mockBaseUrl();
-		$this->mockLinkToDefaultPageUrl();
-		putenv('front_controller_active=false');
-
-		$_REQUEST['redirect_url'] = 'myRedirectUrl.com@foo.com:a';
-		$this->assertSame('http://localhost' . \OC::$WEBROOT . '/index.php/apps/dashboard/', $this->urlGenerator->linkToDefaultPageUrl());
-	}
-
-	public function testLinkToDefaultPageUrlWithRedirectUrlRedirectBypassWithFrontController(): void {
-		$this->mockBaseUrl();
-		$this->mockLinkToDefaultPageUrl();
-		putenv('front_controller_active=true');
-
-		$_REQUEST['redirect_url'] = 'myRedirectUrl.com@foo.com:a';
-		$this->assertSame('http://localhost' . \OC::$WEBROOT . '/apps/dashboard/', $this->urlGenerator->linkToDefaultPageUrl());
-	}
-
-	public function testLinkToDefaultPageUrlWithRedirectUrlWithIgnoreFrontController(): void {
-		$this->mockBaseUrl();
-		$this->mockLinkToDefaultPageUrl(true);
-		putenv('front_controller_active=false');
-
-		$_REQUEST['redirect_url'] = 'myRedirectUrl.com@foo.com:a';
-		$this->assertSame('http://localhost' . \OC::$WEBROOT . '/apps/dashboard/', $this->urlGenerator->linkToDefaultPageUrl());
-	}
-
-	public static function imagePathProvider(): array {
-		return [
-			['core', 'favicon-mask.svg', \OC::$WEBROOT . '/core/img/favicon-mask.svg'],
-			['files', 'folder.svg', \OC::$WEBROOT . '/apps/files/img/folder.svg'],
-		];
-	}
-
-	#[\PHPUnit\Framework\Attributes\DataProvider('imagePathProvider')]
-	public function testImagePath(string $appName, string $file, string $result): void {
-		$this->assertSame($result, $this->urlGenerator->imagePath($appName, $file));
-	}
+    /** @var \PHPUnit\Framework\MockObject\MockObject|IConfig */
+    private $config;
+    /** @var \PHPUnit\Framework\MockObject\MockObject|IUserSession */
+    private $userSession;
+    /** @var \PHPUnit\Framework\MockObject\MockObject|ICacheFactory */
+    private $cacheFactory;
+    /** @var \PHPUnit\Framework\MockObject\MockObject|IRequest */
+    private $request;
+    /** @var \PHPUnit\Framework\MockObject\MockObject|Router */
+    private $router;
+    /** @var IURLGenerator */
+    private $urlGenerator;
+    /** @var string */
+    private $originalWebRoot;
+
+    protected function setUp(): void {
+        parent::setUp();
+        $this->config = $this->createMock(IConfig::class);
+        $this->userSession = $this->createMock(IUserSession::class);
+        $this->cacheFactory = $this->createMock(ICacheFactory::class);
+        $this->request = $this->createMock(IRequest::class);
+        $this->router = $this->createMock(Router::class);
+        $this->urlGenerator = new URLGenerator(
+            $this->config,
+            $this->userSession,
+            $this->cacheFactory,
+            $this->request,
+            $this->router
+        );
+        $this->originalWebRoot = \OC::$WEBROOT;
+    }
+
+    protected function tearDown(): void {
+        // Reset webRoot
+        \OC::$WEBROOT = $this->originalWebRoot;
+    }
+
+    private function mockBaseUrl() {
+        $this->request->expects($this->once())
+            ->method('getServerProtocol')
+            ->willReturn('http');
+        $this->request->expects($this->once())
+            ->method('getServerHost')
+            ->willReturn('localhost');
+    }
+
+    /**
+     * @small
+     * test linkTo URL construction
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideDocRootAppUrlParts')]
+    public function testLinkToDocRoot($app, $file, $args, $expectedResult): void {
+        \OC::$WEBROOT = '';
+        $result = $this->urlGenerator->linkTo($app, $file, $args);
+        $this->assertEquals($expectedResult, $result);
+    }
+
+    /**
+     * @small
+     * test linkTo URL construction in sub directory
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideSubDirAppUrlParts')]
+    public function testLinkToSubDir($app, $file, $args, $expectedResult): void {
+        \OC::$WEBROOT = '/nextcloud';
+        $result = $this->urlGenerator->linkTo($app, $file, $args);
+        $this->assertEquals($expectedResult, $result);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideRoutes')]
+    public function testLinkToRouteAbsolute($route, $expected): void {
+        $this->mockBaseUrl();
+        \OC::$WEBROOT = '/nextcloud';
+        $this->router->expects($this->once())
+            ->method('generate')
+            ->willReturnCallback(function ($routeName, $parameters) {
+                if ($routeName === 'core.Preview.getPreview') {
+                    return '/index.php/core/preview.png';
+                } elseif ($routeName === 'cloud_federation_api.requesthandlercontroller.addShare') {
+                    return '/index.php/ocm/shares';
+                }
+            });
+        $result = $this->urlGenerator->linkToRouteAbsolute($route);
+        $this->assertEquals($expected, $result);
+    }
+
+    public static function provideRoutes(): array {
+        return [
+            ['core.Preview.getPreview', 'http://localhost/nextcloud/index.php/core/preview.png'],
+            ['cloud_federation_api.requesthandlercontroller.addShare', 'http://localhost/nextcloud/index.php/ocm/shares'],
+        ];
+    }
+
+    public static function provideDocRootAppUrlParts(): array {
+        return [
+            ['user_ldap', 'ajax/wizard.php', [], '/index.php/apps/user_ldap/ajax/wizard.php'],
+            ['user_ldap', 'ajax/wizard.php', ['trut' => 'trat', 'dut' => 'dat'], '/index.php/apps/user_ldap/ajax/wizard.php?trut=trat&dut=dat'],
+            ['', 'index.php', ['trut' => 'trat', 'dut' => 'dat'], '/index.php?trut=trat&dut=dat'],
+        ];
+    }
+
+    public static function provideSubDirAppUrlParts(): array {
+        return [
+            ['user_ldap', 'ajax/wizard.php', [], '/nextcloud/index.php/apps/user_ldap/ajax/wizard.php'],
+            ['user_ldap', 'ajax/wizard.php', ['trut' => 'trat', 'dut' => 'dat'], '/nextcloud/index.php/apps/user_ldap/ajax/wizard.php?trut=trat&dut=dat'],
+            ['', 'index.php', ['trut' => 'trat', 'dut' => 'dat'], '/nextcloud/index.php?trut=trat&dut=dat'],
+        ];
+    }
+
+    /**
+     * @small
+     * test absolute URL construction
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideDocRootURLs')]
+    public function testGetAbsoluteURLDocRoot($url, $expectedResult): void {
+        $this->mockBaseUrl();
+        \OC::$WEBROOT = '';
+        $result = $this->urlGenerator->getAbsoluteURL($url);
+        $this->assertEquals($expectedResult, $result);
+    }
+
+    /**
+     * @small
+     * test absolute URL construction
+     */
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideSubDirURLs')]
+    public function testGetAbsoluteURLSubDir($url, $expectedResult): void {
+        $this->mockBaseUrl();
+        \OC::$WEBROOT = '/nextcloud';
+        $result = $this->urlGenerator->getAbsoluteURL($url);
+        $this->assertEquals($expectedResult, $result);
+    }
+
+    public static function provideDocRootURLs(): array {
+        return [
+            ['index.php', 'http://localhost/index.php'],
+            ['/index.php', 'http://localhost/index.php'],
+            ['/apps/index.php', 'http://localhost/apps/index.php'],
+            ['apps/index.php', 'http://localhost/apps/index.php'],
+        ];
+    }
+
+    public static function provideSubDirURLs(): array {
+        return [
+            ['', 'http://localhost/nextcloud/'],
+            ['/', 'http://localhost/nextcloud/'],
+            ['index.php', 'http://localhost/nextcloud/index.php'],
+            ['/index.php', 'http://localhost/nextcloud/index.php'],
+            ['/apps/index.php', 'http://localhost/nextcloud/apps/index.php'],
+            ['apps/index.php', 'http://localhost/nextcloud/apps/index.php'],
+        ];
+    }
+
+    public function testGetBaseUrl(): void {
+        $this->mockBaseUrl();
+        \OC::$WEBROOT = '/nextcloud';
+        $actual = $this->urlGenerator->getBaseUrl();
+        $expected = 'http://localhost/nextcloud';
+        $this->assertEquals($expected, $actual);
+    }
+
+    public function testGetWebroot(): void {
+        \OC::$WEBROOT = '/nextcloud';
+        $actual = $this->urlGenerator->getWebroot();
+        $this->assertEquals(\OC::$WEBROOT, $actual);
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('provideOCSRoutes')]
+    public function testLinkToOCSRouteAbsolute(string $route, bool $ignoreFrontController, string $expected): void {
+        $this->mockBaseUrl();
+        \OC::$WEBROOT = '/nextcloud';
+        $this->router->expects($this->once())
+            ->method('generate')
+            ->willReturnCallback(function (string $routeName, array $parameters) use ($ignoreFrontController) {
+                if ($routeName === 'ocs.core.OCS.getCapabilities') {
+                    if (!$ignoreFrontController) {
+                        return '/nextcloud/index.php/ocsapp/cloud/capabilities';
+                    }
+                    return '/nextcloud/ocsapp/cloud/capabilities';
+                } elseif ($routeName === 'ocs.core.WhatsNew.dismiss') {
+                    if (!$ignoreFrontController) {
+                        return '/nextcloud/index.php/ocsapp/core/whatsnew';
+                    }
+                    return '/nextcloud/ocsapp/core/whatsnew';
+                }
+            });
+        $result = $this->urlGenerator->linkToOCSRouteAbsolute($route);
+        $this->assertEquals($expected, $result);
+    }
+
+    public static function provideOCSRoutes(): array {
+        return [
+            ['core.OCS.getCapabilities', false, 'http://localhost/nextcloud/ocs/v2.php/cloud/capabilities'],
+            ['core.OCS.getCapabilities', true, 'http://localhost/nextcloud/ocs/v2.php/cloud/capabilities'],
+            ['core.WhatsNew.dismiss', false, 'http://localhost/nextcloud/ocs/v2.php/core/whatsnew'],
+            ['core.WhatsNew.dismiss', true, 'http://localhost/nextcloud/ocs/v2.php/core/whatsnew'],
+        ];
+    }
+
+    private function mockLinkToDefaultPageUrl(bool $ignoreFrontControllerConfig = false) {
+        $this->config->expects($this->once())
+            ->method('getAppValue')
+            ->with('core', 'defaultpage')
+            ->willReturn('');
+
+        $this->config->expects($this->once())
+            ->method('getSystemValueBool')
+            ->with('htaccess.IgnoreFrontController', $this->anything())
+            ->willReturn($ignoreFrontControllerConfig);
+    }
+
+    public function testLinkToDefaultPageUrlWithRedirectUrlWithoutFrontController(): void {
+        $this->mockBaseUrl();
+
+        $_REQUEST['redirect_url'] = 'myRedirectUrl.com';
+        $this->assertSame('http://localhost' . \OC::$WEBROOT . '/myRedirectUrl.com', $this->urlGenerator->linkToDefaultPageUrl());
+    }
+
+    public function testLinkToDefaultPageUrlWithRedirectUrlRedirectBypassWithoutFrontController(): void {
+        $this->mockBaseUrl();
+        $this->mockLinkToDefaultPageUrl();
+        putenv('front_controller_active=false');
+
+        $_REQUEST['redirect_url'] = 'myRedirectUrl.com@foo.com:a';
+        $this->assertSame('http://localhost' . \OC::$WEBROOT . '/index.php/apps/dashboard/', $this->urlGenerator->linkToDefaultPageUrl());
+    }
+
+    public function testLinkToDefaultPageUrlWithRedirectUrlRedirectBypassWithFrontController(): void {
+        $this->mockBaseUrl();
+        $this->mockLinkToDefaultPageUrl();
+        putenv('front_controller_active=true');
+
+        $_REQUEST['redirect_url'] = 'myRedirectUrl.com@foo.com:a';
+        $this->assertSame('http://localhost' . \OC::$WEBROOT . '/apps/dashboard/', $this->urlGenerator->linkToDefaultPageUrl());
+    }
+
+    public function testLinkToDefaultPageUrlWithRedirectUrlWithIgnoreFrontController(): void {
+        $this->mockBaseUrl();
+        $this->mockLinkToDefaultPageUrl(true);
+        putenv('front_controller_active=false');
+
+        $_REQUEST['redirect_url'] = 'myRedirectUrl.com@foo.com:a';
+        $this->assertSame('http://localhost' . \OC::$WEBROOT . '/apps/dashboard/', $this->urlGenerator->linkToDefaultPageUrl());
+    }
+
+    public static function imagePathProvider(): array {
+        return [
+            ['core', 'favicon-mask.svg', \OC::$WEBROOT . '/core/img/favicon-mask.svg'],
+            ['files', 'folder.svg', \OC::$WEBROOT . '/apps/files/img/folder.svg'],
+        ];
+    }
+
+    #[\PHPUnit\Framework\Attributes\DataProvider('imagePathProvider')]
+    public function testImagePath(string $appName, string $file, string $result): void {
+        $this->assertSame($result, $this->urlGenerator->imagePath($appName, $file));
+    }
 }