Completed
Pull Request — master (#8824)
by John
19:49 queued 03:28
created
settings/templates/settings.php 2 patches
Indentation   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@  discard block
 block discarded – undo
13 13
  * $tmpl = new OC_Template('settings', 'settings', 'user');
14 14
  * $tmpl->assign('serverData', $serverData);
15 15
  * $tmpl->printPage();
16
-
17 16
  */
18 17
 
19 18
 script('settings', 'main');
@@ -21,7 +20,7 @@  discard block
 block discarded – undo
21 20
 
22 21
 // Did we have some data to inject ?
23 22
 if(is_array($_['serverData'])) {
24
-	$serverData = json_encode($_['serverData']);
23
+    $serverData = json_encode($_['serverData']);
25 24
 ?>
26 25
 <span id="serverData" data-server="<?php p($serverData);?>"></span>
27 26
 <?php } ?>
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,8 +20,8 @@
 block discarded – undo
20 20
 style('settings', 'settings');
21 21
 
22 22
 // Did we have some data to inject ?
23
-if(is_array($_['serverData'])) {
23
+if (is_array($_['serverData'])) {
24 24
 	$serverData = json_encode($_['serverData']);
25 25
 ?>
26
-<span id="serverData" data-server="<?php p($serverData);?>"></span>
26
+<span id="serverData" data-server="<?php p($serverData); ?>"></span>
27 27
 <?php } ?>
Please login to merge, or discard this patch.
settings/main.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -20,5 +20,5 @@
 block discarded – undo
20 20
  *
21 21
  */
22 22
 
23
- $tmpl = new OC_Template("settings", "settings", "user");
24
- $tmpl->printPage();
23
+    $tmpl = new OC_Template("settings", "settings", "user");
24
+    $tmpl->printPage();
Please login to merge, or discard this patch.
settings/routes.php 1 patch
Indentation   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -38,76 +38,76 @@
 block discarded – undo
38 38
 
39 39
 $application = new Application();
40 40
 $application->registerRoutes($this, [
41
-	'resources' => [
42
-		'users' => ['url' => '/settings/users/users'],
43
-		'AuthSettings' => ['url' => '/settings/personal/authtokens'],
44
-	],
45
-	'routes' => [
46
-		['name' => 'MailSettings#setMailSettings', 'url' => '/settings/admin/mailsettings', 'verb' => 'POST'],
47
-		['name' => 'MailSettings#storeCredentials', 'url' => '/settings/admin/mailsettings/credentials', 'verb' => 'POST'],
48
-		['name' => 'MailSettings#sendTestMail', 'url' => '/settings/admin/mailtest', 'verb' => 'POST'],
49
-		['name' => 'Encryption#startMigration', 'url' => '/settings/admin/startmigration', 'verb' => 'POST'],
50
-		['name' => 'AppSettings#listCategories', 'url' => '/settings/apps/categories', 'verb' => 'GET'],
51
-		['name' => 'AppSettings#viewApps', 'url' => '/settings/apps', 'verb' => 'GET'],
52
-		['name' => 'AppSettings#listApps', 'url' => '/settings/apps/list', 'verb' => 'GET'],
53
-		['name' => 'SecuritySettings#trustedDomains', 'url' => '/settings/admin/security/trustedDomains', 'verb' => 'POST'],
54
-		['name' => 'Users#setDisplayName', 'url' => '/settings/users/{id}/displayName', 'verb' => 'PUT'],
55
-		['name' => 'Users#setEMailAddress', 'url' => '/settings/users/{id}/mailAddress', 'verb' => 'PUT'],
56
-		['name' => 'Users#setUserSettings', 'url' => '/settings/users/{username}/settings', 'verb' => 'PUT'],
57
-		['name' => 'Users#getVerificationCode', 'url' => '/settings/users/{account}/verify', 'verb' => 'GET'],
58
-		['name' => 'Users#setEnabled', 'url' => '/settings/users/{id}/setEnabled', 'verb' => 'POST'],
59
-		['name' => 'Users#stats', 'url' => '/settings/users/stats', 'verb' => 'GET'],
60
-		['name' => 'LogSettings#setLogLevel', 'url' => '/settings/admin/log/level', 'verb' => 'POST'],
61
-		['name' => 'LogSettings#getEntries', 'url' => '/settings/admin/log/entries', 'verb' => 'GET'],
62
-		['name' => 'LogSettings#download', 'url' => '/settings/admin/log/download', 'verb' => 'GET'],
63
-		['name' => 'CheckSetup#check', 'url' => '/settings/ajax/checksetup', 'verb' => 'GET'],
64
-		['name' => 'CheckSetup#getFailedIntegrityCheckFiles', 'url' => '/settings/integrity/failed', 'verb' => 'GET'],
65
-		['name' => 'CheckSetup#rescanFailedIntegrityCheck', 'url' => '/settings/integrity/rescan', 'verb' => 'GET'],
66
-		['name' => 'Certificate#addPersonalRootCertificate', 'url' => '/settings/personal/certificate', 'verb' => 'POST'],
67
-		['name' => 'Certificate#removePersonalRootCertificate', 'url' => '/settings/personal/certificate/{certificateIdentifier}', 'verb' => 'DELETE'],
68
-		['name' => 'Certificate#addSystemRootCertificate', 'url' => '/settings/admin/certificate', 'verb' => 'POST'],
69
-		['name' => 'Certificate#removeSystemRootCertificate', 'url' => '/settings/admin/certificate/{certificateIdentifier}', 'verb' => 'DELETE'],
70
-		['name' => 'PersonalSettings#index', 'url' => '/settings/user/{section}', 'verb' => 'GET', 'defaults' => ['section' => 'personal-info']],
71
-		['name' => 'AdminSettings#index', 'url' => '/settings/admin/{section}', 'verb' => 'GET', 'defaults' => ['section' => 'server']],
72
-		['name' => 'AdminSettings#form', 'url' => '/settings/admin/{section}', 'verb' => 'GET'],
73
-		['name' => 'ChangePassword#changePersonalPassword', 'url' => '/settings/personal/changepassword', 'verb' => 'POST'],
74
-		['name' => 'ChangePassword#changeUserPassword', 'url' => '/settings/users/changepassword', 'verb' => 'POST'],
75
-		['name' => 'Groups#index', 'url' => '/settings/users/groups', 'verb' => 'GET'],
76
-		['name' => 'Groups#show', 'url' => '/settings/users/groups/{id}', 'requirements' => ['id' => '[^?]*'], 'verb' => 'GET'],
77
-		['name' => 'Groups#create', 'url' => '/settings/users/groups', 'verb' => 'POST'],
78
-		['name' => 'Groups#update', 'url' => '/settings/users/groups/{id}', 'requirements' => ['id' => '[^?]*'], 'verb' => 'PUT'],
79
-		['name' => 'Groups#destroy', 'url' => '/settings/users/groups/{id}', 'requirements' => ['id' => '[^?]*'], 'verb' => 'DELETE'],
80
-	]
41
+    'resources' => [
42
+        'users' => ['url' => '/settings/users/users'],
43
+        'AuthSettings' => ['url' => '/settings/personal/authtokens'],
44
+    ],
45
+    'routes' => [
46
+        ['name' => 'MailSettings#setMailSettings', 'url' => '/settings/admin/mailsettings', 'verb' => 'POST'],
47
+        ['name' => 'MailSettings#storeCredentials', 'url' => '/settings/admin/mailsettings/credentials', 'verb' => 'POST'],
48
+        ['name' => 'MailSettings#sendTestMail', 'url' => '/settings/admin/mailtest', 'verb' => 'POST'],
49
+        ['name' => 'Encryption#startMigration', 'url' => '/settings/admin/startmigration', 'verb' => 'POST'],
50
+        ['name' => 'AppSettings#listCategories', 'url' => '/settings/apps/categories', 'verb' => 'GET'],
51
+        ['name' => 'AppSettings#viewApps', 'url' => '/settings/apps', 'verb' => 'GET'],
52
+        ['name' => 'AppSettings#listApps', 'url' => '/settings/apps/list', 'verb' => 'GET'],
53
+        ['name' => 'SecuritySettings#trustedDomains', 'url' => '/settings/admin/security/trustedDomains', 'verb' => 'POST'],
54
+        ['name' => 'Users#setDisplayName', 'url' => '/settings/users/{id}/displayName', 'verb' => 'PUT'],
55
+        ['name' => 'Users#setEMailAddress', 'url' => '/settings/users/{id}/mailAddress', 'verb' => 'PUT'],
56
+        ['name' => 'Users#setUserSettings', 'url' => '/settings/users/{username}/settings', 'verb' => 'PUT'],
57
+        ['name' => 'Users#getVerificationCode', 'url' => '/settings/users/{account}/verify', 'verb' => 'GET'],
58
+        ['name' => 'Users#setEnabled', 'url' => '/settings/users/{id}/setEnabled', 'verb' => 'POST'],
59
+        ['name' => 'Users#stats', 'url' => '/settings/users/stats', 'verb' => 'GET'],
60
+        ['name' => 'LogSettings#setLogLevel', 'url' => '/settings/admin/log/level', 'verb' => 'POST'],
61
+        ['name' => 'LogSettings#getEntries', 'url' => '/settings/admin/log/entries', 'verb' => 'GET'],
62
+        ['name' => 'LogSettings#download', 'url' => '/settings/admin/log/download', 'verb' => 'GET'],
63
+        ['name' => 'CheckSetup#check', 'url' => '/settings/ajax/checksetup', 'verb' => 'GET'],
64
+        ['name' => 'CheckSetup#getFailedIntegrityCheckFiles', 'url' => '/settings/integrity/failed', 'verb' => 'GET'],
65
+        ['name' => 'CheckSetup#rescanFailedIntegrityCheck', 'url' => '/settings/integrity/rescan', 'verb' => 'GET'],
66
+        ['name' => 'Certificate#addPersonalRootCertificate', 'url' => '/settings/personal/certificate', 'verb' => 'POST'],
67
+        ['name' => 'Certificate#removePersonalRootCertificate', 'url' => '/settings/personal/certificate/{certificateIdentifier}', 'verb' => 'DELETE'],
68
+        ['name' => 'Certificate#addSystemRootCertificate', 'url' => '/settings/admin/certificate', 'verb' => 'POST'],
69
+        ['name' => 'Certificate#removeSystemRootCertificate', 'url' => '/settings/admin/certificate/{certificateIdentifier}', 'verb' => 'DELETE'],
70
+        ['name' => 'PersonalSettings#index', 'url' => '/settings/user/{section}', 'verb' => 'GET', 'defaults' => ['section' => 'personal-info']],
71
+        ['name' => 'AdminSettings#index', 'url' => '/settings/admin/{section}', 'verb' => 'GET', 'defaults' => ['section' => 'server']],
72
+        ['name' => 'AdminSettings#form', 'url' => '/settings/admin/{section}', 'verb' => 'GET'],
73
+        ['name' => 'ChangePassword#changePersonalPassword', 'url' => '/settings/personal/changepassword', 'verb' => 'POST'],
74
+        ['name' => 'ChangePassword#changeUserPassword', 'url' => '/settings/users/changepassword', 'verb' => 'POST'],
75
+        ['name' => 'Groups#index', 'url' => '/settings/users/groups', 'verb' => 'GET'],
76
+        ['name' => 'Groups#show', 'url' => '/settings/users/groups/{id}', 'requirements' => ['id' => '[^?]*'], 'verb' => 'GET'],
77
+        ['name' => 'Groups#create', 'url' => '/settings/users/groups', 'verb' => 'POST'],
78
+        ['name' => 'Groups#update', 'url' => '/settings/users/groups/{id}', 'requirements' => ['id' => '[^?]*'], 'verb' => 'PUT'],
79
+        ['name' => 'Groups#destroy', 'url' => '/settings/users/groups/{id}', 'requirements' => ['id' => '[^?]*'], 'verb' => 'DELETE'],
80
+    ]
81 81
 ]);
82 82
 
83 83
 /** @var $this \OCP\Route\IRouter */
84 84
 
85 85
 // Settings pages
86 86
 $this->create('settings_help', '/settings/help')
87
-	->actionInclude('settings/help.php');
87
+    ->actionInclude('settings/help.php');
88 88
 $this->create('settings_users', '/settings/users')
89
-	->actionInclude('settings/users.php');
89
+    ->actionInclude('settings/users.php');
90 90
 // Settings ajax actions
91 91
 // users
92 92
 $this->create('settings_ajax_setquota', '/settings/ajax/setquota.php')
93
-	->actionInclude('settings/ajax/setquota.php');
93
+    ->actionInclude('settings/ajax/setquota.php');
94 94
 $this->create('settings_ajax_togglegroups', '/settings/ajax/togglegroups.php')
95
-	->actionInclude('settings/ajax/togglegroups.php');
95
+    ->actionInclude('settings/ajax/togglegroups.php');
96 96
 $this->create('settings_ajax_togglesubadmins', '/settings/ajax/togglesubadmins.php')
97
-	->actionInclude('settings/ajax/togglesubadmins.php');
97
+    ->actionInclude('settings/ajax/togglesubadmins.php');
98 98
 $this->create('settings_ajax_changegorupname', '/settings/ajax/changegroupname.php')
99
-	->actionInclude('settings/ajax/changegroupname.php');
99
+    ->actionInclude('settings/ajax/changegroupname.php');
100 100
 // apps
101 101
 $this->create('settings_ajax_enableapp', '/settings/ajax/enableapp.php')
102
-	->actionInclude('settings/ajax/enableapp.php');
102
+    ->actionInclude('settings/ajax/enableapp.php');
103 103
 $this->create('settings_ajax_disableapp', '/settings/ajax/disableapp.php')
104
-	->actionInclude('settings/ajax/disableapp.php');
104
+    ->actionInclude('settings/ajax/disableapp.php');
105 105
 $this->create('settings_ajax_updateapp', '/settings/ajax/updateapp.php')
106
-	->actionInclude('settings/ajax/updateapp.php');
106
+    ->actionInclude('settings/ajax/updateapp.php');
107 107
 $this->create('settings_ajax_uninstallapp', '/settings/ajax/uninstallapp.php')
108
-	->actionInclude('settings/ajax/uninstallapp.php');
108
+    ->actionInclude('settings/ajax/uninstallapp.php');
109 109
 $this->create('settings_ajax_navigationdetect', '/settings/ajax/navigationdetect.php')
110
-	->actionInclude('settings/ajax/navigationdetect.php');
110
+    ->actionInclude('settings/ajax/navigationdetect.php');
111 111
 // admin
112 112
 $this->create('settings_ajax_excludegroups', '/settings/ajax/excludegroups.php')
113
-	->actionInclude('settings/ajax/excludegroups.php');
113
+    ->actionInclude('settings/ajax/excludegroups.php');
Please login to merge, or discard this patch.
settings/users.php 2 patches
Indentation   +37 added lines, -37 removed lines patch added patch discarded remove patch
@@ -47,18 +47,18 @@  discard block
 block discarded – undo
47 47
 /* SORT OPTION: SORT_USERCOUNT or SORT_GROUPNAME */
48 48
 $sortGroupsBy = \OC\Group\MetaData::SORT_USERCOUNT;
49 49
 if ($config->getSystemValue('sort_groups_by_name', false)) {
50
-	$sortGroupsBy = \OC\Group\MetaData::SORT_GROUPNAME;
50
+    $sortGroupsBy = \OC\Group\MetaData::SORT_GROUPNAME;
51 51
 } else {
52
-	$isLDAPUsed = false;
53
-	if ($appManager->isEnabledForUser('user_ldap')) {
54
-		$isLDAPUsed =
55
-			$groupManager->isBackendUsed('\OCA\User_LDAP\Group_LDAP')
56
-			|| $groupManager->isBackendUsed('\OCA\User_LDAP\Group_Proxy');
57
-		if ($isLDAPUsed) {
58
-			// LDAP user count can be slow, so we sort by group name here
59
-			$sortGroupsBy = \OC\Group\MetaData::SORT_GROUPNAME;
60
-		}
61
-	}
52
+    $isLDAPUsed = false;
53
+    if ($appManager->isEnabledForUser('user_ldap')) {
54
+        $isLDAPUsed =
55
+            $groupManager->isBackendUsed('\OCA\User_LDAP\Group_LDAP')
56
+            || $groupManager->isBackendUsed('\OCA\User_LDAP\Group_Proxy');
57
+        if ($isLDAPUsed) {
58
+            // LDAP user count can be slow, so we sort by group name here
59
+            $sortGroupsBy = \OC\Group\MetaData::SORT_GROUPNAME;
60
+        }
61
+    }
62 62
 }
63 63
 
64 64
 /* ENCRYPTION CONFIG */
@@ -73,42 +73,42 @@  discard block
 block discarded – undo
73 73
 $isAdmin = \OC_User::isAdminUser($uid);
74 74
 
75 75
 $groupsInfo = new \OC\Group\MetaData(
76
-	$uid,
77
-	$isAdmin,
78
-	$groupManager,
79
-	\OC::$server->getUserSession()
76
+    $uid,
77
+    $isAdmin,
78
+    $groupManager,
79
+    \OC::$server->getUserSession()
80 80
 );
81 81
 
82 82
 $groupsInfo->setSorting($sortGroupsBy);
83 83
 list($adminGroup, $groups) = $groupsInfo->get();
84 84
 
85 85
 if ($isAdmin) {
86
-	$subAdmins = \OC::$server->getGroupManager()->getSubAdmin()->getAllSubAdmins();
87
-	// New class returns IUser[] so convert back
88
-	$result = [];
89
-	foreach ($subAdmins as $subAdmin) {
90
-		$result[] = [
91
-			'gid' => $subAdmin['group']->getGID(),
92
-			'uid' => $subAdmin['user']->getUID(),
93
-		];
94
-	}
95
-	$subAdmins = $result;
86
+    $subAdmins = \OC::$server->getGroupManager()->getSubAdmin()->getAllSubAdmins();
87
+    // New class returns IUser[] so convert back
88
+    $result = [];
89
+    foreach ($subAdmins as $subAdmin) {
90
+        $result[] = [
91
+            'gid' => $subAdmin['group']->getGID(),
92
+            'uid' => $subAdmin['user']->getUID(),
93
+        ];
94
+    }
95
+    $subAdmins = $result;
96 96
 } else {
97
-	/* Retrieve group IDs from $groups array, so we can pass that information into OC_Group::displayNamesInGroups() */
98
-	$gids = array();
99
-	foreach($groups as $group) {
100
-		if (isset($group['id'])) {
101
-			$gids[] = $group['id'];
102
-		}
103
-	}
104
-	$subAdmins = false;
97
+    /* Retrieve group IDs from $groups array, so we can pass that information into OC_Group::displayNamesInGroups() */
98
+    $gids = array();
99
+    foreach($groups as $group) {
100
+        if (isset($group['id'])) {
101
+            $gids[] = $group['id'];
102
+        }
103
+    }
104
+    $subAdmins = false;
105 105
 }
106 106
 
107 107
 $disabledUsers = $isLDAPUsed ? 0 : $userManager->countDisabledUsers();
108 108
 $disabledUsersGroup = [
109
-	'id' => '_disabled',
110
-	'name' => 'Disabled users',
111
-	'usercount' => $disabledUsers
109
+    'id' => '_disabled',
110
+    'name' => 'Disabled users',
111
+    'usercount' => $disabledUsers
112 112
 ];
113 113
 $allGroups = array_merge_recursive($adminGroup, $groups);
114 114
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 $quotaPreset=$config->getAppValue('files', 'quota_preset', '1 GB, 5 GB, 10 GB');
117 117
 $quotaPreset=explode(',', $quotaPreset);
118 118
 foreach($quotaPreset as &$preset) {
119
-	$preset=trim($preset);
119
+    $preset=trim($preset);
120 120
 }
121 121
 $quotaPreset=array_diff($quotaPreset, array('default', 'none'));
122 122
 $defaultQuota=$config->getAppValue('files', 'default_quota', 'none');
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 } else {
97 97
 	/* Retrieve group IDs from $groups array, so we can pass that information into OC_Group::displayNamesInGroups() */
98 98
 	$gids = array();
99
-	foreach($groups as $group) {
99
+	foreach ($groups as $group) {
100 100
 		if (isset($group['id'])) {
101 101
 			$gids[] = $group['id'];
102 102
 		}
@@ -113,13 +113,13 @@  discard block
 block discarded – undo
113 113
 $allGroups = array_merge_recursive($adminGroup, $groups);
114 114
 
115 115
 /* QUOTAS PRESETS */
116
-$quotaPreset=$config->getAppValue('files', 'quota_preset', '1 GB, 5 GB, 10 GB');
117
-$quotaPreset=explode(',', $quotaPreset);
118
-foreach($quotaPreset as &$preset) {
119
-	$preset=trim($preset);
116
+$quotaPreset = $config->getAppValue('files', 'quota_preset', '1 GB, 5 GB, 10 GB');
117
+$quotaPreset = explode(',', $quotaPreset);
118
+foreach ($quotaPreset as &$preset) {
119
+	$preset = trim($preset);
120 120
 }
121
-$quotaPreset=array_diff($quotaPreset, array('default', 'none'));
122
-$defaultQuota=$config->getAppValue('files', 'default_quota', 'none');
121
+$quotaPreset = array_diff($quotaPreset, array('default', 'none'));
122
+$defaultQuota = $config->getAppValue('files', 'default_quota', 'none');
123 123
 
124 124
 \OC::$server->getEventDispatcher()->dispatch('OC\Settings\Users::loadAdditionalScripts');
125 125
 
Please login to merge, or discard this patch.