nextcloud / server

apps/user_ldap/lib/Controller/ConfigAPIController.php

Indentation +218 added lines, -218 removed lines

@@ -27,235 +27,235 @@
 use Psr\Log\LoggerInterface;
 
 class ConfigAPIController extends OCSController {
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		CapabilitiesManager $capabilitiesManager,
-		IUserSession $userSession,
-		IUserManager $userManager,
-		Manager $keyManager,
-		ServerVersion $serverVersion,
-		private Helper $ldapHelper,
-		private LoggerInterface $logger,
-		private ConnectionFactory $connectionFactory,
-	) {
-		parent::__construct(
-			$appName,
-			$request,
-			$capabilitiesManager,
-			$userSession,
-			$userManager,
-			$keyManager,
-			$serverVersion,
-		);
-	}
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        CapabilitiesManager $capabilitiesManager,
+        IUserSession $userSession,
+        IUserManager $userManager,
+        Manager $keyManager,
+        ServerVersion $serverVersion,
+        private Helper $ldapHelper,
+        private LoggerInterface $logger,
+        private ConnectionFactory $connectionFactory,
+    ) {
+        parent::__construct(
+            $appName,
+            $request,
+            $capabilitiesManager,
+            $userSession,
+            $userManager,
+            $keyManager,
+            $serverVersion,
+        );
+    }
 
-	/**
-	 * Create a new (empty) configuration and return the resulting prefix
-	 *
-	 * @return DataResponse<Http::STATUS_OK, array{configID: string}, array{}>
-	 * @throws OCSException
-	 *
-	 * 200: Config created successfully
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	#[ApiRoute(verb: 'POST', url: '/api/v1/config')]
-	public function create() {
-		try {
-			$configPrefix = $this->ldapHelper->getNextServerConfigurationPrefix();
-			$configHolder = new Configuration($configPrefix);
-			$configHolder->ldapConfigurationActive = false;
-			$configHolder->saveConfiguration();
-		} catch (\Exception $e) {
-			$this->logger->error($e->getMessage(), ['exception' => $e]);
-			throw new OCSException('An issue occurred when creating the new config.');
-		}
-		return new DataResponse(['configID' => $configPrefix]);
-	}
+    /**
+     * Create a new (empty) configuration and return the resulting prefix
+     *
+     * @return DataResponse<Http::STATUS_OK, array{configID: string}, array{}>
+     * @throws OCSException
+     *
+     * 200: Config created successfully
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    #[ApiRoute(verb: 'POST', url: '/api/v1/config')]
+    public function create() {
+        try {
+            $configPrefix = $this->ldapHelper->getNextServerConfigurationPrefix();
+            $configHolder = new Configuration($configPrefix);
+            $configHolder->ldapConfigurationActive = false;
+            $configHolder->saveConfiguration();
+        } catch (\Exception $e) {
+            $this->logger->error($e->getMessage(), ['exception' => $e]);
+            throw new OCSException('An issue occurred when creating the new config.');
+        }
+        return new DataResponse(['configID' => $configPrefix]);
+    }
 
-	/**
-	 * Delete a LDAP configuration
-	 *
-	 * @param string $configID ID of the config
-	 * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
-	 * @throws OCSException
-	 * @throws OCSNotFoundException Config not found
-	 *
-	 * 200: Config deleted successfully
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	#[ApiRoute(verb: 'DELETE', url: '/api/v1/config/{configID}')]
-	public function delete($configID) {
-		try {
-			$this->ensureConfigIDExists($configID);
-			if (!$this->ldapHelper->deleteServerConfiguration($configID)) {
-				throw new OCSException('Could not delete configuration');
-			}
-		} catch (OCSException $e) {
-			throw $e;
-		} catch (\Exception $e) {
-			$this->logger->error($e->getMessage(), ['exception' => $e]);
-			throw new OCSException('An issue occurred when deleting the config.');
-		}
+    /**
+     * Delete a LDAP configuration
+     *
+     * @param string $configID ID of the config
+     * @return DataResponse<Http::STATUS_OK, list<empty>, array{}>
+     * @throws OCSException
+     * @throws OCSNotFoundException Config not found
+     *
+     * 200: Config deleted successfully
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    #[ApiRoute(verb: 'DELETE', url: '/api/v1/config/{configID}')]
+    public function delete($configID) {
+        try {
+            $this->ensureConfigIDExists($configID);
+            if (!$this->ldapHelper->deleteServerConfiguration($configID)) {
+                throw new OCSException('Could not delete configuration');
+            }
+        } catch (OCSException $e) {
+            throw $e;
+        } catch (\Exception $e) {
+            $this->logger->error($e->getMessage(), ['exception' => $e]);
+            throw new OCSException('An issue occurred when deleting the config.');
+        }
 
-		return new DataResponse();
-	}
+        return new DataResponse();
+    }
 
-	/**
-	 * Modify a configuration
-	 *
-	 * @param string $configID ID of the config
-	 * @param array<string, mixed> $configData New config
-	 * @return DataResponse<Http::STATUS_OK, array<string, mixed>, array{}>
-	 * @throws OCSException
-	 * @throws OCSBadRequestException Modifying config is not possible
-	 * @throws OCSNotFoundException Config not found
-	 *
-	 * 200: Config returned
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	#[ApiRoute(verb: 'PUT', url: '/api/v1/config/{configID}')]
-	public function modify($configID, $configData) {
-		try {
-			$this->ensureConfigIDExists($configID);
+    /**
+     * Modify a configuration
+     *
+     * @param string $configID ID of the config
+     * @param array<string, mixed> $configData New config
+     * @return DataResponse<Http::STATUS_OK, array<string, mixed>, array{}>
+     * @throws OCSException
+     * @throws OCSBadRequestException Modifying config is not possible
+     * @throws OCSNotFoundException Config not found
+     *
+     * 200: Config returned
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    #[ApiRoute(verb: 'PUT', url: '/api/v1/config/{configID}')]
+    public function modify($configID, $configData) {
+        try {
+            $this->ensureConfigIDExists($configID);
 
-			if (!is_array($configData)) {
-				throw new OCSBadRequestException('configData is not properly set');
-			}
+            if (!is_array($configData)) {
+                throw new OCSBadRequestException('configData is not properly set');
+            }
 
-			$configuration = new Configuration($configID);
-			$configKeys = $configuration->getConfigTranslationArray();
+            $configuration = new Configuration($configID);
+            $configKeys = $configuration->getConfigTranslationArray();
 
-			foreach ($configKeys as $i => $key) {
-				if (isset($configData[$key])) {
-					$configuration->$key = $configData[$key];
-				}
-			}
+            foreach ($configKeys as $i => $key) {
+                if (isset($configData[$key])) {
+                    $configuration->$key = $configData[$key];
+                }
+            }
 
-			$configuration->saveConfiguration();
-			$this->connectionFactory->get($configID)->clearCache();
-		} catch (OCSException $e) {
-			throw $e;
-		} catch (\Exception $e) {
-			$this->logger->error($e->getMessage(), ['exception' => $e]);
-			throw new OCSException('An issue occurred when modifying the config.');
-		}
+            $configuration->saveConfiguration();
+            $this->connectionFactory->get($configID)->clearCache();
+        } catch (OCSException $e) {
+            throw $e;
+        } catch (\Exception $e) {
+            $this->logger->error($e->getMessage(), ['exception' => $e]);
+            throw new OCSException('An issue occurred when modifying the config.');
+        }
 
-		return $this->show($configID, false);
-	}
+        return $this->show($configID, false);
+    }
 
-	/**
-	 * Get a configuration
-	 *
-	 * Output can look like this:
-	 * <?xml version="1.0"?>
-	 * <ocs>
-	 *   <meta>
-	 *     <status>ok</status>
-	 *     <statuscode>200</statuscode>
-	 *     <message>OK</message>
-	 *   </meta>
-	 *   <data>
-	 *     <ldapHost>ldaps://my.ldap.server</ldapHost>
-	 *     <ldapPort>7770</ldapPort>
-	 *     <ldapBackupHost></ldapBackupHost>
-	 *     <ldapBackupPort></ldapBackupPort>
-	 *     <ldapBase>ou=small,dc=my,dc=ldap,dc=server</ldapBase>
-	 *     <ldapBaseUsers>ou=users,ou=small,dc=my,dc=ldap,dc=server</ldapBaseUsers>
-	 *     <ldapBaseGroups>ou=small,dc=my,dc=ldap,dc=server</ldapBaseGroups>
-	 *     <ldapAgentName>cn=root,dc=my,dc=ldap,dc=server</ldapAgentName>
-	 *     <ldapAgentPassword>clearTextWithShowPassword=1</ldapAgentPassword>
-	 *     <ldapTLS>1</ldapTLS>
-	 *     <turnOffCertCheck>0</turnOffCertCheck>
-	 *     <ldapIgnoreNamingRules/>
-	 *     <ldapUserDisplayName>displayname</ldapUserDisplayName>
-	 *     <ldapUserDisplayName2>uid</ldapUserDisplayName2>
-	 *     <ldapUserFilterObjectclass>inetOrgPerson</ldapUserFilterObjectclass>
-	 *     <ldapUserFilterGroups></ldapUserFilterGroups>
-	 *     <ldapUserFilter>(&amp;(objectclass=nextcloudUser)(nextcloudEnabled=TRUE))</ldapUserFilter>
-	 *     <ldapUserFilterMode>1</ldapUserFilterMode>
-	 *     <ldapGroupFilter>(&amp;(|(objectclass=nextcloudGroup)))</ldapGroupFilter>
-	 *     <ldapGroupFilterMode>0</ldapGroupFilterMode>
-	 *     <ldapGroupFilterObjectclass>nextcloudGroup</ldapGroupFilterObjectclass>
-	 *     <ldapGroupFilterGroups></ldapGroupFilterGroups>
-	 *     <ldapGroupDisplayName>cn</ldapGroupDisplayName>
-	 *     <ldapGroupMemberAssocAttr>memberUid</ldapGroupMemberAssocAttr>
-	 *     <ldapLoginFilter>(&amp;(|(objectclass=inetOrgPerson))(uid=%uid))</ldapLoginFilter>
-	 *     <ldapLoginFilterMode>0</ldapLoginFilterMode>
-	 *     <ldapLoginFilterEmail>0</ldapLoginFilterEmail>
-	 *     <ldapLoginFilterUsername>1</ldapLoginFilterUsername>
-	 *     <ldapLoginFilterAttributes></ldapLoginFilterAttributes>
-	 *     <ldapQuotaAttribute></ldapQuotaAttribute>
-	 *     <ldapQuotaDefault></ldapQuotaDefault>
-	 *     <ldapEmailAttribute>mail</ldapEmailAttribute>
-	 *     <ldapCacheTTL>20</ldapCacheTTL>
-	 *     <ldapUuidUserAttribute>auto</ldapUuidUserAttribute>
-	 *     <ldapUuidGroupAttribute>auto</ldapUuidGroupAttribute>
-	 *     <ldapOverrideMainServer></ldapOverrideMainServer>
-	 *     <ldapConfigurationActive>1</ldapConfigurationActive>
-	 *     <ldapAttributesForUserSearch>uid;sn;givenname</ldapAttributesForUserSearch>
-	 *     <ldapAttributesForGroupSearch></ldapAttributesForGroupSearch>
-	 *     <ldapExperiencedAdmin>0</ldapExperiencedAdmin>
-	 *     <homeFolderNamingRule></homeFolderNamingRule>
-	 *     <hasMemberOfFilterSupport></hasMemberOfFilterSupport>
-	 *     <useMemberOfToDetectMembership>1</useMemberOfToDetectMembership>
-	 *     <ldapExpertUsernameAttr>uid</ldapExpertUsernameAttr>
-	 *     <ldapExpertUUIDUserAttr>uid</ldapExpertUUIDUserAttr>
-	 *     <ldapExpertUUIDGroupAttr></ldapExpertUUIDGroupAttr>
-	 *     <lastJpegPhotoLookup>0</lastJpegPhotoLookup>
-	 *     <ldapNestedGroups>0</ldapNestedGroups>
-	 *     <ldapPagingSize>500</ldapPagingSize>
-	 *     <turnOnPasswordChange>1</turnOnPasswordChange>
-	 *     <ldapDynamicGroupMemberURL></ldapDynamicGroupMemberURL>
-	 *   </data>
-	 * </ocs>
-	 *
-	 * @param string $configID ID of the config
-	 * @param bool $showPassword Whether to show the password
-	 * @return DataResponse<Http::STATUS_OK, array<string, mixed>, array{}>
-	 * @throws OCSException
-	 * @throws OCSNotFoundException Config not found
-	 *
-	 * 200: Config returned
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	#[ApiRoute(verb: 'GET', url: '/api/v1/config/{configID}')]
-	public function show($configID, $showPassword = false) {
-		try {
-			$this->ensureConfigIDExists($configID);
+    /**
+     * Get a configuration
+     *
+     * Output can look like this:
+     * <?xml version="1.0"?>
+     * <ocs>
+     *   <meta>
+     *     <status>ok</status>
+     *     <statuscode>200</statuscode>
+     *     <message>OK</message>
+     *   </meta>
+     *   <data>
+     *     <ldapHost>ldaps://my.ldap.server</ldapHost>
+     *     <ldapPort>7770</ldapPort>
+     *     <ldapBackupHost></ldapBackupHost>
+     *     <ldapBackupPort></ldapBackupPort>
+     *     <ldapBase>ou=small,dc=my,dc=ldap,dc=server</ldapBase>
+     *     <ldapBaseUsers>ou=users,ou=small,dc=my,dc=ldap,dc=server</ldapBaseUsers>
+     *     <ldapBaseGroups>ou=small,dc=my,dc=ldap,dc=server</ldapBaseGroups>
+     *     <ldapAgentName>cn=root,dc=my,dc=ldap,dc=server</ldapAgentName>
+     *     <ldapAgentPassword>clearTextWithShowPassword=1</ldapAgentPassword>
+     *     <ldapTLS>1</ldapTLS>
+     *     <turnOffCertCheck>0</turnOffCertCheck>
+     *     <ldapIgnoreNamingRules/>
+     *     <ldapUserDisplayName>displayname</ldapUserDisplayName>
+     *     <ldapUserDisplayName2>uid</ldapUserDisplayName2>
+     *     <ldapUserFilterObjectclass>inetOrgPerson</ldapUserFilterObjectclass>
+     *     <ldapUserFilterGroups></ldapUserFilterGroups>
+     *     <ldapUserFilter>(&amp;(objectclass=nextcloudUser)(nextcloudEnabled=TRUE))</ldapUserFilter>
+     *     <ldapUserFilterMode>1</ldapUserFilterMode>
+     *     <ldapGroupFilter>(&amp;(|(objectclass=nextcloudGroup)))</ldapGroupFilter>
+     *     <ldapGroupFilterMode>0</ldapGroupFilterMode>
+     *     <ldapGroupFilterObjectclass>nextcloudGroup</ldapGroupFilterObjectclass>
+     *     <ldapGroupFilterGroups></ldapGroupFilterGroups>
+     *     <ldapGroupDisplayName>cn</ldapGroupDisplayName>
+     *     <ldapGroupMemberAssocAttr>memberUid</ldapGroupMemberAssocAttr>
+     *     <ldapLoginFilter>(&amp;(|(objectclass=inetOrgPerson))(uid=%uid))</ldapLoginFilter>
+     *     <ldapLoginFilterMode>0</ldapLoginFilterMode>
+     *     <ldapLoginFilterEmail>0</ldapLoginFilterEmail>
+     *     <ldapLoginFilterUsername>1</ldapLoginFilterUsername>
+     *     <ldapLoginFilterAttributes></ldapLoginFilterAttributes>
+     *     <ldapQuotaAttribute></ldapQuotaAttribute>
+     *     <ldapQuotaDefault></ldapQuotaDefault>
+     *     <ldapEmailAttribute>mail</ldapEmailAttribute>
+     *     <ldapCacheTTL>20</ldapCacheTTL>
+     *     <ldapUuidUserAttribute>auto</ldapUuidUserAttribute>
+     *     <ldapUuidGroupAttribute>auto</ldapUuidGroupAttribute>
+     *     <ldapOverrideMainServer></ldapOverrideMainServer>
+     *     <ldapConfigurationActive>1</ldapConfigurationActive>
+     *     <ldapAttributesForUserSearch>uid;sn;givenname</ldapAttributesForUserSearch>
+     *     <ldapAttributesForGroupSearch></ldapAttributesForGroupSearch>
+     *     <ldapExperiencedAdmin>0</ldapExperiencedAdmin>
+     *     <homeFolderNamingRule></homeFolderNamingRule>
+     *     <hasMemberOfFilterSupport></hasMemberOfFilterSupport>
+     *     <useMemberOfToDetectMembership>1</useMemberOfToDetectMembership>
+     *     <ldapExpertUsernameAttr>uid</ldapExpertUsernameAttr>
+     *     <ldapExpertUUIDUserAttr>uid</ldapExpertUUIDUserAttr>
+     *     <ldapExpertUUIDGroupAttr></ldapExpertUUIDGroupAttr>
+     *     <lastJpegPhotoLookup>0</lastJpegPhotoLookup>
+     *     <ldapNestedGroups>0</ldapNestedGroups>
+     *     <ldapPagingSize>500</ldapPagingSize>
+     *     <turnOnPasswordChange>1</turnOnPasswordChange>
+     *     <ldapDynamicGroupMemberURL></ldapDynamicGroupMemberURL>
+     *   </data>
+     * </ocs>
+     *
+     * @param string $configID ID of the config
+     * @param bool $showPassword Whether to show the password
+     * @return DataResponse<Http::STATUS_OK, array<string, mixed>, array{}>
+     * @throws OCSException
+     * @throws OCSNotFoundException Config not found
+     *
+     * 200: Config returned
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    #[ApiRoute(verb: 'GET', url: '/api/v1/config/{configID}')]
+    public function show($configID, $showPassword = false) {
+        try {
+            $this->ensureConfigIDExists($configID);
 
-			$config = new Configuration($configID);
-			$data = $config->getConfiguration();
-			if (!$showPassword) {
-				$data['ldapAgentPassword'] = '***';
-			}
-			foreach ($data as $key => $value) {
-				if (is_array($value)) {
-					$value = implode(';', $value);
-					$data[$key] = $value;
-				}
-			}
-		} catch (OCSException $e) {
-			throw $e;
-		} catch (\Exception $e) {
-			$this->logger->error($e->getMessage(), ['exception' => $e]);
-			throw new OCSException('An issue occurred when modifying the config.');
-		}
+            $config = new Configuration($configID);
+            $data = $config->getConfiguration();
+            if (!$showPassword) {
+                $data['ldapAgentPassword'] = '***';
+            }
+            foreach ($data as $key => $value) {
+                if (is_array($value)) {
+                    $value = implode(';', $value);
+                    $data[$key] = $value;
+                }
+            }
+        } catch (OCSException $e) {
+            throw $e;
+        } catch (\Exception $e) {
+            $this->logger->error($e->getMessage(), ['exception' => $e]);
+            throw new OCSException('An issue occurred when modifying the config.');
+        }
 
-		return new DataResponse($data);
-	}
+        return new DataResponse($data);
+    }
 
-	/**
-	 * If the given config ID is not available, an exception is thrown
-	 *
-	 * @param string $configID
-	 * @throws OCSNotFoundException
-	 */
-	#[AuthorizedAdminSetting(settings: Admin::class)]
-	private function ensureConfigIDExists($configID): void {
-		$prefixes = $this->ldapHelper->getServerConfigurationPrefixes();
-		if (!in_array($configID, $prefixes, true)) {
-			throw new OCSNotFoundException('Config ID not found');
-		}
-	}
+    /**
+     * If the given config ID is not available, an exception is thrown
+     *
+     * @param string $configID
+     * @throws OCSNotFoundException
+     */
+    #[AuthorizedAdminSetting(settings: Admin::class)]
+    private function ensureConfigIDExists($configID): void {
+        $prefixes = $this->ldapHelper->getServerConfigurationPrefixes();
+        if (!in_array($configID, $prefixes, true)) {
+            throw new OCSNotFoundException('Config ID not found');
+        }
+    }
 }

apps/user_ldap/lib/Settings/Admin.php

Indentation +58 added lines, -58 removed lines

@@ -16,72 +16,72 @@
 use OCP\Template\ITemplateManager;
 
 class Admin implements IDelegatedSettings {
-	public function __construct(
-		private IL10N $l,
-		private ITemplateManager $templateManager,
-		private IInitialState $initialState,
-	) {
-	}
+    public function __construct(
+        private IL10N $l,
+        private ITemplateManager $templateManager,
+        private IInitialState $initialState,
+    ) {
+    }
 
-	public function getForm(): TemplateResponse {
-		$helper = Server::get(Helper::class);
-		$prefixes = $helper->getServerConfigurationPrefixes();
-		if (count($prefixes) === 0) {
-			$newPrefix = $helper->getNextServerConfigurationPrefix();
-			$config = new Configuration($newPrefix, false);
-			$config->setConfiguration($config->getDefaults());
-			$config->saveConfiguration();
-			$prefixes[] = $newPrefix;
-		}
+    public function getForm(): TemplateResponse {
+        $helper = Server::get(Helper::class);
+        $prefixes = $helper->getServerConfigurationPrefixes();
+        if (count($prefixes) === 0) {
+            $newPrefix = $helper->getNextServerConfigurationPrefix();
+            $config = new Configuration($newPrefix, false);
+            $config->setConfiguration($config->getDefaults());
+            $config->saveConfiguration();
+            $prefixes[] = $newPrefix;
+        }
 
-		// assign default values
-		if (!isset($config)) {
-			$config = new Configuration('', false);
-		}
-		$defaults = $config->getDefaults();
-		foreach ($defaults as $key => $default) {
-			$parameters[$key . '_default'] = $default;
-		}
+        // assign default values
+        if (!isset($config)) {
+            $config = new Configuration('', false);
+        }
+        $defaults = $config->getDefaults();
+        foreach ($defaults as $key => $default) {
+            $parameters[$key . '_default'] = $default;
+        }
 
-		$ldapConfigs = [];
-		foreach ($prefixes as $prefix) {
-			$ldapConfig = new Configuration($prefix);
-			$rawLdapConfig = $ldapConfig->getConfiguration();
-			foreach ($rawLdapConfig as $key => $value) {
-				if (is_array($value)) {
-					$rawLdapConfig[$key] = implode(';', $value);
-				}
-			}
+        $ldapConfigs = [];
+        foreach ($prefixes as $prefix) {
+            $ldapConfig = new Configuration($prefix);
+            $rawLdapConfig = $ldapConfig->getConfiguration();
+            foreach ($rawLdapConfig as $key => $value) {
+                if (is_array($value)) {
+                    $rawLdapConfig[$key] = implode(';', $value);
+                }
+            }
 
-			$ldapConfigs[$prefix] = $rawLdapConfig;
-		}
+            $ldapConfigs[$prefix] = $rawLdapConfig;
+        }
 
-		$this->initialState->provideInitialState('ldapConfigs', $ldapConfigs);
-		$this->initialState->provideInitialState('ldapModuleInstalled', function_exists('ldap_connect'));
+        $this->initialState->provideInitialState('ldapConfigs', $ldapConfigs);
+        $this->initialState->provideInitialState('ldapModuleInstalled', function_exists('ldap_connect'));
 
-		return new TemplateResponse('user_ldap', 'settings', $parameters);
-	}
+        return new TemplateResponse('user_ldap', 'settings', $parameters);
+    }
 
-	public function getSection(): string {
-		return 'ldap';
-	}
+    public function getSection(): string {
+        return 'ldap';
+    }
 
-	/**
-	 * @return int whether the form should be rather on the top or bottom of
-	 *             the admin section. The forms are arranged in ascending order of the
-	 *             priority values. It is required to return a value between 0 and 100.
-	 *
-	 * E.g.: 70
-	 */
-	public function getPriority(): int {
-		return 5;
-	}
+    /**
+     * @return int whether the form should be rather on the top or bottom of
+     *             the admin section. The forms are arranged in ascending order of the
+     *             priority values. It is required to return a value between 0 and 100.
+     *
+     * E.g.: 70
+     */
+    public function getPriority(): int {
+        return 5;
+    }
 
-	public function getName(): ?string {
-		return null; // Only one setting in this section
-	}
+    public function getName(): ?string {
+        return null; // Only one setting in this section
+    }
 
-	public function getAuthorizedAppConfig(): array {
-		return []; // Custom controller
-	}
+    public function getAuthorizedAppConfig(): array {
+        return []; // Custom controller
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 		}
 		$defaults = $config->getDefaults();
 		foreach ($defaults as $key => $default) {
-			$parameters[$key . '_default'] = $default;
+			$parameters[$key.'_default'] = $default;
 		}
 
 		$ldapConfigs = [];

apps/user_ldap/appinfo/routes.php

Indentation +13 added lines, -13 removed lines

@@ -8,25 +8,25 @@
  * SPDX-License-Identifier: AGPL-3.0-only
  */
 $this->create('user_ldap_ajax_clearMappings', 'apps/user_ldap/ajax/clearMappings.php')
-	->actionInclude('user_ldap/ajax/clearMappings.php');
+    ->actionInclude('user_ldap/ajax/clearMappings.php');
 $this->create('user_ldap_ajax_deleteConfiguration', 'apps/user_ldap/ajax/deleteConfiguration.php')
-	->actionInclude('user_ldap/ajax/deleteConfiguration.php');
+    ->actionInclude('user_ldap/ajax/deleteConfiguration.php');
 $this->create('user_ldap_ajax_getConfiguration', 'apps/user_ldap/ajax/getConfiguration.php')
-	->actionInclude('user_ldap/ajax/getConfiguration.php');
+    ->actionInclude('user_ldap/ajax/getConfiguration.php');
 $this->create('user_ldap_ajax_getNewServerConfigPrefix', 'apps/user_ldap/ajax/getNewServerConfigPrefix.php')
-	->actionInclude('user_ldap/ajax/getNewServerConfigPrefix.php');
+    ->actionInclude('user_ldap/ajax/getNewServerConfigPrefix.php');
 $this->create('user_ldap_ajax_setConfiguration', 'apps/user_ldap/ajax/setConfiguration.php')
-	->actionInclude('user_ldap/ajax/setConfiguration.php');
+    ->actionInclude('user_ldap/ajax/setConfiguration.php');
 $this->create('user_ldap_ajax_testConfiguration', 'apps/user_ldap/ajax/testConfiguration.php')
-	->actionInclude('user_ldap/ajax/testConfiguration.php');
+    ->actionInclude('user_ldap/ajax/testConfiguration.php');
 $this->create('user_ldap_ajax_wizard', 'apps/user_ldap/ajax/wizard.php')
-	->actionInclude('user_ldap/ajax/wizard.php');
+    ->actionInclude('user_ldap/ajax/wizard.php');
 
 return [
-	'routes' => [
-		['name' => 'renewPassword#tryRenewPassword', 'url' => '/renewpassword', 'verb' => 'POST'],
-		['name' => 'renewPassword#showRenewPasswordForm', 'url' => '/renewpassword/{user}', 'verb' => 'GET'],
-		['name' => 'renewPassword#cancel', 'url' => '/renewpassword/cancel', 'verb' => 'GET'],
-		['name' => 'renewPassword#showLoginFormInvalidPassword', 'url' => '/renewpassword/invalidlogin/{user}', 'verb' => 'GET'],
-	],
+    'routes' => [
+        ['name' => 'renewPassword#tryRenewPassword', 'url' => '/renewpassword', 'verb' => 'POST'],
+        ['name' => 'renewPassword#showRenewPasswordForm', 'url' => '/renewpassword/{user}', 'verb' => 'GET'],
+        ['name' => 'renewPassword#cancel', 'url' => '/renewpassword/cancel', 'verb' => 'GET'],
+        ['name' => 'renewPassword#showLoginFormInvalidPassword', 'url' => '/renewpassword/invalidlogin/{user}', 'verb' => 'GET'],
+    ],
 ];

apps/user_ldap/tests/Settings/AdminTest.php

Indentation +38 added lines, -38 removed lines

@@ -22,51 +22,51 @@
  * @package OCA\User_LDAP\Tests\Settings
  */
 class AdminTest extends TestCase {
-	private IL10N&MockObject $l10n;
-	private ITemplateManager $templateManager;
-	private IInitialState&MockObject $initialState;
-	private Admin $admin;
+    private IL10N&MockObject $l10n;
+    private ITemplateManager $templateManager;
+    private IInitialState&MockObject $initialState;
+    private Admin $admin;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->templateManager = Server::get(ITemplateManager::class);
-		$this->initialState = $this->createMock(IInitialState::class);
+    protected function setUp(): void {
+        parent::setUp();
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->templateManager = Server::get(ITemplateManager::class);
+        $this->initialState = $this->createMock(IInitialState::class);
 
-		$this->admin = new Admin(
-			$this->l10n,
-			$this->templateManager,
-			$this->initialState,
-		);
-	}
+        $this->admin = new Admin(
+            $this->l10n,
+            $this->templateManager,
+            $this->initialState,
+        );
+    }
 
-	public function testGetForm(): void {
-		$prefixes = ['s01'];
-		$hosts = ['s01' => ''];
+    public function testGetForm(): void {
+        $prefixes = ['s01'];
+        $hosts = ['s01' => ''];
 
-		$wControls = $this->templateManager->getTemplate('user_ldap', 'part.wizardcontrols');
-		$wControls = $wControls->fetchPage();
-		$sControls = $this->templateManager->getTemplate('user_ldap', 'part.settingcontrols');
-		$sControls = $sControls->fetchPage();
+        $wControls = $this->templateManager->getTemplate('user_ldap', 'part.wizardcontrols');
+        $wControls = $wControls->fetchPage();
+        $sControls = $this->templateManager->getTemplate('user_ldap', 'part.settingcontrols');
+        $sControls = $sControls->fetchPage();
 
-		$parameters = [];
+        $parameters = [];
 
-		// assign default values
-		$config = new Configuration('', false);
-		$defaults = $config->getDefaults();
-		foreach ($defaults as $key => $default) {
-			$parameters[$key . '_default'] = $default;
-		}
+        // assign default values
+        $config = new Configuration('', false);
+        $defaults = $config->getDefaults();
+        foreach ($defaults as $key => $default) {
+            $parameters[$key . '_default'] = $default;
+        }
 
-		$expected = new TemplateResponse('user_ldap', 'settings', $parameters);
-		$this->assertEquals($expected, $this->admin->getForm());
-	}
+        $expected = new TemplateResponse('user_ldap', 'settings', $parameters);
+        $this->assertEquals($expected, $this->admin->getForm());
+    }
 
-	public function testGetSection(): void {
-		$this->assertSame('ldap', $this->admin->getSection());
-	}
+    public function testGetSection(): void {
+        $this->assertSame('ldap', $this->admin->getSection());
+    }
 
-	public function testGetPriority(): void {
-		$this->assertSame(5, $this->admin->getPriority());
-	}
+    public function testGetPriority(): void {
+        $this->assertSame(5, $this->admin->getPriority());
+    }
 }