Inspection of "Merge pull request #19968 from nextcloud/enh/noid/..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 48bdd3...b53a48 )

by Blizzz

created 2020-03-16 21:12 UTC

Status

Indentation +152 added lines, -152 removed lines patch added patch discarded remove patch

@@ -40,156 +40,156 @@
 block discarded – undo
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 abstract class ASettings implements ISettings {
-	/** @var IL10N */
-	private $l10n;
-
-	/** @var string */
-	private $appName;
-
-	/** @var EventDispatcherInterface */
-	private $eventDispatcher;
-
-	/** @var Manager */
-	private $manager;
-
-	/** @var IInitialStateService */
-	private $initialStateService;
-
-	/** @var IConfig */
-	private $config;
-
-	/**
-	 * @param string $appName
-	 * @param IL10N $l
-	 * @param EventDispatcherInterface $eventDispatcher
-	 * @param Manager $manager
-	 * @param IInitialStateService $initialStateService
-	 * @param IConfig $config
-	 */
-	public function __construct(
-		$appName,
-		IL10N $l,
-		EventDispatcherInterface $eventDispatcher,
-		Manager $manager,
-		IInitialStateService $initialStateService,
-		IConfig $config
-	) {
-		$this->appName = $appName;
-		$this->l10n = $l;
-		$this->eventDispatcher = $eventDispatcher;
-		$this->manager = $manager;
-		$this->initialStateService = $initialStateService;
-		$this->config = $config;
-	}
-
-	abstract function getScope(): int;
-
-	/**
-	 * @return TemplateResponse
-	 */
-	public function getForm() {
-		$this->eventDispatcher->dispatch('OCP\WorkflowEngine::loadAdditionalSettingScripts');
-
-		$entities = $this->manager->getEntitiesList();
-		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
-			'entities',
-			$this->entitiesToArray($entities)
-		);
-
-		$operators = $this->manager->getOperatorList();
-		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
-			'operators',
-			$this->operatorsToArray($operators)
-		);
-
-		$checks = $this->manager->getCheckList();
-		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
-			'checks',
-			$this->checksToArray($checks)
-		);
-
-		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
-			'scope',
-			$this->getScope()
-		);
-
-		$this->initialStateService->provideInitialState(
-			Application::APP_ID,
-			'appstoreenabled',
-			$this->config->getSystemValueBool('appstoreenabled', true)
-		);
-
-		return new TemplateResponse(Application::APP_ID, 'settings', [], 'blank');
-	}
-
-	/**
-	 * @return string the section ID, e.g. 'sharing'
-	 */
-	public function getSection() {
-		return 'workflow';
-	}
-
-	/**
-	 * @return int whether the form should be rather on the top or bottom of
-	 * the admin section. The forms are arranged in ascending order of the
-	 * priority values. It is required to return a value between 0 and 100.
-	 *
-	 * E.g.: 70
-	 */
-	public function getPriority() {
-		return 0;
-	}
-
-	private function entitiesToArray(array $entities) {
-		return array_map(function (IEntity $entity) {
-			$events = array_map(function(IEntityEvent $entityEvent) {
-				return [
-					'eventName' => $entityEvent->getEventName(),
-					'displayName' => $entityEvent->getDisplayName()
-				];
-			}, $entity->getEvents());
-
-			return [
-				'id' => get_class($entity),
-				'icon' => $entity->getIcon(),
-				'name' => $entity->getName(),
-				'events' => $events,
-			];
-		}, $entities);
-	}
-
-	private function operatorsToArray(array $operators) {
-		$operators = array_filter($operators, function(IOperation $operator) {
-			return $operator->isAvailableForScope($this->getScope());
-		});
-
-		return array_map(function (IOperation $operator) {
-			return [
-				'id' => get_class($operator),
-				'icon' => $operator->getIcon(),
-				'name' => $operator->getDisplayName(),
-				'description' => $operator->getDescription(),
-				'fixedEntity' => $operator instanceof ISpecificOperation ? $operator->getEntityId() : '',
-				'isComplex' => $operator instanceof IComplexOperation,
-				'triggerHint' => $operator instanceof IComplexOperation ? $operator->getTriggerHint() : '',
-			];
-		}, $operators);
-	}
-
-	private function checksToArray(array $checks) {
-		$checks = array_filter($checks, function(ICheck $check) {
-			return $check->isAvailableForScope($this->getScope());
-		});
-
-		return array_map(function (ICheck $check) {
-			return [
-				'id' => get_class($check),
-				'supportedEntities' => $check->supportedEntities(),
-			];
-		}, $checks);
-	}
+    /** @var IL10N */
+    private $l10n;
+
+    /** @var string */
+    private $appName;
+
+    /** @var EventDispatcherInterface */
+    private $eventDispatcher;
+
+    /** @var Manager */
+    private $manager;
+
+    /** @var IInitialStateService */
+    private $initialStateService;
+
+    /** @var IConfig */
+    private $config;
+
+    /**
+     * @param string $appName
+     * @param IL10N $l
+     * @param EventDispatcherInterface $eventDispatcher
+     * @param Manager $manager
+     * @param IInitialStateService $initialStateService
+     * @param IConfig $config
+     */
+    public function __construct(
+        $appName,
+        IL10N $l,
+        EventDispatcherInterface $eventDispatcher,
+        Manager $manager,
+        IInitialStateService $initialStateService,
+        IConfig $config
+    ) {
+        $this->appName = $appName;
+        $this->l10n = $l;
+        $this->eventDispatcher = $eventDispatcher;
+        $this->manager = $manager;
+        $this->initialStateService = $initialStateService;
+        $this->config = $config;
+    }
+
+    abstract function getScope(): int;
+
+    /**
+     * @return TemplateResponse
+     */
+    public function getForm() {
+        $this->eventDispatcher->dispatch('OCP\WorkflowEngine::loadAdditionalSettingScripts');
+
+        $entities = $this->manager->getEntitiesList();
+        $this->initialStateService->provideInitialState(
+            Application::APP_ID,
+            'entities',
+            $this->entitiesToArray($entities)
+        );
+
+        $operators = $this->manager->getOperatorList();
+        $this->initialStateService->provideInitialState(
+            Application::APP_ID,
+            'operators',
+            $this->operatorsToArray($operators)
+        );
+
+        $checks = $this->manager->getCheckList();
+        $this->initialStateService->provideInitialState(
+            Application::APP_ID,
+            'checks',
+            $this->checksToArray($checks)
+        );
+
+        $this->initialStateService->provideInitialState(
+            Application::APP_ID,
+            'scope',
+            $this->getScope()
+        );
+
+        $this->initialStateService->provideInitialState(
+            Application::APP_ID,
+            'appstoreenabled',
+            $this->config->getSystemValueBool('appstoreenabled', true)
+        );
+
+        return new TemplateResponse(Application::APP_ID, 'settings', [], 'blank');
+    }
+
+    /**
+     * @return string the section ID, e.g. 'sharing'
+     */
+    public function getSection() {
+        return 'workflow';
+    }
+
+    /**
+     * @return int whether the form should be rather on the top or bottom of
+     * the admin section. The forms are arranged in ascending order of the
+     * priority values. It is required to return a value between 0 and 100.
+     *
+     * E.g.: 70
+     */
+    public function getPriority() {
+        return 0;
+    }
+
+    private function entitiesToArray(array $entities) {
+        return array_map(function (IEntity $entity) {
+            $events = array_map(function(IEntityEvent $entityEvent) {
+                return [
+                    'eventName' => $entityEvent->getEventName(),
+                    'displayName' => $entityEvent->getDisplayName()
+                ];
+            }, $entity->getEvents());
+
+            return [
+                'id' => get_class($entity),
+                'icon' => $entity->getIcon(),
+                'name' => $entity->getName(),
+                'events' => $events,
+            ];
+        }, $entities);
+    }
+
+    private function operatorsToArray(array $operators) {
+        $operators = array_filter($operators, function(IOperation $operator) {
+            return $operator->isAvailableForScope($this->getScope());
+        });
+
+        return array_map(function (IOperation $operator) {
+            return [
+                'id' => get_class($operator),
+                'icon' => $operator->getIcon(),
+                'name' => $operator->getDisplayName(),
+                'description' => $operator->getDescription(),
+                'fixedEntity' => $operator instanceof ISpecificOperation ? $operator->getEntityId() : '',
+                'isComplex' => $operator instanceof IComplexOperation,
+                'triggerHint' => $operator instanceof IComplexOperation ? $operator->getTriggerHint() : '',
+            ];
+        }, $operators);
+    }
+
+    private function checksToArray(array $checks) {
+        $checks = array_filter($checks, function(ICheck $check) {
+            return $check->isAvailableForScope($this->getScope());
+        });
+
+        return array_map(function (ICheck $check) {
+            return [
+                'id' => get_class($check),
+                'supportedEntities' => $check->supportedEntities(),
+            ];
+        }, $checks);
+    }
 }

Please login to merge, or discard this patch.

		@@ -40,156 +40,156 @@
		block discarded – undo
40	40	use Symfony\Component\EventDispatcher\EventDispatcherInterface;
41	41
42	42	abstract class ASettings implements ISettings {
43		- /** @var IL10N */
44		- private $l10n;
45		-
46		- /** @var string */
47		- private $appName;
48		-
49		- /** @var EventDispatcherInterface */
50		- private $eventDispatcher;
51		-
52		- /** @var Manager */
53		- private $manager;
54		-
55		- /** @var IInitialStateService */
56		- private $initialStateService;
57		-
58		- /** @var IConfig */
59		- private $config;
60		-
61		- /**
62		- * @param string $appName
63		- * @param IL10N $l
64		- * @param EventDispatcherInterface $eventDispatcher
65		- * @param Manager $manager
66		- * @param IInitialStateService $initialStateService
67		- * @param IConfig $config
68		- */
69		- public function __construct(
70		- $appName,
71		- IL10N $l,
72		- EventDispatcherInterface $eventDispatcher,
73		- Manager $manager,
74		- IInitialStateService $initialStateService,
75		- IConfig $config
76		- ) {
77		- $this->appName = $appName;
78		- $this->l10n = $l;
79		- $this->eventDispatcher = $eventDispatcher;
80		- $this->manager = $manager;
81		- $this->initialStateService = $initialStateService;
82		- $this->config = $config;
83		- }
84		-
85		- abstract function getScope(): int;
86		-
87		- /**
88		- * @return TemplateResponse
89		- */
90		- public function getForm() {
91		- $this->eventDispatcher->dispatch('OCP\WorkflowEngine::loadAdditionalSettingScripts');
92		-
93		- $entities = $this->manager->getEntitiesList();
94		- $this->initialStateService->provideInitialState(
95		- Application::APP_ID,
96		- 'entities',
97		- $this->entitiesToArray($entities)
98		- );
99		-
100		- $operators = $this->manager->getOperatorList();
101		- $this->initialStateService->provideInitialState(
102		- Application::APP_ID,
103		- 'operators',
104		- $this->operatorsToArray($operators)
105		- );
106		-
107		- $checks = $this->manager->getCheckList();
108		- $this->initialStateService->provideInitialState(
109		- Application::APP_ID,
110		- 'checks',
111		- $this->checksToArray($checks)
112		- );
113		-
114		- $this->initialStateService->provideInitialState(
115		- Application::APP_ID,
116		- 'scope',
117		- $this->getScope()
118		- );
119		-
120		- $this->initialStateService->provideInitialState(
121		- Application::APP_ID,
122		- 'appstoreenabled',
123		- $this->config->getSystemValueBool('appstoreenabled', true)
124		- );
125		-
126		- return new TemplateResponse(Application::APP_ID, 'settings', [], 'blank');
127		- }
128		-
129		- /**
130		- * @return string the section ID, e.g. 'sharing'
131		- */
132		- public function getSection() {
133		- return 'workflow';
134		- }
135		-
136		- /**
137		- * @return int whether the form should be rather on the top or bottom of
138		- * the admin section. The forms are arranged in ascending order of the
139		- * priority values. It is required to return a value between 0 and 100.
140		- *
141		- * E.g.: 70
142		- */
143		- public function getPriority() {
144		- return 0;
145		- }
146		-
147		- private function entitiesToArray(array $entities) {
148		- return array_map(function (IEntity $entity) {
149		- $events = array_map(function(IEntityEvent $entityEvent) {
150		- return [
151		- 'eventName' => $entityEvent->getEventName(),
152		- 'displayName' => $entityEvent->getDisplayName()
153		- ];
154		- }, $entity->getEvents());
155		-
156		- return [
157		- 'id' => get_class($entity),
158		- 'icon' => $entity->getIcon(),
159		- 'name' => $entity->getName(),
160		- 'events' => $events,
161		- ];
162		- }, $entities);
163		- }
164		-
165		- private function operatorsToArray(array $operators) {
166		- $operators = array_filter($operators, function(IOperation $operator) {
167		- return $operator->isAvailableForScope($this->getScope());
168		- });
169		-
170		- return array_map(function (IOperation $operator) {
171		- return [
172		- 'id' => get_class($operator),
173		- 'icon' => $operator->getIcon(),
174		- 'name' => $operator->getDisplayName(),
175		- 'description' => $operator->getDescription(),
176		- 'fixedEntity' => $operator instanceof ISpecificOperation ? $operator->getEntityId() : '',
177		- 'isComplex' => $operator instanceof IComplexOperation,
178		- 'triggerHint' => $operator instanceof IComplexOperation ? $operator->getTriggerHint() : '',
179		- ];
180		- }, $operators);
181		- }
182		-
183		- private function checksToArray(array $checks) {
184		- $checks = array_filter($checks, function(ICheck $check) {
185		- return $check->isAvailableForScope($this->getScope());
186		- });
187		-
188		- return array_map(function (ICheck $check) {
189		- return [
190		- 'id' => get_class($check),
191		- 'supportedEntities' => $check->supportedEntities(),
192		- ];
193		- }, $checks);
194		- }
	43	+ /** @var IL10N */
	44	+ private $l10n;
	45	+
	46	+ /** @var string */
	47	+ private $appName;
	48	+
	49	+ /** @var EventDispatcherInterface */
	50	+ private $eventDispatcher;
	51	+
	52	+ /** @var Manager */
	53	+ private $manager;
	54	+
	55	+ /** @var IInitialStateService */
	56	+ private $initialStateService;
	57	+
	58	+ /** @var IConfig */
	59	+ private $config;
	60	+
	61	+ /**
	62	+ * @param string $appName
	63	+ * @param IL10N $l
	64	+ * @param EventDispatcherInterface $eventDispatcher
	65	+ * @param Manager $manager
	66	+ * @param IInitialStateService $initialStateService
	67	+ * @param IConfig $config
	68	+ */
	69	+ public function __construct(
	70	+ $appName,
	71	+ IL10N $l,
	72	+ EventDispatcherInterface $eventDispatcher,
	73	+ Manager $manager,
	74	+ IInitialStateService $initialStateService,
	75	+ IConfig $config
	76	+ ) {
	77	+ $this->appName = $appName;
	78	+ $this->l10n = $l;
	79	+ $this->eventDispatcher = $eventDispatcher;
	80	+ $this->manager = $manager;
	81	+ $this->initialStateService = $initialStateService;
	82	+ $this->config = $config;
	83	+ }
	84	+
	85	+ abstract function getScope(): int;
	86	+
	87	+ /**
	88	+ * @return TemplateResponse
	89	+ */
	90	+ public function getForm() {
	91	+ $this->eventDispatcher->dispatch('OCP\WorkflowEngine::loadAdditionalSettingScripts');
	92	+
	93	+ $entities = $this->manager->getEntitiesList();
	94	+ $this->initialStateService->provideInitialState(
	95	+ Application::APP_ID,
	96	+ 'entities',
	97	+ $this->entitiesToArray($entities)
	98	+ );
	99	+
	100	+ $operators = $this->manager->getOperatorList();
	101	+ $this->initialStateService->provideInitialState(
	102	+ Application::APP_ID,
	103	+ 'operators',
	104	+ $this->operatorsToArray($operators)
	105	+ );
	106	+
	107	+ $checks = $this->manager->getCheckList();
	108	+ $this->initialStateService->provideInitialState(
	109	+ Application::APP_ID,
	110	+ 'checks',
	111	+ $this->checksToArray($checks)
	112	+ );
	113	+
	114	+ $this->initialStateService->provideInitialState(
	115	+ Application::APP_ID,
	116	+ 'scope',
	117	+ $this->getScope()
	118	+ );
	119	+
	120	+ $this->initialStateService->provideInitialState(
	121	+ Application::APP_ID,
	122	+ 'appstoreenabled',
	123	+ $this->config->getSystemValueBool('appstoreenabled', true)
	124	+ );
	125	+
	126	+ return new TemplateResponse(Application::APP_ID, 'settings', [], 'blank');
	127	+ }
	128	+
	129	+ /**
	130	+ * @return string the section ID, e.g. 'sharing'
	131	+ */
	132	+ public function getSection() {
	133	+ return 'workflow';
	134	+ }
	135	+
	136	+ /**
	137	+ * @return int whether the form should be rather on the top or bottom of
	138	+ * the admin section. The forms are arranged in ascending order of the
	139	+ * priority values. It is required to return a value between 0 and 100.
	140	+ *
	141	+ * E.g.: 70
	142	+ */
	143	+ public function getPriority() {
	144	+ return 0;
	145	+ }
	146	+
	147	+ private function entitiesToArray(array $entities) {
	148	+ return array_map(function (IEntity $entity) {
	149	+ $events = array_map(function(IEntityEvent $entityEvent) {
	150	+ return [
	151	+ 'eventName' => $entityEvent->getEventName(),
	152	+ 'displayName' => $entityEvent->getDisplayName()
	153	+ ];
	154	+ }, $entity->getEvents());
	155	+
	156	+ return [
	157	+ 'id' => get_class($entity),
	158	+ 'icon' => $entity->getIcon(),
	159	+ 'name' => $entity->getName(),
	160	+ 'events' => $events,
	161	+ ];
	162	+ }, $entities);
	163	+ }
	164	+
	165	+ private function operatorsToArray(array $operators) {
	166	+ $operators = array_filter($operators, function(IOperation $operator) {
	167	+ return $operator->isAvailableForScope($this->getScope());
	168	+ });
	169	+
	170	+ return array_map(function (IOperation $operator) {
	171	+ return [
	172	+ 'id' => get_class($operator),
	173	+ 'icon' => $operator->getIcon(),
	174	+ 'name' => $operator->getDisplayName(),
	175	+ 'description' => $operator->getDescription(),
	176	+ 'fixedEntity' => $operator instanceof ISpecificOperation ? $operator->getEntityId() : '',
	177	+ 'isComplex' => $operator instanceof IComplexOperation,
	178	+ 'triggerHint' => $operator instanceof IComplexOperation ? $operator->getTriggerHint() : '',
	179	+ ];
	180	+ }, $operators);
	181	+ }
	182	+
	183	+ private function checksToArray(array $checks) {
	184	+ $checks = array_filter($checks, function(ICheck $check) {
	185	+ return $check->isAvailableForScope($this->getScope());
	186	+ });
	187	+
	188	+ return array_map(function (ICheck $check) {
	189	+ return [
	190	+ 'id' => get_class($check),
	191	+ 'supportedEntities' => $check->supportedEntities(),
	192	+ ];
	193	+ }, $checks);
	194	+ }
195	195	}

nextcloud / server

Push — master ( 48bdd3...b53a48 )

Status

Category

Indentation +152 added lines, -152 removed lines patch added patch discarded remove patch