nextcloud / server

apps/settings/lib/Controller/AppSettingsController.php

Indentation +625 added lines, -625 removed lines

@@ -53,629 +53,629 @@
 #[OpenAPI(scope: OpenAPI::SCOPE_IGNORE)]
 class AppSettingsController extends Controller {
 
-	/** @var array */
-	private $allApps = [];
-
-	private IAppData $appData;
-
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		IAppDataFactory $appDataFactory,
-		private IL10N $l10n,
-		private IConfig $config,
-		private INavigationManager $navigationManager,
-		private AppManager $appManager,
-		private CategoryFetcher $categoryFetcher,
-		private AppFetcher $appFetcher,
-		private IFactory $l10nFactory,
-		private BundleFetcher $bundleFetcher,
-		private Installer $installer,
-		private IURLGenerator $urlGenerator,
-		private LoggerInterface $logger,
-		private IInitialState $initialState,
-		private AppDiscoverFetcher $discoverFetcher,
-		private IClientService $clientService,
-	) {
-		parent::__construct($appName, $request);
-		$this->appData = $appDataFactory->get('appstore');
-	}
-
-	/**
-	 * @psalm-suppress UndefinedClass AppAPI is shipped since 30.0.1
-	 *
-	 * @return TemplateResponse
-	 */
-	#[NoCSRFRequired]
-	public function viewApps(): TemplateResponse {
-		$this->navigationManager->setActiveEntry('core_apps');
-
-		$this->initialState->provideInitialState('appstoreEnabled', $this->config->getSystemValueBool('appstoreenabled', true));
-		$this->initialState->provideInitialState('appstoreBundles', $this->getBundles());
-		$this->initialState->provideInitialState('appstoreUpdateCount', count($this->getAppsWithUpdates()));
-
-		if ($this->appManager->isEnabledForAnyone('app_api')) {
-			try {
-				Server::get(ExAppsPageService::class)->provideAppApiState($this->initialState);
-			} catch (\Psr\Container\NotFoundExceptionInterface|\Psr\Container\ContainerExceptionInterface $e) {
-			}
-		}
-
-		$policy = new ContentSecurityPolicy();
-		$policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
-
-		$templateResponse = new TemplateResponse('settings', 'settings/empty', ['pageTitle' => $this->l10n->t('Settings')]);
-		$templateResponse->setContentSecurityPolicy($policy);
-
-		Util::addStyle('settings', 'settings');
-		Util::addScript('settings', 'vue-settings-apps-users-management');
-
-		return $templateResponse;
-	}
-
-	/**
-	 * Get all active entries for the app discover section
-	 */
-	#[NoCSRFRequired]
-	public function getAppDiscoverJSON(): JSONResponse {
-		$data = $this->discoverFetcher->get(true);
-		return new JSONResponse(array_values($data));
-	}
-
-	/**
-	 * Get a image for the app discover section - this is proxied for privacy and CSP reasons
-	 *
-	 * @param string $image
-	 * @throws \Exception
-	 */
-	#[NoCSRFRequired]
-	public function getAppDiscoverMedia(string $fileName, ILimiter $limiter, IUserSession $session): Response {
-		$getEtag = $this->discoverFetcher->getETag() ?? date('Y-m');
-		$etag = trim($getEtag, '"');
-
-		$folder = null;
-		try {
-			$folder = $this->appData->getFolder('app-discover-cache');
-			$this->cleanUpImageCache($folder, $etag);
-		} catch (\Throwable $e) {
-			$folder = $this->appData->newFolder('app-discover-cache');
-		}
-
-		// Get the current cache folder
-		try {
-			$folder = $folder->getFolder($etag);
-		} catch (NotFoundException $e) {
-			$folder = $folder->newFolder($etag);
-		}
-
-		$info = pathinfo($fileName);
-		$hashName = md5($fileName);
-		$allFiles = $folder->getDirectoryListing();
-		// Try to find the file
-		$file = array_filter($allFiles, function (ISimpleFile $file) use ($hashName) {
-			return str_starts_with($file->getName(), $hashName);
-		});
-		// Get the first entry
-		$file = reset($file);
-		// If not found request from Web
-		if ($file === false) {
-			$user = $session->getUser();
-			// this route is not public thus we can assume a user is logged-in
-			assert($user !== null);
-			// Register a user request to throttle fetching external data
-			// this will prevent using the server for DoS of other systems.
-			$limiter->registerUserRequest(
-				'settings-discover-media',
-				// allow up to 24 media requests per hour
-				// this should be a sane default when a completely new section is loaded
-				// keep in mind browsers request all files from a source-set
-				24,
-				60 * 60,
-				$user,
-			);
-
-			if (!$this->checkCanDownloadMedia($fileName)) {
-				$this->logger->warning('Tried to load media files for app discover section from untrusted source');
-				return new NotFoundResponse(Http::STATUS_BAD_REQUEST);
-			}
-
-			try {
-				$client = $this->clientService->newClient();
-				$fileResponse = $client->get($fileName);
-				$contentType = $fileResponse->getHeader('Content-Type');
-				$extension = $info['extension'] ?? '';
-				$file = $folder->newFile($hashName . '.' . base64_encode($contentType) . '.' . $extension, $fileResponse->getBody());
-			} catch (\Throwable $e) {
-				$this->logger->warning('Could not load media file for app discover section', ['media_src' => $fileName, 'exception' => $e]);
-				return new NotFoundResponse();
-			}
-		} else {
-			// File was found so we can get the content type from the file name
-			$contentType = base64_decode(explode('.', $file->getName())[1] ?? '');
-		}
-
-		$response = new FileDisplayResponse($file, Http::STATUS_OK, ['Content-Type' => $contentType]);
-		// cache for 7 days
-		$response->cacheFor(604800, false, true);
-		return $response;
-	}
-
-	private function checkCanDownloadMedia(string $filename): bool {
-		$urlInfo = parse_url($filename);
-		if (!isset($urlInfo['host']) || !isset($urlInfo['path'])) {
-			return false;
-		}
-
-		// Always allowed hosts
-		if ($urlInfo['host'] === 'nextcloud.com') {
-			return true;
-		}
-
-		// Hosts that need further verification
-		// Github is only allowed if from our organization
-		$ALLOWED_HOSTS = ['github.com', 'raw.githubusercontent.com'];
-		if (!in_array($urlInfo['host'], $ALLOWED_HOSTS)) {
-			return false;
-		}
-
-		if (str_starts_with($urlInfo['path'], '/nextcloud/') || str_starts_with($urlInfo['path'], '/nextcloud-gmbh/')) {
-			return true;
-		}
-
-		return false;
-	}
-
-	/**
-	 * Remove orphaned folders from the image cache that do not match the current etag
-	 * @param ISimpleFolder $folder The folder to clear
-	 * @param string $etag The etag (directory name) to keep
-	 */
-	private function cleanUpImageCache(ISimpleFolder $folder, string $etag): void {
-		// Cleanup old cache folders
-		$allFiles = $folder->getDirectoryListing();
-		foreach ($allFiles as $dir) {
-			try {
-				if ($dir->getName() !== $etag) {
-					$dir->delete();
-				}
-			} catch (NotPermittedException $e) {
-				// ignore folder for now
-			}
-		}
-	}
-
-	private function getAppsWithUpdates() {
-		$appClass = new \OC_App();
-		$apps = $appClass->listAllApps();
-		foreach ($apps as $key => $app) {
-			$newVersion = $this->installer->isUpdateAvailable($app['id']);
-			if ($newVersion === false) {
-				unset($apps[$key]);
-			}
-		}
-		return $apps;
-	}
-
-	private function getBundles() {
-		$result = [];
-		$bundles = $this->bundleFetcher->getBundles();
-		foreach ($bundles as $bundle) {
-			$result[] = [
-				'name' => $bundle->getName(),
-				'id' => $bundle->getIdentifier(),
-				'appIdentifiers' => $bundle->getAppIdentifiers()
-			];
-		}
-		return $result;
-	}
-
-	/**
-	 * Get all available categories
-	 *
-	 * @return JSONResponse
-	 */
-	public function listCategories(): JSONResponse {
-		return new JSONResponse($this->getAllCategories());
-	}
-
-	private function getAllCategories() {
-		$currentLanguage = substr($this->l10nFactory->findLanguage(), 0, 2);
-
-		$categories = $this->categoryFetcher->get();
-		return array_map(fn ($category) => [
-			'id' => $category['id'],
-			'displayName' => $category['translations'][$currentLanguage]['name'] ?? $category['translations']['en']['name'],
-		], $categories);
-	}
-
-	/**
-	 * Convert URL to proxied URL so CSP is no problem
-	 */
-	private function createProxyPreviewUrl(string $url): string {
-		if ($url === '') {
-			return '';
-		}
-		return 'https://usercontent.apps.nextcloud.com/' . base64_encode($url);
-	}
-
-	private function fetchApps() {
-		$appClass = new \OC_App();
-		$apps = $appClass->listAllApps();
-		foreach ($apps as $app) {
-			$app['installed'] = true;
-
-			if (isset($app['screenshot'][0])) {
-				$appScreenshot = $app['screenshot'][0] ?? null;
-				if (is_array($appScreenshot)) {
-					// Screenshot with thumbnail
-					$appScreenshot = $appScreenshot['@value'];
-				}
-
-				$app['screenshot'] = $this->createProxyPreviewUrl($appScreenshot);
-			}
-			$this->allApps[$app['id']] = $app;
-		}
-
-		$apps = $this->getAppsForCategory('');
-		$supportedApps = $appClass->getSupportedApps();
-		foreach ($apps as $app) {
-			$app['appstore'] = true;
-			if (!array_key_exists($app['id'], $this->allApps)) {
-				$this->allApps[$app['id']] = $app;
-			} else {
-				$this->allApps[$app['id']] = array_merge($app, $this->allApps[$app['id']]);
-			}
-
-			if (in_array($app['id'], $supportedApps)) {
-				$this->allApps[$app['id']]['level'] = \OC_App::supportedApp;
-			}
-		}
-
-		// add bundle information
-		$bundles = $this->bundleFetcher->getBundles();
-		foreach ($bundles as $bundle) {
-			foreach ($bundle->getAppIdentifiers() as $identifier) {
-				foreach ($this->allApps as &$app) {
-					if ($app['id'] === $identifier) {
-						$app['bundleIds'][] = $bundle->getIdentifier();
-						continue;
-					}
-				}
-			}
-		}
-	}
-
-	private function getAllApps() {
-		return $this->allApps;
-	}
-
-	/**
-	 * Get all available apps in a category
-	 *
-	 * @return JSONResponse
-	 * @throws \Exception
-	 */
-	public function listApps(): JSONResponse {
-		$this->fetchApps();
-		$apps = $this->getAllApps();
-
-		$dependencyAnalyzer = Server::get(DependencyAnalyzer::class);
-
-		$ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
-		if (!is_array($ignoreMaxApps)) {
-			$this->logger->warning('The value given for app_install_overwrite is not an array. Ignoring...');
-			$ignoreMaxApps = [];
-		}
-
-		// Extend existing app details
-		$apps = array_map(function (array $appData) use ($dependencyAnalyzer, $ignoreMaxApps) {
-			if (isset($appData['appstoreData'])) {
-				$appstoreData = $appData['appstoreData'];
-				$appData['screenshot'] = $this->createProxyPreviewUrl($appstoreData['screenshots'][0]['url'] ?? '');
-				$appData['category'] = $appstoreData['categories'];
-				$appData['releases'] = $appstoreData['releases'];
-			}
-
-			$newVersion = $this->installer->isUpdateAvailable($appData['id']);
-			if ($newVersion) {
-				$appData['update'] = $newVersion;
-			}
-
-			// fix groups to be an array
-			$groups = [];
-			if (is_string($appData['groups'])) {
-				$groups = json_decode($appData['groups']);
-				// ensure 'groups' is an array
-				if (!is_array($groups)) {
-					$groups = [$groups];
-				}
-			}
-			$appData['groups'] = $groups;
-			$appData['canUnInstall'] = !$appData['active'] && $appData['removable'];
-
-			// fix licence vs license
-			if (isset($appData['license']) && !isset($appData['licence'])) {
-				$appData['licence'] = $appData['license'];
-			}
-
-			$ignoreMax = in_array($appData['id'], $ignoreMaxApps);
-
-			// analyse dependencies
-			$missing = $dependencyAnalyzer->analyze($appData, $ignoreMax);
-			$appData['canInstall'] = empty($missing);
-			$appData['missingDependencies'] = $missing;
-
-			$appData['missingMinOwnCloudVersion'] = !isset($appData['dependencies']['nextcloud']['@attributes']['min-version']);
-			$appData['missingMaxOwnCloudVersion'] = !isset($appData['dependencies']['nextcloud']['@attributes']['max-version']);
-			$appData['isCompatible'] = $dependencyAnalyzer->isMarkedCompatible($appData);
-
-			return $appData;
-		}, $apps);
-
-		usort($apps, [$this, 'sortApps']);
-
-		return new JSONResponse(['apps' => $apps, 'status' => 'success']);
-	}
-
-	/**
-	 * Get all apps for a category from the app store
-	 *
-	 * @param string $requestedCategory
-	 * @return array
-	 * @throws \Exception
-	 */
-	private function getAppsForCategory($requestedCategory = ''): array {
-		$versionParser = new VersionParser();
-		$formattedApps = [];
-		$apps = $this->appFetcher->get();
-		foreach ($apps as $app) {
-			// Skip all apps not in the requested category
-			if ($requestedCategory !== '') {
-				$isInCategory = false;
-				foreach ($app['categories'] as $category) {
-					if ($category === $requestedCategory) {
-						$isInCategory = true;
-					}
-				}
-				if (!$isInCategory) {
-					continue;
-				}
-			}
-
-			if (!isset($app['releases'][0]['rawPlatformVersionSpec'])) {
-				continue;
-			}
-			$nextCloudVersion = $versionParser->getVersion($app['releases'][0]['rawPlatformVersionSpec']);
-			$nextCloudVersionDependencies = [];
-			if ($nextCloudVersion->getMinimumVersion() !== '') {
-				$nextCloudVersionDependencies['nextcloud']['@attributes']['min-version'] = $nextCloudVersion->getMinimumVersion();
-			}
-			if ($nextCloudVersion->getMaximumVersion() !== '') {
-				$nextCloudVersionDependencies['nextcloud']['@attributes']['max-version'] = $nextCloudVersion->getMaximumVersion();
-			}
-			$phpVersion = $versionParser->getVersion($app['releases'][0]['rawPhpVersionSpec']);
-
-			try {
-				$this->appManager->getAppPath($app['id']);
-				$existsLocally = true;
-			} catch (AppPathNotFoundException) {
-				$existsLocally = false;
-			}
-
-			$phpDependencies = [];
-			if ($phpVersion->getMinimumVersion() !== '') {
-				$phpDependencies['php']['@attributes']['min-version'] = $phpVersion->getMinimumVersion();
-			}
-			if ($phpVersion->getMaximumVersion() !== '') {
-				$phpDependencies['php']['@attributes']['max-version'] = $phpVersion->getMaximumVersion();
-			}
-			if (isset($app['releases'][0]['minIntSize'])) {
-				$phpDependencies['php']['@attributes']['min-int-size'] = $app['releases'][0]['minIntSize'];
-			}
-			$authors = '';
-			foreach ($app['authors'] as $key => $author) {
-				$authors .= $author['name'];
-				if ($key !== count($app['authors']) - 1) {
-					$authors .= ', ';
-				}
-			}
-
-			$currentLanguage = substr($this->l10nFactory->findLanguage(), 0, 2);
-			$enabledValue = $this->config->getAppValue($app['id'], 'enabled', 'no');
-			$groups = null;
-			if ($enabledValue !== 'no' && $enabledValue !== 'yes') {
-				$groups = $enabledValue;
-			}
-
-			$currentVersion = '';
-			if ($this->appManager->isEnabledForAnyone($app['id'])) {
-				$currentVersion = $this->appManager->getAppVersion($app['id']);
-			} else {
-				$currentVersion = $app['releases'][0]['version'];
-			}
-
-			$formattedApps[] = [
-				'id' => $app['id'],
-				'app_api' => false,
-				'name' => $app['translations'][$currentLanguage]['name'] ?? $app['translations']['en']['name'],
-				'description' => $app['translations'][$currentLanguage]['description'] ?? $app['translations']['en']['description'],
-				'summary' => $app['translations'][$currentLanguage]['summary'] ?? $app['translations']['en']['summary'],
-				'license' => $app['releases'][0]['licenses'],
-				'author' => $authors,
-				'shipped' => $this->appManager->isShipped($app['id']),
-				'version' => $currentVersion,
-				'default_enable' => '',
-				'types' => [],
-				'documentation' => [
-					'admin' => $app['adminDocs'],
-					'user' => $app['userDocs'],
-					'developer' => $app['developerDocs']
-				],
-				'website' => $app['website'],
-				'bugs' => $app['issueTracker'],
-				'detailpage' => $app['website'],
-				'dependencies' => array_merge(
-					$nextCloudVersionDependencies,
-					$phpDependencies
-				),
-				'level' => ($app['isFeatured'] === true) ? 200 : 100,
-				'missingMaxOwnCloudVersion' => false,
-				'missingMinOwnCloudVersion' => false,
-				'canInstall' => true,
-				'screenshot' => isset($app['screenshots'][0]['url']) ? 'https://usercontent.apps.nextcloud.com/' . base64_encode($app['screenshots'][0]['url']) : '',
-				'score' => $app['ratingOverall'],
-				'ratingNumOverall' => $app['ratingNumOverall'],
-				'ratingNumThresholdReached' => $app['ratingNumOverall'] > 5,
-				'removable' => $existsLocally,
-				'active' => $this->appManager->isEnabledForUser($app['id']),
-				'needsDownload' => !$existsLocally,
-				'groups' => $groups,
-				'fromAppStore' => true,
-				'appstoreData' => $app,
-			];
-		}
-
-		return $formattedApps;
-	}
-
-	/**
-	 * @param string $appId
-	 * @param array $groups
-	 * @return JSONResponse
-	 */
-	#[PasswordConfirmationRequired]
-	public function enableApp(string $appId, array $groups = []): JSONResponse {
-		return $this->enableApps([$appId], $groups);
-	}
-
-	/**
-	 * Enable one or more apps
-	 *
-	 * apps will be enabled for specific groups only if $groups is defined
-	 *
-	 * @param array $appIds
-	 * @param array $groups
-	 * @return JSONResponse
-	 */
-	#[PasswordConfirmationRequired]
-	public function enableApps(array $appIds, array $groups = []): JSONResponse {
-		try {
-			$updateRequired = false;
-
-			foreach ($appIds as $appId) {
-				$appId = $this->appManager->cleanAppId($appId);
-
-				// Check if app is already downloaded
-				if (!$this->installer->isDownloaded($appId)) {
-					$this->installer->downloadApp($appId);
-				}
-
-				$this->installer->installApp($appId);
-
-				if (count($groups) > 0) {
-					$this->appManager->enableAppForGroups($appId, $this->getGroupList($groups));
-				} else {
-					$this->appManager->enableApp($appId);
-				}
-				$updateRequired = $updateRequired || $this->appManager->isUpgradeRequired($appId);
-			}
-			return new JSONResponse(['data' => ['update_required' => $updateRequired]]);
-		} catch (\Throwable $e) {
-			$this->logger->error('could not enable apps', ['exception' => $e]);
-			return new JSONResponse(['data' => ['message' => $e->getMessage()]], Http::STATUS_INTERNAL_SERVER_ERROR);
-		}
-	}
-
-	private function getGroupList(array $groups) {
-		$groupManager = Server::get(IGroupManager::class);
-		$groupsList = [];
-		foreach ($groups as $group) {
-			$groupItem = $groupManager->get($group);
-			if ($groupItem instanceof IGroup) {
-				$groupsList[] = $groupManager->get($group);
-			}
-		}
-		return $groupsList;
-	}
-
-	/**
-	 * @param string $appId
-	 * @return JSONResponse
-	 */
-	#[PasswordConfirmationRequired]
-	public function disableApp(string $appId): JSONResponse {
-		return $this->disableApps([$appId]);
-	}
-
-	/**
-	 * @param array $appIds
-	 * @return JSONResponse
-	 */
-	#[PasswordConfirmationRequired]
-	public function disableApps(array $appIds): JSONResponse {
-		try {
-			foreach ($appIds as $appId) {
-				$appId = $this->appManager->cleanAppId($appId);
-				$this->appManager->disableApp($appId);
-			}
-			return new JSONResponse([]);
-		} catch (\Exception $e) {
-			$this->logger->error('could not disable app', ['exception' => $e]);
-			return new JSONResponse(['data' => ['message' => $e->getMessage()]], Http::STATUS_INTERNAL_SERVER_ERROR);
-		}
-	}
-
-	/**
-	 * @param string $appId
-	 * @return JSONResponse
-	 */
-	#[PasswordConfirmationRequired]
-	public function uninstallApp(string $appId): JSONResponse {
-		$appId = $this->appManager->cleanAppId($appId);
-		$result = $this->installer->removeApp($appId);
-		if ($result !== false) {
-			// If this app was force enabled, remove the force-enabled-state
-			$this->appManager->removeOverwriteNextcloudRequirement($appId);
-			$this->appManager->clearAppsCache();
-			return new JSONResponse(['data' => ['appid' => $appId]]);
-		}
-		return new JSONResponse(['data' => ['message' => $this->l10n->t('Could not remove app.')]], Http::STATUS_INTERNAL_SERVER_ERROR);
-	}
-
-	/**
-	 * @param string $appId
-	 * @return JSONResponse
-	 */
-	public function updateApp(string $appId): JSONResponse {
-		$appId = $this->appManager->cleanAppId($appId);
-
-		$this->config->setSystemValue('maintenance', true);
-		try {
-			$result = $this->installer->updateAppstoreApp($appId);
-			$this->config->setSystemValue('maintenance', false);
-		} catch (\Exception $ex) {
-			$this->config->setSystemValue('maintenance', false);
-			return new JSONResponse(['data' => ['message' => $ex->getMessage()]], Http::STATUS_INTERNAL_SERVER_ERROR);
-		}
-
-		if ($result !== false) {
-			return new JSONResponse(['data' => ['appid' => $appId]]);
-		}
-		return new JSONResponse(['data' => ['message' => $this->l10n->t('Could not update app.')]], Http::STATUS_INTERNAL_SERVER_ERROR);
-	}
-
-	private function sortApps($a, $b) {
-		$a = (string)$a['name'];
-		$b = (string)$b['name'];
-		if ($a === $b) {
-			return 0;
-		}
-		return ($a < $b) ? -1 : 1;
-	}
-
-	public function force(string $appId): JSONResponse {
-		$appId = $this->appManager->cleanAppId($appId);
-		$this->appManager->overwriteNextcloudRequirement($appId);
-		return new JSONResponse();
-	}
+    /** @var array */
+    private $allApps = [];
+
+    private IAppData $appData;
+
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        IAppDataFactory $appDataFactory,
+        private IL10N $l10n,
+        private IConfig $config,
+        private INavigationManager $navigationManager,
+        private AppManager $appManager,
+        private CategoryFetcher $categoryFetcher,
+        private AppFetcher $appFetcher,
+        private IFactory $l10nFactory,
+        private BundleFetcher $bundleFetcher,
+        private Installer $installer,
+        private IURLGenerator $urlGenerator,
+        private LoggerInterface $logger,
+        private IInitialState $initialState,
+        private AppDiscoverFetcher $discoverFetcher,
+        private IClientService $clientService,
+    ) {
+        parent::__construct($appName, $request);
+        $this->appData = $appDataFactory->get('appstore');
+    }
+
+    /**
+     * @psalm-suppress UndefinedClass AppAPI is shipped since 30.0.1
+     *
+     * @return TemplateResponse
+     */
+    #[NoCSRFRequired]
+    public function viewApps(): TemplateResponse {
+        $this->navigationManager->setActiveEntry('core_apps');
+
+        $this->initialState->provideInitialState('appstoreEnabled', $this->config->getSystemValueBool('appstoreenabled', true));
+        $this->initialState->provideInitialState('appstoreBundles', $this->getBundles());
+        $this->initialState->provideInitialState('appstoreUpdateCount', count($this->getAppsWithUpdates()));
+
+        if ($this->appManager->isEnabledForAnyone('app_api')) {
+            try {
+                Server::get(ExAppsPageService::class)->provideAppApiState($this->initialState);
+            } catch (\Psr\Container\NotFoundExceptionInterface|\Psr\Container\ContainerExceptionInterface $e) {
+            }
+        }
+
+        $policy = new ContentSecurityPolicy();
+        $policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
+
+        $templateResponse = new TemplateResponse('settings', 'settings/empty', ['pageTitle' => $this->l10n->t('Settings')]);
+        $templateResponse->setContentSecurityPolicy($policy);
+
+        Util::addStyle('settings', 'settings');
+        Util::addScript('settings', 'vue-settings-apps-users-management');
+
+        return $templateResponse;
+    }
+
+    /**
+     * Get all active entries for the app discover section
+     */
+    #[NoCSRFRequired]
+    public function getAppDiscoverJSON(): JSONResponse {
+        $data = $this->discoverFetcher->get(true);
+        return new JSONResponse(array_values($data));
+    }
+
+    /**
+     * Get a image for the app discover section - this is proxied for privacy and CSP reasons
+     *
+     * @param string $image
+     * @throws \Exception
+     */
+    #[NoCSRFRequired]
+    public function getAppDiscoverMedia(string $fileName, ILimiter $limiter, IUserSession $session): Response {
+        $getEtag = $this->discoverFetcher->getETag() ?? date('Y-m');
+        $etag = trim($getEtag, '"');
+
+        $folder = null;
+        try {
+            $folder = $this->appData->getFolder('app-discover-cache');
+            $this->cleanUpImageCache($folder, $etag);
+        } catch (\Throwable $e) {
+            $folder = $this->appData->newFolder('app-discover-cache');
+        }
+
+        // Get the current cache folder
+        try {
+            $folder = $folder->getFolder($etag);
+        } catch (NotFoundException $e) {
+            $folder = $folder->newFolder($etag);
+        }
+
+        $info = pathinfo($fileName);
+        $hashName = md5($fileName);
+        $allFiles = $folder->getDirectoryListing();
+        // Try to find the file
+        $file = array_filter($allFiles, function (ISimpleFile $file) use ($hashName) {
+            return str_starts_with($file->getName(), $hashName);
+        });
+        // Get the first entry
+        $file = reset($file);
+        // If not found request from Web
+        if ($file === false) {
+            $user = $session->getUser();
+            // this route is not public thus we can assume a user is logged-in
+            assert($user !== null);
+            // Register a user request to throttle fetching external data
+            // this will prevent using the server for DoS of other systems.
+            $limiter->registerUserRequest(
+                'settings-discover-media',
+                // allow up to 24 media requests per hour
+                // this should be a sane default when a completely new section is loaded
+                // keep in mind browsers request all files from a source-set
+                24,
+                60 * 60,
+                $user,
+            );
+
+            if (!$this->checkCanDownloadMedia($fileName)) {
+                $this->logger->warning('Tried to load media files for app discover section from untrusted source');
+                return new NotFoundResponse(Http::STATUS_BAD_REQUEST);
+            }
+
+            try {
+                $client = $this->clientService->newClient();
+                $fileResponse = $client->get($fileName);
+                $contentType = $fileResponse->getHeader('Content-Type');
+                $extension = $info['extension'] ?? '';
+                $file = $folder->newFile($hashName . '.' . base64_encode($contentType) . '.' . $extension, $fileResponse->getBody());
+            } catch (\Throwable $e) {
+                $this->logger->warning('Could not load media file for app discover section', ['media_src' => $fileName, 'exception' => $e]);
+                return new NotFoundResponse();
+            }
+        } else {
+            // File was found so we can get the content type from the file name
+            $contentType = base64_decode(explode('.', $file->getName())[1] ?? '');
+        }
+
+        $response = new FileDisplayResponse($file, Http::STATUS_OK, ['Content-Type' => $contentType]);
+        // cache for 7 days
+        $response->cacheFor(604800, false, true);
+        return $response;
+    }
+
+    private function checkCanDownloadMedia(string $filename): bool {
+        $urlInfo = parse_url($filename);
+        if (!isset($urlInfo['host']) || !isset($urlInfo['path'])) {
+            return false;
+        }
+
+        // Always allowed hosts
+        if ($urlInfo['host'] === 'nextcloud.com') {
+            return true;
+        }
+
+        // Hosts that need further verification
+        // Github is only allowed if from our organization
+        $ALLOWED_HOSTS = ['github.com', 'raw.githubusercontent.com'];
+        if (!in_array($urlInfo['host'], $ALLOWED_HOSTS)) {
+            return false;
+        }
+
+        if (str_starts_with($urlInfo['path'], '/nextcloud/') || str_starts_with($urlInfo['path'], '/nextcloud-gmbh/')) {
+            return true;
+        }
+
+        return false;
+    }
+
+    /**
+     * Remove orphaned folders from the image cache that do not match the current etag
+     * @param ISimpleFolder $folder The folder to clear
+     * @param string $etag The etag (directory name) to keep
+     */
+    private function cleanUpImageCache(ISimpleFolder $folder, string $etag): void {
+        // Cleanup old cache folders
+        $allFiles = $folder->getDirectoryListing();
+        foreach ($allFiles as $dir) {
+            try {
+                if ($dir->getName() !== $etag) {
+                    $dir->delete();
+                }
+            } catch (NotPermittedException $e) {
+                // ignore folder for now
+            }
+        }
+    }
+
+    private function getAppsWithUpdates() {
+        $appClass = new \OC_App();
+        $apps = $appClass->listAllApps();
+        foreach ($apps as $key => $app) {
+            $newVersion = $this->installer->isUpdateAvailable($app['id']);
+            if ($newVersion === false) {
+                unset($apps[$key]);
+            }
+        }
+        return $apps;
+    }
+
+    private function getBundles() {
+        $result = [];
+        $bundles = $this->bundleFetcher->getBundles();
+        foreach ($bundles as $bundle) {
+            $result[] = [
+                'name' => $bundle->getName(),
+                'id' => $bundle->getIdentifier(),
+                'appIdentifiers' => $bundle->getAppIdentifiers()
+            ];
+        }
+        return $result;
+    }
+
+    /**
+     * Get all available categories
+     *
+     * @return JSONResponse
+     */
+    public function listCategories(): JSONResponse {
+        return new JSONResponse($this->getAllCategories());
+    }
+
+    private function getAllCategories() {
+        $currentLanguage = substr($this->l10nFactory->findLanguage(), 0, 2);
+
+        $categories = $this->categoryFetcher->get();
+        return array_map(fn ($category) => [
+            'id' => $category['id'],
+            'displayName' => $category['translations'][$currentLanguage]['name'] ?? $category['translations']['en']['name'],
+        ], $categories);
+    }
+
+    /**
+     * Convert URL to proxied URL so CSP is no problem
+     */
+    private function createProxyPreviewUrl(string $url): string {
+        if ($url === '') {
+            return '';
+        }
+        return 'https://usercontent.apps.nextcloud.com/' . base64_encode($url);
+    }
+
+    private function fetchApps() {
+        $appClass = new \OC_App();
+        $apps = $appClass->listAllApps();
+        foreach ($apps as $app) {
+            $app['installed'] = true;
+
+            if (isset($app['screenshot'][0])) {
+                $appScreenshot = $app['screenshot'][0] ?? null;
+                if (is_array($appScreenshot)) {
+                    // Screenshot with thumbnail
+                    $appScreenshot = $appScreenshot['@value'];
+                }
+
+                $app['screenshot'] = $this->createProxyPreviewUrl($appScreenshot);
+            }
+            $this->allApps[$app['id']] = $app;
+        }
+
+        $apps = $this->getAppsForCategory('');
+        $supportedApps = $appClass->getSupportedApps();
+        foreach ($apps as $app) {
+            $app['appstore'] = true;
+            if (!array_key_exists($app['id'], $this->allApps)) {
+                $this->allApps[$app['id']] = $app;
+            } else {
+                $this->allApps[$app['id']] = array_merge($app, $this->allApps[$app['id']]);
+            }
+
+            if (in_array($app['id'], $supportedApps)) {
+                $this->allApps[$app['id']]['level'] = \OC_App::supportedApp;
+            }
+        }
+
+        // add bundle information
+        $bundles = $this->bundleFetcher->getBundles();
+        foreach ($bundles as $bundle) {
+            foreach ($bundle->getAppIdentifiers() as $identifier) {
+                foreach ($this->allApps as &$app) {
+                    if ($app['id'] === $identifier) {
+                        $app['bundleIds'][] = $bundle->getIdentifier();
+                        continue;
+                    }
+                }
+            }
+        }
+    }
+
+    private function getAllApps() {
+        return $this->allApps;
+    }
+
+    /**
+     * Get all available apps in a category
+     *
+     * @return JSONResponse
+     * @throws \Exception
+     */
+    public function listApps(): JSONResponse {
+        $this->fetchApps();
+        $apps = $this->getAllApps();
+
+        $dependencyAnalyzer = Server::get(DependencyAnalyzer::class);
+
+        $ignoreMaxApps = $this->config->getSystemValue('app_install_overwrite', []);
+        if (!is_array($ignoreMaxApps)) {
+            $this->logger->warning('The value given for app_install_overwrite is not an array. Ignoring...');
+            $ignoreMaxApps = [];
+        }
+
+        // Extend existing app details
+        $apps = array_map(function (array $appData) use ($dependencyAnalyzer, $ignoreMaxApps) {
+            if (isset($appData['appstoreData'])) {
+                $appstoreData = $appData['appstoreData'];
+                $appData['screenshot'] = $this->createProxyPreviewUrl($appstoreData['screenshots'][0]['url'] ?? '');
+                $appData['category'] = $appstoreData['categories'];
+                $appData['releases'] = $appstoreData['releases'];
+            }
+
+            $newVersion = $this->installer->isUpdateAvailable($appData['id']);
+            if ($newVersion) {
+                $appData['update'] = $newVersion;
+            }
+
+            // fix groups to be an array
+            $groups = [];
+            if (is_string($appData['groups'])) {
+                $groups = json_decode($appData['groups']);
+                // ensure 'groups' is an array
+                if (!is_array($groups)) {
+                    $groups = [$groups];
+                }
+            }
+            $appData['groups'] = $groups;
+            $appData['canUnInstall'] = !$appData['active'] && $appData['removable'];
+
+            // fix licence vs license
+            if (isset($appData['license']) && !isset($appData['licence'])) {
+                $appData['licence'] = $appData['license'];
+            }
+
+            $ignoreMax = in_array($appData['id'], $ignoreMaxApps);
+
+            // analyse dependencies
+            $missing = $dependencyAnalyzer->analyze($appData, $ignoreMax);
+            $appData['canInstall'] = empty($missing);
+            $appData['missingDependencies'] = $missing;
+
+            $appData['missingMinOwnCloudVersion'] = !isset($appData['dependencies']['nextcloud']['@attributes']['min-version']);
+            $appData['missingMaxOwnCloudVersion'] = !isset($appData['dependencies']['nextcloud']['@attributes']['max-version']);
+            $appData['isCompatible'] = $dependencyAnalyzer->isMarkedCompatible($appData);
+
+            return $appData;
+        }, $apps);
+
+        usort($apps, [$this, 'sortApps']);
+
+        return new JSONResponse(['apps' => $apps, 'status' => 'success']);
+    }
+
+    /**
+     * Get all apps for a category from the app store
+     *
+     * @param string $requestedCategory
+     * @return array
+     * @throws \Exception
+     */
+    private function getAppsForCategory($requestedCategory = ''): array {
+        $versionParser = new VersionParser();
+        $formattedApps = [];
+        $apps = $this->appFetcher->get();
+        foreach ($apps as $app) {
+            // Skip all apps not in the requested category
+            if ($requestedCategory !== '') {
+                $isInCategory = false;
+                foreach ($app['categories'] as $category) {
+                    if ($category === $requestedCategory) {
+                        $isInCategory = true;
+                    }
+                }
+                if (!$isInCategory) {
+                    continue;
+                }
+            }
+
+            if (!isset($app['releases'][0]['rawPlatformVersionSpec'])) {
+                continue;
+            }
+            $nextCloudVersion = $versionParser->getVersion($app['releases'][0]['rawPlatformVersionSpec']);
+            $nextCloudVersionDependencies = [];
+            if ($nextCloudVersion->getMinimumVersion() !== '') {
+                $nextCloudVersionDependencies['nextcloud']['@attributes']['min-version'] = $nextCloudVersion->getMinimumVersion();
+            }
+            if ($nextCloudVersion->getMaximumVersion() !== '') {
+                $nextCloudVersionDependencies['nextcloud']['@attributes']['max-version'] = $nextCloudVersion->getMaximumVersion();
+            }
+            $phpVersion = $versionParser->getVersion($app['releases'][0]['rawPhpVersionSpec']);
+
+            try {
+                $this->appManager->getAppPath($app['id']);
+                $existsLocally = true;
+            } catch (AppPathNotFoundException) {
+                $existsLocally = false;
+            }
+
+            $phpDependencies = [];
+            if ($phpVersion->getMinimumVersion() !== '') {
+                $phpDependencies['php']['@attributes']['min-version'] = $phpVersion->getMinimumVersion();
+            }
+            if ($phpVersion->getMaximumVersion() !== '') {
+                $phpDependencies['php']['@attributes']['max-version'] = $phpVersion->getMaximumVersion();
+            }
+            if (isset($app['releases'][0]['minIntSize'])) {
+                $phpDependencies['php']['@attributes']['min-int-size'] = $app['releases'][0]['minIntSize'];
+            }
+            $authors = '';
+            foreach ($app['authors'] as $key => $author) {
+                $authors .= $author['name'];
+                if ($key !== count($app['authors']) - 1) {
+                    $authors .= ', ';
+                }
+            }
+
+            $currentLanguage = substr($this->l10nFactory->findLanguage(), 0, 2);
+            $enabledValue = $this->config->getAppValue($app['id'], 'enabled', 'no');
+            $groups = null;
+            if ($enabledValue !== 'no' && $enabledValue !== 'yes') {
+                $groups = $enabledValue;
+            }
+
+            $currentVersion = '';
+            if ($this->appManager->isEnabledForAnyone($app['id'])) {
+                $currentVersion = $this->appManager->getAppVersion($app['id']);
+            } else {
+                $currentVersion = $app['releases'][0]['version'];
+            }
+
+            $formattedApps[] = [
+                'id' => $app['id'],
+                'app_api' => false,
+                'name' => $app['translations'][$currentLanguage]['name'] ?? $app['translations']['en']['name'],
+                'description' => $app['translations'][$currentLanguage]['description'] ?? $app['translations']['en']['description'],
+                'summary' => $app['translations'][$currentLanguage]['summary'] ?? $app['translations']['en']['summary'],
+                'license' => $app['releases'][0]['licenses'],
+                'author' => $authors,
+                'shipped' => $this->appManager->isShipped($app['id']),
+                'version' => $currentVersion,
+                'default_enable' => '',
+                'types' => [],
+                'documentation' => [
+                    'admin' => $app['adminDocs'],
+                    'user' => $app['userDocs'],
+                    'developer' => $app['developerDocs']
+                ],
+                'website' => $app['website'],
+                'bugs' => $app['issueTracker'],
+                'detailpage' => $app['website'],
+                'dependencies' => array_merge(
+                    $nextCloudVersionDependencies,
+                    $phpDependencies
+                ),
+                'level' => ($app['isFeatured'] === true) ? 200 : 100,
+                'missingMaxOwnCloudVersion' => false,
+                'missingMinOwnCloudVersion' => false,
+                'canInstall' => true,
+                'screenshot' => isset($app['screenshots'][0]['url']) ? 'https://usercontent.apps.nextcloud.com/' . base64_encode($app['screenshots'][0]['url']) : '',
+                'score' => $app['ratingOverall'],
+                'ratingNumOverall' => $app['ratingNumOverall'],
+                'ratingNumThresholdReached' => $app['ratingNumOverall'] > 5,
+                'removable' => $existsLocally,
+                'active' => $this->appManager->isEnabledForUser($app['id']),
+                'needsDownload' => !$existsLocally,
+                'groups' => $groups,
+                'fromAppStore' => true,
+                'appstoreData' => $app,
+            ];
+        }
+
+        return $formattedApps;
+    }
+
+    /**
+     * @param string $appId
+     * @param array $groups
+     * @return JSONResponse
+     */
+    #[PasswordConfirmationRequired]
+    public function enableApp(string $appId, array $groups = []): JSONResponse {
+        return $this->enableApps([$appId], $groups);
+    }
+
+    /**
+     * Enable one or more apps
+     *
+     * apps will be enabled for specific groups only if $groups is defined
+     *
+     * @param array $appIds
+     * @param array $groups
+     * @return JSONResponse
+     */
+    #[PasswordConfirmationRequired]
+    public function enableApps(array $appIds, array $groups = []): JSONResponse {
+        try {
+            $updateRequired = false;
+
+            foreach ($appIds as $appId) {
+                $appId = $this->appManager->cleanAppId($appId);
+
+                // Check if app is already downloaded
+                if (!$this->installer->isDownloaded($appId)) {
+                    $this->installer->downloadApp($appId);
+                }
+
+                $this->installer->installApp($appId);
+
+                if (count($groups) > 0) {
+                    $this->appManager->enableAppForGroups($appId, $this->getGroupList($groups));
+                } else {
+                    $this->appManager->enableApp($appId);
+                }
+                $updateRequired = $updateRequired || $this->appManager->isUpgradeRequired($appId);
+            }
+            return new JSONResponse(['data' => ['update_required' => $updateRequired]]);
+        } catch (\Throwable $e) {
+            $this->logger->error('could not enable apps', ['exception' => $e]);
+            return new JSONResponse(['data' => ['message' => $e->getMessage()]], Http::STATUS_INTERNAL_SERVER_ERROR);
+        }
+    }
+
+    private function getGroupList(array $groups) {
+        $groupManager = Server::get(IGroupManager::class);
+        $groupsList = [];
+        foreach ($groups as $group) {
+            $groupItem = $groupManager->get($group);
+            if ($groupItem instanceof IGroup) {
+                $groupsList[] = $groupManager->get($group);
+            }
+        }
+        return $groupsList;
+    }
+
+    /**
+     * @param string $appId
+     * @return JSONResponse
+     */
+    #[PasswordConfirmationRequired]
+    public function disableApp(string $appId): JSONResponse {
+        return $this->disableApps([$appId]);
+    }
+
+    /**
+     * @param array $appIds
+     * @return JSONResponse
+     */
+    #[PasswordConfirmationRequired]
+    public function disableApps(array $appIds): JSONResponse {
+        try {
+            foreach ($appIds as $appId) {
+                $appId = $this->appManager->cleanAppId($appId);
+                $this->appManager->disableApp($appId);
+            }
+            return new JSONResponse([]);
+        } catch (\Exception $e) {
+            $this->logger->error('could not disable app', ['exception' => $e]);
+            return new JSONResponse(['data' => ['message' => $e->getMessage()]], Http::STATUS_INTERNAL_SERVER_ERROR);
+        }
+    }
+
+    /**
+     * @param string $appId
+     * @return JSONResponse
+     */
+    #[PasswordConfirmationRequired]
+    public function uninstallApp(string $appId): JSONResponse {
+        $appId = $this->appManager->cleanAppId($appId);
+        $result = $this->installer->removeApp($appId);
+        if ($result !== false) {
+            // If this app was force enabled, remove the force-enabled-state
+            $this->appManager->removeOverwriteNextcloudRequirement($appId);
+            $this->appManager->clearAppsCache();
+            return new JSONResponse(['data' => ['appid' => $appId]]);
+        }
+        return new JSONResponse(['data' => ['message' => $this->l10n->t('Could not remove app.')]], Http::STATUS_INTERNAL_SERVER_ERROR);
+    }
+
+    /**
+     * @param string $appId
+     * @return JSONResponse
+     */
+    public function updateApp(string $appId): JSONResponse {
+        $appId = $this->appManager->cleanAppId($appId);
+
+        $this->config->setSystemValue('maintenance', true);
+        try {
+            $result = $this->installer->updateAppstoreApp($appId);
+            $this->config->setSystemValue('maintenance', false);
+        } catch (\Exception $ex) {
+            $this->config->setSystemValue('maintenance', false);
+            return new JSONResponse(['data' => ['message' => $ex->getMessage()]], Http::STATUS_INTERNAL_SERVER_ERROR);
+        }
+
+        if ($result !== false) {
+            return new JSONResponse(['data' => ['appid' => $appId]]);
+        }
+        return new JSONResponse(['data' => ['message' => $this->l10n->t('Could not update app.')]], Http::STATUS_INTERNAL_SERVER_ERROR);
+    }
+
+    private function sortApps($a, $b) {
+        $a = (string)$a['name'];
+        $b = (string)$b['name'];
+        if ($a === $b) {
+            return 0;
+        }
+        return ($a < $b) ? -1 : 1;
+    }
+
+    public function force(string $appId): JSONResponse {
+        $appId = $this->appManager->cleanAppId($appId);
+        $this->appManager->overwriteNextcloudRequirement($appId);
+        return new JSONResponse();
+    }
 }

apps/settings/tests/Controller/AppSettingsControllerTest.php

Indentation +182 added lines, -182 removed lines

@@ -37,186 +37,186 @@
  */
 #[\PHPUnit\Framework\Attributes\Group(name: 'DB')]
 class AppSettingsControllerTest extends TestCase {
-	private IRequest&MockObject $request;
-	private IL10N&MockObject $l10n;
-	private IConfig&MockObject $config;
-	private INavigationManager&MockObject $navigationManager;
-	private AppManager&MockObject $appManager;
-	private CategoryFetcher&MockObject $categoryFetcher;
-	private AppFetcher&MockObject $appFetcher;
-	private IFactory&MockObject $l10nFactory;
-	private BundleFetcher&MockObject $bundleFetcher;
-	private Installer&MockObject $installer;
-	private IURLGenerator&MockObject $urlGenerator;
-	private LoggerInterface&MockObject $logger;
-	private IInitialState&MockObject $initialState;
-	private IAppDataFactory&MockObject $appDataFactory;
-	private AppDiscoverFetcher&MockObject $discoverFetcher;
-	private IClientService&MockObject $clientService;
-	private AppSettingsController $appSettingsController;
-
-	protected function setUp(): void {
-		parent::setUp();
-
-		$this->request = $this->createMock(IRequest::class);
-		$this->appDataFactory = $this->createMock(IAppDataFactory::class);
-		$this->l10n = $this->createMock(IL10N::class);
-		$this->l10n->expects($this->any())
-			->method('t')
-			->willReturnArgument(0);
-		$this->config = $this->createMock(IConfig::class);
-		$this->navigationManager = $this->createMock(INavigationManager::class);
-		$this->appManager = $this->createMock(AppManager::class);
-		$this->categoryFetcher = $this->createMock(CategoryFetcher::class);
-		$this->appFetcher = $this->createMock(AppFetcher::class);
-		$this->l10nFactory = $this->createMock(IFactory::class);
-		$this->bundleFetcher = $this->createMock(BundleFetcher::class);
-		$this->installer = $this->createMock(Installer::class);
-		$this->urlGenerator = $this->createMock(IURLGenerator::class);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->initialState = $this->createMock(IInitialState::class);
-		$this->discoverFetcher = $this->createMock(AppDiscoverFetcher::class);
-		$this->clientService = $this->createMock(IClientService::class);
-
-		$this->appSettingsController = new AppSettingsController(
-			'settings',
-			$this->request,
-			$this->appDataFactory,
-			$this->l10n,
-			$this->config,
-			$this->navigationManager,
-			$this->appManager,
-			$this->categoryFetcher,
-			$this->appFetcher,
-			$this->l10nFactory,
-			$this->bundleFetcher,
-			$this->installer,
-			$this->urlGenerator,
-			$this->logger,
-			$this->initialState,
-			$this->discoverFetcher,
-			$this->clientService,
-		);
-	}
-
-	public function testListCategories(): void {
-		$this->installer->expects($this->any())
-			->method('isUpdateAvailable')
-			->willReturn(false);
-		$expected = new JSONResponse([
-			[
-				'id' => 'auth',
-				'displayName' => 'Authentication & authorization',
-			],
-			[
-				'id' => 'customization',
-				'displayName' => 'Customization',
-			],
-			[
-				'id' => 'files',
-				'displayName' => 'Files',
-			],
-			[
-				'id' => 'integration',
-				'displayName' => 'Integration',
-			],
-			[
-				'id' => 'monitoring',
-				'displayName' => 'Monitoring',
-			],
-			[
-				'id' => 'multimedia',
-				'displayName' => 'Multimedia',
-			],
-			[
-				'id' => 'office',
-				'displayName' => 'Office & text',
-			],
-			[
-				'id' => 'organization',
-				'displayName' => 'Organization',
-			],
-			[
-				'id' => 'social',
-				'displayName' => 'Social & communication',
-			],
-			[
-				'id' => 'tools',
-				'displayName' => 'Tools',
-			],
-		]);
-
-		$this->categoryFetcher
-			->expects($this->once())
-			->method('get')
-			->willReturn(json_decode('[{"id":"auth","translations":{"cs":{"name":"Autentizace & autorizace","description":"Aplikace poskytující služby dodatečného ověření nebo přihlášení"},"hu":{"name":"Azonosítás és hitelesítés","description":"Apps that provide additional authentication or authorization services"},"de":{"name":"Authentifizierung & Authorisierung","description":"Apps die zusätzliche Autentifizierungs- oder Autorisierungsdienste bereitstellen"},"nl":{"name":"Authenticatie & authorisatie","description":"Apps die aanvullende authenticatie- en autorisatiediensten bieden"},"nb":{"name":"Pålogging og tilgangsstyring","description":"Apper for å tilby ekstra pålogging eller tilgangsstyring"},"it":{"name":"Autenticazione e autorizzazione","description":"Apps that provide additional authentication or authorization services"},"fr":{"name":"Authentification et autorisations","description":"Applications qui fournissent des services d\'authentification ou d\'autorisations additionnels."},"ru":{"name":"Аутентификация и авторизация","description":"Apps that provide additional authentication or authorization services"},"en":{"name":"Authentication & authorization","description":"Apps that provide additional authentication or authorization services"}}},{"id":"customization","translations":{"cs":{"name":"Přizpůsobení","description":"Motivy a aplikace měnící rozvržení a uživatelské rozhraní"},"it":{"name":"Personalizzazione","description":"Applicazioni di temi, modifiche della disposizione e UX"},"de":{"name":"Anpassung","description":"Apps zur Änderung von Themen, Layout und Benutzererfahrung"},"hu":{"name":"Személyre szabás","description":"Témák, elrendezések felhasználói felület módosító alkalmazások"},"nl":{"name":"Maatwerk","description":"Thema\'s, layout en UX aanpassingsapps"},"nb":{"name":"Tilpasning","description":"Apper for å endre Tema, utseende og brukeropplevelse"},"fr":{"name":"Personalisation","description":"Thèmes, apparence et applications modifiant l\'expérience utilisateur"},"ru":{"name":"Настройка","description":"Themes, layout and UX change apps"},"en":{"name":"Customization","description":"Themes, layout and UX change apps"}}},{"id":"files","translations":{"cs":{"name":"Soubory","description":"Aplikace rozšiřující správu souborů nebo aplikaci Soubory"},"it":{"name":"File","description":"Applicazioni di gestione dei file ed estensione dell\'applicazione FIle"},"de":{"name":"Dateien","description":"Dateimanagement sowie Erweiterungs-Apps für die Dateien-App"},"hu":{"name":"Fájlok","description":"Fájl kezelő és kiegészítő alkalmazások"},"nl":{"name":"Bestanden","description":"Bestandebeheer en uitbreidingen van bestand apps"},"nb":{"name":"Filer","description":"Apper for filhåndtering og filer"},"fr":{"name":"Fichiers","description":"Applications de gestion de fichiers et extensions à l\'application Fichiers"},"ru":{"name":"Файлы","description":"Расширение: файлы и управление файлами"},"en":{"name":"Files","description":"File management and Files app extension apps"}}},{"id":"integration","translations":{"it":{"name":"Integrazione","description":"Applicazioni che collegano Nextcloud con altri servizi e piattaforme"},"hu":{"name":"Integráció","description":"Apps that connect Nextcloud with other services and platforms"},"nl":{"name":"Integratie","description":"Apps die Nextcloud verbinden met andere services en platformen"},"nb":{"name":"Integrasjon","description":"Apper som kobler Nextcloud med andre tjenester og plattformer"},"de":{"name":"Integration","description":"Apps die Nextcloud mit anderen Diensten und Plattformen verbinden"},"cs":{"name":"Propojení","description":"Aplikace propojující NextCloud s dalšími službami a platformami"},"fr":{"name":"Intégration","description":"Applications qui connectent Nextcloud avec d\'autres services et plateformes"},"ru":{"name":"Интеграция","description":"Приложения, соединяющие Nextcloud с другими службами и платформами"},"en":{"name":"Integration","description":"Apps that connect Nextcloud with other services and platforms"}}},{"id":"monitoring","translations":{"nb":{"name":"Overvåking","description":"Apper for statistikk, systemdiagnose og aktivitet"},"it":{"name":"Monitoraggio","description":"Applicazioni di statistiche, diagnostica di sistema e attività"},"de":{"name":"Überwachung","description":"Datenstatistiken-, Systemdiagnose- und Aktivitäten-Apps"},"hu":{"name":"Megfigyelés","description":"Data statistics, system diagnostics and activity apps"},"nl":{"name":"Monitoren","description":"Gegevensstatistiek, systeem diagnose en activiteit apps"},"cs":{"name":"Kontrola","description":"Datové statistiky, diagnózy systému a aktivity aplikací"},"fr":{"name":"Surveillance","description":"Applications de statistiques sur les données, de diagnostics systèmes et d\'activité."},"ru":{"name":"Мониторинг","description":"Статистика данных, диагностика системы и активность приложений"},"en":{"name":"Monitoring","description":"Data statistics, system diagnostics and activity apps"}}},{"id":"multimedia","translations":{"nb":{"name":"Multimedia","description":"Apper for lyd, film og bilde"},"it":{"name":"Multimedia","description":"Applicazioni per audio, video e immagini"},"de":{"name":"Multimedia","description":"Audio-, Video- und Bilder-Apps"},"hu":{"name":"Multimédia","description":"Hang, videó és kép alkalmazások"},"nl":{"name":"Multimedia","description":"Audio, video en afbeelding apps"},"en":{"name":"Multimedia","description":"Audio, video and picture apps"},"cs":{"name":"Multimédia","description":"Aplikace audia, videa a obrázků"},"fr":{"name":"Multimédia","description":"Applications audio, vidéo et image"},"ru":{"name":"Мультимедиа","description":"Приложение аудио, видео и изображения"}}},{"id":"office","translations":{"nb":{"name":"Kontorstøtte og tekst","description":"Apper for Kontorstøtte og tekstbehandling"},"it":{"name":"Ufficio e testo","description":"Applicazione per ufficio ed elaborazione di testi"},"de":{"name":"Büro & Text","description":"Büro- und Textverarbeitungs-Apps"},"hu":{"name":"Iroda és szöveg","description":"Irodai és szöveg feldolgozó alkalmazások"},"nl":{"name":"Office & tekst","description":"Office en tekstverwerkingsapps"},"cs":{"name":"Kancelář a text","description":"Aplikace pro kancelář a zpracování textu"},"fr":{"name":"Bureautique & texte","description":"Applications de bureautique et de traitement de texte"},"en":{"name":"Office & text","description":"Office and text processing apps"}}},{"id":"organization","translations":{"nb":{"name":"Organisering","description":"Apper for tidsstyring, oppgaveliste og kalender"},"it":{"name":"Organizzazione","description":"Applicazioni di gestione del tempo, elenco delle cose da fare e calendario"},"hu":{"name":"Szervezet","description":"Időbeosztás, teendő lista és naptár alkalmazások"},"nl":{"name":"Organisatie","description":"Tijdmanagement, takenlijsten en agenda apps"},"cs":{"name":"Organizace","description":"Aplikace pro správu času, plánování a kalendáře"},"de":{"name":"Organisation","description":"Time management, Todo list and calendar apps"},"fr":{"name":"Organisation","description":"Applications de gestion du temps, de listes de tâches et d\'agendas"},"ru":{"name":"Организация","description":"Приложения по управлению временем, список задач и календарь"},"en":{"name":"Organization","description":"Time management, Todo list and calendar apps"}}},{"id":"social","translations":{"nb":{"name":"Sosialt og kommunikasjon","description":"Apper for meldinger, kontakthåndtering og sosiale medier"},"it":{"name":"Sociale e comunicazione","description":"Applicazioni di messaggistica, gestione dei contatti e reti sociali"},"de":{"name":"Kommunikation","description":"Nachrichten-, Kontaktverwaltungs- und Social-Media-Apps"},"hu":{"name":"Közösségi és kommunikáció","description":"Üzenetküldő, kapcsolat kezelő és közösségi média alkalmazások"},"nl":{"name":"Sociaal & communicatie","description":"Messaging, contactbeheer en social media apps"},"cs":{"name":"Sociální sítě a komunikace","description":"Aplikace pro zasílání zpráv, správu kontaktů a sociální sítě"},"fr":{"name":"Social & communication","description":"Applications de messagerie, de gestion de contacts et de réseaux sociaux"},"ru":{"name":"Социальное и связь","description":"Общение, управление контактами и социальное медиа-приложение"},"en":{"name":"Social & communication","description":"Messaging, contact management and social media apps"}}},{"id":"tools","translations":{"nb":{"name":"Verktøy","description":"Alt annet"},"it":{"name":"Strumenti","description":"Tutto il resto"},"hu":{"name":"Eszközök","description":"Minden más"},"nl":{"name":"Tools","description":"De rest"},"de":{"name":"Werkzeuge","description":"Alles Andere"},"en":{"name":"Tools","description":"Everything else"},"cs":{"name":"Nástroje","description":"Vše ostatní"},"fr":{"name":"Outils","description":"Tout le reste"},"ru":{"name":"Приложения","description":"Что-то еще"}}}]', true));
-
-		$this->assertEquals($expected, $this->appSettingsController->listCategories());
-	}
-
-	public function testViewApps(): void {
-		$this->bundleFetcher->expects($this->once())->method('getBundles')->willReturn([]);
-		$this->installer->expects($this->any())
-			->method('isUpdateAvailable')
-			->willReturn(false);
-		$this->config
-			->expects($this->once())
-			->method('getSystemValueBool')
-			->with('appstoreenabled', true)
-			->willReturn(true);
-		$this->navigationManager
-			->expects($this->once())
-			->method('setActiveEntry')
-			->with('core_apps');
-
-		$this->initialState
-			->expects($this->exactly(3))
-			->method('provideInitialState');
-
-		$policy = new ContentSecurityPolicy();
-		$policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
-
-		$expected = new TemplateResponse('settings',
-			'settings/empty',
-			[
-				'pageTitle' => 'Settings'
-			],
-			'user');
-		$expected->setContentSecurityPolicy($policy);
-
-		$this->assertEquals($expected, $this->appSettingsController->viewApps());
-	}
-
-	public function testViewAppsAppstoreNotEnabled(): void {
-		$this->installer->expects($this->any())
-			->method('isUpdateAvailable')
-			->willReturn(false);
-		$this->bundleFetcher->expects($this->once())->method('getBundles')->willReturn([]);
-		$this->config
-			->expects($this->once())
-			->method('getSystemValueBool')
-			->with('appstoreenabled', true)
-			->willReturn(false);
-		$this->navigationManager
-			->expects($this->once())
-			->method('setActiveEntry')
-			->with('core_apps');
-
-		$this->initialState
-			->expects($this->exactly(3))
-			->method('provideInitialState');
-
-		$policy = new ContentSecurityPolicy();
-		$policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
-
-		$expected = new TemplateResponse('settings',
-			'settings/empty',
-			[
-				'pageTitle' => 'Settings'
-			],
-			'user');
-		$expected->setContentSecurityPolicy($policy);
-
-		$this->assertEquals($expected, $this->appSettingsController->viewApps());
-	}
+    private IRequest&MockObject $request;
+    private IL10N&MockObject $l10n;
+    private IConfig&MockObject $config;
+    private INavigationManager&MockObject $navigationManager;
+    private AppManager&MockObject $appManager;
+    private CategoryFetcher&MockObject $categoryFetcher;
+    private AppFetcher&MockObject $appFetcher;
+    private IFactory&MockObject $l10nFactory;
+    private BundleFetcher&MockObject $bundleFetcher;
+    private Installer&MockObject $installer;
+    private IURLGenerator&MockObject $urlGenerator;
+    private LoggerInterface&MockObject $logger;
+    private IInitialState&MockObject $initialState;
+    private IAppDataFactory&MockObject $appDataFactory;
+    private AppDiscoverFetcher&MockObject $discoverFetcher;
+    private IClientService&MockObject $clientService;
+    private AppSettingsController $appSettingsController;
+
+    protected function setUp(): void {
+        parent::setUp();
+
+        $this->request = $this->createMock(IRequest::class);
+        $this->appDataFactory = $this->createMock(IAppDataFactory::class);
+        $this->l10n = $this->createMock(IL10N::class);
+        $this->l10n->expects($this->any())
+            ->method('t')
+            ->willReturnArgument(0);
+        $this->config = $this->createMock(IConfig::class);
+        $this->navigationManager = $this->createMock(INavigationManager::class);
+        $this->appManager = $this->createMock(AppManager::class);
+        $this->categoryFetcher = $this->createMock(CategoryFetcher::class);
+        $this->appFetcher = $this->createMock(AppFetcher::class);
+        $this->l10nFactory = $this->createMock(IFactory::class);
+        $this->bundleFetcher = $this->createMock(BundleFetcher::class);
+        $this->installer = $this->createMock(Installer::class);
+        $this->urlGenerator = $this->createMock(IURLGenerator::class);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->initialState = $this->createMock(IInitialState::class);
+        $this->discoverFetcher = $this->createMock(AppDiscoverFetcher::class);
+        $this->clientService = $this->createMock(IClientService::class);
+
+        $this->appSettingsController = new AppSettingsController(
+            'settings',
+            $this->request,
+            $this->appDataFactory,
+            $this->l10n,
+            $this->config,
+            $this->navigationManager,
+            $this->appManager,
+            $this->categoryFetcher,
+            $this->appFetcher,
+            $this->l10nFactory,
+            $this->bundleFetcher,
+            $this->installer,
+            $this->urlGenerator,
+            $this->logger,
+            $this->initialState,
+            $this->discoverFetcher,
+            $this->clientService,
+        );
+    }
+
+    public function testListCategories(): void {
+        $this->installer->expects($this->any())
+            ->method('isUpdateAvailable')
+            ->willReturn(false);
+        $expected = new JSONResponse([
+            [
+                'id' => 'auth',
+                'displayName' => 'Authentication & authorization',
+            ],
+            [
+                'id' => 'customization',
+                'displayName' => 'Customization',
+            ],
+            [
+                'id' => 'files',
+                'displayName' => 'Files',
+            ],
+            [
+                'id' => 'integration',
+                'displayName' => 'Integration',
+            ],
+            [
+                'id' => 'monitoring',
+                'displayName' => 'Monitoring',
+            ],
+            [
+                'id' => 'multimedia',
+                'displayName' => 'Multimedia',
+            ],
+            [
+                'id' => 'office',
+                'displayName' => 'Office & text',
+            ],
+            [
+                'id' => 'organization',
+                'displayName' => 'Organization',
+            ],
+            [
+                'id' => 'social',
+                'displayName' => 'Social & communication',
+            ],
+            [
+                'id' => 'tools',
+                'displayName' => 'Tools',
+            ],
+        ]);
+
+        $this->categoryFetcher
+            ->expects($this->once())
+            ->method('get')
+            ->willReturn(json_decode('[{"id":"auth","translations":{"cs":{"name":"Autentizace & autorizace","description":"Aplikace poskytující služby dodatečného ověření nebo přihlášení"},"hu":{"name":"Azonosítás és hitelesítés","description":"Apps that provide additional authentication or authorization services"},"de":{"name":"Authentifizierung & Authorisierung","description":"Apps die zusätzliche Autentifizierungs- oder Autorisierungsdienste bereitstellen"},"nl":{"name":"Authenticatie & authorisatie","description":"Apps die aanvullende authenticatie- en autorisatiediensten bieden"},"nb":{"name":"Pålogging og tilgangsstyring","description":"Apper for å tilby ekstra pålogging eller tilgangsstyring"},"it":{"name":"Autenticazione e autorizzazione","description":"Apps that provide additional authentication or authorization services"},"fr":{"name":"Authentification et autorisations","description":"Applications qui fournissent des services d\'authentification ou d\'autorisations additionnels."},"ru":{"name":"Аутентификация и авторизация","description":"Apps that provide additional authentication or authorization services"},"en":{"name":"Authentication & authorization","description":"Apps that provide additional authentication or authorization services"}}},{"id":"customization","translations":{"cs":{"name":"Přizpůsobení","description":"Motivy a aplikace měnící rozvržení a uživatelské rozhraní"},"it":{"name":"Personalizzazione","description":"Applicazioni di temi, modifiche della disposizione e UX"},"de":{"name":"Anpassung","description":"Apps zur Änderung von Themen, Layout und Benutzererfahrung"},"hu":{"name":"Személyre szabás","description":"Témák, elrendezések felhasználói felület módosító alkalmazások"},"nl":{"name":"Maatwerk","description":"Thema\'s, layout en UX aanpassingsapps"},"nb":{"name":"Tilpasning","description":"Apper for å endre Tema, utseende og brukeropplevelse"},"fr":{"name":"Personalisation","description":"Thèmes, apparence et applications modifiant l\'expérience utilisateur"},"ru":{"name":"Настройка","description":"Themes, layout and UX change apps"},"en":{"name":"Customization","description":"Themes, layout and UX change apps"}}},{"id":"files","translations":{"cs":{"name":"Soubory","description":"Aplikace rozšiřující správu souborů nebo aplikaci Soubory"},"it":{"name":"File","description":"Applicazioni di gestione dei file ed estensione dell\'applicazione FIle"},"de":{"name":"Dateien","description":"Dateimanagement sowie Erweiterungs-Apps für die Dateien-App"},"hu":{"name":"Fájlok","description":"Fájl kezelő és kiegészítő alkalmazások"},"nl":{"name":"Bestanden","description":"Bestandebeheer en uitbreidingen van bestand apps"},"nb":{"name":"Filer","description":"Apper for filhåndtering og filer"},"fr":{"name":"Fichiers","description":"Applications de gestion de fichiers et extensions à l\'application Fichiers"},"ru":{"name":"Файлы","description":"Расширение: файлы и управление файлами"},"en":{"name":"Files","description":"File management and Files app extension apps"}}},{"id":"integration","translations":{"it":{"name":"Integrazione","description":"Applicazioni che collegano Nextcloud con altri servizi e piattaforme"},"hu":{"name":"Integráció","description":"Apps that connect Nextcloud with other services and platforms"},"nl":{"name":"Integratie","description":"Apps die Nextcloud verbinden met andere services en platformen"},"nb":{"name":"Integrasjon","description":"Apper som kobler Nextcloud med andre tjenester og plattformer"},"de":{"name":"Integration","description":"Apps die Nextcloud mit anderen Diensten und Plattformen verbinden"},"cs":{"name":"Propojení","description":"Aplikace propojující NextCloud s dalšími službami a platformami"},"fr":{"name":"Intégration","description":"Applications qui connectent Nextcloud avec d\'autres services et plateformes"},"ru":{"name":"Интеграция","description":"Приложения, соединяющие Nextcloud с другими службами и платформами"},"en":{"name":"Integration","description":"Apps that connect Nextcloud with other services and platforms"}}},{"id":"monitoring","translations":{"nb":{"name":"Overvåking","description":"Apper for statistikk, systemdiagnose og aktivitet"},"it":{"name":"Monitoraggio","description":"Applicazioni di statistiche, diagnostica di sistema e attività"},"de":{"name":"Überwachung","description":"Datenstatistiken-, Systemdiagnose- und Aktivitäten-Apps"},"hu":{"name":"Megfigyelés","description":"Data statistics, system diagnostics and activity apps"},"nl":{"name":"Monitoren","description":"Gegevensstatistiek, systeem diagnose en activiteit apps"},"cs":{"name":"Kontrola","description":"Datové statistiky, diagnózy systému a aktivity aplikací"},"fr":{"name":"Surveillance","description":"Applications de statistiques sur les données, de diagnostics systèmes et d\'activité."},"ru":{"name":"Мониторинг","description":"Статистика данных, диагностика системы и активность приложений"},"en":{"name":"Monitoring","description":"Data statistics, system diagnostics and activity apps"}}},{"id":"multimedia","translations":{"nb":{"name":"Multimedia","description":"Apper for lyd, film og bilde"},"it":{"name":"Multimedia","description":"Applicazioni per audio, video e immagini"},"de":{"name":"Multimedia","description":"Audio-, Video- und Bilder-Apps"},"hu":{"name":"Multimédia","description":"Hang, videó és kép alkalmazások"},"nl":{"name":"Multimedia","description":"Audio, video en afbeelding apps"},"en":{"name":"Multimedia","description":"Audio, video and picture apps"},"cs":{"name":"Multimédia","description":"Aplikace audia, videa a obrázků"},"fr":{"name":"Multimédia","description":"Applications audio, vidéo et image"},"ru":{"name":"Мультимедиа","description":"Приложение аудио, видео и изображения"}}},{"id":"office","translations":{"nb":{"name":"Kontorstøtte og tekst","description":"Apper for Kontorstøtte og tekstbehandling"},"it":{"name":"Ufficio e testo","description":"Applicazione per ufficio ed elaborazione di testi"},"de":{"name":"Büro & Text","description":"Büro- und Textverarbeitungs-Apps"},"hu":{"name":"Iroda és szöveg","description":"Irodai és szöveg feldolgozó alkalmazások"},"nl":{"name":"Office & tekst","description":"Office en tekstverwerkingsapps"},"cs":{"name":"Kancelář a text","description":"Aplikace pro kancelář a zpracování textu"},"fr":{"name":"Bureautique & texte","description":"Applications de bureautique et de traitement de texte"},"en":{"name":"Office & text","description":"Office and text processing apps"}}},{"id":"organization","translations":{"nb":{"name":"Organisering","description":"Apper for tidsstyring, oppgaveliste og kalender"},"it":{"name":"Organizzazione","description":"Applicazioni di gestione del tempo, elenco delle cose da fare e calendario"},"hu":{"name":"Szervezet","description":"Időbeosztás, teendő lista és naptár alkalmazások"},"nl":{"name":"Organisatie","description":"Tijdmanagement, takenlijsten en agenda apps"},"cs":{"name":"Organizace","description":"Aplikace pro správu času, plánování a kalendáře"},"de":{"name":"Organisation","description":"Time management, Todo list and calendar apps"},"fr":{"name":"Organisation","description":"Applications de gestion du temps, de listes de tâches et d\'agendas"},"ru":{"name":"Организация","description":"Приложения по управлению временем, список задач и календарь"},"en":{"name":"Organization","description":"Time management, Todo list and calendar apps"}}},{"id":"social","translations":{"nb":{"name":"Sosialt og kommunikasjon","description":"Apper for meldinger, kontakthåndtering og sosiale medier"},"it":{"name":"Sociale e comunicazione","description":"Applicazioni di messaggistica, gestione dei contatti e reti sociali"},"de":{"name":"Kommunikation","description":"Nachrichten-, Kontaktverwaltungs- und Social-Media-Apps"},"hu":{"name":"Közösségi és kommunikáció","description":"Üzenetküldő, kapcsolat kezelő és közösségi média alkalmazások"},"nl":{"name":"Sociaal & communicatie","description":"Messaging, contactbeheer en social media apps"},"cs":{"name":"Sociální sítě a komunikace","description":"Aplikace pro zasílání zpráv, správu kontaktů a sociální sítě"},"fr":{"name":"Social & communication","description":"Applications de messagerie, de gestion de contacts et de réseaux sociaux"},"ru":{"name":"Социальное и связь","description":"Общение, управление контактами и социальное медиа-приложение"},"en":{"name":"Social & communication","description":"Messaging, contact management and social media apps"}}},{"id":"tools","translations":{"nb":{"name":"Verktøy","description":"Alt annet"},"it":{"name":"Strumenti","description":"Tutto il resto"},"hu":{"name":"Eszközök","description":"Minden más"},"nl":{"name":"Tools","description":"De rest"},"de":{"name":"Werkzeuge","description":"Alles Andere"},"en":{"name":"Tools","description":"Everything else"},"cs":{"name":"Nástroje","description":"Vše ostatní"},"fr":{"name":"Outils","description":"Tout le reste"},"ru":{"name":"Приложения","description":"Что-то еще"}}}]', true));
+
+        $this->assertEquals($expected, $this->appSettingsController->listCategories());
+    }
+
+    public function testViewApps(): void {
+        $this->bundleFetcher->expects($this->once())->method('getBundles')->willReturn([]);
+        $this->installer->expects($this->any())
+            ->method('isUpdateAvailable')
+            ->willReturn(false);
+        $this->config
+            ->expects($this->once())
+            ->method('getSystemValueBool')
+            ->with('appstoreenabled', true)
+            ->willReturn(true);
+        $this->navigationManager
+            ->expects($this->once())
+            ->method('setActiveEntry')
+            ->with('core_apps');
+
+        $this->initialState
+            ->expects($this->exactly(3))
+            ->method('provideInitialState');
+
+        $policy = new ContentSecurityPolicy();
+        $policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
+
+        $expected = new TemplateResponse('settings',
+            'settings/empty',
+            [
+                'pageTitle' => 'Settings'
+            ],
+            'user');
+        $expected->setContentSecurityPolicy($policy);
+
+        $this->assertEquals($expected, $this->appSettingsController->viewApps());
+    }
+
+    public function testViewAppsAppstoreNotEnabled(): void {
+        $this->installer->expects($this->any())
+            ->method('isUpdateAvailable')
+            ->willReturn(false);
+        $this->bundleFetcher->expects($this->once())->method('getBundles')->willReturn([]);
+        $this->config
+            ->expects($this->once())
+            ->method('getSystemValueBool')
+            ->with('appstoreenabled', true)
+            ->willReturn(false);
+        $this->navigationManager
+            ->expects($this->once())
+            ->method('setActiveEntry')
+            ->with('core_apps');
+
+        $this->initialState
+            ->expects($this->exactly(3))
+            ->method('provideInitialState');
+
+        $policy = new ContentSecurityPolicy();
+        $policy->addAllowedImageDomain('https://usercontent.apps.nextcloud.com');
+
+        $expected = new TemplateResponse('settings',
+            'settings/empty',
+            [
+                'pageTitle' => 'Settings'
+            ],
+            'user');
+        $expected->setContentSecurityPolicy($policy);
+
+        $this->assertEquals($expected, $this->appSettingsController->viewApps());
+    }
 }