nextcloud / server

core/Command/Db/AddMissingPrimaryKeys.php

Indentation +128 added lines, -128 removed lines

@@ -45,132 +45,132 @@
  */
 class AddMissingPrimaryKeys extends Command {
 
-	/** @var Connection */
-	private $connection;
-
-	/** @var EventDispatcherInterface */
-	private $dispatcher;
-
-	public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
-		parent::__construct();
-
-		$this->connection = $connection;
-		$this->dispatcher = $dispatcher;
-	}
-
-	protected function configure() {
-		$this
-			->setName('db:add-missing-primary-keys')
-			->setDescription('Add missing primary keys to the database tables');
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$this->addCorePrimaryKeys($output);
-
-		// Dispatch event so apps can also update indexes if needed
-		$event = new GenericEvent($output);
-		$this->dispatcher->dispatch(IDBConnection::ADD_MISSING_PRIMARY_KEYS_EVENT, $event);
-		return 0;
-	}
-
-	/**
-	 * add missing indices to the share table
-	 *
-	 * @param OutputInterface $output
-	 * @throws \Doctrine\DBAL\Schema\SchemaException
-	 */
-	private function addCorePrimaryKeys(OutputInterface $output) {
-		$output->writeln('<info>Check primary keys.</info>');
-
-		$schema = new SchemaWrapper($this->connection);
-		$updated = false;
-
-		if ($schema->hasTable('federated_reshares')) {
-			$table = $schema->getTable('federated_reshares');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the federated_reshares table, this can take some time...</info>');
-				$table->setPrimaryKey(['share_id'], 'federated_res_pk');
-				if ($table->hasIndex('share_id_index')) {
-					$table->dropIndex('share_id_index');
-				}
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>federated_reshares table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('systemtag_object_mapping')) {
-			$table = $schema->getTable('systemtag_object_mapping');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the systemtag_object_mapping table, this can take some time...</info>');
-				$table->setPrimaryKey(['objecttype', 'objectid', 'systemtagid'], 'som_pk');
-				if ($table->hasIndex('mapping')) {
-					$table->dropIndex('mapping');
-				}
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>systemtag_object_mapping table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('comments_read_markers')) {
-			$table = $schema->getTable('comments_read_markers');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the comments_read_markers table, this can take some time...</info>');
-				$table->setPrimaryKey(['user_id', 'object_type', 'object_id'], 'crm_pk');
-				if ($table->hasIndex('comments_marker_index')) {
-					$table->dropIndex('comments_marker_index');
-				}
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>comments_read_markers table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('collres_resources')) {
-			$table = $schema->getTable('collres_resources');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the collres_resources table, this can take some time...</info>');
-				$table->setPrimaryKey(['collection_id', 'resource_type', 'resource_id'], 'crr_pk');
-				if ($table->hasIndex('collres_unique_res')) {
-					$table->dropIndex('collres_unique_res');
-				}
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>collres_resources table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('collres_accesscache')) {
-			$table = $schema->getTable('collres_accesscache');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the collres_accesscache table, this can take some time...</info>');
-				$table->setPrimaryKey(['user_id', 'collection_id', 'resource_type', 'resource_id'], 'cra_pk');
-				if ($table->hasIndex('collres_unique_user')) {
-					$table->dropIndex('collres_unique_user');
-				}
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>collres_accesscache table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('filecache_extended')) {
-			$table = $schema->getTable('filecache_extended');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the filecache_extended table, this can take some time...</info>');
-				$table->setPrimaryKey(['fileid'], 'fce_pk');
-				if ($table->hasIndex('fce_fileid_idx')) {
-					$table->dropIndex('fce_fileid_idx');
-				}
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>filecache_extended table updated successfully.</info>');
-			}
-		}
-
-		if (!$updated) {
-			$output->writeln('<info>Done.</info>');
-		}
-	}
+    /** @var Connection */
+    private $connection;
+
+    /** @var EventDispatcherInterface */
+    private $dispatcher;
+
+    public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
+        parent::__construct();
+
+        $this->connection = $connection;
+        $this->dispatcher = $dispatcher;
+    }
+
+    protected function configure() {
+        $this
+            ->setName('db:add-missing-primary-keys')
+            ->setDescription('Add missing primary keys to the database tables');
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $this->addCorePrimaryKeys($output);
+
+        // Dispatch event so apps can also update indexes if needed
+        $event = new GenericEvent($output);
+        $this->dispatcher->dispatch(IDBConnection::ADD_MISSING_PRIMARY_KEYS_EVENT, $event);
+        return 0;
+    }
+
+    /**
+     * add missing indices to the share table
+     *
+     * @param OutputInterface $output
+     * @throws \Doctrine\DBAL\Schema\SchemaException
+     */
+    private function addCorePrimaryKeys(OutputInterface $output) {
+        $output->writeln('<info>Check primary keys.</info>');
+
+        $schema = new SchemaWrapper($this->connection);
+        $updated = false;
+
+        if ($schema->hasTable('federated_reshares')) {
+            $table = $schema->getTable('federated_reshares');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the federated_reshares table, this can take some time...</info>');
+                $table->setPrimaryKey(['share_id'], 'federated_res_pk');
+                if ($table->hasIndex('share_id_index')) {
+                    $table->dropIndex('share_id_index');
+                }
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>federated_reshares table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('systemtag_object_mapping')) {
+            $table = $schema->getTable('systemtag_object_mapping');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the systemtag_object_mapping table, this can take some time...</info>');
+                $table->setPrimaryKey(['objecttype', 'objectid', 'systemtagid'], 'som_pk');
+                if ($table->hasIndex('mapping')) {
+                    $table->dropIndex('mapping');
+                }
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>systemtag_object_mapping table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('comments_read_markers')) {
+            $table = $schema->getTable('comments_read_markers');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the comments_read_markers table, this can take some time...</info>');
+                $table->setPrimaryKey(['user_id', 'object_type', 'object_id'], 'crm_pk');
+                if ($table->hasIndex('comments_marker_index')) {
+                    $table->dropIndex('comments_marker_index');
+                }
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>comments_read_markers table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('collres_resources')) {
+            $table = $schema->getTable('collres_resources');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the collres_resources table, this can take some time...</info>');
+                $table->setPrimaryKey(['collection_id', 'resource_type', 'resource_id'], 'crr_pk');
+                if ($table->hasIndex('collres_unique_res')) {
+                    $table->dropIndex('collres_unique_res');
+                }
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>collres_resources table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('collres_accesscache')) {
+            $table = $schema->getTable('collres_accesscache');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the collres_accesscache table, this can take some time...</info>');
+                $table->setPrimaryKey(['user_id', 'collection_id', 'resource_type', 'resource_id'], 'cra_pk');
+                if ($table->hasIndex('collres_unique_user')) {
+                    $table->dropIndex('collres_unique_user');
+                }
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>collres_accesscache table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('filecache_extended')) {
+            $table = $schema->getTable('filecache_extended');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the filecache_extended table, this can take some time...</info>');
+                $table->setPrimaryKey(['fileid'], 'fce_pk');
+                if ($table->hasIndex('fce_fileid_idx')) {
+                    $table->dropIndex('fce_fileid_idx');
+                }
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>filecache_extended table updated successfully.</info>');
+            }
+        }
+
+        if (!$updated) {
+            $output->writeln('<info>Done.</info>');
+        }
+    }
 }

core/Command/Db/ConvertMysqlToMB4.php

Indentation +45 added lines, -45 removed lines

@@ -37,59 +37,59 @@
 use Symfony\Component\Console\Output\OutputInterface;
 
 class ConvertMysqlToMB4 extends Command {
-	/** @var IConfig */
-	private $config;
+    /** @var IConfig */
+    private $config;
 
-	/** @var IDBConnection */
-	private $connection;
+    /** @var IDBConnection */
+    private $connection;
 
-	/** @var IURLGenerator */
-	private $urlGenerator;
+    /** @var IURLGenerator */
+    private $urlGenerator;
 
-	/** @var ILogger */
-	private $logger;
+    /** @var ILogger */
+    private $logger;
 
-	/**
-	 * @param IConfig $config
-	 * @param IDBConnection $connection
-	 * @param IURLGenerator $urlGenerator
-	 * @param ILogger $logger
-	 */
-	public function __construct(IConfig $config, IDBConnection $connection, IURLGenerator $urlGenerator, ILogger $logger) {
-		$this->config = $config;
-		$this->connection = $connection;
-		$this->urlGenerator = $urlGenerator;
-		$this->logger = $logger;
-		parent::__construct();
-	}
+    /**
+     * @param IConfig $config
+     * @param IDBConnection $connection
+     * @param IURLGenerator $urlGenerator
+     * @param ILogger $logger
+     */
+    public function __construct(IConfig $config, IDBConnection $connection, IURLGenerator $urlGenerator, ILogger $logger) {
+        $this->config = $config;
+        $this->connection = $connection;
+        $this->urlGenerator = $urlGenerator;
+        $this->logger = $logger;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$this
-			->setName('db:convert-mysql-charset')
-			->setDescription('Convert charset of MySQL/MariaDB to use utf8mb4');
-	}
+    protected function configure() {
+        $this
+            ->setName('db:convert-mysql-charset')
+            ->setDescription('Convert charset of MySQL/MariaDB to use utf8mb4');
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		if (!$this->connection->getDatabasePlatform() instanceof MySQLPlatform) {
-			$output->writeln("This command is only valid for MySQL/MariaDB databases.");
-			return 1;
-		}
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        if (!$this->connection->getDatabasePlatform() instanceof MySQLPlatform) {
+            $output->writeln("This command is only valid for MySQL/MariaDB databases.");
+            return 1;
+        }
 
-		$tools = new MySqlTools();
-		if (!$tools->supports4ByteCharset($this->connection)) {
-			$url = $this->urlGenerator->linkToDocs('admin-mysql-utf8mb4');
-			$output->writeln("The database is not properly setup to use the charset utf8mb4.");
-			$output->writeln("For more information please read the documentation at $url");
-			return 1;
-		}
+        $tools = new MySqlTools();
+        if (!$tools->supports4ByteCharset($this->connection)) {
+            $url = $this->urlGenerator->linkToDocs('admin-mysql-utf8mb4');
+            $output->writeln("The database is not properly setup to use the charset utf8mb4.");
+            $output->writeln("For more information please read the documentation at $url");
+            return 1;
+        }
 
-		// enable charset
-		$this->config->setSystemValue('mysql.utf8mb4', true);
+        // enable charset
+        $this->config->setSystemValue('mysql.utf8mb4', true);
 
-		// run conversion
-		$coll = new Collation($this->config, $this->logger, $this->connection, false);
-		$coll->run(new ConsoleOutput($output));
+        // run conversion
+        $coll = new Collation($this->config, $this->logger, $this->connection, false);
+        $coll->run(new ConsoleOutput($output));
 
-		return 0;
-	}
+        return 0;
+    }
 }

core/Command/Db/Migrations/ExecuteCommand.php

Indentation +86 added lines, -86 removed lines

@@ -36,90 +36,90 @@
 
 class ExecuteCommand extends Command implements CompletionAwareInterface {
 
-	/** @var Connection */
-	private $connection;
-
-	/** @var IConfig */
-	private $config;
-
-	/**
-	 * ExecuteCommand constructor.
-	 *
-	 * @param Connection $connection
-	 * @param IConfig $config
-	 */
-	public function __construct(Connection $connection, IConfig $config) {
-		$this->connection = $connection;
-		$this->config = $config;
-
-		parent::__construct();
-	}
-
-	protected function configure() {
-		$this
-			->setName('migrations:execute')
-			->setDescription('Execute a single migration version manually.')
-			->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on')
-			->addArgument('version', InputArgument::REQUIRED, 'The version to execute.', null);
-
-		parent::configure();
-	}
-
-	/**
-	 * @param InputInterface $input
-	 * @param OutputInterface $output
-	 * @return int
-	 */
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		$appName = $input->getArgument('app');
-		$ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
-		$version = $input->getArgument('version');
-
-		if ($this->config->getSystemValue('debug', false) === false) {
-			$olderVersions = $ms->getMigratedVersions();
-			$olderVersions[] = '0';
-			$olderVersions[] = 'prev';
-			if (in_array($version,  $olderVersions, true)) {
-				$output->writeln('<error>Can not go back to previous migration without debug enabled</error>');
-				return 1;
-			}
-		}
-
-
-		$ms->executeStep($version);
-		return 0;
-	}
-
-	/**
-	 * @param string $optionName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeOptionValues($optionName, CompletionContext $context) {
-		return [];
-	}
-
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
-		if ($argumentName === 'app') {
-			$allApps = \OC_App::getAllApps();
-			return array_diff($allApps, \OC_App::getEnabledApps(true, true));
-		}
-
-		if ($argumentName === 'version') {
-			$appName = $context->getWordAtIndex($context->getWordIndex() - 1);
-
-			$ms = new MigrationService($appName, $this->connection);
-			$migrations = $ms->getAvailableVersions();
-
-			array_unshift($migrations, 'next', 'latest');
-			return $migrations;
-		}
-
-		return [];
-	}
+    /** @var Connection */
+    private $connection;
+
+    /** @var IConfig */
+    private $config;
+
+    /**
+     * ExecuteCommand constructor.
+     *
+     * @param Connection $connection
+     * @param IConfig $config
+     */
+    public function __construct(Connection $connection, IConfig $config) {
+        $this->connection = $connection;
+        $this->config = $config;
+
+        parent::__construct();
+    }
+
+    protected function configure() {
+        $this
+            ->setName('migrations:execute')
+            ->setDescription('Execute a single migration version manually.')
+            ->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on')
+            ->addArgument('version', InputArgument::REQUIRED, 'The version to execute.', null);
+
+        parent::configure();
+    }
+
+    /**
+     * @param InputInterface $input
+     * @param OutputInterface $output
+     * @return int
+     */
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        $appName = $input->getArgument('app');
+        $ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
+        $version = $input->getArgument('version');
+
+        if ($this->config->getSystemValue('debug', false) === false) {
+            $olderVersions = $ms->getMigratedVersions();
+            $olderVersions[] = '0';
+            $olderVersions[] = 'prev';
+            if (in_array($version,  $olderVersions, true)) {
+                $output->writeln('<error>Can not go back to previous migration without debug enabled</error>');
+                return 1;
+            }
+        }
+
+
+        $ms->executeStep($version);
+        return 0;
+    }
+
+    /**
+     * @param string $optionName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeOptionValues($optionName, CompletionContext $context) {
+        return [];
+    }
+
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
+        if ($argumentName === 'app') {
+            $allApps = \OC_App::getAllApps();
+            return array_diff($allApps, \OC_App::getEnabledApps(true, true));
+        }
+
+        if ($argumentName === 'version') {
+            $appName = $context->getWordAtIndex($context->getWordIndex() - 1);
+
+            $ms = new MigrationService($appName, $this->connection);
+            $migrations = $ms->getAvailableVersions();
+
+            array_unshift($migrations, 'next', 'latest');
+            return $migrations;
+        }
+
+        return [];
+    }
 }

core/Command/Db/Migrations/StatusCommand.php

Indentation +107 added lines, -107 removed lines

@@ -36,111 +36,111 @@
 
 class StatusCommand extends Command implements CompletionAwareInterface {
 
-	/** @var Connection */
-	private $connection;
-
-	public function __construct(Connection $connection) {
-		$this->connection = $connection;
-		parent::__construct();
-	}
-
-	protected function configure() {
-		$this
-			->setName('migrations:status')
-			->setDescription('View the status of a set of migrations.')
-			->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on');
-	}
-
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		$appName = $input->getArgument('app');
-		$ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
-
-		$infos = $this->getMigrationsInfos($ms);
-		foreach ($infos as $key => $value) {
-			if (is_array($value)) {
-				$output->writeln("    <comment>>></comment> $key:");
-				foreach ($value as $subKey => $subValue) {
-					$output->writeln("        <comment>>></comment> $subKey: " . str_repeat(' ', 46 - strlen($subKey)) . $subValue);
-				}
-			} else {
-				$output->writeln("    <comment>>></comment> $key: " . str_repeat(' ', 50 - strlen($key)) . $value);
-			}
-		}
-		return 0;
-	}
-
-	/**
-	 * @param string $optionName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeOptionValues($optionName, CompletionContext $context) {
-		return [];
-	}
-
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
-		if ($argumentName === 'app') {
-			$allApps = \OC_App::getAllApps();
-			return array_diff($allApps, \OC_App::getEnabledApps(true, true));
-		}
-		return [];
-	}
-
-	/**
-	 * @param MigrationService $ms
-	 * @return array associative array of human readable info name as key and the actual information as value
-	 */
-	public function getMigrationsInfos(MigrationService $ms) {
-		$executedMigrations = $ms->getMigratedVersions();
-		$availableMigrations = $ms->getAvailableVersions();
-		$executedUnavailableMigrations = array_diff($executedMigrations, array_keys($availableMigrations));
-
-		$numExecutedUnavailableMigrations = count($executedUnavailableMigrations);
-		$numNewMigrations = count(array_diff(array_keys($availableMigrations), $executedMigrations));
-		$pending = $ms->describeMigrationStep('lastest');
-
-		$infos = [
-			'App' => $ms->getApp(),
-			'Version Table Name' => $ms->getMigrationsTableName(),
-			'Migrations Namespace' => $ms->getMigrationsNamespace(),
-			'Migrations Directory' => $ms->getMigrationsDirectory(),
-			'Previous Version' => $this->getFormattedVersionAlias($ms, 'prev'),
-			'Current Version' => $this->getFormattedVersionAlias($ms, 'current'),
-			'Next Version' => $this->getFormattedVersionAlias($ms, 'next'),
-			'Latest Version' => $this->getFormattedVersionAlias($ms, 'latest'),
-			'Executed Migrations' => count($executedMigrations),
-			'Executed Unavailable Migrations' => $numExecutedUnavailableMigrations,
-			'Available Migrations' => count($availableMigrations),
-			'New Migrations' => $numNewMigrations,
-			'Pending Migrations' => count($pending) ? $pending : 'None'
-		];
-
-		return $infos;
-	}
-
-	/**
-	 * @param MigrationService $migrationService
-	 * @param string $alias
-	 * @return mixed|null|string
-	 */
-	private function getFormattedVersionAlias(MigrationService $migrationService, $alias) {
-		$migration = $migrationService->getMigration($alias);
-		//No version found
-		if ($migration === null) {
-			if ($alias === 'next') {
-				return 'Already at latest migration step';
-			}
-
-			if ($alias === 'prev') {
-				return 'Already at first migration step';
-			}
-		}
-
-		return $migration;
-	}
+    /** @var Connection */
+    private $connection;
+
+    public function __construct(Connection $connection) {
+        $this->connection = $connection;
+        parent::__construct();
+    }
+
+    protected function configure() {
+        $this
+            ->setName('migrations:status')
+            ->setDescription('View the status of a set of migrations.')
+            ->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on');
+    }
+
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        $appName = $input->getArgument('app');
+        $ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
+
+        $infos = $this->getMigrationsInfos($ms);
+        foreach ($infos as $key => $value) {
+            if (is_array($value)) {
+                $output->writeln("    <comment>>></comment> $key:");
+                foreach ($value as $subKey => $subValue) {
+                    $output->writeln("        <comment>>></comment> $subKey: " . str_repeat(' ', 46 - strlen($subKey)) . $subValue);
+                }
+            } else {
+                $output->writeln("    <comment>>></comment> $key: " . str_repeat(' ', 50 - strlen($key)) . $value);
+            }
+        }
+        return 0;
+    }
+
+    /**
+     * @param string $optionName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeOptionValues($optionName, CompletionContext $context) {
+        return [];
+    }
+
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
+        if ($argumentName === 'app') {
+            $allApps = \OC_App::getAllApps();
+            return array_diff($allApps, \OC_App::getEnabledApps(true, true));
+        }
+        return [];
+    }
+
+    /**
+     * @param MigrationService $ms
+     * @return array associative array of human readable info name as key and the actual information as value
+     */
+    public function getMigrationsInfos(MigrationService $ms) {
+        $executedMigrations = $ms->getMigratedVersions();
+        $availableMigrations = $ms->getAvailableVersions();
+        $executedUnavailableMigrations = array_diff($executedMigrations, array_keys($availableMigrations));
+
+        $numExecutedUnavailableMigrations = count($executedUnavailableMigrations);
+        $numNewMigrations = count(array_diff(array_keys($availableMigrations), $executedMigrations));
+        $pending = $ms->describeMigrationStep('lastest');
+
+        $infos = [
+            'App' => $ms->getApp(),
+            'Version Table Name' => $ms->getMigrationsTableName(),
+            'Migrations Namespace' => $ms->getMigrationsNamespace(),
+            'Migrations Directory' => $ms->getMigrationsDirectory(),
+            'Previous Version' => $this->getFormattedVersionAlias($ms, 'prev'),
+            'Current Version' => $this->getFormattedVersionAlias($ms, 'current'),
+            'Next Version' => $this->getFormattedVersionAlias($ms, 'next'),
+            'Latest Version' => $this->getFormattedVersionAlias($ms, 'latest'),
+            'Executed Migrations' => count($executedMigrations),
+            'Executed Unavailable Migrations' => $numExecutedUnavailableMigrations,
+            'Available Migrations' => count($availableMigrations),
+            'New Migrations' => $numNewMigrations,
+            'Pending Migrations' => count($pending) ? $pending : 'None'
+        ];
+
+        return $infos;
+    }
+
+    /**
+     * @param MigrationService $migrationService
+     * @param string $alias
+     * @return mixed|null|string
+     */
+    private function getFormattedVersionAlias(MigrationService $migrationService, $alias) {
+        $migration = $migrationService->getMigration($alias);
+        //No version found
+        if ($migration === null) {
+            if ($alias === 'next') {
+                return 'Already at latest migration step';
+            }
+
+            if ($alias === 'prev') {
+                return 'Already at first migration step';
+            }
+        }
+
+        return $migration;
+    }
 }

core/Command/Db/Migrations/GenerateCommand.php

Indentation +127 added lines, -127 removed lines

@@ -38,8 +38,8 @@ 
 use Symfony\Component\Console\Output\OutputInterface;
 
 class GenerateCommand extends Command implements CompletionAwareInterface {
-	protected static $_templateSimple =
-		'<?php
+    protected static $_templateSimple =
+        '<?php
 
 declare(strict_types=1);
 
@@ -83,129 +83,129 @@ 
 }
 ';
 
-	/** @var Connection */
-	protected $connection;
-
-	/** @var IAppManager */
-	protected $appManager;
-
-	/**
-	 * @param Connection $connection
-	 * @param IAppManager $appManager
-	 */
-	public function __construct(Connection $connection, IAppManager $appManager) {
-		$this->connection = $connection;
-		$this->appManager = $appManager;
-
-		parent::__construct();
-	}
-
-	protected function configure() {
-		$this
-			->setName('migrations:generate')
-			->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on')
-			->addArgument('version', InputArgument::REQUIRED, 'Major version of this app, to allow versions on parallel development branches')
-		;
-
-		parent::configure();
-	}
-
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		$appName = $input->getArgument('app');
-		$version = $input->getArgument('version');
-
-		if (!preg_match('/^\d{1,16}$/',$version)) {
-			$output->writeln('<error>The given version is invalid. Only 0-9 are allowed (max. 16 digits)</error>');
-			return 1;
-		}
-
-		$ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
-
-		$date = date('YmdHis');
-		$path = $this->generateMigration($ms, 'Version' . $version . 'Date' . $date);
-
-		$output->writeln("New migration class has been generated to <info>$path</info>");
-		return 0;
-	}
-
-	/**
-	 * @param string $optionName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeOptionValues($optionName, CompletionContext $context) {
-		return [];
-	}
-
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
-		if ($argumentName === 'app') {
-			$allApps = \OC_App::getAllApps();
-			return array_diff($allApps, \OC_App::getEnabledApps(true, true));
-		}
-
-		if ($argumentName === 'version') {
-			$appName = $context->getWordAtIndex($context->getWordIndex() - 1);
-
-			$version = explode('.', $this->appManager->getAppVersion($appName));
-			return [$version[0] . sprintf('%1$03d', $version[1])];
-		}
-
-		return [];
-	}
-
-	/**
-	 * @param MigrationService $ms
-	 * @param string $className
-	 * @param string $schemaBody
-	 * @return string
-	 */
-	protected function generateMigration(MigrationService $ms, $className, $schemaBody = '') {
-		if ($schemaBody === '') {
-			$schemaBody = "\t\t" . 'return null;';
-		}
-
-
-		$placeHolders = [
-			'{{namespace}}',
-			'{{classname}}',
-			'{{schemabody}}',
-		];
-		$replacements = [
-			$ms->getMigrationsNamespace(),
-			$className,
-			$schemaBody,
-		];
-		$code = str_replace($placeHolders, $replacements, self::$_templateSimple);
-		$dir = $ms->getMigrationsDirectory();
-
-		$this->ensureMigrationDirExists($dir);
-		$path = $dir . '/' . $className . '.php';
-
-		if (file_put_contents($path, $code) === false) {
-			throw new RuntimeException('Failed to generate new migration step.');
-		}
-
-		return $path;
-	}
-
-	protected function ensureMigrationDirExists($directory) {
-		if (file_exists($directory) && is_dir($directory)) {
-			return;
-		}
-
-		if (file_exists($directory)) {
-			throw new \RuntimeException("Could not create folder \"$directory\"");
-		}
-
-		$this->ensureMigrationDirExists(dirname($directory));
-
-		if (!@mkdir($directory) && !is_dir($directory)) {
-			throw new \RuntimeException("Could not create folder \"$directory\"");
-		}
-	}
+    /** @var Connection */
+    protected $connection;
+
+    /** @var IAppManager */
+    protected $appManager;
+
+    /**
+     * @param Connection $connection
+     * @param IAppManager $appManager
+     */
+    public function __construct(Connection $connection, IAppManager $appManager) {
+        $this->connection = $connection;
+        $this->appManager = $appManager;
+
+        parent::__construct();
+    }
+
+    protected function configure() {
+        $this
+            ->setName('migrations:generate')
+            ->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on')
+            ->addArgument('version', InputArgument::REQUIRED, 'Major version of this app, to allow versions on parallel development branches')
+        ;
+
+        parent::configure();
+    }
+
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        $appName = $input->getArgument('app');
+        $version = $input->getArgument('version');
+
+        if (!preg_match('/^\d{1,16}$/',$version)) {
+            $output->writeln('<error>The given version is invalid. Only 0-9 are allowed (max. 16 digits)</error>');
+            return 1;
+        }
+
+        $ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
+
+        $date = date('YmdHis');
+        $path = $this->generateMigration($ms, 'Version' . $version . 'Date' . $date);
+
+        $output->writeln("New migration class has been generated to <info>$path</info>");
+        return 0;
+    }
+
+    /**
+     * @param string $optionName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeOptionValues($optionName, CompletionContext $context) {
+        return [];
+    }
+
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
+        if ($argumentName === 'app') {
+            $allApps = \OC_App::getAllApps();
+            return array_diff($allApps, \OC_App::getEnabledApps(true, true));
+        }
+
+        if ($argumentName === 'version') {
+            $appName = $context->getWordAtIndex($context->getWordIndex() - 1);
+
+            $version = explode('.', $this->appManager->getAppVersion($appName));
+            return [$version[0] . sprintf('%1$03d', $version[1])];
+        }
+
+        return [];
+    }
+
+    /**
+     * @param MigrationService $ms
+     * @param string $className
+     * @param string $schemaBody
+     * @return string
+     */
+    protected function generateMigration(MigrationService $ms, $className, $schemaBody = '') {
+        if ($schemaBody === '') {
+            $schemaBody = "\t\t" . 'return null;';
+        }
+
+
+        $placeHolders = [
+            '{{namespace}}',
+            '{{classname}}',
+            '{{schemabody}}',
+        ];
+        $replacements = [
+            $ms->getMigrationsNamespace(),
+            $className,
+            $schemaBody,
+        ];
+        $code = str_replace($placeHolders, $replacements, self::$_templateSimple);
+        $dir = $ms->getMigrationsDirectory();
+
+        $this->ensureMigrationDirExists($dir);
+        $path = $dir . '/' . $className . '.php';
+
+        if (file_put_contents($path, $code) === false) {
+            throw new RuntimeException('Failed to generate new migration step.');
+        }
+
+        return $path;
+    }
+
+    protected function ensureMigrationDirExists($directory) {
+        if (file_exists($directory) && is_dir($directory)) {
+            return;
+        }
+
+        if (file_exists($directory)) {
+            throw new \RuntimeException("Could not create folder \"$directory\"");
+        }
+
+        $this->ensureMigrationDirExists(dirname($directory));
+
+        if (!@mkdir($directory) && !is_dir($directory)) {
+            throw new \RuntimeException("Could not create folder \"$directory\"");
+        }
+    }
 }

core/Command/Db/Migrations/GenerateFromSchemaFileCommand.php

Indentation +99 added lines, -99 removed lines

@@ -37,170 +37,170 @@
 
 class GenerateFromSchemaFileCommand extends GenerateCommand {
 
-	/** @var IConfig */
-	protected $config;
+    /** @var IConfig */
+    protected $config;
 
-	public function __construct(IConfig $config, IAppManager $appManager, Connection $connection) {
-		parent::__construct($connection, $appManager);
-		$this->config = $config;
-	}
+    public function __construct(IConfig $config, IAppManager $appManager, Connection $connection) {
+        parent::__construct($connection, $appManager);
+        $this->config = $config;
+    }
 
 
-	protected function configure() {
-		parent::configure();
+    protected function configure() {
+        parent::configure();
 
-		$this->setName('migrations:generate-from-schema');
-	}
+        $this->setName('migrations:generate-from-schema');
+    }
 
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		$appName = $input->getArgument('app');
-		$version = $input->getArgument('version');
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        $appName = $input->getArgument('app');
+        $version = $input->getArgument('version');
 
-		if (!preg_match('/^\d{1,16}$/',$version)) {
-			$output->writeln('<error>The given version is invalid. Only 0-9 are allowed (max. 16 digits)</error>');
-			return 1;
-		}
+        if (!preg_match('/^\d{1,16}$/',$version)) {
+            $output->writeln('<error>The given version is invalid. Only 0-9 are allowed (max. 16 digits)</error>');
+            return 1;
+        }
 
-		$schemaFile = $this->appManager->getAppPath($appName) . '/appinfo/database.xml';
-		if (!file_exists($schemaFile)) {
-			$output->writeln('<error>App ' . $appName . ' does not have a database.xml file</error>');
-			return 2;
-		}
+        $schemaFile = $this->appManager->getAppPath($appName) . '/appinfo/database.xml';
+        if (!file_exists($schemaFile)) {
+            $output->writeln('<error>App ' . $appName . ' does not have a database.xml file</error>');
+            return 2;
+        }
 
-		$reader = new MDB2SchemaReader($this->config, $this->connection->getDatabasePlatform());
-		$schema = new Schema();
-		$reader->loadSchemaFromFile($schemaFile, $schema);
+        $reader = new MDB2SchemaReader($this->config, $this->connection->getDatabasePlatform());
+        $schema = new Schema();
+        $reader->loadSchemaFromFile($schemaFile, $schema);
 
-		$schemaBody = $this->schemaToMigration($schema);
+        $schemaBody = $this->schemaToMigration($schema);
 
-		$ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
+        $ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
 
-		$date = date('YmdHis');
-		$path = $this->generateMigration($ms, 'Version' . $version . 'Date' . $date, $schemaBody);
+        $date = date('YmdHis');
+        $path = $this->generateMigration($ms, 'Version' . $version . 'Date' . $date, $schemaBody);
 
-		$output->writeln("New migration class has been generated to <info>$path</info>");
-		return 0;
-	}
+        $output->writeln("New migration class has been generated to <info>$path</info>");
+        return 0;
+    }
 
-	/**
-	 * @param Schema $schema
-	 * @return string
-	 */
-	protected function schemaToMigration(Schema $schema) {
-		$content = <<<'EOT'
+    /**
+     * @param Schema $schema
+     * @return string
+     */
+    protected function schemaToMigration(Schema $schema) {
+        $content = <<<'EOT'
 		/** @var ISchemaWrapper $schema */
 		$schema = $schemaClosure();
 
 EOT;
 
-		foreach ($schema->getTables() as $table) {
-			$content .= str_replace('{{table-name}}', substr($table->getName(), 3), <<<'EOT'
+        foreach ($schema->getTables() as $table) {
+            $content .= str_replace('{{table-name}}', substr($table->getName(), 3), <<<'EOT'
 
 		if (!$schema->hasTable('{{table-name}}')) {
 			$table = $schema->createTable('{{table-name}}');
 
 EOT
-			);
+            );
 
-			foreach ($table->getColumns() as $column) {
-				$content .= str_replace(['{{name}}', '{{type}}'], [$column->getName(), $column->getType()->getName()], <<<'EOT'
+            foreach ($table->getColumns() as $column) {
+                $content .= str_replace(['{{name}}', '{{type}}'], [$column->getName(), $column->getType()->getName()], <<<'EOT'
 			$table->addColumn('{{name}}', '{{type}}', [
 
 EOT
-				);
-				if ($column->getAutoincrement()) {
-					$content .= <<<'EOT'
+                );
+                if ($column->getAutoincrement()) {
+                    $content .= <<<'EOT'
 				'autoincrement' => true,
 
 EOT;
-				}
-				$content .= str_replace('{{notnull}}', $column->getNotnull() ? 'true' : 'false', <<<'EOT'
+                }
+                $content .= str_replace('{{notnull}}', $column->getNotnull() ? 'true' : 'false', <<<'EOT'
 				'notnull' => {{notnull}},
 
 EOT
-				);
-				if ($column->getLength() !== null) {
-					$content .= str_replace('{{length}}', $column->getLength(), <<<'EOT'
+                );
+                if ($column->getLength() !== null) {
+                    $content .= str_replace('{{length}}', $column->getLength(), <<<'EOT'
 				'length' => {{length}},
 
 EOT
-					);
-				}
-				$default = $column->getDefault();
-				if ($default !== null) {
-					if (is_string($default)) {
-						$default = "'$default'";
-					} elseif (is_bool($default)) {
-						$default = ($default === true) ? 'true' : 'false';
-					}
-					$content .= str_replace('{{default}}', $default, <<<'EOT'
+                    );
+                }
+                $default = $column->getDefault();
+                if ($default !== null) {
+                    if (is_string($default)) {
+                        $default = "'$default'";
+                    } elseif (is_bool($default)) {
+                        $default = ($default === true) ? 'true' : 'false';
+                    }
+                    $content .= str_replace('{{default}}', $default, <<<'EOT'
 				'default' => {{default}},
 
 EOT
-					);
-				}
-				if ($column->getUnsigned()) {
-					$content .= <<<'EOT'
+                    );
+                }
+                if ($column->getUnsigned()) {
+                    $content .= <<<'EOT'
 				'unsigned' => true,
 
 EOT;
-				}
+                }
 
-				$content .= <<<'EOT'
+                $content .= <<<'EOT'
 			]);
 
 EOT;
-			}
+            }
 
-			$content .= <<<'EOT'
+            $content .= <<<'EOT'
 
 EOT;
 
-			$primaryKey = $table->getPrimaryKey();
-			if ($primaryKey !== null) {
-				$content .= str_replace('{{columns}}', implode('\', \'', $primaryKey->getUnquotedColumns()), <<<'EOT'
+            $primaryKey = $table->getPrimaryKey();
+            if ($primaryKey !== null) {
+                $content .= str_replace('{{columns}}', implode('\', \'', $primaryKey->getUnquotedColumns()), <<<'EOT'
 			$table->setPrimaryKey(['{{columns}}']);
 
 EOT
-				);
-			}
-
-			foreach ($table->getIndexes() as $index) {
-				if ($index->isPrimary()) {
-					continue;
-				}
-
-				if ($index->isUnique()) {
-					$content .= str_replace(
-						['{{columns}}', '{{name}}'],
-						[implode('\', \'', $index->getUnquotedColumns()), $index->getName()],
-						<<<'EOT'
+                );
+            }
+
+            foreach ($table->getIndexes() as $index) {
+                if ($index->isPrimary()) {
+                    continue;
+                }
+
+                if ($index->isUnique()) {
+                    $content .= str_replace(
+                        ['{{columns}}', '{{name}}'],
+                        [implode('\', \'', $index->getUnquotedColumns()), $index->getName()],
+                        <<<'EOT'
 			$table->addUniqueIndex(['{{columns}}'], '{{name}}');
 
 EOT
-					);
-				} else {
-					$content .= str_replace(
-						['{{columns}}', '{{name}}'],
-						[implode('\', \'', $index->getUnquotedColumns()), $index->getName()],
-						<<<'EOT'
+                    );
+                } else {
+                    $content .= str_replace(
+                        ['{{columns}}', '{{name}}'],
+                        [implode('\', \'', $index->getUnquotedColumns()), $index->getName()],
+                        <<<'EOT'
 			$table->addIndex(['{{columns}}'], '{{name}}');
 
 EOT
-					);
-				}
-			}
+                    );
+                }
+            }
 
-			$content .= <<<'EOT'
+            $content .= <<<'EOT'
 		}
 
 EOT;
-		}
+        }
 
-		$content .= <<<'EOT'
+        $content .= <<<'EOT'
 		return $schema;
 EOT;
 
-		return $content;
-	}
+        return $content;
+    }
 }

core/Command/Db/Migrations/MigrateCommand.php

Indentation +51 added lines, -51 removed lines

@@ -34,66 +34,66 @@
 
 class MigrateCommand extends Command implements CompletionAwareInterface {
 
-	/** @var Connection */
-	private $connection;
+    /** @var Connection */
+    private $connection;
 
-	/**
-	 * @param Connection $connection
-	 */
-	public function __construct(Connection $connection) {
-		$this->connection = $connection;
-		parent::__construct();
-	}
+    /**
+     * @param Connection $connection
+     */
+    public function __construct(Connection $connection) {
+        $this->connection = $connection;
+        parent::__construct();
+    }
 
-	protected function configure() {
-		$this
-			->setName('migrations:migrate')
-			->setDescription('Execute a migration to a specified version or the latest available version.')
-			->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on')
-			->addArgument('version', InputArgument::OPTIONAL, 'The version number (YYYYMMDDHHMMSS) or alias (first, prev, next, latest) to migrate to.', 'latest');
+    protected function configure() {
+        $this
+            ->setName('migrations:migrate')
+            ->setDescription('Execute a migration to a specified version or the latest available version.')
+            ->addArgument('app', InputArgument::REQUIRED, 'Name of the app this migration command shall work on')
+            ->addArgument('version', InputArgument::OPTIONAL, 'The version number (YYYYMMDDHHMMSS) or alias (first, prev, next, latest) to migrate to.', 'latest');
 
-		parent::configure();
-	}
+        parent::configure();
+    }
 
-	public function execute(InputInterface $input, OutputInterface $output): int {
-		$appName = $input->getArgument('app');
-		$ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
-		$version = $input->getArgument('version');
+    public function execute(InputInterface $input, OutputInterface $output): int {
+        $appName = $input->getArgument('app');
+        $ms = new MigrationService($appName, $this->connection, new ConsoleOutput($output));
+        $version = $input->getArgument('version');
 
-		$ms->migrate($version);
-		return 0;
-	}
+        $ms->migrate($version);
+        return 0;
+    }
 
-	/**
-	 * @param string $optionName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeOptionValues($optionName, CompletionContext $context) {
-		return [];
-	}
+    /**
+     * @param string $optionName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeOptionValues($optionName, CompletionContext $context) {
+        return [];
+    }
 
-	/**
-	 * @param string $argumentName
-	 * @param CompletionContext $context
-	 * @return string[]
-	 */
-	public function completeArgumentValues($argumentName, CompletionContext $context) {
-		if ($argumentName === 'app') {
-			$allApps = \OC_App::getAllApps();
-			return array_diff($allApps, \OC_App::getEnabledApps(true, true));
-		}
+    /**
+     * @param string $argumentName
+     * @param CompletionContext $context
+     * @return string[]
+     */
+    public function completeArgumentValues($argumentName, CompletionContext $context) {
+        if ($argumentName === 'app') {
+            $allApps = \OC_App::getAllApps();
+            return array_diff($allApps, \OC_App::getEnabledApps(true, true));
+        }
 
-		if ($argumentName === 'version') {
-			$appName = $context->getWordAtIndex($context->getWordIndex() - 1);
+        if ($argumentName === 'version') {
+            $appName = $context->getWordAtIndex($context->getWordIndex() - 1);
 
-			$ms = new MigrationService($appName, $this->connection);
-			$migrations = $ms->getAvailableVersions();
+            $ms = new MigrationService($appName, $this->connection);
+            $migrations = $ms->getAvailableVersions();
 
-			array_unshift($migrations, 'next', 'latest');
-			return $migrations;
-		}
+            array_unshift($migrations, 'next', 'latest');
+            return $migrations;
+        }
 
-		return [];
-	}
+        return [];
+    }
 }

core/Command/Db/ConvertFilecacheBigInt.php

Indentation +87 added lines, -87 removed lines

@@ -43,91 +43,91 @@
 
 class ConvertFilecacheBigInt extends Command {
 
-	/** @var Connection */
-	private $connection;
-
-	/**
-	 * @param Connection $connection
-	 */
-	public function __construct(Connection $connection) {
-		$this->connection = $connection;
-		parent::__construct();
-	}
-
-	protected function configure() {
-		$this
-			->setName('db:convert-filecache-bigint')
-			->setDescription('Convert the ID columns of the filecache to BigInt');
-	}
-
-	protected function getColumnsByTable() {
-		// also update in CheckSetupController::hasBigIntConversionPendingColumns()
-		return [
-			'activity' => ['activity_id', 'object_id'],
-			'activity_mq' => ['mail_id'],
-			'authtoken' => ['id'],
-			'bruteforce_attempts' => ['id'],
-			'federated_reshares' => ['share_id'],
-			'filecache' => ['fileid', 'storage', 'parent', 'mimetype', 'mimepart', 'mtime', 'storage_mtime'],
-			'filecache_extended' => ['fileid'],
-			'files_trash' => ['auto_id'],
-			'file_locks' => ['id'],
-			'jobs' => ['id'],
-			'mimetypes' => ['id'],
-			'mounts' => ['id', 'storage_id', 'root_id', 'mount_id'],
-			'share_external' => ['id', 'parent'],
-			'storages' => ['numeric_id'],
-		];
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$schema = new SchemaWrapper($this->connection);
-		$isSqlite = $this->connection->getDatabasePlatform() instanceof SqlitePlatform;
-		$updates = [];
-
-		$tables = $this->getColumnsByTable();
-		foreach ($tables as $tableName => $columns) {
-			if (!$schema->hasTable($tableName)) {
-				continue;
-			}
-
-			$table = $schema->getTable($tableName);
-
-			foreach ($columns as $columnName) {
-				$column = $table->getColumn($columnName);
-				$isAutoIncrement = $column->getAutoincrement();
-				$isAutoIncrementOnSqlite = $isSqlite && $isAutoIncrement;
-				if ($column->getType()->getName() !== Types::BIGINT && !$isAutoIncrementOnSqlite) {
-					$column->setType(Type::getType(Types::BIGINT));
-					$column->setOptions(['length' => 20]);
-
-					$updates[] = '* ' . $tableName . '.' . $columnName;
-				}
-			}
-		}
-
-		if (empty($updates)) {
-			$output->writeln('<info>All tables already up to date!</info>');
-			return 0;
-		}
-
-		$output->writeln('<comment>Following columns will be updated:</comment>');
-		$output->writeln('');
-		$output->writeln($updates);
-		$output->writeln('');
-		$output->writeln('<comment>This can take up to hours, depending on the number of files in your instance!</comment>');
-
-		if ($input->isInteractive()) {
-			$helper = $this->getHelper('question');
-			$question = new ConfirmationQuestion('Continue with the conversion (y/n)? [n] ', false);
-
-			if (!$helper->ask($input, $output, $question)) {
-				return 1;
-			}
-		}
-
-		$this->connection->migrateToSchema($schema->getWrappedSchema());
-
-		return 0;
-	}
+    /** @var Connection */
+    private $connection;
+
+    /**
+     * @param Connection $connection
+     */
+    public function __construct(Connection $connection) {
+        $this->connection = $connection;
+        parent::__construct();
+    }
+
+    protected function configure() {
+        $this
+            ->setName('db:convert-filecache-bigint')
+            ->setDescription('Convert the ID columns of the filecache to BigInt');
+    }
+
+    protected function getColumnsByTable() {
+        // also update in CheckSetupController::hasBigIntConversionPendingColumns()
+        return [
+            'activity' => ['activity_id', 'object_id'],
+            'activity_mq' => ['mail_id'],
+            'authtoken' => ['id'],
+            'bruteforce_attempts' => ['id'],
+            'federated_reshares' => ['share_id'],
+            'filecache' => ['fileid', 'storage', 'parent', 'mimetype', 'mimepart', 'mtime', 'storage_mtime'],
+            'filecache_extended' => ['fileid'],
+            'files_trash' => ['auto_id'],
+            'file_locks' => ['id'],
+            'jobs' => ['id'],
+            'mimetypes' => ['id'],
+            'mounts' => ['id', 'storage_id', 'root_id', 'mount_id'],
+            'share_external' => ['id', 'parent'],
+            'storages' => ['numeric_id'],
+        ];
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $schema = new SchemaWrapper($this->connection);
+        $isSqlite = $this->connection->getDatabasePlatform() instanceof SqlitePlatform;
+        $updates = [];
+
+        $tables = $this->getColumnsByTable();
+        foreach ($tables as $tableName => $columns) {
+            if (!$schema->hasTable($tableName)) {
+                continue;
+            }
+
+            $table = $schema->getTable($tableName);
+
+            foreach ($columns as $columnName) {
+                $column = $table->getColumn($columnName);
+                $isAutoIncrement = $column->getAutoincrement();
+                $isAutoIncrementOnSqlite = $isSqlite && $isAutoIncrement;
+                if ($column->getType()->getName() !== Types::BIGINT && !$isAutoIncrementOnSqlite) {
+                    $column->setType(Type::getType(Types::BIGINT));
+                    $column->setOptions(['length' => 20]);
+
+                    $updates[] = '* ' . $tableName . '.' . $columnName;
+                }
+            }
+        }
+
+        if (empty($updates)) {
+            $output->writeln('<info>All tables already up to date!</info>');
+            return 0;
+        }
+
+        $output->writeln('<comment>Following columns will be updated:</comment>');
+        $output->writeln('');
+        $output->writeln($updates);
+        $output->writeln('');
+        $output->writeln('<comment>This can take up to hours, depending on the number of files in your instance!</comment>');
+
+        if ($input->isInteractive()) {
+            $helper = $this->getHelper('question');
+            $question = new ConfirmationQuestion('Continue with the conversion (y/n)? [n] ', false);
+
+            if (!$helper->ask($input, $output, $question)) {
+                return 1;
+            }
+        }
+
+        $this->connection->migrateToSchema($schema->getWrappedSchema());
+
+        return 0;
+    }
 }

core/Command/Db/AddMissingIndices.php

Indentation +263 added lines, -263 removed lines

@@ -52,267 +52,267 @@
  */
 class AddMissingIndices extends Command {
 
-	/** @var Connection */
-	private $connection;
-
-	/** @var EventDispatcherInterface */
-	private $dispatcher;
-
-	public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
-		parent::__construct();
-
-		$this->connection = $connection;
-		$this->dispatcher = $dispatcher;
-	}
-
-	protected function configure() {
-		$this
-			->setName('db:add-missing-indices')
-			->setDescription('Add missing indices to the database tables');
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$this->addCoreIndexes($output);
-
-		// Dispatch event so apps can also update indexes if needed
-		$event = new GenericEvent($output);
-		$this->dispatcher->dispatch(IDBConnection::ADD_MISSING_INDEXES_EVENT, $event);
-		return 0;
-	}
-
-	/**
-	 * add missing indices to the share table
-	 *
-	 * @param OutputInterface $output
-	 * @throws \Doctrine\DBAL\Schema\SchemaException
-	 */
-	private function addCoreIndexes(OutputInterface $output) {
-		$output->writeln('<info>Check indices of the share table.</info>');
-
-		$schema = new SchemaWrapper($this->connection);
-		$updated = false;
-
-		if ($schema->hasTable('share')) {
-			$table = $schema->getTable('share');
-			if (!$table->hasIndex('share_with_index')) {
-				$output->writeln('<info>Adding additional share_with index to the share table, this can take some time...</info>');
-				$table->addIndex(['share_with'], 'share_with_index');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>Share table updated successfully.</info>');
-			}
-
-			if (!$table->hasIndex('parent_index')) {
-				$output->writeln('<info>Adding additional parent index to the share table, this can take some time...</info>');
-				$table->addIndex(['parent'], 'parent_index');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>Share table updated successfully.</info>');
-			}
-
-			if (!$table->hasIndex('owner_index')) {
-				$output->writeln('<info>Adding additional owner index to the share table, this can take some time...</info>');
-				$table->addIndex(['uid_owner'], 'owner_index');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>Share table updated successfully.</info>');
-			}
-
-			if (!$table->hasIndex('initiator_index')) {
-				$output->writeln('<info>Adding additional initiator index to the share table, this can take some time...</info>');
-				$table->addIndex(['uid_initiator'], 'initiator_index');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>Share table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the filecache table.</info>');
-		if ($schema->hasTable('filecache')) {
-			$table = $schema->getTable('filecache');
-			if (!$table->hasIndex('fs_mtime')) {
-				$output->writeln('<info>Adding additional mtime index to the filecache table, this can take some time...</info>');
-				$table->addIndex(['mtime'], 'fs_mtime');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>Filecache table updated successfully.</info>');
-			}
-			if (!$table->hasIndex('fs_size')) {
-				$output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>');
-				$table->addIndex(['size'], 'fs_size');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>Filecache table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the twofactor_providers table.</info>');
-		if ($schema->hasTable('twofactor_providers')) {
-			$table = $schema->getTable('twofactor_providers');
-			if (!$table->hasIndex('twofactor_providers_uid')) {
-				$output->writeln('<info>Adding additional twofactor_providers_uid index to the twofactor_providers table, this can take some time...</info>');
-				$table->addIndex(['uid'], 'twofactor_providers_uid');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>Twofactor_providers table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the login_flow_v2 table.</info>');
-		if ($schema->hasTable('login_flow_v2')) {
-			$table = $schema->getTable('login_flow_v2');
-			if (!$table->hasIndex('poll_token')) {
-				$output->writeln('<info>Adding additional indeces to the login_flow_v2 table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					$columns = $index->getColumns();
-					if ($columns === ['poll_token'] ||
-						$columns === ['login_token'] ||
-						$columns === ['timestamp']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addUniqueIndex(['poll_token'], 'poll_token');
-				$table->addUniqueIndex(['login_token'], 'login_token');
-				$table->addIndex(['timestamp'], 'timestamp');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>login_flow_v2 table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the whats_new table.</info>');
-		if ($schema->hasTable('whats_new')) {
-			$table = $schema->getTable('whats_new');
-			if (!$table->hasIndex('version')) {
-				$output->writeln('<info>Adding version index to the whats_new table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['version']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addUniqueIndex(['version'], 'version');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>whats_new table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the cards table.</info>');
-		$cardsUpdated = false;
-		if ($schema->hasTable('cards')) {
-			$table = $schema->getTable('cards');
-
-			if ($table->hasIndex('addressbookid_uri_index')) {
-				$output->writeln('<info>Renaming addressbookid_uri_index index to  to the cards table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['addressbookid', 'uri']) {
-						$table->renameIndex('addressbookid_uri_index', 'cards_abiduri');
-					}
-				}
-
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$cardsUpdated = true;
-			}
-
-			if (!$table->hasIndex('cards_abid')) {
-				$output->writeln('<info>Adding cards_abid index to the cards table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['addressbookid']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addIndex(['addressbookid'], 'cards_abid');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$cardsUpdated = true;
-			}
-
-			if (!$table->hasIndex('cards_abiduri')) {
-				$output->writeln('<info>Adding cards_abiduri index to the cards table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['addressbookid', 'uri']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addIndex(['addressbookid', 'uri'], 'cards_abiduri');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$cardsUpdated = true;
-			}
-
-			if ($cardsUpdated) {
-				$updated = true;
-				$output->writeln('<info>cards table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the cards_properties table.</info>');
-		if ($schema->hasTable('cards_properties')) {
-			$table = $schema->getTable('cards_properties');
-			if (!$table->hasIndex('cards_prop_abid')) {
-				$output->writeln('<info>Adding cards_prop_abid index to the cards_properties table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['addressbookid']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addIndex(['addressbookid'], 'cards_prop_abid');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>cards_properties table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the calendarobjects_props table.</info>');
-		if ($schema->hasTable('calendarobjects_props')) {
-			$table = $schema->getTable('calendarobjects_props');
-			if (!$table->hasIndex('calendarobject_calid_index')) {
-				$output->writeln('<info>Adding calendarobject_calid_index index to the calendarobjects_props table, this can take some time...</info>');
-
-				$table->addIndex(['calendarid', 'calendartype'], 'calendarobject_calid_index');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>calendarobjects_props table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the schedulingobjects table.</info>');
-		if ($schema->hasTable('schedulingobjects')) {
-			$table = $schema->getTable('schedulingobjects');
-			if (!$table->hasIndex('schedulobj_principuri_index')) {
-				$output->writeln('<info>Adding schedulobj_principuri_index index to the schedulingobjects table, this can take some time...</info>');
-
-				$table->addIndex(['principaluri'], 'schedulobj_principuri_index');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>schedulingobjects table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the oc_properties table.</info>');
-		if ($schema->hasTable('properties')) {
-			$table = $schema->getTable('properties');
-			if (!$table->hasIndex('properties_path_index')) {
-				$output->writeln('<info>Adding properties_path_index index to the oc_properties table, this can take some time...</info>');
-
-				$table->addIndex(['userid', 'propertypath'], 'properties_path_index');
-				$this->connection->migrateToSchema($schema->getWrappedSchema());
-				$updated = true;
-				$output->writeln('<info>oc_properties table updated successfully.</info>');
-			}
-		}
-
-		if (!$updated) {
-			$output->writeln('<info>Done.</info>');
-		}
-	}
+    /** @var Connection */
+    private $connection;
+
+    /** @var EventDispatcherInterface */
+    private $dispatcher;
+
+    public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
+        parent::__construct();
+
+        $this->connection = $connection;
+        $this->dispatcher = $dispatcher;
+    }
+
+    protected function configure() {
+        $this
+            ->setName('db:add-missing-indices')
+            ->setDescription('Add missing indices to the database tables');
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $this->addCoreIndexes($output);
+
+        // Dispatch event so apps can also update indexes if needed
+        $event = new GenericEvent($output);
+        $this->dispatcher->dispatch(IDBConnection::ADD_MISSING_INDEXES_EVENT, $event);
+        return 0;
+    }
+
+    /**
+     * add missing indices to the share table
+     *
+     * @param OutputInterface $output
+     * @throws \Doctrine\DBAL\Schema\SchemaException
+     */
+    private function addCoreIndexes(OutputInterface $output) {
+        $output->writeln('<info>Check indices of the share table.</info>');
+
+        $schema = new SchemaWrapper($this->connection);
+        $updated = false;
+
+        if ($schema->hasTable('share')) {
+            $table = $schema->getTable('share');
+            if (!$table->hasIndex('share_with_index')) {
+                $output->writeln('<info>Adding additional share_with index to the share table, this can take some time...</info>');
+                $table->addIndex(['share_with'], 'share_with_index');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>Share table updated successfully.</info>');
+            }
+
+            if (!$table->hasIndex('parent_index')) {
+                $output->writeln('<info>Adding additional parent index to the share table, this can take some time...</info>');
+                $table->addIndex(['parent'], 'parent_index');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>Share table updated successfully.</info>');
+            }
+
+            if (!$table->hasIndex('owner_index')) {
+                $output->writeln('<info>Adding additional owner index to the share table, this can take some time...</info>');
+                $table->addIndex(['uid_owner'], 'owner_index');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>Share table updated successfully.</info>');
+            }
+
+            if (!$table->hasIndex('initiator_index')) {
+                $output->writeln('<info>Adding additional initiator index to the share table, this can take some time...</info>');
+                $table->addIndex(['uid_initiator'], 'initiator_index');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>Share table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the filecache table.</info>');
+        if ($schema->hasTable('filecache')) {
+            $table = $schema->getTable('filecache');
+            if (!$table->hasIndex('fs_mtime')) {
+                $output->writeln('<info>Adding additional mtime index to the filecache table, this can take some time...</info>');
+                $table->addIndex(['mtime'], 'fs_mtime');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>Filecache table updated successfully.</info>');
+            }
+            if (!$table->hasIndex('fs_size')) {
+                $output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>');
+                $table->addIndex(['size'], 'fs_size');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>Filecache table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the twofactor_providers table.</info>');
+        if ($schema->hasTable('twofactor_providers')) {
+            $table = $schema->getTable('twofactor_providers');
+            if (!$table->hasIndex('twofactor_providers_uid')) {
+                $output->writeln('<info>Adding additional twofactor_providers_uid index to the twofactor_providers table, this can take some time...</info>');
+                $table->addIndex(['uid'], 'twofactor_providers_uid');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>Twofactor_providers table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the login_flow_v2 table.</info>');
+        if ($schema->hasTable('login_flow_v2')) {
+            $table = $schema->getTable('login_flow_v2');
+            if (!$table->hasIndex('poll_token')) {
+                $output->writeln('<info>Adding additional indeces to the login_flow_v2 table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    $columns = $index->getColumns();
+                    if ($columns === ['poll_token'] ||
+                        $columns === ['login_token'] ||
+                        $columns === ['timestamp']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addUniqueIndex(['poll_token'], 'poll_token');
+                $table->addUniqueIndex(['login_token'], 'login_token');
+                $table->addIndex(['timestamp'], 'timestamp');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>login_flow_v2 table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the whats_new table.</info>');
+        if ($schema->hasTable('whats_new')) {
+            $table = $schema->getTable('whats_new');
+            if (!$table->hasIndex('version')) {
+                $output->writeln('<info>Adding version index to the whats_new table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['version']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addUniqueIndex(['version'], 'version');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>whats_new table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the cards table.</info>');
+        $cardsUpdated = false;
+        if ($schema->hasTable('cards')) {
+            $table = $schema->getTable('cards');
+
+            if ($table->hasIndex('addressbookid_uri_index')) {
+                $output->writeln('<info>Renaming addressbookid_uri_index index to  to the cards table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['addressbookid', 'uri']) {
+                        $table->renameIndex('addressbookid_uri_index', 'cards_abiduri');
+                    }
+                }
+
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $cardsUpdated = true;
+            }
+
+            if (!$table->hasIndex('cards_abid')) {
+                $output->writeln('<info>Adding cards_abid index to the cards table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['addressbookid']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addIndex(['addressbookid'], 'cards_abid');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $cardsUpdated = true;
+            }
+
+            if (!$table->hasIndex('cards_abiduri')) {
+                $output->writeln('<info>Adding cards_abiduri index to the cards table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['addressbookid', 'uri']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addIndex(['addressbookid', 'uri'], 'cards_abiduri');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $cardsUpdated = true;
+            }
+
+            if ($cardsUpdated) {
+                $updated = true;
+                $output->writeln('<info>cards table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the cards_properties table.</info>');
+        if ($schema->hasTable('cards_properties')) {
+            $table = $schema->getTable('cards_properties');
+            if (!$table->hasIndex('cards_prop_abid')) {
+                $output->writeln('<info>Adding cards_prop_abid index to the cards_properties table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['addressbookid']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addIndex(['addressbookid'], 'cards_prop_abid');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>cards_properties table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the calendarobjects_props table.</info>');
+        if ($schema->hasTable('calendarobjects_props')) {
+            $table = $schema->getTable('calendarobjects_props');
+            if (!$table->hasIndex('calendarobject_calid_index')) {
+                $output->writeln('<info>Adding calendarobject_calid_index index to the calendarobjects_props table, this can take some time...</info>');
+
+                $table->addIndex(['calendarid', 'calendartype'], 'calendarobject_calid_index');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>calendarobjects_props table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the schedulingobjects table.</info>');
+        if ($schema->hasTable('schedulingobjects')) {
+            $table = $schema->getTable('schedulingobjects');
+            if (!$table->hasIndex('schedulobj_principuri_index')) {
+                $output->writeln('<info>Adding schedulobj_principuri_index index to the schedulingobjects table, this can take some time...</info>');
+
+                $table->addIndex(['principaluri'], 'schedulobj_principuri_index');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>schedulingobjects table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the oc_properties table.</info>');
+        if ($schema->hasTable('properties')) {
+            $table = $schema->getTable('properties');
+            if (!$table->hasIndex('properties_path_index')) {
+                $output->writeln('<info>Adding properties_path_index index to the oc_properties table, this can take some time...</info>');
+
+                $table->addIndex(['userid', 'propertypath'], 'properties_path_index');
+                $this->connection->migrateToSchema($schema->getWrappedSchema());
+                $updated = true;
+                $output->writeln('<info>oc_properties table updated successfully.</info>');
+            }
+        }
+
+        if (!$updated) {
+            $output->writeln('<info>Done.</info>');
+        }
+    }
 }