nextcloud / server

lib/private/App/AppStore/Fetcher/AppFetcher.php

Doc Comments +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
 
 	/**
 	 * @param string $version
-	 * @param string $filename
+	 * @param string $fileName
 	 */
 	public function setVersion(string $version, string $fileName = 'apps.json') {
 		parent::setVersion($version);

Indentation +98 added lines, -98 removed lines

@@ -34,110 +34,110 @@
 use OCP\ILogger;
 
 class AppFetcher extends Fetcher {
-	/**
-	 * @param Factory $appDataFactory
-	 * @param IClientService $clientService
-	 * @param ITimeFactory $timeFactory
-	 * @param IConfig $config
-	 * @param ILogger $logger
-	 */
-	public function __construct(Factory $appDataFactory,
-								IClientService $clientService,
-								ITimeFactory $timeFactory,
-								IConfig $config,
-								ILogger $logger) {
-		parent::__construct(
-			$appDataFactory,
-			$clientService,
-			$timeFactory,
-			$config,
-			$logger
-		);
+    /**
+     * @param Factory $appDataFactory
+     * @param IClientService $clientService
+     * @param ITimeFactory $timeFactory
+     * @param IConfig $config
+     * @param ILogger $logger
+     */
+    public function __construct(Factory $appDataFactory,
+                                IClientService $clientService,
+                                ITimeFactory $timeFactory,
+                                IConfig $config,
+                                ILogger $logger) {
+        parent::__construct(
+            $appDataFactory,
+            $clientService,
+            $timeFactory,
+            $config,
+            $logger
+        );
 
-		$this->fileName = 'apps.json';
-		$this->setEndpoint();
-	}
+        $this->fileName = 'apps.json';
+        $this->setEndpoint();
+    }
 
-	/**
-	 * Only returns the latest compatible app release in the releases array
-	 *
-	 * @param string $ETag
-	 * @param string $content
-	 *
-	 * @return array
-	 */
-	protected function fetch($ETag, $content) {
-		/** @var mixed[] $response */
-		$response = parent::fetch($ETag, $content);
+    /**
+     * Only returns the latest compatible app release in the releases array
+     *
+     * @param string $ETag
+     * @param string $content
+     *
+     * @return array
+     */
+    protected function fetch($ETag, $content) {
+        /** @var mixed[] $response */
+        $response = parent::fetch($ETag, $content);
 
-		$ncVersion = $this->getVersion();
-		$ncMajorVersion = explode('.', $ncVersion)[0];
-		foreach($response['data'] as $dataKey => $app) {
-			$releases = [];
+        $ncVersion = $this->getVersion();
+        $ncMajorVersion = explode('.', $ncVersion)[0];
+        foreach($response['data'] as $dataKey => $app) {
+            $releases = [];
 
-			// Filter all compatible releases
-			foreach($app['releases'] as $release) {
-				// Exclude all nightly and pre-releases
-				if($release['isNightly'] === false
-					&& strpos($release['version'], '-') === false) {
-					// Exclude all versions not compatible with the current version
-					$versionParser = new VersionParser();
-					$version = $versionParser->getVersion($release['rawPlatformVersionSpec']);
-					if (
-						// Major version is bigger or equals to the minimum version of the app
-						version_compare($ncMajorVersion, $version->getMinimumVersion(), '>=')
-						// Major version is smaller or equals to the maximum version of the app
-						&& version_compare($ncMajorVersion, $version->getMaximumVersion(), '<=')
-					) {
-						$releases[] = $release;
-					}
-				}
-			}
+            // Filter all compatible releases
+            foreach($app['releases'] as $release) {
+                // Exclude all nightly and pre-releases
+                if($release['isNightly'] === false
+                    && strpos($release['version'], '-') === false) {
+                    // Exclude all versions not compatible with the current version
+                    $versionParser = new VersionParser();
+                    $version = $versionParser->getVersion($release['rawPlatformVersionSpec']);
+                    if (
+                        // Major version is bigger or equals to the minimum version of the app
+                        version_compare($ncMajorVersion, $version->getMinimumVersion(), '>=')
+                        // Major version is smaller or equals to the maximum version of the app
+                        && version_compare($ncMajorVersion, $version->getMaximumVersion(), '<=')
+                    ) {
+                        $releases[] = $release;
+                    }
+                }
+            }
 
-			// Get the highest version
-			$versions = [];
-			foreach($releases as $release) {
-				$versions[] = $release['version'];
-			}
-			usort($versions, 'version_compare');
-			$versions = array_reverse($versions);
-			$compatible = false;
-			if(isset($versions[0])) {
-				$highestVersion = $versions[0];
-				foreach ($releases as $release) {
-					if ((string)$release['version'] === (string)$highestVersion) {
-						$compatible = true;
-						$response['data'][$dataKey]['releases'] = [$release];
-						break;
-					}
-				}
-			}
-			if(!$compatible) {
-				unset($response['data'][$dataKey]);
-			}
-		}
+            // Get the highest version
+            $versions = [];
+            foreach($releases as $release) {
+                $versions[] = $release['version'];
+            }
+            usort($versions, 'version_compare');
+            $versions = array_reverse($versions);
+            $compatible = false;
+            if(isset($versions[0])) {
+                $highestVersion = $versions[0];
+                foreach ($releases as $release) {
+                    if ((string)$release['version'] === (string)$highestVersion) {
+                        $compatible = true;
+                        $response['data'][$dataKey]['releases'] = [$release];
+                        break;
+                    }
+                }
+            }
+            if(!$compatible) {
+                unset($response['data'][$dataKey]);
+            }
+        }
 
-		$response['data'] = array_values($response['data']);
-		return $response;
-	}
+        $response['data'] = array_values($response['data']);
+        return $response;
+    }
 
-	private function setEndpoint() {
-		$versionArray = explode('.', $this->getVersion());
-		$this->endpointUrl = sprintf(
-			'https://apps.nextcloud.com/api/v1/platform/%d.%d.%d/apps.json',
-			$versionArray[0],
-			$versionArray[1],
-			$versionArray[2]
-		);
-	}
+    private function setEndpoint() {
+        $versionArray = explode('.', $this->getVersion());
+        $this->endpointUrl = sprintf(
+            'https://apps.nextcloud.com/api/v1/platform/%d.%d.%d/apps.json',
+            $versionArray[0],
+            $versionArray[1],
+            $versionArray[2]
+        );
+    }
 
-	/**
-	 * @param string $version
-	 * @param string $filename
-	 */
-	public function setVersion(string $version, string $fileName = 'apps.json') {
-		parent::setVersion($version);
-		$this->fileName = $fileName;
-		$this->setEndpoint();
-	}
+    /**
+     * @param string $version
+     * @param string $filename
+     */
+    public function setVersion(string $version, string $fileName = 'apps.json') {
+        parent::setVersion($version);
+        $this->fileName = $fileName;
+        $this->setEndpoint();
+    }
 }

lib/private/App/AppStore/Fetcher/Fetcher.php

Indentation +158 added lines, -158 removed lines

@@ -39,162 +39,162 @@
 use OCP\Util;
 
 abstract class Fetcher {
-	const INVALIDATE_AFTER_SECONDS = 300;
-
-	/** @var IAppData */
-	protected $appData;
-	/** @var IClientService */
-	protected $clientService;
-	/** @var ITimeFactory */
-	protected $timeFactory;
-	/** @var IConfig */
-	protected $config;
-	/** @var Ilogger */
-	protected $logger;
-	/** @var string */
-	protected $fileName;
-	/** @var string */
-	protected $endpointUrl;
-	/** @var string */
-	protected $version;
-
-	/**
-	 * @param Factory $appDataFactory
-	 * @param IClientService $clientService
-	 * @param ITimeFactory $timeFactory
-	 * @param IConfig $config
-	 * @param ILogger $logger
-	 */
-	public function __construct(Factory $appDataFactory,
-								IClientService $clientService,
-								ITimeFactory $timeFactory,
-								IConfig $config,
-								ILogger $logger) {
-		$this->appData = $appDataFactory->get('appstore');
-		$this->clientService = $clientService;
-		$this->timeFactory = $timeFactory;
-		$this->config = $config;
-		$this->logger = $logger;
-	}
-
-	/**
-	 * Fetches the response from the server
-	 *
-	 * @param string $ETag
-	 * @param string $content
-	 *
-	 * @return array
-	 */
-	protected function fetch($ETag, $content) {
-		$appstoreenabled = $this->config->getSystemValue('appstoreenabled', true);
-
-		if (!$appstoreenabled) {
-			return [];
-		}
-
-		$options = [
-			'timeout' => 10,
-		];
-
-		if ($ETag !== '') {
-			$options['headers'] = [
-				'If-None-Match' => $ETag,
-			];
-		}
-
-		$client = $this->clientService->newClient();
-		$response = $client->get($this->endpointUrl, $options);
-
-		$responseJson = [];
-		if ($response->getStatusCode() === Http::STATUS_NOT_MODIFIED) {
-			$responseJson['data'] = json_decode($content, true);
-		} else {
-			$responseJson['data'] = json_decode($response->getBody(), true);
-			$ETag = $response->getHeader('ETag');
-		}
-
-		$responseJson['timestamp'] = $this->timeFactory->getTime();
-		$responseJson['ncversion'] = $this->getVersion();
-		if ($ETag !== '') {
-			$responseJson['ETag'] = $ETag;
-		}
-
-		return $responseJson;
-	}
-
-	/**
-	 * Returns the array with the categories on the appstore server
-	 *
-	 * @return array
-	 */
-	public function get() {
-		$appstoreenabled = $this->config->getSystemValue('appstoreenabled', true);
-		$internetavailable = $this->config->getSystemValue('has_internet_connection', true);
-
-		if (!$appstoreenabled || !$internetavailable) {
-			return [];
-		}
-
-		$rootFolder = $this->appData->getFolder('/');
-
-		$ETag = '';
-		$content = '';
-
-		try {
-			// File does already exists
-			$file = $rootFolder->getFile($this->fileName);
-			$jsonBlob = json_decode($file->getContent(), true);
-			if (is_array($jsonBlob)) {
-
-				// No caching when the version has been updated
-				if (isset($jsonBlob['ncversion']) && $jsonBlob['ncversion'] === $this->getVersion()) {
-
-					// If the timestamp is older than 300 seconds request the files new
-					if ((int)$jsonBlob['timestamp'] > ($this->timeFactory->getTime() - self::INVALIDATE_AFTER_SECONDS)) {
-						return $jsonBlob['data'];
-					}
-
-					if (isset($jsonBlob['ETag'])) {
-						$ETag = $jsonBlob['ETag'];
-						$content = json_encode($jsonBlob['data']);
-					}
-				}
-			}
-		} catch (NotFoundException $e) {
-			// File does not already exists
-			$file = $rootFolder->newFile($this->fileName);
-		}
-
-		// Refresh the file content
-		try {
-			$responseJson = $this->fetch($ETag, $content);
-			$file->putContent(json_encode($responseJson));
-			return json_decode($file->getContent(), true)['data'];
-		} catch (ConnectException $e) {
-			$this->logger->logException($e, ['app' => 'appstoreFetcher', 'level' => Util::INFO, 'message' => 'Could not connect to appstore']);
-			return [];
-		} catch (\Exception $e) {
-			$this->logger->logException($e, ['app' => 'appstoreFetcher', 'level' => Util::INFO]);
-			return [];
-		}
-	}
-
-	/**
-	 * Get the currently Nextcloud version
-	 * @return string
-	 */
-	protected function getVersion() {
-		if ($this->version === null) {
-			$this->version = $this->config->getSystemValue('version', '0.0.0');
-		}
-		return $this->version;
-	}
-
-	/**
-	 * Set the current Nextcloud version
-	 * @param string $version
-	 */
-	public function setVersion(string $version) {
-		$this->version = $version;
-	}
+    const INVALIDATE_AFTER_SECONDS = 300;
+
+    /** @var IAppData */
+    protected $appData;
+    /** @var IClientService */
+    protected $clientService;
+    /** @var ITimeFactory */
+    protected $timeFactory;
+    /** @var IConfig */
+    protected $config;
+    /** @var Ilogger */
+    protected $logger;
+    /** @var string */
+    protected $fileName;
+    /** @var string */
+    protected $endpointUrl;
+    /** @var string */
+    protected $version;
+
+    /**
+     * @param Factory $appDataFactory
+     * @param IClientService $clientService
+     * @param ITimeFactory $timeFactory
+     * @param IConfig $config
+     * @param ILogger $logger
+     */
+    public function __construct(Factory $appDataFactory,
+                                IClientService $clientService,
+                                ITimeFactory $timeFactory,
+                                IConfig $config,
+                                ILogger $logger) {
+        $this->appData = $appDataFactory->get('appstore');
+        $this->clientService = $clientService;
+        $this->timeFactory = $timeFactory;
+        $this->config = $config;
+        $this->logger = $logger;
+    }
+
+    /**
+     * Fetches the response from the server
+     *
+     * @param string $ETag
+     * @param string $content
+     *
+     * @return array
+     */
+    protected function fetch($ETag, $content) {
+        $appstoreenabled = $this->config->getSystemValue('appstoreenabled', true);
+
+        if (!$appstoreenabled) {
+            return [];
+        }
+
+        $options = [
+            'timeout' => 10,
+        ];
+
+        if ($ETag !== '') {
+            $options['headers'] = [
+                'If-None-Match' => $ETag,
+            ];
+        }
+
+        $client = $this->clientService->newClient();
+        $response = $client->get($this->endpointUrl, $options);
+
+        $responseJson = [];
+        if ($response->getStatusCode() === Http::STATUS_NOT_MODIFIED) {
+            $responseJson['data'] = json_decode($content, true);
+        } else {
+            $responseJson['data'] = json_decode($response->getBody(), true);
+            $ETag = $response->getHeader('ETag');
+        }
+
+        $responseJson['timestamp'] = $this->timeFactory->getTime();
+        $responseJson['ncversion'] = $this->getVersion();
+        if ($ETag !== '') {
+            $responseJson['ETag'] = $ETag;
+        }
+
+        return $responseJson;
+    }
+
+    /**
+     * Returns the array with the categories on the appstore server
+     *
+     * @return array
+     */
+    public function get() {
+        $appstoreenabled = $this->config->getSystemValue('appstoreenabled', true);
+        $internetavailable = $this->config->getSystemValue('has_internet_connection', true);
+
+        if (!$appstoreenabled || !$internetavailable) {
+            return [];
+        }
+
+        $rootFolder = $this->appData->getFolder('/');
+
+        $ETag = '';
+        $content = '';
+
+        try {
+            // File does already exists
+            $file = $rootFolder->getFile($this->fileName);
+            $jsonBlob = json_decode($file->getContent(), true);
+            if (is_array($jsonBlob)) {
+
+                // No caching when the version has been updated
+                if (isset($jsonBlob['ncversion']) && $jsonBlob['ncversion'] === $this->getVersion()) {
+
+                    // If the timestamp is older than 300 seconds request the files new
+                    if ((int)$jsonBlob['timestamp'] > ($this->timeFactory->getTime() - self::INVALIDATE_AFTER_SECONDS)) {
+                        return $jsonBlob['data'];
+                    }
+
+                    if (isset($jsonBlob['ETag'])) {
+                        $ETag = $jsonBlob['ETag'];
+                        $content = json_encode($jsonBlob['data']);
+                    }
+                }
+            }
+        } catch (NotFoundException $e) {
+            // File does not already exists
+            $file = $rootFolder->newFile($this->fileName);
+        }
+
+        // Refresh the file content
+        try {
+            $responseJson = $this->fetch($ETag, $content);
+            $file->putContent(json_encode($responseJson));
+            return json_decode($file->getContent(), true)['data'];
+        } catch (ConnectException $e) {
+            $this->logger->logException($e, ['app' => 'appstoreFetcher', 'level' => Util::INFO, 'message' => 'Could not connect to appstore']);
+            return [];
+        } catch (\Exception $e) {
+            $this->logger->logException($e, ['app' => 'appstoreFetcher', 'level' => Util::INFO]);
+            return [];
+        }
+    }
+
+    /**
+     * Get the currently Nextcloud version
+     * @return string
+     */
+    protected function getVersion() {
+        if ($this->version === null) {
+            $this->version = $this->config->getSystemValue('version', '0.0.0');
+        }
+        return $this->version;
+    }
+
+    /**
+     * Set the current Nextcloud version
+     * @param string $version
+     */
+    public function setVersion(string $version) {
+        $this->version = $version;
+    }
 }

apps/updatenotification/appinfo/routes.php

Indentation +7 added lines, -7 removed lines

@@ -22,11 +22,11 @@
  */
 
 return [
-	'routes' => [
-		['name' => 'Admin#createCredentials', 'url' => '/credentials', 'verb' => 'GET'],
-		['name' => 'Admin#setChannel', 'url' => '/channel', 'verb' => 'POST'],
-	],
-	'ocs' => [
-		['name' => 'API#getAppList', 'url' => '/api/{apiVersion}/applist/{newVersion}', 'verb' => 'GET', 'requirements' => ['apiVersion' => 'v1']],
-	],
+    'routes' => [
+        ['name' => 'Admin#createCredentials', 'url' => '/credentials', 'verb' => 'GET'],
+        ['name' => 'Admin#setChannel', 'url' => '/channel', 'verb' => 'POST'],
+    ],
+    'ocs' => [
+        ['name' => 'API#getAppList', 'url' => '/api/{apiVersion}/applist/{newVersion}', 'verb' => 'GET', 'requirements' => ['apiVersion' => 'v1']],
+    ],
 ];

apps/updatenotification/composer/composer/autoload_classmap.php

Spacing +8 added lines, -8 removed lines

@@ -6,12 +6,12 @@
 $baseDir = $vendorDir;
 
 return array(
-    'OCA\\UpdateNotification\\AppInfo\\Application' => $baseDir . '/../lib/AppInfo/Application.php',
-    'OCA\\UpdateNotification\\Controller\\APIController' => $baseDir . '/../lib/Controller/APIController.php',
-    'OCA\\UpdateNotification\\Controller\\AdminController' => $baseDir . '/../lib/Controller/AdminController.php',
-    'OCA\\UpdateNotification\\Notification\\BackgroundJob' => $baseDir . '/../lib/Notification/BackgroundJob.php',
-    'OCA\\UpdateNotification\\Notification\\Notifier' => $baseDir . '/../lib/Notification/Notifier.php',
-    'OCA\\UpdateNotification\\ResetTokenBackgroundJob' => $baseDir . '/../lib/ResetTokenBackgroundJob.php',
-    'OCA\\UpdateNotification\\Settings\\Admin' => $baseDir . '/../lib/Settings/Admin.php',
-    'OCA\\UpdateNotification\\UpdateChecker' => $baseDir . '/../lib/UpdateChecker.php',
+    'OCA\\UpdateNotification\\AppInfo\\Application' => $baseDir.'/../lib/AppInfo/Application.php',
+    'OCA\\UpdateNotification\\Controller\\APIController' => $baseDir.'/../lib/Controller/APIController.php',
+    'OCA\\UpdateNotification\\Controller\\AdminController' => $baseDir.'/../lib/Controller/AdminController.php',
+    'OCA\\UpdateNotification\\Notification\\BackgroundJob' => $baseDir.'/../lib/Notification/BackgroundJob.php',
+    'OCA\\UpdateNotification\\Notification\\Notifier' => $baseDir.'/../lib/Notification/Notifier.php',
+    'OCA\\UpdateNotification\\ResetTokenBackgroundJob' => $baseDir.'/../lib/ResetTokenBackgroundJob.php',
+    'OCA\\UpdateNotification\\Settings\\Admin' => $baseDir.'/../lib/Settings/Admin.php',
+    'OCA\\UpdateNotification\\UpdateChecker' => $baseDir.'/../lib/UpdateChecker.php',
 );

apps/updatenotification/composer/composer/autoload_static.php

Spacing +15 added lines, -15 removed lines

@@ -6,34 +6,34 @@
 
 class ComposerStaticInitUpdateNotification
 {
-    public static $prefixLengthsPsr4 = array (
+    public static $prefixLengthsPsr4 = array(
         'O' => 
-        array (
+        array(
             'OCA\\UpdateNotification\\' => 23,
         ),
     );
 
-    public static $prefixDirsPsr4 = array (
+    public static $prefixDirsPsr4 = array(
         'OCA\\UpdateNotification\\' => 
-        array (
-            0 => __DIR__ . '/..' . '/../lib',
+        array(
+            0 => __DIR__.'/..'.'/../lib',
         ),
     );
 
-    public static $classMap = array (
-        'OCA\\UpdateNotification\\AppInfo\\Application' => __DIR__ . '/..' . '/../lib/AppInfo/Application.php',
-        'OCA\\UpdateNotification\\Controller\\APIController' => __DIR__ . '/..' . '/../lib/Controller/APIController.php',
-        'OCA\\UpdateNotification\\Controller\\AdminController' => __DIR__ . '/..' . '/../lib/Controller/AdminController.php',
-        'OCA\\UpdateNotification\\Notification\\BackgroundJob' => __DIR__ . '/..' . '/../lib/Notification/BackgroundJob.php',
-        'OCA\\UpdateNotification\\Notification\\Notifier' => __DIR__ . '/..' . '/../lib/Notification/Notifier.php',
-        'OCA\\UpdateNotification\\ResetTokenBackgroundJob' => __DIR__ . '/..' . '/../lib/ResetTokenBackgroundJob.php',
-        'OCA\\UpdateNotification\\Settings\\Admin' => __DIR__ . '/..' . '/../lib/Settings/Admin.php',
-        'OCA\\UpdateNotification\\UpdateChecker' => __DIR__ . '/..' . '/../lib/UpdateChecker.php',
+    public static $classMap = array(
+        'OCA\\UpdateNotification\\AppInfo\\Application' => __DIR__.'/..'.'/../lib/AppInfo/Application.php',
+        'OCA\\UpdateNotification\\Controller\\APIController' => __DIR__.'/..'.'/../lib/Controller/APIController.php',
+        'OCA\\UpdateNotification\\Controller\\AdminController' => __DIR__.'/..'.'/../lib/Controller/AdminController.php',
+        'OCA\\UpdateNotification\\Notification\\BackgroundJob' => __DIR__.'/..'.'/../lib/Notification/BackgroundJob.php',
+        'OCA\\UpdateNotification\\Notification\\Notifier' => __DIR__.'/..'.'/../lib/Notification/Notifier.php',
+        'OCA\\UpdateNotification\\ResetTokenBackgroundJob' => __DIR__.'/..'.'/../lib/ResetTokenBackgroundJob.php',
+        'OCA\\UpdateNotification\\Settings\\Admin' => __DIR__.'/..'.'/../lib/Settings/Admin.php',
+        'OCA\\UpdateNotification\\UpdateChecker' => __DIR__.'/..'.'/../lib/UpdateChecker.php',
     );
 
     public static function getInitializer(ClassLoader $loader)
     {
-        return \Closure::bind(function () use ($loader) {
+        return \Closure::bind(function() use ($loader) {
             $loader->prefixLengthsPsr4 = ComposerStaticInitUpdateNotification::$prefixLengthsPsr4;
             $loader->prefixDirsPsr4 = ComposerStaticInitUpdateNotification::$prefixDirsPsr4;
             $loader->classMap = ComposerStaticInitUpdateNotification::$classMap;

apps/updatenotification/lib/Controller/APIController.php

Indentation +98 added lines, -98 removed lines

@@ -33,102 +33,102 @@
 
 class APIController extends OCSController {
 
-	/** @var IConfig */
-	protected $config;
-
-	/** @var IAppManager */
-	protected $appManager;
-
-	/** @var AppFetcher */
-	protected $appFetcher;
-
-	/**
-	 * @param string $appName
-	 * @param IRequest $request
-	 * @param IConfig $config
-	 * @param IAppManager $appManager
-	 * @param AppFetcher $appFetcher
-	 */
-	public function __construct($appName,
-								IRequest $request,
-								IConfig $config,
-								IAppManager $appManager,
-								AppFetcher $appFetcher) {
-		parent::__construct($appName, $request);
-
-		$this->config = $config;
-		$this->appManager = $appManager;
-		$this->appFetcher = $appFetcher;
-	}
-
-	/**
-	 * @param string $newVersion
-	 * @return DataResponse
-	 */
-	public function getAppList(string $newVersion): DataResponse {
-		if (!$this->config->getSystemValue('appstoreenabled', true)) {
-			return new DataResponse([
-				'appstore_disabled' => true,
-			], Http::STATUS_NOT_FOUND);
-		}
-
-		// Get list of installed custom apps
-		$installedApps = $this->appManager->getInstalledApps();
-		$installedApps = array_filter($installedApps, function($app) {
-			try {
-				$this->appManager->getAppPath($app);
-			} catch (AppPathNotFoundException $e) {
-				return false;
-			}
-			return !$this->appManager->isShipped($app);
-		});
-
-		if (empty($installedApps)) {
-			return new DataResponse([
-				'missing' => [],
-				'available' => [],
-			]);
-		}
-
-		$this->appFetcher->setVersion($newVersion, 'future-apps.json');
-
-		// Apps available on the app store for that version
-		$availableApps = array_map(function(array $app) {
-			return $app['id'];
-		}, $this->appFetcher->get());
-
-		if (empty($availableApps)) {
-			return new DataResponse([
-				'appstore_disabled' => false,
-				'already_on_latest' => false,
-			], Http::STATUS_NOT_FOUND);
-		}
-
-		$missing = array_diff($installedApps, $availableApps);
-		$missing = array_map([$this, 'getAppDetails'], $missing);
-		sort($missing);
-
-		$available = array_intersect($installedApps, $availableApps);
-		$available = array_map([$this, 'getAppDetails'], $available);
-		sort($available);
-
-		return new DataResponse([
-			'missing' => $missing,
-			'available' => $available,
-		]);
-	}
-
-	/**
-	 * Get translated app name
-	 *
-	 * @param string $appId
-	 * @return string[]
-	 */
-	protected function getAppDetails($appId): array {
-		$app = $this->appManager->getAppInfo($appId);
-		return [
-			'appId' => $appId,
-			'appName' => $app['name'] ?? $appId,
-		];
-	}
+    /** @var IConfig */
+    protected $config;
+
+    /** @var IAppManager */
+    protected $appManager;
+
+    /** @var AppFetcher */
+    protected $appFetcher;
+
+    /**
+     * @param string $appName
+     * @param IRequest $request
+     * @param IConfig $config
+     * @param IAppManager $appManager
+     * @param AppFetcher $appFetcher
+     */
+    public function __construct($appName,
+                                IRequest $request,
+                                IConfig $config,
+                                IAppManager $appManager,
+                                AppFetcher $appFetcher) {
+        parent::__construct($appName, $request);
+
+        $this->config = $config;
+        $this->appManager = $appManager;
+        $this->appFetcher = $appFetcher;
+    }
+
+    /**
+     * @param string $newVersion
+     * @return DataResponse
+     */
+    public function getAppList(string $newVersion): DataResponse {
+        if (!$this->config->getSystemValue('appstoreenabled', true)) {
+            return new DataResponse([
+                'appstore_disabled' => true,
+            ], Http::STATUS_NOT_FOUND);
+        }
+
+        // Get list of installed custom apps
+        $installedApps = $this->appManager->getInstalledApps();
+        $installedApps = array_filter($installedApps, function($app) {
+            try {
+                $this->appManager->getAppPath($app);
+            } catch (AppPathNotFoundException $e) {
+                return false;
+            }
+            return !$this->appManager->isShipped($app);
+        });
+
+        if (empty($installedApps)) {
+            return new DataResponse([
+                'missing' => [],
+                'available' => [],
+            ]);
+        }
+
+        $this->appFetcher->setVersion($newVersion, 'future-apps.json');
+
+        // Apps available on the app store for that version
+        $availableApps = array_map(function(array $app) {
+            return $app['id'];
+        }, $this->appFetcher->get());
+
+        if (empty($availableApps)) {
+            return new DataResponse([
+                'appstore_disabled' => false,
+                'already_on_latest' => false,
+            ], Http::STATUS_NOT_FOUND);
+        }
+
+        $missing = array_diff($installedApps, $availableApps);
+        $missing = array_map([$this, 'getAppDetails'], $missing);
+        sort($missing);
+
+        $available = array_intersect($installedApps, $availableApps);
+        $available = array_map([$this, 'getAppDetails'], $available);
+        sort($available);
+
+        return new DataResponse([
+            'missing' => $missing,
+            'available' => $available,
+        ]);
+    }
+
+    /**
+     * Get translated app name
+     *
+     * @param string $appId
+     * @return string[]
+     */
+    protected function getAppDetails($appId): array {
+        $app = $this->appManager->getAppInfo($appId);
+        return [
+            'appId' => $appId,
+            'appName' => $app['name'] ?? $appId,
+        ];
+    }
 }

Spacing +1 added lines, -1 removed lines

@@ -1,5 +1,5 @@
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 /**
  * @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com>
  *