nextcloud / server

tests/Core/Controller/OpenMetricsControllerTest.php

Indentation +56 added lines, -56 removed lines

@@ -25,52 +25,52 @@ 
 use Test\TestCase;
 
 class OpenMetricsControllerTest extends TestCase {
-	private IRequest&MockObject $request;
-	private IConfig&MockObject $config;
-	private ExporterManager&MockObject $exporterManager;
-	private LoggerInterface&MockObject $logger;
-	private OpenMetricsController $controller;
+    private IRequest&MockObject $request;
+    private IConfig&MockObject $config;
+    private ExporterManager&MockObject $exporterManager;
+    private LoggerInterface&MockObject $logger;
+    private OpenMetricsController $controller;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->request = $this->createMock(IRequest::class);
-		$this->request->method('getRemoteAddress')
-			->willReturn('192.168.1.1');
-		$this->config = $this->createMock(IConfig::class);
-		$this->exporterManager = $this->createMock(ExporterManager::class);
-		$this->exporterManager->method('export')->willReturnCallback([$this, 'getFakeMetrics']);
-		$this->logger = $this->createMock(LoggerInterface::class);
-		$this->controller = new OpenMetricsController('core', $this->request, $this->config, $this->exporterManager, $this->logger);
-	}
+    protected function setUp(): void {
+        parent::setUp();
+        $this->request = $this->createMock(IRequest::class);
+        $this->request->method('getRemoteAddress')
+            ->willReturn('192.168.1.1');
+        $this->config = $this->createMock(IConfig::class);
+        $this->exporterManager = $this->createMock(ExporterManager::class);
+        $this->exporterManager->method('export')->willReturnCallback([$this, 'getFakeMetrics']);
+        $this->logger = $this->createMock(LoggerInterface::class);
+        $this->controller = new OpenMetricsController('core', $this->request, $this->config, $this->exporterManager, $this->logger);
+    }
 
-	public function getFakeMetrics(): Generator {
-		$metric = $this->createMock(IMetricFamily::class);
-		$metric->method('type')->willReturn(MetricType::gauge);
-		$metric->method('unit')->willReturn('fake');
-		$metric->method('name')->willReturn('fake_count');
-		$metric->method('help')->willReturn('A fake count used for tests');
-		$metric->method('metrics')->willReturnCallback(function () {
-			yield new Metric(42, ['type' => 'used']);
-			yield new Metric(24, ['type' => 'unused']);
-		});
-		yield $metric;
-	}
-	public function testGetMetrics(): void {
-		$output = $this->createMock(IOutput::class);
-		$fullOutput = '';
-		$output->method('setOutput')
-			->willReturnCallback(function ($output) use (&$fullOutput) {
-				$fullOutput .= $output;
-			});
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->with('openmetrics_allowed_clients')
-			->willReturn(['192.168.0.0/16']);
-		$response = $this->controller->export();
-		$this->assertInstanceOf(StreamTraversableResponse::class, $response);
-		$this->assertEquals('200', $response->getStatus());
-		$this->assertEquals('application/openmetrics-text; version=1.0.0; charset=utf-8', $response->getHeaders()['Content-Type']);
-		$expected = <<<EXPECTED
+    public function getFakeMetrics(): Generator {
+        $metric = $this->createMock(IMetricFamily::class);
+        $metric->method('type')->willReturn(MetricType::gauge);
+        $metric->method('unit')->willReturn('fake');
+        $metric->method('name')->willReturn('fake_count');
+        $metric->method('help')->willReturn('A fake count used for tests');
+        $metric->method('metrics')->willReturnCallback(function () {
+            yield new Metric(42, ['type' => 'used']);
+            yield new Metric(24, ['type' => 'unused']);
+        });
+        yield $metric;
+    }
+    public function testGetMetrics(): void {
+        $output = $this->createMock(IOutput::class);
+        $fullOutput = '';
+        $output->method('setOutput')
+            ->willReturnCallback(function ($output) use (&$fullOutput) {
+                $fullOutput .= $output;
+            });
+        $this->config->expects($this->once())
+            ->method('getSystemValue')
+            ->with('openmetrics_allowed_clients')
+            ->willReturn(['192.168.0.0/16']);
+        $response = $this->controller->export();
+        $this->assertInstanceOf(StreamTraversableResponse::class, $response);
+        $this->assertEquals('200', $response->getStatus());
+        $this->assertEquals('application/openmetrics-text; version=1.0.0; charset=utf-8', $response->getHeaders()['Content-Type']);
+        $expected = <<<EXPECTED
 			# TYPE nextcloud_fake_count gauge
 			# UNIT nextcloud_fake_count fake
 			# HELP nextcloud_fake_count A fake count used for tests
@@ -83,17 +83,17 @@ 
 			# EOF
 
 			EXPECTED;
-		$response->callback($output);
-		$this->assertStringMatchesFormat($expected, $fullOutput);
-	}
+        $response->callback($output);
+        $this->assertStringMatchesFormat($expected, $fullOutput);
+    }
 
-	public function testGetMetricsFromForbiddenIp(): void {
-		$this->config->expects($this->once())
-			->method('getSystemValue')
-			->with('openmetrics_allowed_clients')
-			->willReturn(['1.2.3.4']);
-		$response = $this->controller->export();
-		$this->assertInstanceOf(Response::class, $response);
-		$this->assertEquals('403', $response->getStatus());
-	}
+    public function testGetMetricsFromForbiddenIp(): void {
+        $this->config->expects($this->once())
+            ->method('getSystemValue')
+            ->with('openmetrics_allowed_clients')
+            ->willReturn(['1.2.3.4']);
+        $response = $this->controller->export();
+        $this->assertInstanceOf(Response::class, $response);
+        $this->assertEquals('403', $response->getStatus());
+    }
 }

Spacing +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
 		$metric->method('unit')->willReturn('fake');
 		$metric->method('name')->willReturn('fake_count');
 		$metric->method('help')->willReturn('A fake count used for tests');
-		$metric->method('metrics')->willReturnCallback(function () {
+		$metric->method('metrics')->willReturnCallback(function() {
 			yield new Metric(42, ['type' => 'used']);
 			yield new Metric(24, ['type' => 'unused']);
 		});
@@ -59,7 +59,7 @@ 
 		$output = $this->createMock(IOutput::class);
 		$fullOutput = '';
 		$output->method('setOutput')
-			->willReturnCallback(function ($output) use (&$fullOutput) {
+			->willReturnCallback(function($output) use (&$fullOutput) {
 				$fullOutput .= $output;
 			});
 		$this->config->expects($this->once())

tests/lib/OpenMetrics/Exporters/ExporterTestCase.php

Indentation +50 added lines, -50 removed lines

@@ -13,64 +13,64 @@
 use Test\TestCase;
 
 abstract class ExporterTestCase extends TestCase {
-	protected IMetricFamily $exporter;
-	/** @var IMetric[] */
-	protected array $metrics;
+    protected IMetricFamily $exporter;
+    /** @var IMetric[] */
+    protected array $metrics;
 
-	abstract protected function getExporter(): IMetricFamily;
+    abstract protected function getExporter(): IMetricFamily;
 
-	protected function setUp(): void {
-		parent::setUp();
-		$this->exporter = $this->getExporter();
-		$this->metrics = iterator_to_array($this->exporter->metrics());
-	}
+    protected function setUp(): void {
+        parent::setUp();
+        $this->exporter = $this->getExporter();
+        $this->metrics = iterator_to_array($this->exporter->metrics());
+    }
 
-	public function testNotEmptyData(): void {
-		$this->assertNotEmpty($this->metrics);
-	}
+    public function testNotEmptyData(): void {
+        $this->assertNotEmpty($this->metrics);
+    }
 
-	public function testValidExporterName(): void {
-		$exporterName = $this->exporter->name();
-		$this->assertMatchesRegularExpression('/^[a-z_:][a-z0-9_:]*$/i', $exporterName, );
+    public function testValidExporterName(): void {
+        $exporterName = $this->exporter->name();
+        $this->assertMatchesRegularExpression('/^[a-z_:][a-z0-9_:]*$/i', $exporterName, );
 
-		$unit = $this->exporter->unit();
-		if ($unit === '') {
-			return;
-		}
-		// Unit name must follow metric name format
-		$this->assertMatchesRegularExpression('/^[a-z_:][a-z0-9_:]*$/i', $unit);
-		// Unit name must be a suffix in exporter name
-		$this->assertMatchesRegularExpression(
-			'/(^|_)' . $unit . '$/',
-			$exporterName,
-			'Metric name "' . $exporterName . '" must contains unit "' . $unit . '" as a suffix',
-		);
-	}
+        $unit = $this->exporter->unit();
+        if ($unit === '') {
+            return;
+        }
+        // Unit name must follow metric name format
+        $this->assertMatchesRegularExpression('/^[a-z_:][a-z0-9_:]*$/i', $unit);
+        // Unit name must be a suffix in exporter name
+        $this->assertMatchesRegularExpression(
+            '/(^|_)' . $unit . '$/',
+            $exporterName,
+            'Metric name "' . $exporterName . '" must contains unit "' . $unit . '" as a suffix',
+        );
+    }
 
-	public function testValidLabelKey(): void {
-		$labelNames = [];
-		foreach ($this->metrics as $metric) {
-			foreach ($metric->labels as $label => $value) {
-				$labelNames[$label] = $label;
-			}
-		}
+    public function testValidLabelKey(): void {
+        $labelNames = [];
+        foreach ($this->metrics as $metric) {
+            foreach ($metric->labels as $label => $value) {
+                $labelNames[$label] = $label;
+            }
+        }
 
-		if (empty($labelNames)) {
-			$this->expectNotToPerformAssertions();
-			return;
-		}
-		foreach ($labelNames as $label) {
-			$this->assertMatchesRegularExpression('/^[a-z_][a-z0-9_]*$/i', $label);
-		}
+        if (empty($labelNames)) {
+            $this->expectNotToPerformAssertions();
+            return;
+        }
+        foreach ($labelNames as $label) {
+            $this->assertMatchesRegularExpression('/^[a-z_][a-z0-9_]*$/i', $label);
+        }
 
-	}
+    }
 
-	protected function assertLabelsAre(array $expectedLabels): void {
-		$foundLabels = [];
-		foreach ($this->metrics as $metric) {
-			$foundLabels[] = $metric->labels;
-		}
+    protected function assertLabelsAre(array $expectedLabels): void {
+        $foundLabels = [];
+        foreach ($this->metrics as $metric) {
+            $foundLabels[] = $metric->labels;
+        }
 
-		$this->assertSame($foundLabels, $expectedLabels);
-	}
+        $this->assertSame($foundLabels, $expectedLabels);
+    }
 }

Spacing +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
 
 	public function testValidExporterName(): void {
 		$exporterName = $this->exporter->name();
-		$this->assertMatchesRegularExpression('/^[a-z_:][a-z0-9_:]*$/i', $exporterName, );
+		$this->assertMatchesRegularExpression('/^[a-z_:][a-z0-9_:]*$/i', $exporterName,);
 
 		$unit = $this->exporter->unit();
 		if ($unit === '') {
@@ -41,9 +41,9 @@ 
 		$this->assertMatchesRegularExpression('/^[a-z_:][a-z0-9_:]*$/i', $unit);
 		// Unit name must be a suffix in exporter name
 		$this->assertMatchesRegularExpression(
-			'/(^|_)' . $unit . '$/',
+			'/(^|_)'.$unit.'$/',
 			$exporterName,
-			'Metric name "' . $exporterName . '" must contains unit "' . $unit . '" as a suffix',
+			'Metric name "'.$exporterName.'" must contains unit "'.$unit.'" as a suffix',
 		);
 	}
 

lib/private/OpenMetrics/Exporters/RunningJobs.php

Indentation +37 added lines, -37 removed lines

@@ -20,48 +20,48 @@
  * Export the number of running jobs by type
  */
 class RunningJobs implements IMetricFamily {
-	public function __construct(
-		private IDBConnection $connection,
-	) {
-	}
+    public function __construct(
+        private IDBConnection $connection,
+    ) {
+    }
 
-	#[Override]
-	public function name(): string {
-		return 'running_jobs';
-	}
+    #[Override]
+    public function name(): string {
+        return 'running_jobs';
+    }
 
-	#[Override]
-	public function type(): MetricType {
-		return MetricType::gauge;
-	}
+    #[Override]
+    public function type(): MetricType {
+        return MetricType::gauge;
+    }
 
-	#[Override]
-	public function unit(): string {
-		return 'jobs';
-	}
+    #[Override]
+    public function unit(): string {
+        return 'jobs';
+    }
 
-	#[Override]
-	public function help(): string {
-		return 'Number of running jobs';
-	}
+    #[Override]
+    public function help(): string {
+        return 'Number of running jobs';
+    }
 
-	#[Override]
-	public function metrics(): Generator {
-		$qb = $this->connection->getQueryBuilder();
-		$result = $qb->select($qb->func()->count('*', 'nb'), 'class')
-			->from('jobs')
-			->where($qb->expr()->gt('reserved_at', $qb->createNamedParameter(0)))
-			->groupBy('class')
-			->executeQuery();
+    #[Override]
+    public function metrics(): Generator {
+        $qb = $this->connection->getQueryBuilder();
+        $result = $qb->select($qb->func()->count('*', 'nb'), 'class')
+            ->from('jobs')
+            ->where($qb->expr()->gt('reserved_at', $qb->createNamedParameter(0)))
+            ->groupBy('class')
+            ->executeQuery();
 
-		// If no result, return a metric with count '0'
-		if ($result->rowCount() === 0) {
-			yield new Metric(0);
-			return;
-		}
+        // If no result, return a metric with count '0'
+        if ($result->rowCount() === 0) {
+            yield new Metric(0);
+            return;
+        }
 
-		foreach ($result->iterateAssociative() as $row) {
-			yield new Metric($row['nb'], ['class' => $row['class']]);
-		}
-	}
+        foreach ($result->iterateAssociative() as $row) {
+            yield new Metric($row['nb'], ['class' => $row['class']]);
+        }
+    }
 }

lib/private/OpenMetrics/Exporters/AppsCount.php

Indentation +39 added lines, -39 removed lines

@@ -20,43 +20,43 @@
  * Export statistics about apps
  */
 class AppsCount implements IMetricFamily {
-	public function __construct(
-		private IAppManager $appManager,
-	) {
-	}
-
-	#[Override]
-	public function name(): string {
-		return 'installed_applications';
-	}
-
-	#[Override]
-	public function type(): MetricType {
-		return MetricType::gauge;
-	}
-
-	#[Override]
-	public function unit(): string {
-		return 'applications';
-	}
-
-	#[Override]
-	public function help(): string {
-		return 'Number of applications installed in Nextcloud';
-	}
-
-	#[Override]
-	public function metrics(): Generator {
-		$installedAppsCount = count($this->appManager->getAppInstalledVersions(false));
-		$enabledAppsCount = count($this->appManager->getEnabledApps());
-		$disabledAppsCount = $installedAppsCount - $enabledAppsCount;
-		yield new Metric(
-			$disabledAppsCount,
-			['status' => 'disabled'],
-		);
-		yield new Metric(
-			$enabledAppsCount,
-			['status' => 'enabled'],
-		);
-	}
+    public function __construct(
+        private IAppManager $appManager,
+    ) {
+    }
+
+    #[Override]
+    public function name(): string {
+        return 'installed_applications';
+    }
+
+    #[Override]
+    public function type(): MetricType {
+        return MetricType::gauge;
+    }
+
+    #[Override]
+    public function unit(): string {
+        return 'applications';
+    }
+
+    #[Override]
+    public function help(): string {
+        return 'Number of applications installed in Nextcloud';
+    }
+
+    #[Override]
+    public function metrics(): Generator {
+        $installedAppsCount = count($this->appManager->getAppInstalledVersions(false));
+        $enabledAppsCount = count($this->appManager->getEnabledApps());
+        $disabledAppsCount = $installedAppsCount - $enabledAppsCount;
+        yield new Metric(
+            $disabledAppsCount,
+            ['status' => 'disabled'],
+        );
+        yield new Metric(
+            $enabledAppsCount,
+            ['status' => 'enabled'],
+        );
+    }
 }

core/Controller/OpenMetricsController.php

Indentation +112 added lines, -112 removed lines

@@ -31,58 +31,58 @@ 
  * @package OC\Core\Controller
  */
 class OpenMetricsController extends Controller {
-	public function __construct(
-		string $appName,
-		IRequest $request,
-		private IConfig $config,
-		private ExporterManager $exporterManager,
-		private LoggerInterface $logger,
-	) {
-		parent::__construct($appName, $request);
-	}
-
-	#[NoCSRFRequired]
-	#[PublicPage]
-	#[FrontpageRoute(verb: 'GET', url: '/metrics')]
-	public function export(): Http\Response {
-		if (!$this->isRemoteAddressAllowed()) {
-			return new Http\Response(Http::STATUS_FORBIDDEN);
-		}
-
-		return new Http\StreamTraversableResponse(
-			$this->generate(),
-			Http::STATUS_OK,
-			[
-				'Content-Type' => 'application/openmetrics-text; version=1.0.0; charset=utf-8',
-			]
-		);
-	}
-
-	private function isRemoteAddressAllowed(): bool {
-		$clientAddress = new Address($this->request->getRemoteAddress());
-		$allowedRanges = $this->config->getSystemValue('openmetrics_allowed_clients', ['127.0.0.0/16', '::1/128']);
-		if (!is_array($allowedRanges)) {
-			$this->logger->warning('Invalid configuration for "openmetrics_allowed_clients"');
-			return false;
-		}
-
-		foreach ($allowedRanges as $range) {
-			$range = new Range($range);
-			if ($range->contains($clientAddress)) {
-				return true;
-			}
-		}
-
-		return false;
-	}
-
-	private function generate(): \Generator {
-		foreach ($this->exporterManager->export() as $family) {
-			yield $this->formatFamily($family);
-		}
-
-		$elapsed = (string)(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT']);
-		yield <<<SUMMARY
+    public function __construct(
+        string $appName,
+        IRequest $request,
+        private IConfig $config,
+        private ExporterManager $exporterManager,
+        private LoggerInterface $logger,
+    ) {
+        parent::__construct($appName, $request);
+    }
+
+    #[NoCSRFRequired]
+    #[PublicPage]
+    #[FrontpageRoute(verb: 'GET', url: '/metrics')]
+    public function export(): Http\Response {
+        if (!$this->isRemoteAddressAllowed()) {
+            return new Http\Response(Http::STATUS_FORBIDDEN);
+        }
+
+        return new Http\StreamTraversableResponse(
+            $this->generate(),
+            Http::STATUS_OK,
+            [
+                'Content-Type' => 'application/openmetrics-text; version=1.0.0; charset=utf-8',
+            ]
+        );
+    }
+
+    private function isRemoteAddressAllowed(): bool {
+        $clientAddress = new Address($this->request->getRemoteAddress());
+        $allowedRanges = $this->config->getSystemValue('openmetrics_allowed_clients', ['127.0.0.0/16', '::1/128']);
+        if (!is_array($allowedRanges)) {
+            $this->logger->warning('Invalid configuration for "openmetrics_allowed_clients"');
+            return false;
+        }
+
+        foreach ($allowedRanges as $range) {
+            $range = new Range($range);
+            if ($range->contains($clientAddress)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    private function generate(): \Generator {
+        foreach ($this->exporterManager->export() as $family) {
+            yield $this->formatFamily($family);
+        }
+
+        $elapsed = (string)(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT']);
+        yield <<<SUMMARY
 			# TYPE nextcloud_exporter_run_seconds gauge
 			# UNIT nextcloud_exporter_run_seconds seconds
 			# HELP nextcloud_exporter_run_seconds Exporter run time
@@ -90,64 +90,64 @@ 
 			# EOF
 
 			SUMMARY;
-	}
-
-	private function formatFamily(IMetricFamily $family): string {
-		$output = '';
-		$name = $family->name();
-		if ($family->type() !== MetricType::unknown) {
-			$output = '# TYPE nextcloud_' . $name . ' ' . $family->type()->name . "\n";
-		}
-		if ($family->unit() !== '') {
-			$output .= '# UNIT nextcloud_' . $name . ' ' . $family->unit() . "\n";
-		}
-		if ($family->help() !== '') {
-			$output .= '# HELP nextcloud_' . $name . ' ' . $family->help() . "\n";
-		}
-		foreach ($family->metrics() as $metric) {
-			$output .= 'nextcloud_' . $name . $this->formatLabels($metric) . ' ' . $this->formatValue($metric);
-			if ($metric->timestamp !== null) {
-				$output .= ' ' . $this->formatTimestamp($metric);
-			}
-			$output .= "\n";
-		}
-
-		return $output;
-	}
-
-	private function formatLabels(Metric $metric): string {
-		if (empty($metric->labels)) {
-			return '';
-		}
-
-		$labels = [];
-		foreach ($metric->labels as $label => $value) {
-			$labels[] .= $label . '=' . $this->escapeString((string)$value);
-		}
-
-		return '{' . implode(',', $labels) . '}';
-	}
-
-	private function escapeString(string $string): string {
-		return json_encode(
-			$string,
-			JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES | JSON_THROW_ON_ERROR,
-			1
-		);
-	}
-
-	private function formatValue(Metric $metric): string {
-		if (is_bool($metric->value)) {
-			return $metric->value ? '1' : '0';
-		}
-		if ($metric->value instanceof MetricValue) {
-			return $metric->value->value;
-		}
-
-		return (string)$metric->value;
-	}
-
-	private function formatTimestamp(Metric $metric): string {
-		return (string)$metric->timestamp;
-	}
+    }
+
+    private function formatFamily(IMetricFamily $family): string {
+        $output = '';
+        $name = $family->name();
+        if ($family->type() !== MetricType::unknown) {
+            $output = '# TYPE nextcloud_' . $name . ' ' . $family->type()->name . "\n";
+        }
+        if ($family->unit() !== '') {
+            $output .= '# UNIT nextcloud_' . $name . ' ' . $family->unit() . "\n";
+        }
+        if ($family->help() !== '') {
+            $output .= '# HELP nextcloud_' . $name . ' ' . $family->help() . "\n";
+        }
+        foreach ($family->metrics() as $metric) {
+            $output .= 'nextcloud_' . $name . $this->formatLabels($metric) . ' ' . $this->formatValue($metric);
+            if ($metric->timestamp !== null) {
+                $output .= ' ' . $this->formatTimestamp($metric);
+            }
+            $output .= "\n";
+        }
+
+        return $output;
+    }
+
+    private function formatLabels(Metric $metric): string {
+        if (empty($metric->labels)) {
+            return '';
+        }
+
+        $labels = [];
+        foreach ($metric->labels as $label => $value) {
+            $labels[] .= $label . '=' . $this->escapeString((string)$value);
+        }
+
+        return '{' . implode(',', $labels) . '}';
+    }
+
+    private function escapeString(string $string): string {
+        return json_encode(
+            $string,
+            JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES | JSON_THROW_ON_ERROR,
+            1
+        );
+    }
+
+    private function formatValue(Metric $metric): string {
+        if (is_bool($metric->value)) {
+            return $metric->value ? '1' : '0';
+        }
+        if ($metric->value instanceof MetricValue) {
+            return $metric->value->value;
+        }
+
+        return (string)$metric->value;
+    }
+
+    private function formatTimestamp(Metric $metric): string {
+        return (string)$metric->timestamp;
+    }
 }

Spacing +10 added lines, -10 removed lines

@@ -81,7 +81,7 @@ 
 			yield $this->formatFamily($family);
 		}
 
-		$elapsed = (string)(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT']);
+		$elapsed = (string) (microtime(true) - $_SERVER['REQUEST_TIME_FLOAT']);
 		yield <<<SUMMARY
 			# TYPE nextcloud_exporter_run_seconds gauge
 			# UNIT nextcloud_exporter_run_seconds seconds
@@ -96,18 +96,18 @@ 
 		$output = '';
 		$name = $family->name();
 		if ($family->type() !== MetricType::unknown) {
-			$output = '# TYPE nextcloud_' . $name . ' ' . $family->type()->name . "\n";
+			$output = '# TYPE nextcloud_'.$name.' '.$family->type()->name."\n";
 		}
 		if ($family->unit() !== '') {
-			$output .= '# UNIT nextcloud_' . $name . ' ' . $family->unit() . "\n";
+			$output .= '# UNIT nextcloud_'.$name.' '.$family->unit()."\n";
 		}
 		if ($family->help() !== '') {
-			$output .= '# HELP nextcloud_' . $name . ' ' . $family->help() . "\n";
+			$output .= '# HELP nextcloud_'.$name.' '.$family->help()."\n";
 		}
 		foreach ($family->metrics() as $metric) {
-			$output .= 'nextcloud_' . $name . $this->formatLabels($metric) . ' ' . $this->formatValue($metric);
+			$output .= 'nextcloud_'.$name.$this->formatLabels($metric).' '.$this->formatValue($metric);
 			if ($metric->timestamp !== null) {
-				$output .= ' ' . $this->formatTimestamp($metric);
+				$output .= ' '.$this->formatTimestamp($metric);
 			}
 			$output .= "\n";
 		}
@@ -122,10 +122,10 @@ 
 
 		$labels = [];
 		foreach ($metric->labels as $label => $value) {
-			$labels[] .= $label . '=' . $this->escapeString((string)$value);
+			$labels[] .= $label.'='.$this->escapeString((string) $value);
 		}
 
-		return '{' . implode(',', $labels) . '}';
+		return '{'.implode(',', $labels).'}';
 	}
 
 	private function escapeString(string $string): string {
@@ -144,10 +144,10 @@ 
 			return $metric->value->value;
 		}
 
-		return (string)$metric->value;
+		return (string) $metric->value;
 	}
 
 	private function formatTimestamp(Metric $metric): string {
-		return (string)$metric->timestamp;
+		return (string) $metric->timestamp;
 	}
 }