Inspection of "Add the primary font color to the capabilities as..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6128)

by Joas

created 2017-08-15 11:52 UTC

Status

Indentation +41 added lines, -41 removed lines patch added patch discarded remove patch

@@ -34,51 +34,51 @@
 block discarded – undo
  */
 class Capabilities implements IPublicCapability {
 
-	/** @var ThemingDefaults */
-	protected $theming;
+    /** @var ThemingDefaults */
+    protected $theming;
 
-	/** @var Util */
-	protected $util;
+    /** @var Util */
+    protected $util;
 
-	/** @var IURLGenerator */
-	protected $url;
+    /** @var IURLGenerator */
+    protected $url;
 
-	/** @var IConfig */
-	protected $config;
+    /** @var IConfig */
+    protected $config;
 
-	/**
-	 * @param ThemingDefaults $theming
-	 * @param Util $util
-	 * @param IURLGenerator $url
-	 * @param IConfig $config
-	 */
-	public function __construct(ThemingDefaults $theming, Util $util, IURLGenerator $url, IConfig $config) {
-		$this->theming = $theming;
-		$this->util = $util;
-		$this->url = $url;
-		$this->config = $config;
-	}
+    /**
+     * @param ThemingDefaults $theming
+     * @param Util $util
+     * @param IURLGenerator $url
+     * @param IConfig $config
+     */
+    public function __construct(ThemingDefaults $theming, Util $util, IURLGenerator $url, IConfig $config) {
+        $this->theming = $theming;
+        $this->util = $util;
+        $this->url = $url;
+        $this->config = $config;
+    }
 
-	/**
-	 * Return this classes capabilities
-	 *
-	 * @return array
-	 */
-	public function getCapabilities() {
-		$backgroundLogo = $this->config->getAppValue('theming', 'backgroundMime', false);
+    /**
+     * Return this classes capabilities
+     *
+     * @return array
+     */
+    public function getCapabilities() {
+        $backgroundLogo = $this->config->getAppValue('theming', 'backgroundMime', false);
 
-		return [
-			'theming' => [
-				'name' => $this->theming->getName(),
-				'url' => $this->theming->getBaseUrl(),
-				'slogan' => $this->theming->getSlogan(),
-				'color' => $this->theming->getColorPrimary(),
-				'color-text' => $this->util->invertTextColor($this->theming->getColorPrimary()) ? '#000000' : '#FFFFFF',
-				'logo' => $this->url->getAbsoluteURL($this->theming->getLogo()),
-				'background' => $backgroundLogo === 'backgroundColor' ?
-					$this->theming->getColorPrimary() :
-					$this->url->getAbsoluteURL($this->theming->getBackground()),
-			],
-		];
-	}
+        return [
+            'theming' => [
+                'name' => $this->theming->getName(),
+                'url' => $this->theming->getBaseUrl(),
+                'slogan' => $this->theming->getSlogan(),
+                'color' => $this->theming->getColorPrimary(),
+                'color-text' => $this->util->invertTextColor($this->theming->getColorPrimary()) ? '#000000' : '#FFFFFF',
+                'logo' => $this->url->getAbsoluteURL($this->theming->getLogo()),
+                'background' => $backgroundLogo === 'backgroundColor' ?
+                    $this->theming->getColorPrimary() :
+                    $this->url->getAbsoluteURL($this->theming->getBackground()),
+            ],
+        ];
+    }
 }

Please login to merge, or discard this patch.

Spacing +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -76,8 +76,7 @@
 block discarded – undo
 				'color-text' => $this->util->invertTextColor($this->theming->getColorPrimary()) ? '#000000' : '#FFFFFF',
 				'logo' => $this->url->getAbsoluteURL($this->theming->getLogo()),
 				'background' => $backgroundLogo === 'backgroundColor' ?
-					$this->theming->getColorPrimary() :
-					$this->url->getAbsoluteURL($this->theming->getBackground()),
+					$this->theming->getColorPrimary() : $this->url->getAbsoluteURL($this->theming->getBackground()),
 			],
 		];
 	}

Please login to merge, or discard this patch.

		@@ -76,8 +76,7 @@
		block discarded – undo
76	76	'color-text' => $this->util->invertTextColor($this->theming->getColorPrimary()) ? '#000000' : '#FFFFFF',
77	77	'logo' => $this->url->getAbsoluteURL($this->theming->getLogo()),
78	78	'background' => $backgroundLogo === 'backgroundColor' ?
79		- $this->theming->getColorPrimary() :
80		- $this->url->getAbsoluteURL($this->theming->getBackground()),
	79	+ $this->theming->getColorPrimary() : $this->url->getAbsoluteURL($this->theming->getBackground()),
81	80	],
82	81	];
83	82	}

		@@ -34,51 +34,51 @@
		block discarded – undo
34	34	*/
35	35	class Capabilities implements IPublicCapability {
36	36
37		- /** @var ThemingDefaults */
38		- protected $theming;
	37	+ /** @var ThemingDefaults */
	38	+ protected $theming;
39	39
40		- /** @var Util */
41		- protected $util;
	40	+ /** @var Util */
	41	+ protected $util;
42	42
43		- /** @var IURLGenerator */
44		- protected $url;
	43	+ /** @var IURLGenerator */
	44	+ protected $url;
45	45
46		- /** @var IConfig */
47		- protected $config;
	46	+ /** @var IConfig */
	47	+ protected $config;
48	48
49		- /**
50		- * @param ThemingDefaults $theming
51		- * @param Util $util
52		- * @param IURLGenerator $url
53		- * @param IConfig $config
54		- */
55		- public function __construct(ThemingDefaults $theming, Util $util, IURLGenerator $url, IConfig $config) {
56		- $this->theming = $theming;
57		- $this->util = $util;
58		- $this->url = $url;
59		- $this->config = $config;
60		- }
	49	+ /**
	50	+ * @param ThemingDefaults $theming
	51	+ * @param Util $util
	52	+ * @param IURLGenerator $url
	53	+ * @param IConfig $config
	54	+ */
	55	+ public function __construct(ThemingDefaults $theming, Util $util, IURLGenerator $url, IConfig $config) {
	56	+ $this->theming = $theming;
	57	+ $this->util = $util;
	58	+ $this->url = $url;
	59	+ $this->config = $config;
	60	+ }
61	61
62		- /**
63		- * Return this classes capabilities
64		- *
65		- * @return array
66		- */
67		- public function getCapabilities() {
68		- $backgroundLogo = $this->config->getAppValue('theming', 'backgroundMime', false);
	62	+ /**
	63	+ * Return this classes capabilities
	64	+ *
	65	+ * @return array
	66	+ */
	67	+ public function getCapabilities() {
	68	+ $backgroundLogo = $this->config->getAppValue('theming', 'backgroundMime', false);
69	69
70		- return [
71		- 'theming' => [
72		- 'name' => $this->theming->getName(),
73		- 'url' => $this->theming->getBaseUrl(),
74		- 'slogan' => $this->theming->getSlogan(),
75		- 'color' => $this->theming->getColorPrimary(),
76		- 'color-text' => $this->util->invertTextColor($this->theming->getColorPrimary()) ? '#000000' : '#FFFFFF',
77		- 'logo' => $this->url->getAbsoluteURL($this->theming->getLogo()),
78		- 'background' => $backgroundLogo === 'backgroundColor' ?
79		- $this->theming->getColorPrimary() :
80		- $this->url->getAbsoluteURL($this->theming->getBackground()),
81		- ],
82		- ];
83		- }
	70	+ return [
	71	+ 'theming' => [
	72	+ 'name' => $this->theming->getName(),
	73	+ 'url' => $this->theming->getBaseUrl(),
	74	+ 'slogan' => $this->theming->getSlogan(),
	75	+ 'color' => $this->theming->getColorPrimary(),
	76	+ 'color-text' => $this->util->invertTextColor($this->theming->getColorPrimary()) ? '#000000' : '#FFFFFF',
	77	+ 'logo' => $this->url->getAbsoluteURL($this->theming->getLogo()),
	78	+ 'background' => $backgroundLogo === 'backgroundColor' ?
	79	+ $this->theming->getColorPrimary() :
	80	+ $this->url->getAbsoluteURL($this->theming->getBackground()),
	81	+ ],
	82	+ ];
	83	+ }
84	84	}

nextcloud / server

Pull Request — master (#6128)

Status

Category

Indentation +41 added lines, -41 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -2 removed lines patch added patch discarded remove patch