nextcloud / server

lib/private/DB/Connection.php

Indentation +516 added lines, -516 removed lines

@@ -56,520 +56,520 @@
 use OCP\PreConditionNotMetException;
 
 class Connection extends \Doctrine\DBAL\Connection {
-	/** @var string */
-	protected $tablePrefix;
-
-	/** @var \OC\DB\Adapter $adapter */
-	protected $adapter;
-
-	/** @var SystemConfig */
-	private $systemConfig;
-
-	/** @var ILogger */
-	private $logger;
-
-	protected $lockedTable = null;
-
-	/** @var int */
-	protected $queriesBuilt = 0;
-
-	/** @var int */
-	protected $queriesExecuted = 0;
-
-	/**
-	 * @throws Exception
-	 */
-	public function connect() {
-		try {
-			return parent::connect();
-		} catch (Exception $e) {
-			// throw a new exception to prevent leaking info from the stacktrace
-			throw new Exception('Failed to connect to the database: ' . $e->getMessage(), $e->getCode());
-		}
-	}
-
-	public function getStats(): array {
-		return [
-			'built' => $this->queriesBuilt,
-			'executed' => $this->queriesExecuted,
-		];
-	}
-
-	/**
-	 * Returns a QueryBuilder for the connection.
-	 */
-	public function getQueryBuilder(): IQueryBuilder {
-		$this->queriesBuilt++;
-		return new QueryBuilder(
-			new ConnectionAdapter($this),
-			$this->systemConfig,
-			$this->logger
-		);
-	}
-
-	/**
-	 * Gets the QueryBuilder for the connection.
-	 *
-	 * @return \Doctrine\DBAL\Query\QueryBuilder
-	 * @deprecated please use $this->getQueryBuilder() instead
-	 */
-	public function createQueryBuilder() {
-		$backtrace = $this->getCallerBacktrace();
-		\OC::$server->getLogger()->debug('Doctrine QueryBuilder retrieved in {backtrace}', ['app' => 'core', 'backtrace' => $backtrace]);
-		$this->queriesBuilt++;
-		return parent::createQueryBuilder();
-	}
-
-	/**
-	 * Gets the ExpressionBuilder for the connection.
-	 *
-	 * @return \Doctrine\DBAL\Query\Expression\ExpressionBuilder
-	 * @deprecated please use $this->getQueryBuilder()->expr() instead
-	 */
-	public function getExpressionBuilder() {
-		$backtrace = $this->getCallerBacktrace();
-		\OC::$server->getLogger()->debug('Doctrine ExpressionBuilder retrieved in {backtrace}', ['app' => 'core', 'backtrace' => $backtrace]);
-		$this->queriesBuilt++;
-		return parent::getExpressionBuilder();
-	}
-
-	/**
-	 * Get the file and line that called the method where `getCallerBacktrace()` was used
-	 *
-	 * @return string
-	 */
-	protected function getCallerBacktrace() {
-		$traces = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 2);
-
-		// 0 is the method where we use `getCallerBacktrace`
-		// 1 is the target method which uses the method we want to log
-		if (isset($traces[1])) {
-			return $traces[1]['file'] . ':' . $traces[1]['line'];
-		}
-
-		return '';
-	}
-
-	/**
-	 * @return string
-	 */
-	public function getPrefix() {
-		return $this->tablePrefix;
-	}
-
-	/**
-	 * Initializes a new instance of the Connection class.
-	 *
-	 * @param array $params  The connection parameters.
-	 * @param \Doctrine\DBAL\Driver $driver
-	 * @param \Doctrine\DBAL\Configuration $config
-	 * @param \Doctrine\Common\EventManager $eventManager
-	 * @throws \Exception
-	 */
-	public function __construct(array $params, Driver $driver, Configuration $config = null,
-		EventManager $eventManager = null) {
-		if (!isset($params['adapter'])) {
-			throw new \Exception('adapter not set');
-		}
-		if (!isset($params['tablePrefix'])) {
-			throw new \Exception('tablePrefix not set');
-		}
-		/**
-		 * @psalm-suppress InternalMethod
-		 */
-		parent::__construct($params, $driver, $config, $eventManager);
-		$this->adapter = new $params['adapter']($this);
-		$this->tablePrefix = $params['tablePrefix'];
-
-		$this->systemConfig = \OC::$server->getSystemConfig();
-		$this->logger = \OC::$server->getLogger();
-	}
-
-	/**
-	 * Prepares an SQL statement.
-	 *
-	 * @param string $statement The SQL statement to prepare.
-	 * @param int|null $limit
-	 * @param int|null $offset
-	 *
-	 * @return Statement The prepared statement.
-	 * @throws Exception
-	 */
-	public function prepare($statement, $limit = null, $offset = null): Statement {
-		if ($limit === -1 || $limit === null) {
-			$limit = null;
-		} else {
-			$limit = (int) $limit;
-		}
-		if ($offset !== null) {
-			$offset = (int) $offset;
-		}
-		if (!is_null($limit)) {
-			$platform = $this->getDatabasePlatform();
-			$statement = $platform->modifyLimitQuery($statement, $limit, $offset);
-		}
-		$statement = $this->replaceTablePrefix($statement);
-		$statement = $this->adapter->fixupStatement($statement);
-
-		return parent::prepare($statement);
-	}
-
-	/**
-	 * Executes an, optionally parametrized, SQL query.
-	 *
-	 * If the query is parametrized, a prepared statement is used.
-	 * If an SQLLogger is configured, the execution is logged.
-	 *
-	 * @param string                                      $sql  The SQL query to execute.
-	 * @param array                                       $params The parameters to bind to the query, if any.
-	 * @param array                                       $types  The types the previous parameters are in.
-	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
-	 *
-	 * @return Result The executed statement.
-	 *
-	 * @throws \Doctrine\DBAL\Exception
-	 */
-	public function executeQuery(string $sql, array $params = [], $types = [], QueryCacheProfile $qcp = null): Result {
-		$sql = $this->replaceTablePrefix($sql);
-		$sql = $this->adapter->fixupStatement($sql);
-		$this->queriesExecuted++;
-		$this->logQueryToFile($sql);
-		return parent::executeQuery($sql, $params, $types, $qcp);
-	}
-
-	/**
-	 * @throws Exception
-	 */
-	public function executeUpdate(string $sql, array $params = [], array $types = []): int {
-		$sql = $this->replaceTablePrefix($sql);
-		$sql = $this->adapter->fixupStatement($sql);
-		$this->queriesExecuted++;
-		$this->logQueryToFile($sql);
-		return parent::executeUpdate($sql, $params, $types);
-	}
-
-	/**
-	 * Executes an SQL INSERT/UPDATE/DELETE query with the given parameters
-	 * and returns the number of affected rows.
-	 *
-	 * This method supports PDO binding types as well as DBAL mapping types.
-	 *
-	 * @param string $sql  The SQL query.
-	 * @param array  $params The query parameters.
-	 * @param array  $types  The parameter types.
-	 *
-	 * @return int The number of affected rows.
-	 *
-	 * @throws \Doctrine\DBAL\Exception
-	 */
-	public function executeStatement($sql, array $params = [], array $types = []): int {
-		$sql = $this->replaceTablePrefix($sql);
-		$sql = $this->adapter->fixupStatement($sql);
-		$this->queriesExecuted++;
-		$this->logQueryToFile($sql);
-		return parent::executeStatement($sql, $params, $types);
-	}
-
-	protected function logQueryToFile(string $sql): void {
-		$logFile = $this->systemConfig->getValue('query_log_file', '');
-		if ($logFile !== '' && is_writable(dirname($logFile)) && (!file_exists($logFile) || is_writable($logFile))) {
-			file_put_contents(
-				$this->systemConfig->getValue('query_log_file', ''),
-				$sql . "\n",
-				FILE_APPEND
-			);
-		}
-	}
-
-	/**
-	 * Returns the ID of the last inserted row, or the last value from a sequence object,
-	 * depending on the underlying driver.
-	 *
-	 * Note: This method may not return a meaningful or consistent result across different drivers,
-	 * because the underlying database may not even support the notion of AUTO_INCREMENT/IDENTITY
-	 * columns or sequences.
-	 *
-	 * @param string $seqName Name of the sequence object from which the ID should be returned.
-	 *
-	 * @return string the last inserted ID.
-	 * @throws Exception
-	 */
-	public function lastInsertId($seqName = null) {
-		if ($seqName) {
-			$seqName = $this->replaceTablePrefix($seqName);
-		}
-		return $this->adapter->lastInsertId($seqName);
-	}
-
-	/**
-	 * @internal
-	 * @throws Exception
-	 */
-	public function realLastInsertId($seqName = null) {
-		return parent::lastInsertId($seqName);
-	}
-
-	/**
-	 * Insert a row if the matching row does not exists. To accomplish proper race condition avoidance
-	 * it is needed that there is also a unique constraint on the values. Then this method will
-	 * catch the exception and return 0.
-	 *
-	 * @param string $table The table name (will replace *PREFIX* with the actual prefix)
-	 * @param array $input data that should be inserted into the table  (column name => value)
-	 * @param array|null $compare List of values that should be checked for "if not exists"
-	 *				If this is null or an empty array, all keys of $input will be compared
-	 *				Please note: text fields (clob) must not be used in the compare array
-	 * @return int number of inserted rows
-	 * @throws \Doctrine\DBAL\Exception
-	 * @deprecated 15.0.0 - use unique index and "try { $db->insert() } catch (UniqueConstraintViolationException $e) {}" instead, because it is more reliable and does not have the risk for deadlocks - see https://github.com/nextcloud/server/pull/12371
-	 */
-	public function insertIfNotExist($table, $input, array $compare = null) {
-		return $this->adapter->insertIfNotExist($table, $input, $compare);
-	}
-
-	public function insertIgnoreConflict(string $table, array $values) : int {
-		return $this->adapter->insertIgnoreConflict($table, $values);
-	}
-
-	private function getType($value) {
-		if (is_bool($value)) {
-			return IQueryBuilder::PARAM_BOOL;
-		} elseif (is_int($value)) {
-			return IQueryBuilder::PARAM_INT;
-		} else {
-			return IQueryBuilder::PARAM_STR;
-		}
-	}
-
-	/**
-	 * Insert or update a row value
-	 *
-	 * @param string $table
-	 * @param array $keys (column name => value)
-	 * @param array $values (column name => value)
-	 * @param array $updatePreconditionValues ensure values match preconditions (column name => value)
-	 * @return int number of new rows
-	 * @throws \Doctrine\DBAL\Exception
-	 * @throws PreConditionNotMetException
-	 */
-	public function setValues($table, array $keys, array $values, array $updatePreconditionValues = []) {
-		try {
-			$insertQb = $this->getQueryBuilder();
-			$insertQb->insert($table)
-				->values(
-					array_map(function ($value) use ($insertQb) {
-						return $insertQb->createNamedParameter($value, $this->getType($value));
-					}, array_merge($keys, $values))
-				);
-			return $insertQb->execute();
-		} catch (NotNullConstraintViolationException $e) {
-			throw $e;
-		} catch (ConstraintViolationException $e) {
-			// value already exists, try update
-			$updateQb = $this->getQueryBuilder();
-			$updateQb->update($table);
-			foreach ($values as $name => $value) {
-				$updateQb->set($name, $updateQb->createNamedParameter($value, $this->getType($value)));
-			}
-			$where = $updateQb->expr()->andX();
-			$whereValues = array_merge($keys, $updatePreconditionValues);
-			foreach ($whereValues as $name => $value) {
-				if ($value === '') {
-					$where->add($updateQb->expr()->emptyString(
-						$name
-					));
-				} else {
-					$where->add($updateQb->expr()->eq(
-						$name,
-						$updateQb->createNamedParameter($value, $this->getType($value)),
-						$this->getType($value)
-					));
-				}
-			}
-			$updateQb->where($where);
-			$affected = $updateQb->execute();
-
-			if ($affected === 0 && !empty($updatePreconditionValues)) {
-				throw new PreConditionNotMetException();
-			}
-
-			return 0;
-		}
-	}
-
-	/**
-	 * Create an exclusive read+write lock on a table
-	 *
-	 * @param string $tableName
-	 *
-	 * @throws \BadMethodCallException When trying to acquire a second lock
-	 * @throws Exception
-	 * @since 9.1.0
-	 */
-	public function lockTable($tableName) {
-		if ($this->lockedTable !== null) {
-			throw new \BadMethodCallException('Can not lock a new table until the previous lock is released.');
-		}
-
-		$tableName = $this->tablePrefix . $tableName;
-		$this->lockedTable = $tableName;
-		$this->adapter->lockTable($tableName);
-	}
-
-	/**
-	 * Release a previous acquired lock again
-	 *
-	 * @throws Exception
-	 * @since 9.1.0
-	 */
-	public function unlockTable() {
-		$this->adapter->unlockTable();
-		$this->lockedTable = null;
-	}
-
-	/**
-	 * returns the error code and message as a string for logging
-	 * works with DoctrineException
-	 * @return string
-	 */
-	public function getError() {
-		$msg = $this->errorCode() . ': ';
-		$errorInfo = $this->errorInfo();
-		if (!empty($errorInfo)) {
-			$msg .= 'SQLSTATE = '.$errorInfo[0] . ', ';
-			$msg .= 'Driver Code = '.$errorInfo[1] . ', ';
-			$msg .= 'Driver Message = '.$errorInfo[2];
-		}
-		return $msg;
-	}
-
-	public function errorCode() {
-		return -1;
-	}
-
-	public function errorInfo() {
-		return [];
-	}
-
-	/**
-	 * Drop a table from the database if it exists
-	 *
-	 * @param string $table table name without the prefix
-	 *
-	 * @throws Exception
-	 */
-	public function dropTable($table) {
-		$table = $this->tablePrefix . trim($table);
-		$schema = $this->getSchemaManager();
-		if ($schema->tablesExist([$table])) {
-			$schema->dropTable($table);
-		}
-	}
-
-	/**
-	 * Check if a table exists
-	 *
-	 * @param string $table table name without the prefix
-	 *
-	 * @return bool
-	 * @throws Exception
-	 */
-	public function tableExists($table) {
-		$table = $this->tablePrefix . trim($table);
-		$schema = $this->getSchemaManager();
-		return $schema->tablesExist([$table]);
-	}
-
-	// internal use
-	/**
-	 * @param string $statement
-	 * @return string
-	 */
-	protected function replaceTablePrefix($statement) {
-		return str_replace('*PREFIX*', $this->tablePrefix, $statement);
-	}
-
-	/**
-	 * Check if a transaction is active
-	 *
-	 * @return bool
-	 * @since 8.2.0
-	 */
-	public function inTransaction() {
-		return $this->getTransactionNestingLevel() > 0;
-	}
-
-	/**
-	 * Escape a parameter to be used in a LIKE query
-	 *
-	 * @param string $param
-	 * @return string
-	 */
-	public function escapeLikeParameter($param) {
-		return addcslashes($param, '\\_%');
-	}
-
-	/**
-	 * Check whether or not the current database support 4byte wide unicode
-	 *
-	 * @return bool
-	 * @since 11.0.0
-	 */
-	public function supports4ByteText() {
-		if (!$this->getDatabasePlatform() instanceof MySQLPlatform) {
-			return true;
-		}
-		return $this->getParams()['charset'] === 'utf8mb4';
-	}
-
-
-	/**
-	 * Create the schema of the connected database
-	 *
-	 * @return Schema
-	 * @throws Exception
-	 */
-	public function createSchema() {
-		$migrator = $this->getMigrator();
-		return $migrator->createSchema();
-	}
-
-	/**
-	 * Migrate the database to the given schema
-	 *
-	 * @param Schema $toSchema
-	 * @param bool $dryRun If true, will return the sql queries instead of running them.
-	 *
-	 * @throws Exception
-	 *
-	 * @return string|null Returns a string only if $dryRun is true.
-	 */
-	public function migrateToSchema(Schema $toSchema, bool $dryRun = false) {
-		$migrator = $this->getMigrator();
-
-		if ($dryRun) {
-			return $migrator->generateChangeScript($toSchema);
-		} else {
-			$migrator->migrate($toSchema);
-		}
-	}
-
-	private function getMigrator() {
-		// TODO properly inject those dependencies
-		$random = \OC::$server->getSecureRandom();
-		$platform = $this->getDatabasePlatform();
-		$config = \OC::$server->getConfig();
-		$dispatcher = \OC::$server->getEventDispatcher();
-		if ($platform instanceof SqlitePlatform) {
-			return new SQLiteMigrator($this, $config, $dispatcher);
-		} elseif ($platform instanceof OraclePlatform) {
-			return new OracleMigrator($this, $config, $dispatcher);
-		} elseif ($platform instanceof MySQLPlatform) {
-			return new MySQLMigrator($this, $config, $dispatcher);
-		} elseif ($platform instanceof PostgreSQL94Platform) {
-			return new PostgreSqlMigrator($this, $config, $dispatcher);
-		} else {
-			return new Migrator($this, $config, $dispatcher);
-		}
-	}
+    /** @var string */
+    protected $tablePrefix;
+
+    /** @var \OC\DB\Adapter $adapter */
+    protected $adapter;
+
+    /** @var SystemConfig */
+    private $systemConfig;
+
+    /** @var ILogger */
+    private $logger;
+
+    protected $lockedTable = null;
+
+    /** @var int */
+    protected $queriesBuilt = 0;
+
+    /** @var int */
+    protected $queriesExecuted = 0;
+
+    /**
+     * @throws Exception
+     */
+    public function connect() {
+        try {
+            return parent::connect();
+        } catch (Exception $e) {
+            // throw a new exception to prevent leaking info from the stacktrace
+            throw new Exception('Failed to connect to the database: ' . $e->getMessage(), $e->getCode());
+        }
+    }
+
+    public function getStats(): array {
+        return [
+            'built' => $this->queriesBuilt,
+            'executed' => $this->queriesExecuted,
+        ];
+    }
+
+    /**
+     * Returns a QueryBuilder for the connection.
+     */
+    public function getQueryBuilder(): IQueryBuilder {
+        $this->queriesBuilt++;
+        return new QueryBuilder(
+            new ConnectionAdapter($this),
+            $this->systemConfig,
+            $this->logger
+        );
+    }
+
+    /**
+     * Gets the QueryBuilder for the connection.
+     *
+     * @return \Doctrine\DBAL\Query\QueryBuilder
+     * @deprecated please use $this->getQueryBuilder() instead
+     */
+    public function createQueryBuilder() {
+        $backtrace = $this->getCallerBacktrace();
+        \OC::$server->getLogger()->debug('Doctrine QueryBuilder retrieved in {backtrace}', ['app' => 'core', 'backtrace' => $backtrace]);
+        $this->queriesBuilt++;
+        return parent::createQueryBuilder();
+    }
+
+    /**
+     * Gets the ExpressionBuilder for the connection.
+     *
+     * @return \Doctrine\DBAL\Query\Expression\ExpressionBuilder
+     * @deprecated please use $this->getQueryBuilder()->expr() instead
+     */
+    public function getExpressionBuilder() {
+        $backtrace = $this->getCallerBacktrace();
+        \OC::$server->getLogger()->debug('Doctrine ExpressionBuilder retrieved in {backtrace}', ['app' => 'core', 'backtrace' => $backtrace]);
+        $this->queriesBuilt++;
+        return parent::getExpressionBuilder();
+    }
+
+    /**
+     * Get the file and line that called the method where `getCallerBacktrace()` was used
+     *
+     * @return string
+     */
+    protected function getCallerBacktrace() {
+        $traces = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 2);
+
+        // 0 is the method where we use `getCallerBacktrace`
+        // 1 is the target method which uses the method we want to log
+        if (isset($traces[1])) {
+            return $traces[1]['file'] . ':' . $traces[1]['line'];
+        }
+
+        return '';
+    }
+
+    /**
+     * @return string
+     */
+    public function getPrefix() {
+        return $this->tablePrefix;
+    }
+
+    /**
+     * Initializes a new instance of the Connection class.
+     *
+     * @param array $params  The connection parameters.
+     * @param \Doctrine\DBAL\Driver $driver
+     * @param \Doctrine\DBAL\Configuration $config
+     * @param \Doctrine\Common\EventManager $eventManager
+     * @throws \Exception
+     */
+    public function __construct(array $params, Driver $driver, Configuration $config = null,
+        EventManager $eventManager = null) {
+        if (!isset($params['adapter'])) {
+            throw new \Exception('adapter not set');
+        }
+        if (!isset($params['tablePrefix'])) {
+            throw new \Exception('tablePrefix not set');
+        }
+        /**
+         * @psalm-suppress InternalMethod
+         */
+        parent::__construct($params, $driver, $config, $eventManager);
+        $this->adapter = new $params['adapter']($this);
+        $this->tablePrefix = $params['tablePrefix'];
+
+        $this->systemConfig = \OC::$server->getSystemConfig();
+        $this->logger = \OC::$server->getLogger();
+    }
+
+    /**
+     * Prepares an SQL statement.
+     *
+     * @param string $statement The SQL statement to prepare.
+     * @param int|null $limit
+     * @param int|null $offset
+     *
+     * @return Statement The prepared statement.
+     * @throws Exception
+     */
+    public function prepare($statement, $limit = null, $offset = null): Statement {
+        if ($limit === -1 || $limit === null) {
+            $limit = null;
+        } else {
+            $limit = (int) $limit;
+        }
+        if ($offset !== null) {
+            $offset = (int) $offset;
+        }
+        if (!is_null($limit)) {
+            $platform = $this->getDatabasePlatform();
+            $statement = $platform->modifyLimitQuery($statement, $limit, $offset);
+        }
+        $statement = $this->replaceTablePrefix($statement);
+        $statement = $this->adapter->fixupStatement($statement);
+
+        return parent::prepare($statement);
+    }
+
+    /**
+     * Executes an, optionally parametrized, SQL query.
+     *
+     * If the query is parametrized, a prepared statement is used.
+     * If an SQLLogger is configured, the execution is logged.
+     *
+     * @param string                                      $sql  The SQL query to execute.
+     * @param array                                       $params The parameters to bind to the query, if any.
+     * @param array                                       $types  The types the previous parameters are in.
+     * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
+     *
+     * @return Result The executed statement.
+     *
+     * @throws \Doctrine\DBAL\Exception
+     */
+    public function executeQuery(string $sql, array $params = [], $types = [], QueryCacheProfile $qcp = null): Result {
+        $sql = $this->replaceTablePrefix($sql);
+        $sql = $this->adapter->fixupStatement($sql);
+        $this->queriesExecuted++;
+        $this->logQueryToFile($sql);
+        return parent::executeQuery($sql, $params, $types, $qcp);
+    }
+
+    /**
+     * @throws Exception
+     */
+    public function executeUpdate(string $sql, array $params = [], array $types = []): int {
+        $sql = $this->replaceTablePrefix($sql);
+        $sql = $this->adapter->fixupStatement($sql);
+        $this->queriesExecuted++;
+        $this->logQueryToFile($sql);
+        return parent::executeUpdate($sql, $params, $types);
+    }
+
+    /**
+     * Executes an SQL INSERT/UPDATE/DELETE query with the given parameters
+     * and returns the number of affected rows.
+     *
+     * This method supports PDO binding types as well as DBAL mapping types.
+     *
+     * @param string $sql  The SQL query.
+     * @param array  $params The query parameters.
+     * @param array  $types  The parameter types.
+     *
+     * @return int The number of affected rows.
+     *
+     * @throws \Doctrine\DBAL\Exception
+     */
+    public function executeStatement($sql, array $params = [], array $types = []): int {
+        $sql = $this->replaceTablePrefix($sql);
+        $sql = $this->adapter->fixupStatement($sql);
+        $this->queriesExecuted++;
+        $this->logQueryToFile($sql);
+        return parent::executeStatement($sql, $params, $types);
+    }
+
+    protected function logQueryToFile(string $sql): void {
+        $logFile = $this->systemConfig->getValue('query_log_file', '');
+        if ($logFile !== '' && is_writable(dirname($logFile)) && (!file_exists($logFile) || is_writable($logFile))) {
+            file_put_contents(
+                $this->systemConfig->getValue('query_log_file', ''),
+                $sql . "\n",
+                FILE_APPEND
+            );
+        }
+    }
+
+    /**
+     * Returns the ID of the last inserted row, or the last value from a sequence object,
+     * depending on the underlying driver.
+     *
+     * Note: This method may not return a meaningful or consistent result across different drivers,
+     * because the underlying database may not even support the notion of AUTO_INCREMENT/IDENTITY
+     * columns or sequences.
+     *
+     * @param string $seqName Name of the sequence object from which the ID should be returned.
+     *
+     * @return string the last inserted ID.
+     * @throws Exception
+     */
+    public function lastInsertId($seqName = null) {
+        if ($seqName) {
+            $seqName = $this->replaceTablePrefix($seqName);
+        }
+        return $this->adapter->lastInsertId($seqName);
+    }
+
+    /**
+     * @internal
+     * @throws Exception
+     */
+    public function realLastInsertId($seqName = null) {
+        return parent::lastInsertId($seqName);
+    }
+
+    /**
+     * Insert a row if the matching row does not exists. To accomplish proper race condition avoidance
+     * it is needed that there is also a unique constraint on the values. Then this method will
+     * catch the exception and return 0.
+     *
+     * @param string $table The table name (will replace *PREFIX* with the actual prefix)
+     * @param array $input data that should be inserted into the table  (column name => value)
+     * @param array|null $compare List of values that should be checked for "if not exists"
+     *				If this is null or an empty array, all keys of $input will be compared
+     *				Please note: text fields (clob) must not be used in the compare array
+     * @return int number of inserted rows
+     * @throws \Doctrine\DBAL\Exception
+     * @deprecated 15.0.0 - use unique index and "try { $db->insert() } catch (UniqueConstraintViolationException $e) {}" instead, because it is more reliable and does not have the risk for deadlocks - see https://github.com/nextcloud/server/pull/12371
+     */
+    public function insertIfNotExist($table, $input, array $compare = null) {
+        return $this->adapter->insertIfNotExist($table, $input, $compare);
+    }
+
+    public function insertIgnoreConflict(string $table, array $values) : int {
+        return $this->adapter->insertIgnoreConflict($table, $values);
+    }
+
+    private function getType($value) {
+        if (is_bool($value)) {
+            return IQueryBuilder::PARAM_BOOL;
+        } elseif (is_int($value)) {
+            return IQueryBuilder::PARAM_INT;
+        } else {
+            return IQueryBuilder::PARAM_STR;
+        }
+    }
+
+    /**
+     * Insert or update a row value
+     *
+     * @param string $table
+     * @param array $keys (column name => value)
+     * @param array $values (column name => value)
+     * @param array $updatePreconditionValues ensure values match preconditions (column name => value)
+     * @return int number of new rows
+     * @throws \Doctrine\DBAL\Exception
+     * @throws PreConditionNotMetException
+     */
+    public function setValues($table, array $keys, array $values, array $updatePreconditionValues = []) {
+        try {
+            $insertQb = $this->getQueryBuilder();
+            $insertQb->insert($table)
+                ->values(
+                    array_map(function ($value) use ($insertQb) {
+                        return $insertQb->createNamedParameter($value, $this->getType($value));
+                    }, array_merge($keys, $values))
+                );
+            return $insertQb->execute();
+        } catch (NotNullConstraintViolationException $e) {
+            throw $e;
+        } catch (ConstraintViolationException $e) {
+            // value already exists, try update
+            $updateQb = $this->getQueryBuilder();
+            $updateQb->update($table);
+            foreach ($values as $name => $value) {
+                $updateQb->set($name, $updateQb->createNamedParameter($value, $this->getType($value)));
+            }
+            $where = $updateQb->expr()->andX();
+            $whereValues = array_merge($keys, $updatePreconditionValues);
+            foreach ($whereValues as $name => $value) {
+                if ($value === '') {
+                    $where->add($updateQb->expr()->emptyString(
+                        $name
+                    ));
+                } else {
+                    $where->add($updateQb->expr()->eq(
+                        $name,
+                        $updateQb->createNamedParameter($value, $this->getType($value)),
+                        $this->getType($value)
+                    ));
+                }
+            }
+            $updateQb->where($where);
+            $affected = $updateQb->execute();
+
+            if ($affected === 0 && !empty($updatePreconditionValues)) {
+                throw new PreConditionNotMetException();
+            }
+
+            return 0;
+        }
+    }
+
+    /**
+     * Create an exclusive read+write lock on a table
+     *
+     * @param string $tableName
+     *
+     * @throws \BadMethodCallException When trying to acquire a second lock
+     * @throws Exception
+     * @since 9.1.0
+     */
+    public function lockTable($tableName) {
+        if ($this->lockedTable !== null) {
+            throw new \BadMethodCallException('Can not lock a new table until the previous lock is released.');
+        }
+
+        $tableName = $this->tablePrefix . $tableName;
+        $this->lockedTable = $tableName;
+        $this->adapter->lockTable($tableName);
+    }
+
+    /**
+     * Release a previous acquired lock again
+     *
+     * @throws Exception
+     * @since 9.1.0
+     */
+    public function unlockTable() {
+        $this->adapter->unlockTable();
+        $this->lockedTable = null;
+    }
+
+    /**
+     * returns the error code and message as a string for logging
+     * works with DoctrineException
+     * @return string
+     */
+    public function getError() {
+        $msg = $this->errorCode() . ': ';
+        $errorInfo = $this->errorInfo();
+        if (!empty($errorInfo)) {
+            $msg .= 'SQLSTATE = '.$errorInfo[0] . ', ';
+            $msg .= 'Driver Code = '.$errorInfo[1] . ', ';
+            $msg .= 'Driver Message = '.$errorInfo[2];
+        }
+        return $msg;
+    }
+
+    public function errorCode() {
+        return -1;
+    }
+
+    public function errorInfo() {
+        return [];
+    }
+
+    /**
+     * Drop a table from the database if it exists
+     *
+     * @param string $table table name without the prefix
+     *
+     * @throws Exception
+     */
+    public function dropTable($table) {
+        $table = $this->tablePrefix . trim($table);
+        $schema = $this->getSchemaManager();
+        if ($schema->tablesExist([$table])) {
+            $schema->dropTable($table);
+        }
+    }
+
+    /**
+     * Check if a table exists
+     *
+     * @param string $table table name without the prefix
+     *
+     * @return bool
+     * @throws Exception
+     */
+    public function tableExists($table) {
+        $table = $this->tablePrefix . trim($table);
+        $schema = $this->getSchemaManager();
+        return $schema->tablesExist([$table]);
+    }
+
+    // internal use
+    /**
+     * @param string $statement
+     * @return string
+     */
+    protected function replaceTablePrefix($statement) {
+        return str_replace('*PREFIX*', $this->tablePrefix, $statement);
+    }
+
+    /**
+     * Check if a transaction is active
+     *
+     * @return bool
+     * @since 8.2.0
+     */
+    public function inTransaction() {
+        return $this->getTransactionNestingLevel() > 0;
+    }
+
+    /**
+     * Escape a parameter to be used in a LIKE query
+     *
+     * @param string $param
+     * @return string
+     */
+    public function escapeLikeParameter($param) {
+        return addcslashes($param, '\\_%');
+    }
+
+    /**
+     * Check whether or not the current database support 4byte wide unicode
+     *
+     * @return bool
+     * @since 11.0.0
+     */
+    public function supports4ByteText() {
+        if (!$this->getDatabasePlatform() instanceof MySQLPlatform) {
+            return true;
+        }
+        return $this->getParams()['charset'] === 'utf8mb4';
+    }
+
+
+    /**
+     * Create the schema of the connected database
+     *
+     * @return Schema
+     * @throws Exception
+     */
+    public function createSchema() {
+        $migrator = $this->getMigrator();
+        return $migrator->createSchema();
+    }
+
+    /**
+     * Migrate the database to the given schema
+     *
+     * @param Schema $toSchema
+     * @param bool $dryRun If true, will return the sql queries instead of running them.
+     *
+     * @throws Exception
+     *
+     * @return string|null Returns a string only if $dryRun is true.
+     */
+    public function migrateToSchema(Schema $toSchema, bool $dryRun = false) {
+        $migrator = $this->getMigrator();
+
+        if ($dryRun) {
+            return $migrator->generateChangeScript($toSchema);
+        } else {
+            $migrator->migrate($toSchema);
+        }
+    }
+
+    private function getMigrator() {
+        // TODO properly inject those dependencies
+        $random = \OC::$server->getSecureRandom();
+        $platform = $this->getDatabasePlatform();
+        $config = \OC::$server->getConfig();
+        $dispatcher = \OC::$server->getEventDispatcher();
+        if ($platform instanceof SqlitePlatform) {
+            return new SQLiteMigrator($this, $config, $dispatcher);
+        } elseif ($platform instanceof OraclePlatform) {
+            return new OracleMigrator($this, $config, $dispatcher);
+        } elseif ($platform instanceof MySQLPlatform) {
+            return new MySQLMigrator($this, $config, $dispatcher);
+        } elseif ($platform instanceof PostgreSQL94Platform) {
+            return new PostgreSqlMigrator($this, $config, $dispatcher);
+        } else {
+            return new Migrator($this, $config, $dispatcher);
+        }
+    }
 }

core/Command/Db/AddMissingColumns.php

Indentation +53 added lines, -53 removed lines

@@ -46,67 +46,67 @@
  */
 class AddMissingColumns extends Command {
 
-	/** @var Connection */
-	private $connection;
+    /** @var Connection */
+    private $connection;
 
-	/** @var EventDispatcherInterface */
-	private $dispatcher;
+    /** @var EventDispatcherInterface */
+    private $dispatcher;
 
-	public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
-		parent::__construct();
+    public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
+        parent::__construct();
 
-		$this->connection = $connection;
-		$this->dispatcher = $dispatcher;
-	}
+        $this->connection = $connection;
+        $this->dispatcher = $dispatcher;
+    }
 
-	protected function configure() {
-		$this
-			->setName('db:add-missing-columns')
-			->setDescription('Add missing optional columns to the database tables')
-			->addOption('dry-run', null, InputOption::VALUE_NONE, "Output the SQL queries instead of running them.");
-	}
+    protected function configure() {
+        $this
+            ->setName('db:add-missing-columns')
+            ->setDescription('Add missing optional columns to the database tables')
+            ->addOption('dry-run', null, InputOption::VALUE_NONE, "Output the SQL queries instead of running them.");
+    }
 
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$this->addCoreColumns($output, $input->getOption('dry-run'));
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $this->addCoreColumns($output, $input->getOption('dry-run'));
 
-		// Dispatch event so apps can also update columns if needed
-		$event = new GenericEvent($output);
-		$this->dispatcher->dispatch(IDBConnection::ADD_MISSING_COLUMNS_EVENT, $event);
-		return 0;
-	}
+        // Dispatch event so apps can also update columns if needed
+        $event = new GenericEvent($output);
+        $this->dispatcher->dispatch(IDBConnection::ADD_MISSING_COLUMNS_EVENT, $event);
+        return 0;
+    }
 
-	/**
-	 * add missing indices to the share table
-	 *
-	 * @param OutputInterface $output
-	 * @param bool $dryRun If true, will return the sql queries instead of running them.
-	 * @throws \Doctrine\DBAL\Schema\SchemaException
-	 */
-	private function addCoreColumns(OutputInterface $output, bool $dryRun): void {
-		$output->writeln('<info>Check columns of the comments table.</info>');
+    /**
+     * add missing indices to the share table
+     *
+     * @param OutputInterface $output
+     * @param bool $dryRun If true, will return the sql queries instead of running them.
+     * @throws \Doctrine\DBAL\Schema\SchemaException
+     */
+    private function addCoreColumns(OutputInterface $output, bool $dryRun): void {
+        $output->writeln('<info>Check columns of the comments table.</info>');
 
-		$schema = new SchemaWrapper($this->connection);
-		$updated = false;
+        $schema = new SchemaWrapper($this->connection);
+        $updated = false;
 
-		if ($schema->hasTable('comments')) {
-			$table = $schema->getTable('comments');
-			if (!$table->hasColumn('reference_id')) {
-				$output->writeln('<info>Adding additional reference_id column to the comments table, this can take some time...</info>');
-				$table->addColumn('reference_id', 'string', [
-					'notnull' => false,
-					'length' => 64,
-				]);
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Comments table updated successfully.</info>');
-			}
-		}
+        if ($schema->hasTable('comments')) {
+            $table = $schema->getTable('comments');
+            if (!$table->hasColumn('reference_id')) {
+                $output->writeln('<info>Adding additional reference_id column to the comments table, this can take some time...</info>');
+                $table->addColumn('reference_id', 'string', [
+                    'notnull' => false,
+                    'length' => 64,
+                ]);
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Comments table updated successfully.</info>');
+            }
+        }
 
-		if (!$updated) {
-			$output->writeln('<info>Done.</info>');
-		}
-	}
+        if (!$updated) {
+            $output->writeln('<info>Done.</info>');
+        }
+    }
 }

core/Command/Db/AddMissingPrimaryKeys.php

Indentation +148 added lines, -148 removed lines

@@ -46,152 +46,152 @@
  */
 class AddMissingPrimaryKeys extends Command {
 
-	/** @var Connection */
-	private $connection;
-
-	/** @var EventDispatcherInterface */
-	private $dispatcher;
-
-	public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
-		parent::__construct();
-
-		$this->connection = $connection;
-		$this->dispatcher = $dispatcher;
-	}
-
-	protected function configure() {
-		$this
-			->setName('db:add-missing-primary-keys')
-			->setDescription('Add missing primary keys to the database tables')
-			->addOption('dry-run', null, InputOption::VALUE_NONE, "Output the SQL queries instead of running them.");
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$this->addCorePrimaryKeys($output, $input->getOption('dry-run'));
-
-		// Dispatch event so apps can also update indexes if needed
-		$event = new GenericEvent($output);
-		$this->dispatcher->dispatch(IDBConnection::ADD_MISSING_PRIMARY_KEYS_EVENT, $event);
-		return 0;
-	}
-
-	/**
-	 * add missing indices to the share table
-	 *
-	 * @param OutputInterface $output
-	 * @param bool $dryRun If true, will return the sql queries instead of running them.
-	 * @throws \Doctrine\DBAL\Schema\SchemaException
-	 */
-	private function addCorePrimaryKeys(OutputInterface $output, bool $dryRun): void {
-		$output->writeln('<info>Check primary keys.</info>');
-
-		$schema = new SchemaWrapper($this->connection);
-		$updated = false;
-
-		if ($schema->hasTable('federated_reshares')) {
-			$table = $schema->getTable('federated_reshares');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the federated_reshares table, this can take some time...</info>');
-				$table->setPrimaryKey(['share_id'], 'federated_res_pk');
-				if ($table->hasIndex('share_id_index')) {
-					$table->dropIndex('share_id_index');
-				}
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>federated_reshares table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('systemtag_object_mapping')) {
-			$table = $schema->getTable('systemtag_object_mapping');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the systemtag_object_mapping table, this can take some time...</info>');
-				$table->setPrimaryKey(['objecttype', 'objectid', 'systemtagid'], 'som_pk');
-				if ($table->hasIndex('mapping')) {
-					$table->dropIndex('mapping');
-				}
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>systemtag_object_mapping table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('comments_read_markers')) {
-			$table = $schema->getTable('comments_read_markers');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the comments_read_markers table, this can take some time...</info>');
-				$table->setPrimaryKey(['user_id', 'object_type', 'object_id'], 'crm_pk');
-				if ($table->hasIndex('comments_marker_index')) {
-					$table->dropIndex('comments_marker_index');
-				}
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>comments_read_markers table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('collres_resources')) {
-			$table = $schema->getTable('collres_resources');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the collres_resources table, this can take some time...</info>');
-				$table->setPrimaryKey(['collection_id', 'resource_type', 'resource_id'], 'crr_pk');
-				if ($table->hasIndex('collres_unique_res')) {
-					$table->dropIndex('collres_unique_res');
-				}
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>collres_resources table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('collres_accesscache')) {
-			$table = $schema->getTable('collres_accesscache');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the collres_accesscache table, this can take some time...</info>');
-				$table->setPrimaryKey(['user_id', 'collection_id', 'resource_type', 'resource_id'], 'cra_pk');
-				if ($table->hasIndex('collres_unique_user')) {
-					$table->dropIndex('collres_unique_user');
-				}
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>collres_accesscache table updated successfully.</info>');
-			}
-		}
-
-		if ($schema->hasTable('filecache_extended')) {
-			$table = $schema->getTable('filecache_extended');
-			if (!$table->hasPrimaryKey()) {
-				$output->writeln('<info>Adding primary key to the filecache_extended table, this can take some time...</info>');
-				$table->setPrimaryKey(['fileid'], 'fce_pk');
-				if ($table->hasIndex('fce_fileid_idx')) {
-					$table->dropIndex('fce_fileid_idx');
-				}
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>filecache_extended table updated successfully.</info>');
-			}
-		}
-
-		if (!$updated) {
-			$output->writeln('<info>Done.</info>');
-		}
-	}
+    /** @var Connection */
+    private $connection;
+
+    /** @var EventDispatcherInterface */
+    private $dispatcher;
+
+    public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
+        parent::__construct();
+
+        $this->connection = $connection;
+        $this->dispatcher = $dispatcher;
+    }
+
+    protected function configure() {
+        $this
+            ->setName('db:add-missing-primary-keys')
+            ->setDescription('Add missing primary keys to the database tables')
+            ->addOption('dry-run', null, InputOption::VALUE_NONE, "Output the SQL queries instead of running them.");
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $this->addCorePrimaryKeys($output, $input->getOption('dry-run'));
+
+        // Dispatch event so apps can also update indexes if needed
+        $event = new GenericEvent($output);
+        $this->dispatcher->dispatch(IDBConnection::ADD_MISSING_PRIMARY_KEYS_EVENT, $event);
+        return 0;
+    }
+
+    /**
+     * add missing indices to the share table
+     *
+     * @param OutputInterface $output
+     * @param bool $dryRun If true, will return the sql queries instead of running them.
+     * @throws \Doctrine\DBAL\Schema\SchemaException
+     */
+    private function addCorePrimaryKeys(OutputInterface $output, bool $dryRun): void {
+        $output->writeln('<info>Check primary keys.</info>');
+
+        $schema = new SchemaWrapper($this->connection);
+        $updated = false;
+
+        if ($schema->hasTable('federated_reshares')) {
+            $table = $schema->getTable('federated_reshares');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the federated_reshares table, this can take some time...</info>');
+                $table->setPrimaryKey(['share_id'], 'federated_res_pk');
+                if ($table->hasIndex('share_id_index')) {
+                    $table->dropIndex('share_id_index');
+                }
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>federated_reshares table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('systemtag_object_mapping')) {
+            $table = $schema->getTable('systemtag_object_mapping');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the systemtag_object_mapping table, this can take some time...</info>');
+                $table->setPrimaryKey(['objecttype', 'objectid', 'systemtagid'], 'som_pk');
+                if ($table->hasIndex('mapping')) {
+                    $table->dropIndex('mapping');
+                }
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>systemtag_object_mapping table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('comments_read_markers')) {
+            $table = $schema->getTable('comments_read_markers');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the comments_read_markers table, this can take some time...</info>');
+                $table->setPrimaryKey(['user_id', 'object_type', 'object_id'], 'crm_pk');
+                if ($table->hasIndex('comments_marker_index')) {
+                    $table->dropIndex('comments_marker_index');
+                }
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>comments_read_markers table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('collres_resources')) {
+            $table = $schema->getTable('collres_resources');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the collres_resources table, this can take some time...</info>');
+                $table->setPrimaryKey(['collection_id', 'resource_type', 'resource_id'], 'crr_pk');
+                if ($table->hasIndex('collres_unique_res')) {
+                    $table->dropIndex('collres_unique_res');
+                }
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>collres_resources table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('collres_accesscache')) {
+            $table = $schema->getTable('collres_accesscache');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the collres_accesscache table, this can take some time...</info>');
+                $table->setPrimaryKey(['user_id', 'collection_id', 'resource_type', 'resource_id'], 'cra_pk');
+                if ($table->hasIndex('collres_unique_user')) {
+                    $table->dropIndex('collres_unique_user');
+                }
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>collres_accesscache table updated successfully.</info>');
+            }
+        }
+
+        if ($schema->hasTable('filecache_extended')) {
+            $table = $schema->getTable('filecache_extended');
+            if (!$table->hasPrimaryKey()) {
+                $output->writeln('<info>Adding primary key to the filecache_extended table, this can take some time...</info>');
+                $table->setPrimaryKey(['fileid'], 'fce_pk');
+                if ($table->hasIndex('fce_fileid_idx')) {
+                    $table->dropIndex('fce_fileid_idx');
+                }
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>filecache_extended table updated successfully.</info>');
+            }
+        }
+
+        if (!$updated) {
+            $output->writeln('<info>Done.</info>');
+        }
+    }
 }

core/Command/Db/AddMissingIndices.php

Indentation +381 added lines, -381 removed lines

@@ -54,385 +54,385 @@
  */
 class AddMissingIndices extends Command {
 
-	/** @var Connection */
-	private $connection;
-
-	/** @var EventDispatcherInterface */
-	private $dispatcher;
-
-	public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
-		parent::__construct();
-
-		$this->connection = $connection;
-		$this->dispatcher = $dispatcher;
-	}
-
-	protected function configure() {
-		$this
-			->setName('db:add-missing-indices')
-			->setDescription('Add missing indices to the database tables')
-			->addOption('dry-run', null, InputOption::VALUE_NONE, "Output the SQL queries instead of running them.");
-	}
-
-	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$this->addCoreIndexes($output, $input->getOption('dry-run'));
-
-		// Dispatch event so apps can also update indexes if needed
-		$event = new GenericEvent($output);
-		$this->dispatcher->dispatch(IDBConnection::ADD_MISSING_INDEXES_EVENT, $event);
-		return 0;
-	}
-
-	/**
-	 * add missing indices to the share table
-	 *
-	 * @param OutputInterface $output
-	 * @param bool $dryRun If true, will return the sql queries instead of running them.
-	 * @throws \Doctrine\DBAL\Schema\SchemaException
-	 */
-	private function addCoreIndexes(OutputInterface $output, bool $dryRun): void {
-		$output->writeln('<info>Check indices of the share table.</info>');
-
-		$schema = new SchemaWrapper($this->connection);
-		$updated = false;
-
-		if ($schema->hasTable('share')) {
-			$table = $schema->getTable('share');
-			if (!$table->hasIndex('share_with_index')) {
-				$output->writeln('<info>Adding additional share_with index to the share table, this can take some time...</info>');
-				$table->addIndex(['share_with'], 'share_with_index');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Share table updated successfully.</info>');
-			}
-
-			if (!$table->hasIndex('parent_index')) {
-				$output->writeln('<info>Adding additional parent index to the share table, this can take some time...</info>');
-				$table->addIndex(['parent'], 'parent_index');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Share table updated successfully.</info>');
-			}
-
-			if (!$table->hasIndex('owner_index')) {
-				$output->writeln('<info>Adding additional owner index to the share table, this can take some time...</info>');
-				$table->addIndex(['uid_owner'], 'owner_index');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Share table updated successfully.</info>');
-			}
-
-			if (!$table->hasIndex('initiator_index')) {
-				$output->writeln('<info>Adding additional initiator index to the share table, this can take some time...</info>');
-				$table->addIndex(['uid_initiator'], 'initiator_index');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Share table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the filecache table.</info>');
-		if ($schema->hasTable('filecache')) {
-			$table = $schema->getTable('filecache');
-			if (!$table->hasIndex('fs_mtime')) {
-				$output->writeln('<info>Adding additional mtime index to the filecache table, this can take some time...</info>');
-				$table->addIndex(['mtime'], 'fs_mtime');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Filecache table updated successfully.</info>');
-			}
-			if (!$table->hasIndex('fs_size')) {
-				$output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>');
-				$table->addIndex(['size'], 'fs_size');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Filecache table updated successfully.</info>');
-			}
-			if (!$table->hasIndex('fs_id_storage_size')) {
-				$output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>');
-				$table->addIndex(['fileid', 'storage', 'size'], 'fs_id_storage_size');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Filecache table updated successfully.</info>');
-			}
-			if (!$table->hasIndex('fs_storage_path_prefix') && !$schema->getDatabasePlatform() instanceof PostgreSQL94Platform) {
-				$output->writeln('<info>Adding additional path index to the filecache table, this can take some time...</info>');
-				$table->addIndex(['storage', 'path'], 'fs_storage_path_prefix', [], ['lengths' => [null, 64]]);
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Filecache table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the twofactor_providers table.</info>');
-		if ($schema->hasTable('twofactor_providers')) {
-			$table = $schema->getTable('twofactor_providers');
-			if (!$table->hasIndex('twofactor_providers_uid')) {
-				$output->writeln('<info>Adding additional twofactor_providers_uid index to the twofactor_providers table, this can take some time...</info>');
-				$table->addIndex(['uid'], 'twofactor_providers_uid');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>Twofactor_providers table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the login_flow_v2 table.</info>');
-		if ($schema->hasTable('login_flow_v2')) {
-			$table = $schema->getTable('login_flow_v2');
-			if (!$table->hasIndex('poll_token')) {
-				$output->writeln('<info>Adding additional indeces to the login_flow_v2 table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					$columns = $index->getColumns();
-					if ($columns === ['poll_token'] ||
-						$columns === ['login_token'] ||
-						$columns === ['timestamp']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addUniqueIndex(['poll_token'], 'poll_token');
-				$table->addUniqueIndex(['login_token'], 'login_token');
-				$table->addIndex(['timestamp'], 'timestamp');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>login_flow_v2 table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the whats_new table.</info>');
-		if ($schema->hasTable('whats_new')) {
-			$table = $schema->getTable('whats_new');
-			if (!$table->hasIndex('version')) {
-				$output->writeln('<info>Adding version index to the whats_new table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['version']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addUniqueIndex(['version'], 'version');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>whats_new table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the cards table.</info>');
-		$cardsUpdated = false;
-		if ($schema->hasTable('cards')) {
-			$table = $schema->getTable('cards');
-
-			if ($table->hasIndex('addressbookid_uri_index')) {
-				$output->writeln('<info>Renaming addressbookid_uri_index index to  to the cards table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['addressbookid', 'uri']) {
-						$table->renameIndex('addressbookid_uri_index', 'cards_abiduri');
-					}
-				}
-
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$cardsUpdated = true;
-			}
-
-			if (!$table->hasIndex('cards_abid')) {
-				$output->writeln('<info>Adding cards_abid index to the cards table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['addressbookid']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addIndex(['addressbookid'], 'cards_abid');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$cardsUpdated = true;
-			}
-
-			if (!$table->hasIndex('cards_abiduri')) {
-				$output->writeln('<info>Adding cards_abiduri index to the cards table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['addressbookid', 'uri']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addIndex(['addressbookid', 'uri'], 'cards_abiduri');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$cardsUpdated = true;
-			}
-
-			if ($cardsUpdated) {
-				$updated = true;
-				$output->writeln('<info>cards table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the cards_properties table.</info>');
-		if ($schema->hasTable('cards_properties')) {
-			$table = $schema->getTable('cards_properties');
-			if (!$table->hasIndex('cards_prop_abid')) {
-				$output->writeln('<info>Adding cards_prop_abid index to the cards_properties table, this can take some time...</info>');
-
-				foreach ($table->getIndexes() as $index) {
-					if ($index->getColumns() === ['addressbookid']) {
-						$table->dropIndex($index->getName());
-					}
-				}
-
-				$table->addIndex(['addressbookid'], 'cards_prop_abid');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>cards_properties table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the calendarobjects_props table.</info>');
-		if ($schema->hasTable('calendarobjects_props')) {
-			$table = $schema->getTable('calendarobjects_props');
-			if (!$table->hasIndex('calendarobject_calid_index')) {
-				$output->writeln('<info>Adding calendarobject_calid_index index to the calendarobjects_props table, this can take some time...</info>');
-
-				$table->addIndex(['calendarid', 'calendartype'], 'calendarobject_calid_index');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>calendarobjects_props table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the schedulingobjects table.</info>');
-		if ($schema->hasTable('schedulingobjects')) {
-			$table = $schema->getTable('schedulingobjects');
-			if (!$table->hasIndex('schedulobj_principuri_index')) {
-				$output->writeln('<info>Adding schedulobj_principuri_index index to the schedulingobjects table, this can take some time...</info>');
-
-				$table->addIndex(['principaluri'], 'schedulobj_principuri_index');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>schedulingobjects table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the oc_properties table.</info>');
-		if ($schema->hasTable('properties')) {
-			$table = $schema->getTable('properties');
-			$propertiesUpdated = false;
-
-			if (!$table->hasIndex('properties_path_index')) {
-				$output->writeln('<info>Adding properties_path_index index to the oc_properties table, this can take some time...</info>');
-
-				$table->addIndex(['userid', 'propertypath'], 'properties_path_index');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$propertiesUpdated = true;
-			}
-			if (!$table->hasIndex('properties_pathonly_index')) {
-				$output->writeln('<info>Adding properties_pathonly_index index to the oc_properties table, this can take some time...</info>');
-
-				$table->addIndex(['propertypath'], 'properties_pathonly_index');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$propertiesUpdated = true;
-			}
-
-			if ($propertiesUpdated) {
-				$updated = true;
-				$output->writeln('<info>oc_properties table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the oc_jobs table.</info>');
-		if ($schema->hasTable('jobs')) {
-			$table = $schema->getTable('jobs');
-			if (!$table->hasIndex('job_lastcheck_reserved')) {
-				$output->writeln('<info>Adding job_lastcheck_reserved index to the oc_jobs table, this can take some time...</info>');
-
-				$table->addIndex(['last_checked', 'reserved_at'], 'job_lastcheck_reserved');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>oc_properties table updated successfully.</info>');
-			}
-		}
-
-		$output->writeln('<info>Check indices of the oc_direct_edit table.</info>');
-		if ($schema->hasTable('direct_edit')) {
-			$table = $schema->getTable('direct_edit');
-			if (!$table->hasIndex('direct_edit_timestamp')) {
-				$output->writeln('<info>Adding direct_edit_timestamp index to the oc_direct_edit table, this can take some time...</info>');
-
-				$table->addIndex(['timestamp'], 'direct_edit_timestamp');
-				$sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
-				if ($dryRun && $sqlQueries !== null) {
-					$output->writeln($sqlQueries);
-				}
-				$updated = true;
-				$output->writeln('<info>oc_direct_edit table updated successfully.</info>');
-			}
-		}
-
-		if (!$updated) {
-			$output->writeln('<info>Done.</info>');
-		}
-	}
+    /** @var Connection */
+    private $connection;
+
+    /** @var EventDispatcherInterface */
+    private $dispatcher;
+
+    public function __construct(Connection $connection, EventDispatcherInterface $dispatcher) {
+        parent::__construct();
+
+        $this->connection = $connection;
+        $this->dispatcher = $dispatcher;
+    }
+
+    protected function configure() {
+        $this
+            ->setName('db:add-missing-indices')
+            ->setDescription('Add missing indices to the database tables')
+            ->addOption('dry-run', null, InputOption::VALUE_NONE, "Output the SQL queries instead of running them.");
+    }
+
+    protected function execute(InputInterface $input, OutputInterface $output): int {
+        $this->addCoreIndexes($output, $input->getOption('dry-run'));
+
+        // Dispatch event so apps can also update indexes if needed
+        $event = new GenericEvent($output);
+        $this->dispatcher->dispatch(IDBConnection::ADD_MISSING_INDEXES_EVENT, $event);
+        return 0;
+    }
+
+    /**
+     * add missing indices to the share table
+     *
+     * @param OutputInterface $output
+     * @param bool $dryRun If true, will return the sql queries instead of running them.
+     * @throws \Doctrine\DBAL\Schema\SchemaException
+     */
+    private function addCoreIndexes(OutputInterface $output, bool $dryRun): void {
+        $output->writeln('<info>Check indices of the share table.</info>');
+
+        $schema = new SchemaWrapper($this->connection);
+        $updated = false;
+
+        if ($schema->hasTable('share')) {
+            $table = $schema->getTable('share');
+            if (!$table->hasIndex('share_with_index')) {
+                $output->writeln('<info>Adding additional share_with index to the share table, this can take some time...</info>');
+                $table->addIndex(['share_with'], 'share_with_index');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Share table updated successfully.</info>');
+            }
+
+            if (!$table->hasIndex('parent_index')) {
+                $output->writeln('<info>Adding additional parent index to the share table, this can take some time...</info>');
+                $table->addIndex(['parent'], 'parent_index');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Share table updated successfully.</info>');
+            }
+
+            if (!$table->hasIndex('owner_index')) {
+                $output->writeln('<info>Adding additional owner index to the share table, this can take some time...</info>');
+                $table->addIndex(['uid_owner'], 'owner_index');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Share table updated successfully.</info>');
+            }
+
+            if (!$table->hasIndex('initiator_index')) {
+                $output->writeln('<info>Adding additional initiator index to the share table, this can take some time...</info>');
+                $table->addIndex(['uid_initiator'], 'initiator_index');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Share table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the filecache table.</info>');
+        if ($schema->hasTable('filecache')) {
+            $table = $schema->getTable('filecache');
+            if (!$table->hasIndex('fs_mtime')) {
+                $output->writeln('<info>Adding additional mtime index to the filecache table, this can take some time...</info>');
+                $table->addIndex(['mtime'], 'fs_mtime');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Filecache table updated successfully.</info>');
+            }
+            if (!$table->hasIndex('fs_size')) {
+                $output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>');
+                $table->addIndex(['size'], 'fs_size');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Filecache table updated successfully.</info>');
+            }
+            if (!$table->hasIndex('fs_id_storage_size')) {
+                $output->writeln('<info>Adding additional size index to the filecache table, this can take some time...</info>');
+                $table->addIndex(['fileid', 'storage', 'size'], 'fs_id_storage_size');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Filecache table updated successfully.</info>');
+            }
+            if (!$table->hasIndex('fs_storage_path_prefix') && !$schema->getDatabasePlatform() instanceof PostgreSQL94Platform) {
+                $output->writeln('<info>Adding additional path index to the filecache table, this can take some time...</info>');
+                $table->addIndex(['storage', 'path'], 'fs_storage_path_prefix', [], ['lengths' => [null, 64]]);
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Filecache table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the twofactor_providers table.</info>');
+        if ($schema->hasTable('twofactor_providers')) {
+            $table = $schema->getTable('twofactor_providers');
+            if (!$table->hasIndex('twofactor_providers_uid')) {
+                $output->writeln('<info>Adding additional twofactor_providers_uid index to the twofactor_providers table, this can take some time...</info>');
+                $table->addIndex(['uid'], 'twofactor_providers_uid');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>Twofactor_providers table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the login_flow_v2 table.</info>');
+        if ($schema->hasTable('login_flow_v2')) {
+            $table = $schema->getTable('login_flow_v2');
+            if (!$table->hasIndex('poll_token')) {
+                $output->writeln('<info>Adding additional indeces to the login_flow_v2 table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    $columns = $index->getColumns();
+                    if ($columns === ['poll_token'] ||
+                        $columns === ['login_token'] ||
+                        $columns === ['timestamp']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addUniqueIndex(['poll_token'], 'poll_token');
+                $table->addUniqueIndex(['login_token'], 'login_token');
+                $table->addIndex(['timestamp'], 'timestamp');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>login_flow_v2 table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the whats_new table.</info>');
+        if ($schema->hasTable('whats_new')) {
+            $table = $schema->getTable('whats_new');
+            if (!$table->hasIndex('version')) {
+                $output->writeln('<info>Adding version index to the whats_new table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['version']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addUniqueIndex(['version'], 'version');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>whats_new table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the cards table.</info>');
+        $cardsUpdated = false;
+        if ($schema->hasTable('cards')) {
+            $table = $schema->getTable('cards');
+
+            if ($table->hasIndex('addressbookid_uri_index')) {
+                $output->writeln('<info>Renaming addressbookid_uri_index index to  to the cards table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['addressbookid', 'uri']) {
+                        $table->renameIndex('addressbookid_uri_index', 'cards_abiduri');
+                    }
+                }
+
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $cardsUpdated = true;
+            }
+
+            if (!$table->hasIndex('cards_abid')) {
+                $output->writeln('<info>Adding cards_abid index to the cards table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['addressbookid']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addIndex(['addressbookid'], 'cards_abid');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $cardsUpdated = true;
+            }
+
+            if (!$table->hasIndex('cards_abiduri')) {
+                $output->writeln('<info>Adding cards_abiduri index to the cards table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['addressbookid', 'uri']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addIndex(['addressbookid', 'uri'], 'cards_abiduri');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $cardsUpdated = true;
+            }
+
+            if ($cardsUpdated) {
+                $updated = true;
+                $output->writeln('<info>cards table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the cards_properties table.</info>');
+        if ($schema->hasTable('cards_properties')) {
+            $table = $schema->getTable('cards_properties');
+            if (!$table->hasIndex('cards_prop_abid')) {
+                $output->writeln('<info>Adding cards_prop_abid index to the cards_properties table, this can take some time...</info>');
+
+                foreach ($table->getIndexes() as $index) {
+                    if ($index->getColumns() === ['addressbookid']) {
+                        $table->dropIndex($index->getName());
+                    }
+                }
+
+                $table->addIndex(['addressbookid'], 'cards_prop_abid');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>cards_properties table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the calendarobjects_props table.</info>');
+        if ($schema->hasTable('calendarobjects_props')) {
+            $table = $schema->getTable('calendarobjects_props');
+            if (!$table->hasIndex('calendarobject_calid_index')) {
+                $output->writeln('<info>Adding calendarobject_calid_index index to the calendarobjects_props table, this can take some time...</info>');
+
+                $table->addIndex(['calendarid', 'calendartype'], 'calendarobject_calid_index');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>calendarobjects_props table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the schedulingobjects table.</info>');
+        if ($schema->hasTable('schedulingobjects')) {
+            $table = $schema->getTable('schedulingobjects');
+            if (!$table->hasIndex('schedulobj_principuri_index')) {
+                $output->writeln('<info>Adding schedulobj_principuri_index index to the schedulingobjects table, this can take some time...</info>');
+
+                $table->addIndex(['principaluri'], 'schedulobj_principuri_index');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>schedulingobjects table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the oc_properties table.</info>');
+        if ($schema->hasTable('properties')) {
+            $table = $schema->getTable('properties');
+            $propertiesUpdated = false;
+
+            if (!$table->hasIndex('properties_path_index')) {
+                $output->writeln('<info>Adding properties_path_index index to the oc_properties table, this can take some time...</info>');
+
+                $table->addIndex(['userid', 'propertypath'], 'properties_path_index');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $propertiesUpdated = true;
+            }
+            if (!$table->hasIndex('properties_pathonly_index')) {
+                $output->writeln('<info>Adding properties_pathonly_index index to the oc_properties table, this can take some time...</info>');
+
+                $table->addIndex(['propertypath'], 'properties_pathonly_index');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $propertiesUpdated = true;
+            }
+
+            if ($propertiesUpdated) {
+                $updated = true;
+                $output->writeln('<info>oc_properties table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the oc_jobs table.</info>');
+        if ($schema->hasTable('jobs')) {
+            $table = $schema->getTable('jobs');
+            if (!$table->hasIndex('job_lastcheck_reserved')) {
+                $output->writeln('<info>Adding job_lastcheck_reserved index to the oc_jobs table, this can take some time...</info>');
+
+                $table->addIndex(['last_checked', 'reserved_at'], 'job_lastcheck_reserved');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>oc_properties table updated successfully.</info>');
+            }
+        }
+
+        $output->writeln('<info>Check indices of the oc_direct_edit table.</info>');
+        if ($schema->hasTable('direct_edit')) {
+            $table = $schema->getTable('direct_edit');
+            if (!$table->hasIndex('direct_edit_timestamp')) {
+                $output->writeln('<info>Adding direct_edit_timestamp index to the oc_direct_edit table, this can take some time...</info>');
+
+                $table->addIndex(['timestamp'], 'direct_edit_timestamp');
+                $sqlQueries = $this->connection->migrateToSchema($schema->getWrappedSchema(), $dryRun);
+                if ($dryRun && $sqlQueries !== null) {
+                    $output->writeln($sqlQueries);
+                }
+                $updated = true;
+                $output->writeln('<info>oc_direct_edit table updated successfully.</info>');
+            }
+        }
+
+        if (!$updated) {
+            $output->writeln('<info>Done.</info>');
+        }
+    }
 }