nextcloud / server

lib/private/SystemTag/SystemTagObjectMapper.php

Indentation +344 added lines, -344 removed lines

@@ -20,348 +20,348 @@
 use OCP\SystemTag\TagNotFoundException;
 
 class SystemTagObjectMapper implements ISystemTagObjectMapper {
-	public const RELATION_TABLE = 'systemtag_object_mapping';
-
-	public function __construct(
-		protected IDBConnection $connection,
-		protected ISystemTagManager $tagManager,
-		protected IEventDispatcher $dispatcher,
-	) {
-	}
-
-	/**
-	 * {@inheritdoc}
-	 */
-	public function getTagIdsForObjects($objIds, string $objectType): array {
-		if (!\is_array($objIds)) {
-			$objIds = [$objIds];
-		} elseif (empty($objIds)) {
-			return [];
-		}
-
-		$query = $this->connection->getQueryBuilder();
-		$query->select(['systemtagid', 'objectid'])
-			->from(self::RELATION_TABLE)
-			->where($query->expr()->in('objectid', $query->createParameter('objectids')))
-			->andWhere($query->expr()->eq('objecttype', $query->createParameter('objecttype')))
-			->setParameter('objecttype', $objectType)
-			->addOrderBy('objectid', 'ASC')
-			->addOrderBy('systemtagid', 'ASC');
-		$chunks = array_chunk($objIds, 900, false);
-		$mapping = [];
-		foreach ($objIds as $objId) {
-			$mapping[$objId] = [];
-		}
-		foreach ($chunks as $chunk) {
-			$query->setParameter('objectids', $chunk, IQueryBuilder::PARAM_STR_ARRAY);
-			$result = $query->executeQuery();
-			while ($row = $result->fetch()) {
-				$objectId = $row['objectid'];
-				$mapping[$objectId][] = $row['systemtagid'];
-			}
-
-			$result->closeCursor();
-		}
-
-		return $mapping;
-	}
-
-	/**
-	 * {@inheritdoc}
-	 */
-	public function getObjectIdsForTags($tagIds, string $objectType, int $limit = 0, string $offset = ''): array {
-		if (!\is_array($tagIds)) {
-			$tagIds = [$tagIds];
-		}
-
-		$this->assertTagsExist($tagIds);
-
-		$query = $this->connection->getQueryBuilder();
-		$query->selectDistinct('objectid')
-			->from(self::RELATION_TABLE)
-			->where($query->expr()->in('systemtagid', $query->createNamedParameter($tagIds, IQueryBuilder::PARAM_INT_ARRAY)))
-			->andWhere($query->expr()->eq('objecttype', $query->createNamedParameter($objectType)));
-
-		if ($limit) {
-			if (\count($tagIds) !== 1) {
-				throw new \InvalidArgumentException('Limit is only allowed with a single tag');
-			}
-
-			$query->setMaxResults($limit)
-				->orderBy('objectid', 'ASC');
-
-			if ($offset !== '') {
-				$query->andWhere($query->expr()->gt('objectid', $query->createNamedParameter($offset)));
-			}
-		}
-
-		$objectIds = [];
-
-		$result = $query->executeQuery();
-		while ($row = $result->fetch()) {
-			$objectIds[] = $row['objectid'];
-		}
-		$result->closeCursor();
-
-		return $objectIds;
-	}
-
-	/**
-	 * {@inheritdoc}
-	 */
-	public function assignTags(string $objId, string $objectType, $tagIds): void {
-		if (!\is_array($tagIds)) {
-			$tagIds = [$tagIds];
-		}
-
-		$this->assertTagsExist($tagIds);
-		$this->connection->beginTransaction();
-
-		$query = $this->connection->getQueryBuilder();
-		$query->select('systemtagid')
-			->from(self::RELATION_TABLE)
-			->where($query->expr()->in('systemtagid', $query->createNamedParameter($tagIds, IQueryBuilder::PARAM_INT_ARRAY)))
-			->andWhere($query->expr()->eq('objecttype', $query->createNamedParameter($objectType)))
-			->andWhere($query->expr()->eq('objectid', $query->createNamedParameter($objId)));
-		$result = $query->executeQuery();
-		$rows = $result->fetchAll();
-		$existingTags = [];
-		foreach ($rows as $row) {
-			$existingTags[] = $row['systemtagid'];
-		}
-		//filter only tags that do not exist in db
-		$tagIds = array_diff($tagIds, $existingTags);
-		if (empty($tagIds)) {
-			// no tags to insert so return here
-			$this->connection->commit();
-			return;
-		}
-
-		$query = $this->connection->getQueryBuilder();
-		$query->insert(self::RELATION_TABLE)
-			->values([
-				'objectid' => $query->createNamedParameter($objId),
-				'objecttype' => $query->createNamedParameter($objectType),
-				'systemtagid' => $query->createParameter('tagid'),
-			]);
-
-		$tagsAssigned = [];
-		foreach ($tagIds as $tagId) {
-			try {
-				$query->setParameter('tagid', $tagId);
-				$query->execute();
-				$tagsAssigned[] = $tagId;
-			} catch (UniqueConstraintViolationException $e) {
-				// ignore existing relations
-			}
-		}
-
-		$this->updateEtagForTags($tagIds);
-
-		$this->connection->commit();
-		if (empty($tagsAssigned)) {
-			return;
-		}
-
-		$this->dispatcher->dispatch(MapperEvent::EVENT_ASSIGN, new MapperEvent(
-			MapperEvent::EVENT_ASSIGN,
-			$objectType,
-			$objId,
-			$tagsAssigned
-		));
-	}
-
-	/**
-	 * {@inheritdoc}
-	 */
-	public function unassignTags(string $objId, string $objectType, $tagIds): void {
-		if (!\is_array($tagIds)) {
-			$tagIds = [$tagIds];
-		}
-
-		$this->assertTagsExist($tagIds);
-
-		$query = $this->connection->getQueryBuilder();
-		$query->delete(self::RELATION_TABLE)
-			->where($query->expr()->eq('objectid', $query->createParameter('objectid')))
-			->andWhere($query->expr()->eq('objecttype', $query->createParameter('objecttype')))
-			->andWhere($query->expr()->in('systemtagid', $query->createParameter('tagids')))
-			->setParameter('objectid', $objId)
-			->setParameter('objecttype', $objectType)
-			->setParameter('tagids', $tagIds, IQueryBuilder::PARAM_INT_ARRAY)
-			->executeStatement();
-
-		$this->updateEtagForTags($tagIds);
-
-		$this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
-			MapperEvent::EVENT_UNASSIGN,
-			$objectType,
-			$objId,
-			$tagIds
-		));
-	}
-
-	/**
-	 * Update the etag for the given tags.
-	 *
-	 * @param string[] $tagIds
-	 */
-	private function updateEtagForTags(array $tagIds): void {
-		// Update etag after assigning tags
-		$md5 = md5(json_encode(time()));
-		$query = $this->connection->getQueryBuilder();
-		$query->update('systemtag')
-			->set('etag', $query->createNamedParameter($md5))
-			->where($query->expr()->in('id', $query->createNamedParameter($tagIds, IQueryBuilder::PARAM_INT_ARRAY)));
-		$query->execute();
-	}
-
-	/**
-	 * {@inheritdoc}
-	 */
-	public function haveTag($objIds, string $objectType, string $tagId, bool $all = true): bool {
-		$this->assertTagsExist([$tagId]);
-
-		if (!\is_array($objIds)) {
-			$objIds = [$objIds];
-		}
-
-		$query = $this->connection->getQueryBuilder();
-
-		if (!$all) {
-			// If we only need one entry, we make the query lighter, by not
-			// counting the elements
-			$query->select('*')
-				->setMaxResults(1);
-		} else {
-			$query->select($query->func()->count($query->expr()->literal(1)));
-		}
-
-		$query->from(self::RELATION_TABLE)
-			->where($query->expr()->in('objectid', $query->createParameter('objectids')))
-			->andWhere($query->expr()->eq('objecttype', $query->createParameter('objecttype')))
-			->andWhere($query->expr()->eq('systemtagid', $query->createParameter('tagid')))
-			->setParameter('objectids', $objIds, IQueryBuilder::PARAM_STR_ARRAY)
-			->setParameter('tagid', $tagId)
-			->setParameter('objecttype', $objectType);
-
-		$result = $query->executeQuery();
-		$row = $result->fetch(\PDO::FETCH_NUM);
-		$result->closeCursor();
-
-		if ($all) {
-			return ((int)$row[0] === \count($objIds));
-		}
-
-		return (bool)$row;
-	}
-
-	/**
-	 * Asserts that all the given tag ids exist.
-	 *
-	 * @param string[] $tagIds tag ids to check
-	 *
-	 * @throws \OCP\SystemTag\TagNotFoundException if at least one tag did not exist
-	 */
-	private function assertTagsExist(array $tagIds): void {
-		$tags = $this->tagManager->getTagsByIds($tagIds);
-		if (\count($tags) !== \count($tagIds)) {
-			// at least one tag missing, bail out
-			$foundTagIds = array_map(
-				function (ISystemTag $tag) {
-					return $tag->getId();
-				},
-				$tags
-			);
-			$missingTagIds = array_diff($tagIds, $foundTagIds);
-			throw new TagNotFoundException(
-				'Tags not found', 0, null, $missingTagIds
-			);
-		}
-	}
-
-	/**
-	 * {@inheritdoc}
-	 */
-	public function setObjectIdsForTag(string $tagId, string $objectType, array $objectIds): void {
-		$currentObjectIds = $this->getObjectIdsForTags($tagId, $objectType);
-		$removedObjectIds = array_diff($currentObjectIds, $objectIds);
-		$addedObjectIds = array_diff($objectIds, $currentObjectIds);
-
-		$this->connection->beginTransaction();
-		$query = $this->connection->getQueryBuilder();
-		$query->delete(self::RELATION_TABLE)
-			->where($query->expr()->eq('systemtagid', $query->createNamedParameter($tagId, IQueryBuilder::PARAM_INT)))
-			->andWhere($query->expr()->eq('objecttype', $query->createNamedParameter($objectType)))
-			->executeStatement();
-		$this->connection->commit();
-
-		foreach ($removedObjectIds as $objectId) {
-			$this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
-				MapperEvent::EVENT_UNASSIGN,
-				$objectType,
-				(string)$objectId,
-				[(int)$tagId]
-			));
-		}
-
-		if (empty($objectIds)) {
-			return;
-		}
-
-		$this->connection->beginTransaction();
-		$query = $this->connection->getQueryBuilder();
-		$query->insert(self::RELATION_TABLE)
-			->values([
-				'systemtagid' => $query->createNamedParameter($tagId, IQueryBuilder::PARAM_INT),
-				'objecttype' => $query->createNamedParameter($objectType),
-				'objectid' => $query->createParameter('objectid'),
-			]);
-
-		foreach (array_unique($objectIds) as $objectId) {
-			$query->setParameter('objectid', (string)$objectId);
-			$query->executeStatement();
-		}
-
-		$this->updateEtagForTags([$tagId]);
-		$this->connection->commit();
-
-		// Dispatch assign events for new object ids
-		foreach ($addedObjectIds as $objectId) {
-			$this->dispatcher->dispatch(MapperEvent::EVENT_ASSIGN, new MapperEvent(
-				MapperEvent::EVENT_ASSIGN,
-				$objectType,
-				(string)$objectId,
-				[(int)$tagId]
-			));
-		}
-
-		// Dispatch unassign events for removed object ids
-		foreach ($removedObjectIds as $objectId) {
-			$this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
-				MapperEvent::EVENT_UNASSIGN,
-				$objectType,
-				(string)$objectId,
-				[(int)$tagId]
-			));
-		}
-	}
-
-	/**
-	 * {@inheritdoc}
-	 */
-	public function getAvailableObjectTypes(): array {
-		$query = $this->connection->getQueryBuilder();
-		$query->selectDistinct('objecttype')
-			->from(self::RELATION_TABLE);
-
-		$result = $query->executeQuery();
-		$objectTypes = [];
-		while ($row = $result->fetch()) {
-			$objectTypes[] = $row['objecttype'];
-		}
-		$result->closeCursor();
-
-		return $objectTypes;
-	}
+    public const RELATION_TABLE = 'systemtag_object_mapping';
+
+    public function __construct(
+        protected IDBConnection $connection,
+        protected ISystemTagManager $tagManager,
+        protected IEventDispatcher $dispatcher,
+    ) {
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getTagIdsForObjects($objIds, string $objectType): array {
+        if (!\is_array($objIds)) {
+            $objIds = [$objIds];
+        } elseif (empty($objIds)) {
+            return [];
+        }
+
+        $query = $this->connection->getQueryBuilder();
+        $query->select(['systemtagid', 'objectid'])
+            ->from(self::RELATION_TABLE)
+            ->where($query->expr()->in('objectid', $query->createParameter('objectids')))
+            ->andWhere($query->expr()->eq('objecttype', $query->createParameter('objecttype')))
+            ->setParameter('objecttype', $objectType)
+            ->addOrderBy('objectid', 'ASC')
+            ->addOrderBy('systemtagid', 'ASC');
+        $chunks = array_chunk($objIds, 900, false);
+        $mapping = [];
+        foreach ($objIds as $objId) {
+            $mapping[$objId] = [];
+        }
+        foreach ($chunks as $chunk) {
+            $query->setParameter('objectids', $chunk, IQueryBuilder::PARAM_STR_ARRAY);
+            $result = $query->executeQuery();
+            while ($row = $result->fetch()) {
+                $objectId = $row['objectid'];
+                $mapping[$objectId][] = $row['systemtagid'];
+            }
+
+            $result->closeCursor();
+        }
+
+        return $mapping;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getObjectIdsForTags($tagIds, string $objectType, int $limit = 0, string $offset = ''): array {
+        if (!\is_array($tagIds)) {
+            $tagIds = [$tagIds];
+        }
+
+        $this->assertTagsExist($tagIds);
+
+        $query = $this->connection->getQueryBuilder();
+        $query->selectDistinct('objectid')
+            ->from(self::RELATION_TABLE)
+            ->where($query->expr()->in('systemtagid', $query->createNamedParameter($tagIds, IQueryBuilder::PARAM_INT_ARRAY)))
+            ->andWhere($query->expr()->eq('objecttype', $query->createNamedParameter($objectType)));
+
+        if ($limit) {
+            if (\count($tagIds) !== 1) {
+                throw new \InvalidArgumentException('Limit is only allowed with a single tag');
+            }
+
+            $query->setMaxResults($limit)
+                ->orderBy('objectid', 'ASC');
+
+            if ($offset !== '') {
+                $query->andWhere($query->expr()->gt('objectid', $query->createNamedParameter($offset)));
+            }
+        }
+
+        $objectIds = [];
+
+        $result = $query->executeQuery();
+        while ($row = $result->fetch()) {
+            $objectIds[] = $row['objectid'];
+        }
+        $result->closeCursor();
+
+        return $objectIds;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function assignTags(string $objId, string $objectType, $tagIds): void {
+        if (!\is_array($tagIds)) {
+            $tagIds = [$tagIds];
+        }
+
+        $this->assertTagsExist($tagIds);
+        $this->connection->beginTransaction();
+
+        $query = $this->connection->getQueryBuilder();
+        $query->select('systemtagid')
+            ->from(self::RELATION_TABLE)
+            ->where($query->expr()->in('systemtagid', $query->createNamedParameter($tagIds, IQueryBuilder::PARAM_INT_ARRAY)))
+            ->andWhere($query->expr()->eq('objecttype', $query->createNamedParameter($objectType)))
+            ->andWhere($query->expr()->eq('objectid', $query->createNamedParameter($objId)));
+        $result = $query->executeQuery();
+        $rows = $result->fetchAll();
+        $existingTags = [];
+        foreach ($rows as $row) {
+            $existingTags[] = $row['systemtagid'];
+        }
+        //filter only tags that do not exist in db
+        $tagIds = array_diff($tagIds, $existingTags);
+        if (empty($tagIds)) {
+            // no tags to insert so return here
+            $this->connection->commit();
+            return;
+        }
+
+        $query = $this->connection->getQueryBuilder();
+        $query->insert(self::RELATION_TABLE)
+            ->values([
+                'objectid' => $query->createNamedParameter($objId),
+                'objecttype' => $query->createNamedParameter($objectType),
+                'systemtagid' => $query->createParameter('tagid'),
+            ]);
+
+        $tagsAssigned = [];
+        foreach ($tagIds as $tagId) {
+            try {
+                $query->setParameter('tagid', $tagId);
+                $query->execute();
+                $tagsAssigned[] = $tagId;
+            } catch (UniqueConstraintViolationException $e) {
+                // ignore existing relations
+            }
+        }
+
+        $this->updateEtagForTags($tagIds);
+
+        $this->connection->commit();
+        if (empty($tagsAssigned)) {
+            return;
+        }
+
+        $this->dispatcher->dispatch(MapperEvent::EVENT_ASSIGN, new MapperEvent(
+            MapperEvent::EVENT_ASSIGN,
+            $objectType,
+            $objId,
+            $tagsAssigned
+        ));
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function unassignTags(string $objId, string $objectType, $tagIds): void {
+        if (!\is_array($tagIds)) {
+            $tagIds = [$tagIds];
+        }
+
+        $this->assertTagsExist($tagIds);
+
+        $query = $this->connection->getQueryBuilder();
+        $query->delete(self::RELATION_TABLE)
+            ->where($query->expr()->eq('objectid', $query->createParameter('objectid')))
+            ->andWhere($query->expr()->eq('objecttype', $query->createParameter('objecttype')))
+            ->andWhere($query->expr()->in('systemtagid', $query->createParameter('tagids')))
+            ->setParameter('objectid', $objId)
+            ->setParameter('objecttype', $objectType)
+            ->setParameter('tagids', $tagIds, IQueryBuilder::PARAM_INT_ARRAY)
+            ->executeStatement();
+
+        $this->updateEtagForTags($tagIds);
+
+        $this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
+            MapperEvent::EVENT_UNASSIGN,
+            $objectType,
+            $objId,
+            $tagIds
+        ));
+    }
+
+    /**
+     * Update the etag for the given tags.
+     *
+     * @param string[] $tagIds
+     */
+    private function updateEtagForTags(array $tagIds): void {
+        // Update etag after assigning tags
+        $md5 = md5(json_encode(time()));
+        $query = $this->connection->getQueryBuilder();
+        $query->update('systemtag')
+            ->set('etag', $query->createNamedParameter($md5))
+            ->where($query->expr()->in('id', $query->createNamedParameter($tagIds, IQueryBuilder::PARAM_INT_ARRAY)));
+        $query->execute();
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function haveTag($objIds, string $objectType, string $tagId, bool $all = true): bool {
+        $this->assertTagsExist([$tagId]);
+
+        if (!\is_array($objIds)) {
+            $objIds = [$objIds];
+        }
+
+        $query = $this->connection->getQueryBuilder();
+
+        if (!$all) {
+            // If we only need one entry, we make the query lighter, by not
+            // counting the elements
+            $query->select('*')
+                ->setMaxResults(1);
+        } else {
+            $query->select($query->func()->count($query->expr()->literal(1)));
+        }
+
+        $query->from(self::RELATION_TABLE)
+            ->where($query->expr()->in('objectid', $query->createParameter('objectids')))
+            ->andWhere($query->expr()->eq('objecttype', $query->createParameter('objecttype')))
+            ->andWhere($query->expr()->eq('systemtagid', $query->createParameter('tagid')))
+            ->setParameter('objectids', $objIds, IQueryBuilder::PARAM_STR_ARRAY)
+            ->setParameter('tagid', $tagId)
+            ->setParameter('objecttype', $objectType);
+
+        $result = $query->executeQuery();
+        $row = $result->fetch(\PDO::FETCH_NUM);
+        $result->closeCursor();
+
+        if ($all) {
+            return ((int)$row[0] === \count($objIds));
+        }
+
+        return (bool)$row;
+    }
+
+    /**
+     * Asserts that all the given tag ids exist.
+     *
+     * @param string[] $tagIds tag ids to check
+     *
+     * @throws \OCP\SystemTag\TagNotFoundException if at least one tag did not exist
+     */
+    private function assertTagsExist(array $tagIds): void {
+        $tags = $this->tagManager->getTagsByIds($tagIds);
+        if (\count($tags) !== \count($tagIds)) {
+            // at least one tag missing, bail out
+            $foundTagIds = array_map(
+                function (ISystemTag $tag) {
+                    return $tag->getId();
+                },
+                $tags
+            );
+            $missingTagIds = array_diff($tagIds, $foundTagIds);
+            throw new TagNotFoundException(
+                'Tags not found', 0, null, $missingTagIds
+            );
+        }
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function setObjectIdsForTag(string $tagId, string $objectType, array $objectIds): void {
+        $currentObjectIds = $this->getObjectIdsForTags($tagId, $objectType);
+        $removedObjectIds = array_diff($currentObjectIds, $objectIds);
+        $addedObjectIds = array_diff($objectIds, $currentObjectIds);
+
+        $this->connection->beginTransaction();
+        $query = $this->connection->getQueryBuilder();
+        $query->delete(self::RELATION_TABLE)
+            ->where($query->expr()->eq('systemtagid', $query->createNamedParameter($tagId, IQueryBuilder::PARAM_INT)))
+            ->andWhere($query->expr()->eq('objecttype', $query->createNamedParameter($objectType)))
+            ->executeStatement();
+        $this->connection->commit();
+
+        foreach ($removedObjectIds as $objectId) {
+            $this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
+                MapperEvent::EVENT_UNASSIGN,
+                $objectType,
+                (string)$objectId,
+                [(int)$tagId]
+            ));
+        }
+
+        if (empty($objectIds)) {
+            return;
+        }
+
+        $this->connection->beginTransaction();
+        $query = $this->connection->getQueryBuilder();
+        $query->insert(self::RELATION_TABLE)
+            ->values([
+                'systemtagid' => $query->createNamedParameter($tagId, IQueryBuilder::PARAM_INT),
+                'objecttype' => $query->createNamedParameter($objectType),
+                'objectid' => $query->createParameter('objectid'),
+            ]);
+
+        foreach (array_unique($objectIds) as $objectId) {
+            $query->setParameter('objectid', (string)$objectId);
+            $query->executeStatement();
+        }
+
+        $this->updateEtagForTags([$tagId]);
+        $this->connection->commit();
+
+        // Dispatch assign events for new object ids
+        foreach ($addedObjectIds as $objectId) {
+            $this->dispatcher->dispatch(MapperEvent::EVENT_ASSIGN, new MapperEvent(
+                MapperEvent::EVENT_ASSIGN,
+                $objectType,
+                (string)$objectId,
+                [(int)$tagId]
+            ));
+        }
+
+        // Dispatch unassign events for removed object ids
+        foreach ($removedObjectIds as $objectId) {
+            $this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
+                MapperEvent::EVENT_UNASSIGN,
+                $objectType,
+                (string)$objectId,
+                [(int)$tagId]
+            ));
+        }
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getAvailableObjectTypes(): array {
+        $query = $this->connection->getQueryBuilder();
+        $query->selectDistinct('objecttype')
+            ->from(self::RELATION_TABLE);
+
+        $result = $query->executeQuery();
+        $objectTypes = [];
+        while ($row = $result->fetch()) {
+            $objectTypes[] = $row['objecttype'];
+        }
+        $result->closeCursor();
+
+        return $objectTypes;
+    }
 }

Spacing +10 added lines, -10 removed lines

@@ -250,10 +250,10 @@ 
 		$result->closeCursor();
 
 		if ($all) {
-			return ((int)$row[0] === \count($objIds));
+			return ((int) $row[0] === \count($objIds));
 		}
 
-		return (bool)$row;
+		return (bool) $row;
 	}
 
 	/**
@@ -268,7 +268,7 @@ 
 		if (\count($tags) !== \count($tagIds)) {
 			// at least one tag missing, bail out
 			$foundTagIds = array_map(
-				function (ISystemTag $tag) {
+				function(ISystemTag $tag) {
 					return $tag->getId();
 				},
 				$tags
@@ -300,8 +300,8 @@ 
 			$this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
 				MapperEvent::EVENT_UNASSIGN,
 				$objectType,
-				(string)$objectId,
-				[(int)$tagId]
+				(string) $objectId,
+				[(int) $tagId]
 			));
 		}
 
@@ -319,7 +319,7 @@ 
 			]);
 
 		foreach (array_unique($objectIds) as $objectId) {
-			$query->setParameter('objectid', (string)$objectId);
+			$query->setParameter('objectid', (string) $objectId);
 			$query->executeStatement();
 		}
 
@@ -331,8 +331,8 @@ 
 			$this->dispatcher->dispatch(MapperEvent::EVENT_ASSIGN, new MapperEvent(
 				MapperEvent::EVENT_ASSIGN,
 				$objectType,
-				(string)$objectId,
-				[(int)$tagId]
+				(string) $objectId,
+				[(int) $tagId]
 			));
 		}
 
@@ -341,8 +341,8 @@ 
 			$this->dispatcher->dispatch(MapperEvent::EVENT_UNASSIGN, new MapperEvent(
 				MapperEvent::EVENT_UNASSIGN,
 				$objectType,
-				(string)$objectId,
-				[(int)$tagId]
+				(string) $objectId,
+				[(int) $tagId]
 			));
 		}
 	}

apps/systemtags/lib/Activity/Provider.php

Indentation +282 added lines, -282 removed lines

@@ -15,308 +15,308 @@
 use OCP\L10N\IFactory;
 
 class Provider implements IProvider {
-	public const CREATE_TAG = 'create_tag';
-	public const UPDATE_TAG = 'update_tag';
-	public const DELETE_TAG = 'delete_tag';
+    public const CREATE_TAG = 'create_tag';
+    public const UPDATE_TAG = 'update_tag';
+    public const DELETE_TAG = 'delete_tag';
 
-	public const ASSIGN_TAG = 'assign_tag';
-	public const UNASSIGN_TAG = 'unassign_tag';
+    public const ASSIGN_TAG = 'assign_tag';
+    public const UNASSIGN_TAG = 'unassign_tag';
 
-	/** @var IL10N */
-	protected $l;
+    /** @var IL10N */
+    protected $l;
 
-	/**
-	 * @param IFactory $languageFactory
-	 * @param IURLGenerator $url
-	 * @param IManager $activityManager
-	 * @param IUserManager $userManager
-	 */
-	public function __construct(
-		protected IFactory $languageFactory,
-		protected IURLGenerator $url,
-		protected IManager $activityManager,
-		protected IUserManager $userManager,
-	) {
-	}
+    /**
+     * @param IFactory $languageFactory
+     * @param IURLGenerator $url
+     * @param IManager $activityManager
+     * @param IUserManager $userManager
+     */
+    public function __construct(
+        protected IFactory $languageFactory,
+        protected IURLGenerator $url,
+        protected IManager $activityManager,
+        protected IUserManager $userManager,
+    ) {
+    }
 
-	/**
-	 * @param string $language
-	 * @param IEvent $event
-	 * @param IEvent|null $previousEvent
-	 * @return IEvent
-	 * @throws UnknownActivityException
-	 * @since 11.0.0
-	 */
-	public function parse($language, IEvent $event, ?IEvent $previousEvent = null) {
-		if ($event->getApp() !== 'systemtags') {
-			throw new UnknownActivityException();
-		}
+    /**
+     * @param string $language
+     * @param IEvent $event
+     * @param IEvent|null $previousEvent
+     * @return IEvent
+     * @throws UnknownActivityException
+     * @since 11.0.0
+     */
+    public function parse($language, IEvent $event, ?IEvent $previousEvent = null) {
+        if ($event->getApp() !== 'systemtags') {
+            throw new UnknownActivityException();
+        }
 
-		$this->l = $this->languageFactory->get('systemtags', $language);
+        $this->l = $this->languageFactory->get('systemtags', $language);
 
-		if ($this->activityManager->isFormattingFilteredObject()) {
-			try {
-				return $this->parseShortVersion($event);
-			} catch (UnknownActivityException) {
-				// Ignore and simply use the long version...
-			}
-		}
+        if ($this->activityManager->isFormattingFilteredObject()) {
+            try {
+                return $this->parseShortVersion($event);
+            } catch (UnknownActivityException) {
+                // Ignore and simply use the long version...
+            }
+        }
 
-		return $this->parseLongVersion($event);
-	}
+        return $this->parseLongVersion($event);
+    }
 
-	/**
-	 * @param IEvent $event
-	 * @return IEvent
-	 * @throws UnknownActivityException
-	 * @since 11.0.0
-	 */
-	public function parseShortVersion(IEvent $event): IEvent {
-		$parsedParameters = $this->getParameters($event);
+    /**
+     * @param IEvent $event
+     * @return IEvent
+     * @throws UnknownActivityException
+     * @since 11.0.0
+     */
+    public function parseShortVersion(IEvent $event): IEvent {
+        $parsedParameters = $this->getParameters($event);
 
-		if ($this->activityManager->getRequirePNG()) {
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/tag.png')));
-		} else {
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/tag.svg')));
-		}
+        if ($this->activityManager->getRequirePNG()) {
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/tag.png')));
+        } else {
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/tag.svg')));
+        }
 
-		if ($event->getSubject() === self::ASSIGN_TAG) {
-			if ($parsedParameters['actor']['id'] === '') {
-				$event->setParsedSubject($this->l->t('System tag %1$s added by the system', [
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('Added system tag {systemtag}'), [
-						'systemtag' => $parsedParameters['systemtag'],
-					]);
-			} elseif ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
-				$event->setParsedSubject($this->l->t('Added system tag %1$s', [
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('Added system tag {systemtag}'), [
-						'systemtag' => $parsedParameters['systemtag'],
-					]);
-			} else {
-				$event->setParsedSubject($this->l->t('%1$s added system tag %2$s', [
-					$parsedParameters['actor']['name'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('{actor} added system tag {systemtag}'), [
-						'actor' => $parsedParameters['actor'],
-						'systemtag' => $parsedParameters['systemtag'],
-					]);
-			}
-		} elseif ($event->getSubject() === self::UNASSIGN_TAG) {
-			if ($parsedParameters['actor']['id'] === '') {
-				$event->setParsedSubject($this->l->t('System tag %1$s removed by the system', [
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('Removed system tag {systemtag}'), [
-						'systemtag' => $parsedParameters['systemtag'],
-					]);
-			} elseif ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
-				$event->setParsedSubject($this->l->t('Removed system tag %1$s', [
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('Removed system tag {systemtag}'), [
-						'systemtag' => $parsedParameters['systemtag'],
-					]);
-			} else {
-				$event->setParsedSubject($this->l->t('%1$s removed system tag %2$s', [
-					$parsedParameters['actor']['name'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('{actor} removed system tag {systemtag}'), [
-						'actor' => $parsedParameters['actor'],
-						'systemtag' => $parsedParameters['systemtag'],
-					]);
-			}
-		} else {
-			throw new UnknownActivityException();
-		}
+        if ($event->getSubject() === self::ASSIGN_TAG) {
+            if ($parsedParameters['actor']['id'] === '') {
+                $event->setParsedSubject($this->l->t('System tag %1$s added by the system', [
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('Added system tag {systemtag}'), [
+                        'systemtag' => $parsedParameters['systemtag'],
+                    ]);
+            } elseif ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
+                $event->setParsedSubject($this->l->t('Added system tag %1$s', [
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('Added system tag {systemtag}'), [
+                        'systemtag' => $parsedParameters['systemtag'],
+                    ]);
+            } else {
+                $event->setParsedSubject($this->l->t('%1$s added system tag %2$s', [
+                    $parsedParameters['actor']['name'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('{actor} added system tag {systemtag}'), [
+                        'actor' => $parsedParameters['actor'],
+                        'systemtag' => $parsedParameters['systemtag'],
+                    ]);
+            }
+        } elseif ($event->getSubject() === self::UNASSIGN_TAG) {
+            if ($parsedParameters['actor']['id'] === '') {
+                $event->setParsedSubject($this->l->t('System tag %1$s removed by the system', [
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('Removed system tag {systemtag}'), [
+                        'systemtag' => $parsedParameters['systemtag'],
+                    ]);
+            } elseif ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
+                $event->setParsedSubject($this->l->t('Removed system tag %1$s', [
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('Removed system tag {systemtag}'), [
+                        'systemtag' => $parsedParameters['systemtag'],
+                    ]);
+            } else {
+                $event->setParsedSubject($this->l->t('%1$s removed system tag %2$s', [
+                    $parsedParameters['actor']['name'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('{actor} removed system tag {systemtag}'), [
+                        'actor' => $parsedParameters['actor'],
+                        'systemtag' => $parsedParameters['systemtag'],
+                    ]);
+            }
+        } else {
+            throw new UnknownActivityException();
+        }
 
-		return $event;
-	}
+        return $event;
+    }
 
-	/**
-	 * @param IEvent $event
-	 * @return IEvent
-	 * @throws UnknownActivityException
-	 * @since 11.0.0
-	 */
-	public function parseLongVersion(IEvent $event): IEvent {
-		$parsedParameters = $this->getParameters($event);
+    /**
+     * @param IEvent $event
+     * @return IEvent
+     * @throws UnknownActivityException
+     * @since 11.0.0
+     */
+    public function parseLongVersion(IEvent $event): IEvent {
+        $parsedParameters = $this->getParameters($event);
 
-		if ($this->activityManager->getRequirePNG()) {
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/tag.png')));
-		} else {
-			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/tag.svg')));
-		}
+        if ($this->activityManager->getRequirePNG()) {
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/tag.png')));
+        } else {
+            $event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/tag.svg')));
+        }
 
-		if ($event->getSubject() === self::CREATE_TAG) {
-			if ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
-				$event->setParsedSubject($this->l->t('You created system tag %1$s', [
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('You created system tag {systemtag}'), $parsedParameters);
-			} else {
-				$event->setParsedSubject($this->l->t('%1$s created system tag %2$s', [
-					$parsedParameters['actor']['name'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('{actor} created system tag {systemtag}'), $parsedParameters);
-			}
-		} elseif ($event->getSubject() === self::DELETE_TAG) {
-			if ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
-				$event->setParsedSubject($this->l->t('You deleted system tag %1$s', [
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('You deleted system tag {systemtag}'), $parsedParameters);
-			} else {
-				$event->setParsedSubject($this->l->t('%1$s deleted system tag %2$s', [
-					$parsedParameters['actor']['name'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('{actor} deleted system tag {systemtag}'), $parsedParameters);
-			}
-		} elseif ($event->getSubject() === self::UPDATE_TAG) {
-			if ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
-				$event->setParsedSubject($this->l->t('You updated system tag %2$s to %1$s', [
-					$this->generatePlainSystemTag($parsedParameters['newsystemtag']),
-					$this->generatePlainSystemTag($parsedParameters['oldsystemtag']),
-				]))
-					->setRichSubject($this->l->t('You updated system tag {oldsystemtag} to {newsystemtag}'), $parsedParameters);
-			} else {
-				$event->setParsedSubject($this->l->t('%1$s updated system tag %3$s to %2$s', [
-					$parsedParameters['actor']['name'],
-					$this->generatePlainSystemTag($parsedParameters['newsystemtag']),
-					$this->generatePlainSystemTag($parsedParameters['oldsystemtag']),
-				]))
-					->setRichSubject($this->l->t('{actor} updated system tag {oldsystemtag} to {newsystemtag}'), $parsedParameters);
-			}
-		} elseif ($event->getSubject() === self::ASSIGN_TAG) {
-			if ($parsedParameters['actor']['id'] === '') {
-				unset($parsedParameters['actor']);
-				$event->setParsedSubject($this->l->t('System tag %2$s was added to %1$s by the system', [
-					$parsedParameters['file']['path'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('System tag {systemtag} was added to {file} by the system'), $parsedParameters);
-			} elseif ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
-				$event->setParsedSubject($this->l->t('You added system tag %2$s to %1$s', [
-					$parsedParameters['file']['path'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('You added system tag {systemtag} to {file}'), $parsedParameters);
-			} else {
-				$event->setParsedSubject($this->l->t('%1$s added system tag %3$s to %2$s', [
-					$parsedParameters['actor']['name'],
-					$parsedParameters['file']['path'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('{actor} added system tag {systemtag} to {file}'), $parsedParameters);
-			}
-		} elseif ($event->getSubject() === self::UNASSIGN_TAG) {
-			if ($parsedParameters['actor']['id'] === '') {
-				unset($parsedParameters['actor']);
-				$event->setParsedSubject($this->l->t('System tag %2$s was removed from %1$s by the system', [
-					$parsedParameters['file']['path'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('System tag {systemtag} was removed from {file} by the system'), $parsedParameters);
-			} elseif ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
-				$event->setParsedSubject($this->l->t('You removed system tag %2$s from %1$s', [
-					$parsedParameters['file']['path'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('You removed system tag {systemtag} from {file}'), $parsedParameters);
-			} else {
-				$event->setParsedSubject($this->l->t('%1$s removed system tag %3$s from %2$s', [
-					$parsedParameters['actor']['name'],
-					$parsedParameters['file']['path'],
-					$this->generatePlainSystemTag($parsedParameters['systemtag']),
-				]))
-					->setRichSubject($this->l->t('{actor} removed system tag {systemtag} from {file}'), $parsedParameters);
-			}
-		} else {
-			throw new UnknownActivityException();
-		}
+        if ($event->getSubject() === self::CREATE_TAG) {
+            if ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
+                $event->setParsedSubject($this->l->t('You created system tag %1$s', [
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('You created system tag {systemtag}'), $parsedParameters);
+            } else {
+                $event->setParsedSubject($this->l->t('%1$s created system tag %2$s', [
+                    $parsedParameters['actor']['name'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('{actor} created system tag {systemtag}'), $parsedParameters);
+            }
+        } elseif ($event->getSubject() === self::DELETE_TAG) {
+            if ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
+                $event->setParsedSubject($this->l->t('You deleted system tag %1$s', [
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('You deleted system tag {systemtag}'), $parsedParameters);
+            } else {
+                $event->setParsedSubject($this->l->t('%1$s deleted system tag %2$s', [
+                    $parsedParameters['actor']['name'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('{actor} deleted system tag {systemtag}'), $parsedParameters);
+            }
+        } elseif ($event->getSubject() === self::UPDATE_TAG) {
+            if ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
+                $event->setParsedSubject($this->l->t('You updated system tag %2$s to %1$s', [
+                    $this->generatePlainSystemTag($parsedParameters['newsystemtag']),
+                    $this->generatePlainSystemTag($parsedParameters['oldsystemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('You updated system tag {oldsystemtag} to {newsystemtag}'), $parsedParameters);
+            } else {
+                $event->setParsedSubject($this->l->t('%1$s updated system tag %3$s to %2$s', [
+                    $parsedParameters['actor']['name'],
+                    $this->generatePlainSystemTag($parsedParameters['newsystemtag']),
+                    $this->generatePlainSystemTag($parsedParameters['oldsystemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('{actor} updated system tag {oldsystemtag} to {newsystemtag}'), $parsedParameters);
+            }
+        } elseif ($event->getSubject() === self::ASSIGN_TAG) {
+            if ($parsedParameters['actor']['id'] === '') {
+                unset($parsedParameters['actor']);
+                $event->setParsedSubject($this->l->t('System tag %2$s was added to %1$s by the system', [
+                    $parsedParameters['file']['path'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('System tag {systemtag} was added to {file} by the system'), $parsedParameters);
+            } elseif ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
+                $event->setParsedSubject($this->l->t('You added system tag %2$s to %1$s', [
+                    $parsedParameters['file']['path'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('You added system tag {systemtag} to {file}'), $parsedParameters);
+            } else {
+                $event->setParsedSubject($this->l->t('%1$s added system tag %3$s to %2$s', [
+                    $parsedParameters['actor']['name'],
+                    $parsedParameters['file']['path'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('{actor} added system tag {systemtag} to {file}'), $parsedParameters);
+            }
+        } elseif ($event->getSubject() === self::UNASSIGN_TAG) {
+            if ($parsedParameters['actor']['id'] === '') {
+                unset($parsedParameters['actor']);
+                $event->setParsedSubject($this->l->t('System tag %2$s was removed from %1$s by the system', [
+                    $parsedParameters['file']['path'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('System tag {systemtag} was removed from {file} by the system'), $parsedParameters);
+            } elseif ($parsedParameters['actor']['id'] === $this->activityManager->getCurrentUserId()) {
+                $event->setParsedSubject($this->l->t('You removed system tag %2$s from %1$s', [
+                    $parsedParameters['file']['path'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('You removed system tag {systemtag} from {file}'), $parsedParameters);
+            } else {
+                $event->setParsedSubject($this->l->t('%1$s removed system tag %3$s from %2$s', [
+                    $parsedParameters['actor']['name'],
+                    $parsedParameters['file']['path'],
+                    $this->generatePlainSystemTag($parsedParameters['systemtag']),
+                ]))
+                    ->setRichSubject($this->l->t('{actor} removed system tag {systemtag} from {file}'), $parsedParameters);
+            }
+        } else {
+            throw new UnknownActivityException();
+        }
 
-		return $event;
-	}
+        return $event;
+    }
 
-	protected function getParameters(IEvent $event) {
-		$subject = $event->getSubject();
-		$parameters = $event->getSubjectParameters();
+    protected function getParameters(IEvent $event) {
+        $subject = $event->getSubject();
+        $parameters = $event->getSubjectParameters();
 
-		switch ($subject) {
-			case self::CREATE_TAG:
-			case self::DELETE_TAG:
-				return [
-					'actor' => $this->getUserParameter((string)$parameters[0]),
-					'systemtag' => $this->getSystemTagParameter($parameters[1]),
-				];
-			case self::UPDATE_TAG:
-				return [
-					'actor' => $this->getUserParameter((string)$parameters[0]),
-					'newsystemtag' => $this->getSystemTagParameter($parameters[1]),
-					'oldsystemtag' => $this->getSystemTagParameter($parameters[2]),
-				];
-			case self::ASSIGN_TAG:
-			case self::UNASSIGN_TAG:
-				return [
-					'actor' => $this->getUserParameter((string)$parameters[0]),
-					'file' => $this->getFileParameter($event->getObjectId(), $parameters[1]),
-					'systemtag' => $this->getSystemTagParameter($parameters[2]),
-				];
-		}
-		return [];
-	}
+        switch ($subject) {
+            case self::CREATE_TAG:
+            case self::DELETE_TAG:
+                return [
+                    'actor' => $this->getUserParameter((string)$parameters[0]),
+                    'systemtag' => $this->getSystemTagParameter($parameters[1]),
+                ];
+            case self::UPDATE_TAG:
+                return [
+                    'actor' => $this->getUserParameter((string)$parameters[0]),
+                    'newsystemtag' => $this->getSystemTagParameter($parameters[1]),
+                    'oldsystemtag' => $this->getSystemTagParameter($parameters[2]),
+                ];
+            case self::ASSIGN_TAG:
+            case self::UNASSIGN_TAG:
+                return [
+                    'actor' => $this->getUserParameter((string)$parameters[0]),
+                    'file' => $this->getFileParameter($event->getObjectId(), $parameters[1]),
+                    'systemtag' => $this->getSystemTagParameter($parameters[2]),
+                ];
+        }
+        return [];
+    }
 
-	protected function getFileParameter($id, $path) {
-		return [
-			'type' => 'file',
-			'id' => (string)$id,
-			'name' => basename($path),
-			'path' => trim($path, '/'),
-		];
-	}
+    protected function getFileParameter($id, $path) {
+        return [
+            'type' => 'file',
+            'id' => (string)$id,
+            'name' => basename($path),
+            'path' => trim($path, '/'),
+        ];
+    }
 
-	protected function getSystemTagParameter($parameter) {
-		$tagData = json_decode($parameter, true);
-		if ($tagData === null) {
-			[$name, $status] = explode('|||', substr($parameter, 3, -3));
-			$tagData = [
-				'id' => '0', // No way to recover the ID
-				'name' => $name,
-				'assignable' => $status === 'assignable',
-				'visible' => $status !== 'invisible',
-			];
-		}
+    protected function getSystemTagParameter($parameter) {
+        $tagData = json_decode($parameter, true);
+        if ($tagData === null) {
+            [$name, $status] = explode('|||', substr($parameter, 3, -3));
+            $tagData = [
+                'id' => '0', // No way to recover the ID
+                'name' => $name,
+                'assignable' => $status === 'assignable',
+                'visible' => $status !== 'invisible',
+            ];
+        }
 
-		return [
-			'type' => 'systemtag',
-			'id' => (string)$tagData['id'],
-			'name' => $tagData['name'],
-			'assignable' => $tagData['assignable'] ? '1' : '0',
-			'visibility' => $tagData['visible'] ? '1' : '0',
-		];
-	}
+        return [
+            'type' => 'systemtag',
+            'id' => (string)$tagData['id'],
+            'name' => $tagData['name'],
+            'assignable' => $tagData['assignable'] ? '1' : '0',
+            'visibility' => $tagData['visible'] ? '1' : '0',
+        ];
+    }
 
-	protected function getUserParameter(string $uid): array {
-		return [
-			'type' => 'user',
-			'id' => $uid,
-			'name' => $this->userManager->getDisplayName($uid) ?? $uid,
-		];
-	}
+    protected function getUserParameter(string $uid): array {
+        return [
+            'type' => 'user',
+            'id' => $uid,
+            'name' => $this->userManager->getDisplayName($uid) ?? $uid,
+        ];
+    }
 
-	protected function generatePlainSystemTag(array $parameter) {
-		if ($parameter['assignable'] === '1') {
-			return $parameter['name'];
-		} elseif ($parameter['visibility'] === '1') {
-			return $this->l->t('%s (restricted)', $parameter['name']);
-		} else {
-			return $this->l->t('%s (invisible)', $parameter['name']);
-		}
-	}
+    protected function generatePlainSystemTag(array $parameter) {
+        if ($parameter['assignable'] === '1') {
+            return $parameter['name'];
+        } elseif ($parameter['visibility'] === '1') {
+            return $this->l->t('%s (restricted)', $parameter['name']);
+        } else {
+            return $this->l->t('%s (invisible)', $parameter['name']);
+        }
+    }
 }

Spacing +5 added lines, -5 removed lines

@@ -252,19 +252,19 @@ 
 			case self::CREATE_TAG:
 			case self::DELETE_TAG:
 				return [
-					'actor' => $this->getUserParameter((string)$parameters[0]),
+					'actor' => $this->getUserParameter((string) $parameters[0]),
 					'systemtag' => $this->getSystemTagParameter($parameters[1]),
 				];
 			case self::UPDATE_TAG:
 				return [
-					'actor' => $this->getUserParameter((string)$parameters[0]),
+					'actor' => $this->getUserParameter((string) $parameters[0]),
 					'newsystemtag' => $this->getSystemTagParameter($parameters[1]),
 					'oldsystemtag' => $this->getSystemTagParameter($parameters[2]),
 				];
 			case self::ASSIGN_TAG:
 			case self::UNASSIGN_TAG:
 				return [
-					'actor' => $this->getUserParameter((string)$parameters[0]),
+					'actor' => $this->getUserParameter((string) $parameters[0]),
 					'file' => $this->getFileParameter($event->getObjectId(), $parameters[1]),
 					'systemtag' => $this->getSystemTagParameter($parameters[2]),
 				];
@@ -275,7 +275,7 @@ 
 	protected function getFileParameter($id, $path) {
 		return [
 			'type' => 'file',
-			'id' => (string)$id,
+			'id' => (string) $id,
 			'name' => basename($path),
 			'path' => trim($path, '/'),
 		];
@@ -295,7 +295,7 @@ 
 
 		return [
 			'type' => 'systemtag',
-			'id' => (string)$tagData['id'],
+			'id' => (string) $tagData['id'],
 			'name' => $tagData['name'],
 			'assignable' => $tagData['assignable'] ? '1' : '0',
 			'visibility' => $tagData['visible'] ? '1' : '0',