Inspection of "Merge pull request #33292 from nextcloud/no-profil..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a1b7f1...63fc83 )

by Robin

created 2023-04-05 13:58 UTC

Status

Indentation +84 added lines, -84 removed lines patch added patch discarded remove patch

@@ -34,88 +34,88 @@
 block discarded – undo
 use OC\SystemConfig;
 
 class Profiler implements IProfiler {
-	/** @var array<string, IDataCollector> */
-	private array $dataCollectors = [];
-
-	private ?FileProfilerStorage $storage = null;
-
-	private bool $enabled = false;
-
-	public function __construct(SystemConfig $config) {
-		$this->enabled = $config->getValue('profiler', false);
-		if ($this->enabled) {
-			$this->storage = new FileProfilerStorage($config->getValue('datadirectory', \OC::$SERVERROOT . '/data') . '/profiler');
-		}
-	}
-
-	public function add(IDataCollector $dataCollector): void {
-		$this->dataCollectors[$dataCollector->getName()] = $dataCollector;
-	}
-
-	public function loadProfileFromResponse(Response $response): ?IProfile {
-		if (!$token = $response->getHeaders()['X-Debug-Token']) {
-			return null;
-		}
-
-		return $this->loadProfile($token);
-	}
-
-	public function loadProfile(string $token): ?IProfile {
-		if ($this->storage) {
-			return $this->storage->read($token);
-		} else {
-			return null;
-		}
-	}
-
-	public function saveProfile(IProfile $profile): bool {
-		if ($this->storage) {
-			return $this->storage->write($profile);
-		} else {
-			return false;
-		}
-	}
-
-	public function collect(Request $request, Response $response): IProfile {
-		$profile = new Profile($request->getId());
-		$profile->setTime(time());
-		$profile->setUrl($request->getRequestUri());
-		$profile->setMethod($request->getMethod());
-		$profile->setStatusCode($response->getStatus());
-		foreach ($this->dataCollectors as $dataCollector) {
-			$dataCollector->collect($request, $response, null);
-
-			// We clone for subrequests
-			$profile->addCollector(clone $dataCollector);
-		}
-		return $profile;
-	}
-
-	/**
-	 * @return array[]
-	 */
-	public function find(?string $url, ?int $limit, ?string $method, ?int $start, ?int $end,
-						 string $statusCode = null): array {
-		if ($this->storage) {
-			return $this->storage->find($url, $limit, $method, $start, $end, $statusCode);
-		} else {
-			return [];
-		}
-	}
-
-	public function dataProviders(): array {
-		return array_keys($this->dataCollectors);
-	}
-
-	public function isEnabled(): bool {
-		return $this->enabled;
-	}
-
-	public function setEnabled(bool $enabled): void {
-		$this->enabled = $enabled;
-	}
-
-	public function clear(): void {
-		$this->storage->purge();
-	}
+    /** @var array<string, IDataCollector> */
+    private array $dataCollectors = [];
+
+    private ?FileProfilerStorage $storage = null;
+
+    private bool $enabled = false;
+
+    public function __construct(SystemConfig $config) {
+        $this->enabled = $config->getValue('profiler', false);
+        if ($this->enabled) {
+            $this->storage = new FileProfilerStorage($config->getValue('datadirectory', \OC::$SERVERROOT . '/data') . '/profiler');
+        }
+    }
+
+    public function add(IDataCollector $dataCollector): void {
+        $this->dataCollectors[$dataCollector->getName()] = $dataCollector;
+    }
+
+    public function loadProfileFromResponse(Response $response): ?IProfile {
+        if (!$token = $response->getHeaders()['X-Debug-Token']) {
+            return null;
+        }
+
+        return $this->loadProfile($token);
+    }
+
+    public function loadProfile(string $token): ?IProfile {
+        if ($this->storage) {
+            return $this->storage->read($token);
+        } else {
+            return null;
+        }
+    }
+
+    public function saveProfile(IProfile $profile): bool {
+        if ($this->storage) {
+            return $this->storage->write($profile);
+        } else {
+            return false;
+        }
+    }
+
+    public function collect(Request $request, Response $response): IProfile {
+        $profile = new Profile($request->getId());
+        $profile->setTime(time());
+        $profile->setUrl($request->getRequestUri());
+        $profile->setMethod($request->getMethod());
+        $profile->setStatusCode($response->getStatus());
+        foreach ($this->dataCollectors as $dataCollector) {
+            $dataCollector->collect($request, $response, null);
+
+            // We clone for subrequests
+            $profile->addCollector(clone $dataCollector);
+        }
+        return $profile;
+    }
+
+    /**
+     * @return array[]
+     */
+    public function find(?string $url, ?int $limit, ?string $method, ?int $start, ?int $end,
+                            string $statusCode = null): array {
+        if ($this->storage) {
+            return $this->storage->find($url, $limit, $method, $start, $end, $statusCode);
+        } else {
+            return [];
+        }
+    }
+
+    public function dataProviders(): array {
+        return array_keys($this->dataCollectors);
+    }
+
+    public function isEnabled(): bool {
+        return $this->enabled;
+    }
+
+    public function setEnabled(bool $enabled): void {
+        $this->enabled = $enabled;
+    }
+
+    public function clear(): void {
+        $this->storage->purge();
+    }
 }

Please login to merge, or discard this patch.

		@@ -34,88 +34,88 @@
		block discarded – undo
34	34	use OC\SystemConfig;
35	35
36	36	class Profiler implements IProfiler {
37		- /** @var array<string, IDataCollector> */
38		- private array $dataCollectors = [];
39		-
40		- private ?FileProfilerStorage $storage = null;
41		-
42		- private bool $enabled = false;
43		-
44		- public function __construct(SystemConfig $config) {
45		- $this->enabled = $config->getValue('profiler', false);
46		- if ($this->enabled) {
47		- $this->storage = new FileProfilerStorage($config->getValue('datadirectory', \OC::$SERVERROOT . '/data') . '/profiler');
48		- }
49		- }
50		-
51		- public function add(IDataCollector $dataCollector): void {
52		- $this->dataCollectors[$dataCollector->getName()] = $dataCollector;
53		- }
54		-
55		- public function loadProfileFromResponse(Response $response): ?IProfile {
56		- if (!$token = $response->getHeaders()['X-Debug-Token']) {
57		- return null;
58		- }
59		-
60		- return $this->loadProfile($token);
61		- }
62		-
63		- public function loadProfile(string $token): ?IProfile {
64		- if ($this->storage) {
65		- return $this->storage->read($token);
66		- } else {
67		- return null;
68		- }
69		- }
70		-
71		- public function saveProfile(IProfile $profile): bool {
72		- if ($this->storage) {
73		- return $this->storage->write($profile);
74		- } else {
75		- return false;
76		- }
77		- }
78		-
79		- public function collect(Request $request, Response $response): IProfile {
80		- $profile = new Profile($request->getId());
81		- $profile->setTime(time());
82		- $profile->setUrl($request->getRequestUri());
83		- $profile->setMethod($request->getMethod());
84		- $profile->setStatusCode($response->getStatus());
85		- foreach ($this->dataCollectors as $dataCollector) {
86		- $dataCollector->collect($request, $response, null);
87		-
88		- // We clone for subrequests
89		- $profile->addCollector(clone $dataCollector);
90		- }
91		- return $profile;
92		- }
93		-
94		- /**
95		- * @return array[]
96		- */
97		- public function find(?string $url, ?int $limit, ?string $method, ?int $start, ?int $end,
98		- string $statusCode = null): array {
99		- if ($this->storage) {
100		- return $this->storage->find($url, $limit, $method, $start, $end, $statusCode);
101		- } else {
102		- return [];
103		- }
104		- }
105		-
106		- public function dataProviders(): array {
107		- return array_keys($this->dataCollectors);
108		- }
109		-
110		- public function isEnabled(): bool {
111		- return $this->enabled;
112		- }
113		-
114		- public function setEnabled(bool $enabled): void {
115		- $this->enabled = $enabled;
116		- }
117		-
118		- public function clear(): void {
119		- $this->storage->purge();
120		- }
	37	+ /** @var array<string, IDataCollector> */
	38	+ private array $dataCollectors = [];
	39	+
	40	+ private ?FileProfilerStorage $storage = null;
	41	+
	42	+ private bool $enabled = false;
	43	+
	44	+ public function __construct(SystemConfig $config) {
	45	+ $this->enabled = $config->getValue('profiler', false);
	46	+ if ($this->enabled) {
	47	+ $this->storage = new FileProfilerStorage($config->getValue('datadirectory', \OC::$SERVERROOT . '/data') . '/profiler');
	48	+ }
	49	+ }
	50	+
	51	+ public function add(IDataCollector $dataCollector): void {
	52	+ $this->dataCollectors[$dataCollector->getName()] = $dataCollector;
	53	+ }
	54	+
	55	+ public function loadProfileFromResponse(Response $response): ?IProfile {
	56	+ if (!$token = $response->getHeaders()['X-Debug-Token']) {
	57	+ return null;
	58	+ }
	59	+
	60	+ return $this->loadProfile($token);
	61	+ }
	62	+
	63	+ public function loadProfile(string $token): ?IProfile {
	64	+ if ($this->storage) {
	65	+ return $this->storage->read($token);
	66	+ } else {
	67	+ return null;
	68	+ }
	69	+ }
	70	+
	71	+ public function saveProfile(IProfile $profile): bool {
	72	+ if ($this->storage) {
	73	+ return $this->storage->write($profile);
	74	+ } else {
	75	+ return false;
	76	+ }
	77	+ }
	78	+
	79	+ public function collect(Request $request, Response $response): IProfile {
	80	+ $profile = new Profile($request->getId());
	81	+ $profile->setTime(time());
	82	+ $profile->setUrl($request->getRequestUri());
	83	+ $profile->setMethod($request->getMethod());
	84	+ $profile->setStatusCode($response->getStatus());
	85	+ foreach ($this->dataCollectors as $dataCollector) {
	86	+ $dataCollector->collect($request, $response, null);
	87	+
	88	+ // We clone for subrequests
	89	+ $profile->addCollector(clone $dataCollector);
	90	+ }
	91	+ return $profile;
	92	+ }
	93	+
	94	+ /**
	95	+ * @return array[]
	96	+ */
	97	+ public function find(?string $url, ?int $limit, ?string $method, ?int $start, ?int $end,
	98	+ string $statusCode = null): array {
	99	+ if ($this->storage) {
	100	+ return $this->storage->find($url, $limit, $method, $start, $end, $statusCode);
	101	+ } else {
	102	+ return [];
	103	+ }
	104	+ }
	105	+
	106	+ public function dataProviders(): array {
	107	+ return array_keys($this->dataCollectors);
	108	+ }
	109	+
	110	+ public function isEnabled(): bool {
	111	+ return $this->enabled;
	112	+ }
	113	+
	114	+ public function setEnabled(bool $enabled): void {
	115	+ $this->enabled = $enabled;
	116	+ }
	117	+
	118	+ public function clear(): void {
	119	+ $this->storage->purge();
	120	+ }
121	121	}

nextcloud / server

Push — master ( a1b7f1...63fc83 )

Status

Category

Indentation +84 added lines, -84 removed lines patch added patch discarded remove patch