Inspection of "Merge pull request #25856 from nextcloud/techdept/..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 92d6ab...148cc8 )

by Roeland

created 2021-03-01 17:25 UTC

Status

Indentation +100 added lines, -100 removed lines patch added patch discarded remove patch

@@ -32,104 +32,104 @@
 block discarded – undo
 use Sabre\DAVACL\IACL;
 
 class Card implements ICard, IACL {
-	use ACLTrait;
-
-	/** @var RecentContact */
-	private $contact;
-
-	/** @var string */
-	private $principal;
-
-	/** @var array */
-	private $acls;
-
-	public function __construct(RecentContact $contact, string $principal, array $acls) {
-		$this->contact = $contact;
-		$this->principal = $principal;
-		$this->acls = $acls;
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function getOwner(): ?string {
-		return $this->principal;
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function getACL(): array {
-		return $this->acls;
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function setAcls(array $acls): void {
-		throw new NotImplemented();
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function put($data): ?string {
-		throw new NotImplemented();
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function get() {
-		return $this->contact->getCard();
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function getContentType(): ?string {
-		return 'text/vcard; charset=utf-8';
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function getETag(): ?string {
-		return '"' . md5((string) $this->getLastModified()) . '"';
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function getSize(): int {
-		throw new NotImplemented();
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function delete(): void {
-		throw new NotImplemented();
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function getName(): string {
-		return (string) $this->contact->getId();
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function setName($name): void {
-		throw new NotImplemented();
-	}
-
-	/**
-	 * @inheritDoc
-	 */
-	public function getLastModified(): ?int {
-		return $this->contact->getLastContact();
-	}
+    use ACLTrait;
+
+    /** @var RecentContact */
+    private $contact;
+
+    /** @var string */
+    private $principal;
+
+    /** @var array */
+    private $acls;
+
+    public function __construct(RecentContact $contact, string $principal, array $acls) {
+        $this->contact = $contact;
+        $this->principal = $principal;
+        $this->acls = $acls;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getOwner(): ?string {
+        return $this->principal;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getACL(): array {
+        return $this->acls;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function setAcls(array $acls): void {
+        throw new NotImplemented();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function put($data): ?string {
+        throw new NotImplemented();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function get() {
+        return $this->contact->getCard();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getContentType(): ?string {
+        return 'text/vcard; charset=utf-8';
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getETag(): ?string {
+        return '"' . md5((string) $this->getLastModified()) . '"';
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getSize(): int {
+        throw new NotImplemented();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function delete(): void {
+        throw new NotImplemented();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getName(): string {
+        return (string) $this->contact->getId();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function setName($name): void {
+        throw new NotImplemented();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getLastModified(): ?int {
+        return $this->contact->getLastContact();
+    }
 }

Please login to merge, or discard this patch.

		@@ -32,104 +32,104 @@
		block discarded – undo
32	32	use Sabre\DAVACL\IACL;
33	33
34	34	class Card implements ICard, IACL {
35		- use ACLTrait;
36		-
37		- /** @var RecentContact */
38		- private $contact;
39		-
40		- /** @var string */
41		- private $principal;
42		-
43		- /** @var array */
44		- private $acls;
45		-
46		- public function __construct(RecentContact $contact, string $principal, array $acls) {
47		- $this->contact = $contact;
48		- $this->principal = $principal;
49		- $this->acls = $acls;
50		- }
51		-
52		- /**
53		- * @inheritDoc
54		- */
55		- public function getOwner(): ?string {
56		- return $this->principal;
57		- }
58		-
59		- /**
60		- * @inheritDoc
61		- */
62		- public function getACL(): array {
63		- return $this->acls;
64		- }
65		-
66		- /**
67		- * @inheritDoc
68		- */
69		- public function setAcls(array $acls): void {
70		- throw new NotImplemented();
71		- }
72		-
73		- /**
74		- * @inheritDoc
75		- */
76		- public function put($data): ?string {
77		- throw new NotImplemented();
78		- }
79		-
80		- /**
81		- * @inheritDoc
82		- */
83		- public function get() {
84		- return $this->contact->getCard();
85		- }
86		-
87		- /**
88		- * @inheritDoc
89		- */
90		- public function getContentType(): ?string {
91		- return 'text/vcard; charset=utf-8';
92		- }
93		-
94		- /**
95		- * @inheritDoc
96		- */
97		- public function getETag(): ?string {
98		- return '"' . md5((string) $this->getLastModified()) . '"';
99		- }
100		-
101		- /**
102		- * @inheritDoc
103		- */
104		- public function getSize(): int {
105		- throw new NotImplemented();
106		- }
107		-
108		- /**
109		- * @inheritDoc
110		- */
111		- public function delete(): void {
112		- throw new NotImplemented();
113		- }
114		-
115		- /**
116		- * @inheritDoc
117		- */
118		- public function getName(): string {
119		- return (string) $this->contact->getId();
120		- }
121		-
122		- /**
123		- * @inheritDoc
124		- */
125		- public function setName($name): void {
126		- throw new NotImplemented();
127		- }
128		-
129		- /**
130		- * @inheritDoc
131		- */
132		- public function getLastModified(): ?int {
133		- return $this->contact->getLastContact();
134		- }
	35	+ use ACLTrait;
	36	+
	37	+ /** @var RecentContact */
	38	+ private $contact;
	39	+
	40	+ /** @var string */
	41	+ private $principal;
	42	+
	43	+ /** @var array */
	44	+ private $acls;
	45	+
	46	+ public function __construct(RecentContact $contact, string $principal, array $acls) {
	47	+ $this->contact = $contact;
	48	+ $this->principal = $principal;
	49	+ $this->acls = $acls;
	50	+ }
	51	+
	52	+ /**
	53	+ * @inheritDoc
	54	+ */
	55	+ public function getOwner(): ?string {
	56	+ return $this->principal;
	57	+ }
	58	+
	59	+ /**
	60	+ * @inheritDoc
	61	+ */
	62	+ public function getACL(): array {
	63	+ return $this->acls;
	64	+ }
	65	+
	66	+ /**
	67	+ * @inheritDoc
	68	+ */
	69	+ public function setAcls(array $acls): void {
	70	+ throw new NotImplemented();
	71	+ }
	72	+
	73	+ /**
	74	+ * @inheritDoc
	75	+ */
	76	+ public function put($data): ?string {
	77	+ throw new NotImplemented();
	78	+ }
	79	+
	80	+ /**
	81	+ * @inheritDoc
	82	+ */
	83	+ public function get() {
	84	+ return $this->contact->getCard();
	85	+ }
	86	+
	87	+ /**
	88	+ * @inheritDoc
	89	+ */
	90	+ public function getContentType(): ?string {
	91	+ return 'text/vcard; charset=utf-8';
	92	+ }
	93	+
	94	+ /**
	95	+ * @inheritDoc
	96	+ */
	97	+ public function getETag(): ?string {
	98	+ return '"' . md5((string) $this->getLastModified()) . '"';
	99	+ }
	100	+
	101	+ /**
	102	+ * @inheritDoc
	103	+ */
	104	+ public function getSize(): int {
	105	+ throw new NotImplemented();
	106	+ }
	107	+
	108	+ /**
	109	+ * @inheritDoc
	110	+ */
	111	+ public function delete(): void {
	112	+ throw new NotImplemented();
	113	+ }
	114	+
	115	+ /**
	116	+ * @inheritDoc
	117	+ */
	118	+ public function getName(): string {
	119	+ return (string) $this->contact->getId();
	120	+ }
	121	+
	122	+ /**
	123	+ * @inheritDoc
	124	+ */
	125	+ public function setName($name): void {
	126	+ throw new NotImplemented();
	127	+ }
	128	+
	129	+ /**
	130	+ * @inheritDoc
	131	+ */
	132	+ public function getLastModified(): ?int {
	133	+ return $this->contact->getLastContact();
	134	+ }
135	135	}

nextcloud / server

Push — master ( 92d6ab...148cc8 )

Status

Category

Indentation +100 added lines, -100 removed lines patch added patch discarded remove patch