Inspection of "Merge pull request #21864 from nextcloud/techdebt/..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5fc51b...0716fb )

by Morris

created 2020-07-20 22:17 UTC

Status

Indentation +70 added lines, -70 removed lines patch added patch discarded remove patch

@@ -48,83 +48,83 @@
 block discarded – undo
 use Psr\Container\ContainerInterface;
 
 class Application extends App implements IBootstrap {
-	public const APP_ID = 'files_versions';
+    public const APP_ID = 'files_versions';
 
-	public function __construct(array $urlParams = []) {
-		parent::__construct(self::APP_ID, $urlParams);
-	}
+    public function __construct(array $urlParams = []) {
+        parent::__construct(self::APP_ID, $urlParams);
+    }
 
-	public function register(IRegistrationContext $context): void {
-		/**
-		 * Register capabilities
-		 */
-		$context->registerCapability(Capabilities::class);
+    public function register(IRegistrationContext $context): void {
+        /**
+         * Register capabilities
+         */
+        $context->registerCapability(Capabilities::class);
 
-		/**
-		 * Register $principalBackend for the DAV collection
-		 */
-		$context->registerService('principalBackend', function (ContainerInterface $c) {
-			/** @var IServerContainer $server */
-			$server = $c->get(IServerContainer::class);
-			return new Principal(
-				$server->getUserManager(),
-				$server->getGroupManager(),
-				$server->getShareManager(),
-				$server->getUserSession(),
-				$server->getAppManager(),
-				$server->get(ProxyMapper::class),
-				$server->getConfig()
-			);
-		});
+        /**
+         * Register $principalBackend for the DAV collection
+         */
+        $context->registerService('principalBackend', function (ContainerInterface $c) {
+            /** @var IServerContainer $server */
+            $server = $c->get(IServerContainer::class);
+            return new Principal(
+                $server->getUserManager(),
+                $server->getGroupManager(),
+                $server->getShareManager(),
+                $server->getUserSession(),
+                $server->getAppManager(),
+                $server->get(ProxyMapper::class),
+                $server->getConfig()
+            );
+        });
 
-		$context->registerService(IVersionManager::class, function () {
-			return new VersionManager();
-		});
+        $context->registerService(IVersionManager::class, function () {
+            return new VersionManager();
+        });
 
-		/**
-		 * Register Events
-		 */
-		$context->registerEventListener(LoadAdditionalScriptsEvent::class, LoadAdditionalListener::class);
-		$context->registerEventListener(LoadSidebar::class, LoadSidebarListener::class);
-	}
+        /**
+         * Register Events
+         */
+        $context->registerEventListener(LoadAdditionalScriptsEvent::class, LoadAdditionalListener::class);
+        $context->registerEventListener(LoadSidebar::class, LoadSidebarListener::class);
+    }
 
-	public function boot(IBootContext $context): void {
-		$context->injectFn(\Closure::fromCallable([$this, 'registerVersionBackends']));
+    public function boot(IBootContext $context): void {
+        $context->injectFn(\Closure::fromCallable([$this, 'registerVersionBackends']));
 
-		/**
-		 * Register hooks
-		 */
-		Hooks::connectHooks();
-	}
+        /**
+         * Register hooks
+         */
+        Hooks::connectHooks();
+    }
 
-	public function registerVersionBackends(ContainerInterface $container, IAppManager $appManager, ILogger $logger) {
-		foreach ($appManager->getInstalledApps() as $app) {
-			$appInfo = $appManager->getAppInfo($app);
-			if (isset($appInfo['versions'])) {
-				$backends = $appInfo['versions'];
-				foreach ($backends as $backend) {
-					if (isset($backend['@value'])) {
-						$this->loadBackend($backend, $container, $logger);
-					} else {
-						foreach ($backend as $singleBackend) {
-							$this->loadBackend($singleBackend, $container, $logger);
-						}
-					}
-				}
-			}
-		}
-	}
+    public function registerVersionBackends(ContainerInterface $container, IAppManager $appManager, ILogger $logger) {
+        foreach ($appManager->getInstalledApps() as $app) {
+            $appInfo = $appManager->getAppInfo($app);
+            if (isset($appInfo['versions'])) {
+                $backends = $appInfo['versions'];
+                foreach ($backends as $backend) {
+                    if (isset($backend['@value'])) {
+                        $this->loadBackend($backend, $container, $logger);
+                    } else {
+                        foreach ($backend as $singleBackend) {
+                            $this->loadBackend($singleBackend, $container, $logger);
+                        }
+                    }
+                }
+            }
+        }
+    }
 
-	private function loadBackend(array $backend, ContainerInterface $container, ILogger $logger) {
-		/** @var IVersionManager $versionManager */
-		$versionManager = $container->get(IVersionManager::class);
-		$class = $backend['@value'];
-		$for = $backend['@attributes']['for'];
-		try {
-			$backendObject = $container->get($class);
-			$versionManager->registerBackend($for, $backendObject);
-		} catch (\Exception $e) {
-			$logger->logException($e);
-		}
-	}
+    private function loadBackend(array $backend, ContainerInterface $container, ILogger $logger) {
+        /** @var IVersionManager $versionManager */
+        $versionManager = $container->get(IVersionManager::class);
+        $class = $backend['@value'];
+        $for = $backend['@attributes']['for'];
+        try {
+            $backendObject = $container->get($class);
+            $versionManager->registerBackend($for, $backendObject);
+        } catch (\Exception $e) {
+            $logger->logException($e);
+        }
+    }
 }

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 		/**
 		 * Register $principalBackend for the DAV collection
 		 */
-		$context->registerService('principalBackend', function (ContainerInterface $c) {
+		$context->registerService('principalBackend', function(ContainerInterface $c) {
 			/** @var IServerContainer $server */
 			$server = $c->get(IServerContainer::class);
 			return new Principal(
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
 			);
 		});
 
-		$context->registerService(IVersionManager::class, function () {
+		$context->registerService(IVersionManager::class, function() {
 			return new VersionManager();
 		});
 

Please login to merge, or discard this patch.

		@@ -48,83 +48,83 @@
		block discarded – undo
48	48	use Psr\Container\ContainerInterface;
49	49
50	50	class Application extends App implements IBootstrap {
51		- public const APP_ID = 'files_versions';
	51	+ public const APP_ID = 'files_versions';
52	52
53		- public function __construct(array $urlParams = []) {
54		- parent::__construct(self::APP_ID, $urlParams);
55		- }
	53	+ public function __construct(array $urlParams = []) {
	54	+ parent::__construct(self::APP_ID, $urlParams);
	55	+ }
56	56
57		- public function register(IRegistrationContext $context): void {
58		- /**
59		- * Register capabilities
60		- */
61		- $context->registerCapability(Capabilities::class);
	57	+ public function register(IRegistrationContext $context): void {
	58	+ /**
	59	+ * Register capabilities
	60	+ */
	61	+ $context->registerCapability(Capabilities::class);
62	62
63		- /**
64		- * Register $principalBackend for the DAV collection
65		- */
66		- $context->registerService('principalBackend', function (ContainerInterface $c) {
67		- /** @var IServerContainer $server */
68		- $server = $c->get(IServerContainer::class);
69		- return new Principal(
70		- $server->getUserManager(),
71		- $server->getGroupManager(),
72		- $server->getShareManager(),
73		- $server->getUserSession(),
74		- $server->getAppManager(),
75		- $server->get(ProxyMapper::class),
76		- $server->getConfig()
77		- );
78		- });
	63	+ /**
	64	+ * Register $principalBackend for the DAV collection
	65	+ */
	66	+ $context->registerService('principalBackend', function (ContainerInterface $c) {
	67	+ /** @var IServerContainer $server */
	68	+ $server = $c->get(IServerContainer::class);
	69	+ return new Principal(
	70	+ $server->getUserManager(),
	71	+ $server->getGroupManager(),
	72	+ $server->getShareManager(),
	73	+ $server->getUserSession(),
	74	+ $server->getAppManager(),
	75	+ $server->get(ProxyMapper::class),
	76	+ $server->getConfig()
	77	+ );
	78	+ });
79	79
80		- $context->registerService(IVersionManager::class, function () {
81		- return new VersionManager();
82		- });
	80	+ $context->registerService(IVersionManager::class, function () {
	81	+ return new VersionManager();
	82	+ });
83	83
84		- /**
85		- * Register Events
86		- */
87		- $context->registerEventListener(LoadAdditionalScriptsEvent::class, LoadAdditionalListener::class);
88		- $context->registerEventListener(LoadSidebar::class, LoadSidebarListener::class);
89		- }
	84	+ /**
	85	+ * Register Events
	86	+ */
	87	+ $context->registerEventListener(LoadAdditionalScriptsEvent::class, LoadAdditionalListener::class);
	88	+ $context->registerEventListener(LoadSidebar::class, LoadSidebarListener::class);
	89	+ }
90	90
91		- public function boot(IBootContext $context): void {
92		- $context->injectFn(\Closure::fromCallable([$this, 'registerVersionBackends']));
	91	+ public function boot(IBootContext $context): void {
	92	+ $context->injectFn(\Closure::fromCallable([$this, 'registerVersionBackends']));
93	93
94		- /**
95		- * Register hooks
96		- */
97		- Hooks::connectHooks();
98		- }
	94	+ /**
	95	+ * Register hooks
	96	+ */
	97	+ Hooks::connectHooks();
	98	+ }
99	99
100		- public function registerVersionBackends(ContainerInterface $container, IAppManager $appManager, ILogger $logger) {
101		- foreach ($appManager->getInstalledApps() as $app) {
102		- $appInfo = $appManager->getAppInfo($app);
103		- if (isset($appInfo['versions'])) {
104		- $backends = $appInfo['versions'];
105		- foreach ($backends as $backend) {
106		- if (isset($backend['@value'])) {
107		- $this->loadBackend($backend, $container, $logger);
108		- } else {
109		- foreach ($backend as $singleBackend) {
110		- $this->loadBackend($singleBackend, $container, $logger);
111		- }
112		- }
113		- }
114		- }
115		- }
116		- }
	100	+ public function registerVersionBackends(ContainerInterface $container, IAppManager $appManager, ILogger $logger) {
	101	+ foreach ($appManager->getInstalledApps() as $app) {
	102	+ $appInfo = $appManager->getAppInfo($app);
	103	+ if (isset($appInfo['versions'])) {
	104	+ $backends = $appInfo['versions'];
	105	+ foreach ($backends as $backend) {
	106	+ if (isset($backend['@value'])) {
	107	+ $this->loadBackend($backend, $container, $logger);
	108	+ } else {
	109	+ foreach ($backend as $singleBackend) {
	110	+ $this->loadBackend($singleBackend, $container, $logger);
	111	+ }
	112	+ }
	113	+ }
	114	+ }
	115	+ }
	116	+ }
117	117
118		- private function loadBackend(array $backend, ContainerInterface $container, ILogger $logger) {
119		- /** @var IVersionManager $versionManager */
120		- $versionManager = $container->get(IVersionManager::class);
121		- $class = $backend['@value'];
122		- $for = $backend['@attributes']['for'];
123		- try {
124		- $backendObject = $container->get($class);
125		- $versionManager->registerBackend($for, $backendObject);
126		- } catch (\Exception $e) {
127		- $logger->logException($e);
128		- }
129		- }
	118	+ private function loadBackend(array $backend, ContainerInterface $container, ILogger $logger) {
	119	+ /** @var IVersionManager $versionManager */
	120	+ $versionManager = $container->get(IVersionManager::class);
	121	+ $class = $backend['@value'];
	122	+ $for = $backend['@attributes']['for'];
	123	+ try {
	124	+ $backendObject = $container->get($class);
	125	+ $versionManager->registerBackend($for, $backendObject);
	126	+ } catch (\Exception $e) {
	127	+ $logger->logException($e);
	128	+ }
	129	+ }
130	130	}

		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	/**
64	64	* Register $principalBackend for the DAV collection
65	65	*/
66		- $context->registerService('principalBackend', function (ContainerInterface $c) {
	66	+ $context->registerService('principalBackend', function(ContainerInterface $c) {
67	67	/** @var IServerContainer $server */
68	68	$server = $c->get(IServerContainer::class);
69	69	return new Principal(
		@@ -77,7 +77,7 @@ discard block
		block discarded – undo
77	77	);
78	78	});
79	79
80		- $context->registerService(IVersionManager::class, function () {
	80	+ $context->registerService(IVersionManager::class, function() {
81	81	return new VersionManager();
82	82	});
83	83

nextcloud / server

Push — master ( 5fc51b...0716fb )

Status

Category

Indentation +70 added lines, -70 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch