Completed
Pull Request — master (#840)
by Julius
22:03 queued 11:15
created
apps/theming/lib/Controller/IconController.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@  discard block
 block discarded – undo
22 22
  */
23 23
 namespace OCA\Theming\Controller;
24 24
 
25
-use OCA\Theming\Template;
26 25
 use OCA\Theming\ThemingDefaults;
27 26
 use OCP\AppFramework\Controller;
28 27
 use OCP\AppFramework\Http;
@@ -35,7 +34,6 @@  discard block
 block discarded – undo
35 34
 use OCP\IL10N;
36 35
 use OCP\IRequest;
37 36
 use OCA\Theming\Util;
38
-use OCP\IURLGenerator;
39 37
 use Imagick;
40 38
 use ImagickPixel;
41 39
 
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	 *
92 92
 	 * @param $app app name
93 93
 	 * @param $image image file name
94
-	 * @return StreamResponse|DataResponse
94
+	 * @return DataDisplayResponse
95 95
 	 */
96 96
 	public function getThemedIcon($app, $image) {
97 97
 		$image = $this->getAppImage($app, $image);
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
 	 * @NoCSRFRequired
113 113
 	 *
114 114
 	 * @param $app app name
115
-	 * @return StreamResponse|DataResponse
115
+	 * @return DataDisplayResponse
116 116
 	 */
117 117
 	public function getFavicon($app="core") {
118 118
 		$icon = $this->renderAppIcon($app);
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 	 * @NoCSRFRequired
133 133
 	 *
134 134
 	 * @param $app app name
135
-	 * @return StreamResponse|DataResponse
135
+	 * @return DataDisplayResponse
136 136
 	 */
137 137
 	public function getTouchIcon($app="core") {
138 138
 		$icon = $this->renderAppIcon($app);
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 	 * Render app icon on themed background color
149 149
 	 * fallback to logo
150 150
 	 *
151
-	 * @param $app app name
151
+	 * @param string $app app name
152 152
 	 * @return Imagick
153 153
 	 */
154 154
 	private function renderAppIcon($app) {
@@ -277,8 +277,8 @@  discard block
 block discarded – undo
277 277
 	/**
278 278
 	 * replace default color with a custom one
279 279
 	 *
280
-	 * @param $svg content of a svg file
281
-	 * @param $color color to match
280
+	 * @param string $svg content of a svg file
281
+	 * @param string $color color to match
282 282
 	 * @return string
283 283
 	 */
284 284
 	private function colorizeSvg($svg, $color) {
Please login to merge, or discard this patch.