Inspection of "Merge pull request #5185 from nextcloud/error-spam..." - nextcloud/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e934e5...a753fb )

by Morris

created 2017-06-07 22:13 UTC

Status

Indentation +124 added lines, -124 removed lines patch added patch discarded remove patch

@@ -28,137 +28,137 @@
 block discarded – undo
  * @package OCA\Admin_Audit\Actions
  */
 class Files extends Action {
-	/**
-	 * Logs file read actions
-	 *
-	 * @param array $params
-	 */
-	public function read(array $params) {
-		$this->log(
-			'File accessed: "%s"',
-			$params,
-			[
-				'path',
-			]
-		);
-	}
+    /**
+     * Logs file read actions
+     *
+     * @param array $params
+     */
+    public function read(array $params) {
+        $this->log(
+            'File accessed: "%s"',
+            $params,
+            [
+                'path',
+            ]
+        );
+    }
 
-	/**
-	 * Logs rename actions of files
-	 *
-	 * @param array $params
-	 */
-	public function rename(array $params) {
-		$this->log(
-			'File renamed: "%s" to "%s"',
-			$params,
-			[
-				'oldpath',
-				'newpath',
-			]
-		);
-	}
+    /**
+     * Logs rename actions of files
+     *
+     * @param array $params
+     */
+    public function rename(array $params) {
+        $this->log(
+            'File renamed: "%s" to "%s"',
+            $params,
+            [
+                'oldpath',
+                'newpath',
+            ]
+        );
+    }
 
-	/**
-	 * Logs creation of files
-	 *
-	 * @param array $params
-	 */
-	public function create(array $params) {
-		if ($params['path'] === '/' || $params['path'] === '' || $params['path'] === null) {
-			return;
-		}
+    /**
+     * Logs creation of files
+     *
+     * @param array $params
+     */
+    public function create(array $params) {
+        if ($params['path'] === '/' || $params['path'] === '' || $params['path'] === null) {
+            return;
+        }
 
-		$this->log(
-			'File created: "%s"',
-			$params,
-			[
-				'path',
-			]
-		);
-	}
+        $this->log(
+            'File created: "%s"',
+            $params,
+            [
+                'path',
+            ]
+        );
+    }
 
-	/**
-	 * Logs copying of files
-	 *
-	 * @param array $params
-	 */
-	public function copy(array $params) {
-		$this->log(
-			'File copied: "%s" to "%s"',
-			$params,
-			[
-				'oldpath',
-				'newpath',
-			]
-		);
-	}
+    /**
+     * Logs copying of files
+     *
+     * @param array $params
+     */
+    public function copy(array $params) {
+        $this->log(
+            'File copied: "%s" to "%s"',
+            $params,
+            [
+                'oldpath',
+                'newpath',
+            ]
+        );
+    }
 
-	/**
-	 * Logs writing of files
-	 *
-	 * @param array $params
-	 */
-	public function write(array $params) {
-		if ($params['path'] === '/' || $params['path'] === '' || $params['path'] === null) {
-			return;
-		}
+    /**
+     * Logs writing of files
+     *
+     * @param array $params
+     */
+    public function write(array $params) {
+        if ($params['path'] === '/' || $params['path'] === '' || $params['path'] === null) {
+            return;
+        }
 
-		$this->log(
-			'File written to: "%s"',
-			$params,
-			[
-				'path',
-			]
-		);
-	}
+        $this->log(
+            'File written to: "%s"',
+            $params,
+            [
+                'path',
+            ]
+        );
+    }
 
-	/**
-	 * Logs update of files
-	 *
-	 * @param array $params
-	 */
-	public function update(array $params) {
-		$this->log(
-			'File updated: "%s"',
-			$params,
-			[
-				'path',
-			]
-		);
-	}
+    /**
+     * Logs update of files
+     *
+     * @param array $params
+     */
+    public function update(array $params) {
+        $this->log(
+            'File updated: "%s"',
+            $params,
+            [
+                'path',
+            ]
+        );
+    }
 
-	/**
-	 * Logs deletions of files
-	 *
-	 * @param array $params
-	 */
-	public function delete(array $params) {
-		$this->log(
-			'File deleted: "%s"',
-			$params,
-			[
-				'path',
-			]
-		);
-	}
+    /**
+     * Logs deletions of files
+     *
+     * @param array $params
+     */
+    public function delete(array $params) {
+        $this->log(
+            'File deleted: "%s"',
+            $params,
+            [
+                'path',
+            ]
+        );
+    }
 
-	/**
-	 * Logs preview access to a file
-	 *
-	 * @param array $params
-	 */
-	public function preview(array $params) {
-		$this->log(
-			'Preview accessed: "%s" (width: "%s", height: "%s" crop: "%s", mode: "%s")',
-			$params,
-			[
-				'path',
-				'width',
-				'height',
-				'crop',
-				'mode'
-			]
-		);
-	}
+    /**
+     * Logs preview access to a file
+     *
+     * @param array $params
+     */
+    public function preview(array $params) {
+        $this->log(
+            'Preview accessed: "%s" (width: "%s", height: "%s" crop: "%s", mode: "%s")',
+            $params,
+            [
+                'path',
+                'width',
+                'height',
+                'crop',
+                'mode'
+            ]
+        );
+    }
 }

Please login to merge, or discard this patch.

		@@ -28,137 +28,137 @@
		block discarded – undo
28	28	* @package OCA\Admin_Audit\Actions
29	29	*/
30	30	class Files extends Action {
31		- /**
32		- * Logs file read actions
33		- *
34		- * @param array $params
35		- */
36		- public function read(array $params) {
37		- $this->log(
38		- 'File accessed: "%s"',
39		- $params,
40		- [
41		- 'path',
42		- ]
43		- );
44		- }
	31	+ /**
	32	+ * Logs file read actions
	33	+ *
	34	+ * @param array $params
	35	+ */
	36	+ public function read(array $params) {
	37	+ $this->log(
	38	+ 'File accessed: "%s"',
	39	+ $params,
	40	+ [
	41	+ 'path',
	42	+ ]
	43	+ );
	44	+ }
45	45
46		- /**
47		- * Logs rename actions of files
48		- *
49		- * @param array $params
50		- */
51		- public function rename(array $params) {
52		- $this->log(
53		- 'File renamed: "%s" to "%s"',
54		- $params,
55		- [
56		- 'oldpath',
57		- 'newpath',
58		- ]
59		- );
60		- }
	46	+ /**
	47	+ * Logs rename actions of files
	48	+ *
	49	+ * @param array $params
	50	+ */
	51	+ public function rename(array $params) {
	52	+ $this->log(
	53	+ 'File renamed: "%s" to "%s"',
	54	+ $params,
	55	+ [
	56	+ 'oldpath',
	57	+ 'newpath',
	58	+ ]
	59	+ );
	60	+ }
61	61
62		- /**
63		- * Logs creation of files
64		- *
65		- * @param array $params
66		- */
67		- public function create(array $params) {
68		- if ($params['path'] === '/' \|\| $params['path'] === '' \|\| $params['path'] === null) {
69		- return;
70		- }
	62	+ /**
	63	+ * Logs creation of files
	64	+ *
	65	+ * @param array $params
	66	+ */
	67	+ public function create(array $params) {
	68	+ if ($params['path'] === '/' \|\| $params['path'] === '' \|\| $params['path'] === null) {
	69	+ return;
	70	+ }
71	71
72		- $this->log(
73		- 'File created: "%s"',
74		- $params,
75		- [
76		- 'path',
77		- ]
78		- );
79		- }
	72	+ $this->log(
	73	+ 'File created: "%s"',
	74	+ $params,
	75	+ [
	76	+ 'path',
	77	+ ]
	78	+ );
	79	+ }
80	80
81		- /**
82		- * Logs copying of files
83		- *
84		- * @param array $params
85		- */
86		- public function copy(array $params) {
87		- $this->log(
88		- 'File copied: "%s" to "%s"',
89		- $params,
90		- [
91		- 'oldpath',
92		- 'newpath',
93		- ]
94		- );
95		- }
	81	+ /**
	82	+ * Logs copying of files
	83	+ *
	84	+ * @param array $params
	85	+ */
	86	+ public function copy(array $params) {
	87	+ $this->log(
	88	+ 'File copied: "%s" to "%s"',
	89	+ $params,
	90	+ [
	91	+ 'oldpath',
	92	+ 'newpath',
	93	+ ]
	94	+ );
	95	+ }
96	96
97		- /**
98		- * Logs writing of files
99		- *
100		- * @param array $params
101		- */
102		- public function write(array $params) {
103		- if ($params['path'] === '/' \|\| $params['path'] === '' \|\| $params['path'] === null) {
104		- return;
105		- }
	97	+ /**
	98	+ * Logs writing of files
	99	+ *
	100	+ * @param array $params
	101	+ */
	102	+ public function write(array $params) {
	103	+ if ($params['path'] === '/' \|\| $params['path'] === '' \|\| $params['path'] === null) {
	104	+ return;
	105	+ }
106	106
107		- $this->log(
108		- 'File written to: "%s"',
109		- $params,
110		- [
111		- 'path',
112		- ]
113		- );
114		- }
	107	+ $this->log(
	108	+ 'File written to: "%s"',
	109	+ $params,
	110	+ [
	111	+ 'path',
	112	+ ]
	113	+ );
	114	+ }
115	115
116		- /**
117		- * Logs update of files
118		- *
119		- * @param array $params
120		- */
121		- public function update(array $params) {
122		- $this->log(
123		- 'File updated: "%s"',
124		- $params,
125		- [
126		- 'path',
127		- ]
128		- );
129		- }
	116	+ /**
	117	+ * Logs update of files
	118	+ *
	119	+ * @param array $params
	120	+ */
	121	+ public function update(array $params) {
	122	+ $this->log(
	123	+ 'File updated: "%s"',
	124	+ $params,
	125	+ [
	126	+ 'path',
	127	+ ]
	128	+ );
	129	+ }
130	130
131		- /**
132		- * Logs deletions of files
133		- *
134		- * @param array $params
135		- */
136		- public function delete(array $params) {
137		- $this->log(
138		- 'File deleted: "%s"',
139		- $params,
140		- [
141		- 'path',
142		- ]
143		- );
144		- }
	131	+ /**
	132	+ * Logs deletions of files
	133	+ *
	134	+ * @param array $params
	135	+ */
	136	+ public function delete(array $params) {
	137	+ $this->log(
	138	+ 'File deleted: "%s"',
	139	+ $params,
	140	+ [
	141	+ 'path',
	142	+ ]
	143	+ );
	144	+ }
145	145
146		- /**
147		- * Logs preview access to a file
148		- *
149		- * @param array $params
150		- */
151		- public function preview(array $params) {
152		- $this->log(
153		- 'Preview accessed: "%s" (width: "%s", height: "%s" crop: "%s", mode: "%s")',
154		- $params,
155		- [
156		- 'path',
157		- 'width',
158		- 'height',
159		- 'crop',
160		- 'mode'
161		- ]
162		- );
163		- }
	146	+ /**
	147	+ * Logs preview access to a file
	148	+ *
	149	+ * @param array $params
	150	+ */
	151	+ public function preview(array $params) {
	152	+ $this->log(
	153	+ 'Preview accessed: "%s" (width: "%s", height: "%s" crop: "%s", mode: "%s")',
	154	+ $params,
	155	+ [
	156	+ 'path',
	157	+ 'width',
	158	+ 'height',
	159	+ 'crop',
	160	+ 'mode'
	161	+ ]
	162	+ );
	163	+ }
164	164	}

nextcloud / server

Push — master ( e934e5...a753fb )

Status

Category

Indentation +124 added lines, -124 removed lines patch added patch discarded remove patch